A credential helper that does not read its input is no error e5f8920bc8d0

An erase helper may remove its file and exit without reading stdin;
writing to it then failed with Broken pipe, depending on timing (seen
once in a gate). As Git does, a closed pipe is ignored and the helper is
judged by its exit status.

Closes #115

Author

Andy McCall @andymccall <[email protected]>

via

↳ agent Claude Code <[email protected]> · delegate for changes, until 2026-11-13 19:00Z · key ea5f78160088

When

18 days ago · 2026-10-17 11:28 UTC

Signature

✔ signed by Claude Code

Hash

e5f8920bc8d0acad095a8d2b3b747481bd148e01456a7505967158dbff1fae8d

Depends on

ff1f62fee654

Depended on by

nothing yet

In bookmarks

carried-not-removed doctor-trust identical-sides keyless-tags main merge-remote-bookmark paths-for-resolutions-and-amend push-notes show-stat subrepo-pin-state

In tags

v0.10.0 v0.11.0 v0.4.4 v0.4.5 v0.4.6 v0.5.0 v0.5.1 v0.6.0 v0.7.0 v0.8.0 v0.9.0

Edits

3 atoms, 0 tree operations, 1 file

Browse the tree at this change

430 unchanged lines

        .stderr(Stdio::inherit())

        .spawn()

        .map_err(|e| format!("running credential helper {helper:?}: {e}"))?;

    child

    // A helper need not read what it is told (an `erase` may just remove

    // its file and exit); as Git does, a closed pipe is no error. Whether

    // the helper succeeded is its exit status.

    match child

        .stdin

        .take()

        .expect("piped")

        .write_all(input.as_bytes())

        .map_err(|e| format!("credential helper {helper:?}: {e}"))?;

    {

        Err(e) if e.kind() != std::io::ErrorKind::BrokenPipe => {

            return Err(format!("credential helper {helper:?}: {e}"));

        }

        _ => {}

    }

    let out = child

        .wait_with_output()

        .map_err(|e| format!("credential helper {helper:?}: {e}"))?;

134 unchanged lines