OXYGENHUB

Coverage / crates/oxy-core/src/repo/workspace.rs 86.7%

221 of 255 lines run, 37 of 54 functions · run #335 on proposal/123 · run missed

1
//! Multiple workspaces (spec §12.2): extra checkout directories sharing one
2
//! `.oxy`. A secondary workspace holds a `.oxy` *file* of the form
3
//! `oxydir: <path>\nworkspace: <id>`; the repository lists workspaces under
4
//! `.oxy/workspaces/<id>/path`. Each workspace has its own working-copy
5
//! change, manifest, and short-lived snapshot lock.
6
7
use super::*;
8
9
#[derive(Debug, Clone, PartialEq, Eq)]
10
pub struct WorkspaceInfo {
11
    pub id: WorkspaceId,
12
    pub path: PathBuf,
13
    /// Working-copy change hash from the current view, if the workspace is registered there.
14
    pub working_copy: Option<ChangeHash>,
15
    pub current: bool,
16
}
17
18
/// A lock file, taken by creating it exclusively and released on drop: a
19
/// workspace's working-copy lock, the operation head's lock. A stale one,
20
/// whose process is gone (or, where that cannot be told, older than a
21
/// minute), is taken over.
22
pub struct FileLock {
23
    path: PathBuf,
24
}
25
26
/// A workspace's working-copy lock (spec §12.1), held by everything that
27
/// reads or writes the working copy and records its working-copy change:
28
/// snapshot, checkout, bookmark switch, commit, discard, pull. It is
29
/// re-entrant within a thread, so a checkout that snapshots first holds it
30
/// once.
31
pub struct WorkingCopyLock {
32
    path: PathBuf,
33
    _file: Option<FileLock>,
34
}
35
36
/// The working-copy lock; its old name.
37
pub type SnapshotLock = WorkingCopyLock;
38
39
thread_local! {
40
    /// Working-copy locks this thread holds, with their depth.
41
    static HELD: std::cell::RefCell<HashMap<PathBuf, usize>> = Default::default();
42
}
43
44
impl Drop for WorkingCopyLock {
452761×
    fn drop(&mut self) {
462761×
        HELD.with(|h| {
472761×
            let mut h = h.borrow_mut();
482761×
            if let Some(n) = h.get_mut(&self.path) {
492760×
                *n -= 1;
502760×
                if *n == 0 {
511635×
                    h.remove(&self.path);
521635×
                }
531×
            }
542761×
        });
552761×
    }
56
}
57
58
/// Whether the process that wrote a lock file is gone. Where that cannot
59
/// be told (no `/proc`), a lock older than a minute counts as stale.
60130×
pub(crate) fn lock_is_stale(path: &Path) -> bool {
61130×
    let old = fs::metadata(path)
62130×
        .and_then(|m| m.modified())
63130×
        .map(|t| t.elapsed().map(|d| d.as_secs() > 60).unwrap_or(false))
64130×
        .unwrap_or(true);
65130×
    let proc_fs = Path::new("/proc/self").exists();
66130×
    match fs::read_to_string(path)
67130×
        .ok()
68130×
        .and_then(|s| s.trim().parse::<u32>().ok())
69
    {
70130×
        Some(pid) if proc_fs => !Path::new("/proc").join(pid.to_string()).exists(),
71
        // Being written this instant, or by something that is not oxy.
720×
        _ => old,
73
    }
74130×
}
75
76
impl Drop for FileLock {
775157×
    fn drop(&mut self) {
785157×
        let _ = fs::remove_file(&self.path);
795157×
    }
80
}
81
82
impl FileLock {
83
    /// Wait up to about five seconds for `path`; `busy` is the error after that.
843522×
    pub(crate) fn acquire(path: PathBuf, busy: &str) -> Result<FileLock> {
853522×
        Self::acquire_within(path, busy, std::time::Duration::from_secs(5))
863522×
    }
87
88
    /// Wait up to `wait` for `path`; `busy` is the error after that.
895157×
    pub(crate) fn acquire_within(
905157×
        path: PathBuf,
915157×
        busy: &str,
925157×
        wait: std::time::Duration,
935157×
    ) -> Result<FileLock> {
945157×
        let until = std::time::Instant::now() + wait;
95
        loop {
965286×
            match fs::OpenOptions::new()
975286×
                .write(true)
985286×
                .create_new(true)
995286×
                .open(&path)
100
            {
1015157×
                Ok(mut f) => {
1025157×
                    let _ = write!(f, "{}", std::process::id());
1035157×
                    return Ok(FileLock { path });
104
                }
105129×
                Err(e) if e.kind() == std::io::ErrorKind::AlreadyExists => {
106129×
                    if lock_is_stale(&path) {
1071×
                        let _ = fs::remove_file(&path);
1081×
                        continue;
109128×
                    }
110128×
                    if std::time::Instant::now() >= until {
1110×
                        return fail(busy);
112128×
                    }
113128×
                    std::thread::sleep(std::time::Duration::from_millis(10));
114
                }
1150×
                Err(e) => return Err(e.into()),
116
            }
117
        }
1185157×
    }
119
}
120
121
/// Parse a secondary workspace's `.oxy` file.
1229×
pub(crate) fn parse_workspace_file(text: &str) -> Option<(PathBuf, WorkspaceId)> {
1239×
    let mut dir = None;
1249×
    let mut id = None;
12518×
    for line in text.lines() {
12618×
        if let Some(v) = line.strip_prefix("oxydir:") {
1279×
            dir = Some(PathBuf::from(v.trim()));
1289×
        } else if let Some(v) = line.strip_prefix("workspace:") {
1299×
            id = WorkspaceId::from_hex(v.trim());
1309×
        }
131
    }
1329×
    Some((dir?, id?))
1339×
}
134
135
impl Repo {
1363276×
    fn workspace_dir(&self, id: &WorkspaceId) -> PathBuf {
1373276×
        self.oxy.join("workspaces").join(id.to_hex())
1383276×
    }
139
140
    /// Record where a workspace lives.
141510×
    pub(crate) fn register_workspace(&self, id: &WorkspaceId, path: &Path) -> Result<()> {
142510×
        let dir = self.workspace_dir(id);
143510×
        fs::create_dir_all(&dir)?;
144510×
        write_atomic(&dir.join("path"), path.to_string_lossy().as_bytes())
145510×
    }
146
147
    /// The directory of a workspace, if registered.
1484×
    pub fn workspace_path(&self, id: &WorkspaceId) -> Option<PathBuf> {
1494×
        fs::read_to_string(self.workspace_dir(id).join("path"))
1504×
            .ok()
1514×
            .map(|s| PathBuf::from(s.trim()))
1524×
    }
153
154
    /// Every workspace this repository knows about.
1556×
    pub fn workspaces(&self) -> Result<Vec<WorkspaceInfo>> {
1566×
        let view = self.view()?;
1576×
        let mut ids: BTreeSet<WorkspaceId> = view.workspaces.keys().copied().collect();
1586×
        if let Ok(rd) = fs::read_dir(self.oxy.join("workspaces")) {
1599×
            for e in rd.flatten() {
1609×
                if let Some(id) = WorkspaceId::from_hex(&e.file_name().to_string_lossy()) {
1619×
                    if e.path().join("path").exists() {
1629×
                        ids.insert(id);
1639×
                    }
1640×
                }
165
            }
1660×
        }
1676×
        let mut out = Vec::new();
1689×
        for id in ids {
1699×
            let path = if id == self.workspace {
1706×
                self.root.clone()
171
            } else {
1723×
                self.workspace_path(&id)
1733×
                    .unwrap_or_else(|| PathBuf::from("(unknown)"))
174
            };
1759×
            out.push(WorkspaceInfo {
1769×
                id,
1779×
                path,
1789×
                working_copy: view.workspaces.get(&id).copied(),
1799×
                current: id == self.workspace,
1809×
            });
181
        }
1826×
        Ok(out)
1836×
    }
184
185
    /// Create a workspace at `dir` checked out on `heads` (default the
186
    /// bookmark's), and return a `Repo` rooted there.
187
    /// `bookmark` is the new workspace's current bookmark (oxygen#60), by
188
    /// default this workspace's.
1896×
    pub fn workspace_add(&self, dir: &Path, heads: Option<&[ChangeHash]>) -> Result<Repo> {
1906×
        self.workspace_add_on(dir, heads, None)
1916×
    }
192
193
    /// [`Repo::workspace_add`] with the new workspace on `bookmark`.
1948×
    pub fn workspace_add_on(
1958×
        &self,
1968×
        dir: &Path,
1978×
        heads: Option<&[ChangeHash]>,
1988×
        bookmark: Option<&str>,
1998×
    ) -> Result<Repo> {
2008×
        if dir.exists() && fs::read_dir(dir)?.next().is_some() {
2010×
            return fail(format!("{} exists and is not empty", dir.display()));
2028×
        }
2038×
        fs::create_dir_all(dir)?;
2048×
        let dir = dir.canonicalize()?;
2058×
        if dir == self.root || dir.starts_with(&self.root) || self.root.starts_with(&dir) {
2061×
            return fail("a workspace cannot be inside another workspace of the same repository");
2077×
        }
2087×
        let heads = match heads {
2092×
            Some(h) => h.to_vec(),
2105×
            None => self.bookmark_heads()?,
211
        };
2127×
        let id = WorkspaceId::random();
2137×
        let wc = self.new_working_copy(heads.clone(), "");
2147×
        let wc_hash = self.store.put_change(&wc)?;
2157×
        let (op_ref, op) = self.head_op()?;
2167×
        let mut view = op.view.clone();
2177×
        view.workspaces.insert(id, wc_hash);
2187×
        self.record_op(
2197×
            &[op_ref],
2207×
            &format!("oxy workspace add {}", dir.display()),
2217×
            view,
2220×
        )?;
2237×
        self.register_workspace(&id, &dir)?;
2247×
        self.set_workspace_bookmark(&id, bookmark.unwrap_or(&self.config.bookmark))?;
2257×
        write_atomic(
2267×
            &dir.join(OXY_DIR),
2277×
            format!(
2287×
                "oxydir: {}\nworkspace: {}\n",
2297×
                self.oxy.display(),
2307×
                id.to_hex()
2317×
            )
2327×
            .as_bytes(),
2330×
        )?;
2347×
        let repo = Repo::open(&dir)?.with_home(self.keys_dir.parent().unwrap_or(&self.keys_dir));
2357×
        repo.checkout(&heads, true, "oxy workspace add (checkout)")?;
2367×
        self.copy_subrepos_into(&repo);
2377×
        Ok(repo)
2388×
    }
239
240
    /// The new workspace's subrepos at their pins, from this workspace's
241
    /// own copies (oxygen#61): a local clone, its remote then pointed at
242
    /// the subrepo's URL, and the pin checked out, with no network unless
243
    /// this copy lacks the pinned changes. A subrepo this workspace does
244
    /// not have stays for `oxy submodule update --init`. Best effort.
2457×
    fn copy_subrepos_into(&self, new: &Repo) {
2467×
        let Ok(subs) = new.subrepos() else { return };
2477×
        let modules = new.modules_on_disk();
2487×
        for s in subs {
2491×
            let (src, dst) = (self.root.join(&s.path), new.root.join(&s.path));
2501×
            if dst.join(OXY_DIR).exists() || dst.join(".git").exists() {
2510×
                continue;
2521×
            }
2531×
            let url = modules.entries.get(&s.path).map(|m| m.url.clone());
2541×
            if let Some(parent) = dst.parent() {
2551×
                let _ = fs::create_dir_all(parent);
2561×
            }
2571×
            let _ = fs::remove_dir(&dst);
2581×
            if src.join(OXY_DIR).exists() {
2591×
                match Repo::clone(&src.to_string_lossy(), &dst) {
2601×
                    Ok(mut sub) => {
2611×
                        if let Some(u) = &url {
2621×
                            if sub.config.set("remote.origin.url", u).is_ok() {
2631×
                                let _ = sub.save_config();
2641×
                            }
2650×
                        }
266
                    }
2670×
                    Err(_) => continue,
268
                }
2690×
            } else if src.join(".git").exists() {
2700×
                let cloned = std::process::Command::new("git")
2710×
                    .args(["clone", "-q", "--local"])
2720×
                    .arg(&src)
2730×
                    .arg(&dst)
2740×
                    .status()
2750×
                    .is_ok_and(|st| st.success());
2760×
                if !cloned {
2770×
                    continue;
2780×
                }
2790×
                if let Some(u) = &url {
2800×
                    let _ = std::process::Command::new("git")
2810×
                        .arg("-C")
2820×
                        .arg(&dst)
2830×
                        .args(["remote", "set-url", "origin", u])
2840×
                        .status();
2850×
                }
286
            } else {
2870×
                continue;
288
            }
2891×
            let _ = new.sync_subrepo(&s.path, &s.pin, false);
290
        }
2917×
    }
292
293
    /// Drop a workspace from the view and registry; its files stay.
2942×
    pub fn workspace_forget(&self, id: &WorkspaceId) -> Result<()> {
2952×
        if *id == self.workspace {
2961×
            return fail("cannot forget the workspace you are in");
2971×
        }
2981×
        let (op_ref, op) = self.head_op()?;
2991×
        let mut view = op.view.clone();
3001×
        if view.workspaces.remove(id).is_none() && self.workspace_path(id).is_none() {
3010×
            return fail(format!("no workspace {}", id.short(8)));
3021×
        }
3031×
        self.record_op(
3041×
            &[op_ref],
3051×
            &format!("oxy workspace forget {}", id.short(8)),
3061×
            view,
3070×
        )?;
3081×
        let _ = fs::remove_dir_all(self.workspace_dir(id));
3091×
        Ok(())
3102×
    }
311
312
    /// Take this workspace's snapshot lock (spec §12.1).
3131343×
    pub(crate) fn lock_snapshot(&self) -> Result<SnapshotLock> {
3141343×
        self.lock_working_copy()
3151343×
    }
316
317
    /// Take this workspace's working-copy lock (spec §12.1), waiting up to
318
    /// a minute for another process's checkout or snapshot to finish.
3192761×
    pub fn lock_working_copy(&self) -> Result<WorkingCopyLock> {
3202761×
        let dir = self.workspace_dir(&self.workspace);
3212761×
        if self.bare {
322
            // No working copy to guard.
3231×
            return Ok(WorkingCopyLock {
3241×
                path: dir,
3251×
                _file: None,
3261×
            });
3272760×
        }
3282760×
        fs::create_dir_all(&dir)?;
3292760×
        let path = dir.join("lock");
3302760×
        let held = HELD.with(|h| {
3312760×
            let mut h = h.borrow_mut();
3322760×
            match h.get_mut(&path) {
3331125×
                Some(n) => {
3341125×
                    *n += 1;
3351125×
                    true
336
                }
3371635×
                None => false,
338
            }
3392760×
        });
3402760×
        if held {
3411125×
            return Ok(WorkingCopyLock { path, _file: None });
3421635×
        }
3431635×
        let file = FileLock::acquire_within(
3441635×
            path.clone(),
3451635×
            "another oxy process is using this working copy (a checkout or snapshot); try again when it finishes",
3461635×
            std::time::Duration::from_secs(60),
3470×
        )?;
3481635×
        HELD.with(|h| h.borrow_mut().insert(path.clone(), 1));
349
        // Whoever held the lock may have moved the operation head: what
350
        // is done under it starts from the head as it is now (oxygenhub#249).
3511635×
        self.forget_head();
3521635×
        Ok(WorkingCopyLock {
3531635×
            path,
3541635×
            _file: Some(file),
3551635×
        })
3562761×
    }
357
}