A long push in parts: no request past the server's limit, no history held whole issue #95
closed: completed andymccall opened this · 0 comments
andymccall
oxy push sends one request: the whole bundle, built in memory on both sides. The full VS Code import (166,000 changes, several GB of texts) would pass the hub's 4 GiB push_body_limit and hold all of it in memory on the client and the hub.
A push now goes in parts of about push.batch-bytes (default 256 MiB) of changes and their texts and blobs, in dependency order: every part but the last carries objects alone, which the server validates, stores and reports as an objects result; the last moves the bookmark as before. The spinner says which part is going. Spec §16.4.
Needed to put VS Code on the hub (refs issue #81).
oxy push sends one request: the whole bundle, built in memory on both sides. The full VS Code import (166,000 changes, several GB of texts) would pass the hub's 4 GiB push_body_limit and hold all of it in memory on the client and the hub.
A push now goes in parts of about push.batch-bytes (default 256 MiB) of changes and their texts and blobs, in dependency order: every part but the last carries objects alone, which the server validates, stores and reports as an
objectsresult; the last moves the bookmark as before. The spinner says which part is going. Spec §16.4.Needed to put VS Code on the hub (refs issue #81).