Proposals on the dashboard (closes #18) d1f635be9442

- **Proposals on the dashboard (#18):** Waiting for your review (open proposals by others in your repositories you have not reviewed) and Your proposals (your open ones and drafts), as the hub's dashboard lists them, each opening the proposal screen where it can be landed. From the hub's `GET /api/v1/user/proposals`; a hub without it shows neither.

    /** The proposals the caller should act on, across repositories (the hub's dashboard). */

    suspend fun userProposals(): UserProposals

    override suspend fun userProposals(): UserProposals = get("user/proposals", UserProposals.serializer())

/** `GET /api/v1/user/proposals`: the proposals to act on, as the hub's dashboard lists them. */

@Serializable

data class UserProposals(

    /** Open ones by others in the caller's repositories, not yet reviewed by them. */

    val review: List<ProposalBrief> = emptyList(),

    /** The caller's own open ones and drafts. */

    val authored: List<ProposalBrief> = emptyList(),

)

/** A proposal in a list across repositories. */

@Serializable

data class ProposalBrief(

    /** `owner/name`. */

    val repository: String,

    val number: Long,

    val title: String = "",

    val author: String = "",

    val state: String = "open",

    val conflicted: Boolean = false,

    @SerialName("updated_ms") val updatedMs: Long = 0,

    val url: String = "",

) {

    val owner: String get() = repository.substringBefore('/')

    val name: String get() = repository.substringAfter('/')

}

import androidx.compose.material.icons.automirrored.outlined.CallMerge

import androidx.compose.material.icons.outlined.EditNote

import androidx.compose.ui.text.style.TextOverflow

import io.oxygenhub.android.api.ProposalBrief

import io.oxygenhub.android.ui.common.relativeTime

import io.oxygenhub.android.ui.theme.LocalStatusColors

    onOpenProposal: (ProposalBrief) -> Unit = {},

            DashboardContent(d, inbox, onOpenRepository, onAllRepositories, onInbox, onOpenProposal)

    onOpenProposal: (ProposalBrief) -> Unit = {},

                    Column(Modifier.weight(2f), verticalArrangement = Arrangement.spacedBy(16.dp)) {

                        Proposals(d, onOpenProposal)

                        Recent(d, onOpenRepository, onAllRepositories)

                    }

                Column(verticalArrangement = Arrangement.spacedBy(16.dp)) {

                    Unread(inbox, onInbox)

                    Proposals(d, onOpenProposal)

                    Recent(d, onOpenRepository, onAllRepositories)

                }

        }

    }

}

/** Proposals waiting for the account's review, then its own: each opens where it can be landed. */

@Composable

private fun Proposals(d: Dashboard, onOpen: (ProposalBrief) -> Unit) {

    val p = d.proposals ?: return

    Column(verticalArrangement = Arrangement.spacedBy(16.dp)) {

        if (p.review.isNotEmpty()) ProposalCard("Waiting for your review", p.review, onOpen)

        if (p.authored.isNotEmpty()) ProposalCard("Your proposals", p.authored, onOpen)

    }

}

@Composable

private fun ProposalCard(title: String, list: List<ProposalBrief>, onOpen: (ProposalBrief) -> Unit) {

    Card(Modifier.fillMaxWidth()) {

        Text(

            "$title · ${list.size}",

            style = MaterialTheme.typography.titleMedium,

            modifier = Modifier.padding(start = 16.dp, top = 16.dp, end = 16.dp, bottom = 4.dp),

        )

        list.forEachIndexed { i, b ->

            if (i > 0) HorizontalDivider()

            ListItem(

                modifier = Modifier.clickable { onOpen(b) },

                colors = ListItemDefaults.colors(containerColor = Color.Transparent),

                leadingContent = {

                    Icon(

                        if (b.state == "draft") Icons.Outlined.EditNote else Icons.AutoMirrored.Outlined.CallMerge,

                        contentDescription = b.state,

                        tint = if (b.state == "draft") MaterialTheme.colorScheme.onSurfaceVariant else LocalStatusColors.current.ok,

                    )

                },

                headlineContent = { Text(b.title, maxLines = 2, overflow = TextOverflow.Ellipsis) },

                supportingContent = {

                    val by = if (title.startsWith("Waiting")) " by ${b.author}" else ""

                    val conflicts = if (b.conflicted) " · conflicts" else ""

                    Text("${b.repository} #${b.number}$by · ${relativeTime(b.updatedMs)}$conflicts", maxLines = 1, overflow = TextOverflow.Ellipsis)

                },

            )

import io.oxygenhub.android.api.UserProposals

    /** Proposals to review and the account's own (#18); null when the hub cannot say. */

    val proposals: UserProposals? = null,

        // As are the proposals: a hub without the call shows none.

        val proposals = async {

            try {

                api.userProposals()

            } catch (e: CancellationException) {

                throw e

            } catch (_: Exception) {

                null

            }

        }

            proposals = proposals.await(),

                    onOpenProposal = { nav.navigate(ProposalRoute(it.owner, it.name, it.number)) },

import io.oxygenhub.android.api.Check

import io.oxygenhub.android.api.Proposal

import io.oxygenhub.android.api.ProposalBrief

import io.oxygenhub.android.api.ProposalState

import io.oxygenhub.android.api.UserProposals

    override suspend fun userProposals() = UserProposals(

        review = listOf(ProposalBrief("babbage/difference-engine", 12, "Carry the tens with a ratchet", "babbage", updatedMs = now - 2 * hour)),

        authored = listOf(ProposalBrief("ada/engine", 44, "Note G: loop the Bernoulli numbers", "ada", updatedMs = now - 5 * hour)),

    )

    override suspend fun proposals(owner: String, name: String, state: ProposalState) = emptyList<Proposal>()

    override suspend fun proposal(owner: String, name: String, number: Long) = Proposal(number, "Note G")

    override suspend fun checks(owner: String, name: String, number: Long) = emptyList<Check>()

    override suspend fun land(owner: String, name: String, number: Long) = proposal(owner, name, number)

    override suspend fun setAutoLand(owner: String, name: String, number: Long, on: Boolean) = proposal(owner, name, number)

    var userProposals: () -> io.oxygenhub.android.api.UserProposals = {

        io.oxygenhub.android.api.UserProposals(

            review = listOf(io.oxygenhub.android.api.ProposalBrief("andymccall/oxygenhub", 300, "Show a column's archived cards", "ada")),

        )

    }

    override suspend fun userProposals() = userProposals.invoke().also { calls += "user proposals" }

    fun showsProposalsToReviewAndNoneFromAHubWithoutTheCall() {

        val vm = DashboardViewModel(api, session) { 9 }

        assertEquals(listOf(300L), ready(vm).proposals?.review?.map { it.number })

        assertEquals("andymccall" to "oxygenhub", ready(vm).proposals!!.review[0].let { it.owner to it.name })

        api.userProposals = { throw HubException.Http(404, "no such endpoint") }

        vm.refresh()

        assertNull(ready(vm).proposals)

        assertEquals(2, ready(vm).repositoryCount)

    }

    @Test