Land proposals from the phone (closes #17) e2df27a81e5d

package io.oxygenhub.android.ui.proposals

import androidx.compose.foundation.clickable

import androidx.compose.foundation.horizontalScroll

import androidx.compose.foundation.layout.Arrangement

import androidx.compose.foundation.layout.Column

import androidx.compose.foundation.layout.FlowRow

import androidx.compose.foundation.layout.Row

import androidx.compose.foundation.layout.fillMaxSize

import androidx.compose.foundation.layout.padding

import androidx.compose.foundation.lazy.LazyColumn

import androidx.compose.foundation.lazy.items

import androidx.compose.foundation.rememberScrollState

import androidx.compose.material.icons.Icons

import androidx.compose.material.icons.automirrored.outlined.CallMerge

import androidx.compose.material.icons.outlined.Block

import androidx.compose.material.icons.outlined.EditNote

import androidx.compose.material3.FilterChip

import androidx.compose.material3.HorizontalDivider

import androidx.compose.material3.Icon

import androidx.compose.material3.ListItem

import androidx.compose.material3.MaterialTheme

import androidx.compose.material3.Text

import androidx.compose.runtime.Composable

import androidx.compose.runtime.getValue

import androidx.compose.ui.Modifier

import androidx.compose.ui.graphics.Color

import androidx.compose.ui.graphics.vector.ImageVector

import androidx.compose.ui.text.style.TextOverflow

import androidx.compose.ui.unit.dp

import androidx.lifecycle.compose.collectAsStateWithLifecycle

import io.oxygenhub.android.api.Proposal

import io.oxygenhub.android.api.ProposalState

import io.oxygenhub.android.ui.common.EmptyState

import io.oxygenhub.android.ui.common.LoadContent

import io.oxygenhub.android.ui.common.relativeTime

import io.oxygenhub.android.ui.issues.LabelChip

import io.oxygenhub.android.ui.theme.LocalStatusColors

/** A repository's proposals with their filter, for a tab to hold. */

@Composable

fun ProposalList(vm: ProposalsViewModel, onOpen: (Proposal) -> Unit) {

    val state by vm.state.collectAsStateWithLifecycle()

    val filter by vm.filter.collectAsStateWithLifecycle()

    Column(Modifier.fillMaxSize()) {

        Row(

            Modifier.horizontalScroll(rememberScrollState()).padding(horizontal = 16.dp, vertical = 8.dp),

            horizontalArrangement = Arrangement.spacedBy(8.dp),

        ) {

            ProposalState.entries.forEach { s ->

                FilterChip(selected = filter == s, onClick = { vm.setFilter(s) }, label = { Text(s.name) })

            }

        }

        LoadContent(state, onRefresh = vm::refresh) { proposals ->

            if (proposals.isEmpty()) {

                EmptyState(

                    Icons.AutoMirrored.Outlined.CallMerge,

                    when (filter) {

                        ProposalState.Open -> "No open proposals"

                        ProposalState.Landed -> "Nothing landed yet"

                        ProposalState.Closed -> "No closed proposals"

                        ProposalState.All -> "No proposals yet"

                    },

                    "Proposals for ${vm.owner}/${vm.name} show here.",

                )

            } else {

                LazyColumn(Modifier.fillMaxSize()) {

                    items(proposals, key = { it.number }) { p ->

                        ProposalRow(p, onClick = { onOpen(p) })

                        HorizontalDivider()

                    }

                }

            }

        }

    }

}

/** The icon and colour of a proposal's state, as the hub shows them. */

@Composable

internal fun stateLook(p: Proposal): Pair<ImageVector, Color> {

    val status = LocalStatusColors.current

    return when {

        p.state == "landed" -> Icons.AutoMirrored.Outlined.CallMerge to status.warn

        p.state == "closed" -> Icons.Outlined.Block to status.bad

        p.isDraft -> Icons.Outlined.EditNote to MaterialTheme.colorScheme.onSurfaceVariant

        else -> Icons.AutoMirrored.Outlined.CallMerge to status.ok

    }

}

@Composable

fun ProposalRow(p: Proposal, onClick: () -> Unit) {

    val status = LocalStatusColors.current

    val (icon, tint) = stateLook(p)

    ListItem(

        modifier = Modifier.clickable(onClick = onClick),

        leadingContent = { Icon(icon, contentDescription = p.state, tint = tint) },

        headlineContent = { Text(p.title, maxLines = 2, overflow = TextOverflow.Ellipsis) },

        supportingContent = {

            Column {

                val what = when {

                    p.landed != null -> "landed ${relativeTime(p.landed.whenMs)} by ${p.landed.by}"

                    p.state == "closed" -> "closed ${relativeTime(p.updatedMs)}"

                    else -> "by ${p.author} into ${p.target} · ${relativeTime(p.updatedMs)}"

                }

                Text("#${p.number} $what", maxLines = 1, overflow = TextOverflow.Ellipsis)

                if (p.isOpen && !p.isDraft) {

                    val (text, colour) = when {

                        p.landable -> "Ready to land" to status.ok

                        p.autoLand != null -> "Lands when its checks pass" to MaterialTheme.colorScheme.primary

                        else -> "${p.blockers.size} to settle before landing" to status.bad

                    }

                    Text(text, color = colour, style = MaterialTheme.typography.labelMedium, modifier = Modifier.padding(top = 2.dp))

                }

                if (p.labels.isNotEmpty()) {

                    FlowRow(Modifier.padding(top = 4.dp), horizontalArrangement = Arrangement.spacedBy(4.dp), verticalArrangement = Arrangement.spacedBy(4.dp)) {

                        p.labels.forEach { LabelChip(it) }

                    }

                }

            }

        },

    )

}

package io.oxygenhub.android.ui.proposals

import androidx.compose.foundation.clickable

import androidx.compose.foundation.layout.Arrangement

import androidx.compose.foundation.layout.Box

import androidx.compose.foundation.layout.Column

import androidx.compose.foundation.layout.FlowRow

import androidx.compose.foundation.layout.Row

import androidx.compose.foundation.layout.Spacer

import androidx.compose.foundation.layout.fillMaxWidth

import androidx.compose.foundation.layout.padding

import androidx.compose.foundation.layout.size

import androidx.compose.foundation.layout.width

import androidx.compose.foundation.layout.widthIn

import androidx.compose.foundation.rememberScrollState

import androidx.compose.foundation.verticalScroll

import androidx.compose.material.icons.Icons

import androidx.compose.material.icons.automirrored.outlined.OpenInNew

import androidx.compose.material.icons.outlined.Cancel

import androidx.compose.material.icons.outlined.CheckCircle

import androidx.compose.material.icons.outlined.Lock

import androidx.compose.material.icons.outlined.RemoveCircleOutline

import androidx.compose.material.icons.outlined.Schedule

import androidx.compose.material.icons.outlined.WarningAmber

import androidx.compose.material3.AlertDialog

import androidx.compose.material3.Button

import androidx.compose.material3.CircularProgressIndicator

import androidx.compose.material3.ElevatedCard

import androidx.compose.material3.HorizontalDivider

import androidx.compose.material3.Icon

import androidx.compose.material3.IconButton

import androidx.compose.material3.LinearProgressIndicator

import androidx.compose.material3.ListItem

import androidx.compose.material3.MaterialTheme

import androidx.compose.material3.OutlinedButton

import androidx.compose.material3.SnackbarHostState

import androidx.compose.material3.Switch

import androidx.compose.material3.Text

import androidx.compose.material3.TextButton

import androidx.compose.runtime.Composable

import androidx.compose.runtime.LaunchedEffect

import androidx.compose.runtime.getValue

import androidx.compose.runtime.mutableStateOf

import androidx.compose.runtime.remember

import androidx.compose.runtime.saveable.rememberSaveable

import androidx.compose.runtime.setValue

import androidx.compose.ui.Alignment

import androidx.compose.ui.Modifier

import androidx.compose.ui.platform.LocalUriHandler

import androidx.compose.ui.text.font.FontFamily

import androidx.compose.ui.text.font.FontWeight

import androidx.compose.ui.unit.dp

import androidx.lifecycle.compose.collectAsStateWithLifecycle

import io.oxygenhub.android.api.Check

import io.oxygenhub.android.api.Proposal

import io.oxygenhub.android.ui.common.AppScreen

import io.oxygenhub.android.ui.common.LoadContent

import io.oxygenhub.android.ui.common.relativeTime

import io.oxygenhub.android.ui.issues.LabelChip

import io.oxygenhub.android.ui.theme.LocalStatusColors

/**

 * One proposal: whether it may land and what stands in the way, in the

 * hub's words; landing it, or having it land when its checks pass; then

 * its checks, approvals, changes and description.

 */

@Composable

fun ProposalScreen(vm: ProposalViewModel, canWrite: Boolean, onBack: () -> Unit, onSignInAgain: () -> Unit) {

    val state by vm.state.collectAsStateWithLifecycle()

    val action by vm.action.collectAsStateWithLifecycle()

    val snackbar = remember { SnackbarHostState() }

    val uri = LocalUriHandler.current

    val done = action as? LandAction.Done

    LaunchedEffect(done) {

        if (done != null) {

            snackbar.showSnackbar(done.message)

            vm.dismiss()

        }

    }

    AppScreen(

        title = "#${vm.number}",

        subtitle = "${vm.owner}/${vm.name}",

        onBack = onBack,

        snackbar = snackbar,

        actions = {

            val url = state.valueOrNull?.proposal?.url.orEmpty()

            if (url.isNotBlank()) {

                IconButton(onClick = { uri.openUri(url) }) {

                    Icon(Icons.AutoMirrored.Outlined.OpenInNew, contentDescription = "Open on the hub")

                }

            }

        },

    ) {

        LoadContent(state, onRefresh = vm::refresh) { page ->

            Box(Modifier.fillMaxWidth(), contentAlignment = Alignment.TopCenter) {

                Column(

                    Modifier.widthIn(max = 720.dp).verticalScroll(rememberScrollState()).padding(16.dp),

                    verticalArrangement = Arrangement.spacedBy(16.dp),

                ) {

                    Header(page.proposal)

                    Landing(page.proposal, action, canWrite, vm::land, vm::setAutoLand, onSignInAgain, vm::dismiss)

                    Checks(page.checks) { if (it.url.isNotBlank()) uri.openUri(it.url) }

                    Reviews(page.proposal)

                    Changes(page.proposal)

                    if (page.proposal.body.isNotBlank()) {

                        Section("Description") {

                            Text(page.proposal.body, modifier = Modifier.padding(16.dp), style = MaterialTheme.typography.bodyMedium)

                        }

                    }

                }

            }

        }

    }

}

@Composable

private fun Header(p: Proposal) {

    val (icon, tint) = stateLook(p)

    Column(verticalArrangement = Arrangement.spacedBy(6.dp)) {

        Row(verticalAlignment = Alignment.CenterVertically) {

            Icon(icon, contentDescription = null, tint = tint, modifier = Modifier.size(18.dp))

            Spacer(Modifier.width(6.dp))

            Text(p.state.replaceFirstChar { it.uppercase() }, color = tint, style = MaterialTheme.typography.labelLarge)

        }

        Text(p.title, style = MaterialTheme.typography.headlineSmall, fontWeight = FontWeight.Bold)

        val n = p.changes.size

        Text(

            "${p.author} wants to land $n change${if (n == 1) "" else "s"} into ${p.target} · updated ${relativeTime(p.updatedMs)}",

            style = MaterialTheme.typography.bodyMedium,

            color = MaterialTheme.colorScheme.onSurfaceVariant,

        )

        if (p.labels.isNotEmpty()) {

            FlowRow(horizontalArrangement = Arrangement.spacedBy(4.dp), verticalArrangement = Arrangement.spacedBy(4.dp)) {

                p.labels.forEach { LabelChip(it) }

            }

        }

    }

}

@Composable

private fun Landing(

    p: Proposal,

    action: LandAction,

    canWrite: Boolean,

    onLand: () -> Unit,

    onAutoLand: (Boolean) -> Unit,

    onSignInAgain: () -> Unit,

    onDismiss: () -> Unit,

) {

    val status = LocalStatusColors.current

    var confirming by rememberSaveable { mutableStateOf(false) }

    val working = action == LandAction.Working

    ElevatedCard(Modifier.fillMaxWidth()) {

        Column(Modifier.padding(16.dp), verticalArrangement = Arrangement.spacedBy(12.dp)) {

            when {

                p.landed != null -> Text(

                    "Landed ${relativeTime(p.landed.whenMs)} by ${p.landed.by}${if (p.landed.via.isNotBlank()) " (${p.landed.via})" else ""}.",

                    style = MaterialTheme.typography.titleMedium,

                )

                !p.isOpen -> Text("Closed without landing.", style = MaterialTheme.typography.titleMedium)

                else -> {

                    if (p.landable) {

                        Text("Ready to land", style = MaterialTheme.typography.titleMedium, color = status.ok)

                    } else {

                        Text("Not ready to land", style = MaterialTheme.typography.titleMedium)

                        p.blockers.forEach { b ->

                            Row(verticalAlignment = Alignment.Top) {

                                Icon(Icons.Outlined.WarningAmber, contentDescription = null, tint = status.bad, modifier = Modifier.size(18.dp).padding(top = 2.dp))

                                Spacer(Modifier.width(8.dp))

                                Text(b, style = MaterialTheme.typography.bodyMedium)

                            }

                        }

                    }

                    if (!canWrite) {

                        Text(

                            "This phone was signed in to read only. Sign in again to allow landing.",

                            style = MaterialTheme.typography.bodyMedium,

                            color = MaterialTheme.colorScheme.onSurfaceVariant,

                        )

                        OutlinedButton(onClick = onSignInAgain) { Text("Sign in again") }

                    } else {

                        Button(onClick = { confirming = true }, enabled = p.landable && !working, modifier = Modifier.fillMaxWidth()) {

                            Text("Land into ${p.target}")

                        }

                        Row(verticalAlignment = Alignment.CenterVertically) {

                            Column(Modifier.weight(1f)) {

                                Text("Land when its checks pass", style = MaterialTheme.typography.bodyLarge)

                                Text(

                                    p.autoLand?.let { "Set by $it" } ?: "Lands by itself once nothing stands in the way.",

                                    style = MaterialTheme.typography.bodySmall,

                                    color = MaterialTheme.colorScheme.onSurfaceVariant,

                                )

                            }

                            Switch(checked = p.autoLand != null, onCheckedChange = onAutoLand, enabled = !working && !p.isDraft)

                        }

                    }

                }

            }

            if (working) LinearProgressIndicator(Modifier.fillMaxWidth())

            if (action is LandAction.Failed) {

                Text(action.message, color = status.bad, style = MaterialTheme.typography.bodyMedium)

                Row(horizontalArrangement = Arrangement.spacedBy(8.dp)) {

                    if (action.needsWrite) OutlinedButton(onClick = onSignInAgain) { Text("Sign in again") }

                    TextButton(onClick = onDismiss) { Text("OK") }

                }

            }

        }

    }

    if (confirming) {

        AlertDialog(

            onDismissRequest = { confirming = false },

            title = { Text("Land #${p.number}?") },

            text = { Text("“${p.title}” lands into ${p.target} on the hub, as LAND on its page does.") },

            confirmButton = {

                TextButton(onClick = {

                    confirming = false

                    onLand()

                }) { Text("Land") }

            },

            dismissButton = { TextButton(onClick = { confirming = false }) { Text("Cancel") } },

        )

    }

}

@Composable

private fun Checks(checks: List<Check>?, onOpen: (Check) -> Unit) {

    val status = LocalStatusColors.current

    Section(

        when {

            checks == null -> "Checks"

            checks.isEmpty() -> "Checks"

            else -> "Checks · ${checks.count { it.status == "passed" }} of ${checks.size} passed"

        },

    ) {

        when {

            checks == null -> Text("The checks could not be read.", Modifier.padding(16.dp))

            checks.isEmpty() -> Text("No checks have run on what it would land.", Modifier.padding(16.dp))

            else -> checks.sortedBy { order(it.status) }.forEachIndexed { i, c ->

                if (i > 0) HorizontalDivider()

                ListItem(

                    modifier = Modifier.clickable { onOpen(c) },

                    leadingContent = {

                        when (c.status) {

                            "passed" -> Icon(Icons.Outlined.CheckCircle, "Passed", tint = status.ok)

                            "failed" -> Icon(Icons.Outlined.Cancel, "Failed", tint = status.bad)

                            "running" -> CircularProgressIndicator(Modifier.size(22.dp), strokeWidth = 2.dp)

                            "queued" -> Icon(Icons.Outlined.Schedule, "Queued", tint = MaterialTheme.colorScheme.onSurfaceVariant)

                            else -> Icon(Icons.Outlined.RemoveCircleOutline, c.status, tint = MaterialTheme.colorScheme.onSurfaceVariant)

                        }

                    },

                    headlineContent = { Text(c.name) },

                    supportingContent = if (c.summary.isNotBlank()) ({ Text(c.summary) }) else null,

                )

            }

        }

    }

}

/** Failures first, then what is still going, then the rest. */

private fun order(status: String): Int = when (status) {

    "failed" -> 0

    "running" -> 1

    "queued" -> 2

    else -> 3

}

@Composable

private fun Reviews(p: Proposal) {

    if (p.approvals.isEmpty() && p.requestedReviewers.isEmpty()) return

    Section("Reviews") {

        Column(Modifier.padding(vertical = 4.dp)) {

            p.approvals.forEach { a ->

                ListItem(

                    leadingContent = { Icon(Icons.Outlined.CheckCircle, null, tint = LocalStatusColors.current.ok) },

                    headlineContent = { Text(a.account) },

                    supportingContent = { Text(if (a.sealed) "approved, sealed" else "approved, not sealed: it does not count yet") },

                    trailingContent = if (a.sealed) ({ Icon(Icons.Outlined.Lock, "Sealed") }) else null,

                )

            }

            p.requestedReviewers.forEach { r ->

                ListItem(

                    leadingContent = { Icon(Icons.Outlined.Schedule, null) },

                    headlineContent = { Text(r) },

                    supportingContent = { Text("asked to review") },

                )

            }

        }

    }

}

@Composable

private fun Changes(p: Proposal) {

    if (p.changes.isEmpty()) return

    Section("Changes · ${p.changes.size}") {

        Column {

            p.changes.asReversed().forEachIndexed { i, c ->

                if (i > 0) HorizontalDivider()

                ListItem(

                    headlineContent = { Text(c.subject.ifBlank { "(no message)" }) },

                    supportingContent = { Text(c.hash.take(12), fontFamily = FontFamily.Monospace) },

                )

            }

        }

    }

}

@Composable

private fun Section(title: String, content: @Composable () -> Unit) {

    Column(verticalArrangement = Arrangement.spacedBy(8.dp)) {

        Text(title, style = MaterialTheme.typography.titleMedium, fontWeight = FontWeight.SemiBold)

        ElevatedCard(Modifier.fillMaxWidth()) { content() }

    }

}

package io.oxygenhub.android.ui.proposals

import androidx.lifecycle.ViewModel

import androidx.lifecycle.viewModelScope

import io.oxygenhub.android.api.Check

import io.oxygenhub.android.api.HubApi

import io.oxygenhub.android.api.HubException

import io.oxygenhub.android.api.Proposal

import io.oxygenhub.android.api.WriteScope

import io.oxygenhub.android.api.lackedScope

import io.oxygenhub.android.api.userMessage

import io.oxygenhub.android.ui.common.Load

import io.oxygenhub.android.ui.common.load

import kotlinx.coroutines.CancellationException

import kotlinx.coroutines.Job

import kotlinx.coroutines.async

import kotlinx.coroutines.coroutineScope

import kotlinx.coroutines.flow.MutableStateFlow

import kotlinx.coroutines.flow.StateFlow

import kotlinx.coroutines.flow.asStateFlow

import kotlinx.coroutines.launch

/** A proposal and the checks on what it would land; [checks] is null when they could not be read. */

data class ProposalPage(val proposal: Proposal, val checks: List<Check>?)

/** What landing (or setting it to land by itself) is doing, or did. */

sealed interface LandAction {

    data object Idle : LandAction

    data object Working : LandAction

    data class Done(val message: String) : LandAction

    /** [needsWrite]: the token may not change things; signing in again asks for it. */

    data class Failed(val message: String, val needsWrite: Boolean = false) : LandAction

}

/** One proposal, with its checks; lands it, or sets it to land when its checks pass. */

class ProposalViewModel(

    private val api: HubApi,

    val owner: String,

    val name: String,

    val number: Long,

) : ViewModel() {

    private val _state = MutableStateFlow<Load<ProposalPage>>(Load.Loading)

    val state: StateFlow<Load<ProposalPage>> = _state.asStateFlow()

    private val _action = MutableStateFlow<LandAction>(LandAction.Idle)

    val action: StateFlow<LandAction> = _action.asStateFlow()

    private var job: Job? = null

    init {

        refresh()

    }

    fun refresh() {

        job = load(_state, job) {

            coroutineScope {

                // The checks are part of the picture, not the page: without them it still shows.

                val checks = async {

                    try {

                        api.checks(owner, name, number)

                    } catch (e: CancellationException) {

                        throw e

                    } catch (_: Exception) {

                        null

                    }

                }

                ProposalPage(api.proposal(owner, name, number), checks.await())

            }

        }

    }

    fun land() = act { p ->

        val landed = api.land(owner, name, number)

        landed to "Landed #$number into ${p.target}."

    }

    fun setAutoLand(on: Boolean) = act { _ ->

        val after = api.setAutoLand(owner, name, number, on)

        after to if (on) {

            if (after.landed != null) "Its checks had passed: landed #$number." else "#$number will land when its checks pass."

        } else {

            "#$number will not land by itself."

        }

    }

    fun dismiss() {

        _action.value = LandAction.Idle

    }

    private fun act(work: suspend (Proposal) -> Pair<Proposal, String>) {

        val page = _state.value.valueOrNull ?: return

        if (_action.value == LandAction.Working) return

        _action.value = LandAction.Working

        viewModelScope.launch {

            _action.value = try {

                val (after, message) = work(page.proposal)

                _state.value = Load.Ready(page.copy(proposal = after))

                LandAction.Done(message)

            } catch (e: CancellationException) {

                throw e

            } catch (e: Exception) {

                failure(e)

            }

            // What the hub thinks now: blockers, checks, who set auto-land.

            refresh()

        }

    }

    companion object {

        fun failure(e: Exception): LandAction.Failed = when {

            e.lackedScope == WriteScope -> LandAction.Failed(

                "This phone was signed in to read only. Sign in again to allow landing.",

                needsWrite = true,

            )

            // The hub's own reason: blockers, a conflict, a race with another landing.

            e is HubException.Http && e.status == 409 -> LandAction.Failed(e.detail)

            else -> LandAction.Failed(e.userMessage())

        }

    }

}

package io.oxygenhub.android.ui.proposals

import androidx.lifecycle.ViewModel

import io.oxygenhub.android.api.HubApi

import io.oxygenhub.android.api.Proposal

import io.oxygenhub.android.api.ProposalState

import io.oxygenhub.android.ui.common.Load

import io.oxygenhub.android.ui.common.load

import kotlinx.coroutines.Job

import kotlinx.coroutines.flow.MutableStateFlow

import kotlinx.coroutines.flow.StateFlow

import kotlinx.coroutines.flow.asStateFlow

/** A repository's proposals: open (with drafts), landed, closed or all; newest first. */

class ProposalsViewModel(

    private val api: HubApi,

    val owner: String,

    val name: String,

) : ViewModel() {

    private val _state = MutableStateFlow<Load<List<Proposal>>>(Load.Loading)

    val state: StateFlow<Load<List<Proposal>>> = _state.asStateFlow()

    private val _filter = MutableStateFlow(ProposalState.Open)

    val filter: StateFlow<ProposalState> = _filter.asStateFlow()

    private var job: Job? = null

    init {

        refresh()

    }

    fun setFilter(state: ProposalState) {

        if (state == _filter.value) return

        _filter.value = state

        _state.value = Load.Loading

        refresh()

    }

    fun refresh() {

        val state = _filter.value

        job = load(_state, job) { api.proposals(owner, name, state).sortedByDescending { it.number } }

    }

}

package io.oxygenhub.android.ui.repos

import androidx.compose.foundation.layout.Column

import androidx.compose.foundation.layout.fillMaxSize

import androidx.compose.material3.PrimaryTabRow

import androidx.compose.material3.Tab

import androidx.compose.material3.Text

import androidx.compose.runtime.Composable

import androidx.compose.runtime.getValue

import androidx.compose.runtime.mutableIntStateOf

import androidx.compose.runtime.saveable.rememberSaveable

import androidx.compose.runtime.setValue

import androidx.compose.ui.Modifier

import io.oxygenhub.android.api.Proposal

import io.oxygenhub.android.ui.common.AppScreen

import io.oxygenhub.android.ui.issues.IssueList

import io.oxygenhub.android.ui.issues.IssuesViewModel

import io.oxygenhub.android.ui.proposals.ProposalList

import io.oxygenhub.android.ui.proposals.ProposalsViewModel

/** A repository's tabs: its issues and its proposals (the overview, code and history follow, #3). */

enum class RepositoryTab(val label: String) { Issues("Issues"), Proposals("Proposals") }

@Composable

fun RepositoryScreen(

    issues: IssuesViewModel,

    proposals: ProposalsViewModel,

    onBack: (() -> Unit)?,

    onOpenProposal: (Proposal) -> Unit,

    initialTab: RepositoryTab = RepositoryTab.Issues,

) {

    var tab by rememberSaveable { mutableIntStateOf(initialTab.ordinal) }

    AppScreen(title = "${issues.owner}/${issues.name}", onBack = onBack) {

        Column(Modifier.fillMaxSize()) {

            PrimaryTabRow(selectedTabIndex = tab) {

                RepositoryTab.entries.forEach { t ->

                    Tab(selected = tab == t.ordinal, onClick = { tab = t.ordinal }, text = { Text(t.label) })

                }

            }

            when (RepositoryTab.entries[tab]) {

                RepositoryTab.Issues -> IssueList(issues)

                RepositoryTab.Proposals -> ProposalList(proposals, onOpenProposal)

            }

        }

    }

}

package io.oxygenhub.android.ui

import io.oxygenhub.android.FakeHubApi

import io.oxygenhub.android.MainDispatcherRule

import io.oxygenhub.android.api.HubException

import io.oxygenhub.android.api.ProposalState

import io.oxygenhub.android.auth.Session

import io.oxygenhub.android.ui.common.Load

import io.oxygenhub.android.ui.proposals.LandAction

import io.oxygenhub.android.ui.proposals.ProposalPage

import io.oxygenhub.android.ui.proposals.ProposalViewModel

import io.oxygenhub.android.ui.proposals.ProposalsViewModel

import org.junit.Assert.assertEquals

import org.junit.Assert.assertFalse

import org.junit.Assert.assertNull

import org.junit.Assert.assertTrue

import org.junit.Rule

import org.junit.Test

class ProposalViewModelTest {

    @get:Rule val main = MainDispatcherRule()

    private val api = FakeHubApi()

    private fun page(vm: ProposalViewModel): ProposalPage = (vm.state.value as Load.Ready).value

    @Test

    fun listsOpenProposalsNewestFirstAndTheLandedOnAsked() {

        val vm = ProposalsViewModel(api, "andymccall", "oxygenhub")

        assertEquals(listOf(301L, 300L), (vm.state.value as Load.Ready).value.map { it.number })

        vm.setFilter(ProposalState.Landed)

        assertEquals(listOf(264L), (vm.state.value as Load.Ready).value.map { it.number })

        assertTrue("proposals andymccall/oxygenhub landed" in api.calls)

    }

    @Test

    fun showsAProposalWithItsChecks() {

        val p = page(ProposalViewModel(api, "andymccall", "oxygenhub", 300))

        assertTrue(p.proposal.landable)

        assertEquals(5, p.checks?.size)

    }

    @Test

    fun withoutItsChecksTheProposalStillShows() {

        api.checks = { throw HubException.Http(500, "down") }

        val p = page(ProposalViewModel(api, "andymccall", "oxygenhub", 300))

        assertNull(p.checks)

        assertEquals(300L, p.proposal.number)

    }

    @Test

    fun landingSaysSoAndShowsItLanded() {

        val vm = ProposalViewModel(api, "andymccall", "oxygenhub", 300)

        // The hub's answer after landing, as the refresh will read it.

        val landed = api.land(300)

        api.proposal = { landed }

        vm.land()

        assertEquals(LandAction.Done("Landed #300 into main."), vm.action.value)

        assertEquals("landed", page(vm).proposal.state)

        assertTrue("land 300" in api.calls)

    }

    @Test

    fun aRefusalShowsTheHubsReason() {

        api.land = { throw HubException.Http(409, "required checks not passed on the projected state: test") }

        val vm = ProposalViewModel(api, "andymccall", "oxygenhub", 300)

        vm.land()

        assertEquals(LandAction.Failed("required checks not passed on the projected state: test"), vm.action.value)

        assertEquals("open", page(vm).proposal.state)

        vm.dismiss()

        assertEquals(LandAction.Idle, vm.action.value)

    }

    @Test

    fun aReadOnlyTokenIsAskedToSignInAgain() {

        api.land = { throw HubException.Http(403, "this token lacks the repo:write scope") }

        val vm = ProposalViewModel(api, "andymccall", "oxygenhub", 300)

        vm.land()

        val f = vm.action.value as LandAction.Failed

        assertTrue(f.needsWrite)

        // Another 403 is not about the scope.

        assertFalse(ProposalViewModel.failure(HubException.Http(403, "only maintainers may land over checks")).needsWrite)

    }

    @Test

    fun autoLandIsSetAndCleared() {

        val vm = ProposalViewModel(api, "andymccall", "oxygenhub", 301)

        assertEquals("andymccall", page(vm).proposal.autoLand)

        val cleared = api.autoLand(301, false)

        api.proposal = { cleared }

        vm.setAutoLand(false)

        assertEquals(LandAction.Done("#301 will not land by itself."), vm.action.value)

        assertNull(page(vm).proposal.autoLand)

        assertTrue("auto-land 301 false" in api.calls)

    }

    @Test

    fun aSessionMayWriteOnlyWithTheScope() {

        assertTrue(Session("h", "u", "t", listOf("repo:read", "repo:write")).canWrite)

        assertFalse(Session("h", "u", "t", listOf("repo:read", "user:read")).canWrite)

        // The hub did not say: let it decide.

        assertTrue(Session("h", "u", "t").canWrite)

    }

}

[

 {

  "state": "260f02ef1913677e77b72d5b40cbaf6b02def0d2b2bf8aca064e2e19b075c3e9",

  "name": "flow/build",

  "status": "passed",

  "summary": "passed in 7 min 32 s",

  "url": "https://oxygenhub.io/andymccall/oxygenhub/flow/439",

  "reporter": "",

  "seal": null,

  "started_ms": 1792917458200,

  "finished_ms": 1792917926675

 },

 {

  "state": "260f02ef1913677e77b72d5b40cbaf6b02def0d2b2bf8aca064e2e19b075c3e9",

  "name": "flow/clippy",

  "status": "failed",

  "summary": "failed in 1 min 20 s",

  "url": "https://oxygenhub.io/andymccall/oxygenhub/flow/439",

  "reporter": "",

  "seal": null,

  "started_ms": 1792917458202,

  "finished_ms": 1792917553195

 },

 {

  "state": "260f02ef1913677e77b72d5b40cbaf6b02def0d2b2bf8aca064e2e19b075c3e9",

  "name": "flow/fmt",

  "status": "running",

  "summary": "running for 3 min",

  "url": "https://oxygenhub.io/andymccall/oxygenhub/flow/439",

  "reporter": "",

  "seal": null,

  "started_ms": 1792917458198,

  "finished_ms": null

 },

 {

  "state": "260f02ef1913677e77b72d5b40cbaf6b02def0d2b2bf8aca064e2e19b075c3e9",

  "name": "flow/test",

  "status": "passed",

  "summary": "passed in 4 min 33 s",

  "url": "https://oxygenhub.io/andymccall/oxygenhub/flow/439",

  "reporter": "",

  "seal": null,

  "started_ms": 1792917458204,

  "finished_ms": 1792917827616

 },

 {

  "state": "260f02ef1913677e77b72d5b40cbaf6b02def0d2b2bf8aca064e2e19b075c3e9",

  "name": "flow/test-postgres",

  "status": "passed",

  "summary": "passed in 4 min 56 s",

  "url": "https://oxygenhub.io/andymccall/oxygenhub/flow/439",

  "reporter": "",

  "seal": null,

  "started_ms": 1792917458205,

  "finished_ms": 1792918141806

 }

]

{

 "number": 300,

 "title": "Show a column's archived cards",

 "body": "Closes #263 (reported by RSTAR: a landed proposal's queued run kept its place ahead of main's, seven times on 2026-10-18).\n\nOn landing, `flow::moot_after_landing` cancels the proposal's runs that **no runner has started**:\n- its source bookmark's `push` runs, when the source is a bookmark in this repository and not the target;\n- its `proposal/N` runs (the re-check after the target moved).\n\nEach job says `moot: proposal #N landed`. Runs already going finish; other bookmarks' runs are untouched. Called from every landing path: `land_as` (web, API, auto-land), `settle_after_push` (a push that holds the work), and the page finding it landed by another route.\n\nTests: `landing_cancels_the_proposals_unstarted_runs` (queued source run and proposal run cancelled with the reason, a running one left, another bookmark's left). Gate green (fmt, clippy, 284 tests); proposals tests green on Postgres. No migration.",

 "author": "andymccall",

 "state": "open",

 "target": "main",

 "source": {

  "kind": "bookmark",

  "bookmark": "cancel-landed-runs"

 },

 "changes": [

  {

   "hash": "2abea30809ddf37d992b1ab5743b0f2b0c7daa1ddef9ecc1bd93864948816602",

   "message": "Cancel a landed proposal's runs that have not started\n\nThey can no longer change anything, and they held the queue ahead of the\ntarget's own run (refs #263). On landing (web, API, auto-land, a push\nthat holds the work, or the page finding it landed by another route),\nflow::moot_after_landing cancels the proposal's queued runs: its source\nbookmark's push runs, when that bookmark is in this repository, and its\nproposal/N runs, each job saying \"moot: proposal #N landed\". Runs that\nhave started finish. Test landing_cancels_the_proposals_unstarted_runs.",

   "author": {

    "name": "Andy McCall",

    "email": "[email protected]",

    "key": "4cd9916c150f426895a390868c6999314e0ef4955d657f30d2805647c747fc65",

    "account": null,

    "note": "signed by a key not linked to any account; its owner links it under Settings \u2192 Keys (/settings/keys)"

   },

   "when_ms": 1792360184287,

   "deps": [

    "0b20f1ec4007b9c864a8cebcb8945898b88c391cc0c6d85f8f58aeb60f685b47",

    "2a8b621676b42cbc143f985eb3226e83d515504dda995db118836ab6beb672f6"

   ],

   "head": false,

   "signature": {

    "status": "unsigned"

   }

  }

 ],

 "projected_heads": [

  "021f36a627f32602d06536c414c44f9c7448e2424a05286b46da4804baa53591",

  "0cd118748131b9e7e98a2c9b7b50df8ebcbda337097e6b2d61110408cc4d9b33",

  "19355e2283aba765a8a52394216f332db76663c2c0f5c31719803c2a72ad2b55",

  "1966661b1880eb65b7662730b9e609f06d0cbe16dddba1e9a8be8599f5296079",

  "19c71c828f86cc7dbcdd8d0c8d34d9f470b90a45d4bc384686498305b0f6b33e",

  "1b770a1fecf00ba25f4dec05fffd399e8805234618e48ded335d64c955bb5374",

  "1d9702887eee79babadd1a7aa8314ef4500def25217c5137a4ee5587f8be3db0",

  "1e23d0105921f536b1cf0483972849e0255efeb89b7f53656e36d2a8839ca14d",

  "20c36ed92b6b052a02ef585998dc7e42b857a014d92920c913f3507ba345a620",

  "260c33b4b6c4d8d23000b3d146fed71ec748a95dc6fc058119ed2a7c1627d31f",

  "2bbdc0268c23bb07c0fd0ea8922eb70e8bfa18da6bb303ec4a59e7ab5dae7fe2",

  "2d58f17e728b4125bbd7b5d2be9c692536e336f53bd3b34dc56f0361b38b50df",

  "317d776c725b16fe9ed5fd849f2fcb21afdd53bdce4d1c1eca038fc90f44e426",

  "32cfb089f5e6a8eede757776fa39cf1fe98594bda3c89cfc867f07d768d7b510",

  "3a01077da29aabb3ce6154e495f4d2064756cdef5094f011eb0da88e1fe60687",

  "3e5cd2eba62654482a1214b1c387ffce03fa802047622660d17878689e42007f",

  "439ecd8708a13ffd255537fab186ab2b3f49ef9f6a8684d55b0b294d434d6ab7",

  "4745b9844987f696f39f21d7036d00f92adec2b9a507e740fdb7bd28f5fd1d72",

  "5436f0dd942938b88d95fa7451994bfec9477a11cea9c9d15df6854bd9f5a828",

  "56a786aa42f1e2a8c6da70e1acbc76edc81a8c746294d06d9c1be6fa6725e2bf",

  "6978fd76a0666e56bc28171db3f8add9e346ebe90497646c92b8ab10c99a28dc",

  "6ff755541a622b944b170f3a83dfb95ecf972a4387dd77ff481a34df28e05e82",

  "72cde3da4176aff69eecc9cc4a625aa277dc22cd4cd5728ab1e18d0646135100",

  "73beb84b202a8785d9caf0bb65e04c2feb6ae60cea0d5779133cba332a033cb8",

  "76f93eaefe451cb3fe2daefccf8fd5b8c3bbb071a030a6876459bcde7ac54664",

  "92cea629fdf6614fe819c850b117a530402d079bc5dfc690ddacb0fe044fd336",

  "967ef74f6fd9847b2d48a7a20b27bade903fe122f34d4eab7e48efb5242a0020",

  "9991530b4beee381b95233964971965ad66ac833968f4c8f1fdbf4f1c2fb1713",

  "9aee52d392a67323824e269c3f0ffdf4c0e066e2bba44bd4d9204368f3a034a1",

  "9bc6b4720fc12185874a9710b310ddb36d2625cd86d653d23783b960915ef19d",

  "a0dd06b0094eb52d4347f6bde0572de667a0d2cbac5878d9e6928ec3bba09947",

  "a2b29af1ce88b4649df2c55022862b05a3c1079a0a325a5bd4ab6764b473cbd5",

  "a2ef53c5db269fa8bc86bb8abb13bb10ccba916129a301ca8738cb4829ff6680",

  "a7c05940ebc4ba5c73eb14afcc7579680e1cdb53995e464db10d617e055c5d57",

  "ad01845c4bf86859c3072a48277436580de78bbfe6ea6bc85de9b350522bf92b",

  "ae138eea7a71055eed1bdb63b016828e6bbe2de7ff2b8b06a741ebeaa759e950",

  "bd630386001ed3d0fc0d03c01548c193a2297f90b6fedb00b5883259f9ca1ad0",

  "bd91edeb44f8f318af68521ca74c35ee48f09e1002ce0c5972bc8ac10cea6862",

  "c21ef37dd4a0641cafb7fe4cf430093934e416d10b582d4183d9c30f722f42e5",

  "c2732e07323b52f2491200ad8989352bc6fc6834c4d97a21e550b3abbe0acafb",

  "c33dbd9a0d38f03313995c1259c16adbd34571f06efe1a71438b51783f1d7b36",

  "cefb0ea24511445166d0db129929255276092d452c7832e877235b49fcdc5881",

  "d2077a57b1f9a114ebdee7cf9e95e81f8932ebc82b59b4b126664a6b1941260b",

  "d2c1d6a7d12edeaca968546dc2fde25068f3de0afaee844ff11d5afd514e43eb",

  "d336629ffa906b6783adf44337015e3c3d9d4437a6a4f97734367f903674db51",

  "d4a0043fded4b0533c2f0377373bce57e38279a2b3935cdc62be08123505630b",

  "d94449e42718409b41ab98335c6641b2b4429332e8a1cab535e76467509986b4",

  "d9b3b84605a4f30f778d73011e379e8178f33d8d2c6d3d6704c7f5f7e108d5f7",

  "db72849cd22e82e6160e21528548f9766cf4b10867415ce1b2fe177bfa05e71f",

  "dc71378db1dc95169f80a85c58c80bc86dbd44546a90607b3a49297ec2e1843e",

  "df68c58de9471dd2f1eada82669cb2adee804c70fd2507876790c00f10edf73f",

  "e1078e99c5604bb12c431c02dacb6fba8ea2a0515abe39b3accedd23c78af9ac",

  "e15409084ed6de68f460f830d74c15458dcee9ab20a6c8dd39145d04a895d54e",

  "edcef27575a73e6acece529d1c0d3bb9f3509123de1a2c049ef4c0dd28b38bba",

  "efb51b39db1c38e7b881f05a1ce1c46d09dc3317349df6ebfd24a2c6d12279db",

  "f0f6c2d96b1cbdde9c994fe79244bfc4237f3392fc53c71abc5537085c745353",

  "f157bcea0e329a44ac78d59b88fb11028b05d17aa820106d94ba128d777df124",

  "f59e9680d880b1abc8c0b3ac7efb316c71d0001936e45fae4decc1f4a9829f47"

 ],

 "projected_state": "260f02ef1913677e77b72d5b40cbaf6b02def0d2b2bf8aca064e2e19b075c3e9",

 "conflicted": false,

 "approvals": [],

 "landable": true,

 "blockers": [],

 "created_ms": 1792360202344,

 "updated_ms": 1792400658285,

 "url": "https://oxygenhub.io/andymccall/oxygenhub/proposal/264",

 "repository_url": "https://oxygenhub.io/andymccall/oxygenhub",

 "source_url": null,

 "landed": null,

 "auto_land": null,

 "requested_reviewers": [

  "ada"

 ],

 "labels": [

  {

   "name": "performance",

   "colour": "#b48cff",

   "description": "Faster or lighter"

  }

 ]

}

[

 {

  "number": 300,

  "title": "Show a column's archived cards",

  "body": "Closes #263 (reported by RSTAR: a landed proposal's queued run kept its place ahead of main's, seven times on 2026-10-18).\n\nOn landing, `flow::moot_after_landing` cancels the proposal's runs that **no runner has started**:\n- its source bookmark's `push` runs, when the source is a bookmark in this repository and not the target;\n- its `proposal/N` runs (the re-check after the target moved).\n\nEach job says `moot: proposal #N landed`. Runs already going finish; other bookmarks' runs are untouched. Called from every landing path: `land_as` (web, API, auto-land), `settle_after_push` (a push that holds the work), and the page finding it landed by another route.\n\nTests: `landing_cancels_the_proposals_unstarted_runs` (queued source run and proposal run cancelled with the reason, a running one left, another bookmark's left). Gate green (fmt, clippy, 284 tests); proposals tests green on Postgres. No migration.",

  "author": "andymccall",

  "state": "open",

  "target": "main",

  "source": {

   "kind": "bookmark",

   "bookmark": "cancel-landed-runs"

  },

  "changes": [

   {

    "hash": "2abea30809ddf37d992b1ab5743b0f2b0c7daa1ddef9ecc1bd93864948816602",

    "message": "Cancel a landed proposal's runs that have not started\n\nThey can no longer change anything, and they held the queue ahead of the\ntarget's own run (refs #263). On landing (web, API, auto-land, a push\nthat holds the work, or the page finding it landed by another route),\nflow::moot_after_landing cancels the proposal's queued runs: its source\nbookmark's push runs, when that bookmark is in this repository, and its\nproposal/N runs, each job saying \"moot: proposal #N landed\". Runs that\nhave started finish. Test landing_cancels_the_proposals_unstarted_runs.",

    "author": {

     "name": "Andy McCall",

     "email": "[email protected]",

     "key": "4cd9916c150f426895a390868c6999314e0ef4955d657f30d2805647c747fc65",

     "account": null,

     "note": "signed by a key not linked to any account; its owner links it under Settings \u2192 Keys (/settings/keys)"

    },

    "when_ms": 1792360184287,

    "deps": [

     "0b20f1ec4007b9c864a8cebcb8945898b88c391cc0c6d85f8f58aeb60f685b47",

     "2a8b621676b42cbc143f985eb3226e83d515504dda995db118836ab6beb672f6"

    ],

    "head": false,

    "signature": {

     "status": "unsigned"

    }

   }

  ],

  "projected_heads": [

   "021f36a627f32602d06536c414c44f9c7448e2424a05286b46da4804baa53591",

   "0cd118748131b9e7e98a2c9b7b50df8ebcbda337097e6b2d61110408cc4d9b33",

   "19355e2283aba765a8a52394216f332db76663c2c0f5c31719803c2a72ad2b55",

   "1966661b1880eb65b7662730b9e609f06d0cbe16dddba1e9a8be8599f5296079",

   "19c71c828f86cc7dbcdd8d0c8d34d9f470b90a45d4bc384686498305b0f6b33e",

   "1b770a1fecf00ba25f4dec05fffd399e8805234618e48ded335d64c955bb5374",

   "1d9702887eee79babadd1a7aa8314ef4500def25217c5137a4ee5587f8be3db0",

   "1e23d0105921f536b1cf0483972849e0255efeb89b7f53656e36d2a8839ca14d",

   "20c36ed92b6b052a02ef585998dc7e42b857a014d92920c913f3507ba345a620",

   "260c33b4b6c4d8d23000b3d146fed71ec748a95dc6fc058119ed2a7c1627d31f",

   "2bbdc0268c23bb07c0fd0ea8922eb70e8bfa18da6bb303ec4a59e7ab5dae7fe2",

   "2d58f17e728b4125bbd7b5d2be9c692536e336f53bd3b34dc56f0361b38b50df",

   "317d776c725b16fe9ed5fd849f2fcb21afdd53bdce4d1c1eca038fc90f44e426",

   "32cfb089f5e6a8eede757776fa39cf1fe98594bda3c89cfc867f07d768d7b510",

   "3a01077da29aabb3ce6154e495f4d2064756cdef5094f011eb0da88e1fe60687",

   "3e5cd2eba62654482a1214b1c387ffce03fa802047622660d17878689e42007f",

   "439ecd8708a13ffd255537fab186ab2b3f49ef9f6a8684d55b0b294d434d6ab7",

   "4745b9844987f696f39f21d7036d00f92adec2b9a507e740fdb7bd28f5fd1d72",

   "5436f0dd942938b88d95fa7451994bfec9477a11cea9c9d15df6854bd9f5a828",

   "56a786aa42f1e2a8c6da70e1acbc76edc81a8c746294d06d9c1be6fa6725e2bf",

   "6978fd76a0666e56bc28171db3f8add9e346ebe90497646c92b8ab10c99a28dc",

   "6ff755541a622b944b170f3a83dfb95ecf972a4387dd77ff481a34df28e05e82",

   "72cde3da4176aff69eecc9cc4a625aa277dc22cd4cd5728ab1e18d0646135100",

   "73beb84b202a8785d9caf0bb65e04c2feb6ae60cea0d5779133cba332a033cb8",

   "76f93eaefe451cb3fe2daefccf8fd5b8c3bbb071a030a6876459bcde7ac54664",

   "92cea629fdf6614fe819c850b117a530402d079bc5dfc690ddacb0fe044fd336",

   "967ef74f6fd9847b2d48a7a20b27bade903fe122f34d4eab7e48efb5242a0020",

   "9991530b4beee381b95233964971965ad66ac833968f4c8f1fdbf4f1c2fb1713",

   "9aee52d392a67323824e269c3f0ffdf4c0e066e2bba44bd4d9204368f3a034a1",

   "9bc6b4720fc12185874a9710b310ddb36d2625cd86d653d23783b960915ef19d",

   "a0dd06b0094eb52d4347f6bde0572de667a0d2cbac5878d9e6928ec3bba09947",

   "a2b29af1ce88b4649df2c55022862b05a3c1079a0a325a5bd4ab6764b473cbd5",

   "a2ef53c5db269fa8bc86bb8abb13bb10ccba916129a301ca8738cb4829ff6680",

   "a7c05940ebc4ba5c73eb14afcc7579680e1cdb53995e464db10d617e055c5d57",

   "ad01845c4bf86859c3072a48277436580de78bbfe6ea6bc85de9b350522bf92b",

   "ae138eea7a71055eed1bdb63b016828e6bbe2de7ff2b8b06a741ebeaa759e950",

   "bd630386001ed3d0fc0d03c01548c193a2297f90b6fedb00b5883259f9ca1ad0",

   "bd91edeb44f8f318af68521ca74c35ee48f09e1002ce0c5972bc8ac10cea6862",

   "c21ef37dd4a0641cafb7fe4cf430093934e416d10b582d4183d9c30f722f42e5",

   "c2732e07323b52f2491200ad8989352bc6fc6834c4d97a21e550b3abbe0acafb",

   "c33dbd9a0d38f03313995c1259c16adbd34571f06efe1a71438b51783f1d7b36",

   "cefb0ea24511445166d0db129929255276092d452c7832e877235b49fcdc5881",

   "d2077a57b1f9a114ebdee7cf9e95e81f8932ebc82b59b4b126664a6b1941260b",

   "d2c1d6a7d12edeaca968546dc2fde25068f3de0afaee844ff11d5afd514e43eb",

   "d336629ffa906b6783adf44337015e3c3d9d4437a6a4f97734367f903674db51",

   "d4a0043fded4b0533c2f0377373bce57e38279a2b3935cdc62be08123505630b",

   "d94449e42718409b41ab98335c6641b2b4429332e8a1cab535e76467509986b4",

   "d9b3b84605a4f30f778d73011e379e8178f33d8d2c6d3d6704c7f5f7e108d5f7",

   "db72849cd22e82e6160e21528548f9766cf4b10867415ce1b2fe177bfa05e71f",

   "dc71378db1dc95169f80a85c58c80bc86dbd44546a90607b3a49297ec2e1843e",

   "df68c58de9471dd2f1eada82669cb2adee804c70fd2507876790c00f10edf73f",

   "e1078e99c5604bb12c431c02dacb6fba8ea2a0515abe39b3accedd23c78af9ac",

   "e15409084ed6de68f460f830d74c15458dcee9ab20a6c8dd39145d04a895d54e",

   "edcef27575a73e6acece529d1c0d3bb9f3509123de1a2c049ef4c0dd28b38bba",

   "efb51b39db1c38e7b881f05a1ce1c46d09dc3317349df6ebfd24a2c6d12279db",

   "f0f6c2d96b1cbdde9c994fe79244bfc4237f3392fc53c71abc5537085c745353",

   "f157bcea0e329a44ac78d59b88fb11028b05d17aa820106d94ba128d777df124",

   "f59e9680d880b1abc8c0b3ac7efb316c71d0001936e45fae4decc1f4a9829f47"

  ],

  "projected_state": "260f02ef1913677e77b72d5b40cbaf6b02def0d2b2bf8aca064e2e19b075c3e9",

  "conflicted": false,

  "approvals": [],

  "landable": true,

  "blockers": [],

  "created_ms": 1792360202344,

  "updated_ms": 1792400658285,

  "url": "https://oxygenhub.io/andymccall/oxygenhub/proposal/264",

  "repository_url": "https://oxygenhub.io/andymccall/oxygenhub",

  "source_url": null,

  "landed": null,

  "auto_land": null,

  "requested_reviewers": [

   "ada"

  ],

  "labels": [

   {

    "name": "performance",

    "colour": "#b48cff",

    "description": "Faster or lighter"

   }

  ]

 },

 {

  "number": 301,

  "title": "Move the hub to Postgres",

  "body": "Closes #263 (reported by RSTAR: a landed proposal's queued run kept its place ahead of main's, seven times on 2026-10-18).\n\nOn landing, `flow::moot_after_landing` cancels the proposal's runs that **no runner has started**:\n- its source bookmark's `push` runs, when the source is a bookmark in this repository and not the target;\n- its `proposal/N` runs (the re-check after the target moved).\n\nEach job says `moot: proposal #N landed`. Runs already going finish; other bookmarks' runs are untouched. Called from every landing path: `land_as` (web, API, auto-land), `settle_after_push` (a push that holds the work), and the page finding it landed by another route.\n\nTests: `landing_cancels_the_proposals_unstarted_runs` (queued source run and proposal run cancelled with the reason, a running one left, another bookmark's left). Gate green (fmt, clippy, 284 tests); proposals tests green on Postgres. No migration.",

  "author": "andymccall",

  "state": "open",

  "target": "main",

  "source": {

   "kind": "bookmark",

   "bookmark": "cancel-landed-runs"

  },

  "changes": [

   {

    "hash": "2abea30809ddf37d992b1ab5743b0f2b0c7daa1ddef9ecc1bd93864948816602",

    "message": "Cancel a landed proposal's runs that have not started\n\nThey can no longer change anything, and they held the queue ahead of the\ntarget's own run (refs #263). On landing (web, API, auto-land, a push\nthat holds the work, or the page finding it landed by another route),\nflow::moot_after_landing cancels the proposal's queued runs: its source\nbookmark's push runs, when that bookmark is in this repository, and its\nproposal/N runs, each job saying \"moot: proposal #N landed\". Runs that\nhave started finish. Test landing_cancels_the_proposals_unstarted_runs.",

    "author": {

     "name": "Andy McCall",

     "email": "[email protected]",

     "key": "4cd9916c150f426895a390868c6999314e0ef4955d657f30d2805647c747fc65",

     "account": null,

     "note": "signed by a key not linked to any account; its owner links it under Settings \u2192 Keys (/settings/keys)"

    },

    "when_ms": 1792360184287,

    "deps": [

     "0b20f1ec4007b9c864a8cebcb8945898b88c391cc0c6d85f8f58aeb60f685b47",

     "2a8b621676b42cbc143f985eb3226e83d515504dda995db118836ab6beb672f6"

    ],

    "head": false,

    "signature": {

     "status": "unsigned"

    }

   }

  ],

  "projected_heads": [

   "021f36a627f32602d06536c414c44f9c7448e2424a05286b46da4804baa53591",

   "0cd118748131b9e7e98a2c9b7b50df8ebcbda337097e6b2d61110408cc4d9b33",

   "19355e2283aba765a8a52394216f332db76663c2c0f5c31719803c2a72ad2b55",

   "1966661b1880eb65b7662730b9e609f06d0cbe16dddba1e9a8be8599f5296079",

   "19c71c828f86cc7dbcdd8d0c8d34d9f470b90a45d4bc384686498305b0f6b33e",

   "1b770a1fecf00ba25f4dec05fffd399e8805234618e48ded335d64c955bb5374",

   "1d9702887eee79babadd1a7aa8314ef4500def25217c5137a4ee5587f8be3db0",

   "1e23d0105921f536b1cf0483972849e0255efeb89b7f53656e36d2a8839ca14d",

   "20c36ed92b6b052a02ef585998dc7e42b857a014d92920c913f3507ba345a620",

   "260c33b4b6c4d8d23000b3d146fed71ec748a95dc6fc058119ed2a7c1627d31f",

   "2bbdc0268c23bb07c0fd0ea8922eb70e8bfa18da6bb303ec4a59e7ab5dae7fe2",

   "2d58f17e728b4125bbd7b5d2be9c692536e336f53bd3b34dc56f0361b38b50df",

   "317d776c725b16fe9ed5fd849f2fcb21afdd53bdce4d1c1eca038fc90f44e426",

   "32cfb089f5e6a8eede757776fa39cf1fe98594bda3c89cfc867f07d768d7b510",

   "3a01077da29aabb3ce6154e495f4d2064756cdef5094f011eb0da88e1fe60687",

   "3e5cd2eba62654482a1214b1c387ffce03fa802047622660d17878689e42007f",

   "439ecd8708a13ffd255537fab186ab2b3f49ef9f6a8684d55b0b294d434d6ab7",

   "4745b9844987f696f39f21d7036d00f92adec2b9a507e740fdb7bd28f5fd1d72",

   "5436f0dd942938b88d95fa7451994bfec9477a11cea9c9d15df6854bd9f5a828",

   "56a786aa42f1e2a8c6da70e1acbc76edc81a8c746294d06d9c1be6fa6725e2bf",

   "6978fd76a0666e56bc28171db3f8add9e346ebe90497646c92b8ab10c99a28dc",

   "6ff755541a622b944b170f3a83dfb95ecf972a4387dd77ff481a34df28e05e82",

   "72cde3da4176aff69eecc9cc4a625aa277dc22cd4cd5728ab1e18d0646135100",

   "73beb84b202a8785d9caf0bb65e04c2feb6ae60cea0d5779133cba332a033cb8",

   "76f93eaefe451cb3fe2daefccf8fd5b8c3bbb071a030a6876459bcde7ac54664",

   "92cea629fdf6614fe819c850b117a530402d079bc5dfc690ddacb0fe044fd336",

   "967ef74f6fd9847b2d48a7a20b27bade903fe122f34d4eab7e48efb5242a0020",

   "9991530b4beee381b95233964971965ad66ac833968f4c8f1fdbf4f1c2fb1713",

   "9aee52d392a67323824e269c3f0ffdf4c0e066e2bba44bd4d9204368f3a034a1",

   "9bc6b4720fc12185874a9710b310ddb36d2625cd86d653d23783b960915ef19d",

   "a0dd06b0094eb52d4347f6bde0572de667a0d2cbac5878d9e6928ec3bba09947",

   "a2b29af1ce88b4649df2c55022862b05a3c1079a0a325a5bd4ab6764b473cbd5",

   "a2ef53c5db269fa8bc86bb8abb13bb10ccba916129a301ca8738cb4829ff6680",

   "a7c05940ebc4ba5c73eb14afcc7579680e1cdb53995e464db10d617e055c5d57",

   "ad01845c4bf86859c3072a48277436580de78bbfe6ea6bc85de9b350522bf92b",

   "ae138eea7a71055eed1bdb63b016828e6bbe2de7ff2b8b06a741ebeaa759e950",

   "bd630386001ed3d0fc0d03c01548c193a2297f90b6fedb00b5883259f9ca1ad0",

   "bd91edeb44f8f318af68521ca74c35ee48f09e1002ce0c5972bc8ac10cea6862",

   "c21ef37dd4a0641cafb7fe4cf430093934e416d10b582d4183d9c30f722f42e5",

   "c2732e07323b52f2491200ad8989352bc6fc6834c4d97a21e550b3abbe0acafb",

   "c33dbd9a0d38f03313995c1259c16adbd34571f06efe1a71438b51783f1d7b36",

   "cefb0ea24511445166d0db129929255276092d452c7832e877235b49fcdc5881",

   "d2077a57b1f9a114ebdee7cf9e95e81f8932ebc82b59b4b126664a6b1941260b",

   "d2c1d6a7d12edeaca968546dc2fde25068f3de0afaee844ff11d5afd514e43eb",

   "d336629ffa906b6783adf44337015e3c3d9d4437a6a4f97734367f903674db51",

   "d4a0043fded4b0533c2f0377373bce57e38279a2b3935cdc62be08123505630b",

   "d94449e42718409b41ab98335c6641b2b4429332e8a1cab535e76467509986b4",

   "d9b3b84605a4f30f778d73011e379e8178f33d8d2c6d3d6704c7f5f7e108d5f7",

   "db72849cd22e82e6160e21528548f9766cf4b10867415ce1b2fe177bfa05e71f",

   "dc71378db1dc95169f80a85c58c80bc86dbd44546a90607b3a49297ec2e1843e",

   "df68c58de9471dd2f1eada82669cb2adee804c70fd2507876790c00f10edf73f",

   "e1078e99c5604bb12c431c02dacb6fba8ea2a0515abe39b3accedd23c78af9ac",

   "e15409084ed6de68f460f830d74c15458dcee9ab20a6c8dd39145d04a895d54e",

   "edcef27575a73e6acece529d1c0d3bb9f3509123de1a2c049ef4c0dd28b38bba",

   "efb51b39db1c38e7b881f05a1ce1c46d09dc3317349df6ebfd24a2c6d12279db",

   "f0f6c2d96b1cbdde9c994fe79244bfc4237f3392fc53c71abc5537085c745353",

   "f157bcea0e329a44ac78d59b88fb11028b05d17aa820106d94ba128d777df124",

   "f59e9680d880b1abc8c0b3ac7efb316c71d0001936e45fae4decc1f4a9829f47"

  ],

  "projected_state": "260f02ef1913677e77b72d5b40cbaf6b02def0d2b2bf8aca064e2e19b075c3e9",

  "conflicted": false,

  "approvals": [],

  "landable": false,

  "blockers": [

   "0 of 1 required sealed approvals",

   "required checks not passed on the projected state: test"

  ],

  "created_ms": 1792360202344,

  "updated_ms": 1792400658285,

  "url": "https://oxygenhub.io/andymccall/oxygenhub/proposal/264",

  "repository_url": "https://oxygenhub.io/andymccall/oxygenhub",

  "source_url": null,

  "landed": null,

  "auto_land": "andymccall",

  "requested_reviewers": [],

  "labels": [

   {

    "name": "performance",

    "colour": "#b48cff",

    "description": "Faster or lighter"

   }

  ]

 },

 {

  "number": 264,

  "title": "Cancel a landed proposal's runs that have not started (#263)",

  "body": "Closes #263 (reported by RSTAR: a landed proposal's queued run kept its place ahead of main's, seven times on 2026-10-18).\n\nOn landing, `flow::moot_after_landing` cancels the proposal's runs that **no runner has started**:\n- its source bookmark's `push` runs, when the source is a bookmark in this repository and not the target;\n- its `proposal/N` runs (the re-check after the target moved).\n\nEach job says `moot: proposal #N landed`. Runs already going finish; other bookmarks' runs are untouched. Called from every landing path: `land_as` (web, API, auto-land), `settle_after_push` (a push that holds the work), and the page finding it landed by another route.\n\nTests: `landing_cancels_the_proposals_unstarted_runs` (queued source run and proposal run cancelled with the reason, a running one left, another bookmark's left). Gate green (fmt, clippy, 284 tests); proposals tests green on Postgres. No migration.",

  "author": "andymccall",

  "state": "landed",

  "target": "main",

  "source": {

   "kind": "bookmark",

   "bookmark": "cancel-landed-runs"

  },

  "changes": [

   {

    "hash": "2abea30809ddf37d992b1ab5743b0f2b0c7daa1ddef9ecc1bd93864948816602",

    "message": "Cancel a landed proposal's runs that have not started\n\nThey can no longer change anything, and they held the queue ahead of the\ntarget's own run (refs #263). On landing (web, API, auto-land, a push\nthat holds the work, or the page finding it landed by another route),\nflow::moot_after_landing cancels the proposal's queued runs: its source\nbookmark's push runs, when that bookmark is in this repository, and its\nproposal/N runs, each job saying \"moot: proposal #N landed\". Runs that\nhave started finish. Test landing_cancels_the_proposals_unstarted_runs.",

    "author": {

     "name": "Andy McCall",

     "email": "[email protected]",

     "key": "4cd9916c150f426895a390868c6999314e0ef4955d657f30d2805647c747fc65",

     "account": null,

     "note": "signed by a key not linked to any account; its owner links it under Settings \u2192 Keys (/settings/keys)"

    },

    "when_ms": 1792360184287,

    "deps": [

     "0b20f1ec4007b9c864a8cebcb8945898b88c391cc0c6d85f8f58aeb60f685b47",

     "2a8b621676b42cbc143f985eb3226e83d515504dda995db118836ab6beb672f6"

    ],

    "head": false,

    "signature": {

     "status": "unsigned"

    }

   }

  ],

  "projected_heads": [

   "021f36a627f32602d06536c414c44f9c7448e2424a05286b46da4804baa53591",

   "0cd118748131b9e7e98a2c9b7b50df8ebcbda337097e6b2d61110408cc4d9b33",

   "19355e2283aba765a8a52394216f332db76663c2c0f5c31719803c2a72ad2b55",

   "1966661b1880eb65b7662730b9e609f06d0cbe16dddba1e9a8be8599f5296079",

   "19c71c828f86cc7dbcdd8d0c8d34d9f470b90a45d4bc384686498305b0f6b33e",

   "1b770a1fecf00ba25f4dec05fffd399e8805234618e48ded335d64c955bb5374",

   "1d9702887eee79babadd1a7aa8314ef4500def25217c5137a4ee5587f8be3db0",

   "1e23d0105921f536b1cf0483972849e0255efeb89b7f53656e36d2a8839ca14d",

   "20c36ed92b6b052a02ef585998dc7e42b857a014d92920c913f3507ba345a620",

   "260c33b4b6c4d8d23000b3d146fed71ec748a95dc6fc058119ed2a7c1627d31f",

   "2bbdc0268c23bb07c0fd0ea8922eb70e8bfa18da6bb303ec4a59e7ab5dae7fe2",

   "2d58f17e728b4125bbd7b5d2be9c692536e336f53bd3b34dc56f0361b38b50df",

   "317d776c725b16fe9ed5fd849f2fcb21afdd53bdce4d1c1eca038fc90f44e426",

   "32cfb089f5e6a8eede757776fa39cf1fe98594bda3c89cfc867f07d768d7b510",

   "3a01077da29aabb3ce6154e495f4d2064756cdef5094f011eb0da88e1fe60687",

   "3e5cd2eba62654482a1214b1c387ffce03fa802047622660d17878689e42007f",

   "439ecd8708a13ffd255537fab186ab2b3f49ef9f6a8684d55b0b294d434d6ab7",

   "4745b9844987f696f39f21d7036d00f92adec2b9a507e740fdb7bd28f5fd1d72",

   "5436f0dd942938b88d95fa7451994bfec9477a11cea9c9d15df6854bd9f5a828",

   "56a786aa42f1e2a8c6da70e1acbc76edc81a8c746294d06d9c1be6fa6725e2bf",

   "6978fd76a0666e56bc28171db3f8add9e346ebe90497646c92b8ab10c99a28dc",

   "6ff755541a622b944b170f3a83dfb95ecf972a4387dd77ff481a34df28e05e82",

   "72cde3da4176aff69eecc9cc4a625aa277dc22cd4cd5728ab1e18d0646135100",

   "73beb84b202a8785d9caf0bb65e04c2feb6ae60cea0d5779133cba332a033cb8",

   "76f93eaefe451cb3fe2daefccf8fd5b8c3bbb071a030a6876459bcde7ac54664",

   "92cea629fdf6614fe819c850b117a530402d079bc5dfc690ddacb0fe044fd336",

   "967ef74f6fd9847b2d48a7a20b27bade903fe122f34d4eab7e48efb5242a0020",

   "9991530b4beee381b95233964971965ad66ac833968f4c8f1fdbf4f1c2fb1713",

   "9aee52d392a67323824e269c3f0ffdf4c0e066e2bba44bd4d9204368f3a034a1",

   "9bc6b4720fc12185874a9710b310ddb36d2625cd86d653d23783b960915ef19d",

   "a0dd06b0094eb52d4347f6bde0572de667a0d2cbac5878d9e6928ec3bba09947",

   "a2b29af1ce88b4649df2c55022862b05a3c1079a0a325a5bd4ab6764b473cbd5",

   "a2ef53c5db269fa8bc86bb8abb13bb10ccba916129a301ca8738cb4829ff6680",

   "a7c05940ebc4ba5c73eb14afcc7579680e1cdb53995e464db10d617e055c5d57",

   "ad01845c4bf86859c3072a48277436580de78bbfe6ea6bc85de9b350522bf92b",

   "ae138eea7a71055eed1bdb63b016828e6bbe2de7ff2b8b06a741ebeaa759e950",

   "bd630386001ed3d0fc0d03c01548c193a2297f90b6fedb00b5883259f9ca1ad0",

   "bd91edeb44f8f318af68521ca74c35ee48f09e1002ce0c5972bc8ac10cea6862",

   "c21ef37dd4a0641cafb7fe4cf430093934e416d10b582d4183d9c30f722f42e5",

   "c2732e07323b52f2491200ad8989352bc6fc6834c4d97a21e550b3abbe0acafb",

   "c33dbd9a0d38f03313995c1259c16adbd34571f06efe1a71438b51783f1d7b36",

   "cefb0ea24511445166d0db129929255276092d452c7832e877235b49fcdc5881",

   "d2077a57b1f9a114ebdee7cf9e95e81f8932ebc82b59b4b126664a6b1941260b",

   "d2c1d6a7d12edeaca968546dc2fde25068f3de0afaee844ff11d5afd514e43eb",

   "d336629ffa906b6783adf44337015e3c3d9d4437a6a4f97734367f903674db51",

   "d4a0043fded4b0533c2f0377373bce57e38279a2b3935cdc62be08123505630b",

   "d94449e42718409b41ab98335c6641b2b4429332e8a1cab535e76467509986b4",

   "d9b3b84605a4f30f778d73011e379e8178f33d8d2c6d3d6704c7f5f7e108d5f7",

   "db72849cd22e82e6160e21528548f9766cf4b10867415ce1b2fe177bfa05e71f",

   "dc71378db1dc95169f80a85c58c80bc86dbd44546a90607b3a49297ec2e1843e",

   "df68c58de9471dd2f1eada82669cb2adee804c70fd2507876790c00f10edf73f",

   "e1078e99c5604bb12c431c02dacb6fba8ea2a0515abe39b3accedd23c78af9ac",

   "e15409084ed6de68f460f830d74c15458dcee9ab20a6c8dd39145d04a895d54e",

   "edcef27575a73e6acece529d1c0d3bb9f3509123de1a2c049ef4c0dd28b38bba",

   "efb51b39db1c38e7b881f05a1ce1c46d09dc3317349df6ebfd24a2c6d12279db",

   "f0f6c2d96b1cbdde9c994fe79244bfc4237f3392fc53c71abc5537085c745353",

   "f157bcea0e329a44ac78d59b88fb11028b05d17aa820106d94ba128d777df124",

   "f59e9680d880b1abc8c0b3ac7efb316c71d0001936e45fae4decc1f4a9829f47"

  ],

  "projected_state": "260f02ef1913677e77b72d5b40cbaf6b02def0d2b2bf8aca064e2e19b075c3e9",

  "conflicted": false,

  "approvals": [],

  "landable": false,

  "blockers": [],

  "created_ms": 1792360202344,

  "updated_ms": 1792400658285,

  "url": "https://oxygenhub.io/andymccall/oxygenhub/proposal/264",

  "repository_url": "https://oxygenhub.io/andymccall/oxygenhub",

  "source_url": null,

  "landed": {

   "by": "andymccall",

   "via": "web",

   "when_ms": 1792400658285

  },

  "auto_land": null,

  "requested_reviewers": [],

  "labels": [

   {

    "name": "performance",

    "colour": "#b48cff",

    "description": "Faster or lighter"

   }

  ]

 }

]

- **Land proposals from the phone (#17):** a repository has Issues and Proposals tabs; proposals open (with drafts), landed, closed or all, each saying whether it is ready to land, what stands in the way, or that it will land when its checks pass. A proposal shows the landing card (Land into the target, after a confirmation; land when its checks pass, on or off; the hub's blockers in its own words, and its reason when it refuses), then its checks (failures first, each opening its run), sealed approvals and asked reviewers, its changes and description. Landing needs `repo:write`, which sign-in now asks for: a phone signed in before this reads only, and says so with a button to sign in again rather than failing.

* 🔀 **Proposals:** a repository's proposals beside its issues; a proposal's

  checks, approvals, changes and what stands in the way, and **Land** (or

  land when its checks pass) from the phone (#17).