Diffusion: an upstream without checks is amber, not green 9aaa88b2d9c8

    Already { from: Vec<ChangeHash>, to: Vec<ChangeHash> },

            return Ok(Bumped::Already { from: old, to: new_heads });

/// Why a bump was made, which its proposal says.

#[derive(Clone, Copy, Debug, PartialEq, Eq)]

pub enum Why {

    /// The upstream's state passed its checks.

    Green,

    /// The upstream moved (the consumer follows every move).

    Moved,

    /// The upstream has no checks at all: nothing vouched for it, so the

    /// proposal is marked amber, `upstream unverified`.

    Unverified,

}

/// Open the bump proposal for `path`'s bump bookmark, or bring the open

/// one up to date: into `target`, by the `diffusion` account, labelled

/// `dependencies` (and `upstream unverified` while that is so), its body

/// the changelog from the pin `from` to `to`. Its number.

    (from, to): (Vec<ChangeHash>, Vec<ChangeHash>),

    why: Why,

    let when = match why {

        Why::Green => "at its newest state whose checks passed",

        Why::Moved => "as it is now",

        Why::Unverified => "as it is now",

    };

    let amber = if why == Why::Unverified {

        format!("\n\n> **Upstream unverified.** {slug} has no checks of its own, so nothing has tested this state of it. Only this repository's pipeline tests the move; a later bump from a passing run of {slug} clears this.")

    } else {

        String::new()

    };

        "Moves the subrepo `{path}` to [{slug}](/{slug})'s `{ub}`, {when} (`{}`). Only the pin changes; this repository's own checks test it.{amber}\n\n**What it brings** ({count}):\n\n{}\n\nOpened and kept up to date by Diffusion (docs/diffusion.md). It never lands by itself.",

    let (number, id) = match open {

            if p.title != title || p.body != body {

                pdb::edit(&app.db, p.id, &title, &body, target).await.ok()?;

                pdb::add_event(&app.db, p.id, ACCOUNT, "updated", &short.join("+")).await.ok();

            }

            (p.number, p.id)

            (p.number, p.id)

    // Amber while the upstream has no checks; cleared by a green bump.

    let unverified = db::issues::label_by_name(&app.db, consumer.id, "upstream unverified").await.ok().flatten();

    match (why == Why::Unverified, unverified) {

        (true, l) => {

            let l = match l {

                Some(l) => Some(l),

                None => db::issues::upsert_label(

                    &app.db,

                    consumer.id,

                    "upstream unverified",

                    "#e3a008",

                    "The upstream has no checks (Diffusion)",

                )

                .await

                .ok(),

            };

            if let Some(l) = l {

                db::issues::set_proposal_label(&app.db, id, l.id, true).await.ok();

            }

        }

        (false, Some(l)) => {

            db::issues::set_proposal_label(&app.db, id, l.id, false).await.ok();

        }

        (false, None) => {}

    }

    let unverified = unverified(app, upstream).await;

        // An upstream with no checks never turns green: its moves count

        // for green followers too, marked amber (unverified).

            Follow::Green => green || unverified,

        let why = if green {

            Why::Green

        } else if unverified {

            Why::Unverified

        } else {

            Why::Moved

        };

                let n = propose(app, &consumer, &target, &path, upstream, (from, heads.clone()), why).await;

            }

            Ok(Bumped::Already { from, to }) => {

                // Already moved: its proposal's text and labels are brought

                // up to date all the same.

                propose(app, &consumer, &target, &path, upstream, (from, to), why).await;

}

/// Whether `upstream` has no checks of its own: Flow is off for it, or

/// its default bookmark has never had a run. Its moves are then

/// "unverified" (amber), never green.

pub async fn unverified(app: &Shared, upstream: &RepoRow) -> bool {

    if !crate::flow::enabled(app, upstream) {

        return true;

    }

    let runs: i64 = sqlx::query_scalar("SELECT COUNT(*) FROM flow_runs WHERE repo_id = ? AND bookmark = ?")

        .bind(upstream.id)

        .bind(&upstream.default_bookmark)

        .fetch_one(&app.db)

        .await

        .unwrap_or(0);

    runs == 0

    assert!(matches!(

        oxygenhub::diffusion::Bumped::Already { .. }

    ));

}

/// An upstream with no checks never turns green: a consumer following green

/// still gets its bumps, marked amber, `upstream unverified` (#148).

#[tokio::test(flavor = "multi_thread")]

async fn bumps_from_an_upstream_without_checks_are_marked_unverified() {

    let h = hub().await;

    db::accounts::create_account(&h.app.db, "andy", "[email protected]", "x", "salt", true).await.unwrap();

    create(&h.app, "andy", "lib").await;

    create(&h.app, "andy", "app").await;

    let lib_work = tempfile::tempdir().unwrap();

    let lib = client(&format!("{}/andy/lib", h.base), lib_work.path());

    write(lib_work.path(), "lib.h", "v1\n");

    lib.snapshot("t").unwrap();

    lib.commit("lib v1", &[]).unwrap();

    assert!(lib.push("origin", false).unwrap().iter().all(|r| r.ok));

    let app_work = tempfile::tempdir().unwrap();

    let app = client(&format!("{}/andy/app", h.base), app_work.path());

    app.submodule_add(&format!("{}/andy/lib", h.base), "deps/lib", Some("main")).unwrap();

    app.snapshot("t").unwrap();

    app.commit("app on lib", &[]).unwrap();

    assert!(app.push("origin", false).unwrap().iter().all(|r| r.ok));

    let app_row = db::repos::get(&h.app.db, "andy", "app").await.unwrap().unwrap();

    for _ in 0..100 {

        if sqlx::query_scalar::<_, i64>("SELECT COUNT(*) FROM diffusion_pins WHERE consumer_id = ?")

            .bind(app_row.id)

            .fetch_one(&h.app.db)

            .await

            .unwrap()

            > 0

        {

            break;

        }

        tokio::time::sleep(std::time::Duration::from_millis(30)).await;

    }

    let (st, _) = call(&h.app, "PUT", "/api/v1/repos/andy/app/diffusion", Some("site"), Some(r#"{"follow":"green"}"#.into())).await;

    assert_eq!(st, StatusCode::OK);

    write(lib_work.path(), "lib.c", "v2\n");

    lib.snapshot("t").unwrap();

    lib.commit("lib v2", &[]).unwrap();

    assert!(lib.push("origin", false).unwrap().iter().all(|r| r.ok));

    let mut found = None;

    for _ in 0..100 {

        if let Some(p) = db::proposals::list(&h.app.db, app_row.id, &["open"]).await.unwrap().into_iter().next() {

            found = Some(p);

            break;

        }

        tokio::time::sleep(std::time::Duration::from_millis(50)).await;

    }

    let p = found.expect("a bump although the upstream never goes green");

    assert!(p.body.contains("Upstream unverified"), "{}", p.body);

    let mut labels = Vec::new();

    for _ in 0..100 {

        labels = db::issues::proposal_labels(&h.app.db, p.id).await.unwrap().into_iter().map(|l| l.name).collect::<Vec<String>>();

        if labels.len() == 2 {

            break;

        }

        tokio::time::sleep(std::time::Duration::from_millis(30)).await;

    }

    assert!(labels.contains(&"upstream unverified".to_string()) && labels.contains(&"dependencies".to_string()), "{labels:?}");

follows every move. An upstream with no checks at all is **unverified**

(amber): it never turns green, so its moves bump green followers too, and

the proposal is labelled `upstream unverified` with a note saying only the

consumer's pipeline tested it (decided by Andy, 2026-10-13). A passing run

of the upstream later clears it. `auto` lands a green bump itself when the consumer's

- **Architecture** (OxygenFlow spec §11.2–§11.3, oxygenflow#36): a runner reports each image's architecture on its claims (`image_archs`), kept in `flow_images`; a job is offered only to a runner whose architecture matches its sandbox's `arch`, else its image's as known; unknown matches, as before. The queue says which architecture a waiting job asks for. **Images by hash** (oxygenflow#39, Jetstream): `flow rootfs push HASH` sends a rootfs image as the FastCDC chunks the hub lacks (`POST /flow/images/missing`, `PUT /flow/images/chunks/{hash}`, by a token that may write repositories) and then its manifest (`PUT /flow/images/{hash}`), which the hub accepts only when every chunk is held and they make an image with that hash; chunks are kept zstd-compressed under `<data>/images`, shared by every image, and `jet_images` lists what is held. Runners and accounts fetch with `GET /flow/images/{hash}` and `GET /flow/images/chunks/{hash}`. A runner whose claims say `fetches_images` is offered jobs whose image only the hub holds, and fetches it before its preflight. Each claim also carries the runner's `facts` (OxygenFlow spec §11.1, oxygenflow#40): free disk, load, speed score and class, kernel; the hub keeps the latest on the runner, shows them on Admin › Runners and in `GET /runners`. A job's finish carries the most disk and memory it took (`peak_disk_mib`, `peak_memory_mib`, oxygenflow#41); a new job's `need_disk_mib` is the most its last five runs of the same repository and name took, plus a quarter and 64 MiB, and it is offered only to a runner whose claim reports at least that much free disk; the waiting reason says so. **Ranking** (oxygenflow#42): a job that another free runner which polled in the last 10 s would do better (it holds the job's image while the claimant would fetch it, or has a higher speed class) is held from the claimant for up to 15 s, then any runner that fits takes it; each job records why it ran where it did (`placed`: "holds the image, idle, speed 100 (class 3)", with "after N s held for a better runner" when it was), shown on the run page, in the API and by `oh run view`. A run whose jobs pin an image held by neither the hub nor a runner sets a failing `pipeline/images` check on its state (#137), naming the images and how to send them (`flow rootfs push`), so a proposal pinning a new image shows it before it lands; a later run of the state turns it to passed once every image is held. A placement pass every 15 seconds works out why each ready queued job no runner can take waits, from what each online runner offered at its last claim (scope, tier, architecture, image held, labels, memory and CPUs, a recent decline), and shows it on the job (API `waiting`, `oh run view` and `oh run watch`, its panel open on the run page) and in its check's summary, so a proposal says why its check is stuck (#28). **Diffusion** (#148, `docs/diffusion.md`): a push that moves a repository's default bookmark, or the bookmark its work lands on (the most common target of its proposals landed in the last 90 days), records each Oxygen subrepo pin in the new state (`diffusion_pins`: consumer, bookmark, path, the upstream's Oxygen repository id, the pinned heads); a hub that had no index fills it at start. `GET /repos/{owner}/{name}/consumers` lists the consumers the caller may read, each with its pin and how many changes of this repository's default bookmark it lacks (`behind`, null when the pin names changes this repository does not hold), and the overview shows them as Used by. A consumer follows a subrepo's upstream as its `.oxymodules` entry says (`follow = off | green | any`, `land = propose | auto`, `target` naming the bookmark to bump, `watch` listing paths whose upstream changes are flagged), else as its repository setting says (Settings › Diffusion, or `PUT /repos/{owner}/{name}/diffusion {"follow": ...}` by its owners and admins; migration 0058), else as `[diffusion] follow` in hub.toml says (default `off`). A **bump** moves a consumer's pin at a path to a newer upstream state: one change on the target bookmark's heads that replaces only the pin (oxy-core `build_pin_change`), signed with the hub's key, on the bookmark `diffusion/<path>`, which the hub owns and rebuilds on the target each time (a forced update). When the pin has changes the upstream's state lacks (say, from an upstream proposal not landed yet), the bump moves to both, so a consumer never loses changes it relies on; it is skipped when that combination would conflict, when the pin names changes the upstream does not hold, when the pin already holds the state, or when the bump bookmark already moves it there, and the hub logs why. A bump is **proposed** once per bump bookmark, by the hub's `diffusion` account (made on first use, never able to sign in), into the target, labelled `dependencies`, its body the upstream changes the pin lacks (newest first, linking to the upstream's change pages); a later bump edits the same open proposal. It is triggered when a push moves the upstream's default bookmark (for consumers following `any`) or when a run of that bookmark passes (for `green`). Diffusion never lands a proposal. An upstream with no checks of its own (Flow off, or no run ever of its default bookmark) is **unverified**: it never turns green, so its moves also bump consumers following `green`, and those proposals are marked amber with the `upstream unverified` label and a note in the body; a later bump from a passing run removes the label. A bump already in place refreshes its proposal's text and labels. Turning Diffusion on for a consumer (the setting or the API) catches it up at once: it is bumped to each upstream's newest state whose default-bookmark run passed, or to its newest state when it follows every move. **Images page** (#146): Admin › Runners › Images lists every rootfs image a runner holds, the hub keeps, or a job ran on in the last 90 days (from each job's sandbox), newest use first: its size and architecture, where it is (the hub, each runner holding it, each runner fetching it from the swarm now), the repositories whose jobs used it, and who sent it; an image held nowhere is marked. **The swarm** (#144, oxygenflow docs/jetstream.md §8.1): a runner in an image swarm reports its peer address, its site and the BLAKE3 of its TLS certificate with each claim (`swarm`; without a certificate it is not in the swarm), kept in memory and shown on Admin › Runners. `POST /flow/swarm/announce {image, state}` (by a runner; `fetching`, `done` or `stopped`) returns the online runners in its site that hold the image or announced fetching it in the last 45 seconds, each with its certificate's fingerprint, which the fetcher pins its TLS connection to, and a ticket signed with the hub key (JSON naming the runner, its site and an expiry 15 minutes on, hex, then the signature) that peers check against `/.well-known/oxyhub-key` before serving chunks; a runner that has not reported an address is told to add `[runner.swarm]` (409).