Flow: a failing job's receipt may leave kept artifacts out d29070faef66

            // A passing job's receipt names exactly the artifacts uploaded,

            // in name order; a failing one's names none, though it may have

            // kept `when "always"` artifacts (oxygenflow#37).

            let kept: Vec<String> =

                if r.exit_code == 0 { fdb::artifacts(&app.db, job.id).await?.into_iter().map(|a| a.blob).collect() } else { vec![] };

/// oxygenflow#37: a failing job keeps a `when "always"` artifact; its

/// receipt names none, and the run page says the file is outside it.

#[tokio::test(flavor = "multi_thread")]

async fn a_failing_job_keeps_an_artifact_outside_its_receipt() {

    let h = hub().await;

    create(&h.app, "andy", "demo").await;

    let url = format!("{}/andy/demo", h.base);

    let work = tempfile::tempdir().unwrap();

    let c = client(&url, work.path());

    write(

        work.path(),

        ".flow/pipeline.kdl",

        &format!(

            "schema-version 1\nsandbox \"alpine\" {{\n    rootfs \"cas://blob/{ROOTFS}\"\n}}\njob \"test\" {{\n    sandbox \"alpine\"\n    exec \"make\" \"test\"\n    output {{\n        artifact \"junit\" {{\n            path \"/src/out/junit.xml\"\n        }}\n    }}\n}}\n"

        ),

    );

    c.snapshot("test").unwrap();

    c.commit("Test", &[]).unwrap();

    assert!(c.push("origin", false).unwrap().iter().all(|r| r.ok));

    let run = runs_of(&h.app, "andy", "demo").await.remove(0);

    let a = claim(&h.app).await.unwrap();

    let id = a["job_id"].as_i64().unwrap();

    let (st, text) = upload(&h.app, id, "junit", b"<testsuites/>").await;

    assert_eq!(st, StatusCode::OK, "{text}");

    let blob = serde_json::from_str::<serde_json::Value>(&text).unwrap()["blob"].as_str().unwrap().to_string();

    let mut r = receipt("test", a["pipeline_hash"].as_str().unwrap(), 1);

    r["outputs"] = serde_json::json!([blob]);

    assert_eq!(

        finish(&h.app, id, serde_json::json!({ "exit_code": 1, "duration_ms": 700, "receipt": r.clone() })).await,

        StatusCode::BAD_REQUEST,

        "a failing receipt names no outputs"

    );

    r["outputs"] = serde_json::json!([]);

    assert_eq!(finish(&h.app, id, serde_json::json!({ "exit_code": 1, "duration_ms": 700, "receipt": r })).await, StatusCode::NO_CONTENT);

    let (_, page) = call(&h.app, "GET", &format!("/andy/demo/flow/{}", run.number), None, None).await;

    assert!(page.contains(&format!("/andy/demo/flow/{}/artifacts/test/junit", run.number)), "listed");

    assert!(page.contains("not in its receipt"), "marked");

}