Landed and closed proposals are listed as recorded, not projected again; the list takes a limit (closes #331) d7e2c2754807

## Unreleased

- **The API refuses a field an edit does not take (#330).** `PATCH` on an issue, proposal, project, milestone, release or drop answered 200 to a field it does not know and changed nothing (`{"ready": true}` on a draft proposal, say), which looked like success. It now answers 422 naming the field and the ones it takes.

- **Mail reads `[OxygenHub]`, in a wider message (#334).** A notification's subject was tagged with the site's name (`[Oxygenhub on Earth]`); mail now goes by the From address's display name (`OxygenHub <noreply@…>`) in the subject and the footer, falling back to the site's name, so the site keeps its own name (which its apt repository is labelled with). The message card is 720px wide rather than 560.

- **An agent follows its owner's newest identity (oxygen#82).** A keyless certificate's answer now carries `author_chain`: the grant owner's newest linked identity and its predecessors back to the grant's key, so an agent home with `author.for` authors as the owner's current identity, not one several rotations old.

// --------------------------------------------------------------- proposals

async fn proposals(

    State(app): State<Shared>,

    headers: HeaderMap,

    Path((owner, name)): Path<(String, String)>,

) -> Result<Json<Vec<Proposal>>, ApiError> {

    let c = caller(&app, &headers).await?;

    let (repo, row, _) = reach(&app, &c, &owner, &name, Access::Read).await?;

    // Each proposal's projected state is worked out from the store, which

    // for a bucket-backed repository is many slow round trips: four at a

    // time, in order, each under the repository's read lock only. One at

    use futures::StreamExt;

    let out: Vec<Result<Proposal, ApiError>> = futures::stream::iter(rows)

        .map(|p| {

            let (app, repo, owner, name, id) = (app.clone(), repo.clone(), owner.clone(), name.clone(), row.id);

            async move {

                let v = crate::web::proposals::verdict(&app, &loaded, id).await?;

                Ok(crate::web::proposals::to_api(&app, &owner, &name, &loaded, &v, None).await)

            }

        Some(id) => db::repos::get_by_id(&app.db, id).await?.map(|r| format!("{}/{}", app.config.base_url(), r.slug())),

        None => None,

    };

    let v = crate::web::proposals::verdict(&app, &loaded, row.id).await?;

    Ok(Json(crate::web::proposals::to_api(&app, &owner, &name, &loaded, &v, source_url).await))

}

        Some(id) => db::repos::get_by_id(&app.db, id).await?.map(|r| format!("{}/{}", app.config.base_url(), r.slug())),

        None => None,

    };

    let v = crate::web::proposals::verdict(&app, &loaded, row.id).await?;

    Ok(Json(crate::web::proposals::to_api(&app, &owner, &name, &loaded, &v, source_url).await))

}

#[derive(Deserialize)]

struct IssuesQuery {

    state: Option<String>,

}

async fn issues(

    load_with(app, repo, row, false).await

}

async fn load_with(app: &Shared, repo: &RepoName, row: pdb::ProposalRow, render: bool) -> Result<Loaded, crate::repos::RepoError> {

    let fork_dir = match (row.source_kind.as_str(), row.source_repo_id) {

        ("fork", Some(id)) => {

    assert_eq!(v["blockers"], serde_json::json!([]), "{}", api.body);

    assert_eq!(v["landed"]["by"], "andy");

    assert_eq!(v["landed"]["via"], "web");

    let page = get(app, "/andy/demo/proposal/1", Some(&andy)).await;

    assert!(page.body.contains("by <a href=\"/andy\">andy</a>, web"), "{}", page.body);

    // oxygenhub#86: a landed card offering to delete the source bookmark,

#[derive(Subcommand)]

enum ProposalCmd {

    List {

        #[arg(long, default_value = "open")]

        state: String,

    },

    /// One proposal: its changes, approvals and whether it can land

    View { number: i64 },

fn proposal(c: &Client, t: &Target, cmd: ProposalCmd, json: bool) -> Result<i32> {

    let base = t.repo_path()?;

    match cmd {

            if json {

                println!("{}", c.get_text(&path)?);

                return Ok(0);

| `oh project list`, `oh project view N`, `oh project create TITLE [-d DESC] [--private]`, `oh project close\|reopen N` | The repository owner's project boards (`--owner NAME` for another's) |

| `oh project card add N REF [-c COLUMN]`, `oh project card add N --note TEXT`, `oh project card move N CARD -c COLUMN`, `oh project card move N --from COLUMN -c COLUMN [--except 12,#13,name#14,CARD] [--state closed,landed] [--dry-run]`, `oh project card remove N CARD` | Cards: REF is `12` or `#12` here, or `name#12` in another of the owner's repositories; a column by name or id; `--from` moves a whole column at once (#289) |

| `oh issue comment N -b BODY` | Comment |

| `oh proposal create -t TITLE --from BOOKMARK [--into BOOKMARK] [--draft]` | Propose a bookmark's changes |

| `oh proposal checks N` | Checks on the projected state |

| `oh proposal land N` | Land it on its target, as the page's Land button does |