OXYGENHUB

Coverage / crates/hub/src/web/projects.rs 88.9%

592 of 666 lines run, 81 of 184 functions · run #470 on main · run missed

1
//! Projects (hub spec §8.2): boards of issues, proposals and notes across
2
//! the repositories of one person or organisation.
3
4
use super::settings::csrf;
5
use super::{filters, Error, Page, Shell};
6
use crate::auth::{roles, Access, Viewer};
7
use crate::db::{self, issues as idb, projects as pdb};
8
use crate::Shared;
9
use askama::Template;
10
use axum::extract::{Form, Path, Query, State};
11
use axum::response::{IntoResponse, Redirect, Response};
12
use serde::Deserialize;
13
14
/// What a caller may do with an owner's projects.
15
pub struct Rights {
16
    /// Sees private projects.
17
    pub member: bool,
18
    /// Creates and changes projects.
19
    pub edit: bool,
20
}
21
22
/// Rights of `account` (anonymous when `None`) over `owner`'s projects;
23
/// `None` when there is no such person or organisation.
24236×
pub async fn rights_of(app: &Shared, account: Option<&db::accounts::Account>, owner: &str) -> sqlx::Result<Option<Rights>> {
25236×
    let admin = account.is_some_and(|a| a.is_admin);
26236×
    if let Some(a) = db::accounts::account_by_name(&app.db, owner).await? {
27231×
        let me = account.is_some_and(|v| v.id == a.id);
28231×
        return Ok(Some(Rights { member: me || admin, edit: me || admin }));
295×
    }
305×
    if let Some(o) = db::accounts::org_by_name(&app.db, owner).await? {
313×
        let member = match account {
323×
            Some(v) => db::accounts::org_role(&app.db, o.id, v.id).await?.is_some(),
330×
            None => false,
34
        };
353×
        return Ok(Some(Rights { member: member || admin, edit: member || admin }));
362×
    }
372×
    Ok(None)
38236×
}
39
4084×
async fn rights(app: &Shared, shell: &Shell, viewer: &Viewer, owner: &str) -> Result<Rights, Error> {
4184×
    rights_of(app, viewer.account(), owner)
4284×
        .await
4384×
        .map_err(|e| Error::from_db(shell.clone(), e))?
4484×
        .ok_or_else(|| Error::not_found(shell.clone()))
4584×
}
46
47
#[derive(Template)]
48
#[template(path = "projects.html")]
49
pub struct ProjectsPage {
50
    shell: Shell,
51
    owner: String,
52
    /// The projects shown: open or closed as `closed` says, matching `q`.
53
    projects: Vec<pdb::Project>,
54
    can_edit: bool,
55
    error: Option<String>,
56
    /// On your own page, the organisations you belong to: their boards
57
    /// are one click away, and where a board for one is made (#119).
58
    orgs: Vec<String>,
59
    /// The title filter, and whether the closed ones are shown (#124).
60
    q: String,
61
    closed: bool,
62
    open_count: usize,
63
    closed_count: usize,
64
}
65
66
impl ProjectsPage {
67
    /// The page for `all` the projects the viewer may see: counted open
68
    /// and closed among those matching `q`, then the ones asked for.
69
    #[allow(clippy::too_many_arguments)]
7011×
    fn build(
7111×
        shell: Shell,
7211×
        owner: String,
7311×
        all: Vec<pdb::Project>,
7411×
        can_edit: bool,
7511×
        error: Option<String>,
7611×
        orgs: Vec<String>,
7711×
        q: Option<String>,
7811×
        closed: bool,
7911×
    ) -> ProjectsPage {
8011×
        let q = q.unwrap_or_default().trim().to_string();
8111×
        let needle = q.to_lowercase();
8211×
        let matching: Vec<pdb::Project> = all
8311×
            .into_iter()
8411×
            .filter(|p| needle.is_empty() || p.title.to_lowercase().contains(&needle) || p.description.to_lowercase().contains(&needle))
8511×
            .collect();
8611×
        let closed_count = matching.iter().filter(|p| p.closed).count();
8711×
        let open_count = matching.len() - closed_count;
8811×
        let projects = matching.into_iter().filter(|p| p.closed == closed).collect();
8911×
        ProjectsPage { shell, owner, projects, can_edit, error, orgs, q, closed, open_count, closed_count }
9011×
    }
91
}
92
93
/// `?q=TEXT&state=open|closed` on the Projects page (#124).
94
#[derive(Deserialize, Default)]
95
pub struct ProjectsQuery {
96
    #[serde(default)]
97
    q: Option<String>,
98
    #[serde(default)]
99
    state: Option<String>,
100
}
101
102
/// The organisations the viewer belongs to, when `owner` is the viewer.
10311×
async fn own_orgs(app: &Shared, viewer: &Viewer, owner: &str) -> Vec<String> {
10411×
    match viewer.account() {
10510×
        Some(a) if a.username == owner => {
1069×
            crate::db::accounts::orgs_of(&app.db, a.id).await.map(|v| v.into_iter().map(|(o, _)| o.name).collect()).unwrap_or_default()
107
        }
1082×
        _ => vec![],
109
    }
11011×
}
111
11212×
pub async fn list(
11312×
    State(app): State<Shared>,
11412×
    viewer: Viewer,
11512×
    Path(owner): Path<String>,
11612×
    Query(query): Query<ProjectsQuery>,
11712×
) -> Result<Page<ProjectsPage>, Error> {
11812×
    let shell = Shell::new(&app, &format!("/projects/{owner}"), &viewer);
11912×
    let r = rights(&app, &shell, &viewer, &owner).await?;
12011×
    let projects = pdb::of_owner(&app.db, &owner)
12111×
        .await
12211×
        .map_err(|e| Error::from_db(shell.clone(), e))?
12311×
        .into_iter()
12411×
        .filter(|p| p.public || r.member)
12511×
        .collect();
12611×
    let orgs = own_orgs(&app, &viewer, &owner).await;
12711×
    let closed = query.state.as_deref() == Some("closed");
12811×
    Ok(Page(ProjectsPage::build(shell, owner, projects, r.edit, None, orgs, query.q, closed)))
12912×
}
130
131
#[derive(Deserialize)]
132
pub struct NewProjectForm {
133
    #[serde(rename = "_csrf")]
134
    csrf_token: String,
135
    title: String,
136
    #[serde(default)]
137
    description: String,
138
    #[serde(default)]
139
    private: Option<String>,
140
}
141
1426×
pub async fn create(
1436×
    State(app): State<Shared>,
1446×
    viewer: Viewer,
1456×
    Path(owner): Path<String>,
1466×
    Form(f): Form<NewProjectForm>,
1476×
) -> Result<Response, Error> {
1486×
    let shell = Shell::new(&app, &format!("/projects/{owner}"), &viewer);
1496×
    csrf(&viewer, &f.csrf_token, &shell)?;
1506×
    let r = rights(&app, &shell, &viewer, &owner).await?;
1516×
    if !r.edit {
1520×
        return Err(Error::not_found(shell));
1536×
    }
1546×
    let title = f.title.trim();
1556×
    if title.is_empty() || title.len() > 100 {
1560×
        let projects = pdb::of_owner(&app.db, &owner).await.map_err(|e| Error::from_db(shell.clone(), e))?;
1570×
        let orgs = own_orgs(&app, &viewer, &owner).await;
1580×
        return Ok(Page(ProjectsPage::build(
1590×
            shell,
1600×
            owner,
1610×
            projects,
1620×
            true,
1630×
            Some("A project needs a title of up to 100 characters.".into()),
1640×
            orgs,
1650×
            None,
1660×
            false,
1670×
        ))
1680×
        .into_response());
1696×
    }
1706×
    let p = pdb::create(&app.db, &owner, title, f.description.trim(), f.private.is_none())
1716×
        .await
1726×
        .map_err(|e| Error::from_db(shell.clone(), e))?;
1736×
    db::accounts::audit(&app.db, viewer.account(), "project.created", &format!("{owner}/{}", p.number), title).await.ok();
1746×
    Ok(Redirect::to(&format!("/projects/{owner}/{}", p.number)).into_response())
1756×
}
176
177
/// A card as the board shows it.
178
pub struct CardView {
179
    pub card: pdb::Card,
180
    /// `owner/name#N`, for issue and proposal cards.
181
    pub reference: String,
182
    pub url: String,
183
    pub title: String,
184
    /// `open`, `closed`, `landed`, `draft`… for issues and proposals.
185
    pub state: String,
186
    /// The issue's or proposal's labels, and an issue's assignees (#293).
187
    pub labels: Vec<idb::Label>,
188
    pub assignees: Vec<String>,
189
}
190
191
pub struct ColumnView {
192
    pub column: pdb::Column,
193
    pub cards: Vec<CardView>,
194
    /// Cards the page leaves out (#293): the oldest of a long column, or
195
    /// those a filter does not match; `total` is how many it holds.
196
    pub hidden: usize,
197
    pub total: usize,
198
    /// Its archived cards (#293), shown on the archive view.
199
    pub archived: usize,
200
    /// Its cards are all finished work (a Done column): its note says
201
    /// they are archived after a fortnight unless it says otherwise.
202
    pub finished: bool,
203
}
204
205
/// A column longer than this shows its newest cards only, with "show all"
206
/// (#293): a board's Done column otherwise grows without end.
207
pub const COLUMN_SHOWN: usize = 30;
208
209
/// How the board page shows its cards (#293).
210
#[derive(Deserialize, Default)]
211
pub struct BoardQuery {
212
    /// The column shown whole.
213
    #[serde(default)]
214
    all: Option<i64>,
215
    /// Only cards whose title or reference holds these words, and with
216
    /// `label:NAME`, `assignee:NAME` or `state:STATE` as the issue list takes.
217
    #[serde(default)]
218
    q: Option<String>,
219
    /// Only cards in this state (`open`, `closed`, `landed`…).
220
    #[serde(default)]
221
    state: Option<String>,
222
    /// The archived cards instead (`?archived=1`).
223
    #[serde(default)]
224
    archived: Option<String>,
225
}
226
227
impl BoardQuery {
22874×
    fn text(&self) -> String {
22974×
        self.q.as_deref().map(str::trim).unwrap_or("").to_string()
23074×
    }
23174×
    fn state(&self) -> String {
23274×
        self.state.as_deref().map(str::trim).unwrap_or("").to_ascii_lowercase()
23374×
    }
23438×
    fn archived(&self) -> bool {
23538×
        self.archived.as_deref().is_some_and(|a| !a.is_empty() && a != "0")
23638×
    }
237
}
238
239
/// The board filter's `label:`, `assignee:` and `state:` terms, and its words.
240
#[derive(Default)]
241
struct CardFilter {
242
    labels: Vec<String>,
243
    assignees: Vec<String>,
244
    state: String,
245
    words: Vec<String>,
246
}
247
248
impl CardFilter {
24937×
    fn of(view: &BoardQuery) -> CardFilter {
25037×
        let mut f = CardFilter { state: view.state(), ..Default::default() };
25137×
        for tok in view.text().split_whitespace() {
2529×
            match tok.split_once(':') {
2536×
                Some(("label", v)) if !v.is_empty() => f.labels.push(v.to_lowercase()),
2542×
                Some(("assignee", v)) if !v.is_empty() => f.assignees.push(v.trim_start_matches('@').to_lowercase()),
2551×
                Some(("state", v)) if !v.is_empty() => f.state = v.to_lowercase(),
2563×
                _ => f.words.push(tok.to_lowercase()),
257
            }
258
        }
25937×
        f
26037×
    }
261
262105×
    fn is_empty(&self) -> bool {
263105×
        self.labels.is_empty() && self.assignees.is_empty() && self.state.is_empty() && self.words.is_empty()
264105×
    }
265
266
    /// Every term holds: each word in the title or reference, each label
267
    /// and assignee among the card's, and its state.
26886×
    fn keeps(&self, c: &CardView) -> bool {
26986×
        let (title, reference) = (c.title.to_lowercase(), c.reference.to_lowercase());
27086×
        self.words.iter().all(|w| title.contains(w) || reference.contains(w))
27150×
            && self.labels.iter().all(|l| c.labels.iter().any(|x| x.name.eq_ignore_ascii_case(l)))
27247×
            && self.assignees.iter().all(|a| c.assignees.iter().any(|x| x.eq_ignore_ascii_case(a)))
27345×
            && (self.state.is_empty() || c.state.eq_ignore_ascii_case(&self.state))
27486×
    }
275
}
276
277
/// Filter and cut the columns as `view` says.
27837×
fn shape(columns: &mut [ColumnView], view: &BoardQuery) {
27937×
    let filter = CardFilter::of(view);
280105×
    for col in columns.iter_mut() {
281105×
        col.total = col.cards.len();
282105×
        if !filter.is_empty() {
28386×
            col.cards.retain(|c| filter.keeps(c));
28481×
        } else if col.cards.len() > COLUMN_SHOWN && view.all != Some(col.column.id) && !view.archived() {
2851×
            // Cards join a column at its end: the newest are the last.
2861×
            let cut = col.cards.len() - COLUMN_SHOWN;
2871×
            col.cards.drain(..cut);
28880×
        }
289105×
        col.hidden = col.total - col.cards.len();
290
    }
29137×
}
292
293
#[derive(Template)]
294
#[template(path = "project.html")]
295
pub struct BoardPage {
296
    shell: Shell,
297
    project: pdb::Project,
298
    columns: Vec<ColumnView>,
299
    /// The owner's repositories the viewer can read, for adding cards.
300
    repos: Vec<String>,
301
    /// Changes cards and columns (an open project).
302
    can_edit: bool,
303
    /// Changes the settings (to reopen a closed project too).
304
    can_manage: bool,
305
    notice: Option<String>,
306
    error: Option<String>,
307
    /// Owners the viewer may move the project to (#125): themselves and the
308
    /// organisations they belong to, but not its owner now.
309
    transfer_to: Vec<String>,
310
    /// The filter the page shows (#293), and whether one is set.
311
    q: String,
312
    state: String,
313
    filtered: bool,
314
    /// The archive view: archived cards, each restorable (#293).
315
    archived: bool,
316
    /// Archived cards on the whole board.
317
    archived_total: usize,
318
}
319
320
#[allow(clippy::too_many_arguments)]
32139×
async fn board(
32239×
    app: &Shared,
32339×
    shell: Shell,
32439×
    viewer: &Viewer,
32539×
    owner: &str,
32639×
    number: i64,
32739×
    notice: Option<String>,
32839×
    error: Option<String>,
32939×
    view: &BoardQuery,
33039×
) -> Result<Page<BoardPage>, Error> {
33139×
    let e = |e| Error::from_db(shell.clone(), e);
33239×
    let r = rights(app, &shell, viewer, owner).await?;
33339×
    let project = pdb::get(&app.db, owner, number)
33439×
        .await
33539×
        .map_err(e)?
33639×
        .filter(|p| p.public || r.member)
33739×
        .ok_or_else(|| Error::not_found(shell.clone()))?;
33837×
    let archived = view.archived();
33937×
    let (mut columns, repos) = board_columns(app, viewer.account(), owner, &project, archived).await.map_err(e)?;
34037×
    shape(&mut columns, view);
34137×
    let archived_total = columns.iter().map(|c| c.archived).sum();
34237×
    let can_edit = r.edit && !project.closed;
34337×
    let mut transfer_to = Vec::new();
34437×
    if let (true, Some(a)) = (r.edit, viewer.account()) {
34536×
        transfer_to.push(a.username.clone());
34636×
        let orgs = db::accounts::orgs_of(&app.db, a.id).await.map_err(e)?;
34736×
        transfer_to.extend(orgs.into_iter().map(|(o, _)| o.name));
34840×
        transfer_to.retain(|o| o != owner);
3491×
    }
35037×
    let (q, state) = (view.text(), view.state());
35137×
    let filtered = !q.is_empty() || !state.is_empty();
35237×
    Ok(Page(BoardPage {
35337×
        shell,
35437×
        project,
35537×
        columns,
35637×
        repos,
35737×
        can_edit,
35837×
        can_manage: r.edit,
35937×
        notice,
36037×
        error,
36137×
        transfer_to,
36237×
        q,
36337×
        state,
36437×
        filtered,
36537×
        archived,
36637×
        archived_total,
36737×
    }))
36839×
}
369
370
/// A project's columns with the cards `account` may see, and the owner's
371
/// repositories it can read (for adding cards). `archived`: the archived
372
/// cards instead of those on the board (#293); each column counts its
373
/// archived cards either way.
37458×
pub async fn board_columns(
37558×
    app: &Shared,
37658×
    account: Option<&db::accounts::Account>,
37758×
    owner: &str,
37858×
    project: &pdb::Project,
37958×
    archived: bool,
38058×
) -> sqlx::Result<(Vec<ColumnView>, Vec<String>)> {
38158×
    let mut readable: std::collections::HashMap<i64, db::repos::RepoRow> = Default::default();
38264×
    for row in db::repos::list_by_owner(&app.db, owner).await? {
38364×
        let role = roles::role_for(&app.db, account, &row).await?;
38464×
        if roles::allows(role, Access::Read) {
38556×
            readable.insert(row.id, row);
38656×
        }
387
    }
38858×
    let all = pdb::cards(&app.db, project.id).await?;
389897×
    let archived_in = |column: i64| all.iter().filter(|c| c.column_id == column && c.archived_ms.is_some()).count();
390305×
    let cards: Vec<&pdb::Card> = all.iter().filter(|c| c.archived_ms.is_some() == archived).collect();
391
    // What the cards show, read once per repository, not per card: a
392
    // board of 300 cards made 300 queries.
39358×
    let mut shown: std::collections::HashMap<(i64, bool, i64), Shown> = Default::default();
39458×
    let mut repo_ids: Vec<(i64, bool)> =
395280×
        cards.iter().filter_map(|c| Some((c.repo_id?, c.kind == "issue"))).filter(|(rid, _)| readable.contains_key(rid)).collect();
39658×
    repo_ids.sort();
39758×
    repo_ids.dedup();
39858×
    for (rid, issues) in repo_ids {
39998×
        shown.extend(shown_in(app, rid, issues).await?.into_iter().map(|(n, s)| ((rid, issues, n), s)));
400
    }
40158×
    let mut columns = Vec::new();
402168×
    for column in pdb::columns(&app.db, project.id).await? {
403168×
        let mut views = Vec::new();
404822×
        for card in cards.iter().copied().filter(|c| c.column_id == column.id) {
405280×
            match (card.kind.as_str(), card.repo_id, card.number) {
406280×
                ("note", _, _) => views.push(CardView {
407202×
                    card: card.clone(),
408202×
                    reference: String::new(),
409202×
                    url: String::new(),
410202×
                    title: card.note.clone(),
411202×
                    state: String::new(),
412202×
                    labels: Vec::new(),
413202×
                    assignees: Vec::new(),
414202×
                }),
41578×
                (kind, Some(rid), Some(n)) => {
416
                    // Cards of repositories the viewer cannot read are not shown at all.
41778×
                    let Some(row) = readable.get(&rid) else { continue };
41877×
                    let Some(s) = shown.get(&(rid, kind == "issue", n)) else { continue };
41977×
                    let slug = format!("{}/{}", row.owner, row.name);
42077×
                    views.push(CardView {
42177×
                        card: card.clone(),
42277×
                        reference: format!("{slug}#{n}"),
42377×
                        url: format!("/{slug}/{kind}/{n}"),
42477×
                        title: s.title.clone(),
42577×
                        state: s.state.clone(),
42677×
                        labels: s.labels.clone(),
42777×
                        assignees: s.assignees.clone(),
42877×
                    });
429
                }
4300×
                _ => {}
431
            }
432
        }
433168×
        let total = views.len();
434168×
        let archived = archived_in(column.id);
435279×
        let items: Vec<&CardView> = views.iter().filter(|v| v.card.kind != "note").collect();
436168×
        let finished = !items.is_empty() && items.iter().all(|v| matches!(v.state.as_str(), "closed" | "landed"));
437168×
        columns.push(ColumnView { column, cards: views, hidden: 0, total, archived, finished });
438
    }
43958×
    let mut repos: Vec<String> = readable.values().map(|r| r.name.clone()).collect();
44058×
    repos.sort();
44158×
    Ok((columns, repos))
44258×
}
443
444
/// What a card shows of an issue or a proposal.
445
struct Shown {
446
    title: String,
447
    state: String,
448
    labels: Vec<idb::Label>,
449
    assignees: Vec<String>,
450
}
451
452
/// A repository's issues (or proposals) as cards show them, by number.
45356×
async fn shown_in(app: &Shared, repo_id: i64, issues: bool) -> sqlx::Result<Vec<(i64, Shown)>> {
454
    use std::collections::HashMap;
45556×
    let mut out = Vec::new();
45656×
    if issues {
45745×
        let mut labels: HashMap<i64, Vec<idb::Label>> = HashMap::new();
45845×
        for (id, l) in idb::labels_by_issue(&app.db, repo_id).await? {
45918×
            labels.entry(id).or_default().push(l);
46018×
        }
46145×
        let mut assignees: HashMap<i64, Vec<String>> = HashMap::new();
46245×
        for (id, u) in idb::assignees_by_issue(&app.db, repo_id).await? {
4636×
            assignees.entry(id).or_default().push(u);
4646×
        }
46587×
        for i in idb::list(&app.db, repo_id).await? {
46687×
            let mut a = assignees.remove(&i.id).unwrap_or_default();
46787×
            a.sort();
46887×
            let s = Shown { labels: labels.remove(&i.id).unwrap_or_default(), assignees: a, title: i.title, state: i.state };
46987×
            out.push((i.number, s));
47087×
        }
471
    } else {
47211×
        let mut labels: HashMap<i64, Vec<idb::Label>> = HashMap::new();
47311×
        for (id, l) in idb::labels_by_proposal(&app.db, repo_id).await? {
4740×
            labels.entry(id).or_default().push(l);
4750×
        }
47611×
        for p in db::proposals::list(&app.db, repo_id, &[]).await? {
47711×
            let s = Shown { labels: labels.remove(&p.id).unwrap_or_default(), assignees: Vec::new(), title: p.title, state: p.state };
47811×
            out.push((p.number, s));
47911×
        }
480
    }
48156×
    Ok(out)
48256×
}
483
48427×
pub async fn show(
48527×
    State(app): State<Shared>,
48627×
    viewer: Viewer,
48727×
    Path((owner, number)): Path<(String, i64)>,
48827×
    Query(view): Query<BoardQuery>,
48927×
) -> Result<Response, Error> {
49027×
    let shell = Shell::new(&app, &format!("/projects/{owner}/{number}"), &viewer);
491
    // A board transferred away (#125): its old address goes to its new one.
49227×
    let e = |e| Error::from_db(shell.clone(), e);
49327×
    if pdb::get(&app.db, &owner, number).await.map_err(e)?.is_none() {
4942×
        if let Some(p) = pdb::redirected(&app.db, &owner, number).await.map_err(e)? {
4951×
            return Ok(Redirect::permanent(&format!("/projects/{}/{}", p.owner, p.number)).into_response());
4961×
        }
49725×
    }
49826×
    Ok(board(&app, shell, &viewer, &owner, number, None, None, &view).await?.into_response())
49927×
}
500
501
#[derive(Deserialize)]
502
pub struct BoardForm {
503
    #[serde(rename = "_csrf")]
504
    csrf_token: String,
505
    action: String,
506
    #[serde(default)]
507
    card: Option<i64>,
508
    #[serde(default)]
509
    column: Option<i64>,
510
    #[serde(default)]
511
    name: String,
512
    /// `repo#12`, or `#12` with `repo`.
513
    #[serde(default)]
514
    reference: String,
515
    #[serde(default)]
516
    repo: String,
517
    #[serde(default)]
518
    note: String,
519
    /// Automatic archiving: `finished` (the default), `days` or `never`.
520
    #[serde(default)]
521
    mode: String,
522
    #[serde(default)]
523
    title: String,
524
    #[serde(default)]
525
    description: String,
526
    #[serde(default)]
527
    private: Option<String>,
528
    #[serde(default)]
529
    closed: Option<String>,
530
    /// The owner to transfer the project to (#125).
531
    #[serde(default)]
532
    to: String,
533
    /// Days, for archiving a column's older cards (#293); empty is never.
534
    #[serde(default)]
535
    days: String,
536
}
537
538
/// `repo#12` or `#12` (with a repository chosen) to (repository, number).
539
/// `repo#12`, `#12` with `repo`, or `owner/repo#12` when `owner` is the
540
/// board's (the form the board itself shows, oxygenhub#118). `Err` says
541
/// what is wrong.
54222×
fn parse_reference(reference: &str, repo: &str, owner: &str) -> Result<(String, i64), String> {
54322×
    let bad = || "Name an issue or proposal as repo#12, or write a note.".to_string();
54422×
    let r = reference.trim();
54522×
    let (name, n) = r.split_once('#').ok_or_else(bad)?;
54621×
    let name = if name.is_empty() { repo.trim() } else { name.trim() };
54721×
    let name = match name.split_once('/') {
5484×
        Some((o, rest)) if o.eq_ignore_ascii_case(owner) => rest,
5492×
        Some((o, _)) => return Err(format!("This board holds only {owner}'s issues and proposals, not {o}'s.")),
55017×
        None => name,
551
    };
55219×
    let n: i64 = n.trim().parse().map_err(|_| bad())?;
55319×
    if name.is_empty() || n <= 0 || name.contains('/') {
5542×
        return Err(bad());
55517×
    }
55617×
    Ok((name.to_string(), n))
55722×
}
558
559
/// Add a note, or the issue or proposal `reference` names (`repo#12`, or
560
/// `#12` with `repo`), to a column. `Ok(Err(why))` for what the caller
561
/// should be told: an unknown repository or number, or a card already there.
562
#[allow(clippy::too_many_arguments)]
56318×
pub async fn add_card(
56418×
    app: &Shared,
56518×
    account: Option<&db::accounts::Account>,
56618×
    owner: &str,
56718×
    project_id: i64,
56818×
    column_id: i64,
56918×
    reference: &str,
57018×
    repo: &str,
57118×
    note: &str,
57218×
    actor: &str,
57318×
) -> sqlx::Result<Result<pdb::Card, String>> {
57418×
    if !note.trim().is_empty() {
5754×
        let note: String = note.trim().chars().take(500).collect();
5764×
        pdb::add_card(
5774×
            &app.db,
5784×
            project_id,
5794×
            pdb::NewCard { column_id, kind: "note", repo_id: None, number: None, note: &note, added_by: actor },
5804×
        )
5814×
        .await?;
5824×
        return Ok(Ok(newest_card(app, project_id).await?));
58314×
    }
58414×
    let (repo, n) = match parse_reference(reference, repo, owner) {
58513×
        Ok(r) => r,
5861×
        Err(why) => return Ok(Err(why)),
587
    };
58813×
    let Some(row) = db::repos::get(&app.db, owner, &repo).await? else { return Ok(Err(format!("{owner} has no repository {repo}."))) };
58912×
    let role = roles::role_for(&app.db, account, &row).await?;
59012×
    let (issues, proposals) = db::issues::numbers(&app.db, row.id).await?;
59112×
    let kind = if issues.contains(&n) {
5929×
        "issue"
5933×
    } else if proposals.contains(&n) {
5942×
        "proposal"
595
    } else {
5961×
        return Ok(Err(format!("{repo} has no issue or proposal #{n}.")));
597
    };
59811×
    if !roles::allows(role, Access::Read) {
5990×
        return Ok(Err(format!("{repo} has no issue or proposal #{n}.")));
60011×
    }
60111×
    if !pdb::add_card(
60211×
        &app.db,
60311×
        project_id,
60411×
        pdb::NewCard { column_id, kind, repo_id: Some(row.id), number: Some(n), note: "", added_by: actor },
60511×
    )
60611×
    .await?
607
    {
6084×
        return Ok(Err(format!("{repo}#{n} is already on this project.")));
6097×
    }
6107×
    Ok(Ok(newest_card(app, project_id).await?))
61118×
}
612
61311×
async fn newest_card(app: &Shared, project_id: i64) -> sqlx::Result<pdb::Card> {
61411×
    sqlx::query_as("SELECT * FROM project_cards WHERE project_id = $1 ORDER BY id DESC LIMIT 1").bind(project_id).fetch_one(&app.db).await
61511×
}
616
61725×
pub async fn act(
61825×
    State(app): State<Shared>,
61925×
    viewer: Viewer,
62025×
    Path((owner, number)): Path<(String, i64)>,
62125×
    Form(f): Form<BoardForm>,
62225×
) -> Result<Response, Error> {
62325×
    let shell = Shell::new(&app, &format!("/projects/{owner}/{number}"), &viewer);
62425×
    csrf(&viewer, &f.csrf_token, &shell)?;
62525×
    let r = rights(&app, &shell, &viewer, &owner).await?;
62625×
    let e = |e| Error::from_db(shell.clone(), e);
62725×
    let project = pdb::get(&app.db, &owner, number)
62825×
        .await
62925×
        .map_err(e)?
63025×
        .filter(|p| p.public || r.member)
63125×
        .ok_or_else(|| Error::not_found(shell.clone()))?;
63225×
    if !r.edit {
6331×
        return Err(Error::not_found(shell));
63424×
    }
63524×
    if project.closed && !matches!(f.action.as_str(), "settings" | "delete" | "transfer") {
6361×
        return Ok(board(
6371×
            &app,
6381×
            shell,
6391×
            &viewer,
6401×
            &owner,
6411×
            number,
6421×
            None,
6431×
            Some("This project is closed; reopen it to change it.".into()),
6441×
            &BoardQuery::default(),
6451×
        )
6461×
        .await?
6471×
        .into_response());
64823×
    }
64923×
    let actor = viewer.account().map(|a| a.username.clone()).unwrap_or_default();
65023×
    let columns = pdb::columns(&app.db, project.id).await.map_err(e)?;
65131×
    let column = f.column.filter(|c| columns.iter().any(|x| x.id == *c)).or(columns.first().map(|c| c.id));
65223×
    let mut notice = None;
65323×
    let mut error = None;
65423×
    match f.action.as_str() {
65523×
        "add" => {
6567×
            let Some(column_id) = column else { return Err(Error::bad(shell, "no column")) };
6573×
            if let Err(msg) =
6587×
                add_card(&app, viewer.account(), &owner, project.id, column_id, &f.reference, &f.repo, &f.note, &actor).await.map_err(e)?
6593×
            {
6603×
                error = Some(msg);
6614×
            }
662
        }
66316×
        "move" => {
6641×
            if let (Some(card), Some(col)) = (f.card, f.column) {
6651×
                pdb::move_card(&app.db, project.id, card, col).await.map_err(e)?;
6660×
            }
667
        }
66815×
        "up" | "down" => {
6690×
            if let Some(card) = f.card {
6700×
                pdb::shift_card(&app.db, project.id, card, if f.action == "up" { -1 } else { 1 }).await.map_err(e)?;
6710×
            }
672
        }
67315×
        "remove" => {
6740×
            if let Some(card) = f.card {
6750×
                pdb::remove_card(&app.db, project.id, card).await.map_err(e)?;
6760×
            }
677
        }
67815×
        "archive" => {
6791×
            if let Some(card) = f.card {
6801×
                pdb::archive_cards(&app.db, project.id, &[card]).await.map_err(e)?;
6810×
            }
682
        }
68314×
        "restore" => {
6841×
            if let Some(card) = f.card {
6851×
                pdb::restore_card(&app.db, project.id, card).await.map_err(e)?;
6860×
            }
6871×
            return Ok(Redirect::to(&format!("/projects/{owner}/{number}?archived=1")).into_response());
688
        }
68913×
        "archive_older" | "archive_after" => {
6905×
            let Some(col) = f.column else { return Err(Error::bad(shell, "no column")) };
6915×
            let days = match (f.action.as_str(), f.mode.as_str(), f.days.trim()) {
6925×
                ("archive_after", "finished", _) | ("archive_after", "", "") => None,
6931×
                ("archive_after", "never", _) => Some(pdb::NEVER),
6943×
                (_, _, d) => match d.parse::<i64>() {
6952×
                    Ok(n) if (0..=3650).contains(&n) => Some(n),
696
                    _ => {
6971×
                        error = Some("Give a number of days, 0 to 3650.".into());
6981×
                        None
699
                    }
700
                },
701
            };
70215×
            let name = columns.iter().find(|c| c.id == col).map(|c| c.name.clone()).unwrap_or_default();
7035×
            if error.is_none() && f.action == "archive_after" {
7043×
                pdb::set_archive_after(&app.db, project.id, col, days).await.map_err(e)?;
7053×
                notice = Some(match days {
7061×
                    Some(pdb::NEVER) => format!("{name} keeps its cards until you archive them."),
7071×
                    Some(n) => format!("{name} archives its cards {n} day{} after they reach it.", if n == 1 { "" } else { "s" }),
7081×
                    None => format!("{name} archives finished cards {} days after they reach it.", pdb::FINISHED_KEPT_DAYS),
709
                });
7102×
            } else if let (None, Some(days)) = (&error, days) {
7111×
                let now = db::now_ms();
7121×
                let ids: Vec<i64> = pdb::cards(&app.db, project.id)
7131×
                    .await
7141×
                    .map_err(e)?
7151×
                    .into_iter()
7164×
                    .filter(|c| c.column_id == col && c.archived_ms.is_none() && pdb::older_than(c, days, now))
7171×
                    .map(|c| c.id)
7181×
                    .collect();
7191×
                let n = pdb::archive_cards(&app.db, project.id, &ids).await.map_err(e)?;
7201×
                let detail = format!("{n} card(s) of {name} older than {days} days");
7211×
                db::accounts::audit(&app.db, viewer.account(), "project.cards_archived", &format!("{owner}/{number}"), &detail).await.ok();
7221×
                notice = Some(format!("Archived {n} card{} from {name}.", if n == 1 { "" } else { "s" }));
7231×
            }
724
        }
7258×
        "add_column" => {
7260×
            let name = f.name.trim();
7270×
            if name.is_empty() || name.len() > 40 {
7280×
                error = Some("A column has a name of up to 40 characters.".into());
7290×
            } else {
7300×
                pdb::add_column(&app.db, project.id, name).await.map_err(e)?;
731
            }
732
        }
7338×
        "rename_column" => {
7340×
            if let (Some(col), name) = (f.column, f.name.trim()) {
7350×
                if !name.is_empty() && name.len() <= 40 {
7360×
                    pdb::rename_column(&app.db, project.id, col, name).await.map_err(e)?;
7370×
                }
7380×
            }
739
        }
7408×
        "left" | "right" => {
7410×
            if let Some(col) = f.column {
7420×
                pdb::shift_column(&app.db, project.id, col, if f.action == "left" { -1 } else { 1 }).await.map_err(e)?;
7430×
            }
744
        }
7458×
        "remove_column" => {
7463×
            if let Some(col) = f.column {
7473×
                if !pdb::remove_column(&app.db, project.id, col).await.map_err(e)? {
7481×
                    error = Some("A project keeps at least one column.".into());
7492×
                }
7500×
            }
751
        }
7525×
        "settings" => {
7532×
            let title = if f.title.trim().is_empty() { project.title.clone() } else { f.title.trim().chars().take(100).collect() };
7542×
            pdb::set(&app.db, project.id, &title, f.description.trim(), f.private.is_none(), f.closed.is_some()).await.map_err(e)?;
7552×
            notice = Some("Saved.".into());
756
        }
7573×
        "transfer" => {
7582×
            let to = f.to.trim();
7592×
            match rights_of(&app, viewer.account(), to).await.map_err(e)? {
7602×
                _ if to == owner => error = Some(format!("It is {owner}'s already.")),
7611×
                Some(t) if t.edit => {
7621×
                    let moved = pdb::transfer(&app.db, project.id, to).await.map_err(e)?;
7631×
                    let detail = format!("{owner}/{number} to {to}/{}", moved.number);
7641×
                    db::accounts::audit(&app.db, viewer.account(), "project.transferred", &detail, &project.title).await.ok();
7651×
                    return Ok(Redirect::to(&format!("/projects/{to}/{}", moved.number)).into_response());
766
                }
7671×
                _ => error = Some(format!("You cannot make projects under {to}, so you cannot move this one there.")),
768
            }
769
        }
7701×
        "delete" => {
7711×
            pdb::delete(&app.db, project.id).await.map_err(e)?;
7721×
            db::accounts::audit(&app.db, viewer.account(), "project.deleted", &format!("{owner}/{number}"), &project.title).await.ok();
7731×
            return Ok(Redirect::to(&format!("/projects/{owner}")).into_response());
774
        }
7750×
        _ => return Err(Error::bad(shell, "unknown action")),
776
    }
77720×
    if notice.is_none() && error.is_none() {
778
        // Back to the board, so a reload does not repeat the action.
7798×
        return Ok(Redirect::to(&format!("/projects/{owner}/{number}")).into_response());
78012×
    }
78112×
    Ok(board(&app, shell, &viewer, &owner, number, notice, error, &BoardQuery::default()).await?.into_response())
78225×
}
783
784
/// The projects an issue or proposal is on that the viewer may see, with
785
/// their column.
78699×
pub async fn placements_for(app: &Shared, viewer: &Viewer, repo: &db::repos::RepoRow, number: i64) -> Vec<(pdb::Project, String)> {
78799×
    let Ok(all) = pdb::placements(&app.db, repo.id, number).await else { return vec![] };
78899×
    let mut out = Vec::new();
78999×
    for (p, col) in all {
7903×
        let visible = p.public
7911×
            || viewer.is_admin()
7921×
            || match viewer.account() {
7930×
                Some(v) if v.username == p.owner => true,
7940×
                Some(v) => match db::accounts::org_by_name(&app.db, &p.owner).await.ok().flatten() {
7950×
                    Some(o) => db::accounts::org_role(&app.db, o.id, v.id).await.ok().flatten().is_some(),
7960×
                    None => false,
797
                },
7981×
                None => false,
799
            };
8003×
        if visible {
8012×
            out.push((p, col));
8022×
        }
803
    }
80499×
    out
80599×
}
806
807
#[cfg(test)]
808
mod tests {
809
    use super::parse_reference;
810
811
    #[test]
8121×
    fn references() {
8137×
        let p = |r: &str, repo: &str| parse_reference(r, repo, "andy").ok();
8141×
        assert_eq!(p("oxygen#12", ""), Some(("oxygen".into(), 12)));
8151×
        assert_eq!(p("#7", "hub"), Some(("hub".into(), 7)));
8161×
        assert_eq!(p(" hub # 3 ", ""), Some(("hub".into(), 3)));
8171×
        assert_eq!(p("#7", ""), None, "a repository is needed");
8181×
        assert_eq!(p("andy/hub#4", ""), Some(("hub".into(), 4)), "the board's own owner, as it shows cards");
8191×
        assert!(parse_reference("other/repo#1", "", "andy").unwrap_err().contains("only andy's"), "another owner is refused, saying why");
8201×
        assert_eq!(p("hub#0", ""), None);
8211×
        assert_eq!(p("hub", ""), None);
8221×
    }
823
}
824
825
#[derive(Deserialize)]
826
pub struct PlaceForm {
827
    #[serde(rename = "_csrf")]
828
    csrf_token: String,
829
    /// The project's number among its owner's.
830
    project: i64,
831
    /// `add` or `remove`.
832
    action: String,
833
}
834
835
/// Put an issue or proposal on one of its repository owner's projects (in
836
/// the first column), or take it off, from its own page.
8372×
async fn place(
8382×
    app: Shared,
8392×
    viewer: Viewer,
8402×
    owner: String,
8412×
    name: String,
8422×
    kind: &'static str,
8432×
    number: i64,
8442×
    f: PlaceForm,
8452×
) -> Result<Response, Error> {
8462×
    let page = format!("/{owner}/{name}/{kind}/{number}");
8472×
    let shell = Shell::new(&app, &page, &viewer);
8482×
    csrf(&viewer, &f.csrf_token, &shell)?;
8492×
    let (_, row, _) = super::lookup(&app, &shell, &viewer, &owner, &name).await?;
8502×
    let r = rights(&app, &shell, &viewer, &row.owner).await?;
8512×
    if !r.edit {
8520×
        return Err(Error::not_found(shell));
8532×
    }
8542×
    let e = |e| Error::from_db(shell.clone(), e);
8552×
    let project = pdb::get(&app.db, &row.owner, f.project).await.map_err(e)?.ok_or_else(|| Error::not_found(shell.clone()))?;
8562×
    let actor = viewer.account().map(|a| a.username.clone()).unwrap_or_default();
8572×
    let mut error = None;
8582×
    match f.action.as_str() {
8592×
        "add" => {
8601×
            let columns = pdb::columns(&app.db, project.id).await.map_err(e)?;
8611×
            let Some(first) = columns.first() else { return Err(Error::bad(shell, "that project has no columns")) };
8620×
            if let Err(msg) =
8631×
                add_card(&app, viewer.account(), &row.owner, project.id, first.id, &format!("{}#{number}", row.name), &row.name, "", &actor)
8641×
                    .await
8651×
                    .map_err(e)?
8660×
            {
8670×
                error = Some(msg);
8681×
            }
869
        }
8701×
        "remove" => {
8711×
            for c in pdb::cards(&app.db, project.id).await.map_err(e)? {
8721×
                if c.repo_id == Some(row.id) && c.number == Some(number) {
8731×
                    pdb::remove_card(&app.db, project.id, c.id).await.map_err(e)?;
8740×
                }
875
            }
876
        }
8770×
        _ => return Err(Error::bad(shell, "add or remove")),
878
    }
8792×
    let to = match error {
8800×
        Some(m) => format!("{page}?error={}", super::settings::urlencode(&m)),
8812×
        None => page,
882
    };
8832×
    Ok(Redirect::to(&to).into_response())
8842×
}
885
886
/// `POST /{owner}/{name}/proposal/{number}/project`.
8872×
pub async fn place_proposal(
8882×
    State(app): State<Shared>,
8892×
    viewer: Viewer,
8902×
    Path((owner, name, number)): Path<(String, String, i64)>,
8912×
    Form(f): Form<PlaceForm>,
8922×
) -> Result<Response, Error> {
8932×
    place(app, viewer, owner, name, "proposal", number, f).await
8942×
}
895
896
/// `POST /{owner}/{name}/issue/{number}/project`.
8970×
pub async fn place_issue(
8980×
    State(app): State<Shared>,
8990×
    viewer: Viewer,
9000×
    Path((owner, name, number)): Path<(String, String, i64)>,
9010×
    Form(f): Form<PlaceForm>,
9020×
) -> Result<Response, Error> {
9030×
    place(app, viewer, owner, name, "issue", number, f).await
9040×
}
905
906
/// The owner's open projects `viewer` may add an item to that it is not on
907
/// yet; `None` when the viewer may not change the owner's projects at all.
90899×
pub async fn project_choices(
90999×
    app: &Shared,
91099×
    viewer: &Viewer,
91199×
    repo: &db::repos::RepoRow,
91299×
    placed: &[(pdb::Project, String)],
91399×
) -> Option<Vec<pdb::Project>> {
91499×
    let Ok(Some(r)) = rights_of(app, viewer.account(), &repo.owner).await else { return None };
91599×
    if !r.edit {
91645×
        return None;
91754×
    }
918
    Some(
91954×
        pdb::of_owner(&app.db, &repo.owner)
92054×
            .await
92154×
            .unwrap_or_default()
92254×
            .into_iter()
92354×
            .filter(|p| !p.closed && !placed.iter().any(|(q, _)| q.id == p.id))
92454×
            .collect(),
925
    )
92699×
}