//! Milestone 0.4 end to end: issues with labels, assignees and //! milestones, cross references, closing keywords on landing, the inbox, //! watching, mentions and search. use axum::body::Body; use axum::http::{header, Request, StatusCode}; use http_body_util::BodyExt; use oxy_core::repo::Repo; use oxygenhub::config::Config; use oxygenhub::db; use oxygenhub::repos::RepoName; use oxygenhub::Shared; use std::path::Path; use tower::ServiceExt; fn hermetic() { static ONCE: std::sync::Once = std::sync::Once::new(); static DIR: std::sync::OnceLock = std::sync::OnceLock::new(); ONCE.call_once(|| { let d = tempfile::tempdir().unwrap(); std::env::set_var("OXY_HOME", d.path()); DIR.set(d).ok(); }); } fn write(root: &Path, rel: &str, content: &[u8]) { let p = root.join(rel); std::fs::create_dir_all(p.parent().unwrap()).unwrap(); std::fs::write(p, content).unwrap(); } struct Hub { app: Shared, base: String, _dir: tempfile::TempDir, } async fn hub() -> Hub { hermetic(); let dir = tempfile::tempdir().unwrap(); let mut config = Config::load(dir.path()).unwrap(); // The first account's setup code (oxygenhub#245). config.registration.setup_code = "test-setup".into(); config.auth.push_tokens = vec!["site".into()]; config.registration.mode = "open".into(); let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap(); let port = listener.local_addr().unwrap().port(); config.server.base_url = format!("http://127.0.0.1:{port}"); let app = oxygenhub::build(config).await.unwrap(); let router = oxygenhub::router(app.clone()); tokio::spawn(async move { axum::serve(listener, router).await.unwrap() }); Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir } } struct Res { status: StatusCode, body: String, cookie: Option, location: Option, } async fn send(app: &Shared, method: &str, path: &str, cookie: Option<&str>, form: Option<&str>) -> Res { let mut req = Request::builder().method(method).uri(path); if let Some(c) = cookie { req = req.header(header::COOKIE, format!("oxyhub={c}")); } let body = match form { Some(f) => { req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded"); Body::from(f.to_string()) } None => Body::empty(), }; let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap(); let status = res.status(); let cookie = res .headers() .get(header::SET_COOKIE) .and_then(|v| v.to_str().ok()) .and_then(|v| v.split(';').next()) .and_then(|kv| kv.split_once('=')) .map(|(_, v)| v.to_string()); let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from); let bytes = res.into_body().collect().await.unwrap().to_bytes(); Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location } } async fn get(app: &Shared, path: &str, cookie: Option<&str>) -> Res { send(app, "GET", path, cookie, None).await } async fn post(app: &Shared, path: &str, cookie: Option<&str>, form: &str) -> Res { send(app, "POST", path, cookie, Some(form)).await } async fn register(app: &Shared, user: &str) -> String { let r = post( app, "/register", None, &format!("username={user}&email={user}%40example.com&password=correct-horse-battery&setup=test-setup"), ) .await; assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body); r.cookie.unwrap() } fn csrf_of(page: &str) -> String { let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len(); page[i..].split('"').next().unwrap().to_string() } #[tokio::test(flavor = "multi_thread")] async fn issues_notifications_and_search() { let h = hub().await; let app = &h.app; let andy = register(app, "andy").await; let bob = register(app, "bob").await; let repo = RepoName::parse("andy/demo").unwrap(); app.repos.create(&repo, None).unwrap(); db::repos::create(&app.db, "andy", "demo", "", hub_api::Visibility::Public).await.unwrap(); // Labels and a milestone, by the owner. let labels_page = get(app, "/andy/demo/labels", Some(&andy)).await; let csrf_a = csrf_of(&labels_page.body); assert!(post(app, "/andy/demo/labels", Some(&andy), &format!("_csrf={csrf_a}&name=bug&colour=%23ff0000&description=Something+broke")) .await .body .contains("Saved bug")); assert!(post(app, "/andy/demo/milestones", Some(&andy), &format!("_csrf={csrf_a}&title=v1&description=First&due=2027-01-01")) .await .body .contains("v1")); assert_eq!(get(app, "/andy/demo/labels", Some(&bob)).await.status, StatusCode::OK, "readers see labels"); assert!(!get(app, "/andy/demo/labels", Some(&bob)).await.body.contains("Add or change"), "but cannot edit them"); // Bob watches the repository, then Andy opens an issue mentioning @bob: Bob is told twice at most once. let overview = get(app, "/andy/demo", Some(&bob)).await; let csrf_b = csrf_of(&overview.body); assert_eq!(post(app, "/andy/demo/watch", Some(&bob), &format!("_csrf={csrf_b}")).await.status, StatusCode::SEE_OTHER); assert!(get(app, "/andy/demo", Some(&bob)).await.body.contains("UNWATCH")); let new_page = get(app, "/andy/demo/issues/new", Some(&andy)).await; let csrf_a = csrf_of(&new_page.body); let r = post( app, "/andy/demo/issues/new", Some(&andy), &format!("_csrf={csrf_a}&title=Crash+on+start&body=cc+%40bob+see+%23999+and+deadbeefcafe1234"), ) .await; assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body); assert_eq!(r.location.as_deref(), Some("/andy/demo/issue/1")); let page = get(app, "/andy/demo/issue/1", Some(&bob)).await; assert!(page.body.contains("Crash on start")); assert!(page.body.contains("href=\"/bob\""), "mention linked: {}", page.body); assert!(page.body.contains("/andy/demo/change/deadbeefcafe1234"), "hash linked: {}", page.body); assert!(page.body.contains("#999") && !page.body.contains("issue/999"), "unknown numbers are not linked"); let unread = db::notify::unread(&app.db, db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id).await.unwrap(); assert_eq!(unread, 1, "one notification, not one per reason"); // The inbox's thread counts it unread (the SQL is portable now: // oxygenhub#211). let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id; let filter = db::notify::Filter { done: false, unread_only: false, reason: None, kind: None, repo_id: None }; let t = db::notify::threads(&app.db, bob_id, &filter, 10).await.unwrap(); assert_eq!((t[0].count, t[0].unread), (1, 1)); let unread_only = db::notify::Filter { unread_only: true, ..filter.clone() }; assert_eq!(db::notify::threads(&app.db, bob_id, &unread_only, 10).await.unwrap().len(), 1); let inbox = get(app, "/notifications", Some(&bob)).await; assert!(inbox.body.contains("andy/demo#1: Crash on start"), "{}", inbox.body); assert!(get(app, "/andy/demo", Some(&bob)).await.body.contains("class=\"count\">1<"), "bell shows the count"); // Triage: labels, assignee, milestone, pin, lock. let page = get(app, "/andy/demo/issue/1", Some(&andy)).await; let csrf_a = csrf_of(&page.body); let label_id: i64 = sqlx::query_scalar("SELECT id FROM labels WHERE name = 'bug'").fetch_one(&app.db).await.unwrap(); let r = post(app, "/andy/demo/issue/1/labels", Some(&andy), &format!("_csrf={csrf_a}&label={label_id}")).await; assert!(r.body.contains(">bug<"), "{}", r.body); let r = post(app, "/andy/demo/issue/1/assign", Some(&andy), &format!("_csrf={csrf_a}&username=bob&action=add")).await; assert!(r.body.contains("
  • v1<"), "{}", r.body); assert!(post(app, "/andy/demo/issue/1/state", Some(&andy), &format!("_csrf={csrf_a}&action=pin")).await.body.contains("Unpin issue")); assert_eq!( post( app, "/andy/demo/issue/1/state", Some(&bob), &format!("_csrf={}&action=lock", csrf_of(&get(app, "/andy/demo/issue/1", Some(&bob)).await.body)) ) .await .status, StatusCode::NOT_FOUND, "bob cannot lock" ); // Filters on the list. let list = get(app, "/andy/demo/issues?q=label:bug+assignee:bob+milestone:v1", None).await; assert!(list.body.contains("Crash on start"), "{}", list.body); assert!(!get(app, "/andy/demo/issues?q=label:feature", None).await.body.contains("Crash on start")); assert!(get(app, "/andy/demo/milestones", None).await.body.contains("1 open, 0 closed")); // Bob comments and closes; the author is told; search finds the comment. let csrf_b = csrf_of(&get(app, "/andy/demo/issue/1", Some(&bob)).await.body); let r = post(app, "/andy/demo/issue/1/comment", Some(&bob), &format!("_csrf={csrf_b}&body=Reproduced+with+the+flux+capacitor")).await; assert!(r.body.contains("flux capacitor"), "{}", r.body); assert!(get(app, "/notifications", Some(&andy)).await.body.contains("andy/demo#1")); let s = get(app, "/search?q=capacitor", None).await; assert!(s.body.contains("Crash on start") && s.body.contains("capacitor"), "{}", s.body); let s = get(app, "/search?q=demo", None).await; assert!(s.body.contains("/andy/demo\""), "repository hit: {}", s.body); // Bob is not triage, but as an assignee of an open issue he can comment-and-close? No: only the author or triage. let r = post(app, "/andy/demo/issue/1/comment", Some(&bob), &format!("_csrf={csrf_b}&body=closing&close=completed")).await; assert!(r.body.contains(">open<") || r.body.contains("head\">open"), "still open: {}", r.body); let r = post(app, "/andy/demo/issue/1/comment", Some(&andy), &format!("_csrf={csrf_a}&body=fixed&close=completed")).await; assert!(r.body.contains("closed"), "{}", r.body); assert!(get(app, "/andy/demo/issues?state=closed", None).await.body.contains("Crash on start")); // A second issue closed by a change message pushed to the default bookmark. let csrf_a = csrf_of(&get(app, "/andy/demo/issues/new", Some(&andy)).await.body); assert_eq!( post(app, "/andy/demo/issues/new", Some(&andy), &format!("_csrf={csrf_a}&title=Typo&body=")).await.location.as_deref(), Some("/andy/demo/issue/2") ); let work = tempfile::tempdir().unwrap(); let mut client = Repo::init(work.path()).unwrap(); client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap(); client.config.set("remote.origin.token", "site").unwrap(); client.save_config().unwrap(); write(work.path(), "a.txt", b"a\n"); client.snapshot("t").unwrap(); client.commit("Fix the typo\n\nCloses #2", &[]).unwrap(); assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok)); tokio::time::sleep(std::time::Duration::from_millis(300)).await; let issue2 = db::issues::get(&app.db, db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id, 2).await.unwrap().unwrap(); assert_eq!(issue2.state, "closed", "closed by the landed change"); assert!(get(app, "/andy/demo/issue/2", None).await.body.contains("closed by change")); // Numbers are shared: the next proposal is #3, and /issue/3 redirects to it. client.bookmark_create("feat", None).unwrap(); client.bookmark_switch("feat", false).unwrap(); write(work.path(), "b.txt", b"b\n"); client.snapshot("t").unwrap(); client.commit("feat", &[]).unwrap(); assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok)); let csrf_a = csrf_of(&get(app, "/andy/demo/proposals/new?source=feat&target=main", Some(&andy)).await.body); let r = post(app, "/andy/demo/proposals/new", Some(&andy), &format!("_csrf={csrf_a}&title=Feat&target=main&source=feat")).await; assert_eq!(r.location.as_deref(), Some("/andy/demo/proposal/3"), "{}", r.body); assert_eq!(get(app, "/andy/demo/issue/3", None).await.location.as_deref(), Some("/andy/demo/proposal/3")); // A comment on the issue referencing #3 links to the proposal. let r = post(app, "/andy/demo/issue/2/comment", Some(&andy), &format!("_csrf={csrf_a}&body=see+%233")).await; assert!(r.body.contains("href=\"/andy/demo/proposal/3\""), "{}", r.body); // `#N` in a pushed change's message lands on those timelines (hub spec §8). client.bookmark_switch("main", false).unwrap(); write(work.path(), "c.txt", b"c\n"); client.snapshot("t").unwrap(); let r = client.commit("Tidy up (refs #1, see #3)", &[]).unwrap(); assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok)); tokio::time::sleep(std::time::Duration::from_millis(300)).await; let short = &r.to_hex()[..12]; let one = get(app, "/andy/demo/issue/1", None).await.body; assert!( one.contains("referenced by change") && one.contains(&format!("href=\"/andy/demo/change/{short}\"")) && one.contains(" on main"), "{one}" ); let three = get(app, "/andy/demo/proposal/3", Some(&andy)).await.body; assert!(three.contains("referenced by change") && three.contains(short), "proposals too"); assert!(!get(app, "/andy/demo/issue/2", None).await.body.contains("referenced by change"), "a closing change records only that"); // Bob takes part in #1 (mentioned, assigned, commented) and only watches #3. let part = get(app, "/notifications?reason=participating", Some(&bob)).await.body; assert!(part.contains("andy/demo#1") && !part.contains("andy/demo#3: Feat"), "{part}"); let watch = get(app, "/notifications?reason=watching", Some(&bob)).await.body; assert!(watch.contains("andy/demo#3: Feat") && !watch.contains("Crash on start"), "{watch}"); let props = get(app, "/notifications?kind=proposal", Some(&bob)).await.body; assert!(props.contains("andy/demo#3: Feat") && !props.contains("andy/demo#1"), "kind filter"); assert!(get(app, "/notifications?repo=andy/demo", Some(&bob)).await.body.contains("andy/demo#3: Feat")); assert!(get(app, "/notifications?repo=nobody/none", Some(&bob)).await.body.contains("Nothing matches these filters")); // One row per thread, however many events it had. let inbox = get(app, "/notifications", Some(&bob)).await.body; assert_eq!(inbox.matches("data-row-thread=\"/andy/demo/issue/1\"").count(), 1, "{inbox}"); assert!(inbox.contains(" updates"), "the count of a busy thread"); // Opening a thread marks it read and goes there. let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id; let newest: i64 = sqlx::query_scalar( "SELECT id FROM notifications WHERE account_id = $1 AND thread = '/andy/demo/proposal/3' ORDER BY id DESC LIMIT 1", ) .bind(bob_id) .fetch_one(&app.db) .await .unwrap(); let before = db::notify::unread(&app.db, bob_id).await.unwrap(); let r = get(app, &format!("/notifications/open/{newest}"), Some(&bob)).await; assert_eq!(r.location.as_deref(), Some("/andy/demo/proposal/3")); assert!(db::notify::unread(&app.db, bob_id).await.unwrap() < before); assert_eq!(get(app, &format!("/notifications/open/{newest}"), Some(&andy)).await.status, StatusCode::NOT_FOUND, "only your own"); // Done sets a thread aside until something new happens in it. let csrf_b = csrf_of(&get(app, "/notifications", Some(&bob)).await.body); let r = post( app, "/notifications/thread", Some(&bob), &format!("_csrf={csrf_b}&thread=%2Fandy%2Fdemo%2Fissue%2F1&action=done&back=%2Fnotifications"), ) .await; assert_eq!(r.location.as_deref(), Some("/notifications")); assert!(!get(app, "/notifications", Some(&bob)).await.body.contains("Crash on start")); assert!(get(app, "/notifications?view=done", Some(&bob)).await.body.contains("Crash on start")); post(app, "/andy/demo/issue/1/comment", Some(&andy), &format!("_csrf={csrf_a}&body=one+more+thing")).await; assert!(get(app, "/notifications", Some(&bob)).await.body.contains("Crash on start"), "back with the new comment"); let r = post( app, "/notifications/thread", Some(&bob), &format!("_csrf={csrf_b}&thread=%2Fandy%2Fdemo%2Fissue%2F1&action=read&back=https%3A%2F%2Fevil.example"), ) .await; assert_eq!(r.location.as_deref(), Some("/notifications"), "only back to the inbox"); // Bob (watcher) heard about the proposal; the inbox marks all read. assert!(get(app, "/notifications", Some(&bob)).await.body.contains("andy/demo#3: Feat")); let csrf_b = csrf_of(&get(app, "/notifications", Some(&bob)).await.body); let r = post(app, "/notifications/read", Some(&bob), &format!("_csrf={csrf_b}")).await; assert!(r.body.contains("0 unread"), "{}", r.body); // Email preference and the unsubscribe link. let r = post(app, "/settings/notifications", Some(&bob), &format!("_csrf={csrf_b}&email=1")).await; assert!(r.body.contains("Email notifications are on")); let key: String = sqlx::query_scalar("SELECT unsubscribe_key FROM accounts WHERE username = 'bob'").fetch_one(&app.db).await.unwrap(); assert_eq!(get(app, &format!("/settings/notifications?unsubscribe={key}"), None).await.status, StatusCode::OK); let on: bool = sqlx::query_scalar("SELECT email_notifications FROM accounts WHERE username = 'bob'").fetch_one(&app.db).await.unwrap(); assert!(!on); } #[tokio::test(flavor = "multi_thread")] async fn dashboard_shows_what_needs_the_viewer() { let h = hub().await; let app = &h.app; let andy = register(app, "andy").await; let bob = register(app, "bob").await; for (name, vis) in [("demo", hub_api::Visibility::Public), ("secret", hub_api::Visibility::Private)] { app.repos.create(&RepoName::parse(&format!("andy/{name}")).unwrap(), None).unwrap(); db::repos::create(&app.db, "andy", name, "", vis).await.unwrap(); } let demo = db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap(); let secret = db::repos::get(&app.db, "andy", "secret").await.unwrap().unwrap(); let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id; for (repo, title) in [(demo.id, "Faster startup"), (secret.id, "Hidden work")] { let p = db::proposals::create( &app.db, db::proposals::NewProposal { repo_id: repo, title, body: "", author_id: Some(bob_id), author: "bob", draft: false, target: "main", source_kind: "bookmark", source_repo_id: Some(repo), source_bookmark: "fast", source_changes: "", }, ) .await .unwrap(); db::proposals::add_event(&app.db, p.id, "bob", "opened", "").await.unwrap(); } // Signed out, `/` is still the repository list. let anon = get(app, "/", None).await; assert!(anon.body.contains("andy /") && !anon.body.contains("Dashboard "), "{}", anon.body); // Andy owns both repositories: both proposals wait for his review. let page = get(app, "/", Some(&andy)).await; assert_eq!(page.status, StatusCode::OK); assert!(page.body.contains("Waiting for your review2"), "{}", page.body); assert!(page.body.contains("/andy/demo/proposal/1") && page.body.contains("/andy/secret/proposal/1")); assert!(page.body.contains("Your repositories")); assert!(page.body.contains("opened proposal"), "activity feed: {}", page.body); // Your sky (#157, docs/backgrounds.md §5): the canvas, and its data from // the database: his repositories and their events, safe in a script. assert!(page.body.contains(r#""), "site bar and tab" ); let list = get(app, "/projects/andy", Some(&andy)).await.body; assert!(list.contains("href=\"#new\">+ NEW PROJECT") && list.contains("id=\"new\""), "the button and the form"); assert!(get(app, "/projects/andy", Some(&bob)).await.body.contains("Only andy"), "who can make one"); let csrf = csrf_of(&list); let r = post(app, "/projects/andy", Some(&andy), &format!("_csrf={csrf}&title=Roadmap&description=Next+steps")).await; assert_eq!(r.location.as_deref(), Some("/projects/andy/1"), "{}", r.body); // The list (#124): a row per project, counted under Open, and a filter. let list = get(app, "/projects/andy", Some(&andy)).await.body; assert!( list.contains(">Roadmap") && list.contains("Next steps") && list.contains("Open 1"), "{list}" ); let filtered = get(app, "/projects/andy?q=roadm", Some(&andy)).await.body; assert!(filtered.contains(">Roadmap"), "a filter matches part of the title, any case"); let none = get(app, "/projects/andy?q=nothing+like+it", Some(&andy)).await.body; assert!(none.contains("No open project matches") && !none.contains(">Roadmap"), "{none}"); let closed = get(app, "/projects/andy?state=closed", Some(&andy)).await.body; assert!(closed.contains("No closed projects.") && closed.contains("Closed 0"), "{closed}"); let board = get(app, "/projects/andy/1", Some(&andy)).await.body; for col in ["Backlog", "Doing", "Done"] { assert!(board.contains(&format!(">{col} = sqlx::query_scalar("SELECT id FROM project_columns ORDER BY position").fetch_all(&app.db).await.unwrap(); let act = |form: String| { let andy = andy.clone(); async move { post(app, "/projects/andy/1", Some(&andy), &form).await } }; // Cards: by reference, by repository and number, a note; duplicates and strangers refused. assert_eq!( act(format!("_csrf={csrf}&action=add&column={}&reference=demo%231", cols[0])).await.location.as_deref(), Some("/projects/andy/1") ); act(format!("_csrf={csrf}&action=add&column={}&repo=secret&reference=%231", cols[0])).await; act(format!("_csrf={csrf}&action=add&column={}¬e=Write+the+docs", cols[1])).await; assert!(act(format!("_csrf={csrf}&action=add&column={}&reference=demo%231", cols[1])).await.body.contains("already on this project")); assert!(act(format!("_csrf={csrf}&action=add&column={}&reference=demo%2399", cols[0])).await.body.contains("no issue or proposal #99")); assert!(act(format!("_csrf={csrf}&action=add&column={}&reference=nothere%231", cols[0])).await.body.contains("no repository nothere")); // Move demo#1 to Done. let demo_card: i64 = sqlx::query_scalar("SELECT c.id FROM project_cards c JOIN repositories r ON r.id = c.repo_id WHERE r.name = 'demo'") .fetch_one(&app.db) .await .unwrap(); act(format!("_csrf={csrf}&action=move&card={demo_card}&column={}", cols[2])).await; let issue = get(app, "/andy/demo/issue/1", None).await.body; assert!(issue.contains("href=\"/projects/andy/1\">Roadmap · Done"), "the issue shows where it is"); // Readers see public cards, never those of repositories they cannot read. let anon = get(app, "/projects/andy/1", None).await.body; assert!(anon.contains("demo issue") && anon.contains("Write the docs") && !anon.contains("secret issue"), "{anon}"); assert!(!anon.contains("name=\"action\""), "and cannot change anything"); assert!(get(app, "/projects/andy/1", Some(&andy)).await.body.contains("secret issue")); // Only the owner changes it; a private project is invisible to others. let csrf_b = csrf_of(&get(app, "/settings", Some(&bob)).await.body); assert_eq!( post(app, "/projects/andy/1", Some(&bob), &format!("_csrf={csrf_b}&action=remove&card={demo_card}")).await.status, StatusCode::NOT_FOUND ); act(format!("_csrf={csrf}&action=settings&title=Roadmap&description=&private=1")).await; assert_eq!(get(app, "/projects/andy/1", Some(&bob)).await.status, StatusCode::NOT_FOUND); assert!(!get(app, "/projects/andy", None).await.body.contains("Roadmap"), "not even listed"); assert!(!get(app, "/andy/demo/issue/1", None).await.body.contains("Roadmap"), "nor on the issue"); // Columns: removing one moves its cards to the first column; the last one stays. act(format!("_csrf={csrf}&action=remove_column&column={}", cols[1])).await; let note_col: i64 = sqlx::query_scalar("SELECT column_id FROM project_cards WHERE kind = 'note'").fetch_one(&app.db).await.unwrap(); assert_eq!(note_col, cols[0]); act(format!("_csrf={csrf}&action=remove_column&column={}", cols[2])).await; assert!(act(format!("_csrf={csrf}&action=remove_column&column={}", cols[0])).await.body.contains("at least one column")); // Closed projects are read-only until reopened; then deleted, the issues remain. act(format!("_csrf={csrf}&action=settings&title=Roadmap&closed=1")).await; assert!(act(format!("_csrf={csrf}&action=add&column={}¬e=late", cols[0])).await.body.contains("This project is closed")); let r = act(format!("_csrf={csrf}&action=delete")).await; assert_eq!(r.location.as_deref(), Some("/projects/andy")); assert_eq!(get(app, "/projects/andy/1", Some(&andy)).await.status, StatusCode::NOT_FOUND); assert_eq!(get(app, "/andy/demo/issue/1", None).await.status, StatusCode::OK); assert_eq!(get(app, "/projects/nobody", None).await.status, StatusCode::NOT_FOUND); } #[tokio::test(flavor = "multi_thread")] async fn issue_markdown_follows_the_default_bookmark() { let h = hub().await; let app = &h.app; register(app, "andy").await; app.repos.create(&RepoName::parse("andy/trunky").unwrap(), None).unwrap(); let row = db::repos::create(&app.db, "andy", "trunky", "", hub_api::Visibility::Public).await.unwrap(); sqlx::query("UPDATE repositories SET default_bookmark = 'trunk' WHERE id = $1").bind(row.id).execute(&app.db).await.unwrap(); db::issues::create( &app.db, db::issues::NewIssue { repo_id: row.id, title: "Docs", body: "See [the guide](docs/guide.md) and ![shot](img/a.png).", author_id: None, author: "andy", }, ) .await .unwrap(); let page = get(app, "/andy/trunky/issue/1", None).await.body; assert!(page.contains("href=\"/andy/trunky/file/trunk/docs/guide.md\""), "{page}"); assert!(page.contains("src=\"/andy/trunky/raw/trunk/img/a.png\"")); assert!(!page.contains("/file/main/")); } /// #125: a board moves to an owner its user may make boards under, takes the /// next number there with its cards, and its old address redirects to it; a /// new board at the old address takes it over. #[tokio::test(flavor = "multi_thread")] async fn a_project_transfers_to_an_organisation() { let h = hub().await; let app = &h.app; // The first account is the site's administrator, who may make boards // anywhere: Andy is an ordinary user here. let _first = register(app, "ada").await; let andy = register(app, "andy").await; let _bob = register(app, "bob").await; let andy_id = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id; let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id; db::accounts::create_org(&app.db, "retro", "Retro Club", andy_id).await.unwrap(); db::accounts::create_org(&app.db, "other", "Someone else's", bob_id).await.unwrap(); let list = get(app, "/projects/andy", Some(&andy)).await.body; let csrf = csrf_of(&list); let r = post(app, "/projects/andy", Some(&andy), &format!("_csrf={csrf}&title=Roadmap")).await; assert_eq!(r.location.as_deref(), Some("/projects/andy/1")); post(app, "/projects/andy/1", Some(&andy), &format!("_csrf={csrf}&action=add¬e=Keep+me")).await; // Settings offer the organisations Andy belongs to, not other people's. let board = get(app, "/projects/andy/1", Some(&andy)).await.body; assert!(board.contains("") && !board.contains("value=\"other\""), "{board}"); let refused = post(app, "/projects/andy/1", Some(&andy), &format!("_csrf={csrf}&action=transfer&to=other")).await; assert!(refused.body.contains("You cannot make projects under other"), "{}", refused.body); let r = post(app, "/projects/andy/1", Some(&andy), &format!("_csrf={csrf}&action=transfer&to=retro")).await; assert_eq!(r.location.as_deref(), Some("/projects/retro/1"), "{}", r.body); let moved = get(app, "/projects/retro/1", Some(&andy)).await.body; assert!(moved.contains("Roadmap") && moved.contains("Keep me"), "the cards come too"); let old = get(app, "/projects/andy/1", Some(&andy)).await; assert_eq!(old.status, StatusCode::PERMANENT_REDIRECT); assert_eq!(old.location.as_deref(), Some("/projects/retro/1")); // A new board of Andy's takes number 1 again, and its own address back. let r = post(app, "/projects/andy", Some(&andy), &format!("_csrf={csrf}&title=Fresh")).await; assert_eq!(r.location.as_deref(), Some("/projects/andy/1")); let fresh = get(app, "/projects/andy/1", Some(&andy)).await; assert_eq!(fresh.status, StatusCode::OK); assert!(fresh.body.contains("Fresh")); } /// Backups' settings (#169): a user's page, its checks, and an /// organisation's page for its owners only. #[tokio::test(flavor = "multi_thread")] async fn backups_are_set_up_in_settings() { let h = hub().await; let app = &h.app; let andy = register(app, "andy").await; let page = get(app, "/settings/backups", Some(&andy)).await; assert_eq!(page.status, StatusCode::OK); assert!(page.body.contains("href=\"/settings/backups\" class=\"on\"") && page.body.contains("No runs yet."), "{}", page.body); let csrf = csrf_of(&page.body); // This hub allows no directory: only a bucket, and a real provider name. let bad = post( app, "/settings/backups", Some(&andy), &format!("_csrf={csrf}&every=hourly&destination=gcs&bucket=andy-backup&provider=nope&keep_days=30"), ) .await; assert!(bad.body.contains("workload identity provider"), "{}", bad.body); let dir = post(app, "/settings/backups", Some(&andy), &format!("_csrf={csrf}&every=hourly&destination=dir&dir=%2Ftmp&keep_days=30")).await; assert!(dir.body.contains("Pick one of the directories this hub allows.")); let provider = "%2F%2Fiam.googleapis.com%2Fprojects%2F1%2Flocations%2Fglobal%2FworkloadIdentityPools%2Foxygenhub%2Fproviders%2Foxygenhub-io"; let ok = post( app, "/settings/backups", Some(&andy), &format!("_csrf={csrf}&every=hourly&destination=gcs&bucket=gs%3A%2F%2Fandy-backup&provider={provider}&keep_days=7"), ) .await; assert!(ok.body.contains("Saved."), "{}", ok.body); let s = oxygenhub::backups::setting(&app.db, "andy").await.unwrap().unwrap(); assert_eq!((s.target.as_str(), s.keep_days, s.every.as_str()), ("andy-backup", 7, "hourly")); // An S3 bucket (BP4): its region and the role the hub assumes. let bad = post( app, "/settings/backups", Some(&andy), &format!("_csrf={csrf}&every=hourly&destination=s3&s3_bucket=andy-backup&s3_region=eu-west-2&s3_role=admin&keep_days=30"), ) .await; assert!(bad.body.contains("the IAM role"), "{}", bad.body); let role = "arn%3Aaws%3Aiam%3A%3A123456789012%3Arole%2Foxygenhub-backup"; let ok = post( app, "/settings/backups", Some(&andy), &format!( "_csrf={csrf}&every=daily&destination=s3&s3_bucket=s3%3A%2F%2Fandy-backup&s3_region=eu-west-2&s3_role={role}&keep_days=30" ), ) .await; assert!(ok.body.contains("Saved.") && ok.body.contains(r#"value="s3" checked"#), "{}", ok.body); let s = oxygenhub::backups::setting(&app.db, "andy").await.unwrap().unwrap(); assert_eq!((s.destination.as_str(), s.target.as_str(), s.region.as_str()), ("s3", "andy-backup", "eu-west-2")); assert_eq!(s.provider, "arn:aws:iam::123456789012:role/oxygenhub-backup"); // Back to GCS for what follows. let ok = post( app, "/settings/backups", Some(&andy), &format!("_csrf={csrf}&every=hourly&destination=gcs&bucket=gs%3A%2F%2Fandy-backup&provider={provider}&keep_days=7"), ) .await; assert!(ok.body.contains("Saved.")); // An organisation's backups are its owners' business only. let bob = register(app, "bob").await; let andy_id = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id; db::accounts::create_org(&app.db, "club", "Club", andy_id).await.unwrap(); assert_eq!(get(app, "/orgs/club/settings/backups", Some(&bob)).await.status, StatusCode::NOT_FOUND); let club = get(app, "/orgs/club/settings/backups", Some(&andy)).await; assert!(club.body.contains("club's repositories"), "{}", club.body); assert!(get(app, "/orgs/club/settings", Some(&andy)).await.body.contains("/orgs/club/settings/backups")); // Admin › Backups (docs/backups.md §5): whether each ran, and who has // none; administrators only. sqlx::query("UPDATE accounts SET is_admin = (username = 'andy')").execute(&app.db).await.unwrap(); app.repos.create(&oxygenhub::repos::RepoName::parse("bob/game").unwrap(), None).unwrap(); db::repos::create(&app.db, "bob", "game", "", hub_api::Visibility::Public).await.unwrap(); assert_eq!(get(app, "/admin/backups", Some(&bob)).await.status, StatusCode::NOT_FOUND); let admin = get(app, "/admin/backups", Some(&andy)).await; assert_eq!(admin.status, StatusCode::OK); assert!(admin.body.contains("gs://andy-backup") && admin.body.contains("hourly") && admin.body.contains("never"), "{}", admin.body); let missing = &admin.body[admin.body.find("Not backed up").unwrap()..]; assert!(missing.contains("href=\"/bob\"") && missing.contains("1 repository"), "{missing}"); assert!(get(app, "/admin", Some(&andy)).await.body.contains("/admin/backups")); // A repository chooses its own (BP3): its owners decide. let game = get(app, "/bob/game/settings", Some(&bob)).await; assert!(game.body.contains("bob has no backup set up yet") && game.body.contains(r#"name="backup" value="" checked"#), "{}", game.body); let csrf = csrf_of(&game.body); let saved = post(app, "/bob/game/settings/backup", Some(&bob), &format!("_csrf={csrf}&backup=off")).await; assert!(saved.body.contains("left out of its owner"), "{}", saved.body); assert_eq!(db::repos::get(&app.db, "bob", "game").await.unwrap().unwrap().backup, "off"); let bad = post(app, "/bob/game/settings/backup", Some(&bob), &format!("_csrf={csrf}&backup=weekly")).await; assert!(bad.body.contains("Pick how this repository is backed up.")); } /// oxygenhub#183: an owner hears about their repository by default, until /// they mute it; what an agent does with a token its owner marked is told /// to that owner; the administrators hear of each new account. #[tokio::test(flavor = "multi_thread")] async fn owners_hear_by_default_and_agents_tell_their_owner() { let h = hub().await; let app = &h.app; let andy = register(app, "andy").await; let bob = register(app, "bob").await; let andy_id = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id; let kinds = |id: i64| { let db = app.db.clone(); async move { db::notify::inbox(&db, id, 50).await.unwrap().into_iter().map(|n| (n.kind, n.title, n.actor)).collect::>() } }; assert!(kinds(andy_id).await.iter().any(|(k, t, _)| k == "account.registered" && t.contains("bob")), "the administrator hears of bob"); let repo = RepoName::parse("andy/demo").unwrap(); app.repos.create(&repo, None).unwrap(); db::repos::create(&app.db, "andy", "demo", "", hub_api::Visibility::Public).await.unwrap(); let open = |who: &'static str, title: &'static str| { let (app, cookie) = (app.clone(), if who == "bob" { bob.clone() } else { andy.clone() }); async move { let csrf = csrf_of(&get(&app, "/andy/demo/issues/new", Some(&cookie)).await.body); post(&app, "/andy/demo/issues/new", Some(&cookie), &format!("_csrf={csrf}&title={title}&body=x")).await } }; // Andy never pressed Watch, but owns it: he hears of bob's issue. assert!(get(app, "/andy/demo", Some(&andy)).await.body.contains("UNWATCH"), "an owner watches by default"); open("bob", "First").await; assert!(kinds(andy_id).await.iter().any(|(k, t, _)| k == "issue.opened" && t.contains("First"))); // Muted, he does not. let csrf = csrf_of(&get(app, "/andy/demo", Some(&andy)).await.body); post(app, "/andy/demo/watch", Some(&andy), &format!("_csrf={csrf}")).await; assert!(get(app, "/andy/demo", Some(&andy)).await.body.contains(">WATCH<"), "muted"); open("bob", "Second").await; assert!(!kinds(andy_id).await.iter().any(|(_, t, _)| t.contains("Second"))); post(app, "/andy/demo/watch", Some(&andy), &format!("_csrf={csrf}")).await; // His own doing is not told to him; his agent's is. let token = |agent: bool| { let db = app.db.clone(); async move { let (t, hash) = oxygenhub::auth::new_token(); db::accounts::create_token(&db, andy_id, if agent { "Claude" } else { "laptop" }, &hash, "repo:read,repo:write", "", None) .await .unwrap(); if agent { let id = db::accounts::token_by_hash(&db, &hash).await.unwrap().unwrap().id; db::accounts::set_token_agent(&db, andy_id, id, true).await.unwrap(); } t } }; let api_issue = |t: String, title: &'static str| { let app = app.clone(); async move { use tower::ServiceExt; let req = axum::http::Request::post("/api/v1/repos/andy/demo/issues") .header("authorization", format!("Bearer {t}")) .header("content-type", "application/json") .body(axum::body::Body::from(serde_json::json!({ "title": title, "body": "" }).to_string())) .unwrap(); oxygenhub::router(app).oneshot(req).await.unwrap().status() } }; assert_eq!(api_issue(token(false).await, "By hand").await, StatusCode::CREATED); assert!(!kinds(andy_id).await.iter().any(|(_, t, _)| t.contains("By hand")), "his own doing"); assert_eq!(api_issue(token(true).await, "By the agent").await, StatusCode::CREATED); let told = kinds(andy_id).await; let agent = told.iter().find(|(_, t, _)| t.contains("By the agent")).expect("told of his agent's issue"); assert_eq!(agent.2, "andy (agent token Claude)"); // The tokens page marks and unmarks one. let page = get(app, "/settings/tokens", Some(&andy)).await; assert!(page.body.contains("Not an agent") && page.body.contains("Mark as agent"), "{}", page.body); assert!(page.body.contains(r#"