//! Milestone 0.2 end to end: registration, sessions, tokens, roles and //! visibility, linked identities with attribution, organisations. use axum::body::Body; use axum::http::{header, Request, StatusCode}; use http_body_util::BodyExt; use oxy_core::repo::Repo; use oxygenhub::config::Config; use oxygenhub::db; use oxygenhub::Shared; use std::path::Path; use tower::ServiceExt; fn hermetic() { static ONCE: std::sync::Once = std::sync::Once::new(); static DIR: std::sync::OnceLock = std::sync::OnceLock::new(); ONCE.call_once(|| { let d = tempfile::tempdir().unwrap(); std::env::set_var("OXY_HOME", d.path()); DIR.set(d).ok(); }); } fn write(root: &Path, rel: &str, content: &[u8]) { let p = root.join(rel); std::fs::create_dir_all(p.parent().unwrap()).unwrap(); std::fs::write(p, content).unwrap(); } struct Hub { app: Shared, base: String, _dir: tempfile::TempDir, } async fn hub() -> Hub { hermetic(); let dir = tempfile::tempdir().unwrap(); let mut config = Config::load(dir.path()).unwrap(); // The first account's setup code (oxygenhub#245). config.registration.setup_code = "test-setup".into(); let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap(); let port = listener.local_addr().unwrap().port(); config.server.base_url = format!("http://127.0.0.1:{port}"); // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219). config.outbound.allow = vec!["http://127.0.0.1".into()]; config.registration.mode = "invite".into(); let app = oxygenhub::build(config).await.unwrap(); let router = oxygenhub::router(app.clone()); tokio::spawn(async move { axum::serve(listener, router).await.unwrap() }); Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir } } struct Res { status: StatusCode, body: String, /// The session cookie's value, when the response set one. cookie: Option, location: Option, /// Every Set-Cookie header, whole. raw_cookies: Vec, } async fn send(app: &Shared, method: &str, path: &str, cookie: Option<&str>, form: Option<&str>) -> Res { let header_value = cookie.map(|c| format!("oxyhub={c}")); send_with(app, method, path, header_value.as_deref(), form).await } /// As `send`, with the whole Cookie header given. async fn send_with(app: &Shared, method: &str, path: &str, cookie_header: Option<&str>, form: Option<&str>) -> Res { let mut req = Request::builder().method(method).uri(path); if let Some(c) = cookie_header { req = req.header(header::COOKIE, c.to_string()); } let body = match form { Some(f) => { req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded"); Body::from(f.to_string()) } None => Body::empty(), }; let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap(); let status = res.status(); let raw_cookies: Vec = res.headers().get_all(header::SET_COOKIE).iter().filter_map(|v| v.to_str().ok()).map(String::from).collect(); let cookie = raw_cookies.iter().filter_map(|c| c.split(';').next()).filter_map(|kv| kv.strip_prefix("oxyhub=")).map(String::from).next(); let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from); let bytes = res.into_body().collect().await.unwrap().to_bytes(); Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location, raw_cookies } } async fn get(app: &Shared, path: &str, cookie: Option<&str>) -> Res { send(app, "GET", path, cookie, None).await } async fn post(app: &Shared, path: &str, cookie: Option<&str>, form: &str) -> Res { send(app, "POST", path, cookie, Some(form)).await } /// A repository settings form's answer (#278): a redirect to the page that /// holds the form, followed. async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res { assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body); let to = r.location.expect("a redirect"); assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}"); get(app, &to, cookie).await } /// Register (or sign in) and return the session cookie value. async fn register(app: &Shared, user: &str, invite: &str) -> String { let r = post( app, "/register", None, &format!("username={user}&email={user}%40example.com&password=correct-horse-battery&setup=test-setup&invite={invite}"), ) .await; assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body); r.cookie.expect("session cookie") } /// Upload an identity under Settings › Keys; the page it answers with. async fn upload_identity(app: &Shared, cookie: &str, csrf: &str, object: &[u8]) -> String { let boundary = "XYZ"; let mut multipart = Vec::new(); multipart.extend_from_slice(format!("--{boundary}\r\nContent-Disposition: form-data; name=\"_csrf\"\r\n\r\n{csrf}\r\n").as_bytes()); multipart.extend_from_slice(format!("--{boundary}\r\nContent-Disposition: form-data; name=\"identity\"; filename=\"me.identity\"\r\nContent-Type: application/octet-stream\r\n\r\n").as_bytes()); multipart.extend_from_slice(object); multipart.extend_from_slice(format!("\r\n--{boundary}--\r\n").as_bytes()); let req = Request::builder() .method("POST") .uri("/settings/keys/upload") .header(header::COOKIE, format!("oxyhub={cookie}")) .header(header::CONTENT_TYPE, format!("multipart/form-data; boundary={boundary}")) .body(Body::from(multipart)) .unwrap(); let res = oxygenhub::router(app.clone()).oneshot(req).await.unwrap(); assert_eq!(res.status(), StatusCode::OK); String::from_utf8_lossy(&res.into_body().collect().await.unwrap().to_bytes()).into_owned() } fn csrf_of(page: &str) -> String { let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len(); page[i..].split('"').next().unwrap().to_string() } #[tokio::test(flavor = "multi_thread")] async fn accounts_roles_tokens_and_attribution() { let h = hub().await; let app = &h.app; // The first account registers without an invitation and is the administrator. let andy = register(app, "andy", "").await; let me = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap(); assert!(me.is_admin); // A second registration needs an invitation. let r = post(app, "/register", None, "username=mallory&email=m%40example.com&password=correct-horse-battery&setup=test-setup&invite=") .await; assert_eq!(r.status, StatusCode::OK); assert!(r.body.contains("invitation"), "{}", r.body); let admin_page = get(app, "/admin", Some(&andy)).await; assert_eq!(admin_page.status, StatusCode::OK); let csrf = csrf_of(&admin_page.body); let r = post(app, "/admin/invite", Some(&andy), &format!("_csrf={csrf}")).await; let code = r.body.split("register?invite=").nth(1).unwrap().split('<').next().unwrap().trim().to_string(); let bob = register(app, "bob", &code).await; assert!(!db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().is_admin); // Wrong password, banned users and CSRF-less posts are refused. assert_eq!(post(app, "/login", None, "username=andy&password=nope").await.status, StatusCode::OK); assert_eq!(post(app, "/settings", Some(&andy), "_csrf=bogus&display_name=x&email=y").await.status, StatusCode::BAD_REQUEST); assert_eq!(get(app, "/settings", None).await.status, StatusCode::SEE_OTHER, "anonymous settings redirects to sign in"); // Andy creates a private repository through the form; Bob cannot see it. let new_page = get(app, "/new", Some(&andy)).await; let csrf = csrf_of(&new_page.body); let r = post(app, "/new", Some(&andy), &format!("_csrf={csrf}&owner=andy&name=secret&description=hush&visibility=private")).await; assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body); assert_eq!(get(app, "/andy/secret", Some(&andy)).await.status, StatusCode::OK); assert_eq!(get(app, "/andy/secret", Some(&bob)).await.status, StatusCode::NOT_FOUND); assert_eq!(get(app, "/andy/secret", None).await.status, StatusCode::NOT_FOUND); assert!(!get(app, "/", Some(&bob)).await.body.contains("secret")); assert!(get(app, "/", Some(&andy)).await.body.contains("secret")); // Tokens: a read-only token cannot push; a write token can. Anonymous cannot read a private repository. let tokens_page = get(app, "/settings/tokens", Some(&andy)).await; let csrf = csrf_of(&tokens_page.body); let r = post(app, "/settings/tokens", Some(&andy), &format!("_csrf={csrf}&name=ro&scopes=repo%3Aread")).await; let ro = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap(); let r = post(app, "/settings/tokens", Some(&andy), &format!("_csrf={csrf}&name=rw&scopes=repo%3Aread&scopes=repo%3Awrite")).await; let rw = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap(); let work = tempfile::tempdir().unwrap(); let mut client = Repo::init(work.path()).unwrap(); client.create_identity("Andy McCall", "andy@example.com", oxy_core::repo::IdentityScope::User).unwrap(); client.config.set("remote.origin.url", &format!("{}/andy/secret", h.base)).unwrap(); client.config.set("core.sign", "change").unwrap(); client.save_config().unwrap(); write(work.path(), "a.txt", b"a\n"); client.snapshot("t").unwrap(); let c1 = client.commit("first", &[]).unwrap(); let err = client.push("origin", false).err().unwrap().to_string(); assert!(err.contains("404"), "anonymous cannot even see it: {err}"); client.config.set("remote.origin.token", &ro).unwrap(); let err = client.push("origin", false).err().unwrap().to_string(); assert!(err.contains("403"), "read-only token cannot push: {err}"); client.config.set("remote.origin.token", &rw).unwrap(); assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok)); // Bob's token cannot read it either. let bob_tokens = get(app, "/settings/tokens", Some(&bob)).await; let csrf_b = csrf_of(&bob_tokens.body); let r = post(app, "/settings/tokens", Some(&bob), &format!("_csrf={csrf_b}&name=b&scopes=repo%3Aread&scopes=repo%3Awrite")).await; let bob_tok = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap(); std::env::set_var("OXY_TOKEN", &bob_tok); let err = Repo::clone(&format!("{}/andy/secret", h.base), &work.path().join("bobclone")).err().unwrap().to_string(); std::env::remove_var("OXY_TOKEN"); assert!(err.contains("404"), "{err}"); // The push log names the pusher. tokio::time::sleep(std::time::Duration::from_millis(150)).await; let pushes = get(app, "/andy/secret/pushes", Some(&andy)).await.body; assert!(pushes.contains("andy"), "{pushes}"); // Bob becomes a collaborator with write, and can then see and push. let settings = get(app, "/andy/secret/settings", Some(&andy)).await; assert_eq!(settings.status, StatusCode::OK); let csrf = csrf_of(&settings.body); let r = post(app, "/andy/secret/settings/collaborators", Some(&andy), &format!("_csrf={csrf}&username=bob&role=write")).await; let r = settled(app, r, Some(&andy), "/andy/secret/settings/collaborators").await; assert!(r.body.contains("bob now has write access."), "{}", r.body); assert_eq!(get(app, "/andy/secret", Some(&bob)).await.status, StatusCode::OK); assert_eq!(get(app, "/andy/secret/settings", Some(&bob)).await.status, StatusCode::NOT_FOUND, "write is not maintain"); std::env::set_var("OXY_TOKEN", &bob_tok); let ok = Repo::clone(&format!("{}/andy/secret", h.base), &work.path().join("bobclone2")).is_ok(); std::env::remove_var("OXY_TOKEN"); assert!(ok); // oxygen#47: signed in once (oxy auth login), a private repository // clones with no OXY_TOKEN, and the clone keeps no token of its own. let store = oxy_core::credentials::Credentials::user(); let hub = oxy_core::credentials::hub_of(&h.base).unwrap(); store.save(&hub, &rw, Some("andy"), None).unwrap(); let signed_in = Repo::clone(&format!("{}/andy/secret", h.base), &work.path().join("signedin")); store.remove(&hub).unwrap(); let signed_in = signed_in.unwrap(); assert!(signed_in.config.remote_tokens.is_empty()); assert_eq!(signed_in.bookmark_heads().unwrap(), vec![c1]); // Linking a key: upload the identity, sign the challenge, see attribution. let (key, identity) = { let k = client.config.author_key.unwrap(); (k, client.identity(&k).unwrap()) }; let keys_page = get(app, "/settings/keys", Some(&andy)).await; let csrf = csrf_of(&keys_page.body); let body = upload_identity(app, &andy, &csrf, &identity.encode()).await; let challenge_hex = body.split("sign-challenge ").nth(1).unwrap().split('<').next().unwrap().trim().to_string(); let challenge_id = body.split("name=\"challenge\" value=\"").nth(1).unwrap().split('"').next().unwrap().to_string(); let (_, sk) = client.secret_key().unwrap().unwrap(); let sig = sk.sign_challenge(&key, &hex::decode(&challenge_hex).unwrap()).unwrap(); let sig_hex = hex::encode(oxy_core::identity::Signature::encode_list(&[sig])); let r = post(app, "/settings/keys/verify", Some(&andy), &format!("_csrf={csrf}&challenge={challenge_id}&signature={sig_hex}")).await; assert!(r.body.contains("Key linked"), "{}", r.body); // oxygenhub#286: a linked key is "last used" when a push it signed is // accepted. let keys = get(app, "/settings/keys", Some(&andy)).await.body; assert!(keys.contains("last used never") && keys.contains("never expires"), "{keys}"); write(work.path(), "b.txt", b"b\n"); client.snapshot("t").unwrap(); client.commit("second", &[]).unwrap(); assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok)); let mut used = String::new(); for _ in 0..100 { used = get(app, "/settings/keys", Some(&andy)).await.body; if !used.contains("last used never") { break; } tokio::time::sleep(std::time::Duration::from_millis(50)).await; } assert!(used.contains("last used Andy McCall"), "author linked to the account: {hist}"); let change = get(app, &format!("/andy/secret/change/{}", c1.to_hex()), Some(&andy)).await.body; assert!(change.contains("@andy"), "{change}"); // A forged signature is refused. let r = post(app, "/settings/keys/verify", Some(&andy), &format!("_csrf={csrf}&challenge=999&signature={sig_hex}")).await; assert!(r.body.contains("expired"), "{}", r.body); // oxygenhub#281: the hub's own key is refused with what to upload // instead, and a challenge signed by another key names both keys. let body = upload_identity(app, &andy, &csrf, &app.hub_key.identity.encode()).await; assert!(body.contains("this hub's own key") || body.contains("this hub's own key"), "{body}"); assert!(!body.contains("sign-challenge "), "no challenge for the hub's key: {body}"); let other = oxy_core::identity::SecretKey::generate().identity("Other", "other@example.com", 1); let body = upload_identity(app, &andy, &csrf, &other.encode()).await; let challenge_hex = body.split("sign-challenge ").nth(1).unwrap().split('<').next().unwrap().trim().to_string(); let challenge_id = body.split("name=\"challenge\" value=\"").nth(1).unwrap().split('"').next().unwrap().to_string(); let sig = sk.sign_challenge(&key, &hex::decode(&challenge_hex).unwrap()).unwrap(); let sig_hex = hex::encode(oxy_core::identity::Signature::encode_list(&[sig])); let r = post(app, "/settings/keys/verify", Some(&andy), &format!("_csrf={csrf}&challenge={challenge_id}&signature={sig_hex}")).await; assert!( r.body.contains(&format!("That signature is by key {}", key.short(12))) && r.body.contains(&other.hash().short(12)), "{}", r.body ); // Organisations: a private org repository is visible to members through the default role. let org_page = get(app, "/orgs/new", Some(&andy)).await; let csrf = csrf_of(&org_page.body); let r = post(app, "/orgs/new", Some(&andy), &format!("_csrf={csrf}&name=acme&display_name=Acme")).await; assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body); let new_page = get(app, "/new", Some(&andy)).await; let csrf = csrf_of(&new_page.body); assert_eq!( post(app, "/new", Some(&andy), &format!("_csrf={csrf}&owner=acme&name=plans&visibility=private")).await.status, StatusCode::SEE_OTHER ); assert_eq!(get(app, "/acme/plans", Some(&bob)).await.status, StatusCode::NOT_FOUND); let org_settings = get(app, "/orgs/acme/settings", Some(&andy)).await; let csrf = csrf_of(&org_settings.body); assert_eq!( post(app, "/orgs/acme/settings/members", Some(&andy), &format!("_csrf={csrf}&username=bob&role=member")).await.status, StatusCode::OK ); assert_eq!(get(app, "/acme/plans", Some(&bob)).await.status, StatusCode::OK, "members read by default"); assert_eq!(get(app, "/orgs/acme/settings", Some(&bob)).await.status, StatusCode::NOT_FOUND, "members do not administer"); // Bob cannot create under acme's... he can, as a member; a stranger cannot. let r = post( app, "/new", Some(&bob), &format!("_csrf={}&owner=acme&name=bobs&visibility=public", csrf_of(&get(app, "/new", Some(&bob)).await.body)), ) .await; assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body); // Sign out everywhere invalidates the old cookie. let sec = get(app, "/settings/security", Some(&andy)).await; let csrf = csrf_of(&sec.body); let r = post(app, "/settings/security/sessions", Some(&andy), &format!("_csrf={csrf}")).await; assert_eq!(r.status, StatusCode::SEE_OTHER); assert_eq!(get(app, "/settings", Some(&andy)).await.status, StatusCode::SEE_OTHER, "old session is gone"); let fresh = r.cookie.unwrap(); assert_eq!(get(app, "/settings", Some(&fresh)).await.status, StatusCode::OK); // TOTP: enable with the current code, then sign in needs it. let sec = get(app, "/settings/security", Some(&fresh)).await; let csrf = csrf_of(&sec.body); let r = post(app, "/settings/security/totp/begin", Some(&fresh), &format!("_csrf={csrf}")).await; let secret = r.body.split("name=\"secret\" value=\"").nth(1).unwrap().split('"').next().unwrap().to_string(); let now = (db::now_ms() / 1000) as u64; let code = oxygenhub::auth::totp::current(&secret, now).unwrap(); let r = post(app, "/settings/security/totp/enable", Some(&fresh), &format!("_csrf={csrf}&secret={secret}&code={code}")).await; assert!(r.body.contains("Recovery codes"), "{}", r.body); let r = post(app, "/login", None, "username=andy&password=correct-horse-battery&setup=test-setup").await; assert!(r.body.contains("authenticator"), "second step asked: {}", r.body); // Submit the second step as a browser would: every field of the // rendered form, each name once (a repeated name is refused). let form = &r.body[r.body.find("
").unwrap()..]; let form = &form[..form.find("
").unwrap()]; let names: Vec<&str> = form.split("name=\"").skip(1).map(|t| t.split('"').next().unwrap()).collect(); let mut unique = names.clone(); unique.sort(); unique.dedup(); assert_eq!(unique.len(), names.len(), "a field named twice: {names:?}"); // The code step asks for the code alone: the password is not typed // again, the step carries proof of it instead. assert!(!names.contains(&"password"), "{names:?}"); let pending = form.split("name=\"pending\" value=\"").nth(1).unwrap().split('"').next().unwrap().to_string(); let code = oxygenhub::auth::totp::current(&secret, (db::now_ms() / 1000) as u64).unwrap(); let fill = |pending: &str| -> String { names .iter() .map(|n| match *n { "username" => "username=andy".to_string(), "pending" => format!("pending={pending}"), "code" => format!("code={code}"), other => format!("{other}="), }) .collect::>() .join("&") }; // A forged or stale proof starts again. let r = post(app, "/login", None, &fill("1.forged")).await; assert!(r.body.contains("sign in again") && r.cookie.is_none(), "{}", r.body); let r = post(app, "/login", None, &fill(&pending)).await; assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body); assert!(r.cookie.is_some()); assert!(r.location.as_deref() == Some("/")); } /// A multipart picture form. fn picture_form(csrf: &str, action: &str, file: &[u8]) -> (String, Vec) { let boundary = "picture-boundary-1234"; let mut body = Vec::new(); body.extend_from_slice(format!("--{boundary}\r\nContent-Disposition: form-data; name=\"_csrf\"\r\n\r\n{csrf}\r\n").as_bytes()); body.extend_from_slice(format!("--{boundary}\r\nContent-Disposition: form-data; name=\"action\"\r\n\r\n{action}\r\n").as_bytes()); body.extend_from_slice( format!("--{boundary}\r\nContent-Disposition: form-data; name=\"picture\"; filename=\"me.png\"\r\nContent-Type: image/png\r\n\r\n") .as_bytes(), ); body.extend_from_slice(file); body.extend_from_slice(format!("\r\n--{boundary}--\r\n").as_bytes()); (format!("multipart/form-data; boundary={boundary}"), body) } async fn upload(app: &Shared, path: &str, cookie: &str, csrf: &str, action: &str, file: &[u8]) -> Res { let (ct, body) = picture_form(csrf, action, file); let req = Request::post(path) .header(header::COOKIE, format!("oxyhub={cookie}")) .header(header::CONTENT_TYPE, ct) .body(Body::from(body)) .unwrap(); let res = oxygenhub::router(app.clone()).oneshot(req).await.unwrap(); let status = res.status(); let bytes = res.into_body().collect().await.unwrap().to_bytes(); Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie: None, location: None, raw_cookies: vec![] } } /// Status, content type and bytes of a picture. async fn picture(app: &Shared, name: &str) -> (StatusCode, String, Vec) { let res = oxygenhub::router(app.clone()).oneshot(Request::get(format!("/avatar/{name}")).body(Body::empty()).unwrap()).await.unwrap(); let ct = res.headers().get(header::CONTENT_TYPE).and_then(|v| v.to_str().ok()).unwrap_or("").to_string(); let status = res.status(); (status, ct, res.into_body().collect().await.unwrap().to_bytes().to_vec()) } fn png(w: u32, h: u32, alpha: bool) -> Vec { let img = if alpha { image::DynamicImage::ImageRgba8(image::RgbaImage::from_fn(w, h, |x, _| { image::Rgba([0, 114, 255, if x % 2 == 0 { 0 } else { 255 }]) })) } else { image::DynamicImage::ImageRgb8(image::RgbImage::from_fn(w, h, |x, y| image::Rgb([x as u8, y as u8, 128]))) }; let mut out = Vec::new(); img.write_to(&mut std::io::Cursor::new(&mut out), image::ImageFormat::Png).unwrap(); out } /// Repository settings (oxygenhub#278): one page per setting beside a /// grouped sidebar that marks the page shown; a role sees only its pages /// and the others are not found; each form returns to the page holding it. #[tokio::test(flavor = "multi_thread")] async fn repository_settings_are_a_page_each_by_role() { let h = hub().await; let app = &h.app; let andy = register(app, "andy", "").await; let mut invited = vec![]; for name in ["bob", "carol"] { let csrf = csrf_of(&get(app, "/admin", Some(&andy)).await.body); let r = post(app, "/admin/invite", Some(&andy), &format!("_csrf={csrf}")).await; let code = r.body.split("register?invite=").nth(1).unwrap().split('<').next().unwrap().trim().to_string(); invited.push(register(app, name, &code).await); } let (bob, carol) = (invited[0].clone(), invited[1].clone()); let csrf = csrf_of(&get(app, "/new", Some(&andy)).await.body); let r = post(app, "/new", Some(&andy), &format!("_csrf={csrf}&owner=andy&name=demo&visibility=public")).await; assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body); let csrf = csrf_of(&get(app, "/andy/demo/settings", Some(&andy)).await.body); for (who, role) in [("bob", "maintain"), ("carol", "write")] { let r = post(app, "/andy/demo/settings/collaborators", Some(&andy), &format!("_csrf={csrf}&username={who}&role={role}")).await; let page = settled(app, r, Some(&andy), "/andy/demo/settings/collaborators").await; assert!(page.body.contains(&format!("{who} now has {role} access.")), "{}", page.body); } let marked = |slug: &str| format!("href=\"/andy/demo/settings/{slug}\" data-slug=\"{slug}\" class=\"on\" aria-current=\"page\""); let maintainers = ["general", "landing", "checks", "push-protection", "flow", "runs", "gates", "coverage", "git-mirror", "diffusion", "backup"]; let admins = ["collaborators", "runners", "variables", "secrets", "webhooks", "assistants", "advanced"]; // /settings is General, marked in the sidebar, with the groups' headings. let general = get(app, "/andy/demo/settings", Some(&andy)).await; assert_eq!(general.status, StatusCode::OK); assert!(general.body.contains(&marked("general")) && general.body.contains("id=\"general\""), "{}", general.body); for group in ["General", "Code", "Flow", "Integrations", "Data", "Danger zone"] { assert!(general.body.contains(&format!("

{group}

")), "group {group}"); } assert!(general.body.contains("data-settings-anchors"), "kept #anchor links are sent on from General"); // Every page renders for an admin, marked; one page's sections only. for slug in maintainers.iter().chain(admins.iter()) { let page = get(app, &format!("/andy/demo/settings/{slug}"), Some(&andy)).await; assert_eq!(page.status, StatusCode::OK, "{slug}"); assert!(page.body.contains(&marked(slug)), "{slug} is marked: {}", page.body); for other in maintainers.iter().chain(admins.iter()).filter(|o| *o != slug) { assert!(!page.body.contains(&marked(other)), "{slug} marks {other}"); } } let runs = get(app, "/andy/demo/settings/runs", Some(&andy)).await.body; assert!( runs.contains("id=\"flow-priority\"") && runs.contains("id=\"flow-supersede\"") && runs.contains("id=\"flow-skip\"") && !runs.contains("id=\"general\"") ); // Storage is only for a repository kept in a bucket. assert_eq!(get(app, "/andy/demo/settings/storage", Some(&andy)).await.status, StatusCode::NOT_FOUND); assert!(!general.body.contains("/andy/demo/settings/storage\"")); assert_eq!(get(app, "/andy/demo/settings/nope", Some(&andy)).await.status, StatusCode::NOT_FOUND); // A maintainer has the maintainers' pages only; the admins' are not // listed and not found. let page = get(app, "/andy/demo/settings", Some(&bob)).await; assert_eq!(page.status, StatusCode::OK); for slug in maintainers { assert_eq!(get(app, &format!("/andy/demo/settings/{slug}"), Some(&bob)).await.status, StatusCode::OK, "{slug}"); assert!(page.body.contains(&format!("data-slug=\"{slug}\"")), "{slug} listed"); } for slug in admins { assert_eq!(get(app, &format!("/andy/demo/settings/{slug}"), Some(&bob)).await.status, StatusCode::NOT_FOUND, "{slug}"); assert!(!page.body.contains(&format!("data-slug=\"{slug}\"")), "{slug} not listed"); } assert!(!page.body.contains("

Danger zone

"), "an empty group is left out"); let bob_csrf = csrf_of(&page.body); let r = post(app, "/andy/demo/settings/flow-priority", Some(&bob), &format!("_csrf={bob_csrf}&priority=normal")).await; let back = settled(app, r, Some(&bob), "/andy/demo/settings/runs").await; assert!(back.body.contains("Its jobs are normal priority.") && back.body.contains(&marked("runs")), "{}", back.body); // A writer has none of them. assert_eq!(get(app, "/andy/demo/settings", Some(&carol)).await.status, StatusCode::NOT_FOUND); for slug in ["general", "push-protection", "advanced"] { assert_eq!(get(app, &format!("/andy/demo/settings/{slug}"), Some(&carol)).await.status, StatusCode::NOT_FOUND, "{slug}"); } // Each form returns to its own page, with what happened. for (path, form, page, says) in [ ("", "description=Demo&default_bookmark=main&visibility=public&topics=", "general", "Saved."), ("/requirements", "required_approvals=1", "landing", "Landing requirements saved."), ("/checks", "required_checks=build", "checks", "Required checks saved."), ("/push-protection", "", "push-protection", "Push protection is off"), ("/push-protection", "protect=on", "push-protection", "Push protection is on"), ("/secret-bypass", "fingerprint=0123456789abcdef&reason=a+test+fixture", "push-protection", "is allowed here"), ("/flow", "flow=sometimes", "flow", "Pick on, own runners, off or the site default."), ("/flow-priority", "priority=low", "runs", "Its jobs are low priority."), ("/flow-supersede", "running=on", "runs", "cancels the older runs it supersedes, queued or running"), ("/flow-skip", "skip=others", "runs", "skip its run on any bookmark but main"), ("/flow-skip", "skip=sometimes", "runs", "Choose where a push may skip its run."), ("/agent-gates", "agents=on", "gates", "may now approve or reject"), ("/variables", "action=set&name=RUST_LOG&value=debug", "variables", "RUST_LOG set."), ("/coverage", "min=80&max_drop=", "coverage", "Coverage rules saved"), ("/hooks", "action=delete&id=999", "webhooks", "Webhook deleted."), ("/mirror", "", "git-mirror", "The Git mirror is off."), ("/diffusion", "diffusion=off&land=propose", "diffusion", "Diffusion is off"), ("/backup", "backup=off", "backup", "left out of its owner"), ("/archive", "action=neither", "advanced", "Unknown action."), ] { let r = post(app, &format!("/andy/demo/settings{path}"), Some(&andy), &format!("_csrf={csrf}&{form}")).await; let back = settled(app, r, Some(&andy), &format!("/andy/demo/settings/{page}")).await; assert_eq!(back.status, StatusCode::OK, "{path}"); assert!(back.body.contains(says) && back.body.contains(&marked(page)), "{path}: {}", back.body); } // A kept /settings#anchor link is sent on by hub.js, never inline. let js = get(app, "/static/hub.js", None).await.body; assert!(js.contains("[data-settings-anchors]") && js.contains("\"flow-priority\": \"runs\""), "{js}"); } #[tokio::test(flavor = "multi_thread")] async fn profile_pictures_and_logos() { let h = hub().await; let app = &h.app; let andy = register(app, "andy", "").await; assert_eq!(picture(app, "andy").await.1, "image/svg+xml", "the identicon first"); let csrf = csrf_of(&get(app, "/settings", Some(&andy)).await.body); assert!(get(app, "/settings", Some(&andy)).await.body.contains("id=\"picture\"")); // A photo: cropped, scaled and re-encoded as JPEG. let r = upload(app, "/settings/avatar", &andy, &csrf, "upload", &png(640, 480, false)).await; assert!(r.body.contains("Picture saved"), "{}", r.body); let (st, ct, bytes) = picture(app, "andy").await; assert_eq!((st, ct.as_str()), (StatusCode::OK, "image/jpeg")); let img = image::load_from_memory(&bytes).unwrap(); assert_eq!((img.width(), img.height()), (400, 400)); let stored = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().avatar; assert!(stored.starts_with("jpeg:"), "{stored}"); // Not an image, or no CSRF: refused, and the picture stays. let r = upload( app, "/settings/avatar", &andy, &csrf, "upload", b"", ) .await; assert!(r.body.contains("not a PNG, JPEG or WebP"), "{}", r.body); let r = upload(app, "/settings/avatar", &andy, "wrong", "upload", &png(10, 10, false)).await; assert_ne!(r.status, StatusCode::OK); assert_eq!(picture(app, "andy").await.1, "image/jpeg"); // Removing brings the identicon back. let r = upload(app, "/settings/avatar", &andy, &csrf, "remove", b"").await; assert!(r.body.contains("Picture removed")); assert_eq!(picture(app, "andy").await.1, "image/svg+xml"); // An organisation's logo keeps its transparency; only owners may set it. let me = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap(); db::accounts::create_org(&app.db, "acme", "Acme", me.id).await.unwrap(); let org_csrf = csrf_of(&get(app, "/orgs/acme/settings", Some(&andy)).await.body); let r = upload(app, "/orgs/acme/settings/avatar", &andy, &org_csrf, "upload", &png(120, 120, true)).await; assert!(r.body.contains("Picture saved"), "{}", r.body); let (_, ct, bytes) = picture(app, "acme").await; assert_eq!(ct, "image/png"); assert!(image::load_from_memory(&bytes).unwrap().color().has_alpha()); let invite = { let admin = get(app, "/admin", Some(&andy)).await; let r = post(app, "/admin/invite", Some(&andy), &format!("_csrf={}", csrf_of(&admin.body))).await; let i = r.body.find("invite=").map(|i| i + 7).expect("an invitation"); r.body[i..].chars().take_while(|c| c.is_ascii_alphanumeric()).collect::() }; let bob = register(app, "bob", &invite).await; let bob_csrf = csrf_of(&get(app, "/settings", Some(&bob)).await.body); let r = upload(app, "/orgs/acme/settings/avatar", &bob, &bob_csrf, "remove", b"").await; assert_eq!(r.status, StatusCode::NOT_FOUND, "not an owner"); assert_eq!(picture(app, "acme").await.1, "image/png"); } #[tokio::test(flavor = "multi_thread")] async fn organisation_webhooks_and_storage() { let h = hub().await; let app = &h.app; let andy = register(app, "andy", "").await; let me = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap(); let org = db::accounts::create_org(&app.db, "acme", "Acme", me.id).await.unwrap(); // A repository requires one sealed approval by default only where // someone else can give it: an organisation of two or more members // (oxygenhub#64). Acme has one member so far, like a personal account. let alone = db::repos::create(&app.db, "acme", "alone", "", hub_api::Visibility::Public).await.unwrap(); let solo = db::repos::create(&app.db, "andy", "solo", "", hub_api::Visibility::Public).await.unwrap(); assert_eq!(db::proposals::requirements(&app.db, alone.id).await.unwrap().required_approvals, 0); assert_eq!(db::proposals::requirements(&app.db, solo.id).await.unwrap().required_approvals, 0); let bobby = db::accounts::create_account(&app.db, "bobby", "b@example.com", "x", "salt", false).await.unwrap(); db::accounts::set_org_member(&app.db, org.id, bobby.id, "member").await.unwrap(); let tools = db::repos::create(&app.db, "acme", "tools", "", hub_api::Visibility::Public).await.unwrap(); assert_eq!(db::proposals::requirements(&app.db, tools.id).await.unwrap().required_approvals, 1); // Organisation webhooks: add, ping, deliveries; only for this organisation. let page = get(app, "/orgs/acme/settings", Some(&andy)).await; assert!(page.body.contains("id=\"webhooks\"") && page.body.contains("href=\"#webhooks\"")); let csrf = csrf_of(&page.body); let r = post(app, "/orgs/acme/settings/hooks", Some(&andy), &format!("_csrf={csrf}&url=ftp%3A%2F%2Fx&events=*")).await; assert!(r.body.contains("starts with http"), "{}", r.body); let r = post( app, "/orgs/acme/settings/hooks", Some(&andy), &format!("_csrf={csrf}&url=https%3A%2F%2Fhooks.invalid%2Facme&secret=s&events=push"), ) .await; assert!(r.body.contains("Webhook added")); let hooks = db::hooks::hooks_for_org(&app.db, org.id).await.unwrap(); assert_eq!(hooks.len(), 1); let id = hooks[0].id; assert!(post(app, "/orgs/acme/settings/hooks", Some(&andy), &format!("_csrf={csrf}&id={id}&action=ping")) .await .body .contains("Ping queued")); let deliveries = get(app, &format!("/orgs/acme/settings/hooks/{id}/deliveries"), Some(&andy)).await; assert_eq!(deliveries.status, StatusCode::OK); assert!(deliveries.body.contains(">ping<") && deliveries.body.contains("/orgs/acme/settings#webhooks")); // A repository's hook cannot be touched through the organisation's form. let repo = oxygenhub::repos::RepoName::parse("andy/demo").unwrap(); app.repos.create(&repo, None).unwrap(); let row = db::repos::create(&app.db, "andy", "demo", "", hub_api::Visibility::Public).await.unwrap(); let repo_hook = db::hooks::create_hook(&app.db, Some(row.id), None, "https://hooks.invalid/repo", "", "*").await.unwrap().id; post(app, "/orgs/acme/settings/hooks", Some(&andy), &format!("_csrf={csrf}&id={repo_hook}&action=delete")).await; assert!(db::hooks::hook(&app.db, repo_hook).await.unwrap().is_some(), "not the organisation's"); assert_eq!(get(app, &format!("/orgs/acme/settings/hooks/{repo_hook}/deliveries"), Some(&andy)).await.status, StatusCode::NOT_FOUND); // The repository's own settings still manage its hooks (shared code). let rs = get(app, "/andy/demo/settings/webhooks", Some(&andy)).await; assert!(rs.body.contains("https://hooks.invalid/repo") && rs.body.contains("action=\"/andy/demo/settings/hooks\"")); // Storage: sizes and loose objects, and maintenance packs them. let work = tempfile::tempdir().unwrap(); let mut client = Repo::init(work.path()).unwrap(); client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap(); let (token, hash) = oxygenhub::auth::new_token(); db::accounts::create_token(&app.db, me.id, "push", &hash, "repo:write", "", None).await.unwrap(); client.config.set("remote.origin.token", &token).unwrap(); client.save_config().unwrap(); write(work.path(), "a.txt", b"a\n"); client.snapshot("t").unwrap(); client.commit("one", &[]).unwrap(); assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok)); let storage = get(app, "/admin/storage", Some(&andy)).await; assert_eq!(storage.status, StatusCode::OK); assert!(storage.body.contains("href=\"/andy/demo\"")); let loose_before = std::fs::read_dir(app.repos.dir(&repo).join(".oxy/objects/loose")).map(|d| d.count()).unwrap_or(0); assert!(loose_before > 0, "the push left loose objects"); let r = post(app, "/admin/storage", Some(&andy), &format!("_csrf={}&repo=andy%2Fdemo", csrf_of(&storage.body))).await; assert!(r.body.contains("Maintained 1 repository") && r.body.contains("loose objects packed"), "{}", r.body); // Packed: the store has no loose objects; their files stay retired for // an hour, for readers that listed them before the repack (#249). let loose_after = Repo::open(&app.repos.dir(&repo)).unwrap().store().loose_count().unwrap(); assert_eq!(loose_after, 0, "packed"); let audit = db::accounts::audit_rows(&app.db, 20).await.unwrap(); assert!(audit.iter().any(|a| a.action == "admin.gc" && a.target == "andy/demo")); let r = post(app, "/admin/storage", Some(&andy), &format!("_csrf={}&repo=nobody%2Fnone", csrf_of(&storage.body))).await; assert!(r.body.contains("No repository nobody/none")); } /// oxygenhub#81: an admin disables an account (sign-in says so, its session /// and pushes stop) and enables it again; deletes one, refused while it /// owns a repository, after which its name stays retired. #[tokio::test(flavor = "multi_thread")] async fn admins_disable_enable_and_delete_accounts() { let h = hub().await; let app = &h.app; let andy = register(app, "andy", "").await; let invite = |app: Shared, andy: String| async move { let csrf = csrf_of(&get(&app, "/admin", Some(&andy)).await.body); let r = post(&app, "/admin/invite", Some(&andy), &format!("_csrf={csrf}")).await; r.body.split("register?invite=").nth(1).unwrap().split('<').next().unwrap().trim().to_string() }; let bob = register(app, "bob", &invite(app.clone(), andy.clone()).await).await; let act = |who: &'static str, action: &'static str, confirm: &'static str| { let (app, andy) = (app.clone(), andy.clone()); async move { let csrf = csrf_of(&get(&app, "/admin", Some(&andy)).await.body); post(&app, "/admin/account", Some(&andy), &format!("_csrf={csrf}&username={who}&action={action}&confirm={confirm}")).await.body } }; let login = |user: &'static str| { let app = app.clone(); async move { post(&app, "/login", None, &format!("username={user}&password=correct-horse-battery&setup=test-setup")).await } }; // Disabled: sign-in says so, the old session no longer counts. act("bob", "disable", "").await; assert!(db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().disabled); let r = login("bob").await; assert!(r.body.contains("Your account has been disabled"), "{}", r.body); assert!(r.cookie.is_none()); assert_eq!(get(app, "/settings", Some(&bob)).await.status, StatusCode::SEE_OTHER, "the session is refused"); assert!(act("andy", "disable", "").await.contains("Not on yourself")); // Enabled again: sign-in works. act("bob", "enable", "").await; assert_eq!(login("bob").await.status, StatusCode::SEE_OTHER); // Delete: confirmed by name, refused while Bob owns a repository. let bob = login("bob").await.cookie.unwrap(); let csrf = csrf_of(&get(app, "/new", Some(&bob)).await.body); assert_eq!( post(app, "/new", Some(&bob), &format!("_csrf={csrf}&owner=bob&name=keep&visibility=public")).await.status, StatusCode::SEE_OTHER ); assert!(act("bob", "delete", "bo").await.contains("type bob to confirm")); let page = act("bob", "delete", "bob").await; assert!(page.contains("still owns bob/keep"), "{page}"); assert!(db::accounts::account_by_name(&app.db, "bob").await.unwrap().is_some()); let row = db::repos::get(&app.db, "bob", "keep").await.unwrap().unwrap(); db::repos::delete(&app.db, row.id).await.unwrap(); let page = act("bob", "delete", "bob").await; assert!(page.contains("bob deleted"), "{page}"); assert!(db::accounts::account_by_name(&app.db, "bob").await.unwrap().is_none()); assert_eq!(get(app, "/settings", Some(&bob)).await.status, StatusCode::SEE_OTHER); // Its name stays retired. let code = invite(app.clone(), andy.clone()).await; let r = post( app, "/register", None, &format!("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup&invite={code}"), ) .await; assert!(r.body.contains("That name is taken"), "{}", r.body); // The last admin can be neither disabled nor deleted. assert!(act("andy", "delete", "andy").await.contains("Not on yourself")); } /// oxygenhub#89: an admin sets the site's job time limits on Admin → /// Runners → Settings; nobody else can. #[tokio::test(flavor = "multi_thread")] async fn admins_set_the_job_time_limits() { let h = hub().await; let app = &h.app; let andy = register(app, "andy", "").await; let page = get(app, "/admin/runners/settings", Some(&andy)).await; assert_eq!(page.status, StatusCode::OK); assert!(page.body.contains("Job time limits") && page.body.contains("value=\"60\""), "the hub.toml default shows"); let csrf = csrf_of(&page.body); let r = post(app, "/admin/runners/settings", Some(&andy), &format!("_csrf={csrf}&default_minutes=200&max_minutes=120&grace_minutes=5")) .await; assert!(r.body.contains("cannot be longer than the maximum"), "{}", r.body); let r = post(app, "/admin/runners/settings", Some(&andy), &format!("_csrf={csrf}&default_minutes=90&max_minutes=240&grace_minutes=10")) .await; assert!(r.body.contains("Saved."), "{}", r.body); let l = oxygenhub::flow::limits(app).await; assert_eq!((l.default_s, l.max_s, l.grace_ms), (5400, 14400, 600_000)); assert!(get(app, "/admin/runners", Some(&andy)).await.body.contains("href=\"/admin/runners/settings\"")); let code = { let csrf = csrf_of(&get(app, "/admin", Some(&andy)).await.body); let r = post(app, "/admin/invite", Some(&andy), &format!("_csrf={csrf}")).await; r.body.split("register?invite=").nth(1).unwrap().split('<').next().unwrap().trim().to_string() }; let bob = register(app, "bob", &code).await; assert_ne!(get(app, "/admin/runners/settings", Some(&bob)).await.status, StatusCode::OK, "not for others"); } /// Mail settings from the admin page (#101): saved over hub.toml, shown /// with the password masked, a test message sent to the administrator. #[tokio::test(flavor = "multi_thread")] async fn mail_settings_are_saved_masked_and_tested_from_the_admin_page() { let h = hub().await; let app = &h.app; let andy = register(app, "andy", "").await; let page = get(app, "/admin/mail", Some(&andy)).await.body; assert!(page.contains("Mail is off"), "{page}"); let csrf = csrf_of(&page); // A directory store for messages, as hub.toml's file:// would be. let outbox = tempfile::tempdir().unwrap(); let r = post( app, "/admin/mail", Some(&andy), &format!("_csrf={csrf}&smtp=file%3A%2F%2F{}&from=Hub+%3Chub%40example.org%3E", outbox.path().display()), ) .await; assert!(r.body.contains("Mail settings saved") && r.body.contains("Mail is on"), "{}", r.body); assert!(oxygenhub::mail::enabled(app)); let r = post(app, "/admin/mail/test", Some(&andy), &format!("_csrf={csrf}")).await; assert!(r.body.contains("Sent a test message to"), "{}", r.body); let sent: Vec<_> = std::fs::read_dir(outbox.path()).unwrap().flatten().collect(); assert_eq!(sent.len(), 1); let text = std::fs::read_to_string(sent[0].path()).unwrap(); assert!(text.contains("Subject: [") && text.contains("Test message") && text.contains("From: Hub "), "{text}"); // An SMTP URL comes back masked, and a masked value left alone keeps the password. let r = post( app, "/admin/mail", Some(&andy), &format!("_csrf={csrf}&smtp=smtps%3A%2F%2Fhub%3Asecret%40mail.example.org%3A465&from=Hub+%3Chub%40example.org%3E"), ) .await; assert!(r.body.contains("smtps://hub:***@mail.example.org:465") && !r.body.contains("hub:secret"), "{}", r.body); let r = post( app, "/admin/mail", Some(&andy), &format!("_csrf={csrf}&smtp=smtps%3A%2F%2Fhub%3A***%40mail.example.org%3A465&from=Hub+%3Chub%40example.org%3E"), ) .await; assert!(r.body.contains("Mail settings saved"), "{}", r.body); assert_eq!(oxygenhub::mail::settings(app).smtp, "smtps://hub:secret@mail.example.org:465"); // A bad URL is refused; an empty one turns mail off. let r = post(app, "/admin/mail", Some(&andy), &format!("_csrf={csrf}&smtp=mail.example.org&from=x")).await; assert!(r.body.contains("starts with smtp://"), "{}", r.body); let r = post(app, "/admin/mail", Some(&andy), &format!("_csrf={csrf}&smtp=&from=")).await; assert!(r.body.contains("Mail is off"), "{}", r.body); assert!(!oxygenhub::mail::enabled(app)); // Not for everyone. let r = post(app, "/admin/mail", None, &format!("_csrf={csrf}&smtp=&from=")).await; assert_ne!(r.status, StatusCode::OK); // The service panel (oxygenhub#181): Resend asks only for its key, // which is never shown again and is kept when left empty. let from = "from=OxygenHub+%3Cnoreply%40example.org%3E"; let r = post(app, "/admin/mail", Some(&andy), &format!("_csrf={csrf}&service=resend&secret=&{from}")).await; assert!(r.body.contains("Give the Resend API key"), "{}", r.body); let r = post(app, "/admin/mail", Some(&andy), &format!("_csrf={csrf}&service=resend&secret=re_test_key_1&{from}")).await; assert!(r.body.contains("Mail settings saved") && !r.body.contains("re_test_key_1"), "{}", r.body); assert!(r.body.contains(r#"