history_scan tests can hang under PostgreSQL in CI issue #365
closed: completed andymccall opened this · 0 comments
andymccall
In run #537 the test-postgres job on plex-1 hung for about an hour in tests/history_scan.rs: the_scan_resumes_where_its_budget_stopped passed, and the other two tests never finished (no timeout, no output). The same tests passed in the local gate (SQLite and PostgreSQL) and in run #536; a re-run of the job alone passed in a few minutes.
To find: what the two tests wait on under PostgreSQL (a pool connection held across an await, or a lock the scan takes). Either way a hung test should fail after a bound, not hold a runner for an hour: give these tests a timeout.
In run #537 the
test-postgresjob on plex-1 hung for about an hour intests/history_scan.rs:the_scan_resumes_where_its_budget_stoppedpassed, and the other two tests never finished (no timeout, no output). The same tests passed in the local gate (SQLite and PostgreSQL) and in run #536; a re-run of the job alone passed in a few minutes.To find: what the two tests wait on under PostgreSQL (a pool connection held across an await, or a lock the scan takes). Either way a hung test should fail after a bound, not hold a runner for an hour: give these tests a timeout.