Proposals from a bookmark with / in its name issue #62
closed: completed andymccall opened this · 0 comments
andymccall
Feedback item 24 (metalgear): oh proposal create --from feature/16-hud --into develop answers HTTP 400 'The source is a bookmark of this repository, or owner/name:bookmark of a fork.' parse_source (crates/hub/src/web/proposals.rs) accepts a plain source only when it is a single path segment (valid_segment), so every feature/N-name bookmark is refused, and owner/name:bookmark naming this same repository is refused too. Accept any bookmark of the repository by name (check it exists), and this repository's own owner/name:bookmark.
Feedback item 24 (metalgear): oh proposal create --from feature/16-hud --into develop answers HTTP 400 'The source is a bookmark of this repository, or owner/name:bookmark of a fork.' parse_source (crates/hub/src/web/proposals.rs) accepts a plain source only when it is a single path segment (valid_segment), so every feature/N-name bookmark is refused, and owner/name:bookmark naming this same repository is refused too. Accept any bookmark of the repository by name (check it exists), and this repository's own owner/name:bookmark.