OXYGENHUB
# d65cad6bdeb5 oxygenflow / crates / flow-core / src / tests.rs
36.2 KiB · Rust · last changed Sealed approvals: approval { sealed } and the oxygen pin 20 days ago source blame history raw
e0918b88 Andy McCall 1
use crate::*;
2
3
const ROOTFS: &str = "9b5c2a1e8f3d4e7a6b8c9d0e1f2a3b4c5d6e7f8a9b0c1d2e3f4a5b6c7d8e9f0a";
4
5
fn doc(body: &str) -> String {
6
    format!(
7
        "schema-version 1\n\nsandbox \"alpine\" {{\n    runtime \"microvm\"\n    rootfs \"cas://blob/{ROOTFS}\"\n    memory-limit \"512MiB\"\n    cpu-limit 2\n    network \"isolated\"\n}}\n\n{body}"
8
    )
9
}
10
11
fn problems(src: &str) -> Vec<(usize, String)> {
12
    Pipeline::parse(src).unwrap_err().0.into_iter().map(|p| (p.line, p.message)).collect()
13
}
14
15
#[test]
16
fn parses_the_m0_example() {
17
    let p = Pipeline::parse(&doc(r#"job "lint" {
18
    sandbox "alpine"
19
    scope "src/**" "README.md"
20
    env {
21
        LANG "C.UTF-8"
22
    }
23
    exec "grep" "-rn" "TODO" "src"
24
}
25
26
job "test" {
27
    sandbox "alpine"
28
    depends-on "lint"
29
    exec "sh" "-eu" "test.sh"
30
}
31
"#))
32
    .unwrap();
33
    let sb = &p.sandboxes["alpine"];
34
    assert_eq!((sb.runtime, sb.memory_mib, sb.cpus, sb.network), (Runtime::Microvm, 512, 2, Network::Isolated));
35
    assert_eq!(sb.rootfs, ROOTFS);
36
    let lint = &p.jobs["lint"];
37
    assert_eq!(lint.exec, ["grep", "-rn", "TODO", "src"]);
38
    assert_eq!(lint.scope, ["src/**", "README.md"]);
39
    assert_eq!(lint.env["LANG"], "C.UTF-8");
40
    assert_eq!(p.jobs["test"].depends_on, ["lint"]);
41
    assert_eq!(p.order().iter().map(|j| j.name.as_str()).collect::<Vec<_>>(), ["lint", "test"]);
42
    assert_eq!(p.depths()["test"], 1);
43
}
44
45
#[test]
46
fn defaults_and_gib() {
47
    let p = Pipeline::parse(&format!(
48
        "schema-version 1\nsandbox \"s\" {{\n  rootfs \"cas://blob/{ROOTFS}\"\n  memory-limit \"2GiB\"\n}}\njob \"a\" {{\n  sandbox \"s\"\n  exec \"true\"\n}}\n"
49
    ))
50
    .unwrap();
51
    let s = &p.sandboxes["s"];
52
    assert_eq!((s.runtime, s.memory_mib, s.cpus, s.network), (Runtime::Microvm, 2048, 1, Network::Isolated));
53
}
54
55
#[test]
56
fn shell_metacharacters_stay_literal_argv() {
57
    // Spec §10.1: every byte reaches argv as written; nothing adds a shell.
58
    let p = Pipeline::parse(&doc(r#"job "x" { sandbox "alpine"; exec "echo" "a; rm -rf / && $(id) | `x`" "b\nc"; }"#)).unwrap();
59
    assert_eq!(p.jobs["x"].exec, ["echo", "a; rm -rf / && $(id) | `x`", "b\nc"]);
60
}
61
62
#[test]
63
fn problems_carry_lines_and_are_all_reported() {
64
    let src = doc(r#"job "a" {
65
    sandbox "missing"
66
    exec "true"
67
    mount { source "oxy://workspace"; }
68
}
69
job "b" {
70
    sandbox "alpine"
71
    depends-on "nope"
72
    exec
73
}
74
flavour "x"
75
"#);
76
    let ps = problems(&src);
77
    let has = |line: usize, text: &str| ps.iter().any(|(l, m)| *l == line && m.contains(text));
78
    assert!(has(11, "which is not declared") && has(11, "\"missing\""), "{ps:?}");
fc10d9e8 Andy McCall ↶ 79
    assert!(has(14, "mount source \"oxy://workspace\" is not in M0 yet"), "{ps:?}");
e0918b88 Andy McCall 80
    assert!(has(16, "\"nope\""), "{ps:?}");
81
    assert!(has(19, "`exec` needs a program"), "{ps:?}");
82
    assert!(has(21, "unknown node `flavour`"), "{ps:?}");
83
}
84
85
#[test]
86
fn typed_values_are_not_coerced() {
87
    let src = format!(
88
        "schema-version 1\nsandbox \"s\" {{\n  rootfs \"cas://blob/{ROOTFS}\"\n  cpu-limit \"2\"\n  memory-limit \"1.5GiB\"\n}}\njob \"a\" {{\n  sandbox \"s\"\n  exec \"echo\" 1\n}}\n"
89
    );
90
    let ps = problems(&src);
91
    assert!(ps.iter().any(|(l, m)| *l == 4 && m.contains("integer, not a string")), "{ps:?}");
92
    assert!(ps.iter().any(|(l, m)| *l == 5 && m.contains("whole number")), "{ps:?}");
93
    assert!(ps.iter().any(|(l, m)| *l == 9 && m.contains("strings, not an integer")), "{ps:?}");
94
}
95
96
#[test]
97
fn m0_refuses_what_it_cannot_honour() {
ea81796b Andy McCall ↶ 98
    let src = format!("schema-version 1\nsandbox \"s\" {{\n  runtime \"wasm\"\n  rootfs \"cas://blob/{ROOTFS}\"\n  network \"wifi\"\n}}\njob \"a\" {{ sandbox \"s\"; exec \"true\"; }}\n");
e0918b88 Andy McCall 99
    let ps = problems(&src);
100
    assert!(ps.iter().any(|(l, m)| *l == 3 && m.contains("wasm")), "{ps:?}");
101
    assert!(ps.iter().any(|(l, m)| *l == 5 && m.contains("isolated")), "{ps:?}");
102
    assert!(problems("schema-version 2\n").iter().any(|(_, m)| m.contains("schema-version 2")));
103
    assert!(problems(&format!(
104
        "schema-version 1\nsandbox \"s\" {{ rootfs \"cas://blob/{}\"; }}\njob \"a\" {{ sandbox \"s\"; exec \"true\"; }}",
105
        &ROOTFS[..60]
106
    ))
107
    .iter()
108
    .any(|(_, m)| m.contains("64 lower-case hex")));
109
}
110
111
#[test]
112
fn cycles_are_found() {
113
    let ps = problems(&doc(
114
        "job \"a\" { sandbox \"alpine\"; depends-on \"c\"; exec \"true\"; }\njob \"b\" { sandbox \"alpine\"; depends-on \"a\"; exec \"true\"; }\njob \"c\" { sandbox \"alpine\"; depends-on \"b\"; exec \"true\"; }\njob \"d\" { sandbox \"alpine\"; depends-on \"d\"; exec \"true\"; }\n",
115
    ));
116
    assert!(ps.iter().any(|(_, m)| m.contains("cycle: a → c → b → a")), "{ps:?}");
117
    assert!(ps.iter().any(|(_, m)| m.contains("\"d\" depends on itself")), "{ps:?}");
118
}
119
120
#[test]
121
fn invalid_kdl_has_a_line() {
122
    let ps = problems("schema-version 1\njob \"a\" {\n  exec \"unterminated\n}\n");
123
    assert!(!ps.is_empty() && ps[0].0 >= 2, "{ps:?}");
124
}
125
126
#[test]
127
fn canonical_form_ignores_layout_and_order() {
128
    let a = Pipeline::parse(&doc(
129
        "job \"b\" { sandbox \"alpine\"; exec \"true\"; }\njob \"a\" {\n  sandbox \"alpine\"\n  depends-on \"b\"\n  exec \"x\"\n}\n",
130
    ))
131
    .unwrap();
132
    let b = Pipeline::parse(&doc("// comment\njob \"a\" { exec \"x\"; depends-on \"b\"; sandbox \"alpine\"; }\n\n\njob \"b\" { exec \"true\"; sandbox \"alpine\"; }\n")).unwrap();
133
    assert_eq!(a.canonical(), b.canonical());
134
    assert_eq!(a.hash(), b.hash());
135
    let c = Pipeline::parse(&doc(
136
        "job \"b\" { sandbox \"alpine\"; exec \"true\"; }\njob \"a\" { sandbox \"alpine\"; depends-on \"b\"; exec \"y\"; }\n",
137
    ))
138
    .unwrap();
139
    assert_ne!(a.hash(), c.hash());
140
    let sb = &a.sandboxes["alpine"];
141
    assert_ne!(a.jobs["a"].hash(sb), c.jobs["a"].hash(sb));
142
    assert_eq!(a.jobs["b"].hash(sb), c.jobs["b"].hash(sb), "an unchanged job keeps its hash");
143
    // The canonical form round-trips through Oxygen's strict decoder.
144
    oxy_core::cbor::decode(&a.canonical()).unwrap();
145
}
146
147
#[test]
148
fn scope_tree_hash_sees_only_the_scope() {
149
    let f = |b: u8| [b; 32];
150
    let scope = vec!["src/**".to_string()];
151
    let base = scope_tree_hash(&scope, [("src/a.rs", f(1)), ("README.md", f(2))]);
152
    assert_eq!(base, scope_tree_hash(&scope, [("README.md", f(9)), ("src/a.rs", f(1))]), "outside the scope, and order, do not count");
153
    assert_ne!(base, scope_tree_hash(&scope, [("src/a.rs", f(3)), ("README.md", f(2))]));
154
    assert_ne!(scope_tree_hash(&[], [("README.md", f(2))]), scope_tree_hash(&[], [("README.md", f(9))]), "no scope is the whole tree");
155
}
156
157
#[test]
158
fn receipts_hash_as_oxygen_objects() {
159
    let r = Receipt {
160
        job_name: "lint".into(),
161
        pipeline_hash: [1; 32],
162
        scope_tree_hash: [2; 32],
163
        inputs: vec![],
164
        environment: [3; 32],
165
        outputs: vec![],
166
        exit_code: 0,
167
        duration_ms: 1234,
168
    };
169
    let body = r.encode();
170
    let mut want = format!("oxy1 receipt {}\0", body.len()).into_bytes();
171
    want.extend_from_slice(&body);
172
    assert_eq!(r.hash(), *blake3::hash(&want).as_bytes());
173
    let json = serde_json::to_string(&r).unwrap();
174
    assert_eq!(serde_json::from_str::<Receipt>(&json).unwrap(), r);
47c1d64d Andy McCall ↶ 175
    // The same receipt as the Oxygen object a runner signs.
176
    assert_eq!(r.to_oxy().hash().0, r.hash());
177
    assert_eq!(r.to_oxy().encode(), body);
e0918b88 Andy McCall 178
    let mut r2 = r.clone();
179
    r2.exit_code = 1;
180
    assert_ne!(r.hash(), r2.hash());
fc10d9e8 Andy McCall ↶ 181
}
182
183
#[test]
184
fn ephemeral_mounts_parse_sort_and_hash() {
185
    let plain = Pipeline::parse(&doc("job \"b\" {\n    sandbox \"alpine\"\n    exec \"cargo\" \"build\"\n}\n")).unwrap();
186
    let p = Pipeline::parse(&doc(r#"job "b" {
187
    sandbox "alpine"
188
    mount {
189
        source "ephemeral://tmpfs"
190
        target "/tmp/cache"
191
        size "256MiB"
192
    }
193
    mount {
194
        source "ephemeral://disk"
195
        target "/src/target"
196
        size "8GiB"
197
    }
198
    exec "cargo" "build"
199
}
200
"#))
201
    .unwrap();
202
    let b = &p.jobs["b"];
203
    assert_eq!(
204
        b.mounts,
205
        vec![
d60aac6c Andy McCall ↶ 206
            Mount { source: MountSource::Disk, target: "/src/target".into(), size_mib: 8192, cache: None, key: vec![] },
207
            Mount { source: MountSource::Tmpfs, target: "/tmp/cache".into(), size_mib: 256, cache: None, key: vec![] },
fc10d9e8 Andy McCall ↶ 208
        ],
209
        "sorted by target"
210
    );
211
    assert_ne!(p.hash(), plain.hash(), "mounts are part of the job");
212
    // A job without mounts encodes as before mounts existed: no field 6.
213
    let v = oxy_core::cbor::decode(&plain.canonical()).unwrap();
214
    let text = format!("{v:?}");
215
    assert!(!text.contains("ephemeral"), "{text}");
216
    let json = serde_json::to_value(&plain.jobs["b"]).unwrap();
217
    assert!(json.get("mounts").is_none(), "absent from the API too");
218
    let back: Job = serde_json::from_value(json).unwrap();
219
    assert!(back.mounts.is_empty());
220
}
221
222
#[test]
d60aac6c Andy McCall ↶ 223
fn a_disk_mount_can_be_a_cache_keyed_by_files() {
224
    let src = |extra: &str| {
225
        doc(&format!(
226
            "job \"b\" {{\n    sandbox \"alpine\"\n    mount {{\n        source \"ephemeral://disk\"\n        target \"/src/target\"\n        size \"8GiB\"\n{extra}    }}\n    exec \"cargo\" \"build\"\n}}\n"
227
        ))
228
    };
229
    let plain = Pipeline::parse(&src("")).unwrap();
230
    let cached = Pipeline::parse(&src("        cache \"target\"\n        key \"Cargo.lock\" \"rust-toolchain.toml\"\n")).unwrap();
231
    let m = &cached.jobs["b"].mounts[0];
232
    assert_eq!((m.cache.as_deref(), m.key.clone()), (Some("target"), vec!["Cargo.lock".to_string(), "rust-toolchain.toml".to_string()]));
233
    assert_ne!(cached.hash(), plain.hash(), "a cache is part of the job");
234
    let keyless = Pipeline::parse(&src("        cache \"target\"\n")).unwrap();
235
    assert_ne!(keyless.hash(), cached.hash());
236
    let ps = problems(&src("        cache \"no spaces\"\n"));
237
    assert!(ps.iter().any(|(_, m)| m.contains("cache name")), "{ps:?}");
238
    let ps = problems(&src("        key \"Cargo.lock\"\n"));
239
    assert!(ps.iter().any(|(_, m)| m.contains("goes with `cache`")), "{ps:?}");
240
    let ps = problems(&src("        cache \"t\"\n        key \"../x\"\n"));
241
    assert!(ps.iter().any(|(_, m)| m.contains("path in the repository")), "{ps:?}");
242
    let tmpfs = doc("job \"b\" {\n    sandbox \"alpine\"\n    mount {\n        source \"ephemeral://tmpfs\"\n        target \"/tmp/c\"\n        size \"64MiB\"\n        cache \"c\"\n    }\n    exec \"true\"\n}\n");
243
    assert!(problems(&tmpfs).iter().any(|(_, m)| m.contains("only an ephemeral://disk")));
244
}
245
246
#[test]
fc10d9e8 Andy McCall ↶ 247
fn mounts_are_checked() {
248
    let job = |mount: &str| doc(&format!("job \"b\" {{\n    sandbox \"alpine\"\n    mount {{\n{mount}\n    }}\n    exec \"true\"\n}}\n"));
249
    let has = |src: String, want: &str| {
250
        let ps = problems(&src);
251
        assert!(ps.iter().any(|(_, m)| m.contains(want)), "{want:?} not in {ps:?}");
252
    };
253
    has(job("source \"oxy://workspace\"\ntarget \"/src/x\"\nsize \"1GiB\""), "not in M0 yet");
254
    has(job("source \"ephemeral://disk\"\ntarget \"/etc/x\"\nsize \"1GiB\""), "under /src or /tmp");
255
    has(job("source \"ephemeral://disk\"\ntarget \"/src\"\nsize \"1GiB\""), "under /src or /tmp");
256
    has(job("source \"ephemeral://disk\"\ntarget \"/src/../etc\"\nsize \"1GiB\""), "without . or ..");
257
    has(job("source \"ephemeral://disk\"\ntarget \"/src/x/\"\nsize \"1GiB\""), "trailing /");
258
    has(job("source \"ephemeral://disk\"\ntarget \"/src/x\"\nsize \"8MiB\""), "from 16MiB to 64GiB");
259
    has(job("source \"ephemeral://disk\"\ntarget \"/src/x\"\nsize \"65GiB\""), "from 16MiB to 64GiB");
260
    has(job("source \"ephemeral://disk\"\ntarget \"/src/x\"\nsize \"lots\""), "whole number");
261
    has(job("source \"ephemeral://disk\"\ntarget \"/src/x\""), "needs a size");
262
    has(job("source \"ephemeral://disk\"\ntarget \"/src/x\"\nsize \"1GiB\"\nreadonly #true"), "`readonly` is not in M0 yet");
263
    has(job("source \"ephemeral://disk\"\nsource \"ephemeral://tmpfs\"\ntarget \"/src/x\"\nsize \"1GiB\""), "given twice");
264
    let two = |a: &str, b: &str| {
265
        doc(&format!(
266
            "job \"b\" {{\n    sandbox \"alpine\"\n    mount {{ source \"ephemeral://disk\"; target \"{a}\"; size \"1GiB\"; }}\n    mount {{ source \"ephemeral://disk\"; target \"{b}\"; size \"1GiB\"; }}\n    exec \"true\"\n}}\n"
267
        ))
268
    };
269
    has(two("/src/t", "/src/t/deps"), "overlaps");
270
    has(two("/src/t", "/src/t"), "overlaps");
271
    assert!(Pipeline::parse(&two("/src/t", "/src/tt")).is_ok(), "a shared prefix is not nesting");
272
    let five: String =
273
        (0..5).map(|i| format!("    mount {{ source \"ephemeral://tmpfs\"; target \"/tmp/m{i}\"; size \"16MiB\"; }}\n")).collect();
274
    has(doc(&format!("job \"b\" {{\n    sandbox \"alpine\"\n{five}    exec \"true\"\n}}\n")), "at most 4 mounts");
e0918b88 Andy McCall 275
}
eb5c4db6 Andy McCall ↶ 276
277
#[test]
ea81796b Andy McCall ↶ 278
fn loopback_and_allow_listed_egress() {
eb5c4db6 Andy McCall ↶ 279
    let src = |net: &str| {
ea81796b Andy McCall ↶ 280
        format!("schema-version 1\nsandbox \"s\" {{\n  rootfs \"cas://blob/{ROOTFS}\"\n  network {net}\n}}\njob \"a\" {{ sandbox \"s\"; exec \"true\"; }}\n")
eb5c4db6 Andy McCall ↶ 281
    };
ea81796b Andy McCall ↶ 282
    let p = Pipeline::parse(&src("\"loopback\"")).unwrap();
eb5c4db6 Andy McCall ↶ 283
    assert_eq!(p.sandboxes["s"].network, Network::Loopback);
ea81796b Andy McCall ↶ 284
    assert_ne!(p.hash(), Pipeline::parse(&src("\"isolated\"")).unwrap().hash(), "the network is part of the sandbox");
285
286
    // Egress names its hosts (oxygenflow#55), sorted; the sandbox then needs
287
    // a runner offering the egress label.
288
    let p =
289
        Pipeline::parse(&src("\"egress\" { allow \"registry.opentofu.org\" \"*.googleapis.com\"; allow \"*.googleapis.com\"; }")).unwrap();
290
    let s = &p.sandboxes["s"];
291
    assert_eq!(s.network, Network::Egress);
292
    assert_eq!(s.egress_allow, ["*.googleapis.com", "registry.opentofu.org"]);
293
    assert_eq!(s.runs_on, [crate::EGRESS_LABEL]);
294
    let other = Pipeline::parse(&src("\"egress\" { allow \"registry.opentofu.org\"; }")).unwrap();
295
    assert_ne!(p.hash(), other.hash(), "the allow-list is part of the sandbox");
296
297
    let has = |net: &str, want: &str| {
298
        let ps = problems(&src(net));
299
        assert!(ps.iter().any(|(_, m)| m.contains(want)), "{net}: {ps:?}");
300
    };
301
    has("\"egress\"", "needs a block");
302
    has("\"egress\" { }", "at least one `allow");
303
    has("\"egress\" { allow \"Example.COM\"; }", "lower-case host name");
304
    has("\"egress\" { allow \"localhost\"; }", "lower-case host name");
305
    has("\"egress\" { allow \"example.com:8443\"; }", "lower-case host name");
306
    has("\"egress\" { deny \"example.com\"; }", "unknown egress setting");
307
    has("\"loopback\" { allow \"example.com\"; }", "takes no block");
308
    let syscall = format!(
309
        "schema-version 1\nsandbox \"s\" {{\n  runtime \"syscall\"\n  rootfs \"cas://blob/{ROOTFS}\"\n  network \"egress\" {{ allow \"example.com\"; }}\n}}\njob \"a\" {{ sandbox \"s\"; exec \"true\"; }}\n"
310
    );
311
    assert!(problems(&syscall).iter().any(|(_, m)| m.contains("needs runtime \"microvm\"")));
312
}
313
314
#[test]
315
fn egress_patterns_match_names_and_names_under_a_domain() {
316
    let allow = vec!["*.googleapis.com".to_string(), "registry.opentofu.org".to_string()];
317
    for ok in ["storage.googleapis.com", "a.b.googleapis.com", "REGISTRY.opentofu.org.", "registry.opentofu.org"] {
318
        assert!(crate::egress_allows(&allow, ok), "{ok}");
319
    }
320
    for no in ["googleapis.com", "evilgoogleapis.com", "googleapis.com.evil.org", "opentofu.org", "x.registry.opentofu.org", ""] {
321
        assert!(!crate::egress_allows(&allow, no), "{no}");
322
    }
eb5c4db6 Andy McCall ↶ 323
}
c4285535 Andy McCall ↶ 324
325
#[test]
e2c12561 Andy McCall ↶ 326
fn secrets_mount_as_files_and_are_part_of_the_job() {
327
    let plain = Pipeline::parse(&doc("job \"d\" {\n    sandbox \"alpine\"\n    exec \"deploy\"\n}\n")).unwrap();
328
    let p = Pipeline::parse(&doc(r#"job "d" {
329
    sandbox "alpine"
330
    secret "token" {
331
        mount-path "/run/secrets/token"
332
    }
333
    secret "aws" {
334
        mount-path "/run/secrets/aws/credentials"
335
    }
336
    exec "deploy"
337
}"#))
338
    .unwrap();
339
    let d = &p.jobs["d"];
340
    assert_eq!(
341
        d.secrets,
342
        vec![
343
            Secret { name: "aws".into(), mount_path: "/run/secrets/aws/credentials".into() },
344
            Secret { name: "token".into(), mount_path: "/run/secrets/token".into() },
345
        ],
346
        "sorted by name"
347
    );
348
    assert_ne!(p.hash(), plain.hash(), "secrets are part of the job");
349
    for (bad, why) in [
350
        ("secret \"t\" {\n    mount-path \"/tmp/t\"\n}", "under /run/secrets/"),
351
        ("secret \"t\" {\n    mount-path \"/run/secrets/../x\"\n}", "under /run/secrets/"),
352
        ("secret \"t\" {\n}", "needs a mount-path"),
353
        ("secret \"t\" {\n    mount-path \"/run/secrets/a\"\n}\nsecret \"t\" {\n    mount-path \"/run/secrets/b\"\n}", "given twice"),
354
        (
355
            "secret \"t\" {\n    mount-path \"/run/secrets/a\"\n}\nsecret \"u\" {\n    mount-path \"/run/secrets/a\"\n}",
720eb819 Andy McCall ↶ 356
            "two files mount at",
e2c12561 Andy McCall ↶ 357
        ),
358
        ("secret \"t\" {\n    vault-ref \"x\"\n    mount-path \"/run/secrets/a\"\n}", "vault-ref"),
359
    ] {
360
        let e = Pipeline::parse(&doc(&format!("job \"d\" {{\n    sandbox \"alpine\"\n    {bad}\n    exec \"deploy\"\n}}\n"))).unwrap_err();
361
        assert!(e.to_string().contains(why), "{bad}: {e}");
362
    }
363
}
364
365
#[test]
720eb819 Andy McCall ↶ 366
fn identities_are_asked_for_by_audience_and_mount_like_secrets() {
367
    let plain = Pipeline::parse(&doc("job \"d\" {\n    sandbox \"alpine\"\n    exec \"deploy\"\n}\n")).unwrap();
368
    let p = Pipeline::parse(&doc(r#"job "d" {
369
    sandbox "alpine"
370
    identity "sts.amazonaws.com" {
371
        mount-path "/run/secrets/aws-token"
372
    }
373
    identity "https://vault.example" {
374
        mount-path "/run/secrets/vault-token"
375
    }
376
    secret "key" {
377
        mount-path "/run/secrets/key"
378
    }
379
    exec "deploy"
380
}"#))
381
    .unwrap();
382
    let d = &p.jobs["d"];
383
    assert_eq!(
384
        d.identities.iter().map(|i| i.audience.as_str()).collect::<Vec<_>>(),
385
        ["https://vault.example", "sts.amazonaws.com"],
386
        "sorted"
387
    );
388
    assert_ne!(p.hash(), plain.hash(), "identities are part of the job");
389
    for (bad, why) in [
390
        ("identity \"a b\" {\n    mount-path \"/run/secrets/x\"\n}", "without spaces"),
391
        ("identity \"a\" {\n    mount-path \"/tmp/x\"\n}", "under /run/secrets/"),
392
        ("identity \"a\" {\n}", "needs a mount-path"),
393
        ("identity \"a\" {\n    mount-path \"/run/secrets/x\"\n}\nidentity \"a\" {\n    mount-path \"/run/secrets/y\"\n}", "given twice"),
394
        (
395
            "identity \"a\" {\n    mount-path \"/run/secrets/x\"\n}\nsecret \"s\" {\n    mount-path \"/run/secrets/x\"\n}",
396
            "two files mount at",
397
        ),
398
    ] {
399
        let e = Pipeline::parse(&doc(&format!("job \"d\" {{\n    sandbox \"alpine\"\n    {bad}\n    exec \"deploy\"\n}}\n"))).unwrap_err();
400
        assert!(e.to_string().contains(why), "{bad}: {e}");
401
    }
402
}
403
404
#[test]
1abadd4a Andy McCall ↶ 405
fn a_sandbox_may_name_its_architecture() {
406
    let plain = Pipeline::parse(&doc("job \"b\" {\n    sandbox \"alpine\"\n    exec \"make\"\n}\n")).unwrap();
407
    assert_eq!(plain.sandboxes["alpine"].arch, None);
408
    let src =
409
        doc("job \"b\" {\n    sandbox \"alpine\"\n    exec \"make\"\n}\n").replace("memory-limit", "arch \"riscv64\"\n    memory-limit");
410
    let p = Pipeline::parse(&src).unwrap();
411
    assert_eq!(p.sandboxes["alpine"].arch.as_deref(), Some("riscv64"));
412
    assert_ne!(p.hash(), plain.hash(), "the architecture is part of the sandbox");
413
    let bad = src.replace("riscv64", "RISC V");
414
    assert!(Pipeline::parse(&bad).unwrap_err().to_string().contains("not an architecture name"));
415
    assert!(arch_ok("x86_64") && arch_ok("aarch64") && !arch_ok("x") && !arch_ok("A64"));
416
}
417
418
#[test]
c4285535 Andy McCall ↶ 419
fn jobs_are_told_what_they_build() {
420
    let p = Pipeline::parse(&doc(r#"job "build" {
421
    sandbox "alpine"
422
    env {
423
        FLOW_BOOKMARK "pinned-by-the-pipeline"
424
    }
425
    exec "make"
426
}"#))
427
    .unwrap();
428
    let job = p.jobs["build"].clone();
429
    let claim = crate::api::Claim {
430
        job_id: 7,
431
        run_id: 40,
432
        repo: "andy/demo".into(),
433
        clone_url: "https://hub/andy/demo".into(),
434
        token: "t".into(),
435
        heads: vec!["aa".into(), "bb".into()],
436
        pipeline_hash: "00".into(),
437
        job: job.clone(),
438
        sandbox: p.sandboxes["alpine"].clone(),
439
        timeout_s: 60,
440
        subrepos: vec![],
441
        state: "cc".into(),
442
        bookmark: "feature/x".into(),
443
        run_number: 3,
c58efc6a Andy McCall ↶ 444
        env: [("CC".to_string(), "clang".to_string()), ("FLOW_REPO".to_string(), "spoofed".to_string())].into_iter().collect(),
e2c12561 Andy McCall ↶ 445
        secrets: vec![],
46fe2c81 Andy McCall ↶ 446
        inputs: vec![],
c4285535 Andy McCall ↶ 447
    };
448
    let env = job.with_flow_env(&claim.flow_env()).env;
c58efc6a Andy McCall ↶ 449
    assert_eq!(env["CC"], "clang", "the hub's variables reach the job");
450
    assert_eq!(env["FLOW_REPO"], "andy/demo", "a hub variable cannot pose as a FLOW_ fact");
c4285535 Andy McCall ↶ 451
    assert_eq!(env["FLOW_HEADS"], "aa+bb");
452
    assert_eq!(env["FLOW_STATE"], "cc");
453
    assert_eq!(env["FLOW_RUN"], "3", "the run's number in its repository, not the hub's id");
454
    assert_eq!(env["FLOW_JOB"], "build");
455
    assert_eq!(env["FLOW_BOOKMARK"], "pinned-by-the-pipeline", "the pipeline's own value wins");
456
    // Unknown values (an older hub) are left out, not empty.
e2c12561 Andy McCall ↶ 457
    let old = crate::api::Claim {
458
        state: String::new(),
459
        bookmark: String::new(),
460
        run_number: 0,
461
        env: Default::default(),
462
        secrets: vec![],
463
        ..claim
464
    };
c4285535 Andy McCall ↶ 465
    let names: Vec<String> = old.flow_env().into_iter().map(|(k, _)| k).collect();
466
    assert_eq!(names, ["FLOW_REPO", "FLOW_HEADS", "FLOW_JOB"]);
467
}
a72abeee Andy McCall ↶ 468
469
#[test]
470
fn a_sandbox_env_is_where_jobs_start() {
471
    let src = |sandbox_env: &str| {
472
        format!(
473
            "schema-version 1\nsandbox \"mos\" {{\n    rootfs \"cas://blob/{ROOTFS}\"\n{sandbox_env}}}\njob \"build\" {{\n    sandbox \"mos\"\n    env {{\n        X16EMU \"/opt/job\"\n    }}\n    exec \"make\"\n}}\n"
474
        )
475
    };
476
    let with =
477
        Pipeline::parse(&src("    env {\n        PATH \"/opt/llvm-mos/bin:/usr/bin:/bin\"\n        X16EMU \"/opt/x16emu\"\n    }\n"))
478
            .unwrap();
479
    let sb = &with.sandboxes["mos"];
480
    assert_eq!(sb.env["PATH"], "/opt/llvm-mos/bin:/usr/bin:/bin");
481
    let job = with.jobs["build"].in_sandbox(sb);
482
    assert_eq!(job.env["PATH"], "/opt/llvm-mos/bin:/usr/bin:/bin", "from the sandbox");
483
    assert_eq!(job.env["X16EMU"], "/opt/job", "the job's own value wins");
484
    // The sandbox's environment is part of the pipeline's hash; a sandbox
485
    // without one hashes as before.
486
    let without = Pipeline::parse(&src("")).unwrap();
487
    assert!(without.sandboxes["mos"].env.is_empty());
488
    assert_ne!(with.hash(), without.hash());
489
    let bad = problems(&src("    env {\n        BAD-NAME \"x\"\n    }\n"));
490
    assert!(bad.iter().any(|(_, m)| m.contains("letters, digits and _")), "{bad:?}");
491
}
a67b97e9 Andy McCall ↶ 492
493
#[test]
494
fn artifacts_are_declared_checked_and_hashed() {
495
    let src = |out: &str| {
496
        doc(&format!(
497
            "job \"build\" {{\n    sandbox \"alpine\"\n    mount {{\n        source \"ephemeral://disk\"\n        target \"/src/target\"\n        size \"1GiB\"\n    }}\n    mount {{\n        source \"ephemeral://tmpfs\"\n        target \"/src/tmp\"\n        size \"64MiB\"\n    }}\n    exec \"make\"\n{out}}}\n"
498
        ))
499
    };
500
    let p = Pipeline::parse(&src(
501
        "    output {\n        artifact \"tool\" {\n            path \"/src/target/release/tool\"\n            format \"blob\"\n        }\n        artifact \"docs\" {\n            path \"/src/docs/tool.1\"\n        }\n    }\n",
502
    ))
503
    .unwrap();
504
    let names: Vec<(&str, &str)> = p.jobs["build"].outputs.iter().map(|o| (o.name.as_str(), o.path.as_str())).collect();
505
    assert_eq!(names, [("docs", "/src/docs/tool.1"), ("tool", "/src/target/release/tool")], "sorted by name");
506
    // Artifacts are part of the job's hash; a job without them hashes as before.
507
    let plain = Pipeline::parse(&src("")).unwrap();
508
    let sb = &p.sandboxes["alpine"];
509
    assert_ne!(p.jobs["build"].hash(sb), plain.jobs["build"].hash(sb));
510
    assert!(plain.jobs["build"].outputs.is_empty());
511
    let json = serde_json::to_string(&plain.jobs["build"]).unwrap();
512
    assert!(!json.contains("outputs"), "no outputs field when there are none: {json}");
513
514
    let bad = |out: &str| problems(&src(out)).into_iter().map(|(_, m)| m).collect::<Vec<_>>().join("\n");
515
    assert!(bad("    output {\n        artifact \"x\" {\n            path \"/etc/passwd\"\n        }\n    }\n")
516
        .contains("must be an absolute path under /src"));
517
    assert!(bad("    output {\n        artifact \"x\" {\n            path \"/src/../etc\"\n        }\n    }\n")
518
        .contains("must be an absolute path under /src"));
519
    assert!(bad("    output {\n        artifact \"x\" {\n            path \"/src/tmp/a\"\n        }\n    }\n").contains("tmpfs"));
520
    assert!(bad("    output {\n        artifact \"x\" {\n        }\n    }\n").contains("needs a path"));
521
    assert!(bad("    output {\n        artifact \"x\" {\n            path \"/src/a\"\n        }\n        artifact \"x\" {\n            path \"/src/b\"\n        }\n    }\n")
522
        .contains("given twice"));
523
    assert!(bad("    output {\n        artifact \"x\" {\n            path \"/src/a\"\n            format \"tar\"\n        }\n    }\n")
524
        .contains("format"));
9a6fac2b Andy McCall ↶ 525
526
    // oxygenflow#37: `when "always"` keeps a failing job's report; the
527
    // default hashes and serialises as before.
528
    let p = Pipeline::parse(&src(
529
        "    output {\n        artifact \"junit\" {\n            path \"/src/target/junit.xml\"\n            when \"always\"\n        }\n        artifact \"tool\" {\n            path \"/src/target/tool\"\n            when \"passed\"\n        }\n    }\n",
530
    ))
531
    .unwrap();
532
    let outs = &p.jobs["build"].outputs;
533
    assert!(outs[0].always && outs[0].name == "junit");
534
    assert!(!outs[1].always);
535
    let json = serde_json::to_string(&outs[1]).unwrap();
536
    assert!(!json.contains("always"), "{json}");
537
    assert!(serde_json::to_string(&outs[0]).unwrap().contains("\"always\":true"));
538
    assert!(bad("    output {\n        artifact \"x\" {\n            path \"/src/a\"\n            when \"failed\"\n        }\n    }\n")
539
        .contains("\"passed\" (the default) or \"always\""));
6d53fb7d Andy McCall ↶ 540
541
    // oxygenhub#127: a report is a directory output; it shares names with
542
    // artifacts, and its kind is part of the job's hash.
543
    let as_kind = |kind: &str| {
544
        Pipeline::parse(&src(&format!("    output {{\n        {kind} \"perf\" {{\n            path \"/src/target/report\"\n            when \"always\"\n        }}\n    }}\n"))).unwrap()
545
    };
546
    let (report, artifact) = (as_kind("report"), as_kind("artifact"));
547
    let o = &report.jobs["build"].outputs[0];
548
    assert!(o.kind == OutputKind::Report && o.always && o.path == "/src/target/report");
549
    assert!(serde_json::to_string(o).unwrap().contains("\"kind\":\"report\""));
550
    assert!(!serde_json::to_string(&artifact.jobs["build"].outputs[0]).unwrap().contains("kind"));
551
    assert_ne!(report.jobs["build"].hash(sb), artifact.jobs["build"].hash(sb));
552
    assert!(bad("    output {\n        artifact \"x\" {\n            path \"/src/a\"\n        }\n        report \"x\" {\n            path \"/src/b\"\n        }\n    }\n")
553
        .contains("given twice"));
554
    assert!(bad("    output {\n        report \"x\" {\n        }\n    }\n").contains("needs a path"));
a67b97e9 Andy McCall ↶ 555
}
b647ab72 Andy McCall ↶ 556
557
/// metalgear feedback 19 (oxygenflow#17): `\033` in a string is not KDL;
558
/// the problems say to write ESC as `\u{1b}`, which parses.
559
#[test]
560
fn ansi_escapes_are_written_as_unicode() {
561
    let bad = problems(&doc("job \"a\" {\n    sandbox \"alpine\"\n    exec \"printf\" \"\\033[32mok\\033[0m\"\n}\n"));
562
    assert!(bad.iter().any(|(line, m)| *line == 13 && m.contains("\\u{1b}")), "{bad:?}");
563
    let p = Pipeline::parse(&doc("job \"a\" {\n    sandbox \"alpine\"\n    exec \"printf\" \"\\u{1b}[32mok\\u{1b}[0m\"\n}\n")).unwrap();
564
    assert_eq!(p.jobs["a"].exec[1], "\u{1b}[32mok\u{1b}[0m");
565
}
e576e086 Andy McCall ↶ 566
567
#[test]
568
fn runs_on_asks_for_runner_labels() {
569
    let src = doc("job \"cross\" {\n    sandbox \"alpine\"\n    runs-on \"riscv64\" \"big-disk\"\n    exec \"make\"\n}\n")
570
        .replace("    network", "    runs-on \"gpu\"\n    network");
571
    let p = Pipeline::parse(&src).unwrap();
572
    let job = &p.jobs["cross"];
573
    assert_eq!(job.runs_on, vec!["big-disk", "riscv64"], "sorted");
574
    let sandbox = &p.sandboxes["alpine"];
575
    assert_eq!(sandbox.runs_on, vec!["gpu"]);
576
    assert_eq!(job.in_sandbox(sandbox).runs_on, vec!["big-disk", "gpu", "riscv64"], "with its sandbox's");
577
    // A pipeline without runs-on serialises as before, so its jobs' hashes stay.
578
    let plain = Pipeline::parse(&doc("job \"x\" {\n    sandbox \"alpine\"\n    exec \"true\"\n}\n")).unwrap();
579
    assert!(!serde_json::to_string(&plain.jobs["x"]).unwrap().contains("runs_on"));
580
    let bad = problems(&doc("job \"x\" {\n    sandbox \"alpine\"\n    runs-on \"RISCV\"\n    exec \"true\"\n}\n"));
581
    assert!(bad.iter().any(|(_, m)| m.contains("a label is lower-case")), "{bad:?}");
582
    let none = problems(&doc("job \"y\" {\n    sandbox \"alpine\"\n    runs-on\n    exec \"true\"\n}\n"));
583
    assert!(none.iter().any(|(_, m)| m.contains("needs one or more labels")), "{none:?}");
584
}
02b127d2 Andy McCall ↶ 585
586
/// oxygenflow#23: `timeout` on a job, or on its sandbox for every job in
587
/// it, as a duration from a minute to a day.
588
#[test]
589
fn a_job_says_how_long_it_may_run() {
590
    use crate::pipeline::{parse_duration, Pipeline};
591
    assert_eq!(parse_duration("90m"), Some(5400));
592
    assert_eq!(parse_duration("1h30m"), Some(5400));
593
    assert_eq!(parse_duration("2h"), Some(7200));
594
    assert_eq!(parse_duration("45s"), Some(45));
595
    for bad in ["", "90", "m", "30m1h", "1h1h", "2d", "-1h"] {
596
        assert_eq!(parse_duration(bad), None, "{bad:?}");
597
    }
598
    let root = "a".repeat(64);
599
    let text = format!(
600
        "schema-version 1\nsandbox \"s\" {{\n    runtime \"microvm\"\n    rootfs \"cas://blob/{root}\"\n    memory-limit \"1GiB\"\n    cpu-limit 1\n    network \"isolated\"\n    timeout \"2h\"\n}}\njob \"long\" {{\n    sandbox \"s\"\n    timeout \"3h30m\"\n    exec \"true\"\n}}\njob \"plain\" {{\n    sandbox \"s\"\n    exec \"true\"\n}}\n"
601
    );
602
    let p = Pipeline::parse(&text).unwrap();
603
    let job = |n: &str| p.jobs[n].in_sandbox(&p.sandboxes["s"]);
604
    assert_eq!(job("long").timeout_s, Some(12600), "the job's own");
605
    assert_eq!(job("plain").timeout_s, Some(7200), "the sandbox's");
606
    let bad = text.replace("timeout \"3h30m\"", "timeout \"2d\"");
607
    assert!(Pipeline::parse(&bad).unwrap_err().to_string().contains("timeout"));
608
    let long = text.replace("timeout \"3h30m\"", "timeout \"25h\"");
609
    assert!(Pipeline::parse(&long).unwrap_err().to_string().contains("from 1m to 24h"));
610
}
bf7bb1b8 Andy McCall ↶ 611
612
/// oxygenflow#24: `on` says what starts a job, at pipeline or job level;
613
/// a job without one runs on every push and by hand, as before.
614
#[test]
615
fn on_says_what_starts_a_job() {
616
    use crate::pipeline::{Event, Pipeline};
617
    let root = "a".repeat(64);
618
    let text = format!(
619
        "schema-version 1\non {{\n    push \"main\" \"feature/*\"\n    manual\n}}\nsandbox \"s\" {{\n    runtime \"microvm\"\n    rootfs \"cas://blob/{root}\"\n    memory-limit \"1GiB\"\n    cpu-limit 1\n    network \"isolated\"\n}}\njob \"test\" {{\n    sandbox \"s\"\n    exec \"true\"\n}}\njob \"dist\" {{\n    sandbox \"s\"\n    on {{\n        tag \"v*\"\n        manual\n    }}\n    exec \"true\"\n}}\njob \"nightly\" {{\n    sandbox \"s\"\n    on {{\n        schedule \"0 3 * * *\"\n    }}\n    exec \"true\"\n}}\n"
620
    );
621
    let p = Pipeline::parse(&text).unwrap();
622
    let runs = |job: &str, e: Event| p.on_of(&p.jobs[job]).matches(e);
623
    assert!(runs("test", Event::Push("main")) && runs("test", Event::Push("feature/9-x")));
624
    assert!(!runs("test", Event::Push("develop")), "not a bookmark the pipeline names");
625
    assert!(!runs("test", Event::Tag("v1.0.0")) && runs("test", Event::Manual));
626
    assert!(runs("dist", Event::Tag("v0.3.1")) && !runs("dist", Event::Tag("nightly")));
627
    assert!(!runs("dist", Event::Push("main")) && runs("dist", Event::Manual));
628
    assert!(runs("nightly", Event::Schedule) && !runs("nightly", Event::Manual));
629
    // Without any `on`, as before.
630
    let plain = text.replace("on {\n    push \"main\" \"feature/*\"\n    manual\n}\n", "");
631
    let p = Pipeline::parse(&plain).unwrap();
632
    assert!(p.on_of(&p.jobs["test"]).matches(Event::Push("anything")) && p.on_of(&p.jobs["test"]).matches(Event::Manual));
633
    for (bad, why) in [
634
        ("on {\n}\n", "names no event"),
635
        ("on {\n    when \"x\"\n}\n", "unknown `on` event"),
636
        ("on {\n    schedule \"0 3 * *\"\n}\n", "five cron fields"),
637
    ] {
638
        let t = format!("{bad}{plain}");
639
        let e = Pipeline::parse(&t).unwrap_err().to_string();
640
        assert!(e.contains(why), "{bad:?}: {e}");
641
    }
46fe2c81 Andy McCall ↶ 642
}
643
644
#[test]
645
fn a_job_takes_an_artifact_of_a_job_it_depends_on() {
646
    let jobs = |apply: &str| {
647
        doc(&format!(
648
            "job \"plan\" {{\n    sandbox \"alpine\"\n    output {{ artifact \"tfplan\" {{ path \"/src/out/tfplan\"; }}; report \"r\" {{ path \"/src/out/r\"; }}; }}\n    exec \"plan\"\n}}\njob \"apply\" {{\n    sandbox \"alpine\"\n{apply}    exec \"apply\"\n}}\n"
649
        ))
650
    };
651
    let ok = jobs("    depends-on \"plan\"\n    input { artifact \"tfplan\" from \"plan\"; path \"/src/tfplan\"; }\n");
652
    let p = Pipeline::parse(&ok).unwrap();
653
    assert_eq!(p.jobs["apply"].inputs, [crate::Input { artifact: "tfplan".into(), from: "plan".into(), path: "/src/tfplan".into() }]);
654
    let without = Pipeline::parse(&jobs("    depends-on \"plan\"\n")).unwrap();
655
    assert_ne!(p.hash(), without.hash(), "inputs are part of the job");
656
657
    let has = |apply: &str, want: &str| {
658
        let ps = problems(&jobs(apply));
659
        assert!(ps.iter().any(|(_, m)| m.contains(want)), "{apply}: {ps:?}");
660
    };
661
    has("    input { artifact \"tfplan\" from \"plan\"; path \"/src/tfplan\"; }\n", "add depends-on \"plan\"");
662
    has("    depends-on \"plan\"\n    input { artifact \"nope\" from \"plan\"; path \"/src/x\"; }\n", "declares no artifact \"nope\"");
663
    has("    depends-on \"plan\"\n    input { artifact \"r\" from \"plan\"; path \"/src/x\"; }\n", "is a report");
664
    has("    input { artifact \"tfplan\" from \"ghost\"; path \"/src/x\"; }\n", "which is not declared");
665
    has("    depends-on \"plan\"\n    input { artifact \"tfplan\" from \"plan\"; path \"/etc/x\"; }\n", "absolute path under /src");
666
    has("    depends-on \"plan\"\n    input { artifact \"tfplan\" \"plan\"; path \"/src/x\"; }\n", "artifact \"tfplan\" from \"plan\"");
667
    has("    depends-on \"plan\"\n    input { artifact \"tfplan\" from \"plan\"; }\n", "needs a `path`");
668
    has(
669
        "    depends-on \"plan\"\n    input { artifact \"tfplan\" from \"plan\"; path \"/src/x\"; }\n    input { artifact \"tfplan\" from \"plan\"; path \"/src/x\"; }\n",
670
        "two inputs are put at",
671
    );
bf7bb1b8 Andy McCall ↶ 672
}
e2089721 Andy McCall ↶ 673
674
#[test]
675
fn a_job_can_wait_for_approval() {
676
    let job = |approval: &str| doc(&format!("job \"apply\" {{\n    sandbox \"alpine\"\n{approval}    exec \"apply\"\n}}\n"));
677
    let p = Pipeline::parse(&job("    approval { by \"maintain\"; others-only #true; expires \"2h\"; }\n")).unwrap();
2be1fe4a Andy McCall ↶ 678
    assert_eq!(
679
        p.jobs["apply"].approval,
680
        Some(crate::Approval { by: "maintain".into(), others_only: true, expires_s: 7200, sealed: false })
681
    );
e2089721 Andy McCall ↶ 682
    let plain = Pipeline::parse(&job("    approval\n")).unwrap();
683
    assert_eq!(
684
        plain.jobs["apply"].approval,
2be1fe4a Andy McCall ↶ 685
        Some(crate::Approval { by: "maintain".into(), others_only: false, expires_s: 86400, sealed: false }),
e2089721 Andy McCall ↶ 686
        "defaults"
687
    );
2be1fe4a Andy McCall ↶ 688
    // Sealed (oxygenhub#235): on by default for a job with an environment,
689
    // as it says otherwise.
690
    let sealed = |extra: &str| Pipeline::parse(&job(extra)).unwrap().jobs["apply"].approval.clone().unwrap().sealed;
691
    assert!(sealed("    environment \"prod\"\n    approval\n"));
692
    assert!(!sealed("    environment \"prod\"\n    approval { sealed #false; }\n"));
693
    assert!(sealed("    approval { sealed #true; }\n"));
694
    assert_ne!(Pipeline::parse(&job("    approval { sealed #true; }\n")).unwrap().hash(), plain.hash(), "part of the job");
e2089721 Andy McCall ↶ 695
    assert_eq!(Pipeline::parse(&job("")).unwrap().jobs["apply"].approval, None);
696
    assert_ne!(p.hash(), plain.hash(), "the approval is part of the job");
697
    let has = |a: &str, want: &str| {
698
        let ps = problems(&job(a));
699
        assert!(ps.iter().any(|(_, m)| m.contains(want)), "{a}: {ps:?}");
700
    };
701
    has("    approval { by \"read\"; }\n", "expected \"write\", \"maintain\" or \"admin\"");
702
    has("    approval { others-only \"yes\"; }\n", "#true or #false");
703
    has("    approval { expires \"800h\"; }\n", "from 1m to 720h");
704
    has("    approval { when \"later\"; }\n", "unknown approval setting");
2be1fe4a Andy McCall ↶ 705
    has("    approval { sealed \"yes\"; }\n", "#true or #false");
e2089721 Andy McCall ↶ 706
}
f4e51e63 Andy McCall ↶ 707
708
#[test]
709
fn a_job_names_the_environment_it_deploys_to() {
710
    let job = |e: &str| doc(&format!("job \"apply\" {{\n    sandbox \"alpine\"\n{e}    exec \"apply\"\n}}\n"));
711
    let p = Pipeline::parse(&job("    environment \"prod\"\n")).unwrap();
712
    assert_eq!(p.jobs["apply"].environment.as_deref(), Some("prod"));
713
    assert_ne!(p.hash(), Pipeline::parse(&job("")).unwrap().hash(), "part of the job");
714
    assert!(problems(&job("    environment \"Prod env\"\n")).iter().any(|(_, m)| m.contains("1 to 32 of a-z 0-9 -")));
715
}