OXYGENHUB
# 3dd6582de060 oxygenhub / crates / hub / tests / api.rs
77.6 KiB · Rust · last changed Outbound requests only to public addresses 20 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
51
    config.outbound.allow = vec!["http://127.0.0.1".into()];
52
    let app = oxygenhub::build(config).await.unwrap();
53
    let router = oxygenhub::router(app.clone());
54
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
55
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
56
}
57
58
struct Res {
59
    status: StatusCode,
60
    body: String,
61
    cookie: Option<String>,
62
}
63
64
async fn call(
65
    app: &Shared,
66
    method: &str,
67
    path: &str,
68
    bearer: Option<&str>,
69
    cookie: Option<&str>,
70
    json: Option<&str>,
71
    form: Option<&str>,
72
) -> Res {
73
    let mut req = Request::builder().method(method).uri(path);
74
    if let Some(b) = bearer {
75
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
76
    }
77
    if let Some(c) = cookie {
78
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
79
    }
80
    let body = if let Some(j) = json {
81
        req = req.header(header::CONTENT_TYPE, "application/json");
82
        Body::from(j.to_string())
83
    } else if let Some(f) = form {
84
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
85
        Body::from(f.to_string())
86
    } else {
87
        Body::empty()
88
    };
89
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
90
    let status = res.status();
91
    let cookie = res
92
        .headers()
93
        .get(header::SET_COOKIE)
94
        .and_then(|v| v.to_str().ok())
95
        .and_then(|v| v.split(';').next())
96
        .and_then(|kv| kv.split_once('='))
97
        .map(|(_, v)| v.to_string());
98
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
99
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
100
}
101
102
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
103
    let r = call(app, method, path, bearer, None, json, None).await;
104
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
105
    (r.status, v)
106
}
107
108
fn csrf_of(page: &str) -> String {
109
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
110
    page[i..].split('"').next().unwrap().to_string()
111
}
112
113
/// A webhook receiver that records what it gets and fails the first time.
114
struct Receiver {
115
    url: String,
116
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
117
    fail_first: Arc<Mutex<bool>>,
118
}
119
120
async fn receiver() -> Receiver {
121
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
122
    let fail_first = Arc::new(Mutex::new(true));
123
    let (s2, f2) = (seen.clone(), fail_first.clone());
124
    let router = Router::new().route(
125
        "/hook",
126
        post(move |headers: header::HeaderMap, body: String| {
127
            let (s2, f2) = (s2.clone(), f2.clone());
128
            async move {
129
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
130
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
131
                let mut f = f2.lock().unwrap();
132
                if *f {
133
                    *f = false;
134
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
135
                }
136
                s2.lock().unwrap().push((event, sig, body));
137
                (StatusCode::OK, "ok")
138
            }
139
        }),
140
    );
141
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
142
    let port = listener.local_addr().unwrap().port();
143
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
144
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
145
}
146
147
#[tokio::test(flavor = "multi_thread")]
148
async fn api_webhooks_and_checks() {
149
    let h = hub().await;
150
    let app = &h.app;
151
    // Accounts and tokens through the pages.
152
    let r =
153
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
154
    let andy = r.cookie.unwrap();
155
    let r =
156
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
157
    let bob = r.cookie.unwrap();
158
    let mint = |cookie: String, scopes: &'static str| {
159
        let app = app.clone();
160
        async move {
161
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
162
            let csrf = csrf_of(&page.body);
163
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
164
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
165
        }
166
    };
167
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
168
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
169
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
170
171
    // Create a repository through the API; the read-only token cannot.
172
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
173
    assert_eq!(st, StatusCode::FORBIDDEN);
174
    let (st, v) = api(
175
        app,
176
        "POST",
177
        "/api/v1/repos",
178
        Some(&andy_admin),
179
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
180
    )
181
    .await;
182
    assert_eq!(st, StatusCode::CREATED, "{v}");
183
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
184
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
185
    assert_eq!(st, StatusCode::CONFLICT);
186
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
187
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
188
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
189
    assert_eq!(st, StatusCode::OK);
190
    assert_eq!(v["username"], "andy");
191
192
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
193
    let rx = receiver().await;
194
    let (st, v) = api(
195
        app,
196
        "POST",
197
        "/api/v1/repos/andy/demo/hooks",
198
        Some(&andy_admin),
199
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
200
    )
201
    .await;
202
    assert_eq!(st, StatusCode::CREATED, "{v}");
203
    let work = tempfile::tempdir().unwrap();
204
    let mut client = Repo::init(work.path()).unwrap();
205
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
206
    client.config.set("remote.origin.token", "site").unwrap();
207
    client.save_config().unwrap();
208
    write(work.path(), "a.txt", b"a\n");
209
    client.snapshot("t").unwrap();
210
    let base = client.commit("base", &[]).unwrap();
211
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
212
    // The worker retries with backoff; drive it directly for the retry.
213
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
214
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
215
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
216
    oxygenhub::hooks::deliver_due(app).await;
217
    let seen = rx.seen.lock().unwrap().clone();
218
    assert_eq!(seen.len(), 1, "{seen:?}");
219
    assert_eq!(seen[0].0, "push");
220
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
221
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
222
    assert_eq!(payload["repository"]["name"], "demo");
223
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
224
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
225
    assert_eq!(v.as_array().unwrap().len(), 1);
226
227
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
228
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
229
    assert_eq!(st, StatusCode::OK);
230
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
231
    // A revset in place of the whole history (`?r=`), under a budget; a
232
    // bad one is the caller's problem.
233
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
234
    assert_eq!(st, StatusCode::OK, "{v}");
235
    assert_eq!(v["total"].as_u64(), Some(1));
236
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
237
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
238
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
239
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
240
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
241
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
242
    assert_eq!(v[0]["name"], "a.txt");
243
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
244
    assert_eq!(r.body, "a\n");
245
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
246
    assert_eq!(v[0]["change"], base.to_hex());
247
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
248
    assert_eq!(v["files"][0]["path"], "a.txt");
249
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
250
    assert!(v["policy"].is_null());
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
252
    assert_eq!(v[0]["reference"], "main");
253
254
    // Issues through the API: Bob opens one, comments, and closes it.
255
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
256
    assert_eq!(st, StatusCode::CREATED, "{v}");
257
    assert_eq!(v["number"], 1);
258
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
259
    assert_eq!(st, StatusCode::CREATED);
260
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
261
    assert_eq!(st, StatusCode::OK, "{v}");
262
    assert_eq!(v["state"], "closed");
263
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
264
    assert_eq!(v[0]["comments"], 1);
265
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
266
    assert_eq!(v[0]["number"], 1);
267
268
    // A proposal through the API, then a required check gates its landing.
269
    client.bookmark_create("feat", Some(&[base])).unwrap();
270
    client.bookmark_switch("feat", false).unwrap();
271
    write(work.path(), "b.txt", b"b\n");
272
    write(work.path(), "a.txt", b"a\nA\n");
273
    client.snapshot("t").unwrap();
274
    let feat = client.commit("feat", &[]).unwrap();
275
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
276
    let (st, v) =
277
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
278
            .await;
279
    assert_eq!(st, StatusCode::CREATED, "{v}");
280
    assert_eq!(v["number"], 2);
281
    let state = v["projected_state"].as_str().unwrap().to_string();
282
    assert_eq!(v["landable"], true);
283
    // Its files, and each side's bytes, for editors' diff views.
284
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
285
    assert_eq!(st, StatusCode::OK, "{v}");
286
    let files: Vec<(String, String)> =
287
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
288
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
289
    assert_eq!(v[0]["added"], 1);
290
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
291
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
292
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
293
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
294
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
295
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
296
    // Require the "build" check.
297
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
298
    let csrf = csrf_of(&settings.body);
299
    assert_eq!(
300
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
301
            .await
302
            .status,
303
        StatusCode::OK
304
    );
305
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
306
    assert_eq!(v["landable"], false);
307
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
308
    // A checker reports on the projected state: first running, then passed; the page streams it.
309
    let (st, v) = api(
310
        app,
311
        "POST",
312
        "/api/v1/repos/andy/demo/checks",
313
        Some(&andy_ro),
314
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
315
    )
316
    .await;
317
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
318
    let mut events = app.events.proposals.subscribe();
319
    let (st, v) = api(
320
        app,
321
        "POST",
322
        "/api/v1/repos/andy/demo/checks",
323
        Some(&bob_rw),
324
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
325
    )
326
    .await;
327
    assert_eq!(st, StatusCode::CREATED, "{v}");
328
    let (_, ev) = events.recv().await.unwrap();
329
    assert_eq!(ev.kind, "check");
330
    assert_eq!(ev.check.unwrap().name, "build");
331
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
332
    assert_eq!(v[0]["status"], "passed");
333
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
334
    assert_eq!(v["landable"], true, "{v}");
335
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
336
    assert!(page.body.contains("42 tests"), "{}", page.body);
337
    // The check and the proposal reached the webhook too.
338
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
339
    oxygenhub::hooks::deliver_due(app).await;
340
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
341
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
342
    let _ = feat;
343
    let _ = rx.fail_first;
344
345
    // The inbox through the API: count, list, mark one read, mark all read.
346
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
347
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
348
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
349
    oxygenhub::db::notify::add(
350
        &app.db,
351
        oxygenhub::db::notify::New {
352
            account_id: bob_id,
353
            repo_id: None,
354
            reason: oxygenhub::db::notify::Reason::Participating,
355
            kind: "mention",
356
            title: "andy/demo#1: Bug",
357
            url: "/andy/demo/issue/1",
358
            actor: "andy",
359
        },
360
    )
361
    .await
362
    .unwrap();
363
    oxygenhub::db::notify::add(
364
        &app.db,
365
        oxygenhub::db::notify::New {
366
            account_id: bob_id,
367
            repo_id: None,
368
            reason: oxygenhub::db::notify::Reason::Participating,
369
            kind: "review",
370
            title: "andy/demo#2: Feat",
371
            url: "/andy/demo/proposal/2",
372
            actor: "andy",
373
        },
374
    )
375
    .await
376
    .unwrap();
377
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
378
    assert_eq!(st, StatusCode::OK, "{v}");
379
    assert_eq!(v["unread"], 2);
380
    assert_eq!(v["items"][0]["read"], false);
381
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
382
    let first = v["items"][0]["id"].as_i64().unwrap();
383
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
384
    assert_eq!(st, StatusCode::NO_CONTENT);
385
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
386
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
387
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
388
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
389
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
390
391
    // Review requests: the author asks andy; andy is told, reviews, and the
392
    // request is answered; the author hears of the review.
393
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
394
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
395
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
396
        .await
397
        .unwrap();
398
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
399
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
400
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
401
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
402
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
403
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
404
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
405
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
406
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
407
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
408
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
409
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
410
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
411
    let (st, _) =
412
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
413
    assert_eq!(st, StatusCode::CREATED);
414
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
415
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
416
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
417
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
418
    // Asking again and withdrawing it.
419
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
420
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
421
    assert_eq!(st, StatusCode::NO_CONTENT);
422
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
423
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
424
    // oxygenhub#84: the page's menu sets who is asked, all at once.
425
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
426
    assert!(
427
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
428
        "the reviewers menu lists andy"
429
    );
430
    let csrf = csrf_of(&page.body);
431
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
432
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
433
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
434
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
435
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
436
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
437
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
438
439
    // A source bookmark with `/` in its name, as a feature/N-name workflow
440
    // makes them: by name, and as this repository's owner/name:bookmark.
441
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
442
        client.bookmark_create(b, Some(&[base])).unwrap();
443
        client.bookmark_switch(b, false).unwrap();
444
        write(work.path(), file, b"c\n");
445
        client.snapshot("t").unwrap();
446
        client.commit(b, &[]).unwrap();
447
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
448
    }
449
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
450
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
451
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
452
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
453
        let n = v["number"].as_i64().unwrap();
454
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
455
        assert_eq!(page.status, StatusCode::OK);
456
        assert!(page.body.contains("feature/"), "the page names its source");
457
    }
458
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
459
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
460
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
461
462
    // oxygenhub#76: a proposal's title and description are edited through
463
    // the API by its author or a maintainer; what is not given stays.
464
    let edit = |token: &str, number: i64, body: &str| {
465
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
466
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
467
    };
468
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
469
    assert_eq!(st, StatusCode::OK, "{v}");
470
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
471
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
472
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
473
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
474
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
475
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
476
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
477
    let (st, v) = api(
478
        app,
479
        "POST",
480
        "/api/v1/repos/andy/demo/proposals",
481
        Some(&andy_pw),
482
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
483
    )
484
    .await;
485
    assert_eq!(st, StatusCode::CREATED, "{v}");
486
    let n = v["number"].as_i64().unwrap();
487
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
488
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
489
490
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
491
    // before anything changes, shown in its JSON.
492
    for l in ["ui", "flow"] {
493
        let body = format!(r#"{{"name":"{l}"}}"#);
494
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
495
    }
496
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
497
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
498
    assert_eq!(st, StatusCode::OK, "{v}");
499
    let names = |v: &serde_json::Value| -> Vec<String> {
500
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
501
    };
502
    assert_eq!(names(&v), ["flow", "ui"]);
503
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
504
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
505
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
506
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
507
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
508
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
509
    assert_eq!(names(&v), ["flow"]);
510
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
511
}
512
513
#[tokio::test(flavor = "multi_thread")]
514
async fn api_issue_triage_and_labels() {
515
    let h = hub().await;
516
    let app = &h.app;
517
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
518
        .await
519
        .cookie
520
        .unwrap();
521
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
522
        .await
523
        .cookie
524
        .unwrap();
525
    let mint = |cookie: String, scopes: &'static str| {
526
        let app = app.clone();
527
        async move {
528
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
529
            let csrf = csrf_of(&page.body);
530
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
531
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
532
        }
533
    };
534
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
535
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
536
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
537
    assert_eq!(st, StatusCode::CREATED);
538
539
    // Labels through the API; bad colours and non-triage callers are refused.
540
    let (st, v) = api(
541
        app,
542
        "POST",
543
        "/api/v1/repos/andy/demo/labels",
544
        Some(&andy_t),
545
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
546
    )
547
    .await;
548
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
549
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
550
    assert_eq!(
551
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
552
        StatusCode::BAD_REQUEST
553
    );
554
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
555
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
556
    assert_eq!(labels.as_array().unwrap().len(), 2);
557
    // oxygenhub#91: milestones over the API, for triage.
558
    let (st, m) = api(
559
        app,
560
        "POST",
561
        "/api/v1/repos/andy/demo/milestones",
562
        Some(&andy_t),
563
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
564
    )
565
    .await;
566
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
567
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
568
    assert_eq!(
569
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
570
        StatusCode::BAD_REQUEST
571
    );
572
    assert_eq!(
573
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
574
        StatusCode::FORBIDDEN
575
    );
576
    let (st, m) =
577
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
578
            .await;
579
    assert_eq!(
580
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
581
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
582
        "{m}"
583
    );
584
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
585
    assert_eq!(
586
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
587
        StatusCode::NOT_FOUND,
588
        "renamed"
589
    );
590
    assert_eq!(
591
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
592
        StatusCode::BAD_REQUEST
593
    );
594
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
595
    assert_eq!(list.as_array().unwrap().len(), 1);
596
597
    // An issue created with its labels and assignee in one call.
598
    let (st, v) = api(
599
        app,
600
        "POST",
601
        "/api/v1/repos/andy/demo/issues",
602
        Some(&andy_t),
603
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
604
    )
605
    .await;
606
    assert_eq!(st, StatusCode::CREATED, "{v}");
607
    assert_eq!(v["labels"][0]["name"], "bug");
608
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
609
    let n = v["number"].as_i64().unwrap();
610
    // Unknown names are refused before anything is created.
611
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
612
    assert_eq!(st, StatusCode::BAD_REQUEST);
613
    assert!(v["detail"].as_str().unwrap().contains("no label"));
614
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
615
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
616
    // Without triage, labels cannot be set, but a plain issue can be opened.
617
    assert_eq!(
618
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
619
        StatusCode::FORBIDDEN
620
    );
621
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
622
    assert_eq!(st, StatusCode::CREATED);
623
    let bob_n = bobs["number"].as_i64().unwrap();
624
625
    // PATCH: the whole label set, assignees and milestone, with events.
626
    let (st, v) =
627
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
628
            .await;
629
    assert_eq!(st, StatusCode::OK, "{v}");
630
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
631
    assert_eq!(v["assignees"], serde_json::json!([]));
632
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
633
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
634
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
635
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
636
    // The author edits their own title; others cannot; nobody but triage sets labels.
637
    let (st, v) =
638
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
639
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
640
    assert_eq!(
641
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
642
        StatusCode::FORBIDDEN
643
    );
644
    assert_eq!(
645
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
646
        StatusCode::FORBIDDEN
647
    );
648
    assert_eq!(
649
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
650
        StatusCode::BAD_REQUEST
651
    );
652
653
    // Deleting a label takes it off the issues.
654
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
655
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
656
    assert_eq!(v["labels"], serde_json::json!([]));
657
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
658
}
659
660
#[tokio::test(flavor = "multi_thread")]
661
async fn webhook_formats_editing_and_web_issue_events() {
662
    let h = hub().await;
663
    let app = &h.app;
664
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
665
        .await
666
        .cookie
667
        .unwrap();
668
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
669
    let r = call(
670
        app,
671
        "POST",
672
        "/settings/tokens",
673
        None,
674
        Some(&andy),
675
        None,
676
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
677
    )
678
    .await;
679
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
680
    assert_eq!(
681
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
682
        StatusCode::CREATED
683
    );
684
    let rx = receiver().await;
685
    *rx.fail_first.lock().unwrap() = false;
686
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
687
    let csrf = csrf_of(&settings);
688
    let form = |f: String| {
689
        let andy = andy.clone();
690
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
691
    };
692
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
693
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
694
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
695
    assert_eq!(hook.format, "discord");
696
    // Ping arrives as a Discord message.
697
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
698
    let mut got = String::new();
699
    for _ in 0..100 {
700
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
701
            got = body.clone();
702
        }
703
        if !got.is_empty() {
704
            break;
705
        }
706
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
707
    }
708
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
709
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
710
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
711
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
712
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
713
714
    // Editing: a blank URL and secret keep theirs; format, events and active change.
715
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
716
        .await
717
        .contains("Webhook saved"));
718
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
719
    assert_eq!(
720
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
721
        (rx.url.as_str(), "issue", "oxygenhub", true)
722
    );
723
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
724
725
    // An issue opened on the web now reaches the hook, as the signed envelope.
726
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
727
    call(
728
        app,
729
        "POST",
730
        "/andy/demo/issues/new",
731
        None,
732
        Some(&andy),
733
        None,
734
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
735
    )
736
    .await;
737
    let mut envelope = None;
738
    for _ in 0..100 {
739
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
740
        if envelope.is_some() {
741
            break;
742
        }
743
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
744
    }
745
    let (_, sig, body) = envelope.expect("issue.opened delivered");
746
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
747
    assert_eq!(v["data"]["issue"]["title"], "From the web");
748
    assert!(sig.starts_with("blake3-keyed="));
749
    // A disabled hook through the edit form (no active box).
750
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
751
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
752
}
753
754
#[tokio::test(flavor = "multi_thread")]
755
async fn api_projects() {
756
    let h = hub().await;
757
    let app = &h.app;
758
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
759
        .await
760
        .cookie
761
        .unwrap();
762
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
763
        .await
764
        .cookie
765
        .unwrap();
766
    let mint = |cookie: String, scopes: &'static str| {
767
        let app = app.clone();
768
        async move {
769
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
770
            let csrf = csrf_of(&page.body);
771
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
772
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
773
        }
774
    };
775
    let a = mint(andy, "scopes=repo%3Aadmin").await;
776
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
777
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
778
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
779
780
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
781
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
782
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
783
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
784
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
785
786
    // Cards by reference, into a column by name, and a note into the first column.
787
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
788
    assert_eq!(st, StatusCode::CREATED, "{card}");
789
    assert_eq!(
790
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
791
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
792
    );
793
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
794
    assert_eq!(st, StatusCode::BAD_REQUEST);
795
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
796
    assert_eq!(
797
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
798
        StatusCode::BAD_REQUEST
799
    );
800
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
801
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
802
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
803
804
    // Move and read the board.
805
    let id = card["id"].as_i64().unwrap();
806
    assert_eq!(
807
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
808
        StatusCode::NO_CONTENT
809
    );
810
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
811
    let names: Vec<(&str, usize)> =
812
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
813
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
814
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
815
    // The cards by column (#115), and a wrong method answers with a body.
816
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
817
    assert_eq!(st, StatusCode::OK);
818
    assert_eq!(cols, board["columns"]);
819
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
820
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
821
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
822
823
    // Private: hidden from others; closed: read-only; then remove a card.
824
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
825
    assert_eq!(edited["public"], false);
826
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
827
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
828
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
829
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
830
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
831
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
832
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
833
}
834
835
#[tokio::test(flavor = "multi_thread")]
836
async fn api_required_checks() {
837
    let h = hub().await;
838
    let app = &h.app;
839
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
840
        .await
841
        .cookie
842
        .unwrap();
843
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
844
    let csrf = csrf_of(&page.body);
845
    let mint = |scopes: &'static str| {
846
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
847
        async move {
848
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
849
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
850
        }
851
    };
852
    let admin = mint("scopes=repo%3Aadmin").await;
853
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
854
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
855
856
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
857
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
858
    let (st, v) = api(
859
        app,
860
        "PUT",
861
        "/api/v1/repos/andy/demo/checks/required",
862
        Some(&admin),
863
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
864
    )
865
    .await;
866
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
867
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
868
    assert_eq!(
869
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
870
        serde_json::json!(["flow/fmt", "flow/test"])
871
    );
872
    assert_eq!(
873
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
874
        StatusCode::FORBIDDEN,
875
        "repo:admin only"
876
    );
877
    assert_eq!(
878
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
879
        StatusCode::BAD_REQUEST
880
    );
881
    // The settings page shows the same list.
882
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
883
}
884
885
/// OxygenFlow per repository: site administrators turn it on or off in
886
/// the repository's settings; hub.toml's `[flow] repos` is the default.
887
#[tokio::test(flavor = "multi_thread")]
888
async fn flow_is_switched_per_repository_by_site_admins() {
889
    let h = hub().await;
890
    let app = &h.app;
891
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
892
        .await
893
        .cookie
894
        .unwrap();
895
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
896
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
897
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
898
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
899
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
900
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
901
902
    let set = |value: &'static str| {
903
        let (app, andy) = (app.clone(), andy.clone());
904
        async move {
905
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
906
            call(
907
                &app,
908
                "POST",
909
                "/andy/demo/settings/flow",
910
                None,
911
                Some(&andy),
912
                None,
913
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
914
            )
915
            .await
916
        }
917
    };
918
    // A repository admin who is not a site admin sees the state but cannot change it.
919
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
920
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
921
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
922
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
923
    let r = set("on").await;
924
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
925
    assert_eq!(row().await.flow, "");
926
927
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
928
    let r = set("on").await;
929
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
930
    assert_eq!(row().await.flow, "on");
931
    assert!(oxygenhub::flow::enabled(app, &row().await));
932
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
933
    set("off").await;
934
    assert!(!oxygenhub::flow::enabled(app, &row().await));
935
    set("default").await;
936
    assert_eq!(row().await.flow, "");
937
    assert!(set("sometimes").await.body.contains("Pick on, off"));
938
}
939
940
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
941
/// button, never the repository's default bookmark as the hub sets it.
942
#[tokio::test(flavor = "multi_thread")]
943
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
944
    let h = hub().await;
945
    let app = &h.app;
946
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
947
        .await
948
        .cookie
949
        .unwrap();
950
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
951
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
952
    let url = format!("{}/andy/demo", h.base);
953
    let work = tempfile::tempdir().unwrap();
954
    let (w, u) = (work.path().to_path_buf(), url.clone());
955
    let client = tokio::task::spawn_blocking(move || {
956
        let mut c = Repo::init(&w).unwrap();
957
        c.config.set("remote.origin.url", &u).unwrap();
958
        c.config.set("remote.origin.token", "site").unwrap();
959
        c.save_config().unwrap();
960
        write(&w, "a.txt", b"a\n");
961
        c.commit("a", &[]).unwrap();
962
        assert!(c.push("origin", false).unwrap()[0].ok);
963
        for b in ["develop", "feature/x", "stray"] {
964
            c.bookmark_create(b, None).unwrap();
965
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
966
        }
967
        // A pushed deletion.
968
        let r = c.push_delete("origin", "feature/x").unwrap();
969
        assert!(r[0].ok, "{r:?}");
970
        c
971
    })
972
    .await
973
    .unwrap();
974
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
975
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
976
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
977
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
978
    assert!(!anon.body.contains("/bookmarks/delete"));
979
980
    // The hub's default, not the repository's config, is protected: make
981
    // develop the default, then main can go and develop cannot.
982
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
983
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
984
    let client = tokio::task::spawn_blocking(move || {
985
        let r = client.push_delete("origin", "develop").unwrap();
986
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
987
        let r = client.push_delete("origin", "main").unwrap();
988
        assert!(r[0].ok, "{r:?}");
989
        client
990
    })
991
    .await
992
    .unwrap();
993
    drop(client);
994
995
    // On the web: a writer deletes stray; the default is refused.
996
    let form = |b: &'static str| {
997
        let (app, andy) = (app.clone(), andy.clone());
998
        async move {
999
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1000
            call(
1001
                &app,
1002
                "POST",
1003
                "/andy/demo/bookmarks/delete",
1004
                None,
1005
                Some(&andy),
1006
                None,
1007
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1008
            )
1009
            .await
1010
        }
1011
    };
1012
    let r = form("stray").await;
1013
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1014
    assert!(!r.body.contains(">stray<"));
1015
    let r = form("develop").await;
1016
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1017
    let r = form("nope").await;
1018
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1019
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1020
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1021
    // Anonymous visitors cannot.
1022
    assert_ne!(
1023
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1024
        StatusCode::OK
1025
    );
1026
}
1027
1028
/// A change signed by a key no account has linked says so, on its page
1029
/// and in the API (feedback 14).
1030
#[tokio::test(flavor = "multi_thread")]
1031
async fn changes_signed_by_unlinked_keys_say_so() {
1032
    let h = hub().await;
1033
    let app = &h.app;
1034
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1035
        .await
1036
        .cookie
1037
        .unwrap();
1038
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1039
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1040
    let url = format!("{}/andy/demo", h.base);
1041
    let work = tempfile::tempdir().unwrap();
1042
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1043
    let hash = tokio::task::spawn_blocking(move || {
1044
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1045
        c.config.set("remote.origin.url", &u).unwrap();
1046
        c.config.set("remote.origin.token", "site").unwrap();
1047
        c.save_config().unwrap();
1048
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1049
        write(&w.join("r"), "a.txt", b"a\n");
1050
        let h = c.commit("signed by Ada", &[]).unwrap();
1051
        assert!(c.push("origin", false).unwrap()[0].ok);
1052
        h.to_hex()
1053
    })
1054
    .await
1055
    .unwrap();
1056
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1057
    assert_eq!(st, StatusCode::OK, "{v}");
1058
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1059
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1060
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1061
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1062
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1063
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1064
}
1065
1066
/// Function history (hub spec §6.6): the file page lists a file's
1067
/// functions, and a function's page lists exactly the changes to its lines.
1068
#[tokio::test(flavor = "multi_thread")]
1069
async fn a_function_has_its_own_history() {
1070
    let h = hub().await;
1071
    let app = &h.app;
1072
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1073
        .await
1074
        .cookie
1075
        .unwrap();
1076
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1077
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1078
    let url = format!("{}/andy/demo", h.base);
1079
    let work = tempfile::tempdir().unwrap();
1080
    let w = work.path().to_path_buf();
1081
    tokio::task::spawn_blocking(move || {
1082
        let mut c = Repo::init(&w).unwrap();
1083
        c.config.set("remote.origin.url", &url).unwrap();
1084
        c.config.set("remote.origin.token", "site").unwrap();
1085
        c.save_config().unwrap();
1086
        let steps = [
1087
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1088
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1089
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1090
        ];
1091
        for (msg, text) in steps {
1092
            write(&w, "src/lib.rs", text.as_bytes());
1093
            c.commit(msg, &[]).unwrap();
1094
        }
1095
        assert!(c.push("origin", false).unwrap()[0].ok);
1096
    })
1097
    .await
1098
    .unwrap();
1099
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1100
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1101
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1102
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1103
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1104
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1105
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1106
    assert_ne!(bad.status, StatusCode::OK);
1107
}
1108
1109
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1110
/// dependency edges, linked cards.
1111
#[tokio::test(flavor = "multi_thread")]
1112
async fn a_bookmark_shows_as_swimlanes() {
1113
    let h = hub().await;
1114
    let app = &h.app;
1115
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1116
        .await
1117
        .cookie
1118
        .unwrap();
1119
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1120
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1121
    let url = format!("{}/andy/demo", h.base);
1122
    let work = tempfile::tempdir().unwrap();
1123
    let w = work.path().to_path_buf();
1124
    tokio::task::spawn_blocking(move || {
1125
        let mut c = Repo::init(&w).unwrap();
1126
        c.config.set("remote.origin.url", &url).unwrap();
1127
        c.config.set("remote.origin.token", "site").unwrap();
1128
        c.save_config().unwrap();
1129
        // Two files edited independently: two lanes.
1130
        write(&w, "a.txt", b"a\n");
1131
        c.commit("add a", &[]).unwrap();
1132
        write(&w, "b.txt", b"b\n");
1133
        c.commit("add b", &[]).unwrap();
1134
        write(&w, "a.txt", b"a\na2\n");
1135
        c.commit("grow a", &[]).unwrap();
1136
        assert!(c.push("origin", false).unwrap()[0].ok);
1137
    })
1138
    .await
1139
    .unwrap();
1140
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1141
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1142
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1143
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1144
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1145
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1146
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1147
    assert_eq!(board.matches("<rect ").count(), 3);
1148
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1149
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1150
}
1151
1152
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1153
/// offers only what makes sense and rewrites nothing itself.
1154
#[tokio::test(flavor = "multi_thread")]
1155
async fn a_proposal_board_plans_squashes_and_rebases() {
1156
    let h = hub().await;
1157
    let app = &h.app;
1158
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1159
        .await
1160
        .cookie
1161
        .unwrap();
1162
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1163
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1164
    let url = format!("{}/andy/demo", h.base);
1165
    let work = tempfile::tempdir().unwrap();
1166
    let w = work.path().to_path_buf();
1167
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1168
        let mut c = Repo::init(&w).unwrap();
1169
        c.config.set("remote.origin.url", &url).unwrap();
1170
        c.config.set("remote.origin.token", "site").unwrap();
1171
        c.save_config().unwrap();
1172
        write(&w, "a.txt", b"a\n");
1173
        let base = c.commit("base", &[]).unwrap();
1174
        assert!(c.push("origin", false).unwrap()[0].ok);
1175
        c.bookmark_create("feature", None).unwrap();
1176
        c.bookmark_switch("feature", false).unwrap();
1177
        write(&w, "a.txt", b"a\nfirst\n");
1178
        let first = c.commit("first", &[]).unwrap();
1179
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1180
        let second = c.commit("second", &[]).unwrap();
1181
        write(&w, "b.txt", b"apart\n");
1182
        let apart = c.commit("apart", &[]).unwrap();
1183
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1184
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1185
    })
1186
    .await
1187
    .unwrap();
1188
    // No proposal yet: the board is read-only.
1189
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1190
    assert!(!board.contains("data-plan="));
1191
    let (st, _) = api(
1192
        app,
1193
        "POST",
1194
        "/api/v1/repos/andy/demo/proposals",
1195
        Some("site"),
1196
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1197
    )
1198
    .await;
1199
    assert!(st.is_success(), "{st}");
1200
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1201
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1202
    let csrf = csrf_of(&board);
1203
    let plan = |c: &str, t: &str| {
1204
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1205
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1206
        async move {
1207
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1208
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1209
        }
1210
    };
1211
    let kinds = |v: &serde_json::Value| {
1212
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1213
    };
1214
    // second already depends on first: squash, no rebase.
1215
    let v = plan(&second, &first).await;
1216
    assert_eq!(kinds(&v), ["squash"], "{v}");
1217
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1218
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygen.oxygen-vscode/plan?"));
1219
    // apart is independent of second: either.
1220
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1221
    // first under second: nothing (second depends on first).
1222
    assert!(plan(&first, &second).await["error"].is_string());
1223
    // What has landed on main is not rearranged.
1224
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1225
}
1226
1227
/// Issues and proposals share a number space, so every number says what it
1228
/// is, and the chain of work shows from both ends (hub spec §8).
1229
#[tokio::test(flavor = "multi_thread")]
1230
async fn proposals_and_issues_show_their_chain() {
1231
    let h = hub().await;
1232
    let app = &h.app;
1233
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1234
        .await
1235
        .cookie
1236
        .unwrap();
1237
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1238
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1239
    let url = format!("{}/andy/demo", h.base);
1240
    let work = tempfile::tempdir().unwrap();
1241
    let w = work.path().to_path_buf();
1242
    tokio::task::spawn_blocking(move || {
1243
        let mut c = Repo::init(&w).unwrap();
1244
        c.config.set("remote.origin.url", &url).unwrap();
1245
        c.config.set("remote.origin.token", "site").unwrap();
1246
        c.save_config().unwrap();
1247
        write(&w, "a.txt", b"a\n");
1248
        c.commit("base", &[]).unwrap();
1249
        assert!(c.push("origin", false).unwrap()[0].ok);
1250
        c.bookmark_create("feature", None).unwrap();
1251
        c.bookmark_switch("feature", false).unwrap();
1252
        write(&w, "a.txt", b"a\nfixed\n");
1253
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1254
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1255
    })
1256
    .await
1257
    .unwrap();
1258
    for title in ["Slow start", "Crash on save"] {
1259
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1260
        assert!(st.is_success());
1261
    }
1262
    let (st, v) = api(
1263
        app,
1264
        "POST",
1265
        "/api/v1/repos/andy/demo/proposals",
1266
        Some("site"),
1267
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1268
    )
1269
    .await;
1270
    assert!(st.is_success(), "{st} {v}");
1271
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1272
1273
    // The proposal names its kind, links its references by kind, and shows
1274
    // the chain: the issues it closes (description and changes) → it → main.
1275
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1276
    assert!(p.contains(">proposal #3</small>"), "header");
1277
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1278
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1279
    let chain = &chain[..chain.find("</p>").unwrap()];
1280
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1281
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1282
    }
1283
    assert!(p.contains("<h3>Closes</h3>"));
1284
1285
    // The issue shows the proposal that closes it, and names its own kind.
1286
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1287
    assert!(i.contains(">issue #1</small>"));
1288
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1289
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1290
    // The conversation is a timeline with avatars; editing sits with the
1291
    // content, not in the sidebar, and labels and projects are editable.
1292
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1293
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1294
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1295
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1296
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1297
    assert!(st.is_success(), "{st}");
1298
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1299
    assert!(
1300
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1301
        "the owner's projects to add to, in a menu"
1302
    );
1303
    let csrf = csrf_of(&p);
1304
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1305
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1306
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1307
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1308
        .await;
1309
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1310
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1311
1312
    // Closed by the proposal's change, not its description: still shown.
1313
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1314
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1315
    assert!(chain.contains("proposal #3"), "{chain}");
1316
}
1317
1318
/// What the hub is: its version and build, and the libraries it is built on,
1319
/// on /about, in the API and in /health (hub spec §15).
1320
#[tokio::test(flavor = "multi_thread")]
1321
async fn the_hub_says_what_version_it_is() {
1322
    let h = hub().await;
1323
    let app = &h.app;
1324
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1325
    assert_eq!(st, StatusCode::OK);
1326
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1327
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1328
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1329
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1330
    assert!(health.contains("\"build\""), "{health}");
1331
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1332
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1333
    assert!(about.contains("href=\"/about\""), "the footer links here");
1334
}
1335
1336
#[tokio::test(flavor = "multi_thread")]
1337
async fn device_sign_in() {
1338
    let h = hub().await;
1339
    let app = &h.app;
1340
    let r =
1341
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1342
    let andy = r.cookie.unwrap();
1343
1344
    // An unknown scope is refused.
1345
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1346
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1347
1348
    // The app asks for a code and polls; nobody has approved it yet.
1349
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1350
    assert_eq!(st, StatusCode::OK, "{v}");
1351
    let device = v["device_code"].as_str().unwrap().to_string();
1352
    let user = v["user_code"].as_str().unwrap().to_string();
1353
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1354
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1355
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1356
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1357
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1358
    assert_eq!(v["error"], "slow_down", "polled too soon");
1359
1360
    // The user approves it on the web, allowing less than it asked for.
1361
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1362
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1363
    let csrf = csrf_of(&page.body);
1364
    let r =
1365
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1366
            .await;
1367
    // oxygenhub#83: the answer page says it is done, with no code form.
1368
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1369
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1370
1371
    // The next poll gets a token with what was allowed, once.
1372
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1373
    assert_eq!(st, StatusCode::OK, "{v}");
1374
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1375
    let token = v["access_token"].as_str().unwrap().to_string();
1376
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1377
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1378
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1379
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1380
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1381
    assert!(tokens.body.contains("device: Phone app"));
1382
    // oxygenhub#70: a device's token expires, and each use renews it.
1383
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1384
1385
    // The token can revoke itself (oxy auth logout), and is then refused.
1386
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1387
    assert_eq!(st, StatusCode::NO_CONTENT);
1388
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1389
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1390
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1391
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1392
1393
    // A denied code says so.
1394
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1395
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1396
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1397
    let csrf = csrf_of(&page.body);
1398
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1399
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1400
    assert_eq!(v["error"], "access_denied");
1401
1402
    // Signed out, the page asks for a sign-in first.
1403
    let r = call(app, "GET", "/device", None, None, None, None).await;
1404
    assert!(r.status.is_redirection(), "{}", r.status);
1405
}
1406
1407
#[tokio::test(flavor = "multi_thread")]
1408
async fn api_assistants_at_each_level() {
1409
    let h = hub().await;
1410
    let app = &h.app;
1411
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1412
        .await
1413
        .cookie
1414
        .unwrap();
1415
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1416
    let csrf = csrf_of(&page.body);
1417
    let mint = |scopes: &'static str| {
1418
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1419
        async move {
1420
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1421
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1422
        }
1423
    };
1424
    let admin = mint("scopes=repo%3Aadmin").await;
1425
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1426
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1427
    // A stand-in endpoint with no model list: any model name is taken.
1428
    let router = axum::Router::new().route(
1429
        "/v1/chat/completions",
1430
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1431
    );
1432
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1433
    let port = listener.local_addr().unwrap().port();
1434
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1435
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1436
1437
    // The site's, by its administrator; the repository's, by its admin.
1438
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1439
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1440
    assert_eq!(st, StatusCode::OK, "{v}");
1441
    assert_eq!(v["ok"], "Gemini added");
1442
    let body =
1443
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1444
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1445
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1446
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1447
    assert_eq!(st, StatusCode::OK, "{v}");
1448
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1449
    assert_eq!(st, StatusCode::OK);
1450
    let names: Vec<(&str, &str, bool)> = v
1451
        .as_array()
1452
        .unwrap()
1453
        .iter()
1454
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1455
        .collect();
1456
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1457
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1458
    // Changing it keeps the token when none is given.
1459
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1460
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1461
    assert_eq!(v["ok"], "Claude updated");
1462
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1463
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1464
    // Prompts: the site's is inherited by the repository.
1465
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1466
    assert_eq!(st, StatusCode::OK);
1467
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1468
    assert_eq!(v["prompt"], "Rust.");
1469
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1470
    // Removed.
1471
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1472
    assert_eq!(st, StatusCode::NO_CONTENT);
1473
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1474
    assert_eq!(st, StatusCode::NOT_FOUND);
1475
}