OXYGENHUB
# 417184c73f4e oxygenhub / crates / hub / tests / issues.rs
55.7 KiB · Rust · last changed feat: backups for users and organisations, to a directory, with restore (refs #169) 22 days ago source blame history raw
18e381ea Andy McCall ↶ 1
//! Milestone 0.4 end to end: issues with labels, assignees and
2
//! milestones, cross references, closing keywords on landing, the inbox,
3
//! watching, mentions and search.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use http_body_util::BodyExt;
8
use oxy_core::repo::Repo;
9
use oxygenhub::config::Config;
10
use oxygenhub::db;
11
use oxygenhub::repos::RepoName;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use tower::ServiceExt;
15
16
fn hermetic() {
17
    static ONCE: std::sync::Once = std::sync::Once::new();
18
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
19
    ONCE.call_once(|| {
20
        let d = tempfile::tempdir().unwrap();
21
        std::env::set_var("OXY_HOME", d.path());
22
        DIR.set(d).ok();
23
    });
24
}
25
26
fn write(root: &Path, rel: &str, content: &[u8]) {
27
    let p = root.join(rel);
28
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
29
    std::fs::write(p, content).unwrap();
30
}
31
32
struct Hub {
33
    app: Shared,
34
    base: String,
35
    _dir: tempfile::TempDir,
36
}
37
38
async fn hub() -> Hub {
39
    hermetic();
40
    let dir = tempfile::tempdir().unwrap();
41
    let mut config = Config::load(dir.path()).unwrap();
42
    config.auth.push_tokens = vec!["site".into()];
43
    config.registration.mode = "open".into();
44
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
45
    let port = listener.local_addr().unwrap().port();
46
    config.server.base_url = format!("http://127.0.0.1:{port}");
47
    let app = oxygenhub::build(config).await.unwrap();
48
    let router = oxygenhub::router(app.clone());
49
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
50
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
51
}
52
53
struct Res {
54
    status: StatusCode,
55
    body: String,
56
    cookie: Option<String>,
57
    location: Option<String>,
58
}
59
60
async fn send(app: &Shared, method: &str, path: &str, cookie: Option<&str>, form: Option<&str>) -> Res {
61
    let mut req = Request::builder().method(method).uri(path);
62
    if let Some(c) = cookie {
63
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
64
    }
65
    let body = match form {
66
        Some(f) => {
67
            req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
68
            Body::from(f.to_string())
69
        }
70
        None => Body::empty(),
71
    };
72
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
73
    let status = res.status();
74
    let cookie = res
75
        .headers()
76
        .get(header::SET_COOKIE)
77
        .and_then(|v| v.to_str().ok())
78
        .and_then(|v| v.split(';').next())
79
        .and_then(|kv| kv.split_once('='))
80
        .map(|(_, v)| v.to_string());
81
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
82
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
83
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
84
}
85
86
async fn get(app: &Shared, path: &str, cookie: Option<&str>) -> Res {
87
    send(app, "GET", path, cookie, None).await
88
}
89
90
async fn post(app: &Shared, path: &str, cookie: Option<&str>, form: &str) -> Res {
91
    send(app, "POST", path, cookie, Some(form)).await
92
}
93
94
async fn register(app: &Shared, user: &str) -> String {
95
    let r = post(app, "/register", None, &format!("username={user}&email={user}%40example.com&password=correct-horse-battery")).await;
96
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
97
    r.cookie.unwrap()
98
}
99
100
fn csrf_of(page: &str) -> String {
101
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
102
    page[i..].split('"').next().unwrap().to_string()
103
}
104
105
#[tokio::test(flavor = "multi_thread")]
106
async fn issues_notifications_and_search() {
107
    let h = hub().await;
108
    let app = &h.app;
109
    let andy = register(app, "andy").await;
110
    let bob = register(app, "bob").await;
111
    let repo = RepoName::parse("andy/demo").unwrap();
112
    app.repos.create(&repo, None).unwrap();
113
    db::repos::create(&app.db, "andy", "demo", "", hub_api::Visibility::Public).await.unwrap();
114
115
    // Labels and a milestone, by the owner.
116
    let labels_page = get(app, "/andy/demo/labels", Some(&andy)).await;
117
    let csrf_a = csrf_of(&labels_page.body);
118
    assert!(post(app, "/andy/demo/labels", Some(&andy), &format!("_csrf={csrf_a}&name=bug&colour=%23ff0000&description=Something+broke"))
119
        .await
120
        .body
121
        .contains("Saved bug"));
122
    assert!(post(app, "/andy/demo/milestones", Some(&andy), &format!("_csrf={csrf_a}&title=v1&description=First&due=2027-01-01"))
123
        .await
124
        .body
125
        .contains("v1"));
126
    assert_eq!(get(app, "/andy/demo/labels", Some(&bob)).await.status, StatusCode::OK, "readers see labels");
127
    assert!(!get(app, "/andy/demo/labels", Some(&bob)).await.body.contains("Add or change"), "but cannot edit them");
128
129
    // Bob watches the repository, then Andy opens an issue mentioning @bob: Bob is told twice at most once.
130
    let overview = get(app, "/andy/demo", Some(&bob)).await;
131
    let csrf_b = csrf_of(&overview.body);
132
    assert_eq!(post(app, "/andy/demo/watch", Some(&bob), &format!("_csrf={csrf_b}")).await.status, StatusCode::SEE_OTHER);
133
    assert!(get(app, "/andy/demo", Some(&bob)).await.body.contains("UNWATCH"));
134
    let new_page = get(app, "/andy/demo/issues/new", Some(&andy)).await;
135
    let csrf_a = csrf_of(&new_page.body);
136
    let r = post(
137
        app,
138
        "/andy/demo/issues/new",
139
        Some(&andy),
140
        &format!("_csrf={csrf_a}&title=Crash+on+start&body=cc+%40bob+see+%23999+and+deadbeefcafe1234"),
141
    )
142
    .await;
143
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
144
    assert_eq!(r.location.as_deref(), Some("/andy/demo/issue/1"));
145
    let page = get(app, "/andy/demo/issue/1", Some(&bob)).await;
146
    assert!(page.body.contains("Crash on start"));
147
    assert!(page.body.contains("href=\"/bob\""), "mention linked: {}", page.body);
148
    assert!(page.body.contains("/andy/demo/change/deadbeefcafe1234"), "hash linked: {}", page.body);
149
    assert!(page.body.contains("#999") && !page.body.contains("issue/999"), "unknown numbers are not linked");
150
    let unread = db::notify::unread(&app.db, db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id).await.unwrap();
151
    assert_eq!(unread, 1, "one notification, not one per reason");
152
    let inbox = get(app, "/notifications", Some(&bob)).await;
153
    assert!(inbox.body.contains("andy/demo#1: Crash on start"), "{}", inbox.body);
154
    assert!(get(app, "/andy/demo", Some(&bob)).await.body.contains("class=\"count\">1<"), "bell shows the count");
155
156
    // Triage: labels, assignee, milestone, pin, lock.
157
    let page = get(app, "/andy/demo/issue/1", Some(&andy)).await;
158
    let csrf_a = csrf_of(&page.body);
159
    let label_id: i64 = sqlx::query_scalar("SELECT id FROM labels WHERE name = 'bug'").fetch_one(&app.db).await.unwrap();
160
    let r = post(app, "/andy/demo/issue/1/labels", Some(&andy), &format!("_csrf={csrf_a}&label={label_id}")).await;
161
    assert!(r.body.contains(">bug<"), "{}", r.body);
162
    let r = post(app, "/andy/demo/issue/1/assign", Some(&andy), &format!("_csrf={csrf_a}&username=bob&action=add")).await;
cb71e18e Andy McCall ↶ 163
    assert!(r.body.contains("<li><a href=\"/bob\"><img class=\"avatar xs\""), "{}", r.body);
164
    // oxygenhub#82: the sidebar's menu sets the whole list at once.
165
    assert!(r.body.contains("Assign people to this issue") && r.body.contains("data-menu-filter"), "the assignees menu");
166
    let r = post(app, "/andy/demo/issue/1/assign", Some(&andy), &format!("_csrf={csrf_a}&action=set&username=andy&username=bob")).await;
167
    let assigned = |db: sqlx::SqlitePool| async move {
168
        let id: i64 = sqlx::query_scalar("SELECT id FROM issues WHERE number = 1").fetch_one(&db).await.unwrap();
169
        let mut a = db::issues::assignees(&db, id).await.unwrap();
170
        a.sort();
171
        a
172
    };
173
    assert_eq!(assigned(app.db.clone()).await, ["andy", "bob"], "{}", r.status);
174
    post(app, "/andy/demo/issue/1/assign", Some(&andy), &format!("_csrf={csrf_a}&action=set&username=bob")).await;
175
    assert_eq!(assigned(app.db.clone()).await, ["bob"], "set takes off who is not listed");
18e381ea Andy McCall ↶ 176
    let ms_id: i64 = sqlx::query_scalar("SELECT id FROM milestones WHERE title = 'v1'").fetch_one(&app.db).await.unwrap();
177
    let r = post(app, "/andy/demo/issue/1/milestone", Some(&andy), &format!("_csrf={csrf_a}&milestone={ms_id}")).await;
178
    assert!(r.body.contains(">v1<"), "{}", r.body);
cb71e18e Andy McCall ↶ 179
    assert!(post(app, "/andy/demo/issue/1/state", Some(&andy), &format!("_csrf={csrf_a}&action=pin")).await.body.contains("Unpin issue"));
18e381ea Andy McCall ↶ 180
    assert_eq!(
181
        post(
182
            app,
183
            "/andy/demo/issue/1/state",
184
            Some(&bob),
185
            &format!("_csrf={}&action=lock", csrf_of(&get(app, "/andy/demo/issue/1", Some(&bob)).await.body))
186
        )
187
        .await
188
        .status,
189
        StatusCode::NOT_FOUND,
190
        "bob cannot lock"
191
    );
192
    // Filters on the list.
193
    let list = get(app, "/andy/demo/issues?q=label:bug+assignee:bob+milestone:v1", None).await;
194
    assert!(list.body.contains("Crash on start"), "{}", list.body);
195
    assert!(!get(app, "/andy/demo/issues?q=label:feature", None).await.body.contains("Crash on start"));
196
    assert!(get(app, "/andy/demo/milestones", None).await.body.contains("1 open, 0 closed"));
197
198
    // Bob comments and closes; the author is told; search finds the comment.
199
    let csrf_b = csrf_of(&get(app, "/andy/demo/issue/1", Some(&bob)).await.body);
200
    let r = post(app, "/andy/demo/issue/1/comment", Some(&bob), &format!("_csrf={csrf_b}&body=Reproduced+with+the+flux+capacitor")).await;
201
    assert!(r.body.contains("flux capacitor"), "{}", r.body);
202
    assert!(get(app, "/notifications", Some(&andy)).await.body.contains("andy/demo#1"));
203
    let s = get(app, "/search?q=capacitor", None).await;
204
    assert!(s.body.contains("Crash on start") && s.body.contains("<mark>capacitor</mark>"), "{}", s.body);
205
    let s = get(app, "/search?q=demo", None).await;
206
    assert!(s.body.contains("/andy/demo\""), "repository hit: {}", s.body);
207
    // Bob is not triage, but as an assignee of an open issue he can comment-and-close? No: only the author or triage.
208
    let r = post(app, "/andy/demo/issue/1/comment", Some(&bob), &format!("_csrf={csrf_b}&body=closing&close=completed")).await;
209
    assert!(r.body.contains(">open<") || r.body.contains("head\">open"), "still open: {}", r.body);
210
    let r = post(app, "/andy/demo/issue/1/comment", Some(&andy), &format!("_csrf={csrf_a}&body=fixed&close=completed")).await;
211
    assert!(r.body.contains("closed"), "{}", r.body);
212
    assert!(get(app, "/andy/demo/issues?state=closed", None).await.body.contains("Crash on start"));
213
214
    // A second issue closed by a change message pushed to the default bookmark.
215
    let csrf_a = csrf_of(&get(app, "/andy/demo/issues/new", Some(&andy)).await.body);
216
    assert_eq!(
217
        post(app, "/andy/demo/issues/new", Some(&andy), &format!("_csrf={csrf_a}&title=Typo&body=")).await.location.as_deref(),
218
        Some("/andy/demo/issue/2")
219
    );
220
    let work = tempfile::tempdir().unwrap();
221
    let mut client = Repo::init(work.path()).unwrap();
222
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
223
    client.config.set("remote.origin.token", "site").unwrap();
224
    client.save_config().unwrap();
225
    write(work.path(), "a.txt", b"a\n");
226
    client.snapshot("t").unwrap();
227
    client.commit("Fix the typo\n\nCloses #2", &[]).unwrap();
228
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
229
    tokio::time::sleep(std::time::Duration::from_millis(300)).await;
230
    let issue2 = db::issues::get(&app.db, db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id, 2).await.unwrap().unwrap();
231
    assert_eq!(issue2.state, "closed", "closed by the landed change");
232
    assert!(get(app, "/andy/demo/issue/2", None).await.body.contains("closed by change"));
233
234
    // Numbers are shared: the next proposal is #3, and /issue/3 redirects to it.
235
    client.bookmark_create("feat", None).unwrap();
236
    client.bookmark_switch("feat", false).unwrap();
237
    write(work.path(), "b.txt", b"b\n");
238
    client.snapshot("t").unwrap();
239
    client.commit("feat", &[]).unwrap();
240
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
241
    let csrf_a = csrf_of(&get(app, "/andy/demo/proposals/new?source=feat&target=main", Some(&andy)).await.body);
242
    let r = post(app, "/andy/demo/proposals/new", Some(&andy), &format!("_csrf={csrf_a}&title=Feat&target=main&source=feat")).await;
243
    assert_eq!(r.location.as_deref(), Some("/andy/demo/proposal/3"), "{}", r.body);
244
    assert_eq!(get(app, "/andy/demo/issue/3", None).await.location.as_deref(), Some("/andy/demo/proposal/3"));
245
    // A comment on the issue referencing #3 links to the proposal.
246
    let r = post(app, "/andy/demo/issue/2/comment", Some(&andy), &format!("_csrf={csrf_a}&body=see+%233")).await;
247
    assert!(r.body.contains("href=\"/andy/demo/proposal/3\""), "{}", r.body);
78001759 Andy McCall ↶ 248
    // `#N` in a pushed change's message lands on those timelines (hub spec §8).
249
    client.bookmark_switch("main", false).unwrap();
250
    write(work.path(), "c.txt", b"c\n");
251
    client.snapshot("t").unwrap();
252
    let r = client.commit("Tidy up (refs #1, see #3)", &[]).unwrap();
253
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
254
    tokio::time::sleep(std::time::Duration::from_millis(300)).await;
255
    let short = &r.to_hex()[..12];
256
    let one = get(app, "/andy/demo/issue/1", None).await.body;
257
    assert!(
258
        one.contains("referenced by change") && one.contains(&format!("href=\"/andy/demo/change/{short}\"")) && one.contains(" on main"),
259
        "{one}"
260
    );
261
    let three = get(app, "/andy/demo/proposal/3", Some(&andy)).await.body;
262
    assert!(three.contains("referenced by change") && three.contains(short), "proposals too");
263
    assert!(!get(app, "/andy/demo/issue/2", None).await.body.contains("referenced by change"), "a closing change records only that");
264
eb0c44a9 Andy McCall ↶ 265
    // Bob takes part in #1 (mentioned, assigned, commented) and only watches #3.
266
    let part = get(app, "/notifications?reason=participating", Some(&bob)).await.body;
267
    assert!(part.contains("andy/demo#1") && !part.contains("andy/demo#3: Feat"), "{part}");
268
    let watch = get(app, "/notifications?reason=watching", Some(&bob)).await.body;
269
    assert!(watch.contains("andy/demo#3: Feat") && !watch.contains("Crash on start"), "{watch}");
270
    let props = get(app, "/notifications?kind=proposal", Some(&bob)).await.body;
271
    assert!(props.contains("andy/demo#3: Feat") && !props.contains("andy/demo#1"), "kind filter");
272
    assert!(get(app, "/notifications?repo=andy/demo", Some(&bob)).await.body.contains("andy/demo#3: Feat"));
273
    assert!(get(app, "/notifications?repo=nobody/none", Some(&bob)).await.body.contains("Nothing matches these filters"));
274
    // One row per thread, however many events it had.
275
    let inbox = get(app, "/notifications", Some(&bob)).await.body;
276
    assert_eq!(inbox.matches("data-row-thread=\"/andy/demo/issue/1\"").count(), 1, "{inbox}");
277
    assert!(inbox.contains(" updates"), "the count of a busy thread");
278
    // Opening a thread marks it read and goes there.
279
    let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
280
    let newest: i64 = sqlx::query_scalar(
281
        "SELECT id FROM notifications WHERE account_id = ? AND thread = '/andy/demo/proposal/3' ORDER BY id DESC LIMIT 1",
282
    )
283
    .bind(bob_id)
284
    .fetch_one(&app.db)
285
    .await
286
    .unwrap();
287
    let before = db::notify::unread(&app.db, bob_id).await.unwrap();
288
    let r = get(app, &format!("/notifications/open/{newest}"), Some(&bob)).await;
289
    assert_eq!(r.location.as_deref(), Some("/andy/demo/proposal/3"));
290
    assert!(db::notify::unread(&app.db, bob_id).await.unwrap() < before);
291
    assert_eq!(get(app, &format!("/notifications/open/{newest}"), Some(&andy)).await.status, StatusCode::NOT_FOUND, "only your own");
292
    // Done sets a thread aside until something new happens in it.
293
    let csrf_b = csrf_of(&get(app, "/notifications", Some(&bob)).await.body);
294
    let r = post(
295
        app,
296
        "/notifications/thread",
297
        Some(&bob),
298
        &format!("_csrf={csrf_b}&thread=%2Fandy%2Fdemo%2Fissue%2F1&action=done&back=%2Fnotifications"),
299
    )
300
    .await;
301
    assert_eq!(r.location.as_deref(), Some("/notifications"));
302
    assert!(!get(app, "/notifications", Some(&bob)).await.body.contains("Crash on start"));
303
    assert!(get(app, "/notifications?view=done", Some(&bob)).await.body.contains("Crash on start"));
304
    post(app, "/andy/demo/issue/1/comment", Some(&andy), &format!("_csrf={csrf_a}&body=one+more+thing")).await;
305
    assert!(get(app, "/notifications", Some(&bob)).await.body.contains("Crash on start"), "back with the new comment");
306
    let r = post(
307
        app,
308
        "/notifications/thread",
309
        Some(&bob),
310
        &format!("_csrf={csrf_b}&thread=%2Fandy%2Fdemo%2Fissue%2F1&action=read&back=https%3A%2F%2Fevil.example"),
311
    )
312
    .await;
313
    assert_eq!(r.location.as_deref(), Some("/notifications"), "only back to the inbox");
314
18e381ea Andy McCall ↶ 315
    // Bob (watcher) heard about the proposal; the inbox marks all read.
316
    assert!(get(app, "/notifications", Some(&bob)).await.body.contains("andy/demo#3: Feat"));
317
    let csrf_b = csrf_of(&get(app, "/notifications", Some(&bob)).await.body);
318
    let r = post(app, "/notifications/read", Some(&bob), &format!("_csrf={csrf_b}")).await;
319
    assert!(r.body.contains("0 unread"), "{}", r.body);
320
    // Email preference and the unsubscribe link.
321
    let r = post(app, "/settings/notifications", Some(&bob), &format!("_csrf={csrf_b}&email=1")).await;
322
    assert!(r.body.contains("Email notifications are on"));
323
    let key: String = sqlx::query_scalar("SELECT unsubscribe_key FROM accounts WHERE username = 'bob'").fetch_one(&app.db).await.unwrap();
324
    assert_eq!(get(app, &format!("/settings/notifications?unsubscribe={key}"), None).await.status, StatusCode::OK);
325
    let on: bool = sqlx::query_scalar("SELECT email_notifications FROM accounts WHERE username = 'bob'").fetch_one(&app.db).await.unwrap();
326
    assert!(!on);
327
}
25ab8c73 Andy McCall ↶ 328
329
#[tokio::test(flavor = "multi_thread")]
330
async fn dashboard_shows_what_needs_the_viewer() {
331
    let h = hub().await;
332
    let app = &h.app;
333
    let andy = register(app, "andy").await;
334
    let bob = register(app, "bob").await;
335
    for (name, vis) in [("demo", hub_api::Visibility::Public), ("secret", hub_api::Visibility::Private)] {
336
        app.repos.create(&RepoName::parse(&format!("andy/{name}")).unwrap(), None).unwrap();
337
        db::repos::create(&app.db, "andy", name, "", vis).await.unwrap();
338
    }
339
    let demo = db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
340
    let secret = db::repos::get(&app.db, "andy", "secret").await.unwrap().unwrap();
341
    let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
342
    for (repo, title) in [(demo.id, "Faster startup"), (secret.id, "Hidden work")] {
343
        let p = db::proposals::create(
344
            &app.db,
345
            db::proposals::NewProposal {
346
                repo_id: repo,
347
                title,
348
                body: "",
349
                author_id: Some(bob_id),
350
                author: "bob",
351
                draft: false,
352
                target: "main",
353
                source_kind: "bookmark",
354
                source_repo_id: Some(repo),
355
                source_bookmark: "fast",
356
                source_changes: "",
357
            },
358
        )
359
        .await
360
        .unwrap();
361
        db::proposals::add_event(&app.db, p.id, "bob", "opened", "").await.unwrap();
362
    }
363
364
    // Signed out, `/` is still the repository list.
365
    let anon = get(app, "/", None).await;
366
    assert!(anon.body.contains("andy /") && !anon.body.contains("Dashboard <small>"), "{}", anon.body);
367
368
    // Andy owns both repositories: both proposals wait for his review.
369
    let page = get(app, "/", Some(&andy)).await;
370
    assert_eq!(page.status, StatusCode::OK);
f8cf54e9 Andy McCall ↶ 371
    assert!(page.body.contains("Waiting for your review</h2><span class=\"count-chip\">2</span>"), "{}", page.body);
25ab8c73 Andy McCall ↶ 372
    assert!(page.body.contains("/andy/demo/proposal/1") && page.body.contains("/andy/secret/proposal/1"));
373
    assert!(page.body.contains("Your repositories"));
374
    assert!(page.body.contains("opened proposal"), "activity feed: {}", page.body);
375
17ca6cdd Andy McCall ↶ 376
    // Your sky (#157, docs/backgrounds.md §5): the canvas, and its data from
377
    // the database: his repositories and their events, safe in a script.
378
    assert!(page.body.contains(r#"<canvas id="backdrop" aria-hidden="true">"#));
379
    let start = page.body.find(r#"id="backdrop-data">"#).unwrap() + r#"id="backdrop-data">"#.len();
380
    let data: serde_json::Value = serde_json::from_str(&page.body[start..start + page.body[start..].find("</script>").unwrap()]).unwrap();
381
    let repos: Vec<&str> = data["repos"].as_array().unwrap().iter().filter_map(|r| r.as_str()).collect();
382
    assert!(repos.contains(&"andy/demo") && repos.contains(&"andy/secret"), "{data}");
383
    let events = data["events"].as_array().unwrap();
384
    assert!(events.iter().any(|e| e[1] == 1), "the proposals opened are marks: {data}");
385
    assert!(events.iter().all(|e| e[0].as_u64().unwrap() < repos.len() as u64));
33bd0bd4 Andy McCall ↶ 386
    // His page is his alone: no shared cache may keep it (#157).
387
    let res = oxygenhub::router(app.clone())
388
        .oneshot(Request::builder().uri("/").header(header::COOKIE, format!("oxyhub={andy}")).body(Body::empty()).unwrap())
389
        .await
390
        .unwrap();
391
    assert_eq!(res.headers()[header::CACHE_CONTROL], "private, no-store");
392
    // Signed out there is no sky at all.
393
    assert!(!anon.body.contains("backdrop-data"));
17ca6cdd Andy McCall ↶ 394
    // The engine is served as WebAssembly.
395
    let res = oxygenhub::router(app.clone())
396
        .oneshot(Request::builder().uri("/static/backdrop/backdrop_bg.wasm").body(Body::empty()).unwrap())
397
        .await
398
        .unwrap();
399
    assert_eq!(res.headers()[header::CONTENT_TYPE], "application/wasm");
400
    assert!(res.into_body().collect().await.unwrap().to_bytes().starts_with(b"\0asm"));
401
25ab8c73 Andy McCall ↶ 402
    // Once he reviews one, it leaves his queue.
403
    let andy_id = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
404
    let p = db::proposals::get(&app.db, demo.id, 1).await.unwrap().unwrap();
405
    db::proposals::add_review(&app.db, p.id, andy_id, "andy", "approve", "").await.unwrap();
f8cf54e9 Andy McCall ↶ 406
    assert!(get(app, "/", Some(&andy)).await.body.contains("Waiting for your review</h2><span class=\"count-chip\">1</span>"));
25ab8c73 Andy McCall ↶ 407
408
    // Bob sees his own proposal on the public repository, never the private one's.
409
    let page = get(app, "/", Some(&bob)).await;
33bd0bd4 Andy McCall ↶ 410
    // His sky holds only his own repositories: never Andy's, public or
411
    // private, and nothing of the private one (#157).
412
    let start = page.body.find(r#"id="backdrop-data">"#).unwrap() + r#"id="backdrop-data">"#.len();
413
    let sky = &page.body[start..start + page.body[start..].find("</script>").unwrap()];
414
    assert!(!sky.contains("andy/secret") && !sky.contains("andy/demo"), "{sky}");
f8cf54e9 Andy McCall ↶ 415
    assert!(page.body.contains("Your proposals</h2><span class=\"count-chip\">1</span>"), "{}", page.body);
25ab8c73 Andy McCall ↶ 416
    assert!(!page.body.contains("Hidden work"));
f8cf54e9 Andy McCall ↶ 417
    assert!(page.body.contains("Waiting for your review</h2><span class=\"count-chip\">0</span>"));
25ab8c73 Andy McCall ↶ 418
    assert!(page.body.contains("Faster startup"));
419
    let feed = &page.body[page.body.find("Recent activity").unwrap()..];
420
    assert!(!feed.contains("andy/secret"), "private activity leaked: {feed}");
421
422
    // Explore still lists every visible repository.
423
    assert!(get(app, "/explore", Some(&bob)).await.body.contains("andy /"));
424
}
4edcf240 Andy McCall ↶ 425
426
#[tokio::test(flavor = "multi_thread")]
427
async fn empty_repository_shows_a_quickstart() {
428
    let h = hub().await;
429
    let app = &h.app;
430
    let andy = register(app, "andy").await;
431
    let bob = register(app, "bob").await;
432
    app.repos.create(&RepoName::parse("andy/fresh").unwrap(), None).unwrap();
433
    db::repos::create(&app.db, "andy", "fresh", "", hub_api::Visibility::Public).await.unwrap();
434
435
    let page = get(app, "/andy/fresh", Some(&andy)).await;
436
    assert!(page.body.contains("This repository is empty"), "{}", page.body);
437
    let clone_url = format!("{}/andy/fresh", h.base);
438
    assert!(page.body.contains(&format!("oxy remote add hub {clone_url}")), "{}", page.body);
439
    assert!(page.body.contains("oxy config remote.hub.token YOUR-TOKEN"));
440
    assert!(page.body.contains("oxy push hub"));
441
    assert!(
442
        page.body.contains("mkdir fresh &amp;&amp; cd fresh") || page.body.contains("mkdir fresh &#38;&#38; cd fresh"),
443
        "{}",
444
        page.body
445
    );
446
    assert!(page.body.contains("oxy git import --branch main"));
447
    assert!(!page.body.contains("oxyhub-ca.pem"), "no certificate step without a self-signed certificate");
448
449
    // A reader without write access is not told to push.
450
    let page = get(app, "/andy/fresh", Some(&bob)).await;
451
    assert!(page.body.contains("Nothing has been pushed yet") && !page.body.contains("oxy push hub"), "{}", page.body);
452
453
    // After a first push the quickstart gives way to the tree.
454
    let work = tempfile::tempdir().unwrap();
455
    let mut client = Repo::init(work.path()).unwrap();
456
    client.config.set("remote.hub.url", &clone_url).unwrap();
457
    client.config.set("remote.hub.token", "site").unwrap();
458
    client.save_config().unwrap();
459
    write(work.path(), "README.md", b"# fresh\n");
460
    client.commit("First change", &[]).unwrap();
461
    assert!(client.push("hub", false).unwrap().iter().all(|r| r.ok));
462
    let page = get(app, "/andy/fresh", Some(&andy)).await;
463
    assert!(!page.body.contains("This repository is empty") && page.body.contains("README.md"), "{}", page.body);
464
}
c40c2d3e Andy McCall ↶ 465
466
#[tokio::test(flavor = "multi_thread")]
467
async fn theme_is_chosen_in_settings_and_remembered_in_a_cookie() {
468
    let h = hub().await;
469
    let app = &h.app;
470
    let andy = register(app, "andy").await;
471
    let page = get(app, "/settings", Some(&andy)).await;
472
    assert!(page.body.contains("Appearance"));
d98a93c1 Andy McCall ↶ 473
    assert!(page.body.contains(r#"value="light" checked"#), "light by default: {}", page.body);
c40c2d3e Andy McCall ↶ 474
    assert!(page.body.contains("data-theme-toggle"), "the header has the switch");
475
    let csrf = csrf_of(&page.body);
d98a93c1 Andy McCall ↶ 476
    let r = post(app, "/settings/appearance", Some(&andy), &format!("_csrf={csrf}&theme=dark")).await;
c40c2d3e Andy McCall ↶ 477
    assert_eq!(r.status, StatusCode::SEE_OTHER);
d98a93c1 Andy McCall ↶ 478
    assert_eq!(r.cookie.as_deref(), Some("dark"));
c40c2d3e Andy McCall ↶ 479
    assert_eq!(r.location.as_deref(), Some("/settings"));
d98a93c1 Andy McCall ↶ 480
    let page = send_with_theme(app, &andy, "dark").await;
481
    assert!(page.contains(r#"value="dark" checked"#), "the form shows the cookie's theme");
c40c2d3e Andy McCall ↶ 482
    assert_eq!(post(app, "/settings/appearance", Some(&andy), &format!("_csrf={csrf}&theme=purple")).await.status, StatusCode::BAD_REQUEST);
17ca6cdd Andy McCall ↶ 483
484
    // The background (docs/backgrounds.md §7): moving by default, kept in
485
    // its own cookie beside the theme.
486
    assert!(get(app, "/settings", Some(&andy)).await.body.contains(r#"name="backdrop" value="moving" checked"#));
487
    let res = oxygenhub::router(app.clone())
488
        .oneshot(
489
            Request::builder()
490
                .method("POST")
491
                .uri("/settings/appearance")
492
                .header(header::COOKIE, format!("oxyhub={andy}"))
493
                .header(header::CONTENT_TYPE, "application/x-www-form-urlencoded")
494
                .body(Body::from(format!("_csrf={csrf}&theme=light&backdrop=still")))
495
                .unwrap(),
496
        )
497
        .await
498
        .unwrap();
499
    let cookies: Vec<&str> = res.headers().get_all(header::SET_COOKIE).iter().filter_map(|v| v.to_str().ok()).collect();
500
    assert!(
501
        cookies.iter().any(|c| c.starts_with("theme=light;")) && cookies.iter().any(|c| c.starts_with("backdrop=still;")),
502
        "{cookies:?}"
503
    );
504
    assert_eq!(
505
        post(app, "/settings/appearance", Some(&andy), &format!("_csrf={csrf}&theme=light&backdrop=wild")).await.status,
506
        StatusCode::BAD_REQUEST
507
    );
c40c2d3e Andy McCall ↶ 508
    assert_eq!(post(app, "/settings/appearance", Some(&andy), "_csrf=nope&theme=light").await.status, StatusCode::BAD_REQUEST);
509
}
510
511
async fn send_with_theme(app: &Shared, session: &str, theme: &str) -> String {
512
    let req =
513
        Request::builder().uri("/settings").header(header::COOKIE, format!("oxyhub={session}; theme={theme}")).body(Body::empty()).unwrap();
514
    let res = oxygenhub::router(app.clone()).oneshot(req).await.unwrap();
515
    String::from_utf8_lossy(&res.into_body().collect().await.unwrap().to_bytes()).into_owned()
516
}
10174045 Andy McCall ↶ 517
518
#[tokio::test(flavor = "multi_thread")]
519
async fn profile_and_organisation_pages() {
520
    let h = hub().await;
521
    let app = &h.app;
522
    let andy = register(app, "andy").await;
523
    let bob = register(app, "bob").await;
524
    let andy_id = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
525
    let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
526
    app.repos.create(&RepoName::parse("andy/demo").unwrap(), None).unwrap();
527
    db::repos::create(&app.db, "andy", "demo", "A demo", hub_api::Visibility::Public).await.unwrap();
528
    app.repos.create(&RepoName::parse("andy/hidden").unwrap(), None).unwrap();
529
    db::repos::create(&app.db, "andy", "hidden", "", hub_api::Visibility::Private).await.unwrap();
530
531
    // Andy fills in his profile; a script URL and markup are refused or escaped.
532
    let csrf = csrf_of(&get(app, "/settings", Some(&andy)).await.body);
533
    let r = post(app, "/settings", Some(&andy), &format!("_csrf={csrf}&display_name=Andy+McCall&email=a%40example.com&bio=Builds+%3Cb%3Eoxy%3C%2Fb%3E&website=javascript%3Aalert(1)&location=Earth")).await;
534
    assert!(r.body.contains("must be an http"), "{}", r.body);
535
    let r = post(app, "/settings", Some(&andy), &format!("_csrf={csrf}&display_name=Andy+McCall&email=a%40example.com&bio=Builds+%3Cb%3Eoxy%3C%2Fb%3E&website=https%3A%2F%2Fexample.org&location=Earth")).await;
536
    assert!(r.body.contains("Profile saved"), "{}", r.body);
537
538
    let org = db::accounts::create_org(&app.db, "retro", "Retro Club", andy_id).await.unwrap();
539
    db::accounts::set_org_member(&app.db, org.id, bob_id, "member").await.unwrap();
540
    let team = db::accounts::create_team(&app.db, org.id, "core").await.unwrap();
541
    db::accounts::add_team_member(&app.db, team.id, bob_id).await.unwrap();
542
543
    let page = get(app, "/andy", Some(&bob)).await;
544
    assert_eq!(page.status, StatusCode::OK);
545
    for want in ["Andy McCall", "Earth", r#"href="https://example.org""#, "/avatar/andy", "Signing keys", "/retro", "demo"] {
546
        assert!(page.body.contains(want), "profile lacks {want}: {}", page.body);
547
    }
548
    assert!(!page.body.contains("<b>oxy</b>"), "the bio is escaped");
549
    assert!(!page.body.contains("[email protected]"), "the email stays private");
550
    assert!(!page.body.contains("/andy/hidden"), "bob cannot see the private repository");
551
    assert!(!page.body.contains("edit profile"), "only the owner gets the edit link");
552
    assert!(get(app, "/andy", Some(&andy)).await.body.contains("/andy/hidden"), "andy sees his own private repository");
553
554
    let page = get(app, "/retro", Some(&bob)).await;
555
    assert_eq!(page.status, StatusCode::OK);
61ecbd29 Andy McCall ↶ 556
    for want in ["Retro Club", "organisation", r#"Members <span class="count-chip">2</span>"#, "core", "1 member"] {
10174045 Andy McCall ↶ 557
        assert!(page.body.contains(want), "org page lacks {want}: {}", page.body);
558
    }
559
    assert!(!page.body.contains("/orgs/retro/settings"), "bob is not an owner");
560
    assert!(get(app, "/retro", Some(&andy)).await.body.contains("/orgs/retro/settings"));
561
562
    let svg = get(app, "/avatar/andy", None).await;
563
    assert_eq!(svg.status, StatusCode::OK);
564
    assert!(svg.body.starts_with("<svg"));
565
    assert_eq!(svg.body, get(app, "/avatar/ANDY", None).await.body);
566
    assert_eq!(get(app, "/nobody-here", None).await.status, StatusCode::NOT_FOUND);
567
}
9df855f2 Andy McCall ↶ 568
569
#[tokio::test(flavor = "multi_thread")]
570
async fn diffs_mark_words_hide_whitespace_and_collapse() {
571
    let h = hub().await;
572
    let app = &h.app;
573
    let andy = register(app, "andy").await;
574
    app.repos.create(&RepoName::parse("andy/demo").unwrap(), None).unwrap();
575
    db::repos::create(&app.db, "andy", "demo", "", hub_api::Visibility::Public).await.unwrap();
576
    let work = tempfile::tempdir().unwrap();
577
    let mut client = Repo::init(work.path()).unwrap();
578
    client.config.set("remote.hub.url", &format!("{}/andy/demo", h.base)).unwrap();
579
    client.config.set("remote.hub.token", "site").unwrap();
580
    client.save_config().unwrap();
581
    write(work.path(), "main.rs", b"fn main() {\n  setup();\n  let answer = 42;\n}\n");
582
    client.commit("first", &[]).unwrap();
583
    write(work.path(), "main.rs", b"fn main() {\n    setup();\n  let answer = 43;\n}\n");
584
    let second = client.commit("reindent and change the answer", &[]).unwrap();
585
    assert!(client.push("hub", false).unwrap().iter().all(|r| r.ok));
586
587
    let url = format!("/andy/demo/change/{}", second.to_hex());
588
    let page = get(app, &url, Some(&andy)).await;
589
    assert_eq!(page.status, StatusCode::OK);
590
    assert!(page.body.contains(r#"<details class="file-diff""#), "files collapse: {}", page.body);
591
    assert!(page.body.contains(r#"<span class="wx">43</span>"#), "the changed word is marked: {}", page.body);
592
    assert!(page.body.contains("hide whitespace changes"));
593
    assert!(page.body.contains("data-diff-mode=\"split\""));
594
    let adds = |b: &str| b.matches(r#"<tr class="add">"#).count();
595
    assert_eq!(adds(&page.body), 2, "re-indent and answer both changed");
596
597
    let quiet = get(app, &format!("{url}?w=1"), Some(&andy)).await;
598
    assert_eq!(adds(&quiet.body), 1, "only the answer changed ignoring whitespace: {}", quiet.body);
599
    assert!(quiet.body.contains("show whitespace changes"));
600
601
    assert!(quiet.body.contains("?w=0"), "the toggle leads back");
602
}
07b1a5bb Andy McCall ↶ 603
604
#[tokio::test(flavor = "multi_thread")]
605
async fn fork_and_propose_upstream() {
606
    let h = hub().await;
607
    let app = &h.app;
608
    let andy = register(app, "andy").await;
609
    let bob = register(app, "bob").await;
610
    app.repos.create(&RepoName::parse("andy/demo").unwrap(), None).unwrap();
611
    db::repos::create(&app.db, "andy", "demo", "The demo", hub_api::Visibility::Public).await.unwrap();
612
    let work = tempfile::tempdir().unwrap();
613
    let mut client = Repo::init(work.path()).unwrap();
614
    client.config.set("remote.hub.url", &format!("{}/andy/demo", h.base)).unwrap();
615
    client.config.set("remote.hub.token", "site").unwrap();
616
    client.save_config().unwrap();
617
    write(work.path(), "README.md", b"# demo\n");
618
    client.commit("first", &[]).unwrap();
619
    assert!(client.push("hub", false).unwrap().iter().all(|r| r.ok));
620
621
    // Bob forks it; he cannot fork into Andy's name.
622
    let page = get(app, "/andy/demo", Some(&bob)).await;
623
    assert!(page.body.contains("/andy/demo/fork"), "a fork button: {}", page.body);
624
    let csrf = csrf_of(&get(app, "/andy/demo/fork", Some(&bob)).await.body);
625
    let r = post(app, "/andy/demo/fork", Some(&bob), &format!("_csrf={csrf}&owner=andy&name=other")).await;
626
    assert!(r.body.contains("cannot create repositories under that owner"), "{}", r.body);
627
    let r = post(app, "/andy/demo/fork", Some(&bob), &format!("_csrf={csrf}&owner=bob&name=demo")).await;
628
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
629
    assert_eq!(r.location.as_deref(), Some("/bob/demo"));
630
    let forked = get(app, "/bob/demo", Some(&bob)).await;
631
    assert!(forked.body.contains("README.md") && forked.body.contains("forked from"), "{}", forked.body);
632
    assert!(forked.body.contains("propose to andy/demo"));
633
    assert!(get(app, "/andy/demo", None).await.body.contains("1 fork"));
634
    assert!(get(app, "/andy/demo/forks", None).await.body.contains("/bob/demo"));
635
    let fork_row = db::repos::get(&app.db, "bob", "demo").await.unwrap().unwrap();
636
    let up_row = db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
637
    assert_eq!(fork_row.forked_from, Some(up_row.id));
638
    assert_eq!(fork_row.description, "The demo");
639
    let fork_repo = app.repos.open(&RepoName::parse("bob/demo").unwrap()).unwrap();
640
    let up_repo = app.repos.open(&RepoName::parse("andy/demo").unwrap()).unwrap();
641
    assert_ne!(fork_repo.id().unwrap(), up_repo.id().unwrap(), "a fork is a repository of its own");
642
    assert_eq!(fork_repo.bookmark_heads().unwrap(), up_repo.bookmark_heads().unwrap());
643
    assert_eq!(fork_repo.fsck().unwrap().errors(), 0);
644
645
    // Bob works in a clone of his fork, pushes a bookmark, and proposes it upstream.
646
    let bw = tempfile::tempdir().unwrap();
647
    let mut mine = Repo::clone(&format!("{}/bob/demo", h.base), &bw.path().join("c")).unwrap();
648
    mine.config.set("remote.origin.token", "site").unwrap();
649
    mine.save_config().unwrap();
650
    mine.bookmark_create("feat", None).unwrap();
651
    mine.bookmark_switch("feat", false).unwrap();
652
    write(&bw.path().join("c"), "feature.txt", b"new\n");
653
    mine.commit("Add a feature", &[]).unwrap();
654
    assert!(mine.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
655
    let csrf = csrf_of(&get(app, "/andy/demo/proposals/new?source=bob/demo:feat", Some(&bob)).await.body);
656
    let r =
657
        post(app, "/andy/demo/proposals/new", Some(&bob), &format!("_csrf={csrf}&title=From+my+fork&target=main&source=bob%2Fdemo%3Afeat"))
658
            .await;
659
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
660
    let p = get(app, &r.location.unwrap(), Some(&andy)).await;
661
    assert!(p.body.contains("From my fork") && p.body.contains("fork bob/demo"), "{}", p.body);
662
    let files = get(app, "/andy/demo/proposal/1?tab=files", Some(&andy)).await;
663
    assert!(files.body.contains("feature.txt"), "{}", files.body);
664
}
1553bfc9 Andy McCall ↶ 665
666
#[tokio::test(flavor = "multi_thread")]
667
async fn stars_topics_and_explore() {
668
    let h = hub().await;
669
    let app = &h.app;
670
    let andy = register(app, "andy").await;
671
    let bob = register(app, "bob").await;
672
    for (name, desc) in [("alpha", "An emulator"), ("beta", "A compiler"), ("gamma", "Retro games")] {
673
        app.repos.create(&RepoName::parse(&format!("andy/{name}")).unwrap(), None).unwrap();
674
        db::repos::create(&app.db, "andy", name, desc, hub_api::Visibility::Public).await.unwrap();
675
    }
676
677
    // Topics through settings; bad ones are refused.
678
    let csrf = csrf_of(&get(app, "/andy/gamma/settings", Some(&andy)).await.body);
679
    let r = post(
680
        app,
681
        "/andy/gamma/settings",
682
        Some(&andy),
683
        &format!("_csrf={csrf}&description=Retro+games&default_bookmark=main&visibility=public&topics=c%2B%2B"),
684
    )
685
    .await;
686
    assert!(r.body.contains("is not a topic"), "{}", r.body);
687
    let r = post(
688
        app,
689
        "/andy/gamma/settings",
690
        Some(&andy),
691
        &format!("_csrf={csrf}&description=Retro+games&default_bookmark=main&visibility=public&topics=Retro%2C+6502"),
692
    )
693
    .await;
694
    assert!(r.body.contains("Saved"), "{}", r.body);
695
    assert_eq!(db::repos::get(&app.db, "andy", "gamma").await.unwrap().unwrap().topics, "retro 6502");
696
    let page = get(app, "/andy/gamma", None).await;
697
    assert!(page.body.contains(r#"href="/explore?topic=retro""#), "{}", page.body);
698
699
    // Stars: bob stars beta and gamma, andy stars gamma; toggling unstars.
700
    for (who, repo) in [(&bob, "beta"), (&bob, "gamma"), (&andy, "gamma"), (&andy, "alpha")] {
701
        let csrf = csrf_of(&get(app, &format!("/andy/{repo}"), Some(who)).await.body);
702
        assert_eq!(post(app, &format!("/andy/{repo}/star"), Some(who), &format!("_csrf={csrf}")).await.status, StatusCode::SEE_OTHER);
703
    }
704
    let csrf = csrf_of(&get(app, "/andy/alpha", Some(&andy)).await.body);
705
    post(app, "/andy/alpha/star", Some(&andy), &format!("_csrf={csrf}")).await;
706
    assert!(get(app, "/andy/gamma", Some(&bob)).await.body.contains("★ UNSTAR"));
7f283f8e Andy McCall ↶ 707
    assert!(get(app, "/andy/gamma", None).await.body.contains(r#"title="2 stars">"#));
708
    assert!(get(app, "/andy/alpha", None).await.body.contains(r#"title="0 stars">"#), "unstarred again");
1553bfc9 Andy McCall ↶ 709
710
    // Explore: sort by stars, by name, filter by text and by topic.
711
    let order = |b: &str| {
712
        ["alpha", "beta", "gamma"]
713
            .into_iter()
714
            .map(|n| (b.find(&format!("/andy/{n}\"")).unwrap_or(usize::MAX), n))
715
            .collect::<std::collections::BTreeMap<_, _>>()
716
            .into_values()
717
            .collect::<Vec<_>>()
718
    };
719
    assert_eq!(order(&get(app, "/explore?sort=stars", None).await.body)[..2], ["gamma", "beta"]);
720
    assert_eq!(order(&get(app, "/explore?sort=name", None).await.body), ["alpha", "beta", "gamma"]);
721
    let filtered = get(app, "/explore?q=compiler", None).await.body;
722
    assert!(filtered.contains("/andy/beta\"") && !filtered.contains("/andy/alpha\""), "{filtered}");
723
    let by_topic = get(app, "/explore?topic=6502", None).await.body;
724
    assert!(by_topic.contains("/andy/gamma\"") && !by_topic.contains("/andy/beta\""), "{by_topic}");
725
}
1ac84c62 Andy McCall ↶ 726
727
#[tokio::test(flavor = "multi_thread")]
728
async fn lists_filter_sort_page_and_count() {
729
    let h = hub().await;
730
    let app = &h.app;
731
    let andy = register(app, "andy").await;
732
    let _bob = register(app, "bob").await;
733
    app.repos.create(&RepoName::parse("andy/demo").unwrap(), None).unwrap();
734
    let repo = db::repos::create(&app.db, "andy", "demo", "", hub_api::Visibility::Public).await.unwrap();
735
    for n in 0..30 {
736
        let author = if n % 3 == 0 { "bob" } else { "andy" };
737
        db::issues::create(
738
            &app.db,
739
            db::issues::NewIssue { repo_id: repo.id, title: &format!("Issue number {n}"), body: "", author_id: None, author },
740
        )
741
        .await
742
        .unwrap();
743
    }
744
    let ui = db::issues::upsert_label(&app.db, repo.id, "ui", "#00f0ff", "").await.unwrap();
745
    for (title, author, target) in [("Faster menus", "bob", "main"), ("New theme", "andy", "main"), ("Release prep", "andy", "stable")] {
746
        let p = db::proposals::create(
747
            &app.db,
748
            db::proposals::NewProposal {
749
                repo_id: repo.id,
750
                title,
751
                body: "",
752
                author_id: None,
753
                author,
754
                draft: false,
755
                target,
756
                source_kind: "changes",
757
                source_repo_id: None,
758
                source_bookmark: "",
759
                source_changes: "",
760
            },
761
        )
762
        .await
763
        .unwrap();
764
        if title == "New theme" {
765
            db::issues::set_proposal_label(&app.db, p.id, ui.id, true).await.unwrap();
766
        }
767
    }
768
769
    // The tabs count what is open.
770
    let page = get(app, "/andy/demo/issues", Some(&andy)).await;
771
    assert!(page.body.contains(r#"Issues <span class="count-chip">30</span>"#), "{}", page.body);
772
    assert!(page.body.contains(r#"Proposals <span class="count-chip">3</span>"#));
773
774
    // Pages of 25, newest first; the second page holds the rest.
775
    let rows = |b: &str| b.matches("/andy/demo/issue/").count();
776
    assert_eq!(rows(&page.body), 25);
777
    assert!(page.body.contains("page 1 of 2") && page.body.contains("page=2"), "a pager");
778
    let second = get(app, "/andy/demo/issues?page=2", Some(&andy)).await;
779
    assert_eq!(rows(&second.body), 5);
780
    assert!(second.body.contains("Issue number 0<"), "the oldest are last");
781
    let oldest = get(app, "/andy/demo/issues?sort=oldest", Some(&andy)).await;
782
    assert!(oldest.body.find("Issue number 0<").unwrap() < oldest.body.find("Issue number 1<").unwrap());
783
    let bobs = get(app, "/andy/demo/issues?q=author:bob", Some(&andy)).await;
784
    assert_eq!(rows(&bobs.body), 10, "{}", bobs.body);
785
786
    // Proposals: by author, label and target.
787
    let by_bob = get(app, "/andy/demo/proposals?q=author:bob", Some(&andy)).await.body;
788
    assert!(by_bob.contains("Faster menus") && !by_bob.contains("New theme"));
789
    let ui_only = get(app, "/andy/demo/proposals?q=label:ui", Some(&andy)).await.body;
790
    assert!(ui_only.contains("New theme") && !ui_only.contains("Faster menus") && ui_only.contains(r#"class="label""#));
791
    let stable = get(app, "/andy/demo/proposals?q=target:stable", Some(&andy)).await.body;
792
    assert!(stable.contains("Release prep") && !stable.contains("New theme"));
793
}
e1ec9fbf Andy McCall ↶ 794
795
#[tokio::test(flavor = "multi_thread")]
796
async fn project_boards() {
797
    let h = hub().await;
798
    let app = &h.app;
799
    let andy = register(app, "andy").await;
800
    let bob = register(app, "bob").await;
801
    for (name, vis) in [("demo", hub_api::Visibility::Public), ("secret", hub_api::Visibility::Private)] {
802
        app.repos.create(&RepoName::parse(&format!("andy/{name}")).unwrap(), None).unwrap();
803
        let row = db::repos::create(&app.db, "andy", name, "", vis).await.unwrap();
804
        db::issues::create(
805
            &app.db,
806
            db::issues::NewIssue { repo_id: row.id, title: &format!("{name} issue"), body: "", author_id: None, author: "andy" },
807
        )
808
        .await
809
        .unwrap();
810
    }
a024e800 Andy McCall ↶ 811
    // Found from anywhere (#119): the site bar, every repository's tabs, and
812
    // a New project button on the list; a stranger is told who can make one.
813
    let home = get(app, "/andy/demo", Some(&andy)).await.body;
814
    assert!(
c9aacc0e Andy McCall ↶ 815
        home.contains("href=\"/projects/andy\"><svg class=\"ic\"") && home.contains("title=\"andy's project boards\">Projects</a>"),
a024e800 Andy McCall ↶ 816
        "site bar and tab"
817
    );
818
    let list = get(app, "/projects/andy", Some(&andy)).await.body;
819
    assert!(list.contains("href=\"#new\">+ NEW PROJECT</a>") && list.contains("id=\"new\""), "the button and the form");
820
    assert!(get(app, "/projects/andy", Some(&bob)).await.body.contains("Only andy"), "who can make one");
821
    let csrf = csrf_of(&list);
e1ec9fbf Andy McCall ↶ 822
    let r = post(app, "/projects/andy", Some(&andy), &format!("_csrf={csrf}&title=Roadmap&description=Next+steps")).await;
823
    assert_eq!(r.location.as_deref(), Some("/projects/andy/1"), "{}", r.body);
7b26e611 Andy McCall ↶ 824
    // The list (#124): a row per project, counted under Open, and a filter.
825
    let list = get(app, "/projects/andy", Some(&andy)).await.body;
826
    assert!(
827
        list.contains(">Roadmap</a>") && list.contains("Next steps") && list.contains("Open <span class=\"count-chip\">1</span>"),
828
        "{list}"
829
    );
830
    let filtered = get(app, "/projects/andy?q=roadm", Some(&andy)).await.body;
831
    assert!(filtered.contains(">Roadmap</a>"), "a filter matches part of the title, any case");
832
    let none = get(app, "/projects/andy?q=nothing+like+it", Some(&andy)).await.body;
833
    assert!(none.contains("No open project matches") && !none.contains(">Roadmap</a>"), "{none}");
834
    let closed = get(app, "/projects/andy?state=closed", Some(&andy)).await.body;
835
    assert!(closed.contains("No closed projects.") && closed.contains("Closed <span class=\"count-chip\">0</span>"), "{closed}");
e1ec9fbf Andy McCall ↶ 836
    let board = get(app, "/projects/andy/1", Some(&andy)).await.body;
837
    for col in ["Backlog", "Doing", "Done"] {
838
        assert!(board.contains(&format!(">{col} <span")), "{col}");
839
    }
840
    let cols: Vec<i64> = sqlx::query_scalar("SELECT id FROM project_columns ORDER BY position").fetch_all(&app.db).await.unwrap();
841
    let act = |form: String| {
842
        let andy = andy.clone();
843
        async move { post(app, "/projects/andy/1", Some(&andy), &form).await }
844
    };
845
    // Cards: by reference, by repository and number, a note; duplicates and strangers refused.
846
    assert_eq!(
847
        act(format!("_csrf={csrf}&action=add&column={}&reference=demo%231", cols[0])).await.location.as_deref(),
848
        Some("/projects/andy/1")
849
    );
850
    act(format!("_csrf={csrf}&action=add&column={}&repo=secret&reference=%231", cols[0])).await;
851
    act(format!("_csrf={csrf}&action=add&column={}&note=Write+the+docs", cols[1])).await;
852
    assert!(act(format!("_csrf={csrf}&action=add&column={}&reference=demo%231", cols[1])).await.body.contains("already on this project"));
853
    assert!(act(format!("_csrf={csrf}&action=add&column={}&reference=demo%2399", cols[0])).await.body.contains("no issue or proposal #99"));
854
    assert!(act(format!("_csrf={csrf}&action=add&column={}&reference=nothere%231", cols[0])).await.body.contains("no repository nothere"));
855
    // Move demo#1 to Done.
856
    let demo_card: i64 =
857
        sqlx::query_scalar("SELECT c.id FROM project_cards c JOIN repositories r ON r.id = c.repo_id WHERE r.name = 'demo'")
858
            .fetch_one(&app.db)
859
            .await
860
            .unwrap();
861
    act(format!("_csrf={csrf}&action=move&card={demo_card}&column={}", cols[2])).await;
862
    let issue = get(app, "/andy/demo/issue/1", None).await.body;
863
    assert!(issue.contains("href=\"/projects/andy/1\">Roadmap</a> <span class=\"mute\">· Done"), "the issue shows where it is");
864
865
    // Readers see public cards, never those of repositories they cannot read.
866
    let anon = get(app, "/projects/andy/1", None).await.body;
867
    assert!(anon.contains("demo issue") && anon.contains("Write the docs") && !anon.contains("secret issue"), "{anon}");
868
    assert!(!anon.contains("name=\"action\""), "and cannot change anything");
869
    assert!(get(app, "/projects/andy/1", Some(&andy)).await.body.contains("secret issue"));
870
    // Only the owner changes it; a private project is invisible to others.
871
    let csrf_b = csrf_of(&get(app, "/settings", Some(&bob)).await.body);
872
    assert_eq!(
873
        post(app, "/projects/andy/1", Some(&bob), &format!("_csrf={csrf_b}&action=remove&card={demo_card}")).await.status,
874
        StatusCode::NOT_FOUND
875
    );
876
    act(format!("_csrf={csrf}&action=settings&title=Roadmap&description=&private=1")).await;
877
    assert_eq!(get(app, "/projects/andy/1", Some(&bob)).await.status, StatusCode::NOT_FOUND);
878
    assert!(!get(app, "/projects/andy", None).await.body.contains("Roadmap"), "not even listed");
879
    assert!(!get(app, "/andy/demo/issue/1", None).await.body.contains("Roadmap"), "nor on the issue");
880
881
    // Columns: removing one moves its cards to the first column; the last one stays.
882
    act(format!("_csrf={csrf}&action=remove_column&column={}", cols[1])).await;
883
    let note_col: i64 = sqlx::query_scalar("SELECT column_id FROM project_cards WHERE kind = 'note'").fetch_one(&app.db).await.unwrap();
884
    assert_eq!(note_col, cols[0]);
885
    act(format!("_csrf={csrf}&action=remove_column&column={}", cols[2])).await;
886
    assert!(act(format!("_csrf={csrf}&action=remove_column&column={}", cols[0])).await.body.contains("at least one column"));
887
    // Closed projects are read-only until reopened; then deleted, the issues remain.
888
    act(format!("_csrf={csrf}&action=settings&title=Roadmap&closed=1")).await;
889
    assert!(act(format!("_csrf={csrf}&action=add&column={}&note=late", cols[0])).await.body.contains("This project is closed"));
890
    let r = act(format!("_csrf={csrf}&action=delete")).await;
891
    assert_eq!(r.location.as_deref(), Some("/projects/andy"));
892
    assert_eq!(get(app, "/projects/andy/1", Some(&andy)).await.status, StatusCode::NOT_FOUND);
893
    assert_eq!(get(app, "/andy/demo/issue/1", None).await.status, StatusCode::OK);
894
    assert_eq!(get(app, "/projects/nobody", None).await.status, StatusCode::NOT_FOUND);
895
}
c79a1111 Andy McCall ↶ 896
897
#[tokio::test(flavor = "multi_thread")]
898
async fn issue_markdown_follows_the_default_bookmark() {
899
    let h = hub().await;
900
    let app = &h.app;
901
    register(app, "andy").await;
902
    app.repos.create(&RepoName::parse("andy/trunky").unwrap(), None).unwrap();
903
    let row = db::repos::create(&app.db, "andy", "trunky", "", hub_api::Visibility::Public).await.unwrap();
904
    sqlx::query("UPDATE repositories SET default_bookmark = 'trunk' WHERE id = ?").bind(row.id).execute(&app.db).await.unwrap();
905
    db::issues::create(
906
        &app.db,
907
        db::issues::NewIssue {
908
            repo_id: row.id,
909
            title: "Docs",
910
            body: "See [the guide](docs/guide.md) and ![shot](img/a.png).",
911
            author_id: None,
912
            author: "andy",
913
        },
914
    )
915
    .await
916
    .unwrap();
917
    let page = get(app, "/andy/trunky/issue/1", None).await.body;
918
    assert!(page.contains("href=\"/andy/trunky/file/trunk/docs/guide.md\""), "{page}");
919
    assert!(page.contains("src=\"/andy/trunky/raw/trunk/img/a.png\""));
920
    assert!(!page.contains("/file/main/"));
921
}
b1e92a62 Andy McCall ↶ 922
923
/// #125: a board moves to an owner its user may make boards under, takes the
924
/// next number there with its cards, and its old address redirects to it; a
925
/// new board at the old address takes it over.
926
#[tokio::test(flavor = "multi_thread")]
927
async fn a_project_transfers_to_an_organisation() {
928
    let h = hub().await;
929
    let app = &h.app;
930
    // The first account is the site's administrator, who may make boards
931
    // anywhere: Andy is an ordinary user here.
932
    let _first = register(app, "ada").await;
933
    let andy = register(app, "andy").await;
934
    let _bob = register(app, "bob").await;
935
    let andy_id = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
936
    let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
937
    db::accounts::create_org(&app.db, "retro", "Retro Club", andy_id).await.unwrap();
938
    db::accounts::create_org(&app.db, "other", "Someone else's", bob_id).await.unwrap();
939
    let list = get(app, "/projects/andy", Some(&andy)).await.body;
940
    let csrf = csrf_of(&list);
941
    let r = post(app, "/projects/andy", Some(&andy), &format!("_csrf={csrf}&title=Roadmap")).await;
942
    assert_eq!(r.location.as_deref(), Some("/projects/andy/1"));
943
    post(app, "/projects/andy/1", Some(&andy), &format!("_csrf={csrf}&action=add&note=Keep+me")).await;
944
945
    // Settings offer the organisations Andy belongs to, not other people's.
946
    let board = get(app, "/projects/andy/1", Some(&andy)).await.body;
947
    assert!(board.contains("<option value=\"retro\">retro</option>") && !board.contains("value=\"other\""), "{board}");
948
    let refused = post(app, "/projects/andy/1", Some(&andy), &format!("_csrf={csrf}&action=transfer&to=other")).await;
949
    assert!(refused.body.contains("You cannot make projects under other"), "{}", refused.body);
950
951
    let r = post(app, "/projects/andy/1", Some(&andy), &format!("_csrf={csrf}&action=transfer&to=retro")).await;
952
    assert_eq!(r.location.as_deref(), Some("/projects/retro/1"), "{}", r.body);
953
    let moved = get(app, "/projects/retro/1", Some(&andy)).await.body;
954
    assert!(moved.contains("Roadmap") && moved.contains("Keep me"), "the cards come too");
955
    let old = get(app, "/projects/andy/1", Some(&andy)).await;
956
    assert_eq!(old.status, StatusCode::PERMANENT_REDIRECT);
957
    assert_eq!(old.location.as_deref(), Some("/projects/retro/1"));
958
959
    // A new board of Andy's takes number 1 again, and its own address back.
960
    let r = post(app, "/projects/andy", Some(&andy), &format!("_csrf={csrf}&title=Fresh")).await;
961
    assert_eq!(r.location.as_deref(), Some("/projects/andy/1"));
962
    let fresh = get(app, "/projects/andy/1", Some(&andy)).await;
963
    assert_eq!(fresh.status, StatusCode::OK);
964
    assert!(fresh.body.contains("Fresh"));
965
}
d7d18246 Andy McCall ↶ 966
967
/// Backups' settings (#169): a user's page, its checks, and an
968
/// organisation's page for its owners only.
969
#[tokio::test(flavor = "multi_thread")]
970
async fn backups_are_set_up_in_settings() {
971
    let h = hub().await;
972
    let app = &h.app;
973
    let andy = register(app, "andy").await;
974
    let page = get(app, "/settings/backups", Some(&andy)).await;
975
    assert_eq!(page.status, StatusCode::OK);
976
    assert!(page.body.contains("href=\"/settings/backups\" class=\"on\"") && page.body.contains("No runs yet."), "{}", page.body);
977
    let csrf = csrf_of(&page.body);
978
    // This hub allows no directory: only a bucket, and a real provider name.
979
    let bad = post(
980
        app,
981
        "/settings/backups",
982
        Some(&andy),
983
        &format!("_csrf={csrf}&every=hourly&destination=gcs&bucket=andy-backup&provider=nope&keep_days=30"),
984
    )
985
    .await;
986
    assert!(bad.body.contains("workload identity provider"), "{}", bad.body);
987
    let dir =
988
        post(app, "/settings/backups", Some(&andy), &format!("_csrf={csrf}&every=hourly&destination=dir&dir=%2Ftmp&keep_days=30")).await;
989
    assert!(dir.body.contains("Pick one of the directories this hub allows."));
990
    let provider =
991
        "%2F%2Fiam.googleapis.com%2Fprojects%2F1%2Flocations%2Fglobal%2FworkloadIdentityPools%2Foxygenhub%2Fproviders%2Foxygenhub-io";
992
    let ok = post(
993
        app,
994
        "/settings/backups",
995
        Some(&andy),
996
        &format!("_csrf={csrf}&every=hourly&destination=gcs&bucket=gs%3A%2F%2Fandy-backup&provider={provider}&keep_days=7"),
997
    )
998
    .await;
999
    assert!(ok.body.contains("Saved."), "{}", ok.body);
1000
    let s = oxygenhub::backups::setting(&app.db, "andy").await.unwrap().unwrap();
1001
    assert_eq!((s.target.as_str(), s.keep_days, s.every.as_str()), ("andy-backup", 7, "hourly"));
1002
    // An organisation's backups are its owners' business only.
1003
    let bob = register(app, "bob").await;
1004
    let andy_id = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1005
    db::accounts::create_org(&app.db, "club", "Club", andy_id).await.unwrap();
1006
    assert_eq!(get(app, "/orgs/club/settings/backups", Some(&bob)).await.status, StatusCode::NOT_FOUND);
1007
    let club = get(app, "/orgs/club/settings/backups", Some(&andy)).await;
1008
    assert!(club.body.contains("club</a>'s repositories"), "{}", club.body);
1009
    assert!(get(app, "/orgs/club/settings", Some(&andy)).await.body.contains("/orgs/club/settings/backups"));
1010
}