OXYGENHUB
# 439ecd8708a1 oxygenhub / crates / hub / tests / api.rs
89.7 KiB · Rust · last changed Board cards can be archived, by hand or by age (refs #293) 11 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    // The first account's setup code (oxygenhub#245).
46
    config.registration.setup_code = "test-setup".into();
47
    config.auth.push_tokens = vec!["site".into()];
48
    config.registration.mode = "open".into();
49
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
50
    let port = listener.local_addr().unwrap().port();
51
    config.server.base_url = format!("http://127.0.0.1:{port}");
52
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
53
    config.outbound.allow = vec!["http://127.0.0.1".into()];
54
    let app = oxygenhub::build(config).await.unwrap();
55
    let router = oxygenhub::router(app.clone());
56
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
57
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
58
}
59
60
struct Res {
61
    status: StatusCode,
62
    body: String,
63
    cookie: Option<String>,
64
    location: Option<String>,
65
}
66
67
async fn call(
68
    app: &Shared,
69
    method: &str,
70
    path: &str,
71
    bearer: Option<&str>,
72
    cookie: Option<&str>,
73
    json: Option<&str>,
74
    form: Option<&str>,
75
) -> Res {
76
    let mut req = Request::builder().method(method).uri(path);
77
    if let Some(b) = bearer {
78
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
79
    }
80
    if let Some(c) = cookie {
81
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
82
    }
83
    let body = if let Some(j) = json {
84
        req = req.header(header::CONTENT_TYPE, "application/json");
85
        Body::from(j.to_string())
86
    } else if let Some(f) = form {
87
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
88
        Body::from(f.to_string())
89
    } else {
90
        Body::empty()
91
    };
92
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
93
    let status = res.status();
94
    let cookie = res
95
        .headers()
96
        .get(header::SET_COOKIE)
97
        .and_then(|v| v.to_str().ok())
98
        .and_then(|v| v.split(';').next())
99
        .and_then(|kv| kv.split_once('='))
100
        .map(|(_, v)| v.to_string());
101
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
102
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
103
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
104
}
105
106
/// A repository settings form's answer (#278): a redirect to the page that
107
/// holds the form, followed.
108
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
109
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
110
    let to = r.location.expect("a redirect");
111
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
112
    call(app, "GET", &to, None, cookie, None, None).await
113
}
114
115
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
116
    let r = call(app, method, path, bearer, None, json, None).await;
117
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
118
    (r.status, v)
119
}
120
121
fn csrf_of(page: &str) -> String {
122
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
123
    page[i..].split('"').next().unwrap().to_string()
124
}
125
126
/// A webhook receiver that records what it gets and fails the first time.
127
struct Receiver {
128
    url: String,
129
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
130
    fail_first: Arc<Mutex<bool>>,
131
}
132
133
async fn receiver() -> Receiver {
134
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
135
    let fail_first = Arc::new(Mutex::new(true));
136
    let (s2, f2) = (seen.clone(), fail_first.clone());
137
    let router = Router::new().route(
138
        "/hook",
139
        post(move |headers: header::HeaderMap, body: String| {
140
            let (s2, f2) = (s2.clone(), f2.clone());
141
            async move {
142
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
143
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
144
                let mut f = f2.lock().unwrap();
145
                if *f {
146
                    *f = false;
147
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
148
                }
149
                s2.lock().unwrap().push((event, sig, body));
150
                (StatusCode::OK, "ok")
151
            }
152
        }),
153
    );
154
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
155
    let port = listener.local_addr().unwrap().port();
156
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
157
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
158
}
159
160
#[tokio::test(flavor = "multi_thread")]
161
async fn api_webhooks_and_checks() {
162
    let h = hub().await;
163
    let app = &h.app;
164
    // Accounts and tokens through the pages.
165
    let r = call(
166
        app,
167
        "POST",
168
        "/register",
169
        None,
170
        None,
171
        None,
172
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
173
    )
174
    .await;
175
    let andy = r.cookie.unwrap();
176
    let r = call(
177
        app,
178
        "POST",
179
        "/register",
180
        None,
181
        None,
182
        None,
183
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
184
    )
185
    .await;
186
    let bob = r.cookie.unwrap();
187
    let mint = |cookie: String, scopes: &'static str| {
188
        let app = app.clone();
189
        async move {
190
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
191
            let csrf = csrf_of(&page.body);
192
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
193
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
194
        }
195
    };
196
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
197
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
198
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
199
200
    // Create a repository through the API; the read-only token cannot.
201
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
202
    assert_eq!(st, StatusCode::FORBIDDEN);
203
    let (st, v) = api(
204
        app,
205
        "POST",
206
        "/api/v1/repos",
207
        Some(&andy_admin),
208
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
209
    )
210
    .await;
211
    assert_eq!(st, StatusCode::CREATED, "{v}");
212
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
213
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
214
    assert_eq!(st, StatusCode::CONFLICT);
215
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
216
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
217
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
218
    assert_eq!(st, StatusCode::OK);
219
    assert_eq!(v["username"], "andy");
220
221
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
222
    let rx = receiver().await;
223
    let (st, v) = api(
224
        app,
225
        "POST",
226
        "/api/v1/repos/andy/demo/hooks",
227
        Some(&andy_admin),
228
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
229
    )
230
    .await;
231
    assert_eq!(st, StatusCode::CREATED, "{v}");
232
    let work = tempfile::tempdir().unwrap();
233
    let mut client = Repo::init(work.path()).unwrap();
234
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
235
    client.config.set("remote.origin.token", "site").unwrap();
236
    client.save_config().unwrap();
237
    write(work.path(), "a.txt", b"a\n");
238
    client.snapshot("t").unwrap();
239
    let base = client.commit("base", &[]).unwrap();
240
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
241
    // The worker retries with backoff; drive it directly for the retry.
242
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
243
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
244
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
245
    oxygenhub::hooks::deliver_due(app).await;
246
    let seen = rx.seen.lock().unwrap().clone();
247
    assert_eq!(seen.len(), 1, "{seen:?}");
248
    assert_eq!(seen[0].0, "push");
249
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
250
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
251
    assert_eq!(payload["repository"]["name"], "demo");
252
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
253
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
254
    assert_eq!(v.as_array().unwrap().len(), 1);
255
256
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
257
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
258
    assert_eq!(st, StatusCode::OK);
259
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
260
    // A revset in place of the whole history (`?r=`), under a budget; a
261
    // bad one is the caller's problem.
262
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
263
    assert_eq!(st, StatusCode::OK, "{v}");
264
    assert_eq!(v["total"].as_u64(), Some(1));
265
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
266
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
267
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
268
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
269
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
270
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
271
    assert_eq!(v[0]["name"], "a.txt");
272
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
273
    assert_eq!(r.body, "a\n");
274
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
275
    assert_eq!(v[0]["change"], base.to_hex());
276
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
277
    assert_eq!(v["files"][0]["path"], "a.txt");
278
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
279
    assert!(v["policy"].is_null());
280
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
281
    assert_eq!(v[0]["reference"], "main");
282
283
    // Issues through the API: Bob opens one, comments, and closes it.
284
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
285
    assert_eq!(st, StatusCode::CREATED, "{v}");
286
    assert_eq!(v["number"], 1);
287
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
288
    assert_eq!(st, StatusCode::CREATED);
289
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
290
    assert_eq!(st, StatusCode::OK, "{v}");
291
    assert_eq!(v["state"], "closed");
292
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
293
    assert_eq!(v[0]["comments"], 1);
294
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
295
    assert_eq!(v[0]["number"], 1);
296
297
    // A proposal through the API, then a required check gates its landing.
298
    client.bookmark_create("feat", Some(&[base])).unwrap();
299
    client.bookmark_switch("feat", false).unwrap();
300
    write(work.path(), "b.txt", b"b\n");
301
    write(work.path(), "a.txt", b"a\nA\n");
302
    client.snapshot("t").unwrap();
303
    let feat = client.commit("feat", &[]).unwrap();
304
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
305
    let (st, v) =
306
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
307
            .await;
308
    assert_eq!(st, StatusCode::CREATED, "{v}");
309
    assert_eq!(v["number"], 2);
310
    let state = v["projected_state"].as_str().unwrap().to_string();
311
    assert_eq!(v["landable"], true);
312
    // Its files, and each side's bytes, for editors' diff views.
313
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
314
    assert_eq!(st, StatusCode::OK, "{v}");
315
    let files: Vec<(String, String)> =
316
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
317
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
318
    assert_eq!(v[0]["added"], 1);
319
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
320
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
321
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
322
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
323
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
324
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
325
    // An anchored comment comes back with its line in the projected state.
326
    let (st, v) = api(
327
        app,
328
        "POST",
329
        "/api/v1/repos/andy/demo/proposals/2/comments",
330
        Some(&bob_rw),
331
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
332
    )
333
    .await;
334
    assert_eq!(st, StatusCode::CREATED, "{v}");
335
    assert_eq!(v["line"], 2);
336
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
337
    assert_eq!(v[0]["path"], "a.txt");
338
    assert_eq!(v[0]["line"], 2, "{v}");
339
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
340
    // Require the "build" check.
341
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
342
    let csrf = csrf_of(&settings.body);
343
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
344
        .await;
345
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
346
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
347
    assert_eq!(v["landable"], false);
348
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
349
    // A checker reports on the projected state: first running, then passed; the page streams it.
350
    let (st, v) = api(
351
        app,
352
        "POST",
353
        "/api/v1/repos/andy/demo/checks",
354
        Some(&andy_ro),
355
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
356
    )
357
    .await;
358
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
359
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
360
    let (st, v) = api(
361
        app,
362
        "POST",
363
        "/api/v1/repos/andy/demo/checks",
364
        Some(&bob_rw),
365
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
366
    )
367
    .await;
368
    assert_eq!(st, StatusCode::CREATED, "{v}");
369
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
370
    assert_eq!(ev.kind, "check");
371
    assert_eq!(ev.check.unwrap().name, "build");
372
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
373
    assert_eq!(v[0]["status"], "passed");
374
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
375
    assert_eq!(v["landable"], true, "{v}");
376
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
377
    assert!(page.body.contains("42 tests"), "{}", page.body);
378
    // The check and the proposal reached the webhook too.
379
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
380
    oxygenhub::hooks::deliver_due(app).await;
381
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
382
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
383
    let _ = feat;
384
    let _ = rx.fail_first;
385
386
    // The inbox through the API: count, list, mark one read, mark all read.
387
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
388
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
389
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
390
    oxygenhub::db::notify::add(
391
        &app.db,
392
        oxygenhub::db::notify::New {
393
            account_id: bob_id,
394
            repo_id: Some(oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id),
395
            reason: oxygenhub::db::notify::Reason::Participating,
396
            kind: "issue.opened",
397
            title: "andy/demo#1: Bug",
398
            url: "/andy/demo/issue/1",
399
            actor: "andy",
400
        },
401
    )
402
    .await
403
    .unwrap();
404
    oxygenhub::db::notify::add(
405
        &app.db,
406
        oxygenhub::db::notify::New {
407
            account_id: bob_id,
408
            repo_id: None,
409
            reason: oxygenhub::db::notify::Reason::Participating,
410
            kind: "review",
411
            title: "andy/demo#2: Feat",
412
            url: "/andy/demo/proposal/2",
413
            actor: "andy",
414
        },
415
    )
416
    .await
417
    .unwrap();
418
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
419
    assert_eq!(st, StatusCode::OK, "{v}");
420
    assert_eq!(v["unread"], 2);
421
    assert_eq!(v["items"][0]["read"], false);
422
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
423
    // Its repository, why, its thread and the kind's label (#305).
424
    let bug = v["items"].as_array().unwrap().iter().find(|n| n["title"] == "andy/demo#1: Bug").unwrap();
425
    assert_eq!(
426
        (bug["repository"].as_str(), bug["reason"].as_str(), bug["label"].as_str()),
427
        (Some("andy/demo"), Some("participating"), Some("🐛 New Issue")),
428
        "{bug}"
429
    );
430
    assert_eq!(bug["thread"].as_str(), Some(format!("{}/andy/demo/issue/1", h.base).as_str()));
431
    let first = v["items"][0]["id"].as_i64().unwrap();
432
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
433
    assert_eq!(st, StatusCode::NO_CONTENT);
434
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
435
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
436
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
437
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
438
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
439
    // No token at all is 401, so a client knows to sign in (#303).
440
    assert_eq!(api(app, "GET", "/api/v1/notifications", None, None).await.0, StatusCode::UNAUTHORIZED);
441
    assert_eq!(api(app, "GET", "/api/v1/user", None, None).await.0, StatusCode::UNAUTHORIZED);
442
443
    // Review requests: the author asks andy; andy is told, reviews, and the
444
    // request is answered; the author hears of the review.
445
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
446
    let (st, orgs) = api(app, "GET", "/api/v1/user/orgs", Some(&andy_user), None).await;
447
    assert!(st == StatusCode::OK && orgs.is_array(), "the caller's organisations (#302): {orgs}");
448
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
449
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
450
        .await
451
        .unwrap();
452
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
453
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
454
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
455
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
456
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
457
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
458
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
459
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
460
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
461
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
462
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
463
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
464
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
465
    let (st, _) =
466
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
467
    assert_eq!(st, StatusCode::CREATED);
468
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
469
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
470
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
471
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
472
    // Asking again and withdrawing it.
473
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
474
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
475
    assert_eq!(st, StatusCode::NO_CONTENT);
476
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
477
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
478
    // oxygenhub#84: the page's menu sets who is asked, all at once.
479
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
480
    assert!(
481
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
482
        "the reviewers menu lists andy"
483
    );
484
    let csrf = csrf_of(&page.body);
485
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
486
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
487
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
488
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
489
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
490
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
491
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
492
493
    // A source bookmark with `/` in its name, as a feature/N-name workflow
494
    // makes them: by name, and as this repository's owner/name:bookmark.
495
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
496
        client.bookmark_create(b, Some(&[base])).unwrap();
497
        client.bookmark_switch(b, false).unwrap();
498
        write(work.path(), file, b"c\n");
499
        client.snapshot("t").unwrap();
500
        client.commit(b, &[]).unwrap();
501
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
502
    }
503
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
504
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
505
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
506
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
507
        let n = v["number"].as_i64().unwrap();
508
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
509
        assert_eq!(page.status, StatusCode::OK);
510
        assert!(page.body.contains("feature/"), "the page names its source");
511
    }
512
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
513
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
514
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
515
516
    // oxygenhub#76: a proposal's title and description are edited through
517
    // the API by its author or a maintainer; what is not given stays.
518
    let edit = |token: &str, number: i64, body: &str| {
519
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
520
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
521
    };
522
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
523
    assert_eq!(st, StatusCode::OK, "{v}");
524
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
525
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
526
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
527
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
528
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
529
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
530
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
531
    let (st, v) = api(
532
        app,
533
        "POST",
534
        "/api/v1/repos/andy/demo/proposals",
535
        Some(&andy_pw),
536
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
537
    )
538
    .await;
539
    assert_eq!(st, StatusCode::CREATED, "{v}");
540
    let n = v["number"].as_i64().unwrap();
541
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
542
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
543
544
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
545
    // before anything changes, shown in its JSON.
546
    for l in ["ui", "flow"] {
547
        let body = format!(r#"{{"name":"{l}"}}"#);
548
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
549
    }
550
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
551
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
552
    assert_eq!(st, StatusCode::OK, "{v}");
553
    let names = |v: &serde_json::Value| -> Vec<String> {
554
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
555
    };
556
    assert_eq!(names(&v), ["flow", "ui"]);
557
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
558
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
559
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
560
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
561
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
562
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
563
    assert_eq!(names(&v), ["flow"]);
564
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
565
}
566
567
#[tokio::test(flavor = "multi_thread")]
568
async fn api_issue_triage_and_labels() {
569
    let h = hub().await;
570
    let app = &h.app;
571
    let andy = call(
572
        app,
573
        "POST",
574
        "/register",
575
        None,
576
        None,
577
        None,
578
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
579
    )
580
    .await
581
    .cookie
582
    .unwrap();
583
    let bob = call(
584
        app,
585
        "POST",
586
        "/register",
587
        None,
588
        None,
589
        None,
590
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
591
    )
592
    .await
593
    .cookie
594
    .unwrap();
595
    let mint = |cookie: String, scopes: &'static str| {
596
        let app = app.clone();
597
        async move {
598
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
599
            let csrf = csrf_of(&page.body);
600
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
601
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
602
        }
603
    };
604
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
605
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
606
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
607
    assert_eq!(st, StatusCode::CREATED);
608
609
    // Labels through the API; bad colours and non-triage callers are refused.
610
    let (st, v) = api(
611
        app,
612
        "POST",
613
        "/api/v1/repos/andy/demo/labels",
614
        Some(&andy_t),
615
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
616
    )
617
    .await;
618
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
619
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
620
    assert_eq!(
621
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
622
        StatusCode::BAD_REQUEST
623
    );
624
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
625
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
626
    assert_eq!(labels.as_array().unwrap().len(), 2);
627
    // oxygenhub#91: milestones over the API, for triage.
628
    let (st, m) = api(
629
        app,
630
        "POST",
631
        "/api/v1/repos/andy/demo/milestones",
632
        Some(&andy_t),
633
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
634
    )
635
    .await;
636
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
637
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
638
    assert_eq!(
639
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
640
        StatusCode::BAD_REQUEST
641
    );
642
    assert_eq!(
643
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
644
        StatusCode::FORBIDDEN
645
    );
646
    let (st, m) =
647
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
648
            .await;
649
    assert_eq!(
650
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
651
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
652
        "{m}"
653
    );
654
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
655
    assert_eq!(
656
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
657
        StatusCode::NOT_FOUND,
658
        "renamed"
659
    );
660
    assert_eq!(
661
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
662
        StatusCode::BAD_REQUEST
663
    );
664
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
665
    assert_eq!(list.as_array().unwrap().len(), 1);
666
667
    // An issue created with its labels and assignee in one call.
668
    let (st, v) = api(
669
        app,
670
        "POST",
671
        "/api/v1/repos/andy/demo/issues",
672
        Some(&andy_t),
673
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
674
    )
675
    .await;
676
    assert_eq!(st, StatusCode::CREATED, "{v}");
677
    assert_eq!(v["labels"][0]["name"], "bug");
678
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
679
    let n = v["number"].as_i64().unwrap();
680
    // Unknown names are refused before anything is created.
681
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
682
    assert_eq!(st, StatusCode::BAD_REQUEST);
683
    assert!(v["detail"].as_str().unwrap().contains("no label"));
684
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
685
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
686
    // Without triage, labels cannot be set, but a plain issue can be opened.
687
    assert_eq!(
688
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
689
        StatusCode::FORBIDDEN
690
    );
691
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
692
    assert_eq!(st, StatusCode::CREATED);
693
    let bob_n = bobs["number"].as_i64().unwrap();
694
695
    // PATCH: the whole label set, assignees and milestone, with events.
696
    let (st, v) =
697
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
698
            .await;
699
    assert_eq!(st, StatusCode::OK, "{v}");
700
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
701
    assert_eq!(v["assignees"], serde_json::json!([]));
702
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
703
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
704
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
705
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
706
    // The author edits their own title; others cannot; nobody but triage sets labels.
707
    let (st, v) =
708
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
709
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
710
    assert_eq!(
711
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
712
        StatusCode::FORBIDDEN
713
    );
714
    assert_eq!(
715
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
716
        StatusCode::FORBIDDEN
717
    );
718
    assert_eq!(
719
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
720
        StatusCode::BAD_REQUEST
721
    );
722
723
    // Deleting a label takes it off the issues.
724
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
725
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
726
    assert_eq!(v["labels"], serde_json::json!([]));
727
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
728
}
729
730
#[tokio::test(flavor = "multi_thread")]
731
async fn webhook_formats_editing_and_web_issue_events() {
732
    let h = hub().await;
733
    let app = &h.app;
734
    let andy = call(
735
        app,
736
        "POST",
737
        "/register",
738
        None,
739
        None,
740
        None,
741
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
742
    )
743
    .await
744
    .cookie
745
    .unwrap();
746
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
747
    let r = call(
748
        app,
749
        "POST",
750
        "/settings/tokens",
751
        None,
752
        Some(&andy),
753
        None,
754
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
755
    )
756
    .await;
757
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
758
    assert_eq!(
759
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
760
        StatusCode::CREATED
761
    );
762
    let rx = receiver().await;
763
    *rx.fail_first.lock().unwrap() = false;
764
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
765
    let csrf = csrf_of(&settings);
766
    let form = |f: String| {
767
        let andy = andy.clone();
768
        async move {
769
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
770
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
771
        }
772
    };
773
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
774
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
775
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
776
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
777
    {
778
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
779
        let before: i64 =
780
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
781
        for i in 0..MAX_WAITING {
782
            sqlx::query(
783
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
784
            )
785
            .bind(hook.id)
786
            .bind(format!("flood-{i}"))
787
            .execute(&app.db)
788
            .await
789
            .unwrap();
790
        }
791
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
792
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
793
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
794
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
795
        let after: i64 =
796
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
797
        assert_eq!(before, after);
798
    }
799
    assert_eq!(hook.format, "discord");
800
    // Ping arrives as a Discord message.
801
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
802
    let mut got = String::new();
803
    for _ in 0..100 {
804
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
805
            got = body.clone();
806
        }
807
        if !got.is_empty() {
808
            break;
809
        }
810
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
811
    }
812
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
813
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
814
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
815
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
816
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
817
818
    // Editing: a blank URL and secret keep theirs; format, events and active change.
819
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
820
        .await
821
        .contains("Webhook saved"));
822
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
823
    assert_eq!(
824
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
825
        (rx.url.as_str(), "issue", "oxygenhub", true)
826
    );
827
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
828
829
    // An issue opened on the web now reaches the hook, as the signed envelope.
830
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
831
    call(
832
        app,
833
        "POST",
834
        "/andy/demo/issues/new",
835
        None,
836
        Some(&andy),
837
        None,
838
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
839
    )
840
    .await;
841
    let mut envelope = None;
842
    for _ in 0..100 {
843
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
844
        if envelope.is_some() {
845
            break;
846
        }
847
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
848
    }
849
    let (_, sig, body) = envelope.expect("issue.opened delivered");
850
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
851
    assert_eq!(v["data"]["issue"]["title"], "From the web");
852
    assert!(sig.starts_with("blake3-keyed="));
853
    // A disabled hook through the edit form (no active box).
854
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
855
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
856
}
857
858
#[tokio::test(flavor = "multi_thread")]
859
async fn api_projects() {
860
    let h = hub().await;
861
    let app = &h.app;
862
    let andy = call(
863
        app,
864
        "POST",
865
        "/register",
866
        None,
867
        None,
868
        None,
869
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
870
    )
871
    .await
872
    .cookie
873
    .unwrap();
874
    let bob = call(
875
        app,
876
        "POST",
877
        "/register",
878
        None,
879
        None,
880
        None,
881
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
882
    )
883
    .await
884
    .cookie
885
    .unwrap();
886
    let mint = |cookie: String, scopes: &'static str| {
887
        let app = app.clone();
888
        async move {
889
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
890
            let csrf = csrf_of(&page.body);
891
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
892
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
893
        }
894
    };
895
    let a = mint(andy, "scopes=repo%3Aadmin").await;
896
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
897
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
898
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
899
900
    // The caller's own repositories, a page at a time (#302); bob has none.
901
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"zeta","visibility":"private"}"#)).await;
902
    let names =
903
        |v: &serde_json::Value| -> Vec<String> { v.as_array().unwrap().iter().map(|r| r["name"].as_str().unwrap().to_string()).collect() };
904
    let (st, v) = api(app, "GET", "/api/v1/user/repos", Some(&a), None).await;
905
    assert_eq!((st, names(&v)), (StatusCode::OK, vec!["demo".to_string(), "zeta".to_string()]), "{v}");
906
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?limit=1", Some(&a), None).await.1), ["demo"]);
907
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?after=andy/demo", Some(&a), None).await.1), ["zeta"]);
908
    assert!(names(&api(app, "GET", "/api/v1/user/repos", Some(&b), None).await.1).is_empty(), "not bob's");
909
    assert_eq!(api(app, "GET", "/api/v1/user/repos?affiliation=friend", Some(&a), None).await.0, StatusCode::BAD_REQUEST);
910
    assert_eq!(api(app, "GET", "/api/v1/user/repos", None, None).await.0, StatusCode::UNAUTHORIZED);
911
    // Organisations need user:read, which this token lacks.
912
    assert_eq!(api(app, "GET", "/api/v1/user/orgs", Some(&a), None).await.0, StatusCode::FORBIDDEN);
913
914
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
915
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
916
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
917
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
918
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
919
920
    // Cards by reference, into a column by name, and a note into the first column.
921
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
922
    assert_eq!(st, StatusCode::CREATED, "{card}");
923
    assert_eq!(
924
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
925
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
926
    );
927
    assert_eq!((card["labels"].as_array().map(Vec::len), card["assignees"].as_array().map(Vec::len)), (Some(0), Some(0)), "{card}");
928
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
929
    assert_eq!(st, StatusCode::BAD_REQUEST);
930
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
931
    assert_eq!(
932
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
933
        StatusCode::BAD_REQUEST
934
    );
935
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
936
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
937
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
938
939
    // Move and read the board.
940
    let id = card["id"].as_i64().unwrap();
941
    assert_eq!(
942
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
943
        StatusCode::NO_CONTENT
944
    );
945
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
946
    let names: Vec<(&str, usize)> =
947
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
948
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
949
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
950
    // The cards by column (#115), and a wrong method answers with a body.
951
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
952
    assert_eq!(st, StatusCode::OK);
953
    assert_eq!(cols, board["columns"]);
954
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
955
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
956
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
957
958
    // A column's cards at once (#289): with exceptions, a state filter and
959
    // a dry run; one audit entry.
960
    for t in ["Second", "Third"] {
961
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(&format!(r#"{{"title":"{t}"}}"#))).await;
962
    }
963
    for n in [2, 3] {
964
        let body = format!(r#"{{"reference":"demo#{n}","column":"Doing"}}"#);
965
        assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(&body)).await.0, StatusCode::CREATED);
966
    }
967
    let bulk = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&a), Some(body));
968
    let refs = |v: &serde_json::Value, k: &str| -> Vec<String> {
969
        v[k].as_array().unwrap().iter().map(|c| c["reference"].as_str().unwrap().to_string()).collect()
970
    };
971
    let (st, v) = bulk(r##"{"from":"Doing","column":"Done","except":["#2"],"dry_run":true}"##).await;
972
    assert_eq!(st, StatusCode::OK, "{v}");
973
    assert_eq!((refs(&v, "moved"), refs(&v, "kept")), (vec!["andy/demo#3".to_string()], vec!["andy/demo#2".to_string()]));
974
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
975
    assert_eq!(board["columns"][1]["cards"].as_array().unwrap().len(), 2, "a dry run moves nothing");
976
    let (_, v) = bulk(r#"{"from":"Doing","column":"Done","state":["closed"]}"#).await;
977
    assert!(refs(&v, "moved").is_empty(), "both are open: {v}");
978
    let (_, v) = bulk(r#"{"from":"doing","column":"done","except":["demo#2"]}"#).await;
979
    assert_eq!(refs(&v, "moved"), ["andy/demo#3"]);
980
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
981
    let names: Vec<(&str, usize)> =
982
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
983
    assert_eq!(names, [("Backlog", 1), ("Doing", 1), ("Done", 2)]);
984
    let audited: i64 =
985
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_moved'").fetch_one(&app.db).await.unwrap();
986
    assert_eq!(audited, 1, "the dry run and the empty move are not audited");
987
    assert_eq!(bulk(r#"{"from":"Done","column":"Done"}"#).await.0, StatusCode::BAD_REQUEST);
988
    assert_eq!(
989
        api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&b), Some(r#"{"from":"Doing","column":"Done"}"#)).await.0,
990
        StatusCode::FORBIDDEN
991
    );
992
993
    // Archive (#293): Done's cards there more than a week (#3, made old),
994
    // listed with ?archived=true, restored once.
995
    sqlx::query("UPDATE project_cards SET moved_ms = 0 WHERE number = 3").execute(&app.db).await.unwrap();
996
    let archive = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/archive", Some(&a), Some(body));
997
    let (st, v) = archive(r#"{"from":"Done","older_days":7,"dry_run":true}"#).await;
998
    assert_eq!((st, refs(&v, "archived")), (StatusCode::OK, vec!["andy/demo#3".to_string()]), "{v}");
999
    assert!(v["archived"][0].get("archived_ms").is_none(), "a dry run archives nothing: {v}");
1000
    let (_, v) = archive(r#"{"from":"Done","older_days":7}"#).await;
1001
    assert_eq!((refs(&v, "archived"), refs(&v, "kept").len()), (vec!["andy/demo#3".to_string()], 1), "{v}");
1002
    assert!(v["archived"][0]["archived_ms"].as_i64().is_some());
1003
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1004
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 1, "off the board: {board}");
1005
    let (st, archived) = api(app, "GET", "/api/v1/projects/andy/1/cards?archived=true", None, None).await;
1006
    assert_eq!((st, archived[2]["cards"][0]["reference"].as_str()), (StatusCode::OK, Some("andy/demo#3")), "{archived}");
1007
    let card = archived[2]["cards"][0]["id"].as_i64().unwrap();
1008
    let restore = format!("/api/v1/projects/andy/1/cards/{card}/restore");
1009
    assert_eq!(api(app, "POST", &restore, Some(&b), None).await.0, StatusCode::FORBIDDEN);
1010
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NO_CONTENT);
1011
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NOT_FOUND, "not archived now");
1012
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1013
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 2);
1014
    assert_eq!(archive(r#"{"from":"Done","older_days":-1}"#).await.0, StatusCode::BAD_REQUEST);
1015
    let audited: i64 =
1016
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_archived'").fetch_one(&app.db).await.unwrap();
1017
    assert_eq!(audited, 1);
1018
1019
    // Private: hidden from others; closed: read-only; then remove a card.
1020
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
1021
    assert_eq!(edited["public"], false);
1022
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
1023
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
1024
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
1025
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
1026
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
1027
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
1028
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
1029
}
1030
1031
#[tokio::test(flavor = "multi_thread")]
1032
async fn api_required_checks() {
1033
    let h = hub().await;
1034
    let app = &h.app;
1035
    let andy = call(
1036
        app,
1037
        "POST",
1038
        "/register",
1039
        None,
1040
        None,
1041
        None,
1042
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1043
    )
1044
    .await
1045
    .cookie
1046
    .unwrap();
1047
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1048
    let csrf = csrf_of(&page.body);
1049
    let mint = |scopes: &'static str| {
1050
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1051
        async move {
1052
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1053
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1054
        }
1055
    };
1056
    let admin = mint("scopes=repo%3Aadmin").await;
1057
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1058
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1059
1060
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1061
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1062
    let (st, v) = api(
1063
        app,
1064
        "PUT",
1065
        "/api/v1/repos/andy/demo/checks/required",
1066
        Some(&admin),
1067
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1068
    )
1069
    .await;
1070
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1071
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1072
    assert_eq!(
1073
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1074
        serde_json::json!(["flow/fmt", "flow/test"])
1075
    );
1076
    assert_eq!(
1077
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1078
        StatusCode::FORBIDDEN,
1079
        "repo:admin only"
1080
    );
1081
    assert_eq!(
1082
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1083
        StatusCode::BAD_REQUEST
1084
    );
1085
    // The settings page shows the same list.
1086
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
1087
}
1088
1089
/// OxygenFlow per repository: site administrators turn it on or off in
1090
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1091
#[tokio::test(flavor = "multi_thread")]
1092
async fn flow_is_switched_per_repository_by_site_admins() {
1093
    let h = hub().await;
1094
    let app = &h.app;
1095
    let andy = call(
1096
        app,
1097
        "POST",
1098
        "/register",
1099
        None,
1100
        None,
1101
        None,
1102
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1103
    )
1104
    .await
1105
    .cookie
1106
    .unwrap();
1107
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1108
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1109
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1110
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1111
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
1112
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
1113
1114
    let set = |value: &'static str| {
1115
        let (app, andy) = (app.clone(), andy.clone());
1116
        async move {
1117
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1118
            let r = call(
1119
                &app,
1120
                "POST",
1121
                "/andy/demo/settings/flow",
1122
                None,
1123
                Some(&andy),
1124
                None,
1125
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1126
            )
1127
            .await;
1128
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
1129
        }
1130
    };
1131
    // A repository admin who is not a site admin sees the state but cannot change it.
1132
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1133
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
1134
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1135
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1136
    let r = set("on").await;
1137
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1138
    assert_eq!(row().await.flow, "");
1139
1140
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1141
    let r = set("on").await;
1142
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1143
    assert_eq!(row().await.flow, "on");
1144
    assert!(oxygenhub::flow::enabled(app, &row().await));
1145
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1146
    set("off").await;
1147
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1148
    set("default").await;
1149
    assert_eq!(row().await.flow, "");
1150
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
1151
}
1152
1153
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1154
/// button, never the repository's default bookmark as the hub sets it.
1155
#[tokio::test(flavor = "multi_thread")]
1156
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1157
    let h = hub().await;
1158
    let app = &h.app;
1159
    let andy = call(
1160
        app,
1161
        "POST",
1162
        "/register",
1163
        None,
1164
        None,
1165
        None,
1166
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1167
    )
1168
    .await
1169
    .cookie
1170
    .unwrap();
1171
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1172
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1173
    let url = format!("{}/andy/demo", h.base);
1174
    let work = tempfile::tempdir().unwrap();
1175
    let (w, u) = (work.path().to_path_buf(), url.clone());
1176
    let client = tokio::task::spawn_blocking(move || {
1177
        let mut c = Repo::init(&w).unwrap();
1178
        c.config.set("remote.origin.url", &u).unwrap();
1179
        c.config.set("remote.origin.token", "site").unwrap();
1180
        c.save_config().unwrap();
1181
        write(&w, "a.txt", b"a\n");
1182
        c.commit("a", &[]).unwrap();
1183
        assert!(c.push("origin", false).unwrap()[0].ok);
1184
        for b in ["develop", "feature/x", "stray"] {
1185
            c.bookmark_create(b, None).unwrap();
1186
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1187
        }
1188
        // A pushed deletion.
1189
        let r = c.push_delete("origin", "feature/x").unwrap();
1190
        assert!(r[0].ok, "{r:?}");
1191
        c
1192
    })
1193
    .await
1194
    .unwrap();
1195
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1196
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1197
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1198
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1199
    assert!(!anon.body.contains("/bookmarks/delete"));
1200
1201
    // The hub's default, not the repository's config, is protected: make
1202
    // develop the default, then main can go and develop cannot.
1203
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1204
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1205
    let client = tokio::task::spawn_blocking(move || {
1206
        let r = client.push_delete("origin", "develop").unwrap();
1207
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1208
        let r = client.push_delete("origin", "main").unwrap();
1209
        assert!(r[0].ok, "{r:?}");
1210
        client
1211
    })
1212
    .await
1213
    .unwrap();
1214
    drop(client);
1215
1216
    // On the web: a writer deletes stray; the default is refused.
1217
    let form = |b: &'static str| {
1218
        let (app, andy) = (app.clone(), andy.clone());
1219
        async move {
1220
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1221
            call(
1222
                &app,
1223
                "POST",
1224
                "/andy/demo/bookmarks/delete",
1225
                None,
1226
                Some(&andy),
1227
                None,
1228
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1229
            )
1230
            .await
1231
        }
1232
    };
1233
    let r = form("stray").await;
1234
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1235
    assert!(!r.body.contains(">stray<"));
1236
    let r = form("develop").await;
1237
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1238
    let r = form("nope").await;
1239
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1240
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1241
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1242
    // Anonymous visitors cannot.
1243
    assert_ne!(
1244
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1245
        StatusCode::OK
1246
    );
1247
}
1248
1249
/// A change signed by a key no account has linked says so, on its page
1250
/// and in the API (feedback 14).
1251
#[tokio::test(flavor = "multi_thread")]
1252
async fn changes_signed_by_unlinked_keys_say_so() {
1253
    let h = hub().await;
1254
    let app = &h.app;
1255
    let andy = call(
1256
        app,
1257
        "POST",
1258
        "/register",
1259
        None,
1260
        None,
1261
        None,
1262
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1263
    )
1264
    .await
1265
    .cookie
1266
    .unwrap();
1267
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1268
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1269
    let url = format!("{}/andy/demo", h.base);
1270
    let work = tempfile::tempdir().unwrap();
1271
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1272
    let hash = tokio::task::spawn_blocking(move || {
1273
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1274
        c.config.set("remote.origin.url", &u).unwrap();
1275
        c.config.set("remote.origin.token", "site").unwrap();
1276
        c.save_config().unwrap();
1277
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1278
        write(&w.join("r"), "a.txt", b"a\n");
1279
        let h = c.commit("signed by Ada", &[]).unwrap();
1280
        assert!(c.push("origin", false).unwrap()[0].ok);
1281
        h.to_hex()
1282
    })
1283
    .await
1284
    .unwrap();
1285
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1286
    assert_eq!(st, StatusCode::OK, "{v}");
1287
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1288
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1289
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1290
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1291
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1292
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1293
}
1294
1295
/// Function history (hub spec §6.6): the file page lists a file's
1296
/// functions, and a function's page lists exactly the changes to its lines.
1297
#[tokio::test(flavor = "multi_thread")]
1298
async fn a_function_has_its_own_history() {
1299
    let h = hub().await;
1300
    let app = &h.app;
1301
    let andy = call(
1302
        app,
1303
        "POST",
1304
        "/register",
1305
        None,
1306
        None,
1307
        None,
1308
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1309
    )
1310
    .await
1311
    .cookie
1312
    .unwrap();
1313
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1314
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1315
    let url = format!("{}/andy/demo", h.base);
1316
    let work = tempfile::tempdir().unwrap();
1317
    let w = work.path().to_path_buf();
1318
    tokio::task::spawn_blocking(move || {
1319
        let mut c = Repo::init(&w).unwrap();
1320
        c.config.set("remote.origin.url", &url).unwrap();
1321
        c.config.set("remote.origin.token", "site").unwrap();
1322
        c.save_config().unwrap();
1323
        let steps = [
1324
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1325
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1326
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1327
        ];
1328
        for (msg, text) in steps {
1329
            write(&w, "src/lib.rs", text.as_bytes());
1330
            c.commit(msg, &[]).unwrap();
1331
        }
1332
        assert!(c.push("origin", false).unwrap()[0].ok);
1333
    })
1334
    .await
1335
    .unwrap();
1336
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1337
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1338
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1339
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1340
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1341
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1342
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1343
    assert_ne!(bad.status, StatusCode::OK);
1344
}
1345
1346
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1347
/// dependency edges, linked cards.
1348
#[tokio::test(flavor = "multi_thread")]
1349
async fn a_bookmark_shows_as_swimlanes() {
1350
    let h = hub().await;
1351
    let app = &h.app;
1352
    let andy = call(
1353
        app,
1354
        "POST",
1355
        "/register",
1356
        None,
1357
        None,
1358
        None,
1359
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1360
    )
1361
    .await
1362
    .cookie
1363
    .unwrap();
1364
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1365
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1366
    let url = format!("{}/andy/demo", h.base);
1367
    let work = tempfile::tempdir().unwrap();
1368
    let w = work.path().to_path_buf();
1369
    tokio::task::spawn_blocking(move || {
1370
        let mut c = Repo::init(&w).unwrap();
1371
        c.config.set("remote.origin.url", &url).unwrap();
1372
        c.config.set("remote.origin.token", "site").unwrap();
1373
        c.save_config().unwrap();
1374
        // Two files edited independently: two lanes.
1375
        write(&w, "a.txt", b"a\n");
1376
        c.commit("add a", &[]).unwrap();
1377
        write(&w, "b.txt", b"b\n");
1378
        c.commit("add b", &[]).unwrap();
1379
        write(&w, "a.txt", b"a\na2\n");
1380
        c.commit("grow a", &[]).unwrap();
1381
        assert!(c.push("origin", false).unwrap()[0].ok);
1382
    })
1383
    .await
1384
    .unwrap();
1385
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1386
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1387
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1388
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1389
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1390
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1391
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1392
    assert_eq!(board.matches("<rect ").count(), 3);
1393
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1394
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1395
}
1396
1397
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1398
/// offers only what makes sense and rewrites nothing itself.
1399
#[tokio::test(flavor = "multi_thread")]
1400
async fn a_proposal_board_plans_squashes_and_rebases() {
1401
    let h = hub().await;
1402
    let app = &h.app;
1403
    let andy = call(
1404
        app,
1405
        "POST",
1406
        "/register",
1407
        None,
1408
        None,
1409
        None,
1410
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1411
    )
1412
    .await
1413
    .cookie
1414
    .unwrap();
1415
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1416
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1417
    let url = format!("{}/andy/demo", h.base);
1418
    let work = tempfile::tempdir().unwrap();
1419
    let w = work.path().to_path_buf();
1420
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1421
        let mut c = Repo::init(&w).unwrap();
1422
        c.config.set("remote.origin.url", &url).unwrap();
1423
        c.config.set("remote.origin.token", "site").unwrap();
1424
        c.save_config().unwrap();
1425
        write(&w, "a.txt", b"a\n");
1426
        let base = c.commit("base", &[]).unwrap();
1427
        assert!(c.push("origin", false).unwrap()[0].ok);
1428
        c.bookmark_create("feature", None).unwrap();
1429
        c.bookmark_switch("feature", false).unwrap();
1430
        write(&w, "a.txt", b"a\nfirst\n");
1431
        let first = c.commit("first", &[]).unwrap();
1432
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1433
        let second = c.commit("second", &[]).unwrap();
1434
        write(&w, "b.txt", b"apart\n");
1435
        let apart = c.commit("apart", &[]).unwrap();
1436
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1437
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1438
    })
1439
    .await
1440
    .unwrap();
1441
    // No proposal yet: the board is read-only.
1442
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1443
    assert!(!board.contains("data-plan="));
1444
    let (st, _) = api(
1445
        app,
1446
        "POST",
1447
        "/api/v1/repos/andy/demo/proposals",
1448
        Some("site"),
1449
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1450
    )
1451
    .await;
1452
    assert!(st.is_success(), "{st}");
1453
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1454
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1455
    let csrf = csrf_of(&board);
1456
    let plan = |c: &str, t: &str| {
1457
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1458
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1459
        async move {
1460
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1461
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1462
        }
1463
    };
1464
    let kinds = |v: &serde_json::Value| {
1465
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1466
    };
1467
    // second already depends on first: squash, no rebase.
1468
    let v = plan(&second, &first).await;
1469
    assert_eq!(kinds(&v), ["squash"], "{v}");
1470
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1471
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
1472
    // apart is independent of second: either.
1473
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1474
    // first under second: nothing (second depends on first).
1475
    assert!(plan(&first, &second).await["error"].is_string());
1476
    // What has landed on main is not rearranged.
1477
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1478
}
1479
1480
/// Issues and proposals share a number space, so every number says what it
1481
/// is, and the chain of work shows from both ends (hub spec §8).
1482
#[tokio::test(flavor = "multi_thread")]
1483
async fn proposals_and_issues_show_their_chain() {
1484
    let h = hub().await;
1485
    let app = &h.app;
1486
    let andy = call(
1487
        app,
1488
        "POST",
1489
        "/register",
1490
        None,
1491
        None,
1492
        None,
1493
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1494
    )
1495
    .await
1496
    .cookie
1497
    .unwrap();
1498
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1499
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1500
    let url = format!("{}/andy/demo", h.base);
1501
    let work = tempfile::tempdir().unwrap();
1502
    let w = work.path().to_path_buf();
1503
    tokio::task::spawn_blocking(move || {
1504
        let mut c = Repo::init(&w).unwrap();
1505
        c.config.set("remote.origin.url", &url).unwrap();
1506
        c.config.set("remote.origin.token", "site").unwrap();
1507
        c.save_config().unwrap();
1508
        write(&w, "a.txt", b"a\n");
1509
        c.commit("base", &[]).unwrap();
1510
        assert!(c.push("origin", false).unwrap()[0].ok);
1511
        c.bookmark_create("feature", None).unwrap();
1512
        c.bookmark_switch("feature", false).unwrap();
1513
        write(&w, "a.txt", b"a\nfixed\n");
1514
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1515
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1516
    })
1517
    .await
1518
    .unwrap();
1519
    for title in ["Slow start", "Crash on save"] {
1520
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1521
        assert!(st.is_success());
1522
    }
1523
    let (st, v) = api(
1524
        app,
1525
        "POST",
1526
        "/api/v1/repos/andy/demo/proposals",
1527
        Some("site"),
1528
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1529
    )
1530
    .await;
1531
    assert!(st.is_success(), "{st} {v}");
1532
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1533
1534
    // The proposal names its kind, links its references by kind, and shows
1535
    // the chain: the issues it closes (description and changes) → it → main.
1536
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1537
    assert!(p.contains(">proposal #3</small>"), "header");
1538
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1539
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1540
    let chain = &chain[..chain.find("</p>").unwrap()];
1541
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1542
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1543
    }
1544
    assert!(p.contains("<h3>Closes</h3>"));
1545
1546
    // The issue shows the proposal that closes it, and names its own kind.
1547
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1548
    assert!(i.contains(">issue #1</small>"));
1549
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1550
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1551
    // The conversation is a timeline with avatars; editing sits with the
1552
    // content, not in the sidebar, and labels and projects are editable.
1553
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1554
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1555
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1556
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1557
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1558
    assert!(st.is_success(), "{st}");
1559
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1560
    assert!(
1561
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1562
        "the owner's projects to add to, in a menu"
1563
    );
1564
    let csrf = csrf_of(&p);
1565
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1566
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1567
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1568
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1569
        .await;
1570
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1571
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1572
1573
    // Closed by the proposal's change, not its description: still shown.
1574
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1575
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1576
    assert!(chain.contains("proposal #3"), "{chain}");
1577
}
1578
1579
/// What the hub is: its version and build, and the libraries it is built on,
1580
/// on /about, in the API and in /health (hub spec §15).
1581
#[tokio::test(flavor = "multi_thread")]
1582
async fn the_hub_says_what_version_it_is() {
1583
    let h = hub().await;
1584
    let app = &h.app;
1585
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1586
    assert_eq!(st, StatusCode::OK);
1587
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1588
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1589
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1590
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1591
    assert!(health.contains("\"build\""), "{health}");
1592
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1593
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
1594
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1595
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1596
    assert!(about.contains("href=\"/about\""), "the footer links here");
1597
}
1598
1599
#[tokio::test(flavor = "multi_thread")]
1600
async fn device_sign_in() {
1601
    let h = hub().await;
1602
    let app = &h.app;
1603
    let r = call(
1604
        app,
1605
        "POST",
1606
        "/register",
1607
        None,
1608
        None,
1609
        None,
1610
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1611
    )
1612
    .await;
1613
    let andy = r.cookie.unwrap();
1614
1615
    // An unknown scope is refused.
1616
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1617
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1618
1619
    // The app asks for a code and polls; nobody has approved it yet.
1620
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1621
    assert_eq!(st, StatusCode::OK, "{v}");
1622
    let device = v["device_code"].as_str().unwrap().to_string();
1623
    let user = v["user_code"].as_str().unwrap().to_string();
1624
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1625
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1626
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1627
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1628
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1629
    assert_eq!(v["error"], "slow_down", "polled too soon");
1630
1631
    // The user approves it on the web, allowing less than it asked for.
1632
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1633
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1634
    let csrf = csrf_of(&page.body);
1635
    let r =
1636
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1637
            .await;
1638
    // oxygenhub#83: the answer page says it is done, with no code form.
1639
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1640
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1641
1642
    // The next poll gets a token with what was allowed, once.
1643
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1644
    assert_eq!(st, StatusCode::OK, "{v}");
1645
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1646
    let token = v["access_token"].as_str().unwrap().to_string();
1647
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1648
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1649
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1650
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1651
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1652
    assert!(tokens.body.contains("device: Phone app"));
1653
    // oxygenhub#70: a device's token expires, and each use renews it.
1654
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1655
1656
    // The token can revoke itself (oxy auth logout), and is then refused.
1657
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1658
    assert_eq!(st, StatusCode::NO_CONTENT);
1659
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1660
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1661
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1662
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1663
1664
    // A denied code says so.
1665
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1666
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1667
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1668
    let csrf = csrf_of(&page.body);
1669
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1670
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1671
    assert_eq!(v["error"], "access_denied");
1672
1673
    // A code the app gave up on (#304) is gone at once: the page no longer
1674
    // takes it, and the app's poll says so.
1675
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Cancelled"}"#)).await;
1676
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1677
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1678
    assert_eq!(st, StatusCode::NO_CONTENT);
1679
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1680
    let csrf = csrf_of(&page.body);
1681
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve"))).await;
1682
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1683
    assert_eq!(v["error"], "expired_token", "{v}");
1684
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1685
    assert_eq!(st, StatusCode::NO_CONTENT, "again: still fine");
1686
1687
    // Signed out, the page asks for a sign-in first.
1688
    let r = call(app, "GET", "/device", None, None, None, None).await;
1689
    assert!(r.status.is_redirection(), "{}", r.status);
1690
}
1691
1692
#[tokio::test(flavor = "multi_thread")]
1693
async fn api_assistants_at_each_level() {
1694
    let h = hub().await;
1695
    let app = &h.app;
1696
    let andy = call(
1697
        app,
1698
        "POST",
1699
        "/register",
1700
        None,
1701
        None,
1702
        None,
1703
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1704
    )
1705
    .await
1706
    .cookie
1707
    .unwrap();
1708
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1709
    let csrf = csrf_of(&page.body);
1710
    let mint = |scopes: &'static str| {
1711
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1712
        async move {
1713
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1714
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1715
        }
1716
    };
1717
    let admin = mint("scopes=repo%3Aadmin").await;
1718
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1719
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1720
    // A stand-in endpoint with no model list: any model name is taken.
1721
    let router = axum::Router::new().route(
1722
        "/v1/chat/completions",
1723
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1724
    );
1725
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1726
    let port = listener.local_addr().unwrap().port();
1727
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1728
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1729
1730
    // The site's, by its administrator; the repository's, by its admin.
1731
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1732
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1733
    assert_eq!(st, StatusCode::OK, "{v}");
1734
    assert_eq!(v["ok"], "Gemini added");
1735
    let body =
1736
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1737
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1738
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1739
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1740
    assert_eq!(st, StatusCode::OK, "{v}");
1741
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1742
    assert_eq!(st, StatusCode::OK);
1743
    let names: Vec<(&str, &str, bool)> = v
1744
        .as_array()
1745
        .unwrap()
1746
        .iter()
1747
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1748
        .collect();
1749
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1750
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1751
    // Changing it keeps the token when none is given.
1752
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1753
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1754
    assert_eq!(v["ok"], "Claude updated");
1755
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1756
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1757
    // Prompts: the site's is inherited by the repository.
1758
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1759
    assert_eq!(st, StatusCode::OK);
1760
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1761
    assert_eq!(v["prompt"], "Rust.");
1762
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1763
    // Removed.
1764
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1765
    assert_eq!(st, StatusCode::NO_CONTENT);
1766
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1767
    assert_eq!(st, StatusCode::NOT_FOUND);
1768
}