OXYGENHUB
# 58ac360b3345 oxygenhub / crates / hub / tests / api.rs
92.8 KiB · Rust · last changed Images that point at one of this hub's file pages render as the raw file (closes #346); a proposal's diffs over the API, GET …/proposals/N/diff (refs oxygenhub-android#4) 8 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    // The first account's setup code (oxygenhub#245).
46
    config.registration.setup_code = "test-setup".into();
47
    config.auth.push_tokens = vec!["site".into()];
48
    config.registration.mode = "open".into();
49
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
50
    let port = listener.local_addr().unwrap().port();
51
    config.server.base_url = format!("http://127.0.0.1:{port}");
52
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
53
    config.outbound.allow = vec!["http://127.0.0.1".into()];
54
    let app = oxygenhub::build(config).await.unwrap();
55
    let router = oxygenhub::router(app.clone());
56
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
57
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
58
}
59
60
struct Res {
61
    status: StatusCode,
62
    body: String,
63
    cookie: Option<String>,
64
    location: Option<String>,
65
}
66
67
async fn call(
68
    app: &Shared,
69
    method: &str,
70
    path: &str,
71
    bearer: Option<&str>,
72
    cookie: Option<&str>,
73
    json: Option<&str>,
74
    form: Option<&str>,
75
) -> Res {
76
    let mut req = Request::builder().method(method).uri(path);
77
    if let Some(b) = bearer {
78
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
79
    }
80
    if let Some(c) = cookie {
81
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
82
    }
83
    let body = if let Some(j) = json {
84
        req = req.header(header::CONTENT_TYPE, "application/json");
85
        Body::from(j.to_string())
86
    } else if let Some(f) = form {
87
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
88
        Body::from(f.to_string())
89
    } else {
90
        Body::empty()
91
    };
92
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
93
    let status = res.status();
94
    let cookie = res
95
        .headers()
96
        .get(header::SET_COOKIE)
97
        .and_then(|v| v.to_str().ok())
98
        .and_then(|v| v.split(';').next())
99
        .and_then(|kv| kv.split_once('='))
100
        .map(|(_, v)| v.to_string());
101
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
102
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
103
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
104
}
105
106
/// A repository settings form's answer (#278): a redirect to the page that
107
/// holds the form, followed.
108
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
109
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
110
    let to = r.location.expect("a redirect");
111
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
112
    call(app, "GET", &to, None, cookie, None, None).await
113
}
114
115
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
116
    let r = call(app, method, path, bearer, None, json, None).await;
117
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
118
    (r.status, v)
119
}
120
121
fn csrf_of(page: &str) -> String {
122
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
123
    page[i..].split('"').next().unwrap().to_string()
124
}
125
126
/// A webhook receiver that records what it gets and fails the first time.
127
struct Receiver {
128
    url: String,
129
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
130
    fail_first: Arc<Mutex<bool>>,
131
}
132
133
async fn receiver() -> Receiver {
134
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
135
    let fail_first = Arc::new(Mutex::new(true));
136
    let (s2, f2) = (seen.clone(), fail_first.clone());
137
    let router = Router::new().route(
138
        "/hook",
139
        post(move |headers: header::HeaderMap, body: String| {
140
            let (s2, f2) = (s2.clone(), f2.clone());
141
            async move {
142
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
143
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
144
                let mut f = f2.lock().unwrap();
145
                if *f {
146
                    *f = false;
147
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
148
                }
149
                s2.lock().unwrap().push((event, sig, body));
150
                (StatusCode::OK, "ok")
151
            }
152
        }),
153
    );
154
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
155
    let port = listener.local_addr().unwrap().port();
156
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
157
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
158
}
159
160
#[tokio::test(flavor = "multi_thread")]
161
async fn api_webhooks_and_checks() {
162
    let h = hub().await;
163
    let app = &h.app;
164
    // Accounts and tokens through the pages.
165
    let r = call(
166
        app,
167
        "POST",
168
        "/register",
169
        None,
170
        None,
171
        None,
172
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
173
    )
174
    .await;
175
    let andy = r.cookie.unwrap();
176
    let r = call(
177
        app,
178
        "POST",
179
        "/register",
180
        None,
181
        None,
182
        None,
183
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
184
    )
185
    .await;
186
    let bob = r.cookie.unwrap();
187
    let mint = |cookie: String, scopes: &'static str| {
188
        let app = app.clone();
189
        async move {
190
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
191
            let csrf = csrf_of(&page.body);
192
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
193
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
194
        }
195
    };
196
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
197
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
198
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
199
200
    // Create a repository through the API; the read-only token cannot.
201
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
202
    assert_eq!(st, StatusCode::FORBIDDEN);
203
    let (st, v) = api(
204
        app,
205
        "POST",
206
        "/api/v1/repos",
207
        Some(&andy_admin),
208
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
209
    )
210
    .await;
211
    assert_eq!(st, StatusCode::CREATED, "{v}");
212
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
213
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
214
    assert_eq!(st, StatusCode::CONFLICT);
215
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
216
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
217
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
218
    assert_eq!(st, StatusCode::OK);
219
    assert_eq!(v["username"], "andy");
220
221
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
222
    let rx = receiver().await;
223
    let (st, v) = api(
224
        app,
225
        "POST",
226
        "/api/v1/repos/andy/demo/hooks",
227
        Some(&andy_admin),
228
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
229
    )
230
    .await;
231
    assert_eq!(st, StatusCode::CREATED, "{v}");
232
    let work = tempfile::tempdir().unwrap();
233
    let mut client = Repo::init(work.path()).unwrap();
234
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
235
    client.config.set("remote.origin.token", "site").unwrap();
236
    client.save_config().unwrap();
237
    write(work.path(), "a.txt", b"a\n");
238
    client.snapshot("t").unwrap();
239
    let base = client.commit("base", &[]).unwrap();
240
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
241
    // The worker retries with backoff; drive it directly for the retry.
242
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
243
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
244
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
245
    oxygenhub::hooks::deliver_due(app).await;
246
    let seen = rx.seen.lock().unwrap().clone();
247
    assert_eq!(seen.len(), 1, "{seen:?}");
248
    assert_eq!(seen[0].0, "push");
249
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
250
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
251
    assert_eq!(payload["repository"]["name"], "demo");
252
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
253
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
254
    assert_eq!(v.as_array().unwrap().len(), 1);
255
256
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
257
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
258
    assert_eq!(st, StatusCode::OK);
259
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
260
    // A revset in place of the whole history (`?r=`), under a budget; a
261
    // bad one is the caller's problem.
262
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
263
    assert_eq!(st, StatusCode::OK, "{v}");
264
    assert_eq!(v["total"].as_u64(), Some(1));
265
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
266
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
267
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
268
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
269
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
270
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
271
    assert_eq!(v[0]["name"], "a.txt");
272
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
273
    assert_eq!(r.body, "a\n");
274
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
275
    assert_eq!(v[0]["change"], base.to_hex());
276
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
277
    assert_eq!(v["files"][0]["path"], "a.txt");
278
    assert_eq!(v["files"][0]["lines"][0], serde_json::json!({"kind": "add", "new": 1, "text": "a"}), "{v}");
279
    assert_eq!(v["files"][0]["truncated"], false);
280
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
281
    assert!(v["policy"].is_null());
282
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
283
    assert_eq!(v[0]["reference"], "main");
284
285
    // Issues through the API: Bob opens one, comments, and closes it.
286
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
287
    assert_eq!(st, StatusCode::CREATED, "{v}");
288
    assert_eq!(v["number"], 1);
289
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
290
    assert_eq!(st, StatusCode::CREATED);
291
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
292
    assert_eq!(st, StatusCode::OK, "{v}");
293
    assert_eq!(v["state"], "closed");
294
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
295
    assert_eq!(v[0]["comments"], 1);
296
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
297
    assert_eq!(v[0]["number"], 1);
298
299
    // A proposal through the API, then a required check gates its landing.
300
    client.bookmark_create("feat", Some(&[base])).unwrap();
301
    client.bookmark_switch("feat", false).unwrap();
302
    write(work.path(), "b.txt", b"b\n");
303
    write(work.path(), "a.txt", b"a\nA\n");
304
    client.snapshot("t").unwrap();
305
    let feat = client.commit("feat", &[]).unwrap();
306
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
307
    let (st, v) =
308
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
309
            .await;
310
    assert_eq!(st, StatusCode::CREATED, "{v}");
311
    assert_eq!(v["number"], 2);
312
    let state = v["projected_state"].as_str().unwrap().to_string();
313
    assert_eq!(v["landable"], true);
314
    // Its files, and each side's bytes, for editors' diff views.
315
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
316
    assert_eq!(st, StatusCode::OK, "{v}");
317
    let files: Vec<(String, String)> =
318
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
319
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
320
    assert_eq!(v[0]["added"], 1);
321
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
322
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
323
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
324
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
325
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
326
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
327
    // The same files with their diffs, as a change's (oxygenhub-android#4).
328
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/diff", None, None).await;
329
    assert_eq!(st, StatusCode::OK, "{v}");
330
    assert_eq!((v[0]["path"].as_str(), v[0]["added"].as_u64(), v[0]["truncated"].as_bool()), (Some("a.txt"), Some(1), Some(false)), "{v}");
331
    let lines: Vec<(String, String)> = v[0]["lines"]
332
        .as_array()
333
        .unwrap()
334
        .iter()
335
        .map(|l| (l["kind"].as_str().unwrap().to_string(), l["text"].as_str().unwrap().to_string()))
336
        .collect();
337
    assert_eq!(lines, vec![("context".into(), "a".into()), ("add".into(), "A".into())], "{v}");
338
    assert_eq!(v[1]["kind"], "added");
339
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/proposals/99/diff", None, None).await.0, StatusCode::NOT_FOUND);
340
    // An anchored comment comes back with its line in the projected state.
341
    let (st, v) = api(
342
        app,
343
        "POST",
344
        "/api/v1/repos/andy/demo/proposals/2/comments",
345
        Some(&bob_rw),
346
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
347
    )
348
    .await;
349
    assert_eq!(st, StatusCode::CREATED, "{v}");
350
    assert_eq!(v["line"], 2);
351
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
352
    assert_eq!(v[0]["path"], "a.txt");
353
    assert_eq!(v[0]["line"], 2, "{v}");
354
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
355
    // Require the "build" check.
356
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
357
    let csrf = csrf_of(&settings.body);
358
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
359
        .await;
360
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
361
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
362
    assert_eq!(v["landable"], false);
363
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
364
    // Nothing to land yet for its owner (#311), and the list is only there when asked for.
365
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
366
    assert!(v.get("landable").is_none(), "{v}");
367
    // A checker reports on the projected state: first running, then passed; the page streams it.
368
    let (st, v) = api(
369
        app,
370
        "POST",
371
        "/api/v1/repos/andy/demo/checks",
372
        Some(&andy_ro),
373
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
374
    )
375
    .await;
376
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
377
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
378
    let (st, v) = api(
379
        app,
380
        "POST",
381
        "/api/v1/repos/andy/demo/checks",
382
        Some(&bob_rw),
383
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
384
    )
385
    .await;
386
    assert_eq!(st, StatusCode::CREATED, "{v}");
387
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
388
    assert_eq!(ev.kind, "check");
389
    assert_eq!(ev.check.unwrap().name, "build");
390
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
391
    assert_eq!(v[0]["status"], "passed");
392
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
393
    assert_eq!(v["landable"], true, "{v}");
394
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
395
    assert_eq!((v["landable"][0]["repository"].as_str(), v["landable"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
396
    assert!(api(app, "GET", "/api/v1/user/proposals", Some(&andy_ro), None).await.1.get("landable").is_none(), "only when asked");
397
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
398
    assert!(page.body.contains("42 tests"), "{}", page.body);
399
    // The check and the proposal reached the webhook too.
400
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
401
    oxygenhub::hooks::deliver_due(app).await;
402
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
403
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
404
    let _ = feat;
405
    let _ = rx.fail_first;
406
407
    // The inbox through the API: count, list, mark one read, mark all read.
408
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
409
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
410
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
411
    oxygenhub::db::notify::add(
412
        &app.db,
413
        oxygenhub::db::notify::New {
414
            account_id: bob_id,
415
            repo_id: Some(oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id),
416
            reason: oxygenhub::db::notify::Reason::Participating,
417
            kind: "issue.opened",
418
            title: "andy/demo#1: Bug",
419
            url: "/andy/demo/issue/1",
420
            actor: "andy",
421
        },
422
    )
423
    .await
424
    .unwrap();
425
    oxygenhub::db::notify::add(
426
        &app.db,
427
        oxygenhub::db::notify::New {
428
            account_id: bob_id,
429
            repo_id: None,
430
            reason: oxygenhub::db::notify::Reason::Participating,
431
            kind: "review",
432
            title: "andy/demo#2: Feat",
433
            url: "/andy/demo/proposal/2",
434
            actor: "andy",
435
        },
436
    )
437
    .await
438
    .unwrap();
439
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
440
    assert_eq!(st, StatusCode::OK, "{v}");
441
    assert_eq!(v["unread"], 2);
442
    assert_eq!(v["items"][0]["read"], false);
443
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
444
    // Its repository, why, its thread and the kind's label (#305).
445
    let bug = v["items"].as_array().unwrap().iter().find(|n| n["title"] == "andy/demo#1: Bug").unwrap();
446
    assert_eq!(
447
        (bug["repository"].as_str(), bug["reason"].as_str(), bug["label"].as_str()),
448
        (Some("andy/demo"), Some("participating"), Some("🐛 New Issue")),
449
        "{bug}"
450
    );
451
    assert_eq!(bug["thread"].as_str(), Some(format!("{}/andy/demo/issue/1", h.base).as_str()));
452
    let first = v["items"][0]["id"].as_i64().unwrap();
453
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
454
    assert_eq!(st, StatusCode::NO_CONTENT);
455
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
456
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
457
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
458
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
459
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
460
    // No token at all is 401, so a client knows to sign in (#303).
461
    assert_eq!(api(app, "GET", "/api/v1/notifications", None, None).await.0, StatusCode::UNAUTHORIZED);
462
    assert_eq!(api(app, "GET", "/api/v1/user", None, None).await.0, StatusCode::UNAUTHORIZED);
463
464
    // Review requests: the author asks andy; andy is told, reviews, and the
465
    // request is answered; the author hears of the review.
466
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
467
    let (st, orgs) = api(app, "GET", "/api/v1/user/orgs", Some(&andy_user), None).await;
468
    assert!(st == StatusCode::OK && orgs.is_array(), "the caller's organisations (#302): {orgs}");
469
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
470
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
471
        .await
472
        .unwrap();
473
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
474
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
475
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
476
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
477
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
478
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
479
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
480
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
481
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
482
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
483
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
484
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
485
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
486
    let (st, _) =
487
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
488
    assert_eq!(st, StatusCode::CREATED);
489
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
490
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
491
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
492
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
493
    // Asking again and withdrawing it.
494
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
495
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
496
    assert_eq!(st, StatusCode::NO_CONTENT);
497
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
498
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
499
    // oxygenhub#84: the page's menu sets who is asked, all at once.
500
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
501
    assert!(
502
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
503
        "the reviewers menu lists andy"
504
    );
505
    let csrf = csrf_of(&page.body);
506
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
507
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
508
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
509
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
510
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
511
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
512
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
513
514
    // A source bookmark with `/` in its name, as a feature/N-name workflow
515
    // makes them: by name, and as this repository's owner/name:bookmark.
516
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
517
        client.bookmark_create(b, Some(&[base])).unwrap();
518
        client.bookmark_switch(b, false).unwrap();
519
        write(work.path(), file, b"c\n");
520
        client.snapshot("t").unwrap();
521
        client.commit(b, &[]).unwrap();
522
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
523
    }
524
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
525
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
526
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
527
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
528
        let n = v["number"].as_i64().unwrap();
529
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
530
        assert_eq!(page.status, StatusCode::OK);
531
        assert!(page.body.contains("feature/"), "the page names its source");
532
    }
533
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
534
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
535
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
536
537
    // oxygenhub#76: a proposal's title and description are edited through
538
    // the API by its author or a maintainer; what is not given stays.
539
    let edit = |token: &str, number: i64, body: &str| {
540
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
541
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
542
    };
543
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
544
    assert_eq!(st, StatusCode::OK, "{v}");
545
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
546
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
547
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
548
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
549
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
550
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
551
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
552
    let (st, v) = api(
553
        app,
554
        "POST",
555
        "/api/v1/repos/andy/demo/proposals",
556
        Some(&andy_pw),
557
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
558
    )
559
    .await;
560
    assert_eq!(st, StatusCode::CREATED, "{v}");
561
    let n = v["number"].as_i64().unwrap();
562
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
563
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
564
565
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
566
    // before anything changes, shown in its JSON.
567
    for l in ["ui", "flow"] {
568
        let body = format!(r#"{{"name":"{l}"}}"#);
569
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
570
    }
571
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
572
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
573
    assert_eq!(st, StatusCode::OK, "{v}");
574
    let names = |v: &serde_json::Value| -> Vec<String> {
575
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
576
    };
577
    assert_eq!(names(&v), ["flow", "ui"]);
578
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
579
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
580
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
581
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
582
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
583
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
584
    assert_eq!(names(&v), ["flow"]);
585
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
586
}
587
588
#[tokio::test(flavor = "multi_thread")]
589
async fn api_issue_triage_and_labels() {
590
    let h = hub().await;
591
    let app = &h.app;
592
    let andy = call(
593
        app,
594
        "POST",
595
        "/register",
596
        None,
597
        None,
598
        None,
599
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
600
    )
601
    .await
602
    .cookie
603
    .unwrap();
604
    let bob = call(
605
        app,
606
        "POST",
607
        "/register",
608
        None,
609
        None,
610
        None,
611
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
612
    )
613
    .await
614
    .cookie
615
    .unwrap();
616
    let mint = |cookie: String, scopes: &'static str| {
617
        let app = app.clone();
618
        async move {
619
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
620
            let csrf = csrf_of(&page.body);
621
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
622
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
623
        }
624
    };
625
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
626
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
627
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
628
    assert_eq!(st, StatusCode::CREATED);
629
630
    // Labels through the API; bad colours and non-triage callers are refused.
631
    let (st, v) = api(
632
        app,
633
        "POST",
634
        "/api/v1/repos/andy/demo/labels",
635
        Some(&andy_t),
636
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
637
    )
638
    .await;
639
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
640
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
641
    assert_eq!(
642
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
643
        StatusCode::BAD_REQUEST
644
    );
645
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
646
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
647
    assert_eq!(labels.as_array().unwrap().len(), 2);
648
    // oxygenhub#91: milestones over the API, for triage.
649
    let (st, m) = api(
650
        app,
651
        "POST",
652
        "/api/v1/repos/andy/demo/milestones",
653
        Some(&andy_t),
654
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
655
    )
656
    .await;
657
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
658
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
659
    assert_eq!(
660
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
661
        StatusCode::BAD_REQUEST
662
    );
663
    assert_eq!(
664
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
665
        StatusCode::FORBIDDEN
666
    );
667
    let (st, m) =
668
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
669
            .await;
670
    assert_eq!(
671
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
672
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
673
        "{m}"
674
    );
675
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
676
    assert_eq!(
677
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
678
        StatusCode::NOT_FOUND,
679
        "renamed"
680
    );
681
    assert_eq!(
682
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
683
        StatusCode::BAD_REQUEST
684
    );
685
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
686
    assert_eq!(list.as_array().unwrap().len(), 1);
687
688
    // An issue created with its labels and assignee in one call.
689
    let (st, v) = api(
690
        app,
691
        "POST",
692
        "/api/v1/repos/andy/demo/issues",
693
        Some(&andy_t),
694
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
695
    )
696
    .await;
697
    assert_eq!(st, StatusCode::CREATED, "{v}");
698
    assert_eq!(v["labels"][0]["name"], "bug");
699
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
700
    let n = v["number"].as_i64().unwrap();
701
    // Unknown names are refused before anything is created.
702
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
703
    assert_eq!(st, StatusCode::BAD_REQUEST);
704
    assert!(v["detail"].as_str().unwrap().contains("no label"));
705
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
706
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
707
    // Without triage, labels cannot be set, but a plain issue can be opened.
708
    assert_eq!(
709
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
710
        StatusCode::FORBIDDEN
711
    );
712
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
713
    assert_eq!(st, StatusCode::CREATED);
714
    let bob_n = bobs["number"].as_i64().unwrap();
715
716
    // PATCH: the whole label set, assignees and milestone, with events.
717
    let (st, v) =
718
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
719
            .await;
720
    assert_eq!(st, StatusCode::OK, "{v}");
721
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
722
    assert_eq!(v["assignees"], serde_json::json!([]));
723
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
724
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
725
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
726
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
727
    // The author edits their own title; others cannot; nobody but triage sets labels.
728
    let (st, v) =
729
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
730
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
731
    assert_eq!(
732
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
733
        StatusCode::FORBIDDEN
734
    );
735
    assert_eq!(
736
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
737
        StatusCode::FORBIDDEN
738
    );
739
    assert_eq!(
740
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
741
        StatusCode::BAD_REQUEST
742
    );
743
744
    // Deleting a label takes it off the issues.
745
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
746
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
747
    assert_eq!(v["labels"], serde_json::json!([]));
748
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
749
}
750
751
#[tokio::test(flavor = "multi_thread")]
752
async fn webhook_formats_editing_and_web_issue_events() {
753
    let h = hub().await;
754
    let app = &h.app;
755
    let andy = call(
756
        app,
757
        "POST",
758
        "/register",
759
        None,
760
        None,
761
        None,
762
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
763
    )
764
    .await
765
    .cookie
766
    .unwrap();
767
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
768
    let r = call(
769
        app,
770
        "POST",
771
        "/settings/tokens",
772
        None,
773
        Some(&andy),
774
        None,
775
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
776
    )
777
    .await;
778
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
779
    assert_eq!(
780
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
781
        StatusCode::CREATED
782
    );
783
    let rx = receiver().await;
784
    *rx.fail_first.lock().unwrap() = false;
785
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
786
    let csrf = csrf_of(&settings);
787
    let form = |f: String| {
788
        let andy = andy.clone();
789
        async move {
790
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
791
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
792
        }
793
    };
794
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
795
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
796
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
797
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
798
    {
799
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
800
        let before: i64 =
801
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
802
        for i in 0..MAX_WAITING {
803
            sqlx::query(
804
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
805
            )
806
            .bind(hook.id)
807
            .bind(format!("flood-{i}"))
808
            .execute(&app.db)
809
            .await
810
            .unwrap();
811
        }
812
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
813
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
814
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
815
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
816
        let after: i64 =
817
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
818
        assert_eq!(before, after);
819
    }
820
    assert_eq!(hook.format, "discord");
821
    // Ping arrives as a Discord message.
822
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
823
    let mut got = String::new();
824
    for _ in 0..100 {
825
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
826
            got = body.clone();
827
        }
828
        if !got.is_empty() {
829
            break;
830
        }
831
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
832
    }
833
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
834
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
835
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
836
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
837
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
838
839
    // Editing: a blank URL and secret keep theirs; format, events and active change.
840
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
841
        .await
842
        .contains("Webhook saved"));
843
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
844
    assert_eq!(
845
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
846
        (rx.url.as_str(), "issue", "oxygenhub", true)
847
    );
848
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
849
850
    // An issue opened on the web now reaches the hook, as the signed envelope.
851
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
852
    call(
853
        app,
854
        "POST",
855
        "/andy/demo/issues/new",
856
        None,
857
        Some(&andy),
858
        None,
859
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
860
    )
861
    .await;
862
    let mut envelope = None;
863
    for _ in 0..100 {
864
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
865
        if envelope.is_some() {
866
            break;
867
        }
868
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
869
    }
870
    let (_, sig, body) = envelope.expect("issue.opened delivered");
871
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
872
    assert_eq!(v["data"]["issue"]["title"], "From the web");
873
    assert!(sig.starts_with("blake3-keyed="));
874
    // A disabled hook through the edit form (no active box).
875
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
876
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
877
}
878
879
#[tokio::test(flavor = "multi_thread")]
880
async fn api_projects() {
881
    let h = hub().await;
882
    let app = &h.app;
883
    let andy = call(
884
        app,
885
        "POST",
886
        "/register",
887
        None,
888
        None,
889
        None,
890
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
891
    )
892
    .await
893
    .cookie
894
    .unwrap();
895
    let bob = call(
896
        app,
897
        "POST",
898
        "/register",
899
        None,
900
        None,
901
        None,
902
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
903
    )
904
    .await
905
    .cookie
906
    .unwrap();
907
    let mint = |cookie: String, scopes: &'static str| {
908
        let app = app.clone();
909
        async move {
910
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
911
            let csrf = csrf_of(&page.body);
912
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
913
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
914
        }
915
    };
916
    let a = mint(andy, "scopes=repo%3Aadmin").await;
917
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
918
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
919
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
920
921
    // The caller's own repositories, a page at a time (#302); bob has none.
922
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"zeta","visibility":"private"}"#)).await;
923
    let names =
924
        |v: &serde_json::Value| -> Vec<String> { v.as_array().unwrap().iter().map(|r| r["name"].as_str().unwrap().to_string()).collect() };
925
    let (st, v) = api(app, "GET", "/api/v1/user/repos", Some(&a), None).await;
926
    assert_eq!((st, names(&v)), (StatusCode::OK, vec!["demo".to_string(), "zeta".to_string()]), "{v}");
927
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?limit=1", Some(&a), None).await.1), ["demo"]);
928
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?after=andy/demo", Some(&a), None).await.1), ["zeta"]);
929
    assert!(names(&api(app, "GET", "/api/v1/user/repos", Some(&b), None).await.1).is_empty(), "not bob's");
930
    assert_eq!(api(app, "GET", "/api/v1/user/repos?affiliation=friend", Some(&a), None).await.0, StatusCode::BAD_REQUEST);
931
    assert_eq!(api(app, "GET", "/api/v1/user/repos", None, None).await.0, StatusCode::UNAUTHORIZED);
932
    // The proposals to act on, as the dashboard lists them: bob's in andy's
933
    // repository is andy's to review and bob's own.
934
    let demo = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
935
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
936
    oxygenhub::db::proposals::create(
937
        &app.db,
938
        oxygenhub::db::proposals::NewProposal {
939
            repo_id: demo.id,
940
            title: "Faster startup",
941
            body: "",
942
            author_id: Some(bob_id),
943
            author: "bob",
944
            draft: false,
945
            target: "main",
946
            source_kind: "bookmark",
947
            source_repo_id: Some(demo.id),
948
            source_bookmark: "fast",
949
            source_changes: "",
950
        },
951
    )
952
    .await
953
    .unwrap();
954
    let (st, v) = api(app, "GET", "/api/v1/user/proposals", Some(&a), None).await;
955
    assert_eq!(st, StatusCode::OK, "{v}");
956
    assert_eq!((v["review"][0]["repository"].as_str(), v["review"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
957
    assert_eq!(v["review"][0]["state"], "open");
958
    assert!(v["review"][0]["url"].as_str().unwrap().ends_with("/andy/demo/proposal/2"));
959
    assert_eq!(v["authored"].as_array().map(Vec::len), Some(0));
960
    let (_, v) = api(app, "GET", "/api/v1/user/proposals", Some(&b), None).await;
961
    assert_eq!((v["review"].as_array().map(Vec::len), v["authored"][0]["title"].as_str()), (Some(0), Some("Faster startup")), "{v}");
962
    assert_eq!(api(app, "GET", "/api/v1/user/proposals", None, None).await.0, StatusCode::UNAUTHORIZED);
963
964
    // Organisations need user:read, which this token lacks.
965
    assert_eq!(api(app, "GET", "/api/v1/user/orgs", Some(&a), None).await.0, StatusCode::FORBIDDEN);
966
967
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
968
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
969
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
970
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
971
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
972
973
    // Cards by reference, into a column by name, and a note into the first column.
974
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
975
    assert_eq!(st, StatusCode::CREATED, "{card}");
976
    assert_eq!(
977
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
978
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
979
    );
980
    assert_eq!((card["labels"].as_array().map(Vec::len), card["assignees"].as_array().map(Vec::len)), (Some(0), Some(0)), "{card}");
981
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
982
    assert_eq!(st, StatusCode::BAD_REQUEST);
983
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
984
    assert_eq!(
985
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
986
        StatusCode::BAD_REQUEST
987
    );
988
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
989
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
990
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
991
992
    // Move and read the board.
993
    let id = card["id"].as_i64().unwrap();
994
    assert_eq!(
995
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
996
        StatusCode::NO_CONTENT
997
    );
998
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
999
    let names: Vec<(&str, usize)> =
1000
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1001
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
1002
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
1003
    // The cards by column (#115), and a wrong method answers with a body.
1004
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
1005
    assert_eq!(st, StatusCode::OK);
1006
    assert_eq!(cols, board["columns"]);
1007
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
1008
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
1009
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
1010
1011
    // A column's cards at once (#289): with exceptions, a state filter and
1012
    // a dry run; one audit entry.
1013
    for t in ["Second", "Third"] {
1014
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(&format!(r#"{{"title":"{t}"}}"#))).await;
1015
    }
1016
    for n in [2, 3] {
1017
        let body = format!(r#"{{"reference":"demo#{n}","column":"Doing"}}"#);
1018
        assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(&body)).await.0, StatusCode::CREATED);
1019
    }
1020
    let bulk = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&a), Some(body));
1021
    let refs = |v: &serde_json::Value, k: &str| -> Vec<String> {
1022
        v[k].as_array().unwrap().iter().map(|c| c["reference"].as_str().unwrap().to_string()).collect()
1023
    };
1024
    let (st, v) = bulk(r##"{"from":"Doing","column":"Done","except":["#2"],"dry_run":true}"##).await;
1025
    assert_eq!(st, StatusCode::OK, "{v}");
1026
    assert_eq!((refs(&v, "moved"), refs(&v, "kept")), (vec!["andy/demo#3".to_string()], vec!["andy/demo#2".to_string()]));
1027
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1028
    assert_eq!(board["columns"][1]["cards"].as_array().unwrap().len(), 2, "a dry run moves nothing");
1029
    let (_, v) = bulk(r#"{"from":"Doing","column":"Done","state":["closed"]}"#).await;
1030
    assert!(refs(&v, "moved").is_empty(), "both are open: {v}");
1031
    let (_, v) = bulk(r#"{"from":"doing","column":"done","except":["demo#2"]}"#).await;
1032
    assert_eq!(refs(&v, "moved"), ["andy/demo#3"]);
1033
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1034
    let names: Vec<(&str, usize)> =
1035
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1036
    assert_eq!(names, [("Backlog", 1), ("Doing", 1), ("Done", 2)]);
1037
    let audited: i64 =
1038
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_moved'").fetch_one(&app.db).await.unwrap();
1039
    assert_eq!(audited, 1, "the dry run and the empty move are not audited");
1040
    assert_eq!(bulk(r#"{"from":"Done","column":"Done"}"#).await.0, StatusCode::BAD_REQUEST);
1041
    assert_eq!(
1042
        api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&b), Some(r#"{"from":"Doing","column":"Done"}"#)).await.0,
1043
        StatusCode::FORBIDDEN
1044
    );
1045
1046
    // Archive (#293): Done's cards there more than a week (#3, made old),
1047
    // listed with ?archived=true, restored once.
1048
    sqlx::query("UPDATE project_cards SET moved_ms = 0 WHERE number = 3").execute(&app.db).await.unwrap();
1049
    let archive = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/archive", Some(&a), Some(body));
1050
    let (st, v) = archive(r#"{"from":"Done","older_days":7,"dry_run":true}"#).await;
1051
    assert_eq!((st, refs(&v, "archived")), (StatusCode::OK, vec!["andy/demo#3".to_string()]), "{v}");
1052
    assert!(v["archived"][0].get("archived_ms").is_none(), "a dry run archives nothing: {v}");
1053
    let (_, v) = archive(r#"{"from":"Done","older_days":7}"#).await;
1054
    assert_eq!((refs(&v, "archived"), refs(&v, "kept").len()), (vec!["andy/demo#3".to_string()], 1), "{v}");
1055
    assert!(v["archived"][0]["archived_ms"].as_i64().is_some());
1056
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1057
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 1, "off the board: {board}");
1058
    let (st, archived) = api(app, "GET", "/api/v1/projects/andy/1/cards?archived=true", None, None).await;
1059
    assert_eq!((st, archived[2]["cards"][0]["reference"].as_str()), (StatusCode::OK, Some("andy/demo#3")), "{archived}");
1060
    let card = archived[2]["cards"][0]["id"].as_i64().unwrap();
1061
    let restore = format!("/api/v1/projects/andy/1/cards/{card}/restore");
1062
    assert_eq!(api(app, "POST", &restore, Some(&b), None).await.0, StatusCode::FORBIDDEN);
1063
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NO_CONTENT);
1064
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NOT_FOUND, "not archived now");
1065
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1066
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 2);
1067
    assert_eq!(archive(r#"{"from":"Done","older_days":-1}"#).await.0, StatusCode::BAD_REQUEST);
1068
    let audited: i64 =
1069
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_archived'").fetch_one(&app.db).await.unwrap();
1070
    assert_eq!(audited, 1);
1071
1072
    // Private: hidden from others; closed: read-only; then remove a card.
1073
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
1074
    assert_eq!(edited["public"], false);
1075
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
1076
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
1077
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
1078
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
1079
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
1080
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
1081
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
1082
}
1083
1084
#[tokio::test(flavor = "multi_thread")]
1085
async fn api_required_checks() {
1086
    let h = hub().await;
1087
    let app = &h.app;
1088
    let andy = call(
1089
        app,
1090
        "POST",
1091
        "/register",
1092
        None,
1093
        None,
1094
        None,
1095
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1096
    )
1097
    .await
1098
    .cookie
1099
    .unwrap();
1100
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1101
    let csrf = csrf_of(&page.body);
1102
    let mint = |scopes: &'static str| {
1103
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1104
        async move {
1105
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1106
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1107
        }
1108
    };
1109
    let admin = mint("scopes=repo%3Aadmin").await;
1110
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1111
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1112
1113
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1114
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1115
    let (st, v) = api(
1116
        app,
1117
        "PUT",
1118
        "/api/v1/repos/andy/demo/checks/required",
1119
        Some(&admin),
1120
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1121
    )
1122
    .await;
1123
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1124
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1125
    assert_eq!(
1126
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1127
        serde_json::json!(["flow/fmt", "flow/test"])
1128
    );
1129
    assert_eq!(
1130
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1131
        StatusCode::FORBIDDEN,
1132
        "repo:admin only"
1133
    );
1134
    assert_eq!(
1135
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1136
        StatusCode::BAD_REQUEST
1137
    );
1138
    // The settings page shows the same list.
1139
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
1140
}
1141
1142
/// OxygenFlow per repository: site administrators turn it on or off in
1143
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1144
#[tokio::test(flavor = "multi_thread")]
1145
async fn flow_is_switched_per_repository_by_site_admins() {
1146
    let h = hub().await;
1147
    let app = &h.app;
1148
    let andy = call(
1149
        app,
1150
        "POST",
1151
        "/register",
1152
        None,
1153
        None,
1154
        None,
1155
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1156
    )
1157
    .await
1158
    .cookie
1159
    .unwrap();
1160
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1161
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1162
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1163
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1164
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
1165
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
1166
1167
    let set = |value: &'static str| {
1168
        let (app, andy) = (app.clone(), andy.clone());
1169
        async move {
1170
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1171
            let r = call(
1172
                &app,
1173
                "POST",
1174
                "/andy/demo/settings/flow",
1175
                None,
1176
                Some(&andy),
1177
                None,
1178
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1179
            )
1180
            .await;
1181
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
1182
        }
1183
    };
1184
    // A repository admin who is not a site admin sees the state but cannot change it.
1185
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1186
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
1187
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1188
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1189
    let r = set("on").await;
1190
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1191
    assert_eq!(row().await.flow, "");
1192
1193
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1194
    let r = set("on").await;
1195
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1196
    assert_eq!(row().await.flow, "on");
1197
    assert!(oxygenhub::flow::enabled(app, &row().await));
1198
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1199
    set("off").await;
1200
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1201
    set("default").await;
1202
    assert_eq!(row().await.flow, "");
1203
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
1204
}
1205
1206
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1207
/// button, never the repository's default bookmark as the hub sets it.
1208
#[tokio::test(flavor = "multi_thread")]
1209
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1210
    let h = hub().await;
1211
    let app = &h.app;
1212
    let andy = call(
1213
        app,
1214
        "POST",
1215
        "/register",
1216
        None,
1217
        None,
1218
        None,
1219
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1220
    )
1221
    .await
1222
    .cookie
1223
    .unwrap();
1224
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1225
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1226
    let url = format!("{}/andy/demo", h.base);
1227
    let work = tempfile::tempdir().unwrap();
1228
    let (w, u) = (work.path().to_path_buf(), url.clone());
1229
    let client = tokio::task::spawn_blocking(move || {
1230
        let mut c = Repo::init(&w).unwrap();
1231
        c.config.set("remote.origin.url", &u).unwrap();
1232
        c.config.set("remote.origin.token", "site").unwrap();
1233
        c.save_config().unwrap();
1234
        write(&w, "a.txt", b"a\n");
1235
        c.commit("a", &[]).unwrap();
1236
        assert!(c.push("origin", false).unwrap()[0].ok);
1237
        for b in ["develop", "feature/x", "stray"] {
1238
            c.bookmark_create(b, None).unwrap();
1239
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1240
        }
1241
        // A pushed deletion.
1242
        let r = c.push_delete("origin", "feature/x").unwrap();
1243
        assert!(r[0].ok, "{r:?}");
1244
        c
1245
    })
1246
    .await
1247
    .unwrap();
1248
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1249
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1250
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1251
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1252
    assert!(!anon.body.contains("/bookmarks/delete"));
1253
1254
    // The hub's default, not the repository's config, is protected: make
1255
    // develop the default, then main can go and develop cannot.
1256
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1257
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1258
    let client = tokio::task::spawn_blocking(move || {
1259
        let r = client.push_delete("origin", "develop").unwrap();
1260
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1261
        let r = client.push_delete("origin", "main").unwrap();
1262
        assert!(r[0].ok, "{r:?}");
1263
        client
1264
    })
1265
    .await
1266
    .unwrap();
1267
    drop(client);
1268
1269
    // On the web: a writer deletes stray; the default is refused.
1270
    let form = |b: &'static str| {
1271
        let (app, andy) = (app.clone(), andy.clone());
1272
        async move {
1273
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1274
            call(
1275
                &app,
1276
                "POST",
1277
                "/andy/demo/bookmarks/delete",
1278
                None,
1279
                Some(&andy),
1280
                None,
1281
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1282
            )
1283
            .await
1284
        }
1285
    };
1286
    let r = form("stray").await;
1287
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1288
    assert!(!r.body.contains(">stray<"));
1289
    let r = form("develop").await;
1290
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1291
    let r = form("nope").await;
1292
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1293
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1294
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1295
    // Anonymous visitors cannot.
1296
    assert_ne!(
1297
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1298
        StatusCode::OK
1299
    );
1300
}
1301
1302
/// A change signed by a key no account has linked says so, on its page
1303
/// and in the API (feedback 14).
1304
#[tokio::test(flavor = "multi_thread")]
1305
async fn changes_signed_by_unlinked_keys_say_so() {
1306
    let h = hub().await;
1307
    let app = &h.app;
1308
    let andy = call(
1309
        app,
1310
        "POST",
1311
        "/register",
1312
        None,
1313
        None,
1314
        None,
1315
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1316
    )
1317
    .await
1318
    .cookie
1319
    .unwrap();
1320
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1321
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1322
    let url = format!("{}/andy/demo", h.base);
1323
    let work = tempfile::tempdir().unwrap();
1324
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1325
    let hash = tokio::task::spawn_blocking(move || {
1326
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1327
        c.config.set("remote.origin.url", &u).unwrap();
1328
        c.config.set("remote.origin.token", "site").unwrap();
1329
        c.save_config().unwrap();
1330
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1331
        write(&w.join("r"), "a.txt", b"a\n");
1332
        let h = c.commit("signed by Ada", &[]).unwrap();
1333
        assert!(c.push("origin", false).unwrap()[0].ok);
1334
        h.to_hex()
1335
    })
1336
    .await
1337
    .unwrap();
1338
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1339
    assert_eq!(st, StatusCode::OK, "{v}");
1340
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1341
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1342
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1343
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1344
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1345
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1346
}
1347
1348
/// Function history (hub spec §6.6): the file page lists a file's
1349
/// functions, and a function's page lists exactly the changes to its lines.
1350
#[tokio::test(flavor = "multi_thread")]
1351
async fn a_function_has_its_own_history() {
1352
    let h = hub().await;
1353
    let app = &h.app;
1354
    let andy = call(
1355
        app,
1356
        "POST",
1357
        "/register",
1358
        None,
1359
        None,
1360
        None,
1361
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1362
    )
1363
    .await
1364
    .cookie
1365
    .unwrap();
1366
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1367
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1368
    let url = format!("{}/andy/demo", h.base);
1369
    let work = tempfile::tempdir().unwrap();
1370
    let w = work.path().to_path_buf();
1371
    tokio::task::spawn_blocking(move || {
1372
        let mut c = Repo::init(&w).unwrap();
1373
        c.config.set("remote.origin.url", &url).unwrap();
1374
        c.config.set("remote.origin.token", "site").unwrap();
1375
        c.save_config().unwrap();
1376
        let steps = [
1377
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1378
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1379
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1380
        ];
1381
        for (msg, text) in steps {
1382
            write(&w, "src/lib.rs", text.as_bytes());
1383
            c.commit(msg, &[]).unwrap();
1384
        }
1385
        assert!(c.push("origin", false).unwrap()[0].ok);
1386
    })
1387
    .await
1388
    .unwrap();
1389
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1390
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1391
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1392
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1393
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1394
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1395
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1396
    assert_ne!(bad.status, StatusCode::OK);
1397
}
1398
1399
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1400
/// dependency edges, linked cards.
1401
#[tokio::test(flavor = "multi_thread")]
1402
async fn a_bookmark_shows_as_swimlanes() {
1403
    let h = hub().await;
1404
    let app = &h.app;
1405
    let andy = call(
1406
        app,
1407
        "POST",
1408
        "/register",
1409
        None,
1410
        None,
1411
        None,
1412
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1413
    )
1414
    .await
1415
    .cookie
1416
    .unwrap();
1417
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1418
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1419
    let url = format!("{}/andy/demo", h.base);
1420
    let work = tempfile::tempdir().unwrap();
1421
    let w = work.path().to_path_buf();
1422
    tokio::task::spawn_blocking(move || {
1423
        let mut c = Repo::init(&w).unwrap();
1424
        c.config.set("remote.origin.url", &url).unwrap();
1425
        c.config.set("remote.origin.token", "site").unwrap();
1426
        c.save_config().unwrap();
1427
        // Two files edited independently: two lanes.
1428
        write(&w, "a.txt", b"a\n");
1429
        c.commit("add a", &[]).unwrap();
1430
        write(&w, "b.txt", b"b\n");
1431
        c.commit("add b", &[]).unwrap();
1432
        write(&w, "a.txt", b"a\na2\n");
1433
        c.commit("grow a", &[]).unwrap();
1434
        assert!(c.push("origin", false).unwrap()[0].ok);
1435
    })
1436
    .await
1437
    .unwrap();
1438
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1439
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1440
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1441
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1442
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1443
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1444
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1445
    assert_eq!(board.matches("<rect ").count(), 3);
1446
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1447
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1448
}
1449
1450
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1451
/// offers only what makes sense and rewrites nothing itself.
1452
#[tokio::test(flavor = "multi_thread")]
1453
async fn a_proposal_board_plans_squashes_and_rebases() {
1454
    let h = hub().await;
1455
    let app = &h.app;
1456
    let andy = call(
1457
        app,
1458
        "POST",
1459
        "/register",
1460
        None,
1461
        None,
1462
        None,
1463
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1464
    )
1465
    .await
1466
    .cookie
1467
    .unwrap();
1468
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1469
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1470
    let url = format!("{}/andy/demo", h.base);
1471
    let work = tempfile::tempdir().unwrap();
1472
    let w = work.path().to_path_buf();
1473
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1474
        let mut c = Repo::init(&w).unwrap();
1475
        c.config.set("remote.origin.url", &url).unwrap();
1476
        c.config.set("remote.origin.token", "site").unwrap();
1477
        c.save_config().unwrap();
1478
        write(&w, "a.txt", b"a\n");
1479
        let base = c.commit("base", &[]).unwrap();
1480
        assert!(c.push("origin", false).unwrap()[0].ok);
1481
        c.bookmark_create("feature", None).unwrap();
1482
        c.bookmark_switch("feature", false).unwrap();
1483
        write(&w, "a.txt", b"a\nfirst\n");
1484
        let first = c.commit("first", &[]).unwrap();
1485
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1486
        let second = c.commit("second", &[]).unwrap();
1487
        write(&w, "b.txt", b"apart\n");
1488
        let apart = c.commit("apart", &[]).unwrap();
1489
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1490
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1491
    })
1492
    .await
1493
    .unwrap();
1494
    // No proposal yet: the board is read-only.
1495
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1496
    assert!(!board.contains("data-plan="));
1497
    let (st, _) = api(
1498
        app,
1499
        "POST",
1500
        "/api/v1/repos/andy/demo/proposals",
1501
        Some("site"),
1502
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1503
    )
1504
    .await;
1505
    assert!(st.is_success(), "{st}");
1506
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1507
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1508
    let csrf = csrf_of(&board);
1509
    let plan = |c: &str, t: &str| {
1510
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1511
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1512
        async move {
1513
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1514
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1515
        }
1516
    };
1517
    let kinds = |v: &serde_json::Value| {
1518
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1519
    };
1520
    // second already depends on first: squash, no rebase.
1521
    let v = plan(&second, &first).await;
1522
    assert_eq!(kinds(&v), ["squash"], "{v}");
1523
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1524
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
1525
    // apart is independent of second: either.
1526
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1527
    // first under second: nothing (second depends on first).
1528
    assert!(plan(&first, &second).await["error"].is_string());
1529
    // What has landed on main is not rearranged.
1530
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1531
}
1532
1533
/// Issues and proposals share a number space, so every number says what it
1534
/// is, and the chain of work shows from both ends (hub spec §8).
1535
#[tokio::test(flavor = "multi_thread")]
1536
async fn proposals_and_issues_show_their_chain() {
1537
    let h = hub().await;
1538
    let app = &h.app;
1539
    let andy = call(
1540
        app,
1541
        "POST",
1542
        "/register",
1543
        None,
1544
        None,
1545
        None,
1546
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1547
    )
1548
    .await
1549
    .cookie
1550
    .unwrap();
1551
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1552
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1553
    let url = format!("{}/andy/demo", h.base);
1554
    let work = tempfile::tempdir().unwrap();
1555
    let w = work.path().to_path_buf();
1556
    tokio::task::spawn_blocking(move || {
1557
        let mut c = Repo::init(&w).unwrap();
1558
        c.config.set("remote.origin.url", &url).unwrap();
1559
        c.config.set("remote.origin.token", "site").unwrap();
1560
        c.save_config().unwrap();
1561
        write(&w, "a.txt", b"a\n");
1562
        c.commit("base", &[]).unwrap();
1563
        assert!(c.push("origin", false).unwrap()[0].ok);
1564
        c.bookmark_create("feature", None).unwrap();
1565
        c.bookmark_switch("feature", false).unwrap();
1566
        write(&w, "a.txt", b"a\nfixed\n");
1567
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1568
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1569
    })
1570
    .await
1571
    .unwrap();
1572
    for title in ["Slow start", "Crash on save"] {
1573
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1574
        assert!(st.is_success());
1575
    }
1576
    let (st, v) = api(
1577
        app,
1578
        "POST",
1579
        "/api/v1/repos/andy/demo/proposals",
1580
        Some("site"),
1581
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1582
    )
1583
    .await;
1584
    assert!(st.is_success(), "{st} {v}");
1585
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1586
1587
    // The proposal names its kind, links its references by kind, and shows
1588
    // the chain: the issues it closes (description and changes) → it → main.
1589
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1590
    assert!(p.contains(">proposal #3</small>"), "header");
1591
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1592
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1593
    let chain = &chain[..chain.find("</p>").unwrap()];
1594
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1595
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1596
    }
1597
    assert!(p.contains("<h3>Closes</h3>"));
1598
1599
    // The issue shows the proposal that closes it, and names its own kind.
1600
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1601
    assert!(i.contains(">issue #1</small>"));
1602
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1603
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1604
    // The conversation is a timeline with avatars; editing sits with the
1605
    // content, not in the sidebar, and labels and projects are editable.
1606
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1607
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1608
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1609
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1610
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1611
    assert!(st.is_success(), "{st}");
1612
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1613
    assert!(
1614
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1615
        "the owner's projects to add to, in a menu"
1616
    );
1617
    let csrf = csrf_of(&p);
1618
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1619
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1620
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1621
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1622
        .await;
1623
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1624
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1625
1626
    // Closed by the proposal's change, not its description: still shown.
1627
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1628
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1629
    assert!(chain.contains("proposal #3"), "{chain}");
1630
}
1631
1632
/// What the hub is: its version and build, and the libraries it is built on,
1633
/// on /about, in the API and in /health (hub spec §15).
1634
#[tokio::test(flavor = "multi_thread")]
1635
async fn the_hub_says_what_version_it_is() {
1636
    let h = hub().await;
1637
    let app = &h.app;
1638
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1639
    assert_eq!(st, StatusCode::OK);
1640
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1641
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1642
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1643
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1644
    assert!(health.contains("\"build\""), "{health}");
1645
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1646
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
1647
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1648
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1649
    assert!(about.contains("href=\"/about\""), "the footer links here");
1650
}
1651
1652
#[tokio::test(flavor = "multi_thread")]
1653
async fn device_sign_in() {
1654
    let h = hub().await;
1655
    let app = &h.app;
1656
    let r = call(
1657
        app,
1658
        "POST",
1659
        "/register",
1660
        None,
1661
        None,
1662
        None,
1663
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1664
    )
1665
    .await;
1666
    let andy = r.cookie.unwrap();
1667
1668
    // An unknown scope is refused.
1669
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1670
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1671
1672
    // The app asks for a code and polls; nobody has approved it yet.
1673
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1674
    assert_eq!(st, StatusCode::OK, "{v}");
1675
    let device = v["device_code"].as_str().unwrap().to_string();
1676
    let user = v["user_code"].as_str().unwrap().to_string();
1677
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1678
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1679
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1680
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1681
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1682
    assert_eq!(v["error"], "slow_down", "polled too soon");
1683
1684
    // The user approves it on the web, allowing less than it asked for.
1685
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1686
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1687
    let csrf = csrf_of(&page.body);
1688
    let r =
1689
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1690
            .await;
1691
    // oxygenhub#83: the answer page says it is done, with no code form.
1692
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1693
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1694
1695
    // The next poll gets a token with what was allowed, once.
1696
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1697
    assert_eq!(st, StatusCode::OK, "{v}");
1698
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1699
    let token = v["access_token"].as_str().unwrap().to_string();
1700
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1701
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1702
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1703
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1704
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1705
    assert!(tokens.body.contains("device: Phone app"));
1706
    // oxygenhub#70: a device's token expires, and each use renews it.
1707
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1708
1709
    // The token can revoke itself (oxy auth logout), and is then refused.
1710
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1711
    assert_eq!(st, StatusCode::NO_CONTENT);
1712
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1713
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1714
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1715
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1716
1717
    // A denied code says so.
1718
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1719
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1720
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1721
    let csrf = csrf_of(&page.body);
1722
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1723
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1724
    assert_eq!(v["error"], "access_denied");
1725
1726
    // A code the app gave up on (#304) is gone at once: the page no longer
1727
    // takes it, and the app's poll says so.
1728
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Cancelled"}"#)).await;
1729
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1730
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1731
    assert_eq!(st, StatusCode::NO_CONTENT);
1732
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1733
    let csrf = csrf_of(&page.body);
1734
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve"))).await;
1735
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1736
    assert_eq!(v["error"], "expired_token", "{v}");
1737
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1738
    assert_eq!(st, StatusCode::NO_CONTENT, "again: still fine");
1739
1740
    // Signed out, the page asks for a sign-in first.
1741
    let r = call(app, "GET", "/device", None, None, None, None).await;
1742
    assert!(r.status.is_redirection(), "{}", r.status);
1743
}
1744
1745
#[tokio::test(flavor = "multi_thread")]
1746
async fn api_assistants_at_each_level() {
1747
    let h = hub().await;
1748
    let app = &h.app;
1749
    let andy = call(
1750
        app,
1751
        "POST",
1752
        "/register",
1753
        None,
1754
        None,
1755
        None,
1756
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1757
    )
1758
    .await
1759
    .cookie
1760
    .unwrap();
1761
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1762
    let csrf = csrf_of(&page.body);
1763
    let mint = |scopes: &'static str| {
1764
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1765
        async move {
1766
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1767
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1768
        }
1769
    };
1770
    let admin = mint("scopes=repo%3Aadmin").await;
1771
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1772
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1773
    // A stand-in endpoint with no model list: any model name is taken.
1774
    let router = axum::Router::new().route(
1775
        "/v1/chat/completions",
1776
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1777
    );
1778
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1779
    let port = listener.local_addr().unwrap().port();
1780
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1781
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1782
1783
    // The site's, by its administrator; the repository's, by its admin.
1784
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1785
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1786
    assert_eq!(st, StatusCode::OK, "{v}");
1787
    assert_eq!(v["ok"], "Gemini added");
1788
    let body =
1789
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1790
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1791
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1792
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1793
    assert_eq!(st, StatusCode::OK, "{v}");
1794
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1795
    assert_eq!(st, StatusCode::OK);
1796
    let names: Vec<(&str, &str, bool)> = v
1797
        .as_array()
1798
        .unwrap()
1799
        .iter()
1800
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1801
        .collect();
1802
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1803
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1804
    // Changing it keeps the token when none is given.
1805
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1806
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1807
    assert_eq!(v["ok"], "Claude updated");
1808
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1809
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1810
    // Prompts: the site's is inherited by the repository.
1811
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1812
    assert_eq!(st, StatusCode::OK);
1813
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1814
    assert_eq!(v["prompt"], "Rust.");
1815
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1816
    // Removed.
1817
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1818
    assert_eq!(st, StatusCode::NO_CONTENT);
1819
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1820
    assert_eq!(st, StatusCode::NOT_FOUND);
1821
}