OXYGENHUB
# 67040b158ae2 oxygenhub / crates / hub / tests / issues.rs
45.8 KiB · Rust · last changed Issue page: GitHub-style sidebar menus and a full-width comment box 1 month ago source blame history raw
1
//! Milestone 0.4 end to end: issues with labels, assignees and
2
//! milestones, cross references, closing keywords on landing, the inbox,
3
//! watching, mentions and search.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use http_body_util::BodyExt;
8
use oxy_core::repo::Repo;
9
use oxygenhub::config::Config;
10
use oxygenhub::db;
11
use oxygenhub::repos::RepoName;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use tower::ServiceExt;
15
16
fn hermetic() {
17
    static ONCE: std::sync::Once = std::sync::Once::new();
18
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
19
    ONCE.call_once(|| {
20
        let d = tempfile::tempdir().unwrap();
21
        std::env::set_var("OXY_HOME", d.path());
22
        DIR.set(d).ok();
23
    });
24
}
25
26
fn write(root: &Path, rel: &str, content: &[u8]) {
27
    let p = root.join(rel);
28
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
29
    std::fs::write(p, content).unwrap();
30
}
31
32
struct Hub {
33
    app: Shared,
34
    base: String,
35
    _dir: tempfile::TempDir,
36
}
37
38
async fn hub() -> Hub {
39
    hermetic();
40
    let dir = tempfile::tempdir().unwrap();
41
    let mut config = Config::load(dir.path()).unwrap();
42
    config.auth.push_tokens = vec!["site".into()];
43
    config.registration.mode = "open".into();
44
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
45
    let port = listener.local_addr().unwrap().port();
46
    config.server.base_url = format!("http://127.0.0.1:{port}");
47
    let app = oxygenhub::build(config).await.unwrap();
48
    let router = oxygenhub::router(app.clone());
49
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
50
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
51
}
52
53
struct Res {
54
    status: StatusCode,
55
    body: String,
56
    cookie: Option<String>,
57
    location: Option<String>,
58
}
59
60
async fn send(app: &Shared, method: &str, path: &str, cookie: Option<&str>, form: Option<&str>) -> Res {
61
    let mut req = Request::builder().method(method).uri(path);
62
    if let Some(c) = cookie {
63
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
64
    }
65
    let body = match form {
66
        Some(f) => {
67
            req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
68
            Body::from(f.to_string())
69
        }
70
        None => Body::empty(),
71
    };
72
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
73
    let status = res.status();
74
    let cookie = res
75
        .headers()
76
        .get(header::SET_COOKIE)
77
        .and_then(|v| v.to_str().ok())
78
        .and_then(|v| v.split(';').next())
79
        .and_then(|kv| kv.split_once('='))
80
        .map(|(_, v)| v.to_string());
81
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
82
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
83
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
84
}
85
86
async fn get(app: &Shared, path: &str, cookie: Option<&str>) -> Res {
87
    send(app, "GET", path, cookie, None).await
88
}
89
90
async fn post(app: &Shared, path: &str, cookie: Option<&str>, form: &str) -> Res {
91
    send(app, "POST", path, cookie, Some(form)).await
92
}
93
94
async fn register(app: &Shared, user: &str) -> String {
95
    let r = post(app, "/register", None, &format!("username={user}&email={user}%40example.com&password=correct-horse-battery")).await;
96
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
97
    r.cookie.unwrap()
98
}
99
100
fn csrf_of(page: &str) -> String {
101
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
102
    page[i..].split('"').next().unwrap().to_string()
103
}
104
105
#[tokio::test(flavor = "multi_thread")]
106
async fn issues_notifications_and_search() {
107
    let h = hub().await;
108
    let app = &h.app;
109
    let andy = register(app, "andy").await;
110
    let bob = register(app, "bob").await;
111
    let repo = RepoName::parse("andy/demo").unwrap();
112
    app.repos.create(&repo, None).unwrap();
113
    db::repos::create(&app.db, "andy", "demo", "", hub_api::Visibility::Public).await.unwrap();
114
115
    // Labels and a milestone, by the owner.
116
    let labels_page = get(app, "/andy/demo/labels", Some(&andy)).await;
117
    let csrf_a = csrf_of(&labels_page.body);
118
    assert!(post(app, "/andy/demo/labels", Some(&andy), &format!("_csrf={csrf_a}&name=bug&colour=%23ff0000&description=Something+broke"))
119
        .await
120
        .body
121
        .contains("Saved bug"));
122
    assert!(post(app, "/andy/demo/milestones", Some(&andy), &format!("_csrf={csrf_a}&title=v1&description=First&due=2027-01-01"))
123
        .await
124
        .body
125
        .contains("v1"));
126
    assert_eq!(get(app, "/andy/demo/labels", Some(&bob)).await.status, StatusCode::OK, "readers see labels");
127
    assert!(!get(app, "/andy/demo/labels", Some(&bob)).await.body.contains("Add or change"), "but cannot edit them");
128
129
    // Bob watches the repository, then Andy opens an issue mentioning @bob: Bob is told twice at most once.
130
    let overview = get(app, "/andy/demo", Some(&bob)).await;
131
    let csrf_b = csrf_of(&overview.body);
132
    assert_eq!(post(app, "/andy/demo/watch", Some(&bob), &format!("_csrf={csrf_b}")).await.status, StatusCode::SEE_OTHER);
133
    assert!(get(app, "/andy/demo", Some(&bob)).await.body.contains("UNWATCH"));
134
    let new_page = get(app, "/andy/demo/issues/new", Some(&andy)).await;
135
    let csrf_a = csrf_of(&new_page.body);
136
    let r = post(
137
        app,
138
        "/andy/demo/issues/new",
139
        Some(&andy),
140
        &format!("_csrf={csrf_a}&title=Crash+on+start&body=cc+%40bob+see+%23999+and+deadbeefcafe1234"),
141
    )
142
    .await;
143
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
144
    assert_eq!(r.location.as_deref(), Some("/andy/demo/issue/1"));
145
    let page = get(app, "/andy/demo/issue/1", Some(&bob)).await;
146
    assert!(page.body.contains("Crash on start"));
147
    assert!(page.body.contains("href=\"/bob\""), "mention linked: {}", page.body);
148
    assert!(page.body.contains("/andy/demo/change/deadbeefcafe1234"), "hash linked: {}", page.body);
149
    assert!(page.body.contains("#999") && !page.body.contains("issue/999"), "unknown numbers are not linked");
150
    let unread = db::notify::unread(&app.db, db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id).await.unwrap();
151
    assert_eq!(unread, 1, "one notification, not one per reason");
152
    let inbox = get(app, "/notifications", Some(&bob)).await;
153
    assert!(inbox.body.contains("andy/demo#1: Crash on start"), "{}", inbox.body);
154
    assert!(get(app, "/andy/demo", Some(&bob)).await.body.contains("class=\"count\">1<"), "bell shows the count");
155
156
    // Triage: labels, assignee, milestone, pin, lock.
157
    let page = get(app, "/andy/demo/issue/1", Some(&andy)).await;
158
    let csrf_a = csrf_of(&page.body);
159
    let label_id: i64 = sqlx::query_scalar("SELECT id FROM labels WHERE name = 'bug'").fetch_one(&app.db).await.unwrap();
160
    let r = post(app, "/andy/demo/issue/1/labels", Some(&andy), &format!("_csrf={csrf_a}&label={label_id}")).await;
161
    assert!(r.body.contains(">bug<"), "{}", r.body);
162
    let r = post(app, "/andy/demo/issue/1/assign", Some(&andy), &format!("_csrf={csrf_a}&username=bob&action=add")).await;
163
    assert!(r.body.contains("<li><a href=\"/bob\"><img class=\"avatar xs\""), "{}", r.body);
164
    // oxygenhub#82: the sidebar's menu sets the whole list at once.
165
    assert!(r.body.contains("Assign people to this issue") && r.body.contains("data-menu-filter"), "the assignees menu");
166
    let r = post(app, "/andy/demo/issue/1/assign", Some(&andy), &format!("_csrf={csrf_a}&action=set&username=andy&username=bob")).await;
167
    let assigned = |db: sqlx::SqlitePool| async move {
168
        let id: i64 = sqlx::query_scalar("SELECT id FROM issues WHERE number = 1").fetch_one(&db).await.unwrap();
169
        let mut a = db::issues::assignees(&db, id).await.unwrap();
170
        a.sort();
171
        a
172
    };
173
    assert_eq!(assigned(app.db.clone()).await, ["andy", "bob"], "{}", r.status);
174
    post(app, "/andy/demo/issue/1/assign", Some(&andy), &format!("_csrf={csrf_a}&action=set&username=bob")).await;
175
    assert_eq!(assigned(app.db.clone()).await, ["bob"], "set takes off who is not listed");
176
    let ms_id: i64 = sqlx::query_scalar("SELECT id FROM milestones WHERE title = 'v1'").fetch_one(&app.db).await.unwrap();
177
    let r = post(app, "/andy/demo/issue/1/milestone", Some(&andy), &format!("_csrf={csrf_a}&milestone={ms_id}")).await;
178
    assert!(r.body.contains(">v1<"), "{}", r.body);
179
    assert!(post(app, "/andy/demo/issue/1/state", Some(&andy), &format!("_csrf={csrf_a}&action=pin")).await.body.contains("Unpin issue"));
180
    assert_eq!(
181
        post(
182
            app,
183
            "/andy/demo/issue/1/state",
184
            Some(&bob),
185
            &format!("_csrf={}&action=lock", csrf_of(&get(app, "/andy/demo/issue/1", Some(&bob)).await.body))
186
        )
187
        .await
188
        .status,
189
        StatusCode::NOT_FOUND,
190
        "bob cannot lock"
191
    );
192
    // Filters on the list.
193
    let list = get(app, "/andy/demo/issues?q=label:bug+assignee:bob+milestone:v1", None).await;
194
    assert!(list.body.contains("Crash on start"), "{}", list.body);
195
    assert!(!get(app, "/andy/demo/issues?q=label:feature", None).await.body.contains("Crash on start"));
196
    assert!(get(app, "/andy/demo/milestones", None).await.body.contains("1 open, 0 closed"));
197
198
    // Bob comments and closes; the author is told; search finds the comment.
199
    let csrf_b = csrf_of(&get(app, "/andy/demo/issue/1", Some(&bob)).await.body);
200
    let r = post(app, "/andy/demo/issue/1/comment", Some(&bob), &format!("_csrf={csrf_b}&body=Reproduced+with+the+flux+capacitor")).await;
201
    assert!(r.body.contains("flux capacitor"), "{}", r.body);
202
    assert!(get(app, "/notifications", Some(&andy)).await.body.contains("andy/demo#1"));
203
    let s = get(app, "/search?q=capacitor", None).await;
204
    assert!(s.body.contains("Crash on start") && s.body.contains("<mark>capacitor</mark>"), "{}", s.body);
205
    let s = get(app, "/search?q=demo", None).await;
206
    assert!(s.body.contains("/andy/demo\""), "repository hit: {}", s.body);
207
    // Bob is not triage, but as an assignee of an open issue he can comment-and-close? No: only the author or triage.
208
    let r = post(app, "/andy/demo/issue/1/comment", Some(&bob), &format!("_csrf={csrf_b}&body=closing&close=completed")).await;
209
    assert!(r.body.contains(">open<") || r.body.contains("head\">open"), "still open: {}", r.body);
210
    let r = post(app, "/andy/demo/issue/1/comment", Some(&andy), &format!("_csrf={csrf_a}&body=fixed&close=completed")).await;
211
    assert!(r.body.contains("closed"), "{}", r.body);
212
    assert!(get(app, "/andy/demo/issues?state=closed", None).await.body.contains("Crash on start"));
213
214
    // A second issue closed by a change message pushed to the default bookmark.
215
    let csrf_a = csrf_of(&get(app, "/andy/demo/issues/new", Some(&andy)).await.body);
216
    assert_eq!(
217
        post(app, "/andy/demo/issues/new", Some(&andy), &format!("_csrf={csrf_a}&title=Typo&body=")).await.location.as_deref(),
218
        Some("/andy/demo/issue/2")
219
    );
220
    let work = tempfile::tempdir().unwrap();
221
    let mut client = Repo::init(work.path()).unwrap();
222
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
223
    client.config.set("remote.origin.token", "site").unwrap();
224
    client.save_config().unwrap();
225
    write(work.path(), "a.txt", b"a\n");
226
    client.snapshot("t").unwrap();
227
    client.commit("Fix the typo\n\nCloses #2", &[]).unwrap();
228
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
229
    tokio::time::sleep(std::time::Duration::from_millis(300)).await;
230
    let issue2 = db::issues::get(&app.db, db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id, 2).await.unwrap().unwrap();
231
    assert_eq!(issue2.state, "closed", "closed by the landed change");
232
    assert!(get(app, "/andy/demo/issue/2", None).await.body.contains("closed by change"));
233
234
    // Numbers are shared: the next proposal is #3, and /issue/3 redirects to it.
235
    client.bookmark_create("feat", None).unwrap();
236
    client.bookmark_switch("feat", false).unwrap();
237
    write(work.path(), "b.txt", b"b\n");
238
    client.snapshot("t").unwrap();
239
    client.commit("feat", &[]).unwrap();
240
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
241
    let csrf_a = csrf_of(&get(app, "/andy/demo/proposals/new?source=feat&target=main", Some(&andy)).await.body);
242
    let r = post(app, "/andy/demo/proposals/new", Some(&andy), &format!("_csrf={csrf_a}&title=Feat&target=main&source=feat")).await;
243
    assert_eq!(r.location.as_deref(), Some("/andy/demo/proposal/3"), "{}", r.body);
244
    assert_eq!(get(app, "/andy/demo/issue/3", None).await.location.as_deref(), Some("/andy/demo/proposal/3"));
245
    // A comment on the issue referencing #3 links to the proposal.
246
    let r = post(app, "/andy/demo/issue/2/comment", Some(&andy), &format!("_csrf={csrf_a}&body=see+%233")).await;
247
    assert!(r.body.contains("href=\"/andy/demo/proposal/3\""), "{}", r.body);
248
    // `#N` in a pushed change's message lands on those timelines (hub spec §8).
249
    client.bookmark_switch("main", false).unwrap();
250
    write(work.path(), "c.txt", b"c\n");
251
    client.snapshot("t").unwrap();
252
    let r = client.commit("Tidy up (refs #1, see #3)", &[]).unwrap();
253
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
254
    tokio::time::sleep(std::time::Duration::from_millis(300)).await;
255
    let short = &r.to_hex()[..12];
256
    let one = get(app, "/andy/demo/issue/1", None).await.body;
257
    assert!(
258
        one.contains("referenced by change") && one.contains(&format!("href=\"/andy/demo/change/{short}\"")) && one.contains(" on main"),
259
        "{one}"
260
    );
261
    let three = get(app, "/andy/demo/proposal/3", Some(&andy)).await.body;
262
    assert!(three.contains("referenced by change") && three.contains(short), "proposals too");
263
    assert!(!get(app, "/andy/demo/issue/2", None).await.body.contains("referenced by change"), "a closing change records only that");
264
265
    // Bob takes part in #1 (mentioned, assigned, commented) and only watches #3.
266
    let part = get(app, "/notifications?reason=participating", Some(&bob)).await.body;
267
    assert!(part.contains("andy/demo#1") && !part.contains("andy/demo#3: Feat"), "{part}");
268
    let watch = get(app, "/notifications?reason=watching", Some(&bob)).await.body;
269
    assert!(watch.contains("andy/demo#3: Feat") && !watch.contains("Crash on start"), "{watch}");
270
    let props = get(app, "/notifications?kind=proposal", Some(&bob)).await.body;
271
    assert!(props.contains("andy/demo#3: Feat") && !props.contains("andy/demo#1"), "kind filter");
272
    assert!(get(app, "/notifications?repo=andy/demo", Some(&bob)).await.body.contains("andy/demo#3: Feat"));
273
    assert!(get(app, "/notifications?repo=nobody/none", Some(&bob)).await.body.contains("Nothing matches these filters"));
274
    // One row per thread, however many events it had.
275
    let inbox = get(app, "/notifications", Some(&bob)).await.body;
276
    assert_eq!(inbox.matches("data-row-thread=\"/andy/demo/issue/1\"").count(), 1, "{inbox}");
277
    assert!(inbox.contains(" updates"), "the count of a busy thread");
278
    // Opening a thread marks it read and goes there.
279
    let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
280
    let newest: i64 = sqlx::query_scalar(
281
        "SELECT id FROM notifications WHERE account_id = ? AND thread = '/andy/demo/proposal/3' ORDER BY id DESC LIMIT 1",
282
    )
283
    .bind(bob_id)
284
    .fetch_one(&app.db)
285
    .await
286
    .unwrap();
287
    let before = db::notify::unread(&app.db, bob_id).await.unwrap();
288
    let r = get(app, &format!("/notifications/open/{newest}"), Some(&bob)).await;
289
    assert_eq!(r.location.as_deref(), Some("/andy/demo/proposal/3"));
290
    assert!(db::notify::unread(&app.db, bob_id).await.unwrap() < before);
291
    assert_eq!(get(app, &format!("/notifications/open/{newest}"), Some(&andy)).await.status, StatusCode::NOT_FOUND, "only your own");
292
    // Done sets a thread aside until something new happens in it.
293
    let csrf_b = csrf_of(&get(app, "/notifications", Some(&bob)).await.body);
294
    let r = post(
295
        app,
296
        "/notifications/thread",
297
        Some(&bob),
298
        &format!("_csrf={csrf_b}&thread=%2Fandy%2Fdemo%2Fissue%2F1&action=done&back=%2Fnotifications"),
299
    )
300
    .await;
301
    assert_eq!(r.location.as_deref(), Some("/notifications"));
302
    assert!(!get(app, "/notifications", Some(&bob)).await.body.contains("Crash on start"));
303
    assert!(get(app, "/notifications?view=done", Some(&bob)).await.body.contains("Crash on start"));
304
    post(app, "/andy/demo/issue/1/comment", Some(&andy), &format!("_csrf={csrf_a}&body=one+more+thing")).await;
305
    assert!(get(app, "/notifications", Some(&bob)).await.body.contains("Crash on start"), "back with the new comment");
306
    let r = post(
307
        app,
308
        "/notifications/thread",
309
        Some(&bob),
310
        &format!("_csrf={csrf_b}&thread=%2Fandy%2Fdemo%2Fissue%2F1&action=read&back=https%3A%2F%2Fevil.example"),
311
    )
312
    .await;
313
    assert_eq!(r.location.as_deref(), Some("/notifications"), "only back to the inbox");
314
315
    // Bob (watcher) heard about the proposal; the inbox marks all read.
316
    assert!(get(app, "/notifications", Some(&bob)).await.body.contains("andy/demo#3: Feat"));
317
    let csrf_b = csrf_of(&get(app, "/notifications", Some(&bob)).await.body);
318
    let r = post(app, "/notifications/read", Some(&bob), &format!("_csrf={csrf_b}")).await;
319
    assert!(r.body.contains("0 unread"), "{}", r.body);
320
    // Email preference and the unsubscribe link.
321
    let r = post(app, "/settings/notifications", Some(&bob), &format!("_csrf={csrf_b}&email=1")).await;
322
    assert!(r.body.contains("Email notifications are on"));
323
    let key: String = sqlx::query_scalar("SELECT unsubscribe_key FROM accounts WHERE username = 'bob'").fetch_one(&app.db).await.unwrap();
324
    assert_eq!(get(app, &format!("/settings/notifications?unsubscribe={key}"), None).await.status, StatusCode::OK);
325
    let on: bool = sqlx::query_scalar("SELECT email_notifications FROM accounts WHERE username = 'bob'").fetch_one(&app.db).await.unwrap();
326
    assert!(!on);
327
}
328
329
#[tokio::test(flavor = "multi_thread")]
330
async fn dashboard_shows_what_needs_the_viewer() {
331
    let h = hub().await;
332
    let app = &h.app;
333
    let andy = register(app, "andy").await;
334
    let bob = register(app, "bob").await;
335
    for (name, vis) in [("demo", hub_api::Visibility::Public), ("secret", hub_api::Visibility::Private)] {
336
        app.repos.create(&RepoName::parse(&format!("andy/{name}")).unwrap(), None).unwrap();
337
        db::repos::create(&app.db, "andy", name, "", vis).await.unwrap();
338
    }
339
    let demo = db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
340
    let secret = db::repos::get(&app.db, "andy", "secret").await.unwrap().unwrap();
341
    let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
342
    for (repo, title) in [(demo.id, "Faster startup"), (secret.id, "Hidden work")] {
343
        let p = db::proposals::create(
344
            &app.db,
345
            db::proposals::NewProposal {
346
                repo_id: repo,
347
                title,
348
                body: "",
349
                author_id: Some(bob_id),
350
                author: "bob",
351
                draft: false,
352
                target: "main",
353
                source_kind: "bookmark",
354
                source_repo_id: Some(repo),
355
                source_bookmark: "fast",
356
                source_changes: "",
357
            },
358
        )
359
        .await
360
        .unwrap();
361
        db::proposals::add_event(&app.db, p.id, "bob", "opened", "").await.unwrap();
362
    }
363
364
    // Signed out, `/` is still the repository list.
365
    let anon = get(app, "/", None).await;
366
    assert!(anon.body.contains("andy /") && !anon.body.contains("Dashboard <small>"), "{}", anon.body);
367
368
    // Andy owns both repositories: both proposals wait for his review.
369
    let page = get(app, "/", Some(&andy)).await;
370
    assert_eq!(page.status, StatusCode::OK);
371
    assert!(page.body.contains("Waiting for your review <small>2</small>"), "{}", page.body);
372
    assert!(page.body.contains("/andy/demo/proposal/1") && page.body.contains("/andy/secret/proposal/1"));
373
    assert!(page.body.contains("Your repositories"));
374
    assert!(page.body.contains("opened proposal"), "activity feed: {}", page.body);
375
376
    // Once he reviews one, it leaves his queue.
377
    let andy_id = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
378
    let p = db::proposals::get(&app.db, demo.id, 1).await.unwrap().unwrap();
379
    db::proposals::add_review(&app.db, p.id, andy_id, "andy", "approve", "").await.unwrap();
380
    assert!(get(app, "/", Some(&andy)).await.body.contains("Waiting for your review <small>1</small>"));
381
382
    // Bob sees his own proposal on the public repository, never the private one's.
383
    let page = get(app, "/", Some(&bob)).await;
384
    assert!(page.body.contains("Your proposals <small>1</small>"), "{}", page.body);
385
    assert!(!page.body.contains("Hidden work"));
386
    assert!(page.body.contains("Waiting for your review <small>0</small>"));
387
    assert!(page.body.contains("Faster startup"));
388
    let feed = &page.body[page.body.find("Recent activity").unwrap()..];
389
    assert!(!feed.contains("andy/secret"), "private activity leaked: {feed}");
390
391
    // Explore still lists every visible repository.
392
    assert!(get(app, "/explore", Some(&bob)).await.body.contains("andy /"));
393
}
394
395
#[tokio::test(flavor = "multi_thread")]
396
async fn empty_repository_shows_a_quickstart() {
397
    let h = hub().await;
398
    let app = &h.app;
399
    let andy = register(app, "andy").await;
400
    let bob = register(app, "bob").await;
401
    app.repos.create(&RepoName::parse("andy/fresh").unwrap(), None).unwrap();
402
    db::repos::create(&app.db, "andy", "fresh", "", hub_api::Visibility::Public).await.unwrap();
403
404
    let page = get(app, "/andy/fresh", Some(&andy)).await;
405
    assert!(page.body.contains("This repository is empty"), "{}", page.body);
406
    let clone_url = format!("{}/andy/fresh", h.base);
407
    assert!(page.body.contains(&format!("oxy remote add hub {clone_url}")), "{}", page.body);
408
    assert!(page.body.contains("oxy config remote.hub.token YOUR-TOKEN"));
409
    assert!(page.body.contains("oxy push hub"));
410
    assert!(
411
        page.body.contains("mkdir fresh &amp;&amp; cd fresh") || page.body.contains("mkdir fresh &#38;&#38; cd fresh"),
412
        "{}",
413
        page.body
414
    );
415
    assert!(page.body.contains("oxy git import --branch main"));
416
    assert!(!page.body.contains("oxyhub-ca.pem"), "no certificate step without a self-signed certificate");
417
418
    // A reader without write access is not told to push.
419
    let page = get(app, "/andy/fresh", Some(&bob)).await;
420
    assert!(page.body.contains("Nothing has been pushed yet") && !page.body.contains("oxy push hub"), "{}", page.body);
421
422
    // After a first push the quickstart gives way to the tree.
423
    let work = tempfile::tempdir().unwrap();
424
    let mut client = Repo::init(work.path()).unwrap();
425
    client.config.set("remote.hub.url", &clone_url).unwrap();
426
    client.config.set("remote.hub.token", "site").unwrap();
427
    client.save_config().unwrap();
428
    write(work.path(), "README.md", b"# fresh\n");
429
    client.commit("First change", &[]).unwrap();
430
    assert!(client.push("hub", false).unwrap().iter().all(|r| r.ok));
431
    let page = get(app, "/andy/fresh", Some(&andy)).await;
432
    assert!(!page.body.contains("This repository is empty") && page.body.contains("README.md"), "{}", page.body);
433
}
434
435
#[tokio::test(flavor = "multi_thread")]
436
async fn theme_is_chosen_in_settings_and_remembered_in_a_cookie() {
437
    let h = hub().await;
438
    let app = &h.app;
439
    let andy = register(app, "andy").await;
440
    let page = get(app, "/settings", Some(&andy)).await;
441
    assert!(page.body.contains("Appearance"));
442
    assert!(page.body.contains(r#"value="light" checked"#), "light by default: {}", page.body);
443
    assert!(page.body.contains("data-theme-toggle"), "the header has the switch");
444
    let csrf = csrf_of(&page.body);
445
    let r = post(app, "/settings/appearance", Some(&andy), &format!("_csrf={csrf}&theme=dark")).await;
446
    assert_eq!(r.status, StatusCode::SEE_OTHER);
447
    assert_eq!(r.cookie.as_deref(), Some("dark"));
448
    assert_eq!(r.location.as_deref(), Some("/settings"));
449
    let page = send_with_theme(app, &andy, "dark").await;
450
    assert!(page.contains(r#"value="dark" checked"#), "the form shows the cookie's theme");
451
    assert_eq!(post(app, "/settings/appearance", Some(&andy), &format!("_csrf={csrf}&theme=purple")).await.status, StatusCode::BAD_REQUEST);
452
    assert_eq!(post(app, "/settings/appearance", Some(&andy), "_csrf=nope&theme=light").await.status, StatusCode::BAD_REQUEST);
453
}
454
455
async fn send_with_theme(app: &Shared, session: &str, theme: &str) -> String {
456
    let req =
457
        Request::builder().uri("/settings").header(header::COOKIE, format!("oxyhub={session}; theme={theme}")).body(Body::empty()).unwrap();
458
    let res = oxygenhub::router(app.clone()).oneshot(req).await.unwrap();
459
    String::from_utf8_lossy(&res.into_body().collect().await.unwrap().to_bytes()).into_owned()
460
}
461
462
#[tokio::test(flavor = "multi_thread")]
463
async fn profile_and_organisation_pages() {
464
    let h = hub().await;
465
    let app = &h.app;
466
    let andy = register(app, "andy").await;
467
    let bob = register(app, "bob").await;
468
    let andy_id = db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
469
    let bob_id = db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
470
    app.repos.create(&RepoName::parse("andy/demo").unwrap(), None).unwrap();
471
    db::repos::create(&app.db, "andy", "demo", "A demo", hub_api::Visibility::Public).await.unwrap();
472
    app.repos.create(&RepoName::parse("andy/hidden").unwrap(), None).unwrap();
473
    db::repos::create(&app.db, "andy", "hidden", "", hub_api::Visibility::Private).await.unwrap();
474
475
    // Andy fills in his profile; a script URL and markup are refused or escaped.
476
    let csrf = csrf_of(&get(app, "/settings", Some(&andy)).await.body);
477
    let r = post(app, "/settings", Some(&andy), &format!("_csrf={csrf}&display_name=Andy+McCall&email=a%40example.com&bio=Builds+%3Cb%3Eoxy%3C%2Fb%3E&website=javascript%3Aalert(1)&location=Earth")).await;
478
    assert!(r.body.contains("must be an http"), "{}", r.body);
479
    let r = post(app, "/settings", Some(&andy), &format!("_csrf={csrf}&display_name=Andy+McCall&email=a%40example.com&bio=Builds+%3Cb%3Eoxy%3C%2Fb%3E&website=https%3A%2F%2Fexample.org&location=Earth")).await;
480
    assert!(r.body.contains("Profile saved"), "{}", r.body);
481
482
    let org = db::accounts::create_org(&app.db, "retro", "Retro Club", andy_id).await.unwrap();
483
    db::accounts::set_org_member(&app.db, org.id, bob_id, "member").await.unwrap();
484
    let team = db::accounts::create_team(&app.db, org.id, "core").await.unwrap();
485
    db::accounts::add_team_member(&app.db, team.id, bob_id).await.unwrap();
486
487
    let page = get(app, "/andy", Some(&bob)).await;
488
    assert_eq!(page.status, StatusCode::OK);
489
    for want in ["Andy McCall", "Earth", r#"href="https://example.org""#, "/avatar/andy", "Signing keys", "/retro", "demo"] {
490
        assert!(page.body.contains(want), "profile lacks {want}: {}", page.body);
491
    }
492
    assert!(!page.body.contains("<b>oxy</b>"), "the bio is escaped");
493
    assert!(!page.body.contains("[email protected]"), "the email stays private");
494
    assert!(!page.body.contains("/andy/hidden"), "bob cannot see the private repository");
495
    assert!(!page.body.contains("edit profile"), "only the owner gets the edit link");
496
    assert!(get(app, "/andy", Some(&andy)).await.body.contains("/andy/hidden"), "andy sees his own private repository");
497
498
    let page = get(app, "/retro", Some(&bob)).await;
499
    assert_eq!(page.status, StatusCode::OK);
500
    for want in ["Retro Club", "organisation", "Members <small>2</small>", "core", "1 member"] {
501
        assert!(page.body.contains(want), "org page lacks {want}: {}", page.body);
502
    }
503
    assert!(!page.body.contains("/orgs/retro/settings"), "bob is not an owner");
504
    assert!(get(app, "/retro", Some(&andy)).await.body.contains("/orgs/retro/settings"));
505
506
    let svg = get(app, "/avatar/andy", None).await;
507
    assert_eq!(svg.status, StatusCode::OK);
508
    assert!(svg.body.starts_with("<svg"));
509
    assert_eq!(svg.body, get(app, "/avatar/ANDY", None).await.body);
510
    assert_eq!(get(app, "/nobody-here", None).await.status, StatusCode::NOT_FOUND);
511
}
512
513
#[tokio::test(flavor = "multi_thread")]
514
async fn diffs_mark_words_hide_whitespace_and_collapse() {
515
    let h = hub().await;
516
    let app = &h.app;
517
    let andy = register(app, "andy").await;
518
    app.repos.create(&RepoName::parse("andy/demo").unwrap(), None).unwrap();
519
    db::repos::create(&app.db, "andy", "demo", "", hub_api::Visibility::Public).await.unwrap();
520
    let work = tempfile::tempdir().unwrap();
521
    let mut client = Repo::init(work.path()).unwrap();
522
    client.config.set("remote.hub.url", &format!("{}/andy/demo", h.base)).unwrap();
523
    client.config.set("remote.hub.token", "site").unwrap();
524
    client.save_config().unwrap();
525
    write(work.path(), "main.rs", b"fn main() {\n  setup();\n  let answer = 42;\n}\n");
526
    client.commit("first", &[]).unwrap();
527
    write(work.path(), "main.rs", b"fn main() {\n    setup();\n  let answer = 43;\n}\n");
528
    let second = client.commit("reindent and change the answer", &[]).unwrap();
529
    assert!(client.push("hub", false).unwrap().iter().all(|r| r.ok));
530
531
    let url = format!("/andy/demo/change/{}", second.to_hex());
532
    let page = get(app, &url, Some(&andy)).await;
533
    assert_eq!(page.status, StatusCode::OK);
534
    assert!(page.body.contains(r#"<details class="file-diff""#), "files collapse: {}", page.body);
535
    assert!(page.body.contains(r#"<span class="wx">43</span>"#), "the changed word is marked: {}", page.body);
536
    assert!(page.body.contains("hide whitespace changes"));
537
    assert!(page.body.contains("data-diff-mode=\"split\""));
538
    let adds = |b: &str| b.matches(r#"<tr class="add">"#).count();
539
    assert_eq!(adds(&page.body), 2, "re-indent and answer both changed");
540
541
    let quiet = get(app, &format!("{url}?w=1"), Some(&andy)).await;
542
    assert_eq!(adds(&quiet.body), 1, "only the answer changed ignoring whitespace: {}", quiet.body);
543
    assert!(quiet.body.contains("show whitespace changes"));
544
545
    assert!(quiet.body.contains("?w=0"), "the toggle leads back");
546
}
547
548
#[tokio::test(flavor = "multi_thread")]
549
async fn fork_and_propose_upstream() {
550
    let h = hub().await;
551
    let app = &h.app;
552
    let andy = register(app, "andy").await;
553
    let bob = register(app, "bob").await;
554
    app.repos.create(&RepoName::parse("andy/demo").unwrap(), None).unwrap();
555
    db::repos::create(&app.db, "andy", "demo", "The demo", hub_api::Visibility::Public).await.unwrap();
556
    let work = tempfile::tempdir().unwrap();
557
    let mut client = Repo::init(work.path()).unwrap();
558
    client.config.set("remote.hub.url", &format!("{}/andy/demo", h.base)).unwrap();
559
    client.config.set("remote.hub.token", "site").unwrap();
560
    client.save_config().unwrap();
561
    write(work.path(), "README.md", b"# demo\n");
562
    client.commit("first", &[]).unwrap();
563
    assert!(client.push("hub", false).unwrap().iter().all(|r| r.ok));
564
565
    // Bob forks it; he cannot fork into Andy's name.
566
    let page = get(app, "/andy/demo", Some(&bob)).await;
567
    assert!(page.body.contains("/andy/demo/fork"), "a fork button: {}", page.body);
568
    let csrf = csrf_of(&get(app, "/andy/demo/fork", Some(&bob)).await.body);
569
    let r = post(app, "/andy/demo/fork", Some(&bob), &format!("_csrf={csrf}&owner=andy&name=other")).await;
570
    assert!(r.body.contains("cannot create repositories under that owner"), "{}", r.body);
571
    let r = post(app, "/andy/demo/fork", Some(&bob), &format!("_csrf={csrf}&owner=bob&name=demo")).await;
572
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
573
    assert_eq!(r.location.as_deref(), Some("/bob/demo"));
574
    let forked = get(app, "/bob/demo", Some(&bob)).await;
575
    assert!(forked.body.contains("README.md") && forked.body.contains("forked from"), "{}", forked.body);
576
    assert!(forked.body.contains("propose to andy/demo"));
577
    assert!(get(app, "/andy/demo", None).await.body.contains("1 fork"));
578
    assert!(get(app, "/andy/demo/forks", None).await.body.contains("/bob/demo"));
579
    let fork_row = db::repos::get(&app.db, "bob", "demo").await.unwrap().unwrap();
580
    let up_row = db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
581
    assert_eq!(fork_row.forked_from, Some(up_row.id));
582
    assert_eq!(fork_row.description, "The demo");
583
    let fork_repo = app.repos.open(&RepoName::parse("bob/demo").unwrap()).unwrap();
584
    let up_repo = app.repos.open(&RepoName::parse("andy/demo").unwrap()).unwrap();
585
    assert_ne!(fork_repo.id().unwrap(), up_repo.id().unwrap(), "a fork is a repository of its own");
586
    assert_eq!(fork_repo.bookmark_heads().unwrap(), up_repo.bookmark_heads().unwrap());
587
    assert_eq!(fork_repo.fsck().unwrap().errors(), 0);
588
589
    // Bob works in a clone of his fork, pushes a bookmark, and proposes it upstream.
590
    let bw = tempfile::tempdir().unwrap();
591
    let mut mine = Repo::clone(&format!("{}/bob/demo", h.base), &bw.path().join("c")).unwrap();
592
    mine.config.set("remote.origin.token", "site").unwrap();
593
    mine.save_config().unwrap();
594
    mine.bookmark_create("feat", None).unwrap();
595
    mine.bookmark_switch("feat", false).unwrap();
596
    write(&bw.path().join("c"), "feature.txt", b"new\n");
597
    mine.commit("Add a feature", &[]).unwrap();
598
    assert!(mine.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
599
    let csrf = csrf_of(&get(app, "/andy/demo/proposals/new?source=bob/demo:feat", Some(&bob)).await.body);
600
    let r =
601
        post(app, "/andy/demo/proposals/new", Some(&bob), &format!("_csrf={csrf}&title=From+my+fork&target=main&source=bob%2Fdemo%3Afeat"))
602
            .await;
603
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
604
    let p = get(app, &r.location.unwrap(), Some(&andy)).await;
605
    assert!(p.body.contains("From my fork") && p.body.contains("fork bob/demo"), "{}", p.body);
606
    let files = get(app, "/andy/demo/proposal/1?tab=files", Some(&andy)).await;
607
    assert!(files.body.contains("feature.txt"), "{}", files.body);
608
}
609
610
#[tokio::test(flavor = "multi_thread")]
611
async fn stars_topics_and_explore() {
612
    let h = hub().await;
613
    let app = &h.app;
614
    let andy = register(app, "andy").await;
615
    let bob = register(app, "bob").await;
616
    for (name, desc) in [("alpha", "An emulator"), ("beta", "A compiler"), ("gamma", "Retro games")] {
617
        app.repos.create(&RepoName::parse(&format!("andy/{name}")).unwrap(), None).unwrap();
618
        db::repos::create(&app.db, "andy", name, desc, hub_api::Visibility::Public).await.unwrap();
619
    }
620
621
    // Topics through settings; bad ones are refused.
622
    let csrf = csrf_of(&get(app, "/andy/gamma/settings", Some(&andy)).await.body);
623
    let r = post(
624
        app,
625
        "/andy/gamma/settings",
626
        Some(&andy),
627
        &format!("_csrf={csrf}&description=Retro+games&default_bookmark=main&visibility=public&topics=c%2B%2B"),
628
    )
629
    .await;
630
    assert!(r.body.contains("is not a topic"), "{}", r.body);
631
    let r = post(
632
        app,
633
        "/andy/gamma/settings",
634
        Some(&andy),
635
        &format!("_csrf={csrf}&description=Retro+games&default_bookmark=main&visibility=public&topics=Retro%2C+6502"),
636
    )
637
    .await;
638
    assert!(r.body.contains("Saved"), "{}", r.body);
639
    assert_eq!(db::repos::get(&app.db, "andy", "gamma").await.unwrap().unwrap().topics, "retro 6502");
640
    let page = get(app, "/andy/gamma", None).await;
641
    assert!(page.body.contains(r#"href="/explore?topic=retro""#), "{}", page.body);
642
643
    // Stars: bob stars beta and gamma, andy stars gamma; toggling unstars.
644
    for (who, repo) in [(&bob, "beta"), (&bob, "gamma"), (&andy, "gamma"), (&andy, "alpha")] {
645
        let csrf = csrf_of(&get(app, &format!("/andy/{repo}"), Some(who)).await.body);
646
        assert_eq!(post(app, &format!("/andy/{repo}/star"), Some(who), &format!("_csrf={csrf}")).await.status, StatusCode::SEE_OTHER);
647
    }
648
    let csrf = csrf_of(&get(app, "/andy/alpha", Some(&andy)).await.body);
649
    post(app, "/andy/alpha/star", Some(&andy), &format!("_csrf={csrf}")).await;
650
    assert!(get(app, "/andy/gamma", Some(&bob)).await.body.contains("★ UNSTAR"));
651
    assert!(get(app, "/andy/gamma", None).await.body.contains("★ 2"));
652
    assert!(get(app, "/andy/alpha", None).await.body.contains("★ 0"), "unstarred again");
653
654
    // Explore: sort by stars, by name, filter by text and by topic.
655
    let order = |b: &str| {
656
        ["alpha", "beta", "gamma"]
657
            .into_iter()
658
            .map(|n| (b.find(&format!("/andy/{n}\"")).unwrap_or(usize::MAX), n))
659
            .collect::<std::collections::BTreeMap<_, _>>()
660
            .into_values()
661
            .collect::<Vec<_>>()
662
    };
663
    assert_eq!(order(&get(app, "/explore?sort=stars", None).await.body)[..2], ["gamma", "beta"]);
664
    assert_eq!(order(&get(app, "/explore?sort=name", None).await.body), ["alpha", "beta", "gamma"]);
665
    let filtered = get(app, "/explore?q=compiler", None).await.body;
666
    assert!(filtered.contains("/andy/beta\"") && !filtered.contains("/andy/alpha\""), "{filtered}");
667
    let by_topic = get(app, "/explore?topic=6502", None).await.body;
668
    assert!(by_topic.contains("/andy/gamma\"") && !by_topic.contains("/andy/beta\""), "{by_topic}");
669
}
670
671
#[tokio::test(flavor = "multi_thread")]
672
async fn lists_filter_sort_page_and_count() {
673
    let h = hub().await;
674
    let app = &h.app;
675
    let andy = register(app, "andy").await;
676
    let _bob = register(app, "bob").await;
677
    app.repos.create(&RepoName::parse("andy/demo").unwrap(), None).unwrap();
678
    let repo = db::repos::create(&app.db, "andy", "demo", "", hub_api::Visibility::Public).await.unwrap();
679
    for n in 0..30 {
680
        let author = if n % 3 == 0 { "bob" } else { "andy" };
681
        db::issues::create(
682
            &app.db,
683
            db::issues::NewIssue { repo_id: repo.id, title: &format!("Issue number {n}"), body: "", author_id: None, author },
684
        )
685
        .await
686
        .unwrap();
687
    }
688
    let ui = db::issues::upsert_label(&app.db, repo.id, "ui", "#00f0ff", "").await.unwrap();
689
    for (title, author, target) in [("Faster menus", "bob", "main"), ("New theme", "andy", "main"), ("Release prep", "andy", "stable")] {
690
        let p = db::proposals::create(
691
            &app.db,
692
            db::proposals::NewProposal {
693
                repo_id: repo.id,
694
                title,
695
                body: "",
696
                author_id: None,
697
                author,
698
                draft: false,
699
                target,
700
                source_kind: "changes",
701
                source_repo_id: None,
702
                source_bookmark: "",
703
                source_changes: "",
704
            },
705
        )
706
        .await
707
        .unwrap();
708
        if title == "New theme" {
709
            db::issues::set_proposal_label(&app.db, p.id, ui.id, true).await.unwrap();
710
        }
711
    }
712
713
    // The tabs count what is open.
714
    let page = get(app, "/andy/demo/issues", Some(&andy)).await;
715
    assert!(page.body.contains(r#"Issues <span class="count-chip">30</span>"#), "{}", page.body);
716
    assert!(page.body.contains(r#"Proposals <span class="count-chip">3</span>"#));
717
718
    // Pages of 25, newest first; the second page holds the rest.
719
    let rows = |b: &str| b.matches("/andy/demo/issue/").count();
720
    assert_eq!(rows(&page.body), 25);
721
    assert!(page.body.contains("page 1 of 2") && page.body.contains("page=2"), "a pager");
722
    let second = get(app, "/andy/demo/issues?page=2", Some(&andy)).await;
723
    assert_eq!(rows(&second.body), 5);
724
    assert!(second.body.contains("Issue number 0<"), "the oldest are last");
725
    let oldest = get(app, "/andy/demo/issues?sort=oldest", Some(&andy)).await;
726
    assert!(oldest.body.find("Issue number 0<").unwrap() < oldest.body.find("Issue number 1<").unwrap());
727
    let bobs = get(app, "/andy/demo/issues?q=author:bob", Some(&andy)).await;
728
    assert_eq!(rows(&bobs.body), 10, "{}", bobs.body);
729
730
    // Proposals: by author, label and target.
731
    let by_bob = get(app, "/andy/demo/proposals?q=author:bob", Some(&andy)).await.body;
732
    assert!(by_bob.contains("Faster menus") && !by_bob.contains("New theme"));
733
    let ui_only = get(app, "/andy/demo/proposals?q=label:ui", Some(&andy)).await.body;
734
    assert!(ui_only.contains("New theme") && !ui_only.contains("Faster menus") && ui_only.contains(r#"class="label""#));
735
    let stable = get(app, "/andy/demo/proposals?q=target:stable", Some(&andy)).await.body;
736
    assert!(stable.contains("Release prep") && !stable.contains("New theme"));
737
}
738
739
#[tokio::test(flavor = "multi_thread")]
740
async fn project_boards() {
741
    let h = hub().await;
742
    let app = &h.app;
743
    let andy = register(app, "andy").await;
744
    let bob = register(app, "bob").await;
745
    for (name, vis) in [("demo", hub_api::Visibility::Public), ("secret", hub_api::Visibility::Private)] {
746
        app.repos.create(&RepoName::parse(&format!("andy/{name}")).unwrap(), None).unwrap();
747
        let row = db::repos::create(&app.db, "andy", name, "", vis).await.unwrap();
748
        db::issues::create(
749
            &app.db,
750
            db::issues::NewIssue { repo_id: row.id, title: &format!("{name} issue"), body: "", author_id: None, author: "andy" },
751
        )
752
        .await
753
        .unwrap();
754
    }
755
    let csrf = csrf_of(&get(app, "/projects/andy", Some(&andy)).await.body);
756
    let r = post(app, "/projects/andy", Some(&andy), &format!("_csrf={csrf}&title=Roadmap&description=Next+steps")).await;
757
    assert_eq!(r.location.as_deref(), Some("/projects/andy/1"), "{}", r.body);
758
    let board = get(app, "/projects/andy/1", Some(&andy)).await.body;
759
    for col in ["Backlog", "Doing", "Done"] {
760
        assert!(board.contains(&format!(">{col} <span")), "{col}");
761
    }
762
    let cols: Vec<i64> = sqlx::query_scalar("SELECT id FROM project_columns ORDER BY position").fetch_all(&app.db).await.unwrap();
763
    let act = |form: String| {
764
        let andy = andy.clone();
765
        async move { post(app, "/projects/andy/1", Some(&andy), &form).await }
766
    };
767
    // Cards: by reference, by repository and number, a note; duplicates and strangers refused.
768
    assert_eq!(
769
        act(format!("_csrf={csrf}&action=add&column={}&reference=demo%231", cols[0])).await.location.as_deref(),
770
        Some("/projects/andy/1")
771
    );
772
    act(format!("_csrf={csrf}&action=add&column={}&repo=secret&reference=%231", cols[0])).await;
773
    act(format!("_csrf={csrf}&action=add&column={}&note=Write+the+docs", cols[1])).await;
774
    assert!(act(format!("_csrf={csrf}&action=add&column={}&reference=demo%231", cols[1])).await.body.contains("already on this project"));
775
    assert!(act(format!("_csrf={csrf}&action=add&column={}&reference=demo%2399", cols[0])).await.body.contains("no issue or proposal #99"));
776
    assert!(act(format!("_csrf={csrf}&action=add&column={}&reference=nothere%231", cols[0])).await.body.contains("no repository nothere"));
777
    // Move demo#1 to Done.
778
    let demo_card: i64 =
779
        sqlx::query_scalar("SELECT c.id FROM project_cards c JOIN repositories r ON r.id = c.repo_id WHERE r.name = 'demo'")
780
            .fetch_one(&app.db)
781
            .await
782
            .unwrap();
783
    act(format!("_csrf={csrf}&action=move&card={demo_card}&column={}", cols[2])).await;
784
    let issue = get(app, "/andy/demo/issue/1", None).await.body;
785
    assert!(issue.contains("href=\"/projects/andy/1\">Roadmap</a> <span class=\"mute\">· Done"), "the issue shows where it is");
786
787
    // Readers see public cards, never those of repositories they cannot read.
788
    let anon = get(app, "/projects/andy/1", None).await.body;
789
    assert!(anon.contains("demo issue") && anon.contains("Write the docs") && !anon.contains("secret issue"), "{anon}");
790
    assert!(!anon.contains("name=\"action\""), "and cannot change anything");
791
    assert!(get(app, "/projects/andy/1", Some(&andy)).await.body.contains("secret issue"));
792
    // Only the owner changes it; a private project is invisible to others.
793
    let csrf_b = csrf_of(&get(app, "/settings", Some(&bob)).await.body);
794
    assert_eq!(
795
        post(app, "/projects/andy/1", Some(&bob), &format!("_csrf={csrf_b}&action=remove&card={demo_card}")).await.status,
796
        StatusCode::NOT_FOUND
797
    );
798
    act(format!("_csrf={csrf}&action=settings&title=Roadmap&description=&private=1")).await;
799
    assert_eq!(get(app, "/projects/andy/1", Some(&bob)).await.status, StatusCode::NOT_FOUND);
800
    assert!(!get(app, "/projects/andy", None).await.body.contains("Roadmap"), "not even listed");
801
    assert!(!get(app, "/andy/demo/issue/1", None).await.body.contains("Roadmap"), "nor on the issue");
802
803
    // Columns: removing one moves its cards to the first column; the last one stays.
804
    act(format!("_csrf={csrf}&action=remove_column&column={}", cols[1])).await;
805
    let note_col: i64 = sqlx::query_scalar("SELECT column_id FROM project_cards WHERE kind = 'note'").fetch_one(&app.db).await.unwrap();
806
    assert_eq!(note_col, cols[0]);
807
    act(format!("_csrf={csrf}&action=remove_column&column={}", cols[2])).await;
808
    assert!(act(format!("_csrf={csrf}&action=remove_column&column={}", cols[0])).await.body.contains("at least one column"));
809
    // Closed projects are read-only until reopened; then deleted, the issues remain.
810
    act(format!("_csrf={csrf}&action=settings&title=Roadmap&closed=1")).await;
811
    assert!(act(format!("_csrf={csrf}&action=add&column={}&note=late", cols[0])).await.body.contains("This project is closed"));
812
    let r = act(format!("_csrf={csrf}&action=delete")).await;
813
    assert_eq!(r.location.as_deref(), Some("/projects/andy"));
814
    assert_eq!(get(app, "/projects/andy/1", Some(&andy)).await.status, StatusCode::NOT_FOUND);
815
    assert_eq!(get(app, "/andy/demo/issue/1", None).await.status, StatusCode::OK);
816
    assert_eq!(get(app, "/projects/nobody", None).await.status, StatusCode::NOT_FOUND);
817
}
818
819
#[tokio::test(flavor = "multi_thread")]
820
async fn issue_markdown_follows_the_default_bookmark() {
821
    let h = hub().await;
822
    let app = &h.app;
823
    register(app, "andy").await;
824
    app.repos.create(&RepoName::parse("andy/trunky").unwrap(), None).unwrap();
825
    let row = db::repos::create(&app.db, "andy", "trunky", "", hub_api::Visibility::Public).await.unwrap();
826
    sqlx::query("UPDATE repositories SET default_bookmark = 'trunk' WHERE id = ?").bind(row.id).execute(&app.db).await.unwrap();
827
    db::issues::create(
828
        &app.db,
829
        db::issues::NewIssue {
830
            repo_id: row.id,
831
            title: "Docs",
832
            body: "See [the guide](docs/guide.md) and ![shot](img/a.png).",
833
            author_id: None,
834
            author: "andy",
835
        },
836
    )
837
    .await
838
    .unwrap();
839
    let page = get(app, "/andy/trunky/issue/1", None).await.body;
840
    assert!(page.contains("href=\"/andy/trunky/file/trunk/docs/guide.md\""), "{page}");
841
    assert!(page.contains("src=\"/andy/trunky/raw/trunk/img/a.png\""));
842
    assert!(!page.contains("/file/main/"));
843
}