OXYGENHUB
# 71e65fcf95ab oxygenhub / crates / hub / tests / api.rs
77.0 KiB · Rust · last changed Assistants through the API and oh 1 month ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    let app = oxygenhub::build(config).await.unwrap();
51
    let router = oxygenhub::router(app.clone());
52
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
53
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
54
}
55
56
struct Res {
57
    status: StatusCode,
58
    body: String,
59
    cookie: Option<String>,
60
}
61
62
async fn call(
63
    app: &Shared,
64
    method: &str,
65
    path: &str,
66
    bearer: Option<&str>,
67
    cookie: Option<&str>,
68
    json: Option<&str>,
69
    form: Option<&str>,
70
) -> Res {
71
    let mut req = Request::builder().method(method).uri(path);
72
    if let Some(b) = bearer {
73
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
74
    }
75
    if let Some(c) = cookie {
76
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
77
    }
78
    let body = if let Some(j) = json {
79
        req = req.header(header::CONTENT_TYPE, "application/json");
80
        Body::from(j.to_string())
81
    } else if let Some(f) = form {
82
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
83
        Body::from(f.to_string())
84
    } else {
85
        Body::empty()
86
    };
87
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
88
    let status = res.status();
89
    let cookie = res
90
        .headers()
91
        .get(header::SET_COOKIE)
92
        .and_then(|v| v.to_str().ok())
93
        .and_then(|v| v.split(';').next())
94
        .and_then(|kv| kv.split_once('='))
95
        .map(|(_, v)| v.to_string());
96
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
97
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
98
}
99
100
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
101
    let r = call(app, method, path, bearer, None, json, None).await;
102
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
103
    (r.status, v)
104
}
105
106
fn csrf_of(page: &str) -> String {
107
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
108
    page[i..].split('"').next().unwrap().to_string()
109
}
110
111
/// A webhook receiver that records what it gets and fails the first time.
112
struct Receiver {
113
    url: String,
114
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
115
    fail_first: Arc<Mutex<bool>>,
116
}
117
118
async fn receiver() -> Receiver {
119
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
120
    let fail_first = Arc::new(Mutex::new(true));
121
    let (s2, f2) = (seen.clone(), fail_first.clone());
122
    let router = Router::new().route(
123
        "/hook",
124
        post(move |headers: header::HeaderMap, body: String| {
125
            let (s2, f2) = (s2.clone(), f2.clone());
126
            async move {
127
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
128
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
129
                let mut f = f2.lock().unwrap();
130
                if *f {
131
                    *f = false;
132
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
133
                }
134
                s2.lock().unwrap().push((event, sig, body));
135
                (StatusCode::OK, "ok")
136
            }
137
        }),
138
    );
139
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
140
    let port = listener.local_addr().unwrap().port();
141
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
142
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
143
}
144
145
#[tokio::test(flavor = "multi_thread")]
146
async fn api_webhooks_and_checks() {
147
    let h = hub().await;
148
    let app = &h.app;
149
    // Accounts and tokens through the pages.
150
    let r =
151
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
152
    let andy = r.cookie.unwrap();
153
    let r =
154
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
155
    let bob = r.cookie.unwrap();
156
    let mint = |cookie: String, scopes: &'static str| {
157
        let app = app.clone();
158
        async move {
159
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
160
            let csrf = csrf_of(&page.body);
161
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
162
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
163
        }
164
    };
165
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
166
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
167
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
168
169
    // Create a repository through the API; the read-only token cannot.
170
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
171
    assert_eq!(st, StatusCode::FORBIDDEN);
172
    let (st, v) = api(
173
        app,
174
        "POST",
175
        "/api/v1/repos",
176
        Some(&andy_admin),
177
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
178
    )
179
    .await;
180
    assert_eq!(st, StatusCode::CREATED, "{v}");
181
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
182
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
183
    assert_eq!(st, StatusCode::CONFLICT);
184
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
185
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
186
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
187
    assert_eq!(st, StatusCode::OK);
188
    assert_eq!(v["username"], "andy");
189
190
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
191
    let rx = receiver().await;
192
    let (st, v) = api(
193
        app,
194
        "POST",
195
        "/api/v1/repos/andy/demo/hooks",
196
        Some(&andy_admin),
197
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
198
    )
199
    .await;
200
    assert_eq!(st, StatusCode::CREATED, "{v}");
201
    let work = tempfile::tempdir().unwrap();
202
    let mut client = Repo::init(work.path()).unwrap();
203
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
204
    client.config.set("remote.origin.token", "site").unwrap();
205
    client.save_config().unwrap();
206
    write(work.path(), "a.txt", b"a\n");
207
    client.snapshot("t").unwrap();
208
    let base = client.commit("base", &[]).unwrap();
209
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
210
    // The worker retries with backoff; drive it directly for the retry.
211
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
212
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
213
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
214
    oxygenhub::hooks::deliver_due(app).await;
215
    let seen = rx.seen.lock().unwrap().clone();
216
    assert_eq!(seen.len(), 1, "{seen:?}");
217
    assert_eq!(seen[0].0, "push");
218
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
219
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
220
    assert_eq!(payload["repository"]["name"], "demo");
221
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
222
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
223
    assert_eq!(v.as_array().unwrap().len(), 1);
224
225
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
226
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
227
    assert_eq!(st, StatusCode::OK);
228
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
229
    // A revset in place of the whole history (`?r=`), under a budget; a
230
    // bad one is the caller's problem.
231
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
232
    assert_eq!(st, StatusCode::OK, "{v}");
233
    assert_eq!(v["total"].as_u64(), Some(1));
234
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
235
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
236
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
237
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
238
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
239
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
240
    assert_eq!(v[0]["name"], "a.txt");
241
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
242
    assert_eq!(r.body, "a\n");
243
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
244
    assert_eq!(v[0]["change"], base.to_hex());
245
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
246
    assert_eq!(v["files"][0]["path"], "a.txt");
247
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
248
    assert!(v["policy"].is_null());
249
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
250
    assert_eq!(v[0]["reference"], "main");
251
252
    // Issues through the API: Bob opens one, comments, and closes it.
253
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
254
    assert_eq!(st, StatusCode::CREATED, "{v}");
255
    assert_eq!(v["number"], 1);
256
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
257
    assert_eq!(st, StatusCode::CREATED);
258
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
259
    assert_eq!(st, StatusCode::OK, "{v}");
260
    assert_eq!(v["state"], "closed");
261
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
262
    assert_eq!(v[0]["comments"], 1);
263
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
264
    assert_eq!(v[0]["number"], 1);
265
266
    // A proposal through the API, then a required check gates its landing.
267
    client.bookmark_create("feat", Some(&[base])).unwrap();
268
    client.bookmark_switch("feat", false).unwrap();
269
    write(work.path(), "b.txt", b"b\n");
270
    write(work.path(), "a.txt", b"a\nA\n");
271
    client.snapshot("t").unwrap();
272
    let feat = client.commit("feat", &[]).unwrap();
273
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
274
    let (st, v) =
275
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
276
            .await;
277
    assert_eq!(st, StatusCode::CREATED, "{v}");
278
    assert_eq!(v["number"], 2);
279
    let state = v["projected_state"].as_str().unwrap().to_string();
280
    assert_eq!(v["landable"], true);
281
    // Its files, and each side's bytes, for editors' diff views.
282
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
283
    assert_eq!(st, StatusCode::OK, "{v}");
284
    let files: Vec<(String, String)> =
285
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
286
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
287
    assert_eq!(v[0]["added"], 1);
288
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
289
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
290
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
291
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
292
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
293
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
294
    // Require the "build" check.
295
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
296
    let csrf = csrf_of(&settings.body);
297
    assert_eq!(
298
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
299
            .await
300
            .status,
301
        StatusCode::OK
302
    );
303
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
304
    assert_eq!(v["landable"], false);
305
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
306
    // A checker reports on the projected state: first running, then passed; the page streams it.
307
    let (st, v) = api(
308
        app,
309
        "POST",
310
        "/api/v1/repos/andy/demo/checks",
311
        Some(&andy_ro),
312
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
313
    )
314
    .await;
315
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
316
    let mut events = app.events.proposals.subscribe();
317
    let (st, v) = api(
318
        app,
319
        "POST",
320
        "/api/v1/repos/andy/demo/checks",
321
        Some(&bob_rw),
322
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
323
    )
324
    .await;
325
    assert_eq!(st, StatusCode::CREATED, "{v}");
326
    let (_, ev) = events.recv().await.unwrap();
327
    assert_eq!(ev.kind, "check");
328
    assert_eq!(ev.check.unwrap().name, "build");
329
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
330
    assert_eq!(v[0]["status"], "passed");
331
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
332
    assert_eq!(v["landable"], true, "{v}");
333
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
334
    assert!(page.body.contains("42 tests"), "{}", page.body);
335
    // The check and the proposal reached the webhook too.
336
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
337
    oxygenhub::hooks::deliver_due(app).await;
338
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
339
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
340
    let _ = feat;
341
    let _ = rx.fail_first;
342
343
    // The inbox through the API: count, list, mark one read, mark all read.
344
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
345
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
346
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
347
    oxygenhub::db::notify::add(
348
        &app.db,
349
        oxygenhub::db::notify::New {
350
            account_id: bob_id,
351
            repo_id: None,
352
            reason: oxygenhub::db::notify::Reason::Participating,
353
            kind: "mention",
354
            title: "andy/demo#1: Bug",
355
            url: "/andy/demo/issue/1",
356
            actor: "andy",
357
        },
358
    )
359
    .await
360
    .unwrap();
361
    oxygenhub::db::notify::add(
362
        &app.db,
363
        oxygenhub::db::notify::New {
364
            account_id: bob_id,
365
            repo_id: None,
366
            reason: oxygenhub::db::notify::Reason::Participating,
367
            kind: "review",
368
            title: "andy/demo#2: Feat",
369
            url: "/andy/demo/proposal/2",
370
            actor: "andy",
371
        },
372
    )
373
    .await
374
    .unwrap();
375
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
376
    assert_eq!(st, StatusCode::OK, "{v}");
377
    assert_eq!(v["unread"], 2);
378
    assert_eq!(v["items"][0]["read"], false);
379
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
380
    let first = v["items"][0]["id"].as_i64().unwrap();
381
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
382
    assert_eq!(st, StatusCode::NO_CONTENT);
383
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
384
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
385
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
386
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
387
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
388
389
    // Review requests: the author asks andy; andy is told, reviews, and the
390
    // request is answered; the author hears of the review.
391
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
392
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
393
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
394
        .await
395
        .unwrap();
396
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
397
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
398
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
399
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
400
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
401
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
402
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
403
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
404
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
405
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
406
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
407
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
408
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
409
    let (st, _) =
410
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
411
    assert_eq!(st, StatusCode::CREATED);
412
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
413
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
414
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
415
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
416
    // Asking again and withdrawing it.
417
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
418
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
419
    assert_eq!(st, StatusCode::NO_CONTENT);
420
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
421
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
422
    // oxygenhub#84: the page's menu sets who is asked, all at once.
423
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
424
    assert!(
425
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
426
        "the reviewers menu lists andy"
427
    );
428
    let csrf = csrf_of(&page.body);
429
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
430
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
431
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
432
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
433
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
434
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
435
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
436
437
    // A source bookmark with `/` in its name, as a feature/N-name workflow
438
    // makes them: by name, and as this repository's owner/name:bookmark.
439
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
440
        client.bookmark_create(b, Some(&[base])).unwrap();
441
        client.bookmark_switch(b, false).unwrap();
442
        write(work.path(), file, b"c\n");
443
        client.snapshot("t").unwrap();
444
        client.commit(b, &[]).unwrap();
445
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
446
    }
447
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
448
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
449
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
450
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
451
        let n = v["number"].as_i64().unwrap();
452
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
453
        assert_eq!(page.status, StatusCode::OK);
454
        assert!(page.body.contains("feature/"), "the page names its source");
455
    }
456
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
457
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
458
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
459
460
    // oxygenhub#76: a proposal's title and description are edited through
461
    // the API by its author or a maintainer; what is not given stays.
462
    let edit = |token: &str, number: i64, body: &str| {
463
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
464
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
465
    };
466
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
467
    assert_eq!(st, StatusCode::OK, "{v}");
468
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
469
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
470
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
471
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
472
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
473
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
474
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
475
    let (st, v) = api(
476
        app,
477
        "POST",
478
        "/api/v1/repos/andy/demo/proposals",
479
        Some(&andy_pw),
480
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
481
    )
482
    .await;
483
    assert_eq!(st, StatusCode::CREATED, "{v}");
484
    let n = v["number"].as_i64().unwrap();
485
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
486
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
487
488
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
489
    // before anything changes, shown in its JSON.
490
    for l in ["ui", "flow"] {
491
        let body = format!(r#"{{"name":"{l}"}}"#);
492
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
493
    }
494
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
495
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
496
    assert_eq!(st, StatusCode::OK, "{v}");
497
    let names = |v: &serde_json::Value| -> Vec<String> {
498
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
499
    };
500
    assert_eq!(names(&v), ["flow", "ui"]);
501
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
502
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
503
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
504
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
505
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
506
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
507
    assert_eq!(names(&v), ["flow"]);
508
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
509
}
510
511
#[tokio::test(flavor = "multi_thread")]
512
async fn api_issue_triage_and_labels() {
513
    let h = hub().await;
514
    let app = &h.app;
515
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
516
        .await
517
        .cookie
518
        .unwrap();
519
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
520
        .await
521
        .cookie
522
        .unwrap();
523
    let mint = |cookie: String, scopes: &'static str| {
524
        let app = app.clone();
525
        async move {
526
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
527
            let csrf = csrf_of(&page.body);
528
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
529
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
530
        }
531
    };
532
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
533
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
534
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
535
    assert_eq!(st, StatusCode::CREATED);
536
537
    // Labels through the API; bad colours and non-triage callers are refused.
538
    let (st, v) = api(
539
        app,
540
        "POST",
541
        "/api/v1/repos/andy/demo/labels",
542
        Some(&andy_t),
543
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
544
    )
545
    .await;
546
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
547
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
548
    assert_eq!(
549
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
550
        StatusCode::BAD_REQUEST
551
    );
552
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
553
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
554
    assert_eq!(labels.as_array().unwrap().len(), 2);
555
    // oxygenhub#91: milestones over the API, for triage.
556
    let (st, m) = api(
557
        app,
558
        "POST",
559
        "/api/v1/repos/andy/demo/milestones",
560
        Some(&andy_t),
561
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
562
    )
563
    .await;
564
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
565
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
566
    assert_eq!(
567
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
568
        StatusCode::BAD_REQUEST
569
    );
570
    assert_eq!(
571
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
572
        StatusCode::FORBIDDEN
573
    );
574
    let (st, m) =
575
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
576
            .await;
577
    assert_eq!(
578
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
579
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
580
        "{m}"
581
    );
582
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
583
    assert_eq!(
584
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
585
        StatusCode::NOT_FOUND,
586
        "renamed"
587
    );
588
    assert_eq!(
589
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
590
        StatusCode::BAD_REQUEST
591
    );
592
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
593
    assert_eq!(list.as_array().unwrap().len(), 1);
594
595
    // An issue created with its labels and assignee in one call.
596
    let (st, v) = api(
597
        app,
598
        "POST",
599
        "/api/v1/repos/andy/demo/issues",
600
        Some(&andy_t),
601
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
602
    )
603
    .await;
604
    assert_eq!(st, StatusCode::CREATED, "{v}");
605
    assert_eq!(v["labels"][0]["name"], "bug");
606
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
607
    let n = v["number"].as_i64().unwrap();
608
    // Unknown names are refused before anything is created.
609
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
610
    assert_eq!(st, StatusCode::BAD_REQUEST);
611
    assert!(v["detail"].as_str().unwrap().contains("no label"));
612
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
613
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
614
    // Without triage, labels cannot be set, but a plain issue can be opened.
615
    assert_eq!(
616
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
617
        StatusCode::FORBIDDEN
618
    );
619
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
620
    assert_eq!(st, StatusCode::CREATED);
621
    let bob_n = bobs["number"].as_i64().unwrap();
622
623
    // PATCH: the whole label set, assignees and milestone, with events.
624
    let (st, v) =
625
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
626
            .await;
627
    assert_eq!(st, StatusCode::OK, "{v}");
628
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
629
    assert_eq!(v["assignees"], serde_json::json!([]));
630
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
631
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
632
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
633
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
634
    // The author edits their own title; others cannot; nobody but triage sets labels.
635
    let (st, v) =
636
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
637
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
638
    assert_eq!(
639
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
640
        StatusCode::FORBIDDEN
641
    );
642
    assert_eq!(
643
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
644
        StatusCode::FORBIDDEN
645
    );
646
    assert_eq!(
647
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
648
        StatusCode::BAD_REQUEST
649
    );
650
651
    // Deleting a label takes it off the issues.
652
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
653
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
654
    assert_eq!(v["labels"], serde_json::json!([]));
655
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
656
}
657
658
#[tokio::test(flavor = "multi_thread")]
659
async fn webhook_formats_editing_and_web_issue_events() {
660
    let h = hub().await;
661
    let app = &h.app;
662
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
663
        .await
664
        .cookie
665
        .unwrap();
666
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
667
    let r = call(
668
        app,
669
        "POST",
670
        "/settings/tokens",
671
        None,
672
        Some(&andy),
673
        None,
674
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
675
    )
676
    .await;
677
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
678
    assert_eq!(
679
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
680
        StatusCode::CREATED
681
    );
682
    let rx = receiver().await;
683
    *rx.fail_first.lock().unwrap() = false;
684
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
685
    let csrf = csrf_of(&settings);
686
    let form = |f: String| {
687
        let andy = andy.clone();
688
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
689
    };
690
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
691
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
692
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
693
    assert_eq!(hook.format, "discord");
694
    // Ping arrives as a Discord message.
695
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
696
    let mut got = String::new();
697
    for _ in 0..100 {
698
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
699
            got = body.clone();
700
        }
701
        if !got.is_empty() {
702
            break;
703
        }
704
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
705
    }
706
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
707
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
708
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
709
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
710
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
711
712
    // Editing: a blank URL and secret keep theirs; format, events and active change.
713
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
714
        .await
715
        .contains("Webhook saved"));
716
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
717
    assert_eq!(
718
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
719
        (rx.url.as_str(), "issue", "oxygenhub", true)
720
    );
721
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
722
723
    // An issue opened on the web now reaches the hook, as the signed envelope.
724
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
725
    call(
726
        app,
727
        "POST",
728
        "/andy/demo/issues/new",
729
        None,
730
        Some(&andy),
731
        None,
732
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
733
    )
734
    .await;
735
    let mut envelope = None;
736
    for _ in 0..100 {
737
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
738
        if envelope.is_some() {
739
            break;
740
        }
741
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
742
    }
743
    let (_, sig, body) = envelope.expect("issue.opened delivered");
744
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
745
    assert_eq!(v["data"]["issue"]["title"], "From the web");
746
    assert!(sig.starts_with("blake3-keyed="));
747
    // A disabled hook through the edit form (no active box).
748
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
749
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
750
}
751
752
#[tokio::test(flavor = "multi_thread")]
753
async fn api_projects() {
754
    let h = hub().await;
755
    let app = &h.app;
756
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
757
        .await
758
        .cookie
759
        .unwrap();
760
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
761
        .await
762
        .cookie
763
        .unwrap();
764
    let mint = |cookie: String, scopes: &'static str| {
765
        let app = app.clone();
766
        async move {
767
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
768
            let csrf = csrf_of(&page.body);
769
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
770
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
771
        }
772
    };
773
    let a = mint(andy, "scopes=repo%3Aadmin").await;
774
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
775
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
776
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
777
778
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
779
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
780
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
781
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
782
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
783
784
    // Cards by reference, into a column by name, and a note into the first column.
785
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
786
    assert_eq!(st, StatusCode::CREATED, "{card}");
787
    assert_eq!(
788
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
789
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
790
    );
791
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
792
    assert_eq!(st, StatusCode::BAD_REQUEST);
793
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
794
    assert_eq!(
795
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
796
        StatusCode::BAD_REQUEST
797
    );
798
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
799
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
800
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
801
802
    // Move and read the board.
803
    let id = card["id"].as_i64().unwrap();
804
    assert_eq!(
805
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
806
        StatusCode::NO_CONTENT
807
    );
808
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
809
    let names: Vec<(&str, usize)> =
810
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
811
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
812
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
813
814
    // Private: hidden from others; closed: read-only; then remove a card.
815
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
816
    assert_eq!(edited["public"], false);
817
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
818
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
819
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
820
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
821
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
822
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
823
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
824
}
825
826
#[tokio::test(flavor = "multi_thread")]
827
async fn api_required_checks() {
828
    let h = hub().await;
829
    let app = &h.app;
830
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
831
        .await
832
        .cookie
833
        .unwrap();
834
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
835
    let csrf = csrf_of(&page.body);
836
    let mint = |scopes: &'static str| {
837
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
838
        async move {
839
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
840
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
841
        }
842
    };
843
    let admin = mint("scopes=repo%3Aadmin").await;
844
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
845
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
846
847
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
848
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
849
    let (st, v) = api(
850
        app,
851
        "PUT",
852
        "/api/v1/repos/andy/demo/checks/required",
853
        Some(&admin),
854
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
855
    )
856
    .await;
857
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
858
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
859
    assert_eq!(
860
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
861
        serde_json::json!(["flow/fmt", "flow/test"])
862
    );
863
    assert_eq!(
864
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
865
        StatusCode::FORBIDDEN,
866
        "repo:admin only"
867
    );
868
    assert_eq!(
869
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
870
        StatusCode::BAD_REQUEST
871
    );
872
    // The settings page shows the same list.
873
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
874
}
875
876
/// OxygenFlow per repository: site administrators turn it on or off in
877
/// the repository's settings; hub.toml's `[flow] repos` is the default.
878
#[tokio::test(flavor = "multi_thread")]
879
async fn flow_is_switched_per_repository_by_site_admins() {
880
    let h = hub().await;
881
    let app = &h.app;
882
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
883
        .await
884
        .cookie
885
        .unwrap();
886
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
887
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
888
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
889
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
890
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
891
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
892
893
    let set = |value: &'static str| {
894
        let (app, andy) = (app.clone(), andy.clone());
895
        async move {
896
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
897
            call(
898
                &app,
899
                "POST",
900
                "/andy/demo/settings/flow",
901
                None,
902
                Some(&andy),
903
                None,
904
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
905
            )
906
            .await
907
        }
908
    };
909
    // A repository admin who is not a site admin sees the state but cannot change it.
910
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
911
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
912
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
913
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
914
    let r = set("on").await;
915
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
916
    assert_eq!(row().await.flow, "");
917
918
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
919
    let r = set("on").await;
920
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
921
    assert_eq!(row().await.flow, "on");
922
    assert!(oxygenhub::flow::enabled(app, &row().await));
923
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
924
    set("off").await;
925
    assert!(!oxygenhub::flow::enabled(app, &row().await));
926
    set("default").await;
927
    assert_eq!(row().await.flow, "");
928
    assert!(set("sometimes").await.body.contains("Pick on, off"));
929
}
930
931
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
932
/// button, never the repository's default bookmark as the hub sets it.
933
#[tokio::test(flavor = "multi_thread")]
934
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
935
    let h = hub().await;
936
    let app = &h.app;
937
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
938
        .await
939
        .cookie
940
        .unwrap();
941
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
942
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
943
    let url = format!("{}/andy/demo", h.base);
944
    let work = tempfile::tempdir().unwrap();
945
    let (w, u) = (work.path().to_path_buf(), url.clone());
946
    let client = tokio::task::spawn_blocking(move || {
947
        let mut c = Repo::init(&w).unwrap();
948
        c.config.set("remote.origin.url", &u).unwrap();
949
        c.config.set("remote.origin.token", "site").unwrap();
950
        c.save_config().unwrap();
951
        write(&w, "a.txt", b"a\n");
952
        c.commit("a", &[]).unwrap();
953
        assert!(c.push("origin", false).unwrap()[0].ok);
954
        for b in ["develop", "feature/x", "stray"] {
955
            c.bookmark_create(b, None).unwrap();
956
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
957
        }
958
        // A pushed deletion.
959
        let r = c.push_delete("origin", "feature/x").unwrap();
960
        assert!(r[0].ok, "{r:?}");
961
        c
962
    })
963
    .await
964
    .unwrap();
965
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
966
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
967
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
968
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
969
    assert!(!anon.body.contains("/bookmarks/delete"));
970
971
    // The hub's default, not the repository's config, is protected: make
972
    // develop the default, then main can go and develop cannot.
973
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
974
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
975
    let client = tokio::task::spawn_blocking(move || {
976
        let r = client.push_delete("origin", "develop").unwrap();
977
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
978
        let r = client.push_delete("origin", "main").unwrap();
979
        assert!(r[0].ok, "{r:?}");
980
        client
981
    })
982
    .await
983
    .unwrap();
984
    drop(client);
985
986
    // On the web: a writer deletes stray; the default is refused.
987
    let form = |b: &'static str| {
988
        let (app, andy) = (app.clone(), andy.clone());
989
        async move {
990
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
991
            call(
992
                &app,
993
                "POST",
994
                "/andy/demo/bookmarks/delete",
995
                None,
996
                Some(&andy),
997
                None,
998
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
999
            )
1000
            .await
1001
        }
1002
    };
1003
    let r = form("stray").await;
1004
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1005
    assert!(!r.body.contains(">stray<"));
1006
    let r = form("develop").await;
1007
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1008
    let r = form("nope").await;
1009
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1010
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1011
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1012
    // Anonymous visitors cannot.
1013
    assert_ne!(
1014
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1015
        StatusCode::OK
1016
    );
1017
}
1018
1019
/// A change signed by a key no account has linked says so, on its page
1020
/// and in the API (feedback 14).
1021
#[tokio::test(flavor = "multi_thread")]
1022
async fn changes_signed_by_unlinked_keys_say_so() {
1023
    let h = hub().await;
1024
    let app = &h.app;
1025
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1026
        .await
1027
        .cookie
1028
        .unwrap();
1029
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1030
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1031
    let url = format!("{}/andy/demo", h.base);
1032
    let work = tempfile::tempdir().unwrap();
1033
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1034
    let hash = tokio::task::spawn_blocking(move || {
1035
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1036
        c.config.set("remote.origin.url", &u).unwrap();
1037
        c.config.set("remote.origin.token", "site").unwrap();
1038
        c.save_config().unwrap();
1039
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1040
        write(&w.join("r"), "a.txt", b"a\n");
1041
        let h = c.commit("signed by Ada", &[]).unwrap();
1042
        assert!(c.push("origin", false).unwrap()[0].ok);
1043
        h.to_hex()
1044
    })
1045
    .await
1046
    .unwrap();
1047
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1048
    assert_eq!(st, StatusCode::OK, "{v}");
1049
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1050
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1051
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1052
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1053
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1054
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1055
}
1056
1057
/// Function history (hub spec §6.6): the file page lists a file's
1058
/// functions, and a function's page lists exactly the changes to its lines.
1059
#[tokio::test(flavor = "multi_thread")]
1060
async fn a_function_has_its_own_history() {
1061
    let h = hub().await;
1062
    let app = &h.app;
1063
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1064
        .await
1065
        .cookie
1066
        .unwrap();
1067
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1068
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1069
    let url = format!("{}/andy/demo", h.base);
1070
    let work = tempfile::tempdir().unwrap();
1071
    let w = work.path().to_path_buf();
1072
    tokio::task::spawn_blocking(move || {
1073
        let mut c = Repo::init(&w).unwrap();
1074
        c.config.set("remote.origin.url", &url).unwrap();
1075
        c.config.set("remote.origin.token", "site").unwrap();
1076
        c.save_config().unwrap();
1077
        let steps = [
1078
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1079
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1080
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1081
        ];
1082
        for (msg, text) in steps {
1083
            write(&w, "src/lib.rs", text.as_bytes());
1084
            c.commit(msg, &[]).unwrap();
1085
        }
1086
        assert!(c.push("origin", false).unwrap()[0].ok);
1087
    })
1088
    .await
1089
    .unwrap();
1090
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1091
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1092
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1093
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1094
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1095
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1096
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1097
    assert_ne!(bad.status, StatusCode::OK);
1098
}
1099
1100
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1101
/// dependency edges, linked cards.
1102
#[tokio::test(flavor = "multi_thread")]
1103
async fn a_bookmark_shows_as_swimlanes() {
1104
    let h = hub().await;
1105
    let app = &h.app;
1106
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1107
        .await
1108
        .cookie
1109
        .unwrap();
1110
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1111
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1112
    let url = format!("{}/andy/demo", h.base);
1113
    let work = tempfile::tempdir().unwrap();
1114
    let w = work.path().to_path_buf();
1115
    tokio::task::spawn_blocking(move || {
1116
        let mut c = Repo::init(&w).unwrap();
1117
        c.config.set("remote.origin.url", &url).unwrap();
1118
        c.config.set("remote.origin.token", "site").unwrap();
1119
        c.save_config().unwrap();
1120
        // Two files edited independently: two lanes.
1121
        write(&w, "a.txt", b"a\n");
1122
        c.commit("add a", &[]).unwrap();
1123
        write(&w, "b.txt", b"b\n");
1124
        c.commit("add b", &[]).unwrap();
1125
        write(&w, "a.txt", b"a\na2\n");
1126
        c.commit("grow a", &[]).unwrap();
1127
        assert!(c.push("origin", false).unwrap()[0].ok);
1128
    })
1129
    .await
1130
    .unwrap();
1131
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1132
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1133
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1134
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1135
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1136
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1137
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1138
    assert_eq!(board.matches("<rect ").count(), 3);
1139
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1140
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1141
}
1142
1143
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1144
/// offers only what makes sense and rewrites nothing itself.
1145
#[tokio::test(flavor = "multi_thread")]
1146
async fn a_proposal_board_plans_squashes_and_rebases() {
1147
    let h = hub().await;
1148
    let app = &h.app;
1149
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1150
        .await
1151
        .cookie
1152
        .unwrap();
1153
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1154
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1155
    let url = format!("{}/andy/demo", h.base);
1156
    let work = tempfile::tempdir().unwrap();
1157
    let w = work.path().to_path_buf();
1158
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1159
        let mut c = Repo::init(&w).unwrap();
1160
        c.config.set("remote.origin.url", &url).unwrap();
1161
        c.config.set("remote.origin.token", "site").unwrap();
1162
        c.save_config().unwrap();
1163
        write(&w, "a.txt", b"a\n");
1164
        let base = c.commit("base", &[]).unwrap();
1165
        assert!(c.push("origin", false).unwrap()[0].ok);
1166
        c.bookmark_create("feature", None).unwrap();
1167
        c.bookmark_switch("feature", false).unwrap();
1168
        write(&w, "a.txt", b"a\nfirst\n");
1169
        let first = c.commit("first", &[]).unwrap();
1170
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1171
        let second = c.commit("second", &[]).unwrap();
1172
        write(&w, "b.txt", b"apart\n");
1173
        let apart = c.commit("apart", &[]).unwrap();
1174
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1175
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1176
    })
1177
    .await
1178
    .unwrap();
1179
    // No proposal yet: the board is read-only.
1180
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1181
    assert!(!board.contains("data-plan="));
1182
    let (st, _) = api(
1183
        app,
1184
        "POST",
1185
        "/api/v1/repos/andy/demo/proposals",
1186
        Some("site"),
1187
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1188
    )
1189
    .await;
1190
    assert!(st.is_success(), "{st}");
1191
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1192
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1193
    let csrf = csrf_of(&board);
1194
    let plan = |c: &str, t: &str| {
1195
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1196
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1197
        async move {
1198
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1199
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1200
        }
1201
    };
1202
    let kinds = |v: &serde_json::Value| {
1203
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1204
    };
1205
    // second already depends on first: squash, no rebase.
1206
    let v = plan(&second, &first).await;
1207
    assert_eq!(kinds(&v), ["squash"], "{v}");
1208
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1209
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygen.oxygen-vscode/plan?"));
1210
    // apart is independent of second: either.
1211
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1212
    // first under second: nothing (second depends on first).
1213
    assert!(plan(&first, &second).await["error"].is_string());
1214
    // What has landed on main is not rearranged.
1215
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1216
}
1217
1218
/// Issues and proposals share a number space, so every number says what it
1219
/// is, and the chain of work shows from both ends (hub spec §8).
1220
#[tokio::test(flavor = "multi_thread")]
1221
async fn proposals_and_issues_show_their_chain() {
1222
    let h = hub().await;
1223
    let app = &h.app;
1224
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1225
        .await
1226
        .cookie
1227
        .unwrap();
1228
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1229
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1230
    let url = format!("{}/andy/demo", h.base);
1231
    let work = tempfile::tempdir().unwrap();
1232
    let w = work.path().to_path_buf();
1233
    tokio::task::spawn_blocking(move || {
1234
        let mut c = Repo::init(&w).unwrap();
1235
        c.config.set("remote.origin.url", &url).unwrap();
1236
        c.config.set("remote.origin.token", "site").unwrap();
1237
        c.save_config().unwrap();
1238
        write(&w, "a.txt", b"a\n");
1239
        c.commit("base", &[]).unwrap();
1240
        assert!(c.push("origin", false).unwrap()[0].ok);
1241
        c.bookmark_create("feature", None).unwrap();
1242
        c.bookmark_switch("feature", false).unwrap();
1243
        write(&w, "a.txt", b"a\nfixed\n");
1244
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1245
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1246
    })
1247
    .await
1248
    .unwrap();
1249
    for title in ["Slow start", "Crash on save"] {
1250
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1251
        assert!(st.is_success());
1252
    }
1253
    let (st, v) = api(
1254
        app,
1255
        "POST",
1256
        "/api/v1/repos/andy/demo/proposals",
1257
        Some("site"),
1258
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1259
    )
1260
    .await;
1261
    assert!(st.is_success(), "{st} {v}");
1262
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1263
1264
    // The proposal names its kind, links its references by kind, and shows
1265
    // the chain: the issues it closes (description and changes) → it → main.
1266
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1267
    assert!(p.contains(">proposal #3</small>"), "header");
1268
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1269
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1270
    let chain = &chain[..chain.find("</p>").unwrap()];
1271
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1272
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1273
    }
1274
    assert!(p.contains("<h3>Closes</h3>"));
1275
1276
    // The issue shows the proposal that closes it, and names its own kind.
1277
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1278
    assert!(i.contains(">issue #1</small>"));
1279
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1280
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1281
    // The conversation is a timeline with avatars; editing sits with the
1282
    // content, not in the sidebar, and labels and projects are editable.
1283
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1284
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1285
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1286
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1287
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1288
    assert!(st.is_success(), "{st}");
1289
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1290
    assert!(
1291
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1292
        "the owner's projects to add to, in a menu"
1293
    );
1294
    let csrf = csrf_of(&p);
1295
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1296
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1297
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1298
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1299
        .await;
1300
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1301
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1302
1303
    // Closed by the proposal's change, not its description: still shown.
1304
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1305
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1306
    assert!(chain.contains("proposal #3"), "{chain}");
1307
}
1308
1309
/// What the hub is: its version and build, and the libraries it is built on,
1310
/// on /about, in the API and in /health (hub spec §15).
1311
#[tokio::test(flavor = "multi_thread")]
1312
async fn the_hub_says_what_version_it_is() {
1313
    let h = hub().await;
1314
    let app = &h.app;
1315
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1316
    assert_eq!(st, StatusCode::OK);
1317
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1318
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1319
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1320
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1321
    assert!(health.contains("\"build\""), "{health}");
1322
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1323
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1324
    assert!(about.contains("href=\"/about\""), "the footer links here");
1325
}
1326
1327
#[tokio::test(flavor = "multi_thread")]
1328
async fn device_sign_in() {
1329
    let h = hub().await;
1330
    let app = &h.app;
1331
    let r =
1332
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1333
    let andy = r.cookie.unwrap();
1334
1335
    // An unknown scope is refused.
1336
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1337
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1338
1339
    // The app asks for a code and polls; nobody has approved it yet.
1340
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1341
    assert_eq!(st, StatusCode::OK, "{v}");
1342
    let device = v["device_code"].as_str().unwrap().to_string();
1343
    let user = v["user_code"].as_str().unwrap().to_string();
1344
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1345
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1346
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1347
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1348
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1349
    assert_eq!(v["error"], "slow_down", "polled too soon");
1350
1351
    // The user approves it on the web, allowing less than it asked for.
1352
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1353
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1354
    let csrf = csrf_of(&page.body);
1355
    let r =
1356
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1357
            .await;
1358
    // oxygenhub#83: the answer page says it is done, with no code form.
1359
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1360
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1361
1362
    // The next poll gets a token with what was allowed, once.
1363
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1364
    assert_eq!(st, StatusCode::OK, "{v}");
1365
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1366
    let token = v["access_token"].as_str().unwrap().to_string();
1367
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1368
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1369
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1370
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1371
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1372
    assert!(tokens.body.contains("device: Phone app"));
1373
    // oxygenhub#70: a device's token expires, and each use renews it.
1374
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1375
1376
    // The token can revoke itself (oxy auth logout), and is then refused.
1377
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1378
    assert_eq!(st, StatusCode::NO_CONTENT);
1379
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1380
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1381
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1382
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1383
1384
    // A denied code says so.
1385
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1386
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1387
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1388
    let csrf = csrf_of(&page.body);
1389
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1390
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1391
    assert_eq!(v["error"], "access_denied");
1392
1393
    // Signed out, the page asks for a sign-in first.
1394
    let r = call(app, "GET", "/device", None, None, None, None).await;
1395
    assert!(r.status.is_redirection(), "{}", r.status);
1396
}
1397
1398
#[tokio::test(flavor = "multi_thread")]
1399
async fn api_assistants_at_each_level() {
1400
    let h = hub().await;
1401
    let app = &h.app;
1402
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1403
        .await
1404
        .cookie
1405
        .unwrap();
1406
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1407
    let csrf = csrf_of(&page.body);
1408
    let mint = |scopes: &'static str| {
1409
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1410
        async move {
1411
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1412
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1413
        }
1414
    };
1415
    let admin = mint("scopes=repo%3Aadmin").await;
1416
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1417
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1418
    // A stand-in endpoint with no model list: any model name is taken.
1419
    let router = axum::Router::new().route(
1420
        "/v1/chat/completions",
1421
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1422
    );
1423
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1424
    let port = listener.local_addr().unwrap().port();
1425
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1426
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1427
1428
    // The site's, by its administrator; the repository's, by its admin.
1429
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1430
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1431
    assert_eq!(st, StatusCode::OK, "{v}");
1432
    assert_eq!(v["ok"], "Gemini added");
1433
    let body =
1434
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1435
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1436
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1437
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1438
    assert_eq!(st, StatusCode::OK, "{v}");
1439
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1440
    assert_eq!(st, StatusCode::OK);
1441
    let names: Vec<(&str, &str, bool)> = v
1442
        .as_array()
1443
        .unwrap()
1444
        .iter()
1445
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1446
        .collect();
1447
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1448
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1449
    // Changing it keeps the token when none is given.
1450
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1451
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1452
    assert_eq!(v["ok"], "Claude updated");
1453
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1454
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1455
    // Prompts: the site's is inherited by the repository.
1456
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1457
    assert_eq!(st, StatusCode::OK);
1458
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1459
    assert_eq!(v["prompt"], "Rust.");
1460
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1461
    // Removed.
1462
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1463
    assert_eq!(st, StatusCode::NO_CONTENT);
1464
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1465
    assert_eq!(st, StatusCode::NOT_FOUND);
1466
}