OXYGENHUB
# 739a763a558c oxygenhub / crates / hub / tests / api.rs
65.0 KiB · Rust · last changed Edit a proposal through the API; oh proposal edit, comment and create -F 1 month ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    let app = oxygenhub::build(config).await.unwrap();
51
    let router = oxygenhub::router(app.clone());
52
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
53
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
54
}
55
56
struct Res {
57
    status: StatusCode,
58
    body: String,
59
    cookie: Option<String>,
60
}
61
62
async fn call(
63
    app: &Shared,
64
    method: &str,
65
    path: &str,
66
    bearer: Option<&str>,
67
    cookie: Option<&str>,
68
    json: Option<&str>,
69
    form: Option<&str>,
70
) -> Res {
71
    let mut req = Request::builder().method(method).uri(path);
72
    if let Some(b) = bearer {
73
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
74
    }
75
    if let Some(c) = cookie {
76
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
77
    }
78
    let body = if let Some(j) = json {
79
        req = req.header(header::CONTENT_TYPE, "application/json");
80
        Body::from(j.to_string())
81
    } else if let Some(f) = form {
82
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
83
        Body::from(f.to_string())
84
    } else {
85
        Body::empty()
86
    };
87
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
88
    let status = res.status();
89
    let cookie = res
90
        .headers()
91
        .get(header::SET_COOKIE)
92
        .and_then(|v| v.to_str().ok())
93
        .and_then(|v| v.split(';').next())
94
        .and_then(|kv| kv.split_once('='))
95
        .map(|(_, v)| v.to_string());
96
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
97
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
98
}
99
100
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
101
    let r = call(app, method, path, bearer, None, json, None).await;
102
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
103
    (r.status, v)
104
}
105
106
fn csrf_of(page: &str) -> String {
107
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
108
    page[i..].split('"').next().unwrap().to_string()
109
}
110
111
/// A webhook receiver that records what it gets and fails the first time.
112
struct Receiver {
113
    url: String,
114
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
115
    fail_first: Arc<Mutex<bool>>,
116
}
117
118
async fn receiver() -> Receiver {
119
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
120
    let fail_first = Arc::new(Mutex::new(true));
121
    let (s2, f2) = (seen.clone(), fail_first.clone());
122
    let router = Router::new().route(
123
        "/hook",
124
        post(move |headers: header::HeaderMap, body: String| {
125
            let (s2, f2) = (s2.clone(), f2.clone());
126
            async move {
127
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
128
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
129
                let mut f = f2.lock().unwrap();
130
                if *f {
131
                    *f = false;
132
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
133
                }
134
                s2.lock().unwrap().push((event, sig, body));
135
                (StatusCode::OK, "ok")
136
            }
137
        }),
138
    );
139
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
140
    let port = listener.local_addr().unwrap().port();
141
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
142
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
143
}
144
145
#[tokio::test(flavor = "multi_thread")]
146
async fn api_webhooks_and_checks() {
147
    let h = hub().await;
148
    let app = &h.app;
149
    // Accounts and tokens through the pages.
150
    let r =
151
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
152
    let andy = r.cookie.unwrap();
153
    let r =
154
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
155
    let bob = r.cookie.unwrap();
156
    let mint = |cookie: String, scopes: &'static str| {
157
        let app = app.clone();
158
        async move {
159
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
160
            let csrf = csrf_of(&page.body);
161
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
162
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
163
        }
164
    };
165
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
166
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
167
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
168
169
    // Create a repository through the API; the read-only token cannot.
170
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
171
    assert_eq!(st, StatusCode::FORBIDDEN);
172
    let (st, v) = api(
173
        app,
174
        "POST",
175
        "/api/v1/repos",
176
        Some(&andy_admin),
177
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
178
    )
179
    .await;
180
    assert_eq!(st, StatusCode::CREATED, "{v}");
181
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
182
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
183
    assert_eq!(st, StatusCode::CONFLICT);
184
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
185
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
186
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
187
    assert_eq!(st, StatusCode::OK);
188
    assert_eq!(v["username"], "andy");
189
190
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
191
    let rx = receiver().await;
192
    let (st, v) = api(
193
        app,
194
        "POST",
195
        "/api/v1/repos/andy/demo/hooks",
196
        Some(&andy_admin),
197
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
198
    )
199
    .await;
200
    assert_eq!(st, StatusCode::CREATED, "{v}");
201
    let work = tempfile::tempdir().unwrap();
202
    let mut client = Repo::init(work.path()).unwrap();
203
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
204
    client.config.set("remote.origin.token", "site").unwrap();
205
    client.save_config().unwrap();
206
    write(work.path(), "a.txt", b"a\n");
207
    client.snapshot("t").unwrap();
208
    let base = client.commit("base", &[]).unwrap();
209
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
210
    // The worker retries with backoff; drive it directly for the retry.
211
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
212
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
213
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
214
    oxygenhub::hooks::deliver_due(app).await;
215
    let seen = rx.seen.lock().unwrap().clone();
216
    assert_eq!(seen.len(), 1, "{seen:?}");
217
    assert_eq!(seen[0].0, "push");
218
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
219
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
220
    assert_eq!(payload["repository"]["name"], "demo");
221
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
222
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
223
    assert_eq!(v.as_array().unwrap().len(), 1);
224
225
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
226
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
227
    assert_eq!(st, StatusCode::OK);
228
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
229
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
230
    assert_eq!(v[0]["name"], "a.txt");
231
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
232
    assert_eq!(r.body, "a\n");
233
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
234
    assert_eq!(v[0]["change"], base.to_hex());
235
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
236
    assert_eq!(v["files"][0]["path"], "a.txt");
237
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
238
    assert!(v["policy"].is_null());
239
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
240
    assert_eq!(v[0]["reference"], "main");
241
242
    // Issues through the API: Bob opens one, comments, and closes it.
243
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
244
    assert_eq!(st, StatusCode::CREATED, "{v}");
245
    assert_eq!(v["number"], 1);
246
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
247
    assert_eq!(st, StatusCode::CREATED);
248
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
249
    assert_eq!(st, StatusCode::OK, "{v}");
250
    assert_eq!(v["state"], "closed");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
252
    assert_eq!(v[0]["comments"], 1);
253
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
254
    assert_eq!(v[0]["number"], 1);
255
256
    // A proposal through the API, then a required check gates its landing.
257
    client.bookmark_create("feat", Some(&[base])).unwrap();
258
    client.bookmark_switch("feat", false).unwrap();
259
    write(work.path(), "b.txt", b"b\n");
260
    write(work.path(), "a.txt", b"a\nA\n");
261
    client.snapshot("t").unwrap();
262
    let feat = client.commit("feat", &[]).unwrap();
263
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
264
    let (st, v) =
265
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
266
            .await;
267
    assert_eq!(st, StatusCode::CREATED, "{v}");
268
    assert_eq!(v["number"], 2);
269
    let state = v["projected_state"].as_str().unwrap().to_string();
270
    assert_eq!(v["landable"], true);
271
    // Its files, and each side's bytes, for editors' diff views.
272
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
273
    assert_eq!(st, StatusCode::OK, "{v}");
274
    let files: Vec<(String, String)> =
275
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
276
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
277
    assert_eq!(v[0]["added"], 1);
278
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
279
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
280
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
281
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
282
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
283
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
284
    // Require the "build" check.
285
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
286
    let csrf = csrf_of(&settings.body);
287
    assert_eq!(
288
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
289
            .await
290
            .status,
291
        StatusCode::OK
292
    );
293
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
294
    assert_eq!(v["landable"], false);
295
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
296
    // A checker reports on the projected state: first running, then passed; the page streams it.
297
    let (st, v) = api(
298
        app,
299
        "POST",
300
        "/api/v1/repos/andy/demo/checks",
301
        Some(&andy_ro),
302
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
303
    )
304
    .await;
305
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
306
    let mut events = app.events.proposals.subscribe();
307
    let (st, v) = api(
308
        app,
309
        "POST",
310
        "/api/v1/repos/andy/demo/checks",
311
        Some(&bob_rw),
312
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
313
    )
314
    .await;
315
    assert_eq!(st, StatusCode::CREATED, "{v}");
316
    let (_, ev) = events.recv().await.unwrap();
317
    assert_eq!(ev.kind, "check");
318
    assert_eq!(ev.check.unwrap().name, "build");
319
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
320
    assert_eq!(v[0]["status"], "passed");
321
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
322
    assert_eq!(v["landable"], true, "{v}");
323
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
324
    assert!(page.body.contains("42 tests"), "{}", page.body);
325
    // The check and the proposal reached the webhook too.
326
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
327
    oxygenhub::hooks::deliver_due(app).await;
328
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
329
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
330
    let _ = feat;
331
    let _ = rx.fail_first;
332
333
    // The inbox through the API: count, list, mark one read, mark all read.
334
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
335
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
336
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
337
    oxygenhub::db::notify::add(
338
        &app.db,
339
        oxygenhub::db::notify::New {
340
            account_id: bob_id,
341
            repo_id: None,
342
            reason: oxygenhub::db::notify::Reason::Participating,
343
            kind: "mention",
344
            title: "andy/demo#1: Bug",
345
            url: "/andy/demo/issue/1",
346
            actor: "andy",
347
        },
348
    )
349
    .await
350
    .unwrap();
351
    oxygenhub::db::notify::add(
352
        &app.db,
353
        oxygenhub::db::notify::New {
354
            account_id: bob_id,
355
            repo_id: None,
356
            reason: oxygenhub::db::notify::Reason::Participating,
357
            kind: "review",
358
            title: "andy/demo#2: Feat",
359
            url: "/andy/demo/proposal/2",
360
            actor: "andy",
361
        },
362
    )
363
    .await
364
    .unwrap();
365
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
366
    assert_eq!(st, StatusCode::OK, "{v}");
367
    assert_eq!(v["unread"], 2);
368
    assert_eq!(v["items"][0]["read"], false);
369
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
370
    let first = v["items"][0]["id"].as_i64().unwrap();
371
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
372
    assert_eq!(st, StatusCode::NO_CONTENT);
373
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
374
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
375
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
376
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
377
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
378
379
    // A source bookmark with `/` in its name, as a feature/N-name workflow
380
    // makes them: by name, and as this repository's owner/name:bookmark.
381
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
382
        client.bookmark_create(b, Some(&[base])).unwrap();
383
        client.bookmark_switch(b, false).unwrap();
384
        write(work.path(), file, b"c\n");
385
        client.snapshot("t").unwrap();
386
        client.commit(b, &[]).unwrap();
387
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
388
    }
389
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
390
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
391
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
392
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
393
        let n = v["number"].as_i64().unwrap();
394
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
395
        assert_eq!(page.status, StatusCode::OK);
396
        assert!(page.body.contains("feature/"), "the page names its source");
397
    }
398
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
399
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
400
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
401
402
    // oxygenhub#76: a proposal's title and description are edited through
403
    // the API by its author or a maintainer; what is not given stays.
404
    let edit = |token: &str, number: i64, body: &str| {
405
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
406
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
407
    };
408
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
409
    assert_eq!(st, StatusCode::OK, "{v}");
410
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
411
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
412
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
413
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
414
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
415
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
416
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
417
    let (st, v) = api(
418
        app,
419
        "POST",
420
        "/api/v1/repos/andy/demo/proposals",
421
        Some(&andy_pw),
422
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
423
    )
424
    .await;
425
    assert_eq!(st, StatusCode::CREATED, "{v}");
426
    let n = v["number"].as_i64().unwrap();
427
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
428
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
429
}
430
431
#[tokio::test(flavor = "multi_thread")]
432
async fn api_issue_triage_and_labels() {
433
    let h = hub().await;
434
    let app = &h.app;
435
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
436
        .await
437
        .cookie
438
        .unwrap();
439
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
440
        .await
441
        .cookie
442
        .unwrap();
443
    let mint = |cookie: String, scopes: &'static str| {
444
        let app = app.clone();
445
        async move {
446
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
447
            let csrf = csrf_of(&page.body);
448
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
449
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
450
        }
451
    };
452
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
453
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
454
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
455
    assert_eq!(st, StatusCode::CREATED);
456
457
    // Labels through the API; bad colours and non-triage callers are refused.
458
    let (st, v) = api(
459
        app,
460
        "POST",
461
        "/api/v1/repos/andy/demo/labels",
462
        Some(&andy_t),
463
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
464
    )
465
    .await;
466
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
467
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
468
    assert_eq!(
469
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
470
        StatusCode::BAD_REQUEST
471
    );
472
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
473
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
474
    assert_eq!(labels.as_array().unwrap().len(), 2);
475
476
    // An issue created with its labels and assignee in one call.
477
    let (st, v) = api(
478
        app,
479
        "POST",
480
        "/api/v1/repos/andy/demo/issues",
481
        Some(&andy_t),
482
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
483
    )
484
    .await;
485
    assert_eq!(st, StatusCode::CREATED, "{v}");
486
    assert_eq!(v["labels"][0]["name"], "bug");
487
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
488
    let n = v["number"].as_i64().unwrap();
489
    // Unknown names are refused before anything is created.
490
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
491
    assert_eq!(st, StatusCode::BAD_REQUEST);
492
    assert!(v["detail"].as_str().unwrap().contains("no label"));
493
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
494
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
495
    // Without triage, labels cannot be set, but a plain issue can be opened.
496
    assert_eq!(
497
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
498
        StatusCode::FORBIDDEN
499
    );
500
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
501
    assert_eq!(st, StatusCode::CREATED);
502
    let bob_n = bobs["number"].as_i64().unwrap();
503
504
    // PATCH: the whole label set, assignees and milestone, with events.
505
    let (st, v) =
506
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
507
            .await;
508
    assert_eq!(st, StatusCode::OK, "{v}");
509
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
510
    assert_eq!(v["assignees"], serde_json::json!([]));
511
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
512
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
513
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
514
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
515
    // The author edits their own title; others cannot; nobody but triage sets labels.
516
    let (st, v) =
517
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
518
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
519
    assert_eq!(
520
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
521
        StatusCode::FORBIDDEN
522
    );
523
    assert_eq!(
524
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
525
        StatusCode::FORBIDDEN
526
    );
527
    assert_eq!(
528
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
529
        StatusCode::BAD_REQUEST
530
    );
531
532
    // Deleting a label takes it off the issues.
533
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
534
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
535
    assert_eq!(v["labels"], serde_json::json!([]));
536
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
537
}
538
539
#[tokio::test(flavor = "multi_thread")]
540
async fn webhook_formats_editing_and_web_issue_events() {
541
    let h = hub().await;
542
    let app = &h.app;
543
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
544
        .await
545
        .cookie
546
        .unwrap();
547
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
548
    let r = call(
549
        app,
550
        "POST",
551
        "/settings/tokens",
552
        None,
553
        Some(&andy),
554
        None,
555
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
556
    )
557
    .await;
558
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
559
    assert_eq!(
560
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
561
        StatusCode::CREATED
562
    );
563
    let rx = receiver().await;
564
    *rx.fail_first.lock().unwrap() = false;
565
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
566
    let csrf = csrf_of(&settings);
567
    let form = |f: String| {
568
        let andy = andy.clone();
569
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
570
    };
571
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
572
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
573
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
574
    assert_eq!(hook.format, "discord");
575
    // Ping arrives as a Discord message.
576
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
577
    let mut got = String::new();
578
    for _ in 0..100 {
579
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
580
            got = body.clone();
581
        }
582
        if !got.is_empty() {
583
            break;
584
        }
585
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
586
    }
587
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
588
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
589
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
590
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
591
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
592
593
    // Editing: a blank URL and secret keep theirs; format, events and active change.
594
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
595
        .await
596
        .contains("Webhook saved"));
597
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
598
    assert_eq!(
599
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
600
        (rx.url.as_str(), "issue", "oxygenhub", true)
601
    );
602
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
603
604
    // An issue opened on the web now reaches the hook, as the signed envelope.
605
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
606
    call(
607
        app,
608
        "POST",
609
        "/andy/demo/issues/new",
610
        None,
611
        Some(&andy),
612
        None,
613
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
614
    )
615
    .await;
616
    let mut envelope = None;
617
    for _ in 0..100 {
618
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
619
        if envelope.is_some() {
620
            break;
621
        }
622
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
623
    }
624
    let (_, sig, body) = envelope.expect("issue.opened delivered");
625
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
626
    assert_eq!(v["data"]["issue"]["title"], "From the web");
627
    assert!(sig.starts_with("blake3-keyed="));
628
    // A disabled hook through the edit form (no active box).
629
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
630
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
631
}
632
633
#[tokio::test(flavor = "multi_thread")]
634
async fn api_projects() {
635
    let h = hub().await;
636
    let app = &h.app;
637
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
638
        .await
639
        .cookie
640
        .unwrap();
641
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
642
        .await
643
        .cookie
644
        .unwrap();
645
    let mint = |cookie: String, scopes: &'static str| {
646
        let app = app.clone();
647
        async move {
648
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
649
            let csrf = csrf_of(&page.body);
650
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
651
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
652
        }
653
    };
654
    let a = mint(andy, "scopes=repo%3Aadmin").await;
655
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
656
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
657
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
658
659
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
660
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
661
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
662
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
663
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
664
665
    // Cards by reference, into a column by name, and a note into the first column.
666
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
667
    assert_eq!(st, StatusCode::CREATED, "{card}");
668
    assert_eq!(
669
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
670
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
671
    );
672
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
673
    assert_eq!(st, StatusCode::BAD_REQUEST);
674
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
675
    assert_eq!(
676
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
677
        StatusCode::BAD_REQUEST
678
    );
679
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
680
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
681
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
682
683
    // Move and read the board.
684
    let id = card["id"].as_i64().unwrap();
685
    assert_eq!(
686
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
687
        StatusCode::NO_CONTENT
688
    );
689
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
690
    let names: Vec<(&str, usize)> =
691
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
692
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
693
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
694
695
    // Private: hidden from others; closed: read-only; then remove a card.
696
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
697
    assert_eq!(edited["public"], false);
698
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
699
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
700
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
701
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
702
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
703
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
704
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
705
}
706
707
#[tokio::test(flavor = "multi_thread")]
708
async fn api_required_checks() {
709
    let h = hub().await;
710
    let app = &h.app;
711
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
712
        .await
713
        .cookie
714
        .unwrap();
715
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
716
    let csrf = csrf_of(&page.body);
717
    let mint = |scopes: &'static str| {
718
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
719
        async move {
720
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
721
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
722
        }
723
    };
724
    let admin = mint("scopes=repo%3Aadmin").await;
725
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
726
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
727
728
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
729
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
730
    let (st, v) = api(
731
        app,
732
        "PUT",
733
        "/api/v1/repos/andy/demo/checks/required",
734
        Some(&admin),
735
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
736
    )
737
    .await;
738
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
739
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
740
    assert_eq!(
741
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
742
        serde_json::json!(["flow/fmt", "flow/test"])
743
    );
744
    assert_eq!(
745
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
746
        StatusCode::FORBIDDEN,
747
        "repo:admin only"
748
    );
749
    assert_eq!(
750
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
751
        StatusCode::BAD_REQUEST
752
    );
753
    // The settings page shows the same list.
754
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
755
}
756
757
/// OxygenFlow per repository: site administrators turn it on or off in
758
/// the repository's settings; hub.toml's `[flow] repos` is the default.
759
#[tokio::test(flavor = "multi_thread")]
760
async fn flow_is_switched_per_repository_by_site_admins() {
761
    let h = hub().await;
762
    let app = &h.app;
763
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
764
        .await
765
        .cookie
766
        .unwrap();
767
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
768
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
769
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
770
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
771
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
772
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
773
774
    let set = |value: &'static str| {
775
        let (app, andy) = (app.clone(), andy.clone());
776
        async move {
777
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
778
            call(
779
                &app,
780
                "POST",
781
                "/andy/demo/settings/flow",
782
                None,
783
                Some(&andy),
784
                None,
785
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
786
            )
787
            .await
788
        }
789
    };
790
    // A repository admin who is not a site admin sees the state but cannot change it.
791
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
792
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
793
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
794
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
795
    let r = set("on").await;
796
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
797
    assert_eq!(row().await.flow, "");
798
799
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
800
    let r = set("on").await;
801
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
802
    assert_eq!(row().await.flow, "on");
803
    assert!(oxygenhub::flow::enabled(app, &row().await));
804
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
805
    set("off").await;
806
    assert!(!oxygenhub::flow::enabled(app, &row().await));
807
    set("default").await;
808
    assert_eq!(row().await.flow, "");
809
    assert!(set("sometimes").await.body.contains("Pick on, off"));
810
}
811
812
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
813
/// button, never the repository's default bookmark as the hub sets it.
814
#[tokio::test(flavor = "multi_thread")]
815
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
816
    let h = hub().await;
817
    let app = &h.app;
818
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
819
        .await
820
        .cookie
821
        .unwrap();
822
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
823
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
824
    let url = format!("{}/andy/demo", h.base);
825
    let work = tempfile::tempdir().unwrap();
826
    let (w, u) = (work.path().to_path_buf(), url.clone());
827
    let client = tokio::task::spawn_blocking(move || {
828
        let mut c = Repo::init(&w).unwrap();
829
        c.config.set("remote.origin.url", &u).unwrap();
830
        c.config.set("remote.origin.token", "site").unwrap();
831
        c.save_config().unwrap();
832
        write(&w, "a.txt", b"a\n");
833
        c.commit("a", &[]).unwrap();
834
        assert!(c.push("origin", false).unwrap()[0].ok);
835
        for b in ["develop", "feature/x", "stray"] {
836
            c.bookmark_create(b, None).unwrap();
837
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
838
        }
839
        // A pushed deletion.
840
        let r = c.push_delete("origin", "feature/x").unwrap();
841
        assert!(r[0].ok, "{r:?}");
842
        c
843
    })
844
    .await
845
    .unwrap();
846
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
847
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
848
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
849
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
850
    assert!(!anon.body.contains("/bookmarks/delete"));
851
852
    // The hub's default, not the repository's config, is protected: make
853
    // develop the default, then main can go and develop cannot.
854
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
855
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
856
    let client = tokio::task::spawn_blocking(move || {
857
        let r = client.push_delete("origin", "develop").unwrap();
858
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
859
        let r = client.push_delete("origin", "main").unwrap();
860
        assert!(r[0].ok, "{r:?}");
861
        client
862
    })
863
    .await
864
    .unwrap();
865
    drop(client);
866
867
    // On the web: a writer deletes stray; the default is refused.
868
    let form = |b: &'static str| {
869
        let (app, andy) = (app.clone(), andy.clone());
870
        async move {
871
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
872
            call(
873
                &app,
874
                "POST",
875
                "/andy/demo/bookmarks/delete",
876
                None,
877
                Some(&andy),
878
                None,
879
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
880
            )
881
            .await
882
        }
883
    };
884
    let r = form("stray").await;
885
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
886
    assert!(!r.body.contains(">stray<"));
887
    let r = form("develop").await;
888
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
889
    let r = form("nope").await;
890
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
891
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
892
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
893
    // Anonymous visitors cannot.
894
    assert_ne!(
895
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
896
        StatusCode::OK
897
    );
898
}
899
900
/// A change signed by a key no account has linked says so, on its page
901
/// and in the API (feedback 14).
902
#[tokio::test(flavor = "multi_thread")]
903
async fn changes_signed_by_unlinked_keys_say_so() {
904
    let h = hub().await;
905
    let app = &h.app;
906
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
907
        .await
908
        .cookie
909
        .unwrap();
910
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
911
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
912
    let url = format!("{}/andy/demo", h.base);
913
    let work = tempfile::tempdir().unwrap();
914
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
915
    let hash = tokio::task::spawn_blocking(move || {
916
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
917
        c.config.set("remote.origin.url", &u).unwrap();
918
        c.config.set("remote.origin.token", "site").unwrap();
919
        c.save_config().unwrap();
920
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
921
        write(&w.join("r"), "a.txt", b"a\n");
922
        let h = c.commit("signed by Ada", &[]).unwrap();
923
        assert!(c.push("origin", false).unwrap()[0].ok);
924
        h.to_hex()
925
    })
926
    .await
927
    .unwrap();
928
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
929
    assert_eq!(st, StatusCode::OK, "{v}");
930
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
931
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
932
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
933
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
934
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
935
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
936
}
937
938
/// Function history (hub spec §6.6): the file page lists a file's
939
/// functions, and a function's page lists exactly the changes to its lines.
940
#[tokio::test(flavor = "multi_thread")]
941
async fn a_function_has_its_own_history() {
942
    let h = hub().await;
943
    let app = &h.app;
944
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
945
        .await
946
        .cookie
947
        .unwrap();
948
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
949
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
950
    let url = format!("{}/andy/demo", h.base);
951
    let work = tempfile::tempdir().unwrap();
952
    let w = work.path().to_path_buf();
953
    tokio::task::spawn_blocking(move || {
954
        let mut c = Repo::init(&w).unwrap();
955
        c.config.set("remote.origin.url", &url).unwrap();
956
        c.config.set("remote.origin.token", "site").unwrap();
957
        c.save_config().unwrap();
958
        let steps = [
959
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
960
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
961
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
962
        ];
963
        for (msg, text) in steps {
964
            write(&w, "src/lib.rs", text.as_bytes());
965
            c.commit(msg, &[]).unwrap();
966
        }
967
        assert!(c.push("origin", false).unwrap()[0].ok);
968
    })
969
    .await
970
    .unwrap();
971
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
972
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
973
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
974
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
975
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
976
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
977
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
978
    assert_ne!(bad.status, StatusCode::OK);
979
}
980
981
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
982
/// dependency edges, linked cards.
983
#[tokio::test(flavor = "multi_thread")]
984
async fn a_bookmark_shows_as_swimlanes() {
985
    let h = hub().await;
986
    let app = &h.app;
987
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
988
        .await
989
        .cookie
990
        .unwrap();
991
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
992
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
993
    let url = format!("{}/andy/demo", h.base);
994
    let work = tempfile::tempdir().unwrap();
995
    let w = work.path().to_path_buf();
996
    tokio::task::spawn_blocking(move || {
997
        let mut c = Repo::init(&w).unwrap();
998
        c.config.set("remote.origin.url", &url).unwrap();
999
        c.config.set("remote.origin.token", "site").unwrap();
1000
        c.save_config().unwrap();
1001
        // Two files edited independently: two lanes.
1002
        write(&w, "a.txt", b"a\n");
1003
        c.commit("add a", &[]).unwrap();
1004
        write(&w, "b.txt", b"b\n");
1005
        c.commit("add b", &[]).unwrap();
1006
        write(&w, "a.txt", b"a\na2\n");
1007
        c.commit("grow a", &[]).unwrap();
1008
        assert!(c.push("origin", false).unwrap()[0].ok);
1009
    })
1010
    .await
1011
    .unwrap();
1012
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1013
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1014
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1015
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1016
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1017
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1018
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1019
    assert_eq!(board.matches("<rect ").count(), 3);
1020
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1021
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1022
}
1023
1024
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1025
/// offers only what makes sense and rewrites nothing itself.
1026
#[tokio::test(flavor = "multi_thread")]
1027
async fn a_proposal_board_plans_squashes_and_rebases() {
1028
    let h = hub().await;
1029
    let app = &h.app;
1030
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1031
        .await
1032
        .cookie
1033
        .unwrap();
1034
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1035
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1036
    let url = format!("{}/andy/demo", h.base);
1037
    let work = tempfile::tempdir().unwrap();
1038
    let w = work.path().to_path_buf();
1039
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1040
        let mut c = Repo::init(&w).unwrap();
1041
        c.config.set("remote.origin.url", &url).unwrap();
1042
        c.config.set("remote.origin.token", "site").unwrap();
1043
        c.save_config().unwrap();
1044
        write(&w, "a.txt", b"a\n");
1045
        let base = c.commit("base", &[]).unwrap();
1046
        assert!(c.push("origin", false).unwrap()[0].ok);
1047
        c.bookmark_create("feature", None).unwrap();
1048
        c.bookmark_switch("feature", false).unwrap();
1049
        write(&w, "a.txt", b"a\nfirst\n");
1050
        let first = c.commit("first", &[]).unwrap();
1051
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1052
        let second = c.commit("second", &[]).unwrap();
1053
        write(&w, "b.txt", b"apart\n");
1054
        let apart = c.commit("apart", &[]).unwrap();
1055
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1056
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1057
    })
1058
    .await
1059
    .unwrap();
1060
    // No proposal yet: the board is read-only.
1061
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1062
    assert!(!board.contains("data-plan="));
1063
    let (st, _) = api(
1064
        app,
1065
        "POST",
1066
        "/api/v1/repos/andy/demo/proposals",
1067
        Some("site"),
1068
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1069
    )
1070
    .await;
1071
    assert!(st.is_success(), "{st}");
1072
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1073
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1074
    let csrf = csrf_of(&board);
1075
    let plan = |c: &str, t: &str| {
1076
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1077
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1078
        async move {
1079
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1080
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1081
        }
1082
    };
1083
    let kinds = |v: &serde_json::Value| {
1084
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1085
    };
1086
    // second already depends on first: squash, no rebase.
1087
    let v = plan(&second, &first).await;
1088
    assert_eq!(kinds(&v), ["squash"], "{v}");
1089
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1090
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygen.oxygen-vscode/plan?"));
1091
    // apart is independent of second: either.
1092
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1093
    // first under second: nothing (second depends on first).
1094
    assert!(plan(&first, &second).await["error"].is_string());
1095
    // What has landed on main is not rearranged.
1096
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1097
}
1098
1099
/// Issues and proposals share a number space, so every number says what it
1100
/// is, and the chain of work shows from both ends (hub spec §8).
1101
#[tokio::test(flavor = "multi_thread")]
1102
async fn proposals_and_issues_show_their_chain() {
1103
    let h = hub().await;
1104
    let app = &h.app;
1105
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1106
        .await
1107
        .cookie
1108
        .unwrap();
1109
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1110
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1111
    let url = format!("{}/andy/demo", h.base);
1112
    let work = tempfile::tempdir().unwrap();
1113
    let w = work.path().to_path_buf();
1114
    tokio::task::spawn_blocking(move || {
1115
        let mut c = Repo::init(&w).unwrap();
1116
        c.config.set("remote.origin.url", &url).unwrap();
1117
        c.config.set("remote.origin.token", "site").unwrap();
1118
        c.save_config().unwrap();
1119
        write(&w, "a.txt", b"a\n");
1120
        c.commit("base", &[]).unwrap();
1121
        assert!(c.push("origin", false).unwrap()[0].ok);
1122
        c.bookmark_create("feature", None).unwrap();
1123
        c.bookmark_switch("feature", false).unwrap();
1124
        write(&w, "a.txt", b"a\nfixed\n");
1125
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1126
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1127
    })
1128
    .await
1129
    .unwrap();
1130
    for title in ["Slow start", "Crash on save"] {
1131
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1132
        assert!(st.is_success());
1133
    }
1134
    let (st, v) = api(
1135
        app,
1136
        "POST",
1137
        "/api/v1/repos/andy/demo/proposals",
1138
        Some("site"),
1139
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1140
    )
1141
    .await;
1142
    assert!(st.is_success(), "{st} {v}");
1143
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1144
1145
    // The proposal names its kind, links its references by kind, and shows
1146
    // the chain: the issues it closes (description and changes) → it → main.
1147
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1148
    assert!(p.contains(">proposal #3</small>"), "header");
1149
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1150
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1151
    let chain = &chain[..chain.find("</p>").unwrap()];
1152
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1153
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1154
    }
1155
    assert!(p.contains("<h3>Closes</h3>"));
1156
1157
    // The issue shows the proposal that closes it, and names its own kind.
1158
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1159
    assert!(i.contains(">issue #1</small>"));
1160
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1161
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1162
    // The conversation is a timeline with avatars; editing sits with the
1163
    // content, not in the sidebar, and labels and projects are editable.
1164
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1165
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1166
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1167
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1168
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1169
    assert!(st.is_success(), "{st}");
1170
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1171
    assert!(p.contains("<option value=\"1\">Board</option>"), "the owner's projects to add to");
1172
    let csrf = csrf_of(&p);
1173
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1174
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1175
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1176
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1177
        .await;
1178
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1179
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1180
1181
    // Closed by the proposal's change, not its description: still shown.
1182
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1183
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1184
    assert!(chain.contains("proposal #3"), "{chain}");
1185
}
1186
1187
/// What the hub is: its version and build, and the libraries it is built on,
1188
/// on /about, in the API and in /health (hub spec §15).
1189
#[tokio::test(flavor = "multi_thread")]
1190
async fn the_hub_says_what_version_it_is() {
1191
    let h = hub().await;
1192
    let app = &h.app;
1193
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1194
    assert_eq!(st, StatusCode::OK);
1195
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1196
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1197
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1198
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1199
    assert!(health.contains("\"build\""), "{health}");
1200
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1201
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1202
    assert!(about.contains("href=\"/about\""), "the footer links here");
1203
}
1204
1205
#[tokio::test(flavor = "multi_thread")]
1206
async fn device_sign_in() {
1207
    let h = hub().await;
1208
    let app = &h.app;
1209
    let r =
1210
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1211
    let andy = r.cookie.unwrap();
1212
1213
    // An unknown scope is refused.
1214
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1215
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1216
1217
    // The app asks for a code and polls; nobody has approved it yet.
1218
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1219
    assert_eq!(st, StatusCode::OK, "{v}");
1220
    let device = v["device_code"].as_str().unwrap().to_string();
1221
    let user = v["user_code"].as_str().unwrap().to_string();
1222
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1223
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1224
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1225
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1226
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1227
    assert_eq!(v["error"], "slow_down", "polled too soon");
1228
1229
    // The user approves it on the web, allowing less than it asked for.
1230
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1231
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1232
    let csrf = csrf_of(&page.body);
1233
    let r =
1234
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1235
            .await;
1236
    assert!(r.body.contains("Approved"), "{}", r.body);
1237
1238
    // The next poll gets a token with what was allowed, once.
1239
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1240
    assert_eq!(st, StatusCode::OK, "{v}");
1241
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1242
    let token = v["access_token"].as_str().unwrap().to_string();
1243
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1244
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1245
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1246
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1247
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1248
    assert!(tokens.body.contains("device: Phone app"));
1249
    // oxygenhub#70: a device's token expires, and each use renews it.
1250
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1251
1252
    // The token can revoke itself (oxy auth logout), and is then refused.
1253
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1254
    assert_eq!(st, StatusCode::NO_CONTENT);
1255
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1256
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1257
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1258
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1259
1260
    // A denied code says so.
1261
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1262
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1263
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1264
    let csrf = csrf_of(&page.body);
1265
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1266
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1267
    assert_eq!(v["error"], "access_denied");
1268
1269
    // Signed out, the page asks for a sign-in first.
1270
    let r = call(app, "GET", "/device", None, None, None, None).await;
1271
    assert!(r.status.is_redirection(), "{}", r.status);
1272
}