de505df5 Andy McCall 1 month ago ↶
1
2
3
4
use super :: history:: { render_files, FileRows} ;
5
use super :: settings:: { csrf, require} ;
6
use super :: { filters, lookup, lookup_role, Error, Page, RepoShell, Shell} ;
7
use crate :: auth:: { Access, Role, Viewer} ;
8
use crate :: db:: { self , accounts, proposals as pdb} ;
9
use crate :: render:: { self , diff} ;
10
use crate :: repos:: proposals:: { self as pl, Projection, Source} ;
11
use crate :: repos:: view:: { self , ChangeView, ConflictView} ;
12
use crate :: repos:: RepoName;
13
use crate :: Shared;
14
use askama:: Template;
15
use axum:: extract:: { Form, Path, Query, State} ;
16
use axum:: response:: { IntoResponse, Redirect, Response} ;
17
use hub_api:: { Approval, ProposalSource, ProposalState} ;
18
use oxy_core:: hash:: ChangeHash;
19
use serde:: Deserialize;
20
use std:: collections:: { BTreeMap, HashMap} ;
21
22
23
24
# [ derive ( Template ) ]
25
# [ template ( path = " proposals.html" ) ]
26
pub struct ProposalsPage {
27
shell : Shell,
28
repo : RepoShell,
29
rows : Vec< pdb:: ProposalRow> ,
30
filter : String,
31
counts : ( usize , usize , usize ) ,
32
bookmarks : Vec< String> ,
33
}
34
35
# [ derive ( Deserialize ) ]
36
pub struct ListQuery {
37
state : Option< String> ,
38
}
39
40
pub async fn list (
41
State( app ) : State< Shared> ,
42
viewer : Viewer,
43
Path( (owner , name ) ) : Path< ( String, String) > ,
44
Query( q) : Query< ListQuery> ,
45
) -> Result< Page< ProposalsPage> , Error> {
46
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposals" ) , & viewer) ;
47
let ( repo, row, role) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
48
let all = pdb:: list( & app.db, row.id, & [ ] ) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
49
let counts = (
50
all.iter ( ) .filter ( | p | p.is_open ( ) ) .count ( ) ,
51
all.iter ( ) .filter ( | p | p.state = = " landed" ) .count ( ) ,
52
all.iter ( ) .filter ( | p | p.state = = " closed" ) .count ( ) ,
53
) ;
54
let filter = q.state.unwrap_or_else ( | | " open" .into ( ) ) ;
55
let rows = all
56
.into_iter ( )
57
.filter ( | p | match filter.as_str ( ) {
58
" open" => p.is_open ( ) ,
59
" landed" => p.state = = " landed" ,
60
" closed" => p.state = = " closed" ,
61
_ => true ,
62
} )
63
.collect ( ) ;
64
let bookmarks = app
65
.repos
66
.read ( & repo, | r , _| Ok ( r.bookmarks ( ) ? .into_iter ( ) .map ( | b | b.name ) .collect:: < Vec< _ > > ( ) ) )
67
.await
68
.map_err ( | e | Error:: from_repo( shell.clone ( ) , e) ) ? ;
69
Ok ( Page( ProposalsPage { shell, repo: RepoShell:: new( & app, & row, " proposals" ) .with_role ( role) , rows, filter, counts, bookmarks } ) )
70
}
71
72
73
74
# [ derive ( Template ) ]
75
# [ template ( path = " proposal_new.html" ) ]
76
pub struct NewProposalPage {
77
shell : Shell,
78
repo : RepoShell,
79
bookmarks : Vec< String> ,
80
source : String,
81
target : String,
82
error : Option< String> ,
83
84
preview : Vec< ChangeView> ,
85
conflicted : bool ,
86
}
87
88
# [ derive ( Deserialize ) ]
89
pub struct NewQuery {
90
source : Option< String> ,
91
target : Option< String> ,
92
}
93
94
95
fn parse_source ( app : & Shared, repo : & RepoName, source : & str ) -> Option< ( Option< RepoName> , String) > {
96
if let Some ( ( slug, bookmark) ) = source.split_once ( ' :' ) {
97
let fork = RepoName:: parse( slug) ? ;
98
if ! app.repos.exists ( & fork) | | fork = = * repo {
99
return None ;
100
}
101
return Some ( ( Some ( fork) , bookmark.to_string ( ) ) ) ;
102
}
103
crate :: repos:: names:: valid_segment( source) .then ( | | ( None , source.to_string ( ) ) )
104
}
105
106
async fn preview_for (
107
app : & Shared,
108
repo : & RepoName,
109
target : & str ,
110
source : & str ,
111
) -> Result< ( Vec< ChangeView> , bool ) , crate:: repos:: RepoError> {
112
let Some ( ( fork, bookmark) ) = parse_source ( app, repo, source) else { return Ok ( ( vec! [ ] , false ) ) } ;
113
let target = target.to_string ( ) ;
114
let fork_dir = fork.as_ref ( ) .map ( | f | app.repos.dir ( f) ) ;
115
app.repos
116
.read ( repo, move | r, cache| {
117
let projection = match & fork_dir {
118
Some ( dir) => {
119
let fork_repo = oxy_core:: repo:: Repo:: open( dir) ? ;
120
let heads = fork_repo.bookmarks ( ) ? .into_iter ( ) .find ( | b | b.name = = bookmark ) .map ( | b | b.heads ) .unwrap_or_default ( ) ;
121
pl:: project( r, cache, & target, Source:: Fork { fork: & fork_repo, heads } ) ?
122
}
123
None => {
124
let heads = r.bookmarks ( ) ? .into_iter ( ) .find ( | b | b.name = = bookmark ) .map ( | b | b.heads ) .unwrap_or_default ( ) ;
125
pl:: project( r, cache, & target, Source:: Bookmark( heads) ) ?
126
}
127
} ;
128
Ok ( ( projection.changes, projection.conflicted) )
129
} )
130
.await
131
}
132
133
pub async fn new_form (
134
State( app ) : State< Shared> ,
135
viewer : Viewer,
136
Path( (owner , name ) ) : Path< ( String, String) > ,
137
Query( q) : Query< NewQuery> ,
138
) -> Result< Page< NewProposalPage> , Error> {
139
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposals/new" ) , & viewer) ;
140
require ( & viewer, & shell) ? ;
141
let ( repo, row, role) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
142
let bookmarks = app
143
.repos
144
.read ( & repo, | r , _| Ok ( r.bookmarks ( ) ? .into_iter ( ) .map ( | b | b.name ) .collect:: < Vec< _ > > ( ) ) )
145
.await
146
.map_err ( | e | Error:: from_repo( shell.clone ( ) , e) ) ? ;
147
let target = q.target.unwrap_or_else ( | | row.default_bookmark.clone ( ) ) ;
148
let source = q.source.unwrap_or_default ( ) ;
149
let ( preview, conflicted) =
150
if source.is_empty ( ) { ( vec! [ ] , false ) } else { preview_for ( & app, & repo, & target, & source) .await.unwrap_or ( ( vec! [ ] , false ) ) } ;
151
Ok ( Page( NewProposalPage {
152
shell,
153
repo: RepoShell:: new( & app, & row, " proposals" ) .with_role ( role) ,
154
bookmarks,
155
source,
156
target,
157
error: None ,
158
preview,
159
conflicted,
160
} ) )
161
}
162
163
# [ derive ( Deserialize ) ]
164
pub struct NewForm {
165
#[serde(rename = "_csrf")]
166
csrf_token : String,
167
title : String,
168
#[serde(default)]
169
body : String,
170
target : String,
171
source : String,
172
#[serde(default)]
173
draft : Option< String> ,
174
}
175
b64e2537 Andy McCall 1 month ago ↶
176
177
# [ allow ( clippy::too_many_arguments ) ]
178
pub async fn open_proposal (
179
app : & Shared,
180
repo : & RepoName,
181
row : & db:: repos:: RepoRow,
182
me : & accounts:: Account,
183
title : & str ,
184
body : & str ,
185
target : & str ,
186
source : & str ,
187
draft : bool ,
188
) -> Result< pdb:: ProposalRow, String> {
189
if title.trim ( ) .is_empty ( ) {
190
return Err ( " Give the proposal a title." .into ( ) ) ;
de505df5 Andy McCall 1 month ago ↶
191
}
b64e2537 Andy McCall 1 month ago ↶
192
let bookmarks =
193
app.repos.read ( repo, | r , _| Ok ( r.bookmarks ( ) ? .into_iter ( ) .map ( | b | b.name ) .collect:: < Vec< _ > > ( ) ) ) .await.map_err ( | e | e.to_string ( ) ) ? ;
194
if ! bookmarks.iter ( ) .any ( | b | b = = target ) {
195
return Err ( " Pick a target bookmark of this repository." .into ( ) ) ;
de505df5 Andy McCall 1 month ago ↶
196
}
b64e2537 Andy McCall 1 month ago ↶
197
let Some ( ( fork, bookmark) ) = parse_source ( app, repo, source.trim ( ) ) else {
198
return Err ( " The source is a bookmark of this repository, or owner/name:bookmark of a fork." .into ( ) ) ;
de505df5 Andy McCall 1 month ago ↶
199
} ;
b64e2537 Andy McCall 1 month ago ↶
200
if fork.is_none ( ) & & bookmark = = target {
201
return Err ( " The source and the target are the same bookmark." .into ( ) ) ;
de505df5 Andy McCall 1 month ago ↶
202
}
b64e2537 Andy McCall 1 month ago ↶
203
let ( preview, _ ) = preview_for ( app, repo, target, source.trim ( ) ) .await.map_err ( | e | e.to_string ( ) ) ? ;
de505df5 Andy McCall 1 month ago ↶
204
if preview.is_empty ( ) {
b64e2537 Andy McCall 1 month ago ↶
205
return Err ( " The source adds nothing to the target." .into ( ) ) ;
de505df5 Andy McCall 1 month ago ↶
206
}
207
let source_repo_id = match & fork {
b64e2537 Andy McCall 1 month ago ↶
208
Some ( fk) => db:: repos:: get( & app.db, & fk.owner, & fk.name) .await.map_err ( | e | e.to_string ( ) ) ? .map ( | r | r.id ) ,
de505df5 Andy McCall 1 month ago ↶
209
None => None ,
210
} ;
211
let created = pdb:: create(
212
& app.db,
213
pdb:: NewProposal {
214
repo_id: row.id,
b64e2537 Andy McCall 1 month ago ↶
215
title: title.trim ( ) ,
216
body: body.trim ( ) ,
217
author_id: Some ( me.id) ,
218
author: & me.username,
219
draft,
220
target,
de505df5 Andy McCall 1 month ago ↶
221
source_kind: if fork.is_some ( ) { " fork" } else { " bookmark" } ,
222
source_repo_id,
223
source_bookmark: & bookmark,
224
source_changes: " " ,
225
} ,
226
)
227
.await
b64e2537 Andy McCall 1 month ago ↶
228
.map_err ( | e | e.to_string ( ) ) ? ;
229
pdb:: add_event( & app.db, created.id, & me.username, " opened" , " " ) .await.ok ( ) ;
230
accounts:: audit( & app.db, Some ( me) , " proposal.opened" , & format! ( " {} #{} " , row.slug ( ) , created.number) , title) .await.ok ( ) ;
18e381ea Andy McCall 1 month ago ↶
231
db:: notify:: index( & app.db, " proposal" , row.id, created.id, created.number, & created.title, & created.body) .await.ok ( ) ;
b64e2537 Andy McCall 1 month ago ↶
232
let url = format! ( " /{} /proposal/{} " , row.slug ( ) , created.number) ;
18e381ea Andy McCall 1 month ago ↶
233
crate :: notify:: deliver(
b64e2537 Andy McCall 1 month ago ↶
234
app,
18e381ea Andy McCall 1 month ago ↶
235
crate :: notify:: Event {
236
kind: " proposal.opened" ,
b64e2537 Andy McCall 1 month ago ↶
237
title: format! ( " {} #{} : {} " , row.slug ( ) , created.number, created.title) ,
238
url,
239
actor: me,
18e381ea Andy McCall 1 month ago ↶
240
repo_id: row.id,
241
thread: Some ( ( " proposal" , created.id) ) ,
b64e2537 Andy McCall 1 month ago ↶
242
mention_text: body,
18e381ea Andy McCall 1 month ago ↶
243
direct: vec! [ ] ,
244
} ,
245
)
246
.await;
b64e2537 Andy McCall 1 month ago ↶
247
crate :: hooks:: emit(
248
app,
249
row,
250
" proposal.opened" ,
251
& me.username,
252
serde_json:: json! ( { " number" : created.number, " title" : created.title, " target" : target, " source" : source } ) ,
253
)
254
.await;
255
Ok ( created)
256
}
257
258
pub async fn create (
259
State( app ) : State< Shared> ,
260
viewer : Viewer,
261
Path( (owner , name ) ) : Path< ( String, String) > ,
262
Form( f) : Form< NewForm> ,
263
) -> Result< Response, Error> {
264
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposals/new" ) , & viewer) ;
265
let me = require ( & viewer, & shell) ? ;
266
csrf ( & viewer, & f.csrf_token, & shell) ? ;
267
let ( repo, row, role) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
268
match open_proposal ( & app, & repo, & row, & me.account, & f.title, & f.body, & f.target, & f.source, f.draft.is_some ( ) ) .await {
269
Ok ( created) => Ok ( Redirect:: to( & format! ( " /{owner} /{name} /proposal/{} " , created.number) ) .into_response ( ) ) ,
270
Err ( msg) => {
271
let bookmarks =
272
app.repos.read ( & repo, | r , _| Ok ( r.bookmarks ( ) ? .into_iter ( ) .map ( | b | b.name ) .collect:: < Vec< _ > > ( ) ) ) .await.unwrap_or_default ( ) ;
273
Ok ( Page( NewProposalPage {
274
shell,
275
repo: RepoShell:: new( & app, & row, " proposals" ) .with_role ( role) ,
276
bookmarks,
277
source: f.source.clone ( ) ,
278
target: f.target.clone ( ) ,
279
error: Some ( msg) ,
280
preview: vec! [ ] ,
281
conflicted: false ,
282
} )
283
.into_response ( ) )
284
}
285
}
de505df5 Andy McCall 1 month ago ↶
286
}
287
288
289
290
291
pub struct CommentView {
292
pub row : pdb:: CommentRow,
293
pub body_html : String,
294
pub line : Option< usize > ,
295
}
296
297
pub struct ReviewView {
298
pub row : pdb:: ReviewRow,
299
pub body_html : String,
300
pub sealed : bool ,
301
}
302
303
304
pub struct Loaded {
305
pub row : pdb:: ProposalRow,
306
pub changes : Vec< ChangeView> ,
307
pub hashes : Vec< ChangeHash> ,
308
pub heads : Vec< ChangeHash> ,
3f02e5ea Andy McCall 1 month ago ↶
309
pub target_heads : Vec< ChangeHash> ,
de505df5 Andy McCall 1 month ago ↶
310
pub state : String,
311
pub target_state : String,
312
pub conflicted : bool ,
313
pub conflicts : Vec< ConflictView> ,
314
pub files : Vec< FileRows> ,
315
316
pub atoms : HashMap< ( String, usize ) , ( String, u32 ) > ,
317
pub sealing_keys : Vec< String> ,
318
pub touched : Vec< String> ,
319
pub owners : Vec< String> ,
320
pub landed_already : bool ,
321
}
322
323
324
pub async fn load ( app : & Shared, repo : & RepoName, row : pdb:: ProposalRow) -> Result< Loaded, crate:: repos:: RepoError> {
325
let fork_dir = match ( row.source_kind.as_str ( ) , row.source_repo_id) {
326
( " fork" , Some ( id) ) => {
327
db:: repos:: get_by_id( & app.db, id) .await.ok ( ) .flatten ( ) .and_then ( | r | RepoName:: new( & r.owner, & r.name) ) .map ( | n | app.repos.dir ( & n) )
328
}
329
_ => None ,
330
} ;
331
let r2 = row.clone ( ) ;
332
let loaded = app
333
.repos
334
.read ( repo, move | r, cache| {
335
let source = match ( r2.source_kind.as_str ( ) , & fork_dir) {
336
( " changes" , _ ) => Source:: Changes( r2.source_changes ( ) .iter ( ) .filter_map ( | h | ChangeHash:: from_hex( h) ) .collect ( ) ) ,
337
( " fork" , Some ( dir) ) => {
338
let fork_repo = oxy_core:: repo:: Repo:: open( dir) ? ;
339
let heads =
340
fork_repo.bookmarks ( ) ? .into_iter ( ) .find ( | b | b.name = = r2.source_bookmark ) .map ( | b | b.heads ) .unwrap_or_default ( ) ;
341
342
let fork_state = fork_repo.load_state ( & heads) ? ;
343
let missing: Vec< ChangeHash> = fork_state.changes ( ) .map ( | ( h , _) | * h) .filter ( | h | ! r.store ( ) .has ( h) ) .collect ( ) ;
344
if ! missing.is_empty ( ) {
345
r.import_bundle ( & fork_repo.bundle_for ( & missing) ? , r.current_policy ( ) ? .is_some ( ) ) ? ;
346
}
347
Source:: Changes( heads)
348
}
349
_ => {
350
let heads = r.bookmarks ( ) ? .into_iter ( ) .find ( | b | b.name = = r2.source_bookmark ) .map ( | b | b.heads ) .unwrap_or_default ( ) ;
351
Source:: Bookmark( heads)
352
}
353
} ;
354
let p: Projection = pl:: project( r, cache, & r2.target, source) ? ;
355
let target_loaded = cache.load ( r, & p.target_heads) ? ;
356
let files = render_files ( & p.files, & p.bases) ;
357
let mut atoms = HashMap:: new( ) ;
358
for f in & files {
359
for l in & f.lines {
360
if let Some ( n) = l.new_no {
361
if let Some ( ( h, i) ) = pl:: atom_at( & p.loaded, & f.path, n as usize ) {
362
atoms.insert ( ( f.path.clone ( ) , n as usize ) , ( h.to_hex ( ) , i) ) ;
363
}
364
}
365
}
366
}
367
let touched: Vec< String> = p.files.iter ( ) .map ( | f | f.path.clone ( ) ) .collect ( ) ;
368
let owners = pl:: owners_for( & target_loaded, & touched) ;
369
let sealing = pl:: sealing_keys( r, & p.hashes) ? .into_iter ( ) .map ( | k | k.to_hex ( ) ) .collect ( ) ;
370
let landed_already = ! p.hashes.is_empty ( ) & & p.hashes.iter ( ) .all ( | h | target_loaded.state.contains ( h) ) ;
371
Ok ( Loaded {
372
row: r2,
373
changes: p.changes,
374
hashes: p.hashes,
375
heads: p.heads,
3f02e5ea Andy McCall 1 month ago ↶
376
target_heads: p.target_heads.clone ( ) ,
de505df5 Andy McCall 1 month ago ↶
377
state: p.state.to_hex ( ) ,
378
target_state: p.target_state.to_hex ( ) ,
379
conflicted: p.conflicted,
380
conflicts: p.conflicts,
381
files,
382
atoms,
383
sealing_keys: sealing,
384
touched,
385
owners,
386
landed_already,
387
} )
388
} )
389
.await? ;
390
391
let heads_csv = loaded.heads.iter ( ) .map ( | h | h.to_hex ( ) ) .collect:: < Vec< _ > > ( ) .join ( " ," ) ;
392
let changes_csv = loaded.hashes.iter ( ) .map ( | h | h.to_hex ( ) ) .collect:: < Vec< _ > > ( ) .join ( " ," ) ;
393
pdb:: set_projection( & app.db, loaded.row.id, & loaded.state, & heads_csv, & loaded.target_state, & changes_csv, loaded.conflicted)
394
.await
395
.ok ( ) ;
396
Ok ( loaded)
397
}
398
399
400
pub struct Verdict {
401
pub reviews : Vec< ReviewView> ,
402
pub approvals : Vec< Approval> ,
403
pub blockers : Vec< String> ,
404
pub depends_on : Vec< i64 > ,
405
pub requirements : pdb:: Requirements,
406
}
407
408
pub async fn verdict ( app : & Shared, loaded : & Loaded, repo_id : i64 ) -> Result< Verdict, sqlx:: Error> {
409
let rows = pdb:: reviews( & app.db, loaded.row.id) .await? ;
410
let links = accounts:: identity_accounts( & app.db) .await? ;
411
let sealed_accounts: Vec< String> = links.iter ( ) .filter ( | ( k , _) | loaded.sealing_keys.contains ( k) ) .map ( | ( _, u ) | u.clone ( ) ) .collect ( ) ;
412
413
let mut latest: BTreeMap< String, & pdb:: ReviewRow> = BTreeMap:: new( ) ;
414
for r in & rows {
415
latest.insert ( r.author.clone ( ) , r) ;
416
}
417
let mut approvals = Vec :: new( ) ;
418
for ( who, r) in & latest {
419
if r.verdict = = " approve" {
420
let sealed = sealed_accounts.contains ( who) ;
421
let key = links.iter ( ) .find ( | ( k , u ) | u = = who & & loaded.sealing_keys.contains ( k) ) .map ( | ( k , _) | k.clone ( ) ) ;
422
approvals.push ( Approval { account: who.clone ( ) , sealed, key } ) ;
423
}
424
}
425
let reviews = rows
426
.iter ( )
427
.map ( | r | ReviewView {
428
row: r.clone ( ) ,
429
body_html: render:: markdown:: render( & r.body, " /" , " /" ) ,
430
sealed: r.verdict = = " approve" & & sealed_accounts.contains ( & r.author) ,
431
} )
432
.collect ( ) ;
433
let requirements = pdb:: requirements( & app.db, repo_id) .await? ;
434
let mut blockers = Vec :: new( ) ;
435
if loaded.row.state = = " draft" {
436
blockers.push ( " the proposal is a draft" .into ( ) ) ;
437
}
438
if loaded.hashes.is_empty ( ) {
439
blockers.push ( " the proposal adds no changes" .into ( ) ) ;
440
}
441
let sealed_count = approvals.iter ( ) .filter ( | a | a.sealed ) .count ( ) as i64 ;
442
if sealed_count < requirements.required_approvals {
443
blockers.push ( format! ( " {sealed_count} of {} required sealed approvals" , requirements.required_approvals) ) ;
444
}
445
if requirements.require_owners {
446
let missing: Vec< & String> = loaded.owners.iter ( ) .filter ( | o | ! approvals.iter ( ) .any ( | a | a.sealed & & & a.account = = * o ) ) .collect ( ) ;
447
if ! missing.is_empty ( ) {
448
blockers.push ( format! ( " code owners still to approve: {} " , missing.iter ( ) .map ( | s | s.as_str ( ) ) .collect:: < Vec< _ > > ( ) .join ( " , " ) ) ) ;
449
}
450
}
451
if loaded.conflicted & & ! requirements.allow_conflicts {
452
blockers.push ( " landing would carry conflicts, which this repository refuses" .into ( ) ) ;
453
}
b64e2537 Andy McCall 1 month ago ↶
454
let required = db:: hooks:: required_checks( & app.db, repo_id) .await? ;
455
if ! required.is_empty ( ) {
456
let checks = db:: hooks:: checks_for_state( & app.db, repo_id, & loaded.state) .await? ;
457
let missing: Vec< String> =
458
required.iter ( ) .filter ( | n | ! checks.iter ( ) .any ( | c | & c.name = = * n & & c.status = = " passed" ) ) .cloned ( ) .collect ( ) ;
459
if ! missing.is_empty ( ) {
460
blockers.push ( format! ( " required checks not passed on the projected state: {} " , missing.join ( " , " ) ) ) ;
461
}
462
}
de505df5 Andy McCall 1 month ago ↶
463
let requesting: Vec< & String> = latest.iter ( ) .filter ( | ( _, r ) | r.verdict = = " changes" ) .map ( | ( who , _) | who ) .collect ( ) ;
464
if ! requesting.is_empty ( ) {
465
blockers.push ( format! ( " changes requested by {} " , requesting.iter ( ) .map ( | s | s.as_str ( ) ) .collect:: < Vec< _ > > ( ) .join ( " , " ) ) ) ;
466
}
467
468
let mut depends_on = Vec :: new( ) ;
469
for other in pdb:: list( & app.db, repo_id, & [ " open" , " draft" ] ) .await? {
470
if other.id = = loaded.row.id | | other.number > loaded.row.number {
471
continue ;
472
}
473
let theirs = other.projected_changes ( ) ;
474
if ! theirs.is_empty ( ) & & theirs.iter ( ) .all ( | h | loaded.hashes.iter ( ) .any ( | m | m.to_hex ( ) = = * h ) ) {
475
depends_on.push ( other.number) ;
476
}
477
}
478
if ! depends_on.is_empty ( ) {
479
blockers.push ( format! ( " depends on {} " , depends_on.iter ( ) .map ( | n | format! ( " #{n} " ) ) .collect:: < Vec< _ > > ( ) .join ( " , " ) ) ) ;
480
}
481
Ok ( Verdict { reviews, approvals, blockers, depends_on, requirements } )
482
}
483
484
# [ derive ( Template ) ]
485
# [ template ( path = " proposal.html" ) ]
486
pub struct ProposalPage {
487
shell : Shell,
488
repo : RepoShell,
489
p : pdb:: ProposalRow,
490
body_html : String,
491
tab : String,
492
changes : Vec< ChangeView> ,
493
files : Vec< FileRows> ,
494
conflicts : Vec< ConflictView> ,
495
conflicted : bool ,
496
comments : Vec< CommentView> ,
497
498
placed : HashMap< ( String, usize ) , Vec< usize > > ,
499
outdated : Vec< usize > ,
500
reviews : Vec< ReviewView> ,
501
approvals : Vec< Approval> ,
502
blockers : Vec< String> ,
503
depends_on : Vec< i64 > ,
504
events : Vec< pdb:: EventRow> ,
505
owners : Vec< String> ,
506
requirements : pdb:: Requirements,
507
landed_already : bool ,
508
can_edit : bool ,
509
can_land : bool ,
510
hub_can_land : bool ,
511
notice : Option< String> ,
512
error : Option< String> ,
513
heads : Vec< String> ,
514
state_hash : String,
515
source_label : String,
516
api_url : String,
18e381ea Andy McCall 1 month ago ↶
517
labels : Vec< db:: issues:: Label> ,
518
all_labels : Vec< db:: issues:: Label> ,
b64e2537 Andy McCall 1 month ago ↶
519
checks : Vec< db:: hooks:: Check> ,
520
required_checks : Vec< String> ,
de505df5 Andy McCall 1 month ago ↶
521
}
522
523
# [ derive ( Deserialize ) ]
524
pub struct DetailQuery {
525
tab : Option< String> ,
526
}
527
528
529
530
# [ allow ( clippy::too_many_arguments ) ]
531
async fn detail (
532
app : & Shared,
533
shell : Shell,
534
viewer : & Viewer,
535
owner : & str ,
536
name : & str ,
537
number : i64 ,
538
tab : String,
539
notice : Option< String> ,
540
error : Option< String> ,
541
) -> Result< Page< ProposalPage> , Error> {
542
let ( repo, row, role) = lookup ( app, & shell, viewer, owner, name) .await? ;
543
let p = pdb:: get( & app.db, row.id, number)
544
.await
545
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ?
546
.ok_or_else ( | | Error:: not_found( shell.clone ( ) ) ) ? ;
547
let loaded = load ( app, & repo, p) .await.map_err ( | e | Error:: from_repo( shell.clone ( ) , e) ) ? ;
548
549
if loaded.landed_already & & loaded.row.is_open ( ) {
550
pdb:: set_state( & app.db, loaded.row.id, " landed" , & loaded.target_state) .await.ok ( ) ;
551
pdb:: add_event( & app.db, loaded.row.id, " " , " landed" , " every change reached the target" ) .await.ok ( ) ;
552
}
553
let p = pdb:: get( & app.db, row.id, number) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? .unwrap_or ( loaded.row.clone ( ) ) ;
554
let v = verdict ( app, & loaded, row.id) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
555
let comment_rows = pdb:: comments( & app.db, loaded.row.id) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
556
let events = pdb:: events( & app.db, loaded.row.id) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
557
558
let mut by_atom: HashMap< ( String, String, u32 ) , usize > = HashMap:: new( ) ;
559
for ( ( path, line) , ( h, i) ) in & loaded.atoms {
560
by_atom.insert ( ( path.clone ( ) , h.clone ( ) , * i) , * line) ;
561
}
562
let mut comments = Vec :: new( ) ;
563
let mut placed: HashMap< ( String, usize ) , Vec< usize > > = HashMap:: new( ) ;
564
let mut outdated = Vec :: new( ) ;
565
for ( idx, c) in comment_rows.into_iter ( ) .enumerate ( ) {
566
let line = if c.anchor_change.is_empty ( ) {
567
None
568
} else {
569
by_atom.get ( & ( c.path.clone ( ) , c.anchor_change.clone ( ) , c.anchor_index as u32 ) ) .copied ( )
570
} ;
571
if ! c.anchor_change.is_empty ( ) {
572
match line {
573
Some ( l) => placed.entry ( ( c.path.clone ( ) , l) ) .or_default ( ) .push ( idx) ,
574
None => outdated.push ( idx) ,
575
}
576
}
577
comments.push ( CommentView { body_html: render:: markdown:: render( & c.body, " /" , " /" ) , row: c, line } ) ;
578
}
579
let mut changes = loaded.changes.clone ( ) ;
580
super :: attribute( app, & mut changes.iter_mut ( ) .collect:: < Vec< _ > > ( ) ) .await;
581
let me = viewer.account ( ) ;
582
let can_edit = me.is_some_and ( | a | Some ( a.id) = = p.author_id | | role > = Role:: Maintain) ;
583
let can_land = role > = Role:: Write & & p.is_open ( ) & & v.blockers.is_empty ( ) ;
14530604 Andy McCall 1 month ago ↶
584
let delegated = match viewer.account ( ) {
585
Some ( a) => super :: edit:: delegated_identity( app, a.id) .await.is_some ( ) ,
586
None => false ,
587
} ;
588
let hub_can_land = delegated | | app.repos.read ( & repo, | r , _| Ok ( r.current_policy ( ) ? .is_none ( ) ) ) .await.unwrap_or ( false ) ;
de505df5 Andy McCall 1 month ago ↶
589
let source_label = match p.source_kind.as_str ( ) {
590
" fork" => format! (
591
" fork {} " ,
592
db:: repos:: get_by_id( & app.db, p.source_repo_id.unwrap_or ( 0 ) )
593
.await
594
.ok ( )
595
.flatten ( )
596
.map ( | r | format! ( " {} :{} " , r.slug ( ) , p.source_bookmark) )
597
.unwrap_or_default ( )
598
) ,
599
" changes" => format! ( " {} changes" , p.source_changes ( ) .len ( ) ) ,
600
_ => p.source_bookmark.clone ( ) ,
601
} ;
602
Ok ( Page( ProposalPage {
603
shell,
604
repo: RepoShell:: new( app, & row, " proposals" ) .with_role ( role) ,
18e381ea Andy McCall 1 month ago ↶
605
body_html: super :: issues:: markdown( app, row.id, & format! ( " /{owner} /{name} " ) , & p.body) .await,
de505df5 Andy McCall 1 month ago ↶
606
p,
607
tab,
608
changes,
609
files: loaded.files,
610
conflicts: loaded.conflicts,
611
conflicted: loaded.conflicted,
612
comments,
613
placed,
614
outdated,
615
reviews: v.reviews,
616
approvals: v.approvals,
617
blockers: v.blockers,
618
depends_on: v.depends_on,
619
events,
620
owners: loaded.owners,
621
requirements: v.requirements,
622
landed_already: loaded.landed_already,
623
can_edit,
624
can_land,
625
hub_can_land,
626
notice,
627
error,
628
heads: loaded.heads.iter ( ) .map ( | h | h.to_hex ( ) ) .collect ( ) ,
b64e2537 Andy McCall 1 month ago ↶
629
state_hash: loaded.state.clone ( ) ,
de505df5 Andy McCall 1 month ago ↶
630
source_label,
631
api_url: format! ( " {} /api/v1/repos/{owner} /{name} /proposals/{number} " , app.config.base_url ( ) ) ,
18e381ea Andy McCall 1 month ago ↶
632
labels: db:: issues:: proposal_labels( & app.db, loaded.row.id) .await.unwrap_or_default ( ) ,
633
all_labels: db:: issues:: labels( & app.db, row.id) .await.unwrap_or_default ( ) ,
b64e2537 Andy McCall 1 month ago ↶
634
checks: db:: hooks:: checks_for_state( & app.db, row.id, & loaded.state) .await.unwrap_or_default ( ) ,
635
required_checks: db:: hooks:: required_checks( & app.db, row.id) .await.unwrap_or_default ( ) ,
de505df5 Andy McCall 1 month ago ↶
636
} ) )
637
}
638
639
pub async fn show (
640
State( app ) : State< Shared> ,
641
viewer : Viewer,
642
Path( (owner , name , number ) ) : Path< ( String, String, i64 ) > ,
643
Query( q) : Query< DetailQuery> ,
644
) -> Result< Page< ProposalPage> , Error> {
645
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposal/{number} " ) , & viewer) ;
646
detail ( & app, shell, & viewer, & owner, & name, number, q.tab.unwrap_or_else ( | | " conversation" .into ( ) ) , None , None ) .await
647
}
648
649
650
651
# [ derive ( Deserialize ) ]
652
pub struct CommentForm {
653
#[serde(rename = "_csrf")]
654
csrf_token : String,
655
body : String,
656
#[serde(default)]
657
path : String,
658
#[serde(default)]
659
line : Option< usize > ,
660
}
661
662
pub async fn comment (
663
State( app ) : State< Shared> ,
664
viewer : Viewer,
665
Path( (owner , name , number ) ) : Path< ( String, String, i64 ) > ,
666
Form( f) : Form< CommentForm> ,
667
) -> Result< Page< ProposalPage> , Error> {
668
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposal/{number} " ) , & viewer) ;
669
let me = require ( & viewer, & shell) ? ;
670
csrf ( & viewer, & f.csrf_token, & shell) ? ;
671
let ( repo, row, _ ) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
672
let p = pdb:: get( & app.db, row.id, number)
673
.await
674
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ?
675
.ok_or_else ( | | Error:: not_found( shell.clone ( ) ) ) ? ;
676
if f.body.trim ( ) .is_empty ( ) {
677
return detail (
678
& app,
679
shell,
680
& viewer,
681
& owner,
682
& name,
683
number,
684
" conversation" .into ( ) ,
685
None ,
686
Some ( " An empty comment says nothing." .into ( ) ) ,
687
)
688
.await;
689
}
690
let anchor = match ( f.path.trim ( ) , f.line) {
691
( " " , _ ) | ( _ , None ) => None ,
692
( path, Some ( line) ) => {
693
let loaded = load ( & app, & repo, p.clone ( ) ) .await.map_err ( | e | Error:: from_repo( shell.clone ( ) , e) ) ? ;
694
loaded.atoms.get ( & ( path.to_string ( ) , line) ) .cloned ( )
695
}
696
} ;
697
let tab = if anchor.is_some ( ) { " files" } else { " conversation" } ;
698
pdb:: add_comment(
699
& app.db,
700
p.id,
701
Some ( me.account.id) ,
702
& me.account.username,
703
f.body.trim ( ) ,
704
f.path.trim ( ) ,
705
anchor.as_ref ( ) .map ( | ( h , i ) | ( h.as_str ( ) , * i as i64 ) ) ,
706
)
707
.await
708
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
709
detail ( & app, shell, & viewer, & owner, & name, number, tab.into ( ) , None , None ) .await
710
}
711
712
# [ derive ( Deserialize ) ]
713
pub struct ReviewForm {
714
#[serde(rename = "_csrf")]
715
csrf_token : String,
716
verdict : String,
717
#[serde(default)]
718
body : String,
719
}
720
721
pub async fn review (
722
State( app ) : State< Shared> ,
723
viewer : Viewer,
724
Path( (owner , name , number ) ) : Path< ( String, String, i64 ) > ,
725
Form( f) : Form< ReviewForm> ,
726
) -> Result< Page< ProposalPage> , Error> {
727
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposal/{number} " ) , & viewer) ;
728
let me = require ( & viewer, & shell) ? ;
729
csrf ( & viewer, & f.csrf_token, & shell) ? ;
730
let ( _ , row, _ ) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
731
let p = pdb:: get( & app.db, row.id, number)
732
.await
733
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ?
734
.ok_or_else ( | | Error:: not_found( shell.clone ( ) ) ) ? ;
735
if ! matches! ( f.verdict.as_str ( ) , " comment" | " changes" | " approve" ) {
736
return Err ( Error:: bad( shell, " a review is comment, changes or approve" ) ) ;
737
}
738
if f.verdict = = " approve" & & Some ( me.account.id) = = p.author_id {
739
return detail (
740
& app,
741
shell,
742
& viewer,
743
& owner,
744
& name,
745
number,
746
" conversation" .into ( ) ,
747
None ,
748
Some ( " You cannot approve your own proposal." .into ( ) ) ,
749
)
750
.await;
751
}
752
pdb:: add_review( & app.db, p.id, me.account.id, & me.account.username, & f.verdict, f.body.trim ( ) )
753
.await
754
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
755
pdb:: add_event( & app.db, p.id, & me.account.username, & format! ( " review.{} " , f.verdict) , " " ) .await.ok ( ) ;
b64e2537 Andy McCall 1 month ago ↶
756
crate :: hooks:: emit( & app, & row, " review" , & me.account.username, serde_json:: json! ( { " number" : number, " verdict" : f.verdict } ) ) .await;
de505df5 Andy McCall 1 month ago ↶
757
let notice = if f.verdict = = " approve" {
758
Some ( format! (
759
" Approval recorded. It counts once you seal the changes: oxy seal --proposal {} /{owner} /{name} /proposal/{number} " ,
760
app.config.base_url ( )
761
) )
762
} else {
763
None
764
} ;
765
detail ( & app, shell, & viewer, & owner, & name, number, " conversation" .into ( ) , notice, None ) .await
766
}
767
768
# [ derive ( Deserialize ) ]
769
pub struct EditForm {
770
#[serde(rename = "_csrf")]
771
csrf_token : String,
772
title : String,
773
#[serde(default)]
774
body : String,
775
target : String,
776
}
777
778
pub async fn edit (
779
State( app ) : State< Shared> ,
780
viewer : Viewer,
781
Path( (owner , name , number ) ) : Path< ( String, String, i64 ) > ,
782
Form( f) : Form< EditForm> ,
783
) -> Result< Page< ProposalPage> , Error> {
784
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposal/{number} " ) , & viewer) ;
785
let me = require ( & viewer, & shell) ? ;
786
csrf ( & viewer, & f.csrf_token, & shell) ? ;
787
let ( _ , row, role) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
788
let p = pdb:: get( & app.db, row.id, number)
789
.await
790
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ?
791
.ok_or_else ( | | Error:: not_found( shell.clone ( ) ) ) ? ;
792
if Some ( me.account.id) ! = p.author_id & & role < Role:: Maintain {
793
return Err ( Error:: not_found( shell) ) ;
794
}
795
let target = if crate :: repos:: names:: valid_segment( f.target.trim ( ) ) { f.target.trim ( ) } else { & p.target } ;
796
pdb:: edit( & app.db, p.id, f.title.trim ( ) , f.body.trim ( ) , target) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
797
pdb:: add_event( & app.db, p.id, & me.account.username, " edited" , " " ) .await.ok ( ) ;
798
detail ( & app, shell, & viewer, & owner, & name, number, " conversation" .into ( ) , Some ( " Saved." .into ( ) ) , None ) .await
799
}
800
801
# [ derive ( Deserialize ) ]
802
pub struct StateForm {
803
#[serde(rename = "_csrf")]
804
csrf_token : String,
805
action : String,
806
}
807
808
pub async fn state (
809
State( app ) : State< Shared> ,
810
viewer : Viewer,
811
Path( (owner , name , number ) ) : Path< ( String, String, i64 ) > ,
812
Form( f) : Form< StateForm> ,
813
) -> Result< Page< ProposalPage> , Error> {
814
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposal/{number} " ) , & viewer) ;
815
let me = require ( & viewer, & shell) ? ;
816
csrf ( & viewer, & f.csrf_token, & shell) ? ;
817
let ( _ , row, role) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
818
let p = pdb:: get( & app.db, row.id, number)
819
.await
820
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ?
821
.ok_or_else ( | | Error:: not_found( shell.clone ( ) ) ) ? ;
822
if Some ( me.account.id) ! = p.author_id & & role < Role:: Triage {
823
return Err ( Error:: not_found( shell) ) ;
824
}
825
let new_state = match ( f.action.as_str ( ) , p.state.as_str ( ) ) {
826
( " close" , " open" | " draft" ) => " closed" ,
827
( " reopen" , " closed" ) => " open" ,
828
( " ready" , " draft" ) => " open" ,
829
( " draft" , " open" ) => " draft" ,
830
_ => return Err ( Error:: bad( shell, " that transition is not possible" ) ) ,
831
} ;
832
pdb:: set_state( & app.db, p.id, new_state, " " ) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
833
pdb:: add_event( & app.db, p.id, & me.account.username, new_state, " " ) .await.ok ( ) ;
b64e2537 Andy McCall 1 month ago ↶
834
crate :: hooks:: emit( & app, & row, & format! ( " proposal.{new_state} " ) , & me.account.username, serde_json:: json! ( { " number" : number } ) ) .await;
de505df5 Andy McCall 1 month ago ↶
835
detail ( & app, shell, & viewer, & owner, & name, number, " conversation" .into ( ) , None , None ) .await
836
}
837
838
pub async fn resolve_comment (
839
State( app ) : State< Shared> ,
840
viewer : Viewer,
841
Path( (owner , name , number , id ) ) : Path< ( String, String, i64 , i64 ) > ,
842
Form( f) : Form< super:: session:: CsrfForm> ,
843
) -> Result< Page< ProposalPage> , Error> {
844
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposal/{number} " ) , & viewer) ;
845
require ( & viewer, & shell) ? ;
846
csrf ( & viewer, & f.csrf, & shell) ? ;
847
let ( _ , row, _ ) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
848
let p = pdb:: get( & app.db, row.id, number)
849
.await
850
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ?
851
.ok_or_else ( | | Error:: not_found( shell.clone ( ) ) ) ? ;
852
let current: Option< bool > = sqlx:: query_scalar( " SELECT resolved FROM proposal_comments WHERE id = ? AND proposal_id = ?" )
853
.bind ( id)
854
.bind ( p.id)
855
.fetch_optional ( & app.db)
856
.await
857
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
858
if let Some ( r) = current {
859
pdb:: set_comment_resolved( & app.db, id, ! r) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
860
}
861
detail ( & app, shell, & viewer, & owner, & name, number, " files" .into ( ) , None , None ) .await
862
}
863
864
865
866
pub async fn land (
867
State( app ) : State< Shared> ,
868
viewer : Viewer,
869
Path( (owner , name , number ) ) : Path< ( String, String, i64 ) > ,
870
Form( f) : Form< super:: session:: CsrfForm> ,
871
) -> Result< Page< ProposalPage> , Error> {
872
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposal/{number} " ) , & viewer) ;
873
let me = require ( & viewer, & shell) ? ;
874
csrf ( & viewer, & f.csrf, & shell) ? ;
875
let ( repo, row, _ ) = lookup_role ( & app, & shell, & viewer, & owner, & name, Access:: Write) .await? ;
876
let p = pdb:: get( & app.db, row.id, number)
877
.await
878
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ?
879
.ok_or_else ( | | Error:: not_found( shell.clone ( ) ) ) ? ;
880
let loaded = load ( & app, & repo, p.clone ( ) ) .await.map_err ( | e | Error:: from_repo( shell.clone ( ) , e) ) ? ;
881
let v = verdict ( & app, & loaded, row.id) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
882
if ! p.is_open ( ) | | ! v.blockers.is_empty ( ) {
883
return detail (
884
& app,
885
shell,
886
& viewer,
887
& owner,
888
& name,
889
number,
890
" conversation" .into ( ) ,
891
None ,
892
Some ( format! ( " Cannot land: {} " , v.blockers.join ( " ; " ) ) ) ,
893
)
894
.await;
895
}
896
let target = p.target.clone ( ) ;
897
let heads = loaded.heads.clone ( ) ;
14530604 Andy McCall 1 month ago ↶
898
899
900
901
902
let result = match super :: edit:: signer_for( & app, me.account.id) .await {
903
Ok ( signer) => crate :: repos:: edits:: move_bookmark( & app.repos, & repo, target.clone ( ) , heads.clone ( ) , signer) .await.map ( | _| pl:: state_ref( & heads) .to_hex ( ) ) ,
904
Err ( why) => {
905
app.repos
906
.write ( & repo, move | r, _ | {
907
if r.current_policy ( ) ? .is_some ( ) {
908
return Err ( crate :: repos:: RepoError:: Oxy( oxy_core:: repo:: RepoError:: Msg( format! (
909
" this repository has a trust policy, so the landing must be signed by a key it authorises. Land from a client with oxy proposal land, or delegate to the hub. {why} "
910
) ) ) ) ;
911
}
912
r.bookmark_set ( & target, & heads) ? ;
913
Ok ( pl:: state_ref( & heads) .to_hex ( ) )
914
} )
915
.await
916
}
917
} ;
de505df5 Andy McCall 1 month ago ↶
918
match result {
919
Ok ( state) => {
920
pdb:: set_state( & app.db, p.id, " landed" , & state) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
921
pdb:: add_event( & app.db, p.id, & me.account.username, " landed" , " from the hub" ) .await.ok ( ) ;
b64e2537 Andy McCall 1 month ago ↶
922
crate :: hooks:: emit(
923
& app,
924
& row,
925
" proposal.landed" ,
926
& me.account.username,
927
serde_json:: json! ( { " number" : number, " target" : p.target, " state" : state } ) ,
928
)
929
.await;
18e381ea Andy McCall 1 month ago ↶
930
crate :: notify:: deliver(
931
& app,
932
crate :: notify:: Event {
933
kind: " proposal.landed" ,
934
title: format! ( " {owner} /{name} #{number} : {} landed" , p.title) ,
935
url: format! ( " /{owner} /{name} /proposal/{number} " ) ,
936
actor: & me.account,
937
repo_id: row.id,
938
thread: Some ( ( " proposal" , p.id) ) ,
939
mention_text: " " ,
940
direct: p.author_id.into_iter ( ) .collect ( ) ,
941
} ,
942
)
943
.await;
944
if p.target = = row.default_bookmark {
945
let messages: Vec< ( String, String) > =
946
loaded.changes.iter ( ) .map ( | c | ( c.hash.clone ( ) , format! ( " {} \n {} " , c.title, c.body) ) ) .collect ( ) ;
947
super :: issues:: close_from_messages( & app, & row, & messages) .await;
948
}
de505df5 Andy McCall 1 month ago ↶
949
accounts:: audit( & app.db, Some ( & me.account) , " proposal.landed" , & format! ( " {owner} /{name} #{number} " ) , " " ) .await.ok ( ) ;
950
db:: repos:: record_push(
951
& app.db,
952
row.id,
953
Some ( ( me.account.id, me.account.username.as_str ( ) ) ) ,
954
& [ db:: repos:: PushOutcome {
955
reference: p.target.clone ( ) ,
956
ok: true ,
957
reason: format! ( " landed #{number} " ) ,
958
old_state: loaded.target_state.clone ( ) ,
959
new_state: state,
960
heads: loaded.heads.len ( ) as i64 ,
961
changes: loaded.hashes.len ( ) as i64 ,
962
} ] ,
963
)
964
.await
965
.ok ( ) ;
966
detail ( & app, shell, & viewer, & owner, & name, number, " conversation" .into ( ) , Some ( " Landed." .into ( ) ) , None ) .await
967
}
968
Err ( e) => detail ( & app, shell, & viewer, & owner, & name, number, " conversation" .into ( ) , None , Some ( e.to_string ( ) ) ) .await,
969
}
970
}
971
18e381ea Andy McCall 1 month ago ↶
972
# [ derive ( Deserialize ) ]
973
pub struct LabelsForm {
974
#[serde(rename = "_csrf")]
975
csrf_token : String,
976
#[serde(default)]
977
label : Vec< i64 > ,
978
}
979
980
pub async fn set_labels (
981
State( app ) : State< Shared> ,
982
viewer : Viewer,
983
Path( (owner , name , number ) ) : Path< ( String, String, i64 ) > ,
984
axum_extra:: extract:: Form( f) : axum_extra:: extract:: Form< LabelsForm> ,
985
) -> Result< Page< ProposalPage> , Error> {
986
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposal/{number} " ) , & viewer) ;
987
require ( & viewer, & shell) ? ;
988
csrf ( & viewer, & f.csrf_token, & shell) ? ;
989
let ( _ , row, role) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
990
if role < Role:: Triage {
991
return Err ( Error:: not_found( shell) ) ;
992
}
993
let p = pdb:: get( & app.db, row.id, number)
994
.await
995
.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ?
996
.ok_or_else ( | | Error:: not_found( shell.clone ( ) ) ) ? ;
997
for l in db:: issues:: labels( & app.db, row.id) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? {
998
db:: issues:: set_proposal_label( & app.db, p.id, l.id, f.label.contains ( & l.id) ) .await.map_err ( | e | Error:: from_db( shell.clone ( ) , e) ) ? ;
999
}
1000
detail ( & app, shell, & viewer, & owner, & name, number, " conversation" .into ( ) , None , None ) .await
1001
}
1002
b64e2537 Andy McCall 1 month ago ↶
1003
1004
1005
pub async fn events (
1006
State( app ) : State< Shared> ,
1007
viewer : Viewer,
1008
Path( (owner , name , number ) ) : Path< ( String, String, i64 ) > ,
1009
) -> Result< axum:: response:: Sse< impl futures:: Stream< Item = Result< axum:: response:: sse:: Event, std:: convert:: Infallible> > > , Error> {
1010
use futures:: StreamExt;
1011
let shell = Shell:: new( & app, & format! ( " /{owner} /{name} /proposal/{number} " ) , & viewer) ;
1012
let ( _ , row, _ ) = lookup ( & app, & shell, & viewer, & owner, & name) .await? ;
1013
let rx = app.events.proposals.subscribe ( ) ;
1014
let repo_id = row.id;
1015
let stream = tokio_stream:: wrappers:: BroadcastStream:: new( rx) .filter_map ( move | item| async move {
1016
match item {
1017
Ok ( ( id, ev) ) if id = = repo_id => {
1018
Some ( Ok ( axum:: response:: sse:: Event:: default( ) .event ( ev.kind.clone ( ) ) .data ( serde_json:: to_string( & ev) .unwrap_or_default ( ) ) ) )
1019
}
1020
_ => None ,
1021
}
1022
} ) ;
1023
Ok ( axum:: response:: Sse:: new( stream) .keep_alive ( axum:: response:: sse:: KeepAlive:: default( ) ) )
1024
}
1025
de505df5 Andy McCall 1 month ago ↶
1026
1027
1028
pub async fn to_api ( app : & Shared, owner : & str , name : & str , loaded : & Loaded, v : & Verdict, source_url : Option< String> ) -> hub_api:: Proposal {
1029
let p = & loaded.row;
1030
hub_api:: Proposal {
1031
number: p.number,
1032
title: p.title.clone ( ) ,
1033
body: p.body.clone ( ) ,
1034
author: p.author.clone ( ) ,
1035
state: ProposalState:: parse( & p.state) .unwrap_or ( ProposalState:: Open) ,
1036
target: p.target.clone ( ) ,
1037
source: match p.source_kind.as_str ( ) {
1038
" fork" => {
1039
let ( o, n) = source_url
1040
.as_deref ( )
1041
.and_then ( | u | u.rsplit_once ( ' /' ) )
1042
.and_then ( | ( b , n ) | b.rsplit_once ( ' /' ) .map ( | ( _, o ) | ( o.to_string ( ) , n.to_string ( ) ) ) )
1043
.unwrap_or_default ( ) ;
1044
ProposalSource:: Fork { owner: o, name: n, bookmark: p.source_bookmark.clone ( ) }
1045
}
1046
" changes" => ProposalSource:: Changes { hashes: p.source_changes ( ) } ,
1047
_ => ProposalSource:: Bookmark { bookmark: p.source_bookmark.clone ( ) } ,
1048
} ,
1049
changes: loaded
1050
.changes
1051
.iter ( )
1052
.map ( | c | hub_api:: ChangeSummary {
1053
hash: c.hash.clone ( ) ,
1054
message: if c.body.is_empty ( ) { c.title.clone ( ) } else { format! ( " {} \n \n {} " , c.title, c.body) } ,
1055
author: hub_api:: Author {
1056
name: c.author.name.clone ( ) ,
1057
email: c.author.email.clone ( ) ,
1058
key: c.author.key.clone ( ) ,
1059
account: c.author.account.clone ( ) ,
1060
} ,
1061
when_ms: c.when_ms,
1062
deps: c.deps.clone ( ) ,
1063
head: c.head,
1064
signature: match & c.signature {
1065
view:: SigView:: Unsigned => hub_api:: Signature:: Unsigned,
1066
view:: SigView:: Valid { key, sealed, revoked, .. } => {
1067
hub_api:: Signature:: Valid { key: key.clone ( ) , sealed: * sealed, revoked: * revoked }
1068
}
1069
view:: SigView:: Invalid( why) => hub_api:: Signature:: Invalid { reason: why.clone ( ) } ,
1070
} ,
1071
} )
1072
.collect ( ) ,
1073
projected_heads: loaded.heads.iter ( ) .map ( | h | h.to_hex ( ) ) .collect ( ) ,
1074
projected_state: Some ( loaded.state.clone ( ) ) ,
1075
conflicted: loaded.conflicted,
1076
approvals: v.approvals.clone ( ) ,
1077
landable: p.is_open ( ) & & v.blockers.is_empty ( ) ,
1078
blockers: v.blockers.clone ( ) ,
1079
created_ms: p.created_ms,
1080
updated_ms: p.updated_ms,
1081
url: format! ( " {} /{owner} /{name} /proposal/{} " , app.config.base_url ( ) , p.number) ,
1082
repository_url: format! ( " {} /{owner} /{name} " , app.config.base_url ( ) ) ,
1083
source_url,
1084
}
1085
}
1086
1087
1088
pub fn key ( path : & str , line : impl filters:: Num) -> ( String, usize ) {
1089
( path.to_string ( ) , line.as_u64 ( ) as usize )
1090
}
1091
1092
# [ allow ( dead_code ) ]
1093
fn _unused ( _ : & diff:: Line, _ : & ConflictView, _ : & Role) { }