OXYGENHUB
# 8306eca4e4a3 oxygenhub / crates / hub / tests / api.rs
92.7 KiB · Rust · last changed Your sky over the API: GET /api/v1/user/sky, the dashboard backdrop's data for the Android app; 0.9.11 (refs andymccall/oxygenhub-android#23) 8 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    // The first account's setup code (oxygenhub#245).
46
    config.registration.setup_code = "test-setup".into();
47
    config.auth.push_tokens = vec!["site".into()];
48
    config.registration.mode = "open".into();
49
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
50
    let port = listener.local_addr().unwrap().port();
51
    config.server.base_url = format!("http://127.0.0.1:{port}");
52
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
53
    config.outbound.allow = vec!["http://127.0.0.1".into()];
54
    let app = oxygenhub::build(config).await.unwrap();
55
    let router = oxygenhub::router(app.clone());
56
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
57
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
58
}
59
60
struct Res {
61
    status: StatusCode,
62
    body: String,
63
    cookie: Option<String>,
64
    location: Option<String>,
65
}
66
67
async fn call(
68
    app: &Shared,
69
    method: &str,
70
    path: &str,
71
    bearer: Option<&str>,
72
    cookie: Option<&str>,
73
    json: Option<&str>,
74
    form: Option<&str>,
75
) -> Res {
76
    let mut req = Request::builder().method(method).uri(path);
77
    if let Some(b) = bearer {
78
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
79
    }
80
    if let Some(c) = cookie {
81
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
82
    }
83
    let body = if let Some(j) = json {
84
        req = req.header(header::CONTENT_TYPE, "application/json");
85
        Body::from(j.to_string())
86
    } else if let Some(f) = form {
87
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
88
        Body::from(f.to_string())
89
    } else {
90
        Body::empty()
91
    };
92
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
93
    let status = res.status();
94
    let cookie = res
95
        .headers()
96
        .get(header::SET_COOKIE)
97
        .and_then(|v| v.to_str().ok())
98
        .and_then(|v| v.split(';').next())
99
        .and_then(|kv| kv.split_once('='))
100
        .map(|(_, v)| v.to_string());
101
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
102
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
103
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
104
}
105
106
/// A repository settings form's answer (#278): a redirect to the page that
107
/// holds the form, followed.
108
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
109
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
110
    let to = r.location.expect("a redirect");
111
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
112
    call(app, "GET", &to, None, cookie, None, None).await
113
}
114
115
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
116
    let r = call(app, method, path, bearer, None, json, None).await;
117
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
118
    (r.status, v)
119
}
120
121
fn csrf_of(page: &str) -> String {
122
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
123
    page[i..].split('"').next().unwrap().to_string()
124
}
125
126
/// A webhook receiver that records what it gets and fails the first time.
127
struct Receiver {
128
    url: String,
129
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
130
    fail_first: Arc<Mutex<bool>>,
131
}
132
133
async fn receiver() -> Receiver {
134
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
135
    let fail_first = Arc::new(Mutex::new(true));
136
    let (s2, f2) = (seen.clone(), fail_first.clone());
137
    let router = Router::new().route(
138
        "/hook",
139
        post(move |headers: header::HeaderMap, body: String| {
140
            let (s2, f2) = (s2.clone(), f2.clone());
141
            async move {
142
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
143
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
144
                let mut f = f2.lock().unwrap();
145
                if *f {
146
                    *f = false;
147
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
148
                }
149
                s2.lock().unwrap().push((event, sig, body));
150
                (StatusCode::OK, "ok")
151
            }
152
        }),
153
    );
154
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
155
    let port = listener.local_addr().unwrap().port();
156
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
157
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
158
}
159
160
#[tokio::test(flavor = "multi_thread")]
161
async fn api_webhooks_and_checks() {
162
    let h = hub().await;
163
    let app = &h.app;
164
    // Accounts and tokens through the pages.
165
    let r = call(
166
        app,
167
        "POST",
168
        "/register",
169
        None,
170
        None,
171
        None,
172
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
173
    )
174
    .await;
175
    let andy = r.cookie.unwrap();
176
    let r = call(
177
        app,
178
        "POST",
179
        "/register",
180
        None,
181
        None,
182
        None,
183
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
184
    )
185
    .await;
186
    let bob = r.cookie.unwrap();
187
    let mint = |cookie: String, scopes: &'static str| {
188
        let app = app.clone();
189
        async move {
190
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
191
            let csrf = csrf_of(&page.body);
192
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
193
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
194
        }
195
    };
196
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
197
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
198
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
199
200
    // Create a repository through the API; the read-only token cannot.
201
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
202
    assert_eq!(st, StatusCode::FORBIDDEN);
203
    let (st, v) = api(
204
        app,
205
        "POST",
206
        "/api/v1/repos",
207
        Some(&andy_admin),
208
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
209
    )
210
    .await;
211
    assert_eq!(st, StatusCode::CREATED, "{v}");
212
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
213
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
214
    assert_eq!(st, StatusCode::CONFLICT);
215
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
216
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
217
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
218
    assert_eq!(st, StatusCode::OK);
219
    assert_eq!(v["username"], "andy");
220
221
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
222
    let rx = receiver().await;
223
    let (st, v) = api(
224
        app,
225
        "POST",
226
        "/api/v1/repos/andy/demo/hooks",
227
        Some(&andy_admin),
228
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
229
    )
230
    .await;
231
    assert_eq!(st, StatusCode::CREATED, "{v}");
232
    let work = tempfile::tempdir().unwrap();
233
    let mut client = Repo::init(work.path()).unwrap();
234
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
235
    client.config.set("remote.origin.token", "site").unwrap();
236
    client.save_config().unwrap();
237
    write(work.path(), "a.txt", b"a\n");
238
    client.snapshot("t").unwrap();
239
    let base = client.commit("base", &[]).unwrap();
240
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
241
    // The worker retries with backoff; drive it directly for the retry.
242
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
243
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
244
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
245
    oxygenhub::hooks::deliver_due(app).await;
246
    let seen = rx.seen.lock().unwrap().clone();
247
    assert_eq!(seen.len(), 1, "{seen:?}");
248
    assert_eq!(seen[0].0, "push");
249
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
250
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
251
    assert_eq!(payload["repository"]["name"], "demo");
252
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
253
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
254
    assert_eq!(v.as_array().unwrap().len(), 1);
255
256
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
257
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
258
    assert_eq!(st, StatusCode::OK);
259
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
260
    // A revset in place of the whole history (`?r=`), under a budget; a
261
    // bad one is the caller's problem.
262
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
263
    assert_eq!(st, StatusCode::OK, "{v}");
264
    assert_eq!(v["total"].as_u64(), Some(1));
265
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
266
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
267
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
268
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
269
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
270
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
271
    assert_eq!(v[0]["name"], "a.txt");
272
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
273
    assert_eq!(r.body, "a\n");
274
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
275
    assert_eq!(v[0]["change"], base.to_hex());
276
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
277
    assert_eq!(v["files"][0]["path"], "a.txt");
278
    assert_eq!(v["files"][0]["lines"][0], serde_json::json!({"kind": "add", "new": 1, "text": "a"}), "{v}");
279
    assert_eq!(v["files"][0]["truncated"], false);
280
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
281
    assert!(v["policy"].is_null());
282
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
283
    assert_eq!(v[0]["reference"], "main");
284
285
    // Issues through the API: Bob opens one, comments, and closes it.
286
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
287
    assert_eq!(st, StatusCode::CREATED, "{v}");
288
    assert_eq!(v["number"], 1);
289
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
290
    assert_eq!(st, StatusCode::CREATED);
291
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
292
    assert_eq!(st, StatusCode::OK, "{v}");
293
    assert_eq!(v["state"], "closed");
294
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
295
    assert_eq!(v[0]["comments"], 1);
296
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
297
    assert_eq!(v[0]["number"], 1);
298
299
    // A proposal through the API, then a required check gates its landing.
300
    client.bookmark_create("feat", Some(&[base])).unwrap();
301
    client.bookmark_switch("feat", false).unwrap();
302
    write(work.path(), "b.txt", b"b\n");
303
    write(work.path(), "a.txt", b"a\nA\n");
304
    client.snapshot("t").unwrap();
305
    let feat = client.commit("feat", &[]).unwrap();
306
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
307
    let (st, v) =
308
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
309
            .await;
310
    assert_eq!(st, StatusCode::CREATED, "{v}");
311
    assert_eq!(v["number"], 2);
312
    let state = v["projected_state"].as_str().unwrap().to_string();
313
    assert_eq!(v["landable"], true);
314
    // Its files, and each side's bytes, for editors' diff views.
315
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
316
    assert_eq!(st, StatusCode::OK, "{v}");
317
    let files: Vec<(String, String)> =
318
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
319
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
320
    assert_eq!(v[0]["added"], 1);
321
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
322
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
323
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
324
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
325
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
326
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
327
    // An anchored comment comes back with its line in the projected state.
328
    let (st, v) = api(
329
        app,
330
        "POST",
331
        "/api/v1/repos/andy/demo/proposals/2/comments",
332
        Some(&bob_rw),
333
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
334
    )
335
    .await;
336
    assert_eq!(st, StatusCode::CREATED, "{v}");
337
    assert_eq!(v["line"], 2);
338
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
339
    assert_eq!(v[0]["path"], "a.txt");
340
    assert_eq!(v[0]["line"], 2, "{v}");
341
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
342
    // Require the "build" check.
343
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
344
    let csrf = csrf_of(&settings.body);
345
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
346
        .await;
347
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
348
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
349
    assert_eq!(v["landable"], false);
350
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
351
    // Nothing to land yet for its owner (#311), and the list is only there when asked for.
352
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
353
    assert!(v.get("landable").is_none(), "{v}");
354
    // A checker reports on the projected state: first running, then passed; the page streams it.
355
    let (st, v) = api(
356
        app,
357
        "POST",
358
        "/api/v1/repos/andy/demo/checks",
359
        Some(&andy_ro),
360
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
361
    )
362
    .await;
363
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
364
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
365
    let (st, v) = api(
366
        app,
367
        "POST",
368
        "/api/v1/repos/andy/demo/checks",
369
        Some(&bob_rw),
370
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
371
    )
372
    .await;
373
    assert_eq!(st, StatusCode::CREATED, "{v}");
374
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
375
    assert_eq!(ev.kind, "check");
376
    assert_eq!(ev.check.unwrap().name, "build");
377
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
378
    assert_eq!(v[0]["status"], "passed");
379
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
380
    assert_eq!(v["landable"], true, "{v}");
381
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
382
    assert_eq!((v["landable"][0]["repository"].as_str(), v["landable"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
383
    assert!(api(app, "GET", "/api/v1/user/proposals", Some(&andy_ro), None).await.1.get("landable").is_none(), "only when asked");
384
    // Your sky for the app (oxygenhub-android#23): the dashboard's backdrop data.
385
    let (st, v) = api(app, "GET", "/api/v1/user/sky", Some(&andy_ro), None).await;
386
    assert_eq!(st, StatusCode::OK, "{v}");
387
    let demo = v["repos"].as_array().unwrap().iter().position(|r| r == "andy/demo").expect("andy's repository") as i64;
388
    let events = v["events"].as_array().unwrap();
389
    assert!(events.iter().any(|e| e[0] == demo && e[1] == 0), "a push: {v}");
390
    assert!(events.iter().any(|e| e[0] == demo && e[1] == 1), "a proposal event: {v}");
391
    assert!(events.iter().all(|e| e[2].as_i64().unwrap() <= v["now"].as_i64().unwrap()));
392
    assert_eq!(api(app, "GET", "/api/v1/user/sky", None, None).await.0, StatusCode::UNAUTHORIZED);
393
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
394
    assert!(page.body.contains("42 tests"), "{}", page.body);
395
    // The check and the proposal reached the webhook too.
396
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
397
    oxygenhub::hooks::deliver_due(app).await;
398
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
399
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
400
    let _ = feat;
401
    let _ = rx.fail_first;
402
403
    // The inbox through the API: count, list, mark one read, mark all read.
404
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
405
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
406
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
407
    oxygenhub::db::notify::add(
408
        &app.db,
409
        oxygenhub::db::notify::New {
410
            account_id: bob_id,
411
            repo_id: Some(oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id),
412
            reason: oxygenhub::db::notify::Reason::Participating,
413
            kind: "issue.opened",
414
            title: "andy/demo#1: Bug",
415
            url: "/andy/demo/issue/1",
416
            actor: "andy",
417
        },
418
    )
419
    .await
420
    .unwrap();
421
    oxygenhub::db::notify::add(
422
        &app.db,
423
        oxygenhub::db::notify::New {
424
            account_id: bob_id,
425
            repo_id: None,
426
            reason: oxygenhub::db::notify::Reason::Participating,
427
            kind: "review",
428
            title: "andy/demo#2: Feat",
429
            url: "/andy/demo/proposal/2",
430
            actor: "andy",
431
        },
432
    )
433
    .await
434
    .unwrap();
435
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
436
    assert_eq!(st, StatusCode::OK, "{v}");
437
    assert_eq!(v["unread"], 2);
438
    assert_eq!(v["items"][0]["read"], false);
439
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
440
    // Its repository, why, its thread and the kind's label (#305).
441
    let bug = v["items"].as_array().unwrap().iter().find(|n| n["title"] == "andy/demo#1: Bug").unwrap();
442
    assert_eq!(
443
        (bug["repository"].as_str(), bug["reason"].as_str(), bug["label"].as_str()),
444
        (Some("andy/demo"), Some("participating"), Some("🐛 New Issue")),
445
        "{bug}"
446
    );
447
    assert_eq!(bug["thread"].as_str(), Some(format!("{}/andy/demo/issue/1", h.base).as_str()));
448
    let first = v["items"][0]["id"].as_i64().unwrap();
449
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
450
    assert_eq!(st, StatusCode::NO_CONTENT);
451
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
452
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
453
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
454
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
455
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
456
    // No token at all is 401, so a client knows to sign in (#303).
457
    assert_eq!(api(app, "GET", "/api/v1/notifications", None, None).await.0, StatusCode::UNAUTHORIZED);
458
    assert_eq!(api(app, "GET", "/api/v1/user", None, None).await.0, StatusCode::UNAUTHORIZED);
459
460
    // Review requests: the author asks andy; andy is told, reviews, and the
461
    // request is answered; the author hears of the review.
462
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
463
    let (st, orgs) = api(app, "GET", "/api/v1/user/orgs", Some(&andy_user), None).await;
464
    assert!(st == StatusCode::OK && orgs.is_array(), "the caller's organisations (#302): {orgs}");
465
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
466
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
467
        .await
468
        .unwrap();
469
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
470
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
471
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
472
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
473
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
474
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
475
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
476
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
477
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
478
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
479
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
480
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
481
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
482
    let (st, _) =
483
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
484
    assert_eq!(st, StatusCode::CREATED);
485
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
486
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
487
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
488
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
489
    // Asking again and withdrawing it.
490
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
491
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
492
    assert_eq!(st, StatusCode::NO_CONTENT);
493
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
494
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
495
    // oxygenhub#84: the page's menu sets who is asked, all at once.
496
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
497
    assert!(
498
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
499
        "the reviewers menu lists andy"
500
    );
501
    let csrf = csrf_of(&page.body);
502
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
503
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
504
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
505
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
506
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
507
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
508
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
509
510
    // A source bookmark with `/` in its name, as a feature/N-name workflow
511
    // makes them: by name, and as this repository's owner/name:bookmark.
512
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
513
        client.bookmark_create(b, Some(&[base])).unwrap();
514
        client.bookmark_switch(b, false).unwrap();
515
        write(work.path(), file, b"c\n");
516
        client.snapshot("t").unwrap();
517
        client.commit(b, &[]).unwrap();
518
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
519
    }
520
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
521
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
522
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
523
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
524
        let n = v["number"].as_i64().unwrap();
525
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
526
        assert_eq!(page.status, StatusCode::OK);
527
        assert!(page.body.contains("feature/"), "the page names its source");
528
    }
529
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
530
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
531
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
532
533
    // oxygenhub#76: a proposal's title and description are edited through
534
    // the API by its author or a maintainer; what is not given stays.
535
    let edit = |token: &str, number: i64, body: &str| {
536
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
537
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
538
    };
539
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
540
    assert_eq!(st, StatusCode::OK, "{v}");
541
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
542
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
543
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
544
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
545
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
546
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
547
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
548
    let (st, v) = api(
549
        app,
550
        "POST",
551
        "/api/v1/repos/andy/demo/proposals",
552
        Some(&andy_pw),
553
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
554
    )
555
    .await;
556
    assert_eq!(st, StatusCode::CREATED, "{v}");
557
    let n = v["number"].as_i64().unwrap();
558
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
559
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
560
561
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
562
    // before anything changes, shown in its JSON.
563
    for l in ["ui", "flow"] {
564
        let body = format!(r#"{{"name":"{l}"}}"#);
565
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
566
    }
567
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
568
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
569
    assert_eq!(st, StatusCode::OK, "{v}");
570
    let names = |v: &serde_json::Value| -> Vec<String> {
571
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
572
    };
573
    assert_eq!(names(&v), ["flow", "ui"]);
574
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
575
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
576
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
577
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
578
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
579
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
580
    assert_eq!(names(&v), ["flow"]);
581
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
582
}
583
584
#[tokio::test(flavor = "multi_thread")]
585
async fn api_issue_triage_and_labels() {
586
    let h = hub().await;
587
    let app = &h.app;
588
    let andy = call(
589
        app,
590
        "POST",
591
        "/register",
592
        None,
593
        None,
594
        None,
595
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
596
    )
597
    .await
598
    .cookie
599
    .unwrap();
600
    let bob = call(
601
        app,
602
        "POST",
603
        "/register",
604
        None,
605
        None,
606
        None,
607
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
608
    )
609
    .await
610
    .cookie
611
    .unwrap();
612
    let mint = |cookie: String, scopes: &'static str| {
613
        let app = app.clone();
614
        async move {
615
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
616
            let csrf = csrf_of(&page.body);
617
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
618
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
619
        }
620
    };
621
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
622
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
623
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
624
    assert_eq!(st, StatusCode::CREATED);
625
626
    // Labels through the API; bad colours and non-triage callers are refused.
627
    let (st, v) = api(
628
        app,
629
        "POST",
630
        "/api/v1/repos/andy/demo/labels",
631
        Some(&andy_t),
632
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
633
    )
634
    .await;
635
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
636
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
637
    assert_eq!(
638
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
639
        StatusCode::BAD_REQUEST
640
    );
641
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
642
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
643
    assert_eq!(labels.as_array().unwrap().len(), 2);
644
    // oxygenhub#91: milestones over the API, for triage.
645
    let (st, m) = api(
646
        app,
647
        "POST",
648
        "/api/v1/repos/andy/demo/milestones",
649
        Some(&andy_t),
650
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
651
    )
652
    .await;
653
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
654
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
655
    assert_eq!(
656
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
657
        StatusCode::BAD_REQUEST
658
    );
659
    assert_eq!(
660
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
661
        StatusCode::FORBIDDEN
662
    );
663
    let (st, m) =
664
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
665
            .await;
666
    assert_eq!(
667
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
668
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
669
        "{m}"
670
    );
671
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
672
    assert_eq!(
673
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
674
        StatusCode::NOT_FOUND,
675
        "renamed"
676
    );
677
    assert_eq!(
678
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
679
        StatusCode::BAD_REQUEST
680
    );
681
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
682
    assert_eq!(list.as_array().unwrap().len(), 1);
683
684
    // An issue created with its labels and assignee in one call.
685
    let (st, v) = api(
686
        app,
687
        "POST",
688
        "/api/v1/repos/andy/demo/issues",
689
        Some(&andy_t),
690
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
691
    )
692
    .await;
693
    assert_eq!(st, StatusCode::CREATED, "{v}");
694
    assert_eq!(v["labels"][0]["name"], "bug");
695
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
696
    let n = v["number"].as_i64().unwrap();
697
    // Unknown names are refused before anything is created.
698
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
699
    assert_eq!(st, StatusCode::BAD_REQUEST);
700
    assert!(v["detail"].as_str().unwrap().contains("no label"));
701
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
702
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
703
    // Without triage, labels cannot be set, but a plain issue can be opened.
704
    assert_eq!(
705
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
706
        StatusCode::FORBIDDEN
707
    );
708
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
709
    assert_eq!(st, StatusCode::CREATED);
710
    let bob_n = bobs["number"].as_i64().unwrap();
711
712
    // PATCH: the whole label set, assignees and milestone, with events.
713
    let (st, v) =
714
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
715
            .await;
716
    assert_eq!(st, StatusCode::OK, "{v}");
717
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
718
    assert_eq!(v["assignees"], serde_json::json!([]));
719
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
720
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
721
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
722
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
723
    // The author edits their own title; others cannot; nobody but triage sets labels.
724
    let (st, v) =
725
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
726
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
727
    assert_eq!(
728
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
729
        StatusCode::FORBIDDEN
730
    );
731
    assert_eq!(
732
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
733
        StatusCode::FORBIDDEN
734
    );
735
    assert_eq!(
736
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
737
        StatusCode::BAD_REQUEST
738
    );
739
740
    // Deleting a label takes it off the issues.
741
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
742
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
743
    assert_eq!(v["labels"], serde_json::json!([]));
744
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
745
}
746
747
#[tokio::test(flavor = "multi_thread")]
748
async fn webhook_formats_editing_and_web_issue_events() {
749
    let h = hub().await;
750
    let app = &h.app;
751
    let andy = call(
752
        app,
753
        "POST",
754
        "/register",
755
        None,
756
        None,
757
        None,
758
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
759
    )
760
    .await
761
    .cookie
762
    .unwrap();
763
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
764
    let r = call(
765
        app,
766
        "POST",
767
        "/settings/tokens",
768
        None,
769
        Some(&andy),
770
        None,
771
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
772
    )
773
    .await;
774
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
775
    assert_eq!(
776
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
777
        StatusCode::CREATED
778
    );
779
    let rx = receiver().await;
780
    *rx.fail_first.lock().unwrap() = false;
781
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
782
    let csrf = csrf_of(&settings);
783
    let form = |f: String| {
784
        let andy = andy.clone();
785
        async move {
786
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
787
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
788
        }
789
    };
790
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
791
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
792
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
793
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
794
    {
795
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
796
        let before: i64 =
797
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
798
        for i in 0..MAX_WAITING {
799
            sqlx::query(
800
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
801
            )
802
            .bind(hook.id)
803
            .bind(format!("flood-{i}"))
804
            .execute(&app.db)
805
            .await
806
            .unwrap();
807
        }
808
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
809
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
810
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
811
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
812
        let after: i64 =
813
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
814
        assert_eq!(before, after);
815
    }
816
    assert_eq!(hook.format, "discord");
817
    // Ping arrives as a Discord message.
818
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
819
    let mut got = String::new();
820
    for _ in 0..100 {
821
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
822
            got = body.clone();
823
        }
824
        if !got.is_empty() {
825
            break;
826
        }
827
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
828
    }
829
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
830
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
831
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
832
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
833
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
834
835
    // Editing: a blank URL and secret keep theirs; format, events and active change.
836
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
837
        .await
838
        .contains("Webhook saved"));
839
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
840
    assert_eq!(
841
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
842
        (rx.url.as_str(), "issue", "oxygenhub", true)
843
    );
844
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
845
846
    // An issue opened on the web now reaches the hook, as the signed envelope.
847
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
848
    call(
849
        app,
850
        "POST",
851
        "/andy/demo/issues/new",
852
        None,
853
        Some(&andy),
854
        None,
855
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
856
    )
857
    .await;
858
    let mut envelope = None;
859
    for _ in 0..100 {
860
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
861
        if envelope.is_some() {
862
            break;
863
        }
864
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
865
    }
866
    let (_, sig, body) = envelope.expect("issue.opened delivered");
867
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
868
    assert_eq!(v["data"]["issue"]["title"], "From the web");
869
    assert!(sig.starts_with("blake3-keyed="));
870
    // A disabled hook through the edit form (no active box).
871
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
872
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
873
}
874
875
#[tokio::test(flavor = "multi_thread")]
876
async fn api_projects() {
877
    let h = hub().await;
878
    let app = &h.app;
879
    let andy = call(
880
        app,
881
        "POST",
882
        "/register",
883
        None,
884
        None,
885
        None,
886
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
887
    )
888
    .await
889
    .cookie
890
    .unwrap();
891
    let bob = call(
892
        app,
893
        "POST",
894
        "/register",
895
        None,
896
        None,
897
        None,
898
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
899
    )
900
    .await
901
    .cookie
902
    .unwrap();
903
    let mint = |cookie: String, scopes: &'static str| {
904
        let app = app.clone();
905
        async move {
906
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
907
            let csrf = csrf_of(&page.body);
908
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
909
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
910
        }
911
    };
912
    let a = mint(andy, "scopes=repo%3Aadmin").await;
913
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
914
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
915
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
916
917
    // The caller's own repositories, a page at a time (#302); bob has none.
918
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"zeta","visibility":"private"}"#)).await;
919
    let names =
920
        |v: &serde_json::Value| -> Vec<String> { v.as_array().unwrap().iter().map(|r| r["name"].as_str().unwrap().to_string()).collect() };
921
    let (st, v) = api(app, "GET", "/api/v1/user/repos", Some(&a), None).await;
922
    assert_eq!((st, names(&v)), (StatusCode::OK, vec!["demo".to_string(), "zeta".to_string()]), "{v}");
923
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?limit=1", Some(&a), None).await.1), ["demo"]);
924
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?after=andy/demo", Some(&a), None).await.1), ["zeta"]);
925
    assert!(names(&api(app, "GET", "/api/v1/user/repos", Some(&b), None).await.1).is_empty(), "not bob's");
926
    assert_eq!(api(app, "GET", "/api/v1/user/repos?affiliation=friend", Some(&a), None).await.0, StatusCode::BAD_REQUEST);
927
    assert_eq!(api(app, "GET", "/api/v1/user/repos", None, None).await.0, StatusCode::UNAUTHORIZED);
928
    // The proposals to act on, as the dashboard lists them: bob's in andy's
929
    // repository is andy's to review and bob's own.
930
    let demo = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
931
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
932
    oxygenhub::db::proposals::create(
933
        &app.db,
934
        oxygenhub::db::proposals::NewProposal {
935
            repo_id: demo.id,
936
            title: "Faster startup",
937
            body: "",
938
            author_id: Some(bob_id),
939
            author: "bob",
940
            draft: false,
941
            target: "main",
942
            source_kind: "bookmark",
943
            source_repo_id: Some(demo.id),
944
            source_bookmark: "fast",
945
            source_changes: "",
946
        },
947
    )
948
    .await
949
    .unwrap();
950
    let (st, v) = api(app, "GET", "/api/v1/user/proposals", Some(&a), None).await;
951
    assert_eq!(st, StatusCode::OK, "{v}");
952
    assert_eq!((v["review"][0]["repository"].as_str(), v["review"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
953
    assert_eq!(v["review"][0]["state"], "open");
954
    assert!(v["review"][0]["url"].as_str().unwrap().ends_with("/andy/demo/proposal/2"));
955
    assert_eq!(v["authored"].as_array().map(Vec::len), Some(0));
956
    let (_, v) = api(app, "GET", "/api/v1/user/proposals", Some(&b), None).await;
957
    assert_eq!((v["review"].as_array().map(Vec::len), v["authored"][0]["title"].as_str()), (Some(0), Some("Faster startup")), "{v}");
958
    assert_eq!(api(app, "GET", "/api/v1/user/proposals", None, None).await.0, StatusCode::UNAUTHORIZED);
959
960
    // Organisations need user:read, which this token lacks.
961
    assert_eq!(api(app, "GET", "/api/v1/user/orgs", Some(&a), None).await.0, StatusCode::FORBIDDEN);
962
963
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
964
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
965
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
966
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
967
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
968
969
    // Cards by reference, into a column by name, and a note into the first column.
970
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
971
    assert_eq!(st, StatusCode::CREATED, "{card}");
972
    assert_eq!(
973
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
974
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
975
    );
976
    assert_eq!((card["labels"].as_array().map(Vec::len), card["assignees"].as_array().map(Vec::len)), (Some(0), Some(0)), "{card}");
977
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
978
    assert_eq!(st, StatusCode::BAD_REQUEST);
979
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
980
    assert_eq!(
981
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
982
        StatusCode::BAD_REQUEST
983
    );
984
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
985
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
986
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
987
988
    // Move and read the board.
989
    let id = card["id"].as_i64().unwrap();
990
    assert_eq!(
991
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
992
        StatusCode::NO_CONTENT
993
    );
994
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
995
    let names: Vec<(&str, usize)> =
996
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
997
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
998
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
999
    // The cards by column (#115), and a wrong method answers with a body.
1000
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
1001
    assert_eq!(st, StatusCode::OK);
1002
    assert_eq!(cols, board["columns"]);
1003
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
1004
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
1005
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
1006
1007
    // A column's cards at once (#289): with exceptions, a state filter and
1008
    // a dry run; one audit entry.
1009
    for t in ["Second", "Third"] {
1010
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(&format!(r#"{{"title":"{t}"}}"#))).await;
1011
    }
1012
    for n in [2, 3] {
1013
        let body = format!(r#"{{"reference":"demo#{n}","column":"Doing"}}"#);
1014
        assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(&body)).await.0, StatusCode::CREATED);
1015
    }
1016
    let bulk = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&a), Some(body));
1017
    let refs = |v: &serde_json::Value, k: &str| -> Vec<String> {
1018
        v[k].as_array().unwrap().iter().map(|c| c["reference"].as_str().unwrap().to_string()).collect()
1019
    };
1020
    let (st, v) = bulk(r##"{"from":"Doing","column":"Done","except":["#2"],"dry_run":true}"##).await;
1021
    assert_eq!(st, StatusCode::OK, "{v}");
1022
    assert_eq!((refs(&v, "moved"), refs(&v, "kept")), (vec!["andy/demo#3".to_string()], vec!["andy/demo#2".to_string()]));
1023
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1024
    assert_eq!(board["columns"][1]["cards"].as_array().unwrap().len(), 2, "a dry run moves nothing");
1025
    let (_, v) = bulk(r#"{"from":"Doing","column":"Done","state":["closed"]}"#).await;
1026
    assert!(refs(&v, "moved").is_empty(), "both are open: {v}");
1027
    let (_, v) = bulk(r#"{"from":"doing","column":"done","except":["demo#2"]}"#).await;
1028
    assert_eq!(refs(&v, "moved"), ["andy/demo#3"]);
1029
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1030
    let names: Vec<(&str, usize)> =
1031
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1032
    assert_eq!(names, [("Backlog", 1), ("Doing", 1), ("Done", 2)]);
1033
    let audited: i64 =
1034
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_moved'").fetch_one(&app.db).await.unwrap();
1035
    assert_eq!(audited, 1, "the dry run and the empty move are not audited");
1036
    assert_eq!(bulk(r#"{"from":"Done","column":"Done"}"#).await.0, StatusCode::BAD_REQUEST);
1037
    assert_eq!(
1038
        api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&b), Some(r#"{"from":"Doing","column":"Done"}"#)).await.0,
1039
        StatusCode::FORBIDDEN
1040
    );
1041
1042
    // Archive (#293): Done's cards there more than a week (#3, made old),
1043
    // listed with ?archived=true, restored once.
1044
    sqlx::query("UPDATE project_cards SET moved_ms = 0 WHERE number = 3").execute(&app.db).await.unwrap();
1045
    let archive = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/archive", Some(&a), Some(body));
1046
    let (st, v) = archive(r#"{"from":"Done","older_days":7,"dry_run":true}"#).await;
1047
    assert_eq!((st, refs(&v, "archived")), (StatusCode::OK, vec!["andy/demo#3".to_string()]), "{v}");
1048
    assert!(v["archived"][0].get("archived_ms").is_none(), "a dry run archives nothing: {v}");
1049
    let (_, v) = archive(r#"{"from":"Done","older_days":7}"#).await;
1050
    assert_eq!((refs(&v, "archived"), refs(&v, "kept").len()), (vec!["andy/demo#3".to_string()], 1), "{v}");
1051
    assert!(v["archived"][0]["archived_ms"].as_i64().is_some());
1052
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1053
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 1, "off the board: {board}");
1054
    let (st, archived) = api(app, "GET", "/api/v1/projects/andy/1/cards?archived=true", None, None).await;
1055
    assert_eq!((st, archived[2]["cards"][0]["reference"].as_str()), (StatusCode::OK, Some("andy/demo#3")), "{archived}");
1056
    let card = archived[2]["cards"][0]["id"].as_i64().unwrap();
1057
    let restore = format!("/api/v1/projects/andy/1/cards/{card}/restore");
1058
    assert_eq!(api(app, "POST", &restore, Some(&b), None).await.0, StatusCode::FORBIDDEN);
1059
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NO_CONTENT);
1060
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NOT_FOUND, "not archived now");
1061
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1062
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 2);
1063
    assert_eq!(archive(r#"{"from":"Done","older_days":-1}"#).await.0, StatusCode::BAD_REQUEST);
1064
    let audited: i64 =
1065
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_archived'").fetch_one(&app.db).await.unwrap();
1066
    assert_eq!(audited, 1);
1067
1068
    // Private: hidden from others; closed: read-only; then remove a card.
1069
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
1070
    assert_eq!(edited["public"], false);
1071
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
1072
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
1073
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
1074
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
1075
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
1076
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
1077
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
1078
}
1079
1080
#[tokio::test(flavor = "multi_thread")]
1081
async fn api_required_checks() {
1082
    let h = hub().await;
1083
    let app = &h.app;
1084
    let andy = call(
1085
        app,
1086
        "POST",
1087
        "/register",
1088
        None,
1089
        None,
1090
        None,
1091
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1092
    )
1093
    .await
1094
    .cookie
1095
    .unwrap();
1096
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1097
    let csrf = csrf_of(&page.body);
1098
    let mint = |scopes: &'static str| {
1099
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1100
        async move {
1101
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1102
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1103
        }
1104
    };
1105
    let admin = mint("scopes=repo%3Aadmin").await;
1106
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1107
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1108
1109
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1110
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1111
    let (st, v) = api(
1112
        app,
1113
        "PUT",
1114
        "/api/v1/repos/andy/demo/checks/required",
1115
        Some(&admin),
1116
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1117
    )
1118
    .await;
1119
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1120
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1121
    assert_eq!(
1122
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1123
        serde_json::json!(["flow/fmt", "flow/test"])
1124
    );
1125
    assert_eq!(
1126
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1127
        StatusCode::FORBIDDEN,
1128
        "repo:admin only"
1129
    );
1130
    assert_eq!(
1131
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1132
        StatusCode::BAD_REQUEST
1133
    );
1134
    // The settings page shows the same list.
1135
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
1136
}
1137
1138
/// OxygenFlow per repository: site administrators turn it on or off in
1139
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1140
#[tokio::test(flavor = "multi_thread")]
1141
async fn flow_is_switched_per_repository_by_site_admins() {
1142
    let h = hub().await;
1143
    let app = &h.app;
1144
    let andy = call(
1145
        app,
1146
        "POST",
1147
        "/register",
1148
        None,
1149
        None,
1150
        None,
1151
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1152
    )
1153
    .await
1154
    .cookie
1155
    .unwrap();
1156
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1157
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1158
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1159
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1160
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
1161
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
1162
1163
    let set = |value: &'static str| {
1164
        let (app, andy) = (app.clone(), andy.clone());
1165
        async move {
1166
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1167
            let r = call(
1168
                &app,
1169
                "POST",
1170
                "/andy/demo/settings/flow",
1171
                None,
1172
                Some(&andy),
1173
                None,
1174
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1175
            )
1176
            .await;
1177
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
1178
        }
1179
    };
1180
    // A repository admin who is not a site admin sees the state but cannot change it.
1181
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1182
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
1183
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1184
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1185
    let r = set("on").await;
1186
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1187
    assert_eq!(row().await.flow, "");
1188
1189
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1190
    let r = set("on").await;
1191
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1192
    assert_eq!(row().await.flow, "on");
1193
    assert!(oxygenhub::flow::enabled(app, &row().await));
1194
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1195
    set("off").await;
1196
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1197
    set("default").await;
1198
    assert_eq!(row().await.flow, "");
1199
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
1200
}
1201
1202
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1203
/// button, never the repository's default bookmark as the hub sets it.
1204
#[tokio::test(flavor = "multi_thread")]
1205
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1206
    let h = hub().await;
1207
    let app = &h.app;
1208
    let andy = call(
1209
        app,
1210
        "POST",
1211
        "/register",
1212
        None,
1213
        None,
1214
        None,
1215
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1216
    )
1217
    .await
1218
    .cookie
1219
    .unwrap();
1220
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1221
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1222
    let url = format!("{}/andy/demo", h.base);
1223
    let work = tempfile::tempdir().unwrap();
1224
    let (w, u) = (work.path().to_path_buf(), url.clone());
1225
    let client = tokio::task::spawn_blocking(move || {
1226
        let mut c = Repo::init(&w).unwrap();
1227
        c.config.set("remote.origin.url", &u).unwrap();
1228
        c.config.set("remote.origin.token", "site").unwrap();
1229
        c.save_config().unwrap();
1230
        write(&w, "a.txt", b"a\n");
1231
        c.commit("a", &[]).unwrap();
1232
        assert!(c.push("origin", false).unwrap()[0].ok);
1233
        for b in ["develop", "feature/x", "stray"] {
1234
            c.bookmark_create(b, None).unwrap();
1235
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1236
        }
1237
        // A pushed deletion.
1238
        let r = c.push_delete("origin", "feature/x").unwrap();
1239
        assert!(r[0].ok, "{r:?}");
1240
        c
1241
    })
1242
    .await
1243
    .unwrap();
1244
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1245
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1246
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1247
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1248
    assert!(!anon.body.contains("/bookmarks/delete"));
1249
1250
    // The hub's default, not the repository's config, is protected: make
1251
    // develop the default, then main can go and develop cannot.
1252
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1253
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1254
    let client = tokio::task::spawn_blocking(move || {
1255
        let r = client.push_delete("origin", "develop").unwrap();
1256
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1257
        let r = client.push_delete("origin", "main").unwrap();
1258
        assert!(r[0].ok, "{r:?}");
1259
        client
1260
    })
1261
    .await
1262
    .unwrap();
1263
    drop(client);
1264
1265
    // On the web: a writer deletes stray; the default is refused.
1266
    let form = |b: &'static str| {
1267
        let (app, andy) = (app.clone(), andy.clone());
1268
        async move {
1269
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1270
            call(
1271
                &app,
1272
                "POST",
1273
                "/andy/demo/bookmarks/delete",
1274
                None,
1275
                Some(&andy),
1276
                None,
1277
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1278
            )
1279
            .await
1280
        }
1281
    };
1282
    let r = form("stray").await;
1283
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1284
    assert!(!r.body.contains(">stray<"));
1285
    let r = form("develop").await;
1286
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1287
    let r = form("nope").await;
1288
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1289
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1290
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1291
    // Anonymous visitors cannot.
1292
    assert_ne!(
1293
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1294
        StatusCode::OK
1295
    );
1296
}
1297
1298
/// A change signed by a key no account has linked says so, on its page
1299
/// and in the API (feedback 14).
1300
#[tokio::test(flavor = "multi_thread")]
1301
async fn changes_signed_by_unlinked_keys_say_so() {
1302
    let h = hub().await;
1303
    let app = &h.app;
1304
    let andy = call(
1305
        app,
1306
        "POST",
1307
        "/register",
1308
        None,
1309
        None,
1310
        None,
1311
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1312
    )
1313
    .await
1314
    .cookie
1315
    .unwrap();
1316
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1317
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1318
    let url = format!("{}/andy/demo", h.base);
1319
    let work = tempfile::tempdir().unwrap();
1320
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1321
    let hash = tokio::task::spawn_blocking(move || {
1322
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1323
        c.config.set("remote.origin.url", &u).unwrap();
1324
        c.config.set("remote.origin.token", "site").unwrap();
1325
        c.save_config().unwrap();
1326
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1327
        write(&w.join("r"), "a.txt", b"a\n");
1328
        let h = c.commit("signed by Ada", &[]).unwrap();
1329
        assert!(c.push("origin", false).unwrap()[0].ok);
1330
        h.to_hex()
1331
    })
1332
    .await
1333
    .unwrap();
1334
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1335
    assert_eq!(st, StatusCode::OK, "{v}");
1336
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1337
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1338
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1339
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1340
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1341
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1342
}
1343
1344
/// Function history (hub spec §6.6): the file page lists a file's
1345
/// functions, and a function's page lists exactly the changes to its lines.
1346
#[tokio::test(flavor = "multi_thread")]
1347
async fn a_function_has_its_own_history() {
1348
    let h = hub().await;
1349
    let app = &h.app;
1350
    let andy = call(
1351
        app,
1352
        "POST",
1353
        "/register",
1354
        None,
1355
        None,
1356
        None,
1357
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1358
    )
1359
    .await
1360
    .cookie
1361
    .unwrap();
1362
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1363
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1364
    let url = format!("{}/andy/demo", h.base);
1365
    let work = tempfile::tempdir().unwrap();
1366
    let w = work.path().to_path_buf();
1367
    tokio::task::spawn_blocking(move || {
1368
        let mut c = Repo::init(&w).unwrap();
1369
        c.config.set("remote.origin.url", &url).unwrap();
1370
        c.config.set("remote.origin.token", "site").unwrap();
1371
        c.save_config().unwrap();
1372
        let steps = [
1373
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1374
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1375
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1376
        ];
1377
        for (msg, text) in steps {
1378
            write(&w, "src/lib.rs", text.as_bytes());
1379
            c.commit(msg, &[]).unwrap();
1380
        }
1381
        assert!(c.push("origin", false).unwrap()[0].ok);
1382
    })
1383
    .await
1384
    .unwrap();
1385
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1386
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1387
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1388
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1389
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1390
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1391
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1392
    assert_ne!(bad.status, StatusCode::OK);
1393
}
1394
1395
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1396
/// dependency edges, linked cards.
1397
#[tokio::test(flavor = "multi_thread")]
1398
async fn a_bookmark_shows_as_swimlanes() {
1399
    let h = hub().await;
1400
    let app = &h.app;
1401
    let andy = call(
1402
        app,
1403
        "POST",
1404
        "/register",
1405
        None,
1406
        None,
1407
        None,
1408
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1409
    )
1410
    .await
1411
    .cookie
1412
    .unwrap();
1413
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1414
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1415
    let url = format!("{}/andy/demo", h.base);
1416
    let work = tempfile::tempdir().unwrap();
1417
    let w = work.path().to_path_buf();
1418
    tokio::task::spawn_blocking(move || {
1419
        let mut c = Repo::init(&w).unwrap();
1420
        c.config.set("remote.origin.url", &url).unwrap();
1421
        c.config.set("remote.origin.token", "site").unwrap();
1422
        c.save_config().unwrap();
1423
        // Two files edited independently: two lanes.
1424
        write(&w, "a.txt", b"a\n");
1425
        c.commit("add a", &[]).unwrap();
1426
        write(&w, "b.txt", b"b\n");
1427
        c.commit("add b", &[]).unwrap();
1428
        write(&w, "a.txt", b"a\na2\n");
1429
        c.commit("grow a", &[]).unwrap();
1430
        assert!(c.push("origin", false).unwrap()[0].ok);
1431
    })
1432
    .await
1433
    .unwrap();
1434
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1435
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1436
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1437
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1438
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1439
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1440
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1441
    assert_eq!(board.matches("<rect ").count(), 3);
1442
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1443
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1444
}
1445
1446
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1447
/// offers only what makes sense and rewrites nothing itself.
1448
#[tokio::test(flavor = "multi_thread")]
1449
async fn a_proposal_board_plans_squashes_and_rebases() {
1450
    let h = hub().await;
1451
    let app = &h.app;
1452
    let andy = call(
1453
        app,
1454
        "POST",
1455
        "/register",
1456
        None,
1457
        None,
1458
        None,
1459
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1460
    )
1461
    .await
1462
    .cookie
1463
    .unwrap();
1464
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1465
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1466
    let url = format!("{}/andy/demo", h.base);
1467
    let work = tempfile::tempdir().unwrap();
1468
    let w = work.path().to_path_buf();
1469
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1470
        let mut c = Repo::init(&w).unwrap();
1471
        c.config.set("remote.origin.url", &url).unwrap();
1472
        c.config.set("remote.origin.token", "site").unwrap();
1473
        c.save_config().unwrap();
1474
        write(&w, "a.txt", b"a\n");
1475
        let base = c.commit("base", &[]).unwrap();
1476
        assert!(c.push("origin", false).unwrap()[0].ok);
1477
        c.bookmark_create("feature", None).unwrap();
1478
        c.bookmark_switch("feature", false).unwrap();
1479
        write(&w, "a.txt", b"a\nfirst\n");
1480
        let first = c.commit("first", &[]).unwrap();
1481
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1482
        let second = c.commit("second", &[]).unwrap();
1483
        write(&w, "b.txt", b"apart\n");
1484
        let apart = c.commit("apart", &[]).unwrap();
1485
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1486
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1487
    })
1488
    .await
1489
    .unwrap();
1490
    // No proposal yet: the board is read-only.
1491
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1492
    assert!(!board.contains("data-plan="));
1493
    let (st, _) = api(
1494
        app,
1495
        "POST",
1496
        "/api/v1/repos/andy/demo/proposals",
1497
        Some("site"),
1498
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1499
    )
1500
    .await;
1501
    assert!(st.is_success(), "{st}");
1502
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1503
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1504
    let csrf = csrf_of(&board);
1505
    let plan = |c: &str, t: &str| {
1506
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1507
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1508
        async move {
1509
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1510
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1511
        }
1512
    };
1513
    let kinds = |v: &serde_json::Value| {
1514
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1515
    };
1516
    // second already depends on first: squash, no rebase.
1517
    let v = plan(&second, &first).await;
1518
    assert_eq!(kinds(&v), ["squash"], "{v}");
1519
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1520
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
1521
    // apart is independent of second: either.
1522
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1523
    // first under second: nothing (second depends on first).
1524
    assert!(plan(&first, &second).await["error"].is_string());
1525
    // What has landed on main is not rearranged.
1526
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1527
}
1528
1529
/// Issues and proposals share a number space, so every number says what it
1530
/// is, and the chain of work shows from both ends (hub spec §8).
1531
#[tokio::test(flavor = "multi_thread")]
1532
async fn proposals_and_issues_show_their_chain() {
1533
    let h = hub().await;
1534
    let app = &h.app;
1535
    let andy = call(
1536
        app,
1537
        "POST",
1538
        "/register",
1539
        None,
1540
        None,
1541
        None,
1542
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1543
    )
1544
    .await
1545
    .cookie
1546
    .unwrap();
1547
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1548
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1549
    let url = format!("{}/andy/demo", h.base);
1550
    let work = tempfile::tempdir().unwrap();
1551
    let w = work.path().to_path_buf();
1552
    tokio::task::spawn_blocking(move || {
1553
        let mut c = Repo::init(&w).unwrap();
1554
        c.config.set("remote.origin.url", &url).unwrap();
1555
        c.config.set("remote.origin.token", "site").unwrap();
1556
        c.save_config().unwrap();
1557
        write(&w, "a.txt", b"a\n");
1558
        c.commit("base", &[]).unwrap();
1559
        assert!(c.push("origin", false).unwrap()[0].ok);
1560
        c.bookmark_create("feature", None).unwrap();
1561
        c.bookmark_switch("feature", false).unwrap();
1562
        write(&w, "a.txt", b"a\nfixed\n");
1563
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1564
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1565
    })
1566
    .await
1567
    .unwrap();
1568
    for title in ["Slow start", "Crash on save"] {
1569
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1570
        assert!(st.is_success());
1571
    }
1572
    let (st, v) = api(
1573
        app,
1574
        "POST",
1575
        "/api/v1/repos/andy/demo/proposals",
1576
        Some("site"),
1577
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1578
    )
1579
    .await;
1580
    assert!(st.is_success(), "{st} {v}");
1581
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1582
1583
    // The proposal names its kind, links its references by kind, and shows
1584
    // the chain: the issues it closes (description and changes) → it → main.
1585
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1586
    assert!(p.contains(">proposal #3</small>"), "header");
1587
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1588
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1589
    let chain = &chain[..chain.find("</p>").unwrap()];
1590
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1591
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1592
    }
1593
    assert!(p.contains("<h3>Closes</h3>"));
1594
1595
    // The issue shows the proposal that closes it, and names its own kind.
1596
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1597
    assert!(i.contains(">issue #1</small>"));
1598
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1599
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1600
    // The conversation is a timeline with avatars; editing sits with the
1601
    // content, not in the sidebar, and labels and projects are editable.
1602
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1603
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1604
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1605
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1606
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1607
    assert!(st.is_success(), "{st}");
1608
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1609
    assert!(
1610
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1611
        "the owner's projects to add to, in a menu"
1612
    );
1613
    let csrf = csrf_of(&p);
1614
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1615
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1616
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1617
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1618
        .await;
1619
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1620
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1621
1622
    // Closed by the proposal's change, not its description: still shown.
1623
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1624
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1625
    assert!(chain.contains("proposal #3"), "{chain}");
1626
}
1627
1628
/// What the hub is: its version and build, and the libraries it is built on,
1629
/// on /about, in the API and in /health (hub spec §15).
1630
#[tokio::test(flavor = "multi_thread")]
1631
async fn the_hub_says_what_version_it_is() {
1632
    let h = hub().await;
1633
    let app = &h.app;
1634
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1635
    assert_eq!(st, StatusCode::OK);
1636
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1637
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1638
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1639
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1640
    assert!(health.contains("\"build\""), "{health}");
1641
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1642
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
1643
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1644
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1645
    assert!(about.contains("href=\"/about\""), "the footer links here");
1646
}
1647
1648
#[tokio::test(flavor = "multi_thread")]
1649
async fn device_sign_in() {
1650
    let h = hub().await;
1651
    let app = &h.app;
1652
    let r = call(
1653
        app,
1654
        "POST",
1655
        "/register",
1656
        None,
1657
        None,
1658
        None,
1659
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1660
    )
1661
    .await;
1662
    let andy = r.cookie.unwrap();
1663
1664
    // An unknown scope is refused.
1665
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1666
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1667
1668
    // The app asks for a code and polls; nobody has approved it yet.
1669
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1670
    assert_eq!(st, StatusCode::OK, "{v}");
1671
    let device = v["device_code"].as_str().unwrap().to_string();
1672
    let user = v["user_code"].as_str().unwrap().to_string();
1673
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1674
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1675
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1676
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1677
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1678
    assert_eq!(v["error"], "slow_down", "polled too soon");
1679
1680
    // The user approves it on the web, allowing less than it asked for.
1681
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1682
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1683
    let csrf = csrf_of(&page.body);
1684
    let r =
1685
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1686
            .await;
1687
    // oxygenhub#83: the answer page says it is done, with no code form.
1688
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1689
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1690
1691
    // The next poll gets a token with what was allowed, once.
1692
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1693
    assert_eq!(st, StatusCode::OK, "{v}");
1694
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1695
    let token = v["access_token"].as_str().unwrap().to_string();
1696
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1697
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1698
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1699
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1700
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1701
    assert!(tokens.body.contains("device: Phone app"));
1702
    // oxygenhub#70: a device's token expires, and each use renews it.
1703
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1704
1705
    // The token can revoke itself (oxy auth logout), and is then refused.
1706
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1707
    assert_eq!(st, StatusCode::NO_CONTENT);
1708
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1709
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1710
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1711
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1712
1713
    // A denied code says so.
1714
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1715
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1716
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1717
    let csrf = csrf_of(&page.body);
1718
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1719
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1720
    assert_eq!(v["error"], "access_denied");
1721
1722
    // A code the app gave up on (#304) is gone at once: the page no longer
1723
    // takes it, and the app's poll says so.
1724
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Cancelled"}"#)).await;
1725
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1726
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1727
    assert_eq!(st, StatusCode::NO_CONTENT);
1728
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1729
    let csrf = csrf_of(&page.body);
1730
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve"))).await;
1731
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1732
    assert_eq!(v["error"], "expired_token", "{v}");
1733
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1734
    assert_eq!(st, StatusCode::NO_CONTENT, "again: still fine");
1735
1736
    // Signed out, the page asks for a sign-in first.
1737
    let r = call(app, "GET", "/device", None, None, None, None).await;
1738
    assert!(r.status.is_redirection(), "{}", r.status);
1739
}
1740
1741
#[tokio::test(flavor = "multi_thread")]
1742
async fn api_assistants_at_each_level() {
1743
    let h = hub().await;
1744
    let app = &h.app;
1745
    let andy = call(
1746
        app,
1747
        "POST",
1748
        "/register",
1749
        None,
1750
        None,
1751
        None,
1752
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1753
    )
1754
    .await
1755
    .cookie
1756
    .unwrap();
1757
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1758
    let csrf = csrf_of(&page.body);
1759
    let mint = |scopes: &'static str| {
1760
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1761
        async move {
1762
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1763
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1764
        }
1765
    };
1766
    let admin = mint("scopes=repo%3Aadmin").await;
1767
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1768
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1769
    // A stand-in endpoint with no model list: any model name is taken.
1770
    let router = axum::Router::new().route(
1771
        "/v1/chat/completions",
1772
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1773
    );
1774
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1775
    let port = listener.local_addr().unwrap().port();
1776
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1777
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1778
1779
    // The site's, by its administrator; the repository's, by its admin.
1780
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1781
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1782
    assert_eq!(st, StatusCode::OK, "{v}");
1783
    assert_eq!(v["ok"], "Gemini added");
1784
    let body =
1785
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1786
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1787
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1788
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1789
    assert_eq!(st, StatusCode::OK, "{v}");
1790
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1791
    assert_eq!(st, StatusCode::OK);
1792
    let names: Vec<(&str, &str, bool)> = v
1793
        .as_array()
1794
        .unwrap()
1795
        .iter()
1796
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1797
        .collect();
1798
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1799
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1800
    // Changing it keeps the token when none is given.
1801
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1802
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1803
    assert_eq!(v["ok"], "Claude updated");
1804
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1805
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1806
    // Prompts: the site's is inherited by the repository.
1807
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1808
    assert_eq!(st, StatusCode::OK);
1809
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1810
    assert_eq!(v["prompt"], "Rust.");
1811
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1812
    // Removed.
1813
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1814
    assert_eq!(st, StatusCode::NO_CONTENT);
1815
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1816
    assert_eq!(st, StatusCode::NOT_FOUND);
1817
}