OXYGENHUB
# 8e820b4ae875 oxygenhub / crates / hub / tests / api.rs
63.3 KiB · Rust · last changed Device tokens expire and renew on use; the approval page shows the requester (closes #70) 1 month ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    let app = oxygenhub::build(config).await.unwrap();
51
    let router = oxygenhub::router(app.clone());
52
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
53
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
54
}
55
56
struct Res {
57
    status: StatusCode,
58
    body: String,
59
    cookie: Option<String>,
60
}
61
62
async fn call(
63
    app: &Shared,
64
    method: &str,
65
    path: &str,
66
    bearer: Option<&str>,
67
    cookie: Option<&str>,
68
    json: Option<&str>,
69
    form: Option<&str>,
70
) -> Res {
71
    let mut req = Request::builder().method(method).uri(path);
72
    if let Some(b) = bearer {
73
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
74
    }
75
    if let Some(c) = cookie {
76
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
77
    }
78
    let body = if let Some(j) = json {
79
        req = req.header(header::CONTENT_TYPE, "application/json");
80
        Body::from(j.to_string())
81
    } else if let Some(f) = form {
82
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
83
        Body::from(f.to_string())
84
    } else {
85
        Body::empty()
86
    };
87
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
88
    let status = res.status();
89
    let cookie = res
90
        .headers()
91
        .get(header::SET_COOKIE)
92
        .and_then(|v| v.to_str().ok())
93
        .and_then(|v| v.split(';').next())
94
        .and_then(|kv| kv.split_once('='))
95
        .map(|(_, v)| v.to_string());
96
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
97
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
98
}
99
100
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
101
    let r = call(app, method, path, bearer, None, json, None).await;
102
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
103
    (r.status, v)
104
}
105
106
fn csrf_of(page: &str) -> String {
107
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
108
    page[i..].split('"').next().unwrap().to_string()
109
}
110
111
/// A webhook receiver that records what it gets and fails the first time.
112
struct Receiver {
113
    url: String,
114
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
115
    fail_first: Arc<Mutex<bool>>,
116
}
117
118
async fn receiver() -> Receiver {
119
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
120
    let fail_first = Arc::new(Mutex::new(true));
121
    let (s2, f2) = (seen.clone(), fail_first.clone());
122
    let router = Router::new().route(
123
        "/hook",
124
        post(move |headers: header::HeaderMap, body: String| {
125
            let (s2, f2) = (s2.clone(), f2.clone());
126
            async move {
127
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
128
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
129
                let mut f = f2.lock().unwrap();
130
                if *f {
131
                    *f = false;
132
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
133
                }
134
                s2.lock().unwrap().push((event, sig, body));
135
                (StatusCode::OK, "ok")
136
            }
137
        }),
138
    );
139
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
140
    let port = listener.local_addr().unwrap().port();
141
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
142
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
143
}
144
145
#[tokio::test(flavor = "multi_thread")]
146
async fn api_webhooks_and_checks() {
147
    let h = hub().await;
148
    let app = &h.app;
149
    // Accounts and tokens through the pages.
150
    let r =
151
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
152
    let andy = r.cookie.unwrap();
153
    let r =
154
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
155
    let bob = r.cookie.unwrap();
156
    let mint = |cookie: String, scopes: &'static str| {
157
        let app = app.clone();
158
        async move {
159
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
160
            let csrf = csrf_of(&page.body);
161
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
162
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
163
        }
164
    };
165
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
166
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
167
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
168
169
    // Create a repository through the API; the read-only token cannot.
170
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
171
    assert_eq!(st, StatusCode::FORBIDDEN);
172
    let (st, v) = api(
173
        app,
174
        "POST",
175
        "/api/v1/repos",
176
        Some(&andy_admin),
177
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
178
    )
179
    .await;
180
    assert_eq!(st, StatusCode::CREATED, "{v}");
181
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
182
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
183
    assert_eq!(st, StatusCode::CONFLICT);
184
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
185
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
186
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
187
    assert_eq!(st, StatusCode::OK);
188
    assert_eq!(v["username"], "andy");
189
190
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
191
    let rx = receiver().await;
192
    let (st, v) = api(
193
        app,
194
        "POST",
195
        "/api/v1/repos/andy/demo/hooks",
196
        Some(&andy_admin),
197
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
198
    )
199
    .await;
200
    assert_eq!(st, StatusCode::CREATED, "{v}");
201
    let work = tempfile::tempdir().unwrap();
202
    let mut client = Repo::init(work.path()).unwrap();
203
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
204
    client.config.set("remote.origin.token", "site").unwrap();
205
    client.save_config().unwrap();
206
    write(work.path(), "a.txt", b"a\n");
207
    client.snapshot("t").unwrap();
208
    let base = client.commit("base", &[]).unwrap();
209
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
210
    // The worker retries with backoff; drive it directly for the retry.
211
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
212
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
213
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
214
    oxygenhub::hooks::deliver_due(app).await;
215
    let seen = rx.seen.lock().unwrap().clone();
216
    assert_eq!(seen.len(), 1, "{seen:?}");
217
    assert_eq!(seen[0].0, "push");
218
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
219
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
220
    assert_eq!(payload["repository"]["name"], "demo");
221
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
222
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
223
    assert_eq!(v.as_array().unwrap().len(), 1);
224
225
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
226
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
227
    assert_eq!(st, StatusCode::OK);
228
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
229
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
230
    assert_eq!(v[0]["name"], "a.txt");
231
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
232
    assert_eq!(r.body, "a\n");
233
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
234
    assert_eq!(v[0]["change"], base.to_hex());
235
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
236
    assert_eq!(v["files"][0]["path"], "a.txt");
237
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
238
    assert!(v["policy"].is_null());
239
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
240
    assert_eq!(v[0]["reference"], "main");
241
242
    // Issues through the API: Bob opens one, comments, and closes it.
243
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
244
    assert_eq!(st, StatusCode::CREATED, "{v}");
245
    assert_eq!(v["number"], 1);
246
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
247
    assert_eq!(st, StatusCode::CREATED);
248
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
249
    assert_eq!(st, StatusCode::OK, "{v}");
250
    assert_eq!(v["state"], "closed");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
252
    assert_eq!(v[0]["comments"], 1);
253
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
254
    assert_eq!(v[0]["number"], 1);
255
256
    // A proposal through the API, then a required check gates its landing.
257
    client.bookmark_create("feat", Some(&[base])).unwrap();
258
    client.bookmark_switch("feat", false).unwrap();
259
    write(work.path(), "b.txt", b"b\n");
260
    write(work.path(), "a.txt", b"a\nA\n");
261
    client.snapshot("t").unwrap();
262
    let feat = client.commit("feat", &[]).unwrap();
263
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
264
    let (st, v) =
265
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
266
            .await;
267
    assert_eq!(st, StatusCode::CREATED, "{v}");
268
    assert_eq!(v["number"], 2);
269
    let state = v["projected_state"].as_str().unwrap().to_string();
270
    assert_eq!(v["landable"], true);
271
    // Its files, and each side's bytes, for editors' diff views.
272
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
273
    assert_eq!(st, StatusCode::OK, "{v}");
274
    let files: Vec<(String, String)> =
275
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
276
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
277
    assert_eq!(v[0]["added"], 1);
278
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
279
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
280
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
281
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
282
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
283
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
284
    // Require the "build" check.
285
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
286
    let csrf = csrf_of(&settings.body);
287
    assert_eq!(
288
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
289
            .await
290
            .status,
291
        StatusCode::OK
292
    );
293
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
294
    assert_eq!(v["landable"], false);
295
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
296
    // A checker reports on the projected state: first running, then passed; the page streams it.
297
    let (st, v) = api(
298
        app,
299
        "POST",
300
        "/api/v1/repos/andy/demo/checks",
301
        Some(&andy_ro),
302
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
303
    )
304
    .await;
305
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
306
    let mut events = app.events.proposals.subscribe();
307
    let (st, v) = api(
308
        app,
309
        "POST",
310
        "/api/v1/repos/andy/demo/checks",
311
        Some(&bob_rw),
312
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
313
    )
314
    .await;
315
    assert_eq!(st, StatusCode::CREATED, "{v}");
316
    let (_, ev) = events.recv().await.unwrap();
317
    assert_eq!(ev.kind, "check");
318
    assert_eq!(ev.check.unwrap().name, "build");
319
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
320
    assert_eq!(v[0]["status"], "passed");
321
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
322
    assert_eq!(v["landable"], true, "{v}");
323
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
324
    assert!(page.body.contains("42 tests"), "{}", page.body);
325
    // The check and the proposal reached the webhook too.
326
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
327
    oxygenhub::hooks::deliver_due(app).await;
328
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
329
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
330
    let _ = feat;
331
    let _ = rx.fail_first;
332
333
    // The inbox through the API: count, list, mark one read, mark all read.
334
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
335
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
336
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
337
    oxygenhub::db::notify::add(
338
        &app.db,
339
        oxygenhub::db::notify::New {
340
            account_id: bob_id,
341
            repo_id: None,
342
            reason: oxygenhub::db::notify::Reason::Participating,
343
            kind: "mention",
344
            title: "andy/demo#1: Bug",
345
            url: "/andy/demo/issue/1",
346
            actor: "andy",
347
        },
348
    )
349
    .await
350
    .unwrap();
351
    oxygenhub::db::notify::add(
352
        &app.db,
353
        oxygenhub::db::notify::New {
354
            account_id: bob_id,
355
            repo_id: None,
356
            reason: oxygenhub::db::notify::Reason::Participating,
357
            kind: "review",
358
            title: "andy/demo#2: Feat",
359
            url: "/andy/demo/proposal/2",
360
            actor: "andy",
361
        },
362
    )
363
    .await
364
    .unwrap();
365
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
366
    assert_eq!(st, StatusCode::OK, "{v}");
367
    assert_eq!(v["unread"], 2);
368
    assert_eq!(v["items"][0]["read"], false);
369
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
370
    let first = v["items"][0]["id"].as_i64().unwrap();
371
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
372
    assert_eq!(st, StatusCode::NO_CONTENT);
373
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
374
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
375
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
376
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
377
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
378
379
    // A source bookmark with `/` in its name, as a feature/N-name workflow
380
    // makes them: by name, and as this repository's owner/name:bookmark.
381
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
382
        client.bookmark_create(b, Some(&[base])).unwrap();
383
        client.bookmark_switch(b, false).unwrap();
384
        write(work.path(), file, b"c\n");
385
        client.snapshot("t").unwrap();
386
        client.commit(b, &[]).unwrap();
387
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
388
    }
389
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
390
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
391
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
392
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
393
        let n = v["number"].as_i64().unwrap();
394
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
395
        assert_eq!(page.status, StatusCode::OK);
396
        assert!(page.body.contains("feature/"), "the page names its source");
397
    }
398
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
399
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
400
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
401
}
402
403
#[tokio::test(flavor = "multi_thread")]
404
async fn api_issue_triage_and_labels() {
405
    let h = hub().await;
406
    let app = &h.app;
407
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
408
        .await
409
        .cookie
410
        .unwrap();
411
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
412
        .await
413
        .cookie
414
        .unwrap();
415
    let mint = |cookie: String, scopes: &'static str| {
416
        let app = app.clone();
417
        async move {
418
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
419
            let csrf = csrf_of(&page.body);
420
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
421
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
422
        }
423
    };
424
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
425
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
426
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
427
    assert_eq!(st, StatusCode::CREATED);
428
429
    // Labels through the API; bad colours and non-triage callers are refused.
430
    let (st, v) = api(
431
        app,
432
        "POST",
433
        "/api/v1/repos/andy/demo/labels",
434
        Some(&andy_t),
435
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
436
    )
437
    .await;
438
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
439
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
440
    assert_eq!(
441
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
442
        StatusCode::BAD_REQUEST
443
    );
444
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
445
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
446
    assert_eq!(labels.as_array().unwrap().len(), 2);
447
448
    // An issue created with its labels and assignee in one call.
449
    let (st, v) = api(
450
        app,
451
        "POST",
452
        "/api/v1/repos/andy/demo/issues",
453
        Some(&andy_t),
454
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
455
    )
456
    .await;
457
    assert_eq!(st, StatusCode::CREATED, "{v}");
458
    assert_eq!(v["labels"][0]["name"], "bug");
459
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
460
    let n = v["number"].as_i64().unwrap();
461
    // Unknown names are refused before anything is created.
462
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
463
    assert_eq!(st, StatusCode::BAD_REQUEST);
464
    assert!(v["detail"].as_str().unwrap().contains("no label"));
465
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
466
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
467
    // Without triage, labels cannot be set, but a plain issue can be opened.
468
    assert_eq!(
469
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
470
        StatusCode::FORBIDDEN
471
    );
472
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
473
    assert_eq!(st, StatusCode::CREATED);
474
    let bob_n = bobs["number"].as_i64().unwrap();
475
476
    // PATCH: the whole label set, assignees and milestone, with events.
477
    let (st, v) =
478
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
479
            .await;
480
    assert_eq!(st, StatusCode::OK, "{v}");
481
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
482
    assert_eq!(v["assignees"], serde_json::json!([]));
483
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
484
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
485
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
486
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
487
    // The author edits their own title; others cannot; nobody but triage sets labels.
488
    let (st, v) =
489
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
490
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
491
    assert_eq!(
492
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
493
        StatusCode::FORBIDDEN
494
    );
495
    assert_eq!(
496
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
497
        StatusCode::FORBIDDEN
498
    );
499
    assert_eq!(
500
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
501
        StatusCode::BAD_REQUEST
502
    );
503
504
    // Deleting a label takes it off the issues.
505
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
506
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
507
    assert_eq!(v["labels"], serde_json::json!([]));
508
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
509
}
510
511
#[tokio::test(flavor = "multi_thread")]
512
async fn webhook_formats_editing_and_web_issue_events() {
513
    let h = hub().await;
514
    let app = &h.app;
515
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
516
        .await
517
        .cookie
518
        .unwrap();
519
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
520
    let r = call(
521
        app,
522
        "POST",
523
        "/settings/tokens",
524
        None,
525
        Some(&andy),
526
        None,
527
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
528
    )
529
    .await;
530
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
531
    assert_eq!(
532
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
533
        StatusCode::CREATED
534
    );
535
    let rx = receiver().await;
536
    *rx.fail_first.lock().unwrap() = false;
537
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
538
    let csrf = csrf_of(&settings);
539
    let form = |f: String| {
540
        let andy = andy.clone();
541
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
542
    };
543
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
544
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
545
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
546
    assert_eq!(hook.format, "discord");
547
    // Ping arrives as a Discord message.
548
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
549
    let mut got = String::new();
550
    for _ in 0..100 {
551
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
552
            got = body.clone();
553
        }
554
        if !got.is_empty() {
555
            break;
556
        }
557
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
558
    }
559
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
560
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
561
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
562
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
563
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
564
565
    // Editing: a blank URL and secret keep theirs; format, events and active change.
566
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
567
        .await
568
        .contains("Webhook saved"));
569
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
570
    assert_eq!(
571
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
572
        (rx.url.as_str(), "issue", "oxygenhub", true)
573
    );
574
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
575
576
    // An issue opened on the web now reaches the hook, as the signed envelope.
577
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
578
    call(
579
        app,
580
        "POST",
581
        "/andy/demo/issues/new",
582
        None,
583
        Some(&andy),
584
        None,
585
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
586
    )
587
    .await;
588
    let mut envelope = None;
589
    for _ in 0..100 {
590
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
591
        if envelope.is_some() {
592
            break;
593
        }
594
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
595
    }
596
    let (_, sig, body) = envelope.expect("issue.opened delivered");
597
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
598
    assert_eq!(v["data"]["issue"]["title"], "From the web");
599
    assert!(sig.starts_with("blake3-keyed="));
600
    // A disabled hook through the edit form (no active box).
601
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
602
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
603
}
604
605
#[tokio::test(flavor = "multi_thread")]
606
async fn api_projects() {
607
    let h = hub().await;
608
    let app = &h.app;
609
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
610
        .await
611
        .cookie
612
        .unwrap();
613
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
614
        .await
615
        .cookie
616
        .unwrap();
617
    let mint = |cookie: String, scopes: &'static str| {
618
        let app = app.clone();
619
        async move {
620
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
621
            let csrf = csrf_of(&page.body);
622
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
623
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
624
        }
625
    };
626
    let a = mint(andy, "scopes=repo%3Aadmin").await;
627
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
628
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
629
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
630
631
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
632
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
633
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
634
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
635
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
636
637
    // Cards by reference, into a column by name, and a note into the first column.
638
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
639
    assert_eq!(st, StatusCode::CREATED, "{card}");
640
    assert_eq!(
641
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
642
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
643
    );
644
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
645
    assert_eq!(st, StatusCode::BAD_REQUEST);
646
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
647
    assert_eq!(
648
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
649
        StatusCode::BAD_REQUEST
650
    );
651
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
652
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
653
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
654
655
    // Move and read the board.
656
    let id = card["id"].as_i64().unwrap();
657
    assert_eq!(
658
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
659
        StatusCode::NO_CONTENT
660
    );
661
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
662
    let names: Vec<(&str, usize)> =
663
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
664
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
665
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
666
667
    // Private: hidden from others; closed: read-only; then remove a card.
668
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
669
    assert_eq!(edited["public"], false);
670
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
671
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
672
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
673
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
674
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
675
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
676
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
677
}
678
679
#[tokio::test(flavor = "multi_thread")]
680
async fn api_required_checks() {
681
    let h = hub().await;
682
    let app = &h.app;
683
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
684
        .await
685
        .cookie
686
        .unwrap();
687
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
688
    let csrf = csrf_of(&page.body);
689
    let mint = |scopes: &'static str| {
690
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
691
        async move {
692
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
693
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
694
        }
695
    };
696
    let admin = mint("scopes=repo%3Aadmin").await;
697
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
698
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
699
700
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
701
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
702
    let (st, v) = api(
703
        app,
704
        "PUT",
705
        "/api/v1/repos/andy/demo/checks/required",
706
        Some(&admin),
707
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
708
    )
709
    .await;
710
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
711
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
712
    assert_eq!(
713
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
714
        serde_json::json!(["flow/fmt", "flow/test"])
715
    );
716
    assert_eq!(
717
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
718
        StatusCode::FORBIDDEN,
719
        "repo:admin only"
720
    );
721
    assert_eq!(
722
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
723
        StatusCode::BAD_REQUEST
724
    );
725
    // The settings page shows the same list.
726
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
727
}
728
729
/// OxygenFlow per repository: site administrators turn it on or off in
730
/// the repository's settings; hub.toml's `[flow] repos` is the default.
731
#[tokio::test(flavor = "multi_thread")]
732
async fn flow_is_switched_per_repository_by_site_admins() {
733
    let h = hub().await;
734
    let app = &h.app;
735
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
736
        .await
737
        .cookie
738
        .unwrap();
739
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
740
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
741
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
742
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
743
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
744
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
745
746
    let set = |value: &'static str| {
747
        let (app, andy) = (app.clone(), andy.clone());
748
        async move {
749
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
750
            call(
751
                &app,
752
                "POST",
753
                "/andy/demo/settings/flow",
754
                None,
755
                Some(&andy),
756
                None,
757
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
758
            )
759
            .await
760
        }
761
    };
762
    // A repository admin who is not a site admin sees the state but cannot change it.
763
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
764
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
765
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
766
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
767
    let r = set("on").await;
768
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
769
    assert_eq!(row().await.flow, "");
770
771
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
772
    let r = set("on").await;
773
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
774
    assert_eq!(row().await.flow, "on");
775
    assert!(oxygenhub::flow::enabled(app, &row().await));
776
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
777
    set("off").await;
778
    assert!(!oxygenhub::flow::enabled(app, &row().await));
779
    set("default").await;
780
    assert_eq!(row().await.flow, "");
781
    assert!(set("sometimes").await.body.contains("Pick on, off"));
782
}
783
784
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
785
/// button, never the repository's default bookmark as the hub sets it.
786
#[tokio::test(flavor = "multi_thread")]
787
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
788
    let h = hub().await;
789
    let app = &h.app;
790
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
791
        .await
792
        .cookie
793
        .unwrap();
794
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
795
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
796
    let url = format!("{}/andy/demo", h.base);
797
    let work = tempfile::tempdir().unwrap();
798
    let (w, u) = (work.path().to_path_buf(), url.clone());
799
    let client = tokio::task::spawn_blocking(move || {
800
        let mut c = Repo::init(&w).unwrap();
801
        c.config.set("remote.origin.url", &u).unwrap();
802
        c.config.set("remote.origin.token", "site").unwrap();
803
        c.save_config().unwrap();
804
        write(&w, "a.txt", b"a\n");
805
        c.commit("a", &[]).unwrap();
806
        assert!(c.push("origin", false).unwrap()[0].ok);
807
        for b in ["develop", "feature/x", "stray"] {
808
            c.bookmark_create(b, None).unwrap();
809
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
810
        }
811
        // A pushed deletion.
812
        let r = c.push_delete("origin", "feature/x").unwrap();
813
        assert!(r[0].ok, "{r:?}");
814
        c
815
    })
816
    .await
817
    .unwrap();
818
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
819
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
820
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
821
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
822
    assert!(!anon.body.contains("/bookmarks/delete"));
823
824
    // The hub's default, not the repository's config, is protected: make
825
    // develop the default, then main can go and develop cannot.
826
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
827
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
828
    let client = tokio::task::spawn_blocking(move || {
829
        let r = client.push_delete("origin", "develop").unwrap();
830
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
831
        let r = client.push_delete("origin", "main").unwrap();
832
        assert!(r[0].ok, "{r:?}");
833
        client
834
    })
835
    .await
836
    .unwrap();
837
    drop(client);
838
839
    // On the web: a writer deletes stray; the default is refused.
840
    let form = |b: &'static str| {
841
        let (app, andy) = (app.clone(), andy.clone());
842
        async move {
843
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
844
            call(
845
                &app,
846
                "POST",
847
                "/andy/demo/bookmarks/delete",
848
                None,
849
                Some(&andy),
850
                None,
851
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
852
            )
853
            .await
854
        }
855
    };
856
    let r = form("stray").await;
857
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
858
    assert!(!r.body.contains(">stray<"));
859
    let r = form("develop").await;
860
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
861
    let r = form("nope").await;
862
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
863
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
864
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
865
    // Anonymous visitors cannot.
866
    assert_ne!(
867
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
868
        StatusCode::OK
869
    );
870
}
871
872
/// A change signed by a key no account has linked says so, on its page
873
/// and in the API (feedback 14).
874
#[tokio::test(flavor = "multi_thread")]
875
async fn changes_signed_by_unlinked_keys_say_so() {
876
    let h = hub().await;
877
    let app = &h.app;
878
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
879
        .await
880
        .cookie
881
        .unwrap();
882
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
883
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
884
    let url = format!("{}/andy/demo", h.base);
885
    let work = tempfile::tempdir().unwrap();
886
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
887
    let hash = tokio::task::spawn_blocking(move || {
888
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
889
        c.config.set("remote.origin.url", &u).unwrap();
890
        c.config.set("remote.origin.token", "site").unwrap();
891
        c.save_config().unwrap();
892
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
893
        write(&w.join("r"), "a.txt", b"a\n");
894
        let h = c.commit("signed by Ada", &[]).unwrap();
895
        assert!(c.push("origin", false).unwrap()[0].ok);
896
        h.to_hex()
897
    })
898
    .await
899
    .unwrap();
900
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
901
    assert_eq!(st, StatusCode::OK, "{v}");
902
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
903
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
904
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
905
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
906
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
907
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
908
}
909
910
/// Function history (hub spec §6.6): the file page lists a file's
911
/// functions, and a function's page lists exactly the changes to its lines.
912
#[tokio::test(flavor = "multi_thread")]
913
async fn a_function_has_its_own_history() {
914
    let h = hub().await;
915
    let app = &h.app;
916
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
917
        .await
918
        .cookie
919
        .unwrap();
920
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
921
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
922
    let url = format!("{}/andy/demo", h.base);
923
    let work = tempfile::tempdir().unwrap();
924
    let w = work.path().to_path_buf();
925
    tokio::task::spawn_blocking(move || {
926
        let mut c = Repo::init(&w).unwrap();
927
        c.config.set("remote.origin.url", &url).unwrap();
928
        c.config.set("remote.origin.token", "site").unwrap();
929
        c.save_config().unwrap();
930
        let steps = [
931
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
932
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
933
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
934
        ];
935
        for (msg, text) in steps {
936
            write(&w, "src/lib.rs", text.as_bytes());
937
            c.commit(msg, &[]).unwrap();
938
        }
939
        assert!(c.push("origin", false).unwrap()[0].ok);
940
    })
941
    .await
942
    .unwrap();
943
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
944
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
945
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
946
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
947
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
948
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
949
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
950
    assert_ne!(bad.status, StatusCode::OK);
951
}
952
953
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
954
/// dependency edges, linked cards.
955
#[tokio::test(flavor = "multi_thread")]
956
async fn a_bookmark_shows_as_swimlanes() {
957
    let h = hub().await;
958
    let app = &h.app;
959
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
960
        .await
961
        .cookie
962
        .unwrap();
963
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
964
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
965
    let url = format!("{}/andy/demo", h.base);
966
    let work = tempfile::tempdir().unwrap();
967
    let w = work.path().to_path_buf();
968
    tokio::task::spawn_blocking(move || {
969
        let mut c = Repo::init(&w).unwrap();
970
        c.config.set("remote.origin.url", &url).unwrap();
971
        c.config.set("remote.origin.token", "site").unwrap();
972
        c.save_config().unwrap();
973
        // Two files edited independently: two lanes.
974
        write(&w, "a.txt", b"a\n");
975
        c.commit("add a", &[]).unwrap();
976
        write(&w, "b.txt", b"b\n");
977
        c.commit("add b", &[]).unwrap();
978
        write(&w, "a.txt", b"a\na2\n");
979
        c.commit("grow a", &[]).unwrap();
980
        assert!(c.push("origin", false).unwrap()[0].ok);
981
    })
982
    .await
983
    .unwrap();
984
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
985
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
986
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
987
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
988
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
989
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
990
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
991
    assert_eq!(board.matches("<rect ").count(), 3);
992
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
993
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
994
}
995
996
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
997
/// offers only what makes sense and rewrites nothing itself.
998
#[tokio::test(flavor = "multi_thread")]
999
async fn a_proposal_board_plans_squashes_and_rebases() {
1000
    let h = hub().await;
1001
    let app = &h.app;
1002
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1003
        .await
1004
        .cookie
1005
        .unwrap();
1006
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1007
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1008
    let url = format!("{}/andy/demo", h.base);
1009
    let work = tempfile::tempdir().unwrap();
1010
    let w = work.path().to_path_buf();
1011
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1012
        let mut c = Repo::init(&w).unwrap();
1013
        c.config.set("remote.origin.url", &url).unwrap();
1014
        c.config.set("remote.origin.token", "site").unwrap();
1015
        c.save_config().unwrap();
1016
        write(&w, "a.txt", b"a\n");
1017
        let base = c.commit("base", &[]).unwrap();
1018
        assert!(c.push("origin", false).unwrap()[0].ok);
1019
        c.bookmark_create("feature", None).unwrap();
1020
        c.bookmark_switch("feature", false).unwrap();
1021
        write(&w, "a.txt", b"a\nfirst\n");
1022
        let first = c.commit("first", &[]).unwrap();
1023
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1024
        let second = c.commit("second", &[]).unwrap();
1025
        write(&w, "b.txt", b"apart\n");
1026
        let apart = c.commit("apart", &[]).unwrap();
1027
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1028
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1029
    })
1030
    .await
1031
    .unwrap();
1032
    // No proposal yet: the board is read-only.
1033
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1034
    assert!(!board.contains("data-plan="));
1035
    let (st, _) = api(
1036
        app,
1037
        "POST",
1038
        "/api/v1/repos/andy/demo/proposals",
1039
        Some("site"),
1040
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1041
    )
1042
    .await;
1043
    assert!(st.is_success(), "{st}");
1044
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1045
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1046
    let csrf = csrf_of(&board);
1047
    let plan = |c: &str, t: &str| {
1048
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1049
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1050
        async move {
1051
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1052
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1053
        }
1054
    };
1055
    let kinds = |v: &serde_json::Value| {
1056
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1057
    };
1058
    // second already depends on first: squash, no rebase.
1059
    let v = plan(&second, &first).await;
1060
    assert_eq!(kinds(&v), ["squash"], "{v}");
1061
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1062
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygen.oxygen-vscode/plan?"));
1063
    // apart is independent of second: either.
1064
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1065
    // first under second: nothing (second depends on first).
1066
    assert!(plan(&first, &second).await["error"].is_string());
1067
    // What has landed on main is not rearranged.
1068
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1069
}
1070
1071
/// Issues and proposals share a number space, so every number says what it
1072
/// is, and the chain of work shows from both ends (hub spec §8).
1073
#[tokio::test(flavor = "multi_thread")]
1074
async fn proposals_and_issues_show_their_chain() {
1075
    let h = hub().await;
1076
    let app = &h.app;
1077
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1078
        .await
1079
        .cookie
1080
        .unwrap();
1081
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1082
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1083
    let url = format!("{}/andy/demo", h.base);
1084
    let work = tempfile::tempdir().unwrap();
1085
    let w = work.path().to_path_buf();
1086
    tokio::task::spawn_blocking(move || {
1087
        let mut c = Repo::init(&w).unwrap();
1088
        c.config.set("remote.origin.url", &url).unwrap();
1089
        c.config.set("remote.origin.token", "site").unwrap();
1090
        c.save_config().unwrap();
1091
        write(&w, "a.txt", b"a\n");
1092
        c.commit("base", &[]).unwrap();
1093
        assert!(c.push("origin", false).unwrap()[0].ok);
1094
        c.bookmark_create("feature", None).unwrap();
1095
        c.bookmark_switch("feature", false).unwrap();
1096
        write(&w, "a.txt", b"a\nfixed\n");
1097
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1098
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1099
    })
1100
    .await
1101
    .unwrap();
1102
    for title in ["Slow start", "Crash on save"] {
1103
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1104
        assert!(st.is_success());
1105
    }
1106
    let (st, v) = api(
1107
        app,
1108
        "POST",
1109
        "/api/v1/repos/andy/demo/proposals",
1110
        Some("site"),
1111
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1112
    )
1113
    .await;
1114
    assert!(st.is_success(), "{st} {v}");
1115
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1116
1117
    // The proposal names its kind, links its references by kind, and shows
1118
    // the chain: the issues it closes (description and changes) → it → main.
1119
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1120
    assert!(p.contains(">proposal #3</small>"), "header");
1121
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1122
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1123
    let chain = &chain[..chain.find("</p>").unwrap()];
1124
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1125
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1126
    }
1127
    assert!(p.contains("<h3>Closes</h3>"));
1128
1129
    // The issue shows the proposal that closes it, and names its own kind.
1130
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1131
    assert!(i.contains(">issue #1</small>"));
1132
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1133
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1134
    // The conversation is a timeline with avatars; editing sits with the
1135
    // content, not in the sidebar, and labels and projects are editable.
1136
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1137
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1138
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1139
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1140
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1141
    assert!(st.is_success(), "{st}");
1142
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1143
    assert!(p.contains("<option value=\"1\">Board</option>"), "the owner's projects to add to");
1144
    let csrf = csrf_of(&p);
1145
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1146
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1147
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1148
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1149
        .await;
1150
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1151
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1152
1153
    // Closed by the proposal's change, not its description: still shown.
1154
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1155
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1156
    assert!(chain.contains("proposal #3"), "{chain}");
1157
}
1158
1159
/// What the hub is: its version and build, and the libraries it is built on,
1160
/// on /about, in the API and in /health (hub spec §15).
1161
#[tokio::test(flavor = "multi_thread")]
1162
async fn the_hub_says_what_version_it_is() {
1163
    let h = hub().await;
1164
    let app = &h.app;
1165
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1166
    assert_eq!(st, StatusCode::OK);
1167
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1168
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1169
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1170
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1171
    assert!(health.contains("\"build\""), "{health}");
1172
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1173
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1174
    assert!(about.contains("href=\"/about\""), "the footer links here");
1175
}
1176
1177
#[tokio::test(flavor = "multi_thread")]
1178
async fn device_sign_in() {
1179
    let h = hub().await;
1180
    let app = &h.app;
1181
    let r =
1182
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1183
    let andy = r.cookie.unwrap();
1184
1185
    // An unknown scope is refused.
1186
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1187
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1188
1189
    // The app asks for a code and polls; nobody has approved it yet.
1190
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1191
    assert_eq!(st, StatusCode::OK, "{v}");
1192
    let device = v["device_code"].as_str().unwrap().to_string();
1193
    let user = v["user_code"].as_str().unwrap().to_string();
1194
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1195
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1196
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1197
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1198
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1199
    assert_eq!(v["error"], "slow_down", "polled too soon");
1200
1201
    // The user approves it on the web, allowing less than it asked for.
1202
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1203
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1204
    let csrf = csrf_of(&page.body);
1205
    let r =
1206
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1207
            .await;
1208
    assert!(r.body.contains("Approved"), "{}", r.body);
1209
1210
    // The next poll gets a token with what was allowed, once.
1211
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1212
    assert_eq!(st, StatusCode::OK, "{v}");
1213
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1214
    let token = v["access_token"].as_str().unwrap().to_string();
1215
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1216
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1217
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1218
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1219
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1220
    assert!(tokens.body.contains("device: Phone app"));
1221
    // oxygenhub#70: a device's token expires, and each use renews it.
1222
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1223
1224
    // The token can revoke itself (oxy auth logout), and is then refused.
1225
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1226
    assert_eq!(st, StatusCode::NO_CONTENT);
1227
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1228
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1229
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1230
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1231
1232
    // A denied code says so.
1233
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1234
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1235
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1236
    let csrf = csrf_of(&page.body);
1237
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1238
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1239
    assert_eq!(v["error"], "access_denied");
1240
1241
    // Signed out, the page asks for a sign-in first.
1242
    let r = call(app, "GET", "/device", None, None, None, None).await;
1243
    assert!(r.status.is_redirection(), "{}", r.status);
1244
}