OXYGENHUB
# a0dd06b0094e oxygenhub / crates / hub / tests / api.rs
73.4 KiB · Rust · last changed API: a wiki says it takes no proposals, rather than 'no such repository' 25 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    let app = oxygenhub::build(config).await.unwrap();
51
    let router = oxygenhub::router(app.clone());
52
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
53
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
54
}
55
56
struct Res {
57
    status: StatusCode,
58
    body: String,
59
    cookie: Option<String>,
60
}
61
62
async fn call(
63
    app: &Shared,
64
    method: &str,
65
    path: &str,
66
    bearer: Option<&str>,
67
    cookie: Option<&str>,
68
    json: Option<&str>,
69
    form: Option<&str>,
70
) -> Res {
71
    let mut req = Request::builder().method(method).uri(path);
72
    if let Some(b) = bearer {
73
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
74
    }
75
    if let Some(c) = cookie {
76
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
77
    }
78
    let body = if let Some(j) = json {
79
        req = req.header(header::CONTENT_TYPE, "application/json");
80
        Body::from(j.to_string())
81
    } else if let Some(f) = form {
82
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
83
        Body::from(f.to_string())
84
    } else {
85
        Body::empty()
86
    };
87
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
88
    let status = res.status();
89
    let cookie = res
90
        .headers()
91
        .get(header::SET_COOKIE)
92
        .and_then(|v| v.to_str().ok())
93
        .and_then(|v| v.split(';').next())
94
        .and_then(|kv| kv.split_once('='))
95
        .map(|(_, v)| v.to_string());
96
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
97
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
98
}
99
100
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
101
    let r = call(app, method, path, bearer, None, json, None).await;
102
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
103
    (r.status, v)
104
}
105
106
fn csrf_of(page: &str) -> String {
107
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
108
    page[i..].split('"').next().unwrap().to_string()
109
}
110
111
/// A webhook receiver that records what it gets and fails the first time.
112
struct Receiver {
113
    url: String,
114
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
115
    fail_first: Arc<Mutex<bool>>,
116
}
117
118
async fn receiver() -> Receiver {
119
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
120
    let fail_first = Arc::new(Mutex::new(true));
121
    let (s2, f2) = (seen.clone(), fail_first.clone());
122
    let router = Router::new().route(
123
        "/hook",
124
        post(move |headers: header::HeaderMap, body: String| {
125
            let (s2, f2) = (s2.clone(), f2.clone());
126
            async move {
127
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
128
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
129
                let mut f = f2.lock().unwrap();
130
                if *f {
131
                    *f = false;
132
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
133
                }
134
                s2.lock().unwrap().push((event, sig, body));
135
                (StatusCode::OK, "ok")
136
            }
137
        }),
138
    );
139
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
140
    let port = listener.local_addr().unwrap().port();
141
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
142
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
143
}
144
145
#[tokio::test(flavor = "multi_thread")]
146
async fn api_webhooks_and_checks() {
147
    let h = hub().await;
148
    let app = &h.app;
149
    // Accounts and tokens through the pages.
150
    let r =
151
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
152
    let andy = r.cookie.unwrap();
153
    let r =
154
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
155
    let bob = r.cookie.unwrap();
156
    let mint = |cookie: String, scopes: &'static str| {
157
        let app = app.clone();
158
        async move {
159
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
160
            let csrf = csrf_of(&page.body);
161
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
162
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
163
        }
164
    };
165
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
166
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
167
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
168
169
    // Create a repository through the API; the read-only token cannot.
170
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
171
    assert_eq!(st, StatusCode::FORBIDDEN);
172
    let (st, v) = api(
173
        app,
174
        "POST",
175
        "/api/v1/repos",
176
        Some(&andy_admin),
177
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
178
    )
179
    .await;
180
    assert_eq!(st, StatusCode::CREATED, "{v}");
181
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
182
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
183
    assert_eq!(st, StatusCode::CONFLICT);
184
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
185
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
186
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
187
    assert_eq!(st, StatusCode::OK);
188
    assert_eq!(v["username"], "andy");
189
190
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
191
    let rx = receiver().await;
192
    let (st, v) = api(
193
        app,
194
        "POST",
195
        "/api/v1/repos/andy/demo/hooks",
196
        Some(&andy_admin),
197
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
198
    )
199
    .await;
200
    assert_eq!(st, StatusCode::CREATED, "{v}");
201
    let work = tempfile::tempdir().unwrap();
202
    let mut client = Repo::init(work.path()).unwrap();
203
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
204
    client.config.set("remote.origin.token", "site").unwrap();
205
    client.save_config().unwrap();
206
    write(work.path(), "a.txt", b"a\n");
207
    client.snapshot("t").unwrap();
208
    let base = client.commit("base", &[]).unwrap();
209
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
210
    // The worker retries with backoff; drive it directly for the retry.
211
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
212
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
213
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
214
    oxygenhub::hooks::deliver_due(app).await;
215
    let seen = rx.seen.lock().unwrap().clone();
216
    assert_eq!(seen.len(), 1, "{seen:?}");
217
    assert_eq!(seen[0].0, "push");
218
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
219
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
220
    assert_eq!(payload["repository"]["name"], "demo");
221
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
222
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
223
    assert_eq!(v.as_array().unwrap().len(), 1);
224
225
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
226
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
227
    assert_eq!(st, StatusCode::OK);
228
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
229
    // A revset in place of the whole history (`?r=`), under a budget; a
230
    // bad one is the caller's problem.
231
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
232
    assert_eq!(st, StatusCode::OK, "{v}");
233
    assert_eq!(v["total"].as_u64(), Some(1));
234
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
235
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
236
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
237
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
238
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
239
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
240
    assert_eq!(v[0]["name"], "a.txt");
241
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
242
    assert_eq!(r.body, "a\n");
243
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
244
    assert_eq!(v[0]["change"], base.to_hex());
245
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
246
    assert_eq!(v["files"][0]["path"], "a.txt");
247
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
248
    assert!(v["policy"].is_null());
249
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
250
    assert_eq!(v[0]["reference"], "main");
251
252
    // Issues through the API: Bob opens one, comments, and closes it.
253
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
254
    assert_eq!(st, StatusCode::CREATED, "{v}");
255
    assert_eq!(v["number"], 1);
256
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
257
    assert_eq!(st, StatusCode::CREATED);
258
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
259
    assert_eq!(st, StatusCode::OK, "{v}");
260
    assert_eq!(v["state"], "closed");
261
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
262
    assert_eq!(v[0]["comments"], 1);
263
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
264
    assert_eq!(v[0]["number"], 1);
265
266
    // A proposal through the API, then a required check gates its landing.
267
    client.bookmark_create("feat", Some(&[base])).unwrap();
268
    client.bookmark_switch("feat", false).unwrap();
269
    write(work.path(), "b.txt", b"b\n");
270
    write(work.path(), "a.txt", b"a\nA\n");
271
    client.snapshot("t").unwrap();
272
    let feat = client.commit("feat", &[]).unwrap();
273
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
274
    let (st, v) =
275
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
276
            .await;
277
    assert_eq!(st, StatusCode::CREATED, "{v}");
278
    assert_eq!(v["number"], 2);
279
    let state = v["projected_state"].as_str().unwrap().to_string();
280
    assert_eq!(v["landable"], true);
281
    // A wiki takes no proposals, and says so rather than "no such
282
    // repository" (oxygenhub#128); a repository's that does not exist
283
    // still does not.
284
    let (st, v) =
285
        api(app, "POST", "/api/v1/repos/andy/demo.wiki/proposals", Some(&bob_rw), Some(r#"{"title":"W","target":"main","source":"p"}"#))
286
            .await;
287
    let detail = v["detail"].as_str().unwrap_or_default();
288
    assert!(st == StatusCode::NOT_FOUND && detail.contains("is the wiki of andy/demo") && detail.contains("push main"), "{v}");
289
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/nope.wiki/proposals", Some(&bob_rw), None).await;
290
    assert_eq!(v["detail"], "no such repository");
291
    // Its files, and each side's bytes, for editors' diff views.
292
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
293
    assert_eq!(st, StatusCode::OK, "{v}");
294
    let files: Vec<(String, String)> =
295
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
296
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
297
    assert_eq!(v[0]["added"], 1);
298
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
299
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
300
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
301
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
302
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
303
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
304
    // Require the "build" check.
305
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
306
    let csrf = csrf_of(&settings.body);
307
    assert_eq!(
308
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
309
            .await
310
            .status,
311
        StatusCode::OK
312
    );
313
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
314
    assert_eq!(v["landable"], false);
315
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
316
    // A checker reports on the projected state: first running, then passed; the page streams it.
317
    let (st, v) = api(
318
        app,
319
        "POST",
320
        "/api/v1/repos/andy/demo/checks",
321
        Some(&andy_ro),
322
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
323
    )
324
    .await;
325
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
326
    let mut events = app.events.proposals.subscribe();
327
    let (st, v) = api(
328
        app,
329
        "POST",
330
        "/api/v1/repos/andy/demo/checks",
331
        Some(&bob_rw),
332
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
333
    )
334
    .await;
335
    assert_eq!(st, StatusCode::CREATED, "{v}");
336
    let (_, ev) = events.recv().await.unwrap();
337
    assert_eq!(ev.kind, "check");
338
    assert_eq!(ev.check.unwrap().name, "build");
339
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
340
    assert_eq!(v[0]["status"], "passed");
341
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
342
    assert_eq!(v["landable"], true, "{v}");
343
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
344
    assert!(page.body.contains("42 tests"), "{}", page.body);
345
    // The check and the proposal reached the webhook too.
346
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
347
    oxygenhub::hooks::deliver_due(app).await;
348
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
349
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
350
    let _ = feat;
351
    let _ = rx.fail_first;
352
353
    // The inbox through the API: count, list, mark one read, mark all read.
354
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
355
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
356
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
357
    oxygenhub::db::notify::add(
358
        &app.db,
359
        oxygenhub::db::notify::New {
360
            account_id: bob_id,
361
            repo_id: None,
362
            reason: oxygenhub::db::notify::Reason::Participating,
363
            kind: "mention",
364
            title: "andy/demo#1: Bug",
365
            url: "/andy/demo/issue/1",
366
            actor: "andy",
367
        },
368
    )
369
    .await
370
    .unwrap();
371
    oxygenhub::db::notify::add(
372
        &app.db,
373
        oxygenhub::db::notify::New {
374
            account_id: bob_id,
375
            repo_id: None,
376
            reason: oxygenhub::db::notify::Reason::Participating,
377
            kind: "review",
378
            title: "andy/demo#2: Feat",
379
            url: "/andy/demo/proposal/2",
380
            actor: "andy",
381
        },
382
    )
383
    .await
384
    .unwrap();
385
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
386
    assert_eq!(st, StatusCode::OK, "{v}");
387
    assert_eq!(v["unread"], 2);
388
    assert_eq!(v["items"][0]["read"], false);
389
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
390
    let first = v["items"][0]["id"].as_i64().unwrap();
391
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
392
    assert_eq!(st, StatusCode::NO_CONTENT);
393
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
394
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
395
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
396
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
397
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
398
399
    // Review requests: the author asks andy; andy is told, reviews, and the
400
    // request is answered; the author hears of the review.
401
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
402
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
403
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
404
        .await
405
        .unwrap();
406
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
407
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
408
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
409
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
410
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
411
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
412
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
413
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
414
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
415
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
416
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
417
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
418
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
419
    let (st, _) =
420
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
421
    assert_eq!(st, StatusCode::CREATED);
422
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
423
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
424
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
425
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
426
    // Asking again and withdrawing it.
427
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
428
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
429
    assert_eq!(st, StatusCode::NO_CONTENT);
430
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
431
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
432
    // oxygenhub#84: the page's menu sets who is asked, all at once.
433
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
434
    assert!(
435
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
436
        "the reviewers menu lists andy"
437
    );
438
    let csrf = csrf_of(&page.body);
439
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
440
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
441
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
442
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
443
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
444
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
445
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
446
447
    // A source bookmark with `/` in its name, as a feature/N-name workflow
448
    // makes them: by name, and as this repository's owner/name:bookmark.
449
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
450
        client.bookmark_create(b, Some(&[base])).unwrap();
451
        client.bookmark_switch(b, false).unwrap();
452
        write(work.path(), file, b"c\n");
453
        client.snapshot("t").unwrap();
454
        client.commit(b, &[]).unwrap();
455
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
456
    }
457
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
458
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
459
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
460
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
461
        let n = v["number"].as_i64().unwrap();
462
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
463
        assert_eq!(page.status, StatusCode::OK);
464
        assert!(page.body.contains("feature/"), "the page names its source");
465
    }
466
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
467
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
468
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
469
470
    // oxygenhub#76: a proposal's title and description are edited through
471
    // the API by its author or a maintainer; what is not given stays.
472
    let edit = |token: &str, number: i64, body: &str| {
473
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
474
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
475
    };
476
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
477
    assert_eq!(st, StatusCode::OK, "{v}");
478
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
479
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
480
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
481
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
482
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
483
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
484
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
485
    let (st, v) = api(
486
        app,
487
        "POST",
488
        "/api/v1/repos/andy/demo/proposals",
489
        Some(&andy_pw),
490
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
491
    )
492
    .await;
493
    assert_eq!(st, StatusCode::CREATED, "{v}");
494
    let n = v["number"].as_i64().unwrap();
495
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
496
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
497
498
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
499
    // before anything changes, shown in its JSON.
500
    for l in ["ui", "flow"] {
501
        let body = format!(r#"{{"name":"{l}"}}"#);
502
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
503
    }
504
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
505
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
506
    assert_eq!(st, StatusCode::OK, "{v}");
507
    let names = |v: &serde_json::Value| -> Vec<String> {
508
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
509
    };
510
    assert_eq!(names(&v), ["flow", "ui"]);
511
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
512
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
513
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
514
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
515
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
516
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
517
    assert_eq!(names(&v), ["flow"]);
518
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
519
}
520
521
#[tokio::test(flavor = "multi_thread")]
522
async fn api_issue_triage_and_labels() {
523
    let h = hub().await;
524
    let app = &h.app;
525
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
526
        .await
527
        .cookie
528
        .unwrap();
529
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
530
        .await
531
        .cookie
532
        .unwrap();
533
    let mint = |cookie: String, scopes: &'static str| {
534
        let app = app.clone();
535
        async move {
536
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
537
            let csrf = csrf_of(&page.body);
538
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
539
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
540
        }
541
    };
542
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
543
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
544
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
545
    assert_eq!(st, StatusCode::CREATED);
546
547
    // Labels through the API; bad colours and non-triage callers are refused.
548
    let (st, v) = api(
549
        app,
550
        "POST",
551
        "/api/v1/repos/andy/demo/labels",
552
        Some(&andy_t),
553
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
554
    )
555
    .await;
556
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
557
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
558
    assert_eq!(
559
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
560
        StatusCode::BAD_REQUEST
561
    );
562
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
563
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
564
    assert_eq!(labels.as_array().unwrap().len(), 2);
565
    // oxygenhub#91: milestones over the API, for triage.
566
    let (st, m) = api(
567
        app,
568
        "POST",
569
        "/api/v1/repos/andy/demo/milestones",
570
        Some(&andy_t),
571
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
572
    )
573
    .await;
574
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
575
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
576
    assert_eq!(
577
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
578
        StatusCode::BAD_REQUEST
579
    );
580
    assert_eq!(
581
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
582
        StatusCode::FORBIDDEN
583
    );
584
    let (st, m) =
585
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
586
            .await;
587
    assert_eq!(
588
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
589
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
590
        "{m}"
591
    );
592
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
593
    assert_eq!(
594
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
595
        StatusCode::NOT_FOUND,
596
        "renamed"
597
    );
598
    assert_eq!(
599
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
600
        StatusCode::BAD_REQUEST
601
    );
602
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
603
    assert_eq!(list.as_array().unwrap().len(), 1);
604
605
    // An issue created with its labels and assignee in one call.
606
    let (st, v) = api(
607
        app,
608
        "POST",
609
        "/api/v1/repos/andy/demo/issues",
610
        Some(&andy_t),
611
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
612
    )
613
    .await;
614
    assert_eq!(st, StatusCode::CREATED, "{v}");
615
    assert_eq!(v["labels"][0]["name"], "bug");
616
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
617
    let n = v["number"].as_i64().unwrap();
618
    // Unknown names are refused before anything is created.
619
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
620
    assert_eq!(st, StatusCode::BAD_REQUEST);
621
    assert!(v["detail"].as_str().unwrap().contains("no label"));
622
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
623
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
624
    // Without triage, labels cannot be set, but a plain issue can be opened.
625
    assert_eq!(
626
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
627
        StatusCode::FORBIDDEN
628
    );
629
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
630
    assert_eq!(st, StatusCode::CREATED);
631
    let bob_n = bobs["number"].as_i64().unwrap();
632
633
    // PATCH: the whole label set, assignees and milestone, with events.
634
    let (st, v) =
635
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
636
            .await;
637
    assert_eq!(st, StatusCode::OK, "{v}");
638
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
639
    assert_eq!(v["assignees"], serde_json::json!([]));
640
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
641
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
642
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
643
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
644
    // The author edits their own title; others cannot; nobody but triage sets labels.
645
    let (st, v) =
646
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
647
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
648
    assert_eq!(
649
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
650
        StatusCode::FORBIDDEN
651
    );
652
    assert_eq!(
653
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
654
        StatusCode::FORBIDDEN
655
    );
656
    assert_eq!(
657
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
658
        StatusCode::BAD_REQUEST
659
    );
660
661
    // Deleting a label takes it off the issues.
662
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
663
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
664
    assert_eq!(v["labels"], serde_json::json!([]));
665
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
666
}
667
668
#[tokio::test(flavor = "multi_thread")]
669
async fn webhook_formats_editing_and_web_issue_events() {
670
    let h = hub().await;
671
    let app = &h.app;
672
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
673
        .await
674
        .cookie
675
        .unwrap();
676
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
677
    let r = call(
678
        app,
679
        "POST",
680
        "/settings/tokens",
681
        None,
682
        Some(&andy),
683
        None,
684
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
685
    )
686
    .await;
687
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
688
    assert_eq!(
689
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
690
        StatusCode::CREATED
691
    );
692
    let rx = receiver().await;
693
    *rx.fail_first.lock().unwrap() = false;
694
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
695
    let csrf = csrf_of(&settings);
696
    let form = |f: String| {
697
        let andy = andy.clone();
698
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
699
    };
700
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
701
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
702
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
703
    assert_eq!(hook.format, "discord");
704
    // Ping arrives as a Discord message.
705
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
706
    let mut got = String::new();
707
    for _ in 0..100 {
708
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
709
            got = body.clone();
710
        }
711
        if !got.is_empty() {
712
            break;
713
        }
714
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
715
    }
716
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
717
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
718
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
719
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
720
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
721
722
    // Editing: a blank URL and secret keep theirs; format, events and active change.
723
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
724
        .await
725
        .contains("Webhook saved"));
726
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
727
    assert_eq!(
728
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
729
        (rx.url.as_str(), "issue", "oxygenhub", true)
730
    );
731
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
732
733
    // An issue opened on the web now reaches the hook, as the signed envelope.
734
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
735
    call(
736
        app,
737
        "POST",
738
        "/andy/demo/issues/new",
739
        None,
740
        Some(&andy),
741
        None,
742
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
743
    )
744
    .await;
745
    let mut envelope = None;
746
    for _ in 0..100 {
747
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
748
        if envelope.is_some() {
749
            break;
750
        }
751
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
752
    }
753
    let (_, sig, body) = envelope.expect("issue.opened delivered");
754
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
755
    assert_eq!(v["data"]["issue"]["title"], "From the web");
756
    assert!(sig.starts_with("blake3-keyed="));
757
    // A disabled hook through the edit form (no active box).
758
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
759
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
760
}
761
762
#[tokio::test(flavor = "multi_thread")]
763
async fn api_projects() {
764
    let h = hub().await;
765
    let app = &h.app;
766
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
767
        .await
768
        .cookie
769
        .unwrap();
770
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
771
        .await
772
        .cookie
773
        .unwrap();
774
    let mint = |cookie: String, scopes: &'static str| {
775
        let app = app.clone();
776
        async move {
777
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
778
            let csrf = csrf_of(&page.body);
779
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
780
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
781
        }
782
    };
783
    let a = mint(andy, "scopes=repo%3Aadmin").await;
784
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
785
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
786
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
787
788
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
789
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
790
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
791
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
792
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
793
794
    // Cards by reference, into a column by name, and a note into the first column.
795
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
796
    assert_eq!(st, StatusCode::CREATED, "{card}");
797
    assert_eq!(
798
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
799
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
800
    );
801
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
802
    assert_eq!(st, StatusCode::BAD_REQUEST);
803
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
804
    assert_eq!(
805
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
806
        StatusCode::BAD_REQUEST
807
    );
808
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
809
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
810
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
811
812
    // Move and read the board.
813
    let id = card["id"].as_i64().unwrap();
814
    assert_eq!(
815
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
816
        StatusCode::NO_CONTENT
817
    );
818
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
819
    let names: Vec<(&str, usize)> =
820
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
821
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
822
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
823
824
    // Private: hidden from others; closed: read-only; then remove a card.
825
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
826
    assert_eq!(edited["public"], false);
827
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
828
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
829
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
830
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
831
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
832
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
833
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
834
}
835
836
#[tokio::test(flavor = "multi_thread")]
837
async fn api_required_checks() {
838
    let h = hub().await;
839
    let app = &h.app;
840
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
841
        .await
842
        .cookie
843
        .unwrap();
844
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
845
    let csrf = csrf_of(&page.body);
846
    let mint = |scopes: &'static str| {
847
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
848
        async move {
849
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
850
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
851
        }
852
    };
853
    let admin = mint("scopes=repo%3Aadmin").await;
854
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
855
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
856
857
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
858
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
859
    let (st, v) = api(
860
        app,
861
        "PUT",
862
        "/api/v1/repos/andy/demo/checks/required",
863
        Some(&admin),
864
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
865
    )
866
    .await;
867
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
868
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
869
    assert_eq!(
870
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
871
        serde_json::json!(["flow/fmt", "flow/test"])
872
    );
873
    assert_eq!(
874
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
875
        StatusCode::FORBIDDEN,
876
        "repo:admin only"
877
    );
878
    assert_eq!(
879
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
880
        StatusCode::BAD_REQUEST
881
    );
882
    // The settings page shows the same list.
883
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
884
}
885
886
/// OxygenFlow per repository: site administrators turn it on or off in
887
/// the repository's settings; hub.toml's `[flow] repos` is the default.
888
#[tokio::test(flavor = "multi_thread")]
889
async fn flow_is_switched_per_repository_by_site_admins() {
890
    let h = hub().await;
891
    let app = &h.app;
892
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
893
        .await
894
        .cookie
895
        .unwrap();
896
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
897
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
898
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
899
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
900
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
901
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
902
903
    let set = |value: &'static str| {
904
        let (app, andy) = (app.clone(), andy.clone());
905
        async move {
906
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
907
            call(
908
                &app,
909
                "POST",
910
                "/andy/demo/settings/flow",
911
                None,
912
                Some(&andy),
913
                None,
914
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
915
            )
916
            .await
917
        }
918
    };
919
    // A repository admin who is not a site admin sees the state but cannot change it.
920
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
921
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
922
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
923
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
924
    let r = set("on").await;
925
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
926
    assert_eq!(row().await.flow, "");
927
928
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
929
    let r = set("on").await;
930
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
931
    assert_eq!(row().await.flow, "on");
932
    assert!(oxygenhub::flow::enabled(app, &row().await));
933
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
934
    set("off").await;
935
    assert!(!oxygenhub::flow::enabled(app, &row().await));
936
    set("default").await;
937
    assert_eq!(row().await.flow, "");
938
    assert!(set("sometimes").await.body.contains("Pick on, off"));
939
}
940
941
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
942
/// button, never the repository's default bookmark as the hub sets it.
943
#[tokio::test(flavor = "multi_thread")]
944
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
945
    let h = hub().await;
946
    let app = &h.app;
947
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
948
        .await
949
        .cookie
950
        .unwrap();
951
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
952
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
953
    let url = format!("{}/andy/demo", h.base);
954
    let work = tempfile::tempdir().unwrap();
955
    let (w, u) = (work.path().to_path_buf(), url.clone());
956
    let client = tokio::task::spawn_blocking(move || {
957
        let mut c = Repo::init(&w).unwrap();
958
        c.config.set("remote.origin.url", &u).unwrap();
959
        c.config.set("remote.origin.token", "site").unwrap();
960
        c.save_config().unwrap();
961
        write(&w, "a.txt", b"a\n");
962
        c.commit("a", &[]).unwrap();
963
        assert!(c.push("origin", false).unwrap()[0].ok);
964
        for b in ["develop", "feature/x", "stray"] {
965
            c.bookmark_create(b, None).unwrap();
966
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
967
        }
968
        // A pushed deletion.
969
        let r = c.push_delete("origin", "feature/x").unwrap();
970
        assert!(r[0].ok, "{r:?}");
971
        c
972
    })
973
    .await
974
    .unwrap();
975
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
976
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
977
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
978
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
979
    assert!(!anon.body.contains("/bookmarks/delete"));
980
981
    // The hub's default, not the repository's config, is protected: make
982
    // develop the default, then main can go and develop cannot.
983
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
984
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
985
    let client = tokio::task::spawn_blocking(move || {
986
        let r = client.push_delete("origin", "develop").unwrap();
987
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
988
        let r = client.push_delete("origin", "main").unwrap();
989
        assert!(r[0].ok, "{r:?}");
990
        client
991
    })
992
    .await
993
    .unwrap();
994
    drop(client);
995
996
    // On the web: a writer deletes stray; the default is refused.
997
    let form = |b: &'static str| {
998
        let (app, andy) = (app.clone(), andy.clone());
999
        async move {
1000
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1001
            call(
1002
                &app,
1003
                "POST",
1004
                "/andy/demo/bookmarks/delete",
1005
                None,
1006
                Some(&andy),
1007
                None,
1008
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1009
            )
1010
            .await
1011
        }
1012
    };
1013
    let r = form("stray").await;
1014
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1015
    assert!(!r.body.contains(">stray<"));
1016
    let r = form("develop").await;
1017
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1018
    let r = form("nope").await;
1019
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1020
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1021
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1022
    // Anonymous visitors cannot.
1023
    assert_ne!(
1024
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1025
        StatusCode::OK
1026
    );
1027
}
1028
1029
/// A change signed by a key no account has linked says so, on its page
1030
/// and in the API (feedback 14).
1031
#[tokio::test(flavor = "multi_thread")]
1032
async fn changes_signed_by_unlinked_keys_say_so() {
1033
    let h = hub().await;
1034
    let app = &h.app;
1035
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1036
        .await
1037
        .cookie
1038
        .unwrap();
1039
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1040
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1041
    let url = format!("{}/andy/demo", h.base);
1042
    let work = tempfile::tempdir().unwrap();
1043
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1044
    let hash = tokio::task::spawn_blocking(move || {
1045
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1046
        c.config.set("remote.origin.url", &u).unwrap();
1047
        c.config.set("remote.origin.token", "site").unwrap();
1048
        c.save_config().unwrap();
1049
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1050
        write(&w.join("r"), "a.txt", b"a\n");
1051
        let h = c.commit("signed by Ada", &[]).unwrap();
1052
        assert!(c.push("origin", false).unwrap()[0].ok);
1053
        h.to_hex()
1054
    })
1055
    .await
1056
    .unwrap();
1057
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1058
    assert_eq!(st, StatusCode::OK, "{v}");
1059
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1060
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1061
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1062
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1063
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1064
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1065
}
1066
1067
/// Function history (hub spec §6.6): the file page lists a file's
1068
/// functions, and a function's page lists exactly the changes to its lines.
1069
#[tokio::test(flavor = "multi_thread")]
1070
async fn a_function_has_its_own_history() {
1071
    let h = hub().await;
1072
    let app = &h.app;
1073
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1074
        .await
1075
        .cookie
1076
        .unwrap();
1077
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1078
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1079
    let url = format!("{}/andy/demo", h.base);
1080
    let work = tempfile::tempdir().unwrap();
1081
    let w = work.path().to_path_buf();
1082
    tokio::task::spawn_blocking(move || {
1083
        let mut c = Repo::init(&w).unwrap();
1084
        c.config.set("remote.origin.url", &url).unwrap();
1085
        c.config.set("remote.origin.token", "site").unwrap();
1086
        c.save_config().unwrap();
1087
        let steps = [
1088
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1089
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1090
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1091
        ];
1092
        for (msg, text) in steps {
1093
            write(&w, "src/lib.rs", text.as_bytes());
1094
            c.commit(msg, &[]).unwrap();
1095
        }
1096
        assert!(c.push("origin", false).unwrap()[0].ok);
1097
    })
1098
    .await
1099
    .unwrap();
1100
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1101
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1102
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1103
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1104
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1105
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1106
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1107
    assert_ne!(bad.status, StatusCode::OK);
1108
}
1109
1110
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1111
/// dependency edges, linked cards.
1112
#[tokio::test(flavor = "multi_thread")]
1113
async fn a_bookmark_shows_as_swimlanes() {
1114
    let h = hub().await;
1115
    let app = &h.app;
1116
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1117
        .await
1118
        .cookie
1119
        .unwrap();
1120
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1121
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1122
    let url = format!("{}/andy/demo", h.base);
1123
    let work = tempfile::tempdir().unwrap();
1124
    let w = work.path().to_path_buf();
1125
    tokio::task::spawn_blocking(move || {
1126
        let mut c = Repo::init(&w).unwrap();
1127
        c.config.set("remote.origin.url", &url).unwrap();
1128
        c.config.set("remote.origin.token", "site").unwrap();
1129
        c.save_config().unwrap();
1130
        // Two files edited independently: two lanes.
1131
        write(&w, "a.txt", b"a\n");
1132
        c.commit("add a", &[]).unwrap();
1133
        write(&w, "b.txt", b"b\n");
1134
        c.commit("add b", &[]).unwrap();
1135
        write(&w, "a.txt", b"a\na2\n");
1136
        c.commit("grow a", &[]).unwrap();
1137
        assert!(c.push("origin", false).unwrap()[0].ok);
1138
    })
1139
    .await
1140
    .unwrap();
1141
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1142
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1143
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1144
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1145
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1146
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1147
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1148
    assert_eq!(board.matches("<rect ").count(), 3);
1149
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1150
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1151
}
1152
1153
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1154
/// offers only what makes sense and rewrites nothing itself.
1155
#[tokio::test(flavor = "multi_thread")]
1156
async fn a_proposal_board_plans_squashes_and_rebases() {
1157
    let h = hub().await;
1158
    let app = &h.app;
1159
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1160
        .await
1161
        .cookie
1162
        .unwrap();
1163
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1164
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1165
    let url = format!("{}/andy/demo", h.base);
1166
    let work = tempfile::tempdir().unwrap();
1167
    let w = work.path().to_path_buf();
1168
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1169
        let mut c = Repo::init(&w).unwrap();
1170
        c.config.set("remote.origin.url", &url).unwrap();
1171
        c.config.set("remote.origin.token", "site").unwrap();
1172
        c.save_config().unwrap();
1173
        write(&w, "a.txt", b"a\n");
1174
        let base = c.commit("base", &[]).unwrap();
1175
        assert!(c.push("origin", false).unwrap()[0].ok);
1176
        c.bookmark_create("feature", None).unwrap();
1177
        c.bookmark_switch("feature", false).unwrap();
1178
        write(&w, "a.txt", b"a\nfirst\n");
1179
        let first = c.commit("first", &[]).unwrap();
1180
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1181
        let second = c.commit("second", &[]).unwrap();
1182
        write(&w, "b.txt", b"apart\n");
1183
        let apart = c.commit("apart", &[]).unwrap();
1184
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1185
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1186
    })
1187
    .await
1188
    .unwrap();
1189
    // No proposal yet: the board is read-only.
1190
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1191
    assert!(!board.contains("data-plan="));
1192
    let (st, _) = api(
1193
        app,
1194
        "POST",
1195
        "/api/v1/repos/andy/demo/proposals",
1196
        Some("site"),
1197
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1198
    )
1199
    .await;
1200
    assert!(st.is_success(), "{st}");
1201
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1202
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1203
    let csrf = csrf_of(&board);
1204
    let plan = |c: &str, t: &str| {
1205
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1206
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1207
        async move {
1208
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1209
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1210
        }
1211
    };
1212
    let kinds = |v: &serde_json::Value| {
1213
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1214
    };
1215
    // second already depends on first: squash, no rebase.
1216
    let v = plan(&second, &first).await;
1217
    assert_eq!(kinds(&v), ["squash"], "{v}");
1218
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1219
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygen.oxygen-vscode/plan?"));
1220
    // apart is independent of second: either.
1221
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1222
    // first under second: nothing (second depends on first).
1223
    assert!(plan(&first, &second).await["error"].is_string());
1224
    // What has landed on main is not rearranged.
1225
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1226
}
1227
1228
/// Issues and proposals share a number space, so every number says what it
1229
/// is, and the chain of work shows from both ends (hub spec §8).
1230
#[tokio::test(flavor = "multi_thread")]
1231
async fn proposals_and_issues_show_their_chain() {
1232
    let h = hub().await;
1233
    let app = &h.app;
1234
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1235
        .await
1236
        .cookie
1237
        .unwrap();
1238
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1239
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1240
    let url = format!("{}/andy/demo", h.base);
1241
    let work = tempfile::tempdir().unwrap();
1242
    let w = work.path().to_path_buf();
1243
    tokio::task::spawn_blocking(move || {
1244
        let mut c = Repo::init(&w).unwrap();
1245
        c.config.set("remote.origin.url", &url).unwrap();
1246
        c.config.set("remote.origin.token", "site").unwrap();
1247
        c.save_config().unwrap();
1248
        write(&w, "a.txt", b"a\n");
1249
        c.commit("base", &[]).unwrap();
1250
        assert!(c.push("origin", false).unwrap()[0].ok);
1251
        c.bookmark_create("feature", None).unwrap();
1252
        c.bookmark_switch("feature", false).unwrap();
1253
        write(&w, "a.txt", b"a\nfixed\n");
1254
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1255
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1256
    })
1257
    .await
1258
    .unwrap();
1259
    for title in ["Slow start", "Crash on save"] {
1260
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1261
        assert!(st.is_success());
1262
    }
1263
    let (st, v) = api(
1264
        app,
1265
        "POST",
1266
        "/api/v1/repos/andy/demo/proposals",
1267
        Some("site"),
1268
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1269
    )
1270
    .await;
1271
    assert!(st.is_success(), "{st} {v}");
1272
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1273
1274
    // The proposal names its kind, links its references by kind, and shows
1275
    // the chain: the issues it closes (description and changes) → it → main.
1276
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1277
    assert!(p.contains(">proposal #3</small>"), "header");
1278
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1279
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1280
    let chain = &chain[..chain.find("</p>").unwrap()];
1281
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1282
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1283
    }
1284
    assert!(p.contains("<h3>Closes</h3>"));
1285
1286
    // The issue shows the proposal that closes it, and names its own kind.
1287
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1288
    assert!(i.contains(">issue #1</small>"));
1289
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1290
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1291
    // The conversation is a timeline with avatars; editing sits with the
1292
    // content, not in the sidebar, and labels and projects are editable.
1293
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1294
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1295
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1296
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1297
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1298
    assert!(st.is_success(), "{st}");
1299
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1300
    assert!(
1301
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1302
        "the owner's projects to add to, in a menu"
1303
    );
1304
    let csrf = csrf_of(&p);
1305
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1306
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1307
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1308
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1309
        .await;
1310
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1311
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1312
1313
    // Closed by the proposal's change, not its description: still shown.
1314
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1315
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1316
    assert!(chain.contains("proposal #3"), "{chain}");
1317
}
1318
1319
/// What the hub is: its version and build, and the libraries it is built on,
1320
/// on /about, in the API and in /health (hub spec §15).
1321
#[tokio::test(flavor = "multi_thread")]
1322
async fn the_hub_says_what_version_it_is() {
1323
    let h = hub().await;
1324
    let app = &h.app;
1325
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1326
    assert_eq!(st, StatusCode::OK);
1327
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1328
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1329
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1330
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1331
    assert!(health.contains("\"build\""), "{health}");
1332
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1333
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1334
    assert!(about.contains("href=\"/about\""), "the footer links here");
1335
}
1336
1337
#[tokio::test(flavor = "multi_thread")]
1338
async fn device_sign_in() {
1339
    let h = hub().await;
1340
    let app = &h.app;
1341
    let r =
1342
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1343
    let andy = r.cookie.unwrap();
1344
1345
    // An unknown scope is refused.
1346
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1347
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1348
1349
    // The app asks for a code and polls; nobody has approved it yet.
1350
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1351
    assert_eq!(st, StatusCode::OK, "{v}");
1352
    let device = v["device_code"].as_str().unwrap().to_string();
1353
    let user = v["user_code"].as_str().unwrap().to_string();
1354
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1355
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1356
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1357
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1358
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1359
    assert_eq!(v["error"], "slow_down", "polled too soon");
1360
1361
    // The user approves it on the web, allowing less than it asked for.
1362
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1363
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1364
    let csrf = csrf_of(&page.body);
1365
    let r =
1366
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1367
            .await;
1368
    // oxygenhub#83: the answer page says it is done, with no code form.
1369
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1370
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1371
1372
    // The next poll gets a token with what was allowed, once.
1373
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1374
    assert_eq!(st, StatusCode::OK, "{v}");
1375
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1376
    let token = v["access_token"].as_str().unwrap().to_string();
1377
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1378
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1379
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1380
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1381
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1382
    assert!(tokens.body.contains("device: Phone app"));
1383
    // oxygenhub#70: a device's token expires, and each use renews it.
1384
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1385
1386
    // The token can revoke itself (oxy auth logout), and is then refused.
1387
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1388
    assert_eq!(st, StatusCode::NO_CONTENT);
1389
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1390
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1391
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1392
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1393
1394
    // A denied code says so.
1395
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1396
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1397
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1398
    let csrf = csrf_of(&page.body);
1399
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1400
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1401
    assert_eq!(v["error"], "access_denied");
1402
1403
    // Signed out, the page asks for a sign-in first.
1404
    let r = call(app, "GET", "/device", None, None, None, None).await;
1405
    assert!(r.status.is_redirection(), "{}", r.status);
1406
}