OXYGENHUB
# a1b9869565aa oxygenhub / crates / hub / src / web / proposals.rs
48.9 KiB · Rust · last changed Proposal page: centred timeline with avatars, inline editing, labels and projects 1 month ago source blame history raw
1 
//! Proposal pages (hub spec §7): list, new, detail with conversation,
2 
//! changes and files, comments anchored to atoms, reviews, landing.
3
4 
use super::history::{render_files, FileRows};
5 
use super::settings::{csrf, require};
6 
use super::{filters, lookup, lookup_role, Error, Page, RepoShell, Shell};
7 
use crate::auth::{Access, Role, Viewer};
8 
use crate::db::{self, accounts, proposals as pdb};
9 
use crate::render::{self, diff};
10 
use crate::repos::proposals::{self as pl, Projection, Source};
11 
use crate::repos::view::{self, ChangeView, ConflictView};
12 
use crate::repos::RepoName;
13 
use crate::Shared;
14 
use askama::Template;
15 
use axum::extract::{Form, Path, Query, State};
16 
use axum::response::{IntoResponse, Redirect, Response};
17 
use hub_api::{Approval, ProposalSource, ProposalState};
18 
use oxy_core::hash::ChangeHash;
19 
use serde::Deserialize;
20 
use std::collections::{BTreeMap, HashMap};
21
22 
// ------------------------------------------------------------------ list
23
24 
#[derive(Template)]
25 
#[template(path = "proposals.html")]
26 
pub struct ProposalsPage {
27 
    shell: Shell,
28 
    repo: RepoShell,
29 
    rows: Vec<pdb::ProposalRow>,
30 
    filter: String,
31 
    counts: (usize, usize, usize),
32 
    bookmarks: Vec<String>,
33 
    q: String,
34 
    sort: String,
35 
    pager: super::Pager,
36 
    labels: std::collections::HashMap<i64, Vec<db::issues::Label>>,
37 
}
38
39 
impl ProposalsPage {
40 
    fn labels_of(&self, id: &i64) -> &[db::issues::Label] {
41 
        self.labels.get(id).map(Vec::as_slice).unwrap_or(&[])
42 
    }
43 
}
44
45 
#[derive(Deserialize)]
46 
pub struct ListQuery {
47 
    state: Option<String>,
48 
    q: Option<String>,
49 
    sort: Option<String>,
50 
    page: Option<usize>,
51 
}
52
53 
/// The list's sort orders.
54 
pub const SORTS: &[(&str, &str)] = &[("updated", "recently updated"), ("newest", "newest"), ("oldest", "oldest")];
55
56 
pub async fn list(
57 
    State(app): State<Shared>,
58 
    viewer: Viewer,
59 
    Path((owner, name)): Path<(String, String)>,
60 
    Query(q): Query<ListQuery>,
61 
) -> Result<Page<ProposalsPage>, Error> {
62 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposals"), &viewer);
63 
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
64 
    let all = pdb::list(&app.db, row.id, &[]).await.map_err(|e| Error::from_db(shell.clone(), e))?;
65 
    let counts = (
66 
        all.iter().filter(|p| p.is_open()).count(),
67 
        all.iter().filter(|p| p.state == "landed").count(),
68 
        all.iter().filter(|p| p.state == "closed").count(),
69 
    );
70 
    let filter = q.state.unwrap_or_else(|| "open".into());
71 
    let mut labels: std::collections::HashMap<i64, Vec<db::issues::Label>> = std::collections::HashMap::new();
72 
    for (id, l) in db::issues::labels_by_proposal(&app.db, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))? {
73 
        labels.entry(id).or_default().push(l);
74 
    }
75 
    // `author:bob label:ui target:main words…`
76 
    let qtext = q.q.clone().unwrap_or_default();
77 
    let (mut authors, mut wanted, mut targets, mut words) = (vec![], vec![], vec![], vec![]);
78 
    for tok in qtext.split_whitespace() {
79 
        match tok.split_once(':') {
80 
            Some(("author", v)) => authors.push(v.to_lowercase()),
81 
            Some(("label", v)) => wanted.push(v.to_lowercase()),
82 
            Some(("target", v)) => targets.push(v.to_string()),
83 
            _ => words.push(tok.to_lowercase()),
84 
        }
85 
    }
86 
    let mut rows: Vec<pdb::ProposalRow> = all
87 
        .into_iter()
88 
        .filter(|p| match filter.as_str() {
89 
            "open" => p.is_open(),
90 
            "landed" => p.state == "landed",
91 
            "closed" => p.state == "closed",
92 
            _ => true,
93 
        })
94 
        .filter(|p| authors.is_empty() || authors.contains(&p.author.to_lowercase()))
95 
        .filter(|p| targets.is_empty() || targets.contains(&p.target))
96 
        .filter(|p| wanted.iter().all(|w| labels.get(&p.id).is_some_and(|ls| ls.iter().any(|l| l.name.to_lowercase() == *w))))
97 
        .filter(|p| words.iter().all(|w| p.title.to_lowercase().contains(w) || p.body.to_lowercase().contains(w)))
98 
        .collect();
99 
    let sort = q.sort.filter(|s| SORTS.iter().any(|(k, _)| k == s)).unwrap_or_else(|| "updated".into());
100 
    match sort.as_str() {
101 
        "newest" => rows.sort_by_key(|p| std::cmp::Reverse(p.number)),
102 
        "oldest" => rows.sort_by_key(|p| p.number),
103 
        _ => rows.sort_by_key(|p| std::cmp::Reverse(p.updated_ms)),
104 
    }
105 
    let pager = super::Pager::new(rows.len(), q.page, &[("state", &filter), ("q", &qtext), ("sort", &sort)]);
106 
    let rows = pager.slice(rows);
107 
    let bookmarks = app
108 
        .repos
109 
        .read(&repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>()))
110 
        .await
111 
        .map_err(|e| Error::from_repo(shell.clone(), e))?;
112 
    Ok(Page(ProposalsPage {
113 
        shell,
114 
        repo: RepoShell::new(&app, &row, "proposals").with_role(role),
115 
        rows,
116 
        filter,
117 
        counts,
118 
        bookmarks,
119 
        q: qtext,
120 
        sort,
121 
        pager,
122 
        labels,
123 
    }))
124 
}
125
126 
// ------------------------------------------------------------------- new
127
128 
#[derive(Template)]
129 
#[template(path = "proposal_new.html")]
130 
pub struct NewProposalPage {
131 
    shell: Shell,
132 
    repo: RepoShell,
133 
    bookmarks: Vec<String>,
134 
    source: String,
135 
    target: String,
136 
    error: Option<String>,
137 
    /// Preview: the changes the proposal would add.
138 
    preview: Vec<ChangeView>,
139 
    conflicted: bool,
140 
}
141
142 
#[derive(Deserialize)]
143 
pub struct NewQuery {
144 
    source: Option<String>,
145 
    target: Option<String>,
146 
}
147
148 
/// `owner/name:bookmark` for a fork, else a bookmark of this repository.
149 
fn parse_source(app: &Shared, repo: &RepoName, source: &str) -> Option<(Option<RepoName>, String)> {
150 
    if let Some((slug, bookmark)) = source.split_once(':') {
151 
        let fork = RepoName::parse(slug)?;
152 
        if !app.repos.exists(&fork) || fork == *repo {
153 
            return None;
154 
        }
155 
        return Some((Some(fork), bookmark.to_string()));
156 
    }
157 
    crate::repos::names::valid_segment(source).then(|| (None, source.to_string()))
158 
}
159
160 
async fn preview_for(
161 
    app: &Shared,
162 
    repo: &RepoName,
163 
    target: &str,
164 
    source: &str,
165 
) -> Result<(Vec<ChangeView>, bool), crate::repos::RepoError> {
166 
    let Some((fork, bookmark)) = parse_source(app, repo, source) else { return Ok((vec![], false)) };
167 
    let target = target.to_string();
168 
    let fork_dir = fork.as_ref().map(|f| app.repos.dir(f));
169 
    app.repos
170 
        .read(repo, move |r, cache| {
171 
            let projection = match &fork_dir {
172 
                Some(dir) => {
173 
                    let fork_repo = oxy_core::repo::Repo::open(dir)?;
174 
                    let heads = fork_repo.bookmarks()?.into_iter().find(|b| b.name == bookmark).map(|b| b.heads).unwrap_or_default();
175 
                    pl::project(r, cache, &target, Source::Fork { fork: &fork_repo, heads })?
176 
                }
177 
                None => {
178 
                    let heads = r.bookmarks()?.into_iter().find(|b| b.name == bookmark).map(|b| b.heads).unwrap_or_default();
179 
                    pl::project(r, cache, &target, Source::Bookmark(heads))?
180 
                }
181 
            };
182 
            Ok((projection.changes, projection.conflicted))
183 
        })
184 
        .await
185 
}
186
187 
pub async fn new_form(
188 
    State(app): State<Shared>,
189 
    viewer: Viewer,
190 
    Path((owner, name)): Path<(String, String)>,
191 
    Query(q): Query<NewQuery>,
192 
) -> Result<Page<NewProposalPage>, Error> {
193 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposals/new"), &viewer);
194 
    require(&viewer, &shell)?;
195 
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
196 
    let bookmarks = app
197 
        .repos
198 
        .read(&repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>()))
199 
        .await
200 
        .map_err(|e| Error::from_repo(shell.clone(), e))?;
201 
    let target = q.target.unwrap_or_else(|| row.default_bookmark.clone());
202 
    let source = q.source.unwrap_or_default();
203 
    let (preview, conflicted) =
204 
        if source.is_empty() { (vec![], false) } else { preview_for(&app, &repo, &target, &source).await.unwrap_or((vec![], false)) };
205 
    Ok(Page(NewProposalPage {
206 
        shell,
207 
        repo: RepoShell::new(&app, &row, "proposals").with_role(role),
208 
        bookmarks,
209 
        source,
210 
        target,
211 
        error: None,
212 
        preview,
213 
        conflicted,
214 
    }))
215 
}
216
217 
#[derive(Deserialize)]
218 
pub struct NewForm {
219 
    #[serde(rename = "_csrf")]
220 
    csrf_token: String,
221 
    title: String,
222 
    #[serde(default)]
223 
    body: String,
224 
    target: String,
225 
    source: String,
226 
    #[serde(default)]
227 
    draft: Option<String>,
228 
}
229
230 
/// Open a proposal from a form or the API: validate, create, index, notify.
231 
#[allow(clippy::too_many_arguments)]
232 
pub async fn open_proposal(
233 
    app: &Shared,
234 
    repo: &RepoName,
235 
    row: &db::repos::RepoRow,
236 
    me: &accounts::Account,
237 
    title: &str,
238 
    body: &str,
239 
    target: &str,
240 
    source: &str,
241 
    draft: bool,
242 
) -> Result<pdb::ProposalRow, String> {
243 
    if title.trim().is_empty() {
244 
        return Err("Give the proposal a title.".into());
245 
    }
246 
    let bookmarks =
247 
        app.repos.read(repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>())).await.map_err(|e| e.to_string())?;
248 
    if !bookmarks.iter().any(|b| b == target) {
249 
        return Err("Pick a target bookmark of this repository.".into());
250 
    }
251 
    let Some((fork, bookmark)) = parse_source(app, repo, source.trim()) else {
252 
        return Err("The source is a bookmark of this repository, or owner/name:bookmark of a fork.".into());
253 
    };
254 
    if fork.is_none() && bookmark == target {
255 
        return Err("The source and the target are the same bookmark.".into());
256 
    }
257 
    let (preview, _) = preview_for(app, repo, target, source.trim()).await.map_err(|e| e.to_string())?;
258 
    if preview.is_empty() {
259 
        return Err("The source adds nothing to the target.".into());
260 
    }
261 
    let source_repo_id = match &fork {
262 
        Some(fk) => db::repos::get(&app.db, &fk.owner, &fk.name).await.map_err(|e| e.to_string())?.map(|r| r.id),
263 
        None => None,
264 
    };
265 
    let created = pdb::create(
266 
        &app.db,
267 
        pdb::NewProposal {
268 
            repo_id: row.id,
269 
            title: title.trim(),
270 
            body: body.trim(),
271 
            author_id: Some(me.id),
272 
            author: &me.username,
273 
            draft,
274 
            target,
275 
            source_kind: if fork.is_some() { "fork" } else { "bookmark" },
276 
            source_repo_id,
277 
            source_bookmark: &bookmark,
278 
            source_changes: "",
279 
        },
280 
    )
281 
    .await
282 
    .map_err(|e| e.to_string())?;
283 
    pdb::add_event(&app.db, created.id, &me.username, "opened", "").await.ok();
284 
    accounts::audit(&app.db, Some(me), "proposal.opened", &format!("{}#{}", row.slug(), created.number), title).await.ok();
285 
    db::notify::index(&app.db, "proposal", row.id, created.id, created.number, &created.title, &created.body).await.ok();
286 
    let url = format!("/{}/proposal/{}", row.slug(), created.number);
287 
    crate::notify::deliver(
288 
        app,
289 
        crate::notify::Event {
290 
            kind: "proposal.opened",
291 
            title: format!("{}#{}: {}", row.slug(), created.number, created.title),
292 
            url,
293 
            actor: me,
294 
            repo_id: row.id,
295 
            thread: Some(("proposal", created.id)),
296 
            mention_text: body,
297 
            direct: vec![],
298 
        },
299 
    )
300 
    .await;
301 
    crate::hooks::emit(
302 
        app,
303 
        row,
304 
        "proposal.opened",
305 
        &me.username,
306 
        serde_json::json!({ "number": created.number, "title": created.title, "target": target, "source": source }),
307 
    )
308 
    .await;
309 
    Ok(created)
310 
}
311
312 
pub async fn create(
313 
    State(app): State<Shared>,
314 
    viewer: Viewer,
315 
    Path((owner, name)): Path<(String, String)>,
316 
    Form(f): Form<NewForm>,
317 
) -> Result<Response, Error> {
318 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposals/new"), &viewer);
319 
    let me = require(&viewer, &shell)?;
320 
    csrf(&viewer, &f.csrf_token, &shell)?;
321 
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
322 
    match open_proposal(&app, &repo, &row, &me.account, &f.title, &f.body, &f.target, &f.source, f.draft.is_some()).await {
323 
        Ok(created) => Ok(Redirect::to(&format!("/{owner}/{name}/proposal/{}", created.number)).into_response()),
324 
        Err(msg) => {
325 
            let bookmarks =
326 
                app.repos.read(&repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>())).await.unwrap_or_default();
327 
            Ok(Page(NewProposalPage {
328 
                shell,
329 
                repo: RepoShell::new(&app, &row, "proposals").with_role(role),
330 
                bookmarks,
331 
                source: f.source.clone(),
332 
                target: f.target.clone(),
333 
                error: Some(msg),
334 
                preview: vec![],
335 
                conflicted: false,
336 
            })
337 
            .into_response())
338 
        }
339 
    }
340 
}
341
342 
// ---------------------------------------------------------------- detail
343
344 
/// A comment placed on a diff row, or general.
345 
pub struct CommentView {
346 
    pub row: pdb::CommentRow,
347 
    pub body_html: String,
348 
    pub line: Option<usize>,
349 
}
350
351 
/// One entry of a proposal's conversation, in time order: what kind it
352 
/// is and its index in `comments`, `reviews` or `events`.
353 
pub struct Entry {
354 
    pub kind: &'static str,
355 
    pub index: usize,
356 
}
357
358 
pub struct ReviewView {
359 
    pub row: pdb::ReviewRow,
360 
    pub body_html: String,
361 
    pub sealed: bool,
362 
}
363
364 
/// Everything the detail page and the API need, computed once under the lock.
365 
pub struct Loaded {
366 
    pub row: pdb::ProposalRow,
367 
    pub changes: Vec<ChangeView>,
368 
    pub hashes: Vec<ChangeHash>,
369 
    pub heads: Vec<ChangeHash>,
370 
    pub target_heads: Vec<ChangeHash>,
371 
    pub state: String,
372 
    pub target_state: String,
373 
    pub conflicted: bool,
374 
    pub conflicts: Vec<ConflictView>,
375 
    pub files: Vec<FileRows>,
376 
    /// The per-file hunks and bases behind `files`, to render again with other options.
377 
    pub diffs: Vec<oxy_core::repo::FileDiff>,
378 
    pub bases: std::collections::BTreeMap<String, Vec<u8>>,
379 
    /// Atom per (path, new line number) of the projected state.
380 
    pub atoms: HashMap<(String, usize), (String, u32)>,
381 
    pub sealing_keys: Vec<String>,
382 
    pub touched: Vec<String>,
383 
    pub owners: Vec<String>,
384 
    pub landed_already: bool,
385 
}
386
387 
/// Compute the projection and everything derived from it.
388 
pub async fn load(app: &Shared, repo: &RepoName, row: pdb::ProposalRow) -> Result<Loaded, crate::repos::RepoError> {
389 
    let fork_dir = match (row.source_kind.as_str(), row.source_repo_id) {
390 
        ("fork", Some(id)) => {
391 
            db::repos::get_by_id(&app.db, id).await.ok().flatten().and_then(|r| RepoName::new(&r.owner, &r.name)).map(|n| app.repos.dir(&n))
392 
        }
393 
        _ => None,
394 
    };
395 
    let r2 = row.clone();
396 
    let loaded = app
397 
        .repos
398 
        .read(repo, move |r, cache| {
399 
            let source = match (r2.source_kind.as_str(), &fork_dir) {
400 
                ("changes", _) => Source::Changes(r2.source_changes().iter().filter_map(|h| ChangeHash::from_hex(h)).collect()),
401 
                ("fork", Some(dir)) => {
402 
                    let fork_repo = oxy_core::repo::Repo::open(dir)?;
403 
                    let heads =
404 
                        fork_repo.bookmarks()?.into_iter().find(|b| b.name == r2.source_bookmark).map(|b| b.heads).unwrap_or_default();
405 
                    // Bring the fork's changes over now, so the projection below can read them.
406 
                    let fork_state = fork_repo.load_state(&heads)?;
407 
                    let missing: Vec<ChangeHash> = fork_state.changes().map(|(h, _)| *h).filter(|h| !r.store().has(h)).collect();
408 
                    if !missing.is_empty() {
409 
                        r.import_bundle(&fork_repo.bundle_for(&missing)?, r.current_policy()?.is_some())?;
410 
                    }
411 
                    Source::Changes(heads)
412 
                }
413 
                _ => {
414 
                    let heads = r.bookmarks()?.into_iter().find(|b| b.name == r2.source_bookmark).map(|b| b.heads).unwrap_or_default();
415 
                    Source::Bookmark(heads)
416 
                }
417 
            };
418 
            let p: Projection = pl::project(r, cache, &r2.target, source)?;
419 
            let target_loaded = cache.load(r, &p.target_heads)?;
420 
            let files = render_files(&p.files, &p.bases);
421 
            let mut atoms = HashMap::new();
422 
            for f in &files {
423 
                for l in &f.lines {
424 
                    if let Some(n) = l.new_no {
425 
                        if let Some((h, i)) = pl::atom_at(&p.loaded, &f.path, n as usize) {
426 
                            atoms.insert((f.path.clone(), n as usize), (h.to_hex(), i));
427 
                        }
428 
                    }
429 
                }
430 
            }
431 
            let touched: Vec<String> = p.files.iter().map(|f| f.path.clone()).collect();
432 
            let owners = pl::owners_for(&target_loaded, &touched);
433 
            let sealing = pl::sealing_keys(r, &p.hashes)?.into_iter().map(|k| k.to_hex()).collect();
434 
            let landed_already = !p.hashes.is_empty() && p.hashes.iter().all(|h| target_loaded.state.contains(h));
435 
            Ok(Loaded {
436 
                row: r2,
437 
                changes: p.changes,
438 
                hashes: p.hashes,
439 
                heads: p.heads,
440 
                target_heads: p.target_heads.clone(),
441 
                state: p.state.to_hex(),
442 
                target_state: p.target_state.to_hex(),
443 
                conflicted: p.conflicted,
444 
                conflicts: p.conflicts,
445 
                files,
446 
                diffs: p.files.clone(),
447 
                bases: p.bases.clone(),
448 
                atoms,
449 
                sealing_keys: sealing,
450 
                touched,
451 
                owners,
452 
                landed_already,
453 
            })
454 
        })
455 
        .await?;
456 
    // Remember the projection for the list, the API and other proposals' stacking checks.
457 
    let heads_csv = loaded.heads.iter().map(|h| h.to_hex()).collect::<Vec<_>>().join(",");
458 
    let changes_csv = loaded.hashes.iter().map(|h| h.to_hex()).collect::<Vec<_>>().join(",");
459 
    pdb::set_projection(&app.db, loaded.row.id, &loaded.state, &heads_csv, &loaded.target_state, &changes_csv, loaded.conflicted)
460 
        .await
461 
        .ok();
462 
    Ok(loaded)
463 
}
464
465 
/// Reviews, approvals and blockers.
466 
pub struct Verdict {
467 
    pub reviews: Vec<ReviewView>,
468 
    pub approvals: Vec<Approval>,
469 
    pub blockers: Vec<String>,
470 
    pub depends_on: Vec<i64>,
471 
    pub requirements: pdb::Requirements,
472 
}
473
474 
pub async fn verdict(app: &Shared, loaded: &Loaded, repo_id: i64) -> Result<Verdict, sqlx::Error> {
475 
    let rows = pdb::reviews(&app.db, loaded.row.id).await?;
476 
    let links = accounts::identity_accounts(&app.db).await?;
477 
    let sealed_accounts: Vec<String> = links.iter().filter(|(k, _)| loaded.sealing_keys.contains(k)).map(|(_, u)| u.clone()).collect();
478 
    // Latest verdict per reviewer.
479 
    let mut latest: BTreeMap<String, &pdb::ReviewRow> = BTreeMap::new();
480 
    for r in &rows {
481 
        latest.insert(r.author.clone(), r);
482 
    }
483 
    let mut approvals = Vec::new();
484 
    for (who, r) in &latest {
485 
        if r.verdict == "approve" {
486 
            let sealed = sealed_accounts.contains(who);
487 
            let key = links.iter().find(|(k, u)| u == who && loaded.sealing_keys.contains(k)).map(|(k, _)| k.clone());
488 
            approvals.push(Approval { account: who.clone(), sealed, key });
489 
        }
490 
    }
491 
    let reviews = rows
492 
        .iter()
493 
        .map(|r| ReviewView {
494 
            row: r.clone(),
495 
            body_html: render::markdown::render(&r.body, "/", "/"),
496 
            sealed: r.verdict == "approve" && sealed_accounts.contains(&r.author),
497 
        })
498 
        .collect();
499 
    let requirements = pdb::requirements(&app.db, repo_id).await?;
500 
    let mut blockers = Vec::new();
501 
    if loaded.row.state == "draft" {
502 
        blockers.push("the proposal is a draft".into());
503 
    }
504 
    if loaded.hashes.is_empty() {
505 
        blockers.push("the proposal adds no changes".into());
506 
    }
507 
    let sealed_count = approvals.iter().filter(|a| a.sealed).count() as i64;
508 
    if sealed_count < requirements.required_approvals {
509 
        blockers.push(format!("{sealed_count} of {} required sealed approvals", requirements.required_approvals));
510 
    }
511 
    if requirements.require_owners {
512 
        let missing: Vec<&String> = loaded.owners.iter().filter(|o| !approvals.iter().any(|a| a.sealed && &a.account == *o)).collect();
513 
        if !missing.is_empty() {
514 
            blockers.push(format!("code owners still to approve: {}", missing.iter().map(|s| s.as_str()).collect::<Vec<_>>().join(", ")));
515 
        }
516 
    }
517 
    if loaded.conflicted && !requirements.allow_conflicts {
518 
        blockers.push("landing would carry conflicts, which this repository refuses".into());
519 
    }
520 
    let required = db::hooks::required_checks(&app.db, repo_id).await?;
521 
    if !required.is_empty() {
522 
        let checks = db::hooks::checks_for_state(&app.db, repo_id, &loaded.state).await?;
523 
        let missing: Vec<String> =
524 
            required.iter().filter(|n| !checks.iter().any(|c| &c.name == *n && c.status == "passed")).cloned().collect();
525 
        if !missing.is_empty() {
526 
            blockers.push(format!("required checks not passed on the projected state: {}", missing.join(", ")));
527 
        }
528 
    }
529 
    let requesting: Vec<&String> = latest.iter().filter(|(_, r)| r.verdict == "changes").map(|(who, _)| who).collect();
530 
    if !requesting.is_empty() {
531 
        blockers.push(format!("changes requested by {}", requesting.iter().map(|s| s.as_str()).collect::<Vec<_>>().join(", ")));
532 
    }
533 
    // Stacking: another open, earlier proposal whose changes this one includes.
534 
    let mut depends_on = Vec::new();
535 
    for other in pdb::list(&app.db, repo_id, &["open", "draft"]).await? {
536 
        if other.id == loaded.row.id || other.number > loaded.row.number {
537 
            continue;
538 
        }
539 
        let theirs = other.projected_changes();
540 
        if !theirs.is_empty() && theirs.iter().all(|h| loaded.hashes.iter().any(|m| m.to_hex() == *h)) {
541 
            depends_on.push(other.number);
542 
        }
543 
    }
544 
    if !depends_on.is_empty() {
545 
        blockers.push(format!("depends on {}", depends_on.iter().map(|n| format!("#{n}")).collect::<Vec<_>>().join(", ")));
546 
    }
547 
    Ok(Verdict { reviews, approvals, blockers, depends_on, requirements })
548 
}
549
550 
#[derive(Template)]
551 
#[template(path = "proposal.html")]
552 
pub struct ProposalPage {
553 
    shell: Shell,
554 
    repo: RepoShell,
555 
    p: pdb::ProposalRow,
556 
    /// Issues it closes, from its description and its changes.
557 
    closes: Vec<super::chain::Link>,
558 
    /// Projects the viewer may add it to.
559 
    project_choices: Option<Vec<db::projects::Project>>,
560 
    /// Comments (not anchored to a line), reviews and events, oldest first.
561 
    timeline: Vec<Entry>,
562 
    /// The viewer may set labels (triage or above).
563 
    can_triage: bool,
564 
    body_html: String,
565 
    tab: String,
566 
    changes: Vec<ChangeView>,
567 
    files: Vec<FileRows>,
568 
    diffs: Vec<oxy_core::repo::FileDiff>,
569 
    bases: std::collections::BTreeMap<String, Vec<u8>>,
570 
    /// Whitespace-only changes are hidden (`?w=1`).
571 
    ignore_ws: bool,
572 
    conflicts: Vec<ConflictView>,
573 
    conflicted: bool,
574 
    comments: Vec<CommentView>,
575 
    /// Anchored comments by (path, current line).
576 
    placed: HashMap<(String, usize), Vec<usize>>,
577 
    outdated: Vec<usize>,
578 
    reviews: Vec<ReviewView>,
579 
    approvals: Vec<Approval>,
580 
    blockers: Vec<String>,
581 
    depends_on: Vec<i64>,
582 
    events: Vec<pdb::EventRow>,
583 
    owners: Vec<String>,
584 
    requirements: pdb::Requirements,
585 
    landed_already: bool,
586 
    can_edit: bool,
587 
    can_land: bool,
588 
    hub_can_land: bool,
589 
    notice: Option<String>,
590 
    error: Option<String>,
591 
    heads: Vec<String>,
592 
    state_hash: String,
593 
    source_label: String,
594 
    api_url: String,
595 
    labels: Vec<db::issues::Label>,
596 
    all_labels: Vec<db::issues::Label>,
597 
    checks: Vec<db::hooks::Check>,
598 
    required_checks: Vec<String>,
599 
    /// Projects this proposal is on that the viewer may see, with the column.
600 
    projects: Vec<(db::projects::Project, String)>,
601 
}
602
603 
#[derive(Deserialize)]
604 
pub struct DetailQuery {
605 
    tab: Option<String>,
606 
    /// What an action said, after it redirected here.
607 
    #[serde(default)]
608 
    notice: Option<String>,
609 
    #[serde(default)]
610 
    error: Option<String>,
611 
    #[serde(default)]
612 
    w: Option<String>,
613 
}
614
615 
/// The page assembler every action ends in; its arguments are the route
616 
/// plus what to say, and a struct would only rename them.
617 
#[allow(clippy::too_many_arguments)]
618 
async fn detail(
619 
    app: &Shared,
620 
    shell: Shell,
621 
    viewer: &Viewer,
622 
    owner: &str,
623 
    name: &str,
624 
    number: i64,
625 
    tab: String,
626 
    notice: Option<String>,
627 
    error: Option<String>,
628 
) -> Result<Page<ProposalPage>, Error> {
629 
    let (repo, row, role) = lookup(app, &shell, viewer, owner, name).await?;
630 
    let p = pdb::get(&app.db, row.id, number)
631 
        .await
632 
        .map_err(|e| Error::from_db(shell.clone(), e))?
633 
        .ok_or_else(|| Error::not_found(shell.clone()))?;
634 
    let loaded = load(app, &repo, p).await.map_err(|e| Error::from_repo(shell.clone(), e))?;
635 
    // A proposal whose changes all reached the target landed by another route.
636 
    if loaded.landed_already && loaded.row.is_open() {
637 
        pdb::set_state(&app.db, loaded.row.id, "landed", &loaded.target_state).await.ok();
638 
        pdb::add_event(&app.db, loaded.row.id, "", "landed", "every change reached the target").await.ok();
639 
    }
640 
    let p = pdb::get(&app.db, row.id, number).await.map_err(|e| Error::from_db(shell.clone(), e))?.unwrap_or(loaded.row.clone());
641 
    let v = verdict(app, &loaded, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
642 
    let comment_rows = pdb::comments(&app.db, loaded.row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
643 
    let events = pdb::events(&app.db, loaded.row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
644 
    // Place anchored comments at their atom's current line.
645 
    let mut by_atom: HashMap<(String, String, u32), usize> = HashMap::new();
646 
    for ((path, line), (h, i)) in &loaded.atoms {
647 
        by_atom.insert((path.clone(), h.clone(), *i), *line);
648 
    }
649 
    let mut comments = Vec::new();
650 
    let mut placed: HashMap<(String, usize), Vec<usize>> = HashMap::new();
651 
    let mut outdated = Vec::new();
652 
    for (idx, c) in comment_rows.into_iter().enumerate() {
653 
        let line = if c.anchor_change.is_empty() {
654 
            None
655 
        } else {
656 
            by_atom.get(&(c.path.clone(), c.anchor_change.clone(), c.anchor_index as u32)).copied()
657 
        };
658 
        if !c.anchor_change.is_empty() {
659 
            match line {
660 
                Some(l) => placed.entry((c.path.clone(), l)).or_default().push(idx),
661 
                None => outdated.push(idx),
662 
            }
663 
        }
664 
        comments.push(CommentView { body_html: render::markdown::render(&c.body, "/", "/"), row: c, line });
665 
    }
666 
    let mut changes = loaded.changes.clone();
667 
    super::attribute(app, &mut changes.iter_mut().collect::<Vec<_>>()).await;
668 
    let me = viewer.account();
669 
    let can_edit = me.is_some_and(|a| Some(a.id) == p.author_id || role >= Role::Maintain);
670 
    let can_land = role >= Role::Write && p.is_open() && v.blockers.is_empty();
671 
    let delegated = match viewer.account() {
672 
        Some(a) => super::edit::delegated_identity(app, a.id).await.is_some(),
673 
        None => false,
674 
    };
675 
    let hub_can_land = delegated || app.repos.read(&repo, |r, _| Ok(r.current_policy()?.is_none())).await.unwrap_or(false);
676 
    let source_label = match p.source_kind.as_str() {
677 
        "fork" => format!(
678 
            "fork {}",
679 
            db::repos::get_by_id(&app.db, p.source_repo_id.unwrap_or(0))
680 
                .await
681 
                .ok()
682 
                .flatten()
683 
                .map(|r| format!("{}:{}", r.slug(), p.source_bookmark))
684 
                .unwrap_or_default()
685 
        ),
686 
        "changes" => format!("{} changes", p.source_changes().len()),
687 
        _ => p.source_bookmark.clone(),
688 
    };
689 
    let projects = super::projects::placements_for(app, viewer, &row, p.number).await;
690 
    let texts: Vec<String> = std::iter::once(p.body.clone()).chain(changes.iter().map(|c| format!("{}\n{}", c.title, c.body))).collect();
691 
    let closes = super::chain::issues_closed_by(app, &row, &texts.iter().map(String::as_str).collect::<Vec<_>>()).await;
692 
    let project_choices = super::projects::project_choices(app, viewer, &row, &projects).await;
693 
    let mut dated: Vec<(i64, Entry)> = Vec::new();
694 
    for (index, c) in comments.iter().enumerate() {
695 
        if c.row.anchor_change.is_empty() {
696 
            dated.push((c.row.created_ms, Entry { kind: "comment", index }));
697 
        }
698 
    }
699 
    for (index, r) in v.reviews.iter().enumerate() {
700 
        dated.push((r.row.created_ms, Entry { kind: "review", index }));
701 
    }
702 
    for (index, e) in events.iter().enumerate() {
703 
        dated.push((e.at_ms, Entry { kind: "event", index }));
704 
    }
705 
    dated.sort_by_key(|(at, _)| *at);
706 
    let timeline: Vec<Entry> = dated.into_iter().map(|(_, e)| e).collect();
707 
    Ok(Page(ProposalPage {
708 
        can_triage: role >= Role::Triage,
709 
        timeline,
710 
        closes,
711 
        project_choices,
712 
        projects,
713 
        shell,
714 
        repo: RepoShell::new(app, &row, "proposals").with_role(role),
715 
        body_html: super::issues::markdown(app, &row, &row.default_bookmark, &p.body).await,
716 
        p,
717 
        tab,
718 
        changes,
719 
        files: loaded.files,
720 
        diffs: loaded.diffs,
721 
        bases: loaded.bases,
722 
        ignore_ws: false,
723 
        conflicts: loaded.conflicts,
724 
        conflicted: loaded.conflicted,
725 
        comments,
726 
        placed,
727 
        outdated,
728 
        reviews: v.reviews,
729 
        approvals: v.approvals,
730 
        blockers: v.blockers,
731 
        depends_on: v.depends_on,
732 
        events,
733 
        owners: loaded.owners,
734 
        requirements: v.requirements,
735 
        landed_already: loaded.landed_already,
736 
        can_edit,
737 
        can_land,
738 
        hub_can_land,
739 
        notice,
740 
        error,
741 
        heads: loaded.heads.iter().map(|h| h.to_hex()).collect(),
742 
        state_hash: loaded.state.clone(),
743 
        source_label,
744 
        api_url: format!("{}/api/v1/repos/{owner}/{name}/proposals/{number}", app.config.base_url()),
745 
        labels: db::issues::proposal_labels(&app.db, loaded.row.id).await.unwrap_or_default(),
746 
        all_labels: db::issues::labels(&app.db, row.id).await.unwrap_or_default(),
747 
        checks: db::hooks::checks_for_state(&app.db, row.id, &loaded.state).await.unwrap_or_default(),
748 
        required_checks: db::hooks::required_checks(&app.db, row.id).await.unwrap_or_default(),
749 
    }))
750 
}
751
752 
/// Back to the proposal after an action, with what to say: a redirect, so
753 
/// reloading the page (the checks script does) never repeats the action.
754 
fn back(owner: &str, name: &str, number: i64, tab: &str, notice: Option<String>, error: Option<String>) -> Response {
755 
    let mut url = format!("/{owner}/{name}/proposal/{number}?tab={tab}");
756 
    if let Some(n) = notice {
757 
        url.push_str(&format!("&notice={}", super::settings::urlencode(&n)));
758 
    }
759 
    if let Some(e) = error {
760 
        url.push_str(&format!("&error={}", super::settings::urlencode(&e)));
761 
    }
762 
    Redirect::to(&url).into_response()
763 
}
764
765 
pub async fn show(
766 
    State(app): State<Shared>,
767 
    viewer: Viewer,
768 
    Path((owner, name, number)): Path<(String, String, i64)>,
769 
    Query(q): Query<DetailQuery>,
770 
) -> Result<Page<ProposalPage>, Error> {
771 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
772 
    let mut page =
773 
        detail(&app, shell, &viewer, &owner, &name, number, q.tab.unwrap_or_else(|| "conversation".into()), q.notice, q.error).await?;
774 
    if q.w.as_deref() == Some("1") {
775 
        // Hide whitespace-only changes: the same hunks, rendered again.
776 
        page.0.files =
777 
            super::history::render_files_with(&page.0.diffs, &page.0.bases, crate::render::diff::Options { ignore_whitespace: true });
778 
        page.0.ignore_ws = true;
779 
    }
780 
    Ok(page)
781 
}
782
783 
// ---------------------------------------------------------------- actions
784
785 
#[derive(Deserialize)]
786 
pub struct CommentForm {
787 
    #[serde(rename = "_csrf")]
788 
    csrf_token: String,
789 
    body: String,
790 
    #[serde(default)]
791 
    path: String,
792 
    #[serde(default)]
793 
    line: Option<usize>,
794 
}
795
796 
pub async fn comment(
797 
    State(app): State<Shared>,
798 
    viewer: Viewer,
799 
    Path((owner, name, number)): Path<(String, String, i64)>,
800 
    Form(f): Form<CommentForm>,
801 
) -> Result<Response, Error> {
802 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
803 
    let me = require(&viewer, &shell)?;
804 
    csrf(&viewer, &f.csrf_token, &shell)?;
805 
    let (repo, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
806 
    let p = pdb::get(&app.db, row.id, number)
807 
        .await
808 
        .map_err(|e| Error::from_db(shell.clone(), e))?
809 
        .ok_or_else(|| Error::not_found(shell.clone()))?;
810 
    if f.body.trim().is_empty() {
811 
        return Ok(back(&owner, &name, number, "conversation", None, Some("An empty comment says nothing.".into())));
812 
    }
813 
    let anchor = match (f.path.trim(), f.line) {
814 
        ("", _) | (_, None) => None,
815 
        (path, Some(line)) => {
816 
            let loaded = load(&app, &repo, p.clone()).await.map_err(|e| Error::from_repo(shell.clone(), e))?;
817 
            loaded.atoms.get(&(path.to_string(), line)).cloned()
818 
        }
819 
    };
820 
    let tab = if anchor.is_some() { "files" } else { "conversation" };
821 
    pdb::add_comment(
822 
        &app.db,
823 
        p.id,
824 
        Some(me.account.id),
825 
        &me.account.username,
826 
        f.body.trim(),
827 
        f.path.trim(),
828 
        anchor.as_ref().map(|(h, i)| (h.as_str(), *i as i64)),
829 
    )
830 
    .await
831 
    .map_err(|e| Error::from_db(shell.clone(), e))?;
832 
    Ok(back(&owner, &name, number, tab, None, None))
833 
}
834
835 
#[derive(Deserialize)]
836 
pub struct ReviewForm {
837 
    #[serde(rename = "_csrf")]
838 
    csrf_token: String,
839 
    verdict: String,
840 
    #[serde(default)]
841 
    body: String,
842 
}
843
844 
pub async fn review(
845 
    State(app): State<Shared>,
846 
    viewer: Viewer,
847 
    Path((owner, name, number)): Path<(String, String, i64)>,
848 
    Form(f): Form<ReviewForm>,
849 
) -> Result<Response, Error> {
850 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
851 
    let me = require(&viewer, &shell)?;
852 
    csrf(&viewer, &f.csrf_token, &shell)?;
853 
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
854 
    let p = pdb::get(&app.db, row.id, number)
855 
        .await
856 
        .map_err(|e| Error::from_db(shell.clone(), e))?
857 
        .ok_or_else(|| Error::not_found(shell.clone()))?;
858 
    if !matches!(f.verdict.as_str(), "comment" | "changes" | "approve") {
859 
        return Err(Error::bad(shell, "a review is comment, changes or approve"));
860 
    }
861 
    if f.verdict == "approve" && Some(me.account.id) == p.author_id {
862 
        return Ok(back(&owner, &name, number, "conversation", None, Some("You cannot approve your own proposal.".into())));
863 
    }
864 
    pdb::add_review(&app.db, p.id, me.account.id, &me.account.username, &f.verdict, f.body.trim())
865 
        .await
866 
        .map_err(|e| Error::from_db(shell.clone(), e))?;
867 
    pdb::add_event(&app.db, p.id, &me.account.username, &format!("review.{}", f.verdict), "").await.ok();
868 
    crate::hooks::emit(&app, &row, "review", &me.account.username, serde_json::json!({ "number": number, "verdict": f.verdict })).await;
869 
    let notice = if f.verdict == "approve" {
870 
        Some(format!(
871 
            "Approval recorded. It counts once you seal the changes: oxy seal --proposal {}/{owner}/{name}/proposal/{number}",
872 
            app.config.base_url()
873 
        ))
874 
    } else {
875 
        None
876 
    };
877 
    Ok(back(&owner, &name, number, "conversation", notice, None))
878 
}
879
880 
#[derive(Deserialize)]
881 
pub struct EditForm {
882 
    #[serde(rename = "_csrf")]
883 
    csrf_token: String,
884 
    title: String,
885 
    #[serde(default)]
886 
    body: String,
887 
    target: String,
888 
}
889
890 
pub async fn edit(
891 
    State(app): State<Shared>,
892 
    viewer: Viewer,
893 
    Path((owner, name, number)): Path<(String, String, i64)>,
894 
    Form(f): Form<EditForm>,
895 
) -> Result<Response, Error> {
896 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
897 
    let me = require(&viewer, &shell)?;
898 
    csrf(&viewer, &f.csrf_token, &shell)?;
899 
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
900 
    let p = pdb::get(&app.db, row.id, number)
901 
        .await
902 
        .map_err(|e| Error::from_db(shell.clone(), e))?
903 
        .ok_or_else(|| Error::not_found(shell.clone()))?;
904 
    if Some(me.account.id) != p.author_id && role < Role::Maintain {
905 
        return Err(Error::not_found(shell));
906 
    }
907 
    let target = if crate::repos::names::valid_segment(f.target.trim()) { f.target.trim() } else { &p.target };
908 
    pdb::edit(&app.db, p.id, f.title.trim(), f.body.trim(), target).await.map_err(|e| Error::from_db(shell.clone(), e))?;
909 
    pdb::add_event(&app.db, p.id, &me.account.username, "edited", "").await.ok();
910 
    Ok(back(&owner, &name, number, "conversation", Some("Saved.".into()), None))
911 
}
912
913 
#[derive(Deserialize)]
914 
pub struct StateForm {
915 
    #[serde(rename = "_csrf")]
916 
    csrf_token: String,
917 
    action: String,
918 
}
919
920 
pub async fn state(
921 
    State(app): State<Shared>,
922 
    viewer: Viewer,
923 
    Path((owner, name, number)): Path<(String, String, i64)>,
924 
    Form(f): Form<StateForm>,
925 
) -> Result<Response, Error> {
926 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
927 
    let me = require(&viewer, &shell)?;
928 
    csrf(&viewer, &f.csrf_token, &shell)?;
929 
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
930 
    let p = pdb::get(&app.db, row.id, number)
931 
        .await
932 
        .map_err(|e| Error::from_db(shell.clone(), e))?
933 
        .ok_or_else(|| Error::not_found(shell.clone()))?;
934 
    if Some(me.account.id) != p.author_id && role < Role::Triage {
935 
        return Err(Error::not_found(shell));
936 
    }
937 
    let new_state = match (f.action.as_str(), p.state.as_str()) {
938 
        ("close", "open" | "draft") => "closed",
939 
        ("reopen", "closed") => "open",
940 
        ("ready", "draft") => "open",
941 
        ("draft", "open") => "draft",
942 
        _ => return Err(Error::bad(shell, "that transition is not possible")),
943 
    };
944 
    pdb::set_state(&app.db, p.id, new_state, "").await.map_err(|e| Error::from_db(shell.clone(), e))?;
945 
    pdb::add_event(&app.db, p.id, &me.account.username, new_state, "").await.ok();
946 
    crate::hooks::emit(&app, &row, &format!("proposal.{new_state}"), &me.account.username, serde_json::json!({ "number": number })).await;
947 
    Ok(back(&owner, &name, number, "conversation", None, None))
948 
}
949
950 
pub async fn resolve_comment(
951 
    State(app): State<Shared>,
952 
    viewer: Viewer,
953 
    Path((owner, name, number, id)): Path<(String, String, i64, i64)>,
954 
    Form(f): Form<super::session::CsrfForm>,
955 
) -> Result<Response, Error> {
956 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
957 
    require(&viewer, &shell)?;
958 
    csrf(&viewer, &f.csrf, &shell)?;
959 
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
960 
    let p = pdb::get(&app.db, row.id, number)
961 
        .await
962 
        .map_err(|e| Error::from_db(shell.clone(), e))?
963 
        .ok_or_else(|| Error::not_found(shell.clone()))?;
964 
    let current: Option<bool> = sqlx::query_scalar("SELECT resolved FROM proposal_comments WHERE id = ? AND proposal_id = ?")
965 
        .bind(id)
966 
        .bind(p.id)
967 
        .fetch_optional(&app.db)
968 
        .await
969 
        .map_err(|e| Error::from_db(shell.clone(), e))?;
970 
    if let Some(r) = current {
971 
        pdb::set_comment_resolved(&app.db, id, !r).await.map_err(|e| Error::from_db(shell.clone(), e))?;
972 
    }
973 
    Ok(back(&owner, &name, number, "files", None, None))
974 
}
975
976 
/// Land from the hub: only when the repository has no trust policy (the
977 
/// hub never signs a reference update the policy would have to admit).
978 
pub async fn land(
979 
    State(app): State<Shared>,
980 
    viewer: Viewer,
981 
    Path((owner, name, number)): Path<(String, String, i64)>,
982 
    Form(f): Form<super::session::CsrfForm>,
983 
) -> Result<Response, Error> {
984 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
985 
    let me = require(&viewer, &shell)?;
986 
    csrf(&viewer, &f.csrf, &shell)?;
987 
    let (repo, row, _) = lookup_role(&app, &shell, &viewer, &owner, &name, Access::Write).await?;
988 
    match land_as(&app, &repo, &row, &me.account, number).await {
989 
        Ok(_) => Ok(back(&owner, &name, number, "conversation", Some("Landed.".into()), None)),
990 
        Err(Landing::NotFound) => Err(Error::not_found(shell)),
991 
        Err(Landing::Refused(m)) => Ok(back(&owner, &name, number, "conversation", None, Some(m))),
992 
    }
993 
}
994
995 
/// Why a proposal did not land.
996 
pub enum Landing {
997 
    NotFound,
998 
    Refused(String),
999 
}
1000
1001 
/// Land proposal `number` as `me` (hub spec §8.4), who has write access:
1002 
/// refused while it is not open or has blockers. Moves the target bookmark
1003 
/// (attested by the hub key on `me`'s behalf when they delegated to it),
1004 
/// then records, announces and audits the landing. Returns the new state.
1005 
pub async fn land_as(
1006 
    app: &Shared,
1007 
    repo: &RepoName,
1008 
    row: &db::repos::RepoRow,
1009 
    me: &accounts::Account,
1010 
    number: i64,
1011 
) -> Result<String, Landing> {
1012 
    let (owner, name) = (row.owner.clone(), row.name.clone());
1013 
    let refused = |e: String| Landing::Refused(e);
1014 
    let p = pdb::get(&app.db, row.id, number).await.map_err(|e| refused(e.to_string()))?.ok_or(Landing::NotFound)?;
1015 
    let loaded = load(app, repo, p.clone()).await.map_err(|e| refused(e.to_string()))?;
1016 
    let v = verdict(app, &loaded, row.id).await.map_err(|e| refused(e.to_string()))?;
1017 
    if !p.is_open() {
1018 
        return Err(refused(format!("Cannot land: the proposal is {}", p.state)));
1019 
    }
1020 
    if !v.blockers.is_empty() {
1021 
        return Err(refused(format!("Cannot land: {}", v.blockers.join("; "))));
1022 
    }
1023 
    let target = p.target.clone();
1024 
    let heads = loaded.heads.clone();
1025 
    // With a delegation the landing is attested by the hub key on the
1026 
    // user's behalf, which a policy accepts when it lets the user update
1027 
    // the target (spec §14.5); without one, only a policy-free repository
1028 
    // can be landed here.
1029 
    let result = match super::edit::signer_for(app, me.id).await {
1030 
        Ok(signer) => crate::repos::edits::move_bookmark(&app.repos, repo, target.clone(), heads.clone(), signer).await.map(|_| pl::state_ref(&heads).to_hex()),
1031 
        Err(why) => {
1032 
            app.repos
1033 
                .write(repo, move |r, _| {
1034 
                    if r.current_policy()?.is_some() {
1035 
                        return Err(crate::repos::RepoError::Oxy(oxy_core::repo::RepoError::Msg(format!(
1036 
                            "this repository has a trust policy, so the landing must be signed by a key it authorises. Land from a client with oxy proposal land, or delegate to the hub. {why}"
1037 
                        ))));
1038 
                    }
1039 
                    r.bookmark_set(&target, &heads)?;
1040 
                    Ok(pl::state_ref(&heads).to_hex())
1041 
                })
1042 
                .await
1043 
        }
1044 
    };
1045 
    let state = result.map_err(|e| refused(e.to_string()))?;
1046 
    pdb::set_state(&app.db, p.id, "landed", &state).await.map_err(|e| refused(e.to_string()))?;
1047 
    pdb::add_event(&app.db, p.id, &me.username, "landed", "from the hub").await.ok();
1048 
    crate::hooks::emit(
1049 
        app,
1050 
        row,
1051 
        "proposal.landed",
1052 
        &me.username,
1053 
        serde_json::json!({ "number": number, "target": p.target, "state": state }),
1054 
    )
1055 
    .await;
1056 
    crate::notify::deliver(
1057 
        app,
1058 
        crate::notify::Event {
1059 
            kind: "proposal.landed",
1060 
            title: format!("{owner}/{name}#{number}: {} landed", p.title),
1061 
            url: format!("/{owner}/{name}/proposal/{number}"),
1062 
            actor: me,
1063 
            repo_id: row.id,
1064 
            thread: Some(("proposal", p.id)),
1065 
            mention_text: "",
1066 
            direct: p.author_id.into_iter().collect(),
1067 
        },
1068 
    )
1069 
    .await;
1070 
    if p.target == row.default_bookmark {
1071 
        let messages: Vec<(String, String)> = loaded.changes.iter().map(|c| (c.hash.clone(), format!("{}\n{}", c.title, c.body))).collect();
1072 
        super::issues::close_from_messages(app, row, &messages).await;
1073 
    }
1074 
    accounts::audit(&app.db, Some(me), "proposal.landed", &format!("{owner}/{name}#{number}"), "").await.ok();
1075 
    db::repos::record_push(
1076 
        &app.db,
1077 
        row.id,
1078 
        Some((me.id, me.username.as_str())),
1079 
        &[db::repos::PushOutcome {
1080 
            reference: p.target.clone(),
1081 
            ok: true,
1082 
            reason: format!("landed #{number}"),
1083 
            old_state: loaded.target_state.clone(),
1084 
            new_state: state.clone(),
1085 
            heads: loaded.heads.len() as i64,
1086 
            changes: loaded.hashes.len() as i64,
1087 
        }],
1088 
    )
1089 
    .await
1090 
    .ok();
1091 
    Ok(state)
1092 
}
1093
1094 
#[derive(Deserialize)]
1095 
pub struct LabelsForm {
1096 
    #[serde(rename = "_csrf")]
1097 
    csrf_token: String,
1098 
    #[serde(default)]
1099 
    label: Vec<i64>,
1100 
}
1101
1102 
pub async fn set_labels(
1103 
    State(app): State<Shared>,
1104 
    viewer: Viewer,
1105 
    Path((owner, name, number)): Path<(String, String, i64)>,
1106 
    axum_extra::extract::Form(f): axum_extra::extract::Form<LabelsForm>,
1107 
) -> Result<Response, Error> {
1108 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
1109 
    require(&viewer, &shell)?;
1110 
    csrf(&viewer, &f.csrf_token, &shell)?;
1111 
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
1112 
    if role < Role::Triage {
1113 
        return Err(Error::not_found(shell));
1114 
    }
1115 
    let p = pdb::get(&app.db, row.id, number)
1116 
        .await
1117 
        .map_err(|e| Error::from_db(shell.clone(), e))?
1118 
        .ok_or_else(|| Error::not_found(shell.clone()))?;
1119 
    for l in db::issues::labels(&app.db, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))? {
1120 
        db::issues::set_proposal_label(&app.db, p.id, l.id, f.label.contains(&l.id)).await.map_err(|e| Error::from_db(shell.clone(), e))?;
1121 
    }
1122 
    Ok(back(&owner, &name, number, "conversation", None, None))
1123 
}
1124
1125 
/// `GET /{owner}/{name}/proposal/{number}/events`: server-sent events for
1126 
/// checks on the projected state (hub spec §13.1).
1127 
pub async fn events(
1128 
    State(app): State<Shared>,
1129 
    viewer: Viewer,
1130 
    Path((owner, name, number)): Path<(String, String, i64)>,
1131 
) -> Result<axum::response::Sse<impl futures::Stream<Item = Result<axum::response::sse::Event, std::convert::Infallible>>>, Error> {
1132 
    use futures::StreamExt;
1133 
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
1134 
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
1135 
    let rx = app.events.proposals.subscribe();
1136 
    let repo_id = row.id;
1137 
    let stream = tokio_stream::wrappers::BroadcastStream::new(rx).filter_map(move |item| async move {
1138 
        match item {
1139 
            Ok((id, ev)) if id == repo_id => {
1140 
                Some(Ok(axum::response::sse::Event::default().event(ev.kind.clone()).data(serde_json::to_string(&ev).unwrap_or_default())))
1141 
            }
1142 
            _ => None,
1143 
        }
1144 
    });
1145 
    Ok(axum::response::Sse::new(stream).keep_alive(axum::response::sse::KeepAlive::default()))
1146 
}
1147
1148 
// -------------------------------------------------------------------- API
1149
1150 
pub async fn to_api(app: &Shared, owner: &str, name: &str, loaded: &Loaded, v: &Verdict, source_url: Option<String>) -> hub_api::Proposal {
1151 
    let p = &loaded.row;
1152 
    hub_api::Proposal {
1153 
        number: p.number,
1154 
        title: p.title.clone(),
1155 
        body: p.body.clone(),
1156 
        author: p.author.clone(),
1157 
        state: ProposalState::parse(&p.state).unwrap_or(ProposalState::Open),
1158 
        target: p.target.clone(),
1159 
        source: match p.source_kind.as_str() {
1160 
            "fork" => {
1161 
                let (o, n) = source_url
1162 
                    .as_deref()
1163 
                    .and_then(|u| u.rsplit_once('/'))
1164 
                    .and_then(|(b, n)| b.rsplit_once('/').map(|(_, o)| (o.to_string(), n.to_string())))
1165 
                    .unwrap_or_default();
1166 
                ProposalSource::Fork { owner: o, name: n, bookmark: p.source_bookmark.clone() }
1167 
            }
1168 
            "changes" => ProposalSource::Changes { hashes: p.source_changes() },
1169 
            _ => ProposalSource::Bookmark { bookmark: p.source_bookmark.clone() },
1170 
        },
1171 
        changes: loaded
1172 
            .changes
1173 
            .iter()
1174 
            .map(|c| hub_api::ChangeSummary {
1175 
                hash: c.hash.clone(),
1176 
                message: if c.body.is_empty() { c.title.clone() } else { format!("{}\n\n{}", c.title, c.body) },
1177 
                author: hub_api::Author {
1178 
                    name: c.author.name.clone(),
1179 
                    email: c.author.email.clone(),
1180 
                    key: c.author.key.clone(),
1181 
                    account: c.author.account.clone(),
1182 
                    note: hub_api::Author::note_for(&c.author.key, &c.author.account),
1183 
                },
1184 
                when_ms: c.when_ms,
1185 
                deps: c.deps.clone(),
1186 
                head: c.head,
1187 
                signature: match &c.signature {
1188 
                    view::SigView::Unsigned => hub_api::Signature::Unsigned,
1189 
                    view::SigView::Valid { key, sealed, revoked, .. } => {
1190 
                        hub_api::Signature::Valid { key: key.clone(), sealed: *sealed, revoked: *revoked }
1191 
                    }
1192 
                    view::SigView::Invalid(why) => hub_api::Signature::Invalid { reason: why.clone() },
1193 
                },
1194 
            })
1195 
            .collect(),
1196 
        projected_heads: loaded.heads.iter().map(|h| h.to_hex()).collect(),
1197 
        projected_state: Some(loaded.state.clone()),
1198 
        conflicted: loaded.conflicted,
1199 
        approvals: v.approvals.clone(),
1200 
        landable: p.is_open() && v.blockers.is_empty(),
1201 
        blockers: v.blockers.clone(),
1202 
        created_ms: p.created_ms,
1203 
        updated_ms: p.updated_ms,
1204 
        url: format!("{}/{owner}/{name}/proposal/{}", app.config.base_url(), p.number),
1205 
        repository_url: format!("{}/{owner}/{name}", app.config.base_url()),
1206 
        source_url,
1207 
    }
1208 
}
1209
1210 
/// The line comment form's placement key, for templates.
1211 
pub fn key(path: &str, line: impl filters::Num) -> (String, usize) {
1212 
    (path.to_string(), line.as_u64() as usize)
1213 
}
1214
1215 
#[allow(dead_code)]
1216 
fn _unused(_: &diff::Line, _: &ConflictView, _: &Role) {}