OXYGENHUB
# a2ef53c5db26 oxygenhub / crates / hub / tests / api.rs
78.9 KiB · Rust · last changed Checks keep their width and refresh in place; live parts share one fetch 20 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
51
    config.outbound.allow = vec!["http://127.0.0.1".into()];
52
    let app = oxygenhub::build(config).await.unwrap();
53
    let router = oxygenhub::router(app.clone());
54
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
55
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
56
}
57
58
struct Res {
59
    status: StatusCode,
60
    body: String,
61
    cookie: Option<String>,
62
}
63
64
async fn call(
65
    app: &Shared,
66
    method: &str,
67
    path: &str,
68
    bearer: Option<&str>,
69
    cookie: Option<&str>,
70
    json: Option<&str>,
71
    form: Option<&str>,
72
) -> Res {
73
    let mut req = Request::builder().method(method).uri(path);
74
    if let Some(b) = bearer {
75
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
76
    }
77
    if let Some(c) = cookie {
78
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
79
    }
80
    let body = if let Some(j) = json {
81
        req = req.header(header::CONTENT_TYPE, "application/json");
82
        Body::from(j.to_string())
83
    } else if let Some(f) = form {
84
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
85
        Body::from(f.to_string())
86
    } else {
87
        Body::empty()
88
    };
89
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
90
    let status = res.status();
91
    let cookie = res
92
        .headers()
93
        .get(header::SET_COOKIE)
94
        .and_then(|v| v.to_str().ok())
95
        .and_then(|v| v.split(';').next())
96
        .and_then(|kv| kv.split_once('='))
97
        .map(|(_, v)| v.to_string());
98
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
99
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
100
}
101
102
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
103
    let r = call(app, method, path, bearer, None, json, None).await;
104
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
105
    (r.status, v)
106
}
107
108
fn csrf_of(page: &str) -> String {
109
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
110
    page[i..].split('"').next().unwrap().to_string()
111
}
112
113
/// A webhook receiver that records what it gets and fails the first time.
114
struct Receiver {
115
    url: String,
116
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
117
    fail_first: Arc<Mutex<bool>>,
118
}
119
120
async fn receiver() -> Receiver {
121
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
122
    let fail_first = Arc::new(Mutex::new(true));
123
    let (s2, f2) = (seen.clone(), fail_first.clone());
124
    let router = Router::new().route(
125
        "/hook",
126
        post(move |headers: header::HeaderMap, body: String| {
127
            let (s2, f2) = (s2.clone(), f2.clone());
128
            async move {
129
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
130
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
131
                let mut f = f2.lock().unwrap();
132
                if *f {
133
                    *f = false;
134
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
135
                }
136
                s2.lock().unwrap().push((event, sig, body));
137
                (StatusCode::OK, "ok")
138
            }
139
        }),
140
    );
141
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
142
    let port = listener.local_addr().unwrap().port();
143
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
144
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
145
}
146
147
#[tokio::test(flavor = "multi_thread")]
148
async fn api_webhooks_and_checks() {
149
    let h = hub().await;
150
    let app = &h.app;
151
    // Accounts and tokens through the pages.
152
    let r =
153
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
154
    let andy = r.cookie.unwrap();
155
    let r =
156
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
157
    let bob = r.cookie.unwrap();
158
    let mint = |cookie: String, scopes: &'static str| {
159
        let app = app.clone();
160
        async move {
161
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
162
            let csrf = csrf_of(&page.body);
163
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
164
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
165
        }
166
    };
167
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
168
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
169
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
170
171
    // Create a repository through the API; the read-only token cannot.
172
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
173
    assert_eq!(st, StatusCode::FORBIDDEN);
174
    let (st, v) = api(
175
        app,
176
        "POST",
177
        "/api/v1/repos",
178
        Some(&andy_admin),
179
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
180
    )
181
    .await;
182
    assert_eq!(st, StatusCode::CREATED, "{v}");
183
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
184
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
185
    assert_eq!(st, StatusCode::CONFLICT);
186
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
187
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
188
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
189
    assert_eq!(st, StatusCode::OK);
190
    assert_eq!(v["username"], "andy");
191
192
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
193
    let rx = receiver().await;
194
    let (st, v) = api(
195
        app,
196
        "POST",
197
        "/api/v1/repos/andy/demo/hooks",
198
        Some(&andy_admin),
199
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
200
    )
201
    .await;
202
    assert_eq!(st, StatusCode::CREATED, "{v}");
203
    let work = tempfile::tempdir().unwrap();
204
    let mut client = Repo::init(work.path()).unwrap();
205
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
206
    client.config.set("remote.origin.token", "site").unwrap();
207
    client.save_config().unwrap();
208
    write(work.path(), "a.txt", b"a\n");
209
    client.snapshot("t").unwrap();
210
    let base = client.commit("base", &[]).unwrap();
211
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
212
    // The worker retries with backoff; drive it directly for the retry.
213
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
214
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
215
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
216
    oxygenhub::hooks::deliver_due(app).await;
217
    let seen = rx.seen.lock().unwrap().clone();
218
    assert_eq!(seen.len(), 1, "{seen:?}");
219
    assert_eq!(seen[0].0, "push");
220
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
221
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
222
    assert_eq!(payload["repository"]["name"], "demo");
223
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
224
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
225
    assert_eq!(v.as_array().unwrap().len(), 1);
226
227
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
228
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
229
    assert_eq!(st, StatusCode::OK);
230
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
231
    // A revset in place of the whole history (`?r=`), under a budget; a
232
    // bad one is the caller's problem.
233
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
234
    assert_eq!(st, StatusCode::OK, "{v}");
235
    assert_eq!(v["total"].as_u64(), Some(1));
236
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
237
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
238
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
239
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
240
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
241
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
242
    assert_eq!(v[0]["name"], "a.txt");
243
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
244
    assert_eq!(r.body, "a\n");
245
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
246
    assert_eq!(v[0]["change"], base.to_hex());
247
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
248
    assert_eq!(v["files"][0]["path"], "a.txt");
249
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
250
    assert!(v["policy"].is_null());
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
252
    assert_eq!(v[0]["reference"], "main");
253
254
    // Issues through the API: Bob opens one, comments, and closes it.
255
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
256
    assert_eq!(st, StatusCode::CREATED, "{v}");
257
    assert_eq!(v["number"], 1);
258
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
259
    assert_eq!(st, StatusCode::CREATED);
260
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
261
    assert_eq!(st, StatusCode::OK, "{v}");
262
    assert_eq!(v["state"], "closed");
263
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
264
    assert_eq!(v[0]["comments"], 1);
265
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
266
    assert_eq!(v[0]["number"], 1);
267
268
    // A proposal through the API, then a required check gates its landing.
269
    client.bookmark_create("feat", Some(&[base])).unwrap();
270
    client.bookmark_switch("feat", false).unwrap();
271
    write(work.path(), "b.txt", b"b\n");
272
    write(work.path(), "a.txt", b"a\nA\n");
273
    client.snapshot("t").unwrap();
274
    let feat = client.commit("feat", &[]).unwrap();
275
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
276
    let (st, v) =
277
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
278
            .await;
279
    assert_eq!(st, StatusCode::CREATED, "{v}");
280
    assert_eq!(v["number"], 2);
281
    let state = v["projected_state"].as_str().unwrap().to_string();
282
    assert_eq!(v["landable"], true);
283
    // Its files, and each side's bytes, for editors' diff views.
284
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
285
    assert_eq!(st, StatusCode::OK, "{v}");
286
    let files: Vec<(String, String)> =
287
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
288
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
289
    assert_eq!(v[0]["added"], 1);
290
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
291
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
292
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
293
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
294
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
295
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
296
    // Require the "build" check.
297
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
298
    let csrf = csrf_of(&settings.body);
299
    assert_eq!(
300
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
301
            .await
302
            .status,
303
        StatusCode::OK
304
    );
305
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
306
    assert_eq!(v["landable"], false);
307
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
308
    // A checker reports on the projected state: first running, then passed; the page streams it.
309
    let (st, v) = api(
310
        app,
311
        "POST",
312
        "/api/v1/repos/andy/demo/checks",
313
        Some(&andy_ro),
314
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
315
    )
316
    .await;
317
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
318
    let mut events = app.events.proposals.subscribe();
319
    let (st, v) = api(
320
        app,
321
        "POST",
322
        "/api/v1/repos/andy/demo/checks",
323
        Some(&bob_rw),
324
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
325
    )
326
    .await;
327
    assert_eq!(st, StatusCode::CREATED, "{v}");
328
    let (_, ev) = events.recv().await.unwrap();
329
    assert_eq!(ev.kind, "check");
330
    assert_eq!(ev.check.unwrap().name, "build");
331
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
332
    assert_eq!(v[0]["status"], "passed");
333
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
334
    assert_eq!(v["landable"], true, "{v}");
335
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
336
    assert!(page.body.contains("42 tests"), "{}", page.body);
337
    // A summary carrying whole hashes shows them by their ends, so the
338
    // Checks panel keeps its width (a pin mismatch's message, 2026-10-16).
339
    let (a, b) = (
340
        "6ea27b1d35037a4e4d0f6208b1ca99630df40888bd21fd55c8f8aba51dcdd7cb",
341
        "f7495d7689da3ac5b68684f26fce28b91ce55e6b8131c5e484ad2aab90c3020f",
342
    );
343
    let summary = format!("could not run: flow-init has BLAKE3 {a}, but {b} is pinned");
344
    let body = serde_json::json!({ "state": state, "name": "lint", "status": "failed", "summary": summary }).to_string();
345
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/checks", Some(&bob_rw), Some(&body)).await;
346
    assert_eq!(st, StatusCode::CREATED, "{v}");
347
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await.body;
348
    assert!(page.contains("6ea27b1d…1dcdd7cb") && page.contains(&format!("data-full=\"{a}\"")), "{page}");
349
    assert!(!page.contains(&format!("BLAKE3 {a},")), "never the whole hash inline");
350
    // The Checks section refreshes itself; nothing reloads the whole page.
351
    assert!(!page.contains("location.reload()"), "no full reload on a check");
352
    let part = call(app, "GET", "/andy/demo/proposal/2?fragment=checks", None, Some(&andy), None, None).await.body;
353
    assert!(part.contains("<h3>Checks</h3>") && part.contains("6ea27b1d…1dcdd7cb") && !part.contains("<html"), "{part}");
354
    // The check and the proposal reached the webhook too.
355
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
356
    oxygenhub::hooks::deliver_due(app).await;
357
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
358
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
359
    let _ = feat;
360
    let _ = rx.fail_first;
361
362
    // The inbox through the API: count, list, mark one read, mark all read.
363
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
364
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
365
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
366
    oxygenhub::db::notify::add(
367
        &app.db,
368
        oxygenhub::db::notify::New {
369
            account_id: bob_id,
370
            repo_id: None,
371
            reason: oxygenhub::db::notify::Reason::Participating,
372
            kind: "mention",
373
            title: "andy/demo#1: Bug",
374
            url: "/andy/demo/issue/1",
375
            actor: "andy",
376
        },
377
    )
378
    .await
379
    .unwrap();
380
    oxygenhub::db::notify::add(
381
        &app.db,
382
        oxygenhub::db::notify::New {
383
            account_id: bob_id,
384
            repo_id: None,
385
            reason: oxygenhub::db::notify::Reason::Participating,
386
            kind: "review",
387
            title: "andy/demo#2: Feat",
388
            url: "/andy/demo/proposal/2",
389
            actor: "andy",
390
        },
391
    )
392
    .await
393
    .unwrap();
394
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
395
    assert_eq!(st, StatusCode::OK, "{v}");
396
    assert_eq!(v["unread"], 2);
397
    assert_eq!(v["items"][0]["read"], false);
398
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
399
    let first = v["items"][0]["id"].as_i64().unwrap();
400
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
401
    assert_eq!(st, StatusCode::NO_CONTENT);
402
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
403
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
404
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
405
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
406
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
407
408
    // Review requests: the author asks andy; andy is told, reviews, and the
409
    // request is answered; the author hears of the review.
410
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
411
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
412
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
413
        .await
414
        .unwrap();
415
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
416
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
417
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
418
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
419
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
420
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
421
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
422
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
423
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
424
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
425
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
426
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
427
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
428
    let (st, _) =
429
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
430
    assert_eq!(st, StatusCode::CREATED);
431
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
432
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
433
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
434
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
435
    // Asking again and withdrawing it.
436
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
437
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
438
    assert_eq!(st, StatusCode::NO_CONTENT);
439
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
440
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
441
    // oxygenhub#84: the page's menu sets who is asked, all at once.
442
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
443
    assert!(
444
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
445
        "the reviewers menu lists andy"
446
    );
447
    let csrf = csrf_of(&page.body);
448
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
449
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
450
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
451
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
452
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
453
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
454
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
455
456
    // A source bookmark with `/` in its name, as a feature/N-name workflow
457
    // makes them: by name, and as this repository's owner/name:bookmark.
458
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
459
        client.bookmark_create(b, Some(&[base])).unwrap();
460
        client.bookmark_switch(b, false).unwrap();
461
        write(work.path(), file, b"c\n");
462
        client.snapshot("t").unwrap();
463
        client.commit(b, &[]).unwrap();
464
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
465
    }
466
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
467
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
468
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
469
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
470
        let n = v["number"].as_i64().unwrap();
471
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
472
        assert_eq!(page.status, StatusCode::OK);
473
        assert!(page.body.contains("feature/"), "the page names its source");
474
    }
475
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
476
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
477
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
478
479
    // oxygenhub#76: a proposal's title and description are edited through
480
    // the API by its author or a maintainer; what is not given stays.
481
    let edit = |token: &str, number: i64, body: &str| {
482
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
483
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
484
    };
485
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
486
    assert_eq!(st, StatusCode::OK, "{v}");
487
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
488
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
489
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
490
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
491
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
492
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
493
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
494
    let (st, v) = api(
495
        app,
496
        "POST",
497
        "/api/v1/repos/andy/demo/proposals",
498
        Some(&andy_pw),
499
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
500
    )
501
    .await;
502
    assert_eq!(st, StatusCode::CREATED, "{v}");
503
    let n = v["number"].as_i64().unwrap();
504
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
505
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
506
507
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
508
    // before anything changes, shown in its JSON.
509
    for l in ["ui", "flow"] {
510
        let body = format!(r#"{{"name":"{l}"}}"#);
511
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
512
    }
513
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
514
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
515
    assert_eq!(st, StatusCode::OK, "{v}");
516
    let names = |v: &serde_json::Value| -> Vec<String> {
517
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
518
    };
519
    assert_eq!(names(&v), ["flow", "ui"]);
520
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
521
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
522
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
523
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
524
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
525
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
526
    assert_eq!(names(&v), ["flow"]);
527
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
528
}
529
530
#[tokio::test(flavor = "multi_thread")]
531
async fn api_issue_triage_and_labels() {
532
    let h = hub().await;
533
    let app = &h.app;
534
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
535
        .await
536
        .cookie
537
        .unwrap();
538
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
539
        .await
540
        .cookie
541
        .unwrap();
542
    let mint = |cookie: String, scopes: &'static str| {
543
        let app = app.clone();
544
        async move {
545
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
546
            let csrf = csrf_of(&page.body);
547
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
548
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
549
        }
550
    };
551
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
552
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
553
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
554
    assert_eq!(st, StatusCode::CREATED);
555
556
    // Labels through the API; bad colours and non-triage callers are refused.
557
    let (st, v) = api(
558
        app,
559
        "POST",
560
        "/api/v1/repos/andy/demo/labels",
561
        Some(&andy_t),
562
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
563
    )
564
    .await;
565
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
566
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
567
    assert_eq!(
568
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
569
        StatusCode::BAD_REQUEST
570
    );
571
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
572
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
573
    assert_eq!(labels.as_array().unwrap().len(), 2);
574
    // oxygenhub#91: milestones over the API, for triage.
575
    let (st, m) = api(
576
        app,
577
        "POST",
578
        "/api/v1/repos/andy/demo/milestones",
579
        Some(&andy_t),
580
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
581
    )
582
    .await;
583
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
584
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
585
    assert_eq!(
586
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
587
        StatusCode::BAD_REQUEST
588
    );
589
    assert_eq!(
590
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
591
        StatusCode::FORBIDDEN
592
    );
593
    let (st, m) =
594
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
595
            .await;
596
    assert_eq!(
597
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
598
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
599
        "{m}"
600
    );
601
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
602
    assert_eq!(
603
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
604
        StatusCode::NOT_FOUND,
605
        "renamed"
606
    );
607
    assert_eq!(
608
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
609
        StatusCode::BAD_REQUEST
610
    );
611
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
612
    assert_eq!(list.as_array().unwrap().len(), 1);
613
614
    // An issue created with its labels and assignee in one call.
615
    let (st, v) = api(
616
        app,
617
        "POST",
618
        "/api/v1/repos/andy/demo/issues",
619
        Some(&andy_t),
620
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
621
    )
622
    .await;
623
    assert_eq!(st, StatusCode::CREATED, "{v}");
624
    assert_eq!(v["labels"][0]["name"], "bug");
625
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
626
    let n = v["number"].as_i64().unwrap();
627
    // Unknown names are refused before anything is created.
628
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
629
    assert_eq!(st, StatusCode::BAD_REQUEST);
630
    assert!(v["detail"].as_str().unwrap().contains("no label"));
631
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
632
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
633
    // Without triage, labels cannot be set, but a plain issue can be opened.
634
    assert_eq!(
635
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
636
        StatusCode::FORBIDDEN
637
    );
638
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
639
    assert_eq!(st, StatusCode::CREATED);
640
    let bob_n = bobs["number"].as_i64().unwrap();
641
642
    // PATCH: the whole label set, assignees and milestone, with events.
643
    let (st, v) =
644
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
645
            .await;
646
    assert_eq!(st, StatusCode::OK, "{v}");
647
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
648
    assert_eq!(v["assignees"], serde_json::json!([]));
649
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
650
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
651
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
652
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
653
    // The author edits their own title; others cannot; nobody but triage sets labels.
654
    let (st, v) =
655
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
656
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
657
    assert_eq!(
658
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
659
        StatusCode::FORBIDDEN
660
    );
661
    assert_eq!(
662
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
663
        StatusCode::FORBIDDEN
664
    );
665
    assert_eq!(
666
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
667
        StatusCode::BAD_REQUEST
668
    );
669
670
    // Deleting a label takes it off the issues.
671
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
672
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
673
    assert_eq!(v["labels"], serde_json::json!([]));
674
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
675
}
676
677
#[tokio::test(flavor = "multi_thread")]
678
async fn webhook_formats_editing_and_web_issue_events() {
679
    let h = hub().await;
680
    let app = &h.app;
681
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
682
        .await
683
        .cookie
684
        .unwrap();
685
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
686
    let r = call(
687
        app,
688
        "POST",
689
        "/settings/tokens",
690
        None,
691
        Some(&andy),
692
        None,
693
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
694
    )
695
    .await;
696
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
697
    assert_eq!(
698
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
699
        StatusCode::CREATED
700
    );
701
    let rx = receiver().await;
702
    *rx.fail_first.lock().unwrap() = false;
703
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
704
    let csrf = csrf_of(&settings);
705
    let form = |f: String| {
706
        let andy = andy.clone();
707
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
708
    };
709
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
710
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
711
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
712
    assert_eq!(hook.format, "discord");
713
    // Ping arrives as a Discord message.
714
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
715
    let mut got = String::new();
716
    for _ in 0..100 {
717
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
718
            got = body.clone();
719
        }
720
        if !got.is_empty() {
721
            break;
722
        }
723
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
724
    }
725
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
726
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
727
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
728
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
729
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
730
731
    // Editing: a blank URL and secret keep theirs; format, events and active change.
732
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
733
        .await
734
        .contains("Webhook saved"));
735
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
736
    assert_eq!(
737
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
738
        (rx.url.as_str(), "issue", "oxygenhub", true)
739
    );
740
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
741
742
    // An issue opened on the web now reaches the hook, as the signed envelope.
743
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
744
    call(
745
        app,
746
        "POST",
747
        "/andy/demo/issues/new",
748
        None,
749
        Some(&andy),
750
        None,
751
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
752
    )
753
    .await;
754
    let mut envelope = None;
755
    for _ in 0..100 {
756
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
757
        if envelope.is_some() {
758
            break;
759
        }
760
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
761
    }
762
    let (_, sig, body) = envelope.expect("issue.opened delivered");
763
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
764
    assert_eq!(v["data"]["issue"]["title"], "From the web");
765
    assert!(sig.starts_with("blake3-keyed="));
766
    // A disabled hook through the edit form (no active box).
767
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
768
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
769
}
770
771
#[tokio::test(flavor = "multi_thread")]
772
async fn api_projects() {
773
    let h = hub().await;
774
    let app = &h.app;
775
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
776
        .await
777
        .cookie
778
        .unwrap();
779
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
780
        .await
781
        .cookie
782
        .unwrap();
783
    let mint = |cookie: String, scopes: &'static str| {
784
        let app = app.clone();
785
        async move {
786
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
787
            let csrf = csrf_of(&page.body);
788
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
789
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
790
        }
791
    };
792
    let a = mint(andy, "scopes=repo%3Aadmin").await;
793
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
794
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
795
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
796
797
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
798
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
799
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
800
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
801
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
802
803
    // Cards by reference, into a column by name, and a note into the first column.
804
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
805
    assert_eq!(st, StatusCode::CREATED, "{card}");
806
    assert_eq!(
807
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
808
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
809
    );
810
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
811
    assert_eq!(st, StatusCode::BAD_REQUEST);
812
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
813
    assert_eq!(
814
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
815
        StatusCode::BAD_REQUEST
816
    );
817
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
818
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
819
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
820
821
    // Move and read the board.
822
    let id = card["id"].as_i64().unwrap();
823
    assert_eq!(
824
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
825
        StatusCode::NO_CONTENT
826
    );
827
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
828
    let names: Vec<(&str, usize)> =
829
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
830
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
831
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
832
    // The cards by column (#115), and a wrong method answers with a body.
833
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
834
    assert_eq!(st, StatusCode::OK);
835
    assert_eq!(cols, board["columns"]);
836
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
837
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
838
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
839
840
    // Private: hidden from others; closed: read-only; then remove a card.
841
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
842
    assert_eq!(edited["public"], false);
843
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
844
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
845
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
846
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
847
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
848
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
849
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
850
}
851
852
#[tokio::test(flavor = "multi_thread")]
853
async fn api_required_checks() {
854
    let h = hub().await;
855
    let app = &h.app;
856
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
857
        .await
858
        .cookie
859
        .unwrap();
860
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
861
    let csrf = csrf_of(&page.body);
862
    let mint = |scopes: &'static str| {
863
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
864
        async move {
865
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
866
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
867
        }
868
    };
869
    let admin = mint("scopes=repo%3Aadmin").await;
870
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
871
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
872
873
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
874
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
875
    let (st, v) = api(
876
        app,
877
        "PUT",
878
        "/api/v1/repos/andy/demo/checks/required",
879
        Some(&admin),
880
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
881
    )
882
    .await;
883
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
884
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
885
    assert_eq!(
886
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
887
        serde_json::json!(["flow/fmt", "flow/test"])
888
    );
889
    assert_eq!(
890
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
891
        StatusCode::FORBIDDEN,
892
        "repo:admin only"
893
    );
894
    assert_eq!(
895
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
896
        StatusCode::BAD_REQUEST
897
    );
898
    // The settings page shows the same list.
899
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
900
}
901
902
/// OxygenFlow per repository: site administrators turn it on or off in
903
/// the repository's settings; hub.toml's `[flow] repos` is the default.
904
#[tokio::test(flavor = "multi_thread")]
905
async fn flow_is_switched_per_repository_by_site_admins() {
906
    let h = hub().await;
907
    let app = &h.app;
908
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
909
        .await
910
        .cookie
911
        .unwrap();
912
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
913
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
914
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
915
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
916
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
917
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
918
919
    let set = |value: &'static str| {
920
        let (app, andy) = (app.clone(), andy.clone());
921
        async move {
922
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
923
            call(
924
                &app,
925
                "POST",
926
                "/andy/demo/settings/flow",
927
                None,
928
                Some(&andy),
929
                None,
930
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
931
            )
932
            .await
933
        }
934
    };
935
    // A repository admin who is not a site admin sees the state but cannot change it.
936
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
937
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
938
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
939
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
940
    let r = set("on").await;
941
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
942
    assert_eq!(row().await.flow, "");
943
944
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
945
    let r = set("on").await;
946
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
947
    assert_eq!(row().await.flow, "on");
948
    assert!(oxygenhub::flow::enabled(app, &row().await));
949
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
950
    set("off").await;
951
    assert!(!oxygenhub::flow::enabled(app, &row().await));
952
    set("default").await;
953
    assert_eq!(row().await.flow, "");
954
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
955
}
956
957
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
958
/// button, never the repository's default bookmark as the hub sets it.
959
#[tokio::test(flavor = "multi_thread")]
960
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
961
    let h = hub().await;
962
    let app = &h.app;
963
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
964
        .await
965
        .cookie
966
        .unwrap();
967
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
968
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
969
    let url = format!("{}/andy/demo", h.base);
970
    let work = tempfile::tempdir().unwrap();
971
    let (w, u) = (work.path().to_path_buf(), url.clone());
972
    let client = tokio::task::spawn_blocking(move || {
973
        let mut c = Repo::init(&w).unwrap();
974
        c.config.set("remote.origin.url", &u).unwrap();
975
        c.config.set("remote.origin.token", "site").unwrap();
976
        c.save_config().unwrap();
977
        write(&w, "a.txt", b"a\n");
978
        c.commit("a", &[]).unwrap();
979
        assert!(c.push("origin", false).unwrap()[0].ok);
980
        for b in ["develop", "feature/x", "stray"] {
981
            c.bookmark_create(b, None).unwrap();
982
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
983
        }
984
        // A pushed deletion.
985
        let r = c.push_delete("origin", "feature/x").unwrap();
986
        assert!(r[0].ok, "{r:?}");
987
        c
988
    })
989
    .await
990
    .unwrap();
991
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
992
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
993
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
994
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
995
    assert!(!anon.body.contains("/bookmarks/delete"));
996
997
    // The hub's default, not the repository's config, is protected: make
998
    // develop the default, then main can go and develop cannot.
999
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1000
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1001
    let client = tokio::task::spawn_blocking(move || {
1002
        let r = client.push_delete("origin", "develop").unwrap();
1003
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1004
        let r = client.push_delete("origin", "main").unwrap();
1005
        assert!(r[0].ok, "{r:?}");
1006
        client
1007
    })
1008
    .await
1009
    .unwrap();
1010
    drop(client);
1011
1012
    // On the web: a writer deletes stray; the default is refused.
1013
    let form = |b: &'static str| {
1014
        let (app, andy) = (app.clone(), andy.clone());
1015
        async move {
1016
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1017
            call(
1018
                &app,
1019
                "POST",
1020
                "/andy/demo/bookmarks/delete",
1021
                None,
1022
                Some(&andy),
1023
                None,
1024
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1025
            )
1026
            .await
1027
        }
1028
    };
1029
    let r = form("stray").await;
1030
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1031
    assert!(!r.body.contains(">stray<"));
1032
    let r = form("develop").await;
1033
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1034
    let r = form("nope").await;
1035
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1036
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1037
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1038
    // Anonymous visitors cannot.
1039
    assert_ne!(
1040
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1041
        StatusCode::OK
1042
    );
1043
}
1044
1045
/// A change signed by a key no account has linked says so, on its page
1046
/// and in the API (feedback 14).
1047
#[tokio::test(flavor = "multi_thread")]
1048
async fn changes_signed_by_unlinked_keys_say_so() {
1049
    let h = hub().await;
1050
    let app = &h.app;
1051
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1052
        .await
1053
        .cookie
1054
        .unwrap();
1055
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1056
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1057
    let url = format!("{}/andy/demo", h.base);
1058
    let work = tempfile::tempdir().unwrap();
1059
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1060
    let hash = tokio::task::spawn_blocking(move || {
1061
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1062
        c.config.set("remote.origin.url", &u).unwrap();
1063
        c.config.set("remote.origin.token", "site").unwrap();
1064
        c.save_config().unwrap();
1065
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1066
        write(&w.join("r"), "a.txt", b"a\n");
1067
        let h = c.commit("signed by Ada", &[]).unwrap();
1068
        assert!(c.push("origin", false).unwrap()[0].ok);
1069
        h.to_hex()
1070
    })
1071
    .await
1072
    .unwrap();
1073
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1074
    assert_eq!(st, StatusCode::OK, "{v}");
1075
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1076
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1077
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1078
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1079
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1080
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1081
}
1082
1083
/// Function history (hub spec §6.6): the file page lists a file's
1084
/// functions, and a function's page lists exactly the changes to its lines.
1085
#[tokio::test(flavor = "multi_thread")]
1086
async fn a_function_has_its_own_history() {
1087
    let h = hub().await;
1088
    let app = &h.app;
1089
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1090
        .await
1091
        .cookie
1092
        .unwrap();
1093
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1094
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1095
    let url = format!("{}/andy/demo", h.base);
1096
    let work = tempfile::tempdir().unwrap();
1097
    let w = work.path().to_path_buf();
1098
    tokio::task::spawn_blocking(move || {
1099
        let mut c = Repo::init(&w).unwrap();
1100
        c.config.set("remote.origin.url", &url).unwrap();
1101
        c.config.set("remote.origin.token", "site").unwrap();
1102
        c.save_config().unwrap();
1103
        let steps = [
1104
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1105
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1106
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1107
        ];
1108
        for (msg, text) in steps {
1109
            write(&w, "src/lib.rs", text.as_bytes());
1110
            c.commit(msg, &[]).unwrap();
1111
        }
1112
        assert!(c.push("origin", false).unwrap()[0].ok);
1113
    })
1114
    .await
1115
    .unwrap();
1116
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1117
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1118
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1119
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1120
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1121
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1122
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1123
    assert_ne!(bad.status, StatusCode::OK);
1124
}
1125
1126
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1127
/// dependency edges, linked cards.
1128
#[tokio::test(flavor = "multi_thread")]
1129
async fn a_bookmark_shows_as_swimlanes() {
1130
    let h = hub().await;
1131
    let app = &h.app;
1132
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1133
        .await
1134
        .cookie
1135
        .unwrap();
1136
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1137
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1138
    let url = format!("{}/andy/demo", h.base);
1139
    let work = tempfile::tempdir().unwrap();
1140
    let w = work.path().to_path_buf();
1141
    tokio::task::spawn_blocking(move || {
1142
        let mut c = Repo::init(&w).unwrap();
1143
        c.config.set("remote.origin.url", &url).unwrap();
1144
        c.config.set("remote.origin.token", "site").unwrap();
1145
        c.save_config().unwrap();
1146
        // Two files edited independently: two lanes.
1147
        write(&w, "a.txt", b"a\n");
1148
        c.commit("add a", &[]).unwrap();
1149
        write(&w, "b.txt", b"b\n");
1150
        c.commit("add b", &[]).unwrap();
1151
        write(&w, "a.txt", b"a\na2\n");
1152
        c.commit("grow a", &[]).unwrap();
1153
        assert!(c.push("origin", false).unwrap()[0].ok);
1154
    })
1155
    .await
1156
    .unwrap();
1157
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1158
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1159
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1160
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1161
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1162
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1163
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1164
    assert_eq!(board.matches("<rect ").count(), 3);
1165
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1166
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1167
}
1168
1169
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1170
/// offers only what makes sense and rewrites nothing itself.
1171
#[tokio::test(flavor = "multi_thread")]
1172
async fn a_proposal_board_plans_squashes_and_rebases() {
1173
    let h = hub().await;
1174
    let app = &h.app;
1175
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1176
        .await
1177
        .cookie
1178
        .unwrap();
1179
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1180
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1181
    let url = format!("{}/andy/demo", h.base);
1182
    let work = tempfile::tempdir().unwrap();
1183
    let w = work.path().to_path_buf();
1184
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1185
        let mut c = Repo::init(&w).unwrap();
1186
        c.config.set("remote.origin.url", &url).unwrap();
1187
        c.config.set("remote.origin.token", "site").unwrap();
1188
        c.save_config().unwrap();
1189
        write(&w, "a.txt", b"a\n");
1190
        let base = c.commit("base", &[]).unwrap();
1191
        assert!(c.push("origin", false).unwrap()[0].ok);
1192
        c.bookmark_create("feature", None).unwrap();
1193
        c.bookmark_switch("feature", false).unwrap();
1194
        write(&w, "a.txt", b"a\nfirst\n");
1195
        let first = c.commit("first", &[]).unwrap();
1196
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1197
        let second = c.commit("second", &[]).unwrap();
1198
        write(&w, "b.txt", b"apart\n");
1199
        let apart = c.commit("apart", &[]).unwrap();
1200
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1201
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1202
    })
1203
    .await
1204
    .unwrap();
1205
    // No proposal yet: the board is read-only.
1206
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1207
    assert!(!board.contains("data-plan="));
1208
    let (st, _) = api(
1209
        app,
1210
        "POST",
1211
        "/api/v1/repos/andy/demo/proposals",
1212
        Some("site"),
1213
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1214
    )
1215
    .await;
1216
    assert!(st.is_success(), "{st}");
1217
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1218
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1219
    let csrf = csrf_of(&board);
1220
    let plan = |c: &str, t: &str| {
1221
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1222
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1223
        async move {
1224
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1225
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1226
        }
1227
    };
1228
    let kinds = |v: &serde_json::Value| {
1229
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1230
    };
1231
    // second already depends on first: squash, no rebase.
1232
    let v = plan(&second, &first).await;
1233
    assert_eq!(kinds(&v), ["squash"], "{v}");
1234
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1235
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygen.oxygen-vscode/plan?"));
1236
    // apart is independent of second: either.
1237
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1238
    // first under second: nothing (second depends on first).
1239
    assert!(plan(&first, &second).await["error"].is_string());
1240
    // What has landed on main is not rearranged.
1241
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1242
}
1243
1244
/// Issues and proposals share a number space, so every number says what it
1245
/// is, and the chain of work shows from both ends (hub spec §8).
1246
#[tokio::test(flavor = "multi_thread")]
1247
async fn proposals_and_issues_show_their_chain() {
1248
    let h = hub().await;
1249
    let app = &h.app;
1250
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1251
        .await
1252
        .cookie
1253
        .unwrap();
1254
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1255
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1256
    let url = format!("{}/andy/demo", h.base);
1257
    let work = tempfile::tempdir().unwrap();
1258
    let w = work.path().to_path_buf();
1259
    tokio::task::spawn_blocking(move || {
1260
        let mut c = Repo::init(&w).unwrap();
1261
        c.config.set("remote.origin.url", &url).unwrap();
1262
        c.config.set("remote.origin.token", "site").unwrap();
1263
        c.save_config().unwrap();
1264
        write(&w, "a.txt", b"a\n");
1265
        c.commit("base", &[]).unwrap();
1266
        assert!(c.push("origin", false).unwrap()[0].ok);
1267
        c.bookmark_create("feature", None).unwrap();
1268
        c.bookmark_switch("feature", false).unwrap();
1269
        write(&w, "a.txt", b"a\nfixed\n");
1270
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1271
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1272
    })
1273
    .await
1274
    .unwrap();
1275
    for title in ["Slow start", "Crash on save"] {
1276
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1277
        assert!(st.is_success());
1278
    }
1279
    let (st, v) = api(
1280
        app,
1281
        "POST",
1282
        "/api/v1/repos/andy/demo/proposals",
1283
        Some("site"),
1284
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1285
    )
1286
    .await;
1287
    assert!(st.is_success(), "{st} {v}");
1288
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1289
1290
    // The proposal names its kind, links its references by kind, and shows
1291
    // the chain: the issues it closes (description and changes) → it → main.
1292
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1293
    assert!(p.contains(">proposal #3</small>"), "header");
1294
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1295
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1296
    let chain = &chain[..chain.find("</p>").unwrap()];
1297
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1298
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1299
    }
1300
    assert!(p.contains("<h3>Closes</h3>"));
1301
1302
    // The issue shows the proposal that closes it, and names its own kind.
1303
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1304
    assert!(i.contains(">issue #1</small>"));
1305
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1306
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1307
    // The conversation is a timeline with avatars; editing sits with the
1308
    // content, not in the sidebar, and labels and projects are editable.
1309
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1310
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1311
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1312
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1313
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1314
    assert!(st.is_success(), "{st}");
1315
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1316
    assert!(
1317
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1318
        "the owner's projects to add to, in a menu"
1319
    );
1320
    let csrf = csrf_of(&p);
1321
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1322
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1323
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1324
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1325
        .await;
1326
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1327
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1328
1329
    // Closed by the proposal's change, not its description: still shown.
1330
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1331
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1332
    assert!(chain.contains("proposal #3"), "{chain}");
1333
}
1334
1335
/// What the hub is: its version and build, and the libraries it is built on,
1336
/// on /about, in the API and in /health (hub spec §15).
1337
#[tokio::test(flavor = "multi_thread")]
1338
async fn the_hub_says_what_version_it_is() {
1339
    let h = hub().await;
1340
    let app = &h.app;
1341
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1342
    assert_eq!(st, StatusCode::OK);
1343
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1344
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1345
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1346
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1347
    assert!(health.contains("\"build\""), "{health}");
1348
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1349
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1350
    assert!(about.contains("href=\"/about\""), "the footer links here");
1351
}
1352
1353
#[tokio::test(flavor = "multi_thread")]
1354
async fn device_sign_in() {
1355
    let h = hub().await;
1356
    let app = &h.app;
1357
    let r =
1358
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1359
    let andy = r.cookie.unwrap();
1360
1361
    // An unknown scope is refused.
1362
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1363
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1364
1365
    // The app asks for a code and polls; nobody has approved it yet.
1366
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1367
    assert_eq!(st, StatusCode::OK, "{v}");
1368
    let device = v["device_code"].as_str().unwrap().to_string();
1369
    let user = v["user_code"].as_str().unwrap().to_string();
1370
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1371
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1372
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1373
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1374
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1375
    assert_eq!(v["error"], "slow_down", "polled too soon");
1376
1377
    // The user approves it on the web, allowing less than it asked for.
1378
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1379
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1380
    let csrf = csrf_of(&page.body);
1381
    let r =
1382
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1383
            .await;
1384
    // oxygenhub#83: the answer page says it is done, with no code form.
1385
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1386
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1387
1388
    // The next poll gets a token with what was allowed, once.
1389
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1390
    assert_eq!(st, StatusCode::OK, "{v}");
1391
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1392
    let token = v["access_token"].as_str().unwrap().to_string();
1393
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1394
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1395
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1396
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1397
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1398
    assert!(tokens.body.contains("device: Phone app"));
1399
    // oxygenhub#70: a device's token expires, and each use renews it.
1400
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1401
1402
    // The token can revoke itself (oxy auth logout), and is then refused.
1403
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1404
    assert_eq!(st, StatusCode::NO_CONTENT);
1405
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1406
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1407
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1408
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1409
1410
    // A denied code says so.
1411
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1412
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1413
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1414
    let csrf = csrf_of(&page.body);
1415
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1416
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1417
    assert_eq!(v["error"], "access_denied");
1418
1419
    // Signed out, the page asks for a sign-in first.
1420
    let r = call(app, "GET", "/device", None, None, None, None).await;
1421
    assert!(r.status.is_redirection(), "{}", r.status);
1422
}
1423
1424
#[tokio::test(flavor = "multi_thread")]
1425
async fn api_assistants_at_each_level() {
1426
    let h = hub().await;
1427
    let app = &h.app;
1428
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1429
        .await
1430
        .cookie
1431
        .unwrap();
1432
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1433
    let csrf = csrf_of(&page.body);
1434
    let mint = |scopes: &'static str| {
1435
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1436
        async move {
1437
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1438
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1439
        }
1440
    };
1441
    let admin = mint("scopes=repo%3Aadmin").await;
1442
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1443
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1444
    // A stand-in endpoint with no model list: any model name is taken.
1445
    let router = axum::Router::new().route(
1446
        "/v1/chat/completions",
1447
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1448
    );
1449
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1450
    let port = listener.local_addr().unwrap().port();
1451
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1452
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1453
1454
    // The site's, by its administrator; the repository's, by its admin.
1455
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1456
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1457
    assert_eq!(st, StatusCode::OK, "{v}");
1458
    assert_eq!(v["ok"], "Gemini added");
1459
    let body =
1460
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1461
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1462
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1463
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1464
    assert_eq!(st, StatusCode::OK, "{v}");
1465
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1466
    assert_eq!(st, StatusCode::OK);
1467
    let names: Vec<(&str, &str, bool)> = v
1468
        .as_array()
1469
        .unwrap()
1470
        .iter()
1471
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1472
        .collect();
1473
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1474
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1475
    // Changing it keeps the token when none is given.
1476
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1477
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1478
    assert_eq!(v["ok"], "Claude updated");
1479
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1480
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1481
    // Prompts: the site's is inherited by the repository.
1482
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1483
    assert_eq!(st, StatusCode::OK);
1484
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1485
    assert_eq!(v["prompt"], "Rust.");
1486
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1487
    // Removed.
1488
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1489
    assert_eq!(st, StatusCode::NO_CONTENT);
1490
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1491
    assert_eq!(st, StatusCode::NOT_FOUND);
1492
}