OXYGENHUB
# a3ba7cc10673 oxygenhub / crates / hub / tests / api.rs
91.9 KiB · Rust · last changed GET /user/proposals?landable=true: the proposals the caller can land now (closes #311) 10 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    // The first account's setup code (oxygenhub#245).
46
    config.registration.setup_code = "test-setup".into();
47
    config.auth.push_tokens = vec!["site".into()];
48
    config.registration.mode = "open".into();
49
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
50
    let port = listener.local_addr().unwrap().port();
51
    config.server.base_url = format!("http://127.0.0.1:{port}");
52
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
53
    config.outbound.allow = vec!["http://127.0.0.1".into()];
54
    let app = oxygenhub::build(config).await.unwrap();
55
    let router = oxygenhub::router(app.clone());
56
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
57
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
58
}
59
60
struct Res {
61
    status: StatusCode,
62
    body: String,
63
    cookie: Option<String>,
64
    location: Option<String>,
65
}
66
67
async fn call(
68
    app: &Shared,
69
    method: &str,
70
    path: &str,
71
    bearer: Option<&str>,
72
    cookie: Option<&str>,
73
    json: Option<&str>,
74
    form: Option<&str>,
75
) -> Res {
76
    let mut req = Request::builder().method(method).uri(path);
77
    if let Some(b) = bearer {
78
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
79
    }
80
    if let Some(c) = cookie {
81
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
82
    }
83
    let body = if let Some(j) = json {
84
        req = req.header(header::CONTENT_TYPE, "application/json");
85
        Body::from(j.to_string())
86
    } else if let Some(f) = form {
87
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
88
        Body::from(f.to_string())
89
    } else {
90
        Body::empty()
91
    };
92
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
93
    let status = res.status();
94
    let cookie = res
95
        .headers()
96
        .get(header::SET_COOKIE)
97
        .and_then(|v| v.to_str().ok())
98
        .and_then(|v| v.split(';').next())
99
        .and_then(|kv| kv.split_once('='))
100
        .map(|(_, v)| v.to_string());
101
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
102
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
103
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
104
}
105
106
/// A repository settings form's answer (#278): a redirect to the page that
107
/// holds the form, followed.
108
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
109
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
110
    let to = r.location.expect("a redirect");
111
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
112
    call(app, "GET", &to, None, cookie, None, None).await
113
}
114
115
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
116
    let r = call(app, method, path, bearer, None, json, None).await;
117
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
118
    (r.status, v)
119
}
120
121
fn csrf_of(page: &str) -> String {
122
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
123
    page[i..].split('"').next().unwrap().to_string()
124
}
125
126
/// A webhook receiver that records what it gets and fails the first time.
127
struct Receiver {
128
    url: String,
129
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
130
    fail_first: Arc<Mutex<bool>>,
131
}
132
133
async fn receiver() -> Receiver {
134
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
135
    let fail_first = Arc::new(Mutex::new(true));
136
    let (s2, f2) = (seen.clone(), fail_first.clone());
137
    let router = Router::new().route(
138
        "/hook",
139
        post(move |headers: header::HeaderMap, body: String| {
140
            let (s2, f2) = (s2.clone(), f2.clone());
141
            async move {
142
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
143
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
144
                let mut f = f2.lock().unwrap();
145
                if *f {
146
                    *f = false;
147
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
148
                }
149
                s2.lock().unwrap().push((event, sig, body));
150
                (StatusCode::OK, "ok")
151
            }
152
        }),
153
    );
154
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
155
    let port = listener.local_addr().unwrap().port();
156
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
157
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
158
}
159
160
#[tokio::test(flavor = "multi_thread")]
161
async fn api_webhooks_and_checks() {
162
    let h = hub().await;
163
    let app = &h.app;
164
    // Accounts and tokens through the pages.
165
    let r = call(
166
        app,
167
        "POST",
168
        "/register",
169
        None,
170
        None,
171
        None,
172
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
173
    )
174
    .await;
175
    let andy = r.cookie.unwrap();
176
    let r = call(
177
        app,
178
        "POST",
179
        "/register",
180
        None,
181
        None,
182
        None,
183
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
184
    )
185
    .await;
186
    let bob = r.cookie.unwrap();
187
    let mint = |cookie: String, scopes: &'static str| {
188
        let app = app.clone();
189
        async move {
190
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
191
            let csrf = csrf_of(&page.body);
192
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
193
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
194
        }
195
    };
196
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
197
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
198
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
199
200
    // Create a repository through the API; the read-only token cannot.
201
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
202
    assert_eq!(st, StatusCode::FORBIDDEN);
203
    let (st, v) = api(
204
        app,
205
        "POST",
206
        "/api/v1/repos",
207
        Some(&andy_admin),
208
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
209
    )
210
    .await;
211
    assert_eq!(st, StatusCode::CREATED, "{v}");
212
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
213
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
214
    assert_eq!(st, StatusCode::CONFLICT);
215
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
216
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
217
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
218
    assert_eq!(st, StatusCode::OK);
219
    assert_eq!(v["username"], "andy");
220
221
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
222
    let rx = receiver().await;
223
    let (st, v) = api(
224
        app,
225
        "POST",
226
        "/api/v1/repos/andy/demo/hooks",
227
        Some(&andy_admin),
228
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
229
    )
230
    .await;
231
    assert_eq!(st, StatusCode::CREATED, "{v}");
232
    let work = tempfile::tempdir().unwrap();
233
    let mut client = Repo::init(work.path()).unwrap();
234
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
235
    client.config.set("remote.origin.token", "site").unwrap();
236
    client.save_config().unwrap();
237
    write(work.path(), "a.txt", b"a\n");
238
    client.snapshot("t").unwrap();
239
    let base = client.commit("base", &[]).unwrap();
240
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
241
    // The worker retries with backoff; drive it directly for the retry.
242
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
243
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
244
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
245
    oxygenhub::hooks::deliver_due(app).await;
246
    let seen = rx.seen.lock().unwrap().clone();
247
    assert_eq!(seen.len(), 1, "{seen:?}");
248
    assert_eq!(seen[0].0, "push");
249
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
250
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
251
    assert_eq!(payload["repository"]["name"], "demo");
252
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
253
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
254
    assert_eq!(v.as_array().unwrap().len(), 1);
255
256
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
257
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
258
    assert_eq!(st, StatusCode::OK);
259
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
260
    // A revset in place of the whole history (`?r=`), under a budget; a
261
    // bad one is the caller's problem.
262
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
263
    assert_eq!(st, StatusCode::OK, "{v}");
264
    assert_eq!(v["total"].as_u64(), Some(1));
265
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
266
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
267
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
268
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
269
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
270
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
271
    assert_eq!(v[0]["name"], "a.txt");
272
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
273
    assert_eq!(r.body, "a\n");
274
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
275
    assert_eq!(v[0]["change"], base.to_hex());
276
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
277
    assert_eq!(v["files"][0]["path"], "a.txt");
278
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
279
    assert!(v["policy"].is_null());
280
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
281
    assert_eq!(v[0]["reference"], "main");
282
283
    // Issues through the API: Bob opens one, comments, and closes it.
284
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
285
    assert_eq!(st, StatusCode::CREATED, "{v}");
286
    assert_eq!(v["number"], 1);
287
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
288
    assert_eq!(st, StatusCode::CREATED);
289
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
290
    assert_eq!(st, StatusCode::OK, "{v}");
291
    assert_eq!(v["state"], "closed");
292
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
293
    assert_eq!(v[0]["comments"], 1);
294
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
295
    assert_eq!(v[0]["number"], 1);
296
297
    // A proposal through the API, then a required check gates its landing.
298
    client.bookmark_create("feat", Some(&[base])).unwrap();
299
    client.bookmark_switch("feat", false).unwrap();
300
    write(work.path(), "b.txt", b"b\n");
301
    write(work.path(), "a.txt", b"a\nA\n");
302
    client.snapshot("t").unwrap();
303
    let feat = client.commit("feat", &[]).unwrap();
304
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
305
    let (st, v) =
306
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
307
            .await;
308
    assert_eq!(st, StatusCode::CREATED, "{v}");
309
    assert_eq!(v["number"], 2);
310
    let state = v["projected_state"].as_str().unwrap().to_string();
311
    assert_eq!(v["landable"], true);
312
    // Its files, and each side's bytes, for editors' diff views.
313
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
314
    assert_eq!(st, StatusCode::OK, "{v}");
315
    let files: Vec<(String, String)> =
316
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
317
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
318
    assert_eq!(v[0]["added"], 1);
319
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
320
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
321
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
322
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
323
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
324
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
325
    // An anchored comment comes back with its line in the projected state.
326
    let (st, v) = api(
327
        app,
328
        "POST",
329
        "/api/v1/repos/andy/demo/proposals/2/comments",
330
        Some(&bob_rw),
331
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
332
    )
333
    .await;
334
    assert_eq!(st, StatusCode::CREATED, "{v}");
335
    assert_eq!(v["line"], 2);
336
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
337
    assert_eq!(v[0]["path"], "a.txt");
338
    assert_eq!(v[0]["line"], 2, "{v}");
339
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
340
    // Require the "build" check.
341
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
342
    let csrf = csrf_of(&settings.body);
343
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
344
        .await;
345
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
346
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
347
    assert_eq!(v["landable"], false);
348
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
349
    // Nothing to land yet for its owner (#311), and the list is only there when asked for.
350
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
351
    assert!(v.get("landable").is_none(), "{v}");
352
    // A checker reports on the projected state: first running, then passed; the page streams it.
353
    let (st, v) = api(
354
        app,
355
        "POST",
356
        "/api/v1/repos/andy/demo/checks",
357
        Some(&andy_ro),
358
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
359
    )
360
    .await;
361
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
362
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
363
    let (st, v) = api(
364
        app,
365
        "POST",
366
        "/api/v1/repos/andy/demo/checks",
367
        Some(&bob_rw),
368
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
369
    )
370
    .await;
371
    assert_eq!(st, StatusCode::CREATED, "{v}");
372
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
373
    assert_eq!(ev.kind, "check");
374
    assert_eq!(ev.check.unwrap().name, "build");
375
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
376
    assert_eq!(v[0]["status"], "passed");
377
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
378
    assert_eq!(v["landable"], true, "{v}");
379
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
380
    assert_eq!((v["landable"][0]["repository"].as_str(), v["landable"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
381
    assert!(api(app, "GET", "/api/v1/user/proposals", Some(&andy_ro), None).await.1.get("landable").is_none(), "only when asked");
382
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
383
    assert!(page.body.contains("42 tests"), "{}", page.body);
384
    // The check and the proposal reached the webhook too.
385
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
386
    oxygenhub::hooks::deliver_due(app).await;
387
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
388
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
389
    let _ = feat;
390
    let _ = rx.fail_first;
391
392
    // The inbox through the API: count, list, mark one read, mark all read.
393
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
394
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
395
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
396
    oxygenhub::db::notify::add(
397
        &app.db,
398
        oxygenhub::db::notify::New {
399
            account_id: bob_id,
400
            repo_id: Some(oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id),
401
            reason: oxygenhub::db::notify::Reason::Participating,
402
            kind: "issue.opened",
403
            title: "andy/demo#1: Bug",
404
            url: "/andy/demo/issue/1",
405
            actor: "andy",
406
        },
407
    )
408
    .await
409
    .unwrap();
410
    oxygenhub::db::notify::add(
411
        &app.db,
412
        oxygenhub::db::notify::New {
413
            account_id: bob_id,
414
            repo_id: None,
415
            reason: oxygenhub::db::notify::Reason::Participating,
416
            kind: "review",
417
            title: "andy/demo#2: Feat",
418
            url: "/andy/demo/proposal/2",
419
            actor: "andy",
420
        },
421
    )
422
    .await
423
    .unwrap();
424
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
425
    assert_eq!(st, StatusCode::OK, "{v}");
426
    assert_eq!(v["unread"], 2);
427
    assert_eq!(v["items"][0]["read"], false);
428
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
429
    // Its repository, why, its thread and the kind's label (#305).
430
    let bug = v["items"].as_array().unwrap().iter().find(|n| n["title"] == "andy/demo#1: Bug").unwrap();
431
    assert_eq!(
432
        (bug["repository"].as_str(), bug["reason"].as_str(), bug["label"].as_str()),
433
        (Some("andy/demo"), Some("participating"), Some("🐛 New Issue")),
434
        "{bug}"
435
    );
436
    assert_eq!(bug["thread"].as_str(), Some(format!("{}/andy/demo/issue/1", h.base).as_str()));
437
    let first = v["items"][0]["id"].as_i64().unwrap();
438
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
439
    assert_eq!(st, StatusCode::NO_CONTENT);
440
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
441
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
442
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
443
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
444
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
445
    // No token at all is 401, so a client knows to sign in (#303).
446
    assert_eq!(api(app, "GET", "/api/v1/notifications", None, None).await.0, StatusCode::UNAUTHORIZED);
447
    assert_eq!(api(app, "GET", "/api/v1/user", None, None).await.0, StatusCode::UNAUTHORIZED);
448
449
    // Review requests: the author asks andy; andy is told, reviews, and the
450
    // request is answered; the author hears of the review.
451
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
452
    let (st, orgs) = api(app, "GET", "/api/v1/user/orgs", Some(&andy_user), None).await;
453
    assert!(st == StatusCode::OK && orgs.is_array(), "the caller's organisations (#302): {orgs}");
454
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
455
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
456
        .await
457
        .unwrap();
458
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
459
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
460
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
461
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
462
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
463
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
464
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
465
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
466
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
467
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
468
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
469
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
470
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
471
    let (st, _) =
472
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
473
    assert_eq!(st, StatusCode::CREATED);
474
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
475
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
476
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
477
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
478
    // Asking again and withdrawing it.
479
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
480
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
481
    assert_eq!(st, StatusCode::NO_CONTENT);
482
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
483
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
484
    // oxygenhub#84: the page's menu sets who is asked, all at once.
485
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
486
    assert!(
487
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
488
        "the reviewers menu lists andy"
489
    );
490
    let csrf = csrf_of(&page.body);
491
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
492
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
493
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
494
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
495
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
496
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
497
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
498
499
    // A source bookmark with `/` in its name, as a feature/N-name workflow
500
    // makes them: by name, and as this repository's owner/name:bookmark.
501
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
502
        client.bookmark_create(b, Some(&[base])).unwrap();
503
        client.bookmark_switch(b, false).unwrap();
504
        write(work.path(), file, b"c\n");
505
        client.snapshot("t").unwrap();
506
        client.commit(b, &[]).unwrap();
507
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
508
    }
509
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
510
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
511
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
512
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
513
        let n = v["number"].as_i64().unwrap();
514
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
515
        assert_eq!(page.status, StatusCode::OK);
516
        assert!(page.body.contains("feature/"), "the page names its source");
517
    }
518
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
519
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
520
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
521
522
    // oxygenhub#76: a proposal's title and description are edited through
523
    // the API by its author or a maintainer; what is not given stays.
524
    let edit = |token: &str, number: i64, body: &str| {
525
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
526
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
527
    };
528
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
529
    assert_eq!(st, StatusCode::OK, "{v}");
530
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
531
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
532
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
533
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
534
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
535
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
536
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
537
    let (st, v) = api(
538
        app,
539
        "POST",
540
        "/api/v1/repos/andy/demo/proposals",
541
        Some(&andy_pw),
542
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
543
    )
544
    .await;
545
    assert_eq!(st, StatusCode::CREATED, "{v}");
546
    let n = v["number"].as_i64().unwrap();
547
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
548
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
549
550
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
551
    // before anything changes, shown in its JSON.
552
    for l in ["ui", "flow"] {
553
        let body = format!(r#"{{"name":"{l}"}}"#);
554
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
555
    }
556
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
557
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
558
    assert_eq!(st, StatusCode::OK, "{v}");
559
    let names = |v: &serde_json::Value| -> Vec<String> {
560
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
561
    };
562
    assert_eq!(names(&v), ["flow", "ui"]);
563
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
564
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
565
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
566
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
567
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
568
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
569
    assert_eq!(names(&v), ["flow"]);
570
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
571
}
572
573
#[tokio::test(flavor = "multi_thread")]
574
async fn api_issue_triage_and_labels() {
575
    let h = hub().await;
576
    let app = &h.app;
577
    let andy = call(
578
        app,
579
        "POST",
580
        "/register",
581
        None,
582
        None,
583
        None,
584
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
585
    )
586
    .await
587
    .cookie
588
    .unwrap();
589
    let bob = call(
590
        app,
591
        "POST",
592
        "/register",
593
        None,
594
        None,
595
        None,
596
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
597
    )
598
    .await
599
    .cookie
600
    .unwrap();
601
    let mint = |cookie: String, scopes: &'static str| {
602
        let app = app.clone();
603
        async move {
604
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
605
            let csrf = csrf_of(&page.body);
606
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
607
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
608
        }
609
    };
610
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
611
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
612
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
613
    assert_eq!(st, StatusCode::CREATED);
614
615
    // Labels through the API; bad colours and non-triage callers are refused.
616
    let (st, v) = api(
617
        app,
618
        "POST",
619
        "/api/v1/repos/andy/demo/labels",
620
        Some(&andy_t),
621
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
622
    )
623
    .await;
624
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
625
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
626
    assert_eq!(
627
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
628
        StatusCode::BAD_REQUEST
629
    );
630
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
631
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
632
    assert_eq!(labels.as_array().unwrap().len(), 2);
633
    // oxygenhub#91: milestones over the API, for triage.
634
    let (st, m) = api(
635
        app,
636
        "POST",
637
        "/api/v1/repos/andy/demo/milestones",
638
        Some(&andy_t),
639
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
640
    )
641
    .await;
642
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
643
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
644
    assert_eq!(
645
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
646
        StatusCode::BAD_REQUEST
647
    );
648
    assert_eq!(
649
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
650
        StatusCode::FORBIDDEN
651
    );
652
    let (st, m) =
653
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
654
            .await;
655
    assert_eq!(
656
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
657
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
658
        "{m}"
659
    );
660
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
661
    assert_eq!(
662
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
663
        StatusCode::NOT_FOUND,
664
        "renamed"
665
    );
666
    assert_eq!(
667
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
668
        StatusCode::BAD_REQUEST
669
    );
670
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
671
    assert_eq!(list.as_array().unwrap().len(), 1);
672
673
    // An issue created with its labels and assignee in one call.
674
    let (st, v) = api(
675
        app,
676
        "POST",
677
        "/api/v1/repos/andy/demo/issues",
678
        Some(&andy_t),
679
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
680
    )
681
    .await;
682
    assert_eq!(st, StatusCode::CREATED, "{v}");
683
    assert_eq!(v["labels"][0]["name"], "bug");
684
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
685
    let n = v["number"].as_i64().unwrap();
686
    // Unknown names are refused before anything is created.
687
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
688
    assert_eq!(st, StatusCode::BAD_REQUEST);
689
    assert!(v["detail"].as_str().unwrap().contains("no label"));
690
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
691
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
692
    // Without triage, labels cannot be set, but a plain issue can be opened.
693
    assert_eq!(
694
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
695
        StatusCode::FORBIDDEN
696
    );
697
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
698
    assert_eq!(st, StatusCode::CREATED);
699
    let bob_n = bobs["number"].as_i64().unwrap();
700
701
    // PATCH: the whole label set, assignees and milestone, with events.
702
    let (st, v) =
703
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
704
            .await;
705
    assert_eq!(st, StatusCode::OK, "{v}");
706
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
707
    assert_eq!(v["assignees"], serde_json::json!([]));
708
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
709
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
710
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
711
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
712
    // The author edits their own title; others cannot; nobody but triage sets labels.
713
    let (st, v) =
714
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
715
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
716
    assert_eq!(
717
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
718
        StatusCode::FORBIDDEN
719
    );
720
    assert_eq!(
721
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
722
        StatusCode::FORBIDDEN
723
    );
724
    assert_eq!(
725
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
726
        StatusCode::BAD_REQUEST
727
    );
728
729
    // Deleting a label takes it off the issues.
730
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
731
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
732
    assert_eq!(v["labels"], serde_json::json!([]));
733
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
734
}
735
736
#[tokio::test(flavor = "multi_thread")]
737
async fn webhook_formats_editing_and_web_issue_events() {
738
    let h = hub().await;
739
    let app = &h.app;
740
    let andy = call(
741
        app,
742
        "POST",
743
        "/register",
744
        None,
745
        None,
746
        None,
747
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
748
    )
749
    .await
750
    .cookie
751
    .unwrap();
752
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
753
    let r = call(
754
        app,
755
        "POST",
756
        "/settings/tokens",
757
        None,
758
        Some(&andy),
759
        None,
760
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
761
    )
762
    .await;
763
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
764
    assert_eq!(
765
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
766
        StatusCode::CREATED
767
    );
768
    let rx = receiver().await;
769
    *rx.fail_first.lock().unwrap() = false;
770
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
771
    let csrf = csrf_of(&settings);
772
    let form = |f: String| {
773
        let andy = andy.clone();
774
        async move {
775
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
776
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
777
        }
778
    };
779
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
780
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
781
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
782
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
783
    {
784
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
785
        let before: i64 =
786
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
787
        for i in 0..MAX_WAITING {
788
            sqlx::query(
789
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
790
            )
791
            .bind(hook.id)
792
            .bind(format!("flood-{i}"))
793
            .execute(&app.db)
794
            .await
795
            .unwrap();
796
        }
797
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
798
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
799
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
800
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
801
        let after: i64 =
802
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
803
        assert_eq!(before, after);
804
    }
805
    assert_eq!(hook.format, "discord");
806
    // Ping arrives as a Discord message.
807
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
808
    let mut got = String::new();
809
    for _ in 0..100 {
810
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
811
            got = body.clone();
812
        }
813
        if !got.is_empty() {
814
            break;
815
        }
816
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
817
    }
818
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
819
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
820
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
821
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
822
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
823
824
    // Editing: a blank URL and secret keep theirs; format, events and active change.
825
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
826
        .await
827
        .contains("Webhook saved"));
828
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
829
    assert_eq!(
830
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
831
        (rx.url.as_str(), "issue", "oxygenhub", true)
832
    );
833
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
834
835
    // An issue opened on the web now reaches the hook, as the signed envelope.
836
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
837
    call(
838
        app,
839
        "POST",
840
        "/andy/demo/issues/new",
841
        None,
842
        Some(&andy),
843
        None,
844
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
845
    )
846
    .await;
847
    let mut envelope = None;
848
    for _ in 0..100 {
849
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
850
        if envelope.is_some() {
851
            break;
852
        }
853
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
854
    }
855
    let (_, sig, body) = envelope.expect("issue.opened delivered");
856
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
857
    assert_eq!(v["data"]["issue"]["title"], "From the web");
858
    assert!(sig.starts_with("blake3-keyed="));
859
    // A disabled hook through the edit form (no active box).
860
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
861
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
862
}
863
864
#[tokio::test(flavor = "multi_thread")]
865
async fn api_projects() {
866
    let h = hub().await;
867
    let app = &h.app;
868
    let andy = call(
869
        app,
870
        "POST",
871
        "/register",
872
        None,
873
        None,
874
        None,
875
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
876
    )
877
    .await
878
    .cookie
879
    .unwrap();
880
    let bob = call(
881
        app,
882
        "POST",
883
        "/register",
884
        None,
885
        None,
886
        None,
887
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
888
    )
889
    .await
890
    .cookie
891
    .unwrap();
892
    let mint = |cookie: String, scopes: &'static str| {
893
        let app = app.clone();
894
        async move {
895
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
896
            let csrf = csrf_of(&page.body);
897
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
898
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
899
        }
900
    };
901
    let a = mint(andy, "scopes=repo%3Aadmin").await;
902
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
903
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
904
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
905
906
    // The caller's own repositories, a page at a time (#302); bob has none.
907
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"zeta","visibility":"private"}"#)).await;
908
    let names =
909
        |v: &serde_json::Value| -> Vec<String> { v.as_array().unwrap().iter().map(|r| r["name"].as_str().unwrap().to_string()).collect() };
910
    let (st, v) = api(app, "GET", "/api/v1/user/repos", Some(&a), None).await;
911
    assert_eq!((st, names(&v)), (StatusCode::OK, vec!["demo".to_string(), "zeta".to_string()]), "{v}");
912
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?limit=1", Some(&a), None).await.1), ["demo"]);
913
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?after=andy/demo", Some(&a), None).await.1), ["zeta"]);
914
    assert!(names(&api(app, "GET", "/api/v1/user/repos", Some(&b), None).await.1).is_empty(), "not bob's");
915
    assert_eq!(api(app, "GET", "/api/v1/user/repos?affiliation=friend", Some(&a), None).await.0, StatusCode::BAD_REQUEST);
916
    assert_eq!(api(app, "GET", "/api/v1/user/repos", None, None).await.0, StatusCode::UNAUTHORIZED);
917
    // The proposals to act on, as the dashboard lists them: bob's in andy's
918
    // repository is andy's to review and bob's own.
919
    let demo = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
920
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
921
    oxygenhub::db::proposals::create(
922
        &app.db,
923
        oxygenhub::db::proposals::NewProposal {
924
            repo_id: demo.id,
925
            title: "Faster startup",
926
            body: "",
927
            author_id: Some(bob_id),
928
            author: "bob",
929
            draft: false,
930
            target: "main",
931
            source_kind: "bookmark",
932
            source_repo_id: Some(demo.id),
933
            source_bookmark: "fast",
934
            source_changes: "",
935
        },
936
    )
937
    .await
938
    .unwrap();
939
    let (st, v) = api(app, "GET", "/api/v1/user/proposals", Some(&a), None).await;
940
    assert_eq!(st, StatusCode::OK, "{v}");
941
    assert_eq!((v["review"][0]["repository"].as_str(), v["review"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
942
    assert_eq!(v["review"][0]["state"], "open");
943
    assert!(v["review"][0]["url"].as_str().unwrap().ends_with("/andy/demo/proposal/2"));
944
    assert_eq!(v["authored"].as_array().map(Vec::len), Some(0));
945
    let (_, v) = api(app, "GET", "/api/v1/user/proposals", Some(&b), None).await;
946
    assert_eq!((v["review"].as_array().map(Vec::len), v["authored"][0]["title"].as_str()), (Some(0), Some("Faster startup")), "{v}");
947
    assert_eq!(api(app, "GET", "/api/v1/user/proposals", None, None).await.0, StatusCode::UNAUTHORIZED);
948
949
    // Organisations need user:read, which this token lacks.
950
    assert_eq!(api(app, "GET", "/api/v1/user/orgs", Some(&a), None).await.0, StatusCode::FORBIDDEN);
951
952
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
953
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
954
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
955
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
956
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
957
958
    // Cards by reference, into a column by name, and a note into the first column.
959
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
960
    assert_eq!(st, StatusCode::CREATED, "{card}");
961
    assert_eq!(
962
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
963
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
964
    );
965
    assert_eq!((card["labels"].as_array().map(Vec::len), card["assignees"].as_array().map(Vec::len)), (Some(0), Some(0)), "{card}");
966
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
967
    assert_eq!(st, StatusCode::BAD_REQUEST);
968
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
969
    assert_eq!(
970
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
971
        StatusCode::BAD_REQUEST
972
    );
973
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
974
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
975
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
976
977
    // Move and read the board.
978
    let id = card["id"].as_i64().unwrap();
979
    assert_eq!(
980
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
981
        StatusCode::NO_CONTENT
982
    );
983
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
984
    let names: Vec<(&str, usize)> =
985
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
986
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
987
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
988
    // The cards by column (#115), and a wrong method answers with a body.
989
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
990
    assert_eq!(st, StatusCode::OK);
991
    assert_eq!(cols, board["columns"]);
992
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
993
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
994
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
995
996
    // A column's cards at once (#289): with exceptions, a state filter and
997
    // a dry run; one audit entry.
998
    for t in ["Second", "Third"] {
999
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(&format!(r#"{{"title":"{t}"}}"#))).await;
1000
    }
1001
    for n in [2, 3] {
1002
        let body = format!(r#"{{"reference":"demo#{n}","column":"Doing"}}"#);
1003
        assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(&body)).await.0, StatusCode::CREATED);
1004
    }
1005
    let bulk = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&a), Some(body));
1006
    let refs = |v: &serde_json::Value, k: &str| -> Vec<String> {
1007
        v[k].as_array().unwrap().iter().map(|c| c["reference"].as_str().unwrap().to_string()).collect()
1008
    };
1009
    let (st, v) = bulk(r##"{"from":"Doing","column":"Done","except":["#2"],"dry_run":true}"##).await;
1010
    assert_eq!(st, StatusCode::OK, "{v}");
1011
    assert_eq!((refs(&v, "moved"), refs(&v, "kept")), (vec!["andy/demo#3".to_string()], vec!["andy/demo#2".to_string()]));
1012
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1013
    assert_eq!(board["columns"][1]["cards"].as_array().unwrap().len(), 2, "a dry run moves nothing");
1014
    let (_, v) = bulk(r#"{"from":"Doing","column":"Done","state":["closed"]}"#).await;
1015
    assert!(refs(&v, "moved").is_empty(), "both are open: {v}");
1016
    let (_, v) = bulk(r#"{"from":"doing","column":"done","except":["demo#2"]}"#).await;
1017
    assert_eq!(refs(&v, "moved"), ["andy/demo#3"]);
1018
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1019
    let names: Vec<(&str, usize)> =
1020
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1021
    assert_eq!(names, [("Backlog", 1), ("Doing", 1), ("Done", 2)]);
1022
    let audited: i64 =
1023
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_moved'").fetch_one(&app.db).await.unwrap();
1024
    assert_eq!(audited, 1, "the dry run and the empty move are not audited");
1025
    assert_eq!(bulk(r#"{"from":"Done","column":"Done"}"#).await.0, StatusCode::BAD_REQUEST);
1026
    assert_eq!(
1027
        api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&b), Some(r#"{"from":"Doing","column":"Done"}"#)).await.0,
1028
        StatusCode::FORBIDDEN
1029
    );
1030
1031
    // Archive (#293): Done's cards there more than a week (#3, made old),
1032
    // listed with ?archived=true, restored once.
1033
    sqlx::query("UPDATE project_cards SET moved_ms = 0 WHERE number = 3").execute(&app.db).await.unwrap();
1034
    let archive = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/archive", Some(&a), Some(body));
1035
    let (st, v) = archive(r#"{"from":"Done","older_days":7,"dry_run":true}"#).await;
1036
    assert_eq!((st, refs(&v, "archived")), (StatusCode::OK, vec!["andy/demo#3".to_string()]), "{v}");
1037
    assert!(v["archived"][0].get("archived_ms").is_none(), "a dry run archives nothing: {v}");
1038
    let (_, v) = archive(r#"{"from":"Done","older_days":7}"#).await;
1039
    assert_eq!((refs(&v, "archived"), refs(&v, "kept").len()), (vec!["andy/demo#3".to_string()], 1), "{v}");
1040
    assert!(v["archived"][0]["archived_ms"].as_i64().is_some());
1041
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1042
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 1, "off the board: {board}");
1043
    let (st, archived) = api(app, "GET", "/api/v1/projects/andy/1/cards?archived=true", None, None).await;
1044
    assert_eq!((st, archived[2]["cards"][0]["reference"].as_str()), (StatusCode::OK, Some("andy/demo#3")), "{archived}");
1045
    let card = archived[2]["cards"][0]["id"].as_i64().unwrap();
1046
    let restore = format!("/api/v1/projects/andy/1/cards/{card}/restore");
1047
    assert_eq!(api(app, "POST", &restore, Some(&b), None).await.0, StatusCode::FORBIDDEN);
1048
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NO_CONTENT);
1049
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NOT_FOUND, "not archived now");
1050
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1051
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 2);
1052
    assert_eq!(archive(r#"{"from":"Done","older_days":-1}"#).await.0, StatusCode::BAD_REQUEST);
1053
    let audited: i64 =
1054
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_archived'").fetch_one(&app.db).await.unwrap();
1055
    assert_eq!(audited, 1);
1056
1057
    // Private: hidden from others; closed: read-only; then remove a card.
1058
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
1059
    assert_eq!(edited["public"], false);
1060
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
1061
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
1062
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
1063
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
1064
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
1065
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
1066
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
1067
}
1068
1069
#[tokio::test(flavor = "multi_thread")]
1070
async fn api_required_checks() {
1071
    let h = hub().await;
1072
    let app = &h.app;
1073
    let andy = call(
1074
        app,
1075
        "POST",
1076
        "/register",
1077
        None,
1078
        None,
1079
        None,
1080
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1081
    )
1082
    .await
1083
    .cookie
1084
    .unwrap();
1085
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1086
    let csrf = csrf_of(&page.body);
1087
    let mint = |scopes: &'static str| {
1088
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1089
        async move {
1090
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1091
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1092
        }
1093
    };
1094
    let admin = mint("scopes=repo%3Aadmin").await;
1095
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1096
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1097
1098
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1099
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1100
    let (st, v) = api(
1101
        app,
1102
        "PUT",
1103
        "/api/v1/repos/andy/demo/checks/required",
1104
        Some(&admin),
1105
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1106
    )
1107
    .await;
1108
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1109
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1110
    assert_eq!(
1111
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1112
        serde_json::json!(["flow/fmt", "flow/test"])
1113
    );
1114
    assert_eq!(
1115
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1116
        StatusCode::FORBIDDEN,
1117
        "repo:admin only"
1118
    );
1119
    assert_eq!(
1120
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1121
        StatusCode::BAD_REQUEST
1122
    );
1123
    // The settings page shows the same list.
1124
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
1125
}
1126
1127
/// OxygenFlow per repository: site administrators turn it on or off in
1128
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1129
#[tokio::test(flavor = "multi_thread")]
1130
async fn flow_is_switched_per_repository_by_site_admins() {
1131
    let h = hub().await;
1132
    let app = &h.app;
1133
    let andy = call(
1134
        app,
1135
        "POST",
1136
        "/register",
1137
        None,
1138
        None,
1139
        None,
1140
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1141
    )
1142
    .await
1143
    .cookie
1144
    .unwrap();
1145
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1146
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1147
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1148
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1149
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
1150
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
1151
1152
    let set = |value: &'static str| {
1153
        let (app, andy) = (app.clone(), andy.clone());
1154
        async move {
1155
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1156
            let r = call(
1157
                &app,
1158
                "POST",
1159
                "/andy/demo/settings/flow",
1160
                None,
1161
                Some(&andy),
1162
                None,
1163
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1164
            )
1165
            .await;
1166
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
1167
        }
1168
    };
1169
    // A repository admin who is not a site admin sees the state but cannot change it.
1170
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1171
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
1172
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1173
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1174
    let r = set("on").await;
1175
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1176
    assert_eq!(row().await.flow, "");
1177
1178
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1179
    let r = set("on").await;
1180
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1181
    assert_eq!(row().await.flow, "on");
1182
    assert!(oxygenhub::flow::enabled(app, &row().await));
1183
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1184
    set("off").await;
1185
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1186
    set("default").await;
1187
    assert_eq!(row().await.flow, "");
1188
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
1189
}
1190
1191
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1192
/// button, never the repository's default bookmark as the hub sets it.
1193
#[tokio::test(flavor = "multi_thread")]
1194
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1195
    let h = hub().await;
1196
    let app = &h.app;
1197
    let andy = call(
1198
        app,
1199
        "POST",
1200
        "/register",
1201
        None,
1202
        None,
1203
        None,
1204
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1205
    )
1206
    .await
1207
    .cookie
1208
    .unwrap();
1209
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1210
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1211
    let url = format!("{}/andy/demo", h.base);
1212
    let work = tempfile::tempdir().unwrap();
1213
    let (w, u) = (work.path().to_path_buf(), url.clone());
1214
    let client = tokio::task::spawn_blocking(move || {
1215
        let mut c = Repo::init(&w).unwrap();
1216
        c.config.set("remote.origin.url", &u).unwrap();
1217
        c.config.set("remote.origin.token", "site").unwrap();
1218
        c.save_config().unwrap();
1219
        write(&w, "a.txt", b"a\n");
1220
        c.commit("a", &[]).unwrap();
1221
        assert!(c.push("origin", false).unwrap()[0].ok);
1222
        for b in ["develop", "feature/x", "stray"] {
1223
            c.bookmark_create(b, None).unwrap();
1224
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1225
        }
1226
        // A pushed deletion.
1227
        let r = c.push_delete("origin", "feature/x").unwrap();
1228
        assert!(r[0].ok, "{r:?}");
1229
        c
1230
    })
1231
    .await
1232
    .unwrap();
1233
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1234
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1235
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1236
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1237
    assert!(!anon.body.contains("/bookmarks/delete"));
1238
1239
    // The hub's default, not the repository's config, is protected: make
1240
    // develop the default, then main can go and develop cannot.
1241
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1242
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1243
    let client = tokio::task::spawn_blocking(move || {
1244
        let r = client.push_delete("origin", "develop").unwrap();
1245
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1246
        let r = client.push_delete("origin", "main").unwrap();
1247
        assert!(r[0].ok, "{r:?}");
1248
        client
1249
    })
1250
    .await
1251
    .unwrap();
1252
    drop(client);
1253
1254
    // On the web: a writer deletes stray; the default is refused.
1255
    let form = |b: &'static str| {
1256
        let (app, andy) = (app.clone(), andy.clone());
1257
        async move {
1258
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1259
            call(
1260
                &app,
1261
                "POST",
1262
                "/andy/demo/bookmarks/delete",
1263
                None,
1264
                Some(&andy),
1265
                None,
1266
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1267
            )
1268
            .await
1269
        }
1270
    };
1271
    let r = form("stray").await;
1272
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1273
    assert!(!r.body.contains(">stray<"));
1274
    let r = form("develop").await;
1275
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1276
    let r = form("nope").await;
1277
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1278
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1279
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1280
    // Anonymous visitors cannot.
1281
    assert_ne!(
1282
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1283
        StatusCode::OK
1284
    );
1285
}
1286
1287
/// A change signed by a key no account has linked says so, on its page
1288
/// and in the API (feedback 14).
1289
#[tokio::test(flavor = "multi_thread")]
1290
async fn changes_signed_by_unlinked_keys_say_so() {
1291
    let h = hub().await;
1292
    let app = &h.app;
1293
    let andy = call(
1294
        app,
1295
        "POST",
1296
        "/register",
1297
        None,
1298
        None,
1299
        None,
1300
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1301
    )
1302
    .await
1303
    .cookie
1304
    .unwrap();
1305
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1306
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1307
    let url = format!("{}/andy/demo", h.base);
1308
    let work = tempfile::tempdir().unwrap();
1309
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1310
    let hash = tokio::task::spawn_blocking(move || {
1311
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1312
        c.config.set("remote.origin.url", &u).unwrap();
1313
        c.config.set("remote.origin.token", "site").unwrap();
1314
        c.save_config().unwrap();
1315
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1316
        write(&w.join("r"), "a.txt", b"a\n");
1317
        let h = c.commit("signed by Ada", &[]).unwrap();
1318
        assert!(c.push("origin", false).unwrap()[0].ok);
1319
        h.to_hex()
1320
    })
1321
    .await
1322
    .unwrap();
1323
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1324
    assert_eq!(st, StatusCode::OK, "{v}");
1325
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1326
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1327
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1328
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1329
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1330
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1331
}
1332
1333
/// Function history (hub spec §6.6): the file page lists a file's
1334
/// functions, and a function's page lists exactly the changes to its lines.
1335
#[tokio::test(flavor = "multi_thread")]
1336
async fn a_function_has_its_own_history() {
1337
    let h = hub().await;
1338
    let app = &h.app;
1339
    let andy = call(
1340
        app,
1341
        "POST",
1342
        "/register",
1343
        None,
1344
        None,
1345
        None,
1346
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1347
    )
1348
    .await
1349
    .cookie
1350
    .unwrap();
1351
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1352
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1353
    let url = format!("{}/andy/demo", h.base);
1354
    let work = tempfile::tempdir().unwrap();
1355
    let w = work.path().to_path_buf();
1356
    tokio::task::spawn_blocking(move || {
1357
        let mut c = Repo::init(&w).unwrap();
1358
        c.config.set("remote.origin.url", &url).unwrap();
1359
        c.config.set("remote.origin.token", "site").unwrap();
1360
        c.save_config().unwrap();
1361
        let steps = [
1362
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1363
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1364
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1365
        ];
1366
        for (msg, text) in steps {
1367
            write(&w, "src/lib.rs", text.as_bytes());
1368
            c.commit(msg, &[]).unwrap();
1369
        }
1370
        assert!(c.push("origin", false).unwrap()[0].ok);
1371
    })
1372
    .await
1373
    .unwrap();
1374
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1375
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1376
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1377
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1378
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1379
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1380
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1381
    assert_ne!(bad.status, StatusCode::OK);
1382
}
1383
1384
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1385
/// dependency edges, linked cards.
1386
#[tokio::test(flavor = "multi_thread")]
1387
async fn a_bookmark_shows_as_swimlanes() {
1388
    let h = hub().await;
1389
    let app = &h.app;
1390
    let andy = call(
1391
        app,
1392
        "POST",
1393
        "/register",
1394
        None,
1395
        None,
1396
        None,
1397
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1398
    )
1399
    .await
1400
    .cookie
1401
    .unwrap();
1402
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1403
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1404
    let url = format!("{}/andy/demo", h.base);
1405
    let work = tempfile::tempdir().unwrap();
1406
    let w = work.path().to_path_buf();
1407
    tokio::task::spawn_blocking(move || {
1408
        let mut c = Repo::init(&w).unwrap();
1409
        c.config.set("remote.origin.url", &url).unwrap();
1410
        c.config.set("remote.origin.token", "site").unwrap();
1411
        c.save_config().unwrap();
1412
        // Two files edited independently: two lanes.
1413
        write(&w, "a.txt", b"a\n");
1414
        c.commit("add a", &[]).unwrap();
1415
        write(&w, "b.txt", b"b\n");
1416
        c.commit("add b", &[]).unwrap();
1417
        write(&w, "a.txt", b"a\na2\n");
1418
        c.commit("grow a", &[]).unwrap();
1419
        assert!(c.push("origin", false).unwrap()[0].ok);
1420
    })
1421
    .await
1422
    .unwrap();
1423
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1424
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1425
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1426
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1427
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1428
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1429
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1430
    assert_eq!(board.matches("<rect ").count(), 3);
1431
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1432
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1433
}
1434
1435
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1436
/// offers only what makes sense and rewrites nothing itself.
1437
#[tokio::test(flavor = "multi_thread")]
1438
async fn a_proposal_board_plans_squashes_and_rebases() {
1439
    let h = hub().await;
1440
    let app = &h.app;
1441
    let andy = call(
1442
        app,
1443
        "POST",
1444
        "/register",
1445
        None,
1446
        None,
1447
        None,
1448
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1449
    )
1450
    .await
1451
    .cookie
1452
    .unwrap();
1453
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1454
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1455
    let url = format!("{}/andy/demo", h.base);
1456
    let work = tempfile::tempdir().unwrap();
1457
    let w = work.path().to_path_buf();
1458
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1459
        let mut c = Repo::init(&w).unwrap();
1460
        c.config.set("remote.origin.url", &url).unwrap();
1461
        c.config.set("remote.origin.token", "site").unwrap();
1462
        c.save_config().unwrap();
1463
        write(&w, "a.txt", b"a\n");
1464
        let base = c.commit("base", &[]).unwrap();
1465
        assert!(c.push("origin", false).unwrap()[0].ok);
1466
        c.bookmark_create("feature", None).unwrap();
1467
        c.bookmark_switch("feature", false).unwrap();
1468
        write(&w, "a.txt", b"a\nfirst\n");
1469
        let first = c.commit("first", &[]).unwrap();
1470
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1471
        let second = c.commit("second", &[]).unwrap();
1472
        write(&w, "b.txt", b"apart\n");
1473
        let apart = c.commit("apart", &[]).unwrap();
1474
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1475
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1476
    })
1477
    .await
1478
    .unwrap();
1479
    // No proposal yet: the board is read-only.
1480
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1481
    assert!(!board.contains("data-plan="));
1482
    let (st, _) = api(
1483
        app,
1484
        "POST",
1485
        "/api/v1/repos/andy/demo/proposals",
1486
        Some("site"),
1487
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1488
    )
1489
    .await;
1490
    assert!(st.is_success(), "{st}");
1491
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1492
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1493
    let csrf = csrf_of(&board);
1494
    let plan = |c: &str, t: &str| {
1495
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1496
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1497
        async move {
1498
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1499
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1500
        }
1501
    };
1502
    let kinds = |v: &serde_json::Value| {
1503
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1504
    };
1505
    // second already depends on first: squash, no rebase.
1506
    let v = plan(&second, &first).await;
1507
    assert_eq!(kinds(&v), ["squash"], "{v}");
1508
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1509
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
1510
    // apart is independent of second: either.
1511
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1512
    // first under second: nothing (second depends on first).
1513
    assert!(plan(&first, &second).await["error"].is_string());
1514
    // What has landed on main is not rearranged.
1515
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1516
}
1517
1518
/// Issues and proposals share a number space, so every number says what it
1519
/// is, and the chain of work shows from both ends (hub spec §8).
1520
#[tokio::test(flavor = "multi_thread")]
1521
async fn proposals_and_issues_show_their_chain() {
1522
    let h = hub().await;
1523
    let app = &h.app;
1524
    let andy = call(
1525
        app,
1526
        "POST",
1527
        "/register",
1528
        None,
1529
        None,
1530
        None,
1531
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1532
    )
1533
    .await
1534
    .cookie
1535
    .unwrap();
1536
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1537
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1538
    let url = format!("{}/andy/demo", h.base);
1539
    let work = tempfile::tempdir().unwrap();
1540
    let w = work.path().to_path_buf();
1541
    tokio::task::spawn_blocking(move || {
1542
        let mut c = Repo::init(&w).unwrap();
1543
        c.config.set("remote.origin.url", &url).unwrap();
1544
        c.config.set("remote.origin.token", "site").unwrap();
1545
        c.save_config().unwrap();
1546
        write(&w, "a.txt", b"a\n");
1547
        c.commit("base", &[]).unwrap();
1548
        assert!(c.push("origin", false).unwrap()[0].ok);
1549
        c.bookmark_create("feature", None).unwrap();
1550
        c.bookmark_switch("feature", false).unwrap();
1551
        write(&w, "a.txt", b"a\nfixed\n");
1552
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1553
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1554
    })
1555
    .await
1556
    .unwrap();
1557
    for title in ["Slow start", "Crash on save"] {
1558
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1559
        assert!(st.is_success());
1560
    }
1561
    let (st, v) = api(
1562
        app,
1563
        "POST",
1564
        "/api/v1/repos/andy/demo/proposals",
1565
        Some("site"),
1566
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1567
    )
1568
    .await;
1569
    assert!(st.is_success(), "{st} {v}");
1570
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1571
1572
    // The proposal names its kind, links its references by kind, and shows
1573
    // the chain: the issues it closes (description and changes) → it → main.
1574
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1575
    assert!(p.contains(">proposal #3</small>"), "header");
1576
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1577
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1578
    let chain = &chain[..chain.find("</p>").unwrap()];
1579
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1580
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1581
    }
1582
    assert!(p.contains("<h3>Closes</h3>"));
1583
1584
    // The issue shows the proposal that closes it, and names its own kind.
1585
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1586
    assert!(i.contains(">issue #1</small>"));
1587
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1588
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1589
    // The conversation is a timeline with avatars; editing sits with the
1590
    // content, not in the sidebar, and labels and projects are editable.
1591
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1592
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1593
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1594
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1595
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1596
    assert!(st.is_success(), "{st}");
1597
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1598
    assert!(
1599
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1600
        "the owner's projects to add to, in a menu"
1601
    );
1602
    let csrf = csrf_of(&p);
1603
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1604
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1605
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1606
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1607
        .await;
1608
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1609
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1610
1611
    // Closed by the proposal's change, not its description: still shown.
1612
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1613
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1614
    assert!(chain.contains("proposal #3"), "{chain}");
1615
}
1616
1617
/// What the hub is: its version and build, and the libraries it is built on,
1618
/// on /about, in the API and in /health (hub spec §15).
1619
#[tokio::test(flavor = "multi_thread")]
1620
async fn the_hub_says_what_version_it_is() {
1621
    let h = hub().await;
1622
    let app = &h.app;
1623
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1624
    assert_eq!(st, StatusCode::OK);
1625
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1626
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1627
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1628
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1629
    assert!(health.contains("\"build\""), "{health}");
1630
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1631
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
1632
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1633
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1634
    assert!(about.contains("href=\"/about\""), "the footer links here");
1635
}
1636
1637
#[tokio::test(flavor = "multi_thread")]
1638
async fn device_sign_in() {
1639
    let h = hub().await;
1640
    let app = &h.app;
1641
    let r = call(
1642
        app,
1643
        "POST",
1644
        "/register",
1645
        None,
1646
        None,
1647
        None,
1648
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1649
    )
1650
    .await;
1651
    let andy = r.cookie.unwrap();
1652
1653
    // An unknown scope is refused.
1654
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1655
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1656
1657
    // The app asks for a code and polls; nobody has approved it yet.
1658
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1659
    assert_eq!(st, StatusCode::OK, "{v}");
1660
    let device = v["device_code"].as_str().unwrap().to_string();
1661
    let user = v["user_code"].as_str().unwrap().to_string();
1662
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1663
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1664
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1665
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1666
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1667
    assert_eq!(v["error"], "slow_down", "polled too soon");
1668
1669
    // The user approves it on the web, allowing less than it asked for.
1670
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1671
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1672
    let csrf = csrf_of(&page.body);
1673
    let r =
1674
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1675
            .await;
1676
    // oxygenhub#83: the answer page says it is done, with no code form.
1677
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1678
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1679
1680
    // The next poll gets a token with what was allowed, once.
1681
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1682
    assert_eq!(st, StatusCode::OK, "{v}");
1683
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1684
    let token = v["access_token"].as_str().unwrap().to_string();
1685
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1686
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1687
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1688
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1689
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1690
    assert!(tokens.body.contains("device: Phone app"));
1691
    // oxygenhub#70: a device's token expires, and each use renews it.
1692
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1693
1694
    // The token can revoke itself (oxy auth logout), and is then refused.
1695
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1696
    assert_eq!(st, StatusCode::NO_CONTENT);
1697
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1698
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1699
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1700
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1701
1702
    // A denied code says so.
1703
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1704
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1705
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1706
    let csrf = csrf_of(&page.body);
1707
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1708
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1709
    assert_eq!(v["error"], "access_denied");
1710
1711
    // A code the app gave up on (#304) is gone at once: the page no longer
1712
    // takes it, and the app's poll says so.
1713
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Cancelled"}"#)).await;
1714
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1715
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1716
    assert_eq!(st, StatusCode::NO_CONTENT);
1717
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1718
    let csrf = csrf_of(&page.body);
1719
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve"))).await;
1720
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1721
    assert_eq!(v["error"], "expired_token", "{v}");
1722
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1723
    assert_eq!(st, StatusCode::NO_CONTENT, "again: still fine");
1724
1725
    // Signed out, the page asks for a sign-in first.
1726
    let r = call(app, "GET", "/device", None, None, None, None).await;
1727
    assert!(r.status.is_redirection(), "{}", r.status);
1728
}
1729
1730
#[tokio::test(flavor = "multi_thread")]
1731
async fn api_assistants_at_each_level() {
1732
    let h = hub().await;
1733
    let app = &h.app;
1734
    let andy = call(
1735
        app,
1736
        "POST",
1737
        "/register",
1738
        None,
1739
        None,
1740
        None,
1741
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1742
    )
1743
    .await
1744
    .cookie
1745
    .unwrap();
1746
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1747
    let csrf = csrf_of(&page.body);
1748
    let mint = |scopes: &'static str| {
1749
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1750
        async move {
1751
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1752
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1753
        }
1754
    };
1755
    let admin = mint("scopes=repo%3Aadmin").await;
1756
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1757
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1758
    // A stand-in endpoint with no model list: any model name is taken.
1759
    let router = axum::Router::new().route(
1760
        "/v1/chat/completions",
1761
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1762
    );
1763
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1764
    let port = listener.local_addr().unwrap().port();
1765
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1766
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1767
1768
    // The site's, by its administrator; the repository's, by its admin.
1769
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1770
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1771
    assert_eq!(st, StatusCode::OK, "{v}");
1772
    assert_eq!(v["ok"], "Gemini added");
1773
    let body =
1774
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1775
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1776
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1777
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1778
    assert_eq!(st, StatusCode::OK, "{v}");
1779
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1780
    assert_eq!(st, StatusCode::OK);
1781
    let names: Vec<(&str, &str, bool)> = v
1782
        .as_array()
1783
        .unwrap()
1784
        .iter()
1785
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1786
        .collect();
1787
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1788
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1789
    // Changing it keeps the token when none is given.
1790
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1791
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1792
    assert_eq!(v["ok"], "Claude updated");
1793
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1794
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1795
    // Prompts: the site's is inherited by the repository.
1796
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1797
    assert_eq!(st, StatusCode::OK);
1798
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1799
    assert_eq!(v["prompt"], "Rust.");
1800
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1801
    // Removed.
1802
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1803
    assert_eq!(st, StatusCode::NO_CONTENT);
1804
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1805
    assert_eq!(st, StatusCode::NOT_FOUND);
1806
}