OXYGENHUB
# ac689cd21adf oxygenhub / crates / hub / tests / api.rs
93.2 KiB · Rust · last changed A repository's sky over the API: GET /api/v1/repos/OWNER/NAME/sky (refs andymccall/oxygenhub-android#23) 8 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    // The first account's setup code (oxygenhub#245).
46
    config.registration.setup_code = "test-setup".into();
47
    config.auth.push_tokens = vec!["site".into()];
48
    config.registration.mode = "open".into();
49
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
50
    let port = listener.local_addr().unwrap().port();
51
    config.server.base_url = format!("http://127.0.0.1:{port}");
52
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
53
    config.outbound.allow = vec!["http://127.0.0.1".into()];
54
    let app = oxygenhub::build(config).await.unwrap();
55
    let router = oxygenhub::router(app.clone());
56
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
57
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
58
}
59
60
struct Res {
61
    status: StatusCode,
62
    body: String,
63
    cookie: Option<String>,
64
    location: Option<String>,
65
}
66
67
async fn call(
68
    app: &Shared,
69
    method: &str,
70
    path: &str,
71
    bearer: Option<&str>,
72
    cookie: Option<&str>,
73
    json: Option<&str>,
74
    form: Option<&str>,
75
) -> Res {
76
    let mut req = Request::builder().method(method).uri(path);
77
    if let Some(b) = bearer {
78
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
79
    }
80
    if let Some(c) = cookie {
81
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
82
    }
83
    let body = if let Some(j) = json {
84
        req = req.header(header::CONTENT_TYPE, "application/json");
85
        Body::from(j.to_string())
86
    } else if let Some(f) = form {
87
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
88
        Body::from(f.to_string())
89
    } else {
90
        Body::empty()
91
    };
92
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
93
    let status = res.status();
94
    let cookie = res
95
        .headers()
96
        .get(header::SET_COOKIE)
97
        .and_then(|v| v.to_str().ok())
98
        .and_then(|v| v.split(';').next())
99
        .and_then(|kv| kv.split_once('='))
100
        .map(|(_, v)| v.to_string());
101
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
102
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
103
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
104
}
105
106
/// A repository settings form's answer (#278): a redirect to the page that
107
/// holds the form, followed.
108
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
109
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
110
    let to = r.location.expect("a redirect");
111
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
112
    call(app, "GET", &to, None, cookie, None, None).await
113
}
114
115
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
116
    let r = call(app, method, path, bearer, None, json, None).await;
117
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
118
    (r.status, v)
119
}
120
121
fn csrf_of(page: &str) -> String {
122
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
123
    page[i..].split('"').next().unwrap().to_string()
124
}
125
126
/// A webhook receiver that records what it gets and fails the first time.
127
struct Receiver {
128
    url: String,
129
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
130
    fail_first: Arc<Mutex<bool>>,
131
}
132
133
async fn receiver() -> Receiver {
134
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
135
    let fail_first = Arc::new(Mutex::new(true));
136
    let (s2, f2) = (seen.clone(), fail_first.clone());
137
    let router = Router::new().route(
138
        "/hook",
139
        post(move |headers: header::HeaderMap, body: String| {
140
            let (s2, f2) = (s2.clone(), f2.clone());
141
            async move {
142
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
143
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
144
                let mut f = f2.lock().unwrap();
145
                if *f {
146
                    *f = false;
147
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
148
                }
149
                s2.lock().unwrap().push((event, sig, body));
150
                (StatusCode::OK, "ok")
151
            }
152
        }),
153
    );
154
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
155
    let port = listener.local_addr().unwrap().port();
156
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
157
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
158
}
159
160
#[tokio::test(flavor = "multi_thread")]
161
async fn api_webhooks_and_checks() {
162
    let h = hub().await;
163
    let app = &h.app;
164
    // Accounts and tokens through the pages.
165
    let r = call(
166
        app,
167
        "POST",
168
        "/register",
169
        None,
170
        None,
171
        None,
172
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
173
    )
174
    .await;
175
    let andy = r.cookie.unwrap();
176
    let r = call(
177
        app,
178
        "POST",
179
        "/register",
180
        None,
181
        None,
182
        None,
183
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
184
    )
185
    .await;
186
    let bob = r.cookie.unwrap();
187
    let mint = |cookie: String, scopes: &'static str| {
188
        let app = app.clone();
189
        async move {
190
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
191
            let csrf = csrf_of(&page.body);
192
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
193
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
194
        }
195
    };
196
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
197
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
198
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
199
200
    // Create a repository through the API; the read-only token cannot.
201
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
202
    assert_eq!(st, StatusCode::FORBIDDEN);
203
    let (st, v) = api(
204
        app,
205
        "POST",
206
        "/api/v1/repos",
207
        Some(&andy_admin),
208
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
209
    )
210
    .await;
211
    assert_eq!(st, StatusCode::CREATED, "{v}");
212
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
213
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
214
    assert_eq!(st, StatusCode::CONFLICT);
215
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
216
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
217
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
218
    assert_eq!(st, StatusCode::OK);
219
    assert_eq!(v["username"], "andy");
220
221
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
222
    let rx = receiver().await;
223
    let (st, v) = api(
224
        app,
225
        "POST",
226
        "/api/v1/repos/andy/demo/hooks",
227
        Some(&andy_admin),
228
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
229
    )
230
    .await;
231
    assert_eq!(st, StatusCode::CREATED, "{v}");
232
    let work = tempfile::tempdir().unwrap();
233
    let mut client = Repo::init(work.path()).unwrap();
234
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
235
    client.config.set("remote.origin.token", "site").unwrap();
236
    client.save_config().unwrap();
237
    write(work.path(), "a.txt", b"a\n");
238
    client.snapshot("t").unwrap();
239
    let base = client.commit("base", &[]).unwrap();
240
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
241
    // The worker retries with backoff; drive it directly for the retry.
242
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
243
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
244
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
245
    oxygenhub::hooks::deliver_due(app).await;
246
    let seen = rx.seen.lock().unwrap().clone();
247
    assert_eq!(seen.len(), 1, "{seen:?}");
248
    assert_eq!(seen[0].0, "push");
249
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
250
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
251
    assert_eq!(payload["repository"]["name"], "demo");
252
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
253
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
254
    assert_eq!(v.as_array().unwrap().len(), 1);
255
256
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
257
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
258
    assert_eq!(st, StatusCode::OK);
259
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
260
    // A revset in place of the whole history (`?r=`), under a budget; a
261
    // bad one is the caller's problem.
262
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
263
    assert_eq!(st, StatusCode::OK, "{v}");
264
    assert_eq!(v["total"].as_u64(), Some(1));
265
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
266
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
267
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
268
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
269
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
270
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
271
    assert_eq!(v[0]["name"], "a.txt");
272
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
273
    assert_eq!(r.body, "a\n");
274
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
275
    assert_eq!(v[0]["change"], base.to_hex());
276
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
277
    assert_eq!(v["files"][0]["path"], "a.txt");
278
    assert_eq!(v["files"][0]["lines"][0], serde_json::json!({"kind": "add", "new": 1, "text": "a"}), "{v}");
279
    assert_eq!(v["files"][0]["truncated"], false);
280
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
281
    assert!(v["policy"].is_null());
282
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
283
    assert_eq!(v[0]["reference"], "main");
284
285
    // Issues through the API: Bob opens one, comments, and closes it.
286
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
287
    assert_eq!(st, StatusCode::CREATED, "{v}");
288
    assert_eq!(v["number"], 1);
289
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
290
    assert_eq!(st, StatusCode::CREATED);
291
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
292
    assert_eq!(st, StatusCode::OK, "{v}");
293
    assert_eq!(v["state"], "closed");
294
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
295
    assert_eq!(v[0]["comments"], 1);
296
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
297
    assert_eq!(v[0]["number"], 1);
298
299
    // A proposal through the API, then a required check gates its landing.
300
    client.bookmark_create("feat", Some(&[base])).unwrap();
301
    client.bookmark_switch("feat", false).unwrap();
302
    write(work.path(), "b.txt", b"b\n");
303
    write(work.path(), "a.txt", b"a\nA\n");
304
    client.snapshot("t").unwrap();
305
    let feat = client.commit("feat", &[]).unwrap();
306
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
307
    let (st, v) =
308
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
309
            .await;
310
    assert_eq!(st, StatusCode::CREATED, "{v}");
311
    assert_eq!(v["number"], 2);
312
    let state = v["projected_state"].as_str().unwrap().to_string();
313
    assert_eq!(v["landable"], true);
314
    // Its files, and each side's bytes, for editors' diff views.
315
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
316
    assert_eq!(st, StatusCode::OK, "{v}");
317
    let files: Vec<(String, String)> =
318
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
319
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
320
    assert_eq!(v[0]["added"], 1);
321
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
322
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
323
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
324
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
325
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
326
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
327
    // An anchored comment comes back with its line in the projected state.
328
    let (st, v) = api(
329
        app,
330
        "POST",
331
        "/api/v1/repos/andy/demo/proposals/2/comments",
332
        Some(&bob_rw),
333
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
334
    )
335
    .await;
336
    assert_eq!(st, StatusCode::CREATED, "{v}");
337
    assert_eq!(v["line"], 2);
338
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
339
    assert_eq!(v[0]["path"], "a.txt");
340
    assert_eq!(v[0]["line"], 2, "{v}");
341
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
342
    // Require the "build" check.
343
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
344
    let csrf = csrf_of(&settings.body);
345
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
346
        .await;
347
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
348
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
349
    assert_eq!(v["landable"], false);
350
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
351
    // Nothing to land yet for its owner (#311), and the list is only there when asked for.
352
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
353
    assert!(v.get("landable").is_none(), "{v}");
354
    // A checker reports on the projected state: first running, then passed; the page streams it.
355
    let (st, v) = api(
356
        app,
357
        "POST",
358
        "/api/v1/repos/andy/demo/checks",
359
        Some(&andy_ro),
360
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
361
    )
362
    .await;
363
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
364
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
365
    let (st, v) = api(
366
        app,
367
        "POST",
368
        "/api/v1/repos/andy/demo/checks",
369
        Some(&bob_rw),
370
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
371
    )
372
    .await;
373
    assert_eq!(st, StatusCode::CREATED, "{v}");
374
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
375
    assert_eq!(ev.kind, "check");
376
    assert_eq!(ev.check.unwrap().name, "build");
377
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
378
    assert_eq!(v[0]["status"], "passed");
379
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
380
    assert_eq!(v["landable"], true, "{v}");
381
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
382
    assert_eq!((v["landable"][0]["repository"].as_str(), v["landable"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
383
    assert!(api(app, "GET", "/api/v1/user/proposals", Some(&andy_ro), None).await.1.get("landable").is_none(), "only when asked");
384
    // Your sky for the app (oxygenhub-android#23): the dashboard's backdrop data.
385
    let (st, v) = api(app, "GET", "/api/v1/user/sky", Some(&andy_ro), None).await;
386
    assert_eq!(st, StatusCode::OK, "{v}");
387
    let demo = v["repos"].as_array().unwrap().iter().position(|r| r == "andy/demo").expect("andy's repository") as i64;
388
    let events = v["events"].as_array().unwrap();
389
    assert!(events.iter().any(|e| e[0] == demo && e[1] == 0), "a push: {v}");
390
    assert!(events.iter().any(|e| e[0] == demo && e[1] == 1), "a proposal event: {v}");
391
    assert!(events.iter().all(|e| e[2].as_i64().unwrap() <= v["now"].as_i64().unwrap()));
392
    assert_eq!(api(app, "GET", "/api/v1/user/sky", None, None).await.0, StatusCode::UNAUTHORIZED);
393
    // One repository's, its pages' backdrop, in the same shape.
394
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/sky", Some(&andy_ro), None).await;
395
    assert_eq!(st, StatusCode::OK, "{v}");
396
    assert_eq!(v["repos"], serde_json::json!(["andy/demo"]));
397
    assert!(v["events"].as_array().unwrap().iter().all(|e| e[0] == 0) && v["events"].as_array().unwrap().iter().any(|e| e[1] == 0), "{v}");
398
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/nope/sky", Some(&andy_ro), None).await.0, StatusCode::NOT_FOUND);
399
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
400
    assert!(page.body.contains("42 tests"), "{}", page.body);
401
    // The check and the proposal reached the webhook too.
402
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
403
    oxygenhub::hooks::deliver_due(app).await;
404
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
405
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
406
    let _ = feat;
407
    let _ = rx.fail_first;
408
409
    // The inbox through the API: count, list, mark one read, mark all read.
410
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
411
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
412
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
413
    oxygenhub::db::notify::add(
414
        &app.db,
415
        oxygenhub::db::notify::New {
416
            account_id: bob_id,
417
            repo_id: Some(oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id),
418
            reason: oxygenhub::db::notify::Reason::Participating,
419
            kind: "issue.opened",
420
            title: "andy/demo#1: Bug",
421
            url: "/andy/demo/issue/1",
422
            actor: "andy",
423
        },
424
    )
425
    .await
426
    .unwrap();
427
    oxygenhub::db::notify::add(
428
        &app.db,
429
        oxygenhub::db::notify::New {
430
            account_id: bob_id,
431
            repo_id: None,
432
            reason: oxygenhub::db::notify::Reason::Participating,
433
            kind: "review",
434
            title: "andy/demo#2: Feat",
435
            url: "/andy/demo/proposal/2",
436
            actor: "andy",
437
        },
438
    )
439
    .await
440
    .unwrap();
441
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
442
    assert_eq!(st, StatusCode::OK, "{v}");
443
    assert_eq!(v["unread"], 2);
444
    assert_eq!(v["items"][0]["read"], false);
445
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
446
    // Its repository, why, its thread and the kind's label (#305).
447
    let bug = v["items"].as_array().unwrap().iter().find(|n| n["title"] == "andy/demo#1: Bug").unwrap();
448
    assert_eq!(
449
        (bug["repository"].as_str(), bug["reason"].as_str(), bug["label"].as_str()),
450
        (Some("andy/demo"), Some("participating"), Some("🐛 New Issue")),
451
        "{bug}"
452
    );
453
    assert_eq!(bug["thread"].as_str(), Some(format!("{}/andy/demo/issue/1", h.base).as_str()));
454
    let first = v["items"][0]["id"].as_i64().unwrap();
455
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
456
    assert_eq!(st, StatusCode::NO_CONTENT);
457
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
458
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
459
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
460
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
461
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
462
    // No token at all is 401, so a client knows to sign in (#303).
463
    assert_eq!(api(app, "GET", "/api/v1/notifications", None, None).await.0, StatusCode::UNAUTHORIZED);
464
    assert_eq!(api(app, "GET", "/api/v1/user", None, None).await.0, StatusCode::UNAUTHORIZED);
465
466
    // Review requests: the author asks andy; andy is told, reviews, and the
467
    // request is answered; the author hears of the review.
468
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
469
    let (st, orgs) = api(app, "GET", "/api/v1/user/orgs", Some(&andy_user), None).await;
470
    assert!(st == StatusCode::OK && orgs.is_array(), "the caller's organisations (#302): {orgs}");
471
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
472
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
473
        .await
474
        .unwrap();
475
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
476
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
477
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
478
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
479
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
480
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
481
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
482
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
483
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
484
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
485
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
486
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
487
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
488
    let (st, _) =
489
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
490
    assert_eq!(st, StatusCode::CREATED);
491
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
492
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
493
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
494
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
495
    // Asking again and withdrawing it.
496
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
497
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
498
    assert_eq!(st, StatusCode::NO_CONTENT);
499
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
500
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
501
    // oxygenhub#84: the page's menu sets who is asked, all at once.
502
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
503
    assert!(
504
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
505
        "the reviewers menu lists andy"
506
    );
507
    let csrf = csrf_of(&page.body);
508
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
509
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
510
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
511
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
512
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
513
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
514
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
515
516
    // A source bookmark with `/` in its name, as a feature/N-name workflow
517
    // makes them: by name, and as this repository's owner/name:bookmark.
518
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
519
        client.bookmark_create(b, Some(&[base])).unwrap();
520
        client.bookmark_switch(b, false).unwrap();
521
        write(work.path(), file, b"c\n");
522
        client.snapshot("t").unwrap();
523
        client.commit(b, &[]).unwrap();
524
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
525
    }
526
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
527
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
528
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
529
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
530
        let n = v["number"].as_i64().unwrap();
531
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
532
        assert_eq!(page.status, StatusCode::OK);
533
        assert!(page.body.contains("feature/"), "the page names its source");
534
    }
535
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
536
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
537
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
538
539
    // oxygenhub#76: a proposal's title and description are edited through
540
    // the API by its author or a maintainer; what is not given stays.
541
    let edit = |token: &str, number: i64, body: &str| {
542
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
543
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
544
    };
545
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
546
    assert_eq!(st, StatusCode::OK, "{v}");
547
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
548
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
549
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
550
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
551
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
552
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
553
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
554
    let (st, v) = api(
555
        app,
556
        "POST",
557
        "/api/v1/repos/andy/demo/proposals",
558
        Some(&andy_pw),
559
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
560
    )
561
    .await;
562
    assert_eq!(st, StatusCode::CREATED, "{v}");
563
    let n = v["number"].as_i64().unwrap();
564
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
565
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
566
567
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
568
    // before anything changes, shown in its JSON.
569
    for l in ["ui", "flow"] {
570
        let body = format!(r#"{{"name":"{l}"}}"#);
571
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
572
    }
573
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
574
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
575
    assert_eq!(st, StatusCode::OK, "{v}");
576
    let names = |v: &serde_json::Value| -> Vec<String> {
577
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
578
    };
579
    assert_eq!(names(&v), ["flow", "ui"]);
580
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
581
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
582
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
583
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
584
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
585
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
586
    assert_eq!(names(&v), ["flow"]);
587
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
588
}
589
590
#[tokio::test(flavor = "multi_thread")]
591
async fn api_issue_triage_and_labels() {
592
    let h = hub().await;
593
    let app = &h.app;
594
    let andy = call(
595
        app,
596
        "POST",
597
        "/register",
598
        None,
599
        None,
600
        None,
601
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
602
    )
603
    .await
604
    .cookie
605
    .unwrap();
606
    let bob = call(
607
        app,
608
        "POST",
609
        "/register",
610
        None,
611
        None,
612
        None,
613
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
614
    )
615
    .await
616
    .cookie
617
    .unwrap();
618
    let mint = |cookie: String, scopes: &'static str| {
619
        let app = app.clone();
620
        async move {
621
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
622
            let csrf = csrf_of(&page.body);
623
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
624
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
625
        }
626
    };
627
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
628
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
629
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
630
    assert_eq!(st, StatusCode::CREATED);
631
632
    // Labels through the API; bad colours and non-triage callers are refused.
633
    let (st, v) = api(
634
        app,
635
        "POST",
636
        "/api/v1/repos/andy/demo/labels",
637
        Some(&andy_t),
638
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
639
    )
640
    .await;
641
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
642
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
643
    assert_eq!(
644
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
645
        StatusCode::BAD_REQUEST
646
    );
647
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
648
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
649
    assert_eq!(labels.as_array().unwrap().len(), 2);
650
    // oxygenhub#91: milestones over the API, for triage.
651
    let (st, m) = api(
652
        app,
653
        "POST",
654
        "/api/v1/repos/andy/demo/milestones",
655
        Some(&andy_t),
656
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
657
    )
658
    .await;
659
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
660
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
661
    assert_eq!(
662
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
663
        StatusCode::BAD_REQUEST
664
    );
665
    assert_eq!(
666
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
667
        StatusCode::FORBIDDEN
668
    );
669
    let (st, m) =
670
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
671
            .await;
672
    assert_eq!(
673
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
674
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
675
        "{m}"
676
    );
677
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
678
    assert_eq!(
679
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
680
        StatusCode::NOT_FOUND,
681
        "renamed"
682
    );
683
    assert_eq!(
684
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
685
        StatusCode::BAD_REQUEST
686
    );
687
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
688
    assert_eq!(list.as_array().unwrap().len(), 1);
689
690
    // An issue created with its labels and assignee in one call.
691
    let (st, v) = api(
692
        app,
693
        "POST",
694
        "/api/v1/repos/andy/demo/issues",
695
        Some(&andy_t),
696
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
697
    )
698
    .await;
699
    assert_eq!(st, StatusCode::CREATED, "{v}");
700
    assert_eq!(v["labels"][0]["name"], "bug");
701
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
702
    let n = v["number"].as_i64().unwrap();
703
    // Unknown names are refused before anything is created.
704
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
705
    assert_eq!(st, StatusCode::BAD_REQUEST);
706
    assert!(v["detail"].as_str().unwrap().contains("no label"));
707
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
708
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
709
    // Without triage, labels cannot be set, but a plain issue can be opened.
710
    assert_eq!(
711
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
712
        StatusCode::FORBIDDEN
713
    );
714
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
715
    assert_eq!(st, StatusCode::CREATED);
716
    let bob_n = bobs["number"].as_i64().unwrap();
717
718
    // PATCH: the whole label set, assignees and milestone, with events.
719
    let (st, v) =
720
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
721
            .await;
722
    assert_eq!(st, StatusCode::OK, "{v}");
723
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
724
    assert_eq!(v["assignees"], serde_json::json!([]));
725
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
726
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
727
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
728
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
729
    // The author edits their own title; others cannot; nobody but triage sets labels.
730
    let (st, v) =
731
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
732
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
733
    assert_eq!(
734
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
735
        StatusCode::FORBIDDEN
736
    );
737
    assert_eq!(
738
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
739
        StatusCode::FORBIDDEN
740
    );
741
    assert_eq!(
742
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
743
        StatusCode::BAD_REQUEST
744
    );
745
746
    // Deleting a label takes it off the issues.
747
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
748
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
749
    assert_eq!(v["labels"], serde_json::json!([]));
750
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
751
}
752
753
#[tokio::test(flavor = "multi_thread")]
754
async fn webhook_formats_editing_and_web_issue_events() {
755
    let h = hub().await;
756
    let app = &h.app;
757
    let andy = call(
758
        app,
759
        "POST",
760
        "/register",
761
        None,
762
        None,
763
        None,
764
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
765
    )
766
    .await
767
    .cookie
768
    .unwrap();
769
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
770
    let r = call(
771
        app,
772
        "POST",
773
        "/settings/tokens",
774
        None,
775
        Some(&andy),
776
        None,
777
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
778
    )
779
    .await;
780
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
781
    assert_eq!(
782
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
783
        StatusCode::CREATED
784
    );
785
    let rx = receiver().await;
786
    *rx.fail_first.lock().unwrap() = false;
787
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
788
    let csrf = csrf_of(&settings);
789
    let form = |f: String| {
790
        let andy = andy.clone();
791
        async move {
792
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
793
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
794
        }
795
    };
796
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
797
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
798
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
799
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
800
    {
801
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
802
        let before: i64 =
803
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
804
        for i in 0..MAX_WAITING {
805
            sqlx::query(
806
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
807
            )
808
            .bind(hook.id)
809
            .bind(format!("flood-{i}"))
810
            .execute(&app.db)
811
            .await
812
            .unwrap();
813
        }
814
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
815
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
816
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
817
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
818
        let after: i64 =
819
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
820
        assert_eq!(before, after);
821
    }
822
    assert_eq!(hook.format, "discord");
823
    // Ping arrives as a Discord message.
824
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
825
    let mut got = String::new();
826
    for _ in 0..100 {
827
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
828
            got = body.clone();
829
        }
830
        if !got.is_empty() {
831
            break;
832
        }
833
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
834
    }
835
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
836
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
837
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
838
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
839
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
840
841
    // Editing: a blank URL and secret keep theirs; format, events and active change.
842
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
843
        .await
844
        .contains("Webhook saved"));
845
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
846
    assert_eq!(
847
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
848
        (rx.url.as_str(), "issue", "oxygenhub", true)
849
    );
850
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
851
852
    // An issue opened on the web now reaches the hook, as the signed envelope.
853
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
854
    call(
855
        app,
856
        "POST",
857
        "/andy/demo/issues/new",
858
        None,
859
        Some(&andy),
860
        None,
861
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
862
    )
863
    .await;
864
    let mut envelope = None;
865
    for _ in 0..100 {
866
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
867
        if envelope.is_some() {
868
            break;
869
        }
870
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
871
    }
872
    let (_, sig, body) = envelope.expect("issue.opened delivered");
873
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
874
    assert_eq!(v["data"]["issue"]["title"], "From the web");
875
    assert!(sig.starts_with("blake3-keyed="));
876
    // A disabled hook through the edit form (no active box).
877
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
878
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
879
}
880
881
#[tokio::test(flavor = "multi_thread")]
882
async fn api_projects() {
883
    let h = hub().await;
884
    let app = &h.app;
885
    let andy = call(
886
        app,
887
        "POST",
888
        "/register",
889
        None,
890
        None,
891
        None,
892
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
893
    )
894
    .await
895
    .cookie
896
    .unwrap();
897
    let bob = call(
898
        app,
899
        "POST",
900
        "/register",
901
        None,
902
        None,
903
        None,
904
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
905
    )
906
    .await
907
    .cookie
908
    .unwrap();
909
    let mint = |cookie: String, scopes: &'static str| {
910
        let app = app.clone();
911
        async move {
912
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
913
            let csrf = csrf_of(&page.body);
914
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
915
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
916
        }
917
    };
918
    let a = mint(andy, "scopes=repo%3Aadmin").await;
919
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
920
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
921
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
922
923
    // The caller's own repositories, a page at a time (#302); bob has none.
924
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"zeta","visibility":"private"}"#)).await;
925
    let names =
926
        |v: &serde_json::Value| -> Vec<String> { v.as_array().unwrap().iter().map(|r| r["name"].as_str().unwrap().to_string()).collect() };
927
    let (st, v) = api(app, "GET", "/api/v1/user/repos", Some(&a), None).await;
928
    assert_eq!((st, names(&v)), (StatusCode::OK, vec!["demo".to_string(), "zeta".to_string()]), "{v}");
929
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?limit=1", Some(&a), None).await.1), ["demo"]);
930
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?after=andy/demo", Some(&a), None).await.1), ["zeta"]);
931
    assert!(names(&api(app, "GET", "/api/v1/user/repos", Some(&b), None).await.1).is_empty(), "not bob's");
932
    assert_eq!(api(app, "GET", "/api/v1/user/repos?affiliation=friend", Some(&a), None).await.0, StatusCode::BAD_REQUEST);
933
    assert_eq!(api(app, "GET", "/api/v1/user/repos", None, None).await.0, StatusCode::UNAUTHORIZED);
934
    // The proposals to act on, as the dashboard lists them: bob's in andy's
935
    // repository is andy's to review and bob's own.
936
    let demo = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
937
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
938
    oxygenhub::db::proposals::create(
939
        &app.db,
940
        oxygenhub::db::proposals::NewProposal {
941
            repo_id: demo.id,
942
            title: "Faster startup",
943
            body: "",
944
            author_id: Some(bob_id),
945
            author: "bob",
946
            draft: false,
947
            target: "main",
948
            source_kind: "bookmark",
949
            source_repo_id: Some(demo.id),
950
            source_bookmark: "fast",
951
            source_changes: "",
952
        },
953
    )
954
    .await
955
    .unwrap();
956
    let (st, v) = api(app, "GET", "/api/v1/user/proposals", Some(&a), None).await;
957
    assert_eq!(st, StatusCode::OK, "{v}");
958
    assert_eq!((v["review"][0]["repository"].as_str(), v["review"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
959
    assert_eq!(v["review"][0]["state"], "open");
960
    assert!(v["review"][0]["url"].as_str().unwrap().ends_with("/andy/demo/proposal/2"));
961
    assert_eq!(v["authored"].as_array().map(Vec::len), Some(0));
962
    let (_, v) = api(app, "GET", "/api/v1/user/proposals", Some(&b), None).await;
963
    assert_eq!((v["review"].as_array().map(Vec::len), v["authored"][0]["title"].as_str()), (Some(0), Some("Faster startup")), "{v}");
964
    assert_eq!(api(app, "GET", "/api/v1/user/proposals", None, None).await.0, StatusCode::UNAUTHORIZED);
965
966
    // Organisations need user:read, which this token lacks.
967
    assert_eq!(api(app, "GET", "/api/v1/user/orgs", Some(&a), None).await.0, StatusCode::FORBIDDEN);
968
969
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
970
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
971
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
972
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
973
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
974
975
    // Cards by reference, into a column by name, and a note into the first column.
976
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
977
    assert_eq!(st, StatusCode::CREATED, "{card}");
978
    assert_eq!(
979
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
980
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
981
    );
982
    assert_eq!((card["labels"].as_array().map(Vec::len), card["assignees"].as_array().map(Vec::len)), (Some(0), Some(0)), "{card}");
983
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
984
    assert_eq!(st, StatusCode::BAD_REQUEST);
985
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
986
    assert_eq!(
987
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
988
        StatusCode::BAD_REQUEST
989
    );
990
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
991
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
992
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
993
994
    // Move and read the board.
995
    let id = card["id"].as_i64().unwrap();
996
    assert_eq!(
997
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
998
        StatusCode::NO_CONTENT
999
    );
1000
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1001
    let names: Vec<(&str, usize)> =
1002
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1003
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
1004
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
1005
    // The cards by column (#115), and a wrong method answers with a body.
1006
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
1007
    assert_eq!(st, StatusCode::OK);
1008
    assert_eq!(cols, board["columns"]);
1009
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
1010
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
1011
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
1012
1013
    // A column's cards at once (#289): with exceptions, a state filter and
1014
    // a dry run; one audit entry.
1015
    for t in ["Second", "Third"] {
1016
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(&format!(r#"{{"title":"{t}"}}"#))).await;
1017
    }
1018
    for n in [2, 3] {
1019
        let body = format!(r#"{{"reference":"demo#{n}","column":"Doing"}}"#);
1020
        assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(&body)).await.0, StatusCode::CREATED);
1021
    }
1022
    let bulk = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&a), Some(body));
1023
    let refs = |v: &serde_json::Value, k: &str| -> Vec<String> {
1024
        v[k].as_array().unwrap().iter().map(|c| c["reference"].as_str().unwrap().to_string()).collect()
1025
    };
1026
    let (st, v) = bulk(r##"{"from":"Doing","column":"Done","except":["#2"],"dry_run":true}"##).await;
1027
    assert_eq!(st, StatusCode::OK, "{v}");
1028
    assert_eq!((refs(&v, "moved"), refs(&v, "kept")), (vec!["andy/demo#3".to_string()], vec!["andy/demo#2".to_string()]));
1029
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1030
    assert_eq!(board["columns"][1]["cards"].as_array().unwrap().len(), 2, "a dry run moves nothing");
1031
    let (_, v) = bulk(r#"{"from":"Doing","column":"Done","state":["closed"]}"#).await;
1032
    assert!(refs(&v, "moved").is_empty(), "both are open: {v}");
1033
    let (_, v) = bulk(r#"{"from":"doing","column":"done","except":["demo#2"]}"#).await;
1034
    assert_eq!(refs(&v, "moved"), ["andy/demo#3"]);
1035
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1036
    let names: Vec<(&str, usize)> =
1037
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1038
    assert_eq!(names, [("Backlog", 1), ("Doing", 1), ("Done", 2)]);
1039
    let audited: i64 =
1040
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_moved'").fetch_one(&app.db).await.unwrap();
1041
    assert_eq!(audited, 1, "the dry run and the empty move are not audited");
1042
    assert_eq!(bulk(r#"{"from":"Done","column":"Done"}"#).await.0, StatusCode::BAD_REQUEST);
1043
    assert_eq!(
1044
        api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&b), Some(r#"{"from":"Doing","column":"Done"}"#)).await.0,
1045
        StatusCode::FORBIDDEN
1046
    );
1047
1048
    // Archive (#293): Done's cards there more than a week (#3, made old),
1049
    // listed with ?archived=true, restored once.
1050
    sqlx::query("UPDATE project_cards SET moved_ms = 0 WHERE number = 3").execute(&app.db).await.unwrap();
1051
    let archive = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/archive", Some(&a), Some(body));
1052
    let (st, v) = archive(r#"{"from":"Done","older_days":7,"dry_run":true}"#).await;
1053
    assert_eq!((st, refs(&v, "archived")), (StatusCode::OK, vec!["andy/demo#3".to_string()]), "{v}");
1054
    assert!(v["archived"][0].get("archived_ms").is_none(), "a dry run archives nothing: {v}");
1055
    let (_, v) = archive(r#"{"from":"Done","older_days":7}"#).await;
1056
    assert_eq!((refs(&v, "archived"), refs(&v, "kept").len()), (vec!["andy/demo#3".to_string()], 1), "{v}");
1057
    assert!(v["archived"][0]["archived_ms"].as_i64().is_some());
1058
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1059
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 1, "off the board: {board}");
1060
    let (st, archived) = api(app, "GET", "/api/v1/projects/andy/1/cards?archived=true", None, None).await;
1061
    assert_eq!((st, archived[2]["cards"][0]["reference"].as_str()), (StatusCode::OK, Some("andy/demo#3")), "{archived}");
1062
    let card = archived[2]["cards"][0]["id"].as_i64().unwrap();
1063
    let restore = format!("/api/v1/projects/andy/1/cards/{card}/restore");
1064
    assert_eq!(api(app, "POST", &restore, Some(&b), None).await.0, StatusCode::FORBIDDEN);
1065
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NO_CONTENT);
1066
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NOT_FOUND, "not archived now");
1067
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1068
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 2);
1069
    assert_eq!(archive(r#"{"from":"Done","older_days":-1}"#).await.0, StatusCode::BAD_REQUEST);
1070
    let audited: i64 =
1071
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_archived'").fetch_one(&app.db).await.unwrap();
1072
    assert_eq!(audited, 1);
1073
1074
    // Private: hidden from others; closed: read-only; then remove a card.
1075
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
1076
    assert_eq!(edited["public"], false);
1077
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
1078
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
1079
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
1080
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
1081
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
1082
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
1083
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
1084
}
1085
1086
#[tokio::test(flavor = "multi_thread")]
1087
async fn api_required_checks() {
1088
    let h = hub().await;
1089
    let app = &h.app;
1090
    let andy = call(
1091
        app,
1092
        "POST",
1093
        "/register",
1094
        None,
1095
        None,
1096
        None,
1097
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1098
    )
1099
    .await
1100
    .cookie
1101
    .unwrap();
1102
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1103
    let csrf = csrf_of(&page.body);
1104
    let mint = |scopes: &'static str| {
1105
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1106
        async move {
1107
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1108
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1109
        }
1110
    };
1111
    let admin = mint("scopes=repo%3Aadmin").await;
1112
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1113
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1114
1115
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1116
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1117
    let (st, v) = api(
1118
        app,
1119
        "PUT",
1120
        "/api/v1/repos/andy/demo/checks/required",
1121
        Some(&admin),
1122
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1123
    )
1124
    .await;
1125
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1126
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1127
    assert_eq!(
1128
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1129
        serde_json::json!(["flow/fmt", "flow/test"])
1130
    );
1131
    assert_eq!(
1132
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1133
        StatusCode::FORBIDDEN,
1134
        "repo:admin only"
1135
    );
1136
    assert_eq!(
1137
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1138
        StatusCode::BAD_REQUEST
1139
    );
1140
    // The settings page shows the same list.
1141
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
1142
}
1143
1144
/// OxygenFlow per repository: site administrators turn it on or off in
1145
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1146
#[tokio::test(flavor = "multi_thread")]
1147
async fn flow_is_switched_per_repository_by_site_admins() {
1148
    let h = hub().await;
1149
    let app = &h.app;
1150
    let andy = call(
1151
        app,
1152
        "POST",
1153
        "/register",
1154
        None,
1155
        None,
1156
        None,
1157
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1158
    )
1159
    .await
1160
    .cookie
1161
    .unwrap();
1162
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1163
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1164
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1165
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1166
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
1167
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
1168
1169
    let set = |value: &'static str| {
1170
        let (app, andy) = (app.clone(), andy.clone());
1171
        async move {
1172
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1173
            let r = call(
1174
                &app,
1175
                "POST",
1176
                "/andy/demo/settings/flow",
1177
                None,
1178
                Some(&andy),
1179
                None,
1180
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1181
            )
1182
            .await;
1183
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
1184
        }
1185
    };
1186
    // A repository admin who is not a site admin sees the state but cannot change it.
1187
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1188
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
1189
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1190
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1191
    let r = set("on").await;
1192
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1193
    assert_eq!(row().await.flow, "");
1194
1195
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1196
    let r = set("on").await;
1197
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1198
    assert_eq!(row().await.flow, "on");
1199
    assert!(oxygenhub::flow::enabled(app, &row().await));
1200
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1201
    set("off").await;
1202
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1203
    set("default").await;
1204
    assert_eq!(row().await.flow, "");
1205
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
1206
}
1207
1208
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1209
/// button, never the repository's default bookmark as the hub sets it.
1210
#[tokio::test(flavor = "multi_thread")]
1211
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1212
    let h = hub().await;
1213
    let app = &h.app;
1214
    let andy = call(
1215
        app,
1216
        "POST",
1217
        "/register",
1218
        None,
1219
        None,
1220
        None,
1221
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1222
    )
1223
    .await
1224
    .cookie
1225
    .unwrap();
1226
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1227
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1228
    let url = format!("{}/andy/demo", h.base);
1229
    let work = tempfile::tempdir().unwrap();
1230
    let (w, u) = (work.path().to_path_buf(), url.clone());
1231
    let client = tokio::task::spawn_blocking(move || {
1232
        let mut c = Repo::init(&w).unwrap();
1233
        c.config.set("remote.origin.url", &u).unwrap();
1234
        c.config.set("remote.origin.token", "site").unwrap();
1235
        c.save_config().unwrap();
1236
        write(&w, "a.txt", b"a\n");
1237
        c.commit("a", &[]).unwrap();
1238
        assert!(c.push("origin", false).unwrap()[0].ok);
1239
        for b in ["develop", "feature/x", "stray"] {
1240
            c.bookmark_create(b, None).unwrap();
1241
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1242
        }
1243
        // A pushed deletion.
1244
        let r = c.push_delete("origin", "feature/x").unwrap();
1245
        assert!(r[0].ok, "{r:?}");
1246
        c
1247
    })
1248
    .await
1249
    .unwrap();
1250
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1251
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1252
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1253
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1254
    assert!(!anon.body.contains("/bookmarks/delete"));
1255
1256
    // The hub's default, not the repository's config, is protected: make
1257
    // develop the default, then main can go and develop cannot.
1258
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1259
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1260
    let client = tokio::task::spawn_blocking(move || {
1261
        let r = client.push_delete("origin", "develop").unwrap();
1262
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1263
        let r = client.push_delete("origin", "main").unwrap();
1264
        assert!(r[0].ok, "{r:?}");
1265
        client
1266
    })
1267
    .await
1268
    .unwrap();
1269
    drop(client);
1270
1271
    // On the web: a writer deletes stray; the default is refused.
1272
    let form = |b: &'static str| {
1273
        let (app, andy) = (app.clone(), andy.clone());
1274
        async move {
1275
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1276
            call(
1277
                &app,
1278
                "POST",
1279
                "/andy/demo/bookmarks/delete",
1280
                None,
1281
                Some(&andy),
1282
                None,
1283
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1284
            )
1285
            .await
1286
        }
1287
    };
1288
    let r = form("stray").await;
1289
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1290
    assert!(!r.body.contains(">stray<"));
1291
    let r = form("develop").await;
1292
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1293
    let r = form("nope").await;
1294
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1295
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1296
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1297
    // Anonymous visitors cannot.
1298
    assert_ne!(
1299
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1300
        StatusCode::OK
1301
    );
1302
}
1303
1304
/// A change signed by a key no account has linked says so, on its page
1305
/// and in the API (feedback 14).
1306
#[tokio::test(flavor = "multi_thread")]
1307
async fn changes_signed_by_unlinked_keys_say_so() {
1308
    let h = hub().await;
1309
    let app = &h.app;
1310
    let andy = call(
1311
        app,
1312
        "POST",
1313
        "/register",
1314
        None,
1315
        None,
1316
        None,
1317
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1318
    )
1319
    .await
1320
    .cookie
1321
    .unwrap();
1322
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1323
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1324
    let url = format!("{}/andy/demo", h.base);
1325
    let work = tempfile::tempdir().unwrap();
1326
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1327
    let hash = tokio::task::spawn_blocking(move || {
1328
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1329
        c.config.set("remote.origin.url", &u).unwrap();
1330
        c.config.set("remote.origin.token", "site").unwrap();
1331
        c.save_config().unwrap();
1332
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1333
        write(&w.join("r"), "a.txt", b"a\n");
1334
        let h = c.commit("signed by Ada", &[]).unwrap();
1335
        assert!(c.push("origin", false).unwrap()[0].ok);
1336
        h.to_hex()
1337
    })
1338
    .await
1339
    .unwrap();
1340
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1341
    assert_eq!(st, StatusCode::OK, "{v}");
1342
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1343
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1344
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1345
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1346
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1347
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1348
}
1349
1350
/// Function history (hub spec §6.6): the file page lists a file's
1351
/// functions, and a function's page lists exactly the changes to its lines.
1352
#[tokio::test(flavor = "multi_thread")]
1353
async fn a_function_has_its_own_history() {
1354
    let h = hub().await;
1355
    let app = &h.app;
1356
    let andy = call(
1357
        app,
1358
        "POST",
1359
        "/register",
1360
        None,
1361
        None,
1362
        None,
1363
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1364
    )
1365
    .await
1366
    .cookie
1367
    .unwrap();
1368
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1369
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1370
    let url = format!("{}/andy/demo", h.base);
1371
    let work = tempfile::tempdir().unwrap();
1372
    let w = work.path().to_path_buf();
1373
    tokio::task::spawn_blocking(move || {
1374
        let mut c = Repo::init(&w).unwrap();
1375
        c.config.set("remote.origin.url", &url).unwrap();
1376
        c.config.set("remote.origin.token", "site").unwrap();
1377
        c.save_config().unwrap();
1378
        let steps = [
1379
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1380
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1381
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1382
        ];
1383
        for (msg, text) in steps {
1384
            write(&w, "src/lib.rs", text.as_bytes());
1385
            c.commit(msg, &[]).unwrap();
1386
        }
1387
        assert!(c.push("origin", false).unwrap()[0].ok);
1388
    })
1389
    .await
1390
    .unwrap();
1391
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1392
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1393
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1394
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1395
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1396
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1397
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1398
    assert_ne!(bad.status, StatusCode::OK);
1399
}
1400
1401
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1402
/// dependency edges, linked cards.
1403
#[tokio::test(flavor = "multi_thread")]
1404
async fn a_bookmark_shows_as_swimlanes() {
1405
    let h = hub().await;
1406
    let app = &h.app;
1407
    let andy = call(
1408
        app,
1409
        "POST",
1410
        "/register",
1411
        None,
1412
        None,
1413
        None,
1414
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1415
    )
1416
    .await
1417
    .cookie
1418
    .unwrap();
1419
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1420
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1421
    let url = format!("{}/andy/demo", h.base);
1422
    let work = tempfile::tempdir().unwrap();
1423
    let w = work.path().to_path_buf();
1424
    tokio::task::spawn_blocking(move || {
1425
        let mut c = Repo::init(&w).unwrap();
1426
        c.config.set("remote.origin.url", &url).unwrap();
1427
        c.config.set("remote.origin.token", "site").unwrap();
1428
        c.save_config().unwrap();
1429
        // Two files edited independently: two lanes.
1430
        write(&w, "a.txt", b"a\n");
1431
        c.commit("add a", &[]).unwrap();
1432
        write(&w, "b.txt", b"b\n");
1433
        c.commit("add b", &[]).unwrap();
1434
        write(&w, "a.txt", b"a\na2\n");
1435
        c.commit("grow a", &[]).unwrap();
1436
        assert!(c.push("origin", false).unwrap()[0].ok);
1437
    })
1438
    .await
1439
    .unwrap();
1440
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1441
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1442
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1443
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1444
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1445
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1446
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1447
    assert_eq!(board.matches("<rect ").count(), 3);
1448
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1449
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1450
}
1451
1452
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1453
/// offers only what makes sense and rewrites nothing itself.
1454
#[tokio::test(flavor = "multi_thread")]
1455
async fn a_proposal_board_plans_squashes_and_rebases() {
1456
    let h = hub().await;
1457
    let app = &h.app;
1458
    let andy = call(
1459
        app,
1460
        "POST",
1461
        "/register",
1462
        None,
1463
        None,
1464
        None,
1465
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1466
    )
1467
    .await
1468
    .cookie
1469
    .unwrap();
1470
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1471
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1472
    let url = format!("{}/andy/demo", h.base);
1473
    let work = tempfile::tempdir().unwrap();
1474
    let w = work.path().to_path_buf();
1475
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1476
        let mut c = Repo::init(&w).unwrap();
1477
        c.config.set("remote.origin.url", &url).unwrap();
1478
        c.config.set("remote.origin.token", "site").unwrap();
1479
        c.save_config().unwrap();
1480
        write(&w, "a.txt", b"a\n");
1481
        let base = c.commit("base", &[]).unwrap();
1482
        assert!(c.push("origin", false).unwrap()[0].ok);
1483
        c.bookmark_create("feature", None).unwrap();
1484
        c.bookmark_switch("feature", false).unwrap();
1485
        write(&w, "a.txt", b"a\nfirst\n");
1486
        let first = c.commit("first", &[]).unwrap();
1487
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1488
        let second = c.commit("second", &[]).unwrap();
1489
        write(&w, "b.txt", b"apart\n");
1490
        let apart = c.commit("apart", &[]).unwrap();
1491
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1492
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1493
    })
1494
    .await
1495
    .unwrap();
1496
    // No proposal yet: the board is read-only.
1497
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1498
    assert!(!board.contains("data-plan="));
1499
    let (st, _) = api(
1500
        app,
1501
        "POST",
1502
        "/api/v1/repos/andy/demo/proposals",
1503
        Some("site"),
1504
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1505
    )
1506
    .await;
1507
    assert!(st.is_success(), "{st}");
1508
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1509
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1510
    let csrf = csrf_of(&board);
1511
    let plan = |c: &str, t: &str| {
1512
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1513
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1514
        async move {
1515
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1516
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1517
        }
1518
    };
1519
    let kinds = |v: &serde_json::Value| {
1520
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1521
    };
1522
    // second already depends on first: squash, no rebase.
1523
    let v = plan(&second, &first).await;
1524
    assert_eq!(kinds(&v), ["squash"], "{v}");
1525
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1526
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
1527
    // apart is independent of second: either.
1528
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1529
    // first under second: nothing (second depends on first).
1530
    assert!(plan(&first, &second).await["error"].is_string());
1531
    // What has landed on main is not rearranged.
1532
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1533
}
1534
1535
/// Issues and proposals share a number space, so every number says what it
1536
/// is, and the chain of work shows from both ends (hub spec §8).
1537
#[tokio::test(flavor = "multi_thread")]
1538
async fn proposals_and_issues_show_their_chain() {
1539
    let h = hub().await;
1540
    let app = &h.app;
1541
    let andy = call(
1542
        app,
1543
        "POST",
1544
        "/register",
1545
        None,
1546
        None,
1547
        None,
1548
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1549
    )
1550
    .await
1551
    .cookie
1552
    .unwrap();
1553
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1554
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1555
    let url = format!("{}/andy/demo", h.base);
1556
    let work = tempfile::tempdir().unwrap();
1557
    let w = work.path().to_path_buf();
1558
    tokio::task::spawn_blocking(move || {
1559
        let mut c = Repo::init(&w).unwrap();
1560
        c.config.set("remote.origin.url", &url).unwrap();
1561
        c.config.set("remote.origin.token", "site").unwrap();
1562
        c.save_config().unwrap();
1563
        write(&w, "a.txt", b"a\n");
1564
        c.commit("base", &[]).unwrap();
1565
        assert!(c.push("origin", false).unwrap()[0].ok);
1566
        c.bookmark_create("feature", None).unwrap();
1567
        c.bookmark_switch("feature", false).unwrap();
1568
        write(&w, "a.txt", b"a\nfixed\n");
1569
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1570
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1571
    })
1572
    .await
1573
    .unwrap();
1574
    for title in ["Slow start", "Crash on save"] {
1575
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1576
        assert!(st.is_success());
1577
    }
1578
    let (st, v) = api(
1579
        app,
1580
        "POST",
1581
        "/api/v1/repos/andy/demo/proposals",
1582
        Some("site"),
1583
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1584
    )
1585
    .await;
1586
    assert!(st.is_success(), "{st} {v}");
1587
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1588
1589
    // The proposal names its kind, links its references by kind, and shows
1590
    // the chain: the issues it closes (description and changes) → it → main.
1591
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1592
    assert!(p.contains(">proposal #3</small>"), "header");
1593
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1594
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1595
    let chain = &chain[..chain.find("</p>").unwrap()];
1596
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1597
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1598
    }
1599
    assert!(p.contains("<h3>Closes</h3>"));
1600
1601
    // The issue shows the proposal that closes it, and names its own kind.
1602
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1603
    assert!(i.contains(">issue #1</small>"));
1604
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1605
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1606
    // The conversation is a timeline with avatars; editing sits with the
1607
    // content, not in the sidebar, and labels and projects are editable.
1608
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1609
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1610
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1611
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1612
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1613
    assert!(st.is_success(), "{st}");
1614
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1615
    assert!(
1616
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1617
        "the owner's projects to add to, in a menu"
1618
    );
1619
    let csrf = csrf_of(&p);
1620
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1621
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1622
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1623
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1624
        .await;
1625
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1626
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1627
1628
    // Closed by the proposal's change, not its description: still shown.
1629
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1630
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1631
    assert!(chain.contains("proposal #3"), "{chain}");
1632
}
1633
1634
/// What the hub is: its version and build, and the libraries it is built on,
1635
/// on /about, in the API and in /health (hub spec §15).
1636
#[tokio::test(flavor = "multi_thread")]
1637
async fn the_hub_says_what_version_it_is() {
1638
    let h = hub().await;
1639
    let app = &h.app;
1640
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1641
    assert_eq!(st, StatusCode::OK);
1642
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1643
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1644
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1645
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1646
    assert!(health.contains("\"build\""), "{health}");
1647
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1648
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
1649
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1650
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1651
    assert!(about.contains("href=\"/about\""), "the footer links here");
1652
}
1653
1654
#[tokio::test(flavor = "multi_thread")]
1655
async fn device_sign_in() {
1656
    let h = hub().await;
1657
    let app = &h.app;
1658
    let r = call(
1659
        app,
1660
        "POST",
1661
        "/register",
1662
        None,
1663
        None,
1664
        None,
1665
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1666
    )
1667
    .await;
1668
    let andy = r.cookie.unwrap();
1669
1670
    // An unknown scope is refused.
1671
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1672
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1673
1674
    // The app asks for a code and polls; nobody has approved it yet.
1675
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1676
    assert_eq!(st, StatusCode::OK, "{v}");
1677
    let device = v["device_code"].as_str().unwrap().to_string();
1678
    let user = v["user_code"].as_str().unwrap().to_string();
1679
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1680
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1681
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1682
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1683
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1684
    assert_eq!(v["error"], "slow_down", "polled too soon");
1685
1686
    // The user approves it on the web, allowing less than it asked for.
1687
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1688
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1689
    let csrf = csrf_of(&page.body);
1690
    let r =
1691
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1692
            .await;
1693
    // oxygenhub#83: the answer page says it is done, with no code form.
1694
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1695
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1696
1697
    // The next poll gets a token with what was allowed, once.
1698
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1699
    assert_eq!(st, StatusCode::OK, "{v}");
1700
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1701
    let token = v["access_token"].as_str().unwrap().to_string();
1702
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1703
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1704
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1705
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1706
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1707
    assert!(tokens.body.contains("device: Phone app"));
1708
    // oxygenhub#70: a device's token expires, and each use renews it.
1709
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1710
1711
    // The token can revoke itself (oxy auth logout), and is then refused.
1712
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1713
    assert_eq!(st, StatusCode::NO_CONTENT);
1714
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1715
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1716
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1717
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1718
1719
    // A denied code says so.
1720
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1721
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1722
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1723
    let csrf = csrf_of(&page.body);
1724
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1725
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1726
    assert_eq!(v["error"], "access_denied");
1727
1728
    // A code the app gave up on (#304) is gone at once: the page no longer
1729
    // takes it, and the app's poll says so.
1730
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Cancelled"}"#)).await;
1731
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1732
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1733
    assert_eq!(st, StatusCode::NO_CONTENT);
1734
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1735
    let csrf = csrf_of(&page.body);
1736
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve"))).await;
1737
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1738
    assert_eq!(v["error"], "expired_token", "{v}");
1739
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1740
    assert_eq!(st, StatusCode::NO_CONTENT, "again: still fine");
1741
1742
    // Signed out, the page asks for a sign-in first.
1743
    let r = call(app, "GET", "/device", None, None, None, None).await;
1744
    assert!(r.status.is_redirection(), "{}", r.status);
1745
}
1746
1747
#[tokio::test(flavor = "multi_thread")]
1748
async fn api_assistants_at_each_level() {
1749
    let h = hub().await;
1750
    let app = &h.app;
1751
    let andy = call(
1752
        app,
1753
        "POST",
1754
        "/register",
1755
        None,
1756
        None,
1757
        None,
1758
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1759
    )
1760
    .await
1761
    .cookie
1762
    .unwrap();
1763
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1764
    let csrf = csrf_of(&page.body);
1765
    let mint = |scopes: &'static str| {
1766
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1767
        async move {
1768
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1769
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1770
        }
1771
    };
1772
    let admin = mint("scopes=repo%3Aadmin").await;
1773
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1774
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1775
    // A stand-in endpoint with no model list: any model name is taken.
1776
    let router = axum::Router::new().route(
1777
        "/v1/chat/completions",
1778
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1779
    );
1780
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1781
    let port = listener.local_addr().unwrap().port();
1782
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1783
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1784
1785
    // The site's, by its administrator; the repository's, by its admin.
1786
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1787
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1788
    assert_eq!(st, StatusCode::OK, "{v}");
1789
    assert_eq!(v["ok"], "Gemini added");
1790
    let body =
1791
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1792
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1793
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1794
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1795
    assert_eq!(st, StatusCode::OK, "{v}");
1796
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1797
    assert_eq!(st, StatusCode::OK);
1798
    let names: Vec<(&str, &str, bool)> = v
1799
        .as_array()
1800
        .unwrap()
1801
        .iter()
1802
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1803
        .collect();
1804
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1805
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1806
    // Changing it keeps the token when none is given.
1807
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1808
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1809
    assert_eq!(v["ok"], "Claude updated");
1810
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1811
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1812
    // Prompts: the site's is inherited by the repository.
1813
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1814
    assert_eq!(st, StatusCode::OK);
1815
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1816
    assert_eq!(v["prompt"], "Rust.");
1817
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1818
    // Removed.
1819
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1820
    assert_eq!(st, StatusCode::NO_CONTENT);
1821
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1822
    assert_eq!(st, StatusCode::NOT_FOUND);
1823
}