OXYGENHUB
# b951c58734e8 oxygenhub / crates / hub / tests / api.rs
81.0 KiB · Rust · last changed Carry events between the hub's processes on an event bus 16 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    // The first account's setup code (oxygenhub#245).
46
    config.registration.setup_code = "test-setup".into();
47
    config.auth.push_tokens = vec!["site".into()];
48
    config.registration.mode = "open".into();
49
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
50
    let port = listener.local_addr().unwrap().port();
51
    config.server.base_url = format!("http://127.0.0.1:{port}");
52
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
53
    config.outbound.allow = vec!["http://127.0.0.1".into()];
54
    let app = oxygenhub::build(config).await.unwrap();
55
    let router = oxygenhub::router(app.clone());
56
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
57
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
58
}
59
60
struct Res {
61
    status: StatusCode,
62
    body: String,
63
    cookie: Option<String>,
64
}
65
66
async fn call(
67
    app: &Shared,
68
    method: &str,
69
    path: &str,
70
    bearer: Option<&str>,
71
    cookie: Option<&str>,
72
    json: Option<&str>,
73
    form: Option<&str>,
74
) -> Res {
75
    let mut req = Request::builder().method(method).uri(path);
76
    if let Some(b) = bearer {
77
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
78
    }
79
    if let Some(c) = cookie {
80
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
81
    }
82
    let body = if let Some(j) = json {
83
        req = req.header(header::CONTENT_TYPE, "application/json");
84
        Body::from(j.to_string())
85
    } else if let Some(f) = form {
86
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
87
        Body::from(f.to_string())
88
    } else {
89
        Body::empty()
90
    };
91
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
92
    let status = res.status();
93
    let cookie = res
94
        .headers()
95
        .get(header::SET_COOKIE)
96
        .and_then(|v| v.to_str().ok())
97
        .and_then(|v| v.split(';').next())
98
        .and_then(|kv| kv.split_once('='))
99
        .map(|(_, v)| v.to_string());
100
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
101
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
102
}
103
104
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
105
    let r = call(app, method, path, bearer, None, json, None).await;
106
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
107
    (r.status, v)
108
}
109
110
fn csrf_of(page: &str) -> String {
111
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
112
    page[i..].split('"').next().unwrap().to_string()
113
}
114
115
/// A webhook receiver that records what it gets and fails the first time.
116
struct Receiver {
117
    url: String,
118
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
119
    fail_first: Arc<Mutex<bool>>,
120
}
121
122
async fn receiver() -> Receiver {
123
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
124
    let fail_first = Arc::new(Mutex::new(true));
125
    let (s2, f2) = (seen.clone(), fail_first.clone());
126
    let router = Router::new().route(
127
        "/hook",
128
        post(move |headers: header::HeaderMap, body: String| {
129
            let (s2, f2) = (s2.clone(), f2.clone());
130
            async move {
131
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
132
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
133
                let mut f = f2.lock().unwrap();
134
                if *f {
135
                    *f = false;
136
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
137
                }
138
                s2.lock().unwrap().push((event, sig, body));
139
                (StatusCode::OK, "ok")
140
            }
141
        }),
142
    );
143
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
144
    let port = listener.local_addr().unwrap().port();
145
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
146
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
147
}
148
149
#[tokio::test(flavor = "multi_thread")]
150
async fn api_webhooks_and_checks() {
151
    let h = hub().await;
152
    let app = &h.app;
153
    // Accounts and tokens through the pages.
154
    let r = call(
155
        app,
156
        "POST",
157
        "/register",
158
        None,
159
        None,
160
        None,
161
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
162
    )
163
    .await;
164
    let andy = r.cookie.unwrap();
165
    let r = call(
166
        app,
167
        "POST",
168
        "/register",
169
        None,
170
        None,
171
        None,
172
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
173
    )
174
    .await;
175
    let bob = r.cookie.unwrap();
176
    let mint = |cookie: String, scopes: &'static str| {
177
        let app = app.clone();
178
        async move {
179
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
180
            let csrf = csrf_of(&page.body);
181
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
182
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
183
        }
184
    };
185
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
186
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
187
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
188
189
    // Create a repository through the API; the read-only token cannot.
190
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
191
    assert_eq!(st, StatusCode::FORBIDDEN);
192
    let (st, v) = api(
193
        app,
194
        "POST",
195
        "/api/v1/repos",
196
        Some(&andy_admin),
197
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
198
    )
199
    .await;
200
    assert_eq!(st, StatusCode::CREATED, "{v}");
201
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
202
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
203
    assert_eq!(st, StatusCode::CONFLICT);
204
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
205
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
206
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
207
    assert_eq!(st, StatusCode::OK);
208
    assert_eq!(v["username"], "andy");
209
210
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
211
    let rx = receiver().await;
212
    let (st, v) = api(
213
        app,
214
        "POST",
215
        "/api/v1/repos/andy/demo/hooks",
216
        Some(&andy_admin),
217
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
218
    )
219
    .await;
220
    assert_eq!(st, StatusCode::CREATED, "{v}");
221
    let work = tempfile::tempdir().unwrap();
222
    let mut client = Repo::init(work.path()).unwrap();
223
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
224
    client.config.set("remote.origin.token", "site").unwrap();
225
    client.save_config().unwrap();
226
    write(work.path(), "a.txt", b"a\n");
227
    client.snapshot("t").unwrap();
228
    let base = client.commit("base", &[]).unwrap();
229
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
230
    // The worker retries with backoff; drive it directly for the retry.
231
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
232
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
233
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
234
    oxygenhub::hooks::deliver_due(app).await;
235
    let seen = rx.seen.lock().unwrap().clone();
236
    assert_eq!(seen.len(), 1, "{seen:?}");
237
    assert_eq!(seen[0].0, "push");
238
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
239
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
240
    assert_eq!(payload["repository"]["name"], "demo");
241
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
242
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
243
    assert_eq!(v.as_array().unwrap().len(), 1);
244
245
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
246
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
247
    assert_eq!(st, StatusCode::OK);
248
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
249
    // A revset in place of the whole history (`?r=`), under a budget; a
250
    // bad one is the caller's problem.
251
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
252
    assert_eq!(st, StatusCode::OK, "{v}");
253
    assert_eq!(v["total"].as_u64(), Some(1));
254
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
255
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
256
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
257
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
258
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
259
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
260
    assert_eq!(v[0]["name"], "a.txt");
261
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
262
    assert_eq!(r.body, "a\n");
263
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
264
    assert_eq!(v[0]["change"], base.to_hex());
265
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
266
    assert_eq!(v["files"][0]["path"], "a.txt");
267
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
268
    assert!(v["policy"].is_null());
269
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
270
    assert_eq!(v[0]["reference"], "main");
271
272
    // Issues through the API: Bob opens one, comments, and closes it.
273
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
274
    assert_eq!(st, StatusCode::CREATED, "{v}");
275
    assert_eq!(v["number"], 1);
276
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
277
    assert_eq!(st, StatusCode::CREATED);
278
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
279
    assert_eq!(st, StatusCode::OK, "{v}");
280
    assert_eq!(v["state"], "closed");
281
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
282
    assert_eq!(v[0]["comments"], 1);
283
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
284
    assert_eq!(v[0]["number"], 1);
285
286
    // A proposal through the API, then a required check gates its landing.
287
    client.bookmark_create("feat", Some(&[base])).unwrap();
288
    client.bookmark_switch("feat", false).unwrap();
289
    write(work.path(), "b.txt", b"b\n");
290
    write(work.path(), "a.txt", b"a\nA\n");
291
    client.snapshot("t").unwrap();
292
    let feat = client.commit("feat", &[]).unwrap();
293
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
294
    let (st, v) =
295
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
296
            .await;
297
    assert_eq!(st, StatusCode::CREATED, "{v}");
298
    assert_eq!(v["number"], 2);
299
    let state = v["projected_state"].as_str().unwrap().to_string();
300
    assert_eq!(v["landable"], true);
301
    // Its files, and each side's bytes, for editors' diff views.
302
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
303
    assert_eq!(st, StatusCode::OK, "{v}");
304
    let files: Vec<(String, String)> =
305
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
306
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
307
    assert_eq!(v[0]["added"], 1);
308
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
309
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
310
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
311
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
312
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
313
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
314
    // An anchored comment comes back with its line in the projected state.
315
    let (st, v) = api(
316
        app,
317
        "POST",
318
        "/api/v1/repos/andy/demo/proposals/2/comments",
319
        Some(&bob_rw),
320
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
321
    )
322
    .await;
323
    assert_eq!(st, StatusCode::CREATED, "{v}");
324
    assert_eq!(v["line"], 2);
325
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
326
    assert_eq!(v[0]["path"], "a.txt");
327
    assert_eq!(v[0]["line"], 2, "{v}");
328
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
329
    // Require the "build" check.
330
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
331
    let csrf = csrf_of(&settings.body);
332
    assert_eq!(
333
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
334
            .await
335
            .status,
336
        StatusCode::OK
337
    );
338
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
339
    assert_eq!(v["landable"], false);
340
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
341
    // A checker reports on the projected state: first running, then passed; the page streams it.
342
    let (st, v) = api(
343
        app,
344
        "POST",
345
        "/api/v1/repos/andy/demo/checks",
346
        Some(&andy_ro),
347
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
348
    )
349
    .await;
350
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
351
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
352
    let (st, v) = api(
353
        app,
354
        "POST",
355
        "/api/v1/repos/andy/demo/checks",
356
        Some(&bob_rw),
357
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
358
    )
359
    .await;
360
    assert_eq!(st, StatusCode::CREATED, "{v}");
361
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
362
    assert_eq!(ev.kind, "check");
363
    assert_eq!(ev.check.unwrap().name, "build");
364
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
365
    assert_eq!(v[0]["status"], "passed");
366
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
367
    assert_eq!(v["landable"], true, "{v}");
368
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
369
    assert!(page.body.contains("42 tests"), "{}", page.body);
370
    // The check and the proposal reached the webhook too.
371
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
372
    oxygenhub::hooks::deliver_due(app).await;
373
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
374
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
375
    let _ = feat;
376
    let _ = rx.fail_first;
377
378
    // The inbox through the API: count, list, mark one read, mark all read.
379
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
380
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
381
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
382
    oxygenhub::db::notify::add(
383
        &app.db,
384
        oxygenhub::db::notify::New {
385
            account_id: bob_id,
386
            repo_id: None,
387
            reason: oxygenhub::db::notify::Reason::Participating,
388
            kind: "mention",
389
            title: "andy/demo#1: Bug",
390
            url: "/andy/demo/issue/1",
391
            actor: "andy",
392
        },
393
    )
394
    .await
395
    .unwrap();
396
    oxygenhub::db::notify::add(
397
        &app.db,
398
        oxygenhub::db::notify::New {
399
            account_id: bob_id,
400
            repo_id: None,
401
            reason: oxygenhub::db::notify::Reason::Participating,
402
            kind: "review",
403
            title: "andy/demo#2: Feat",
404
            url: "/andy/demo/proposal/2",
405
            actor: "andy",
406
        },
407
    )
408
    .await
409
    .unwrap();
410
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
411
    assert_eq!(st, StatusCode::OK, "{v}");
412
    assert_eq!(v["unread"], 2);
413
    assert_eq!(v["items"][0]["read"], false);
414
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
415
    let first = v["items"][0]["id"].as_i64().unwrap();
416
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
417
    assert_eq!(st, StatusCode::NO_CONTENT);
418
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
419
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
420
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
421
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
422
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
423
424
    // Review requests: the author asks andy; andy is told, reviews, and the
425
    // request is answered; the author hears of the review.
426
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
427
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
428
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
429
        .await
430
        .unwrap();
431
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
432
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
433
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
434
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
435
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
436
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
437
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
438
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
439
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
440
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
441
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
442
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
443
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
444
    let (st, _) =
445
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
446
    assert_eq!(st, StatusCode::CREATED);
447
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
448
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
449
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
450
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
451
    // Asking again and withdrawing it.
452
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
453
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
454
    assert_eq!(st, StatusCode::NO_CONTENT);
455
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
456
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
457
    // oxygenhub#84: the page's menu sets who is asked, all at once.
458
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
459
    assert!(
460
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
461
        "the reviewers menu lists andy"
462
    );
463
    let csrf = csrf_of(&page.body);
464
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
465
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
466
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
467
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
468
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
469
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
470
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
471
472
    // A source bookmark with `/` in its name, as a feature/N-name workflow
473
    // makes them: by name, and as this repository's owner/name:bookmark.
474
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
475
        client.bookmark_create(b, Some(&[base])).unwrap();
476
        client.bookmark_switch(b, false).unwrap();
477
        write(work.path(), file, b"c\n");
478
        client.snapshot("t").unwrap();
479
        client.commit(b, &[]).unwrap();
480
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
481
    }
482
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
483
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
484
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
485
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
486
        let n = v["number"].as_i64().unwrap();
487
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
488
        assert_eq!(page.status, StatusCode::OK);
489
        assert!(page.body.contains("feature/"), "the page names its source");
490
    }
491
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
492
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
493
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
494
495
    // oxygenhub#76: a proposal's title and description are edited through
496
    // the API by its author or a maintainer; what is not given stays.
497
    let edit = |token: &str, number: i64, body: &str| {
498
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
499
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
500
    };
501
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
502
    assert_eq!(st, StatusCode::OK, "{v}");
503
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
504
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
505
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
506
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
507
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
508
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
509
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
510
    let (st, v) = api(
511
        app,
512
        "POST",
513
        "/api/v1/repos/andy/demo/proposals",
514
        Some(&andy_pw),
515
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
516
    )
517
    .await;
518
    assert_eq!(st, StatusCode::CREATED, "{v}");
519
    let n = v["number"].as_i64().unwrap();
520
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
521
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
522
523
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
524
    // before anything changes, shown in its JSON.
525
    for l in ["ui", "flow"] {
526
        let body = format!(r#"{{"name":"{l}"}}"#);
527
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
528
    }
529
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
530
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
531
    assert_eq!(st, StatusCode::OK, "{v}");
532
    let names = |v: &serde_json::Value| -> Vec<String> {
533
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
534
    };
535
    assert_eq!(names(&v), ["flow", "ui"]);
536
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
537
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
538
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
539
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
540
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
541
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
542
    assert_eq!(names(&v), ["flow"]);
543
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
544
}
545
546
#[tokio::test(flavor = "multi_thread")]
547
async fn api_issue_triage_and_labels() {
548
    let h = hub().await;
549
    let app = &h.app;
550
    let andy = call(
551
        app,
552
        "POST",
553
        "/register",
554
        None,
555
        None,
556
        None,
557
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
558
    )
559
    .await
560
    .cookie
561
    .unwrap();
562
    let bob = call(
563
        app,
564
        "POST",
565
        "/register",
566
        None,
567
        None,
568
        None,
569
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
570
    )
571
    .await
572
    .cookie
573
    .unwrap();
574
    let mint = |cookie: String, scopes: &'static str| {
575
        let app = app.clone();
576
        async move {
577
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
578
            let csrf = csrf_of(&page.body);
579
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
580
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
581
        }
582
    };
583
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
584
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
585
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
586
    assert_eq!(st, StatusCode::CREATED);
587
588
    // Labels through the API; bad colours and non-triage callers are refused.
589
    let (st, v) = api(
590
        app,
591
        "POST",
592
        "/api/v1/repos/andy/demo/labels",
593
        Some(&andy_t),
594
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
595
    )
596
    .await;
597
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
598
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
599
    assert_eq!(
600
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
601
        StatusCode::BAD_REQUEST
602
    );
603
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
604
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
605
    assert_eq!(labels.as_array().unwrap().len(), 2);
606
    // oxygenhub#91: milestones over the API, for triage.
607
    let (st, m) = api(
608
        app,
609
        "POST",
610
        "/api/v1/repos/andy/demo/milestones",
611
        Some(&andy_t),
612
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
613
    )
614
    .await;
615
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
616
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
617
    assert_eq!(
618
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
619
        StatusCode::BAD_REQUEST
620
    );
621
    assert_eq!(
622
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
623
        StatusCode::FORBIDDEN
624
    );
625
    let (st, m) =
626
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
627
            .await;
628
    assert_eq!(
629
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
630
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
631
        "{m}"
632
    );
633
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
634
    assert_eq!(
635
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
636
        StatusCode::NOT_FOUND,
637
        "renamed"
638
    );
639
    assert_eq!(
640
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
641
        StatusCode::BAD_REQUEST
642
    );
643
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
644
    assert_eq!(list.as_array().unwrap().len(), 1);
645
646
    // An issue created with its labels and assignee in one call.
647
    let (st, v) = api(
648
        app,
649
        "POST",
650
        "/api/v1/repos/andy/demo/issues",
651
        Some(&andy_t),
652
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
653
    )
654
    .await;
655
    assert_eq!(st, StatusCode::CREATED, "{v}");
656
    assert_eq!(v["labels"][0]["name"], "bug");
657
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
658
    let n = v["number"].as_i64().unwrap();
659
    // Unknown names are refused before anything is created.
660
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
661
    assert_eq!(st, StatusCode::BAD_REQUEST);
662
    assert!(v["detail"].as_str().unwrap().contains("no label"));
663
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
664
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
665
    // Without triage, labels cannot be set, but a plain issue can be opened.
666
    assert_eq!(
667
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
668
        StatusCode::FORBIDDEN
669
    );
670
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
671
    assert_eq!(st, StatusCode::CREATED);
672
    let bob_n = bobs["number"].as_i64().unwrap();
673
674
    // PATCH: the whole label set, assignees and milestone, with events.
675
    let (st, v) =
676
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
677
            .await;
678
    assert_eq!(st, StatusCode::OK, "{v}");
679
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
680
    assert_eq!(v["assignees"], serde_json::json!([]));
681
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
682
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
683
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
684
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
685
    // The author edits their own title; others cannot; nobody but triage sets labels.
686
    let (st, v) =
687
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
688
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
689
    assert_eq!(
690
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
691
        StatusCode::FORBIDDEN
692
    );
693
    assert_eq!(
694
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
695
        StatusCode::FORBIDDEN
696
    );
697
    assert_eq!(
698
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
699
        StatusCode::BAD_REQUEST
700
    );
701
702
    // Deleting a label takes it off the issues.
703
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
704
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
705
    assert_eq!(v["labels"], serde_json::json!([]));
706
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
707
}
708
709
#[tokio::test(flavor = "multi_thread")]
710
async fn webhook_formats_editing_and_web_issue_events() {
711
    let h = hub().await;
712
    let app = &h.app;
713
    let andy = call(
714
        app,
715
        "POST",
716
        "/register",
717
        None,
718
        None,
719
        None,
720
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
721
    )
722
    .await
723
    .cookie
724
    .unwrap();
725
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
726
    let r = call(
727
        app,
728
        "POST",
729
        "/settings/tokens",
730
        None,
731
        Some(&andy),
732
        None,
733
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
734
    )
735
    .await;
736
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
737
    assert_eq!(
738
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
739
        StatusCode::CREATED
740
    );
741
    let rx = receiver().await;
742
    *rx.fail_first.lock().unwrap() = false;
743
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
744
    let csrf = csrf_of(&settings);
745
    let form = |f: String| {
746
        let andy = andy.clone();
747
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
748
    };
749
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
750
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
751
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
752
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
753
    {
754
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
755
        let before: i64 =
756
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
757
        for i in 0..MAX_WAITING {
758
            sqlx::query(
759
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
760
            )
761
            .bind(hook.id)
762
            .bind(format!("flood-{i}"))
763
            .execute(&app.db)
764
            .await
765
            .unwrap();
766
        }
767
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
768
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
769
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
770
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
771
        let after: i64 =
772
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
773
        assert_eq!(before, after);
774
    }
775
    assert_eq!(hook.format, "discord");
776
    // Ping arrives as a Discord message.
777
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
778
    let mut got = String::new();
779
    for _ in 0..100 {
780
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
781
            got = body.clone();
782
        }
783
        if !got.is_empty() {
784
            break;
785
        }
786
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
787
    }
788
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
789
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
790
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
791
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
792
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
793
794
    // Editing: a blank URL and secret keep theirs; format, events and active change.
795
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
796
        .await
797
        .contains("Webhook saved"));
798
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
799
    assert_eq!(
800
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
801
        (rx.url.as_str(), "issue", "oxygenhub", true)
802
    );
803
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
804
805
    // An issue opened on the web now reaches the hook, as the signed envelope.
806
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
807
    call(
808
        app,
809
        "POST",
810
        "/andy/demo/issues/new",
811
        None,
812
        Some(&andy),
813
        None,
814
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
815
    )
816
    .await;
817
    let mut envelope = None;
818
    for _ in 0..100 {
819
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
820
        if envelope.is_some() {
821
            break;
822
        }
823
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
824
    }
825
    let (_, sig, body) = envelope.expect("issue.opened delivered");
826
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
827
    assert_eq!(v["data"]["issue"]["title"], "From the web");
828
    assert!(sig.starts_with("blake3-keyed="));
829
    // A disabled hook through the edit form (no active box).
830
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
831
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
832
}
833
834
#[tokio::test(flavor = "multi_thread")]
835
async fn api_projects() {
836
    let h = hub().await;
837
    let app = &h.app;
838
    let andy = call(
839
        app,
840
        "POST",
841
        "/register",
842
        None,
843
        None,
844
        None,
845
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
846
    )
847
    .await
848
    .cookie
849
    .unwrap();
850
    let bob = call(
851
        app,
852
        "POST",
853
        "/register",
854
        None,
855
        None,
856
        None,
857
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
858
    )
859
    .await
860
    .cookie
861
    .unwrap();
862
    let mint = |cookie: String, scopes: &'static str| {
863
        let app = app.clone();
864
        async move {
865
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
866
            let csrf = csrf_of(&page.body);
867
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
868
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
869
        }
870
    };
871
    let a = mint(andy, "scopes=repo%3Aadmin").await;
872
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
873
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
874
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
875
876
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
877
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
878
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
879
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
880
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
881
882
    // Cards by reference, into a column by name, and a note into the first column.
883
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
884
    assert_eq!(st, StatusCode::CREATED, "{card}");
885
    assert_eq!(
886
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
887
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
888
    );
889
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
890
    assert_eq!(st, StatusCode::BAD_REQUEST);
891
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
892
    assert_eq!(
893
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
894
        StatusCode::BAD_REQUEST
895
    );
896
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
897
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
898
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
899
900
    // Move and read the board.
901
    let id = card["id"].as_i64().unwrap();
902
    assert_eq!(
903
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
904
        StatusCode::NO_CONTENT
905
    );
906
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
907
    let names: Vec<(&str, usize)> =
908
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
909
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
910
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
911
    // The cards by column (#115), and a wrong method answers with a body.
912
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
913
    assert_eq!(st, StatusCode::OK);
914
    assert_eq!(cols, board["columns"]);
915
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
916
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
917
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
918
919
    // Private: hidden from others; closed: read-only; then remove a card.
920
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
921
    assert_eq!(edited["public"], false);
922
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
923
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
924
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
925
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
926
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
927
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
928
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
929
}
930
931
#[tokio::test(flavor = "multi_thread")]
932
async fn api_required_checks() {
933
    let h = hub().await;
934
    let app = &h.app;
935
    let andy = call(
936
        app,
937
        "POST",
938
        "/register",
939
        None,
940
        None,
941
        None,
942
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
943
    )
944
    .await
945
    .cookie
946
    .unwrap();
947
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
948
    let csrf = csrf_of(&page.body);
949
    let mint = |scopes: &'static str| {
950
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
951
        async move {
952
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
953
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
954
        }
955
    };
956
    let admin = mint("scopes=repo%3Aadmin").await;
957
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
958
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
959
960
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
961
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
962
    let (st, v) = api(
963
        app,
964
        "PUT",
965
        "/api/v1/repos/andy/demo/checks/required",
966
        Some(&admin),
967
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
968
    )
969
    .await;
970
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
971
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
972
    assert_eq!(
973
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
974
        serde_json::json!(["flow/fmt", "flow/test"])
975
    );
976
    assert_eq!(
977
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
978
        StatusCode::FORBIDDEN,
979
        "repo:admin only"
980
    );
981
    assert_eq!(
982
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
983
        StatusCode::BAD_REQUEST
984
    );
985
    // The settings page shows the same list.
986
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
987
}
988
989
/// OxygenFlow per repository: site administrators turn it on or off in
990
/// the repository's settings; hub.toml's `[flow] repos` is the default.
991
#[tokio::test(flavor = "multi_thread")]
992
async fn flow_is_switched_per_repository_by_site_admins() {
993
    let h = hub().await;
994
    let app = &h.app;
995
    let andy = call(
996
        app,
997
        "POST",
998
        "/register",
999
        None,
1000
        None,
1001
        None,
1002
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1003
    )
1004
    .await
1005
    .cookie
1006
    .unwrap();
1007
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1008
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1009
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1010
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1011
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
1012
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
1013
1014
    let set = |value: &'static str| {
1015
        let (app, andy) = (app.clone(), andy.clone());
1016
        async move {
1017
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
1018
            call(
1019
                &app,
1020
                "POST",
1021
                "/andy/demo/settings/flow",
1022
                None,
1023
                Some(&andy),
1024
                None,
1025
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1026
            )
1027
            .await
1028
        }
1029
    };
1030
    // A repository admin who is not a site admin sees the state but cannot change it.
1031
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1032
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
1033
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
1034
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1035
    let r = set("on").await;
1036
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1037
    assert_eq!(row().await.flow, "");
1038
1039
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1040
    let r = set("on").await;
1041
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1042
    assert_eq!(row().await.flow, "on");
1043
    assert!(oxygenhub::flow::enabled(app, &row().await));
1044
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1045
    set("off").await;
1046
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1047
    set("default").await;
1048
    assert_eq!(row().await.flow, "");
1049
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
1050
}
1051
1052
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1053
/// button, never the repository's default bookmark as the hub sets it.
1054
#[tokio::test(flavor = "multi_thread")]
1055
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1056
    let h = hub().await;
1057
    let app = &h.app;
1058
    let andy = call(
1059
        app,
1060
        "POST",
1061
        "/register",
1062
        None,
1063
        None,
1064
        None,
1065
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1066
    )
1067
    .await
1068
    .cookie
1069
    .unwrap();
1070
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1071
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1072
    let url = format!("{}/andy/demo", h.base);
1073
    let work = tempfile::tempdir().unwrap();
1074
    let (w, u) = (work.path().to_path_buf(), url.clone());
1075
    let client = tokio::task::spawn_blocking(move || {
1076
        let mut c = Repo::init(&w).unwrap();
1077
        c.config.set("remote.origin.url", &u).unwrap();
1078
        c.config.set("remote.origin.token", "site").unwrap();
1079
        c.save_config().unwrap();
1080
        write(&w, "a.txt", b"a\n");
1081
        c.commit("a", &[]).unwrap();
1082
        assert!(c.push("origin", false).unwrap()[0].ok);
1083
        for b in ["develop", "feature/x", "stray"] {
1084
            c.bookmark_create(b, None).unwrap();
1085
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1086
        }
1087
        // A pushed deletion.
1088
        let r = c.push_delete("origin", "feature/x").unwrap();
1089
        assert!(r[0].ok, "{r:?}");
1090
        c
1091
    })
1092
    .await
1093
    .unwrap();
1094
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1095
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1096
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1097
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1098
    assert!(!anon.body.contains("/bookmarks/delete"));
1099
1100
    // The hub's default, not the repository's config, is protected: make
1101
    // develop the default, then main can go and develop cannot.
1102
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1103
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1104
    let client = tokio::task::spawn_blocking(move || {
1105
        let r = client.push_delete("origin", "develop").unwrap();
1106
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1107
        let r = client.push_delete("origin", "main").unwrap();
1108
        assert!(r[0].ok, "{r:?}");
1109
        client
1110
    })
1111
    .await
1112
    .unwrap();
1113
    drop(client);
1114
1115
    // On the web: a writer deletes stray; the default is refused.
1116
    let form = |b: &'static str| {
1117
        let (app, andy) = (app.clone(), andy.clone());
1118
        async move {
1119
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1120
            call(
1121
                &app,
1122
                "POST",
1123
                "/andy/demo/bookmarks/delete",
1124
                None,
1125
                Some(&andy),
1126
                None,
1127
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1128
            )
1129
            .await
1130
        }
1131
    };
1132
    let r = form("stray").await;
1133
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1134
    assert!(!r.body.contains(">stray<"));
1135
    let r = form("develop").await;
1136
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1137
    let r = form("nope").await;
1138
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1139
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1140
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1141
    // Anonymous visitors cannot.
1142
    assert_ne!(
1143
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1144
        StatusCode::OK
1145
    );
1146
}
1147
1148
/// A change signed by a key no account has linked says so, on its page
1149
/// and in the API (feedback 14).
1150
#[tokio::test(flavor = "multi_thread")]
1151
async fn changes_signed_by_unlinked_keys_say_so() {
1152
    let h = hub().await;
1153
    let app = &h.app;
1154
    let andy = call(
1155
        app,
1156
        "POST",
1157
        "/register",
1158
        None,
1159
        None,
1160
        None,
1161
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1162
    )
1163
    .await
1164
    .cookie
1165
    .unwrap();
1166
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1167
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1168
    let url = format!("{}/andy/demo", h.base);
1169
    let work = tempfile::tempdir().unwrap();
1170
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1171
    let hash = tokio::task::spawn_blocking(move || {
1172
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1173
        c.config.set("remote.origin.url", &u).unwrap();
1174
        c.config.set("remote.origin.token", "site").unwrap();
1175
        c.save_config().unwrap();
1176
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1177
        write(&w.join("r"), "a.txt", b"a\n");
1178
        let h = c.commit("signed by Ada", &[]).unwrap();
1179
        assert!(c.push("origin", false).unwrap()[0].ok);
1180
        h.to_hex()
1181
    })
1182
    .await
1183
    .unwrap();
1184
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1185
    assert_eq!(st, StatusCode::OK, "{v}");
1186
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1187
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1188
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1189
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1190
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1191
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1192
}
1193
1194
/// Function history (hub spec §6.6): the file page lists a file's
1195
/// functions, and a function's page lists exactly the changes to its lines.
1196
#[tokio::test(flavor = "multi_thread")]
1197
async fn a_function_has_its_own_history() {
1198
    let h = hub().await;
1199
    let app = &h.app;
1200
    let andy = call(
1201
        app,
1202
        "POST",
1203
        "/register",
1204
        None,
1205
        None,
1206
        None,
1207
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1208
    )
1209
    .await
1210
    .cookie
1211
    .unwrap();
1212
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1213
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1214
    let url = format!("{}/andy/demo", h.base);
1215
    let work = tempfile::tempdir().unwrap();
1216
    let w = work.path().to_path_buf();
1217
    tokio::task::spawn_blocking(move || {
1218
        let mut c = Repo::init(&w).unwrap();
1219
        c.config.set("remote.origin.url", &url).unwrap();
1220
        c.config.set("remote.origin.token", "site").unwrap();
1221
        c.save_config().unwrap();
1222
        let steps = [
1223
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1224
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1225
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1226
        ];
1227
        for (msg, text) in steps {
1228
            write(&w, "src/lib.rs", text.as_bytes());
1229
            c.commit(msg, &[]).unwrap();
1230
        }
1231
        assert!(c.push("origin", false).unwrap()[0].ok);
1232
    })
1233
    .await
1234
    .unwrap();
1235
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1236
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1237
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1238
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1239
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1240
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1241
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1242
    assert_ne!(bad.status, StatusCode::OK);
1243
}
1244
1245
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1246
/// dependency edges, linked cards.
1247
#[tokio::test(flavor = "multi_thread")]
1248
async fn a_bookmark_shows_as_swimlanes() {
1249
    let h = hub().await;
1250
    let app = &h.app;
1251
    let andy = call(
1252
        app,
1253
        "POST",
1254
        "/register",
1255
        None,
1256
        None,
1257
        None,
1258
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1259
    )
1260
    .await
1261
    .cookie
1262
    .unwrap();
1263
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1264
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1265
    let url = format!("{}/andy/demo", h.base);
1266
    let work = tempfile::tempdir().unwrap();
1267
    let w = work.path().to_path_buf();
1268
    tokio::task::spawn_blocking(move || {
1269
        let mut c = Repo::init(&w).unwrap();
1270
        c.config.set("remote.origin.url", &url).unwrap();
1271
        c.config.set("remote.origin.token", "site").unwrap();
1272
        c.save_config().unwrap();
1273
        // Two files edited independently: two lanes.
1274
        write(&w, "a.txt", b"a\n");
1275
        c.commit("add a", &[]).unwrap();
1276
        write(&w, "b.txt", b"b\n");
1277
        c.commit("add b", &[]).unwrap();
1278
        write(&w, "a.txt", b"a\na2\n");
1279
        c.commit("grow a", &[]).unwrap();
1280
        assert!(c.push("origin", false).unwrap()[0].ok);
1281
    })
1282
    .await
1283
    .unwrap();
1284
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1285
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1286
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1287
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1288
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1289
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1290
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1291
    assert_eq!(board.matches("<rect ").count(), 3);
1292
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1293
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1294
}
1295
1296
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1297
/// offers only what makes sense and rewrites nothing itself.
1298
#[tokio::test(flavor = "multi_thread")]
1299
async fn a_proposal_board_plans_squashes_and_rebases() {
1300
    let h = hub().await;
1301
    let app = &h.app;
1302
    let andy = call(
1303
        app,
1304
        "POST",
1305
        "/register",
1306
        None,
1307
        None,
1308
        None,
1309
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1310
    )
1311
    .await
1312
    .cookie
1313
    .unwrap();
1314
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1315
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1316
    let url = format!("{}/andy/demo", h.base);
1317
    let work = tempfile::tempdir().unwrap();
1318
    let w = work.path().to_path_buf();
1319
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1320
        let mut c = Repo::init(&w).unwrap();
1321
        c.config.set("remote.origin.url", &url).unwrap();
1322
        c.config.set("remote.origin.token", "site").unwrap();
1323
        c.save_config().unwrap();
1324
        write(&w, "a.txt", b"a\n");
1325
        let base = c.commit("base", &[]).unwrap();
1326
        assert!(c.push("origin", false).unwrap()[0].ok);
1327
        c.bookmark_create("feature", None).unwrap();
1328
        c.bookmark_switch("feature", false).unwrap();
1329
        write(&w, "a.txt", b"a\nfirst\n");
1330
        let first = c.commit("first", &[]).unwrap();
1331
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1332
        let second = c.commit("second", &[]).unwrap();
1333
        write(&w, "b.txt", b"apart\n");
1334
        let apart = c.commit("apart", &[]).unwrap();
1335
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1336
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1337
    })
1338
    .await
1339
    .unwrap();
1340
    // No proposal yet: the board is read-only.
1341
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1342
    assert!(!board.contains("data-plan="));
1343
    let (st, _) = api(
1344
        app,
1345
        "POST",
1346
        "/api/v1/repos/andy/demo/proposals",
1347
        Some("site"),
1348
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1349
    )
1350
    .await;
1351
    assert!(st.is_success(), "{st}");
1352
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1353
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1354
    let csrf = csrf_of(&board);
1355
    let plan = |c: &str, t: &str| {
1356
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1357
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1358
        async move {
1359
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1360
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1361
        }
1362
    };
1363
    let kinds = |v: &serde_json::Value| {
1364
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1365
    };
1366
    // second already depends on first: squash, no rebase.
1367
    let v = plan(&second, &first).await;
1368
    assert_eq!(kinds(&v), ["squash"], "{v}");
1369
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1370
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
1371
    // apart is independent of second: either.
1372
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1373
    // first under second: nothing (second depends on first).
1374
    assert!(plan(&first, &second).await["error"].is_string());
1375
    // What has landed on main is not rearranged.
1376
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1377
}
1378
1379
/// Issues and proposals share a number space, so every number says what it
1380
/// is, and the chain of work shows from both ends (hub spec §8).
1381
#[tokio::test(flavor = "multi_thread")]
1382
async fn proposals_and_issues_show_their_chain() {
1383
    let h = hub().await;
1384
    let app = &h.app;
1385
    let andy = call(
1386
        app,
1387
        "POST",
1388
        "/register",
1389
        None,
1390
        None,
1391
        None,
1392
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1393
    )
1394
    .await
1395
    .cookie
1396
    .unwrap();
1397
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1398
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1399
    let url = format!("{}/andy/demo", h.base);
1400
    let work = tempfile::tempdir().unwrap();
1401
    let w = work.path().to_path_buf();
1402
    tokio::task::spawn_blocking(move || {
1403
        let mut c = Repo::init(&w).unwrap();
1404
        c.config.set("remote.origin.url", &url).unwrap();
1405
        c.config.set("remote.origin.token", "site").unwrap();
1406
        c.save_config().unwrap();
1407
        write(&w, "a.txt", b"a\n");
1408
        c.commit("base", &[]).unwrap();
1409
        assert!(c.push("origin", false).unwrap()[0].ok);
1410
        c.bookmark_create("feature", None).unwrap();
1411
        c.bookmark_switch("feature", false).unwrap();
1412
        write(&w, "a.txt", b"a\nfixed\n");
1413
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1414
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1415
    })
1416
    .await
1417
    .unwrap();
1418
    for title in ["Slow start", "Crash on save"] {
1419
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1420
        assert!(st.is_success());
1421
    }
1422
    let (st, v) = api(
1423
        app,
1424
        "POST",
1425
        "/api/v1/repos/andy/demo/proposals",
1426
        Some("site"),
1427
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1428
    )
1429
    .await;
1430
    assert!(st.is_success(), "{st} {v}");
1431
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1432
1433
    // The proposal names its kind, links its references by kind, and shows
1434
    // the chain: the issues it closes (description and changes) → it → main.
1435
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1436
    assert!(p.contains(">proposal #3</small>"), "header");
1437
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1438
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1439
    let chain = &chain[..chain.find("</p>").unwrap()];
1440
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1441
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1442
    }
1443
    assert!(p.contains("<h3>Closes</h3>"));
1444
1445
    // The issue shows the proposal that closes it, and names its own kind.
1446
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1447
    assert!(i.contains(">issue #1</small>"));
1448
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1449
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1450
    // The conversation is a timeline with avatars; editing sits with the
1451
    // content, not in the sidebar, and labels and projects are editable.
1452
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1453
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1454
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1455
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1456
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1457
    assert!(st.is_success(), "{st}");
1458
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1459
    assert!(
1460
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1461
        "the owner's projects to add to, in a menu"
1462
    );
1463
    let csrf = csrf_of(&p);
1464
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1465
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1466
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1467
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1468
        .await;
1469
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1470
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1471
1472
    // Closed by the proposal's change, not its description: still shown.
1473
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1474
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1475
    assert!(chain.contains("proposal #3"), "{chain}");
1476
}
1477
1478
/// What the hub is: its version and build, and the libraries it is built on,
1479
/// on /about, in the API and in /health (hub spec §15).
1480
#[tokio::test(flavor = "multi_thread")]
1481
async fn the_hub_says_what_version_it_is() {
1482
    let h = hub().await;
1483
    let app = &h.app;
1484
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1485
    assert_eq!(st, StatusCode::OK);
1486
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1487
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1488
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1489
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1490
    assert!(health.contains("\"build\""), "{health}");
1491
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1492
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
1493
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1494
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1495
    assert!(about.contains("href=\"/about\""), "the footer links here");
1496
}
1497
1498
#[tokio::test(flavor = "multi_thread")]
1499
async fn device_sign_in() {
1500
    let h = hub().await;
1501
    let app = &h.app;
1502
    let r = call(
1503
        app,
1504
        "POST",
1505
        "/register",
1506
        None,
1507
        None,
1508
        None,
1509
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1510
    )
1511
    .await;
1512
    let andy = r.cookie.unwrap();
1513
1514
    // An unknown scope is refused.
1515
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1516
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1517
1518
    // The app asks for a code and polls; nobody has approved it yet.
1519
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1520
    assert_eq!(st, StatusCode::OK, "{v}");
1521
    let device = v["device_code"].as_str().unwrap().to_string();
1522
    let user = v["user_code"].as_str().unwrap().to_string();
1523
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1524
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1525
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1526
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1527
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1528
    assert_eq!(v["error"], "slow_down", "polled too soon");
1529
1530
    // The user approves it on the web, allowing less than it asked for.
1531
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1532
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1533
    let csrf = csrf_of(&page.body);
1534
    let r =
1535
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1536
            .await;
1537
    // oxygenhub#83: the answer page says it is done, with no code form.
1538
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1539
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1540
1541
    // The next poll gets a token with what was allowed, once.
1542
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1543
    assert_eq!(st, StatusCode::OK, "{v}");
1544
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1545
    let token = v["access_token"].as_str().unwrap().to_string();
1546
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1547
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1548
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1549
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1550
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1551
    assert!(tokens.body.contains("device: Phone app"));
1552
    // oxygenhub#70: a device's token expires, and each use renews it.
1553
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1554
1555
    // The token can revoke itself (oxy auth logout), and is then refused.
1556
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1557
    assert_eq!(st, StatusCode::NO_CONTENT);
1558
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1559
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1560
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1561
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1562
1563
    // A denied code says so.
1564
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1565
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1566
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1567
    let csrf = csrf_of(&page.body);
1568
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1569
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1570
    assert_eq!(v["error"], "access_denied");
1571
1572
    // Signed out, the page asks for a sign-in first.
1573
    let r = call(app, "GET", "/device", None, None, None, None).await;
1574
    assert!(r.status.is_redirection(), "{}", r.status);
1575
}
1576
1577
#[tokio::test(flavor = "multi_thread")]
1578
async fn api_assistants_at_each_level() {
1579
    let h = hub().await;
1580
    let app = &h.app;
1581
    let andy = call(
1582
        app,
1583
        "POST",
1584
        "/register",
1585
        None,
1586
        None,
1587
        None,
1588
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1589
    )
1590
    .await
1591
    .cookie
1592
    .unwrap();
1593
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1594
    let csrf = csrf_of(&page.body);
1595
    let mint = |scopes: &'static str| {
1596
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1597
        async move {
1598
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1599
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1600
        }
1601
    };
1602
    let admin = mint("scopes=repo%3Aadmin").await;
1603
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1604
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1605
    // A stand-in endpoint with no model list: any model name is taken.
1606
    let router = axum::Router::new().route(
1607
        "/v1/chat/completions",
1608
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1609
    );
1610
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1611
    let port = listener.local_addr().unwrap().port();
1612
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1613
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1614
1615
    // The site's, by its administrator; the repository's, by its admin.
1616
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1617
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1618
    assert_eq!(st, StatusCode::OK, "{v}");
1619
    assert_eq!(v["ok"], "Gemini added");
1620
    let body =
1621
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1622
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1623
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1624
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1625
    assert_eq!(st, StatusCode::OK, "{v}");
1626
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1627
    assert_eq!(st, StatusCode::OK);
1628
    let names: Vec<(&str, &str, bool)> = v
1629
        .as_array()
1630
        .unwrap()
1631
        .iter()
1632
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1633
        .collect();
1634
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1635
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1636
    // Changing it keeps the token when none is given.
1637
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1638
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1639
    assert_eq!(v["ok"], "Claude updated");
1640
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1641
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1642
    // Prompts: the site's is inherited by the repository.
1643
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1644
    assert_eq!(st, StatusCode::OK);
1645
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1646
    assert_eq!(v["prompt"], "Rust.");
1647
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1648
    // Removed.
1649
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1650
    assert_eq!(st, StatusCode::NO_CONTENT);
1651
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1652
    assert_eq!(st, StatusCode::NOT_FOUND);
1653
}