OXYGENHUB
# c40c2d3edb51 oxygenhub / crates / hub / src / web / proposals.rs
43.4 KiB · Rust · last changed Web edits and browser conflict resolution; landing under a policy 1 month ago source blame history raw
de505df5 Andy McCall ↶ 1
//! Proposal pages (hub spec §7): list, new, detail with conversation,
2
//! changes and files, comments anchored to atoms, reviews, landing.
3
4
use super::history::{render_files, FileRows};
5
use super::settings::{csrf, require};
6
use super::{filters, lookup, lookup_role, Error, Page, RepoShell, Shell};
7
use crate::auth::{Access, Role, Viewer};
8
use crate::db::{self, accounts, proposals as pdb};
9
use crate::render::{self, diff};
10
use crate::repos::proposals::{self as pl, Projection, Source};
11
use crate::repos::view::{self, ChangeView, ConflictView};
12
use crate::repos::RepoName;
13
use crate::Shared;
14
use askama::Template;
15
use axum::extract::{Form, Path, Query, State};
16
use axum::response::{IntoResponse, Redirect, Response};
17
use hub_api::{Approval, ProposalSource, ProposalState};
18
use oxy_core::hash::ChangeHash;
19
use serde::Deserialize;
20
use std::collections::{BTreeMap, HashMap};
21
22
// ------------------------------------------------------------------ list
23
24
#[derive(Template)]
25
#[template(path = "proposals.html")]
26
pub struct ProposalsPage {
27
    shell: Shell,
28
    repo: RepoShell,
29
    rows: Vec<pdb::ProposalRow>,
30
    filter: String,
31
    counts: (usize, usize, usize),
32
    bookmarks: Vec<String>,
33
}
34
35
#[derive(Deserialize)]
36
pub struct ListQuery {
37
    state: Option<String>,
38
}
39
40
pub async fn list(
41
    State(app): State<Shared>,
42
    viewer: Viewer,
43
    Path((owner, name)): Path<(String, String)>,
44
    Query(q): Query<ListQuery>,
45
) -> Result<Page<ProposalsPage>, Error> {
46
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposals"), &viewer);
47
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
48
    let all = pdb::list(&app.db, row.id, &[]).await.map_err(|e| Error::from_db(shell.clone(), e))?;
49
    let counts = (
50
        all.iter().filter(|p| p.is_open()).count(),
51
        all.iter().filter(|p| p.state == "landed").count(),
52
        all.iter().filter(|p| p.state == "closed").count(),
53
    );
54
    let filter = q.state.unwrap_or_else(|| "open".into());
55
    let rows = all
56
        .into_iter()
57
        .filter(|p| match filter.as_str() {
58
            "open" => p.is_open(),
59
            "landed" => p.state == "landed",
60
            "closed" => p.state == "closed",
61
            _ => true,
62
        })
63
        .collect();
64
    let bookmarks = app
65
        .repos
66
        .read(&repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>()))
67
        .await
68
        .map_err(|e| Error::from_repo(shell.clone(), e))?;
69
    Ok(Page(ProposalsPage { shell, repo: RepoShell::new(&app, &row, "proposals").with_role(role), rows, filter, counts, bookmarks }))
70
}
71
72
// ------------------------------------------------------------------- new
73
74
#[derive(Template)]
75
#[template(path = "proposal_new.html")]
76
pub struct NewProposalPage {
77
    shell: Shell,
78
    repo: RepoShell,
79
    bookmarks: Vec<String>,
80
    source: String,
81
    target: String,
82
    error: Option<String>,
83
    /// Preview: the changes the proposal would add.
84
    preview: Vec<ChangeView>,
85
    conflicted: bool,
86
}
87
88
#[derive(Deserialize)]
89
pub struct NewQuery {
90
    source: Option<String>,
91
    target: Option<String>,
92
}
93
94
/// `owner/name:bookmark` for a fork, else a bookmark of this repository.
95
fn parse_source(app: &Shared, repo: &RepoName, source: &str) -> Option<(Option<RepoName>, String)> {
96
    if let Some((slug, bookmark)) = source.split_once(':') {
97
        let fork = RepoName::parse(slug)?;
98
        if !app.repos.exists(&fork) || fork == *repo {
99
            return None;
100
        }
101
        return Some((Some(fork), bookmark.to_string()));
102
    }
103
    crate::repos::names::valid_segment(source).then(|| (None, source.to_string()))
104
}
105
106
async fn preview_for(
107
    app: &Shared,
108
    repo: &RepoName,
109
    target: &str,
110
    source: &str,
111
) -> Result<(Vec<ChangeView>, bool), crate::repos::RepoError> {
112
    let Some((fork, bookmark)) = parse_source(app, repo, source) else { return Ok((vec![], false)) };
113
    let target = target.to_string();
114
    let fork_dir = fork.as_ref().map(|f| app.repos.dir(f));
115
    app.repos
116
        .read(repo, move |r, cache| {
117
            let projection = match &fork_dir {
118
                Some(dir) => {
119
                    let fork_repo = oxy_core::repo::Repo::open(dir)?;
120
                    let heads = fork_repo.bookmarks()?.into_iter().find(|b| b.name == bookmark).map(|b| b.heads).unwrap_or_default();
121
                    pl::project(r, cache, &target, Source::Fork { fork: &fork_repo, heads })?
122
                }
123
                None => {
124
                    let heads = r.bookmarks()?.into_iter().find(|b| b.name == bookmark).map(|b| b.heads).unwrap_or_default();
125
                    pl::project(r, cache, &target, Source::Bookmark(heads))?
126
                }
127
            };
128
            Ok((projection.changes, projection.conflicted))
129
        })
130
        .await
131
}
132
133
pub async fn new_form(
134
    State(app): State<Shared>,
135
    viewer: Viewer,
136
    Path((owner, name)): Path<(String, String)>,
137
    Query(q): Query<NewQuery>,
138
) -> Result<Page<NewProposalPage>, Error> {
139
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposals/new"), &viewer);
140
    require(&viewer, &shell)?;
141
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
142
    let bookmarks = app
143
        .repos
144
        .read(&repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>()))
145
        .await
146
        .map_err(|e| Error::from_repo(shell.clone(), e))?;
147
    let target = q.target.unwrap_or_else(|| row.default_bookmark.clone());
148
    let source = q.source.unwrap_or_default();
149
    let (preview, conflicted) =
150
        if source.is_empty() { (vec![], false) } else { preview_for(&app, &repo, &target, &source).await.unwrap_or((vec![], false)) };
151
    Ok(Page(NewProposalPage {
152
        shell,
153
        repo: RepoShell::new(&app, &row, "proposals").with_role(role),
154
        bookmarks,
155
        source,
156
        target,
157
        error: None,
158
        preview,
159
        conflicted,
160
    }))
161
}
162
163
#[derive(Deserialize)]
164
pub struct NewForm {
165
    #[serde(rename = "_csrf")]
166
    csrf_token: String,
167
    title: String,
168
    #[serde(default)]
169
    body: String,
170
    target: String,
171
    source: String,
172
    #[serde(default)]
173
    draft: Option<String>,
174
}
175
b64e2537 Andy McCall ↶ 176
/// Open a proposal from a form or the API: validate, create, index, notify.
177
#[allow(clippy::too_many_arguments)]
178
pub async fn open_proposal(
179
    app: &Shared,
180
    repo: &RepoName,
181
    row: &db::repos::RepoRow,
182
    me: &accounts::Account,
183
    title: &str,
184
    body: &str,
185
    target: &str,
186
    source: &str,
187
    draft: bool,
188
) -> Result<pdb::ProposalRow, String> {
189
    if title.trim().is_empty() {
190
        return Err("Give the proposal a title.".into());
de505df5 Andy McCall ↶ 191
    }
b64e2537 Andy McCall ↶ 192
    let bookmarks =
193
        app.repos.read(repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>())).await.map_err(|e| e.to_string())?;
194
    if !bookmarks.iter().any(|b| b == target) {
195
        return Err("Pick a target bookmark of this repository.".into());
de505df5 Andy McCall ↶ 196
    }
b64e2537 Andy McCall ↶ 197
    let Some((fork, bookmark)) = parse_source(app, repo, source.trim()) else {
198
        return Err("The source is a bookmark of this repository, or owner/name:bookmark of a fork.".into());
de505df5 Andy McCall ↶ 199
    };
b64e2537 Andy McCall ↶ 200
    if fork.is_none() && bookmark == target {
201
        return Err("The source and the target are the same bookmark.".into());
de505df5 Andy McCall ↶ 202
    }
b64e2537 Andy McCall ↶ 203
    let (preview, _) = preview_for(app, repo, target, source.trim()).await.map_err(|e| e.to_string())?;
de505df5 Andy McCall ↶ 204
    if preview.is_empty() {
b64e2537 Andy McCall ↶ 205
        return Err("The source adds nothing to the target.".into());
de505df5 Andy McCall ↶ 206
    }
207
    let source_repo_id = match &fork {
b64e2537 Andy McCall ↶ 208
        Some(fk) => db::repos::get(&app.db, &fk.owner, &fk.name).await.map_err(|e| e.to_string())?.map(|r| r.id),
de505df5 Andy McCall ↶ 209
        None => None,
210
    };
211
    let created = pdb::create(
212
        &app.db,
213
        pdb::NewProposal {
214
            repo_id: row.id,
b64e2537 Andy McCall ↶ 215
            title: title.trim(),
216
            body: body.trim(),
217
            author_id: Some(me.id),
218
            author: &me.username,
219
            draft,
220
            target,
de505df5 Andy McCall ↶ 221
            source_kind: if fork.is_some() { "fork" } else { "bookmark" },
222
            source_repo_id,
223
            source_bookmark: &bookmark,
224
            source_changes: "",
225
        },
226
    )
227
    .await
b64e2537 Andy McCall ↶ 228
    .map_err(|e| e.to_string())?;
229
    pdb::add_event(&app.db, created.id, &me.username, "opened", "").await.ok();
230
    accounts::audit(&app.db, Some(me), "proposal.opened", &format!("{}#{}", row.slug(), created.number), title).await.ok();
18e381ea Andy McCall ↶ 231
    db::notify::index(&app.db, "proposal", row.id, created.id, created.number, &created.title, &created.body).await.ok();
b64e2537 Andy McCall ↶ 232
    let url = format!("/{}/proposal/{}", row.slug(), created.number);
18e381ea Andy McCall ↶ 233
    crate::notify::deliver(
b64e2537 Andy McCall ↶ 234
        app,
18e381ea Andy McCall ↶ 235
        crate::notify::Event {
236
            kind: "proposal.opened",
b64e2537 Andy McCall ↶ 237
            title: format!("{}#{}: {}", row.slug(), created.number, created.title),
238
            url,
239
            actor: me,
18e381ea Andy McCall ↶ 240
            repo_id: row.id,
241
            thread: Some(("proposal", created.id)),
b64e2537 Andy McCall ↶ 242
            mention_text: body,
18e381ea Andy McCall ↶ 243
            direct: vec![],
244
        },
245
    )
246
    .await;
b64e2537 Andy McCall ↶ 247
    crate::hooks::emit(
248
        app,
249
        row,
250
        "proposal.opened",
251
        &me.username,
252
        serde_json::json!({ "number": created.number, "title": created.title, "target": target, "source": source }),
253
    )
254
    .await;
255
    Ok(created)
256
}
257
258
pub async fn create(
259
    State(app): State<Shared>,
260
    viewer: Viewer,
261
    Path((owner, name)): Path<(String, String)>,
262
    Form(f): Form<NewForm>,
263
) -> Result<Response, Error> {
264
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposals/new"), &viewer);
265
    let me = require(&viewer, &shell)?;
266
    csrf(&viewer, &f.csrf_token, &shell)?;
267
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
268
    match open_proposal(&app, &repo, &row, &me.account, &f.title, &f.body, &f.target, &f.source, f.draft.is_some()).await {
269
        Ok(created) => Ok(Redirect::to(&format!("/{owner}/{name}/proposal/{}", created.number)).into_response()),
270
        Err(msg) => {
271
            let bookmarks =
272
                app.repos.read(&repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>())).await.unwrap_or_default();
273
            Ok(Page(NewProposalPage {
274
                shell,
275
                repo: RepoShell::new(&app, &row, "proposals").with_role(role),
276
                bookmarks,
277
                source: f.source.clone(),
278
                target: f.target.clone(),
279
                error: Some(msg),
280
                preview: vec![],
281
                conflicted: false,
282
            })
283
            .into_response())
284
        }
285
    }
de505df5 Andy McCall ↶ 286
}
287
288
// ---------------------------------------------------------------- detail
289
290
/// A comment placed on a diff row, or general.
291
pub struct CommentView {
292
    pub row: pdb::CommentRow,
293
    pub body_html: String,
294
    pub line: Option<usize>,
295
}
296
297
pub struct ReviewView {
298
    pub row: pdb::ReviewRow,
299
    pub body_html: String,
300
    pub sealed: bool,
301
}
302
303
/// Everything the detail page and the API need, computed once under the lock.
304
pub struct Loaded {
305
    pub row: pdb::ProposalRow,
306
    pub changes: Vec<ChangeView>,
307
    pub hashes: Vec<ChangeHash>,
308
    pub heads: Vec<ChangeHash>,
309
    pub state: String,
310
    pub target_state: String,
311
    pub conflicted: bool,
312
    pub conflicts: Vec<ConflictView>,
313
    pub files: Vec<FileRows>,
314
    /// Atom per (path, new line number) of the projected state.
315
    pub atoms: HashMap<(String, usize), (String, u32)>,
316
    pub sealing_keys: Vec<String>,
317
    pub touched: Vec<String>,
318
    pub owners: Vec<String>,
319
    pub landed_already: bool,
320
}
321
322
/// Compute the projection and everything derived from it.
323
pub async fn load(app: &Shared, repo: &RepoName, row: pdb::ProposalRow) -> Result<Loaded, crate::repos::RepoError> {
324
    let fork_dir = match (row.source_kind.as_str(), row.source_repo_id) {
325
        ("fork", Some(id)) => {
326
            db::repos::get_by_id(&app.db, id).await.ok().flatten().and_then(|r| RepoName::new(&r.owner, &r.name)).map(|n| app.repos.dir(&n))
327
        }
328
        _ => None,
329
    };
330
    let r2 = row.clone();
331
    let loaded = app
332
        .repos
333
        .read(repo, move |r, cache| {
334
            let source = match (r2.source_kind.as_str(), &fork_dir) {
335
                ("changes", _) => Source::Changes(r2.source_changes().iter().filter_map(|h| ChangeHash::from_hex(h)).collect()),
336
                ("fork", Some(dir)) => {
337
                    let fork_repo = oxy_core::repo::Repo::open(dir)?;
338
                    let heads =
339
                        fork_repo.bookmarks()?.into_iter().find(|b| b.name == r2.source_bookmark).map(|b| b.heads).unwrap_or_default();
340
                    // Bring the fork's changes over now, so the projection below can read them.
341
                    let fork_state = fork_repo.load_state(&heads)?;
342
                    let missing: Vec<ChangeHash> = fork_state.changes().map(|(h, _)| *h).filter(|h| !r.store().has(h)).collect();
343
                    if !missing.is_empty() {
344
                        r.import_bundle(&fork_repo.bundle_for(&missing)?, r.current_policy()?.is_some())?;
345
                    }
346
                    Source::Changes(heads)
347
                }
348
                _ => {
349
                    let heads = r.bookmarks()?.into_iter().find(|b| b.name == r2.source_bookmark).map(|b| b.heads).unwrap_or_default();
350
                    Source::Bookmark(heads)
351
                }
352
            };
353
            let p: Projection = pl::project(r, cache, &r2.target, source)?;
354
            let target_loaded = cache.load(r, &p.target_heads)?;
355
            let files = render_files(&p.files, &p.bases);
356
            let mut atoms = HashMap::new();
357
            for f in &files {
358
                for l in &f.lines {
359
                    if let Some(n) = l.new_no {
360
                        if let Some((h, i)) = pl::atom_at(&p.loaded, &f.path, n as usize) {
361
                            atoms.insert((f.path.clone(), n as usize), (h.to_hex(), i));
362
                        }
363
                    }
364
                }
365
            }
366
            let touched: Vec<String> = p.files.iter().map(|f| f.path.clone()).collect();
367
            let owners = pl::owners_for(&target_loaded, &touched);
368
            let sealing = pl::sealing_keys(r, &p.hashes)?.into_iter().map(|k| k.to_hex()).collect();
369
            let landed_already = !p.hashes.is_empty() && p.hashes.iter().all(|h| target_loaded.state.contains(h));
370
            Ok(Loaded {
371
                row: r2,
372
                changes: p.changes,
373
                hashes: p.hashes,
374
                heads: p.heads,
375
                state: p.state.to_hex(),
376
                target_state: p.target_state.to_hex(),
377
                conflicted: p.conflicted,
378
                conflicts: p.conflicts,
379
                files,
380
                atoms,
381
                sealing_keys: sealing,
382
                touched,
383
                owners,
384
                landed_already,
385
            })
386
        })
387
        .await?;
388
    // Remember the projection for the list, the API and other proposals' stacking checks.
389
    let heads_csv = loaded.heads.iter().map(|h| h.to_hex()).collect::<Vec<_>>().join(",");
390
    let changes_csv = loaded.hashes.iter().map(|h| h.to_hex()).collect::<Vec<_>>().join(",");
391
    pdb::set_projection(&app.db, loaded.row.id, &loaded.state, &heads_csv, &loaded.target_state, &changes_csv, loaded.conflicted)
392
        .await
393
        .ok();
394
    Ok(loaded)
395
}
396
397
/// Reviews, approvals and blockers.
398
pub struct Verdict {
399
    pub reviews: Vec<ReviewView>,
400
    pub approvals: Vec<Approval>,
401
    pub blockers: Vec<String>,
402
    pub depends_on: Vec<i64>,
403
    pub requirements: pdb::Requirements,
404
}
405
406
pub async fn verdict(app: &Shared, loaded: &Loaded, repo_id: i64) -> Result<Verdict, sqlx::Error> {
407
    let rows = pdb::reviews(&app.db, loaded.row.id).await?;
408
    let links = accounts::identity_accounts(&app.db).await?;
409
    let sealed_accounts: Vec<String> = links.iter().filter(|(k, _)| loaded.sealing_keys.contains(k)).map(|(_, u)| u.clone()).collect();
410
    // Latest verdict per reviewer.
411
    let mut latest: BTreeMap<String, &pdb::ReviewRow> = BTreeMap::new();
412
    for r in &rows {
413
        latest.insert(r.author.clone(), r);
414
    }
415
    let mut approvals = Vec::new();
416
    for (who, r) in &latest {
417
        if r.verdict == "approve" {
418
            let sealed = sealed_accounts.contains(who);
419
            let key = links.iter().find(|(k, u)| u == who && loaded.sealing_keys.contains(k)).map(|(k, _)| k.clone());
420
            approvals.push(Approval { account: who.clone(), sealed, key });
421
        }
422
    }
423
    let reviews = rows
424
        .iter()
425
        .map(|r| ReviewView {
426
            row: r.clone(),
427
            body_html: render::markdown::render(&r.body, "/", "/"),
428
            sealed: r.verdict == "approve" && sealed_accounts.contains(&r.author),
429
        })
430
        .collect();
431
    let requirements = pdb::requirements(&app.db, repo_id).await?;
432
    let mut blockers = Vec::new();
433
    if loaded.row.state == "draft" {
434
        blockers.push("the proposal is a draft".into());
435
    }
436
    if loaded.hashes.is_empty() {
437
        blockers.push("the proposal adds no changes".into());
438
    }
439
    let sealed_count = approvals.iter().filter(|a| a.sealed).count() as i64;
440
    if sealed_count < requirements.required_approvals {
441
        blockers.push(format!("{sealed_count} of {} required sealed approvals", requirements.required_approvals));
442
    }
443
    if requirements.require_owners {
444
        let missing: Vec<&String> = loaded.owners.iter().filter(|o| !approvals.iter().any(|a| a.sealed && &a.account == *o)).collect();
445
        if !missing.is_empty() {
446
            blockers.push(format!("code owners still to approve: {}", missing.iter().map(|s| s.as_str()).collect::<Vec<_>>().join(", ")));
447
        }
448
    }
449
    if loaded.conflicted && !requirements.allow_conflicts {
450
        blockers.push("landing would carry conflicts, which this repository refuses".into());
451
    }
b64e2537 Andy McCall ↶ 452
    let required = db::hooks::required_checks(&app.db, repo_id).await?;
453
    if !required.is_empty() {
454
        let checks = db::hooks::checks_for_state(&app.db, repo_id, &loaded.state).await?;
455
        let missing: Vec<String> =
456
            required.iter().filter(|n| !checks.iter().any(|c| &c.name == *n && c.status == "passed")).cloned().collect();
457
        if !missing.is_empty() {
458
            blockers.push(format!("required checks not passed on the projected state: {}", missing.join(", ")));
459
        }
460
    }
de505df5 Andy McCall ↶ 461
    let requesting: Vec<&String> = latest.iter().filter(|(_, r)| r.verdict == "changes").map(|(who, _)| who).collect();
462
    if !requesting.is_empty() {
463
        blockers.push(format!("changes requested by {}", requesting.iter().map(|s| s.as_str()).collect::<Vec<_>>().join(", ")));
464
    }
465
    // Stacking: another open, earlier proposal whose changes this one includes.
466
    let mut depends_on = Vec::new();
467
    for other in pdb::list(&app.db, repo_id, &["open", "draft"]).await? {
468
        if other.id == loaded.row.id || other.number > loaded.row.number {
469
            continue;
470
        }
471
        let theirs = other.projected_changes();
472
        if !theirs.is_empty() && theirs.iter().all(|h| loaded.hashes.iter().any(|m| m.to_hex() == *h)) {
473
            depends_on.push(other.number);
474
        }
475
    }
476
    if !depends_on.is_empty() {
477
        blockers.push(format!("depends on {}", depends_on.iter().map(|n| format!("#{n}")).collect::<Vec<_>>().join(", ")));
478
    }
479
    Ok(Verdict { reviews, approvals, blockers, depends_on, requirements })
480
}
481
482
#[derive(Template)]
483
#[template(path = "proposal.html")]
484
pub struct ProposalPage {
485
    shell: Shell,
486
    repo: RepoShell,
487
    p: pdb::ProposalRow,
488
    body_html: String,
489
    tab: String,
490
    changes: Vec<ChangeView>,
491
    files: Vec<FileRows>,
492
    conflicts: Vec<ConflictView>,
493
    conflicted: bool,
494
    comments: Vec<CommentView>,
495
    /// Anchored comments by (path, current line).
496
    placed: HashMap<(String, usize), Vec<usize>>,
497
    outdated: Vec<usize>,
498
    reviews: Vec<ReviewView>,
499
    approvals: Vec<Approval>,
500
    blockers: Vec<String>,
501
    depends_on: Vec<i64>,
502
    events: Vec<pdb::EventRow>,
503
    owners: Vec<String>,
504
    requirements: pdb::Requirements,
505
    landed_already: bool,
506
    can_edit: bool,
507
    can_land: bool,
508
    hub_can_land: bool,
509
    notice: Option<String>,
510
    error: Option<String>,
511
    heads: Vec<String>,
512
    state_hash: String,
513
    source_label: String,
514
    api_url: String,
18e381ea Andy McCall ↶ 515
    labels: Vec<db::issues::Label>,
516
    all_labels: Vec<db::issues::Label>,
b64e2537 Andy McCall ↶ 517
    checks: Vec<db::hooks::Check>,
518
    required_checks: Vec<String>,
de505df5 Andy McCall ↶ 519
}
520
521
#[derive(Deserialize)]
522
pub struct DetailQuery {
523
    tab: Option<String>,
524
}
525
526
/// The page assembler every action ends in; its arguments are the route
527
/// plus what to say, and a struct would only rename them.
528
#[allow(clippy::too_many_arguments)]
529
async fn detail(
530
    app: &Shared,
531
    shell: Shell,
532
    viewer: &Viewer,
533
    owner: &str,
534
    name: &str,
535
    number: i64,
536
    tab: String,
537
    notice: Option<String>,
538
    error: Option<String>,
539
) -> Result<Page<ProposalPage>, Error> {
540
    let (repo, row, role) = lookup(app, &shell, viewer, owner, name).await?;
541
    let p = pdb::get(&app.db, row.id, number)
542
        .await
543
        .map_err(|e| Error::from_db(shell.clone(), e))?
544
        .ok_or_else(|| Error::not_found(shell.clone()))?;
545
    let loaded = load(app, &repo, p).await.map_err(|e| Error::from_repo(shell.clone(), e))?;
546
    // A proposal whose changes all reached the target landed by another route.
547
    if loaded.landed_already && loaded.row.is_open() {
548
        pdb::set_state(&app.db, loaded.row.id, "landed", &loaded.target_state).await.ok();
549
        pdb::add_event(&app.db, loaded.row.id, "", "landed", "every change reached the target").await.ok();
550
    }
551
    let p = pdb::get(&app.db, row.id, number).await.map_err(|e| Error::from_db(shell.clone(), e))?.unwrap_or(loaded.row.clone());
552
    let v = verdict(app, &loaded, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
553
    let comment_rows = pdb::comments(&app.db, loaded.row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
554
    let events = pdb::events(&app.db, loaded.row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
555
    // Place anchored comments at their atom's current line.
556
    let mut by_atom: HashMap<(String, String, u32), usize> = HashMap::new();
557
    for ((path, line), (h, i)) in &loaded.atoms {
558
        by_atom.insert((path.clone(), h.clone(), *i), *line);
559
    }
560
    let mut comments = Vec::new();
561
    let mut placed: HashMap<(String, usize), Vec<usize>> = HashMap::new();
562
    let mut outdated = Vec::new();
563
    for (idx, c) in comment_rows.into_iter().enumerate() {
564
        let line = if c.anchor_change.is_empty() {
565
            None
566
        } else {
567
            by_atom.get(&(c.path.clone(), c.anchor_change.clone(), c.anchor_index as u32)).copied()
568
        };
569
        if !c.anchor_change.is_empty() {
570
            match line {
571
                Some(l) => placed.entry((c.path.clone(), l)).or_default().push(idx),
572
                None => outdated.push(idx),
573
            }
574
        }
575
        comments.push(CommentView { body_html: render::markdown::render(&c.body, "/", "/"), row: c, line });
576
    }
577
    let mut changes = loaded.changes.clone();
578
    super::attribute(app, &mut changes.iter_mut().collect::<Vec<_>>()).await;
579
    let me = viewer.account();
580
    let can_edit = me.is_some_and(|a| Some(a.id) == p.author_id || role >= Role::Maintain);
581
    let can_land = role >= Role::Write && p.is_open() && v.blockers.is_empty();
14530604 Andy McCall ↶ 582
    let delegated = match viewer.account() {
583
        Some(a) => super::edit::delegated_identity(app, a.id).await.is_some(),
584
        None => false,
585
    };
586
    let hub_can_land = delegated || app.repos.read(&repo, |r, _| Ok(r.current_policy()?.is_none())).await.unwrap_or(false);
de505df5 Andy McCall ↶ 587
    let source_label = match p.source_kind.as_str() {
588
        "fork" => format!(
589
            "fork {}",
590
            db::repos::get_by_id(&app.db, p.source_repo_id.unwrap_or(0))
591
                .await
592
                .ok()
593
                .flatten()
594
                .map(|r| format!("{}:{}", r.slug(), p.source_bookmark))
595
                .unwrap_or_default()
596
        ),
597
        "changes" => format!("{} changes", p.source_changes().len()),
598
        _ => p.source_bookmark.clone(),
599
    };
600
    Ok(Page(ProposalPage {
601
        shell,
602
        repo: RepoShell::new(app, &row, "proposals").with_role(role),
18e381ea Andy McCall ↶ 603
        body_html: super::issues::markdown(app, row.id, &format!("/{owner}/{name}"), &p.body).await,
de505df5 Andy McCall ↶ 604
        p,
605
        tab,
606
        changes,
607
        files: loaded.files,
608
        conflicts: loaded.conflicts,
609
        conflicted: loaded.conflicted,
610
        comments,
611
        placed,
612
        outdated,
613
        reviews: v.reviews,
614
        approvals: v.approvals,
615
        blockers: v.blockers,
616
        depends_on: v.depends_on,
617
        events,
618
        owners: loaded.owners,
619
        requirements: v.requirements,
620
        landed_already: loaded.landed_already,
621
        can_edit,
622
        can_land,
623
        hub_can_land,
624
        notice,
625
        error,
626
        heads: loaded.heads.iter().map(|h| h.to_hex()).collect(),
b64e2537 Andy McCall ↶ 627
        state_hash: loaded.state.clone(),
de505df5 Andy McCall ↶ 628
        source_label,
629
        api_url: format!("{}/api/v1/repos/{owner}/{name}/proposals/{number}", app.config.base_url()),
18e381ea Andy McCall ↶ 630
        labels: db::issues::proposal_labels(&app.db, loaded.row.id).await.unwrap_or_default(),
631
        all_labels: db::issues::labels(&app.db, row.id).await.unwrap_or_default(),
b64e2537 Andy McCall ↶ 632
        checks: db::hooks::checks_for_state(&app.db, row.id, &loaded.state).await.unwrap_or_default(),
633
        required_checks: db::hooks::required_checks(&app.db, row.id).await.unwrap_or_default(),
de505df5 Andy McCall ↶ 634
    }))
635
}
636
637
pub async fn show(
638
    State(app): State<Shared>,
639
    viewer: Viewer,
640
    Path((owner, name, number)): Path<(String, String, i64)>,
641
    Query(q): Query<DetailQuery>,
642
) -> Result<Page<ProposalPage>, Error> {
643
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
644
    detail(&app, shell, &viewer, &owner, &name, number, q.tab.unwrap_or_else(|| "conversation".into()), None, None).await
645
}
646
647
// ---------------------------------------------------------------- actions
648
649
#[derive(Deserialize)]
650
pub struct CommentForm {
651
    #[serde(rename = "_csrf")]
652
    csrf_token: String,
653
    body: String,
654
    #[serde(default)]
655
    path: String,
656
    #[serde(default)]
657
    line: Option<usize>,
658
}
659
660
pub async fn comment(
661
    State(app): State<Shared>,
662
    viewer: Viewer,
663
    Path((owner, name, number)): Path<(String, String, i64)>,
664
    Form(f): Form<CommentForm>,
665
) -> Result<Page<ProposalPage>, Error> {
666
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
667
    let me = require(&viewer, &shell)?;
668
    csrf(&viewer, &f.csrf_token, &shell)?;
669
    let (repo, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
670
    let p = pdb::get(&app.db, row.id, number)
671
        .await
672
        .map_err(|e| Error::from_db(shell.clone(), e))?
673
        .ok_or_else(|| Error::not_found(shell.clone()))?;
674
    if f.body.trim().is_empty() {
675
        return detail(
676
            &app,
677
            shell,
678
            &viewer,
679
            &owner,
680
            &name,
681
            number,
682
            "conversation".into(),
683
            None,
684
            Some("An empty comment says nothing.".into()),
685
        )
686
        .await;
687
    }
688
    let anchor = match (f.path.trim(), f.line) {
689
        ("", _) | (_, None) => None,
690
        (path, Some(line)) => {
691
            let loaded = load(&app, &repo, p.clone()).await.map_err(|e| Error::from_repo(shell.clone(), e))?;
692
            loaded.atoms.get(&(path.to_string(), line)).cloned()
693
        }
694
    };
695
    let tab = if anchor.is_some() { "files" } else { "conversation" };
696
    pdb::add_comment(
697
        &app.db,
698
        p.id,
699
        Some(me.account.id),
700
        &me.account.username,
701
        f.body.trim(),
702
        f.path.trim(),
703
        anchor.as_ref().map(|(h, i)| (h.as_str(), *i as i64)),
704
    )
705
    .await
706
    .map_err(|e| Error::from_db(shell.clone(), e))?;
707
    detail(&app, shell, &viewer, &owner, &name, number, tab.into(), None, None).await
708
}
709
710
#[derive(Deserialize)]
711
pub struct ReviewForm {
712
    #[serde(rename = "_csrf")]
713
    csrf_token: String,
714
    verdict: String,
715
    #[serde(default)]
716
    body: String,
717
}
718
719
pub async fn review(
720
    State(app): State<Shared>,
721
    viewer: Viewer,
722
    Path((owner, name, number)): Path<(String, String, i64)>,
723
    Form(f): Form<ReviewForm>,
724
) -> Result<Page<ProposalPage>, Error> {
725
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
726
    let me = require(&viewer, &shell)?;
727
    csrf(&viewer, &f.csrf_token, &shell)?;
728
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
729
    let p = pdb::get(&app.db, row.id, number)
730
        .await
731
        .map_err(|e| Error::from_db(shell.clone(), e))?
732
        .ok_or_else(|| Error::not_found(shell.clone()))?;
733
    if !matches!(f.verdict.as_str(), "comment" | "changes" | "approve") {
734
        return Err(Error::bad(shell, "a review is comment, changes or approve"));
735
    }
736
    if f.verdict == "approve" && Some(me.account.id) == p.author_id {
737
        return detail(
738
            &app,
739
            shell,
740
            &viewer,
741
            &owner,
742
            &name,
743
            number,
744
            "conversation".into(),
745
            None,
746
            Some("You cannot approve your own proposal.".into()),
747
        )
748
        .await;
749
    }
750
    pdb::add_review(&app.db, p.id, me.account.id, &me.account.username, &f.verdict, f.body.trim())
751
        .await
752
        .map_err(|e| Error::from_db(shell.clone(), e))?;
753
    pdb::add_event(&app.db, p.id, &me.account.username, &format!("review.{}", f.verdict), "").await.ok();
b64e2537 Andy McCall ↶ 754
    crate::hooks::emit(&app, &row, "review", &me.account.username, serde_json::json!({ "number": number, "verdict": f.verdict })).await;
de505df5 Andy McCall ↶ 755
    let notice = if f.verdict == "approve" {
756
        Some(format!(
757
            "Approval recorded. It counts once you seal the changes: oxy seal --proposal {}/{owner}/{name}/proposal/{number}",
758
            app.config.base_url()
759
        ))
760
    } else {
761
        None
762
    };
763
    detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), notice, None).await
764
}
765
766
#[derive(Deserialize)]
767
pub struct EditForm {
768
    #[serde(rename = "_csrf")]
769
    csrf_token: String,
770
    title: String,
771
    #[serde(default)]
772
    body: String,
773
    target: String,
774
}
775
776
pub async fn edit(
777
    State(app): State<Shared>,
778
    viewer: Viewer,
779
    Path((owner, name, number)): Path<(String, String, i64)>,
780
    Form(f): Form<EditForm>,
781
) -> Result<Page<ProposalPage>, Error> {
782
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
783
    let me = require(&viewer, &shell)?;
784
    csrf(&viewer, &f.csrf_token, &shell)?;
785
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
786
    let p = pdb::get(&app.db, row.id, number)
787
        .await
788
        .map_err(|e| Error::from_db(shell.clone(), e))?
789
        .ok_or_else(|| Error::not_found(shell.clone()))?;
790
    if Some(me.account.id) != p.author_id && role < Role::Maintain {
791
        return Err(Error::not_found(shell));
792
    }
793
    let target = if crate::repos::names::valid_segment(f.target.trim()) { f.target.trim() } else { &p.target };
794
    pdb::edit(&app.db, p.id, f.title.trim(), f.body.trim(), target).await.map_err(|e| Error::from_db(shell.clone(), e))?;
795
    pdb::add_event(&app.db, p.id, &me.account.username, "edited", "").await.ok();
796
    detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), Some("Saved.".into()), None).await
797
}
798
799
#[derive(Deserialize)]
800
pub struct StateForm {
801
    #[serde(rename = "_csrf")]
802
    csrf_token: String,
803
    action: String,
804
}
805
806
pub async fn state(
807
    State(app): State<Shared>,
808
    viewer: Viewer,
809
    Path((owner, name, number)): Path<(String, String, i64)>,
810
    Form(f): Form<StateForm>,
811
) -> Result<Page<ProposalPage>, Error> {
812
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
813
    let me = require(&viewer, &shell)?;
814
    csrf(&viewer, &f.csrf_token, &shell)?;
815
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
816
    let p = pdb::get(&app.db, row.id, number)
817
        .await
818
        .map_err(|e| Error::from_db(shell.clone(), e))?
819
        .ok_or_else(|| Error::not_found(shell.clone()))?;
820
    if Some(me.account.id) != p.author_id && role < Role::Triage {
821
        return Err(Error::not_found(shell));
822
    }
823
    let new_state = match (f.action.as_str(), p.state.as_str()) {
824
        ("close", "open" | "draft") => "closed",
825
        ("reopen", "closed") => "open",
826
        ("ready", "draft") => "open",
827
        ("draft", "open") => "draft",
828
        _ => return Err(Error::bad(shell, "that transition is not possible")),
829
    };
830
    pdb::set_state(&app.db, p.id, new_state, "").await.map_err(|e| Error::from_db(shell.clone(), e))?;
831
    pdb::add_event(&app.db, p.id, &me.account.username, new_state, "").await.ok();
b64e2537 Andy McCall ↶ 832
    crate::hooks::emit(&app, &row, &format!("proposal.{new_state}"), &me.account.username, serde_json::json!({ "number": number })).await;
de505df5 Andy McCall ↶ 833
    detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), None, None).await
834
}
835
836
pub async fn resolve_comment(
837
    State(app): State<Shared>,
838
    viewer: Viewer,
839
    Path((owner, name, number, id)): Path<(String, String, i64, i64)>,
840
    Form(f): Form<super::session::CsrfForm>,
841
) -> Result<Page<ProposalPage>, Error> {
842
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
843
    require(&viewer, &shell)?;
844
    csrf(&viewer, &f.csrf, &shell)?;
845
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
846
    let p = pdb::get(&app.db, row.id, number)
847
        .await
848
        .map_err(|e| Error::from_db(shell.clone(), e))?
849
        .ok_or_else(|| Error::not_found(shell.clone()))?;
850
    let current: Option<bool> = sqlx::query_scalar("SELECT resolved FROM proposal_comments WHERE id = ? AND proposal_id = ?")
851
        .bind(id)
852
        .bind(p.id)
853
        .fetch_optional(&app.db)
854
        .await
855
        .map_err(|e| Error::from_db(shell.clone(), e))?;
856
    if let Some(r) = current {
857
        pdb::set_comment_resolved(&app.db, id, !r).await.map_err(|e| Error::from_db(shell.clone(), e))?;
858
    }
859
    detail(&app, shell, &viewer, &owner, &name, number, "files".into(), None, None).await
860
}
861
862
/// Land from the hub: only when the repository has no trust policy (the
863
/// hub never signs a reference update the policy would have to admit).
864
pub async fn land(
865
    State(app): State<Shared>,
866
    viewer: Viewer,
867
    Path((owner, name, number)): Path<(String, String, i64)>,
868
    Form(f): Form<super::session::CsrfForm>,
869
) -> Result<Page<ProposalPage>, Error> {
870
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
871
    let me = require(&viewer, &shell)?;
872
    csrf(&viewer, &f.csrf, &shell)?;
873
    let (repo, row, _) = lookup_role(&app, &shell, &viewer, &owner, &name, Access::Write).await?;
874
    let p = pdb::get(&app.db, row.id, number)
875
        .await
876
        .map_err(|e| Error::from_db(shell.clone(), e))?
877
        .ok_or_else(|| Error::not_found(shell.clone()))?;
878
    let loaded = load(&app, &repo, p.clone()).await.map_err(|e| Error::from_repo(shell.clone(), e))?;
879
    let v = verdict(&app, &loaded, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
880
    if !p.is_open() || !v.blockers.is_empty() {
881
        return detail(
882
            &app,
883
            shell,
884
            &viewer,
885
            &owner,
886
            &name,
887
            number,
888
            "conversation".into(),
889
            None,
890
            Some(format!("Cannot land: {}", v.blockers.join("; "))),
891
        )
892
        .await;
893
    }
894
    let target = p.target.clone();
895
    let heads = loaded.heads.clone();
14530604 Andy McCall ↶ 896
    // With a delegation the landing is attested by the hub key on the
897
    // user's behalf, which a policy accepts when it lets the user update
898
    // the target (spec §14.5); without one, only a policy-free repository
899
    // can be landed here.
900
    let result = match super::edit::signer_for(&app, me.account.id).await {
901
        Ok(signer) => crate::repos::edits::move_bookmark(&app.repos, &repo, target.clone(), heads.clone(), signer).await.map(|_| pl::state_ref(&heads).to_hex()),
902
        Err(why) => {
903
            app.repos
904
                .write(&repo, move |r, _| {
905
                    if r.current_policy()?.is_some() {
906
                        return Err(crate::repos::RepoError::Oxy(oxy_core::repo::RepoError::Msg(format!(
907
                            "this repository has a trust policy, so the landing must be signed by a key it authorises. Land from a client with oxy proposal land, or delegate to the hub. {why}"
908
                        ))));
909
                    }
910
                    r.bookmark_set(&target, &heads)?;
911
                    Ok(pl::state_ref(&heads).to_hex())
912
                })
913
                .await
914
        }
915
    };
de505df5 Andy McCall ↶ 916
    match result {
917
        Ok(state) => {
918
            pdb::set_state(&app.db, p.id, "landed", &state).await.map_err(|e| Error::from_db(shell.clone(), e))?;
919
            pdb::add_event(&app.db, p.id, &me.account.username, "landed", "from the hub").await.ok();
b64e2537 Andy McCall ↶ 920
            crate::hooks::emit(
921
                &app,
922
                &row,
923
                "proposal.landed",
924
                &me.account.username,
925
                serde_json::json!({ "number": number, "target": p.target, "state": state }),
926
            )
927
            .await;
18e381ea Andy McCall ↶ 928
            crate::notify::deliver(
929
                &app,
930
                crate::notify::Event {
931
                    kind: "proposal.landed",
932
                    title: format!("{owner}/{name}#{number}: {} landed", p.title),
933
                    url: format!("/{owner}/{name}/proposal/{number}"),
934
                    actor: &me.account,
935
                    repo_id: row.id,
936
                    thread: Some(("proposal", p.id)),
937
                    mention_text: "",
938
                    direct: p.author_id.into_iter().collect(),
939
                },
940
            )
941
            .await;
942
            if p.target == row.default_bookmark {
943
                let messages: Vec<(String, String)> =
944
                    loaded.changes.iter().map(|c| (c.hash.clone(), format!("{}\n{}", c.title, c.body))).collect();
945
                super::issues::close_from_messages(&app, &row, &messages).await;
946
            }
de505df5 Andy McCall ↶ 947
            accounts::audit(&app.db, Some(&me.account), "proposal.landed", &format!("{owner}/{name}#{number}"), "").await.ok();
948
            db::repos::record_push(
949
                &app.db,
950
                row.id,
951
                Some((me.account.id, me.account.username.as_str())),
952
                &[db::repos::PushOutcome {
953
                    reference: p.target.clone(),
954
                    ok: true,
955
                    reason: format!("landed #{number}"),
956
                    old_state: loaded.target_state.clone(),
957
                    new_state: state,
958
                    heads: loaded.heads.len() as i64,
959
                    changes: loaded.hashes.len() as i64,
960
                }],
961
            )
962
            .await
963
            .ok();
964
            detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), Some("Landed.".into()), None).await
965
        }
966
        Err(e) => detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), None, Some(e.to_string())).await,
967
    }
968
}
969
18e381ea Andy McCall ↶ 970
#[derive(Deserialize)]
971
pub struct LabelsForm {
972
    #[serde(rename = "_csrf")]
973
    csrf_token: String,
974
    #[serde(default)]
975
    label: Vec<i64>,
976
}
977
978
pub async fn set_labels(
979
    State(app): State<Shared>,
980
    viewer: Viewer,
981
    Path((owner, name, number)): Path<(String, String, i64)>,
982
    axum_extra::extract::Form(f): axum_extra::extract::Form<LabelsForm>,
983
) -> Result<Page<ProposalPage>, Error> {
984
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
985
    require(&viewer, &shell)?;
986
    csrf(&viewer, &f.csrf_token, &shell)?;
987
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
988
    if role < Role::Triage {
989
        return Err(Error::not_found(shell));
990
    }
991
    let p = pdb::get(&app.db, row.id, number)
992
        .await
993
        .map_err(|e| Error::from_db(shell.clone(), e))?
994
        .ok_or_else(|| Error::not_found(shell.clone()))?;
995
    for l in db::issues::labels(&app.db, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))? {
996
        db::issues::set_proposal_label(&app.db, p.id, l.id, f.label.contains(&l.id)).await.map_err(|e| Error::from_db(shell.clone(), e))?;
997
    }
998
    detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), None, None).await
999
}
1000
b64e2537 Andy McCall ↶ 1001
/// `GET /{owner}/{name}/proposal/{number}/events`: server-sent events for
1002
/// checks on the projected state (hub spec §13.1).
1003
pub async fn events(
1004
    State(app): State<Shared>,
1005
    viewer: Viewer,
1006
    Path((owner, name, number)): Path<(String, String, i64)>,
1007
) -> Result<axum::response::Sse<impl futures::Stream<Item = Result<axum::response::sse::Event, std::convert::Infallible>>>, Error> {
1008
    use futures::StreamExt;
1009
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
1010
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
1011
    let rx = app.events.proposals.subscribe();
1012
    let repo_id = row.id;
1013
    let stream = tokio_stream::wrappers::BroadcastStream::new(rx).filter_map(move |item| async move {
1014
        match item {
1015
            Ok((id, ev)) if id == repo_id => {
1016
                Some(Ok(axum::response::sse::Event::default().event(ev.kind.clone()).data(serde_json::to_string(&ev).unwrap_or_default())))
1017
            }
1018
            _ => None,
1019
        }
1020
    });
1021
    Ok(axum::response::Sse::new(stream).keep_alive(axum::response::sse::KeepAlive::default()))
1022
}
1023
de505df5 Andy McCall ↶ 1024
// -------------------------------------------------------------------- API
1025
1026
pub async fn to_api(app: &Shared, owner: &str, name: &str, loaded: &Loaded, v: &Verdict, source_url: Option<String>) -> hub_api::Proposal {
1027
    let p = &loaded.row;
1028
    hub_api::Proposal {
1029
        number: p.number,
1030
        title: p.title.clone(),
1031
        body: p.body.clone(),
1032
        author: p.author.clone(),
1033
        state: ProposalState::parse(&p.state).unwrap_or(ProposalState::Open),
1034
        target: p.target.clone(),
1035
        source: match p.source_kind.as_str() {
1036
            "fork" => {
1037
                let (o, n) = source_url
1038
                    .as_deref()
1039
                    .and_then(|u| u.rsplit_once('/'))
1040
                    .and_then(|(b, n)| b.rsplit_once('/').map(|(_, o)| (o.to_string(), n.to_string())))
1041
                    .unwrap_or_default();
1042
                ProposalSource::Fork { owner: o, name: n, bookmark: p.source_bookmark.clone() }
1043
            }
1044
            "changes" => ProposalSource::Changes { hashes: p.source_changes() },
1045
            _ => ProposalSource::Bookmark { bookmark: p.source_bookmark.clone() },
1046
        },
1047
        changes: loaded
1048
            .changes
1049
            .iter()
1050
            .map(|c| hub_api::ChangeSummary {
1051
                hash: c.hash.clone(),
1052
                message: if c.body.is_empty() { c.title.clone() } else { format!("{}\n\n{}", c.title, c.body) },
1053
                author: hub_api::Author {
1054
                    name: c.author.name.clone(),
1055
                    email: c.author.email.clone(),
1056
                    key: c.author.key.clone(),
1057
                    account: c.author.account.clone(),
1058
                },
1059
                when_ms: c.when_ms,
1060
                deps: c.deps.clone(),
1061
                head: c.head,
1062
                signature: match &c.signature {
1063
                    view::SigView::Unsigned => hub_api::Signature::Unsigned,
1064
                    view::SigView::Valid { key, sealed, revoked, .. } => {
1065
                        hub_api::Signature::Valid { key: key.clone(), sealed: *sealed, revoked: *revoked }
1066
                    }
1067
                    view::SigView::Invalid(why) => hub_api::Signature::Invalid { reason: why.clone() },
1068
                },
1069
            })
1070
            .collect(),
1071
        projected_heads: loaded.heads.iter().map(|h| h.to_hex()).collect(),
1072
        projected_state: Some(loaded.state.clone()),
1073
        conflicted: loaded.conflicted,
1074
        approvals: v.approvals.clone(),
1075
        landable: p.is_open() && v.blockers.is_empty(),
1076
        blockers: v.blockers.clone(),
1077
        created_ms: p.created_ms,
1078
        updated_ms: p.updated_ms,
1079
        url: format!("{}/{owner}/{name}/proposal/{}", app.config.base_url(), p.number),
1080
        repository_url: format!("{}/{owner}/{name}", app.config.base_url()),
1081
        source_url,
1082
    }
1083
}
1084
1085
/// The line comment form's placement key, for templates.
1086
pub fn key(path: &str, line: impl filters::Num) -> (String, usize) {
1087
    (path.to_string(), line.as_u64() as usize)
1088
}
1089
1090
#[allow(dead_code)]
1091
fn _unused(_: &diff::Line, _: &ConflictView, _: &Role) {}