OXYGENHUB
# c4c87f481d05 oxygenhub / crates / hub / tests / api.rs
59.7 KiB · Rust · last changed Device sign-in: approve an app's code on the web, the app gets a scoped token (closes #67) 1 month ago source blame history raw
b64e2537 Andy McCall ↶ 1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    let app = oxygenhub::build(config).await.unwrap();
51
    let router = oxygenhub::router(app.clone());
52
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
53
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
54
}
55
56
struct Res {
57
    status: StatusCode,
58
    body: String,
59
    cookie: Option<String>,
60
}
61
62
async fn call(
63
    app: &Shared,
64
    method: &str,
65
    path: &str,
66
    bearer: Option<&str>,
67
    cookie: Option<&str>,
68
    json: Option<&str>,
69
    form: Option<&str>,
70
) -> Res {
71
    let mut req = Request::builder().method(method).uri(path);
72
    if let Some(b) = bearer {
73
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
74
    }
75
    if let Some(c) = cookie {
76
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
77
    }
78
    let body = if let Some(j) = json {
79
        req = req.header(header::CONTENT_TYPE, "application/json");
80
        Body::from(j.to_string())
81
    } else if let Some(f) = form {
82
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
83
        Body::from(f.to_string())
84
    } else {
85
        Body::empty()
86
    };
87
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
88
    let status = res.status();
89
    let cookie = res
90
        .headers()
91
        .get(header::SET_COOKIE)
92
        .and_then(|v| v.to_str().ok())
93
        .and_then(|v| v.split(';').next())
94
        .and_then(|kv| kv.split_once('='))
95
        .map(|(_, v)| v.to_string());
96
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
97
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
98
}
99
100
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
101
    let r = call(app, method, path, bearer, None, json, None).await;
102
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
103
    (r.status, v)
104
}
105
106
fn csrf_of(page: &str) -> String {
107
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
108
    page[i..].split('"').next().unwrap().to_string()
109
}
110
111
/// A webhook receiver that records what it gets and fails the first time.
112
struct Receiver {
113
    url: String,
114
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
115
    fail_first: Arc<Mutex<bool>>,
116
}
117
118
async fn receiver() -> Receiver {
119
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
120
    let fail_first = Arc::new(Mutex::new(true));
121
    let (s2, f2) = (seen.clone(), fail_first.clone());
122
    let router = Router::new().route(
123
        "/hook",
124
        post(move |headers: header::HeaderMap, body: String| {
125
            let (s2, f2) = (s2.clone(), f2.clone());
126
            async move {
127
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
128
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
129
                let mut f = f2.lock().unwrap();
130
                if *f {
131
                    *f = false;
132
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
133
                }
134
                s2.lock().unwrap().push((event, sig, body));
135
                (StatusCode::OK, "ok")
136
            }
137
        }),
138
    );
139
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
140
    let port = listener.local_addr().unwrap().port();
141
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
142
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
143
}
144
145
#[tokio::test(flavor = "multi_thread")]
146
async fn api_webhooks_and_checks() {
147
    let h = hub().await;
148
    let app = &h.app;
149
    // Accounts and tokens through the pages.
150
    let r =
151
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
152
    let andy = r.cookie.unwrap();
153
    let r =
154
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
155
    let bob = r.cookie.unwrap();
156
    let mint = |cookie: String, scopes: &'static str| {
157
        let app = app.clone();
158
        async move {
159
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
160
            let csrf = csrf_of(&page.body);
161
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
162
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
163
        }
164
    };
165
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
166
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
167
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
168
169
    // Create a repository through the API; the read-only token cannot.
170
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
171
    assert_eq!(st, StatusCode::FORBIDDEN);
172
    let (st, v) = api(
173
        app,
174
        "POST",
175
        "/api/v1/repos",
176
        Some(&andy_admin),
177
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
178
    )
179
    .await;
180
    assert_eq!(st, StatusCode::CREATED, "{v}");
181
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
182
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
183
    assert_eq!(st, StatusCode::CONFLICT);
184
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
185
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
186
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
187
    assert_eq!(st, StatusCode::OK);
188
    assert_eq!(v["username"], "andy");
189
190
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
191
    let rx = receiver().await;
192
    let (st, v) = api(
193
        app,
194
        "POST",
195
        "/api/v1/repos/andy/demo/hooks",
196
        Some(&andy_admin),
197
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
198
    )
199
    .await;
200
    assert_eq!(st, StatusCode::CREATED, "{v}");
201
    let work = tempfile::tempdir().unwrap();
202
    let mut client = Repo::init(work.path()).unwrap();
203
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
204
    client.config.set("remote.origin.token", "site").unwrap();
205
    client.save_config().unwrap();
206
    write(work.path(), "a.txt", b"a\n");
207
    client.snapshot("t").unwrap();
208
    let base = client.commit("base", &[]).unwrap();
209
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
210
    // The worker retries with backoff; drive it directly for the retry.
211
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
212
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
213
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
214
    oxygenhub::hooks::deliver_due(app).await;
215
    let seen = rx.seen.lock().unwrap().clone();
216
    assert_eq!(seen.len(), 1, "{seen:?}");
217
    assert_eq!(seen[0].0, "push");
218
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
219
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
220
    assert_eq!(payload["repository"]["name"], "demo");
221
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
222
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
223
    assert_eq!(v.as_array().unwrap().len(), 1);
224
225
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
226
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
227
    assert_eq!(st, StatusCode::OK);
228
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
229
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
230
    assert_eq!(v[0]["name"], "a.txt");
231
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
232
    assert_eq!(r.body, "a\n");
233
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
234
    assert_eq!(v[0]["change"], base.to_hex());
235
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
236
    assert_eq!(v["files"][0]["path"], "a.txt");
237
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
238
    assert!(v["policy"].is_null());
239
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
240
    assert_eq!(v[0]["reference"], "main");
241
242
    // Issues through the API: Bob opens one, comments, and closes it.
243
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
244
    assert_eq!(st, StatusCode::CREATED, "{v}");
245
    assert_eq!(v["number"], 1);
246
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
247
    assert_eq!(st, StatusCode::CREATED);
248
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
249
    assert_eq!(st, StatusCode::OK, "{v}");
250
    assert_eq!(v["state"], "closed");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
252
    assert_eq!(v[0]["comments"], 1);
253
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
254
    assert_eq!(v[0]["number"], 1);
255
256
    // A proposal through the API, then a required check gates its landing.
257
    client.bookmark_create("feat", Some(&[base])).unwrap();
258
    client.bookmark_switch("feat", false).unwrap();
259
    write(work.path(), "b.txt", b"b\n");
3f02e5ea Andy McCall ↶ 260
    write(work.path(), "a.txt", b"a\nA\n");
b64e2537 Andy McCall ↶ 261
    client.snapshot("t").unwrap();
262
    let feat = client.commit("feat", &[]).unwrap();
263
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
264
    let (st, v) =
265
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
266
            .await;
267
    assert_eq!(st, StatusCode::CREATED, "{v}");
268
    assert_eq!(v["number"], 2);
269
    let state = v["projected_state"].as_str().unwrap().to_string();
270
    assert_eq!(v["landable"], true);
3f02e5ea Andy McCall ↶ 271
    // Its files, and each side's bytes, for editors' diff views.
272
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
273
    assert_eq!(st, StatusCode::OK, "{v}");
274
    let files: Vec<(String, String)> =
275
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
276
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
277
    assert_eq!(v[0]["added"], 1);
278
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
279
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
280
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
281
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
282
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
283
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
b64e2537 Andy McCall ↶ 284
    // Require the "build" check.
285
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
286
    let csrf = csrf_of(&settings.body);
287
    assert_eq!(
288
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
289
            .await
290
            .status,
291
        StatusCode::OK
292
    );
293
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
294
    assert_eq!(v["landable"], false);
295
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
296
    // A checker reports on the projected state: first running, then passed; the page streams it.
297
    let (st, v) = api(
298
        app,
299
        "POST",
300
        "/api/v1/repos/andy/demo/checks",
301
        Some(&andy_ro),
302
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
303
    )
304
    .await;
305
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
306
    let mut events = app.events.proposals.subscribe();
307
    let (st, v) = api(
308
        app,
309
        "POST",
310
        "/api/v1/repos/andy/demo/checks",
311
        Some(&bob_rw),
312
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
313
    )
314
    .await;
315
    assert_eq!(st, StatusCode::CREATED, "{v}");
316
    let (_, ev) = events.recv().await.unwrap();
317
    assert_eq!(ev.kind, "check");
318
    assert_eq!(ev.check.unwrap().name, "build");
319
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
320
    assert_eq!(v[0]["status"], "passed");
321
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
322
    assert_eq!(v["landable"], true, "{v}");
323
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
324
    assert!(page.body.contains("42 tests"), "{}", page.body);
325
    // The check and the proposal reached the webhook too.
326
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
327
    oxygenhub::hooks::deliver_due(app).await;
328
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
329
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
330
    let _ = feat;
331
    let _ = rx.fail_first;
42a0ba4b Andy McCall ↶ 332
333
    // The inbox through the API: count, list, mark one read, mark all read.
334
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
335
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
336
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
eb0c44a9 Andy McCall ↶ 337
    oxygenhub::db::notify::add(
338
        &app.db,
339
        oxygenhub::db::notify::New {
340
            account_id: bob_id,
341
            repo_id: None,
342
            reason: oxygenhub::db::notify::Reason::Participating,
343
            kind: "mention",
344
            title: "andy/demo#1: Bug",
345
            url: "/andy/demo/issue/1",
346
            actor: "andy",
347
        },
348
    )
349
    .await
350
    .unwrap();
351
    oxygenhub::db::notify::add(
352
        &app.db,
353
        oxygenhub::db::notify::New {
354
            account_id: bob_id,
355
            repo_id: None,
356
            reason: oxygenhub::db::notify::Reason::Participating,
357
            kind: "review",
358
            title: "andy/demo#2: Feat",
359
            url: "/andy/demo/proposal/2",
360
            actor: "andy",
361
        },
362
    )
363
    .await
364
    .unwrap();
42a0ba4b Andy McCall ↶ 365
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
366
    assert_eq!(st, StatusCode::OK, "{v}");
367
    assert_eq!(v["unread"], 2);
368
    assert_eq!(v["items"][0]["read"], false);
369
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
370
    let first = v["items"][0]["id"].as_i64().unwrap();
371
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
372
    assert_eq!(st, StatusCode::NO_CONTENT);
373
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
374
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
375
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
376
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
377
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
b64e2537 Andy McCall ↶ 378
}
76f262e1 Andy McCall ↶ 379
380
#[tokio::test(flavor = "multi_thread")]
381
async fn api_issue_triage_and_labels() {
382
    let h = hub().await;
383
    let app = &h.app;
384
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
385
        .await
386
        .cookie
387
        .unwrap();
388
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
389
        .await
390
        .cookie
391
        .unwrap();
392
    let mint = |cookie: String, scopes: &'static str| {
393
        let app = app.clone();
394
        async move {
395
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
396
            let csrf = csrf_of(&page.body);
397
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
398
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
399
        }
400
    };
401
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
402
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
403
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
404
    assert_eq!(st, StatusCode::CREATED);
405
406
    // Labels through the API; bad colours and non-triage callers are refused.
407
    let (st, v) = api(
408
        app,
409
        "POST",
410
        "/api/v1/repos/andy/demo/labels",
411
        Some(&andy_t),
412
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
413
    )
414
    .await;
415
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
416
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
417
    assert_eq!(
418
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
419
        StatusCode::BAD_REQUEST
420
    );
421
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
422
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
423
    assert_eq!(labels.as_array().unwrap().len(), 2);
424
425
    // An issue created with its labels and assignee in one call.
426
    let (st, v) = api(
427
        app,
428
        "POST",
429
        "/api/v1/repos/andy/demo/issues",
430
        Some(&andy_t),
431
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
432
    )
433
    .await;
434
    assert_eq!(st, StatusCode::CREATED, "{v}");
435
    assert_eq!(v["labels"][0]["name"], "bug");
436
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
437
    let n = v["number"].as_i64().unwrap();
438
    // Unknown names are refused before anything is created.
439
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
440
    assert_eq!(st, StatusCode::BAD_REQUEST);
441
    assert!(v["detail"].as_str().unwrap().contains("no label"));
442
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
443
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
444
    // Without triage, labels cannot be set, but a plain issue can be opened.
445
    assert_eq!(
446
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
447
        StatusCode::FORBIDDEN
448
    );
449
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
450
    assert_eq!(st, StatusCode::CREATED);
451
    let bob_n = bobs["number"].as_i64().unwrap();
452
453
    // PATCH: the whole label set, assignees and milestone, with events.
454
    let (st, v) =
455
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
456
            .await;
457
    assert_eq!(st, StatusCode::OK, "{v}");
458
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
459
    assert_eq!(v["assignees"], serde_json::json!([]));
460
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
461
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
462
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
463
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
464
    // The author edits their own title; others cannot; nobody but triage sets labels.
465
    let (st, v) =
466
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
467
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
468
    assert_eq!(
469
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
470
        StatusCode::FORBIDDEN
471
    );
472
    assert_eq!(
473
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
474
        StatusCode::FORBIDDEN
475
    );
476
    assert_eq!(
477
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
478
        StatusCode::BAD_REQUEST
479
    );
480
481
    // Deleting a label takes it off the issues.
482
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
483
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
484
    assert_eq!(v["labels"], serde_json::json!([]));
485
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
486
}
9756c67d Andy McCall ↶ 487
488
#[tokio::test(flavor = "multi_thread")]
489
async fn webhook_formats_editing_and_web_issue_events() {
490
    let h = hub().await;
491
    let app = &h.app;
492
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
493
        .await
494
        .cookie
495
        .unwrap();
496
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
497
    let r = call(
498
        app,
499
        "POST",
500
        "/settings/tokens",
501
        None,
502
        Some(&andy),
503
        None,
504
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
505
    )
506
    .await;
507
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
508
    assert_eq!(
509
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
510
        StatusCode::CREATED
511
    );
512
    let rx = receiver().await;
513
    *rx.fail_first.lock().unwrap() = false;
514
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
515
    let csrf = csrf_of(&settings);
516
    let form = |f: String| {
517
        let andy = andy.clone();
518
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
519
    };
520
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
521
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
522
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
523
    assert_eq!(hook.format, "discord");
524
    // Ping arrives as a Discord message.
525
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
526
    let mut got = String::new();
527
    for _ in 0..100 {
528
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
529
            got = body.clone();
530
        }
531
        if !got.is_empty() {
532
            break;
533
        }
534
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
535
    }
536
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
537
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
538
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
539
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
540
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
541
542
    // Editing: a blank URL and secret keep theirs; format, events and active change.
543
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
544
        .await
545
        .contains("Webhook saved"));
546
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
547
    assert_eq!(
548
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
549
        (rx.url.as_str(), "issue", "oxygenhub", true)
550
    );
551
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
552
553
    // An issue opened on the web now reaches the hook, as the signed envelope.
554
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
555
    call(
556
        app,
557
        "POST",
558
        "/andy/demo/issues/new",
559
        None,
560
        Some(&andy),
561
        None,
562
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
563
    )
564
    .await;
565
    let mut envelope = None;
566
    for _ in 0..100 {
567
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
568
        if envelope.is_some() {
569
            break;
570
        }
571
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
572
    }
573
    let (_, sig, body) = envelope.expect("issue.opened delivered");
574
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
575
    assert_eq!(v["data"]["issue"]["title"], "From the web");
576
    assert!(sig.starts_with("blake3-keyed="));
577
    // A disabled hook through the edit form (no active box).
578
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
579
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
580
}
ef20fdc1 Andy McCall ↶ 581
582
#[tokio::test(flavor = "multi_thread")]
583
async fn api_projects() {
584
    let h = hub().await;
585
    let app = &h.app;
586
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
587
        .await
588
        .cookie
589
        .unwrap();
590
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
591
        .await
592
        .cookie
593
        .unwrap();
594
    let mint = |cookie: String, scopes: &'static str| {
595
        let app = app.clone();
596
        async move {
597
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
598
            let csrf = csrf_of(&page.body);
599
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
600
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
601
        }
602
    };
603
    let a = mint(andy, "scopes=repo%3Aadmin").await;
604
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
605
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
606
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
607
608
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
609
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
610
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
611
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
612
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
613
614
    // Cards by reference, into a column by name, and a note into the first column.
615
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
616
    assert_eq!(st, StatusCode::CREATED, "{card}");
617
    assert_eq!(
618
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
619
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
620
    );
621
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
622
    assert_eq!(st, StatusCode::BAD_REQUEST);
623
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
624
    assert_eq!(
625
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
626
        StatusCode::BAD_REQUEST
627
    );
628
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
629
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
630
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
631
632
    // Move and read the board.
633
    let id = card["id"].as_i64().unwrap();
634
    assert_eq!(
635
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
636
        StatusCode::NO_CONTENT
637
    );
638
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
639
    let names: Vec<(&str, usize)> =
640
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
641
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
642
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
643
644
    // Private: hidden from others; closed: read-only; then remove a card.
645
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
646
    assert_eq!(edited["public"], false);
647
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
648
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
649
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
650
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
651
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
652
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
653
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
654
}
961c10be Andy McCall ↶ 655
656
#[tokio::test(flavor = "multi_thread")]
657
async fn api_required_checks() {
658
    let h = hub().await;
659
    let app = &h.app;
660
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
661
        .await
662
        .cookie
663
        .unwrap();
664
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
665
    let csrf = csrf_of(&page.body);
666
    let mint = |scopes: &'static str| {
667
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
668
        async move {
669
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
670
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
671
        }
672
    };
673
    let admin = mint("scopes=repo%3Aadmin").await;
674
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
675
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
676
677
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
678
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
679
    let (st, v) = api(
680
        app,
681
        "PUT",
682
        "/api/v1/repos/andy/demo/checks/required",
683
        Some(&admin),
684
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
685
    )
686
    .await;
687
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
688
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
689
    assert_eq!(
690
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
691
        serde_json::json!(["flow/fmt", "flow/test"])
692
    );
693
    assert_eq!(
694
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
695
        StatusCode::FORBIDDEN,
696
        "repo:admin only"
697
    );
698
    assert_eq!(
699
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
700
        StatusCode::BAD_REQUEST
701
    );
702
    // The settings page shows the same list.
703
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
704
}
9008bf6c Andy McCall ↶ 705
706
/// OxygenFlow per repository: site administrators turn it on or off in
707
/// the repository's settings; hub.toml's `[flow] repos` is the default.
708
#[tokio::test(flavor = "multi_thread")]
709
async fn flow_is_switched_per_repository_by_site_admins() {
710
    let h = hub().await;
711
    let app = &h.app;
712
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
713
        .await
714
        .cookie
715
        .unwrap();
716
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
717
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
718
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
719
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
720
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
721
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
722
723
    let set = |value: &'static str| {
724
        let (app, andy) = (app.clone(), andy.clone());
725
        async move {
726
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
727
            call(
728
                &app,
729
                "POST",
730
                "/andy/demo/settings/flow",
731
                None,
732
                Some(&andy),
733
                None,
734
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
735
            )
736
            .await
737
        }
738
    };
739
    // A repository admin who is not a site admin sees the state but cannot change it.
740
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
741
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
742
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
743
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
744
    let r = set("on").await;
745
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
746
    assert_eq!(row().await.flow, "");
747
748
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
749
    let r = set("on").await;
750
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
751
    assert_eq!(row().await.flow, "on");
752
    assert!(oxygenhub::flow::enabled(app, &row().await));
753
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
754
    set("off").await;
755
    assert!(!oxygenhub::flow::enabled(app, &row().await));
756
    set("default").await;
757
    assert_eq!(row().await.flow, "");
758
    assert!(set("sometimes").await.body.contains("Pick on, off"));
759
}
e271a37b Andy McCall ↶ 760
761
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
762
/// button, never the repository's default bookmark as the hub sets it.
763
#[tokio::test(flavor = "multi_thread")]
764
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
765
    let h = hub().await;
766
    let app = &h.app;
767
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
768
        .await
769
        .cookie
770
        .unwrap();
771
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
772
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
773
    let url = format!("{}/andy/demo", h.base);
774
    let work = tempfile::tempdir().unwrap();
775
    let (w, u) = (work.path().to_path_buf(), url.clone());
776
    let client = tokio::task::spawn_blocking(move || {
777
        let mut c = Repo::init(&w).unwrap();
778
        c.config.set("remote.origin.url", &u).unwrap();
779
        c.config.set("remote.origin.token", "site").unwrap();
780
        c.save_config().unwrap();
781
        write(&w, "a.txt", b"a\n");
782
        c.commit("a", &[]).unwrap();
783
        assert!(c.push("origin", false).unwrap()[0].ok);
784
        for b in ["develop", "feature/x", "stray"] {
785
            c.bookmark_create(b, None).unwrap();
786
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
787
        }
788
        // A pushed deletion.
789
        let r = c.push_delete("origin", "feature/x").unwrap();
790
        assert!(r[0].ok, "{r:?}");
791
        c
792
    })
793
    .await
794
    .unwrap();
795
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
796
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
797
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
798
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
799
    assert!(!anon.body.contains("/bookmarks/delete"));
800
801
    // The hub's default, not the repository's config, is protected: make
802
    // develop the default, then main can go and develop cannot.
803
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
804
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
805
    let client = tokio::task::spawn_blocking(move || {
806
        let r = client.push_delete("origin", "develop").unwrap();
807
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
808
        let r = client.push_delete("origin", "main").unwrap();
809
        assert!(r[0].ok, "{r:?}");
810
        client
811
    })
812
    .await
813
    .unwrap();
814
    drop(client);
815
816
    // On the web: a writer deletes stray; the default is refused.
817
    let form = |b: &'static str| {
818
        let (app, andy) = (app.clone(), andy.clone());
819
        async move {
820
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
821
            call(
822
                &app,
823
                "POST",
824
                "/andy/demo/bookmarks/delete",
825
                None,
826
                Some(&andy),
827
                None,
828
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
829
            )
830
            .await
831
        }
832
    };
833
    let r = form("stray").await;
834
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
835
    assert!(!r.body.contains(">stray<"));
836
    let r = form("develop").await;
837
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
838
    let r = form("nope").await;
839
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
840
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
841
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
842
    // Anonymous visitors cannot.
843
    assert_ne!(
844
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
845
        StatusCode::OK
846
    );
847
}
760a7dd3 Andy McCall ↶ 848
849
/// A change signed by a key no account has linked says so, on its page
850
/// and in the API (feedback 14).
851
#[tokio::test(flavor = "multi_thread")]
852
async fn changes_signed_by_unlinked_keys_say_so() {
853
    let h = hub().await;
854
    let app = &h.app;
855
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
856
        .await
857
        .cookie
858
        .unwrap();
859
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
860
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
861
    let url = format!("{}/andy/demo", h.base);
862
    let work = tempfile::tempdir().unwrap();
863
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
864
    let hash = tokio::task::spawn_blocking(move || {
865
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
866
        c.config.set("remote.origin.url", &u).unwrap();
867
        c.config.set("remote.origin.token", "site").unwrap();
868
        c.save_config().unwrap();
869
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
870
        write(&w.join("r"), "a.txt", b"a\n");
871
        let h = c.commit("signed by Ada", &[]).unwrap();
872
        assert!(c.push("origin", false).unwrap()[0].ok);
873
        h.to_hex()
874
    })
875
    .await
876
    .unwrap();
877
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
878
    assert_eq!(st, StatusCode::OK, "{v}");
879
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
880
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
881
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
882
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
883
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
884
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
885
}
65be9f9c Andy McCall ↶ 886
887
/// Function history (hub spec §6.6): the file page lists a file's
888
/// functions, and a function's page lists exactly the changes to its lines.
889
#[tokio::test(flavor = "multi_thread")]
890
async fn a_function_has_its_own_history() {
891
    let h = hub().await;
892
    let app = &h.app;
893
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
894
        .await
895
        .cookie
896
        .unwrap();
897
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
898
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
899
    let url = format!("{}/andy/demo", h.base);
900
    let work = tempfile::tempdir().unwrap();
901
    let w = work.path().to_path_buf();
902
    tokio::task::spawn_blocking(move || {
903
        let mut c = Repo::init(&w).unwrap();
904
        c.config.set("remote.origin.url", &url).unwrap();
905
        c.config.set("remote.origin.token", "site").unwrap();
906
        c.save_config().unwrap();
907
        let steps = [
908
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
909
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
910
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
911
        ];
912
        for (msg, text) in steps {
913
            write(&w, "src/lib.rs", text.as_bytes());
914
            c.commit(msg, &[]).unwrap();
915
        }
916
        assert!(c.push("origin", false).unwrap()[0].ok);
917
    })
918
    .await
919
    .unwrap();
920
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
921
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
922
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
923
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
924
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
925
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
926
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
927
    assert_ne!(bad.status, StatusCode::OK);
928
}
92574625 Andy McCall ↶ 929
930
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
931
/// dependency edges, linked cards.
932
#[tokio::test(flavor = "multi_thread")]
933
async fn a_bookmark_shows_as_swimlanes() {
934
    let h = hub().await;
935
    let app = &h.app;
936
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
937
        .await
938
        .cookie
939
        .unwrap();
940
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
941
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
942
    let url = format!("{}/andy/demo", h.base);
943
    let work = tempfile::tempdir().unwrap();
944
    let w = work.path().to_path_buf();
945
    tokio::task::spawn_blocking(move || {
946
        let mut c = Repo::init(&w).unwrap();
947
        c.config.set("remote.origin.url", &url).unwrap();
948
        c.config.set("remote.origin.token", "site").unwrap();
949
        c.save_config().unwrap();
950
        // Two files edited independently: two lanes.
951
        write(&w, "a.txt", b"a\n");
952
        c.commit("add a", &[]).unwrap();
953
        write(&w, "b.txt", b"b\n");
954
        c.commit("add b", &[]).unwrap();
955
        write(&w, "a.txt", b"a\na2\n");
956
        c.commit("grow a", &[]).unwrap();
957
        assert!(c.push("origin", false).unwrap()[0].ok);
958
    })
959
    .await
960
    .unwrap();
961
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
962
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
963
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
964
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
965
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
966
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
967
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
968
    assert_eq!(board.matches("<rect ").count(), 3);
969
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
970
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
971
}
2bfe5ef6 Andy McCall ↶ 972
973
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
974
/// offers only what makes sense and rewrites nothing itself.
975
#[tokio::test(flavor = "multi_thread")]
976
async fn a_proposal_board_plans_squashes_and_rebases() {
977
    let h = hub().await;
978
    let app = &h.app;
979
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
980
        .await
981
        .cookie
982
        .unwrap();
983
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
984
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
985
    let url = format!("{}/andy/demo", h.base);
986
    let work = tempfile::tempdir().unwrap();
987
    let w = work.path().to_path_buf();
988
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
989
        let mut c = Repo::init(&w).unwrap();
990
        c.config.set("remote.origin.url", &url).unwrap();
991
        c.config.set("remote.origin.token", "site").unwrap();
992
        c.save_config().unwrap();
993
        write(&w, "a.txt", b"a\n");
994
        let base = c.commit("base", &[]).unwrap();
995
        assert!(c.push("origin", false).unwrap()[0].ok);
996
        c.bookmark_create("feature", None).unwrap();
997
        c.bookmark_switch("feature", false).unwrap();
998
        write(&w, "a.txt", b"a\nfirst\n");
999
        let first = c.commit("first", &[]).unwrap();
1000
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1001
        let second = c.commit("second", &[]).unwrap();
1002
        write(&w, "b.txt", b"apart\n");
1003
        let apart = c.commit("apart", &[]).unwrap();
1004
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1005
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1006
    })
1007
    .await
1008
    .unwrap();
1009
    // No proposal yet: the board is read-only.
1010
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1011
    assert!(!board.contains("data-plan="));
1012
    let (st, _) = api(
1013
        app,
1014
        "POST",
1015
        "/api/v1/repos/andy/demo/proposals",
1016
        Some("site"),
1017
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1018
    )
1019
    .await;
1020
    assert!(st.is_success(), "{st}");
1021
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1022
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1023
    let csrf = csrf_of(&board);
1024
    let plan = |c: &str, t: &str| {
1025
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1026
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1027
        async move {
1028
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1029
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1030
        }
1031
    };
1032
    let kinds = |v: &serde_json::Value| {
1033
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1034
    };
1035
    // second already depends on first: squash, no rebase.
1036
    let v = plan(&second, &first).await;
1037
    assert_eq!(kinds(&v), ["squash"], "{v}");
1038
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1039
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygen.oxygen-vscode/plan?"));
1040
    // apart is independent of second: either.
1041
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1042
    // first under second: nothing (second depends on first).
1043
    assert!(plan(&first, &second).await["error"].is_string());
1044
    // What has landed on main is not rearranged.
1045
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1046
}
38833ed7 Andy McCall ↶ 1047
1048
/// Issues and proposals share a number space, so every number says what it
1049
/// is, and the chain of work shows from both ends (hub spec §8).
1050
#[tokio::test(flavor = "multi_thread")]
1051
async fn proposals_and_issues_show_their_chain() {
1052
    let h = hub().await;
1053
    let app = &h.app;
1054
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1055
        .await
1056
        .cookie
1057
        .unwrap();
1058
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1059
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1060
    let url = format!("{}/andy/demo", h.base);
1061
    let work = tempfile::tempdir().unwrap();
1062
    let w = work.path().to_path_buf();
1063
    tokio::task::spawn_blocking(move || {
1064
        let mut c = Repo::init(&w).unwrap();
1065
        c.config.set("remote.origin.url", &url).unwrap();
1066
        c.config.set("remote.origin.token", "site").unwrap();
1067
        c.save_config().unwrap();
1068
        write(&w, "a.txt", b"a\n");
1069
        c.commit("base", &[]).unwrap();
1070
        assert!(c.push("origin", false).unwrap()[0].ok);
1071
        c.bookmark_create("feature", None).unwrap();
1072
        c.bookmark_switch("feature", false).unwrap();
1073
        write(&w, "a.txt", b"a\nfixed\n");
1074
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1075
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1076
    })
1077
    .await
1078
    .unwrap();
1079
    for title in ["Slow start", "Crash on save"] {
1080
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1081
        assert!(st.is_success());
1082
    }
1083
    let (st, v) = api(
1084
        app,
1085
        "POST",
1086
        "/api/v1/repos/andy/demo/proposals",
1087
        Some("site"),
1088
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1089
    )
1090
    .await;
1091
    assert!(st.is_success(), "{st} {v}");
1092
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1093
1094
    // The proposal names its kind, links its references by kind, and shows
1095
    // the chain: the issues it closes (description and changes) → it → main.
1096
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1097
    assert!(p.contains(">proposal #3</small>"), "header");
1098
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1099
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1100
    let chain = &chain[..chain.find("</p>").unwrap()];
1101
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1102
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1103
    }
1104
    assert!(p.contains("<h3>Closes</h3>"));
1105
1106
    // The issue shows the proposal that closes it, and names its own kind.
1107
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1108
    assert!(i.contains(">issue #1</small>"));
1109
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1110
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1111
    // Closed by the proposal's change, not its description: still shown.
1112
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1113
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1114
    assert!(chain.contains("proposal #3"), "{chain}");
1115
}
e9bfea8e Andy McCall ↶ 1116
1117
/// What the hub is: its version and build, and the libraries it is built on,
1118
/// on /about, in the API and in /health (hub spec §15).
1119
#[tokio::test(flavor = "multi_thread")]
1120
async fn the_hub_says_what_version_it_is() {
1121
    let h = hub().await;
1122
    let app = &h.app;
1123
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1124
    assert_eq!(st, StatusCode::OK);
1125
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1126
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1127
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1128
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1129
    assert!(health.contains("\"build\""), "{health}");
1130
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1131
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1132
    assert!(about.contains("href=\"/about\""), "the footer links here");
1133
}
df71c789 Andy McCall ↶ 1134
1135
#[tokio::test(flavor = "multi_thread")]
1136
async fn device_sign_in() {
1137
    let h = hub().await;
1138
    let app = &h.app;
1139
    let r =
1140
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1141
    let andy = r.cookie.unwrap();
1142
1143
    // An unknown scope is refused.
1144
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1145
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1146
1147
    // The app asks for a code and polls; nobody has approved it yet.
1148
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1149
    assert_eq!(st, StatusCode::OK, "{v}");
1150
    let device = v["device_code"].as_str().unwrap().to_string();
1151
    let user = v["user_code"].as_str().unwrap().to_string();
1152
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1153
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1154
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1155
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1156
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1157
    assert_eq!(v["error"], "slow_down", "polled too soon");
1158
1159
    // The user approves it on the web, allowing less than it asked for.
1160
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1161
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1162
    let csrf = csrf_of(&page.body);
1163
    let r =
1164
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1165
            .await;
1166
    assert!(r.body.contains("Approved"), "{}", r.body);
1167
1168
    // The next poll gets a token with what was allowed, once.
1169
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1170
    assert_eq!(st, StatusCode::OK, "{v}");
1171
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1172
    let token = v["access_token"].as_str().unwrap().to_string();
1173
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1174
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1175
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1176
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1177
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1178
    assert!(tokens.body.contains("device: Phone app"));
1179
1180
    // A denied code says so.
1181
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1182
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1183
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1184
    let csrf = csrf_of(&page.body);
1185
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1186
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1187
    assert_eq!(v["error"], "access_denied");
1188
1189
    // Signed out, the page asks for a sign-in first.
1190
    let r = call(app, "GET", "/device", None, None, None, None).await;
1191
    assert!(r.status.is_redirection(), "{}", r.status);
1192
}