OXYGENHUB
# cc1cd197df1d oxygenhub / crates / hub / tests / api.rs
60.7 KiB · Rust · last changed Review requests: ask someone to review a proposal (closes #68) 1 month ago source blame history raw
b64e2537 Andy McCall ↶ 1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    let app = oxygenhub::build(config).await.unwrap();
51
    let router = oxygenhub::router(app.clone());
52
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
53
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
54
}
55
56
struct Res {
57
    status: StatusCode,
58
    body: String,
59
    cookie: Option<String>,
60
}
61
62
async fn call(
63
    app: &Shared,
64
    method: &str,
65
    path: &str,
66
    bearer: Option<&str>,
67
    cookie: Option<&str>,
68
    json: Option<&str>,
69
    form: Option<&str>,
70
) -> Res {
71
    let mut req = Request::builder().method(method).uri(path);
72
    if let Some(b) = bearer {
73
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
74
    }
75
    if let Some(c) = cookie {
76
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
77
    }
78
    let body = if let Some(j) = json {
79
        req = req.header(header::CONTENT_TYPE, "application/json");
80
        Body::from(j.to_string())
81
    } else if let Some(f) = form {
82
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
83
        Body::from(f.to_string())
84
    } else {
85
        Body::empty()
86
    };
87
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
88
    let status = res.status();
89
    let cookie = res
90
        .headers()
91
        .get(header::SET_COOKIE)
92
        .and_then(|v| v.to_str().ok())
93
        .and_then(|v| v.split(';').next())
94
        .and_then(|kv| kv.split_once('='))
95
        .map(|(_, v)| v.to_string());
96
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
97
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
98
}
99
100
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
101
    let r = call(app, method, path, bearer, None, json, None).await;
102
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
103
    (r.status, v)
104
}
105
106
fn csrf_of(page: &str) -> String {
107
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
108
    page[i..].split('"').next().unwrap().to_string()
109
}
110
111
/// A webhook receiver that records what it gets and fails the first time.
112
struct Receiver {
113
    url: String,
114
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
115
    fail_first: Arc<Mutex<bool>>,
116
}
117
118
async fn receiver() -> Receiver {
119
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
120
    let fail_first = Arc::new(Mutex::new(true));
121
    let (s2, f2) = (seen.clone(), fail_first.clone());
122
    let router = Router::new().route(
123
        "/hook",
124
        post(move |headers: header::HeaderMap, body: String| {
125
            let (s2, f2) = (s2.clone(), f2.clone());
126
            async move {
127
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
128
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
129
                let mut f = f2.lock().unwrap();
130
                if *f {
131
                    *f = false;
132
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
133
                }
134
                s2.lock().unwrap().push((event, sig, body));
135
                (StatusCode::OK, "ok")
136
            }
137
        }),
138
    );
139
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
140
    let port = listener.local_addr().unwrap().port();
141
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
142
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
143
}
144
145
#[tokio::test(flavor = "multi_thread")]
146
async fn api_webhooks_and_checks() {
147
    let h = hub().await;
148
    let app = &h.app;
149
    // Accounts and tokens through the pages.
150
    let r =
151
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
152
    let andy = r.cookie.unwrap();
153
    let r =
154
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
155
    let bob = r.cookie.unwrap();
156
    let mint = |cookie: String, scopes: &'static str| {
157
        let app = app.clone();
158
        async move {
159
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
160
            let csrf = csrf_of(&page.body);
161
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
162
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
163
        }
164
    };
165
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
166
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
167
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
168
169
    // Create a repository through the API; the read-only token cannot.
170
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
171
    assert_eq!(st, StatusCode::FORBIDDEN);
172
    let (st, v) = api(
173
        app,
174
        "POST",
175
        "/api/v1/repos",
176
        Some(&andy_admin),
177
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
178
    )
179
    .await;
180
    assert_eq!(st, StatusCode::CREATED, "{v}");
181
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
182
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
183
    assert_eq!(st, StatusCode::CONFLICT);
184
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
185
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
186
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
187
    assert_eq!(st, StatusCode::OK);
188
    assert_eq!(v["username"], "andy");
189
190
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
191
    let rx = receiver().await;
192
    let (st, v) = api(
193
        app,
194
        "POST",
195
        "/api/v1/repos/andy/demo/hooks",
196
        Some(&andy_admin),
197
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
198
    )
199
    .await;
200
    assert_eq!(st, StatusCode::CREATED, "{v}");
201
    let work = tempfile::tempdir().unwrap();
202
    let mut client = Repo::init(work.path()).unwrap();
203
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
204
    client.config.set("remote.origin.token", "site").unwrap();
205
    client.save_config().unwrap();
206
    write(work.path(), "a.txt", b"a\n");
207
    client.snapshot("t").unwrap();
208
    let base = client.commit("base", &[]).unwrap();
209
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
210
    // The worker retries with backoff; drive it directly for the retry.
211
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
212
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
213
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
214
    oxygenhub::hooks::deliver_due(app).await;
215
    let seen = rx.seen.lock().unwrap().clone();
216
    assert_eq!(seen.len(), 1, "{seen:?}");
217
    assert_eq!(seen[0].0, "push");
218
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
219
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
220
    assert_eq!(payload["repository"]["name"], "demo");
221
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
222
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
223
    assert_eq!(v.as_array().unwrap().len(), 1);
224
225
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
226
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
227
    assert_eq!(st, StatusCode::OK);
228
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
229
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
230
    assert_eq!(v[0]["name"], "a.txt");
231
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
232
    assert_eq!(r.body, "a\n");
233
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
234
    assert_eq!(v[0]["change"], base.to_hex());
235
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
236
    assert_eq!(v["files"][0]["path"], "a.txt");
237
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
238
    assert!(v["policy"].is_null());
239
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
240
    assert_eq!(v[0]["reference"], "main");
241
242
    // Issues through the API: Bob opens one, comments, and closes it.
243
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
244
    assert_eq!(st, StatusCode::CREATED, "{v}");
245
    assert_eq!(v["number"], 1);
246
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
247
    assert_eq!(st, StatusCode::CREATED);
248
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
249
    assert_eq!(st, StatusCode::OK, "{v}");
250
    assert_eq!(v["state"], "closed");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
252
    assert_eq!(v[0]["comments"], 1);
253
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
254
    assert_eq!(v[0]["number"], 1);
255
256
    // A proposal through the API, then a required check gates its landing.
257
    client.bookmark_create("feat", Some(&[base])).unwrap();
258
    client.bookmark_switch("feat", false).unwrap();
259
    write(work.path(), "b.txt", b"b\n");
3f02e5ea Andy McCall ↶ 260
    write(work.path(), "a.txt", b"a\nA\n");
b64e2537 Andy McCall ↶ 261
    client.snapshot("t").unwrap();
262
    let feat = client.commit("feat", &[]).unwrap();
263
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
264
    let (st, v) =
265
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
266
            .await;
267
    assert_eq!(st, StatusCode::CREATED, "{v}");
268
    assert_eq!(v["number"], 2);
269
    let state = v["projected_state"].as_str().unwrap().to_string();
270
    assert_eq!(v["landable"], true);
3f02e5ea Andy McCall ↶ 271
    // Its files, and each side's bytes, for editors' diff views.
272
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
273
    assert_eq!(st, StatusCode::OK, "{v}");
274
    let files: Vec<(String, String)> =
275
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
276
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
277
    assert_eq!(v[0]["added"], 1);
278
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
279
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
280
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
281
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
282
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
283
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
b64e2537 Andy McCall ↶ 284
    // Require the "build" check.
285
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
286
    let csrf = csrf_of(&settings.body);
287
    assert_eq!(
288
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
289
            .await
290
            .status,
291
        StatusCode::OK
292
    );
293
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
294
    assert_eq!(v["landable"], false);
295
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
296
    // A checker reports on the projected state: first running, then passed; the page streams it.
297
    let (st, v) = api(
298
        app,
299
        "POST",
300
        "/api/v1/repos/andy/demo/checks",
301
        Some(&andy_ro),
302
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
303
    )
304
    .await;
305
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
306
    let mut events = app.events.proposals.subscribe();
307
    let (st, v) = api(
308
        app,
309
        "POST",
310
        "/api/v1/repos/andy/demo/checks",
311
        Some(&bob_rw),
312
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
313
    )
314
    .await;
315
    assert_eq!(st, StatusCode::CREATED, "{v}");
316
    let (_, ev) = events.recv().await.unwrap();
317
    assert_eq!(ev.kind, "check");
318
    assert_eq!(ev.check.unwrap().name, "build");
319
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
320
    assert_eq!(v[0]["status"], "passed");
321
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
322
    assert_eq!(v["landable"], true, "{v}");
323
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
324
    assert!(page.body.contains("42 tests"), "{}", page.body);
325
    // The check and the proposal reached the webhook too.
326
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
327
    oxygenhub::hooks::deliver_due(app).await;
328
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
329
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
330
    let _ = feat;
331
    let _ = rx.fail_first;
42a0ba4b Andy McCall ↶ 332
333
    // The inbox through the API: count, list, mark one read, mark all read.
334
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
335
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
336
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
eb0c44a9 Andy McCall ↶ 337
    oxygenhub::db::notify::add(
338
        &app.db,
339
        oxygenhub::db::notify::New {
340
            account_id: bob_id,
341
            repo_id: None,
342
            reason: oxygenhub::db::notify::Reason::Participating,
343
            kind: "mention",
344
            title: "andy/demo#1: Bug",
345
            url: "/andy/demo/issue/1",
346
            actor: "andy",
347
        },
348
    )
349
    .await
350
    .unwrap();
351
    oxygenhub::db::notify::add(
352
        &app.db,
353
        oxygenhub::db::notify::New {
354
            account_id: bob_id,
355
            repo_id: None,
356
            reason: oxygenhub::db::notify::Reason::Participating,
357
            kind: "review",
358
            title: "andy/demo#2: Feat",
359
            url: "/andy/demo/proposal/2",
360
            actor: "andy",
361
        },
362
    )
363
    .await
364
    .unwrap();
42a0ba4b Andy McCall ↶ 365
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
366
    assert_eq!(st, StatusCode::OK, "{v}");
367
    assert_eq!(v["unread"], 2);
368
    assert_eq!(v["items"][0]["read"], false);
369
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
370
    let first = v["items"][0]["id"].as_i64().unwrap();
371
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
372
    assert_eq!(st, StatusCode::NO_CONTENT);
373
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
374
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
375
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
376
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
377
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
0b20f1ec Andy McCall ↶ 378
cc1cd197 Andy McCall ↶ 379
    // Review requests: the author asks andy; andy is told, reviews, and the
380
    // request is answered; the author hears of the review.
381
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
382
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
383
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
384
        .await
385
        .unwrap();
386
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
387
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
388
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
389
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
390
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
391
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
392
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
393
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
394
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
395
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
396
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
397
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
398
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
399
    let (st, _) =
400
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
401
    assert_eq!(st, StatusCode::CREATED);
402
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
403
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
404
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
405
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
406
    // Asking again and withdrawing it.
407
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
408
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
409
    assert_eq!(st, StatusCode::NO_CONTENT);
410
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
411
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
412
0b20f1ec Andy McCall ↶ 413
    // A source bookmark with `/` in its name, as a feature/N-name workflow
414
    // makes them: by name, and as this repository's owner/name:bookmark.
415
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
416
        client.bookmark_create(b, Some(&[base])).unwrap();
417
        client.bookmark_switch(b, false).unwrap();
418
        write(work.path(), file, b"c\n");
419
        client.snapshot("t").unwrap();
420
        client.commit(b, &[]).unwrap();
421
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
422
    }
423
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
424
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
425
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
426
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
427
        let n = v["number"].as_i64().unwrap();
428
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
429
        assert_eq!(page.status, StatusCode::OK);
430
        assert!(page.body.contains("feature/"), "the page names its source");
431
    }
432
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
433
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
434
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
b64e2537 Andy McCall ↶ 435
}
76f262e1 Andy McCall ↶ 436
437
#[tokio::test(flavor = "multi_thread")]
438
async fn api_issue_triage_and_labels() {
439
    let h = hub().await;
440
    let app = &h.app;
441
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
442
        .await
443
        .cookie
444
        .unwrap();
445
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
446
        .await
447
        .cookie
448
        .unwrap();
449
    let mint = |cookie: String, scopes: &'static str| {
450
        let app = app.clone();
451
        async move {
452
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
453
            let csrf = csrf_of(&page.body);
454
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
455
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
456
        }
457
    };
458
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
459
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
460
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
461
    assert_eq!(st, StatusCode::CREATED);
462
463
    // Labels through the API; bad colours and non-triage callers are refused.
464
    let (st, v) = api(
465
        app,
466
        "POST",
467
        "/api/v1/repos/andy/demo/labels",
468
        Some(&andy_t),
469
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
470
    )
471
    .await;
472
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
473
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
474
    assert_eq!(
475
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
476
        StatusCode::BAD_REQUEST
477
    );
478
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
479
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
480
    assert_eq!(labels.as_array().unwrap().len(), 2);
481
482
    // An issue created with its labels and assignee in one call.
483
    let (st, v) = api(
484
        app,
485
        "POST",
486
        "/api/v1/repos/andy/demo/issues",
487
        Some(&andy_t),
488
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
489
    )
490
    .await;
491
    assert_eq!(st, StatusCode::CREATED, "{v}");
492
    assert_eq!(v["labels"][0]["name"], "bug");
493
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
494
    let n = v["number"].as_i64().unwrap();
495
    // Unknown names are refused before anything is created.
496
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
497
    assert_eq!(st, StatusCode::BAD_REQUEST);
498
    assert!(v["detail"].as_str().unwrap().contains("no label"));
499
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
500
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
501
    // Without triage, labels cannot be set, but a plain issue can be opened.
502
    assert_eq!(
503
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
504
        StatusCode::FORBIDDEN
505
    );
506
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
507
    assert_eq!(st, StatusCode::CREATED);
508
    let bob_n = bobs["number"].as_i64().unwrap();
509
510
    // PATCH: the whole label set, assignees and milestone, with events.
511
    let (st, v) =
512
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
513
            .await;
514
    assert_eq!(st, StatusCode::OK, "{v}");
515
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
516
    assert_eq!(v["assignees"], serde_json::json!([]));
517
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
518
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
519
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
520
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
521
    // The author edits their own title; others cannot; nobody but triage sets labels.
522
    let (st, v) =
523
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
524
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
525
    assert_eq!(
526
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
527
        StatusCode::FORBIDDEN
528
    );
529
    assert_eq!(
530
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
531
        StatusCode::FORBIDDEN
532
    );
533
    assert_eq!(
534
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
535
        StatusCode::BAD_REQUEST
536
    );
537
538
    // Deleting a label takes it off the issues.
539
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
540
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
541
    assert_eq!(v["labels"], serde_json::json!([]));
542
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
543
}
9756c67d Andy McCall ↶ 544
545
#[tokio::test(flavor = "multi_thread")]
546
async fn webhook_formats_editing_and_web_issue_events() {
547
    let h = hub().await;
548
    let app = &h.app;
549
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
550
        .await
551
        .cookie
552
        .unwrap();
553
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
554
    let r = call(
555
        app,
556
        "POST",
557
        "/settings/tokens",
558
        None,
559
        Some(&andy),
560
        None,
561
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
562
    )
563
    .await;
564
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
565
    assert_eq!(
566
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
567
        StatusCode::CREATED
568
    );
569
    let rx = receiver().await;
570
    *rx.fail_first.lock().unwrap() = false;
571
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
572
    let csrf = csrf_of(&settings);
573
    let form = |f: String| {
574
        let andy = andy.clone();
575
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
576
    };
577
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
578
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
579
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
580
    assert_eq!(hook.format, "discord");
581
    // Ping arrives as a Discord message.
582
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
583
    let mut got = String::new();
584
    for _ in 0..100 {
585
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
586
            got = body.clone();
587
        }
588
        if !got.is_empty() {
589
            break;
590
        }
591
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
592
    }
593
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
594
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
595
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
596
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
597
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
598
599
    // Editing: a blank URL and secret keep theirs; format, events and active change.
600
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
601
        .await
602
        .contains("Webhook saved"));
603
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
604
    assert_eq!(
605
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
606
        (rx.url.as_str(), "issue", "oxygenhub", true)
607
    );
608
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
609
610
    // An issue opened on the web now reaches the hook, as the signed envelope.
611
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
612
    call(
613
        app,
614
        "POST",
615
        "/andy/demo/issues/new",
616
        None,
617
        Some(&andy),
618
        None,
619
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
620
    )
621
    .await;
622
    let mut envelope = None;
623
    for _ in 0..100 {
624
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
625
        if envelope.is_some() {
626
            break;
627
        }
628
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
629
    }
630
    let (_, sig, body) = envelope.expect("issue.opened delivered");
631
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
632
    assert_eq!(v["data"]["issue"]["title"], "From the web");
633
    assert!(sig.starts_with("blake3-keyed="));
634
    // A disabled hook through the edit form (no active box).
635
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
636
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
637
}
ef20fdc1 Andy McCall ↶ 638
639
#[tokio::test(flavor = "multi_thread")]
640
async fn api_projects() {
641
    let h = hub().await;
642
    let app = &h.app;
643
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
644
        .await
645
        .cookie
646
        .unwrap();
647
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
648
        .await
649
        .cookie
650
        .unwrap();
651
    let mint = |cookie: String, scopes: &'static str| {
652
        let app = app.clone();
653
        async move {
654
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
655
            let csrf = csrf_of(&page.body);
656
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
657
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
658
        }
659
    };
660
    let a = mint(andy, "scopes=repo%3Aadmin").await;
661
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
662
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
663
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
664
665
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
666
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
667
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
668
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
669
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
670
671
    // Cards by reference, into a column by name, and a note into the first column.
672
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
673
    assert_eq!(st, StatusCode::CREATED, "{card}");
674
    assert_eq!(
675
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
676
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
677
    );
678
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
679
    assert_eq!(st, StatusCode::BAD_REQUEST);
680
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
681
    assert_eq!(
682
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
683
        StatusCode::BAD_REQUEST
684
    );
685
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
686
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
687
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
688
689
    // Move and read the board.
690
    let id = card["id"].as_i64().unwrap();
691
    assert_eq!(
692
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
693
        StatusCode::NO_CONTENT
694
    );
695
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
696
    let names: Vec<(&str, usize)> =
697
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
698
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
699
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
700
701
    // Private: hidden from others; closed: read-only; then remove a card.
702
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
703
    assert_eq!(edited["public"], false);
704
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
705
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
706
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
707
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
708
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
709
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
710
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
711
}
961c10be Andy McCall ↶ 712
713
#[tokio::test(flavor = "multi_thread")]
714
async fn api_required_checks() {
715
    let h = hub().await;
716
    let app = &h.app;
717
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
718
        .await
719
        .cookie
720
        .unwrap();
721
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
722
    let csrf = csrf_of(&page.body);
723
    let mint = |scopes: &'static str| {
724
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
725
        async move {
726
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
727
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
728
        }
729
    };
730
    let admin = mint("scopes=repo%3Aadmin").await;
731
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
732
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
733
734
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
735
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
736
    let (st, v) = api(
737
        app,
738
        "PUT",
739
        "/api/v1/repos/andy/demo/checks/required",
740
        Some(&admin),
741
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
742
    )
743
    .await;
744
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
745
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
746
    assert_eq!(
747
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
748
        serde_json::json!(["flow/fmt", "flow/test"])
749
    );
750
    assert_eq!(
751
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
752
        StatusCode::FORBIDDEN,
753
        "repo:admin only"
754
    );
755
    assert_eq!(
756
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
757
        StatusCode::BAD_REQUEST
758
    );
759
    // The settings page shows the same list.
760
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
761
}
9008bf6c Andy McCall ↶ 762
763
/// OxygenFlow per repository: site administrators turn it on or off in
764
/// the repository's settings; hub.toml's `[flow] repos` is the default.
765
#[tokio::test(flavor = "multi_thread")]
766
async fn flow_is_switched_per_repository_by_site_admins() {
767
    let h = hub().await;
768
    let app = &h.app;
769
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
770
        .await
771
        .cookie
772
        .unwrap();
773
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
774
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
775
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
776
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
777
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
778
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
779
780
    let set = |value: &'static str| {
781
        let (app, andy) = (app.clone(), andy.clone());
782
        async move {
783
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
784
            call(
785
                &app,
786
                "POST",
787
                "/andy/demo/settings/flow",
788
                None,
789
                Some(&andy),
790
                None,
791
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
792
            )
793
            .await
794
        }
795
    };
796
    // A repository admin who is not a site admin sees the state but cannot change it.
797
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
798
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
799
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
800
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
801
    let r = set("on").await;
802
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
803
    assert_eq!(row().await.flow, "");
804
805
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
806
    let r = set("on").await;
807
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
808
    assert_eq!(row().await.flow, "on");
809
    assert!(oxygenhub::flow::enabled(app, &row().await));
810
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
811
    set("off").await;
812
    assert!(!oxygenhub::flow::enabled(app, &row().await));
813
    set("default").await;
814
    assert_eq!(row().await.flow, "");
815
    assert!(set("sometimes").await.body.contains("Pick on, off"));
816
}
e271a37b Andy McCall ↶ 817
818
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
819
/// button, never the repository's default bookmark as the hub sets it.
820
#[tokio::test(flavor = "multi_thread")]
821
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
822
    let h = hub().await;
823
    let app = &h.app;
824
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
825
        .await
826
        .cookie
827
        .unwrap();
828
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
829
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
830
    let url = format!("{}/andy/demo", h.base);
831
    let work = tempfile::tempdir().unwrap();
832
    let (w, u) = (work.path().to_path_buf(), url.clone());
833
    let client = tokio::task::spawn_blocking(move || {
834
        let mut c = Repo::init(&w).unwrap();
835
        c.config.set("remote.origin.url", &u).unwrap();
836
        c.config.set("remote.origin.token", "site").unwrap();
837
        c.save_config().unwrap();
838
        write(&w, "a.txt", b"a\n");
839
        c.commit("a", &[]).unwrap();
840
        assert!(c.push("origin", false).unwrap()[0].ok);
841
        for b in ["develop", "feature/x", "stray"] {
842
            c.bookmark_create(b, None).unwrap();
843
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
844
        }
845
        // A pushed deletion.
846
        let r = c.push_delete("origin", "feature/x").unwrap();
847
        assert!(r[0].ok, "{r:?}");
848
        c
849
    })
850
    .await
851
    .unwrap();
852
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
853
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
854
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
855
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
856
    assert!(!anon.body.contains("/bookmarks/delete"));
857
858
    // The hub's default, not the repository's config, is protected: make
859
    // develop the default, then main can go and develop cannot.
860
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
861
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
862
    let client = tokio::task::spawn_blocking(move || {
863
        let r = client.push_delete("origin", "develop").unwrap();
864
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
865
        let r = client.push_delete("origin", "main").unwrap();
866
        assert!(r[0].ok, "{r:?}");
867
        client
868
    })
869
    .await
870
    .unwrap();
871
    drop(client);
872
873
    // On the web: a writer deletes stray; the default is refused.
874
    let form = |b: &'static str| {
875
        let (app, andy) = (app.clone(), andy.clone());
876
        async move {
877
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
878
            call(
879
                &app,
880
                "POST",
881
                "/andy/demo/bookmarks/delete",
882
                None,
883
                Some(&andy),
884
                None,
885
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
886
            )
887
            .await
888
        }
889
    };
890
    let r = form("stray").await;
891
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
892
    assert!(!r.body.contains(">stray<"));
893
    let r = form("develop").await;
894
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
895
    let r = form("nope").await;
896
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
897
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
898
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
899
    // Anonymous visitors cannot.
900
    assert_ne!(
901
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
902
        StatusCode::OK
903
    );
904
}
760a7dd3 Andy McCall ↶ 905
906
/// A change signed by a key no account has linked says so, on its page
907
/// and in the API (feedback 14).
908
#[tokio::test(flavor = "multi_thread")]
909
async fn changes_signed_by_unlinked_keys_say_so() {
910
    let h = hub().await;
911
    let app = &h.app;
912
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
913
        .await
914
        .cookie
915
        .unwrap();
916
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
917
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
918
    let url = format!("{}/andy/demo", h.base);
919
    let work = tempfile::tempdir().unwrap();
920
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
921
    let hash = tokio::task::spawn_blocking(move || {
922
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
923
        c.config.set("remote.origin.url", &u).unwrap();
924
        c.config.set("remote.origin.token", "site").unwrap();
925
        c.save_config().unwrap();
926
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
927
        write(&w.join("r"), "a.txt", b"a\n");
928
        let h = c.commit("signed by Ada", &[]).unwrap();
929
        assert!(c.push("origin", false).unwrap()[0].ok);
930
        h.to_hex()
931
    })
932
    .await
933
    .unwrap();
934
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
935
    assert_eq!(st, StatusCode::OK, "{v}");
936
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
937
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
938
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
939
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
940
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
941
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
942
}
65be9f9c Andy McCall ↶ 943
944
/// Function history (hub spec §6.6): the file page lists a file's
945
/// functions, and a function's page lists exactly the changes to its lines.
946
#[tokio::test(flavor = "multi_thread")]
947
async fn a_function_has_its_own_history() {
948
    let h = hub().await;
949
    let app = &h.app;
950
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
951
        .await
952
        .cookie
953
        .unwrap();
954
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
955
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
956
    let url = format!("{}/andy/demo", h.base);
957
    let work = tempfile::tempdir().unwrap();
958
    let w = work.path().to_path_buf();
959
    tokio::task::spawn_blocking(move || {
960
        let mut c = Repo::init(&w).unwrap();
961
        c.config.set("remote.origin.url", &url).unwrap();
962
        c.config.set("remote.origin.token", "site").unwrap();
963
        c.save_config().unwrap();
964
        let steps = [
965
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
966
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
967
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
968
        ];
969
        for (msg, text) in steps {
970
            write(&w, "src/lib.rs", text.as_bytes());
971
            c.commit(msg, &[]).unwrap();
972
        }
973
        assert!(c.push("origin", false).unwrap()[0].ok);
974
    })
975
    .await
976
    .unwrap();
977
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
978
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
979
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
980
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
981
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
982
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
983
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
984
    assert_ne!(bad.status, StatusCode::OK);
985
}
92574625 Andy McCall ↶ 986
987
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
988
/// dependency edges, linked cards.
989
#[tokio::test(flavor = "multi_thread")]
990
async fn a_bookmark_shows_as_swimlanes() {
991
    let h = hub().await;
992
    let app = &h.app;
993
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
994
        .await
995
        .cookie
996
        .unwrap();
997
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
998
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
999
    let url = format!("{}/andy/demo", h.base);
1000
    let work = tempfile::tempdir().unwrap();
1001
    let w = work.path().to_path_buf();
1002
    tokio::task::spawn_blocking(move || {
1003
        let mut c = Repo::init(&w).unwrap();
1004
        c.config.set("remote.origin.url", &url).unwrap();
1005
        c.config.set("remote.origin.token", "site").unwrap();
1006
        c.save_config().unwrap();
1007
        // Two files edited independently: two lanes.
1008
        write(&w, "a.txt", b"a\n");
1009
        c.commit("add a", &[]).unwrap();
1010
        write(&w, "b.txt", b"b\n");
1011
        c.commit("add b", &[]).unwrap();
1012
        write(&w, "a.txt", b"a\na2\n");
1013
        c.commit("grow a", &[]).unwrap();
1014
        assert!(c.push("origin", false).unwrap()[0].ok);
1015
    })
1016
    .await
1017
    .unwrap();
1018
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1019
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1020
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1021
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1022
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1023
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1024
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1025
    assert_eq!(board.matches("<rect ").count(), 3);
1026
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1027
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1028
}
2bfe5ef6 Andy McCall ↶ 1029
1030
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1031
/// offers only what makes sense and rewrites nothing itself.
1032
#[tokio::test(flavor = "multi_thread")]
1033
async fn a_proposal_board_plans_squashes_and_rebases() {
1034
    let h = hub().await;
1035
    let app = &h.app;
1036
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1037
        .await
1038
        .cookie
1039
        .unwrap();
1040
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1041
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1042
    let url = format!("{}/andy/demo", h.base);
1043
    let work = tempfile::tempdir().unwrap();
1044
    let w = work.path().to_path_buf();
1045
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1046
        let mut c = Repo::init(&w).unwrap();
1047
        c.config.set("remote.origin.url", &url).unwrap();
1048
        c.config.set("remote.origin.token", "site").unwrap();
1049
        c.save_config().unwrap();
1050
        write(&w, "a.txt", b"a\n");
1051
        let base = c.commit("base", &[]).unwrap();
1052
        assert!(c.push("origin", false).unwrap()[0].ok);
1053
        c.bookmark_create("feature", None).unwrap();
1054
        c.bookmark_switch("feature", false).unwrap();
1055
        write(&w, "a.txt", b"a\nfirst\n");
1056
        let first = c.commit("first", &[]).unwrap();
1057
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1058
        let second = c.commit("second", &[]).unwrap();
1059
        write(&w, "b.txt", b"apart\n");
1060
        let apart = c.commit("apart", &[]).unwrap();
1061
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1062
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1063
    })
1064
    .await
1065
    .unwrap();
1066
    // No proposal yet: the board is read-only.
1067
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1068
    assert!(!board.contains("data-plan="));
1069
    let (st, _) = api(
1070
        app,
1071
        "POST",
1072
        "/api/v1/repos/andy/demo/proposals",
1073
        Some("site"),
1074
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1075
    )
1076
    .await;
1077
    assert!(st.is_success(), "{st}");
1078
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1079
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1080
    let csrf = csrf_of(&board);
1081
    let plan = |c: &str, t: &str| {
1082
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1083
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1084
        async move {
1085
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1086
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1087
        }
1088
    };
1089
    let kinds = |v: &serde_json::Value| {
1090
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1091
    };
1092
    // second already depends on first: squash, no rebase.
1093
    let v = plan(&second, &first).await;
1094
    assert_eq!(kinds(&v), ["squash"], "{v}");
1095
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1096
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygen.oxygen-vscode/plan?"));
1097
    // apart is independent of second: either.
1098
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1099
    // first under second: nothing (second depends on first).
1100
    assert!(plan(&first, &second).await["error"].is_string());
1101
    // What has landed on main is not rearranged.
1102
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1103
}
38833ed7 Andy McCall ↶ 1104
1105
/// Issues and proposals share a number space, so every number says what it
1106
/// is, and the chain of work shows from both ends (hub spec §8).
1107
#[tokio::test(flavor = "multi_thread")]
1108
async fn proposals_and_issues_show_their_chain() {
1109
    let h = hub().await;
1110
    let app = &h.app;
1111
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1112
        .await
1113
        .cookie
1114
        .unwrap();
1115
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1116
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1117
    let url = format!("{}/andy/demo", h.base);
1118
    let work = tempfile::tempdir().unwrap();
1119
    let w = work.path().to_path_buf();
1120
    tokio::task::spawn_blocking(move || {
1121
        let mut c = Repo::init(&w).unwrap();
1122
        c.config.set("remote.origin.url", &url).unwrap();
1123
        c.config.set("remote.origin.token", "site").unwrap();
1124
        c.save_config().unwrap();
1125
        write(&w, "a.txt", b"a\n");
1126
        c.commit("base", &[]).unwrap();
1127
        assert!(c.push("origin", false).unwrap()[0].ok);
1128
        c.bookmark_create("feature", None).unwrap();
1129
        c.bookmark_switch("feature", false).unwrap();
1130
        write(&w, "a.txt", b"a\nfixed\n");
1131
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1132
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1133
    })
1134
    .await
1135
    .unwrap();
1136
    for title in ["Slow start", "Crash on save"] {
1137
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1138
        assert!(st.is_success());
1139
    }
1140
    let (st, v) = api(
1141
        app,
1142
        "POST",
1143
        "/api/v1/repos/andy/demo/proposals",
1144
        Some("site"),
1145
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1146
    )
1147
    .await;
1148
    assert!(st.is_success(), "{st} {v}");
1149
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1150
1151
    // The proposal names its kind, links its references by kind, and shows
1152
    // the chain: the issues it closes (description and changes) → it → main.
1153
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1154
    assert!(p.contains(">proposal #3</small>"), "header");
1155
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1156
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1157
    let chain = &chain[..chain.find("</p>").unwrap()];
1158
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1159
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1160
    }
1161
    assert!(p.contains("<h3>Closes</h3>"));
1162
1163
    // The issue shows the proposal that closes it, and names its own kind.
1164
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1165
    assert!(i.contains(">issue #1</small>"));
1166
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1167
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
a1b98695 Andy McCall ↶ 1168
    // The conversation is a timeline with avatars; editing sits with the
1169
    // content, not in the sidebar, and labels and projects are editable.
1170
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1171
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1172
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1173
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1174
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1175
    assert!(st.is_success(), "{st}");
1176
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1177
    assert!(p.contains("<option value=\"1\">Board</option>"), "the owner's projects to add to");
1178
    let csrf = csrf_of(&p);
1179
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1180
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1181
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1182
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1183
        .await;
1184
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1185
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1186
38833ed7 Andy McCall ↶ 1187
    // Closed by the proposal's change, not its description: still shown.
1188
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1189
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1190
    assert!(chain.contains("proposal #3"), "{chain}");
1191
}