OXYGENHUB
# d4792b4a4629 oxygenhub / crates / hub / tests / api.rs
71.9 KiB · Rust · last changed Milestones over the API, and oh milestone 1 month ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::db;
13
use oxygenhub::repos::RepoName;
14
use oxygenhub::Shared;
15
use std::path::Path;
16
use std::sync::{Arc, Mutex};
17
use tower::ServiceExt;
18
19
fn hermetic() {
20
    static ONCE: std::sync::Once = std::sync::Once::new();
21
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
22
    ONCE.call_once(|| {
23
        let d = tempfile::tempdir().unwrap();
24
        std::env::set_var("OXY_HOME", d.path());
25
        DIR.set(d).ok();
26
    });
27
}
28
29
fn write(root: &Path, rel: &str, content: &[u8]) {
30
    let p = root.join(rel);
31
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
32
    std::fs::write(p, content).unwrap();
33
}
34
35
struct Hub {
36
    app: Shared,
37
    base: String,
38
    _dir: tempfile::TempDir,
39
}
40
41
async fn hub() -> Hub {
42
    hermetic();
43
    let dir = tempfile::tempdir().unwrap();
44
    let mut config = Config::load(dir.path()).unwrap();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    let app = oxygenhub::build(config).await.unwrap();
51
    let router = oxygenhub::router(app.clone());
52
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
53
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
54
}
55
56
struct Res {
57
    status: StatusCode,
58
    body: String,
59
    cookie: Option<String>,
60
}
61
62
async fn call(
63
    app: &Shared,
64
    method: &str,
65
    path: &str,
66
    bearer: Option<&str>,
67
    cookie: Option<&str>,
68
    json: Option<&str>,
69
    form: Option<&str>,
70
) -> Res {
71
    let mut req = Request::builder().method(method).uri(path);
72
    if let Some(b) = bearer {
73
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
74
    }
75
    if let Some(c) = cookie {
76
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
77
    }
78
    let body = if let Some(j) = json {
79
        req = req.header(header::CONTENT_TYPE, "application/json");
80
        Body::from(j.to_string())
81
    } else if let Some(f) = form {
82
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
83
        Body::from(f.to_string())
84
    } else {
85
        Body::empty()
86
    };
87
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
88
    let status = res.status();
89
    let cookie = res
90
        .headers()
91
        .get(header::SET_COOKIE)
92
        .and_then(|v| v.to_str().ok())
93
        .and_then(|v| v.split(';').next())
94
        .and_then(|kv| kv.split_once('='))
95
        .map(|(_, v)| v.to_string());
96
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
97
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
98
}
99
100
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
101
    let r = call(app, method, path, bearer, None, json, None).await;
102
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
103
    (r.status, v)
104
}
105
106
fn csrf_of(page: &str) -> String {
107
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
108
    page[i..].split('"').next().unwrap().to_string()
109
}
110
111
/// A webhook receiver that records what it gets and fails the first time.
112
struct Receiver {
113
    url: String,
114
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
115
    fail_first: Arc<Mutex<bool>>,
116
}
117
118
async fn receiver() -> Receiver {
119
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
120
    let fail_first = Arc::new(Mutex::new(true));
121
    let (s2, f2) = (seen.clone(), fail_first.clone());
122
    let router = Router::new().route(
123
        "/hook",
124
        post(move |headers: header::HeaderMap, body: String| {
125
            let (s2, f2) = (s2.clone(), f2.clone());
126
            async move {
127
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
128
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
129
                let mut f = f2.lock().unwrap();
130
                if *f {
131
                    *f = false;
132
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
133
                }
134
                s2.lock().unwrap().push((event, sig, body));
135
                (StatusCode::OK, "ok")
136
            }
137
        }),
138
    );
139
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
140
    let port = listener.local_addr().unwrap().port();
141
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
142
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
143
}
144
145
#[tokio::test(flavor = "multi_thread")]
146
async fn api_webhooks_and_checks() {
147
    let h = hub().await;
148
    let app = &h.app;
149
    // Accounts and tokens through the pages.
150
    let r =
151
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
152
    let andy = r.cookie.unwrap();
153
    let r =
154
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
155
    let bob = r.cookie.unwrap();
156
    let mint = |cookie: String, scopes: &'static str| {
157
        let app = app.clone();
158
        async move {
159
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
160
            let csrf = csrf_of(&page.body);
161
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
162
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
163
        }
164
    };
165
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
166
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
167
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
168
169
    // Create a repository through the API; the read-only token cannot.
170
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
171
    assert_eq!(st, StatusCode::FORBIDDEN);
172
    let (st, v) = api(
173
        app,
174
        "POST",
175
        "/api/v1/repos",
176
        Some(&andy_admin),
177
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
178
    )
179
    .await;
180
    assert_eq!(st, StatusCode::CREATED, "{v}");
181
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
182
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
183
    assert_eq!(st, StatusCode::CONFLICT);
184
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
185
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
186
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
187
    assert_eq!(st, StatusCode::OK);
188
    assert_eq!(v["username"], "andy");
189
190
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
191
    let rx = receiver().await;
192
    let (st, v) = api(
193
        app,
194
        "POST",
195
        "/api/v1/repos/andy/demo/hooks",
196
        Some(&andy_admin),
197
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
198
    )
199
    .await;
200
    assert_eq!(st, StatusCode::CREATED, "{v}");
201
    let work = tempfile::tempdir().unwrap();
202
    let mut client = Repo::init(work.path()).unwrap();
203
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
204
    client.config.set("remote.origin.token", "site").unwrap();
205
    client.save_config().unwrap();
206
    write(work.path(), "a.txt", b"a\n");
207
    client.snapshot("t").unwrap();
208
    let base = client.commit("base", &[]).unwrap();
209
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
210
    // The worker retries with backoff; drive it directly for the retry.
211
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
212
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
213
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
214
    oxygenhub::hooks::deliver_due(app).await;
215
    let seen = rx.seen.lock().unwrap().clone();
216
    assert_eq!(seen.len(), 1, "{seen:?}");
217
    assert_eq!(seen[0].0, "push");
218
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
219
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
220
    assert_eq!(payload["repository"]["name"], "demo");
221
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
222
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
223
    assert_eq!(v.as_array().unwrap().len(), 1);
224
225
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
226
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
227
    assert_eq!(st, StatusCode::OK);
228
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
229
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
230
    assert_eq!(v[0]["name"], "a.txt");
231
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
232
    assert_eq!(r.body, "a\n");
233
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
234
    assert_eq!(v[0]["change"], base.to_hex());
235
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
236
    assert_eq!(v["files"][0]["path"], "a.txt");
237
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
238
    assert!(v["policy"].is_null());
239
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
240
    assert_eq!(v[0]["reference"], "main");
241
242
    // Issues through the API: Bob opens one, comments, and closes it.
243
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
244
    assert_eq!(st, StatusCode::CREATED, "{v}");
245
    assert_eq!(v["number"], 1);
246
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
247
    assert_eq!(st, StatusCode::CREATED);
248
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
249
    assert_eq!(st, StatusCode::OK, "{v}");
250
    assert_eq!(v["state"], "closed");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
252
    assert_eq!(v[0]["comments"], 1);
253
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
254
    assert_eq!(v[0]["number"], 1);
255
256
    // A proposal through the API, then a required check gates its landing.
257
    client.bookmark_create("feat", Some(&[base])).unwrap();
258
    client.bookmark_switch("feat", false).unwrap();
259
    write(work.path(), "b.txt", b"b\n");
260
    write(work.path(), "a.txt", b"a\nA\n");
261
    client.snapshot("t").unwrap();
262
    let feat = client.commit("feat", &[]).unwrap();
263
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
264
    let (st, v) =
265
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
266
            .await;
267
    assert_eq!(st, StatusCode::CREATED, "{v}");
268
    assert_eq!(v["number"], 2);
269
    let state = v["projected_state"].as_str().unwrap().to_string();
270
    assert_eq!(v["landable"], true);
271
    // Its files, and each side's bytes, for editors' diff views.
272
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
273
    assert_eq!(st, StatusCode::OK, "{v}");
274
    let files: Vec<(String, String)> =
275
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
276
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
277
    assert_eq!(v[0]["added"], 1);
278
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
279
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
280
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
281
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
282
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
283
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
284
    // Require the "build" check.
285
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
286
    let csrf = csrf_of(&settings.body);
287
    assert_eq!(
288
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
289
            .await
290
            .status,
291
        StatusCode::OK
292
    );
293
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
294
    assert_eq!(v["landable"], false);
295
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
296
    // A checker reports on the projected state: first running, then passed; the page streams it.
297
    let (st, v) = api(
298
        app,
299
        "POST",
300
        "/api/v1/repos/andy/demo/checks",
301
        Some(&andy_ro),
302
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
303
    )
304
    .await;
305
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
306
    let mut events = app.events.proposals.subscribe();
307
    let (st, v) = api(
308
        app,
309
        "POST",
310
        "/api/v1/repos/andy/demo/checks",
311
        Some(&bob_rw),
312
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
313
    )
314
    .await;
315
    assert_eq!(st, StatusCode::CREATED, "{v}");
316
    let (_, ev) = events.recv().await.unwrap();
317
    assert_eq!(ev.kind, "check");
318
    assert_eq!(ev.check.unwrap().name, "build");
319
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
320
    assert_eq!(v[0]["status"], "passed");
321
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
322
    assert_eq!(v["landable"], true, "{v}");
323
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
324
    assert!(page.body.contains("42 tests"), "{}", page.body);
325
    // The check and the proposal reached the webhook too.
326
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
327
    oxygenhub::hooks::deliver_due(app).await;
328
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
329
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
330
    let _ = feat;
331
    let _ = rx.fail_first;
332
333
    // The inbox through the API: count, list, mark one read, mark all read.
334
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
335
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
336
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
337
    oxygenhub::db::notify::add(
338
        &app.db,
339
        oxygenhub::db::notify::New {
340
            account_id: bob_id,
341
            repo_id: None,
342
            reason: oxygenhub::db::notify::Reason::Participating,
343
            kind: "mention",
344
            title: "andy/demo#1: Bug",
345
            url: "/andy/demo/issue/1",
346
            actor: "andy",
347
        },
348
    )
349
    .await
350
    .unwrap();
351
    oxygenhub::db::notify::add(
352
        &app.db,
353
        oxygenhub::db::notify::New {
354
            account_id: bob_id,
355
            repo_id: None,
356
            reason: oxygenhub::db::notify::Reason::Participating,
357
            kind: "review",
358
            title: "andy/demo#2: Feat",
359
            url: "/andy/demo/proposal/2",
360
            actor: "andy",
361
        },
362
    )
363
    .await
364
    .unwrap();
365
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
366
    assert_eq!(st, StatusCode::OK, "{v}");
367
    assert_eq!(v["unread"], 2);
368
    assert_eq!(v["items"][0]["read"], false);
369
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
370
    let first = v["items"][0]["id"].as_i64().unwrap();
371
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
372
    assert_eq!(st, StatusCode::NO_CONTENT);
373
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
374
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
375
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
376
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
377
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
378
379
    // Review requests: the author asks andy; andy is told, reviews, and the
380
    // request is answered; the author hears of the review.
381
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
382
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
383
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
384
        .await
385
        .unwrap();
386
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
387
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
388
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
389
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
390
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
391
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
392
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
393
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
394
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
395
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
396
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
397
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
398
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
399
    let (st, _) =
400
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
401
    assert_eq!(st, StatusCode::CREATED);
402
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
403
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
404
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
405
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
406
    // Asking again and withdrawing it.
407
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
408
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
409
    assert_eq!(st, StatusCode::NO_CONTENT);
410
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
411
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
412
    // oxygenhub#84: the page's menu sets who is asked, all at once.
413
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
414
    assert!(
415
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
416
        "the reviewers menu lists andy"
417
    );
418
    let csrf = csrf_of(&page.body);
419
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
420
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
421
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
422
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
423
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
424
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
425
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
426
427
    // A source bookmark with `/` in its name, as a feature/N-name workflow
428
    // makes them: by name, and as this repository's owner/name:bookmark.
429
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
430
        client.bookmark_create(b, Some(&[base])).unwrap();
431
        client.bookmark_switch(b, false).unwrap();
432
        write(work.path(), file, b"c\n");
433
        client.snapshot("t").unwrap();
434
        client.commit(b, &[]).unwrap();
435
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
436
    }
437
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
438
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
439
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
440
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
441
        let n = v["number"].as_i64().unwrap();
442
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
443
        assert_eq!(page.status, StatusCode::OK);
444
        assert!(page.body.contains("feature/"), "the page names its source");
445
    }
446
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
447
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
448
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
449
450
    // oxygenhub#76: a proposal's title and description are edited through
451
    // the API by its author or a maintainer; what is not given stays.
452
    let edit = |token: &str, number: i64, body: &str| {
453
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
454
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
455
    };
456
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
457
    assert_eq!(st, StatusCode::OK, "{v}");
458
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
459
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
460
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
461
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
462
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
463
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
464
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
465
    let (st, v) = api(
466
        app,
467
        "POST",
468
        "/api/v1/repos/andy/demo/proposals",
469
        Some(&andy_pw),
470
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
471
    )
472
    .await;
473
    assert_eq!(st, StatusCode::CREATED, "{v}");
474
    let n = v["number"].as_i64().unwrap();
475
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
476
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
477
478
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
479
    // before anything changes, shown in its JSON.
480
    for l in ["ui", "flow"] {
481
        let body = format!(r#"{{"name":"{l}"}}"#);
482
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
483
    }
484
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
485
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
486
    assert_eq!(st, StatusCode::OK, "{v}");
487
    let names = |v: &serde_json::Value| -> Vec<String> {
488
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
489
    };
490
    assert_eq!(names(&v), ["flow", "ui"]);
491
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
492
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
493
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
494
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
495
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
496
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
497
    assert_eq!(names(&v), ["flow"]);
498
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
499
}
500
501
#[tokio::test(flavor = "multi_thread")]
502
async fn api_issue_triage_and_labels() {
503
    let h = hub().await;
504
    let app = &h.app;
505
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
506
        .await
507
        .cookie
508
        .unwrap();
509
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
510
        .await
511
        .cookie
512
        .unwrap();
513
    let mint = |cookie: String, scopes: &'static str| {
514
        let app = app.clone();
515
        async move {
516
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
517
            let csrf = csrf_of(&page.body);
518
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
519
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
520
        }
521
    };
522
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
523
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
524
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
525
    assert_eq!(st, StatusCode::CREATED);
526
527
    // Labels through the API; bad colours and non-triage callers are refused.
528
    let (st, v) = api(
529
        app,
530
        "POST",
531
        "/api/v1/repos/andy/demo/labels",
532
        Some(&andy_t),
533
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
534
    )
535
    .await;
536
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
537
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
538
    assert_eq!(
539
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
540
        StatusCode::BAD_REQUEST
541
    );
542
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
543
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
544
    assert_eq!(labels.as_array().unwrap().len(), 2);
545
    // oxygenhub#91: milestones over the API, for triage.
546
    let (st, m) = api(
547
        app,
548
        "POST",
549
        "/api/v1/repos/andy/demo/milestones",
550
        Some(&andy_t),
551
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
552
    )
553
    .await;
554
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
555
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
556
    assert_eq!(
557
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
558
        StatusCode::BAD_REQUEST
559
    );
560
    assert_eq!(
561
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
562
        StatusCode::FORBIDDEN
563
    );
564
    let (st, m) =
565
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
566
            .await;
567
    assert_eq!(
568
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
569
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
570
        "{m}"
571
    );
572
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
573
    assert_eq!(
574
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
575
        StatusCode::NOT_FOUND,
576
        "renamed"
577
    );
578
    assert_eq!(
579
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
580
        StatusCode::BAD_REQUEST
581
    );
582
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
583
    assert_eq!(list.as_array().unwrap().len(), 1);
584
585
    // An issue created with its labels and assignee in one call.
586
    let (st, v) = api(
587
        app,
588
        "POST",
589
        "/api/v1/repos/andy/demo/issues",
590
        Some(&andy_t),
591
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
592
    )
593
    .await;
594
    assert_eq!(st, StatusCode::CREATED, "{v}");
595
    assert_eq!(v["labels"][0]["name"], "bug");
596
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
597
    let n = v["number"].as_i64().unwrap();
598
    // Unknown names are refused before anything is created.
599
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
600
    assert_eq!(st, StatusCode::BAD_REQUEST);
601
    assert!(v["detail"].as_str().unwrap().contains("no label"));
602
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
603
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
604
    // Without triage, labels cannot be set, but a plain issue can be opened.
605
    assert_eq!(
606
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
607
        StatusCode::FORBIDDEN
608
    );
609
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
610
    assert_eq!(st, StatusCode::CREATED);
611
    let bob_n = bobs["number"].as_i64().unwrap();
612
613
    // PATCH: the whole label set, assignees and milestone, with events.
614
    let (st, v) =
615
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
616
            .await;
617
    assert_eq!(st, StatusCode::OK, "{v}");
618
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
619
    assert_eq!(v["assignees"], serde_json::json!([]));
620
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
621
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
622
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
623
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
624
    // The author edits their own title; others cannot; nobody but triage sets labels.
625
    let (st, v) =
626
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
627
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
628
    assert_eq!(
629
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
630
        StatusCode::FORBIDDEN
631
    );
632
    assert_eq!(
633
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
634
        StatusCode::FORBIDDEN
635
    );
636
    assert_eq!(
637
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
638
        StatusCode::BAD_REQUEST
639
    );
640
641
    // Deleting a label takes it off the issues.
642
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
643
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
644
    assert_eq!(v["labels"], serde_json::json!([]));
645
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
646
}
647
648
#[tokio::test(flavor = "multi_thread")]
649
async fn webhook_formats_editing_and_web_issue_events() {
650
    let h = hub().await;
651
    let app = &h.app;
652
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
653
        .await
654
        .cookie
655
        .unwrap();
656
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
657
    let r = call(
658
        app,
659
        "POST",
660
        "/settings/tokens",
661
        None,
662
        Some(&andy),
663
        None,
664
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
665
    )
666
    .await;
667
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
668
    assert_eq!(
669
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
670
        StatusCode::CREATED
671
    );
672
    let rx = receiver().await;
673
    *rx.fail_first.lock().unwrap() = false;
674
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
675
    let csrf = csrf_of(&settings);
676
    let form = |f: String| {
677
        let andy = andy.clone();
678
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
679
    };
680
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
681
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
682
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
683
    assert_eq!(hook.format, "discord");
684
    // Ping arrives as a Discord message.
685
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
686
    let mut got = String::new();
687
    for _ in 0..100 {
688
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
689
            got = body.clone();
690
        }
691
        if !got.is_empty() {
692
            break;
693
        }
694
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
695
    }
696
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
697
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
698
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
699
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
700
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
701
702
    // Editing: a blank URL and secret keep theirs; format, events and active change.
703
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
704
        .await
705
        .contains("Webhook saved"));
706
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
707
    assert_eq!(
708
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
709
        (rx.url.as_str(), "issue", "oxygenhub", true)
710
    );
711
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
712
713
    // An issue opened on the web now reaches the hook, as the signed envelope.
714
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
715
    call(
716
        app,
717
        "POST",
718
        "/andy/demo/issues/new",
719
        None,
720
        Some(&andy),
721
        None,
722
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
723
    )
724
    .await;
725
    let mut envelope = None;
726
    for _ in 0..100 {
727
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
728
        if envelope.is_some() {
729
            break;
730
        }
731
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
732
    }
733
    let (_, sig, body) = envelope.expect("issue.opened delivered");
734
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
735
    assert_eq!(v["data"]["issue"]["title"], "From the web");
736
    assert!(sig.starts_with("blake3-keyed="));
737
    // A disabled hook through the edit form (no active box).
738
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
739
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
740
}
741
742
#[tokio::test(flavor = "multi_thread")]
743
async fn api_projects() {
744
    let h = hub().await;
745
    let app = &h.app;
746
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
747
        .await
748
        .cookie
749
        .unwrap();
750
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
751
        .await
752
        .cookie
753
        .unwrap();
754
    let mint = |cookie: String, scopes: &'static str| {
755
        let app = app.clone();
756
        async move {
757
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
758
            let csrf = csrf_of(&page.body);
759
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
760
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
761
        }
762
    };
763
    let a = mint(andy, "scopes=repo%3Aadmin").await;
764
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
765
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
766
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
767
768
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
769
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
770
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
771
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
772
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
773
774
    // Cards by reference, into a column by name, and a note into the first column.
775
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
776
    assert_eq!(st, StatusCode::CREATED, "{card}");
777
    assert_eq!(
778
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
779
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
780
    );
781
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
782
    assert_eq!(st, StatusCode::BAD_REQUEST);
783
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
784
    assert_eq!(
785
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
786
        StatusCode::BAD_REQUEST
787
    );
788
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
789
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
790
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
791
792
    // Move and read the board.
793
    let id = card["id"].as_i64().unwrap();
794
    assert_eq!(
795
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
796
        StatusCode::NO_CONTENT
797
    );
798
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
799
    let names: Vec<(&str, usize)> =
800
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
801
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
802
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
803
804
    // Private: hidden from others; closed: read-only; then remove a card.
805
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
806
    assert_eq!(edited["public"], false);
807
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
808
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
809
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
810
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
811
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
812
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
813
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
814
}
815
816
#[tokio::test(flavor = "multi_thread")]
817
async fn api_required_checks() {
818
    let h = hub().await;
819
    let app = &h.app;
820
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
821
        .await
822
        .cookie
823
        .unwrap();
824
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
825
    let csrf = csrf_of(&page.body);
826
    let mint = |scopes: &'static str| {
827
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
828
        async move {
829
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
830
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
831
        }
832
    };
833
    let admin = mint("scopes=repo%3Aadmin").await;
834
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
835
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
836
837
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
838
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
839
    let (st, v) = api(
840
        app,
841
        "PUT",
842
        "/api/v1/repos/andy/demo/checks/required",
843
        Some(&admin),
844
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
845
    )
846
    .await;
847
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
848
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
849
    assert_eq!(
850
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
851
        serde_json::json!(["flow/fmt", "flow/test"])
852
    );
853
    assert_eq!(
854
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
855
        StatusCode::FORBIDDEN,
856
        "repo:admin only"
857
    );
858
    assert_eq!(
859
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
860
        StatusCode::BAD_REQUEST
861
    );
862
    // The settings page shows the same list.
863
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
864
}
865
866
/// OxygenFlow per repository: site administrators turn it on or off in
867
/// the repository's settings; hub.toml's `[flow] repos` is the default.
868
#[tokio::test(flavor = "multi_thread")]
869
async fn flow_is_switched_per_repository_by_site_admins() {
870
    let h = hub().await;
871
    let app = &h.app;
872
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
873
        .await
874
        .cookie
875
        .unwrap();
876
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
877
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
878
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
879
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
880
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
881
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
882
883
    let set = |value: &'static str| {
884
        let (app, andy) = (app.clone(), andy.clone());
885
        async move {
886
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
887
            call(
888
                &app,
889
                "POST",
890
                "/andy/demo/settings/flow",
891
                None,
892
                Some(&andy),
893
                None,
894
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
895
            )
896
            .await
897
        }
898
    };
899
    // A repository admin who is not a site admin sees the state but cannot change it.
900
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
901
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
902
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
903
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
904
    let r = set("on").await;
905
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
906
    assert_eq!(row().await.flow, "");
907
908
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
909
    let r = set("on").await;
910
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
911
    assert_eq!(row().await.flow, "on");
912
    assert!(oxygenhub::flow::enabled(app, &row().await));
913
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
914
    set("off").await;
915
    assert!(!oxygenhub::flow::enabled(app, &row().await));
916
    set("default").await;
917
    assert_eq!(row().await.flow, "");
918
    assert!(set("sometimes").await.body.contains("Pick on, off"));
919
}
920
921
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
922
/// button, never the repository's default bookmark as the hub sets it.
923
#[tokio::test(flavor = "multi_thread")]
924
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
925
    let h = hub().await;
926
    let app = &h.app;
927
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
928
        .await
929
        .cookie
930
        .unwrap();
931
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
932
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
933
    let url = format!("{}/andy/demo", h.base);
934
    let work = tempfile::tempdir().unwrap();
935
    let (w, u) = (work.path().to_path_buf(), url.clone());
936
    let client = tokio::task::spawn_blocking(move || {
937
        let mut c = Repo::init(&w).unwrap();
938
        c.config.set("remote.origin.url", &u).unwrap();
939
        c.config.set("remote.origin.token", "site").unwrap();
940
        c.save_config().unwrap();
941
        write(&w, "a.txt", b"a\n");
942
        c.commit("a", &[]).unwrap();
943
        assert!(c.push("origin", false).unwrap()[0].ok);
944
        for b in ["develop", "feature/x", "stray"] {
945
            c.bookmark_create(b, None).unwrap();
946
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
947
        }
948
        // A pushed deletion.
949
        let r = c.push_delete("origin", "feature/x").unwrap();
950
        assert!(r[0].ok, "{r:?}");
951
        c
952
    })
953
    .await
954
    .unwrap();
955
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
956
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
957
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
958
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
959
    assert!(!anon.body.contains("/bookmarks/delete"));
960
961
    // The hub's default, not the repository's config, is protected: make
962
    // develop the default, then main can go and develop cannot.
963
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
964
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
965
    let client = tokio::task::spawn_blocking(move || {
966
        let r = client.push_delete("origin", "develop").unwrap();
967
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
968
        let r = client.push_delete("origin", "main").unwrap();
969
        assert!(r[0].ok, "{r:?}");
970
        client
971
    })
972
    .await
973
    .unwrap();
974
    drop(client);
975
976
    // On the web: a writer deletes stray; the default is refused.
977
    let form = |b: &'static str| {
978
        let (app, andy) = (app.clone(), andy.clone());
979
        async move {
980
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
981
            call(
982
                &app,
983
                "POST",
984
                "/andy/demo/bookmarks/delete",
985
                None,
986
                Some(&andy),
987
                None,
988
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
989
            )
990
            .await
991
        }
992
    };
993
    let r = form("stray").await;
994
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
995
    assert!(!r.body.contains(">stray<"));
996
    let r = form("develop").await;
997
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
998
    let r = form("nope").await;
999
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1000
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1001
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1002
    // Anonymous visitors cannot.
1003
    assert_ne!(
1004
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1005
        StatusCode::OK
1006
    );
1007
}
1008
1009
/// A change signed by a key no account has linked says so, on its page
1010
/// and in the API (feedback 14).
1011
#[tokio::test(flavor = "multi_thread")]
1012
async fn changes_signed_by_unlinked_keys_say_so() {
1013
    let h = hub().await;
1014
    let app = &h.app;
1015
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1016
        .await
1017
        .cookie
1018
        .unwrap();
1019
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1020
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1021
    let url = format!("{}/andy/demo", h.base);
1022
    let work = tempfile::tempdir().unwrap();
1023
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1024
    let hash = tokio::task::spawn_blocking(move || {
1025
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1026
        c.config.set("remote.origin.url", &u).unwrap();
1027
        c.config.set("remote.origin.token", "site").unwrap();
1028
        c.save_config().unwrap();
1029
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1030
        write(&w.join("r"), "a.txt", b"a\n");
1031
        let h = c.commit("signed by Ada", &[]).unwrap();
1032
        assert!(c.push("origin", false).unwrap()[0].ok);
1033
        h.to_hex()
1034
    })
1035
    .await
1036
    .unwrap();
1037
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1038
    assert_eq!(st, StatusCode::OK, "{v}");
1039
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1040
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1041
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1042
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1043
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1044
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1045
}
1046
1047
/// Function history (hub spec §6.6): the file page lists a file's
1048
/// functions, and a function's page lists exactly the changes to its lines.
1049
#[tokio::test(flavor = "multi_thread")]
1050
async fn a_function_has_its_own_history() {
1051
    let h = hub().await;
1052
    let app = &h.app;
1053
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1054
        .await
1055
        .cookie
1056
        .unwrap();
1057
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1058
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1059
    let url = format!("{}/andy/demo", h.base);
1060
    let work = tempfile::tempdir().unwrap();
1061
    let w = work.path().to_path_buf();
1062
    tokio::task::spawn_blocking(move || {
1063
        let mut c = Repo::init(&w).unwrap();
1064
        c.config.set("remote.origin.url", &url).unwrap();
1065
        c.config.set("remote.origin.token", "site").unwrap();
1066
        c.save_config().unwrap();
1067
        let steps = [
1068
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1069
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1070
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1071
        ];
1072
        for (msg, text) in steps {
1073
            write(&w, "src/lib.rs", text.as_bytes());
1074
            c.commit(msg, &[]).unwrap();
1075
        }
1076
        assert!(c.push("origin", false).unwrap()[0].ok);
1077
    })
1078
    .await
1079
    .unwrap();
1080
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1081
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1082
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1083
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1084
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1085
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1086
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1087
    assert_ne!(bad.status, StatusCode::OK);
1088
}
1089
1090
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1091
/// dependency edges, linked cards.
1092
#[tokio::test(flavor = "multi_thread")]
1093
async fn a_bookmark_shows_as_swimlanes() {
1094
    let h = hub().await;
1095
    let app = &h.app;
1096
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1097
        .await
1098
        .cookie
1099
        .unwrap();
1100
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1101
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1102
    let url = format!("{}/andy/demo", h.base);
1103
    let work = tempfile::tempdir().unwrap();
1104
    let w = work.path().to_path_buf();
1105
    tokio::task::spawn_blocking(move || {
1106
        let mut c = Repo::init(&w).unwrap();
1107
        c.config.set("remote.origin.url", &url).unwrap();
1108
        c.config.set("remote.origin.token", "site").unwrap();
1109
        c.save_config().unwrap();
1110
        // Two files edited independently: two lanes.
1111
        write(&w, "a.txt", b"a\n");
1112
        c.commit("add a", &[]).unwrap();
1113
        write(&w, "b.txt", b"b\n");
1114
        c.commit("add b", &[]).unwrap();
1115
        write(&w, "a.txt", b"a\na2\n");
1116
        c.commit("grow a", &[]).unwrap();
1117
        assert!(c.push("origin", false).unwrap()[0].ok);
1118
    })
1119
    .await
1120
    .unwrap();
1121
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1122
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1123
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1124
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1125
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1126
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1127
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1128
    assert_eq!(board.matches("<rect ").count(), 3);
1129
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1130
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1131
}
1132
1133
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1134
/// offers only what makes sense and rewrites nothing itself.
1135
#[tokio::test(flavor = "multi_thread")]
1136
async fn a_proposal_board_plans_squashes_and_rebases() {
1137
    let h = hub().await;
1138
    let app = &h.app;
1139
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1140
        .await
1141
        .cookie
1142
        .unwrap();
1143
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1144
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1145
    let url = format!("{}/andy/demo", h.base);
1146
    let work = tempfile::tempdir().unwrap();
1147
    let w = work.path().to_path_buf();
1148
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1149
        let mut c = Repo::init(&w).unwrap();
1150
        c.config.set("remote.origin.url", &url).unwrap();
1151
        c.config.set("remote.origin.token", "site").unwrap();
1152
        c.save_config().unwrap();
1153
        write(&w, "a.txt", b"a\n");
1154
        let base = c.commit("base", &[]).unwrap();
1155
        assert!(c.push("origin", false).unwrap()[0].ok);
1156
        c.bookmark_create("feature", None).unwrap();
1157
        c.bookmark_switch("feature", false).unwrap();
1158
        write(&w, "a.txt", b"a\nfirst\n");
1159
        let first = c.commit("first", &[]).unwrap();
1160
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1161
        let second = c.commit("second", &[]).unwrap();
1162
        write(&w, "b.txt", b"apart\n");
1163
        let apart = c.commit("apart", &[]).unwrap();
1164
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1165
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1166
    })
1167
    .await
1168
    .unwrap();
1169
    // No proposal yet: the board is read-only.
1170
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1171
    assert!(!board.contains("data-plan="));
1172
    let (st, _) = api(
1173
        app,
1174
        "POST",
1175
        "/api/v1/repos/andy/demo/proposals",
1176
        Some("site"),
1177
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1178
    )
1179
    .await;
1180
    assert!(st.is_success(), "{st}");
1181
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1182
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1183
    let csrf = csrf_of(&board);
1184
    let plan = |c: &str, t: &str| {
1185
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1186
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1187
        async move {
1188
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1189
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1190
        }
1191
    };
1192
    let kinds = |v: &serde_json::Value| {
1193
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1194
    };
1195
    // second already depends on first: squash, no rebase.
1196
    let v = plan(&second, &first).await;
1197
    assert_eq!(kinds(&v), ["squash"], "{v}");
1198
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1199
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygen.oxygen-vscode/plan?"));
1200
    // apart is independent of second: either.
1201
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1202
    // first under second: nothing (second depends on first).
1203
    assert!(plan(&first, &second).await["error"].is_string());
1204
    // What has landed on main is not rearranged.
1205
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1206
}
1207
1208
/// Issues and proposals share a number space, so every number says what it
1209
/// is, and the chain of work shows from both ends (hub spec §8).
1210
#[tokio::test(flavor = "multi_thread")]
1211
async fn proposals_and_issues_show_their_chain() {
1212
    let h = hub().await;
1213
    let app = &h.app;
1214
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1215
        .await
1216
        .cookie
1217
        .unwrap();
1218
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1219
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1220
    let url = format!("{}/andy/demo", h.base);
1221
    let work = tempfile::tempdir().unwrap();
1222
    let w = work.path().to_path_buf();
1223
    tokio::task::spawn_blocking(move || {
1224
        let mut c = Repo::init(&w).unwrap();
1225
        c.config.set("remote.origin.url", &url).unwrap();
1226
        c.config.set("remote.origin.token", "site").unwrap();
1227
        c.save_config().unwrap();
1228
        write(&w, "a.txt", b"a\n");
1229
        c.commit("base", &[]).unwrap();
1230
        assert!(c.push("origin", false).unwrap()[0].ok);
1231
        c.bookmark_create("feature", None).unwrap();
1232
        c.bookmark_switch("feature", false).unwrap();
1233
        write(&w, "a.txt", b"a\nfixed\n");
1234
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1235
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1236
    })
1237
    .await
1238
    .unwrap();
1239
    for title in ["Slow start", "Crash on save"] {
1240
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1241
        assert!(st.is_success());
1242
    }
1243
    let (st, v) = api(
1244
        app,
1245
        "POST",
1246
        "/api/v1/repos/andy/demo/proposals",
1247
        Some("site"),
1248
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1249
    )
1250
    .await;
1251
    assert!(st.is_success(), "{st} {v}");
1252
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1253
1254
    // The proposal names its kind, links its references by kind, and shows
1255
    // the chain: the issues it closes (description and changes) → it → main.
1256
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1257
    assert!(p.contains(">proposal #3</small>"), "header");
1258
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1259
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1260
    let chain = &chain[..chain.find("</p>").unwrap()];
1261
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1262
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1263
    }
1264
    assert!(p.contains("<h3>Closes</h3>"));
1265
1266
    // The issue shows the proposal that closes it, and names its own kind.
1267
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1268
    assert!(i.contains(">issue #1</small>"));
1269
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1270
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1271
    // The conversation is a timeline with avatars; editing sits with the
1272
    // content, not in the sidebar, and labels and projects are editable.
1273
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1274
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1275
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1276
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1277
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1278
    assert!(st.is_success(), "{st}");
1279
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1280
    assert!(
1281
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1282
        "the owner's projects to add to, in a menu"
1283
    );
1284
    let csrf = csrf_of(&p);
1285
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1286
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1287
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1288
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1289
        .await;
1290
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1291
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1292
1293
    // Closed by the proposal's change, not its description: still shown.
1294
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1295
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1296
    assert!(chain.contains("proposal #3"), "{chain}");
1297
}
1298
1299
/// What the hub is: its version and build, and the libraries it is built on,
1300
/// on /about, in the API and in /health (hub spec §15).
1301
#[tokio::test(flavor = "multi_thread")]
1302
async fn the_hub_says_what_version_it_is() {
1303
    let h = hub().await;
1304
    let app = &h.app;
1305
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1306
    assert_eq!(st, StatusCode::OK);
1307
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1308
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1309
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1310
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1311
    assert!(health.contains("\"build\""), "{health}");
1312
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1313
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1314
    assert!(about.contains("href=\"/about\""), "the footer links here");
1315
}
1316
1317
#[tokio::test(flavor = "multi_thread")]
1318
async fn device_sign_in() {
1319
    let h = hub().await;
1320
    let app = &h.app;
1321
    let r =
1322
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1323
    let andy = r.cookie.unwrap();
1324
1325
    // An unknown scope is refused.
1326
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1327
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1328
1329
    // The app asks for a code and polls; nobody has approved it yet.
1330
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1331
    assert_eq!(st, StatusCode::OK, "{v}");
1332
    let device = v["device_code"].as_str().unwrap().to_string();
1333
    let user = v["user_code"].as_str().unwrap().to_string();
1334
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1335
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1336
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1337
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1338
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1339
    assert_eq!(v["error"], "slow_down", "polled too soon");
1340
1341
    // The user approves it on the web, allowing less than it asked for.
1342
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1343
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1344
    let csrf = csrf_of(&page.body);
1345
    let r =
1346
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1347
            .await;
1348
    // oxygenhub#83: the answer page says it is done, with no code form.
1349
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1350
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1351
1352
    // The next poll gets a token with what was allowed, once.
1353
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1354
    assert_eq!(st, StatusCode::OK, "{v}");
1355
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1356
    let token = v["access_token"].as_str().unwrap().to_string();
1357
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1358
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1359
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1360
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1361
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1362
    assert!(tokens.body.contains("device: Phone app"));
1363
    // oxygenhub#70: a device's token expires, and each use renews it.
1364
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1365
1366
    // The token can revoke itself (oxy auth logout), and is then refused.
1367
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1368
    assert_eq!(st, StatusCode::NO_CONTENT);
1369
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1370
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1371
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1372
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1373
1374
    // A denied code says so.
1375
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1376
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1377
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1378
    let csrf = csrf_of(&page.body);
1379
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1380
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1381
    assert_eq!(v["error"], "access_denied");
1382
1383
    // Signed out, the page asks for a sign-in first.
1384
    let r = call(app, "GET", "/device", None, None, None, None).await;
1385
    assert!(r.status.is_redirection(), "{}", r.status);
1386
}