OXYGENHUB
# de505df5cf8d oxygenhub / crates / hub / src / web / proposals.rs
36.6 KiB · Rust · last changed Milestone 0.3: proposals and review 1 month ago source blame history raw
de505df5 Andy McCall ↶ 1
//! Proposal pages (hub spec §7): list, new, detail with conversation,
2
//! changes and files, comments anchored to atoms, reviews, landing.
3
4
use super::history::{render_files, FileRows};
5
use super::settings::{csrf, require};
6
use super::{filters, lookup, lookup_role, Error, Page, RepoShell, Shell};
7
use crate::auth::{Access, Role, Viewer};
8
use crate::db::{self, accounts, proposals as pdb};
9
use crate::render::{self, diff};
10
use crate::repos::proposals::{self as pl, Projection, Source};
11
use crate::repos::view::{self, ChangeView, ConflictView};
12
use crate::repos::RepoName;
13
use crate::Shared;
14
use askama::Template;
15
use axum::extract::{Form, Path, Query, State};
16
use axum::response::{IntoResponse, Redirect, Response};
17
use hub_api::{Approval, ProposalSource, ProposalState};
18
use oxy_core::hash::ChangeHash;
19
use serde::Deserialize;
20
use std::collections::{BTreeMap, HashMap};
21
22
// ------------------------------------------------------------------ list
23
24
#[derive(Template)]
25
#[template(path = "proposals.html")]
26
pub struct ProposalsPage {
27
    shell: Shell,
28
    repo: RepoShell,
29
    rows: Vec<pdb::ProposalRow>,
30
    filter: String,
31
    counts: (usize, usize, usize),
32
    bookmarks: Vec<String>,
33
}
34
35
#[derive(Deserialize)]
36
pub struct ListQuery {
37
    state: Option<String>,
38
}
39
40
pub async fn list(
41
    State(app): State<Shared>,
42
    viewer: Viewer,
43
    Path((owner, name)): Path<(String, String)>,
44
    Query(q): Query<ListQuery>,
45
) -> Result<Page<ProposalsPage>, Error> {
46
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposals"), &viewer);
47
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
48
    let all = pdb::list(&app.db, row.id, &[]).await.map_err(|e| Error::from_db(shell.clone(), e))?;
49
    let counts = (
50
        all.iter().filter(|p| p.is_open()).count(),
51
        all.iter().filter(|p| p.state == "landed").count(),
52
        all.iter().filter(|p| p.state == "closed").count(),
53
    );
54
    let filter = q.state.unwrap_or_else(|| "open".into());
55
    let rows = all
56
        .into_iter()
57
        .filter(|p| match filter.as_str() {
58
            "open" => p.is_open(),
59
            "landed" => p.state == "landed",
60
            "closed" => p.state == "closed",
61
            _ => true,
62
        })
63
        .collect();
64
    let bookmarks = app
65
        .repos
66
        .read(&repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>()))
67
        .await
68
        .map_err(|e| Error::from_repo(shell.clone(), e))?;
69
    Ok(Page(ProposalsPage { shell, repo: RepoShell::new(&app, &row, "proposals").with_role(role), rows, filter, counts, bookmarks }))
70
}
71
72
// ------------------------------------------------------------------- new
73
74
#[derive(Template)]
75
#[template(path = "proposal_new.html")]
76
pub struct NewProposalPage {
77
    shell: Shell,
78
    repo: RepoShell,
79
    bookmarks: Vec<String>,
80
    source: String,
81
    target: String,
82
    error: Option<String>,
83
    /// Preview: the changes the proposal would add.
84
    preview: Vec<ChangeView>,
85
    conflicted: bool,
86
}
87
88
#[derive(Deserialize)]
89
pub struct NewQuery {
90
    source: Option<String>,
91
    target: Option<String>,
92
}
93
94
/// `owner/name:bookmark` for a fork, else a bookmark of this repository.
95
fn parse_source(app: &Shared, repo: &RepoName, source: &str) -> Option<(Option<RepoName>, String)> {
96
    if let Some((slug, bookmark)) = source.split_once(':') {
97
        let fork = RepoName::parse(slug)?;
98
        if !app.repos.exists(&fork) || fork == *repo {
99
            return None;
100
        }
101
        return Some((Some(fork), bookmark.to_string()));
102
    }
103
    crate::repos::names::valid_segment(source).then(|| (None, source.to_string()))
104
}
105
106
async fn preview_for(
107
    app: &Shared,
108
    repo: &RepoName,
109
    target: &str,
110
    source: &str,
111
) -> Result<(Vec<ChangeView>, bool), crate::repos::RepoError> {
112
    let Some((fork, bookmark)) = parse_source(app, repo, source) else { return Ok((vec![], false)) };
113
    let target = target.to_string();
114
    let fork_dir = fork.as_ref().map(|f| app.repos.dir(f));
115
    app.repos
116
        .read(repo, move |r, cache| {
117
            let projection = match &fork_dir {
118
                Some(dir) => {
119
                    let fork_repo = oxy_core::repo::Repo::open(dir)?;
120
                    let heads = fork_repo.bookmarks()?.into_iter().find(|b| b.name == bookmark).map(|b| b.heads).unwrap_or_default();
121
                    pl::project(r, cache, &target, Source::Fork { fork: &fork_repo, heads })?
122
                }
123
                None => {
124
                    let heads = r.bookmarks()?.into_iter().find(|b| b.name == bookmark).map(|b| b.heads).unwrap_or_default();
125
                    pl::project(r, cache, &target, Source::Bookmark(heads))?
126
                }
127
            };
128
            Ok((projection.changes, projection.conflicted))
129
        })
130
        .await
131
}
132
133
pub async fn new_form(
134
    State(app): State<Shared>,
135
    viewer: Viewer,
136
    Path((owner, name)): Path<(String, String)>,
137
    Query(q): Query<NewQuery>,
138
) -> Result<Page<NewProposalPage>, Error> {
139
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposals/new"), &viewer);
140
    require(&viewer, &shell)?;
141
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
142
    let bookmarks = app
143
        .repos
144
        .read(&repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>()))
145
        .await
146
        .map_err(|e| Error::from_repo(shell.clone(), e))?;
147
    let target = q.target.unwrap_or_else(|| row.default_bookmark.clone());
148
    let source = q.source.unwrap_or_default();
149
    let (preview, conflicted) =
150
        if source.is_empty() { (vec![], false) } else { preview_for(&app, &repo, &target, &source).await.unwrap_or((vec![], false)) };
151
    Ok(Page(NewProposalPage {
152
        shell,
153
        repo: RepoShell::new(&app, &row, "proposals").with_role(role),
154
        bookmarks,
155
        source,
156
        target,
157
        error: None,
158
        preview,
159
        conflicted,
160
    }))
161
}
162
163
#[derive(Deserialize)]
164
pub struct NewForm {
165
    #[serde(rename = "_csrf")]
166
    csrf_token: String,
167
    title: String,
168
    #[serde(default)]
169
    body: String,
170
    target: String,
171
    source: String,
172
    #[serde(default)]
173
    draft: Option<String>,
174
}
175
176
pub async fn create(
177
    State(app): State<Shared>,
178
    viewer: Viewer,
179
    Path((owner, name)): Path<(String, String)>,
180
    Form(f): Form<NewForm>,
181
) -> Result<Response, Error> {
182
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposals/new"), &viewer);
183
    let me = require(&viewer, &shell)?;
184
    csrf(&viewer, &f.csrf_token, &shell)?;
185
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
186
    let bookmarks = app
187
        .repos
188
        .read(&repo, |r, _| Ok(r.bookmarks()?.into_iter().map(|b| b.name).collect::<Vec<_>>()))
189
        .await
190
        .map_err(|e| Error::from_repo(shell.clone(), e))?;
191
    let fail = |msg: &str, preview: Vec<ChangeView>| {
192
        Page(NewProposalPage {
193
            shell: shell.clone(),
194
            repo: RepoShell::new(&app, &row, "proposals").with_role(role),
195
            bookmarks: bookmarks.clone(),
196
            source: f.source.clone(),
197
            target: f.target.clone(),
198
            error: Some(msg.into()),
199
            preview,
200
            conflicted: false,
201
        })
202
        .into_response()
203
    };
204
    if f.title.trim().is_empty() {
205
        return Ok(fail("Give the proposal a title.", vec![]));
206
    }
207
    if !bookmarks.contains(&f.target) {
208
        return Ok(fail("Pick a target bookmark of this repository.", vec![]));
209
    }
210
    let Some((fork, bookmark)) = parse_source(&app, &repo, f.source.trim()) else {
211
        return Ok(fail("The source is a bookmark of this repository, or owner/name:bookmark of a fork.", vec![]));
212
    };
213
    if fork.is_none() && bookmark == f.target {
214
        return Ok(fail("The source and the target are the same bookmark.", vec![]));
215
    }
216
    let (preview, _) = preview_for(&app, &repo, &f.target, f.source.trim()).await.map_err(|e| Error::from_repo(shell.clone(), e))?;
217
    if preview.is_empty() {
218
        return Ok(fail("The source adds nothing to the target.", vec![]));
219
    }
220
    let source_repo_id = match &fork {
221
        Some(fk) => db::repos::get(&app.db, &fk.owner, &fk.name).await.map_err(|e| Error::from_db(shell.clone(), e))?.map(|r| r.id),
222
        None => None,
223
    };
224
    let created = pdb::create(
225
        &app.db,
226
        pdb::NewProposal {
227
            repo_id: row.id,
228
            title: f.title.trim(),
229
            body: f.body.trim(),
230
            author_id: Some(me.account.id),
231
            author: &me.account.username,
232
            draft: f.draft.is_some(),
233
            target: &f.target,
234
            source_kind: if fork.is_some() { "fork" } else { "bookmark" },
235
            source_repo_id,
236
            source_bookmark: &bookmark,
237
            source_changes: "",
238
        },
239
    )
240
    .await
241
    .map_err(|e| Error::from_db(shell.clone(), e))?;
242
    pdb::add_event(&app.db, created.id, &me.account.username, "opened", "").await.ok();
243
    accounts::audit(&app.db, Some(&me.account), "proposal.opened", &format!("{owner}/{name}#{}", created.number), &f.title).await.ok();
244
    Ok(Redirect::to(&format!("/{owner}/{name}/proposal/{}", created.number)).into_response())
245
}
246
247
// ---------------------------------------------------------------- detail
248
249
/// A comment placed on a diff row, or general.
250
pub struct CommentView {
251
    pub row: pdb::CommentRow,
252
    pub body_html: String,
253
    pub line: Option<usize>,
254
}
255
256
pub struct ReviewView {
257
    pub row: pdb::ReviewRow,
258
    pub body_html: String,
259
    pub sealed: bool,
260
}
261
262
/// Everything the detail page and the API need, computed once under the lock.
263
pub struct Loaded {
264
    pub row: pdb::ProposalRow,
265
    pub changes: Vec<ChangeView>,
266
    pub hashes: Vec<ChangeHash>,
267
    pub heads: Vec<ChangeHash>,
268
    pub state: String,
269
    pub target_state: String,
270
    pub conflicted: bool,
271
    pub conflicts: Vec<ConflictView>,
272
    pub files: Vec<FileRows>,
273
    /// Atom per (path, new line number) of the projected state.
274
    pub atoms: HashMap<(String, usize), (String, u32)>,
275
    pub sealing_keys: Vec<String>,
276
    pub touched: Vec<String>,
277
    pub owners: Vec<String>,
278
    pub landed_already: bool,
279
}
280
281
/// Compute the projection and everything derived from it.
282
pub async fn load(app: &Shared, repo: &RepoName, row: pdb::ProposalRow) -> Result<Loaded, crate::repos::RepoError> {
283
    let fork_dir = match (row.source_kind.as_str(), row.source_repo_id) {
284
        ("fork", Some(id)) => {
285
            db::repos::get_by_id(&app.db, id).await.ok().flatten().and_then(|r| RepoName::new(&r.owner, &r.name)).map(|n| app.repos.dir(&n))
286
        }
287
        _ => None,
288
    };
289
    let r2 = row.clone();
290
    let loaded = app
291
        .repos
292
        .read(repo, move |r, cache| {
293
            let source = match (r2.source_kind.as_str(), &fork_dir) {
294
                ("changes", _) => Source::Changes(r2.source_changes().iter().filter_map(|h| ChangeHash::from_hex(h)).collect()),
295
                ("fork", Some(dir)) => {
296
                    let fork_repo = oxy_core::repo::Repo::open(dir)?;
297
                    let heads =
298
                        fork_repo.bookmarks()?.into_iter().find(|b| b.name == r2.source_bookmark).map(|b| b.heads).unwrap_or_default();
299
                    // Bring the fork's changes over now, so the projection below can read them.
300
                    let fork_state = fork_repo.load_state(&heads)?;
301
                    let missing: Vec<ChangeHash> = fork_state.changes().map(|(h, _)| *h).filter(|h| !r.store().has(h)).collect();
302
                    if !missing.is_empty() {
303
                        r.import_bundle(&fork_repo.bundle_for(&missing)?, r.current_policy()?.is_some())?;
304
                    }
305
                    Source::Changes(heads)
306
                }
307
                _ => {
308
                    let heads = r.bookmarks()?.into_iter().find(|b| b.name == r2.source_bookmark).map(|b| b.heads).unwrap_or_default();
309
                    Source::Bookmark(heads)
310
                }
311
            };
312
            let p: Projection = pl::project(r, cache, &r2.target, source)?;
313
            let target_loaded = cache.load(r, &p.target_heads)?;
314
            let files = render_files(&p.files, &p.bases);
315
            let mut atoms = HashMap::new();
316
            for f in &files {
317
                for l in &f.lines {
318
                    if let Some(n) = l.new_no {
319
                        if let Some((h, i)) = pl::atom_at(&p.loaded, &f.path, n as usize) {
320
                            atoms.insert((f.path.clone(), n as usize), (h.to_hex(), i));
321
                        }
322
                    }
323
                }
324
            }
325
            let touched: Vec<String> = p.files.iter().map(|f| f.path.clone()).collect();
326
            let owners = pl::owners_for(&target_loaded, &touched);
327
            let sealing = pl::sealing_keys(r, &p.hashes)?.into_iter().map(|k| k.to_hex()).collect();
328
            let landed_already = !p.hashes.is_empty() && p.hashes.iter().all(|h| target_loaded.state.contains(h));
329
            Ok(Loaded {
330
                row: r2,
331
                changes: p.changes,
332
                hashes: p.hashes,
333
                heads: p.heads,
334
                state: p.state.to_hex(),
335
                target_state: p.target_state.to_hex(),
336
                conflicted: p.conflicted,
337
                conflicts: p.conflicts,
338
                files,
339
                atoms,
340
                sealing_keys: sealing,
341
                touched,
342
                owners,
343
                landed_already,
344
            })
345
        })
346
        .await?;
347
    // Remember the projection for the list, the API and other proposals' stacking checks.
348
    let heads_csv = loaded.heads.iter().map(|h| h.to_hex()).collect::<Vec<_>>().join(",");
349
    let changes_csv = loaded.hashes.iter().map(|h| h.to_hex()).collect::<Vec<_>>().join(",");
350
    pdb::set_projection(&app.db, loaded.row.id, &loaded.state, &heads_csv, &loaded.target_state, &changes_csv, loaded.conflicted)
351
        .await
352
        .ok();
353
    Ok(loaded)
354
}
355
356
/// Reviews, approvals and blockers.
357
pub struct Verdict {
358
    pub reviews: Vec<ReviewView>,
359
    pub approvals: Vec<Approval>,
360
    pub blockers: Vec<String>,
361
    pub depends_on: Vec<i64>,
362
    pub requirements: pdb::Requirements,
363
}
364
365
pub async fn verdict(app: &Shared, loaded: &Loaded, repo_id: i64) -> Result<Verdict, sqlx::Error> {
366
    let rows = pdb::reviews(&app.db, loaded.row.id).await?;
367
    let links = accounts::identity_accounts(&app.db).await?;
368
    let sealed_accounts: Vec<String> = links.iter().filter(|(k, _)| loaded.sealing_keys.contains(k)).map(|(_, u)| u.clone()).collect();
369
    // Latest verdict per reviewer.
370
    let mut latest: BTreeMap<String, &pdb::ReviewRow> = BTreeMap::new();
371
    for r in &rows {
372
        latest.insert(r.author.clone(), r);
373
    }
374
    let mut approvals = Vec::new();
375
    for (who, r) in &latest {
376
        if r.verdict == "approve" {
377
            let sealed = sealed_accounts.contains(who);
378
            let key = links.iter().find(|(k, u)| u == who && loaded.sealing_keys.contains(k)).map(|(k, _)| k.clone());
379
            approvals.push(Approval { account: who.clone(), sealed, key });
380
        }
381
    }
382
    let reviews = rows
383
        .iter()
384
        .map(|r| ReviewView {
385
            row: r.clone(),
386
            body_html: render::markdown::render(&r.body, "/", "/"),
387
            sealed: r.verdict == "approve" && sealed_accounts.contains(&r.author),
388
        })
389
        .collect();
390
    let requirements = pdb::requirements(&app.db, repo_id).await?;
391
    let mut blockers = Vec::new();
392
    if loaded.row.state == "draft" {
393
        blockers.push("the proposal is a draft".into());
394
    }
395
    if loaded.hashes.is_empty() {
396
        blockers.push("the proposal adds no changes".into());
397
    }
398
    let sealed_count = approvals.iter().filter(|a| a.sealed).count() as i64;
399
    if sealed_count < requirements.required_approvals {
400
        blockers.push(format!("{sealed_count} of {} required sealed approvals", requirements.required_approvals));
401
    }
402
    if requirements.require_owners {
403
        let missing: Vec<&String> = loaded.owners.iter().filter(|o| !approvals.iter().any(|a| a.sealed && &a.account == *o)).collect();
404
        if !missing.is_empty() {
405
            blockers.push(format!("code owners still to approve: {}", missing.iter().map(|s| s.as_str()).collect::<Vec<_>>().join(", ")));
406
        }
407
    }
408
    if loaded.conflicted && !requirements.allow_conflicts {
409
        blockers.push("landing would carry conflicts, which this repository refuses".into());
410
    }
411
    let requesting: Vec<&String> = latest.iter().filter(|(_, r)| r.verdict == "changes").map(|(who, _)| who).collect();
412
    if !requesting.is_empty() {
413
        blockers.push(format!("changes requested by {}", requesting.iter().map(|s| s.as_str()).collect::<Vec<_>>().join(", ")));
414
    }
415
    // Stacking: another open, earlier proposal whose changes this one includes.
416
    let mut depends_on = Vec::new();
417
    for other in pdb::list(&app.db, repo_id, &["open", "draft"]).await? {
418
        if other.id == loaded.row.id || other.number > loaded.row.number {
419
            continue;
420
        }
421
        let theirs = other.projected_changes();
422
        if !theirs.is_empty() && theirs.iter().all(|h| loaded.hashes.iter().any(|m| m.to_hex() == *h)) {
423
            depends_on.push(other.number);
424
        }
425
    }
426
    if !depends_on.is_empty() {
427
        blockers.push(format!("depends on {}", depends_on.iter().map(|n| format!("#{n}")).collect::<Vec<_>>().join(", ")));
428
    }
429
    Ok(Verdict { reviews, approvals, blockers, depends_on, requirements })
430
}
431
432
#[derive(Template)]
433
#[template(path = "proposal.html")]
434
pub struct ProposalPage {
435
    shell: Shell,
436
    repo: RepoShell,
437
    p: pdb::ProposalRow,
438
    body_html: String,
439
    tab: String,
440
    changes: Vec<ChangeView>,
441
    files: Vec<FileRows>,
442
    conflicts: Vec<ConflictView>,
443
    conflicted: bool,
444
    comments: Vec<CommentView>,
445
    /// Anchored comments by (path, current line).
446
    placed: HashMap<(String, usize), Vec<usize>>,
447
    outdated: Vec<usize>,
448
    reviews: Vec<ReviewView>,
449
    approvals: Vec<Approval>,
450
    blockers: Vec<String>,
451
    depends_on: Vec<i64>,
452
    events: Vec<pdb::EventRow>,
453
    owners: Vec<String>,
454
    requirements: pdb::Requirements,
455
    landed_already: bool,
456
    can_edit: bool,
457
    can_land: bool,
458
    hub_can_land: bool,
459
    notice: Option<String>,
460
    error: Option<String>,
461
    heads: Vec<String>,
462
    state_hash: String,
463
    source_label: String,
464
    api_url: String,
465
}
466
467
#[derive(Deserialize)]
468
pub struct DetailQuery {
469
    tab: Option<String>,
470
}
471
472
/// The page assembler every action ends in; its arguments are the route
473
/// plus what to say, and a struct would only rename them.
474
#[allow(clippy::too_many_arguments)]
475
async fn detail(
476
    app: &Shared,
477
    shell: Shell,
478
    viewer: &Viewer,
479
    owner: &str,
480
    name: &str,
481
    number: i64,
482
    tab: String,
483
    notice: Option<String>,
484
    error: Option<String>,
485
) -> Result<Page<ProposalPage>, Error> {
486
    let (repo, row, role) = lookup(app, &shell, viewer, owner, name).await?;
487
    let p = pdb::get(&app.db, row.id, number)
488
        .await
489
        .map_err(|e| Error::from_db(shell.clone(), e))?
490
        .ok_or_else(|| Error::not_found(shell.clone()))?;
491
    let loaded = load(app, &repo, p).await.map_err(|e| Error::from_repo(shell.clone(), e))?;
492
    // A proposal whose changes all reached the target landed by another route.
493
    if loaded.landed_already && loaded.row.is_open() {
494
        pdb::set_state(&app.db, loaded.row.id, "landed", &loaded.target_state).await.ok();
495
        pdb::add_event(&app.db, loaded.row.id, "", "landed", "every change reached the target").await.ok();
496
    }
497
    let p = pdb::get(&app.db, row.id, number).await.map_err(|e| Error::from_db(shell.clone(), e))?.unwrap_or(loaded.row.clone());
498
    let v = verdict(app, &loaded, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
499
    let comment_rows = pdb::comments(&app.db, loaded.row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
500
    let events = pdb::events(&app.db, loaded.row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
501
    // Place anchored comments at their atom's current line.
502
    let mut by_atom: HashMap<(String, String, u32), usize> = HashMap::new();
503
    for ((path, line), (h, i)) in &loaded.atoms {
504
        by_atom.insert((path.clone(), h.clone(), *i), *line);
505
    }
506
    let mut comments = Vec::new();
507
    let mut placed: HashMap<(String, usize), Vec<usize>> = HashMap::new();
508
    let mut outdated = Vec::new();
509
    for (idx, c) in comment_rows.into_iter().enumerate() {
510
        let line = if c.anchor_change.is_empty() {
511
            None
512
        } else {
513
            by_atom.get(&(c.path.clone(), c.anchor_change.clone(), c.anchor_index as u32)).copied()
514
        };
515
        if !c.anchor_change.is_empty() {
516
            match line {
517
                Some(l) => placed.entry((c.path.clone(), l)).or_default().push(idx),
518
                None => outdated.push(idx),
519
            }
520
        }
521
        comments.push(CommentView { body_html: render::markdown::render(&c.body, "/", "/"), row: c, line });
522
    }
523
    let mut changes = loaded.changes.clone();
524
    super::attribute(app, &mut changes.iter_mut().collect::<Vec<_>>()).await;
525
    let me = viewer.account();
526
    let can_edit = me.is_some_and(|a| Some(a.id) == p.author_id || role >= Role::Maintain);
527
    let can_land = role >= Role::Write && p.is_open() && v.blockers.is_empty();
528
    let hub_can_land = app.repos.read(&repo, |r, _| Ok(r.current_policy()?.is_none())).await.unwrap_or(false);
529
    let source_label = match p.source_kind.as_str() {
530
        "fork" => format!(
531
            "fork {}",
532
            db::repos::get_by_id(&app.db, p.source_repo_id.unwrap_or(0))
533
                .await
534
                .ok()
535
                .flatten()
536
                .map(|r| format!("{}:{}", r.slug(), p.source_bookmark))
537
                .unwrap_or_default()
538
        ),
539
        "changes" => format!("{} changes", p.source_changes().len()),
540
        _ => p.source_bookmark.clone(),
541
    };
542
    Ok(Page(ProposalPage {
543
        shell,
544
        repo: RepoShell::new(app, &row, "proposals").with_role(role),
545
        body_html: render::markdown::render(&p.body, "/", "/"),
546
        p,
547
        tab,
548
        changes,
549
        files: loaded.files,
550
        conflicts: loaded.conflicts,
551
        conflicted: loaded.conflicted,
552
        comments,
553
        placed,
554
        outdated,
555
        reviews: v.reviews,
556
        approvals: v.approvals,
557
        blockers: v.blockers,
558
        depends_on: v.depends_on,
559
        events,
560
        owners: loaded.owners,
561
        requirements: v.requirements,
562
        landed_already: loaded.landed_already,
563
        can_edit,
564
        can_land,
565
        hub_can_land,
566
        notice,
567
        error,
568
        heads: loaded.heads.iter().map(|h| h.to_hex()).collect(),
569
        state_hash: loaded.state,
570
        source_label,
571
        api_url: format!("{}/api/v1/repos/{owner}/{name}/proposals/{number}", app.config.base_url()),
572
    }))
573
}
574
575
pub async fn show(
576
    State(app): State<Shared>,
577
    viewer: Viewer,
578
    Path((owner, name, number)): Path<(String, String, i64)>,
579
    Query(q): Query<DetailQuery>,
580
) -> Result<Page<ProposalPage>, Error> {
581
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
582
    detail(&app, shell, &viewer, &owner, &name, number, q.tab.unwrap_or_else(|| "conversation".into()), None, None).await
583
}
584
585
// ---------------------------------------------------------------- actions
586
587
#[derive(Deserialize)]
588
pub struct CommentForm {
589
    #[serde(rename = "_csrf")]
590
    csrf_token: String,
591
    body: String,
592
    #[serde(default)]
593
    path: String,
594
    #[serde(default)]
595
    line: Option<usize>,
596
}
597
598
pub async fn comment(
599
    State(app): State<Shared>,
600
    viewer: Viewer,
601
    Path((owner, name, number)): Path<(String, String, i64)>,
602
    Form(f): Form<CommentForm>,
603
) -> Result<Page<ProposalPage>, Error> {
604
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
605
    let me = require(&viewer, &shell)?;
606
    csrf(&viewer, &f.csrf_token, &shell)?;
607
    let (repo, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
608
    let p = pdb::get(&app.db, row.id, number)
609
        .await
610
        .map_err(|e| Error::from_db(shell.clone(), e))?
611
        .ok_or_else(|| Error::not_found(shell.clone()))?;
612
    if f.body.trim().is_empty() {
613
        return detail(
614
            &app,
615
            shell,
616
            &viewer,
617
            &owner,
618
            &name,
619
            number,
620
            "conversation".into(),
621
            None,
622
            Some("An empty comment says nothing.".into()),
623
        )
624
        .await;
625
    }
626
    let anchor = match (f.path.trim(), f.line) {
627
        ("", _) | (_, None) => None,
628
        (path, Some(line)) => {
629
            let loaded = load(&app, &repo, p.clone()).await.map_err(|e| Error::from_repo(shell.clone(), e))?;
630
            loaded.atoms.get(&(path.to_string(), line)).cloned()
631
        }
632
    };
633
    let tab = if anchor.is_some() { "files" } else { "conversation" };
634
    pdb::add_comment(
635
        &app.db,
636
        p.id,
637
        Some(me.account.id),
638
        &me.account.username,
639
        f.body.trim(),
640
        f.path.trim(),
641
        anchor.as_ref().map(|(h, i)| (h.as_str(), *i as i64)),
642
    )
643
    .await
644
    .map_err(|e| Error::from_db(shell.clone(), e))?;
645
    detail(&app, shell, &viewer, &owner, &name, number, tab.into(), None, None).await
646
}
647
648
#[derive(Deserialize)]
649
pub struct ReviewForm {
650
    #[serde(rename = "_csrf")]
651
    csrf_token: String,
652
    verdict: String,
653
    #[serde(default)]
654
    body: String,
655
}
656
657
pub async fn review(
658
    State(app): State<Shared>,
659
    viewer: Viewer,
660
    Path((owner, name, number)): Path<(String, String, i64)>,
661
    Form(f): Form<ReviewForm>,
662
) -> Result<Page<ProposalPage>, Error> {
663
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
664
    let me = require(&viewer, &shell)?;
665
    csrf(&viewer, &f.csrf_token, &shell)?;
666
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
667
    let p = pdb::get(&app.db, row.id, number)
668
        .await
669
        .map_err(|e| Error::from_db(shell.clone(), e))?
670
        .ok_or_else(|| Error::not_found(shell.clone()))?;
671
    if !matches!(f.verdict.as_str(), "comment" | "changes" | "approve") {
672
        return Err(Error::bad(shell, "a review is comment, changes or approve"));
673
    }
674
    if f.verdict == "approve" && Some(me.account.id) == p.author_id {
675
        return detail(
676
            &app,
677
            shell,
678
            &viewer,
679
            &owner,
680
            &name,
681
            number,
682
            "conversation".into(),
683
            None,
684
            Some("You cannot approve your own proposal.".into()),
685
        )
686
        .await;
687
    }
688
    pdb::add_review(&app.db, p.id, me.account.id, &me.account.username, &f.verdict, f.body.trim())
689
        .await
690
        .map_err(|e| Error::from_db(shell.clone(), e))?;
691
    pdb::add_event(&app.db, p.id, &me.account.username, &format!("review.{}", f.verdict), "").await.ok();
692
    let notice = if f.verdict == "approve" {
693
        Some(format!(
694
            "Approval recorded. It counts once you seal the changes: oxy seal --proposal {}/{owner}/{name}/proposal/{number}",
695
            app.config.base_url()
696
        ))
697
    } else {
698
        None
699
    };
700
    detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), notice, None).await
701
}
702
703
#[derive(Deserialize)]
704
pub struct EditForm {
705
    #[serde(rename = "_csrf")]
706
    csrf_token: String,
707
    title: String,
708
    #[serde(default)]
709
    body: String,
710
    target: String,
711
}
712
713
pub async fn edit(
714
    State(app): State<Shared>,
715
    viewer: Viewer,
716
    Path((owner, name, number)): Path<(String, String, i64)>,
717
    Form(f): Form<EditForm>,
718
) -> Result<Page<ProposalPage>, Error> {
719
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
720
    let me = require(&viewer, &shell)?;
721
    csrf(&viewer, &f.csrf_token, &shell)?;
722
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
723
    let p = pdb::get(&app.db, row.id, number)
724
        .await
725
        .map_err(|e| Error::from_db(shell.clone(), e))?
726
        .ok_or_else(|| Error::not_found(shell.clone()))?;
727
    if Some(me.account.id) != p.author_id && role < Role::Maintain {
728
        return Err(Error::not_found(shell));
729
    }
730
    let target = if crate::repos::names::valid_segment(f.target.trim()) { f.target.trim() } else { &p.target };
731
    pdb::edit(&app.db, p.id, f.title.trim(), f.body.trim(), target).await.map_err(|e| Error::from_db(shell.clone(), e))?;
732
    pdb::add_event(&app.db, p.id, &me.account.username, "edited", "").await.ok();
733
    detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), Some("Saved.".into()), None).await
734
}
735
736
#[derive(Deserialize)]
737
pub struct StateForm {
738
    #[serde(rename = "_csrf")]
739
    csrf_token: String,
740
    action: String,
741
}
742
743
pub async fn state(
744
    State(app): State<Shared>,
745
    viewer: Viewer,
746
    Path((owner, name, number)): Path<(String, String, i64)>,
747
    Form(f): Form<StateForm>,
748
) -> Result<Page<ProposalPage>, Error> {
749
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
750
    let me = require(&viewer, &shell)?;
751
    csrf(&viewer, &f.csrf_token, &shell)?;
752
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
753
    let p = pdb::get(&app.db, row.id, number)
754
        .await
755
        .map_err(|e| Error::from_db(shell.clone(), e))?
756
        .ok_or_else(|| Error::not_found(shell.clone()))?;
757
    if Some(me.account.id) != p.author_id && role < Role::Triage {
758
        return Err(Error::not_found(shell));
759
    }
760
    let new_state = match (f.action.as_str(), p.state.as_str()) {
761
        ("close", "open" | "draft") => "closed",
762
        ("reopen", "closed") => "open",
763
        ("ready", "draft") => "open",
764
        ("draft", "open") => "draft",
765
        _ => return Err(Error::bad(shell, "that transition is not possible")),
766
    };
767
    pdb::set_state(&app.db, p.id, new_state, "").await.map_err(|e| Error::from_db(shell.clone(), e))?;
768
    pdb::add_event(&app.db, p.id, &me.account.username, new_state, "").await.ok();
769
    detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), None, None).await
770
}
771
772
pub async fn resolve_comment(
773
    State(app): State<Shared>,
774
    viewer: Viewer,
775
    Path((owner, name, number, id)): Path<(String, String, i64, i64)>,
776
    Form(f): Form<super::session::CsrfForm>,
777
) -> Result<Page<ProposalPage>, Error> {
778
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
779
    require(&viewer, &shell)?;
780
    csrf(&viewer, &f.csrf, &shell)?;
781
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
782
    let p = pdb::get(&app.db, row.id, number)
783
        .await
784
        .map_err(|e| Error::from_db(shell.clone(), e))?
785
        .ok_or_else(|| Error::not_found(shell.clone()))?;
786
    let current: Option<bool> = sqlx::query_scalar("SELECT resolved FROM proposal_comments WHERE id = ? AND proposal_id = ?")
787
        .bind(id)
788
        .bind(p.id)
789
        .fetch_optional(&app.db)
790
        .await
791
        .map_err(|e| Error::from_db(shell.clone(), e))?;
792
    if let Some(r) = current {
793
        pdb::set_comment_resolved(&app.db, id, !r).await.map_err(|e| Error::from_db(shell.clone(), e))?;
794
    }
795
    detail(&app, shell, &viewer, &owner, &name, number, "files".into(), None, None).await
796
}
797
798
/// Land from the hub: only when the repository has no trust policy (the
799
/// hub never signs a reference update the policy would have to admit).
800
pub async fn land(
801
    State(app): State<Shared>,
802
    viewer: Viewer,
803
    Path((owner, name, number)): Path<(String, String, i64)>,
804
    Form(f): Form<super::session::CsrfForm>,
805
) -> Result<Page<ProposalPage>, Error> {
806
    let shell = Shell::new(&app, &format!("/{owner}/{name}/proposal/{number}"), &viewer);
807
    let me = require(&viewer, &shell)?;
808
    csrf(&viewer, &f.csrf, &shell)?;
809
    let (repo, row, _) = lookup_role(&app, &shell, &viewer, &owner, &name, Access::Write).await?;
810
    let p = pdb::get(&app.db, row.id, number)
811
        .await
812
        .map_err(|e| Error::from_db(shell.clone(), e))?
813
        .ok_or_else(|| Error::not_found(shell.clone()))?;
814
    let loaded = load(&app, &repo, p.clone()).await.map_err(|e| Error::from_repo(shell.clone(), e))?;
815
    let v = verdict(&app, &loaded, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
816
    if !p.is_open() || !v.blockers.is_empty() {
817
        return detail(
818
            &app,
819
            shell,
820
            &viewer,
821
            &owner,
822
            &name,
823
            number,
824
            "conversation".into(),
825
            None,
826
            Some(format!("Cannot land: {}", v.blockers.join("; "))),
827
        )
828
        .await;
829
    }
830
    let target = p.target.clone();
831
    let heads = loaded.heads.clone();
832
    let result = app
833
        .repos
834
        .write(&repo, move |r, _| {
835
            if r.current_policy()?.is_some() {
836
                return Err(crate::repos::RepoError::Oxy(oxy_core::repo::RepoError::Msg(
837
                    "this repository has a trust policy, so a reference update must be signed by an authorised key: land from a client with oxy proposal land".into(),
838
                )));
839
            }
840
            r.bookmark_set(&target, &heads)?;
841
            Ok(pl::state_ref(&heads).to_hex())
842
        })
843
        .await;
844
    match result {
845
        Ok(state) => {
846
            pdb::set_state(&app.db, p.id, "landed", &state).await.map_err(|e| Error::from_db(shell.clone(), e))?;
847
            pdb::add_event(&app.db, p.id, &me.account.username, "landed", "from the hub").await.ok();
848
            accounts::audit(&app.db, Some(&me.account), "proposal.landed", &format!("{owner}/{name}#{number}"), "").await.ok();
849
            db::repos::record_push(
850
                &app.db,
851
                row.id,
852
                Some((me.account.id, me.account.username.as_str())),
853
                &[db::repos::PushOutcome {
854
                    reference: p.target.clone(),
855
                    ok: true,
856
                    reason: format!("landed #{number}"),
857
                    old_state: loaded.target_state.clone(),
858
                    new_state: state,
859
                    heads: loaded.heads.len() as i64,
860
                    changes: loaded.hashes.len() as i64,
861
                }],
862
            )
863
            .await
864
            .ok();
865
            detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), Some("Landed.".into()), None).await
866
        }
867
        Err(e) => detail(&app, shell, &viewer, &owner, &name, number, "conversation".into(), None, Some(e.to_string())).await,
868
    }
869
}
870
871
// -------------------------------------------------------------------- API
872
873
pub async fn to_api(app: &Shared, owner: &str, name: &str, loaded: &Loaded, v: &Verdict, source_url: Option<String>) -> hub_api::Proposal {
874
    let p = &loaded.row;
875
    hub_api::Proposal {
876
        number: p.number,
877
        title: p.title.clone(),
878
        body: p.body.clone(),
879
        author: p.author.clone(),
880
        state: ProposalState::parse(&p.state).unwrap_or(ProposalState::Open),
881
        target: p.target.clone(),
882
        source: match p.source_kind.as_str() {
883
            "fork" => {
884
                let (o, n) = source_url
885
                    .as_deref()
886
                    .and_then(|u| u.rsplit_once('/'))
887
                    .and_then(|(b, n)| b.rsplit_once('/').map(|(_, o)| (o.to_string(), n.to_string())))
888
                    .unwrap_or_default();
889
                ProposalSource::Fork { owner: o, name: n, bookmark: p.source_bookmark.clone() }
890
            }
891
            "changes" => ProposalSource::Changes { hashes: p.source_changes() },
892
            _ => ProposalSource::Bookmark { bookmark: p.source_bookmark.clone() },
893
        },
894
        changes: loaded
895
            .changes
896
            .iter()
897
            .map(|c| hub_api::ChangeSummary {
898
                hash: c.hash.clone(),
899
                message: if c.body.is_empty() { c.title.clone() } else { format!("{}\n\n{}", c.title, c.body) },
900
                author: hub_api::Author {
901
                    name: c.author.name.clone(),
902
                    email: c.author.email.clone(),
903
                    key: c.author.key.clone(),
904
                    account: c.author.account.clone(),
905
                },
906
                when_ms: c.when_ms,
907
                deps: c.deps.clone(),
908
                head: c.head,
909
                signature: match &c.signature {
910
                    view::SigView::Unsigned => hub_api::Signature::Unsigned,
911
                    view::SigView::Valid { key, sealed, revoked, .. } => {
912
                        hub_api::Signature::Valid { key: key.clone(), sealed: *sealed, revoked: *revoked }
913
                    }
914
                    view::SigView::Invalid(why) => hub_api::Signature::Invalid { reason: why.clone() },
915
                },
916
            })
917
            .collect(),
918
        projected_heads: loaded.heads.iter().map(|h| h.to_hex()).collect(),
919
        projected_state: Some(loaded.state.clone()),
920
        conflicted: loaded.conflicted,
921
        approvals: v.approvals.clone(),
922
        landable: p.is_open() && v.blockers.is_empty(),
923
        blockers: v.blockers.clone(),
924
        created_ms: p.created_ms,
925
        updated_ms: p.updated_ms,
926
        url: format!("{}/{owner}/{name}/proposal/{}", app.config.base_url(), p.number),
927
        repository_url: format!("{}/{owner}/{name}", app.config.base_url()),
928
        source_url,
929
    }
930
}
931
932
/// The line comment form's placement key, for templates.
933
pub fn key(path: &str, line: impl filters::Num) -> (String, usize) {
934
    (path.to_string(), line.as_u64() as usize)
935
}
936
937
#[allow(dead_code)]
938
fn _unused(_: &diff::Line, _: &ConflictView, _: &Role) {}