OXYGENHUB
◆ draft-ready oxygenhub / crates / hub / tests / api.rs
94.3 KiB · Rust · last changed GET /user/proposals?landable=true: the proposals the caller can land now (closes #311) 10 days ago source blame history raw
b64e2537 Andy McCall ↶ 1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use std::sync::{Arc, Mutex};
15
use tower::ServiceExt;
16
17
fn hermetic() {
18
    static ONCE: std::sync::Once = std::sync::Once::new();
19
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
20
    ONCE.call_once(|| {
21
        let d = tempfile::tempdir().unwrap();
22
        std::env::set_var("OXY_HOME", d.path());
23
        DIR.set(d).ok();
24
    });
25
}
26
27
fn write(root: &Path, rel: &str, content: &[u8]) {
28
    let p = root.join(rel);
29
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
30
    std::fs::write(p, content).unwrap();
31
}
32
33
struct Hub {
34
    app: Shared,
35
    base: String,
36
    _dir: tempfile::TempDir,
37
}
38
39
async fn hub() -> Hub {
40
    hermetic();
41
    let dir = tempfile::tempdir().unwrap();
42
    let mut config = Config::load(dir.path()).unwrap();
c8684d44 Andy McCall 43
    // The first account's setup code (oxygenhub#245).
44
    config.registration.setup_code = "test-setup".into();
b64e2537 Andy McCall ↶ 45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
9a777fec Andy McCall ↶ 50
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
51
    config.outbound.allow = vec!["http://127.0.0.1".into()];
b64e2537 Andy McCall ↶ 52
    let app = oxygenhub::build(config).await.unwrap();
53
    let router = oxygenhub::router(app.clone());
54
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
55
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
56
}
57
58
struct Res {
59
    status: StatusCode,
60
    body: String,
61
    cookie: Option<String>,
c7067c7b Andy McCall 62
    location: Option<String>,
b64e2537 Andy McCall ↶ 63
}
64
65
async fn call(
66
    app: &Shared,
67
    method: &str,
68
    path: &str,
69
    bearer: Option<&str>,
70
    cookie: Option<&str>,
71
    json: Option<&str>,
72
    form: Option<&str>,
73
) -> Res {
74
    let mut req = Request::builder().method(method).uri(path);
75
    if let Some(b) = bearer {
76
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
77
    }
78
    if let Some(c) = cookie {
79
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
80
    }
81
    let body = if let Some(j) = json {
82
        req = req.header(header::CONTENT_TYPE, "application/json");
83
        Body::from(j.to_string())
84
    } else if let Some(f) = form {
85
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
86
        Body::from(f.to_string())
87
    } else {
88
        Body::empty()
89
    };
90
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
91
    let status = res.status();
92
    let cookie = res
93
        .headers()
94
        .get(header::SET_COOKIE)
95
        .and_then(|v| v.to_str().ok())
96
        .and_then(|v| v.split(';').next())
97
        .and_then(|kv| kv.split_once('='))
98
        .map(|(_, v)| v.to_string());
c7067c7b Andy McCall 99
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
b64e2537 Andy McCall ↶ 100
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
c7067c7b Andy McCall 101
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
b64e2537 Andy McCall ↶ 102
}
103
c7067c7b Andy McCall 104
/// A repository settings form's answer (#278): a redirect to the page that
105
/// holds the form, followed.
106
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
107
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
108
    let to = r.location.expect("a redirect");
109
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
110
    call(app, "GET", &to, None, cookie, None, None).await
111
}
112
b64e2537 Andy McCall ↶ 113
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
114
    let r = call(app, method, path, bearer, None, json, None).await;
115
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
116
    (r.status, v)
117
}
118
119
fn csrf_of(page: &str) -> String {
120
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
121
    page[i..].split('"').next().unwrap().to_string()
122
}
123
124
/// A webhook receiver that records what it gets and fails the first time.
125
struct Receiver {
126
    url: String,
127
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
128
    fail_first: Arc<Mutex<bool>>,
129
}
130
131
async fn receiver() -> Receiver {
132
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
133
    let fail_first = Arc::new(Mutex::new(true));
134
    let (s2, f2) = (seen.clone(), fail_first.clone());
135
    let router = Router::new().route(
136
        "/hook",
137
        post(move |headers: header::HeaderMap, body: String| {
138
            let (s2, f2) = (s2.clone(), f2.clone());
139
            async move {
140
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
141
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
142
                let mut f = f2.lock().unwrap();
143
                if *f {
144
                    *f = false;
145
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
146
                }
147
                s2.lock().unwrap().push((event, sig, body));
148
                (StatusCode::OK, "ok")
149
            }
150
        }),
151
    );
152
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
153
    let port = listener.local_addr().unwrap().port();
154
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
155
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
156
}
157
158
#[tokio::test(flavor = "multi_thread")]
159
async fn api_webhooks_and_checks() {
160
    let h = hub().await;
161
    let app = &h.app;
162
    // Accounts and tokens through the pages.
c8684d44 Andy McCall 163
    let r = call(
164
        app,
165
        "POST",
166
        "/register",
167
        None,
168
        None,
169
        None,
170
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
171
    )
172
    .await;
b64e2537 Andy McCall ↶ 173
    let andy = r.cookie.unwrap();
c8684d44 Andy McCall 174
    let r = call(
175
        app,
176
        "POST",
177
        "/register",
178
        None,
179
        None,
180
        None,
181
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
182
    )
183
    .await;
b64e2537 Andy McCall ↶ 184
    let bob = r.cookie.unwrap();
185
    let mint = |cookie: String, scopes: &'static str| {
186
        let app = app.clone();
187
        async move {
188
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
189
            let csrf = csrf_of(&page.body);
190
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
191
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
192
        }
193
    };
194
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
195
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
196
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
197
198
    // Create a repository through the API; the read-only token cannot.
199
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
200
    assert_eq!(st, StatusCode::FORBIDDEN);
201
    let (st, v) = api(
202
        app,
203
        "POST",
204
        "/api/v1/repos",
205
        Some(&andy_admin),
206
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
207
    )
208
    .await;
209
    assert_eq!(st, StatusCode::CREATED, "{v}");
210
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
211
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
212
    assert_eq!(st, StatusCode::CONFLICT);
213
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
214
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
215
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
216
    assert_eq!(st, StatusCode::OK);
217
    assert_eq!(v["username"], "andy");
218
219
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
220
    let rx = receiver().await;
221
    let (st, v) = api(
222
        app,
223
        "POST",
224
        "/api/v1/repos/andy/demo/hooks",
225
        Some(&andy_admin),
226
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
227
    )
228
    .await;
229
    assert_eq!(st, StatusCode::CREATED, "{v}");
230
    let work = tempfile::tempdir().unwrap();
231
    let mut client = Repo::init(work.path()).unwrap();
232
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
233
    client.config.set("remote.origin.token", "site").unwrap();
234
    client.save_config().unwrap();
235
    write(work.path(), "a.txt", b"a\n");
236
    client.snapshot("t").unwrap();
237
    let base = client.commit("base", &[]).unwrap();
238
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
239
    // The worker retries with backoff; drive it directly for the retry.
240
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
241
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
242
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
243
    oxygenhub::hooks::deliver_due(app).await;
244
    let seen = rx.seen.lock().unwrap().clone();
245
    assert_eq!(seen.len(), 1, "{seen:?}");
246
    assert_eq!(seen[0].0, "push");
247
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
248
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
249
    assert_eq!(payload["repository"]["name"], "demo");
250
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
252
    assert_eq!(v.as_array().unwrap().len(), 1);
253
254
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
255
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
256
    assert_eq!(st, StatusCode::OK);
257
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
f28389bd Andy McCall ↶ 258
    // A revset in place of the whole history (`?r=`), under a budget; a
259
    // bad one is the caller's problem.
260
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
261
    assert_eq!(st, StatusCode::OK, "{v}");
262
    assert_eq!(v["total"].as_u64(), Some(1));
263
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
264
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
265
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
266
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
267
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
b64e2537 Andy McCall ↶ 268
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
269
    assert_eq!(v[0]["name"], "a.txt");
270
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
271
    assert_eq!(r.body, "a\n");
272
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
273
    assert_eq!(v[0]["change"], base.to_hex());
274
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
275
    assert_eq!(v["files"][0]["path"], "a.txt");
276
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
277
    assert!(v["policy"].is_null());
278
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
279
    assert_eq!(v[0]["reference"], "main");
280
281
    // Issues through the API: Bob opens one, comments, and closes it.
282
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
283
    assert_eq!(st, StatusCode::CREATED, "{v}");
284
    assert_eq!(v["number"], 1);
285
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
286
    assert_eq!(st, StatusCode::CREATED);
287
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
288
    assert_eq!(st, StatusCode::OK, "{v}");
289
    assert_eq!(v["state"], "closed");
290
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
291
    assert_eq!(v[0]["comments"], 1);
292
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
293
    assert_eq!(v[0]["number"], 1);
294
295
    // A proposal through the API, then a required check gates its landing.
296
    client.bookmark_create("feat", Some(&[base])).unwrap();
297
    client.bookmark_switch("feat", false).unwrap();
298
    write(work.path(), "b.txt", b"b\n");
3f02e5ea Andy McCall ↶ 299
    write(work.path(), "a.txt", b"a\nA\n");
b64e2537 Andy McCall ↶ 300
    client.snapshot("t").unwrap();
301
    let feat = client.commit("feat", &[]).unwrap();
302
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
303
    let (st, v) =
304
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
305
            .await;
306
    assert_eq!(st, StatusCode::CREATED, "{v}");
307
    assert_eq!(v["number"], 2);
308
    let state = v["projected_state"].as_str().unwrap().to_string();
309
    assert_eq!(v["landable"], true);
a0dd06b0 Andy McCall ↶ 310
    // A wiki takes no proposals, and says so rather than "no such
311
    // repository" (oxygenhub#128); a repository's that does not exist
312
    // still does not.
313
    let (st, v) =
314
        api(app, "POST", "/api/v1/repos/andy/demo.wiki/proposals", Some(&bob_rw), Some(r#"{"title":"W","target":"main","source":"p"}"#))
315
            .await;
316
    let detail = v["detail"].as_str().unwrap_or_default();
317
    assert!(st == StatusCode::NOT_FOUND && detail.contains("is the wiki of andy/demo") && detail.contains("push main"), "{v}");
318
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/nope.wiki/proposals", Some(&bob_rw), None).await;
319
    assert_eq!(v["detail"], "no such repository");
3f02e5ea Andy McCall ↶ 320
    // Its files, and each side's bytes, for editors' diff views.
321
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
322
    assert_eq!(st, StatusCode::OK, "{v}");
323
    let files: Vec<(String, String)> =
324
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
325
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
326
    assert_eq!(v[0]["added"], 1);
327
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
328
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
329
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
330
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
331
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
332
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
c0fac31d Andy McCall ↶ 333
    // An anchored comment comes back with its line in the projected state.
334
    let (st, v) = api(
335
        app,
336
        "POST",
337
        "/api/v1/repos/andy/demo/proposals/2/comments",
338
        Some(&bob_rw),
339
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
340
    )
341
    .await;
342
    assert_eq!(st, StatusCode::CREATED, "{v}");
343
    assert_eq!(v["line"], 2);
344
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
345
    assert_eq!(v[0]["path"], "a.txt");
346
    assert_eq!(v[0]["line"], 2, "{v}");
347
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
b64e2537 Andy McCall ↶ 348
    // Require the "build" check.
349
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
350
    let csrf = csrf_of(&settings.body);
c7067c7b Andy McCall 351
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
352
        .await;
353
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
b64e2537 Andy McCall ↶ 354
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
355
    assert_eq!(v["landable"], false);
356
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
5d818ec7 Andy McCall ↶ 357
    // Nothing to land yet for its owner (#311), and the list is only there when asked for.
358
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
359
    assert!(v.get("landable").is_none(), "{v}");
b64e2537 Andy McCall ↶ 360
    // A checker reports on the projected state: first running, then passed; the page streams it.
361
    let (st, v) = api(
362
        app,
363
        "POST",
364
        "/api/v1/repos/andy/demo/checks",
365
        Some(&andy_ro),
366
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
367
    )
368
    .await;
369
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
33d98147 Andy McCall 370
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
b64e2537 Andy McCall ↶ 371
    let (st, v) = api(
372
        app,
373
        "POST",
374
        "/api/v1/repos/andy/demo/checks",
375
        Some(&bob_rw),
376
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
377
    )
378
    .await;
379
    assert_eq!(st, StatusCode::CREATED, "{v}");
33d98147 Andy McCall 380
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
b64e2537 Andy McCall ↶ 381
    assert_eq!(ev.kind, "check");
382
    assert_eq!(ev.check.unwrap().name, "build");
383
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
384
    assert_eq!(v[0]["status"], "passed");
385
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
386
    assert_eq!(v["landable"], true, "{v}");
5d818ec7 Andy McCall ↶ 387
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
388
    assert_eq!((v["landable"][0]["repository"].as_str(), v["landable"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
389
    assert!(api(app, "GET", "/api/v1/user/proposals", Some(&andy_ro), None).await.1.get("landable").is_none(), "only when asked");
b64e2537 Andy McCall ↶ 390
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
391
    assert!(page.body.contains("42 tests"), "{}", page.body);
a2ef53c5 Andy McCall ↶ 392
    // A summary carrying whole hashes shows them by their ends, so the
393
    // Checks panel keeps its width (a pin mismatch's message, 2026-10-16).
394
    let (a, b) = (
395
        "6ea27b1d35037a4e4d0f6208b1ca99630df40888bd21fd55c8f8aba51dcdd7cb",
396
        "f7495d7689da3ac5b68684f26fce28b91ce55e6b8131c5e484ad2aab90c3020f",
397
    );
398
    let summary = format!("could not run: flow-init has BLAKE3 {a}, but {b} is pinned");
399
    let body = serde_json::json!({ "state": state, "name": "lint", "status": "failed", "summary": summary }).to_string();
400
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/checks", Some(&bob_rw), Some(&body)).await;
401
    assert_eq!(st, StatusCode::CREATED, "{v}");
402
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await.body;
403
    assert!(page.contains("6ea27b1d…1dcdd7cb") && page.contains(&format!("data-full=\"{a}\"")), "{page}");
404
    assert!(!page.contains(&format!("BLAKE3 {a},")), "never the whole hash inline");
405
    // The Checks section refreshes itself; nothing reloads the whole page.
406
    assert!(!page.contains("location.reload()"), "no full reload on a check");
407
    let part = call(app, "GET", "/andy/demo/proposal/2?fragment=checks", None, Some(&andy), None, None).await.body;
408
    assert!(part.contains("<h3>Checks</h3>") && part.contains("6ea27b1d…1dcdd7cb") && !part.contains("<html"), "{part}");
b64e2537 Andy McCall ↶ 409
    // The check and the proposal reached the webhook too.
410
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
411
    oxygenhub::hooks::deliver_due(app).await;
412
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
413
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
414
    let _ = feat;
415
    let _ = rx.fail_first;
42a0ba4b Andy McCall ↶ 416
417
    // The inbox through the API: count, list, mark one read, mark all read.
418
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
419
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
420
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
eb0c44a9 Andy McCall ↶ 421
    oxygenhub::db::notify::add(
422
        &app.db,
423
        oxygenhub::db::notify::New {
424
            account_id: bob_id,
ecac6e8d Andy McCall ↶ 425
            repo_id: Some(oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id),
eb0c44a9 Andy McCall ↶ 426
            reason: oxygenhub::db::notify::Reason::Participating,
ecac6e8d Andy McCall ↶ 427
            kind: "issue.opened",
eb0c44a9 Andy McCall ↶ 428
            title: "andy/demo#1: Bug",
429
            url: "/andy/demo/issue/1",
430
            actor: "andy",
431
        },
432
    )
433
    .await
434
    .unwrap();
435
    oxygenhub::db::notify::add(
436
        &app.db,
437
        oxygenhub::db::notify::New {
438
            account_id: bob_id,
439
            repo_id: None,
440
            reason: oxygenhub::db::notify::Reason::Participating,
441
            kind: "review",
442
            title: "andy/demo#2: Feat",
443
            url: "/andy/demo/proposal/2",
444
            actor: "andy",
445
        },
446
    )
447
    .await
448
    .unwrap();
42a0ba4b Andy McCall ↶ 449
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
450
    assert_eq!(st, StatusCode::OK, "{v}");
451
    assert_eq!(v["unread"], 2);
452
    assert_eq!(v["items"][0]["read"], false);
453
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
ecac6e8d Andy McCall ↶ 454
    // Its repository, why, its thread and the kind's label (#305).
455
    let bug = v["items"].as_array().unwrap().iter().find(|n| n["title"] == "andy/demo#1: Bug").unwrap();
456
    assert_eq!(
457
        (bug["repository"].as_str(), bug["reason"].as_str(), bug["label"].as_str()),
458
        (Some("andy/demo"), Some("participating"), Some("🐛 New Issue")),
459
        "{bug}"
460
    );
461
    assert_eq!(bug["thread"].as_str(), Some(format!("{}/andy/demo/issue/1", h.base).as_str()));
42a0ba4b Andy McCall ↶ 462
    let first = v["items"][0]["id"].as_i64().unwrap();
463
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
464
    assert_eq!(st, StatusCode::NO_CONTENT);
465
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
466
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
467
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
468
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
469
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
ecac6e8d Andy McCall ↶ 470
    // No token at all is 401, so a client knows to sign in (#303).
471
    assert_eq!(api(app, "GET", "/api/v1/notifications", None, None).await.0, StatusCode::UNAUTHORIZED);
472
    assert_eq!(api(app, "GET", "/api/v1/user", None, None).await.0, StatusCode::UNAUTHORIZED);
0b20f1ec Andy McCall ↶ 473
cc1cd197 Andy McCall ↶ 474
    // Review requests: the author asks andy; andy is told, reviews, and the
475
    // request is answered; the author hears of the review.
476
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
ecac6e8d Andy McCall ↶ 477
    let (st, orgs) = api(app, "GET", "/api/v1/user/orgs", Some(&andy_user), None).await;
478
    assert!(st == StatusCode::OK && orgs.is_array(), "the caller's organisations (#302): {orgs}");
cc1cd197 Andy McCall ↶ 479
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
480
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
481
        .await
482
        .unwrap();
483
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
484
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
485
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
486
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
487
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
488
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
489
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
490
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
491
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
492
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
493
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
494
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
495
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
496
    let (st, _) =
497
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
498
    assert_eq!(st, StatusCode::CREATED);
499
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
500
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
501
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
502
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
503
    // Asking again and withdrawing it.
504
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
505
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
506
    assert_eq!(st, StatusCode::NO_CONTENT);
507
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
508
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
8e96499f Andy McCall ↶ 509
    // oxygenhub#84: the page's menu sets who is asked, all at once.
510
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
511
    assert!(
512
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
513
        "the reviewers menu lists andy"
514
    );
515
    let csrf = csrf_of(&page.body);
516
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
517
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
518
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
519
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
520
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
521
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
522
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
cc1cd197 Andy McCall ↶ 523
0b20f1ec Andy McCall ↶ 524
    // A source bookmark with `/` in its name, as a feature/N-name workflow
525
    // makes them: by name, and as this repository's owner/name:bookmark.
526
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
527
        client.bookmark_create(b, Some(&[base])).unwrap();
528
        client.bookmark_switch(b, false).unwrap();
529
        write(work.path(), file, b"c\n");
530
        client.snapshot("t").unwrap();
531
        client.commit(b, &[]).unwrap();
532
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
533
    }
534
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
535
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
536
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
537
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
538
        let n = v["number"].as_i64().unwrap();
539
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
540
        assert_eq!(page.status, StatusCode::OK);
541
        assert!(page.body.contains("feature/"), "the page names its source");
542
    }
543
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
544
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
545
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
739a763a Andy McCall ↶ 546
547
    // oxygenhub#76: a proposal's title and description are edited through
548
    // the API by its author or a maintainer; what is not given stays.
549
    let edit = |token: &str, number: i64, body: &str| {
550
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
551
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
552
    };
553
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
554
    assert_eq!(st, StatusCode::OK, "{v}");
555
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
556
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
557
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
558
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
559
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
560
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
561
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
562
    let (st, v) = api(
563
        app,
564
        "POST",
565
        "/api/v1/repos/andy/demo/proposals",
566
        Some(&andy_pw),
567
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
568
    )
569
    .await;
570
    assert_eq!(st, StatusCode::CREATED, "{v}");
571
    let n = v["number"].as_i64().unwrap();
572
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
573
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
2291f8cc Andy McCall ↶ 574
575
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
576
    // before anything changes, shown in its JSON.
577
    for l in ["ui", "flow"] {
578
        let body = format!(r#"{{"name":"{l}"}}"#);
579
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
580
    }
581
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
582
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
583
    assert_eq!(st, StatusCode::OK, "{v}");
584
    let names = |v: &serde_json::Value| -> Vec<String> {
585
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
586
    };
587
    assert_eq!(names(&v), ["flow", "ui"]);
588
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
589
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
590
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
591
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
592
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
593
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
594
    assert_eq!(names(&v), ["flow"]);
595
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
b64e2537 Andy McCall ↶ 596
}
76f262e1 Andy McCall ↶ 597
598
#[tokio::test(flavor = "multi_thread")]
599
async fn api_issue_triage_and_labels() {
600
    let h = hub().await;
601
    let app = &h.app;
c8684d44 Andy McCall 602
    let andy = call(
603
        app,
604
        "POST",
605
        "/register",
606
        None,
607
        None,
608
        None,
609
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
610
    )
611
    .await
612
    .cookie
613
    .unwrap();
614
    let bob = call(
615
        app,
616
        "POST",
617
        "/register",
618
        None,
619
        None,
620
        None,
621
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
622
    )
623
    .await
624
    .cookie
625
    .unwrap();
76f262e1 Andy McCall ↶ 626
    let mint = |cookie: String, scopes: &'static str| {
627
        let app = app.clone();
628
        async move {
629
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
630
            let csrf = csrf_of(&page.body);
631
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
632
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
633
        }
634
    };
635
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
636
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
637
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
638
    assert_eq!(st, StatusCode::CREATED);
639
640
    // Labels through the API; bad colours and non-triage callers are refused.
641
    let (st, v) = api(
642
        app,
643
        "POST",
644
        "/api/v1/repos/andy/demo/labels",
645
        Some(&andy_t),
646
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
647
    )
648
    .await;
649
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
650
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
651
    assert_eq!(
652
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
653
        StatusCode::BAD_REQUEST
654
    );
655
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
656
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
657
    assert_eq!(labels.as_array().unwrap().len(), 2);
5ea4872f Andy McCall ↶ 658
    // oxygenhub#91: milestones over the API, for triage.
659
    let (st, m) = api(
660
        app,
661
        "POST",
662
        "/api/v1/repos/andy/demo/milestones",
663
        Some(&andy_t),
664
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
665
    )
666
    .await;
667
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
668
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
669
    assert_eq!(
670
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
671
        StatusCode::BAD_REQUEST
672
    );
673
    assert_eq!(
674
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
675
        StatusCode::FORBIDDEN
676
    );
677
    let (st, m) =
678
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
679
            .await;
680
    assert_eq!(
681
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
682
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
683
        "{m}"
684
    );
685
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
686
    assert_eq!(
687
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
688
        StatusCode::NOT_FOUND,
689
        "renamed"
690
    );
691
    assert_eq!(
692
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
693
        StatusCode::BAD_REQUEST
694
    );
695
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
696
    assert_eq!(list.as_array().unwrap().len(), 1);
76f262e1 Andy McCall ↶ 697
698
    // An issue created with its labels and assignee in one call.
699
    let (st, v) = api(
700
        app,
701
        "POST",
702
        "/api/v1/repos/andy/demo/issues",
703
        Some(&andy_t),
704
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
705
    )
706
    .await;
707
    assert_eq!(st, StatusCode::CREATED, "{v}");
708
    assert_eq!(v["labels"][0]["name"], "bug");
709
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
710
    let n = v["number"].as_i64().unwrap();
711
    // Unknown names are refused before anything is created.
712
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
713
    assert_eq!(st, StatusCode::BAD_REQUEST);
714
    assert!(v["detail"].as_str().unwrap().contains("no label"));
715
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
716
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
717
    // Without triage, labels cannot be set, but a plain issue can be opened.
718
    assert_eq!(
719
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
720
        StatusCode::FORBIDDEN
721
    );
722
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
723
    assert_eq!(st, StatusCode::CREATED);
724
    let bob_n = bobs["number"].as_i64().unwrap();
725
726
    // PATCH: the whole label set, assignees and milestone, with events.
727
    let (st, v) =
728
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
729
            .await;
730
    assert_eq!(st, StatusCode::OK, "{v}");
731
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
732
    assert_eq!(v["assignees"], serde_json::json!([]));
733
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
734
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
735
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
736
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
737
    // The author edits their own title; others cannot; nobody but triage sets labels.
738
    let (st, v) =
739
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
740
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
741
    assert_eq!(
742
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
743
        StatusCode::FORBIDDEN
744
    );
745
    assert_eq!(
746
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
747
        StatusCode::FORBIDDEN
748
    );
749
    assert_eq!(
750
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
751
        StatusCode::BAD_REQUEST
752
    );
753
754
    // Deleting a label takes it off the issues.
755
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
756
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
757
    assert_eq!(v["labels"], serde_json::json!([]));
758
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
759
}
9756c67d Andy McCall ↶ 760
761
#[tokio::test(flavor = "multi_thread")]
762
async fn webhook_formats_editing_and_web_issue_events() {
763
    let h = hub().await;
764
    let app = &h.app;
c8684d44 Andy McCall 765
    let andy = call(
766
        app,
767
        "POST",
768
        "/register",
769
        None,
770
        None,
771
        None,
772
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
773
    )
774
    .await
775
    .cookie
776
    .unwrap();
9756c67d Andy McCall ↶ 777
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
778
    let r = call(
779
        app,
780
        "POST",
781
        "/settings/tokens",
782
        None,
783
        Some(&andy),
784
        None,
785
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
786
    )
787
    .await;
788
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
789
    assert_eq!(
790
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
791
        StatusCode::CREATED
792
    );
793
    let rx = receiver().await;
794
    *rx.fail_first.lock().unwrap() = false;
795
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
796
    let csrf = csrf_of(&settings);
797
    let form = |f: String| {
798
        let andy = andy.clone();
c7067c7b Andy McCall 799
        async move {
800
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
801
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
802
        }
9756c67d Andy McCall ↶ 803
    };
804
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
805
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
806
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
c9893553 Andy McCall ↶ 807
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
808
    {
809
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
810
        let before: i64 =
3b1bc27f Andy McCall 811
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 812
        for i in 0..MAX_WAITING {
813
            sqlx::query(
3b1bc27f Andy McCall 814
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
c9893553 Andy McCall ↶ 815
            )
816
            .bind(hook.id)
817
            .bind(format!("flood-{i}"))
818
            .execute(&app.db)
819
            .await
820
            .unwrap();
821
        }
822
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
823
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
824
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
825
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
826
        let after: i64 =
3b1bc27f Andy McCall 827
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 828
        assert_eq!(before, after);
829
    }
9756c67d Andy McCall ↶ 830
    assert_eq!(hook.format, "discord");
831
    // Ping arrives as a Discord message.
832
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
833
    let mut got = String::new();
834
    for _ in 0..100 {
835
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
836
            got = body.clone();
837
        }
838
        if !got.is_empty() {
839
            break;
840
        }
841
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
842
    }
843
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
844
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
845
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
c7067c7b Andy McCall 846
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
9756c67d Andy McCall ↶ 847
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
848
849
    // Editing: a blank URL and secret keep theirs; format, events and active change.
850
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
851
        .await
852
        .contains("Webhook saved"));
853
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
854
    assert_eq!(
855
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
856
        (rx.url.as_str(), "issue", "oxygenhub", true)
857
    );
858
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
859
860
    // An issue opened on the web now reaches the hook, as the signed envelope.
861
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
862
    call(
863
        app,
864
        "POST",
865
        "/andy/demo/issues/new",
866
        None,
867
        Some(&andy),
868
        None,
869
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
870
    )
871
    .await;
872
    let mut envelope = None;
873
    for _ in 0..100 {
874
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
875
        if envelope.is_some() {
876
            break;
877
        }
878
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
879
    }
880
    let (_, sig, body) = envelope.expect("issue.opened delivered");
881
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
882
    assert_eq!(v["data"]["issue"]["title"], "From the web");
883
    assert!(sig.starts_with("blake3-keyed="));
884
    // A disabled hook through the edit form (no active box).
885
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
886
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
887
}
ef20fdc1 Andy McCall ↶ 888
889
#[tokio::test(flavor = "multi_thread")]
890
async fn api_projects() {
891
    let h = hub().await;
892
    let app = &h.app;
c8684d44 Andy McCall 893
    let andy = call(
894
        app,
895
        "POST",
896
        "/register",
897
        None,
898
        None,
899
        None,
900
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
901
    )
902
    .await
903
    .cookie
904
    .unwrap();
905
    let bob = call(
906
        app,
907
        "POST",
908
        "/register",
909
        None,
910
        None,
911
        None,
912
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
913
    )
914
    .await
915
    .cookie
916
    .unwrap();
ef20fdc1 Andy McCall ↶ 917
    let mint = |cookie: String, scopes: &'static str| {
918
        let app = app.clone();
919
        async move {
920
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
921
            let csrf = csrf_of(&page.body);
922
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
923
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
924
        }
925
    };
926
    let a = mint(andy, "scopes=repo%3Aadmin").await;
927
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
928
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
929
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
930
ecac6e8d Andy McCall ↶ 931
    // The caller's own repositories, a page at a time (#302); bob has none.
932
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"zeta","visibility":"private"}"#)).await;
933
    let names =
934
        |v: &serde_json::Value| -> Vec<String> { v.as_array().unwrap().iter().map(|r| r["name"].as_str().unwrap().to_string()).collect() };
935
    let (st, v) = api(app, "GET", "/api/v1/user/repos", Some(&a), None).await;
936
    assert_eq!((st, names(&v)), (StatusCode::OK, vec!["demo".to_string(), "zeta".to_string()]), "{v}");
937
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?limit=1", Some(&a), None).await.1), ["demo"]);
938
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?after=andy/demo", Some(&a), None).await.1), ["zeta"]);
939
    assert!(names(&api(app, "GET", "/api/v1/user/repos", Some(&b), None).await.1).is_empty(), "not bob's");
940
    assert_eq!(api(app, "GET", "/api/v1/user/repos?affiliation=friend", Some(&a), None).await.0, StatusCode::BAD_REQUEST);
941
    assert_eq!(api(app, "GET", "/api/v1/user/repos", None, None).await.0, StatusCode::UNAUTHORIZED);
f4e13830 Andy McCall ↶ 942
    // The proposals to act on, as the dashboard lists them: bob's in andy's
943
    // repository is andy's to review and bob's own.
944
    let demo = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
945
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
946
    oxygenhub::db::proposals::create(
947
        &app.db,
948
        oxygenhub::db::proposals::NewProposal {
949
            repo_id: demo.id,
950
            title: "Faster startup",
951
            body: "",
952
            author_id: Some(bob_id),
953
            author: "bob",
954
            draft: false,
955
            target: "main",
956
            source_kind: "bookmark",
957
            source_repo_id: Some(demo.id),
958
            source_bookmark: "fast",
959
            source_changes: "",
960
        },
961
    )
962
    .await
963
    .unwrap();
964
    let (st, v) = api(app, "GET", "/api/v1/user/proposals", Some(&a), None).await;
965
    assert_eq!(st, StatusCode::OK, "{v}");
966
    assert_eq!((v["review"][0]["repository"].as_str(), v["review"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
967
    assert_eq!(v["review"][0]["state"], "open");
968
    assert!(v["review"][0]["url"].as_str().unwrap().ends_with("/andy/demo/proposal/2"));
969
    assert_eq!(v["authored"].as_array().map(Vec::len), Some(0));
970
    let (_, v) = api(app, "GET", "/api/v1/user/proposals", Some(&b), None).await;
971
    assert_eq!((v["review"].as_array().map(Vec::len), v["authored"][0]["title"].as_str()), (Some(0), Some("Faster startup")), "{v}");
972
    assert_eq!(api(app, "GET", "/api/v1/user/proposals", None, None).await.0, StatusCode::UNAUTHORIZED);
973
ecac6e8d Andy McCall ↶ 974
    // Organisations need user:read, which this token lacks.
975
    assert_eq!(api(app, "GET", "/api/v1/user/orgs", Some(&a), None).await.0, StatusCode::FORBIDDEN);
976
ef20fdc1 Andy McCall ↶ 977
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
978
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
979
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
980
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
981
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
982
983
    // Cards by reference, into a column by name, and a note into the first column.
984
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
985
    assert_eq!(st, StatusCode::CREATED, "{card}");
986
    assert_eq!(
987
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
988
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
989
    );
6a306cd0 Andy McCall ↶ 990
    assert_eq!((card["labels"].as_array().map(Vec::len), card["assignees"].as_array().map(Vec::len)), (Some(0), Some(0)), "{card}");
ef20fdc1 Andy McCall ↶ 991
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
992
    assert_eq!(st, StatusCode::BAD_REQUEST);
993
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
efb51b39 Andy McCall ↶ 994
    // The form the board shows its cards in is taken too (#118); another owner's is refused.
995
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"andy/demo#1"}"#)).await;
996
    assert!(v["detail"].as_str().unwrap().contains("already on this project"), "{v}");
997
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"other/demo#1"}"#)).await;
998
    assert!(v["detail"].as_str().unwrap().contains("only andy's"), "{v}");
ef20fdc1 Andy McCall ↶ 999
    assert_eq!(
1000
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
1001
        StatusCode::BAD_REQUEST
1002
    );
1003
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
1004
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
1005
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
1006
1007
    // Move and read the board.
1008
    let id = card["id"].as_i64().unwrap();
1009
    assert_eq!(
1010
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
1011
        StatusCode::NO_CONTENT
1012
    );
1013
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1014
    let names: Vec<(&str, usize)> =
1015
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1016
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
1017
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
17a3a84b Andy McCall ↶ 1018
    // The cards by column (#115), and a wrong method answers with a body.
1019
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
1020
    assert_eq!(st, StatusCode::OK);
1021
    assert_eq!(cols, board["columns"]);
1022
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
1023
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
1024
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
ef20fdc1 Andy McCall ↶ 1025
456f4197 Andy McCall ↶ 1026
    // A column's cards at once (#289): with exceptions, a state filter and
1027
    // a dry run; one audit entry.
1028
    for t in ["Second", "Third"] {
1029
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(&format!(r#"{{"title":"{t}"}}"#))).await;
1030
    }
1031
    for n in [2, 3] {
1032
        let body = format!(r#"{{"reference":"demo#{n}","column":"Doing"}}"#);
1033
        assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(&body)).await.0, StatusCode::CREATED);
1034
    }
1035
    let bulk = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&a), Some(body));
1036
    let refs = |v: &serde_json::Value, k: &str| -> Vec<String> {
1037
        v[k].as_array().unwrap().iter().map(|c| c["reference"].as_str().unwrap().to_string()).collect()
1038
    };
1039
    let (st, v) = bulk(r##"{"from":"Doing","column":"Done","except":["#2"],"dry_run":true}"##).await;
1040
    assert_eq!(st, StatusCode::OK, "{v}");
1041
    assert_eq!((refs(&v, "moved"), refs(&v, "kept")), (vec!["andy/demo#3".to_string()], vec!["andy/demo#2".to_string()]));
1042
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1043
    assert_eq!(board["columns"][1]["cards"].as_array().unwrap().len(), 2, "a dry run moves nothing");
1044
    let (_, v) = bulk(r#"{"from":"Doing","column":"Done","state":["closed"]}"#).await;
1045
    assert!(refs(&v, "moved").is_empty(), "both are open: {v}");
1046
    let (_, v) = bulk(r#"{"from":"doing","column":"done","except":["demo#2"]}"#).await;
1047
    assert_eq!(refs(&v, "moved"), ["andy/demo#3"]);
1048
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1049
    let names: Vec<(&str, usize)> =
1050
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1051
    assert_eq!(names, [("Backlog", 1), ("Doing", 1), ("Done", 2)]);
1052
    let audited: i64 =
1053
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_moved'").fetch_one(&app.db).await.unwrap();
1054
    assert_eq!(audited, 1, "the dry run and the empty move are not audited");
1055
    assert_eq!(bulk(r#"{"from":"Done","column":"Done"}"#).await.0, StatusCode::BAD_REQUEST);
1056
    assert_eq!(
1057
        api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&b), Some(r#"{"from":"Doing","column":"Done"}"#)).await.0,
1058
        StatusCode::FORBIDDEN
1059
    );
1060
439ecd87 Andy McCall ↶ 1061
    // Archive (#293): Done's cards there more than a week (#3, made old),
1062
    // listed with ?archived=true, restored once.
1063
    sqlx::query("UPDATE project_cards SET moved_ms = 0 WHERE number = 3").execute(&app.db).await.unwrap();
1064
    let archive = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/archive", Some(&a), Some(body));
1065
    let (st, v) = archive(r#"{"from":"Done","older_days":7,"dry_run":true}"#).await;
1066
    assert_eq!((st, refs(&v, "archived")), (StatusCode::OK, vec!["andy/demo#3".to_string()]), "{v}");
1067
    assert!(v["archived"][0].get("archived_ms").is_none(), "a dry run archives nothing: {v}");
1068
    let (_, v) = archive(r#"{"from":"Done","older_days":7}"#).await;
1069
    assert_eq!((refs(&v, "archived"), refs(&v, "kept").len()), (vec!["andy/demo#3".to_string()], 1), "{v}");
1070
    assert!(v["archived"][0]["archived_ms"].as_i64().is_some());
1071
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1072
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 1, "off the board: {board}");
1073
    let (st, archived) = api(app, "GET", "/api/v1/projects/andy/1/cards?archived=true", None, None).await;
1074
    assert_eq!((st, archived[2]["cards"][0]["reference"].as_str()), (StatusCode::OK, Some("andy/demo#3")), "{archived}");
1075
    let card = archived[2]["cards"][0]["id"].as_i64().unwrap();
1076
    let restore = format!("/api/v1/projects/andy/1/cards/{card}/restore");
1077
    assert_eq!(api(app, "POST", &restore, Some(&b), None).await.0, StatusCode::FORBIDDEN);
1078
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NO_CONTENT);
1079
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NOT_FOUND, "not archived now");
1080
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1081
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 2);
1082
    assert_eq!(archive(r#"{"from":"Done","older_days":-1}"#).await.0, StatusCode::BAD_REQUEST);
1083
    let audited: i64 =
1084
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_archived'").fetch_one(&app.db).await.unwrap();
1085
    assert_eq!(audited, 1);
1086
ef20fdc1 Andy McCall ↶ 1087
    // Private: hidden from others; closed: read-only; then remove a card.
1088
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
1089
    assert_eq!(edited["public"], false);
1090
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
1091
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
1092
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
1093
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
1094
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
1095
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
1096
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
1097
}
961c10be Andy McCall ↶ 1098
1099
#[tokio::test(flavor = "multi_thread")]
1100
async fn api_required_checks() {
1101
    let h = hub().await;
1102
    let app = &h.app;
c8684d44 Andy McCall 1103
    let andy = call(
1104
        app,
1105
        "POST",
1106
        "/register",
1107
        None,
1108
        None,
1109
        None,
1110
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1111
    )
1112
    .await
1113
    .cookie
1114
    .unwrap();
961c10be Andy McCall ↶ 1115
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1116
    let csrf = csrf_of(&page.body);
1117
    let mint = |scopes: &'static str| {
1118
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1119
        async move {
1120
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1121
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1122
        }
1123
    };
1124
    let admin = mint("scopes=repo%3Aadmin").await;
1125
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1126
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1127
1128
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1129
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1130
    let (st, v) = api(
1131
        app,
1132
        "PUT",
1133
        "/api/v1/repos/andy/demo/checks/required",
1134
        Some(&admin),
1135
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1136
    )
1137
    .await;
1138
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1139
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1140
    assert_eq!(
1141
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1142
        serde_json::json!(["flow/fmt", "flow/test"])
1143
    );
1144
    assert_eq!(
1145
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1146
        StatusCode::FORBIDDEN,
1147
        "repo:admin only"
1148
    );
1149
    assert_eq!(
1150
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1151
        StatusCode::BAD_REQUEST
1152
    );
1153
    // The settings page shows the same list.
c7067c7b Andy McCall 1154
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
961c10be Andy McCall ↶ 1155
}
9008bf6c Andy McCall ↶ 1156
1157
/// OxygenFlow per repository: site administrators turn it on or off in
1158
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1159
#[tokio::test(flavor = "multi_thread")]
1160
async fn flow_is_switched_per_repository_by_site_admins() {
1161
    let h = hub().await;
1162
    let app = &h.app;
c8684d44 Andy McCall 1163
    let andy = call(
1164
        app,
1165
        "POST",
1166
        "/register",
1167
        None,
1168
        None,
1169
        None,
1170
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1171
    )
1172
    .await
1173
    .cookie
1174
    .unwrap();
9008bf6c Andy McCall ↶ 1175
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1176
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1177
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1178
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1179
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
c7067c7b Andy McCall 1180
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
9008bf6c Andy McCall ↶ 1181
1182
    let set = |value: &'static str| {
1183
        let (app, andy) = (app.clone(), andy.clone());
1184
        async move {
c7067c7b Andy McCall 1185
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1186
            let r = call(
9008bf6c Andy McCall ↶ 1187
                &app,
1188
                "POST",
1189
                "/andy/demo/settings/flow",
1190
                None,
1191
                Some(&andy),
1192
                None,
1193
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1194
            )
c7067c7b Andy McCall 1195
            .await;
1196
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
9008bf6c Andy McCall ↶ 1197
        }
1198
    };
1199
    // A repository admin who is not a site admin sees the state but cannot change it.
1200
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1201
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
c7067c7b Andy McCall 1202
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
9008bf6c Andy McCall ↶ 1203
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1204
    let r = set("on").await;
1205
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1206
    assert_eq!(row().await.flow, "");
1207
1208
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1209
    let r = set("on").await;
1210
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1211
    assert_eq!(row().await.flow, "on");
1212
    assert!(oxygenhub::flow::enabled(app, &row().await));
1213
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1214
    set("off").await;
1215
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1216
    set("default").await;
1217
    assert_eq!(row().await.flow, "");
1870e4fa Andy McCall ↶ 1218
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
9008bf6c Andy McCall ↶ 1219
}
e271a37b Andy McCall ↶ 1220
1221
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1222
/// button, never the repository's default bookmark as the hub sets it.
1223
#[tokio::test(flavor = "multi_thread")]
1224
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1225
    let h = hub().await;
1226
    let app = &h.app;
c8684d44 Andy McCall 1227
    let andy = call(
1228
        app,
1229
        "POST",
1230
        "/register",
1231
        None,
1232
        None,
1233
        None,
1234
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1235
    )
1236
    .await
1237
    .cookie
1238
    .unwrap();
e271a37b Andy McCall ↶ 1239
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1240
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1241
    let url = format!("{}/andy/demo", h.base);
1242
    let work = tempfile::tempdir().unwrap();
1243
    let (w, u) = (work.path().to_path_buf(), url.clone());
1244
    let client = tokio::task::spawn_blocking(move || {
1245
        let mut c = Repo::init(&w).unwrap();
1246
        c.config.set("remote.origin.url", &u).unwrap();
1247
        c.config.set("remote.origin.token", "site").unwrap();
1248
        c.save_config().unwrap();
1249
        write(&w, "a.txt", b"a\n");
1250
        c.commit("a", &[]).unwrap();
1251
        assert!(c.push("origin", false).unwrap()[0].ok);
1252
        for b in ["develop", "feature/x", "stray"] {
1253
            c.bookmark_create(b, None).unwrap();
1254
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1255
        }
1256
        // A pushed deletion.
1257
        let r = c.push_delete("origin", "feature/x").unwrap();
1258
        assert!(r[0].ok, "{r:?}");
1259
        c
1260
    })
1261
    .await
1262
    .unwrap();
1263
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1264
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1265
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1266
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1267
    assert!(!anon.body.contains("/bookmarks/delete"));
1268
1269
    // The hub's default, not the repository's config, is protected: make
1270
    // develop the default, then main can go and develop cannot.
1271
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1272
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1273
    let client = tokio::task::spawn_blocking(move || {
1274
        let r = client.push_delete("origin", "develop").unwrap();
1275
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1276
        let r = client.push_delete("origin", "main").unwrap();
1277
        assert!(r[0].ok, "{r:?}");
1278
        client
1279
    })
1280
    .await
1281
    .unwrap();
1282
    drop(client);
1283
1284
    // On the web: a writer deletes stray; the default is refused.
1285
    let form = |b: &'static str| {
1286
        let (app, andy) = (app.clone(), andy.clone());
1287
        async move {
1288
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1289
            call(
1290
                &app,
1291
                "POST",
1292
                "/andy/demo/bookmarks/delete",
1293
                None,
1294
                Some(&andy),
1295
                None,
1296
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1297
            )
1298
            .await
1299
        }
1300
    };
1301
    let r = form("stray").await;
1302
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1303
    assert!(!r.body.contains(">stray<"));
1304
    let r = form("develop").await;
1305
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1306
    let r = form("nope").await;
1307
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1308
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1309
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1310
    // Anonymous visitors cannot.
1311
    assert_ne!(
1312
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1313
        StatusCode::OK
1314
    );
1315
}
760a7dd3 Andy McCall ↶ 1316
1317
/// A change signed by a key no account has linked says so, on its page
1318
/// and in the API (feedback 14).
1319
#[tokio::test(flavor = "multi_thread")]
1320
async fn changes_signed_by_unlinked_keys_say_so() {
1321
    let h = hub().await;
1322
    let app = &h.app;
c8684d44 Andy McCall 1323
    let andy = call(
1324
        app,
1325
        "POST",
1326
        "/register",
1327
        None,
1328
        None,
1329
        None,
1330
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1331
    )
1332
    .await
1333
    .cookie
1334
    .unwrap();
760a7dd3 Andy McCall ↶ 1335
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1336
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1337
    let url = format!("{}/andy/demo", h.base);
1338
    let work = tempfile::tempdir().unwrap();
1339
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1340
    let hash = tokio::task::spawn_blocking(move || {
1341
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1342
        c.config.set("remote.origin.url", &u).unwrap();
1343
        c.config.set("remote.origin.token", "site").unwrap();
1344
        c.save_config().unwrap();
1345
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1346
        write(&w.join("r"), "a.txt", b"a\n");
1347
        let h = c.commit("signed by Ada", &[]).unwrap();
1348
        assert!(c.push("origin", false).unwrap()[0].ok);
1349
        h.to_hex()
1350
    })
1351
    .await
1352
    .unwrap();
1353
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1354
    assert_eq!(st, StatusCode::OK, "{v}");
1355
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1356
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1357
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1358
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1359
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1360
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1361
}
65be9f9c Andy McCall ↶ 1362
1363
/// Function history (hub spec §6.6): the file page lists a file's
1364
/// functions, and a function's page lists exactly the changes to its lines.
1365
#[tokio::test(flavor = "multi_thread")]
1366
async fn a_function_has_its_own_history() {
1367
    let h = hub().await;
1368
    let app = &h.app;
c8684d44 Andy McCall 1369
    let andy = call(
1370
        app,
1371
        "POST",
1372
        "/register",
1373
        None,
1374
        None,
1375
        None,
1376
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1377
    )
1378
    .await
1379
    .cookie
1380
    .unwrap();
65be9f9c Andy McCall ↶ 1381
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1382
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1383
    let url = format!("{}/andy/demo", h.base);
1384
    let work = tempfile::tempdir().unwrap();
1385
    let w = work.path().to_path_buf();
1386
    tokio::task::spawn_blocking(move || {
1387
        let mut c = Repo::init(&w).unwrap();
1388
        c.config.set("remote.origin.url", &url).unwrap();
1389
        c.config.set("remote.origin.token", "site").unwrap();
1390
        c.save_config().unwrap();
1391
        let steps = [
1392
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1393
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1394
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1395
        ];
1396
        for (msg, text) in steps {
1397
            write(&w, "src/lib.rs", text.as_bytes());
1398
            c.commit(msg, &[]).unwrap();
1399
        }
1400
        assert!(c.push("origin", false).unwrap()[0].ok);
1401
    })
1402
    .await
1403
    .unwrap();
1404
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1405
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1406
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1407
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1408
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1409
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1410
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1411
    assert_ne!(bad.status, StatusCode::OK);
1412
}
92574625 Andy McCall ↶ 1413
1414
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1415
/// dependency edges, linked cards.
1416
#[tokio::test(flavor = "multi_thread")]
1417
async fn a_bookmark_shows_as_swimlanes() {
1418
    let h = hub().await;
1419
    let app = &h.app;
c8684d44 Andy McCall 1420
    let andy = call(
1421
        app,
1422
        "POST",
1423
        "/register",
1424
        None,
1425
        None,
1426
        None,
1427
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1428
    )
1429
    .await
1430
    .cookie
1431
    .unwrap();
92574625 Andy McCall ↶ 1432
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1433
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1434
    let url = format!("{}/andy/demo", h.base);
1435
    let work = tempfile::tempdir().unwrap();
1436
    let w = work.path().to_path_buf();
1437
    tokio::task::spawn_blocking(move || {
1438
        let mut c = Repo::init(&w).unwrap();
1439
        c.config.set("remote.origin.url", &url).unwrap();
1440
        c.config.set("remote.origin.token", "site").unwrap();
1441
        c.save_config().unwrap();
1442
        // Two files edited independently: two lanes.
1443
        write(&w, "a.txt", b"a\n");
1444
        c.commit("add a", &[]).unwrap();
1445
        write(&w, "b.txt", b"b\n");
1446
        c.commit("add b", &[]).unwrap();
1447
        write(&w, "a.txt", b"a\na2\n");
1448
        c.commit("grow a", &[]).unwrap();
1449
        assert!(c.push("origin", false).unwrap()[0].ok);
1450
    })
1451
    .await
1452
    .unwrap();
1453
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1454
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1455
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1456
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1457
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1458
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1459
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1460
    assert_eq!(board.matches("<rect ").count(), 3);
1461
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1462
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1463
}
2bfe5ef6 Andy McCall ↶ 1464
1465
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1466
/// offers only what makes sense and rewrites nothing itself.
1467
#[tokio::test(flavor = "multi_thread")]
1468
async fn a_proposal_board_plans_squashes_and_rebases() {
1469
    let h = hub().await;
1470
    let app = &h.app;
c8684d44 Andy McCall 1471
    let andy = call(
1472
        app,
1473
        "POST",
1474
        "/register",
1475
        None,
1476
        None,
1477
        None,
1478
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1479
    )
1480
    .await
1481
    .cookie
1482
    .unwrap();
2bfe5ef6 Andy McCall ↶ 1483
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1484
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1485
    let url = format!("{}/andy/demo", h.base);
1486
    let work = tempfile::tempdir().unwrap();
1487
    let w = work.path().to_path_buf();
1488
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1489
        let mut c = Repo::init(&w).unwrap();
1490
        c.config.set("remote.origin.url", &url).unwrap();
1491
        c.config.set("remote.origin.token", "site").unwrap();
1492
        c.save_config().unwrap();
1493
        write(&w, "a.txt", b"a\n");
1494
        let base = c.commit("base", &[]).unwrap();
1495
        assert!(c.push("origin", false).unwrap()[0].ok);
1496
        c.bookmark_create("feature", None).unwrap();
1497
        c.bookmark_switch("feature", false).unwrap();
1498
        write(&w, "a.txt", b"a\nfirst\n");
1499
        let first = c.commit("first", &[]).unwrap();
1500
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1501
        let second = c.commit("second", &[]).unwrap();
1502
        write(&w, "b.txt", b"apart\n");
1503
        let apart = c.commit("apart", &[]).unwrap();
1504
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1505
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1506
    })
1507
    .await
1508
    .unwrap();
1509
    // No proposal yet: the board is read-only.
1510
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1511
    assert!(!board.contains("data-plan="));
1512
    let (st, _) = api(
1513
        app,
1514
        "POST",
1515
        "/api/v1/repos/andy/demo/proposals",
1516
        Some("site"),
1517
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1518
    )
1519
    .await;
1520
    assert!(st.is_success(), "{st}");
1521
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1522
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1523
    let csrf = csrf_of(&board);
1524
    let plan = |c: &str, t: &str| {
1525
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1526
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1527
        async move {
1528
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1529
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1530
        }
1531
    };
1532
    let kinds = |v: &serde_json::Value| {
1533
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1534
    };
1535
    // second already depends on first: squash, no rebase.
1536
    let v = plan(&second, &first).await;
1537
    assert_eq!(kinds(&v), ["squash"], "{v}");
1538
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
c96b3286 Andy McCall ↶ 1539
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
2bfe5ef6 Andy McCall ↶ 1540
    // apart is independent of second: either.
1541
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1542
    // first under second: nothing (second depends on first).
1543
    assert!(plan(&first, &second).await["error"].is_string());
1544
    // What has landed on main is not rearranged.
1545
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1546
}
38833ed7 Andy McCall ↶ 1547
1548
/// Issues and proposals share a number space, so every number says what it
1549
/// is, and the chain of work shows from both ends (hub spec §8).
1550
#[tokio::test(flavor = "multi_thread")]
1551
async fn proposals_and_issues_show_their_chain() {
1552
    let h = hub().await;
1553
    let app = &h.app;
c8684d44 Andy McCall 1554
    let andy = call(
1555
        app,
1556
        "POST",
1557
        "/register",
1558
        None,
1559
        None,
1560
        None,
1561
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1562
    )
1563
    .await
1564
    .cookie
1565
    .unwrap();
38833ed7 Andy McCall ↶ 1566
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1567
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1568
    let url = format!("{}/andy/demo", h.base);
1569
    let work = tempfile::tempdir().unwrap();
1570
    let w = work.path().to_path_buf();
1571
    tokio::task::spawn_blocking(move || {
1572
        let mut c = Repo::init(&w).unwrap();
1573
        c.config.set("remote.origin.url", &url).unwrap();
1574
        c.config.set("remote.origin.token", "site").unwrap();
1575
        c.save_config().unwrap();
1576
        write(&w, "a.txt", b"a\n");
1577
        c.commit("base", &[]).unwrap();
1578
        assert!(c.push("origin", false).unwrap()[0].ok);
1579
        c.bookmark_create("feature", None).unwrap();
1580
        c.bookmark_switch("feature", false).unwrap();
1581
        write(&w, "a.txt", b"a\nfixed\n");
1582
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1583
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1584
    })
1585
    .await
1586
    .unwrap();
1587
    for title in ["Slow start", "Crash on save"] {
1588
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1589
        assert!(st.is_success());
1590
    }
1591
    let (st, v) = api(
1592
        app,
1593
        "POST",
1594
        "/api/v1/repos/andy/demo/proposals",
1595
        Some("site"),
1596
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1597
    )
1598
    .await;
1599
    assert!(st.is_success(), "{st} {v}");
1600
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1601
1602
    // The proposal names its kind, links its references by kind, and shows
1603
    // the chain: the issues it closes (description and changes) → it → main.
1604
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1605
    assert!(p.contains(">proposal #3</small>"), "header");
1606
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1607
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1608
    let chain = &chain[..chain.find("</p>").unwrap()];
1609
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1610
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1611
    }
1612
    assert!(p.contains("<h3>Closes</h3>"));
1613
1614
    // The issue shows the proposal that closes it, and names its own kind.
1615
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1616
    assert!(i.contains(">issue #1</small>"));
1617
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1618
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
a1b98695 Andy McCall ↶ 1619
    // The conversation is a timeline with avatars; editing sits with the
1620
    // content, not in the sidebar, and labels and projects are editable.
1621
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1622
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1623
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1624
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1625
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1626
    assert!(st.is_success(), "{st}");
1627
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
9e50caed Andy McCall ↶ 1628
    assert!(
1629
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1630
        "the owner's projects to add to, in a menu"
1631
    );
a1b98695 Andy McCall ↶ 1632
    let csrf = csrf_of(&p);
1633
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1634
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1635
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1636
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1637
        .await;
1638
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1639
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1640
38833ed7 Andy McCall ↶ 1641
    // Closed by the proposal's change, not its description: still shown.
1642
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1643
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1644
    assert!(chain.contains("proposal #3"), "{chain}");
1645
}
e9bfea8e Andy McCall ↶ 1646
1647
/// What the hub is: its version and build, and the libraries it is built on,
1648
/// on /about, in the API and in /health (hub spec §15).
1649
#[tokio::test(flavor = "multi_thread")]
1650
async fn the_hub_says_what_version_it_is() {
1651
    let h = hub().await;
1652
    let app = &h.app;
1653
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1654
    assert_eq!(st, StatusCode::OK);
1655
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1656
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1657
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1658
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1659
    assert!(health.contains("\"build\""), "{health}");
b2107275 Andy McCall ↶ 1660
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1661
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
e9bfea8e Andy McCall ↶ 1662
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1663
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1664
    assert!(about.contains("href=\"/about\""), "the footer links here");
1665
}
df71c789 Andy McCall ↶ 1666
1667
#[tokio::test(flavor = "multi_thread")]
1668
async fn device_sign_in() {
1669
    let h = hub().await;
1670
    let app = &h.app;
c8684d44 Andy McCall 1671
    let r = call(
1672
        app,
1673
        "POST",
1674
        "/register",
1675
        None,
1676
        None,
1677
        None,
1678
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1679
    )
1680
    .await;
df71c789 Andy McCall ↶ 1681
    let andy = r.cookie.unwrap();
1682
1683
    // An unknown scope is refused.
1684
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1685
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1686
1687
    // The app asks for a code and polls; nobody has approved it yet.
1688
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1689
    assert_eq!(st, StatusCode::OK, "{v}");
1690
    let device = v["device_code"].as_str().unwrap().to_string();
1691
    let user = v["user_code"].as_str().unwrap().to_string();
1692
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1693
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1694
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1695
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1696
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1697
    assert_eq!(v["error"], "slow_down", "polled too soon");
1698
1699
    // The user approves it on the web, allowing less than it asked for.
1700
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1701
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1702
    let csrf = csrf_of(&page.body);
1703
    let r =
1704
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1705
            .await;
4da8b828 Andy McCall ↶ 1706
    // oxygenhub#83: the answer page says it is done, with no code form.
1707
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1708
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
df71c789 Andy McCall ↶ 1709
1710
    // The next poll gets a token with what was allowed, once.
1711
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1712
    assert_eq!(st, StatusCode::OK, "{v}");
1713
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1714
    let token = v["access_token"].as_str().unwrap().to_string();
1715
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1716
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1717
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1718
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1719
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1720
    assert!(tokens.body.contains("device: Phone app"));
60f11b71 Andy McCall ↶ 1721
    // oxygenhub#70: a device's token expires, and each use renews it.
1722
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
df71c789 Andy McCall ↶ 1723
60f11b71 Andy McCall ↶ 1724
    // The token can revoke itself (oxy auth logout), and is then refused.
1725
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1726
    assert_eq!(st, StatusCode::NO_CONTENT);
1727
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1728
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1729
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1730
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1731
df71c789 Andy McCall ↶ 1732
    // A denied code says so.
1733
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1734
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1735
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1736
    let csrf = csrf_of(&page.body);
1737
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1738
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1739
    assert_eq!(v["error"], "access_denied");
ecac6e8d Andy McCall ↶ 1740
1741
    // A code the app gave up on (#304) is gone at once: the page no longer
1742
    // takes it, and the app's poll says so.
1743
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Cancelled"}"#)).await;
1744
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1745
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1746
    assert_eq!(st, StatusCode::NO_CONTENT);
1747
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1748
    let csrf = csrf_of(&page.body);
1749
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve"))).await;
1750
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1751
    assert_eq!(v["error"], "expired_token", "{v}");
1752
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1753
    assert_eq!(st, StatusCode::NO_CONTENT, "again: still fine");
df71c789 Andy McCall ↶ 1754
1755
    // Signed out, the page asks for a sign-in first.
1756
    let r = call(app, "GET", "/device", None, None, None, None).await;
1757
    assert!(r.status.is_redirection(), "{}", r.status);
1758
}
62ceb2ee Andy McCall ↶ 1759
1760
#[tokio::test(flavor = "multi_thread")]
1761
async fn api_assistants_at_each_level() {
1762
    let h = hub().await;
1763
    let app = &h.app;
c8684d44 Andy McCall 1764
    let andy = call(
1765
        app,
1766
        "POST",
1767
        "/register",
1768
        None,
1769
        None,
1770
        None,
1771
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1772
    )
1773
    .await
1774
    .cookie
1775
    .unwrap();
62ceb2ee Andy McCall ↶ 1776
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1777
    let csrf = csrf_of(&page.body);
1778
    let mint = |scopes: &'static str| {
1779
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1780
        async move {
1781
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1782
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1783
        }
1784
    };
1785
    let admin = mint("scopes=repo%3Aadmin").await;
1786
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1787
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1788
    // A stand-in endpoint with no model list: any model name is taken.
1789
    let router = axum::Router::new().route(
1790
        "/v1/chat/completions",
1791
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1792
    );
1793
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1794
    let port = listener.local_addr().unwrap().port();
1795
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1796
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1797
1798
    // The site's, by its administrator; the repository's, by its admin.
1799
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1800
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1801
    assert_eq!(st, StatusCode::OK, "{v}");
1802
    assert_eq!(v["ok"], "Gemini added");
1803
    let body =
1804
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1805
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1806
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1807
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1808
    assert_eq!(st, StatusCode::OK, "{v}");
1809
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1810
    assert_eq!(st, StatusCode::OK);
1811
    let names: Vec<(&str, &str, bool)> = v
1812
        .as_array()
1813
        .unwrap()
1814
        .iter()
1815
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1816
        .collect();
1817
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1818
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1819
    // Changing it keeps the token when none is given.
1820
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1821
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1822
    assert_eq!(v["ok"], "Claude updated");
1823
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1824
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1825
    // Prompts: the site's is inherited by the repository.
1826
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1827
    assert_eq!(st, StatusCode::OK);
1828
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1829
    assert_eq!(v["prompt"], "Rust.");
1830
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1831
    // Removed.
1832
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1833
    assert_eq!(st, StatusCode::NO_CONTENT);
1834
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1835
    assert_eq!(st, StatusCode::NOT_FOUND);
1836
}