OXYGENHUB
◆ run-one-job oxygenhub / crates / hub / tests / api.rs
78.7 KiB · Rust · last changed Project cards: take owner/repo#N, as the board shows them 28 days ago source blame history raw
b64e2537 Andy McCall ↶ 1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use std::sync::{Arc, Mutex};
15
use tower::ServiceExt;
16
17
fn hermetic() {
18
    static ONCE: std::sync::Once = std::sync::Once::new();
19
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
20
    ONCE.call_once(|| {
21
        let d = tempfile::tempdir().unwrap();
22
        std::env::set_var("OXY_HOME", d.path());
23
        DIR.set(d).ok();
24
    });
25
}
26
27
fn write(root: &Path, rel: &str, content: &[u8]) {
28
    let p = root.join(rel);
29
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
30
    std::fs::write(p, content).unwrap();
31
}
32
33
struct Hub {
34
    app: Shared,
35
    base: String,
36
    _dir: tempfile::TempDir,
37
}
38
39
async fn hub() -> Hub {
40
    hermetic();
41
    let dir = tempfile::tempdir().unwrap();
42
    let mut config = Config::load(dir.path()).unwrap();
43
    config.auth.push_tokens = vec!["site".into()];
44
    config.registration.mode = "open".into();
45
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
46
    let port = listener.local_addr().unwrap().port();
47
    config.server.base_url = format!("http://127.0.0.1:{port}");
48
    let app = oxygenhub::build(config).await.unwrap();
49
    let router = oxygenhub::router(app.clone());
50
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
51
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
52
}
53
54
struct Res {
55
    status: StatusCode,
56
    body: String,
57
    cookie: Option<String>,
58
}
59
60
async fn call(
61
    app: &Shared,
62
    method: &str,
63
    path: &str,
64
    bearer: Option<&str>,
65
    cookie: Option<&str>,
66
    json: Option<&str>,
67
    form: Option<&str>,
68
) -> Res {
69
    let mut req = Request::builder().method(method).uri(path);
70
    if let Some(b) = bearer {
71
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
72
    }
73
    if let Some(c) = cookie {
74
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
75
    }
76
    let body = if let Some(j) = json {
77
        req = req.header(header::CONTENT_TYPE, "application/json");
78
        Body::from(j.to_string())
79
    } else if let Some(f) = form {
80
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
81
        Body::from(f.to_string())
82
    } else {
83
        Body::empty()
84
    };
85
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
86
    let status = res.status();
87
    let cookie = res
88
        .headers()
89
        .get(header::SET_COOKIE)
90
        .and_then(|v| v.to_str().ok())
91
        .and_then(|v| v.split(';').next())
92
        .and_then(|kv| kv.split_once('='))
93
        .map(|(_, v)| v.to_string());
94
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
95
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
96
}
97
98
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
99
    let r = call(app, method, path, bearer, None, json, None).await;
100
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
101
    (r.status, v)
102
}
103
104
fn csrf_of(page: &str) -> String {
105
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
106
    page[i..].split('"').next().unwrap().to_string()
107
}
108
109
/// A webhook receiver that records what it gets and fails the first time.
110
struct Receiver {
111
    url: String,
112
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
113
    fail_first: Arc<Mutex<bool>>,
114
}
115
116
async fn receiver() -> Receiver {
117
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
118
    let fail_first = Arc::new(Mutex::new(true));
119
    let (s2, f2) = (seen.clone(), fail_first.clone());
120
    let router = Router::new().route(
121
        "/hook",
122
        post(move |headers: header::HeaderMap, body: String| {
123
            let (s2, f2) = (s2.clone(), f2.clone());
124
            async move {
125
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
126
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
127
                let mut f = f2.lock().unwrap();
128
                if *f {
129
                    *f = false;
130
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
131
                }
132
                s2.lock().unwrap().push((event, sig, body));
133
                (StatusCode::OK, "ok")
134
            }
135
        }),
136
    );
137
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
138
    let port = listener.local_addr().unwrap().port();
139
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
140
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
141
}
142
143
#[tokio::test(flavor = "multi_thread")]
144
async fn api_webhooks_and_checks() {
145
    let h = hub().await;
146
    let app = &h.app;
147
    // Accounts and tokens through the pages.
148
    let r =
149
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
150
    let andy = r.cookie.unwrap();
151
    let r =
152
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
153
    let bob = r.cookie.unwrap();
154
    let mint = |cookie: String, scopes: &'static str| {
155
        let app = app.clone();
156
        async move {
157
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
158
            let csrf = csrf_of(&page.body);
159
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
160
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
161
        }
162
    };
163
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
164
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
165
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
166
167
    // Create a repository through the API; the read-only token cannot.
168
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
169
    assert_eq!(st, StatusCode::FORBIDDEN);
170
    let (st, v) = api(
171
        app,
172
        "POST",
173
        "/api/v1/repos",
174
        Some(&andy_admin),
175
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
176
    )
177
    .await;
178
    assert_eq!(st, StatusCode::CREATED, "{v}");
179
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
180
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
181
    assert_eq!(st, StatusCode::CONFLICT);
182
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
183
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
184
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
185
    assert_eq!(st, StatusCode::OK);
186
    assert_eq!(v["username"], "andy");
187
188
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
189
    let rx = receiver().await;
190
    let (st, v) = api(
191
        app,
192
        "POST",
193
        "/api/v1/repos/andy/demo/hooks",
194
        Some(&andy_admin),
195
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
196
    )
197
    .await;
198
    assert_eq!(st, StatusCode::CREATED, "{v}");
199
    let work = tempfile::tempdir().unwrap();
200
    let mut client = Repo::init(work.path()).unwrap();
201
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
202
    client.config.set("remote.origin.token", "site").unwrap();
203
    client.save_config().unwrap();
204
    write(work.path(), "a.txt", b"a\n");
205
    client.snapshot("t").unwrap();
206
    let base = client.commit("base", &[]).unwrap();
207
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
208
    // The worker retries with backoff; drive it directly for the retry.
209
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
210
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
211
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
212
    oxygenhub::hooks::deliver_due(app).await;
213
    let seen = rx.seen.lock().unwrap().clone();
214
    assert_eq!(seen.len(), 1, "{seen:?}");
215
    assert_eq!(seen[0].0, "push");
216
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
217
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
218
    assert_eq!(payload["repository"]["name"], "demo");
219
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
220
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
221
    assert_eq!(v.as_array().unwrap().len(), 1);
222
223
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
224
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
225
    assert_eq!(st, StatusCode::OK);
226
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
f28389bd Andy McCall ↶ 227
    // A revset in place of the whole history (`?r=`), under a budget; a
228
    // bad one is the caller's problem.
229
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
230
    assert_eq!(st, StatusCode::OK, "{v}");
231
    assert_eq!(v["total"].as_u64(), Some(1));
232
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
233
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
234
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
235
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
236
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
b64e2537 Andy McCall ↶ 237
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
238
    assert_eq!(v[0]["name"], "a.txt");
239
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
240
    assert_eq!(r.body, "a\n");
241
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
242
    assert_eq!(v[0]["change"], base.to_hex());
243
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
244
    assert_eq!(v["files"][0]["path"], "a.txt");
245
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
246
    assert!(v["policy"].is_null());
247
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
248
    assert_eq!(v[0]["reference"], "main");
249
250
    // Issues through the API: Bob opens one, comments, and closes it.
251
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
252
    assert_eq!(st, StatusCode::CREATED, "{v}");
253
    assert_eq!(v["number"], 1);
254
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
255
    assert_eq!(st, StatusCode::CREATED);
256
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
257
    assert_eq!(st, StatusCode::OK, "{v}");
258
    assert_eq!(v["state"], "closed");
259
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
260
    assert_eq!(v[0]["comments"], 1);
261
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
262
    assert_eq!(v[0]["number"], 1);
263
264
    // A proposal through the API, then a required check gates its landing.
265
    client.bookmark_create("feat", Some(&[base])).unwrap();
266
    client.bookmark_switch("feat", false).unwrap();
267
    write(work.path(), "b.txt", b"b\n");
3f02e5ea Andy McCall ↶ 268
    write(work.path(), "a.txt", b"a\nA\n");
b64e2537 Andy McCall ↶ 269
    client.snapshot("t").unwrap();
270
    let feat = client.commit("feat", &[]).unwrap();
271
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
272
    let (st, v) =
273
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
274
            .await;
275
    assert_eq!(st, StatusCode::CREATED, "{v}");
276
    assert_eq!(v["number"], 2);
277
    let state = v["projected_state"].as_str().unwrap().to_string();
278
    assert_eq!(v["landable"], true);
3f02e5ea Andy McCall ↶ 279
    // Its files, and each side's bytes, for editors' diff views.
280
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
281
    assert_eq!(st, StatusCode::OK, "{v}");
282
    let files: Vec<(String, String)> =
283
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
284
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
285
    assert_eq!(v[0]["added"], 1);
286
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
287
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
288
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
289
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
290
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
291
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
c0fac31d Andy McCall ↶ 292
    // An anchored comment comes back with its line in the projected state.
293
    let (st, v) = api(
294
        app,
295
        "POST",
296
        "/api/v1/repos/andy/demo/proposals/2/comments",
297
        Some(&bob_rw),
298
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
299
    )
300
    .await;
301
    assert_eq!(st, StatusCode::CREATED, "{v}");
302
    assert_eq!(v["line"], 2);
303
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
304
    assert_eq!(v[0]["path"], "a.txt");
305
    assert_eq!(v[0]["line"], 2, "{v}");
306
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
b64e2537 Andy McCall ↶ 307
    // Require the "build" check.
308
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
309
    let csrf = csrf_of(&settings.body);
310
    assert_eq!(
311
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
312
            .await
313
            .status,
314
        StatusCode::OK
315
    );
316
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
317
    assert_eq!(v["landable"], false);
318
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
319
    // A checker reports on the projected state: first running, then passed; the page streams it.
320
    let (st, v) = api(
321
        app,
322
        "POST",
323
        "/api/v1/repos/andy/demo/checks",
324
        Some(&andy_ro),
325
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
326
    )
327
    .await;
328
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
329
    let mut events = app.events.proposals.subscribe();
330
    let (st, v) = api(
331
        app,
332
        "POST",
333
        "/api/v1/repos/andy/demo/checks",
334
        Some(&bob_rw),
335
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
336
    )
337
    .await;
338
    assert_eq!(st, StatusCode::CREATED, "{v}");
339
    let (_, ev) = events.recv().await.unwrap();
340
    assert_eq!(ev.kind, "check");
341
    assert_eq!(ev.check.unwrap().name, "build");
342
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
343
    assert_eq!(v[0]["status"], "passed");
344
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
345
    assert_eq!(v["landable"], true, "{v}");
346
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
347
    assert!(page.body.contains("42 tests"), "{}", page.body);
348
    // The check and the proposal reached the webhook too.
349
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
350
    oxygenhub::hooks::deliver_due(app).await;
351
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
352
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
353
    let _ = feat;
354
    let _ = rx.fail_first;
42a0ba4b Andy McCall ↶ 355
356
    // The inbox through the API: count, list, mark one read, mark all read.
357
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
358
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
359
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
eb0c44a9 Andy McCall ↶ 360
    oxygenhub::db::notify::add(
361
        &app.db,
362
        oxygenhub::db::notify::New {
363
            account_id: bob_id,
364
            repo_id: None,
365
            reason: oxygenhub::db::notify::Reason::Participating,
366
            kind: "mention",
367
            title: "andy/demo#1: Bug",
368
            url: "/andy/demo/issue/1",
369
            actor: "andy",
370
        },
371
    )
372
    .await
373
    .unwrap();
374
    oxygenhub::db::notify::add(
375
        &app.db,
376
        oxygenhub::db::notify::New {
377
            account_id: bob_id,
378
            repo_id: None,
379
            reason: oxygenhub::db::notify::Reason::Participating,
380
            kind: "review",
381
            title: "andy/demo#2: Feat",
382
            url: "/andy/demo/proposal/2",
383
            actor: "andy",
384
        },
385
    )
386
    .await
387
    .unwrap();
42a0ba4b Andy McCall ↶ 388
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
389
    assert_eq!(st, StatusCode::OK, "{v}");
390
    assert_eq!(v["unread"], 2);
391
    assert_eq!(v["items"][0]["read"], false);
392
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
393
    let first = v["items"][0]["id"].as_i64().unwrap();
394
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
395
    assert_eq!(st, StatusCode::NO_CONTENT);
396
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
397
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
398
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
399
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
400
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
0b20f1ec Andy McCall ↶ 401
cc1cd197 Andy McCall ↶ 402
    // Review requests: the author asks andy; andy is told, reviews, and the
403
    // request is answered; the author hears of the review.
404
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
405
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
406
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
407
        .await
408
        .unwrap();
409
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
410
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
411
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
412
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
413
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
414
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
415
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
416
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
417
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
418
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
419
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
420
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
421
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
422
    let (st, _) =
423
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
424
    assert_eq!(st, StatusCode::CREATED);
425
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
426
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
427
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
428
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
429
    // Asking again and withdrawing it.
430
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
431
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
432
    assert_eq!(st, StatusCode::NO_CONTENT);
433
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
434
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
8e96499f Andy McCall ↶ 435
    // oxygenhub#84: the page's menu sets who is asked, all at once.
436
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
437
    assert!(
438
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
439
        "the reviewers menu lists andy"
440
    );
441
    let csrf = csrf_of(&page.body);
442
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
443
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
444
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
445
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
446
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
447
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
448
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
cc1cd197 Andy McCall ↶ 449
0b20f1ec Andy McCall ↶ 450
    // A source bookmark with `/` in its name, as a feature/N-name workflow
451
    // makes them: by name, and as this repository's owner/name:bookmark.
452
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
453
        client.bookmark_create(b, Some(&[base])).unwrap();
454
        client.bookmark_switch(b, false).unwrap();
455
        write(work.path(), file, b"c\n");
456
        client.snapshot("t").unwrap();
457
        client.commit(b, &[]).unwrap();
458
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
459
    }
460
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
461
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
462
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
463
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
464
        let n = v["number"].as_i64().unwrap();
465
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
466
        assert_eq!(page.status, StatusCode::OK);
467
        assert!(page.body.contains("feature/"), "the page names its source");
468
    }
469
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
470
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
471
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
739a763a Andy McCall ↶ 472
473
    // oxygenhub#76: a proposal's title and description are edited through
474
    // the API by its author or a maintainer; what is not given stays.
475
    let edit = |token: &str, number: i64, body: &str| {
476
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
477
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
478
    };
479
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
480
    assert_eq!(st, StatusCode::OK, "{v}");
481
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
482
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
483
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
484
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
485
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
486
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
487
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
488
    let (st, v) = api(
489
        app,
490
        "POST",
491
        "/api/v1/repos/andy/demo/proposals",
492
        Some(&andy_pw),
493
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
494
    )
495
    .await;
496
    assert_eq!(st, StatusCode::CREATED, "{v}");
497
    let n = v["number"].as_i64().unwrap();
498
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
499
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
2291f8cc Andy McCall ↶ 500
501
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
502
    // before anything changes, shown in its JSON.
503
    for l in ["ui", "flow"] {
504
        let body = format!(r#"{{"name":"{l}"}}"#);
505
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
506
    }
507
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
508
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
509
    assert_eq!(st, StatusCode::OK, "{v}");
510
    let names = |v: &serde_json::Value| -> Vec<String> {
511
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
512
    };
513
    assert_eq!(names(&v), ["flow", "ui"]);
514
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
515
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
516
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
517
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
518
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
519
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
520
    assert_eq!(names(&v), ["flow"]);
521
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
b64e2537 Andy McCall ↶ 522
}
76f262e1 Andy McCall ↶ 523
524
#[tokio::test(flavor = "multi_thread")]
525
async fn api_issue_triage_and_labels() {
526
    let h = hub().await;
527
    let app = &h.app;
528
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
529
        .await
530
        .cookie
531
        .unwrap();
532
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
533
        .await
534
        .cookie
535
        .unwrap();
536
    let mint = |cookie: String, scopes: &'static str| {
537
        let app = app.clone();
538
        async move {
539
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
540
            let csrf = csrf_of(&page.body);
541
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
542
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
543
        }
544
    };
545
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
546
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
547
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
548
    assert_eq!(st, StatusCode::CREATED);
549
550
    // Labels through the API; bad colours and non-triage callers are refused.
551
    let (st, v) = api(
552
        app,
553
        "POST",
554
        "/api/v1/repos/andy/demo/labels",
555
        Some(&andy_t),
556
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
557
    )
558
    .await;
559
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
560
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
561
    assert_eq!(
562
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
563
        StatusCode::BAD_REQUEST
564
    );
565
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
566
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
567
    assert_eq!(labels.as_array().unwrap().len(), 2);
5ea4872f Andy McCall ↶ 568
    // oxygenhub#91: milestones over the API, for triage.
569
    let (st, m) = api(
570
        app,
571
        "POST",
572
        "/api/v1/repos/andy/demo/milestones",
573
        Some(&andy_t),
574
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
575
    )
576
    .await;
577
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
578
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
579
    assert_eq!(
580
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
581
        StatusCode::BAD_REQUEST
582
    );
583
    assert_eq!(
584
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
585
        StatusCode::FORBIDDEN
586
    );
587
    let (st, m) =
588
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
589
            .await;
590
    assert_eq!(
591
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
592
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
593
        "{m}"
594
    );
595
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
596
    assert_eq!(
597
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
598
        StatusCode::NOT_FOUND,
599
        "renamed"
600
    );
601
    assert_eq!(
602
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
603
        StatusCode::BAD_REQUEST
604
    );
605
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
606
    assert_eq!(list.as_array().unwrap().len(), 1);
76f262e1 Andy McCall ↶ 607
608
    // An issue created with its labels and assignee in one call.
609
    let (st, v) = api(
610
        app,
611
        "POST",
612
        "/api/v1/repos/andy/demo/issues",
613
        Some(&andy_t),
614
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
615
    )
616
    .await;
617
    assert_eq!(st, StatusCode::CREATED, "{v}");
618
    assert_eq!(v["labels"][0]["name"], "bug");
619
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
620
    let n = v["number"].as_i64().unwrap();
621
    // Unknown names are refused before anything is created.
622
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
623
    assert_eq!(st, StatusCode::BAD_REQUEST);
624
    assert!(v["detail"].as_str().unwrap().contains("no label"));
625
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
626
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
627
    // Without triage, labels cannot be set, but a plain issue can be opened.
628
    assert_eq!(
629
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
630
        StatusCode::FORBIDDEN
631
    );
632
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
633
    assert_eq!(st, StatusCode::CREATED);
634
    let bob_n = bobs["number"].as_i64().unwrap();
635
636
    // PATCH: the whole label set, assignees and milestone, with events.
637
    let (st, v) =
638
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
639
            .await;
640
    assert_eq!(st, StatusCode::OK, "{v}");
641
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
642
    assert_eq!(v["assignees"], serde_json::json!([]));
643
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
644
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
645
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
646
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
647
    // The author edits their own title; others cannot; nobody but triage sets labels.
648
    let (st, v) =
649
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
650
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
651
    assert_eq!(
652
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
653
        StatusCode::FORBIDDEN
654
    );
655
    assert_eq!(
656
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
657
        StatusCode::FORBIDDEN
658
    );
659
    assert_eq!(
660
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
661
        StatusCode::BAD_REQUEST
662
    );
663
664
    // Deleting a label takes it off the issues.
665
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
666
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
667
    assert_eq!(v["labels"], serde_json::json!([]));
668
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
669
}
9756c67d Andy McCall ↶ 670
671
#[tokio::test(flavor = "multi_thread")]
672
async fn webhook_formats_editing_and_web_issue_events() {
673
    let h = hub().await;
674
    let app = &h.app;
675
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
676
        .await
677
        .cookie
678
        .unwrap();
679
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
680
    let r = call(
681
        app,
682
        "POST",
683
        "/settings/tokens",
684
        None,
685
        Some(&andy),
686
        None,
687
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
688
    )
689
    .await;
690
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
691
    assert_eq!(
692
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
693
        StatusCode::CREATED
694
    );
695
    let rx = receiver().await;
696
    *rx.fail_first.lock().unwrap() = false;
697
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
698
    let csrf = csrf_of(&settings);
699
    let form = |f: String| {
700
        let andy = andy.clone();
701
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
702
    };
703
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
704
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
705
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
706
    assert_eq!(hook.format, "discord");
707
    // Ping arrives as a Discord message.
708
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
709
    let mut got = String::new();
710
    for _ in 0..100 {
711
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
712
            got = body.clone();
713
        }
714
        if !got.is_empty() {
715
            break;
716
        }
717
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
718
    }
719
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
720
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
721
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
722
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
723
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
724
725
    // Editing: a blank URL and secret keep theirs; format, events and active change.
726
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
727
        .await
728
        .contains("Webhook saved"));
729
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
730
    assert_eq!(
731
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
732
        (rx.url.as_str(), "issue", "oxygenhub", true)
733
    );
734
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
735
736
    // An issue opened on the web now reaches the hook, as the signed envelope.
737
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
738
    call(
739
        app,
740
        "POST",
741
        "/andy/demo/issues/new",
742
        None,
743
        Some(&andy),
744
        None,
745
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
746
    )
747
    .await;
748
    let mut envelope = None;
749
    for _ in 0..100 {
750
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
751
        if envelope.is_some() {
752
            break;
753
        }
754
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
755
    }
756
    let (_, sig, body) = envelope.expect("issue.opened delivered");
757
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
758
    assert_eq!(v["data"]["issue"]["title"], "From the web");
759
    assert!(sig.starts_with("blake3-keyed="));
760
    // A disabled hook through the edit form (no active box).
761
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
762
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
763
}
ef20fdc1 Andy McCall ↶ 764
765
#[tokio::test(flavor = "multi_thread")]
766
async fn api_projects() {
767
    let h = hub().await;
768
    let app = &h.app;
769
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
770
        .await
771
        .cookie
772
        .unwrap();
773
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
774
        .await
775
        .cookie
776
        .unwrap();
777
    let mint = |cookie: String, scopes: &'static str| {
778
        let app = app.clone();
779
        async move {
780
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
781
            let csrf = csrf_of(&page.body);
782
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
783
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
784
        }
785
    };
786
    let a = mint(andy, "scopes=repo%3Aadmin").await;
787
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
788
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
789
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
790
791
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
792
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
793
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
794
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
795
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
796
797
    // Cards by reference, into a column by name, and a note into the first column.
798
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
799
    assert_eq!(st, StatusCode::CREATED, "{card}");
800
    assert_eq!(
801
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
802
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
803
    );
804
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
805
    assert_eq!(st, StatusCode::BAD_REQUEST);
806
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
efb51b39 Andy McCall ↶ 807
    // The form the board shows its cards in is taken too (#118); another owner's is refused.
808
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"andy/demo#1"}"#)).await;
809
    assert!(v["detail"].as_str().unwrap().contains("already on this project"), "{v}");
810
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"other/demo#1"}"#)).await;
811
    assert!(v["detail"].as_str().unwrap().contains("only andy's"), "{v}");
ef20fdc1 Andy McCall ↶ 812
    assert_eq!(
813
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
814
        StatusCode::BAD_REQUEST
815
    );
816
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
817
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
818
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
819
820
    // Move and read the board.
821
    let id = card["id"].as_i64().unwrap();
822
    assert_eq!(
823
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
824
        StatusCode::NO_CONTENT
825
    );
826
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
827
    let names: Vec<(&str, usize)> =
828
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
829
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
830
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
17a3a84b Andy McCall ↶ 831
    // The cards by column (#115), and a wrong method answers with a body.
832
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
833
    assert_eq!(st, StatusCode::OK);
834
    assert_eq!(cols, board["columns"]);
835
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
836
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
837
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
ef20fdc1 Andy McCall ↶ 838
839
    // Private: hidden from others; closed: read-only; then remove a card.
840
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
841
    assert_eq!(edited["public"], false);
842
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
843
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
844
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
845
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
846
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
847
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
848
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
849
}
961c10be Andy McCall ↶ 850
851
#[tokio::test(flavor = "multi_thread")]
852
async fn api_required_checks() {
853
    let h = hub().await;
854
    let app = &h.app;
855
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
856
        .await
857
        .cookie
858
        .unwrap();
859
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
860
    let csrf = csrf_of(&page.body);
861
    let mint = |scopes: &'static str| {
862
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
863
        async move {
864
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
865
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
866
        }
867
    };
868
    let admin = mint("scopes=repo%3Aadmin").await;
869
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
870
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
871
872
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
873
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
874
    let (st, v) = api(
875
        app,
876
        "PUT",
877
        "/api/v1/repos/andy/demo/checks/required",
878
        Some(&admin),
879
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
880
    )
881
    .await;
882
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
883
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
884
    assert_eq!(
885
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
886
        serde_json::json!(["flow/fmt", "flow/test"])
887
    );
888
    assert_eq!(
889
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
890
        StatusCode::FORBIDDEN,
891
        "repo:admin only"
892
    );
893
    assert_eq!(
894
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
895
        StatusCode::BAD_REQUEST
896
    );
897
    // The settings page shows the same list.
898
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
899
}
9008bf6c Andy McCall ↶ 900
901
/// OxygenFlow per repository: site administrators turn it on or off in
902
/// the repository's settings; hub.toml's `[flow] repos` is the default.
903
#[tokio::test(flavor = "multi_thread")]
904
async fn flow_is_switched_per_repository_by_site_admins() {
905
    let h = hub().await;
906
    let app = &h.app;
907
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
908
        .await
909
        .cookie
910
        .unwrap();
911
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
912
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
913
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
914
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
915
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
916
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
917
918
    let set = |value: &'static str| {
919
        let (app, andy) = (app.clone(), andy.clone());
920
        async move {
921
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
922
            call(
923
                &app,
924
                "POST",
925
                "/andy/demo/settings/flow",
926
                None,
927
                Some(&andy),
928
                None,
929
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
930
            )
931
            .await
932
        }
933
    };
934
    // A repository admin who is not a site admin sees the state but cannot change it.
935
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
936
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
937
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
938
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
939
    let r = set("on").await;
940
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
941
    assert_eq!(row().await.flow, "");
942
943
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
944
    let r = set("on").await;
945
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
946
    assert_eq!(row().await.flow, "on");
947
    assert!(oxygenhub::flow::enabled(app, &row().await));
948
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
949
    set("off").await;
950
    assert!(!oxygenhub::flow::enabled(app, &row().await));
951
    set("default").await;
952
    assert_eq!(row().await.flow, "");
953
    assert!(set("sometimes").await.body.contains("Pick on, off"));
954
}
e271a37b Andy McCall ↶ 955
956
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
957
/// button, never the repository's default bookmark as the hub sets it.
958
#[tokio::test(flavor = "multi_thread")]
959
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
960
    let h = hub().await;
961
    let app = &h.app;
962
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
963
        .await
964
        .cookie
965
        .unwrap();
966
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
967
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
968
    let url = format!("{}/andy/demo", h.base);
969
    let work = tempfile::tempdir().unwrap();
970
    let (w, u) = (work.path().to_path_buf(), url.clone());
971
    let client = tokio::task::spawn_blocking(move || {
972
        let mut c = Repo::init(&w).unwrap();
973
        c.config.set("remote.origin.url", &u).unwrap();
974
        c.config.set("remote.origin.token", "site").unwrap();
975
        c.save_config().unwrap();
976
        write(&w, "a.txt", b"a\n");
977
        c.commit("a", &[]).unwrap();
978
        assert!(c.push("origin", false).unwrap()[0].ok);
979
        for b in ["develop", "feature/x", "stray"] {
980
            c.bookmark_create(b, None).unwrap();
981
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
982
        }
983
        // A pushed deletion.
984
        let r = c.push_delete("origin", "feature/x").unwrap();
985
        assert!(r[0].ok, "{r:?}");
986
        c
987
    })
988
    .await
989
    .unwrap();
990
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
991
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
992
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
993
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
994
    assert!(!anon.body.contains("/bookmarks/delete"));
995
996
    // The hub's default, not the repository's config, is protected: make
997
    // develop the default, then main can go and develop cannot.
998
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
999
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1000
    let client = tokio::task::spawn_blocking(move || {
1001
        let r = client.push_delete("origin", "develop").unwrap();
1002
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1003
        let r = client.push_delete("origin", "main").unwrap();
1004
        assert!(r[0].ok, "{r:?}");
1005
        client
1006
    })
1007
    .await
1008
    .unwrap();
1009
    drop(client);
1010
1011
    // On the web: a writer deletes stray; the default is refused.
1012
    let form = |b: &'static str| {
1013
        let (app, andy) = (app.clone(), andy.clone());
1014
        async move {
1015
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1016
            call(
1017
                &app,
1018
                "POST",
1019
                "/andy/demo/bookmarks/delete",
1020
                None,
1021
                Some(&andy),
1022
                None,
1023
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1024
            )
1025
            .await
1026
        }
1027
    };
1028
    let r = form("stray").await;
1029
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1030
    assert!(!r.body.contains(">stray<"));
1031
    let r = form("develop").await;
1032
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1033
    let r = form("nope").await;
1034
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1035
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1036
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1037
    // Anonymous visitors cannot.
1038
    assert_ne!(
1039
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1040
        StatusCode::OK
1041
    );
1042
}
760a7dd3 Andy McCall ↶ 1043
1044
/// A change signed by a key no account has linked says so, on its page
1045
/// and in the API (feedback 14).
1046
#[tokio::test(flavor = "multi_thread")]
1047
async fn changes_signed_by_unlinked_keys_say_so() {
1048
    let h = hub().await;
1049
    let app = &h.app;
1050
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1051
        .await
1052
        .cookie
1053
        .unwrap();
1054
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1055
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1056
    let url = format!("{}/andy/demo", h.base);
1057
    let work = tempfile::tempdir().unwrap();
1058
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1059
    let hash = tokio::task::spawn_blocking(move || {
1060
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1061
        c.config.set("remote.origin.url", &u).unwrap();
1062
        c.config.set("remote.origin.token", "site").unwrap();
1063
        c.save_config().unwrap();
1064
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1065
        write(&w.join("r"), "a.txt", b"a\n");
1066
        let h = c.commit("signed by Ada", &[]).unwrap();
1067
        assert!(c.push("origin", false).unwrap()[0].ok);
1068
        h.to_hex()
1069
    })
1070
    .await
1071
    .unwrap();
1072
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1073
    assert_eq!(st, StatusCode::OK, "{v}");
1074
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1075
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1076
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1077
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1078
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1079
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1080
}
65be9f9c Andy McCall ↶ 1081
1082
/// Function history (hub spec §6.6): the file page lists a file's
1083
/// functions, and a function's page lists exactly the changes to its lines.
1084
#[tokio::test(flavor = "multi_thread")]
1085
async fn a_function_has_its_own_history() {
1086
    let h = hub().await;
1087
    let app = &h.app;
1088
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1089
        .await
1090
        .cookie
1091
        .unwrap();
1092
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1093
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1094
    let url = format!("{}/andy/demo", h.base);
1095
    let work = tempfile::tempdir().unwrap();
1096
    let w = work.path().to_path_buf();
1097
    tokio::task::spawn_blocking(move || {
1098
        let mut c = Repo::init(&w).unwrap();
1099
        c.config.set("remote.origin.url", &url).unwrap();
1100
        c.config.set("remote.origin.token", "site").unwrap();
1101
        c.save_config().unwrap();
1102
        let steps = [
1103
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1104
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1105
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1106
        ];
1107
        for (msg, text) in steps {
1108
            write(&w, "src/lib.rs", text.as_bytes());
1109
            c.commit(msg, &[]).unwrap();
1110
        }
1111
        assert!(c.push("origin", false).unwrap()[0].ok);
1112
    })
1113
    .await
1114
    .unwrap();
1115
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1116
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1117
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1118
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1119
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1120
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1121
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1122
    assert_ne!(bad.status, StatusCode::OK);
1123
}
92574625 Andy McCall ↶ 1124
1125
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1126
/// dependency edges, linked cards.
1127
#[tokio::test(flavor = "multi_thread")]
1128
async fn a_bookmark_shows_as_swimlanes() {
1129
    let h = hub().await;
1130
    let app = &h.app;
1131
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1132
        .await
1133
        .cookie
1134
        .unwrap();
1135
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1136
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1137
    let url = format!("{}/andy/demo", h.base);
1138
    let work = tempfile::tempdir().unwrap();
1139
    let w = work.path().to_path_buf();
1140
    tokio::task::spawn_blocking(move || {
1141
        let mut c = Repo::init(&w).unwrap();
1142
        c.config.set("remote.origin.url", &url).unwrap();
1143
        c.config.set("remote.origin.token", "site").unwrap();
1144
        c.save_config().unwrap();
1145
        // Two files edited independently: two lanes.
1146
        write(&w, "a.txt", b"a\n");
1147
        c.commit("add a", &[]).unwrap();
1148
        write(&w, "b.txt", b"b\n");
1149
        c.commit("add b", &[]).unwrap();
1150
        write(&w, "a.txt", b"a\na2\n");
1151
        c.commit("grow a", &[]).unwrap();
1152
        assert!(c.push("origin", false).unwrap()[0].ok);
1153
    })
1154
    .await
1155
    .unwrap();
1156
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1157
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1158
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1159
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1160
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1161
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1162
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1163
    assert_eq!(board.matches("<rect ").count(), 3);
1164
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1165
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1166
}
2bfe5ef6 Andy McCall ↶ 1167
1168
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1169
/// offers only what makes sense and rewrites nothing itself.
1170
#[tokio::test(flavor = "multi_thread")]
1171
async fn a_proposal_board_plans_squashes_and_rebases() {
1172
    let h = hub().await;
1173
    let app = &h.app;
1174
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1175
        .await
1176
        .cookie
1177
        .unwrap();
1178
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1179
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1180
    let url = format!("{}/andy/demo", h.base);
1181
    let work = tempfile::tempdir().unwrap();
1182
    let w = work.path().to_path_buf();
1183
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1184
        let mut c = Repo::init(&w).unwrap();
1185
        c.config.set("remote.origin.url", &url).unwrap();
1186
        c.config.set("remote.origin.token", "site").unwrap();
1187
        c.save_config().unwrap();
1188
        write(&w, "a.txt", b"a\n");
1189
        let base = c.commit("base", &[]).unwrap();
1190
        assert!(c.push("origin", false).unwrap()[0].ok);
1191
        c.bookmark_create("feature", None).unwrap();
1192
        c.bookmark_switch("feature", false).unwrap();
1193
        write(&w, "a.txt", b"a\nfirst\n");
1194
        let first = c.commit("first", &[]).unwrap();
1195
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1196
        let second = c.commit("second", &[]).unwrap();
1197
        write(&w, "b.txt", b"apart\n");
1198
        let apart = c.commit("apart", &[]).unwrap();
1199
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1200
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1201
    })
1202
    .await
1203
    .unwrap();
1204
    // No proposal yet: the board is read-only.
1205
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1206
    assert!(!board.contains("data-plan="));
1207
    let (st, _) = api(
1208
        app,
1209
        "POST",
1210
        "/api/v1/repos/andy/demo/proposals",
1211
        Some("site"),
1212
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1213
    )
1214
    .await;
1215
    assert!(st.is_success(), "{st}");
1216
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1217
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1218
    let csrf = csrf_of(&board);
1219
    let plan = |c: &str, t: &str| {
1220
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1221
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1222
        async move {
1223
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1224
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1225
        }
1226
    };
1227
    let kinds = |v: &serde_json::Value| {
1228
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1229
    };
1230
    // second already depends on first: squash, no rebase.
1231
    let v = plan(&second, &first).await;
1232
    assert_eq!(kinds(&v), ["squash"], "{v}");
1233
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
c96b3286 Andy McCall ↶ 1234
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
2bfe5ef6 Andy McCall ↶ 1235
    // apart is independent of second: either.
1236
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1237
    // first under second: nothing (second depends on first).
1238
    assert!(plan(&first, &second).await["error"].is_string());
1239
    // What has landed on main is not rearranged.
1240
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1241
}
38833ed7 Andy McCall ↶ 1242
1243
/// Issues and proposals share a number space, so every number says what it
1244
/// is, and the chain of work shows from both ends (hub spec §8).
1245
#[tokio::test(flavor = "multi_thread")]
1246
async fn proposals_and_issues_show_their_chain() {
1247
    let h = hub().await;
1248
    let app = &h.app;
1249
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1250
        .await
1251
        .cookie
1252
        .unwrap();
1253
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1254
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1255
    let url = format!("{}/andy/demo", h.base);
1256
    let work = tempfile::tempdir().unwrap();
1257
    let w = work.path().to_path_buf();
1258
    tokio::task::spawn_blocking(move || {
1259
        let mut c = Repo::init(&w).unwrap();
1260
        c.config.set("remote.origin.url", &url).unwrap();
1261
        c.config.set("remote.origin.token", "site").unwrap();
1262
        c.save_config().unwrap();
1263
        write(&w, "a.txt", b"a\n");
1264
        c.commit("base", &[]).unwrap();
1265
        assert!(c.push("origin", false).unwrap()[0].ok);
1266
        c.bookmark_create("feature", None).unwrap();
1267
        c.bookmark_switch("feature", false).unwrap();
1268
        write(&w, "a.txt", b"a\nfixed\n");
1269
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1270
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1271
    })
1272
    .await
1273
    .unwrap();
1274
    for title in ["Slow start", "Crash on save"] {
1275
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1276
        assert!(st.is_success());
1277
    }
1278
    let (st, v) = api(
1279
        app,
1280
        "POST",
1281
        "/api/v1/repos/andy/demo/proposals",
1282
        Some("site"),
1283
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1284
    )
1285
    .await;
1286
    assert!(st.is_success(), "{st} {v}");
1287
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1288
1289
    // The proposal names its kind, links its references by kind, and shows
1290
    // the chain: the issues it closes (description and changes) → it → main.
1291
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1292
    assert!(p.contains(">proposal #3</small>"), "header");
1293
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1294
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1295
    let chain = &chain[..chain.find("</p>").unwrap()];
1296
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1297
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1298
    }
1299
    assert!(p.contains("<h3>Closes</h3>"));
1300
1301
    // The issue shows the proposal that closes it, and names its own kind.
1302
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1303
    assert!(i.contains(">issue #1</small>"));
1304
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1305
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
a1b98695 Andy McCall ↶ 1306
    // The conversation is a timeline with avatars; editing sits with the
1307
    // content, not in the sidebar, and labels and projects are editable.
1308
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1309
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1310
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1311
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1312
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1313
    assert!(st.is_success(), "{st}");
1314
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
9e50caed Andy McCall ↶ 1315
    assert!(
1316
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1317
        "the owner's projects to add to, in a menu"
1318
    );
a1b98695 Andy McCall ↶ 1319
    let csrf = csrf_of(&p);
1320
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1321
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1322
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1323
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1324
        .await;
1325
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1326
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1327
38833ed7 Andy McCall ↶ 1328
    // Closed by the proposal's change, not its description: still shown.
1329
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1330
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1331
    assert!(chain.contains("proposal #3"), "{chain}");
1332
}
e9bfea8e Andy McCall ↶ 1333
1334
/// What the hub is: its version and build, and the libraries it is built on,
1335
/// on /about, in the API and in /health (hub spec §15).
1336
#[tokio::test(flavor = "multi_thread")]
1337
async fn the_hub_says_what_version_it_is() {
1338
    let h = hub().await;
1339
    let app = &h.app;
1340
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1341
    assert_eq!(st, StatusCode::OK);
1342
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1343
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1344
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1345
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1346
    assert!(health.contains("\"build\""), "{health}");
b2107275 Andy McCall ↶ 1347
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1348
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
e9bfea8e Andy McCall ↶ 1349
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1350
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1351
    assert!(about.contains("href=\"/about\""), "the footer links here");
1352
}
df71c789 Andy McCall ↶ 1353
1354
#[tokio::test(flavor = "multi_thread")]
1355
async fn device_sign_in() {
1356
    let h = hub().await;
1357
    let app = &h.app;
1358
    let r =
1359
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1360
    let andy = r.cookie.unwrap();
1361
1362
    // An unknown scope is refused.
1363
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1364
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1365
1366
    // The app asks for a code and polls; nobody has approved it yet.
1367
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1368
    assert_eq!(st, StatusCode::OK, "{v}");
1369
    let device = v["device_code"].as_str().unwrap().to_string();
1370
    let user = v["user_code"].as_str().unwrap().to_string();
1371
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1372
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1373
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1374
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1375
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1376
    assert_eq!(v["error"], "slow_down", "polled too soon");
1377
1378
    // The user approves it on the web, allowing less than it asked for.
1379
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1380
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1381
    let csrf = csrf_of(&page.body);
1382
    let r =
1383
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1384
            .await;
4da8b828 Andy McCall ↶ 1385
    // oxygenhub#83: the answer page says it is done, with no code form.
1386
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1387
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
df71c789 Andy McCall ↶ 1388
1389
    // The next poll gets a token with what was allowed, once.
1390
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1391
    assert_eq!(st, StatusCode::OK, "{v}");
1392
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1393
    let token = v["access_token"].as_str().unwrap().to_string();
1394
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1395
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1396
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1397
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1398
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1399
    assert!(tokens.body.contains("device: Phone app"));
60f11b71 Andy McCall ↶ 1400
    // oxygenhub#70: a device's token expires, and each use renews it.
1401
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
df71c789 Andy McCall ↶ 1402
60f11b71 Andy McCall ↶ 1403
    // The token can revoke itself (oxy auth logout), and is then refused.
1404
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1405
    assert_eq!(st, StatusCode::NO_CONTENT);
1406
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1407
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1408
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1409
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1410
df71c789 Andy McCall ↶ 1411
    // A denied code says so.
1412
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1413
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1414
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1415
    let csrf = csrf_of(&page.body);
1416
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1417
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1418
    assert_eq!(v["error"], "access_denied");
1419
1420
    // Signed out, the page asks for a sign-in first.
1421
    let r = call(app, "GET", "/device", None, None, None, None).await;
1422
    assert!(r.status.is_redirection(), "{}", r.status);
1423
}
62ceb2ee Andy McCall ↶ 1424
1425
#[tokio::test(flavor = "multi_thread")]
1426
async fn api_assistants_at_each_level() {
1427
    let h = hub().await;
1428
    let app = &h.app;
1429
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1430
        .await
1431
        .cookie
1432
        .unwrap();
1433
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1434
    let csrf = csrf_of(&page.body);
1435
    let mint = |scopes: &'static str| {
1436
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1437
        async move {
1438
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1439
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1440
        }
1441
    };
1442
    let admin = mint("scopes=repo%3Aadmin").await;
1443
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1444
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1445
    // A stand-in endpoint with no model list: any model name is taken.
1446
    let router = axum::Router::new().route(
1447
        "/v1/chat/completions",
1448
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1449
    );
1450
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1451
    let port = listener.local_addr().unwrap().port();
1452
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1453
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1454
1455
    // The site's, by its administrator; the repository's, by its admin.
1456
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1457
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1458
    assert_eq!(st, StatusCode::OK, "{v}");
1459
    assert_eq!(v["ok"], "Gemini added");
1460
    let body =
1461
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1462
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1463
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1464
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1465
    assert_eq!(st, StatusCode::OK, "{v}");
1466
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1467
    assert_eq!(st, StatusCode::OK);
1468
    let names: Vec<(&str, &str, bool)> = v
1469
        .as_array()
1470
        .unwrap()
1471
        .iter()
1472
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1473
        .collect();
1474
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1475
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1476
    // Changing it keeps the token when none is given.
1477
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1478
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1479
    assert_eq!(v["ok"], "Claude updated");
1480
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1481
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1482
    // Prompts: the site's is inherited by the repository.
1483
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1484
    assert_eq!(st, StatusCode::OK);
1485
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1486
    assert_eq!(v["prompt"], "Rust.");
1487
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1488
    // Removed.
1489
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1490
    assert_eq!(st, StatusCode::NO_CONTENT);
1491
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1492
    assert_eq!(st, StatusCode::NOT_FOUND);
1493
}