OXYGENHUB
◆ v0.1.0 oxygenhub / crates / hub / src / web / issues.rs
38.4 KiB · Rust · last changed Proposal page: centred timeline with avatars, inline editing, labels and projects 1 month ago source blame history raw
18e381ea Andy McCall ↶ 1
//! Issues, labels and milestones (hub spec §8).
2
3
use super::settings::{csrf, require};
4
use super::{filters, lookup, lookup_role, Error, Page, RepoShell, Shell};
5
use crate::auth::{Access, Role, Viewer};
6
use crate::db::{self, accounts, issues as idb, notify as ndb};
7
use crate::notify::{self, Event};
8
use crate::render::{self, refs::Numbers};
9
use crate::repos::view;
10
use crate::Shared;
11
use askama::Template;
12
use axum::extract::{Form, Path, Query, State};
13
use axum::response::{IntoResponse, Redirect, Response};
14
use serde::Deserialize;
15
use std::collections::HashMap;
16
c79a1111 Andy McCall ↶ 17
/// Markdown with cross references linked, for a repository; relative
18
/// links and images resolve against `reference` (the default bookmark for
19
/// issues and proposals, the tag for release notes).
20
pub async fn markdown(app: &Shared, row: &db::repos::RepoRow, reference: &str, text: &str) -> String {
21
    let repo_url = format!("/{}", row.slug());
22
    let (issues, proposals) = idb::numbers(&app.db, row.id).await.unwrap_or_default();
23
    let linked = render::refs::link(text, &Numbers { repo_url: &repo_url, issues: &issues, proposals: &proposals });
24
    render::markdown::render(&linked, &format!("{repo_url}/file/{reference}/"), &format!("{repo_url}/raw/{reference}/"))
18e381ea Andy McCall ↶ 25
}
26
27
/// Re-index a thread for search: title, body and every comment.
28
pub async fn reindex(app: &Shared, repo_id: i64, issue: &idb::IssueRow) {
29
    let comments = idb::comments(&app.db, issue.id).await.unwrap_or_default();
30
    let text = std::iter::once(issue.body.clone()).chain(comments.into_iter().map(|c| c.body)).collect::<Vec<_>>().join("\n\n");
31
    ndb::index(&app.db, "issue", repo_id, issue.id, issue.number, &issue.title, &text).await.ok();
32
}
33
34
// ------------------------------------------------------------------ list
35
36
pub struct IssueLine {
37
    pub issue: idb::IssueRow,
38
    pub labels: Vec<idb::Label>,
39
    pub assignees: Vec<String>,
40
    pub milestone: Option<String>,
41
    pub comments: i64,
42
}
43
44
#[derive(Template)]
45
#[template(path = "issues.html")]
46
pub struct IssuesPage {
47
    shell: Shell,
48
    repo: RepoShell,
49
    rows: Vec<IssueLine>,
50
    state: String,
51
    q: String,
52
    counts: (usize, usize),
1ac84c62 Andy McCall ↶ 53
    sort: String,
54
    pager: super::Pager,
18e381ea Andy McCall ↶ 55
}
56
57
#[derive(Deserialize)]
58
pub struct ListQuery {
59
    state: Option<String>,
60
    q: Option<String>,
1ac84c62 Andy McCall ↶ 61
    sort: Option<String>,
62
    page: Option<usize>,
18e381ea Andy McCall ↶ 63
}
64
1ac84c62 Andy McCall ↶ 65
/// The list's sort orders: `newest` (pinned first, the default),
66
/// `oldest`, `updated`, `comments`.
67
pub const SORTS: &[(&str, &str)] =
68
    &[("newest", "newest"), ("oldest", "oldest"), ("updated", "recently updated"), ("comments", "most comments")];
69
18e381ea Andy McCall ↶ 70
/// `label:bug assignee:andy milestone:v1 state:closed words…`
71
struct Filter {
72
    state: String,
73
    labels: Vec<String>,
74
    assignees: Vec<String>,
1ac84c62 Andy McCall ↶ 75
    authors: Vec<String>,
18e381ea Andy McCall ↶ 76
    milestone: Option<String>,
77
    words: Vec<String>,
78
}
79
80
fn parse_filter(state: Option<String>, q: &str) -> Filter {
1ac84c62 Andy McCall ↶ 81
    let mut f = Filter {
82
        state: state.unwrap_or_else(|| "open".into()),
83
        labels: vec![],
84
        assignees: vec![],
85
        authors: vec![],
86
        milestone: None,
87
        words: vec![],
88
    };
18e381ea Andy McCall ↶ 89
    for tok in q.split_whitespace() {
90
        match tok.split_once(':') {
91
            Some(("label", v)) => f.labels.push(v.to_lowercase()),
92
            Some(("assignee", v)) => f.assignees.push(v.to_lowercase()),
1ac84c62 Andy McCall ↶ 93
            Some(("author", v)) => f.authors.push(v.to_lowercase()),
18e381ea Andy McCall ↶ 94
            Some(("milestone", v)) => f.milestone = Some(v.to_lowercase()),
95
            Some(("state", v)) => f.state = v.to_string(),
96
            _ => f.words.push(tok.to_lowercase()),
97
        }
98
    }
99
    f
100
}
101
102
pub async fn list(
103
    State(app): State<Shared>,
104
    viewer: Viewer,
105
    Path((owner, name)): Path<(String, String)>,
106
    Query(q): Query<ListQuery>,
107
) -> Result<Page<IssuesPage>, Error> {
108
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issues"), &viewer);
109
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
110
    let e = |e| Error::from_db(shell.clone(), e);
111
    let all = idb::list(&app.db, row.id).await.map_err(e)?;
112
    let counts = (all.iter().filter(|i| i.state == "open").count(), all.iter().filter(|i| i.state == "closed").count());
113
    let qtext = q.q.clone().unwrap_or_default();
114
    let f = parse_filter(q.state, &qtext);
115
    let mut labels_by: HashMap<i64, Vec<idb::Label>> = HashMap::new();
116
    for (id, l) in idb::labels_by_issue(&app.db, row.id).await.map_err(e)? {
117
        labels_by.entry(id).or_default().push(l);
118
    }
119
    let mut assignees_by: HashMap<i64, Vec<String>> = HashMap::new();
120
    for (id, u) in idb::assignees_by_issue(&app.db, row.id).await.map_err(e)? {
121
        assignees_by.entry(id).or_default().push(u);
122
    }
123
    let milestones: HashMap<i64, String> =
124
        idb::milestones(&app.db, row.id).await.map_err(e)?.into_iter().map(|m| (m.id, m.title)).collect();
125
    let mut rows = Vec::new();
126
    for i in all {
127
        let labels = labels_by.remove(&i.id).unwrap_or_default();
128
        let assignees = assignees_by.remove(&i.id).unwrap_or_default();
129
        let milestone = i.milestone_id.and_then(|m| milestones.get(&m).cloned());
130
        let keep = (f.state == "all" || i.state == f.state)
131
            && f.labels.iter().all(|l| labels.iter().any(|x| x.name.to_lowercase() == *l))
132
            && f.assignees.iter().all(|a| assignees.iter().any(|x| x.to_lowercase() == *a))
1ac84c62 Andy McCall ↶ 133
            && (f.authors.is_empty() || f.authors.contains(&i.author.to_lowercase()))
18e381ea Andy McCall ↶ 134
            && f.milestone.as_ref().is_none_or(|m| milestone.as_ref().is_some_and(|x| x.to_lowercase() == *m))
135
            && f.words.iter().all(|w| i.title.to_lowercase().contains(w) || i.body.to_lowercase().contains(w));
136
        if keep {
137
            let comments: i64 = sqlx::query_scalar("SELECT COUNT(*) FROM issue_comments WHERE issue_id = ?")
138
                .bind(i.id)
139
                .fetch_one(&app.db)
140
                .await
141
                .map_err(e)?;
142
            rows.push(IssueLine { issue: i, labels, assignees, milestone, comments });
143
        }
144
    }
1ac84c62 Andy McCall ↶ 145
    let sort = q.sort.filter(|s| SORTS.iter().any(|(k, _)| k == s)).unwrap_or_else(|| "newest".into());
146
    match sort.as_str() {
147
        "oldest" => rows.sort_by_key(|r| r.issue.number),
148
        "updated" => rows.sort_by_key(|r| std::cmp::Reverse(r.issue.updated_ms)),
149
        "comments" => rows.sort_by_key(|r| (std::cmp::Reverse(r.comments), std::cmp::Reverse(r.issue.number))),
150
        _ => {}
151
    }
152
    let pager = super::Pager::new(rows.len(), q.page, &[("state", &f.state), ("q", &qtext), ("sort", &sort)]);
153
    let rows = pager.slice(rows);
154
    Ok(Page(IssuesPage {
155
        shell,
156
        repo: RepoShell::new(&app, &row, "issues").with_role(role),
157
        rows,
158
        state: f.state,
159
        q: qtext,
160
        counts,
161
        sort,
162
        pager,
163
    }))
18e381ea Andy McCall ↶ 164
}
165
166
// ------------------------------------------------------------------- new
167
168
#[derive(Template)]
169
#[template(path = "issue_new.html")]
170
pub struct NewIssuePage {
171
    shell: Shell,
172
    repo: RepoShell,
173
    templates: Vec<(String, String)>,
174
    template: String,
175
    error: Option<String>,
176
}
177
178
#[derive(Deserialize)]
179
pub struct NewQuery {
180
    template: Option<String>,
181
}
182
183
/// `.oxyhub/ISSUE_TEMPLATE/*.md` in the default bookmark's state.
184
async fn issue_templates(app: &Shared, repo: &crate::repos::RepoName, default: &str) -> Vec<(String, String)> {
185
    let default = default.to_string();
186
    app.repos
187
        .read(repo, move |r, cache| {
188
            let Ok(target) = view::resolve(r, cache, &default) else { return Ok(vec![]) };
189
            let loaded = cache.load(r, &target.heads)?;
190
            let mut out = Vec::new();
191
            for (path, f) in &loaded.snapshot.files {
192
                if let Some(rest) = path.strip_prefix(".oxyhub/ISSUE_TEMPLATE/") {
193
                    if let (Some(name), oxy_core::state::FileContent::Text { bytes, .. }) = (rest.strip_suffix(".md"), &f.content) {
194
                        out.push((name.to_string(), String::from_utf8_lossy(bytes).into_owned()));
195
                    }
196
                }
197
            }
198
            Ok(out)
199
        })
200
        .await
201
        .unwrap_or_default()
202
}
203
204
pub async fn new_form(
205
    State(app): State<Shared>,
206
    viewer: Viewer,
207
    Path((owner, name)): Path<(String, String)>,
208
    Query(q): Query<NewQuery>,
209
) -> Result<Page<NewIssuePage>, Error> {
210
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issues/new"), &viewer);
211
    require(&viewer, &shell)?;
212
    let (repo, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
213
    let templates = issue_templates(&app, &repo, &row.default_bookmark).await;
214
    let template = match q.template.as_deref() {
215
        Some("blank") => " ".into(),
216
        Some(t) => templates.iter().find(|(n, _)| n == t).map(|(_, b)| b.clone()).unwrap_or_default(),
217
        None if templates.is_empty() => " ".into(),
218
        None => String::new(),
219
    };
220
    Ok(Page(NewIssuePage { shell, repo: RepoShell::new(&app, &row, "issues").with_role(role), templates, template, error: None }))
221
}
222
223
#[derive(Deserialize)]
224
pub struct NewIssueForm {
225
    #[serde(rename = "_csrf")]
226
    csrf_token: String,
227
    title: String,
228
    #[serde(default)]
229
    body: String,
230
}
231
232
pub async fn create(
233
    State(app): State<Shared>,
234
    viewer: Viewer,
235
    Path((owner, name)): Path<(String, String)>,
236
    Form(f): Form<NewIssueForm>,
237
) -> Result<Response, Error> {
238
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issues/new"), &viewer);
239
    let me = require(&viewer, &shell)?;
240
    csrf(&viewer, &f.csrf_token, &shell)?;
241
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
242
    if f.title.trim().is_empty() {
243
        return Ok(Page(NewIssuePage {
244
            shell,
245
            repo: RepoShell::new(&app, &row, "issues").with_role(role),
246
            templates: vec![],
247
            template: f.body,
248
            error: Some("Give the issue a title.".into()),
249
        })
250
        .into_response());
251
    }
252
    let issue = idb::create(
253
        &app.db,
254
        idb::NewIssue {
255
            repo_id: row.id,
256
            title: f.title.trim(),
257
            body: f.body.trim(),
258
            author_id: Some(me.account.id),
259
            author: &me.account.username,
260
        },
261
    )
262
    .await
263
    .map_err(|e| Error::from_db(shell.clone(), e))?;
264
    idb::add_event(&app.db, issue.id, &me.account.username, "opened", "").await.ok();
265
    reindex(&app, row.id, &issue).await;
266
    let url = format!("/{owner}/{name}/issue/{}", issue.number);
267
    notify::deliver(
268
        &app,
269
        Event {
270
            kind: "issue.opened",
271
            title: format!("{owner}/{name}#{}: {}", issue.number, issue.title),
272
            url: url.clone(),
273
            actor: &me.account,
274
            repo_id: row.id,
275
            thread: Some(("issue", issue.id)),
276
            mention_text: &f.body,
277
            direct: vec![],
278
        },
279
    )
280
    .await;
9756c67d Andy McCall ↶ 281
    crate::hooks::emit(
282
        &app,
283
        &row,
284
        "issue.opened",
285
        &me.account.username,
286
        serde_json::json!({ "issue": { "number": issue.number, "title": issue.title, "body": issue.body } }),
287
    )
288
    .await;
18e381ea Andy McCall ↶ 289
    Ok(Redirect::to(&url).into_response())
290
}
291
292
// ---------------------------------------------------------------- detail
293
294
pub enum Item {
295
    Comment(idb::IssueComment, String),
296
    Event(idb::IssueEvent),
297
}
298
299
#[derive(Template)]
300
#[template(path = "issue.html")]
301
pub struct IssuePage {
302
    shell: Shell,
303
    repo: RepoShell,
304
    i: idb::IssueRow,
305
    body_html: String,
306
    timeline: Vec<Item>,
307
    comments: Vec<idb::IssueComment>,
308
    labels: Vec<idb::Label>,
309
    all_labels: Vec<idb::Label>,
310
    assignees: Vec<String>,
311
    milestone: Option<idb::Milestone>,
312
    milestones: Vec<(idb::Milestone, bool)>,
313
    subscribed: bool,
314
    can_edit: bool,
315
    can_triage: bool,
e1ec9fbf Andy McCall ↶ 316
    /// Projects this issue is on that the viewer may see, with the column.
317
    projects: Vec<(crate::db::projects::Project, String)>,
38833ed7 Andy McCall ↶ 318
    /// Proposals whose description closes it.
319
    closed_by: Vec<super::chain::Link>,
a1b98695 Andy McCall ↶ 320
    /// Projects the viewer may add it to.
321
    project_choices: Option<Vec<crate::db::projects::Project>>,
18e381ea Andy McCall ↶ 322
    notice: Option<String>,
323
    error: Option<String>,
324
}
325
326
/// The page assembler every action ends in.
327
#[allow(clippy::too_many_arguments)]
328
async fn detail(
329
    app: &Shared,
330
    shell: Shell,
331
    viewer: &Viewer,
332
    owner: &str,
333
    name: &str,
334
    number: i64,
335
    notice: Option<String>,
336
    error: Option<String>,
337
) -> Result<Page<IssuePage>, Error> {
338
    let (_, row, role) = lookup(app, &shell, viewer, owner, name).await?;
339
    let e = |e| Error::from_db(shell.clone(), e);
340
    let i = idb::get(&app.db, row.id, number).await.map_err(e)?.ok_or_else(|| Error::not_found(shell.clone()))?;
c79a1111 Andy McCall ↶ 341
    let body_html = markdown(app, &row, &row.default_bookmark, &i.body).await;
18e381ea Andy McCall ↶ 342
    let comments = idb::comments(&app.db, i.id).await.map_err(e)?;
343
    let events = idb::events(&app.db, i.id).await.map_err(e)?;
344
    let mut timeline: Vec<(i64, Item)> = Vec::new();
345
    for c in &comments {
c79a1111 Andy McCall ↶ 346
        timeline.push((c.created_ms, Item::Comment(c.clone(), markdown(app, &row, &row.default_bookmark, &c.body).await)));
18e381ea Andy McCall ↶ 347
    }
348
    for ev in events {
349
        if ev.event != "opened" {
350
            timeline.push((ev.at_ms, Item::Event(ev)));
351
        }
352
    }
353
    timeline.sort_by_key(|(t, _)| *t);
354
    let labels = idb::issue_labels(&app.db, i.id).await.map_err(e)?;
355
    let all_labels = idb::labels(&app.db, row.id).await.map_err(e)?;
356
    let assignees = idb::assignees(&app.db, i.id).await.map_err(e)?;
357
    let milestones: Vec<(idb::Milestone, bool)> = idb::milestones(&app.db, row.id)
358
        .await
359
        .map_err(e)?
360
        .into_iter()
361
        .map(|m| {
362
            let sel = i.milestone_id == Some(m.id);
363
            (m, sel)
364
        })
365
        .collect();
366
    let milestone = match i.milestone_id {
367
        Some(id) => idb::milestone(&app.db, id).await.map_err(e)?,
368
        None => None,
369
    };
370
    let me = viewer.account();
371
    let subscribed = match me {
372
        Some(a) => ndb::subscribed(&app.db, a.id, "issue", i.id).await.map_err(e)?,
373
        None => false,
374
    };
375
    let can_triage = role >= Role::Triage;
376
    let can_edit = me.is_some_and(|a| Some(a.id) == i.author_id) || can_triage;
e1ec9fbf Andy McCall ↶ 377
    let projects = super::projects::placements_for(app, viewer, &row, i.number).await;
38833ed7 Andy McCall ↶ 378
    let closed_by = super::chain::proposals_closing(app, &row, i.number).await;
a1b98695 Andy McCall ↶ 379
    let project_choices = super::projects::project_choices(app, viewer, &row, &projects).await;
18e381ea Andy McCall ↶ 380
    Ok(Page(IssuePage {
381
        shell,
382
        repo: RepoShell::new(app, &row, "issues").with_role(role),
383
        i,
38833ed7 Andy McCall ↶ 384
        closed_by,
a1b98695 Andy McCall ↶ 385
        project_choices,
18e381ea Andy McCall ↶ 386
        body_html,
387
        timeline: timeline.into_iter().map(|(_, it)| it).collect(),
388
        comments,
389
        labels,
390
        all_labels,
391
        assignees,
392
        milestone,
393
        milestones,
394
        subscribed,
395
        can_edit,
396
        can_triage,
e1ec9fbf Andy McCall ↶ 397
        projects,
18e381ea Andy McCall ↶ 398
        notice,
399
        error,
400
    }))
401
}
402
403
pub async fn show(
404
    State(app): State<Shared>,
405
    viewer: Viewer,
406
    Path((owner, name, number)): Path<(String, String, i64)>,
407
) -> Result<Response, Error> {
408
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issue/{number}"), &viewer);
409
    // A number that belongs to a proposal goes there (shared number space).
410
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
411
    if idb::get(&app.db, row.id, number).await.map_err(|e| Error::from_db(shell.clone(), e))?.is_none()
412
        && db::proposals::get(&app.db, row.id, number).await.map_err(|e| Error::from_db(shell.clone(), e))?.is_some()
413
    {
414
        return Ok(Redirect::to(&format!("/{owner}/{name}/proposal/{number}")).into_response());
415
    }
416
    Ok(detail(&app, shell, &viewer, &owner, &name, number, None, None).await?.into_response())
417
}
418
419
// ---------------------------------------------------------------- actions
420
421
async fn issue_for(
422
    app: &Shared,
423
    shell: &Shell,
424
    viewer: &Viewer,
425
    owner: &str,
426
    name: &str,
427
    number: i64,
428
    access: Access,
429
) -> Result<(db::repos::RepoRow, idb::IssueRow, Role), Error> {
430
    let (_, row, role) = lookup_role(app, shell, viewer, owner, name, access).await?;
431
    let i = idb::get(&app.db, row.id, number)
432
        .await
433
        .map_err(|e| Error::from_db(shell.clone(), e))?
434
        .ok_or_else(|| Error::not_found(shell.clone()))?;
435
    Ok((row, i, role))
436
}
437
438
#[derive(Deserialize)]
439
pub struct CommentForm {
440
    #[serde(rename = "_csrf")]
441
    csrf_token: String,
442
    body: String,
443
    #[serde(default)]
444
    close: Option<String>,
445
    #[serde(default)]
446
    reopen: Option<String>,
447
}
448
449
pub async fn comment(
450
    State(app): State<Shared>,
451
    viewer: Viewer,
452
    Path((owner, name, number)): Path<(String, String, i64)>,
453
    Form(f): Form<CommentForm>,
454
) -> Result<Page<IssuePage>, Error> {
455
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issue/{number}"), &viewer);
456
    let me = require(&viewer, &shell)?;
457
    csrf(&viewer, &f.csrf_token, &shell)?;
458
    let (row, i, role) = issue_for(&app, &shell, &viewer, &owner, &name, number, Access::Read).await?;
459
    if i.locked && role < Role::Triage {
460
        return detail(&app, shell, &viewer, &owner, &name, number, None, Some("This issue is locked.".into())).await;
461
    }
462
    if f.body.trim().is_empty() {
463
        return detail(&app, shell, &viewer, &owner, &name, number, None, Some("An empty comment says nothing.".into())).await;
464
    }
465
    let e = |e| Error::from_db(shell.clone(), e);
466
    idb::add_comment(&app.db, i.id, Some(me.account.id), &me.account.username, f.body.trim()).await.map_err(e)?;
467
    let url = format!("/{owner}/{name}/issue/{number}");
468
    let mut kind = "issue.comment";
469
    let may_close = Some(me.account.id) == i.author_id || role >= Role::Triage;
470
    if f.close.is_some() && i.state == "open" && may_close {
471
        idb::set_state(&app.db, i.id, "closed", "completed").await.map_err(e)?;
472
        idb::add_event(&app.db, i.id, &me.account.username, "closed", "").await.ok();
473
        kind = "issue.closed";
474
    } else if f.reopen.is_some() && i.state == "closed" && may_close {
475
        idb::set_state(&app.db, i.id, "open", "").await.map_err(e)?;
476
        idb::add_event(&app.db, i.id, &me.account.username, "reopened", "").await.ok();
477
        kind = "issue.reopened";
478
    }
479
    reindex(&app, row.id, &i).await;
9756c67d Andy McCall ↶ 480
    let hook_event = if kind == "issue.comment" { "comment.issue" } else { kind };
481
    crate::hooks::emit(
482
        &app,
483
        &row,
484
        hook_event,
485
        &me.account.username,
486
        serde_json::json!({ "number": number, "issue": { "number": number, "title": i.title }, "comment": { "body": f.body.trim() } }),
487
    )
488
    .await;
18e381ea Andy McCall ↶ 489
    let direct = i.author_id.into_iter().collect();
490
    notify::deliver(
491
        &app,
492
        Event {
493
            kind,
494
            title: format!("{owner}/{name}#{number}: {}", i.title),
495
            url,
496
            actor: &me.account,
497
            repo_id: row.id,
498
            thread: Some(("issue", i.id)),
499
            mention_text: &f.body,
500
            direct,
501
        },
502
    )
503
    .await;
504
    detail(&app, shell, &viewer, &owner, &name, number, None, None).await
505
}
506
507
pub async fn delete_comment(
508
    State(app): State<Shared>,
509
    viewer: Viewer,
510
    Path((owner, name, number, id)): Path<(String, String, i64, i64)>,
511
    Form(f): Form<super::session::CsrfForm>,
512
) -> Result<Page<IssuePage>, Error> {
513
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issue/{number}"), &viewer);
514
    let me = require(&viewer, &shell)?;
515
    csrf(&viewer, &f.csrf, &shell)?;
516
    let (row, i, role) = issue_for(&app, &shell, &viewer, &owner, &name, number, Access::Read).await?;
517
    let c = idb::comments(&app.db, i.id).await.map_err(|e| Error::from_db(shell.clone(), e))?.into_iter().find(|c| c.id == id);
518
    if let Some(c) = c {
519
        if c.author_id == Some(me.account.id) || role >= Role::Triage {
520
            idb::delete_comment(&app.db, id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
521
            idb::add_event(&app.db, i.id, &me.account.username, "deleted a comment", "").await.ok();
522
            reindex(&app, row.id, &i).await;
523
        }
524
    }
525
    detail(&app, shell, &viewer, &owner, &name, number, None, None).await
526
}
527
528
#[derive(Deserialize)]
529
pub struct EditForm {
530
    #[serde(rename = "_csrf")]
531
    csrf_token: String,
532
    title: String,
533
    #[serde(default)]
534
    body: String,
535
}
536
537
pub async fn edit(
538
    State(app): State<Shared>,
539
    viewer: Viewer,
540
    Path((owner, name, number)): Path<(String, String, i64)>,
541
    Form(f): Form<EditForm>,
542
) -> Result<Page<IssuePage>, Error> {
543
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issue/{number}"), &viewer);
544
    let me = require(&viewer, &shell)?;
545
    csrf(&viewer, &f.csrf_token, &shell)?;
546
    let (row, i, role) = issue_for(&app, &shell, &viewer, &owner, &name, number, Access::Read).await?;
547
    if Some(me.account.id) != i.author_id && role < Role::Triage {
548
        return Err(Error::not_found(shell));
549
    }
550
    if f.title.trim().is_empty() {
551
        return detail(&app, shell, &viewer, &owner, &name, number, None, Some("An issue keeps a title.".into())).await;
552
    }
553
    idb::edit(&app.db, i.id, f.title.trim(), f.body.trim()).await.map_err(|e| Error::from_db(shell.clone(), e))?;
554
    idb::add_event(&app.db, i.id, &me.account.username, "edited", "").await.ok();
555
    if let Ok(Some(fresh)) = idb::get(&app.db, row.id, number).await {
556
        reindex(&app, row.id, &fresh).await;
557
    }
558
    detail(&app, shell, &viewer, &owner, &name, number, Some("Saved.".into()), None).await
559
}
560
561
#[derive(Deserialize)]
562
pub struct StateForm {
563
    #[serde(rename = "_csrf")]
564
    csrf_token: String,
565
    action: String,
566
}
567
568
pub async fn state(
569
    State(app): State<Shared>,
570
    viewer: Viewer,
571
    Path((owner, name, number)): Path<(String, String, i64)>,
572
    Form(f): Form<StateForm>,
573
) -> Result<Page<IssuePage>, Error> {
574
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issue/{number}"), &viewer);
575
    let me = require(&viewer, &shell)?;
576
    csrf(&viewer, &f.csrf_token, &shell)?;
577
    let (row, i, _) = issue_for(&app, &shell, &viewer, &owner, &name, number, Access::Read).await?;
578
    let role = crate::auth::roles::role_for(&app.db, Some(&me.account), &row).await.map_err(|e| Error::from_db(shell.clone(), e))?;
579
    if !crate::auth::roles::allows(role, Access::Read) || (role < Some(Role::Triage) && Some(me.account.id) != i.author_id) {
580
        return Err(Error::not_found(shell));
581
    }
582
    let e = |e| Error::from_db(shell.clone(), e);
583
    let (event, kind) = match f.action.as_str() {
584
        "close" => {
585
            idb::set_state(&app.db, i.id, "closed", "completed").await.map_err(e)?;
586
            ("closed", "issue.closed")
587
        }
588
        "not_planned" => {
589
            idb::set_state(&app.db, i.id, "closed", "not_planned").await.map_err(e)?;
590
            ("closed as not planned", "issue.closed")
591
        }
592
        "reopen" => {
593
            idb::set_state(&app.db, i.id, "open", "").await.map_err(e)?;
594
            ("reopened", "issue.reopened")
595
        }
596
        "lock" if role >= Some(Role::Triage) => {
597
            idb::set_flags(&app.db, i.id, Some(true), None).await.map_err(e)?;
598
            ("locked", "")
599
        }
600
        "unlock" if role >= Some(Role::Triage) => {
601
            idb::set_flags(&app.db, i.id, Some(false), None).await.map_err(e)?;
602
            ("unlocked", "")
603
        }
604
        "pin" if role >= Some(Role::Triage) => {
605
            idb::set_flags(&app.db, i.id, None, Some(true)).await.map_err(e)?;
606
            ("pinned", "")
607
        }
608
        "unpin" if role >= Some(Role::Triage) => {
609
            idb::set_flags(&app.db, i.id, None, Some(false)).await.map_err(e)?;
610
            ("unpinned", "")
611
        }
612
        _ => return Err(Error::bad(shell, "unknown action")),
613
    };
614
    idb::add_event(&app.db, i.id, &me.account.username, event, "").await.ok();
615
    if !kind.is_empty() {
9756c67d Andy McCall ↶ 616
        crate::hooks::emit(
617
            &app,
618
            &row,
619
            kind,
620
            &me.account.username,
621
            serde_json::json!({ "issue": { "number": number, "title": i.title }, "reason": event }),
622
        )
623
        .await;
18e381ea Andy McCall ↶ 624
        let direct = i.author_id.into_iter().collect();
625
        notify::deliver(
626
            &app,
627
            Event {
628
                kind,
629
                title: format!("{owner}/{name}#{number}: {}", i.title),
630
                url: format!("/{owner}/{name}/issue/{number}"),
631
                actor: &me.account,
632
                repo_id: row.id,
633
                thread: Some(("issue", i.id)),
634
                mention_text: "",
635
                direct,
636
            },
637
        )
638
        .await;
639
    }
640
    detail(&app, shell, &viewer, &owner, &name, number, None, None).await
641
}
642
643
#[derive(Deserialize)]
644
pub struct LabelsForm {
645
    #[serde(rename = "_csrf")]
646
    csrf_token: String,
647
    #[serde(default)]
648
    label: Vec<i64>,
649
}
650
651
pub async fn set_labels(
652
    State(app): State<Shared>,
653
    viewer: Viewer,
654
    Path((owner, name, number)): Path<(String, String, i64)>,
655
    axum_extra::extract::Form(f): axum_extra::extract::Form<LabelsForm>,
656
) -> Result<Page<IssuePage>, Error> {
657
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issue/{number}"), &viewer);
658
    let me = require(&viewer, &shell)?;
659
    csrf(&viewer, &f.csrf_token, &shell)?;
660
    let (row, i, _) = issue_for(&app, &shell, &viewer, &owner, &name, number, Access::Read).await?;
661
    let role = crate::auth::roles::role_for(&app.db, Some(&me.account), &row).await.map_err(|e| Error::from_db(shell.clone(), e))?;
662
    if role < Some(Role::Triage) {
663
        return Err(Error::not_found(shell));
664
    }
665
    let e = |e| Error::from_db(shell.clone(), e);
666
    for l in idb::labels(&app.db, row.id).await.map_err(e)? {
667
        idb::set_issue_label(&app.db, i.id, l.id, f.label.contains(&l.id)).await.map_err(e)?;
668
    }
669
    idb::add_event(&app.db, i.id, &me.account.username, "set labels", "").await.ok();
670
    detail(&app, shell, &viewer, &owner, &name, number, None, None).await
671
}
672
673
#[derive(Deserialize)]
674
pub struct AssignForm {
675
    #[serde(rename = "_csrf")]
676
    csrf_token: String,
677
    username: String,
678
    action: String,
679
}
680
681
pub async fn assign(
682
    State(app): State<Shared>,
683
    viewer: Viewer,
684
    Path((owner, name, number)): Path<(String, String, i64)>,
685
    Form(f): Form<AssignForm>,
686
) -> Result<Page<IssuePage>, Error> {
687
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issue/{number}"), &viewer);
688
    let me = require(&viewer, &shell)?;
689
    csrf(&viewer, &f.csrf_token, &shell)?;
690
    let (row, i, role) = issue_for(&app, &shell, &viewer, &owner, &name, number, Access::Read).await?;
691
    if role < Role::Triage {
692
        return Err(Error::not_found(shell));
693
    }
694
    let Some(target) = accounts::account_by_name(&app.db, f.username.trim()).await.map_err(|e| Error::from_db(shell.clone(), e))? else {
695
        return detail(&app, shell, &viewer, &owner, &name, number, None, Some("No such account.".into())).await;
696
    };
697
    let on = f.action == "add";
698
    idb::set_assignee(&app.db, i.id, target.id, on).await.map_err(|e| Error::from_db(shell.clone(), e))?;
699
    idb::add_event(&app.db, i.id, &me.account.username, if on { "assigned" } else { "unassigned" }, &target.username).await.ok();
700
    if on {
701
        notify::deliver(
702
            &app,
703
            Event {
704
                kind: "issue.assigned",
705
                title: format!("{owner}/{name}#{number}: {}", i.title),
706
                url: format!("/{owner}/{name}/issue/{number}"),
707
                actor: &me.account,
708
                repo_id: row.id,
709
                thread: None,
710
                mention_text: "",
711
                direct: vec![target.id],
712
            },
713
        )
714
        .await;
715
        ndb::subscribe(&app.db, target.id, "issue", i.id).await.ok();
716
    }
717
    detail(&app, shell, &viewer, &owner, &name, number, None, None).await
718
}
719
720
#[derive(Deserialize)]
721
pub struct MilestoneForm {
722
    #[serde(rename = "_csrf")]
723
    csrf_token: String,
724
    #[serde(default)]
725
    milestone: String,
726
}
727
728
pub async fn set_milestone(
729
    State(app): State<Shared>,
730
    viewer: Viewer,
731
    Path((owner, name, number)): Path<(String, String, i64)>,
732
    Form(f): Form<MilestoneForm>,
733
) -> Result<Page<IssuePage>, Error> {
734
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issue/{number}"), &viewer);
735
    let me = require(&viewer, &shell)?;
736
    csrf(&viewer, &f.csrf_token, &shell)?;
737
    let (_, i, role) = issue_for(&app, &shell, &viewer, &owner, &name, number, Access::Read).await?;
738
    if role < Role::Triage {
739
        return Err(Error::not_found(shell));
740
    }
741
    let id = f.milestone.trim().parse::<i64>().ok();
742
    idb::set_milestone(&app.db, i.id, id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
743
    idb::add_event(&app.db, i.id, &me.account.username, "set milestone", "").await.ok();
744
    detail(&app, shell, &viewer, &owner, &name, number, None, None).await
745
}
746
747
pub async fn subscribe(
748
    State(app): State<Shared>,
749
    viewer: Viewer,
750
    Path((owner, name, number)): Path<(String, String, i64)>,
751
    Form(f): Form<super::session::CsrfForm>,
752
) -> Result<Page<IssuePage>, Error> {
753
    let shell = Shell::new(&app, &format!("/{owner}/{name}/issue/{number}"), &viewer);
754
    let me = require(&viewer, &shell)?;
755
    csrf(&viewer, &f.csrf, &shell)?;
756
    let (_, i, _) = issue_for(&app, &shell, &viewer, &owner, &name, number, Access::Read).await?;
757
    let e = |e| Error::from_db(shell.clone(), e);
758
    if ndb::subscribed(&app.db, me.account.id, "issue", i.id).await.map_err(e)? {
759
        ndb::unsubscribe(&app.db, me.account.id, "issue", i.id).await.map_err(e)?;
760
    } else {
761
        ndb::subscribe(&app.db, me.account.id, "issue", i.id).await.map_err(e)?;
762
    }
763
    detail(&app, shell, &viewer, &owner, &name, number, None, None).await
764
}
765
766
// ---------------------------------------------------------------- labels
767
768
#[derive(Template)]
769
#[template(path = "labels.html")]
770
pub struct LabelsPage {
771
    shell: Shell,
772
    repo: RepoShell,
773
    labels: Vec<idb::Label>,
774
    can_triage: bool,
775
    notice: Option<String>,
776
}
777
778
pub async fn labels(
779
    State(app): State<Shared>,
780
    viewer: Viewer,
781
    Path((owner, name)): Path<(String, String)>,
782
) -> Result<Page<LabelsPage>, Error> {
783
    let shell = Shell::new(&app, &format!("/{owner}/{name}/labels"), &viewer);
784
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
785
    let labels = idb::labels(&app.db, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
786
    Ok(Page(LabelsPage {
787
        shell,
788
        repo: RepoShell::new(&app, &row, "issues").with_role(role),
789
        labels,
790
        can_triage: role >= Role::Triage,
791
        notice: None,
792
    }))
793
}
794
795
#[derive(Deserialize)]
796
pub struct LabelForm {
797
    #[serde(rename = "_csrf")]
798
    csrf_token: String,
799
    name: String,
800
    #[serde(default = "default_colour")]
801
    colour: String,
802
    #[serde(default)]
803
    description: String,
804
    #[serde(default)]
805
    delete: Option<String>,
806
}
807
808
fn default_colour() -> String {
809
    "#0072ff".into()
810
}
811
812
pub async fn save_label(
813
    State(app): State<Shared>,
814
    viewer: Viewer,
815
    Path((owner, name)): Path<(String, String)>,
816
    Form(f): Form<LabelForm>,
817
) -> Result<Page<LabelsPage>, Error> {
818
    let shell = Shell::new(&app, &format!("/{owner}/{name}/labels"), &viewer);
819
    require(&viewer, &shell)?;
820
    csrf(&viewer, &f.csrf_token, &shell)?;
821
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
822
    if role < Role::Triage {
823
        return Err(Error::not_found(shell));
824
    }
825
    let e = |e| Error::from_db(shell.clone(), e);
826
    let notice = if f.delete.is_some() {
827
        if let Some(l) = idb::label_by_name(&app.db, row.id, f.name.trim()).await.map_err(e)? {
828
            idb::delete_label(&app.db, l.id).await.map_err(e)?;
829
        }
830
        format!("Deleted {}.", f.name.trim())
831
    } else {
832
        let colour = if regex::Regex::new(r"^#[0-9a-fA-F]{6}$").unwrap().is_match(&f.colour) { f.colour.clone() } else { default_colour() };
833
        idb::upsert_label(&app.db, row.id, f.name.trim(), &colour, f.description.trim()).await.map_err(e)?;
834
        format!("Saved {}.", f.name.trim())
835
    };
836
    let labels = idb::labels(&app.db, row.id).await.map_err(e)?;
837
    Ok(Page(LabelsPage {
838
        shell,
839
        repo: RepoShell::new(&app, &row, "issues").with_role(role),
840
        labels,
841
        can_triage: true,
842
        notice: Some(notice),
843
    }))
844
}
845
846
// ------------------------------------------------------------ milestones
847
848
#[derive(Template)]
849
#[template(path = "milestones.html")]
850
pub struct MilestonesPage {
851
    shell: Shell,
852
    repo: RepoShell,
853
    rows: Vec<(idb::Milestone, i64, i64)>,
854
    can_triage: bool,
855
    notice: Option<String>,
856
}
857
858
async fn milestones_page(
859
    app: &Shared,
860
    shell: Shell,
861
    row: db::repos::RepoRow,
862
    role: Role,
863
    notice: Option<String>,
864
) -> Result<Page<MilestonesPage>, Error> {
865
    let mut rows = Vec::new();
866
    for m in idb::milestones(&app.db, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))? {
867
        let (open, closed) = idb::milestone_counts(&app.db, m.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
868
        rows.push((m, open, closed));
869
    }
870
    Ok(Page(MilestonesPage {
871
        shell,
872
        repo: RepoShell::new(app, &row, "issues").with_role(role),
873
        rows,
874
        can_triage: role >= Role::Triage,
875
        notice,
876
    }))
877
}
878
879
pub async fn milestones(
880
    State(app): State<Shared>,
881
    viewer: Viewer,
882
    Path((owner, name)): Path<(String, String)>,
883
) -> Result<Page<MilestonesPage>, Error> {
884
    let shell = Shell::new(&app, &format!("/{owner}/{name}/milestones"), &viewer);
885
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
886
    milestones_page(&app, shell, row, role, None).await
887
}
888
889
#[derive(Deserialize)]
890
pub struct MilestoneSaveForm {
891
    #[serde(rename = "_csrf")]
892
    csrf_token: String,
893
    title: String,
894
    #[serde(default)]
895
    description: String,
896
    #[serde(default)]
897
    due: String,
898
    #[serde(default)]
899
    state: Option<String>,
900
}
901
902
pub async fn save_milestone(
903
    State(app): State<Shared>,
904
    viewer: Viewer,
905
    Path((owner, name)): Path<(String, String)>,
906
    Form(f): Form<MilestoneSaveForm>,
907
) -> Result<Page<MilestonesPage>, Error> {
908
    let shell = Shell::new(&app, &format!("/{owner}/{name}/milestones"), &viewer);
909
    require(&viewer, &shell)?;
910
    csrf(&viewer, &f.csrf_token, &shell)?;
911
    let (_, row, role) = lookup(&app, &shell, &viewer, &owner, &name).await?;
912
    if role < Role::Triage {
913
        return Err(Error::not_found(shell));
914
    }
915
    let e = |e| Error::from_db(shell.clone(), e);
916
    if let Some(state) = f.state.as_deref() {
917
        if let Some(m) = idb::milestones(&app.db, row.id).await.map_err(e)?.into_iter().find(|m| m.title == f.title) {
918
            idb::set_milestone_state(&app.db, m.id, if state == "closed" { "closed" } else { "open" }).await.map_err(e)?;
919
        }
920
        return milestones_page(&app, shell, row, role, Some("Updated.".into())).await;
921
    }
922
    let due_ms = time::Date::parse(f.due.trim(), &time::macros::format_description!("[year]-[month]-[day]"))
923
        .ok()
924
        .map(|d| d.midnight().assume_utc().unix_timestamp() * 1000);
925
    idb::upsert_milestone(&app.db, row.id, f.title.trim(), f.description.trim(), due_ms).await.map_err(e)?;
926
    milestones_page(&app, shell, row, role, Some("Saved.".into())).await
927
}
928
929
// ----------------------------------------------------------------- watch
930
931
pub async fn watch(
932
    State(app): State<Shared>,
933
    viewer: Viewer,
934
    Path((owner, name)): Path<(String, String)>,
935
    Form(f): Form<super::session::CsrfForm>,
936
) -> Result<Response, Error> {
937
    let shell = Shell::new(&app, &format!("/{owner}/{name}"), &viewer);
938
    let me = require(&viewer, &shell)?;
939
    csrf(&viewer, &f.csrf, &shell)?;
940
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
941
    let on = !ndb::watching(&app.db, me.account.id, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
942
    ndb::set_watch(&app.db, me.account.id, row.id, on).await.map_err(|e| Error::from_db(shell.clone(), e))?;
943
    Ok(Redirect::to(&format!("/{owner}/{name}")).into_response())
944
}
945
1553bfc9 Andy McCall ↶ 946
/// Star or unstar a repository.
947
pub async fn star(
948
    State(app): State<Shared>,
949
    viewer: Viewer,
950
    Path((owner, name)): Path<(String, String)>,
951
    Form(f): Form<super::session::CsrfForm>,
952
) -> Result<Response, Error> {
953
    let shell = Shell::new(&app, &format!("/{owner}/{name}"), &viewer);
954
    let me = require(&viewer, &shell)?;
955
    csrf(&viewer, &f.csrf, &shell)?;
956
    let (_, row, _) = lookup(&app, &shell, &viewer, &owner, &name).await?;
957
    db::repos::toggle_star(&app.db, me.account.id, row.id).await.map_err(|e| Error::from_db(shell.clone(), e))?;
958
    Ok(Redirect::to(&format!("/{owner}/{name}")).into_response())
959
}
960
78001759 Andy McCall ↶ 961
/// Put `#N` references of pushed changes on the timelines of those issues
962
/// and proposals: "referenced by change <hash> on <bookmark>".
963
pub async fn references_from_messages(app: &Shared, row: &db::repos::RepoRow, messages: &[(String, String)], bookmark: &str, actor: &str) {
964
    let Ok((issues, proposals)) = idb::numbers(&app.db, row.id).await else { return };
965
    for (hash, message) in messages {
966
        let detail = format!("{} on {bookmark}", &hash[..12.min(hash.len())]);
967
        for n in render::refs::references(message) {
968
            if issues.contains(&n) {
969
                if let Ok(Some(i)) = idb::get(&app.db, row.id, n).await {
970
                    idb::add_event(&app.db, i.id, actor, "referenced by change", &detail).await.ok();
971
                }
972
            } else if proposals.contains(&n) {
973
                if let Ok(Some(p)) = db::proposals::get(&app.db, row.id, n).await {
974
                    db::proposals::add_event(&app.db, p.id, actor, "referenced by change", &detail).await.ok();
975
                }
976
            }
977
        }
978
    }
979
}
980
18e381ea Andy McCall ↶ 981
/// Close issues a landed change's message names (`closes #12`), when the
982
/// landing reached the default bookmark. Called from the push hook and
983
/// the hub's own landing.
984
pub async fn close_from_messages(app: &Shared, row: &db::repos::RepoRow, messages: &[(String, String)]) {
985
    for (hash, message) in messages {
986
        for n in render::refs::closes(message) {
987
            if let Ok(Some(i)) = idb::get(&app.db, row.id, n).await {
988
                if i.state == "open" {
989
                    idb::set_state(&app.db, i.id, "closed", "completed").await.ok();
990
                    idb::add_event(&app.db, i.id, "", "closed by change", &hash[..12.min(hash.len())]).await.ok();
991
                    for id in ndb::subscribers(&app.db, "issue", i.id).await.unwrap_or_default() {
eb0c44a9 Andy McCall ↶ 992
                        let title = format!("{}#{}: {} (closed by {})", row.slug(), i.number, i.title, &hash[..12.min(hash.len())]);
993
                        let url = format!("/{}/issue/{}", row.slug(), i.number);
18e381ea Andy McCall ↶ 994
                        ndb::add(
995
                            &app.db,
eb0c44a9 Andy McCall ↶ 996
                            ndb::New {
997
                                account_id: id,
998
                                repo_id: Some(row.id),
999
                                reason: ndb::Reason::Participating,
1000
                                kind: "issue.closed",
1001
                                title: &title,
1002
                                url: &url,
1003
                                actor: "",
1004
                            },
18e381ea Andy McCall ↶ 1005
                        )
1006
                        .await
1007
                        .ok();
1008
                    }
1009
                }
1010
            }
1011
        }
1012
    }
1013
}