OXYGENHUB
◆ v0.2.0 oxygenhub / crates / hub / tests / api.rs
66.4 KiB · Rust · last changed Device tokens expire and renew on use; the approval page shows the requester (closes #70) 1 month ago source blame history raw
b64e2537 Andy McCall ↶ 1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use std::sync::{Arc, Mutex};
15
use tower::ServiceExt;
16
17
fn hermetic() {
18
    static ONCE: std::sync::Once = std::sync::Once::new();
19
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
20
    ONCE.call_once(|| {
21
        let d = tempfile::tempdir().unwrap();
22
        std::env::set_var("OXY_HOME", d.path());
23
        DIR.set(d).ok();
24
    });
25
}
26
27
fn write(root: &Path, rel: &str, content: &[u8]) {
28
    let p = root.join(rel);
29
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
30
    std::fs::write(p, content).unwrap();
31
}
32
33
struct Hub {
34
    app: Shared,
35
    base: String,
36
    _dir: tempfile::TempDir,
37
}
38
39
async fn hub() -> Hub {
40
    hermetic();
41
    let dir = tempfile::tempdir().unwrap();
42
    let mut config = Config::load(dir.path()).unwrap();
43
    config.auth.push_tokens = vec!["site".into()];
44
    config.registration.mode = "open".into();
45
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
46
    let port = listener.local_addr().unwrap().port();
47
    config.server.base_url = format!("http://127.0.0.1:{port}");
48
    let app = oxygenhub::build(config).await.unwrap();
49
    let router = oxygenhub::router(app.clone());
50
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
51
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
52
}
53
54
struct Res {
55
    status: StatusCode,
56
    body: String,
57
    cookie: Option<String>,
58
}
59
60
async fn call(
61
    app: &Shared,
62
    method: &str,
63
    path: &str,
64
    bearer: Option<&str>,
65
    cookie: Option<&str>,
66
    json: Option<&str>,
67
    form: Option<&str>,
68
) -> Res {
69
    let mut req = Request::builder().method(method).uri(path);
70
    if let Some(b) = bearer {
71
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
72
    }
73
    if let Some(c) = cookie {
74
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
75
    }
76
    let body = if let Some(j) = json {
77
        req = req.header(header::CONTENT_TYPE, "application/json");
78
        Body::from(j.to_string())
79
    } else if let Some(f) = form {
80
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
81
        Body::from(f.to_string())
82
    } else {
83
        Body::empty()
84
    };
85
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
86
    let status = res.status();
87
    let cookie = res
88
        .headers()
89
        .get(header::SET_COOKIE)
90
        .and_then(|v| v.to_str().ok())
91
        .and_then(|v| v.split(';').next())
92
        .and_then(|kv| kv.split_once('='))
93
        .map(|(_, v)| v.to_string());
94
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
95
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
96
}
97
98
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
99
    let r = call(app, method, path, bearer, None, json, None).await;
100
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
101
    (r.status, v)
102
}
103
104
fn csrf_of(page: &str) -> String {
105
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
106
    page[i..].split('"').next().unwrap().to_string()
107
}
108
109
/// A webhook receiver that records what it gets and fails the first time.
110
struct Receiver {
111
    url: String,
112
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
113
    fail_first: Arc<Mutex<bool>>,
114
}
115
116
async fn receiver() -> Receiver {
117
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
118
    let fail_first = Arc::new(Mutex::new(true));
119
    let (s2, f2) = (seen.clone(), fail_first.clone());
120
    let router = Router::new().route(
121
        "/hook",
122
        post(move |headers: header::HeaderMap, body: String| {
123
            let (s2, f2) = (s2.clone(), f2.clone());
124
            async move {
125
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
126
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
127
                let mut f = f2.lock().unwrap();
128
                if *f {
129
                    *f = false;
130
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
131
                }
132
                s2.lock().unwrap().push((event, sig, body));
133
                (StatusCode::OK, "ok")
134
            }
135
        }),
136
    );
137
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
138
    let port = listener.local_addr().unwrap().port();
139
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
140
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
141
}
142
143
#[tokio::test(flavor = "multi_thread")]
144
async fn api_webhooks_and_checks() {
145
    let h = hub().await;
146
    let app = &h.app;
147
    // Accounts and tokens through the pages.
148
    let r =
149
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
150
    let andy = r.cookie.unwrap();
151
    let r =
152
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
153
    let bob = r.cookie.unwrap();
154
    let mint = |cookie: String, scopes: &'static str| {
155
        let app = app.clone();
156
        async move {
157
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
158
            let csrf = csrf_of(&page.body);
159
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
160
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
161
        }
162
    };
163
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
164
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
165
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
166
167
    // Create a repository through the API; the read-only token cannot.
168
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
169
    assert_eq!(st, StatusCode::FORBIDDEN);
170
    let (st, v) = api(
171
        app,
172
        "POST",
173
        "/api/v1/repos",
174
        Some(&andy_admin),
175
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
176
    )
177
    .await;
178
    assert_eq!(st, StatusCode::CREATED, "{v}");
179
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
180
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
181
    assert_eq!(st, StatusCode::CONFLICT);
182
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
183
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
184
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
185
    assert_eq!(st, StatusCode::OK);
186
    assert_eq!(v["username"], "andy");
187
188
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
189
    let rx = receiver().await;
190
    let (st, v) = api(
191
        app,
192
        "POST",
193
        "/api/v1/repos/andy/demo/hooks",
194
        Some(&andy_admin),
195
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
196
    )
197
    .await;
198
    assert_eq!(st, StatusCode::CREATED, "{v}");
199
    let work = tempfile::tempdir().unwrap();
200
    let mut client = Repo::init(work.path()).unwrap();
201
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
202
    client.config.set("remote.origin.token", "site").unwrap();
203
    client.save_config().unwrap();
204
    write(work.path(), "a.txt", b"a\n");
205
    client.snapshot("t").unwrap();
206
    let base = client.commit("base", &[]).unwrap();
207
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
208
    // The worker retries with backoff; drive it directly for the retry.
209
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
210
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
211
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
212
    oxygenhub::hooks::deliver_due(app).await;
213
    let seen = rx.seen.lock().unwrap().clone();
214
    assert_eq!(seen.len(), 1, "{seen:?}");
215
    assert_eq!(seen[0].0, "push");
216
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
217
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
218
    assert_eq!(payload["repository"]["name"], "demo");
219
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
220
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
221
    assert_eq!(v.as_array().unwrap().len(), 1);
222
223
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
224
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
225
    assert_eq!(st, StatusCode::OK);
226
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
227
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
228
    assert_eq!(v[0]["name"], "a.txt");
229
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
230
    assert_eq!(r.body, "a\n");
231
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
232
    assert_eq!(v[0]["change"], base.to_hex());
233
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
234
    assert_eq!(v["files"][0]["path"], "a.txt");
235
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
236
    assert!(v["policy"].is_null());
237
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
238
    assert_eq!(v[0]["reference"], "main");
239
240
    // Issues through the API: Bob opens one, comments, and closes it.
241
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
242
    assert_eq!(st, StatusCode::CREATED, "{v}");
243
    assert_eq!(v["number"], 1);
244
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
245
    assert_eq!(st, StatusCode::CREATED);
246
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
247
    assert_eq!(st, StatusCode::OK, "{v}");
248
    assert_eq!(v["state"], "closed");
249
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
250
    assert_eq!(v[0]["comments"], 1);
251
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
252
    assert_eq!(v[0]["number"], 1);
253
254
    // A proposal through the API, then a required check gates its landing.
255
    client.bookmark_create("feat", Some(&[base])).unwrap();
256
    client.bookmark_switch("feat", false).unwrap();
257
    write(work.path(), "b.txt", b"b\n");
3f02e5ea Andy McCall ↶ 258
    write(work.path(), "a.txt", b"a\nA\n");
b64e2537 Andy McCall ↶ 259
    client.snapshot("t").unwrap();
260
    let feat = client.commit("feat", &[]).unwrap();
261
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
262
    let (st, v) =
263
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
264
            .await;
265
    assert_eq!(st, StatusCode::CREATED, "{v}");
266
    assert_eq!(v["number"], 2);
267
    let state = v["projected_state"].as_str().unwrap().to_string();
268
    assert_eq!(v["landable"], true);
3f02e5ea Andy McCall ↶ 269
    // Its files, and each side's bytes, for editors' diff views.
270
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
271
    assert_eq!(st, StatusCode::OK, "{v}");
272
    let files: Vec<(String, String)> =
273
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
274
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
275
    assert_eq!(v[0]["added"], 1);
276
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
277
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
278
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
279
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
280
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
281
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
c0fac31d Andy McCall ↶ 282
    // An anchored comment comes back with its line in the projected state.
283
    let (st, v) = api(
284
        app,
285
        "POST",
286
        "/api/v1/repos/andy/demo/proposals/2/comments",
287
        Some(&bob_rw),
288
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
289
    )
290
    .await;
291
    assert_eq!(st, StatusCode::CREATED, "{v}");
292
    assert_eq!(v["line"], 2);
293
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
294
    assert_eq!(v[0]["path"], "a.txt");
295
    assert_eq!(v[0]["line"], 2, "{v}");
296
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
b64e2537 Andy McCall ↶ 297
    // Require the "build" check.
298
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
299
    let csrf = csrf_of(&settings.body);
300
    assert_eq!(
301
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
302
            .await
303
            .status,
304
        StatusCode::OK
305
    );
306
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
307
    assert_eq!(v["landable"], false);
308
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
309
    // A checker reports on the projected state: first running, then passed; the page streams it.
310
    let (st, v) = api(
311
        app,
312
        "POST",
313
        "/api/v1/repos/andy/demo/checks",
314
        Some(&andy_ro),
315
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
316
    )
317
    .await;
318
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
319
    let mut events = app.events.proposals.subscribe();
320
    let (st, v) = api(
321
        app,
322
        "POST",
323
        "/api/v1/repos/andy/demo/checks",
324
        Some(&bob_rw),
325
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
326
    )
327
    .await;
328
    assert_eq!(st, StatusCode::CREATED, "{v}");
329
    let (_, ev) = events.recv().await.unwrap();
330
    assert_eq!(ev.kind, "check");
331
    assert_eq!(ev.check.unwrap().name, "build");
332
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
333
    assert_eq!(v[0]["status"], "passed");
334
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
335
    assert_eq!(v["landable"], true, "{v}");
336
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
337
    assert!(page.body.contains("42 tests"), "{}", page.body);
338
    // The check and the proposal reached the webhook too.
339
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
340
    oxygenhub::hooks::deliver_due(app).await;
341
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
342
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
343
    let _ = feat;
344
    let _ = rx.fail_first;
42a0ba4b Andy McCall ↶ 345
346
    // The inbox through the API: count, list, mark one read, mark all read.
347
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
348
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
349
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
eb0c44a9 Andy McCall ↶ 350
    oxygenhub::db::notify::add(
351
        &app.db,
352
        oxygenhub::db::notify::New {
353
            account_id: bob_id,
354
            repo_id: None,
355
            reason: oxygenhub::db::notify::Reason::Participating,
356
            kind: "mention",
357
            title: "andy/demo#1: Bug",
358
            url: "/andy/demo/issue/1",
359
            actor: "andy",
360
        },
361
    )
362
    .await
363
    .unwrap();
364
    oxygenhub::db::notify::add(
365
        &app.db,
366
        oxygenhub::db::notify::New {
367
            account_id: bob_id,
368
            repo_id: None,
369
            reason: oxygenhub::db::notify::Reason::Participating,
370
            kind: "review",
371
            title: "andy/demo#2: Feat",
372
            url: "/andy/demo/proposal/2",
373
            actor: "andy",
374
        },
375
    )
376
    .await
377
    .unwrap();
42a0ba4b Andy McCall ↶ 378
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
379
    assert_eq!(st, StatusCode::OK, "{v}");
380
    assert_eq!(v["unread"], 2);
381
    assert_eq!(v["items"][0]["read"], false);
382
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
383
    let first = v["items"][0]["id"].as_i64().unwrap();
384
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
385
    assert_eq!(st, StatusCode::NO_CONTENT);
386
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
387
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
388
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
389
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
390
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
0b20f1ec Andy McCall ↶ 391
cc1cd197 Andy McCall ↶ 392
    // Review requests: the author asks andy; andy is told, reviews, and the
393
    // request is answered; the author hears of the review.
394
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
395
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
396
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
397
        .await
398
        .unwrap();
399
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
400
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
401
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
402
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
403
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
404
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
405
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
406
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
407
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
408
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
409
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
410
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
411
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
412
    let (st, _) =
413
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
414
    assert_eq!(st, StatusCode::CREATED);
415
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
416
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
417
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
418
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
419
    // Asking again and withdrawing it.
420
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
421
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
422
    assert_eq!(st, StatusCode::NO_CONTENT);
423
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
424
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
425
0b20f1ec Andy McCall ↶ 426
    // A source bookmark with `/` in its name, as a feature/N-name workflow
427
    // makes them: by name, and as this repository's owner/name:bookmark.
428
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
429
        client.bookmark_create(b, Some(&[base])).unwrap();
430
        client.bookmark_switch(b, false).unwrap();
431
        write(work.path(), file, b"c\n");
432
        client.snapshot("t").unwrap();
433
        client.commit(b, &[]).unwrap();
434
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
435
    }
436
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
437
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
438
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
439
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
440
        let n = v["number"].as_i64().unwrap();
441
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
442
        assert_eq!(page.status, StatusCode::OK);
443
        assert!(page.body.contains("feature/"), "the page names its source");
444
    }
445
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
446
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
447
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
b64e2537 Andy McCall ↶ 448
}
76f262e1 Andy McCall ↶ 449
450
#[tokio::test(flavor = "multi_thread")]
451
async fn api_issue_triage_and_labels() {
452
    let h = hub().await;
453
    let app = &h.app;
454
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
455
        .await
456
        .cookie
457
        .unwrap();
458
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
459
        .await
460
        .cookie
461
        .unwrap();
462
    let mint = |cookie: String, scopes: &'static str| {
463
        let app = app.clone();
464
        async move {
465
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
466
            let csrf = csrf_of(&page.body);
467
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
468
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
469
        }
470
    };
471
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
472
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
473
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
474
    assert_eq!(st, StatusCode::CREATED);
475
476
    // Labels through the API; bad colours and non-triage callers are refused.
477
    let (st, v) = api(
478
        app,
479
        "POST",
480
        "/api/v1/repos/andy/demo/labels",
481
        Some(&andy_t),
482
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
483
    )
484
    .await;
485
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
486
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
487
    assert_eq!(
488
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
489
        StatusCode::BAD_REQUEST
490
    );
491
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
492
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
493
    assert_eq!(labels.as_array().unwrap().len(), 2);
494
495
    // An issue created with its labels and assignee in one call.
496
    let (st, v) = api(
497
        app,
498
        "POST",
499
        "/api/v1/repos/andy/demo/issues",
500
        Some(&andy_t),
501
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
502
    )
503
    .await;
504
    assert_eq!(st, StatusCode::CREATED, "{v}");
505
    assert_eq!(v["labels"][0]["name"], "bug");
506
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
507
    let n = v["number"].as_i64().unwrap();
508
    // Unknown names are refused before anything is created.
509
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
510
    assert_eq!(st, StatusCode::BAD_REQUEST);
511
    assert!(v["detail"].as_str().unwrap().contains("no label"));
512
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
513
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
514
    // Without triage, labels cannot be set, but a plain issue can be opened.
515
    assert_eq!(
516
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
517
        StatusCode::FORBIDDEN
518
    );
519
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
520
    assert_eq!(st, StatusCode::CREATED);
521
    let bob_n = bobs["number"].as_i64().unwrap();
522
523
    // PATCH: the whole label set, assignees and milestone, with events.
524
    let (st, v) =
525
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
526
            .await;
527
    assert_eq!(st, StatusCode::OK, "{v}");
528
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
529
    assert_eq!(v["assignees"], serde_json::json!([]));
530
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
531
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
532
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
533
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
534
    // The author edits their own title; others cannot; nobody but triage sets labels.
535
    let (st, v) =
536
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
537
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
538
    assert_eq!(
539
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
540
        StatusCode::FORBIDDEN
541
    );
542
    assert_eq!(
543
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
544
        StatusCode::FORBIDDEN
545
    );
546
    assert_eq!(
547
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
548
        StatusCode::BAD_REQUEST
549
    );
550
551
    // Deleting a label takes it off the issues.
552
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
553
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
554
    assert_eq!(v["labels"], serde_json::json!([]));
555
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
556
}
9756c67d Andy McCall ↶ 557
558
#[tokio::test(flavor = "multi_thread")]
559
async fn webhook_formats_editing_and_web_issue_events() {
560
    let h = hub().await;
561
    let app = &h.app;
562
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
563
        .await
564
        .cookie
565
        .unwrap();
566
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
567
    let r = call(
568
        app,
569
        "POST",
570
        "/settings/tokens",
571
        None,
572
        Some(&andy),
573
        None,
574
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
575
    )
576
    .await;
577
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
578
    assert_eq!(
579
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
580
        StatusCode::CREATED
581
    );
582
    let rx = receiver().await;
583
    *rx.fail_first.lock().unwrap() = false;
584
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
585
    let csrf = csrf_of(&settings);
586
    let form = |f: String| {
587
        let andy = andy.clone();
588
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
589
    };
590
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
591
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
592
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
593
    assert_eq!(hook.format, "discord");
594
    // Ping arrives as a Discord message.
595
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
596
    let mut got = String::new();
597
    for _ in 0..100 {
598
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
599
            got = body.clone();
600
        }
601
        if !got.is_empty() {
602
            break;
603
        }
604
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
605
    }
606
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
607
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
608
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
609
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
610
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
611
612
    // Editing: a blank URL and secret keep theirs; format, events and active change.
613
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
614
        .await
615
        .contains("Webhook saved"));
616
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
617
    assert_eq!(
618
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
619
        (rx.url.as_str(), "issue", "oxygenhub", true)
620
    );
621
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
622
623
    // An issue opened on the web now reaches the hook, as the signed envelope.
624
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
625
    call(
626
        app,
627
        "POST",
628
        "/andy/demo/issues/new",
629
        None,
630
        Some(&andy),
631
        None,
632
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
633
    )
634
    .await;
635
    let mut envelope = None;
636
    for _ in 0..100 {
637
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
638
        if envelope.is_some() {
639
            break;
640
        }
641
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
642
    }
643
    let (_, sig, body) = envelope.expect("issue.opened delivered");
644
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
645
    assert_eq!(v["data"]["issue"]["title"], "From the web");
646
    assert!(sig.starts_with("blake3-keyed="));
647
    // A disabled hook through the edit form (no active box).
648
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
649
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
650
}
ef20fdc1 Andy McCall ↶ 651
652
#[tokio::test(flavor = "multi_thread")]
653
async fn api_projects() {
654
    let h = hub().await;
655
    let app = &h.app;
656
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
657
        .await
658
        .cookie
659
        .unwrap();
660
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
661
        .await
662
        .cookie
663
        .unwrap();
664
    let mint = |cookie: String, scopes: &'static str| {
665
        let app = app.clone();
666
        async move {
667
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
668
            let csrf = csrf_of(&page.body);
669
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
670
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
671
        }
672
    };
673
    let a = mint(andy, "scopes=repo%3Aadmin").await;
674
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
675
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
676
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
677
678
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
679
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
680
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
681
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
682
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
683
684
    // Cards by reference, into a column by name, and a note into the first column.
685
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
686
    assert_eq!(st, StatusCode::CREATED, "{card}");
687
    assert_eq!(
688
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
689
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
690
    );
691
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
692
    assert_eq!(st, StatusCode::BAD_REQUEST);
693
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
694
    assert_eq!(
695
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
696
        StatusCode::BAD_REQUEST
697
    );
698
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
699
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
700
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
701
702
    // Move and read the board.
703
    let id = card["id"].as_i64().unwrap();
704
    assert_eq!(
705
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
706
        StatusCode::NO_CONTENT
707
    );
708
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
709
    let names: Vec<(&str, usize)> =
710
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
711
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
712
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
713
714
    // Private: hidden from others; closed: read-only; then remove a card.
715
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
716
    assert_eq!(edited["public"], false);
717
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
718
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
719
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
720
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
721
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
722
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
723
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
724
}
961c10be Andy McCall ↶ 725
726
#[tokio::test(flavor = "multi_thread")]
727
async fn api_required_checks() {
728
    let h = hub().await;
729
    let app = &h.app;
730
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
731
        .await
732
        .cookie
733
        .unwrap();
734
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
735
    let csrf = csrf_of(&page.body);
736
    let mint = |scopes: &'static str| {
737
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
738
        async move {
739
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
740
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
741
        }
742
    };
743
    let admin = mint("scopes=repo%3Aadmin").await;
744
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
745
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
746
747
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
748
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
749
    let (st, v) = api(
750
        app,
751
        "PUT",
752
        "/api/v1/repos/andy/demo/checks/required",
753
        Some(&admin),
754
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
755
    )
756
    .await;
757
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
758
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
759
    assert_eq!(
760
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
761
        serde_json::json!(["flow/fmt", "flow/test"])
762
    );
763
    assert_eq!(
764
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
765
        StatusCode::FORBIDDEN,
766
        "repo:admin only"
767
    );
768
    assert_eq!(
769
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
770
        StatusCode::BAD_REQUEST
771
    );
772
    // The settings page shows the same list.
773
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
774
}
9008bf6c Andy McCall ↶ 775
776
/// OxygenFlow per repository: site administrators turn it on or off in
777
/// the repository's settings; hub.toml's `[flow] repos` is the default.
778
#[tokio::test(flavor = "multi_thread")]
779
async fn flow_is_switched_per_repository_by_site_admins() {
780
    let h = hub().await;
781
    let app = &h.app;
782
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
783
        .await
784
        .cookie
785
        .unwrap();
786
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
787
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
788
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
789
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
790
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
791
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
792
793
    let set = |value: &'static str| {
794
        let (app, andy) = (app.clone(), andy.clone());
795
        async move {
796
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
797
            call(
798
                &app,
799
                "POST",
800
                "/andy/demo/settings/flow",
801
                None,
802
                Some(&andy),
803
                None,
804
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
805
            )
806
            .await
807
        }
808
    };
809
    // A repository admin who is not a site admin sees the state but cannot change it.
810
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
811
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
812
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
813
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
814
    let r = set("on").await;
815
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
816
    assert_eq!(row().await.flow, "");
817
818
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
819
    let r = set("on").await;
820
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
821
    assert_eq!(row().await.flow, "on");
822
    assert!(oxygenhub::flow::enabled(app, &row().await));
823
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
824
    set("off").await;
825
    assert!(!oxygenhub::flow::enabled(app, &row().await));
826
    set("default").await;
827
    assert_eq!(row().await.flow, "");
828
    assert!(set("sometimes").await.body.contains("Pick on, off"));
829
}
e271a37b Andy McCall ↶ 830
831
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
832
/// button, never the repository's default bookmark as the hub sets it.
833
#[tokio::test(flavor = "multi_thread")]
834
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
835
    let h = hub().await;
836
    let app = &h.app;
837
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
838
        .await
839
        .cookie
840
        .unwrap();
841
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
842
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
843
    let url = format!("{}/andy/demo", h.base);
844
    let work = tempfile::tempdir().unwrap();
845
    let (w, u) = (work.path().to_path_buf(), url.clone());
846
    let client = tokio::task::spawn_blocking(move || {
847
        let mut c = Repo::init(&w).unwrap();
848
        c.config.set("remote.origin.url", &u).unwrap();
849
        c.config.set("remote.origin.token", "site").unwrap();
850
        c.save_config().unwrap();
851
        write(&w, "a.txt", b"a\n");
852
        c.commit("a", &[]).unwrap();
853
        assert!(c.push("origin", false).unwrap()[0].ok);
854
        for b in ["develop", "feature/x", "stray"] {
855
            c.bookmark_create(b, None).unwrap();
856
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
857
        }
858
        // A pushed deletion.
859
        let r = c.push_delete("origin", "feature/x").unwrap();
860
        assert!(r[0].ok, "{r:?}");
861
        c
862
    })
863
    .await
864
    .unwrap();
865
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
866
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
867
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
868
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
869
    assert!(!anon.body.contains("/bookmarks/delete"));
870
871
    // The hub's default, not the repository's config, is protected: make
872
    // develop the default, then main can go and develop cannot.
873
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
874
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
875
    let client = tokio::task::spawn_blocking(move || {
876
        let r = client.push_delete("origin", "develop").unwrap();
877
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
878
        let r = client.push_delete("origin", "main").unwrap();
879
        assert!(r[0].ok, "{r:?}");
880
        client
881
    })
882
    .await
883
    .unwrap();
884
    drop(client);
885
886
    // On the web: a writer deletes stray; the default is refused.
887
    let form = |b: &'static str| {
888
        let (app, andy) = (app.clone(), andy.clone());
889
        async move {
890
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
891
            call(
892
                &app,
893
                "POST",
894
                "/andy/demo/bookmarks/delete",
895
                None,
896
                Some(&andy),
897
                None,
898
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
899
            )
900
            .await
901
        }
902
    };
903
    let r = form("stray").await;
904
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
905
    assert!(!r.body.contains(">stray<"));
906
    let r = form("develop").await;
907
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
908
    let r = form("nope").await;
909
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
910
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
911
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
912
    // Anonymous visitors cannot.
913
    assert_ne!(
914
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
915
        StatusCode::OK
916
    );
917
}
760a7dd3 Andy McCall ↶ 918
919
/// A change signed by a key no account has linked says so, on its page
920
/// and in the API (feedback 14).
921
#[tokio::test(flavor = "multi_thread")]
922
async fn changes_signed_by_unlinked_keys_say_so() {
923
    let h = hub().await;
924
    let app = &h.app;
925
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
926
        .await
927
        .cookie
928
        .unwrap();
929
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
930
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
931
    let url = format!("{}/andy/demo", h.base);
932
    let work = tempfile::tempdir().unwrap();
933
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
934
    let hash = tokio::task::spawn_blocking(move || {
935
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
936
        c.config.set("remote.origin.url", &u).unwrap();
937
        c.config.set("remote.origin.token", "site").unwrap();
938
        c.save_config().unwrap();
939
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
940
        write(&w.join("r"), "a.txt", b"a\n");
941
        let h = c.commit("signed by Ada", &[]).unwrap();
942
        assert!(c.push("origin", false).unwrap()[0].ok);
943
        h.to_hex()
944
    })
945
    .await
946
    .unwrap();
947
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
948
    assert_eq!(st, StatusCode::OK, "{v}");
949
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
950
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
951
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
952
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
953
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
954
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
955
}
65be9f9c Andy McCall ↶ 956
957
/// Function history (hub spec §6.6): the file page lists a file's
958
/// functions, and a function's page lists exactly the changes to its lines.
959
#[tokio::test(flavor = "multi_thread")]
960
async fn a_function_has_its_own_history() {
961
    let h = hub().await;
962
    let app = &h.app;
963
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
964
        .await
965
        .cookie
966
        .unwrap();
967
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
968
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
969
    let url = format!("{}/andy/demo", h.base);
970
    let work = tempfile::tempdir().unwrap();
971
    let w = work.path().to_path_buf();
972
    tokio::task::spawn_blocking(move || {
973
        let mut c = Repo::init(&w).unwrap();
974
        c.config.set("remote.origin.url", &url).unwrap();
975
        c.config.set("remote.origin.token", "site").unwrap();
976
        c.save_config().unwrap();
977
        let steps = [
978
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
979
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
980
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
981
        ];
982
        for (msg, text) in steps {
983
            write(&w, "src/lib.rs", text.as_bytes());
984
            c.commit(msg, &[]).unwrap();
985
        }
986
        assert!(c.push("origin", false).unwrap()[0].ok);
987
    })
988
    .await
989
    .unwrap();
990
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
991
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
992
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
993
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
994
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
995
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
996
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
997
    assert_ne!(bad.status, StatusCode::OK);
998
}
92574625 Andy McCall ↶ 999
1000
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1001
/// dependency edges, linked cards.
1002
#[tokio::test(flavor = "multi_thread")]
1003
async fn a_bookmark_shows_as_swimlanes() {
1004
    let h = hub().await;
1005
    let app = &h.app;
1006
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1007
        .await
1008
        .cookie
1009
        .unwrap();
1010
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1011
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1012
    let url = format!("{}/andy/demo", h.base);
1013
    let work = tempfile::tempdir().unwrap();
1014
    let w = work.path().to_path_buf();
1015
    tokio::task::spawn_blocking(move || {
1016
        let mut c = Repo::init(&w).unwrap();
1017
        c.config.set("remote.origin.url", &url).unwrap();
1018
        c.config.set("remote.origin.token", "site").unwrap();
1019
        c.save_config().unwrap();
1020
        // Two files edited independently: two lanes.
1021
        write(&w, "a.txt", b"a\n");
1022
        c.commit("add a", &[]).unwrap();
1023
        write(&w, "b.txt", b"b\n");
1024
        c.commit("add b", &[]).unwrap();
1025
        write(&w, "a.txt", b"a\na2\n");
1026
        c.commit("grow a", &[]).unwrap();
1027
        assert!(c.push("origin", false).unwrap()[0].ok);
1028
    })
1029
    .await
1030
    .unwrap();
1031
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1032
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1033
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1034
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1035
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1036
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1037
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1038
    assert_eq!(board.matches("<rect ").count(), 3);
1039
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1040
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1041
}
2bfe5ef6 Andy McCall ↶ 1042
1043
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1044
/// offers only what makes sense and rewrites nothing itself.
1045
#[tokio::test(flavor = "multi_thread")]
1046
async fn a_proposal_board_plans_squashes_and_rebases() {
1047
    let h = hub().await;
1048
    let app = &h.app;
1049
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1050
        .await
1051
        .cookie
1052
        .unwrap();
1053
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1054
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1055
    let url = format!("{}/andy/demo", h.base);
1056
    let work = tempfile::tempdir().unwrap();
1057
    let w = work.path().to_path_buf();
1058
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1059
        let mut c = Repo::init(&w).unwrap();
1060
        c.config.set("remote.origin.url", &url).unwrap();
1061
        c.config.set("remote.origin.token", "site").unwrap();
1062
        c.save_config().unwrap();
1063
        write(&w, "a.txt", b"a\n");
1064
        let base = c.commit("base", &[]).unwrap();
1065
        assert!(c.push("origin", false).unwrap()[0].ok);
1066
        c.bookmark_create("feature", None).unwrap();
1067
        c.bookmark_switch("feature", false).unwrap();
1068
        write(&w, "a.txt", b"a\nfirst\n");
1069
        let first = c.commit("first", &[]).unwrap();
1070
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1071
        let second = c.commit("second", &[]).unwrap();
1072
        write(&w, "b.txt", b"apart\n");
1073
        let apart = c.commit("apart", &[]).unwrap();
1074
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1075
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1076
    })
1077
    .await
1078
    .unwrap();
1079
    // No proposal yet: the board is read-only.
1080
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1081
    assert!(!board.contains("data-plan="));
1082
    let (st, _) = api(
1083
        app,
1084
        "POST",
1085
        "/api/v1/repos/andy/demo/proposals",
1086
        Some("site"),
1087
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1088
    )
1089
    .await;
1090
    assert!(st.is_success(), "{st}");
1091
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1092
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1093
    let csrf = csrf_of(&board);
1094
    let plan = |c: &str, t: &str| {
1095
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1096
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1097
        async move {
1098
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1099
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1100
        }
1101
    };
1102
    let kinds = |v: &serde_json::Value| {
1103
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1104
    };
1105
    // second already depends on first: squash, no rebase.
1106
    let v = plan(&second, &first).await;
1107
    assert_eq!(kinds(&v), ["squash"], "{v}");
1108
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
c96b3286 Andy McCall ↶ 1109
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
2bfe5ef6 Andy McCall ↶ 1110
    // apart is independent of second: either.
1111
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1112
    // first under second: nothing (second depends on first).
1113
    assert!(plan(&first, &second).await["error"].is_string());
1114
    // What has landed on main is not rearranged.
1115
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1116
}
38833ed7 Andy McCall ↶ 1117
1118
/// Issues and proposals share a number space, so every number says what it
1119
/// is, and the chain of work shows from both ends (hub spec §8).
1120
#[tokio::test(flavor = "multi_thread")]
1121
async fn proposals_and_issues_show_their_chain() {
1122
    let h = hub().await;
1123
    let app = &h.app;
1124
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1125
        .await
1126
        .cookie
1127
        .unwrap();
1128
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1129
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1130
    let url = format!("{}/andy/demo", h.base);
1131
    let work = tempfile::tempdir().unwrap();
1132
    let w = work.path().to_path_buf();
1133
    tokio::task::spawn_blocking(move || {
1134
        let mut c = Repo::init(&w).unwrap();
1135
        c.config.set("remote.origin.url", &url).unwrap();
1136
        c.config.set("remote.origin.token", "site").unwrap();
1137
        c.save_config().unwrap();
1138
        write(&w, "a.txt", b"a\n");
1139
        c.commit("base", &[]).unwrap();
1140
        assert!(c.push("origin", false).unwrap()[0].ok);
1141
        c.bookmark_create("feature", None).unwrap();
1142
        c.bookmark_switch("feature", false).unwrap();
1143
        write(&w, "a.txt", b"a\nfixed\n");
1144
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1145
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1146
    })
1147
    .await
1148
    .unwrap();
1149
    for title in ["Slow start", "Crash on save"] {
1150
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1151
        assert!(st.is_success());
1152
    }
1153
    let (st, v) = api(
1154
        app,
1155
        "POST",
1156
        "/api/v1/repos/andy/demo/proposals",
1157
        Some("site"),
1158
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1159
    )
1160
    .await;
1161
    assert!(st.is_success(), "{st} {v}");
1162
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1163
1164
    // The proposal names its kind, links its references by kind, and shows
1165
    // the chain: the issues it closes (description and changes) → it → main.
1166
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1167
    assert!(p.contains(">proposal #3</small>"), "header");
1168
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1169
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1170
    let chain = &chain[..chain.find("</p>").unwrap()];
1171
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1172
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1173
    }
1174
    assert!(p.contains("<h3>Closes</h3>"));
1175
1176
    // The issue shows the proposal that closes it, and names its own kind.
1177
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1178
    assert!(i.contains(">issue #1</small>"));
1179
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1180
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
a1b98695 Andy McCall ↶ 1181
    // The conversation is a timeline with avatars; editing sits with the
1182
    // content, not in the sidebar, and labels and projects are editable.
1183
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1184
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1185
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1186
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1187
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1188
    assert!(st.is_success(), "{st}");
1189
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1190
    assert!(p.contains("<option value=\"1\">Board</option>"), "the owner's projects to add to");
1191
    let csrf = csrf_of(&p);
1192
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1193
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1194
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1195
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1196
        .await;
1197
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1198
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1199
38833ed7 Andy McCall ↶ 1200
    // Closed by the proposal's change, not its description: still shown.
1201
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1202
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1203
    assert!(chain.contains("proposal #3"), "{chain}");
1204
}
e9bfea8e Andy McCall ↶ 1205
1206
/// What the hub is: its version and build, and the libraries it is built on,
1207
/// on /about, in the API and in /health (hub spec §15).
1208
#[tokio::test(flavor = "multi_thread")]
1209
async fn the_hub_says_what_version_it_is() {
1210
    let h = hub().await;
1211
    let app = &h.app;
1212
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1213
    assert_eq!(st, StatusCode::OK);
1214
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1215
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1216
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1217
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1218
    assert!(health.contains("\"build\""), "{health}");
1219
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1220
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1221
    assert!(about.contains("href=\"/about\""), "the footer links here");
1222
}
df71c789 Andy McCall ↶ 1223
1224
#[tokio::test(flavor = "multi_thread")]
1225
async fn device_sign_in() {
1226
    let h = hub().await;
1227
    let app = &h.app;
1228
    let r =
1229
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1230
    let andy = r.cookie.unwrap();
1231
1232
    // An unknown scope is refused.
1233
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1234
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1235
1236
    // The app asks for a code and polls; nobody has approved it yet.
1237
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1238
    assert_eq!(st, StatusCode::OK, "{v}");
1239
    let device = v["device_code"].as_str().unwrap().to_string();
1240
    let user = v["user_code"].as_str().unwrap().to_string();
1241
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1242
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1243
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1244
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1245
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1246
    assert_eq!(v["error"], "slow_down", "polled too soon");
1247
1248
    // The user approves it on the web, allowing less than it asked for.
1249
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1250
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1251
    let csrf = csrf_of(&page.body);
1252
    let r =
1253
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1254
            .await;
1255
    assert!(r.body.contains("Approved"), "{}", r.body);
1256
1257
    // The next poll gets a token with what was allowed, once.
1258
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1259
    assert_eq!(st, StatusCode::OK, "{v}");
1260
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1261
    let token = v["access_token"].as_str().unwrap().to_string();
1262
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1263
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1264
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1265
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1266
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1267
    assert!(tokens.body.contains("device: Phone app"));
60f11b71 Andy McCall ↶ 1268
    // oxygenhub#70: a device's token expires, and each use renews it.
1269
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
df71c789 Andy McCall ↶ 1270
60f11b71 Andy McCall ↶ 1271
    // The token can revoke itself (oxy auth logout), and is then refused.
1272
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1273
    assert_eq!(st, StatusCode::NO_CONTENT);
1274
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1275
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1276
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1277
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1278
df71c789 Andy McCall ↶ 1279
    // A denied code says so.
1280
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1281
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1282
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1283
    let csrf = csrf_of(&page.body);
1284
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1285
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1286
    assert_eq!(v["error"], "access_denied");
1287
1288
    // Signed out, the page asks for a sign-in first.
1289
    let r = call(app, "GET", "/device", None, None, None, None).await;
1290
    assert!(r.status.is_redirection(), "{}", r.status);
1291
}