OXYGENHUB
◆ v0.3.0 oxygenhub / crates / hub / tests / api.rs
68.1 KiB · Rust · last changed Edit a proposal through the API; oh proposal edit, comment and create -F 1 month ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use std::sync::{Arc, Mutex};
15
use tower::ServiceExt;
16
17
fn hermetic() {
18
    static ONCE: std::sync::Once = std::sync::Once::new();
19
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
20
    ONCE.call_once(|| {
21
        let d = tempfile::tempdir().unwrap();
22
        std::env::set_var("OXY_HOME", d.path());
23
        DIR.set(d).ok();
24
    });
25
}
26
27
fn write(root: &Path, rel: &str, content: &[u8]) {
28
    let p = root.join(rel);
29
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
30
    std::fs::write(p, content).unwrap();
31
}
32
33
struct Hub {
34
    app: Shared,
35
    base: String,
36
    _dir: tempfile::TempDir,
37
}
38
39
async fn hub() -> Hub {
40
    hermetic();
41
    let dir = tempfile::tempdir().unwrap();
42
    let mut config = Config::load(dir.path()).unwrap();
43
    config.auth.push_tokens = vec!["site".into()];
44
    config.registration.mode = "open".into();
45
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
46
    let port = listener.local_addr().unwrap().port();
47
    config.server.base_url = format!("http://127.0.0.1:{port}");
48
    let app = oxygenhub::build(config).await.unwrap();
49
    let router = oxygenhub::router(app.clone());
50
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
51
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
52
}
53
54
struct Res {
55
    status: StatusCode,
56
    body: String,
57
    cookie: Option<String>,
58
}
59
60
async fn call(
61
    app: &Shared,
62
    method: &str,
63
    path: &str,
64
    bearer: Option<&str>,
65
    cookie: Option<&str>,
66
    json: Option<&str>,
67
    form: Option<&str>,
68
) -> Res {
69
    let mut req = Request::builder().method(method).uri(path);
70
    if let Some(b) = bearer {
71
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
72
    }
73
    if let Some(c) = cookie {
74
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
75
    }
76
    let body = if let Some(j) = json {
77
        req = req.header(header::CONTENT_TYPE, "application/json");
78
        Body::from(j.to_string())
79
    } else if let Some(f) = form {
80
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
81
        Body::from(f.to_string())
82
    } else {
83
        Body::empty()
84
    };
85
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
86
    let status = res.status();
87
    let cookie = res
88
        .headers()
89
        .get(header::SET_COOKIE)
90
        .and_then(|v| v.to_str().ok())
91
        .and_then(|v| v.split(';').next())
92
        .and_then(|kv| kv.split_once('='))
93
        .map(|(_, v)| v.to_string());
94
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
95
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
96
}
97
98
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
99
    let r = call(app, method, path, bearer, None, json, None).await;
100
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
101
    (r.status, v)
102
}
103
104
fn csrf_of(page: &str) -> String {
105
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
106
    page[i..].split('"').next().unwrap().to_string()
107
}
108
109
/// A webhook receiver that records what it gets and fails the first time.
110
struct Receiver {
111
    url: String,
112
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
113
    fail_first: Arc<Mutex<bool>>,
114
}
115
116
async fn receiver() -> Receiver {
117
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
118
    let fail_first = Arc::new(Mutex::new(true));
119
    let (s2, f2) = (seen.clone(), fail_first.clone());
120
    let router = Router::new().route(
121
        "/hook",
122
        post(move |headers: header::HeaderMap, body: String| {
123
            let (s2, f2) = (s2.clone(), f2.clone());
124
            async move {
125
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
126
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
127
                let mut f = f2.lock().unwrap();
128
                if *f {
129
                    *f = false;
130
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
131
                }
132
                s2.lock().unwrap().push((event, sig, body));
133
                (StatusCode::OK, "ok")
134
            }
135
        }),
136
    );
137
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
138
    let port = listener.local_addr().unwrap().port();
139
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
140
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
141
}
142
143
#[tokio::test(flavor = "multi_thread")]
144
async fn api_webhooks_and_checks() {
145
    let h = hub().await;
146
    let app = &h.app;
147
    // Accounts and tokens through the pages.
148
    let r =
149
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
150
    let andy = r.cookie.unwrap();
151
    let r =
152
        call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery")).await;
153
    let bob = r.cookie.unwrap();
154
    let mint = |cookie: String, scopes: &'static str| {
155
        let app = app.clone();
156
        async move {
157
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
158
            let csrf = csrf_of(&page.body);
159
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
160
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
161
        }
162
    };
163
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
164
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
165
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
166
167
    // Create a repository through the API; the read-only token cannot.
168
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
169
    assert_eq!(st, StatusCode::FORBIDDEN);
170
    let (st, v) = api(
171
        app,
172
        "POST",
173
        "/api/v1/repos",
174
        Some(&andy_admin),
175
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
176
    )
177
    .await;
178
    assert_eq!(st, StatusCode::CREATED, "{v}");
179
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
180
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
181
    assert_eq!(st, StatusCode::CONFLICT);
182
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
183
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
184
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
185
    assert_eq!(st, StatusCode::OK);
186
    assert_eq!(v["username"], "andy");
187
188
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
189
    let rx = receiver().await;
190
    let (st, v) = api(
191
        app,
192
        "POST",
193
        "/api/v1/repos/andy/demo/hooks",
194
        Some(&andy_admin),
195
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
196
    )
197
    .await;
198
    assert_eq!(st, StatusCode::CREATED, "{v}");
199
    let work = tempfile::tempdir().unwrap();
200
    let mut client = Repo::init(work.path()).unwrap();
201
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
202
    client.config.set("remote.origin.token", "site").unwrap();
203
    client.save_config().unwrap();
204
    write(work.path(), "a.txt", b"a\n");
205
    client.snapshot("t").unwrap();
206
    let base = client.commit("base", &[]).unwrap();
207
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
208
    // The worker retries with backoff; drive it directly for the retry.
209
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
210
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
211
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
212
    oxygenhub::hooks::deliver_due(app).await;
213
    let seen = rx.seen.lock().unwrap().clone();
214
    assert_eq!(seen.len(), 1, "{seen:?}");
215
    assert_eq!(seen[0].0, "push");
216
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
217
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
218
    assert_eq!(payload["repository"]["name"], "demo");
219
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
220
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
221
    assert_eq!(v.as_array().unwrap().len(), 1);
222
223
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
224
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
225
    assert_eq!(st, StatusCode::OK);
226
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
227
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
228
    assert_eq!(v[0]["name"], "a.txt");
229
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
230
    assert_eq!(r.body, "a\n");
231
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
232
    assert_eq!(v[0]["change"], base.to_hex());
233
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
234
    assert_eq!(v["files"][0]["path"], "a.txt");
235
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
236
    assert!(v["policy"].is_null());
237
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
238
    assert_eq!(v[0]["reference"], "main");
239
240
    // Issues through the API: Bob opens one, comments, and closes it.
241
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
242
    assert_eq!(st, StatusCode::CREATED, "{v}");
243
    assert_eq!(v["number"], 1);
244
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
245
    assert_eq!(st, StatusCode::CREATED);
246
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
247
    assert_eq!(st, StatusCode::OK, "{v}");
248
    assert_eq!(v["state"], "closed");
249
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
250
    assert_eq!(v[0]["comments"], 1);
251
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
252
    assert_eq!(v[0]["number"], 1);
253
254
    // A proposal through the API, then a required check gates its landing.
255
    client.bookmark_create("feat", Some(&[base])).unwrap();
256
    client.bookmark_switch("feat", false).unwrap();
257
    write(work.path(), "b.txt", b"b\n");
258
    write(work.path(), "a.txt", b"a\nA\n");
259
    client.snapshot("t").unwrap();
260
    let feat = client.commit("feat", &[]).unwrap();
261
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
262
    let (st, v) =
263
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
264
            .await;
265
    assert_eq!(st, StatusCode::CREATED, "{v}");
266
    assert_eq!(v["number"], 2);
267
    let state = v["projected_state"].as_str().unwrap().to_string();
268
    assert_eq!(v["landable"], true);
269
    // Its files, and each side's bytes, for editors' diff views.
270
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
271
    assert_eq!(st, StatusCode::OK, "{v}");
272
    let files: Vec<(String, String)> =
273
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
274
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
275
    assert_eq!(v[0]["added"], 1);
276
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
277
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
278
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
279
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
280
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
281
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
282
    // An anchored comment comes back with its line in the projected state.
283
    let (st, v) = api(
284
        app,
285
        "POST",
286
        "/api/v1/repos/andy/demo/proposals/2/comments",
287
        Some(&bob_rw),
288
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
289
    )
290
    .await;
291
    assert_eq!(st, StatusCode::CREATED, "{v}");
292
    assert_eq!(v["line"], 2);
293
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
294
    assert_eq!(v[0]["path"], "a.txt");
295
    assert_eq!(v[0]["line"], 2, "{v}");
296
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
297
    // Require the "build" check.
298
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
299
    let csrf = csrf_of(&settings.body);
300
    assert_eq!(
301
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
302
            .await
303
            .status,
304
        StatusCode::OK
305
    );
306
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
307
    assert_eq!(v["landable"], false);
308
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
309
    // A checker reports on the projected state: first running, then passed; the page streams it.
310
    let (st, v) = api(
311
        app,
312
        "POST",
313
        "/api/v1/repos/andy/demo/checks",
314
        Some(&andy_ro),
315
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
316
    )
317
    .await;
318
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
319
    let mut events = app.events.proposals.subscribe();
320
    let (st, v) = api(
321
        app,
322
        "POST",
323
        "/api/v1/repos/andy/demo/checks",
324
        Some(&bob_rw),
325
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
326
    )
327
    .await;
328
    assert_eq!(st, StatusCode::CREATED, "{v}");
329
    let (_, ev) = events.recv().await.unwrap();
330
    assert_eq!(ev.kind, "check");
331
    assert_eq!(ev.check.unwrap().name, "build");
332
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
333
    assert_eq!(v[0]["status"], "passed");
334
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
335
    assert_eq!(v["landable"], true, "{v}");
336
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
337
    assert!(page.body.contains("42 tests"), "{}", page.body);
338
    // The check and the proposal reached the webhook too.
339
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
340
    oxygenhub::hooks::deliver_due(app).await;
341
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
342
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
343
    let _ = feat;
344
    let _ = rx.fail_first;
345
346
    // The inbox through the API: count, list, mark one read, mark all read.
347
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
348
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
349
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
350
    oxygenhub::db::notify::add(
351
        &app.db,
352
        oxygenhub::db::notify::New {
353
            account_id: bob_id,
354
            repo_id: None,
355
            reason: oxygenhub::db::notify::Reason::Participating,
356
            kind: "mention",
357
            title: "andy/demo#1: Bug",
358
            url: "/andy/demo/issue/1",
359
            actor: "andy",
360
        },
361
    )
362
    .await
363
    .unwrap();
364
    oxygenhub::db::notify::add(
365
        &app.db,
366
        oxygenhub::db::notify::New {
367
            account_id: bob_id,
368
            repo_id: None,
369
            reason: oxygenhub::db::notify::Reason::Participating,
370
            kind: "review",
371
            title: "andy/demo#2: Feat",
372
            url: "/andy/demo/proposal/2",
373
            actor: "andy",
374
        },
375
    )
376
    .await
377
    .unwrap();
378
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
379
    assert_eq!(st, StatusCode::OK, "{v}");
380
    assert_eq!(v["unread"], 2);
381
    assert_eq!(v["items"][0]["read"], false);
382
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
383
    let first = v["items"][0]["id"].as_i64().unwrap();
384
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
385
    assert_eq!(st, StatusCode::NO_CONTENT);
386
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
387
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
388
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
389
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
390
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
391
392
    // Review requests: the author asks andy; andy is told, reviews, and the
393
    // request is answered; the author hears of the review.
394
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
395
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
396
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
397
        .await
398
        .unwrap();
399
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
400
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
401
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
402
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
403
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
404
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
405
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
406
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
407
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
408
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
409
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
410
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
411
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
412
    let (st, _) =
413
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
414
    assert_eq!(st, StatusCode::CREATED);
415
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
416
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
417
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
418
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
419
    // Asking again and withdrawing it.
420
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
421
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
422
    assert_eq!(st, StatusCode::NO_CONTENT);
423
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
424
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
425
426
    // A source bookmark with `/` in its name, as a feature/N-name workflow
427
    // makes them: by name, and as this repository's owner/name:bookmark.
428
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
429
        client.bookmark_create(b, Some(&[base])).unwrap();
430
        client.bookmark_switch(b, false).unwrap();
431
        write(work.path(), file, b"c\n");
432
        client.snapshot("t").unwrap();
433
        client.commit(b, &[]).unwrap();
434
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
435
    }
436
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
437
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
438
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
439
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
440
        let n = v["number"].as_i64().unwrap();
441
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
442
        assert_eq!(page.status, StatusCode::OK);
443
        assert!(page.body.contains("feature/"), "the page names its source");
444
    }
445
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
446
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
447
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
448
449
    // oxygenhub#76: a proposal's title and description are edited through
450
    // the API by its author or a maintainer; what is not given stays.
451
    let edit = |token: &str, number: i64, body: &str| {
452
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
453
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
454
    };
455
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
456
    assert_eq!(st, StatusCode::OK, "{v}");
457
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
458
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
459
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
460
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
461
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
462
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
463
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
464
    let (st, v) = api(
465
        app,
466
        "POST",
467
        "/api/v1/repos/andy/demo/proposals",
468
        Some(&andy_pw),
469
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
470
    )
471
    .await;
472
    assert_eq!(st, StatusCode::CREATED, "{v}");
473
    let n = v["number"].as_i64().unwrap();
474
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
475
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
476
}
477
478
#[tokio::test(flavor = "multi_thread")]
479
async fn api_issue_triage_and_labels() {
480
    let h = hub().await;
481
    let app = &h.app;
482
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
483
        .await
484
        .cookie
485
        .unwrap();
486
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
487
        .await
488
        .cookie
489
        .unwrap();
490
    let mint = |cookie: String, scopes: &'static str| {
491
        let app = app.clone();
492
        async move {
493
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
494
            let csrf = csrf_of(&page.body);
495
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
496
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
497
        }
498
    };
499
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
500
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
501
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
502
    assert_eq!(st, StatusCode::CREATED);
503
504
    // Labels through the API; bad colours and non-triage callers are refused.
505
    let (st, v) = api(
506
        app,
507
        "POST",
508
        "/api/v1/repos/andy/demo/labels",
509
        Some(&andy_t),
510
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
511
    )
512
    .await;
513
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
514
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
515
    assert_eq!(
516
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
517
        StatusCode::BAD_REQUEST
518
    );
519
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
520
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
521
    assert_eq!(labels.as_array().unwrap().len(), 2);
522
523
    // An issue created with its labels and assignee in one call.
524
    let (st, v) = api(
525
        app,
526
        "POST",
527
        "/api/v1/repos/andy/demo/issues",
528
        Some(&andy_t),
529
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
530
    )
531
    .await;
532
    assert_eq!(st, StatusCode::CREATED, "{v}");
533
    assert_eq!(v["labels"][0]["name"], "bug");
534
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
535
    let n = v["number"].as_i64().unwrap();
536
    // Unknown names are refused before anything is created.
537
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
538
    assert_eq!(st, StatusCode::BAD_REQUEST);
539
    assert!(v["detail"].as_str().unwrap().contains("no label"));
540
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
541
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
542
    // Without triage, labels cannot be set, but a plain issue can be opened.
543
    assert_eq!(
544
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
545
        StatusCode::FORBIDDEN
546
    );
547
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
548
    assert_eq!(st, StatusCode::CREATED);
549
    let bob_n = bobs["number"].as_i64().unwrap();
550
551
    // PATCH: the whole label set, assignees and milestone, with events.
552
    let (st, v) =
553
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
554
            .await;
555
    assert_eq!(st, StatusCode::OK, "{v}");
556
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
557
    assert_eq!(v["assignees"], serde_json::json!([]));
558
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
559
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
560
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
561
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
562
    // The author edits their own title; others cannot; nobody but triage sets labels.
563
    let (st, v) =
564
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
565
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
566
    assert_eq!(
567
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
568
        StatusCode::FORBIDDEN
569
    );
570
    assert_eq!(
571
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
572
        StatusCode::FORBIDDEN
573
    );
574
    assert_eq!(
575
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
576
        StatusCode::BAD_REQUEST
577
    );
578
579
    // Deleting a label takes it off the issues.
580
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
581
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
582
    assert_eq!(v["labels"], serde_json::json!([]));
583
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
584
}
585
586
#[tokio::test(flavor = "multi_thread")]
587
async fn webhook_formats_editing_and_web_issue_events() {
588
    let h = hub().await;
589
    let app = &h.app;
590
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
591
        .await
592
        .cookie
593
        .unwrap();
594
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
595
    let r = call(
596
        app,
597
        "POST",
598
        "/settings/tokens",
599
        None,
600
        Some(&andy),
601
        None,
602
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
603
    )
604
    .await;
605
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
606
    assert_eq!(
607
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
608
        StatusCode::CREATED
609
    );
610
    let rx = receiver().await;
611
    *rx.fail_first.lock().unwrap() = false;
612
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
613
    let csrf = csrf_of(&settings);
614
    let form = |f: String| {
615
        let andy = andy.clone();
616
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
617
    };
618
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
619
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
620
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
621
    assert_eq!(hook.format, "discord");
622
    // Ping arrives as a Discord message.
623
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
624
    let mut got = String::new();
625
    for _ in 0..100 {
626
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
627
            got = body.clone();
628
        }
629
        if !got.is_empty() {
630
            break;
631
        }
632
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
633
    }
634
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
635
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
636
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
637
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
638
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
639
640
    // Editing: a blank URL and secret keep theirs; format, events and active change.
641
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
642
        .await
643
        .contains("Webhook saved"));
644
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
645
    assert_eq!(
646
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
647
        (rx.url.as_str(), "issue", "oxygenhub", true)
648
    );
649
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
650
651
    // An issue opened on the web now reaches the hook, as the signed envelope.
652
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
653
    call(
654
        app,
655
        "POST",
656
        "/andy/demo/issues/new",
657
        None,
658
        Some(&andy),
659
        None,
660
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
661
    )
662
    .await;
663
    let mut envelope = None;
664
    for _ in 0..100 {
665
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
666
        if envelope.is_some() {
667
            break;
668
        }
669
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
670
    }
671
    let (_, sig, body) = envelope.expect("issue.opened delivered");
672
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
673
    assert_eq!(v["data"]["issue"]["title"], "From the web");
674
    assert!(sig.starts_with("blake3-keyed="));
675
    // A disabled hook through the edit form (no active box).
676
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
677
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
678
}
679
680
#[tokio::test(flavor = "multi_thread")]
681
async fn api_projects() {
682
    let h = hub().await;
683
    let app = &h.app;
684
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
685
        .await
686
        .cookie
687
        .unwrap();
688
    let bob = call(app, "POST", "/register", None, None, None, Some("username=bob&email=b%40example.com&password=correct-horse-battery"))
689
        .await
690
        .cookie
691
        .unwrap();
692
    let mint = |cookie: String, scopes: &'static str| {
693
        let app = app.clone();
694
        async move {
695
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
696
            let csrf = csrf_of(&page.body);
697
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
698
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
699
        }
700
    };
701
    let a = mint(andy, "scopes=repo%3Aadmin").await;
702
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
703
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
704
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
705
706
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
707
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
708
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
709
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
710
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
711
712
    // Cards by reference, into a column by name, and a note into the first column.
713
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
714
    assert_eq!(st, StatusCode::CREATED, "{card}");
715
    assert_eq!(
716
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
717
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
718
    );
719
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
720
    assert_eq!(st, StatusCode::BAD_REQUEST);
721
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
722
    assert_eq!(
723
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
724
        StatusCode::BAD_REQUEST
725
    );
726
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
727
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
728
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
729
730
    // Move and read the board.
731
    let id = card["id"].as_i64().unwrap();
732
    assert_eq!(
733
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
734
        StatusCode::NO_CONTENT
735
    );
736
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
737
    let names: Vec<(&str, usize)> =
738
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
739
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
740
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
741
742
    // Private: hidden from others; closed: read-only; then remove a card.
743
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
744
    assert_eq!(edited["public"], false);
745
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
746
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
747
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
748
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
749
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
750
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
751
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
752
}
753
754
#[tokio::test(flavor = "multi_thread")]
755
async fn api_required_checks() {
756
    let h = hub().await;
757
    let app = &h.app;
758
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
759
        .await
760
        .cookie
761
        .unwrap();
762
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
763
    let csrf = csrf_of(&page.body);
764
    let mint = |scopes: &'static str| {
765
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
766
        async move {
767
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
768
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
769
        }
770
    };
771
    let admin = mint("scopes=repo%3Aadmin").await;
772
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
773
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
774
775
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
776
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
777
    let (st, v) = api(
778
        app,
779
        "PUT",
780
        "/api/v1/repos/andy/demo/checks/required",
781
        Some(&admin),
782
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
783
    )
784
    .await;
785
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
786
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
787
    assert_eq!(
788
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
789
        serde_json::json!(["flow/fmt", "flow/test"])
790
    );
791
    assert_eq!(
792
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
793
        StatusCode::FORBIDDEN,
794
        "repo:admin only"
795
    );
796
    assert_eq!(
797
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
798
        StatusCode::BAD_REQUEST
799
    );
800
    // The settings page shows the same list.
801
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
802
}
803
804
/// OxygenFlow per repository: site administrators turn it on or off in
805
/// the repository's settings; hub.toml's `[flow] repos` is the default.
806
#[tokio::test(flavor = "multi_thread")]
807
async fn flow_is_switched_per_repository_by_site_admins() {
808
    let h = hub().await;
809
    let app = &h.app;
810
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
811
        .await
812
        .cookie
813
        .unwrap();
814
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
815
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
816
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
817
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
818
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
819
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
820
821
    let set = |value: &'static str| {
822
        let (app, andy) = (app.clone(), andy.clone());
823
        async move {
824
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
825
            call(
826
                &app,
827
                "POST",
828
                "/andy/demo/settings/flow",
829
                None,
830
                Some(&andy),
831
                None,
832
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
833
            )
834
            .await
835
        }
836
    };
837
    // A repository admin who is not a site admin sees the state but cannot change it.
838
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
839
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
840
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
841
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
842
    let r = set("on").await;
843
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
844
    assert_eq!(row().await.flow, "");
845
846
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
847
    let r = set("on").await;
848
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
849
    assert_eq!(row().await.flow, "on");
850
    assert!(oxygenhub::flow::enabled(app, &row().await));
851
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
852
    set("off").await;
853
    assert!(!oxygenhub::flow::enabled(app, &row().await));
854
    set("default").await;
855
    assert_eq!(row().await.flow, "");
856
    assert!(set("sometimes").await.body.contains("Pick on, off"));
857
}
858
859
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
860
/// button, never the repository's default bookmark as the hub sets it.
861
#[tokio::test(flavor = "multi_thread")]
862
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
863
    let h = hub().await;
864
    let app = &h.app;
865
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
866
        .await
867
        .cookie
868
        .unwrap();
869
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
870
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
871
    let url = format!("{}/andy/demo", h.base);
872
    let work = tempfile::tempdir().unwrap();
873
    let (w, u) = (work.path().to_path_buf(), url.clone());
874
    let client = tokio::task::spawn_blocking(move || {
875
        let mut c = Repo::init(&w).unwrap();
876
        c.config.set("remote.origin.url", &u).unwrap();
877
        c.config.set("remote.origin.token", "site").unwrap();
878
        c.save_config().unwrap();
879
        write(&w, "a.txt", b"a\n");
880
        c.commit("a", &[]).unwrap();
881
        assert!(c.push("origin", false).unwrap()[0].ok);
882
        for b in ["develop", "feature/x", "stray"] {
883
            c.bookmark_create(b, None).unwrap();
884
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
885
        }
886
        // A pushed deletion.
887
        let r = c.push_delete("origin", "feature/x").unwrap();
888
        assert!(r[0].ok, "{r:?}");
889
        c
890
    })
891
    .await
892
    .unwrap();
893
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
894
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
895
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
896
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
897
    assert!(!anon.body.contains("/bookmarks/delete"));
898
899
    // The hub's default, not the repository's config, is protected: make
900
    // develop the default, then main can go and develop cannot.
901
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
902
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
903
    let client = tokio::task::spawn_blocking(move || {
904
        let r = client.push_delete("origin", "develop").unwrap();
905
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
906
        let r = client.push_delete("origin", "main").unwrap();
907
        assert!(r[0].ok, "{r:?}");
908
        client
909
    })
910
    .await
911
    .unwrap();
912
    drop(client);
913
914
    // On the web: a writer deletes stray; the default is refused.
915
    let form = |b: &'static str| {
916
        let (app, andy) = (app.clone(), andy.clone());
917
        async move {
918
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
919
            call(
920
                &app,
921
                "POST",
922
                "/andy/demo/bookmarks/delete",
923
                None,
924
                Some(&andy),
925
                None,
926
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
927
            )
928
            .await
929
        }
930
    };
931
    let r = form("stray").await;
932
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
933
    assert!(!r.body.contains(">stray<"));
934
    let r = form("develop").await;
935
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
936
    let r = form("nope").await;
937
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
938
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
939
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
940
    // Anonymous visitors cannot.
941
    assert_ne!(
942
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
943
        StatusCode::OK
944
    );
945
}
946
947
/// A change signed by a key no account has linked says so, on its page
948
/// and in the API (feedback 14).
949
#[tokio::test(flavor = "multi_thread")]
950
async fn changes_signed_by_unlinked_keys_say_so() {
951
    let h = hub().await;
952
    let app = &h.app;
953
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
954
        .await
955
        .cookie
956
        .unwrap();
957
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
958
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
959
    let url = format!("{}/andy/demo", h.base);
960
    let work = tempfile::tempdir().unwrap();
961
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
962
    let hash = tokio::task::spawn_blocking(move || {
963
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
964
        c.config.set("remote.origin.url", &u).unwrap();
965
        c.config.set("remote.origin.token", "site").unwrap();
966
        c.save_config().unwrap();
967
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
968
        write(&w.join("r"), "a.txt", b"a\n");
969
        let h = c.commit("signed by Ada", &[]).unwrap();
970
        assert!(c.push("origin", false).unwrap()[0].ok);
971
        h.to_hex()
972
    })
973
    .await
974
    .unwrap();
975
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
976
    assert_eq!(st, StatusCode::OK, "{v}");
977
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
978
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
979
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
980
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
981
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
982
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
983
}
984
985
/// Function history (hub spec §6.6): the file page lists a file's
986
/// functions, and a function's page lists exactly the changes to its lines.
987
#[tokio::test(flavor = "multi_thread")]
988
async fn a_function_has_its_own_history() {
989
    let h = hub().await;
990
    let app = &h.app;
991
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
992
        .await
993
        .cookie
994
        .unwrap();
995
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
996
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
997
    let url = format!("{}/andy/demo", h.base);
998
    let work = tempfile::tempdir().unwrap();
999
    let w = work.path().to_path_buf();
1000
    tokio::task::spawn_blocking(move || {
1001
        let mut c = Repo::init(&w).unwrap();
1002
        c.config.set("remote.origin.url", &url).unwrap();
1003
        c.config.set("remote.origin.token", "site").unwrap();
1004
        c.save_config().unwrap();
1005
        let steps = [
1006
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1007
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1008
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1009
        ];
1010
        for (msg, text) in steps {
1011
            write(&w, "src/lib.rs", text.as_bytes());
1012
            c.commit(msg, &[]).unwrap();
1013
        }
1014
        assert!(c.push("origin", false).unwrap()[0].ok);
1015
    })
1016
    .await
1017
    .unwrap();
1018
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1019
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1020
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1021
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1022
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1023
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1024
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1025
    assert_ne!(bad.status, StatusCode::OK);
1026
}
1027
1028
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1029
/// dependency edges, linked cards.
1030
#[tokio::test(flavor = "multi_thread")]
1031
async fn a_bookmark_shows_as_swimlanes() {
1032
    let h = hub().await;
1033
    let app = &h.app;
1034
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1035
        .await
1036
        .cookie
1037
        .unwrap();
1038
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1039
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1040
    let url = format!("{}/andy/demo", h.base);
1041
    let work = tempfile::tempdir().unwrap();
1042
    let w = work.path().to_path_buf();
1043
    tokio::task::spawn_blocking(move || {
1044
        let mut c = Repo::init(&w).unwrap();
1045
        c.config.set("remote.origin.url", &url).unwrap();
1046
        c.config.set("remote.origin.token", "site").unwrap();
1047
        c.save_config().unwrap();
1048
        // Two files edited independently: two lanes.
1049
        write(&w, "a.txt", b"a\n");
1050
        c.commit("add a", &[]).unwrap();
1051
        write(&w, "b.txt", b"b\n");
1052
        c.commit("add b", &[]).unwrap();
1053
        write(&w, "a.txt", b"a\na2\n");
1054
        c.commit("grow a", &[]).unwrap();
1055
        assert!(c.push("origin", false).unwrap()[0].ok);
1056
    })
1057
    .await
1058
    .unwrap();
1059
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1060
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1061
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1062
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1063
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1064
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1065
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1066
    assert_eq!(board.matches("<rect ").count(), 3);
1067
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1068
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1069
}
1070
1071
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1072
/// offers only what makes sense and rewrites nothing itself.
1073
#[tokio::test(flavor = "multi_thread")]
1074
async fn a_proposal_board_plans_squashes_and_rebases() {
1075
    let h = hub().await;
1076
    let app = &h.app;
1077
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1078
        .await
1079
        .cookie
1080
        .unwrap();
1081
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1082
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1083
    let url = format!("{}/andy/demo", h.base);
1084
    let work = tempfile::tempdir().unwrap();
1085
    let w = work.path().to_path_buf();
1086
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1087
        let mut c = Repo::init(&w).unwrap();
1088
        c.config.set("remote.origin.url", &url).unwrap();
1089
        c.config.set("remote.origin.token", "site").unwrap();
1090
        c.save_config().unwrap();
1091
        write(&w, "a.txt", b"a\n");
1092
        let base = c.commit("base", &[]).unwrap();
1093
        assert!(c.push("origin", false).unwrap()[0].ok);
1094
        c.bookmark_create("feature", None).unwrap();
1095
        c.bookmark_switch("feature", false).unwrap();
1096
        write(&w, "a.txt", b"a\nfirst\n");
1097
        let first = c.commit("first", &[]).unwrap();
1098
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1099
        let second = c.commit("second", &[]).unwrap();
1100
        write(&w, "b.txt", b"apart\n");
1101
        let apart = c.commit("apart", &[]).unwrap();
1102
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1103
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1104
    })
1105
    .await
1106
    .unwrap();
1107
    // No proposal yet: the board is read-only.
1108
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1109
    assert!(!board.contains("data-plan="));
1110
    let (st, _) = api(
1111
        app,
1112
        "POST",
1113
        "/api/v1/repos/andy/demo/proposals",
1114
        Some("site"),
1115
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1116
    )
1117
    .await;
1118
    assert!(st.is_success(), "{st}");
1119
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1120
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1121
    let csrf = csrf_of(&board);
1122
    let plan = |c: &str, t: &str| {
1123
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1124
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1125
        async move {
1126
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1127
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1128
        }
1129
    };
1130
    let kinds = |v: &serde_json::Value| {
1131
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1132
    };
1133
    // second already depends on first: squash, no rebase.
1134
    let v = plan(&second, &first).await;
1135
    assert_eq!(kinds(&v), ["squash"], "{v}");
1136
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1137
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
1138
    // apart is independent of second: either.
1139
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1140
    // first under second: nothing (second depends on first).
1141
    assert!(plan(&first, &second).await["error"].is_string());
1142
    // What has landed on main is not rearranged.
1143
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1144
}
1145
1146
/// Issues and proposals share a number space, so every number says what it
1147
/// is, and the chain of work shows from both ends (hub spec §8).
1148
#[tokio::test(flavor = "multi_thread")]
1149
async fn proposals_and_issues_show_their_chain() {
1150
    let h = hub().await;
1151
    let app = &h.app;
1152
    let andy = call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery"))
1153
        .await
1154
        .cookie
1155
        .unwrap();
1156
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1157
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1158
    let url = format!("{}/andy/demo", h.base);
1159
    let work = tempfile::tempdir().unwrap();
1160
    let w = work.path().to_path_buf();
1161
    tokio::task::spawn_blocking(move || {
1162
        let mut c = Repo::init(&w).unwrap();
1163
        c.config.set("remote.origin.url", &url).unwrap();
1164
        c.config.set("remote.origin.token", "site").unwrap();
1165
        c.save_config().unwrap();
1166
        write(&w, "a.txt", b"a\n");
1167
        c.commit("base", &[]).unwrap();
1168
        assert!(c.push("origin", false).unwrap()[0].ok);
1169
        c.bookmark_create("feature", None).unwrap();
1170
        c.bookmark_switch("feature", false).unwrap();
1171
        write(&w, "a.txt", b"a\nfixed\n");
1172
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1173
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1174
    })
1175
    .await
1176
    .unwrap();
1177
    for title in ["Slow start", "Crash on save"] {
1178
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1179
        assert!(st.is_success());
1180
    }
1181
    let (st, v) = api(
1182
        app,
1183
        "POST",
1184
        "/api/v1/repos/andy/demo/proposals",
1185
        Some("site"),
1186
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1187
    )
1188
    .await;
1189
    assert!(st.is_success(), "{st} {v}");
1190
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1191
1192
    // The proposal names its kind, links its references by kind, and shows
1193
    // the chain: the issues it closes (description and changes) → it → main.
1194
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1195
    assert!(p.contains(">proposal #3</small>"), "header");
1196
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1197
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1198
    let chain = &chain[..chain.find("</p>").unwrap()];
1199
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1200
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1201
    }
1202
    assert!(p.contains("<h3>Closes</h3>"));
1203
1204
    // The issue shows the proposal that closes it, and names its own kind.
1205
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1206
    assert!(i.contains(">issue #1</small>"));
1207
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1208
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1209
    // The conversation is a timeline with avatars; editing sits with the
1210
    // content, not in the sidebar, and labels and projects are editable.
1211
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1212
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1213
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1214
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1215
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1216
    assert!(st.is_success(), "{st}");
1217
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1218
    assert!(p.contains("<option value=\"1\">Board</option>"), "the owner's projects to add to");
1219
    let csrf = csrf_of(&p);
1220
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1221
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1222
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1223
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1224
        .await;
1225
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1226
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1227
1228
    // Closed by the proposal's change, not its description: still shown.
1229
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1230
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1231
    assert!(chain.contains("proposal #3"), "{chain}");
1232
}
1233
1234
/// What the hub is: its version and build, and the libraries it is built on,
1235
/// on /about, in the API and in /health (hub spec §15).
1236
#[tokio::test(flavor = "multi_thread")]
1237
async fn the_hub_says_what_version_it_is() {
1238
    let h = hub().await;
1239
    let app = &h.app;
1240
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1241
    assert_eq!(st, StatusCode::OK);
1242
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1243
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1244
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1245
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1246
    assert!(health.contains("\"build\""), "{health}");
1247
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1248
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1249
    assert!(about.contains("href=\"/about\""), "the footer links here");
1250
}
1251
1252
#[tokio::test(flavor = "multi_thread")]
1253
async fn device_sign_in() {
1254
    let h = hub().await;
1255
    let app = &h.app;
1256
    let r =
1257
        call(app, "POST", "/register", None, None, None, Some("username=andy&email=a%40example.com&password=correct-horse-battery")).await;
1258
    let andy = r.cookie.unwrap();
1259
1260
    // An unknown scope is refused.
1261
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1262
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1263
1264
    // The app asks for a code and polls; nobody has approved it yet.
1265
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1266
    assert_eq!(st, StatusCode::OK, "{v}");
1267
    let device = v["device_code"].as_str().unwrap().to_string();
1268
    let user = v["user_code"].as_str().unwrap().to_string();
1269
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1270
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1271
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1272
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1273
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1274
    assert_eq!(v["error"], "slow_down", "polled too soon");
1275
1276
    // The user approves it on the web, allowing less than it asked for.
1277
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1278
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1279
    let csrf = csrf_of(&page.body);
1280
    let r =
1281
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1282
            .await;
1283
    assert!(r.body.contains("Approved"), "{}", r.body);
1284
1285
    // The next poll gets a token with what was allowed, once.
1286
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1287
    assert_eq!(st, StatusCode::OK, "{v}");
1288
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1289
    let token = v["access_token"].as_str().unwrap().to_string();
1290
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1291
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1292
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1293
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1294
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1295
    assert!(tokens.body.contains("device: Phone app"));
1296
    // oxygenhub#70: a device's token expires, and each use renews it.
1297
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1298
1299
    // The token can revoke itself (oxy auth logout), and is then refused.
1300
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1301
    assert_eq!(st, StatusCode::NO_CONTENT);
1302
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1303
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1304
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1305
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1306
1307
    // A denied code says so.
1308
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1309
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1310
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1311
    let csrf = csrf_of(&page.body);
1312
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1313
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1314
    assert_eq!(v["error"], "access_denied");
1315
1316
    // Signed out, the page asks for a sign-in first.
1317
    let r = call(app, "GET", "/device", None, None, None, None).await;
1318
    assert!(r.status.is_redirection(), "{}", r.status);
1319
}