OXYGENHUB
◆ v0.6.0 oxygenhub / crates / hub / tests / api.rs
83.5 KiB · Rust · last changed Carry events between the hub's processes on an event bus 16 days ago source blame history raw
b64e2537 Andy McCall ↶ 1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use std::sync::{Arc, Mutex};
15
use tower::ServiceExt;
16
17
fn hermetic() {
18
    static ONCE: std::sync::Once = std::sync::Once::new();
19
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
20
    ONCE.call_once(|| {
21
        let d = tempfile::tempdir().unwrap();
22
        std::env::set_var("OXY_HOME", d.path());
23
        DIR.set(d).ok();
24
    });
25
}
26
27
fn write(root: &Path, rel: &str, content: &[u8]) {
28
    let p = root.join(rel);
29
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
30
    std::fs::write(p, content).unwrap();
31
}
32
33
struct Hub {
34
    app: Shared,
35
    base: String,
36
    _dir: tempfile::TempDir,
37
}
38
39
async fn hub() -> Hub {
40
    hermetic();
41
    let dir = tempfile::tempdir().unwrap();
42
    let mut config = Config::load(dir.path()).unwrap();
c8684d44 Andy McCall 43
    // The first account's setup code (oxygenhub#245).
44
    config.registration.setup_code = "test-setup".into();
b64e2537 Andy McCall ↶ 45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
9a777fec Andy McCall ↶ 50
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
51
    config.outbound.allow = vec!["http://127.0.0.1".into()];
b64e2537 Andy McCall ↶ 52
    let app = oxygenhub::build(config).await.unwrap();
53
    let router = oxygenhub::router(app.clone());
54
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
55
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
56
}
57
58
struct Res {
59
    status: StatusCode,
60
    body: String,
61
    cookie: Option<String>,
62
}
63
64
async fn call(
65
    app: &Shared,
66
    method: &str,
67
    path: &str,
68
    bearer: Option<&str>,
69
    cookie: Option<&str>,
70
    json: Option<&str>,
71
    form: Option<&str>,
72
) -> Res {
73
    let mut req = Request::builder().method(method).uri(path);
74
    if let Some(b) = bearer {
75
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
76
    }
77
    if let Some(c) = cookie {
78
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
79
    }
80
    let body = if let Some(j) = json {
81
        req = req.header(header::CONTENT_TYPE, "application/json");
82
        Body::from(j.to_string())
83
    } else if let Some(f) = form {
84
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
85
        Body::from(f.to_string())
86
    } else {
87
        Body::empty()
88
    };
89
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
90
    let status = res.status();
91
    let cookie = res
92
        .headers()
93
        .get(header::SET_COOKIE)
94
        .and_then(|v| v.to_str().ok())
95
        .and_then(|v| v.split(';').next())
96
        .and_then(|kv| kv.split_once('='))
97
        .map(|(_, v)| v.to_string());
98
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
99
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie }
100
}
101
102
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
103
    let r = call(app, method, path, bearer, None, json, None).await;
104
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
105
    (r.status, v)
106
}
107
108
fn csrf_of(page: &str) -> String {
109
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
110
    page[i..].split('"').next().unwrap().to_string()
111
}
112
113
/// A webhook receiver that records what it gets and fails the first time.
114
struct Receiver {
115
    url: String,
116
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
117
    fail_first: Arc<Mutex<bool>>,
118
}
119
120
async fn receiver() -> Receiver {
121
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
122
    let fail_first = Arc::new(Mutex::new(true));
123
    let (s2, f2) = (seen.clone(), fail_first.clone());
124
    let router = Router::new().route(
125
        "/hook",
126
        post(move |headers: header::HeaderMap, body: String| {
127
            let (s2, f2) = (s2.clone(), f2.clone());
128
            async move {
129
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
130
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
131
                let mut f = f2.lock().unwrap();
132
                if *f {
133
                    *f = false;
134
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
135
                }
136
                s2.lock().unwrap().push((event, sig, body));
137
                (StatusCode::OK, "ok")
138
            }
139
        }),
140
    );
141
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
142
    let port = listener.local_addr().unwrap().port();
143
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
144
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
145
}
146
147
#[tokio::test(flavor = "multi_thread")]
148
async fn api_webhooks_and_checks() {
149
    let h = hub().await;
150
    let app = &h.app;
151
    // Accounts and tokens through the pages.
c8684d44 Andy McCall 152
    let r = call(
153
        app,
154
        "POST",
155
        "/register",
156
        None,
157
        None,
158
        None,
159
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
160
    )
161
    .await;
b64e2537 Andy McCall ↶ 162
    let andy = r.cookie.unwrap();
c8684d44 Andy McCall 163
    let r = call(
164
        app,
165
        "POST",
166
        "/register",
167
        None,
168
        None,
169
        None,
170
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
171
    )
172
    .await;
b64e2537 Andy McCall ↶ 173
    let bob = r.cookie.unwrap();
174
    let mint = |cookie: String, scopes: &'static str| {
175
        let app = app.clone();
176
        async move {
177
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
178
            let csrf = csrf_of(&page.body);
179
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
180
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
181
        }
182
    };
183
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
184
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
185
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
186
187
    // Create a repository through the API; the read-only token cannot.
188
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
189
    assert_eq!(st, StatusCode::FORBIDDEN);
190
    let (st, v) = api(
191
        app,
192
        "POST",
193
        "/api/v1/repos",
194
        Some(&andy_admin),
195
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
196
    )
197
    .await;
198
    assert_eq!(st, StatusCode::CREATED, "{v}");
199
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
200
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
201
    assert_eq!(st, StatusCode::CONFLICT);
202
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
203
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
204
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
205
    assert_eq!(st, StatusCode::OK);
206
    assert_eq!(v["username"], "andy");
207
208
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
209
    let rx = receiver().await;
210
    let (st, v) = api(
211
        app,
212
        "POST",
213
        "/api/v1/repos/andy/demo/hooks",
214
        Some(&andy_admin),
215
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
216
    )
217
    .await;
218
    assert_eq!(st, StatusCode::CREATED, "{v}");
219
    let work = tempfile::tempdir().unwrap();
220
    let mut client = Repo::init(work.path()).unwrap();
221
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
222
    client.config.set("remote.origin.token", "site").unwrap();
223
    client.save_config().unwrap();
224
    write(work.path(), "a.txt", b"a\n");
225
    client.snapshot("t").unwrap();
226
    let base = client.commit("base", &[]).unwrap();
227
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
228
    // The worker retries with backoff; drive it directly for the retry.
229
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
230
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
231
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
232
    oxygenhub::hooks::deliver_due(app).await;
233
    let seen = rx.seen.lock().unwrap().clone();
234
    assert_eq!(seen.len(), 1, "{seen:?}");
235
    assert_eq!(seen[0].0, "push");
236
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
237
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
238
    assert_eq!(payload["repository"]["name"], "demo");
239
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
240
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
241
    assert_eq!(v.as_array().unwrap().len(), 1);
242
243
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
244
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
245
    assert_eq!(st, StatusCode::OK);
246
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
f28389bd Andy McCall ↶ 247
    // A revset in place of the whole history (`?r=`), under a budget; a
248
    // bad one is the caller's problem.
249
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
250
    assert_eq!(st, StatusCode::OK, "{v}");
251
    assert_eq!(v["total"].as_u64(), Some(1));
252
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
253
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
254
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
255
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
256
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
b64e2537 Andy McCall ↶ 257
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
258
    assert_eq!(v[0]["name"], "a.txt");
259
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
260
    assert_eq!(r.body, "a\n");
261
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
262
    assert_eq!(v[0]["change"], base.to_hex());
263
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
264
    assert_eq!(v["files"][0]["path"], "a.txt");
265
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
266
    assert!(v["policy"].is_null());
267
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
268
    assert_eq!(v[0]["reference"], "main");
269
270
    // Issues through the API: Bob opens one, comments, and closes it.
271
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
272
    assert_eq!(st, StatusCode::CREATED, "{v}");
273
    assert_eq!(v["number"], 1);
274
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
275
    assert_eq!(st, StatusCode::CREATED);
276
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
277
    assert_eq!(st, StatusCode::OK, "{v}");
278
    assert_eq!(v["state"], "closed");
279
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
280
    assert_eq!(v[0]["comments"], 1);
281
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
282
    assert_eq!(v[0]["number"], 1);
283
284
    // A proposal through the API, then a required check gates its landing.
285
    client.bookmark_create("feat", Some(&[base])).unwrap();
286
    client.bookmark_switch("feat", false).unwrap();
287
    write(work.path(), "b.txt", b"b\n");
3f02e5ea Andy McCall ↶ 288
    write(work.path(), "a.txt", b"a\nA\n");
b64e2537 Andy McCall ↶ 289
    client.snapshot("t").unwrap();
290
    let feat = client.commit("feat", &[]).unwrap();
291
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
292
    let (st, v) =
293
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
294
            .await;
295
    assert_eq!(st, StatusCode::CREATED, "{v}");
296
    assert_eq!(v["number"], 2);
297
    let state = v["projected_state"].as_str().unwrap().to_string();
298
    assert_eq!(v["landable"], true);
a0dd06b0 Andy McCall ↶ 299
    // A wiki takes no proposals, and says so rather than "no such
300
    // repository" (oxygenhub#128); a repository's that does not exist
301
    // still does not.
302
    let (st, v) =
303
        api(app, "POST", "/api/v1/repos/andy/demo.wiki/proposals", Some(&bob_rw), Some(r#"{"title":"W","target":"main","source":"p"}"#))
304
            .await;
305
    let detail = v["detail"].as_str().unwrap_or_default();
306
    assert!(st == StatusCode::NOT_FOUND && detail.contains("is the wiki of andy/demo") && detail.contains("push main"), "{v}");
307
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/nope.wiki/proposals", Some(&bob_rw), None).await;
308
    assert_eq!(v["detail"], "no such repository");
3f02e5ea Andy McCall ↶ 309
    // Its files, and each side's bytes, for editors' diff views.
310
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
311
    assert_eq!(st, StatusCode::OK, "{v}");
312
    let files: Vec<(String, String)> =
313
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
314
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
315
    assert_eq!(v[0]["added"], 1);
316
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
317
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
318
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
319
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
320
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
321
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
c0fac31d Andy McCall ↶ 322
    // An anchored comment comes back with its line in the projected state.
323
    let (st, v) = api(
324
        app,
325
        "POST",
326
        "/api/v1/repos/andy/demo/proposals/2/comments",
327
        Some(&bob_rw),
328
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
329
    )
330
    .await;
331
    assert_eq!(st, StatusCode::CREATED, "{v}");
332
    assert_eq!(v["line"], 2);
333
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
334
    assert_eq!(v[0]["path"], "a.txt");
335
    assert_eq!(v[0]["line"], 2, "{v}");
336
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
b64e2537 Andy McCall ↶ 337
    // Require the "build" check.
338
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
339
    let csrf = csrf_of(&settings.body);
340
    assert_eq!(
341
        call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
342
            .await
343
            .status,
344
        StatusCode::OK
345
    );
346
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
347
    assert_eq!(v["landable"], false);
348
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
349
    // A checker reports on the projected state: first running, then passed; the page streams it.
350
    let (st, v) = api(
351
        app,
352
        "POST",
353
        "/api/v1/repos/andy/demo/checks",
354
        Some(&andy_ro),
355
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
356
    )
357
    .await;
358
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
33d98147 Andy McCall 359
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
b64e2537 Andy McCall ↶ 360
    let (st, v) = api(
361
        app,
362
        "POST",
363
        "/api/v1/repos/andy/demo/checks",
364
        Some(&bob_rw),
365
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
366
    )
367
    .await;
368
    assert_eq!(st, StatusCode::CREATED, "{v}");
33d98147 Andy McCall 369
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
b64e2537 Andy McCall ↶ 370
    assert_eq!(ev.kind, "check");
371
    assert_eq!(ev.check.unwrap().name, "build");
372
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
373
    assert_eq!(v[0]["status"], "passed");
374
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
375
    assert_eq!(v["landable"], true, "{v}");
376
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
377
    assert!(page.body.contains("42 tests"), "{}", page.body);
a2ef53c5 Andy McCall ↶ 378
    // A summary carrying whole hashes shows them by their ends, so the
379
    // Checks panel keeps its width (a pin mismatch's message, 2026-10-16).
380
    let (a, b) = (
381
        "6ea27b1d35037a4e4d0f6208b1ca99630df40888bd21fd55c8f8aba51dcdd7cb",
382
        "f7495d7689da3ac5b68684f26fce28b91ce55e6b8131c5e484ad2aab90c3020f",
383
    );
384
    let summary = format!("could not run: flow-init has BLAKE3 {a}, but {b} is pinned");
385
    let body = serde_json::json!({ "state": state, "name": "lint", "status": "failed", "summary": summary }).to_string();
386
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/checks", Some(&bob_rw), Some(&body)).await;
387
    assert_eq!(st, StatusCode::CREATED, "{v}");
388
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await.body;
389
    assert!(page.contains("6ea27b1d…1dcdd7cb") && page.contains(&format!("data-full=\"{a}\"")), "{page}");
390
    assert!(!page.contains(&format!("BLAKE3 {a},")), "never the whole hash inline");
391
    // The Checks section refreshes itself; nothing reloads the whole page.
392
    assert!(!page.contains("location.reload()"), "no full reload on a check");
393
    let part = call(app, "GET", "/andy/demo/proposal/2?fragment=checks", None, Some(&andy), None, None).await.body;
394
    assert!(part.contains("<h3>Checks</h3>") && part.contains("6ea27b1d…1dcdd7cb") && !part.contains("<html"), "{part}");
b64e2537 Andy McCall ↶ 395
    // The check and the proposal reached the webhook too.
396
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
397
    oxygenhub::hooks::deliver_due(app).await;
398
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
399
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
400
    let _ = feat;
401
    let _ = rx.fail_first;
42a0ba4b Andy McCall ↶ 402
403
    // The inbox through the API: count, list, mark one read, mark all read.
404
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
405
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
406
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
eb0c44a9 Andy McCall ↶ 407
    oxygenhub::db::notify::add(
408
        &app.db,
409
        oxygenhub::db::notify::New {
410
            account_id: bob_id,
411
            repo_id: None,
412
            reason: oxygenhub::db::notify::Reason::Participating,
413
            kind: "mention",
414
            title: "andy/demo#1: Bug",
415
            url: "/andy/demo/issue/1",
416
            actor: "andy",
417
        },
418
    )
419
    .await
420
    .unwrap();
421
    oxygenhub::db::notify::add(
422
        &app.db,
423
        oxygenhub::db::notify::New {
424
            account_id: bob_id,
425
            repo_id: None,
426
            reason: oxygenhub::db::notify::Reason::Participating,
427
            kind: "review",
428
            title: "andy/demo#2: Feat",
429
            url: "/andy/demo/proposal/2",
430
            actor: "andy",
431
        },
432
    )
433
    .await
434
    .unwrap();
42a0ba4b Andy McCall ↶ 435
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
436
    assert_eq!(st, StatusCode::OK, "{v}");
437
    assert_eq!(v["unread"], 2);
438
    assert_eq!(v["items"][0]["read"], false);
439
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
440
    let first = v["items"][0]["id"].as_i64().unwrap();
441
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
442
    assert_eq!(st, StatusCode::NO_CONTENT);
443
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
444
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
445
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
446
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
447
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
0b20f1ec Andy McCall ↶ 448
cc1cd197 Andy McCall ↶ 449
    // Review requests: the author asks andy; andy is told, reviews, and the
450
    // request is answered; the author hears of the review.
451
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
452
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
453
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
454
        .await
455
        .unwrap();
456
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
457
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
458
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
459
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
460
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
461
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
462
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
463
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
464
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
465
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
466
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
467
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
468
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
469
    let (st, _) =
470
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
471
    assert_eq!(st, StatusCode::CREATED);
472
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
473
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
474
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
475
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
476
    // Asking again and withdrawing it.
477
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
478
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
479
    assert_eq!(st, StatusCode::NO_CONTENT);
480
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
481
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
8e96499f Andy McCall ↶ 482
    // oxygenhub#84: the page's menu sets who is asked, all at once.
483
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
484
    assert!(
485
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
486
        "the reviewers menu lists andy"
487
    );
488
    let csrf = csrf_of(&page.body);
489
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
490
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
491
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
492
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
493
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
494
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
495
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
cc1cd197 Andy McCall ↶ 496
0b20f1ec Andy McCall ↶ 497
    // A source bookmark with `/` in its name, as a feature/N-name workflow
498
    // makes them: by name, and as this repository's owner/name:bookmark.
499
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
500
        client.bookmark_create(b, Some(&[base])).unwrap();
501
        client.bookmark_switch(b, false).unwrap();
502
        write(work.path(), file, b"c\n");
503
        client.snapshot("t").unwrap();
504
        client.commit(b, &[]).unwrap();
505
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
506
    }
507
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
508
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
509
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
510
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
511
        let n = v["number"].as_i64().unwrap();
512
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
513
        assert_eq!(page.status, StatusCode::OK);
514
        assert!(page.body.contains("feature/"), "the page names its source");
515
    }
516
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
517
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
518
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
739a763a Andy McCall ↶ 519
520
    // oxygenhub#76: a proposal's title and description are edited through
521
    // the API by its author or a maintainer; what is not given stays.
522
    let edit = |token: &str, number: i64, body: &str| {
523
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
524
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
525
    };
526
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
527
    assert_eq!(st, StatusCode::OK, "{v}");
528
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
529
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
530
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
531
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
532
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
533
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
534
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
535
    let (st, v) = api(
536
        app,
537
        "POST",
538
        "/api/v1/repos/andy/demo/proposals",
539
        Some(&andy_pw),
540
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
541
    )
542
    .await;
543
    assert_eq!(st, StatusCode::CREATED, "{v}");
544
    let n = v["number"].as_i64().unwrap();
545
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
546
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
2291f8cc Andy McCall ↶ 547
548
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
549
    // before anything changes, shown in its JSON.
550
    for l in ["ui", "flow"] {
551
        let body = format!(r#"{{"name":"{l}"}}"#);
552
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
553
    }
554
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
555
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
556
    assert_eq!(st, StatusCode::OK, "{v}");
557
    let names = |v: &serde_json::Value| -> Vec<String> {
558
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
559
    };
560
    assert_eq!(names(&v), ["flow", "ui"]);
561
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
562
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
563
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
564
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
565
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
566
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
567
    assert_eq!(names(&v), ["flow"]);
568
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
b64e2537 Andy McCall ↶ 569
}
76f262e1 Andy McCall ↶ 570
571
#[tokio::test(flavor = "multi_thread")]
572
async fn api_issue_triage_and_labels() {
573
    let h = hub().await;
574
    let app = &h.app;
c8684d44 Andy McCall 575
    let andy = call(
576
        app,
577
        "POST",
578
        "/register",
579
        None,
580
        None,
581
        None,
582
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
583
    )
584
    .await
585
    .cookie
586
    .unwrap();
587
    let bob = call(
588
        app,
589
        "POST",
590
        "/register",
591
        None,
592
        None,
593
        None,
594
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
595
    )
596
    .await
597
    .cookie
598
    .unwrap();
76f262e1 Andy McCall ↶ 599
    let mint = |cookie: String, scopes: &'static str| {
600
        let app = app.clone();
601
        async move {
602
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
603
            let csrf = csrf_of(&page.body);
604
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
605
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
606
        }
607
    };
608
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
609
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
610
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
611
    assert_eq!(st, StatusCode::CREATED);
612
613
    // Labels through the API; bad colours and non-triage callers are refused.
614
    let (st, v) = api(
615
        app,
616
        "POST",
617
        "/api/v1/repos/andy/demo/labels",
618
        Some(&andy_t),
619
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
620
    )
621
    .await;
622
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
623
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
624
    assert_eq!(
625
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
626
        StatusCode::BAD_REQUEST
627
    );
628
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
629
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
630
    assert_eq!(labels.as_array().unwrap().len(), 2);
5ea4872f Andy McCall ↶ 631
    // oxygenhub#91: milestones over the API, for triage.
632
    let (st, m) = api(
633
        app,
634
        "POST",
635
        "/api/v1/repos/andy/demo/milestones",
636
        Some(&andy_t),
637
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
638
    )
639
    .await;
640
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
641
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
642
    assert_eq!(
643
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
644
        StatusCode::BAD_REQUEST
645
    );
646
    assert_eq!(
647
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
648
        StatusCode::FORBIDDEN
649
    );
650
    let (st, m) =
651
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
652
            .await;
653
    assert_eq!(
654
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
655
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
656
        "{m}"
657
    );
658
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
659
    assert_eq!(
660
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
661
        StatusCode::NOT_FOUND,
662
        "renamed"
663
    );
664
    assert_eq!(
665
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
666
        StatusCode::BAD_REQUEST
667
    );
668
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
669
    assert_eq!(list.as_array().unwrap().len(), 1);
76f262e1 Andy McCall ↶ 670
671
    // An issue created with its labels and assignee in one call.
672
    let (st, v) = api(
673
        app,
674
        "POST",
675
        "/api/v1/repos/andy/demo/issues",
676
        Some(&andy_t),
677
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
678
    )
679
    .await;
680
    assert_eq!(st, StatusCode::CREATED, "{v}");
681
    assert_eq!(v["labels"][0]["name"], "bug");
682
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
683
    let n = v["number"].as_i64().unwrap();
684
    // Unknown names are refused before anything is created.
685
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
686
    assert_eq!(st, StatusCode::BAD_REQUEST);
687
    assert!(v["detail"].as_str().unwrap().contains("no label"));
688
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
689
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
690
    // Without triage, labels cannot be set, but a plain issue can be opened.
691
    assert_eq!(
692
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
693
        StatusCode::FORBIDDEN
694
    );
695
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
696
    assert_eq!(st, StatusCode::CREATED);
697
    let bob_n = bobs["number"].as_i64().unwrap();
698
699
    // PATCH: the whole label set, assignees and milestone, with events.
700
    let (st, v) =
701
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
702
            .await;
703
    assert_eq!(st, StatusCode::OK, "{v}");
704
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
705
    assert_eq!(v["assignees"], serde_json::json!([]));
706
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
707
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
708
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
709
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
710
    // The author edits their own title; others cannot; nobody but triage sets labels.
711
    let (st, v) =
712
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
713
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
714
    assert_eq!(
715
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
716
        StatusCode::FORBIDDEN
717
    );
718
    assert_eq!(
719
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
720
        StatusCode::FORBIDDEN
721
    );
722
    assert_eq!(
723
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
724
        StatusCode::BAD_REQUEST
725
    );
726
727
    // Deleting a label takes it off the issues.
728
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
729
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
730
    assert_eq!(v["labels"], serde_json::json!([]));
731
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
732
}
9756c67d Andy McCall ↶ 733
734
#[tokio::test(flavor = "multi_thread")]
735
async fn webhook_formats_editing_and_web_issue_events() {
736
    let h = hub().await;
737
    let app = &h.app;
c8684d44 Andy McCall 738
    let andy = call(
739
        app,
740
        "POST",
741
        "/register",
742
        None,
743
        None,
744
        None,
745
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
746
    )
747
    .await
748
    .cookie
749
    .unwrap();
9756c67d Andy McCall ↶ 750
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
751
    let r = call(
752
        app,
753
        "POST",
754
        "/settings/tokens",
755
        None,
756
        Some(&andy),
757
        None,
758
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
759
    )
760
    .await;
761
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
762
    assert_eq!(
763
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
764
        StatusCode::CREATED
765
    );
766
    let rx = receiver().await;
767
    *rx.fail_first.lock().unwrap() = false;
768
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
769
    let csrf = csrf_of(&settings);
770
    let form = |f: String| {
771
        let andy = andy.clone();
772
        async move { call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await.body }
773
    };
774
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
775
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
776
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
c9893553 Andy McCall ↶ 777
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
778
    {
779
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
780
        let before: i64 =
3b1bc27f Andy McCall 781
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 782
        for i in 0..MAX_WAITING {
783
            sqlx::query(
3b1bc27f Andy McCall 784
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
c9893553 Andy McCall ↶ 785
            )
786
            .bind(hook.id)
787
            .bind(format!("flood-{i}"))
788
            .execute(&app.db)
789
            .await
790
            .unwrap();
791
        }
792
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
793
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
794
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
795
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
796
        let after: i64 =
3b1bc27f Andy McCall 797
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 798
        assert_eq!(before, after);
799
    }
9756c67d Andy McCall ↶ 800
    assert_eq!(hook.format, "discord");
801
    // Ping arrives as a Discord message.
802
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
803
    let mut got = String::new();
804
    for _ in 0..100 {
805
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
806
            got = body.clone();
807
        }
808
        if !got.is_empty() {
809
            break;
810
        }
811
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
812
    }
813
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
814
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
815
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
816
    let page = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
817
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
818
819
    // Editing: a blank URL and secret keep theirs; format, events and active change.
820
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
821
        .await
822
        .contains("Webhook saved"));
823
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
824
    assert_eq!(
825
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
826
        (rx.url.as_str(), "issue", "oxygenhub", true)
827
    );
828
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
829
830
    // An issue opened on the web now reaches the hook, as the signed envelope.
831
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
832
    call(
833
        app,
834
        "POST",
835
        "/andy/demo/issues/new",
836
        None,
837
        Some(&andy),
838
        None,
839
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
840
    )
841
    .await;
842
    let mut envelope = None;
843
    for _ in 0..100 {
844
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
845
        if envelope.is_some() {
846
            break;
847
        }
848
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
849
    }
850
    let (_, sig, body) = envelope.expect("issue.opened delivered");
851
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
852
    assert_eq!(v["data"]["issue"]["title"], "From the web");
853
    assert!(sig.starts_with("blake3-keyed="));
854
    // A disabled hook through the edit form (no active box).
855
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
856
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
857
}
ef20fdc1 Andy McCall ↶ 858
859
#[tokio::test(flavor = "multi_thread")]
860
async fn api_projects() {
861
    let h = hub().await;
862
    let app = &h.app;
c8684d44 Andy McCall 863
    let andy = call(
864
        app,
865
        "POST",
866
        "/register",
867
        None,
868
        None,
869
        None,
870
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
871
    )
872
    .await
873
    .cookie
874
    .unwrap();
875
    let bob = call(
876
        app,
877
        "POST",
878
        "/register",
879
        None,
880
        None,
881
        None,
882
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
883
    )
884
    .await
885
    .cookie
886
    .unwrap();
ef20fdc1 Andy McCall ↶ 887
    let mint = |cookie: String, scopes: &'static str| {
888
        let app = app.clone();
889
        async move {
890
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
891
            let csrf = csrf_of(&page.body);
892
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
893
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
894
        }
895
    };
896
    let a = mint(andy, "scopes=repo%3Aadmin").await;
897
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
898
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
899
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
900
901
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
902
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
903
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
904
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
905
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
906
907
    // Cards by reference, into a column by name, and a note into the first column.
908
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
909
    assert_eq!(st, StatusCode::CREATED, "{card}");
910
    assert_eq!(
911
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
912
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
913
    );
914
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
915
    assert_eq!(st, StatusCode::BAD_REQUEST);
916
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
efb51b39 Andy McCall ↶ 917
    // The form the board shows its cards in is taken too (#118); another owner's is refused.
918
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"andy/demo#1"}"#)).await;
919
    assert!(v["detail"].as_str().unwrap().contains("already on this project"), "{v}");
920
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"other/demo#1"}"#)).await;
921
    assert!(v["detail"].as_str().unwrap().contains("only andy's"), "{v}");
ef20fdc1 Andy McCall ↶ 922
    assert_eq!(
923
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
924
        StatusCode::BAD_REQUEST
925
    );
926
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
927
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
928
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
929
930
    // Move and read the board.
931
    let id = card["id"].as_i64().unwrap();
932
    assert_eq!(
933
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
934
        StatusCode::NO_CONTENT
935
    );
936
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
937
    let names: Vec<(&str, usize)> =
938
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
939
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
940
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
17a3a84b Andy McCall ↶ 941
    // The cards by column (#115), and a wrong method answers with a body.
942
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
943
    assert_eq!(st, StatusCode::OK);
944
    assert_eq!(cols, board["columns"]);
945
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
946
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
947
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
ef20fdc1 Andy McCall ↶ 948
949
    // Private: hidden from others; closed: read-only; then remove a card.
950
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
951
    assert_eq!(edited["public"], false);
952
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
953
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
954
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
955
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
956
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
957
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
958
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
959
}
961c10be Andy McCall ↶ 960
961
#[tokio::test(flavor = "multi_thread")]
962
async fn api_required_checks() {
963
    let h = hub().await;
964
    let app = &h.app;
c8684d44 Andy McCall 965
    let andy = call(
966
        app,
967
        "POST",
968
        "/register",
969
        None,
970
        None,
971
        None,
972
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
973
    )
974
    .await
975
    .cookie
976
    .unwrap();
961c10be Andy McCall ↶ 977
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
978
    let csrf = csrf_of(&page.body);
979
    let mint = |scopes: &'static str| {
980
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
981
        async move {
982
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
983
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
984
        }
985
    };
986
    let admin = mint("scopes=repo%3Aadmin").await;
987
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
988
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
989
990
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
991
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
992
    let (st, v) = api(
993
        app,
994
        "PUT",
995
        "/api/v1/repos/andy/demo/checks/required",
996
        Some(&admin),
997
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
998
    )
999
    .await;
1000
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1001
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1002
    assert_eq!(
1003
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1004
        serde_json::json!(["flow/fmt", "flow/test"])
1005
    );
1006
    assert_eq!(
1007
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1008
        StatusCode::FORBIDDEN,
1009
        "repo:admin only"
1010
    );
1011
    assert_eq!(
1012
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1013
        StatusCode::BAD_REQUEST
1014
    );
1015
    // The settings page shows the same list.
1016
    assert!(call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
1017
}
9008bf6c Andy McCall ↶ 1018
1019
/// OxygenFlow per repository: site administrators turn it on or off in
1020
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1021
#[tokio::test(flavor = "multi_thread")]
1022
async fn flow_is_switched_per_repository_by_site_admins() {
1023
    let h = hub().await;
1024
    let app = &h.app;
c8684d44 Andy McCall 1025
    let andy = call(
1026
        app,
1027
        "POST",
1028
        "/register",
1029
        None,
1030
        None,
1031
        None,
1032
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1033
    )
1034
    .await
1035
    .cookie
1036
    .unwrap();
9008bf6c Andy McCall ↶ 1037
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1038
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1039
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1040
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1041
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
1042
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings#flow"));
1043
1044
    let set = |value: &'static str| {
1045
        let (app, andy) = (app.clone(), andy.clone());
1046
        async move {
1047
            let settings = call(&app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
1048
            call(
1049
                &app,
1050
                "POST",
1051
                "/andy/demo/settings/flow",
1052
                None,
1053
                Some(&andy),
1054
                None,
1055
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1056
            )
1057
            .await
1058
        }
1059
    };
1060
    // A repository admin who is not a site admin sees the state but cannot change it.
1061
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1062
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
1063
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
1064
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1065
    let r = set("on").await;
1066
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1067
    assert_eq!(row().await.flow, "");
1068
1069
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1070
    let r = set("on").await;
1071
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1072
    assert_eq!(row().await.flow, "on");
1073
    assert!(oxygenhub::flow::enabled(app, &row().await));
1074
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1075
    set("off").await;
1076
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1077
    set("default").await;
1078
    assert_eq!(row().await.flow, "");
1870e4fa Andy McCall ↶ 1079
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
9008bf6c Andy McCall ↶ 1080
}
e271a37b Andy McCall ↶ 1081
1082
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1083
/// button, never the repository's default bookmark as the hub sets it.
1084
#[tokio::test(flavor = "multi_thread")]
1085
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1086
    let h = hub().await;
1087
    let app = &h.app;
c8684d44 Andy McCall 1088
    let andy = call(
1089
        app,
1090
        "POST",
1091
        "/register",
1092
        None,
1093
        None,
1094
        None,
1095
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1096
    )
1097
    .await
1098
    .cookie
1099
    .unwrap();
e271a37b Andy McCall ↶ 1100
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1101
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1102
    let url = format!("{}/andy/demo", h.base);
1103
    let work = tempfile::tempdir().unwrap();
1104
    let (w, u) = (work.path().to_path_buf(), url.clone());
1105
    let client = tokio::task::spawn_blocking(move || {
1106
        let mut c = Repo::init(&w).unwrap();
1107
        c.config.set("remote.origin.url", &u).unwrap();
1108
        c.config.set("remote.origin.token", "site").unwrap();
1109
        c.save_config().unwrap();
1110
        write(&w, "a.txt", b"a\n");
1111
        c.commit("a", &[]).unwrap();
1112
        assert!(c.push("origin", false).unwrap()[0].ok);
1113
        for b in ["develop", "feature/x", "stray"] {
1114
            c.bookmark_create(b, None).unwrap();
1115
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1116
        }
1117
        // A pushed deletion.
1118
        let r = c.push_delete("origin", "feature/x").unwrap();
1119
        assert!(r[0].ok, "{r:?}");
1120
        c
1121
    })
1122
    .await
1123
    .unwrap();
1124
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1125
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1126
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1127
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1128
    assert!(!anon.body.contains("/bookmarks/delete"));
1129
1130
    // The hub's default, not the repository's config, is protected: make
1131
    // develop the default, then main can go and develop cannot.
1132
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1133
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1134
    let client = tokio::task::spawn_blocking(move || {
1135
        let r = client.push_delete("origin", "develop").unwrap();
1136
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1137
        let r = client.push_delete("origin", "main").unwrap();
1138
        assert!(r[0].ok, "{r:?}");
1139
        client
1140
    })
1141
    .await
1142
    .unwrap();
1143
    drop(client);
1144
1145
    // On the web: a writer deletes stray; the default is refused.
1146
    let form = |b: &'static str| {
1147
        let (app, andy) = (app.clone(), andy.clone());
1148
        async move {
1149
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1150
            call(
1151
                &app,
1152
                "POST",
1153
                "/andy/demo/bookmarks/delete",
1154
                None,
1155
                Some(&andy),
1156
                None,
1157
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1158
            )
1159
            .await
1160
        }
1161
    };
1162
    let r = form("stray").await;
1163
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1164
    assert!(!r.body.contains(">stray<"));
1165
    let r = form("develop").await;
1166
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1167
    let r = form("nope").await;
1168
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1169
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1170
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1171
    // Anonymous visitors cannot.
1172
    assert_ne!(
1173
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1174
        StatusCode::OK
1175
    );
1176
}
760a7dd3 Andy McCall ↶ 1177
1178
/// A change signed by a key no account has linked says so, on its page
1179
/// and in the API (feedback 14).
1180
#[tokio::test(flavor = "multi_thread")]
1181
async fn changes_signed_by_unlinked_keys_say_so() {
1182
    let h = hub().await;
1183
    let app = &h.app;
c8684d44 Andy McCall 1184
    let andy = call(
1185
        app,
1186
        "POST",
1187
        "/register",
1188
        None,
1189
        None,
1190
        None,
1191
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1192
    )
1193
    .await
1194
    .cookie
1195
    .unwrap();
760a7dd3 Andy McCall ↶ 1196
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1197
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1198
    let url = format!("{}/andy/demo", h.base);
1199
    let work = tempfile::tempdir().unwrap();
1200
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1201
    let hash = tokio::task::spawn_blocking(move || {
1202
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1203
        c.config.set("remote.origin.url", &u).unwrap();
1204
        c.config.set("remote.origin.token", "site").unwrap();
1205
        c.save_config().unwrap();
1206
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1207
        write(&w.join("r"), "a.txt", b"a\n");
1208
        let h = c.commit("signed by Ada", &[]).unwrap();
1209
        assert!(c.push("origin", false).unwrap()[0].ok);
1210
        h.to_hex()
1211
    })
1212
    .await
1213
    .unwrap();
1214
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1215
    assert_eq!(st, StatusCode::OK, "{v}");
1216
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1217
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1218
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1219
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1220
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1221
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1222
}
65be9f9c Andy McCall ↶ 1223
1224
/// Function history (hub spec §6.6): the file page lists a file's
1225
/// functions, and a function's page lists exactly the changes to its lines.
1226
#[tokio::test(flavor = "multi_thread")]
1227
async fn a_function_has_its_own_history() {
1228
    let h = hub().await;
1229
    let app = &h.app;
c8684d44 Andy McCall 1230
    let andy = call(
1231
        app,
1232
        "POST",
1233
        "/register",
1234
        None,
1235
        None,
1236
        None,
1237
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1238
    )
1239
    .await
1240
    .cookie
1241
    .unwrap();
65be9f9c Andy McCall ↶ 1242
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1243
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1244
    let url = format!("{}/andy/demo", h.base);
1245
    let work = tempfile::tempdir().unwrap();
1246
    let w = work.path().to_path_buf();
1247
    tokio::task::spawn_blocking(move || {
1248
        let mut c = Repo::init(&w).unwrap();
1249
        c.config.set("remote.origin.url", &url).unwrap();
1250
        c.config.set("remote.origin.token", "site").unwrap();
1251
        c.save_config().unwrap();
1252
        let steps = [
1253
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1254
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1255
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1256
        ];
1257
        for (msg, text) in steps {
1258
            write(&w, "src/lib.rs", text.as_bytes());
1259
            c.commit(msg, &[]).unwrap();
1260
        }
1261
        assert!(c.push("origin", false).unwrap()[0].ok);
1262
    })
1263
    .await
1264
    .unwrap();
1265
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1266
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1267
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1268
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1269
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1270
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1271
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1272
    assert_ne!(bad.status, StatusCode::OK);
1273
}
92574625 Andy McCall ↶ 1274
1275
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1276
/// dependency edges, linked cards.
1277
#[tokio::test(flavor = "multi_thread")]
1278
async fn a_bookmark_shows_as_swimlanes() {
1279
    let h = hub().await;
1280
    let app = &h.app;
c8684d44 Andy McCall 1281
    let andy = call(
1282
        app,
1283
        "POST",
1284
        "/register",
1285
        None,
1286
        None,
1287
        None,
1288
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1289
    )
1290
    .await
1291
    .cookie
1292
    .unwrap();
92574625 Andy McCall ↶ 1293
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1294
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1295
    let url = format!("{}/andy/demo", h.base);
1296
    let work = tempfile::tempdir().unwrap();
1297
    let w = work.path().to_path_buf();
1298
    tokio::task::spawn_blocking(move || {
1299
        let mut c = Repo::init(&w).unwrap();
1300
        c.config.set("remote.origin.url", &url).unwrap();
1301
        c.config.set("remote.origin.token", "site").unwrap();
1302
        c.save_config().unwrap();
1303
        // Two files edited independently: two lanes.
1304
        write(&w, "a.txt", b"a\n");
1305
        c.commit("add a", &[]).unwrap();
1306
        write(&w, "b.txt", b"b\n");
1307
        c.commit("add b", &[]).unwrap();
1308
        write(&w, "a.txt", b"a\na2\n");
1309
        c.commit("grow a", &[]).unwrap();
1310
        assert!(c.push("origin", false).unwrap()[0].ok);
1311
    })
1312
    .await
1313
    .unwrap();
1314
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1315
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1316
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1317
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1318
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1319
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1320
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1321
    assert_eq!(board.matches("<rect ").count(), 3);
1322
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1323
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1324
}
2bfe5ef6 Andy McCall ↶ 1325
1326
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1327
/// offers only what makes sense and rewrites nothing itself.
1328
#[tokio::test(flavor = "multi_thread")]
1329
async fn a_proposal_board_plans_squashes_and_rebases() {
1330
    let h = hub().await;
1331
    let app = &h.app;
c8684d44 Andy McCall 1332
    let andy = call(
1333
        app,
1334
        "POST",
1335
        "/register",
1336
        None,
1337
        None,
1338
        None,
1339
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1340
    )
1341
    .await
1342
    .cookie
1343
    .unwrap();
2bfe5ef6 Andy McCall ↶ 1344
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1345
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1346
    let url = format!("{}/andy/demo", h.base);
1347
    let work = tempfile::tempdir().unwrap();
1348
    let w = work.path().to_path_buf();
1349
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1350
        let mut c = Repo::init(&w).unwrap();
1351
        c.config.set("remote.origin.url", &url).unwrap();
1352
        c.config.set("remote.origin.token", "site").unwrap();
1353
        c.save_config().unwrap();
1354
        write(&w, "a.txt", b"a\n");
1355
        let base = c.commit("base", &[]).unwrap();
1356
        assert!(c.push("origin", false).unwrap()[0].ok);
1357
        c.bookmark_create("feature", None).unwrap();
1358
        c.bookmark_switch("feature", false).unwrap();
1359
        write(&w, "a.txt", b"a\nfirst\n");
1360
        let first = c.commit("first", &[]).unwrap();
1361
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1362
        let second = c.commit("second", &[]).unwrap();
1363
        write(&w, "b.txt", b"apart\n");
1364
        let apart = c.commit("apart", &[]).unwrap();
1365
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1366
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1367
    })
1368
    .await
1369
    .unwrap();
1370
    // No proposal yet: the board is read-only.
1371
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1372
    assert!(!board.contains("data-plan="));
1373
    let (st, _) = api(
1374
        app,
1375
        "POST",
1376
        "/api/v1/repos/andy/demo/proposals",
1377
        Some("site"),
1378
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1379
    )
1380
    .await;
1381
    assert!(st.is_success(), "{st}");
1382
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1383
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1384
    let csrf = csrf_of(&board);
1385
    let plan = |c: &str, t: &str| {
1386
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1387
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1388
        async move {
1389
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1390
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1391
        }
1392
    };
1393
    let kinds = |v: &serde_json::Value| {
1394
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1395
    };
1396
    // second already depends on first: squash, no rebase.
1397
    let v = plan(&second, &first).await;
1398
    assert_eq!(kinds(&v), ["squash"], "{v}");
1399
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
c96b3286 Andy McCall ↶ 1400
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
2bfe5ef6 Andy McCall ↶ 1401
    // apart is independent of second: either.
1402
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1403
    // first under second: nothing (second depends on first).
1404
    assert!(plan(&first, &second).await["error"].is_string());
1405
    // What has landed on main is not rearranged.
1406
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1407
}
38833ed7 Andy McCall ↶ 1408
1409
/// Issues and proposals share a number space, so every number says what it
1410
/// is, and the chain of work shows from both ends (hub spec §8).
1411
#[tokio::test(flavor = "multi_thread")]
1412
async fn proposals_and_issues_show_their_chain() {
1413
    let h = hub().await;
1414
    let app = &h.app;
c8684d44 Andy McCall 1415
    let andy = call(
1416
        app,
1417
        "POST",
1418
        "/register",
1419
        None,
1420
        None,
1421
        None,
1422
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1423
    )
1424
    .await
1425
    .cookie
1426
    .unwrap();
38833ed7 Andy McCall ↶ 1427
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1428
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1429
    let url = format!("{}/andy/demo", h.base);
1430
    let work = tempfile::tempdir().unwrap();
1431
    let w = work.path().to_path_buf();
1432
    tokio::task::spawn_blocking(move || {
1433
        let mut c = Repo::init(&w).unwrap();
1434
        c.config.set("remote.origin.url", &url).unwrap();
1435
        c.config.set("remote.origin.token", "site").unwrap();
1436
        c.save_config().unwrap();
1437
        write(&w, "a.txt", b"a\n");
1438
        c.commit("base", &[]).unwrap();
1439
        assert!(c.push("origin", false).unwrap()[0].ok);
1440
        c.bookmark_create("feature", None).unwrap();
1441
        c.bookmark_switch("feature", false).unwrap();
1442
        write(&w, "a.txt", b"a\nfixed\n");
1443
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1444
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1445
    })
1446
    .await
1447
    .unwrap();
1448
    for title in ["Slow start", "Crash on save"] {
1449
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1450
        assert!(st.is_success());
1451
    }
1452
    let (st, v) = api(
1453
        app,
1454
        "POST",
1455
        "/api/v1/repos/andy/demo/proposals",
1456
        Some("site"),
1457
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1458
    )
1459
    .await;
1460
    assert!(st.is_success(), "{st} {v}");
1461
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1462
1463
    // The proposal names its kind, links its references by kind, and shows
1464
    // the chain: the issues it closes (description and changes) → it → main.
1465
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1466
    assert!(p.contains(">proposal #3</small>"), "header");
1467
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1468
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1469
    let chain = &chain[..chain.find("</p>").unwrap()];
1470
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1471
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1472
    }
1473
    assert!(p.contains("<h3>Closes</h3>"));
1474
1475
    // The issue shows the proposal that closes it, and names its own kind.
1476
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1477
    assert!(i.contains(">issue #1</small>"));
1478
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1479
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
a1b98695 Andy McCall ↶ 1480
    // The conversation is a timeline with avatars; editing sits with the
1481
    // content, not in the sidebar, and labels and projects are editable.
1482
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1483
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1484
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1485
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1486
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1487
    assert!(st.is_success(), "{st}");
1488
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
9e50caed Andy McCall ↶ 1489
    assert!(
1490
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1491
        "the owner's projects to add to, in a menu"
1492
    );
a1b98695 Andy McCall ↶ 1493
    let csrf = csrf_of(&p);
1494
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1495
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1496
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1497
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1498
        .await;
1499
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1500
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1501
38833ed7 Andy McCall ↶ 1502
    // Closed by the proposal's change, not its description: still shown.
1503
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1504
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1505
    assert!(chain.contains("proposal #3"), "{chain}");
1506
}
e9bfea8e Andy McCall ↶ 1507
1508
/// What the hub is: its version and build, and the libraries it is built on,
1509
/// on /about, in the API and in /health (hub spec §15).
1510
#[tokio::test(flavor = "multi_thread")]
1511
async fn the_hub_says_what_version_it_is() {
1512
    let h = hub().await;
1513
    let app = &h.app;
1514
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1515
    assert_eq!(st, StatusCode::OK);
1516
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1517
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1518
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1519
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1520
    assert!(health.contains("\"build\""), "{health}");
b2107275 Andy McCall ↶ 1521
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1522
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
e9bfea8e Andy McCall ↶ 1523
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1524
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1525
    assert!(about.contains("href=\"/about\""), "the footer links here");
1526
}
df71c789 Andy McCall ↶ 1527
1528
#[tokio::test(flavor = "multi_thread")]
1529
async fn device_sign_in() {
1530
    let h = hub().await;
1531
    let app = &h.app;
c8684d44 Andy McCall 1532
    let r = call(
1533
        app,
1534
        "POST",
1535
        "/register",
1536
        None,
1537
        None,
1538
        None,
1539
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1540
    )
1541
    .await;
df71c789 Andy McCall ↶ 1542
    let andy = r.cookie.unwrap();
1543
1544
    // An unknown scope is refused.
1545
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1546
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1547
1548
    // The app asks for a code and polls; nobody has approved it yet.
1549
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1550
    assert_eq!(st, StatusCode::OK, "{v}");
1551
    let device = v["device_code"].as_str().unwrap().to_string();
1552
    let user = v["user_code"].as_str().unwrap().to_string();
1553
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1554
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1555
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1556
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1557
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1558
    assert_eq!(v["error"], "slow_down", "polled too soon");
1559
1560
    // The user approves it on the web, allowing less than it asked for.
1561
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1562
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1563
    let csrf = csrf_of(&page.body);
1564
    let r =
1565
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1566
            .await;
4da8b828 Andy McCall ↶ 1567
    // oxygenhub#83: the answer page says it is done, with no code form.
1568
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1569
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
df71c789 Andy McCall ↶ 1570
1571
    // The next poll gets a token with what was allowed, once.
1572
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1573
    assert_eq!(st, StatusCode::OK, "{v}");
1574
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1575
    let token = v["access_token"].as_str().unwrap().to_string();
1576
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1577
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1578
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1579
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1580
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1581
    assert!(tokens.body.contains("device: Phone app"));
60f11b71 Andy McCall ↶ 1582
    // oxygenhub#70: a device's token expires, and each use renews it.
1583
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
df71c789 Andy McCall ↶ 1584
60f11b71 Andy McCall ↶ 1585
    // The token can revoke itself (oxy auth logout), and is then refused.
1586
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1587
    assert_eq!(st, StatusCode::NO_CONTENT);
1588
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1589
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1590
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1591
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1592
df71c789 Andy McCall ↶ 1593
    // A denied code says so.
1594
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1595
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1596
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1597
    let csrf = csrf_of(&page.body);
1598
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1599
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1600
    assert_eq!(v["error"], "access_denied");
1601
1602
    // Signed out, the page asks for a sign-in first.
1603
    let r = call(app, "GET", "/device", None, None, None, None).await;
1604
    assert!(r.status.is_redirection(), "{}", r.status);
1605
}
62ceb2ee Andy McCall ↶ 1606
1607
#[tokio::test(flavor = "multi_thread")]
1608
async fn api_assistants_at_each_level() {
1609
    let h = hub().await;
1610
    let app = &h.app;
c8684d44 Andy McCall 1611
    let andy = call(
1612
        app,
1613
        "POST",
1614
        "/register",
1615
        None,
1616
        None,
1617
        None,
1618
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1619
    )
1620
    .await
1621
    .cookie
1622
    .unwrap();
62ceb2ee Andy McCall ↶ 1623
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1624
    let csrf = csrf_of(&page.body);
1625
    let mint = |scopes: &'static str| {
1626
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1627
        async move {
1628
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1629
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1630
        }
1631
    };
1632
    let admin = mint("scopes=repo%3Aadmin").await;
1633
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1634
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1635
    // A stand-in endpoint with no model list: any model name is taken.
1636
    let router = axum::Router::new().route(
1637
        "/v1/chat/completions",
1638
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1639
    );
1640
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1641
    let port = listener.local_addr().unwrap().port();
1642
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1643
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1644
1645
    // The site's, by its administrator; the repository's, by its admin.
1646
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1647
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1648
    assert_eq!(st, StatusCode::OK, "{v}");
1649
    assert_eq!(v["ok"], "Gemini added");
1650
    let body =
1651
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1652
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1653
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1654
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1655
    assert_eq!(st, StatusCode::OK, "{v}");
1656
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1657
    assert_eq!(st, StatusCode::OK);
1658
    let names: Vec<(&str, &str, bool)> = v
1659
        .as_array()
1660
        .unwrap()
1661
        .iter()
1662
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1663
        .collect();
1664
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1665
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1666
    // Changing it keeps the token when none is given.
1667
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1668
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1669
    assert_eq!(v["ok"], "Claude updated");
1670
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1671
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1672
    // Prompts: the site's is inherited by the repository.
1673
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1674
    assert_eq!(st, StatusCode::OK);
1675
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1676
    assert_eq!(v["prompt"], "Rust.");
1677
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1678
    // Removed.
1679
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1680
    assert_eq!(st, StatusCode::NO_CONTENT);
1681
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1682
    assert_eq!(st, StatusCode::NOT_FOUND);
1683
}