OXYGENHUB
◆ v0.7.0 oxygenhub / crates / hub / tests / api.rs
84.3 KiB · Rust · last changed Repository settings: one page per setting under a grouped sidebar (#278) 15 days ago source blame history raw
b64e2537 Andy McCall ↶ 1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use std::sync::{Arc, Mutex};
15
use tower::ServiceExt;
16
17
fn hermetic() {
18
    static ONCE: std::sync::Once = std::sync::Once::new();
19
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
20
    ONCE.call_once(|| {
21
        let d = tempfile::tempdir().unwrap();
22
        std::env::set_var("OXY_HOME", d.path());
23
        DIR.set(d).ok();
24
    });
25
}
26
27
fn write(root: &Path, rel: &str, content: &[u8]) {
28
    let p = root.join(rel);
29
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
30
    std::fs::write(p, content).unwrap();
31
}
32
33
struct Hub {
34
    app: Shared,
35
    base: String,
36
    _dir: tempfile::TempDir,
37
}
38
39
async fn hub() -> Hub {
40
    hermetic();
41
    let dir = tempfile::tempdir().unwrap();
42
    let mut config = Config::load(dir.path()).unwrap();
c8684d44 Andy McCall 43
    // The first account's setup code (oxygenhub#245).
44
    config.registration.setup_code = "test-setup".into();
b64e2537 Andy McCall ↶ 45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
9a777fec Andy McCall ↶ 50
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
51
    config.outbound.allow = vec!["http://127.0.0.1".into()];
b64e2537 Andy McCall ↶ 52
    let app = oxygenhub::build(config).await.unwrap();
53
    let router = oxygenhub::router(app.clone());
54
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
55
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
56
}
57
58
struct Res {
59
    status: StatusCode,
60
    body: String,
61
    cookie: Option<String>,
c7067c7b Andy McCall 62
    location: Option<String>,
b64e2537 Andy McCall ↶ 63
}
64
65
async fn call(
66
    app: &Shared,
67
    method: &str,
68
    path: &str,
69
    bearer: Option<&str>,
70
    cookie: Option<&str>,
71
    json: Option<&str>,
72
    form: Option<&str>,
73
) -> Res {
74
    let mut req = Request::builder().method(method).uri(path);
75
    if let Some(b) = bearer {
76
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
77
    }
78
    if let Some(c) = cookie {
79
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
80
    }
81
    let body = if let Some(j) = json {
82
        req = req.header(header::CONTENT_TYPE, "application/json");
83
        Body::from(j.to_string())
84
    } else if let Some(f) = form {
85
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
86
        Body::from(f.to_string())
87
    } else {
88
        Body::empty()
89
    };
90
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
91
    let status = res.status();
92
    let cookie = res
93
        .headers()
94
        .get(header::SET_COOKIE)
95
        .and_then(|v| v.to_str().ok())
96
        .and_then(|v| v.split(';').next())
97
        .and_then(|kv| kv.split_once('='))
98
        .map(|(_, v)| v.to_string());
c7067c7b Andy McCall 99
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
b64e2537 Andy McCall ↶ 100
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
c7067c7b Andy McCall 101
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
b64e2537 Andy McCall ↶ 102
}
103
c7067c7b Andy McCall 104
/// A repository settings form's answer (#278): a redirect to the page that
105
/// holds the form, followed.
106
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
107
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
108
    let to = r.location.expect("a redirect");
109
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
110
    call(app, "GET", &to, None, cookie, None, None).await
111
}
112
b64e2537 Andy McCall ↶ 113
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
114
    let r = call(app, method, path, bearer, None, json, None).await;
115
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
116
    (r.status, v)
117
}
118
119
fn csrf_of(page: &str) -> String {
120
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
121
    page[i..].split('"').next().unwrap().to_string()
122
}
123
124
/// A webhook receiver that records what it gets and fails the first time.
125
struct Receiver {
126
    url: String,
127
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
128
    fail_first: Arc<Mutex<bool>>,
129
}
130
131
async fn receiver() -> Receiver {
132
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
133
    let fail_first = Arc::new(Mutex::new(true));
134
    let (s2, f2) = (seen.clone(), fail_first.clone());
135
    let router = Router::new().route(
136
        "/hook",
137
        post(move |headers: header::HeaderMap, body: String| {
138
            let (s2, f2) = (s2.clone(), f2.clone());
139
            async move {
140
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
141
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
142
                let mut f = f2.lock().unwrap();
143
                if *f {
144
                    *f = false;
145
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
146
                }
147
                s2.lock().unwrap().push((event, sig, body));
148
                (StatusCode::OK, "ok")
149
            }
150
        }),
151
    );
152
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
153
    let port = listener.local_addr().unwrap().port();
154
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
155
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
156
}
157
158
#[tokio::test(flavor = "multi_thread")]
159
async fn api_webhooks_and_checks() {
160
    let h = hub().await;
161
    let app = &h.app;
162
    // Accounts and tokens through the pages.
c8684d44 Andy McCall 163
    let r = call(
164
        app,
165
        "POST",
166
        "/register",
167
        None,
168
        None,
169
        None,
170
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
171
    )
172
    .await;
b64e2537 Andy McCall ↶ 173
    let andy = r.cookie.unwrap();
c8684d44 Andy McCall 174
    let r = call(
175
        app,
176
        "POST",
177
        "/register",
178
        None,
179
        None,
180
        None,
181
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
182
    )
183
    .await;
b64e2537 Andy McCall ↶ 184
    let bob = r.cookie.unwrap();
185
    let mint = |cookie: String, scopes: &'static str| {
186
        let app = app.clone();
187
        async move {
188
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
189
            let csrf = csrf_of(&page.body);
190
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
191
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
192
        }
193
    };
194
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
195
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
196
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
197
198
    // Create a repository through the API; the read-only token cannot.
199
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
200
    assert_eq!(st, StatusCode::FORBIDDEN);
201
    let (st, v) = api(
202
        app,
203
        "POST",
204
        "/api/v1/repos",
205
        Some(&andy_admin),
206
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
207
    )
208
    .await;
209
    assert_eq!(st, StatusCode::CREATED, "{v}");
210
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
211
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
212
    assert_eq!(st, StatusCode::CONFLICT);
213
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
214
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
215
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
216
    assert_eq!(st, StatusCode::OK);
217
    assert_eq!(v["username"], "andy");
218
219
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
220
    let rx = receiver().await;
221
    let (st, v) = api(
222
        app,
223
        "POST",
224
        "/api/v1/repos/andy/demo/hooks",
225
        Some(&andy_admin),
226
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
227
    )
228
    .await;
229
    assert_eq!(st, StatusCode::CREATED, "{v}");
230
    let work = tempfile::tempdir().unwrap();
231
    let mut client = Repo::init(work.path()).unwrap();
232
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
233
    client.config.set("remote.origin.token", "site").unwrap();
234
    client.save_config().unwrap();
235
    write(work.path(), "a.txt", b"a\n");
236
    client.snapshot("t").unwrap();
237
    let base = client.commit("base", &[]).unwrap();
238
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
239
    // The worker retries with backoff; drive it directly for the retry.
240
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
241
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
242
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
243
    oxygenhub::hooks::deliver_due(app).await;
244
    let seen = rx.seen.lock().unwrap().clone();
245
    assert_eq!(seen.len(), 1, "{seen:?}");
246
    assert_eq!(seen[0].0, "push");
247
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
248
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
249
    assert_eq!(payload["repository"]["name"], "demo");
250
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
252
    assert_eq!(v.as_array().unwrap().len(), 1);
253
254
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
255
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
256
    assert_eq!(st, StatusCode::OK);
257
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
f28389bd Andy McCall ↶ 258
    // A revset in place of the whole history (`?r=`), under a budget; a
259
    // bad one is the caller's problem.
260
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
261
    assert_eq!(st, StatusCode::OK, "{v}");
262
    assert_eq!(v["total"].as_u64(), Some(1));
263
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
264
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
265
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
266
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
267
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
b64e2537 Andy McCall ↶ 268
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
269
    assert_eq!(v[0]["name"], "a.txt");
270
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
271
    assert_eq!(r.body, "a\n");
272
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
273
    assert_eq!(v[0]["change"], base.to_hex());
274
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
275
    assert_eq!(v["files"][0]["path"], "a.txt");
276
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
277
    assert!(v["policy"].is_null());
278
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
279
    assert_eq!(v[0]["reference"], "main");
280
281
    // Issues through the API: Bob opens one, comments, and closes it.
282
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
283
    assert_eq!(st, StatusCode::CREATED, "{v}");
284
    assert_eq!(v["number"], 1);
285
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
286
    assert_eq!(st, StatusCode::CREATED);
287
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
288
    assert_eq!(st, StatusCode::OK, "{v}");
289
    assert_eq!(v["state"], "closed");
290
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
291
    assert_eq!(v[0]["comments"], 1);
292
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
293
    assert_eq!(v[0]["number"], 1);
294
295
    // A proposal through the API, then a required check gates its landing.
296
    client.bookmark_create("feat", Some(&[base])).unwrap();
297
    client.bookmark_switch("feat", false).unwrap();
298
    write(work.path(), "b.txt", b"b\n");
3f02e5ea Andy McCall ↶ 299
    write(work.path(), "a.txt", b"a\nA\n");
b64e2537 Andy McCall ↶ 300
    client.snapshot("t").unwrap();
301
    let feat = client.commit("feat", &[]).unwrap();
302
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
303
    let (st, v) =
304
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
305
            .await;
306
    assert_eq!(st, StatusCode::CREATED, "{v}");
307
    assert_eq!(v["number"], 2);
308
    let state = v["projected_state"].as_str().unwrap().to_string();
309
    assert_eq!(v["landable"], true);
a0dd06b0 Andy McCall ↶ 310
    // A wiki takes no proposals, and says so rather than "no such
311
    // repository" (oxygenhub#128); a repository's that does not exist
312
    // still does not.
313
    let (st, v) =
314
        api(app, "POST", "/api/v1/repos/andy/demo.wiki/proposals", Some(&bob_rw), Some(r#"{"title":"W","target":"main","source":"p"}"#))
315
            .await;
316
    let detail = v["detail"].as_str().unwrap_or_default();
317
    assert!(st == StatusCode::NOT_FOUND && detail.contains("is the wiki of andy/demo") && detail.contains("push main"), "{v}");
318
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/nope.wiki/proposals", Some(&bob_rw), None).await;
319
    assert_eq!(v["detail"], "no such repository");
3f02e5ea Andy McCall ↶ 320
    // Its files, and each side's bytes, for editors' diff views.
321
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
322
    assert_eq!(st, StatusCode::OK, "{v}");
323
    let files: Vec<(String, String)> =
324
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
325
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
326
    assert_eq!(v[0]["added"], 1);
327
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
328
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
329
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
330
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
331
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
332
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
c0fac31d Andy McCall ↶ 333
    // An anchored comment comes back with its line in the projected state.
334
    let (st, v) = api(
335
        app,
336
        "POST",
337
        "/api/v1/repos/andy/demo/proposals/2/comments",
338
        Some(&bob_rw),
339
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
340
    )
341
    .await;
342
    assert_eq!(st, StatusCode::CREATED, "{v}");
343
    assert_eq!(v["line"], 2);
344
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
345
    assert_eq!(v[0]["path"], "a.txt");
346
    assert_eq!(v[0]["line"], 2, "{v}");
347
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
b64e2537 Andy McCall ↶ 348
    // Require the "build" check.
349
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
350
    let csrf = csrf_of(&settings.body);
c7067c7b Andy McCall 351
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
352
        .await;
353
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
b64e2537 Andy McCall ↶ 354
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
355
    assert_eq!(v["landable"], false);
356
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
357
    // A checker reports on the projected state: first running, then passed; the page streams it.
358
    let (st, v) = api(
359
        app,
360
        "POST",
361
        "/api/v1/repos/andy/demo/checks",
362
        Some(&andy_ro),
363
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
364
    )
365
    .await;
366
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
33d98147 Andy McCall 367
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
b64e2537 Andy McCall ↶ 368
    let (st, v) = api(
369
        app,
370
        "POST",
371
        "/api/v1/repos/andy/demo/checks",
372
        Some(&bob_rw),
373
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
374
    )
375
    .await;
376
    assert_eq!(st, StatusCode::CREATED, "{v}");
33d98147 Andy McCall 377
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
b64e2537 Andy McCall ↶ 378
    assert_eq!(ev.kind, "check");
379
    assert_eq!(ev.check.unwrap().name, "build");
380
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
381
    assert_eq!(v[0]["status"], "passed");
382
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
383
    assert_eq!(v["landable"], true, "{v}");
384
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
385
    assert!(page.body.contains("42 tests"), "{}", page.body);
a2ef53c5 Andy McCall ↶ 386
    // A summary carrying whole hashes shows them by their ends, so the
387
    // Checks panel keeps its width (a pin mismatch's message, 2026-10-16).
388
    let (a, b) = (
389
        "6ea27b1d35037a4e4d0f6208b1ca99630df40888bd21fd55c8f8aba51dcdd7cb",
390
        "f7495d7689da3ac5b68684f26fce28b91ce55e6b8131c5e484ad2aab90c3020f",
391
    );
392
    let summary = format!("could not run: flow-init has BLAKE3 {a}, but {b} is pinned");
393
    let body = serde_json::json!({ "state": state, "name": "lint", "status": "failed", "summary": summary }).to_string();
394
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/checks", Some(&bob_rw), Some(&body)).await;
395
    assert_eq!(st, StatusCode::CREATED, "{v}");
396
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await.body;
397
    assert!(page.contains("6ea27b1d…1dcdd7cb") && page.contains(&format!("data-full=\"{a}\"")), "{page}");
398
    assert!(!page.contains(&format!("BLAKE3 {a},")), "never the whole hash inline");
399
    // The Checks section refreshes itself; nothing reloads the whole page.
400
    assert!(!page.contains("location.reload()"), "no full reload on a check");
401
    let part = call(app, "GET", "/andy/demo/proposal/2?fragment=checks", None, Some(&andy), None, None).await.body;
402
    assert!(part.contains("<h3>Checks</h3>") && part.contains("6ea27b1d…1dcdd7cb") && !part.contains("<html"), "{part}");
b64e2537 Andy McCall ↶ 403
    // The check and the proposal reached the webhook too.
404
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
405
    oxygenhub::hooks::deliver_due(app).await;
406
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
407
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
408
    let _ = feat;
409
    let _ = rx.fail_first;
42a0ba4b Andy McCall ↶ 410
411
    // The inbox through the API: count, list, mark one read, mark all read.
412
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
413
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
414
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
eb0c44a9 Andy McCall ↶ 415
    oxygenhub::db::notify::add(
416
        &app.db,
417
        oxygenhub::db::notify::New {
418
            account_id: bob_id,
419
            repo_id: None,
420
            reason: oxygenhub::db::notify::Reason::Participating,
421
            kind: "mention",
422
            title: "andy/demo#1: Bug",
423
            url: "/andy/demo/issue/1",
424
            actor: "andy",
425
        },
426
    )
427
    .await
428
    .unwrap();
429
    oxygenhub::db::notify::add(
430
        &app.db,
431
        oxygenhub::db::notify::New {
432
            account_id: bob_id,
433
            repo_id: None,
434
            reason: oxygenhub::db::notify::Reason::Participating,
435
            kind: "review",
436
            title: "andy/demo#2: Feat",
437
            url: "/andy/demo/proposal/2",
438
            actor: "andy",
439
        },
440
    )
441
    .await
442
    .unwrap();
42a0ba4b Andy McCall ↶ 443
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
444
    assert_eq!(st, StatusCode::OK, "{v}");
445
    assert_eq!(v["unread"], 2);
446
    assert_eq!(v["items"][0]["read"], false);
447
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
448
    let first = v["items"][0]["id"].as_i64().unwrap();
449
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
450
    assert_eq!(st, StatusCode::NO_CONTENT);
451
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
452
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
453
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
454
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
455
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
0b20f1ec Andy McCall ↶ 456
cc1cd197 Andy McCall ↶ 457
    // Review requests: the author asks andy; andy is told, reviews, and the
458
    // request is answered; the author hears of the review.
459
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
460
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
461
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
462
        .await
463
        .unwrap();
464
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
465
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
466
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
467
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
468
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
469
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
470
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
471
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
472
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
473
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
474
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
475
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
476
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
477
    let (st, _) =
478
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
479
    assert_eq!(st, StatusCode::CREATED);
480
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
481
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
482
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
483
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
484
    // Asking again and withdrawing it.
485
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
486
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
487
    assert_eq!(st, StatusCode::NO_CONTENT);
488
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
489
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
8e96499f Andy McCall ↶ 490
    // oxygenhub#84: the page's menu sets who is asked, all at once.
491
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
492
    assert!(
493
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
494
        "the reviewers menu lists andy"
495
    );
496
    let csrf = csrf_of(&page.body);
497
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
498
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
499
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
500
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
501
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
502
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
503
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
cc1cd197 Andy McCall ↶ 504
0b20f1ec Andy McCall ↶ 505
    // A source bookmark with `/` in its name, as a feature/N-name workflow
506
    // makes them: by name, and as this repository's owner/name:bookmark.
507
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
508
        client.bookmark_create(b, Some(&[base])).unwrap();
509
        client.bookmark_switch(b, false).unwrap();
510
        write(work.path(), file, b"c\n");
511
        client.snapshot("t").unwrap();
512
        client.commit(b, &[]).unwrap();
513
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
514
    }
515
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
516
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
517
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
518
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
519
        let n = v["number"].as_i64().unwrap();
520
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
521
        assert_eq!(page.status, StatusCode::OK);
522
        assert!(page.body.contains("feature/"), "the page names its source");
523
    }
524
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
525
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
526
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
739a763a Andy McCall ↶ 527
528
    // oxygenhub#76: a proposal's title and description are edited through
529
    // the API by its author or a maintainer; what is not given stays.
530
    let edit = |token: &str, number: i64, body: &str| {
531
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
532
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
533
    };
534
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
535
    assert_eq!(st, StatusCode::OK, "{v}");
536
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
537
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
538
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
539
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
540
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
541
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
542
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
543
    let (st, v) = api(
544
        app,
545
        "POST",
546
        "/api/v1/repos/andy/demo/proposals",
547
        Some(&andy_pw),
548
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
549
    )
550
    .await;
551
    assert_eq!(st, StatusCode::CREATED, "{v}");
552
    let n = v["number"].as_i64().unwrap();
553
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
554
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
2291f8cc Andy McCall ↶ 555
556
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
557
    // before anything changes, shown in its JSON.
558
    for l in ["ui", "flow"] {
559
        let body = format!(r#"{{"name":"{l}"}}"#);
560
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
561
    }
562
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
563
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
564
    assert_eq!(st, StatusCode::OK, "{v}");
565
    let names = |v: &serde_json::Value| -> Vec<String> {
566
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
567
    };
568
    assert_eq!(names(&v), ["flow", "ui"]);
569
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
570
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
571
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
572
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
573
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
574
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
575
    assert_eq!(names(&v), ["flow"]);
576
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
b64e2537 Andy McCall ↶ 577
}
76f262e1 Andy McCall ↶ 578
579
#[tokio::test(flavor = "multi_thread")]
580
async fn api_issue_triage_and_labels() {
581
    let h = hub().await;
582
    let app = &h.app;
c8684d44 Andy McCall 583
    let andy = call(
584
        app,
585
        "POST",
586
        "/register",
587
        None,
588
        None,
589
        None,
590
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
591
    )
592
    .await
593
    .cookie
594
    .unwrap();
595
    let bob = call(
596
        app,
597
        "POST",
598
        "/register",
599
        None,
600
        None,
601
        None,
602
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
603
    )
604
    .await
605
    .cookie
606
    .unwrap();
76f262e1 Andy McCall ↶ 607
    let mint = |cookie: String, scopes: &'static str| {
608
        let app = app.clone();
609
        async move {
610
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
611
            let csrf = csrf_of(&page.body);
612
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
613
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
614
        }
615
    };
616
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
617
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
618
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
619
    assert_eq!(st, StatusCode::CREATED);
620
621
    // Labels through the API; bad colours and non-triage callers are refused.
622
    let (st, v) = api(
623
        app,
624
        "POST",
625
        "/api/v1/repos/andy/demo/labels",
626
        Some(&andy_t),
627
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
628
    )
629
    .await;
630
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
631
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
632
    assert_eq!(
633
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
634
        StatusCode::BAD_REQUEST
635
    );
636
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
637
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
638
    assert_eq!(labels.as_array().unwrap().len(), 2);
5ea4872f Andy McCall ↶ 639
    // oxygenhub#91: milestones over the API, for triage.
640
    let (st, m) = api(
641
        app,
642
        "POST",
643
        "/api/v1/repos/andy/demo/milestones",
644
        Some(&andy_t),
645
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
646
    )
647
    .await;
648
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
649
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
650
    assert_eq!(
651
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
652
        StatusCode::BAD_REQUEST
653
    );
654
    assert_eq!(
655
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
656
        StatusCode::FORBIDDEN
657
    );
658
    let (st, m) =
659
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
660
            .await;
661
    assert_eq!(
662
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
663
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
664
        "{m}"
665
    );
666
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
667
    assert_eq!(
668
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
669
        StatusCode::NOT_FOUND,
670
        "renamed"
671
    );
672
    assert_eq!(
673
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
674
        StatusCode::BAD_REQUEST
675
    );
676
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
677
    assert_eq!(list.as_array().unwrap().len(), 1);
76f262e1 Andy McCall ↶ 678
679
    // An issue created with its labels and assignee in one call.
680
    let (st, v) = api(
681
        app,
682
        "POST",
683
        "/api/v1/repos/andy/demo/issues",
684
        Some(&andy_t),
685
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
686
    )
687
    .await;
688
    assert_eq!(st, StatusCode::CREATED, "{v}");
689
    assert_eq!(v["labels"][0]["name"], "bug");
690
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
691
    let n = v["number"].as_i64().unwrap();
692
    // Unknown names are refused before anything is created.
693
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
694
    assert_eq!(st, StatusCode::BAD_REQUEST);
695
    assert!(v["detail"].as_str().unwrap().contains("no label"));
696
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
697
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
698
    // Without triage, labels cannot be set, but a plain issue can be opened.
699
    assert_eq!(
700
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
701
        StatusCode::FORBIDDEN
702
    );
703
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
704
    assert_eq!(st, StatusCode::CREATED);
705
    let bob_n = bobs["number"].as_i64().unwrap();
706
707
    // PATCH: the whole label set, assignees and milestone, with events.
708
    let (st, v) =
709
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
710
            .await;
711
    assert_eq!(st, StatusCode::OK, "{v}");
712
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
713
    assert_eq!(v["assignees"], serde_json::json!([]));
714
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
715
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
716
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
717
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
718
    // The author edits their own title; others cannot; nobody but triage sets labels.
719
    let (st, v) =
720
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
721
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
722
    assert_eq!(
723
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
724
        StatusCode::FORBIDDEN
725
    );
726
    assert_eq!(
727
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
728
        StatusCode::FORBIDDEN
729
    );
730
    assert_eq!(
731
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
732
        StatusCode::BAD_REQUEST
733
    );
734
735
    // Deleting a label takes it off the issues.
736
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
737
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
738
    assert_eq!(v["labels"], serde_json::json!([]));
739
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
740
}
9756c67d Andy McCall ↶ 741
742
#[tokio::test(flavor = "multi_thread")]
743
async fn webhook_formats_editing_and_web_issue_events() {
744
    let h = hub().await;
745
    let app = &h.app;
c8684d44 Andy McCall 746
    let andy = call(
747
        app,
748
        "POST",
749
        "/register",
750
        None,
751
        None,
752
        None,
753
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
754
    )
755
    .await
756
    .cookie
757
    .unwrap();
9756c67d Andy McCall ↶ 758
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
759
    let r = call(
760
        app,
761
        "POST",
762
        "/settings/tokens",
763
        None,
764
        Some(&andy),
765
        None,
766
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
767
    )
768
    .await;
769
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
770
    assert_eq!(
771
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
772
        StatusCode::CREATED
773
    );
774
    let rx = receiver().await;
775
    *rx.fail_first.lock().unwrap() = false;
776
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
777
    let csrf = csrf_of(&settings);
778
    let form = |f: String| {
779
        let andy = andy.clone();
c7067c7b Andy McCall 780
        async move {
781
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
782
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
783
        }
9756c67d Andy McCall ↶ 784
    };
785
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
786
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
787
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
c9893553 Andy McCall ↶ 788
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
789
    {
790
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
791
        let before: i64 =
3b1bc27f Andy McCall 792
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 793
        for i in 0..MAX_WAITING {
794
            sqlx::query(
3b1bc27f Andy McCall 795
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
c9893553 Andy McCall ↶ 796
            )
797
            .bind(hook.id)
798
            .bind(format!("flood-{i}"))
799
            .execute(&app.db)
800
            .await
801
            .unwrap();
802
        }
803
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
804
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
805
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
806
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
807
        let after: i64 =
3b1bc27f Andy McCall 808
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 809
        assert_eq!(before, after);
810
    }
9756c67d Andy McCall ↶ 811
    assert_eq!(hook.format, "discord");
812
    // Ping arrives as a Discord message.
813
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
814
    let mut got = String::new();
815
    for _ in 0..100 {
816
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
817
            got = body.clone();
818
        }
819
        if !got.is_empty() {
820
            break;
821
        }
822
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
823
    }
824
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
825
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
826
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
c7067c7b Andy McCall 827
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
9756c67d Andy McCall ↶ 828
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
829
830
    // Editing: a blank URL and secret keep theirs; format, events and active change.
831
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
832
        .await
833
        .contains("Webhook saved"));
834
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
835
    assert_eq!(
836
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
837
        (rx.url.as_str(), "issue", "oxygenhub", true)
838
    );
839
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
840
841
    // An issue opened on the web now reaches the hook, as the signed envelope.
842
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
843
    call(
844
        app,
845
        "POST",
846
        "/andy/demo/issues/new",
847
        None,
848
        Some(&andy),
849
        None,
850
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
851
    )
852
    .await;
853
    let mut envelope = None;
854
    for _ in 0..100 {
855
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
856
        if envelope.is_some() {
857
            break;
858
        }
859
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
860
    }
861
    let (_, sig, body) = envelope.expect("issue.opened delivered");
862
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
863
    assert_eq!(v["data"]["issue"]["title"], "From the web");
864
    assert!(sig.starts_with("blake3-keyed="));
865
    // A disabled hook through the edit form (no active box).
866
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
867
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
868
}
ef20fdc1 Andy McCall ↶ 869
870
#[tokio::test(flavor = "multi_thread")]
871
async fn api_projects() {
872
    let h = hub().await;
873
    let app = &h.app;
c8684d44 Andy McCall 874
    let andy = call(
875
        app,
876
        "POST",
877
        "/register",
878
        None,
879
        None,
880
        None,
881
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
882
    )
883
    .await
884
    .cookie
885
    .unwrap();
886
    let bob = call(
887
        app,
888
        "POST",
889
        "/register",
890
        None,
891
        None,
892
        None,
893
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
894
    )
895
    .await
896
    .cookie
897
    .unwrap();
ef20fdc1 Andy McCall ↶ 898
    let mint = |cookie: String, scopes: &'static str| {
899
        let app = app.clone();
900
        async move {
901
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
902
            let csrf = csrf_of(&page.body);
903
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
904
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
905
        }
906
    };
907
    let a = mint(andy, "scopes=repo%3Aadmin").await;
908
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
909
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
910
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
911
912
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
913
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
914
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
915
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
916
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
917
918
    // Cards by reference, into a column by name, and a note into the first column.
919
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
920
    assert_eq!(st, StatusCode::CREATED, "{card}");
921
    assert_eq!(
922
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
923
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
924
    );
925
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
926
    assert_eq!(st, StatusCode::BAD_REQUEST);
927
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
efb51b39 Andy McCall ↶ 928
    // The form the board shows its cards in is taken too (#118); another owner's is refused.
929
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"andy/demo#1"}"#)).await;
930
    assert!(v["detail"].as_str().unwrap().contains("already on this project"), "{v}");
931
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"other/demo#1"}"#)).await;
932
    assert!(v["detail"].as_str().unwrap().contains("only andy's"), "{v}");
ef20fdc1 Andy McCall ↶ 933
    assert_eq!(
934
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
935
        StatusCode::BAD_REQUEST
936
    );
937
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
938
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
939
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
940
941
    // Move and read the board.
942
    let id = card["id"].as_i64().unwrap();
943
    assert_eq!(
944
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
945
        StatusCode::NO_CONTENT
946
    );
947
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
948
    let names: Vec<(&str, usize)> =
949
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
950
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
951
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
17a3a84b Andy McCall ↶ 952
    // The cards by column (#115), and a wrong method answers with a body.
953
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
954
    assert_eq!(st, StatusCode::OK);
955
    assert_eq!(cols, board["columns"]);
956
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
957
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
958
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
ef20fdc1 Andy McCall ↶ 959
960
    // Private: hidden from others; closed: read-only; then remove a card.
961
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
962
    assert_eq!(edited["public"], false);
963
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
964
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
965
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
966
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
967
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
968
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
969
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
970
}
961c10be Andy McCall ↶ 971
972
#[tokio::test(flavor = "multi_thread")]
973
async fn api_required_checks() {
974
    let h = hub().await;
975
    let app = &h.app;
c8684d44 Andy McCall 976
    let andy = call(
977
        app,
978
        "POST",
979
        "/register",
980
        None,
981
        None,
982
        None,
983
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
984
    )
985
    .await
986
    .cookie
987
    .unwrap();
961c10be Andy McCall ↶ 988
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
989
    let csrf = csrf_of(&page.body);
990
    let mint = |scopes: &'static str| {
991
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
992
        async move {
993
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
994
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
995
        }
996
    };
997
    let admin = mint("scopes=repo%3Aadmin").await;
998
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
999
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1000
1001
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1002
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1003
    let (st, v) = api(
1004
        app,
1005
        "PUT",
1006
        "/api/v1/repos/andy/demo/checks/required",
1007
        Some(&admin),
1008
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1009
    )
1010
    .await;
1011
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1012
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1013
    assert_eq!(
1014
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1015
        serde_json::json!(["flow/fmt", "flow/test"])
1016
    );
1017
    assert_eq!(
1018
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1019
        StatusCode::FORBIDDEN,
1020
        "repo:admin only"
1021
    );
1022
    assert_eq!(
1023
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1024
        StatusCode::BAD_REQUEST
1025
    );
1026
    // The settings page shows the same list.
c7067c7b Andy McCall 1027
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
961c10be Andy McCall ↶ 1028
}
9008bf6c Andy McCall ↶ 1029
1030
/// OxygenFlow per repository: site administrators turn it on or off in
1031
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1032
#[tokio::test(flavor = "multi_thread")]
1033
async fn flow_is_switched_per_repository_by_site_admins() {
1034
    let h = hub().await;
1035
    let app = &h.app;
c8684d44 Andy McCall 1036
    let andy = call(
1037
        app,
1038
        "POST",
1039
        "/register",
1040
        None,
1041
        None,
1042
        None,
1043
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1044
    )
1045
    .await
1046
    .cookie
1047
    .unwrap();
9008bf6c Andy McCall ↶ 1048
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1049
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1050
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1051
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1052
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
c7067c7b Andy McCall 1053
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
9008bf6c Andy McCall ↶ 1054
1055
    let set = |value: &'static str| {
1056
        let (app, andy) = (app.clone(), andy.clone());
1057
        async move {
c7067c7b Andy McCall 1058
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1059
            let r = call(
9008bf6c Andy McCall ↶ 1060
                &app,
1061
                "POST",
1062
                "/andy/demo/settings/flow",
1063
                None,
1064
                Some(&andy),
1065
                None,
1066
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1067
            )
c7067c7b Andy McCall 1068
            .await;
1069
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
9008bf6c Andy McCall ↶ 1070
        }
1071
    };
1072
    // A repository admin who is not a site admin sees the state but cannot change it.
1073
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1074
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
c7067c7b Andy McCall 1075
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
9008bf6c Andy McCall ↶ 1076
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1077
    let r = set("on").await;
1078
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1079
    assert_eq!(row().await.flow, "");
1080
1081
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1082
    let r = set("on").await;
1083
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1084
    assert_eq!(row().await.flow, "on");
1085
    assert!(oxygenhub::flow::enabled(app, &row().await));
1086
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1087
    set("off").await;
1088
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1089
    set("default").await;
1090
    assert_eq!(row().await.flow, "");
1870e4fa Andy McCall ↶ 1091
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
9008bf6c Andy McCall ↶ 1092
}
e271a37b Andy McCall ↶ 1093
1094
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1095
/// button, never the repository's default bookmark as the hub sets it.
1096
#[tokio::test(flavor = "multi_thread")]
1097
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1098
    let h = hub().await;
1099
    let app = &h.app;
c8684d44 Andy McCall 1100
    let andy = call(
1101
        app,
1102
        "POST",
1103
        "/register",
1104
        None,
1105
        None,
1106
        None,
1107
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1108
    )
1109
    .await
1110
    .cookie
1111
    .unwrap();
e271a37b Andy McCall ↶ 1112
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1113
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1114
    let url = format!("{}/andy/demo", h.base);
1115
    let work = tempfile::tempdir().unwrap();
1116
    let (w, u) = (work.path().to_path_buf(), url.clone());
1117
    let client = tokio::task::spawn_blocking(move || {
1118
        let mut c = Repo::init(&w).unwrap();
1119
        c.config.set("remote.origin.url", &u).unwrap();
1120
        c.config.set("remote.origin.token", "site").unwrap();
1121
        c.save_config().unwrap();
1122
        write(&w, "a.txt", b"a\n");
1123
        c.commit("a", &[]).unwrap();
1124
        assert!(c.push("origin", false).unwrap()[0].ok);
1125
        for b in ["develop", "feature/x", "stray"] {
1126
            c.bookmark_create(b, None).unwrap();
1127
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1128
        }
1129
        // A pushed deletion.
1130
        let r = c.push_delete("origin", "feature/x").unwrap();
1131
        assert!(r[0].ok, "{r:?}");
1132
        c
1133
    })
1134
    .await
1135
    .unwrap();
1136
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1137
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1138
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1139
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1140
    assert!(!anon.body.contains("/bookmarks/delete"));
1141
1142
    // The hub's default, not the repository's config, is protected: make
1143
    // develop the default, then main can go and develop cannot.
1144
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1145
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1146
    let client = tokio::task::spawn_blocking(move || {
1147
        let r = client.push_delete("origin", "develop").unwrap();
1148
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1149
        let r = client.push_delete("origin", "main").unwrap();
1150
        assert!(r[0].ok, "{r:?}");
1151
        client
1152
    })
1153
    .await
1154
    .unwrap();
1155
    drop(client);
1156
1157
    // On the web: a writer deletes stray; the default is refused.
1158
    let form = |b: &'static str| {
1159
        let (app, andy) = (app.clone(), andy.clone());
1160
        async move {
1161
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1162
            call(
1163
                &app,
1164
                "POST",
1165
                "/andy/demo/bookmarks/delete",
1166
                None,
1167
                Some(&andy),
1168
                None,
1169
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1170
            )
1171
            .await
1172
        }
1173
    };
1174
    let r = form("stray").await;
1175
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1176
    assert!(!r.body.contains(">stray<"));
1177
    let r = form("develop").await;
1178
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1179
    let r = form("nope").await;
1180
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1181
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1182
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1183
    // Anonymous visitors cannot.
1184
    assert_ne!(
1185
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1186
        StatusCode::OK
1187
    );
1188
}
760a7dd3 Andy McCall ↶ 1189
1190
/// A change signed by a key no account has linked says so, on its page
1191
/// and in the API (feedback 14).
1192
#[tokio::test(flavor = "multi_thread")]
1193
async fn changes_signed_by_unlinked_keys_say_so() {
1194
    let h = hub().await;
1195
    let app = &h.app;
c8684d44 Andy McCall 1196
    let andy = call(
1197
        app,
1198
        "POST",
1199
        "/register",
1200
        None,
1201
        None,
1202
        None,
1203
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1204
    )
1205
    .await
1206
    .cookie
1207
    .unwrap();
760a7dd3 Andy McCall ↶ 1208
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1209
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1210
    let url = format!("{}/andy/demo", h.base);
1211
    let work = tempfile::tempdir().unwrap();
1212
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1213
    let hash = tokio::task::spawn_blocking(move || {
1214
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1215
        c.config.set("remote.origin.url", &u).unwrap();
1216
        c.config.set("remote.origin.token", "site").unwrap();
1217
        c.save_config().unwrap();
1218
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1219
        write(&w.join("r"), "a.txt", b"a\n");
1220
        let h = c.commit("signed by Ada", &[]).unwrap();
1221
        assert!(c.push("origin", false).unwrap()[0].ok);
1222
        h.to_hex()
1223
    })
1224
    .await
1225
    .unwrap();
1226
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1227
    assert_eq!(st, StatusCode::OK, "{v}");
1228
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1229
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1230
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1231
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1232
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1233
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1234
}
65be9f9c Andy McCall ↶ 1235
1236
/// Function history (hub spec §6.6): the file page lists a file's
1237
/// functions, and a function's page lists exactly the changes to its lines.
1238
#[tokio::test(flavor = "multi_thread")]
1239
async fn a_function_has_its_own_history() {
1240
    let h = hub().await;
1241
    let app = &h.app;
c8684d44 Andy McCall 1242
    let andy = call(
1243
        app,
1244
        "POST",
1245
        "/register",
1246
        None,
1247
        None,
1248
        None,
1249
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1250
    )
1251
    .await
1252
    .cookie
1253
    .unwrap();
65be9f9c Andy McCall ↶ 1254
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1255
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1256
    let url = format!("{}/andy/demo", h.base);
1257
    let work = tempfile::tempdir().unwrap();
1258
    let w = work.path().to_path_buf();
1259
    tokio::task::spawn_blocking(move || {
1260
        let mut c = Repo::init(&w).unwrap();
1261
        c.config.set("remote.origin.url", &url).unwrap();
1262
        c.config.set("remote.origin.token", "site").unwrap();
1263
        c.save_config().unwrap();
1264
        let steps = [
1265
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1266
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1267
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1268
        ];
1269
        for (msg, text) in steps {
1270
            write(&w, "src/lib.rs", text.as_bytes());
1271
            c.commit(msg, &[]).unwrap();
1272
        }
1273
        assert!(c.push("origin", false).unwrap()[0].ok);
1274
    })
1275
    .await
1276
    .unwrap();
1277
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1278
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1279
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1280
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1281
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1282
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1283
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1284
    assert_ne!(bad.status, StatusCode::OK);
1285
}
92574625 Andy McCall ↶ 1286
1287
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1288
/// dependency edges, linked cards.
1289
#[tokio::test(flavor = "multi_thread")]
1290
async fn a_bookmark_shows_as_swimlanes() {
1291
    let h = hub().await;
1292
    let app = &h.app;
c8684d44 Andy McCall 1293
    let andy = call(
1294
        app,
1295
        "POST",
1296
        "/register",
1297
        None,
1298
        None,
1299
        None,
1300
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1301
    )
1302
    .await
1303
    .cookie
1304
    .unwrap();
92574625 Andy McCall ↶ 1305
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1306
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1307
    let url = format!("{}/andy/demo", h.base);
1308
    let work = tempfile::tempdir().unwrap();
1309
    let w = work.path().to_path_buf();
1310
    tokio::task::spawn_blocking(move || {
1311
        let mut c = Repo::init(&w).unwrap();
1312
        c.config.set("remote.origin.url", &url).unwrap();
1313
        c.config.set("remote.origin.token", "site").unwrap();
1314
        c.save_config().unwrap();
1315
        // Two files edited independently: two lanes.
1316
        write(&w, "a.txt", b"a\n");
1317
        c.commit("add a", &[]).unwrap();
1318
        write(&w, "b.txt", b"b\n");
1319
        c.commit("add b", &[]).unwrap();
1320
        write(&w, "a.txt", b"a\na2\n");
1321
        c.commit("grow a", &[]).unwrap();
1322
        assert!(c.push("origin", false).unwrap()[0].ok);
1323
    })
1324
    .await
1325
    .unwrap();
1326
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1327
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1328
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1329
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1330
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1331
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1332
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1333
    assert_eq!(board.matches("<rect ").count(), 3);
1334
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1335
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1336
}
2bfe5ef6 Andy McCall ↶ 1337
1338
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1339
/// offers only what makes sense and rewrites nothing itself.
1340
#[tokio::test(flavor = "multi_thread")]
1341
async fn a_proposal_board_plans_squashes_and_rebases() {
1342
    let h = hub().await;
1343
    let app = &h.app;
c8684d44 Andy McCall 1344
    let andy = call(
1345
        app,
1346
        "POST",
1347
        "/register",
1348
        None,
1349
        None,
1350
        None,
1351
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1352
    )
1353
    .await
1354
    .cookie
1355
    .unwrap();
2bfe5ef6 Andy McCall ↶ 1356
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1357
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1358
    let url = format!("{}/andy/demo", h.base);
1359
    let work = tempfile::tempdir().unwrap();
1360
    let w = work.path().to_path_buf();
1361
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1362
        let mut c = Repo::init(&w).unwrap();
1363
        c.config.set("remote.origin.url", &url).unwrap();
1364
        c.config.set("remote.origin.token", "site").unwrap();
1365
        c.save_config().unwrap();
1366
        write(&w, "a.txt", b"a\n");
1367
        let base = c.commit("base", &[]).unwrap();
1368
        assert!(c.push("origin", false).unwrap()[0].ok);
1369
        c.bookmark_create("feature", None).unwrap();
1370
        c.bookmark_switch("feature", false).unwrap();
1371
        write(&w, "a.txt", b"a\nfirst\n");
1372
        let first = c.commit("first", &[]).unwrap();
1373
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1374
        let second = c.commit("second", &[]).unwrap();
1375
        write(&w, "b.txt", b"apart\n");
1376
        let apart = c.commit("apart", &[]).unwrap();
1377
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1378
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1379
    })
1380
    .await
1381
    .unwrap();
1382
    // No proposal yet: the board is read-only.
1383
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1384
    assert!(!board.contains("data-plan="));
1385
    let (st, _) = api(
1386
        app,
1387
        "POST",
1388
        "/api/v1/repos/andy/demo/proposals",
1389
        Some("site"),
1390
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1391
    )
1392
    .await;
1393
    assert!(st.is_success(), "{st}");
1394
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1395
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1396
    let csrf = csrf_of(&board);
1397
    let plan = |c: &str, t: &str| {
1398
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1399
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1400
        async move {
1401
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1402
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1403
        }
1404
    };
1405
    let kinds = |v: &serde_json::Value| {
1406
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1407
    };
1408
    // second already depends on first: squash, no rebase.
1409
    let v = plan(&second, &first).await;
1410
    assert_eq!(kinds(&v), ["squash"], "{v}");
1411
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
c96b3286 Andy McCall ↶ 1412
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
2bfe5ef6 Andy McCall ↶ 1413
    // apart is independent of second: either.
1414
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1415
    // first under second: nothing (second depends on first).
1416
    assert!(plan(&first, &second).await["error"].is_string());
1417
    // What has landed on main is not rearranged.
1418
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1419
}
38833ed7 Andy McCall ↶ 1420
1421
/// Issues and proposals share a number space, so every number says what it
1422
/// is, and the chain of work shows from both ends (hub spec §8).
1423
#[tokio::test(flavor = "multi_thread")]
1424
async fn proposals_and_issues_show_their_chain() {
1425
    let h = hub().await;
1426
    let app = &h.app;
c8684d44 Andy McCall 1427
    let andy = call(
1428
        app,
1429
        "POST",
1430
        "/register",
1431
        None,
1432
        None,
1433
        None,
1434
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1435
    )
1436
    .await
1437
    .cookie
1438
    .unwrap();
38833ed7 Andy McCall ↶ 1439
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1440
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1441
    let url = format!("{}/andy/demo", h.base);
1442
    let work = tempfile::tempdir().unwrap();
1443
    let w = work.path().to_path_buf();
1444
    tokio::task::spawn_blocking(move || {
1445
        let mut c = Repo::init(&w).unwrap();
1446
        c.config.set("remote.origin.url", &url).unwrap();
1447
        c.config.set("remote.origin.token", "site").unwrap();
1448
        c.save_config().unwrap();
1449
        write(&w, "a.txt", b"a\n");
1450
        c.commit("base", &[]).unwrap();
1451
        assert!(c.push("origin", false).unwrap()[0].ok);
1452
        c.bookmark_create("feature", None).unwrap();
1453
        c.bookmark_switch("feature", false).unwrap();
1454
        write(&w, "a.txt", b"a\nfixed\n");
1455
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1456
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1457
    })
1458
    .await
1459
    .unwrap();
1460
    for title in ["Slow start", "Crash on save"] {
1461
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1462
        assert!(st.is_success());
1463
    }
1464
    let (st, v) = api(
1465
        app,
1466
        "POST",
1467
        "/api/v1/repos/andy/demo/proposals",
1468
        Some("site"),
1469
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1470
    )
1471
    .await;
1472
    assert!(st.is_success(), "{st} {v}");
1473
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1474
1475
    // The proposal names its kind, links its references by kind, and shows
1476
    // the chain: the issues it closes (description and changes) → it → main.
1477
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1478
    assert!(p.contains(">proposal #3</small>"), "header");
1479
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1480
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1481
    let chain = &chain[..chain.find("</p>").unwrap()];
1482
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1483
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1484
    }
1485
    assert!(p.contains("<h3>Closes</h3>"));
1486
1487
    // The issue shows the proposal that closes it, and names its own kind.
1488
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1489
    assert!(i.contains(">issue #1</small>"));
1490
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1491
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
a1b98695 Andy McCall ↶ 1492
    // The conversation is a timeline with avatars; editing sits with the
1493
    // content, not in the sidebar, and labels and projects are editable.
1494
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1495
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1496
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1497
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1498
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1499
    assert!(st.is_success(), "{st}");
1500
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
9e50caed Andy McCall ↶ 1501
    assert!(
1502
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1503
        "the owner's projects to add to, in a menu"
1504
    );
a1b98695 Andy McCall ↶ 1505
    let csrf = csrf_of(&p);
1506
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1507
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1508
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1509
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1510
        .await;
1511
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1512
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1513
38833ed7 Andy McCall ↶ 1514
    // Closed by the proposal's change, not its description: still shown.
1515
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1516
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1517
    assert!(chain.contains("proposal #3"), "{chain}");
1518
}
e9bfea8e Andy McCall ↶ 1519
1520
/// What the hub is: its version and build, and the libraries it is built on,
1521
/// on /about, in the API and in /health (hub spec §15).
1522
#[tokio::test(flavor = "multi_thread")]
1523
async fn the_hub_says_what_version_it_is() {
1524
    let h = hub().await;
1525
    let app = &h.app;
1526
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1527
    assert_eq!(st, StatusCode::OK);
1528
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1529
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1530
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1531
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1532
    assert!(health.contains("\"build\""), "{health}");
b2107275 Andy McCall ↶ 1533
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1534
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
e9bfea8e Andy McCall ↶ 1535
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1536
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1537
    assert!(about.contains("href=\"/about\""), "the footer links here");
1538
}
df71c789 Andy McCall ↶ 1539
1540
#[tokio::test(flavor = "multi_thread")]
1541
async fn device_sign_in() {
1542
    let h = hub().await;
1543
    let app = &h.app;
c8684d44 Andy McCall 1544
    let r = call(
1545
        app,
1546
        "POST",
1547
        "/register",
1548
        None,
1549
        None,
1550
        None,
1551
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1552
    )
1553
    .await;
df71c789 Andy McCall ↶ 1554
    let andy = r.cookie.unwrap();
1555
1556
    // An unknown scope is refused.
1557
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1558
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1559
1560
    // The app asks for a code and polls; nobody has approved it yet.
1561
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1562
    assert_eq!(st, StatusCode::OK, "{v}");
1563
    let device = v["device_code"].as_str().unwrap().to_string();
1564
    let user = v["user_code"].as_str().unwrap().to_string();
1565
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1566
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1567
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1568
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1569
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1570
    assert_eq!(v["error"], "slow_down", "polled too soon");
1571
1572
    // The user approves it on the web, allowing less than it asked for.
1573
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1574
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1575
    let csrf = csrf_of(&page.body);
1576
    let r =
1577
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1578
            .await;
4da8b828 Andy McCall ↶ 1579
    // oxygenhub#83: the answer page says it is done, with no code form.
1580
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1581
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
df71c789 Andy McCall ↶ 1582
1583
    // The next poll gets a token with what was allowed, once.
1584
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1585
    assert_eq!(st, StatusCode::OK, "{v}");
1586
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1587
    let token = v["access_token"].as_str().unwrap().to_string();
1588
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1589
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1590
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1591
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1592
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1593
    assert!(tokens.body.contains("device: Phone app"));
60f11b71 Andy McCall ↶ 1594
    // oxygenhub#70: a device's token expires, and each use renews it.
1595
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
df71c789 Andy McCall ↶ 1596
60f11b71 Andy McCall ↶ 1597
    // The token can revoke itself (oxy auth logout), and is then refused.
1598
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1599
    assert_eq!(st, StatusCode::NO_CONTENT);
1600
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1601
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1602
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1603
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1604
df71c789 Andy McCall ↶ 1605
    // A denied code says so.
1606
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1607
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1608
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1609
    let csrf = csrf_of(&page.body);
1610
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1611
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1612
    assert_eq!(v["error"], "access_denied");
1613
1614
    // Signed out, the page asks for a sign-in first.
1615
    let r = call(app, "GET", "/device", None, None, None, None).await;
1616
    assert!(r.status.is_redirection(), "{}", r.status);
1617
}
62ceb2ee Andy McCall ↶ 1618
1619
#[tokio::test(flavor = "multi_thread")]
1620
async fn api_assistants_at_each_level() {
1621
    let h = hub().await;
1622
    let app = &h.app;
c8684d44 Andy McCall 1623
    let andy = call(
1624
        app,
1625
        "POST",
1626
        "/register",
1627
        None,
1628
        None,
1629
        None,
1630
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1631
    )
1632
    .await
1633
    .cookie
1634
    .unwrap();
62ceb2ee Andy McCall ↶ 1635
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1636
    let csrf = csrf_of(&page.body);
1637
    let mint = |scopes: &'static str| {
1638
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1639
        async move {
1640
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1641
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1642
        }
1643
    };
1644
    let admin = mint("scopes=repo%3Aadmin").await;
1645
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1646
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1647
    // A stand-in endpoint with no model list: any model name is taken.
1648
    let router = axum::Router::new().route(
1649
        "/v1/chat/completions",
1650
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1651
    );
1652
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1653
    let port = listener.local_addr().unwrap().port();
1654
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1655
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1656
1657
    // The site's, by its administrator; the repository's, by its admin.
1658
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1659
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1660
    assert_eq!(st, StatusCode::OK, "{v}");
1661
    assert_eq!(v["ok"], "Gemini added");
1662
    let body =
1663
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1664
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1665
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1666
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1667
    assert_eq!(st, StatusCode::OK, "{v}");
1668
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1669
    assert_eq!(st, StatusCode::OK);
1670
    let names: Vec<(&str, &str, bool)> = v
1671
        .as_array()
1672
        .unwrap()
1673
        .iter()
1674
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1675
        .collect();
1676
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1677
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1678
    // Changing it keeps the token when none is given.
1679
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1680
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1681
    assert_eq!(v["ok"], "Claude updated");
1682
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1683
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1684
    // Prompts: the site's is inherited by the repository.
1685
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1686
    assert_eq!(st, StatusCode::OK);
1687
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1688
    assert_eq!(v["prompt"], "Rust.");
1689
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1690
    // Removed.
1691
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1692
    assert_eq!(st, StatusCode::NO_CONTENT);
1693
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1694
    assert_eq!(st, StatusCode::NOT_FOUND);
1695
}