OXYGENHUB
◆ v0.8.0 oxygenhub / crates / hub / tests / api.rs
89.9 KiB · Rust · last changed The API for apps: own repositories, organisations, 401, device cancel, richer notifications (closes #302, closes #303, closes #304, closes #305) 11 days ago source blame history raw
b64e2537 Andy McCall ↶ 1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use std::sync::{Arc, Mutex};
15
use tower::ServiceExt;
16
17
fn hermetic() {
18
    static ONCE: std::sync::Once = std::sync::Once::new();
19
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
20
    ONCE.call_once(|| {
21
        let d = tempfile::tempdir().unwrap();
22
        std::env::set_var("OXY_HOME", d.path());
23
        DIR.set(d).ok();
24
    });
25
}
26
27
fn write(root: &Path, rel: &str, content: &[u8]) {
28
    let p = root.join(rel);
29
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
30
    std::fs::write(p, content).unwrap();
31
}
32
33
struct Hub {
34
    app: Shared,
35
    base: String,
36
    _dir: tempfile::TempDir,
37
}
38
39
async fn hub() -> Hub {
40
    hermetic();
41
    let dir = tempfile::tempdir().unwrap();
42
    let mut config = Config::load(dir.path()).unwrap();
c8684d44 Andy McCall 43
    // The first account's setup code (oxygenhub#245).
44
    config.registration.setup_code = "test-setup".into();
b64e2537 Andy McCall ↶ 45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
9a777fec Andy McCall ↶ 50
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
51
    config.outbound.allow = vec!["http://127.0.0.1".into()];
b64e2537 Andy McCall ↶ 52
    let app = oxygenhub::build(config).await.unwrap();
53
    let router = oxygenhub::router(app.clone());
54
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
55
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
56
}
57
58
struct Res {
59
    status: StatusCode,
60
    body: String,
61
    cookie: Option<String>,
c7067c7b Andy McCall 62
    location: Option<String>,
b64e2537 Andy McCall ↶ 63
}
64
65
async fn call(
66
    app: &Shared,
67
    method: &str,
68
    path: &str,
69
    bearer: Option<&str>,
70
    cookie: Option<&str>,
71
    json: Option<&str>,
72
    form: Option<&str>,
73
) -> Res {
74
    let mut req = Request::builder().method(method).uri(path);
75
    if let Some(b) = bearer {
76
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
77
    }
78
    if let Some(c) = cookie {
79
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
80
    }
81
    let body = if let Some(j) = json {
82
        req = req.header(header::CONTENT_TYPE, "application/json");
83
        Body::from(j.to_string())
84
    } else if let Some(f) = form {
85
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
86
        Body::from(f.to_string())
87
    } else {
88
        Body::empty()
89
    };
90
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
91
    let status = res.status();
92
    let cookie = res
93
        .headers()
94
        .get(header::SET_COOKIE)
95
        .and_then(|v| v.to_str().ok())
96
        .and_then(|v| v.split(';').next())
97
        .and_then(|kv| kv.split_once('='))
98
        .map(|(_, v)| v.to_string());
c7067c7b Andy McCall 99
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
b64e2537 Andy McCall ↶ 100
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
c7067c7b Andy McCall 101
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
b64e2537 Andy McCall ↶ 102
}
103
c7067c7b Andy McCall 104
/// A repository settings form's answer (#278): a redirect to the page that
105
/// holds the form, followed.
106
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
107
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
108
    let to = r.location.expect("a redirect");
109
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
110
    call(app, "GET", &to, None, cookie, None, None).await
111
}
112
b64e2537 Andy McCall ↶ 113
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
114
    let r = call(app, method, path, bearer, None, json, None).await;
115
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
116
    (r.status, v)
117
}
118
119
fn csrf_of(page: &str) -> String {
120
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
121
    page[i..].split('"').next().unwrap().to_string()
122
}
123
124
/// A webhook receiver that records what it gets and fails the first time.
125
struct Receiver {
126
    url: String,
127
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
128
    fail_first: Arc<Mutex<bool>>,
129
}
130
131
async fn receiver() -> Receiver {
132
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
133
    let fail_first = Arc::new(Mutex::new(true));
134
    let (s2, f2) = (seen.clone(), fail_first.clone());
135
    let router = Router::new().route(
136
        "/hook",
137
        post(move |headers: header::HeaderMap, body: String| {
138
            let (s2, f2) = (s2.clone(), f2.clone());
139
            async move {
140
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
141
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
142
                let mut f = f2.lock().unwrap();
143
                if *f {
144
                    *f = false;
145
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
146
                }
147
                s2.lock().unwrap().push((event, sig, body));
148
                (StatusCode::OK, "ok")
149
            }
150
        }),
151
    );
152
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
153
    let port = listener.local_addr().unwrap().port();
154
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
155
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
156
}
157
158
#[tokio::test(flavor = "multi_thread")]
159
async fn api_webhooks_and_checks() {
160
    let h = hub().await;
161
    let app = &h.app;
162
    // Accounts and tokens through the pages.
c8684d44 Andy McCall 163
    let r = call(
164
        app,
165
        "POST",
166
        "/register",
167
        None,
168
        None,
169
        None,
170
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
171
    )
172
    .await;
b64e2537 Andy McCall ↶ 173
    let andy = r.cookie.unwrap();
c8684d44 Andy McCall 174
    let r = call(
175
        app,
176
        "POST",
177
        "/register",
178
        None,
179
        None,
180
        None,
181
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
182
    )
183
    .await;
b64e2537 Andy McCall ↶ 184
    let bob = r.cookie.unwrap();
185
    let mint = |cookie: String, scopes: &'static str| {
186
        let app = app.clone();
187
        async move {
188
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
189
            let csrf = csrf_of(&page.body);
190
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
191
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
192
        }
193
    };
194
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
195
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
196
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
197
198
    // Create a repository through the API; the read-only token cannot.
199
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
200
    assert_eq!(st, StatusCode::FORBIDDEN);
201
    let (st, v) = api(
202
        app,
203
        "POST",
204
        "/api/v1/repos",
205
        Some(&andy_admin),
206
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
207
    )
208
    .await;
209
    assert_eq!(st, StatusCode::CREATED, "{v}");
210
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
211
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
212
    assert_eq!(st, StatusCode::CONFLICT);
213
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
214
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
215
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
216
    assert_eq!(st, StatusCode::OK);
217
    assert_eq!(v["username"], "andy");
218
219
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
220
    let rx = receiver().await;
221
    let (st, v) = api(
222
        app,
223
        "POST",
224
        "/api/v1/repos/andy/demo/hooks",
225
        Some(&andy_admin),
226
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
227
    )
228
    .await;
229
    assert_eq!(st, StatusCode::CREATED, "{v}");
230
    let work = tempfile::tempdir().unwrap();
231
    let mut client = Repo::init(work.path()).unwrap();
232
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
233
    client.config.set("remote.origin.token", "site").unwrap();
234
    client.save_config().unwrap();
235
    write(work.path(), "a.txt", b"a\n");
236
    client.snapshot("t").unwrap();
237
    let base = client.commit("base", &[]).unwrap();
238
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
239
    // The worker retries with backoff; drive it directly for the retry.
240
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
241
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
242
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
243
    oxygenhub::hooks::deliver_due(app).await;
244
    let seen = rx.seen.lock().unwrap().clone();
245
    assert_eq!(seen.len(), 1, "{seen:?}");
246
    assert_eq!(seen[0].0, "push");
247
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
248
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
249
    assert_eq!(payload["repository"]["name"], "demo");
250
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
252
    assert_eq!(v.as_array().unwrap().len(), 1);
253
254
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
255
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
256
    assert_eq!(st, StatusCode::OK);
257
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
f28389bd Andy McCall ↶ 258
    // A revset in place of the whole history (`?r=`), under a budget; a
259
    // bad one is the caller's problem.
260
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
261
    assert_eq!(st, StatusCode::OK, "{v}");
262
    assert_eq!(v["total"].as_u64(), Some(1));
263
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
264
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
265
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
266
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
267
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
b64e2537 Andy McCall ↶ 268
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
269
    assert_eq!(v[0]["name"], "a.txt");
270
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
271
    assert_eq!(r.body, "a\n");
272
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
273
    assert_eq!(v[0]["change"], base.to_hex());
274
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
275
    assert_eq!(v["files"][0]["path"], "a.txt");
276
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
277
    assert!(v["policy"].is_null());
278
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
279
    assert_eq!(v[0]["reference"], "main");
280
281
    // Issues through the API: Bob opens one, comments, and closes it.
282
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
283
    assert_eq!(st, StatusCode::CREATED, "{v}");
284
    assert_eq!(v["number"], 1);
285
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
286
    assert_eq!(st, StatusCode::CREATED);
287
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
288
    assert_eq!(st, StatusCode::OK, "{v}");
289
    assert_eq!(v["state"], "closed");
290
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
291
    assert_eq!(v[0]["comments"], 1);
292
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
293
    assert_eq!(v[0]["number"], 1);
294
295
    // A proposal through the API, then a required check gates its landing.
296
    client.bookmark_create("feat", Some(&[base])).unwrap();
297
    client.bookmark_switch("feat", false).unwrap();
298
    write(work.path(), "b.txt", b"b\n");
3f02e5ea Andy McCall ↶ 299
    write(work.path(), "a.txt", b"a\nA\n");
b64e2537 Andy McCall ↶ 300
    client.snapshot("t").unwrap();
301
    let feat = client.commit("feat", &[]).unwrap();
302
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
303
    let (st, v) =
304
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
305
            .await;
306
    assert_eq!(st, StatusCode::CREATED, "{v}");
307
    assert_eq!(v["number"], 2);
308
    let state = v["projected_state"].as_str().unwrap().to_string();
309
    assert_eq!(v["landable"], true);
a0dd06b0 Andy McCall ↶ 310
    // A wiki takes no proposals, and says so rather than "no such
311
    // repository" (oxygenhub#128); a repository's that does not exist
312
    // still does not.
313
    let (st, v) =
314
        api(app, "POST", "/api/v1/repos/andy/demo.wiki/proposals", Some(&bob_rw), Some(r#"{"title":"W","target":"main","source":"p"}"#))
315
            .await;
316
    let detail = v["detail"].as_str().unwrap_or_default();
317
    assert!(st == StatusCode::NOT_FOUND && detail.contains("is the wiki of andy/demo") && detail.contains("push main"), "{v}");
318
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/nope.wiki/proposals", Some(&bob_rw), None).await;
319
    assert_eq!(v["detail"], "no such repository");
3f02e5ea Andy McCall ↶ 320
    // Its files, and each side's bytes, for editors' diff views.
321
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
322
    assert_eq!(st, StatusCode::OK, "{v}");
323
    let files: Vec<(String, String)> =
324
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
325
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
326
    assert_eq!(v[0]["added"], 1);
327
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
328
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
329
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
330
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
331
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
332
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
c0fac31d Andy McCall ↶ 333
    // An anchored comment comes back with its line in the projected state.
334
    let (st, v) = api(
335
        app,
336
        "POST",
337
        "/api/v1/repos/andy/demo/proposals/2/comments",
338
        Some(&bob_rw),
339
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
340
    )
341
    .await;
342
    assert_eq!(st, StatusCode::CREATED, "{v}");
343
    assert_eq!(v["line"], 2);
344
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
345
    assert_eq!(v[0]["path"], "a.txt");
346
    assert_eq!(v[0]["line"], 2, "{v}");
347
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
b64e2537 Andy McCall ↶ 348
    // Require the "build" check.
349
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
350
    let csrf = csrf_of(&settings.body);
c7067c7b Andy McCall 351
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
352
        .await;
353
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
b64e2537 Andy McCall ↶ 354
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
355
    assert_eq!(v["landable"], false);
356
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
357
    // A checker reports on the projected state: first running, then passed; the page streams it.
358
    let (st, v) = api(
359
        app,
360
        "POST",
361
        "/api/v1/repos/andy/demo/checks",
362
        Some(&andy_ro),
363
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
364
    )
365
    .await;
366
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
33d98147 Andy McCall 367
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
b64e2537 Andy McCall ↶ 368
    let (st, v) = api(
369
        app,
370
        "POST",
371
        "/api/v1/repos/andy/demo/checks",
372
        Some(&bob_rw),
373
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
374
    )
375
    .await;
376
    assert_eq!(st, StatusCode::CREATED, "{v}");
33d98147 Andy McCall 377
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
b64e2537 Andy McCall ↶ 378
    assert_eq!(ev.kind, "check");
379
    assert_eq!(ev.check.unwrap().name, "build");
380
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
381
    assert_eq!(v[0]["status"], "passed");
382
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
383
    assert_eq!(v["landable"], true, "{v}");
384
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
385
    assert!(page.body.contains("42 tests"), "{}", page.body);
a2ef53c5 Andy McCall ↶ 386
    // A summary carrying whole hashes shows them by their ends, so the
387
    // Checks panel keeps its width (a pin mismatch's message, 2026-10-16).
388
    let (a, b) = (
389
        "6ea27b1d35037a4e4d0f6208b1ca99630df40888bd21fd55c8f8aba51dcdd7cb",
390
        "f7495d7689da3ac5b68684f26fce28b91ce55e6b8131c5e484ad2aab90c3020f",
391
    );
392
    let summary = format!("could not run: flow-init has BLAKE3 {a}, but {b} is pinned");
393
    let body = serde_json::json!({ "state": state, "name": "lint", "status": "failed", "summary": summary }).to_string();
394
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/checks", Some(&bob_rw), Some(&body)).await;
395
    assert_eq!(st, StatusCode::CREATED, "{v}");
396
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await.body;
397
    assert!(page.contains("6ea27b1d…1dcdd7cb") && page.contains(&format!("data-full=\"{a}\"")), "{page}");
398
    assert!(!page.contains(&format!("BLAKE3 {a},")), "never the whole hash inline");
399
    // The Checks section refreshes itself; nothing reloads the whole page.
400
    assert!(!page.contains("location.reload()"), "no full reload on a check");
401
    let part = call(app, "GET", "/andy/demo/proposal/2?fragment=checks", None, Some(&andy), None, None).await.body;
402
    assert!(part.contains("<h3>Checks</h3>") && part.contains("6ea27b1d…1dcdd7cb") && !part.contains("<html"), "{part}");
b64e2537 Andy McCall ↶ 403
    // The check and the proposal reached the webhook too.
404
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
405
    oxygenhub::hooks::deliver_due(app).await;
406
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
407
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
408
    let _ = feat;
409
    let _ = rx.fail_first;
42a0ba4b Andy McCall ↶ 410
411
    // The inbox through the API: count, list, mark one read, mark all read.
412
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
413
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
414
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
eb0c44a9 Andy McCall ↶ 415
    oxygenhub::db::notify::add(
416
        &app.db,
417
        oxygenhub::db::notify::New {
418
            account_id: bob_id,
ecac6e8d Andy McCall ↶ 419
            repo_id: Some(oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id),
eb0c44a9 Andy McCall ↶ 420
            reason: oxygenhub::db::notify::Reason::Participating,
ecac6e8d Andy McCall ↶ 421
            kind: "issue.opened",
eb0c44a9 Andy McCall ↶ 422
            title: "andy/demo#1: Bug",
423
            url: "/andy/demo/issue/1",
424
            actor: "andy",
425
        },
426
    )
427
    .await
428
    .unwrap();
429
    oxygenhub::db::notify::add(
430
        &app.db,
431
        oxygenhub::db::notify::New {
432
            account_id: bob_id,
433
            repo_id: None,
434
            reason: oxygenhub::db::notify::Reason::Participating,
435
            kind: "review",
436
            title: "andy/demo#2: Feat",
437
            url: "/andy/demo/proposal/2",
438
            actor: "andy",
439
        },
440
    )
441
    .await
442
    .unwrap();
42a0ba4b Andy McCall ↶ 443
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
444
    assert_eq!(st, StatusCode::OK, "{v}");
445
    assert_eq!(v["unread"], 2);
446
    assert_eq!(v["items"][0]["read"], false);
447
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
ecac6e8d Andy McCall ↶ 448
    // Its repository, why, its thread and the kind's label (#305).
449
    let bug = v["items"].as_array().unwrap().iter().find(|n| n["title"] == "andy/demo#1: Bug").unwrap();
450
    assert_eq!(
451
        (bug["repository"].as_str(), bug["reason"].as_str(), bug["label"].as_str()),
452
        (Some("andy/demo"), Some("participating"), Some("🐛 New Issue")),
453
        "{bug}"
454
    );
455
    assert_eq!(bug["thread"].as_str(), Some(format!("{}/andy/demo/issue/1", h.base).as_str()));
42a0ba4b Andy McCall ↶ 456
    let first = v["items"][0]["id"].as_i64().unwrap();
457
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
458
    assert_eq!(st, StatusCode::NO_CONTENT);
459
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
460
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
461
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
462
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
463
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
ecac6e8d Andy McCall ↶ 464
    // No token at all is 401, so a client knows to sign in (#303).
465
    assert_eq!(api(app, "GET", "/api/v1/notifications", None, None).await.0, StatusCode::UNAUTHORIZED);
466
    assert_eq!(api(app, "GET", "/api/v1/user", None, None).await.0, StatusCode::UNAUTHORIZED);
0b20f1ec Andy McCall ↶ 467
cc1cd197 Andy McCall ↶ 468
    // Review requests: the author asks andy; andy is told, reviews, and the
469
    // request is answered; the author hears of the review.
470
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
ecac6e8d Andy McCall ↶ 471
    let (st, orgs) = api(app, "GET", "/api/v1/user/orgs", Some(&andy_user), None).await;
472
    assert!(st == StatusCode::OK && orgs.is_array(), "the caller's organisations (#302): {orgs}");
cc1cd197 Andy McCall ↶ 473
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
474
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
475
        .await
476
        .unwrap();
477
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
478
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
479
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
480
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
481
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
482
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
483
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
484
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
485
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
486
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
487
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
488
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
489
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
490
    let (st, _) =
491
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
492
    assert_eq!(st, StatusCode::CREATED);
493
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
494
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
495
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
496
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
497
    // Asking again and withdrawing it.
498
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
499
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
500
    assert_eq!(st, StatusCode::NO_CONTENT);
501
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
502
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
8e96499f Andy McCall ↶ 503
    // oxygenhub#84: the page's menu sets who is asked, all at once.
504
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
505
    assert!(
506
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
507
        "the reviewers menu lists andy"
508
    );
509
    let csrf = csrf_of(&page.body);
510
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
511
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
512
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
513
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
514
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
515
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
516
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
cc1cd197 Andy McCall ↶ 517
0b20f1ec Andy McCall ↶ 518
    // A source bookmark with `/` in its name, as a feature/N-name workflow
519
    // makes them: by name, and as this repository's owner/name:bookmark.
520
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
521
        client.bookmark_create(b, Some(&[base])).unwrap();
522
        client.bookmark_switch(b, false).unwrap();
523
        write(work.path(), file, b"c\n");
524
        client.snapshot("t").unwrap();
525
        client.commit(b, &[]).unwrap();
526
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
527
    }
528
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
529
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
530
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
531
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
532
        let n = v["number"].as_i64().unwrap();
533
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
534
        assert_eq!(page.status, StatusCode::OK);
535
        assert!(page.body.contains("feature/"), "the page names its source");
536
    }
537
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
538
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
539
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
739a763a Andy McCall ↶ 540
541
    // oxygenhub#76: a proposal's title and description are edited through
542
    // the API by its author or a maintainer; what is not given stays.
543
    let edit = |token: &str, number: i64, body: &str| {
544
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
545
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
546
    };
547
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
548
    assert_eq!(st, StatusCode::OK, "{v}");
549
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
550
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
551
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
552
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
553
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
554
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
555
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
556
    let (st, v) = api(
557
        app,
558
        "POST",
559
        "/api/v1/repos/andy/demo/proposals",
560
        Some(&andy_pw),
561
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
562
    )
563
    .await;
564
    assert_eq!(st, StatusCode::CREATED, "{v}");
565
    let n = v["number"].as_i64().unwrap();
566
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
567
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
2291f8cc Andy McCall ↶ 568
569
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
570
    // before anything changes, shown in its JSON.
571
    for l in ["ui", "flow"] {
572
        let body = format!(r#"{{"name":"{l}"}}"#);
573
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
574
    }
575
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
576
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
577
    assert_eq!(st, StatusCode::OK, "{v}");
578
    let names = |v: &serde_json::Value| -> Vec<String> {
579
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
580
    };
581
    assert_eq!(names(&v), ["flow", "ui"]);
582
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
583
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
584
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
585
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
586
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
587
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
588
    assert_eq!(names(&v), ["flow"]);
589
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
b64e2537 Andy McCall ↶ 590
}
76f262e1 Andy McCall ↶ 591
592
#[tokio::test(flavor = "multi_thread")]
593
async fn api_issue_triage_and_labels() {
594
    let h = hub().await;
595
    let app = &h.app;
c8684d44 Andy McCall 596
    let andy = call(
597
        app,
598
        "POST",
599
        "/register",
600
        None,
601
        None,
602
        None,
603
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
604
    )
605
    .await
606
    .cookie
607
    .unwrap();
608
    let bob = call(
609
        app,
610
        "POST",
611
        "/register",
612
        None,
613
        None,
614
        None,
615
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
616
    )
617
    .await
618
    .cookie
619
    .unwrap();
76f262e1 Andy McCall ↶ 620
    let mint = |cookie: String, scopes: &'static str| {
621
        let app = app.clone();
622
        async move {
623
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
624
            let csrf = csrf_of(&page.body);
625
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
626
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
627
        }
628
    };
629
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
630
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
631
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
632
    assert_eq!(st, StatusCode::CREATED);
633
634
    // Labels through the API; bad colours and non-triage callers are refused.
635
    let (st, v) = api(
636
        app,
637
        "POST",
638
        "/api/v1/repos/andy/demo/labels",
639
        Some(&andy_t),
640
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
641
    )
642
    .await;
643
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
644
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
645
    assert_eq!(
646
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
647
        StatusCode::BAD_REQUEST
648
    );
649
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
650
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
651
    assert_eq!(labels.as_array().unwrap().len(), 2);
5ea4872f Andy McCall ↶ 652
    // oxygenhub#91: milestones over the API, for triage.
653
    let (st, m) = api(
654
        app,
655
        "POST",
656
        "/api/v1/repos/andy/demo/milestones",
657
        Some(&andy_t),
658
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
659
    )
660
    .await;
661
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
662
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
663
    assert_eq!(
664
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
665
        StatusCode::BAD_REQUEST
666
    );
667
    assert_eq!(
668
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
669
        StatusCode::FORBIDDEN
670
    );
671
    let (st, m) =
672
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
673
            .await;
674
    assert_eq!(
675
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
676
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
677
        "{m}"
678
    );
679
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
680
    assert_eq!(
681
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
682
        StatusCode::NOT_FOUND,
683
        "renamed"
684
    );
685
    assert_eq!(
686
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
687
        StatusCode::BAD_REQUEST
688
    );
689
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
690
    assert_eq!(list.as_array().unwrap().len(), 1);
76f262e1 Andy McCall ↶ 691
692
    // An issue created with its labels and assignee in one call.
693
    let (st, v) = api(
694
        app,
695
        "POST",
696
        "/api/v1/repos/andy/demo/issues",
697
        Some(&andy_t),
698
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
699
    )
700
    .await;
701
    assert_eq!(st, StatusCode::CREATED, "{v}");
702
    assert_eq!(v["labels"][0]["name"], "bug");
703
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
704
    let n = v["number"].as_i64().unwrap();
705
    // Unknown names are refused before anything is created.
706
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
707
    assert_eq!(st, StatusCode::BAD_REQUEST);
708
    assert!(v["detail"].as_str().unwrap().contains("no label"));
709
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
710
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
711
    // Without triage, labels cannot be set, but a plain issue can be opened.
712
    assert_eq!(
713
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
714
        StatusCode::FORBIDDEN
715
    );
716
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
717
    assert_eq!(st, StatusCode::CREATED);
718
    let bob_n = bobs["number"].as_i64().unwrap();
719
720
    // PATCH: the whole label set, assignees and milestone, with events.
721
    let (st, v) =
722
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
723
            .await;
724
    assert_eq!(st, StatusCode::OK, "{v}");
725
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
726
    assert_eq!(v["assignees"], serde_json::json!([]));
727
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
728
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
729
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
730
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
731
    // The author edits their own title; others cannot; nobody but triage sets labels.
732
    let (st, v) =
733
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
734
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
735
    assert_eq!(
736
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
737
        StatusCode::FORBIDDEN
738
    );
739
    assert_eq!(
740
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
741
        StatusCode::FORBIDDEN
742
    );
743
    assert_eq!(
744
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
745
        StatusCode::BAD_REQUEST
746
    );
747
748
    // Deleting a label takes it off the issues.
749
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
750
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
751
    assert_eq!(v["labels"], serde_json::json!([]));
752
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
753
}
9756c67d Andy McCall ↶ 754
755
#[tokio::test(flavor = "multi_thread")]
756
async fn webhook_formats_editing_and_web_issue_events() {
757
    let h = hub().await;
758
    let app = &h.app;
c8684d44 Andy McCall 759
    let andy = call(
760
        app,
761
        "POST",
762
        "/register",
763
        None,
764
        None,
765
        None,
766
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
767
    )
768
    .await
769
    .cookie
770
    .unwrap();
9756c67d Andy McCall ↶ 771
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
772
    let r = call(
773
        app,
774
        "POST",
775
        "/settings/tokens",
776
        None,
777
        Some(&andy),
778
        None,
779
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
780
    )
781
    .await;
782
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
783
    assert_eq!(
784
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
785
        StatusCode::CREATED
786
    );
787
    let rx = receiver().await;
788
    *rx.fail_first.lock().unwrap() = false;
789
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
790
    let csrf = csrf_of(&settings);
791
    let form = |f: String| {
792
        let andy = andy.clone();
c7067c7b Andy McCall 793
        async move {
794
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
795
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
796
        }
9756c67d Andy McCall ↶ 797
    };
798
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
799
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
800
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
c9893553 Andy McCall ↶ 801
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
802
    {
803
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
804
        let before: i64 =
3b1bc27f Andy McCall 805
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 806
        for i in 0..MAX_WAITING {
807
            sqlx::query(
3b1bc27f Andy McCall 808
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
c9893553 Andy McCall ↶ 809
            )
810
            .bind(hook.id)
811
            .bind(format!("flood-{i}"))
812
            .execute(&app.db)
813
            .await
814
            .unwrap();
815
        }
816
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
817
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
818
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
819
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
820
        let after: i64 =
3b1bc27f Andy McCall 821
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 822
        assert_eq!(before, after);
823
    }
9756c67d Andy McCall ↶ 824
    assert_eq!(hook.format, "discord");
825
    // Ping arrives as a Discord message.
826
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
827
    let mut got = String::new();
828
    for _ in 0..100 {
829
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
830
            got = body.clone();
831
        }
832
        if !got.is_empty() {
833
            break;
834
        }
835
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
836
    }
837
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
838
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
839
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
c7067c7b Andy McCall 840
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
9756c67d Andy McCall ↶ 841
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
842
843
    // Editing: a blank URL and secret keep theirs; format, events and active change.
844
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
845
        .await
846
        .contains("Webhook saved"));
847
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
848
    assert_eq!(
849
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
850
        (rx.url.as_str(), "issue", "oxygenhub", true)
851
    );
852
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
853
854
    // An issue opened on the web now reaches the hook, as the signed envelope.
855
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
856
    call(
857
        app,
858
        "POST",
859
        "/andy/demo/issues/new",
860
        None,
861
        Some(&andy),
862
        None,
863
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
864
    )
865
    .await;
866
    let mut envelope = None;
867
    for _ in 0..100 {
868
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
869
        if envelope.is_some() {
870
            break;
871
        }
872
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
873
    }
874
    let (_, sig, body) = envelope.expect("issue.opened delivered");
875
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
876
    assert_eq!(v["data"]["issue"]["title"], "From the web");
877
    assert!(sig.starts_with("blake3-keyed="));
878
    // A disabled hook through the edit form (no active box).
879
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
880
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
881
}
ef20fdc1 Andy McCall ↶ 882
883
#[tokio::test(flavor = "multi_thread")]
884
async fn api_projects() {
885
    let h = hub().await;
886
    let app = &h.app;
c8684d44 Andy McCall 887
    let andy = call(
888
        app,
889
        "POST",
890
        "/register",
891
        None,
892
        None,
893
        None,
894
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
895
    )
896
    .await
897
    .cookie
898
    .unwrap();
899
    let bob = call(
900
        app,
901
        "POST",
902
        "/register",
903
        None,
904
        None,
905
        None,
906
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
907
    )
908
    .await
909
    .cookie
910
    .unwrap();
ef20fdc1 Andy McCall ↶ 911
    let mint = |cookie: String, scopes: &'static str| {
912
        let app = app.clone();
913
        async move {
914
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
915
            let csrf = csrf_of(&page.body);
916
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
917
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
918
        }
919
    };
920
    let a = mint(andy, "scopes=repo%3Aadmin").await;
921
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
922
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
923
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
924
ecac6e8d Andy McCall ↶ 925
    // The caller's own repositories, a page at a time (#302); bob has none.
926
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"zeta","visibility":"private"}"#)).await;
927
    let names =
928
        |v: &serde_json::Value| -> Vec<String> { v.as_array().unwrap().iter().map(|r| r["name"].as_str().unwrap().to_string()).collect() };
929
    let (st, v) = api(app, "GET", "/api/v1/user/repos", Some(&a), None).await;
930
    assert_eq!((st, names(&v)), (StatusCode::OK, vec!["demo".to_string(), "zeta".to_string()]), "{v}");
931
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?limit=1", Some(&a), None).await.1), ["demo"]);
932
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?after=andy/demo", Some(&a), None).await.1), ["zeta"]);
933
    assert!(names(&api(app, "GET", "/api/v1/user/repos", Some(&b), None).await.1).is_empty(), "not bob's");
934
    assert_eq!(api(app, "GET", "/api/v1/user/repos?affiliation=friend", Some(&a), None).await.0, StatusCode::BAD_REQUEST);
935
    assert_eq!(api(app, "GET", "/api/v1/user/repos", None, None).await.0, StatusCode::UNAUTHORIZED);
936
    // Organisations need user:read, which this token lacks.
937
    assert_eq!(api(app, "GET", "/api/v1/user/orgs", Some(&a), None).await.0, StatusCode::FORBIDDEN);
938
ef20fdc1 Andy McCall ↶ 939
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
940
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
941
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
942
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
943
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
944
945
    // Cards by reference, into a column by name, and a note into the first column.
946
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
947
    assert_eq!(st, StatusCode::CREATED, "{card}");
948
    assert_eq!(
949
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
950
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
951
    );
952
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
953
    assert_eq!(st, StatusCode::BAD_REQUEST);
954
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
efb51b39 Andy McCall ↶ 955
    // The form the board shows its cards in is taken too (#118); another owner's is refused.
956
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"andy/demo#1"}"#)).await;
957
    assert!(v["detail"].as_str().unwrap().contains("already on this project"), "{v}");
958
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"other/demo#1"}"#)).await;
959
    assert!(v["detail"].as_str().unwrap().contains("only andy's"), "{v}");
ef20fdc1 Andy McCall ↶ 960
    assert_eq!(
961
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
962
        StatusCode::BAD_REQUEST
963
    );
964
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
965
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
966
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
967
968
    // Move and read the board.
969
    let id = card["id"].as_i64().unwrap();
970
    assert_eq!(
971
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
972
        StatusCode::NO_CONTENT
973
    );
974
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
975
    let names: Vec<(&str, usize)> =
976
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
977
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
978
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
17a3a84b Andy McCall ↶ 979
    // The cards by column (#115), and a wrong method answers with a body.
980
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
981
    assert_eq!(st, StatusCode::OK);
982
    assert_eq!(cols, board["columns"]);
983
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
984
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
985
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
ef20fdc1 Andy McCall ↶ 986
456f4197 Andy McCall ↶ 987
    // A column's cards at once (#289): with exceptions, a state filter and
988
    // a dry run; one audit entry.
989
    for t in ["Second", "Third"] {
990
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(&format!(r#"{{"title":"{t}"}}"#))).await;
991
    }
992
    for n in [2, 3] {
993
        let body = format!(r#"{{"reference":"demo#{n}","column":"Doing"}}"#);
994
        assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(&body)).await.0, StatusCode::CREATED);
995
    }
996
    let bulk = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&a), Some(body));
997
    let refs = |v: &serde_json::Value, k: &str| -> Vec<String> {
998
        v[k].as_array().unwrap().iter().map(|c| c["reference"].as_str().unwrap().to_string()).collect()
999
    };
1000
    let (st, v) = bulk(r##"{"from":"Doing","column":"Done","except":["#2"],"dry_run":true}"##).await;
1001
    assert_eq!(st, StatusCode::OK, "{v}");
1002
    assert_eq!((refs(&v, "moved"), refs(&v, "kept")), (vec!["andy/demo#3".to_string()], vec!["andy/demo#2".to_string()]));
1003
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1004
    assert_eq!(board["columns"][1]["cards"].as_array().unwrap().len(), 2, "a dry run moves nothing");
1005
    let (_, v) = bulk(r#"{"from":"Doing","column":"Done","state":["closed"]}"#).await;
1006
    assert!(refs(&v, "moved").is_empty(), "both are open: {v}");
1007
    let (_, v) = bulk(r#"{"from":"doing","column":"done","except":["demo#2"]}"#).await;
1008
    assert_eq!(refs(&v, "moved"), ["andy/demo#3"]);
1009
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1010
    let names: Vec<(&str, usize)> =
1011
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1012
    assert_eq!(names, [("Backlog", 1), ("Doing", 1), ("Done", 2)]);
1013
    let audited: i64 =
1014
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_moved'").fetch_one(&app.db).await.unwrap();
1015
    assert_eq!(audited, 1, "the dry run and the empty move are not audited");
1016
    assert_eq!(bulk(r#"{"from":"Done","column":"Done"}"#).await.0, StatusCode::BAD_REQUEST);
1017
    assert_eq!(
1018
        api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&b), Some(r#"{"from":"Doing","column":"Done"}"#)).await.0,
1019
        StatusCode::FORBIDDEN
1020
    );
1021
ef20fdc1 Andy McCall ↶ 1022
    // Private: hidden from others; closed: read-only; then remove a card.
1023
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
1024
    assert_eq!(edited["public"], false);
1025
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
1026
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
1027
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
1028
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
1029
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
1030
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
1031
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
1032
}
961c10be Andy McCall ↶ 1033
1034
#[tokio::test(flavor = "multi_thread")]
1035
async fn api_required_checks() {
1036
    let h = hub().await;
1037
    let app = &h.app;
c8684d44 Andy McCall 1038
    let andy = call(
1039
        app,
1040
        "POST",
1041
        "/register",
1042
        None,
1043
        None,
1044
        None,
1045
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1046
    )
1047
    .await
1048
    .cookie
1049
    .unwrap();
961c10be Andy McCall ↶ 1050
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1051
    let csrf = csrf_of(&page.body);
1052
    let mint = |scopes: &'static str| {
1053
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1054
        async move {
1055
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1056
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1057
        }
1058
    };
1059
    let admin = mint("scopes=repo%3Aadmin").await;
1060
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1061
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1062
1063
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1064
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1065
    let (st, v) = api(
1066
        app,
1067
        "PUT",
1068
        "/api/v1/repos/andy/demo/checks/required",
1069
        Some(&admin),
1070
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1071
    )
1072
    .await;
1073
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1074
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1075
    assert_eq!(
1076
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1077
        serde_json::json!(["flow/fmt", "flow/test"])
1078
    );
1079
    assert_eq!(
1080
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1081
        StatusCode::FORBIDDEN,
1082
        "repo:admin only"
1083
    );
1084
    assert_eq!(
1085
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1086
        StatusCode::BAD_REQUEST
1087
    );
1088
    // The settings page shows the same list.
c7067c7b Andy McCall 1089
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
961c10be Andy McCall ↶ 1090
}
9008bf6c Andy McCall ↶ 1091
1092
/// OxygenFlow per repository: site administrators turn it on or off in
1093
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1094
#[tokio::test(flavor = "multi_thread")]
1095
async fn flow_is_switched_per_repository_by_site_admins() {
1096
    let h = hub().await;
1097
    let app = &h.app;
c8684d44 Andy McCall 1098
    let andy = call(
1099
        app,
1100
        "POST",
1101
        "/register",
1102
        None,
1103
        None,
1104
        None,
1105
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1106
    )
1107
    .await
1108
    .cookie
1109
    .unwrap();
9008bf6c Andy McCall ↶ 1110
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1111
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1112
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1113
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1114
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
c7067c7b Andy McCall 1115
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
9008bf6c Andy McCall ↶ 1116
1117
    let set = |value: &'static str| {
1118
        let (app, andy) = (app.clone(), andy.clone());
1119
        async move {
c7067c7b Andy McCall 1120
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1121
            let r = call(
9008bf6c Andy McCall ↶ 1122
                &app,
1123
                "POST",
1124
                "/andy/demo/settings/flow",
1125
                None,
1126
                Some(&andy),
1127
                None,
1128
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1129
            )
c7067c7b Andy McCall 1130
            .await;
1131
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
9008bf6c Andy McCall ↶ 1132
        }
1133
    };
1134
    // A repository admin who is not a site admin sees the state but cannot change it.
1135
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1136
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
c7067c7b Andy McCall 1137
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
9008bf6c Andy McCall ↶ 1138
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1139
    let r = set("on").await;
1140
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1141
    assert_eq!(row().await.flow, "");
1142
1143
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1144
    let r = set("on").await;
1145
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1146
    assert_eq!(row().await.flow, "on");
1147
    assert!(oxygenhub::flow::enabled(app, &row().await));
1148
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1149
    set("off").await;
1150
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1151
    set("default").await;
1152
    assert_eq!(row().await.flow, "");
1870e4fa Andy McCall ↶ 1153
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
9008bf6c Andy McCall ↶ 1154
}
e271a37b Andy McCall ↶ 1155
1156
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1157
/// button, never the repository's default bookmark as the hub sets it.
1158
#[tokio::test(flavor = "multi_thread")]
1159
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1160
    let h = hub().await;
1161
    let app = &h.app;
c8684d44 Andy McCall 1162
    let andy = call(
1163
        app,
1164
        "POST",
1165
        "/register",
1166
        None,
1167
        None,
1168
        None,
1169
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1170
    )
1171
    .await
1172
    .cookie
1173
    .unwrap();
e271a37b Andy McCall ↶ 1174
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1175
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1176
    let url = format!("{}/andy/demo", h.base);
1177
    let work = tempfile::tempdir().unwrap();
1178
    let (w, u) = (work.path().to_path_buf(), url.clone());
1179
    let client = tokio::task::spawn_blocking(move || {
1180
        let mut c = Repo::init(&w).unwrap();
1181
        c.config.set("remote.origin.url", &u).unwrap();
1182
        c.config.set("remote.origin.token", "site").unwrap();
1183
        c.save_config().unwrap();
1184
        write(&w, "a.txt", b"a\n");
1185
        c.commit("a", &[]).unwrap();
1186
        assert!(c.push("origin", false).unwrap()[0].ok);
1187
        for b in ["develop", "feature/x", "stray"] {
1188
            c.bookmark_create(b, None).unwrap();
1189
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1190
        }
1191
        // A pushed deletion.
1192
        let r = c.push_delete("origin", "feature/x").unwrap();
1193
        assert!(r[0].ok, "{r:?}");
1194
        c
1195
    })
1196
    .await
1197
    .unwrap();
1198
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1199
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1200
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1201
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1202
    assert!(!anon.body.contains("/bookmarks/delete"));
1203
1204
    // The hub's default, not the repository's config, is protected: make
1205
    // develop the default, then main can go and develop cannot.
1206
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1207
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1208
    let client = tokio::task::spawn_blocking(move || {
1209
        let r = client.push_delete("origin", "develop").unwrap();
1210
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1211
        let r = client.push_delete("origin", "main").unwrap();
1212
        assert!(r[0].ok, "{r:?}");
1213
        client
1214
    })
1215
    .await
1216
    .unwrap();
1217
    drop(client);
1218
1219
    // On the web: a writer deletes stray; the default is refused.
1220
    let form = |b: &'static str| {
1221
        let (app, andy) = (app.clone(), andy.clone());
1222
        async move {
1223
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1224
            call(
1225
                &app,
1226
                "POST",
1227
                "/andy/demo/bookmarks/delete",
1228
                None,
1229
                Some(&andy),
1230
                None,
1231
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1232
            )
1233
            .await
1234
        }
1235
    };
1236
    let r = form("stray").await;
1237
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1238
    assert!(!r.body.contains(">stray<"));
1239
    let r = form("develop").await;
1240
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1241
    let r = form("nope").await;
1242
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1243
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1244
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1245
    // Anonymous visitors cannot.
1246
    assert_ne!(
1247
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1248
        StatusCode::OK
1249
    );
1250
}
760a7dd3 Andy McCall ↶ 1251
1252
/// A change signed by a key no account has linked says so, on its page
1253
/// and in the API (feedback 14).
1254
#[tokio::test(flavor = "multi_thread")]
1255
async fn changes_signed_by_unlinked_keys_say_so() {
1256
    let h = hub().await;
1257
    let app = &h.app;
c8684d44 Andy McCall 1258
    let andy = call(
1259
        app,
1260
        "POST",
1261
        "/register",
1262
        None,
1263
        None,
1264
        None,
1265
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1266
    )
1267
    .await
1268
    .cookie
1269
    .unwrap();
760a7dd3 Andy McCall ↶ 1270
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1271
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1272
    let url = format!("{}/andy/demo", h.base);
1273
    let work = tempfile::tempdir().unwrap();
1274
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1275
    let hash = tokio::task::spawn_blocking(move || {
1276
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1277
        c.config.set("remote.origin.url", &u).unwrap();
1278
        c.config.set("remote.origin.token", "site").unwrap();
1279
        c.save_config().unwrap();
1280
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1281
        write(&w.join("r"), "a.txt", b"a\n");
1282
        let h = c.commit("signed by Ada", &[]).unwrap();
1283
        assert!(c.push("origin", false).unwrap()[0].ok);
1284
        h.to_hex()
1285
    })
1286
    .await
1287
    .unwrap();
1288
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1289
    assert_eq!(st, StatusCode::OK, "{v}");
1290
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1291
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1292
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1293
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1294
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1295
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1296
}
65be9f9c Andy McCall ↶ 1297
1298
/// Function history (hub spec §6.6): the file page lists a file's
1299
/// functions, and a function's page lists exactly the changes to its lines.
1300
#[tokio::test(flavor = "multi_thread")]
1301
async fn a_function_has_its_own_history() {
1302
    let h = hub().await;
1303
    let app = &h.app;
c8684d44 Andy McCall 1304
    let andy = call(
1305
        app,
1306
        "POST",
1307
        "/register",
1308
        None,
1309
        None,
1310
        None,
1311
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1312
    )
1313
    .await
1314
    .cookie
1315
    .unwrap();
65be9f9c Andy McCall ↶ 1316
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1317
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1318
    let url = format!("{}/andy/demo", h.base);
1319
    let work = tempfile::tempdir().unwrap();
1320
    let w = work.path().to_path_buf();
1321
    tokio::task::spawn_blocking(move || {
1322
        let mut c = Repo::init(&w).unwrap();
1323
        c.config.set("remote.origin.url", &url).unwrap();
1324
        c.config.set("remote.origin.token", "site").unwrap();
1325
        c.save_config().unwrap();
1326
        let steps = [
1327
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1328
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1329
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1330
        ];
1331
        for (msg, text) in steps {
1332
            write(&w, "src/lib.rs", text.as_bytes());
1333
            c.commit(msg, &[]).unwrap();
1334
        }
1335
        assert!(c.push("origin", false).unwrap()[0].ok);
1336
    })
1337
    .await
1338
    .unwrap();
1339
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1340
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1341
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1342
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1343
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1344
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1345
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1346
    assert_ne!(bad.status, StatusCode::OK);
1347
}
92574625 Andy McCall ↶ 1348
1349
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1350
/// dependency edges, linked cards.
1351
#[tokio::test(flavor = "multi_thread")]
1352
async fn a_bookmark_shows_as_swimlanes() {
1353
    let h = hub().await;
1354
    let app = &h.app;
c8684d44 Andy McCall 1355
    let andy = call(
1356
        app,
1357
        "POST",
1358
        "/register",
1359
        None,
1360
        None,
1361
        None,
1362
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1363
    )
1364
    .await
1365
    .cookie
1366
    .unwrap();
92574625 Andy McCall ↶ 1367
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1368
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1369
    let url = format!("{}/andy/demo", h.base);
1370
    let work = tempfile::tempdir().unwrap();
1371
    let w = work.path().to_path_buf();
1372
    tokio::task::spawn_blocking(move || {
1373
        let mut c = Repo::init(&w).unwrap();
1374
        c.config.set("remote.origin.url", &url).unwrap();
1375
        c.config.set("remote.origin.token", "site").unwrap();
1376
        c.save_config().unwrap();
1377
        // Two files edited independently: two lanes.
1378
        write(&w, "a.txt", b"a\n");
1379
        c.commit("add a", &[]).unwrap();
1380
        write(&w, "b.txt", b"b\n");
1381
        c.commit("add b", &[]).unwrap();
1382
        write(&w, "a.txt", b"a\na2\n");
1383
        c.commit("grow a", &[]).unwrap();
1384
        assert!(c.push("origin", false).unwrap()[0].ok);
1385
    })
1386
    .await
1387
    .unwrap();
1388
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1389
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1390
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1391
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1392
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1393
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1394
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1395
    assert_eq!(board.matches("<rect ").count(), 3);
1396
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1397
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1398
}
2bfe5ef6 Andy McCall ↶ 1399
1400
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1401
/// offers only what makes sense and rewrites nothing itself.
1402
#[tokio::test(flavor = "multi_thread")]
1403
async fn a_proposal_board_plans_squashes_and_rebases() {
1404
    let h = hub().await;
1405
    let app = &h.app;
c8684d44 Andy McCall 1406
    let andy = call(
1407
        app,
1408
        "POST",
1409
        "/register",
1410
        None,
1411
        None,
1412
        None,
1413
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1414
    )
1415
    .await
1416
    .cookie
1417
    .unwrap();
2bfe5ef6 Andy McCall ↶ 1418
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1419
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1420
    let url = format!("{}/andy/demo", h.base);
1421
    let work = tempfile::tempdir().unwrap();
1422
    let w = work.path().to_path_buf();
1423
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1424
        let mut c = Repo::init(&w).unwrap();
1425
        c.config.set("remote.origin.url", &url).unwrap();
1426
        c.config.set("remote.origin.token", "site").unwrap();
1427
        c.save_config().unwrap();
1428
        write(&w, "a.txt", b"a\n");
1429
        let base = c.commit("base", &[]).unwrap();
1430
        assert!(c.push("origin", false).unwrap()[0].ok);
1431
        c.bookmark_create("feature", None).unwrap();
1432
        c.bookmark_switch("feature", false).unwrap();
1433
        write(&w, "a.txt", b"a\nfirst\n");
1434
        let first = c.commit("first", &[]).unwrap();
1435
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1436
        let second = c.commit("second", &[]).unwrap();
1437
        write(&w, "b.txt", b"apart\n");
1438
        let apart = c.commit("apart", &[]).unwrap();
1439
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1440
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1441
    })
1442
    .await
1443
    .unwrap();
1444
    // No proposal yet: the board is read-only.
1445
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1446
    assert!(!board.contains("data-plan="));
1447
    let (st, _) = api(
1448
        app,
1449
        "POST",
1450
        "/api/v1/repos/andy/demo/proposals",
1451
        Some("site"),
1452
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1453
    )
1454
    .await;
1455
    assert!(st.is_success(), "{st}");
1456
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1457
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1458
    let csrf = csrf_of(&board);
1459
    let plan = |c: &str, t: &str| {
1460
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1461
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1462
        async move {
1463
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1464
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1465
        }
1466
    };
1467
    let kinds = |v: &serde_json::Value| {
1468
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1469
    };
1470
    // second already depends on first: squash, no rebase.
1471
    let v = plan(&second, &first).await;
1472
    assert_eq!(kinds(&v), ["squash"], "{v}");
1473
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
c96b3286 Andy McCall ↶ 1474
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
2bfe5ef6 Andy McCall ↶ 1475
    // apart is independent of second: either.
1476
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1477
    // first under second: nothing (second depends on first).
1478
    assert!(plan(&first, &second).await["error"].is_string());
1479
    // What has landed on main is not rearranged.
1480
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1481
}
38833ed7 Andy McCall ↶ 1482
1483
/// Issues and proposals share a number space, so every number says what it
1484
/// is, and the chain of work shows from both ends (hub spec §8).
1485
#[tokio::test(flavor = "multi_thread")]
1486
async fn proposals_and_issues_show_their_chain() {
1487
    let h = hub().await;
1488
    let app = &h.app;
c8684d44 Andy McCall 1489
    let andy = call(
1490
        app,
1491
        "POST",
1492
        "/register",
1493
        None,
1494
        None,
1495
        None,
1496
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1497
    )
1498
    .await
1499
    .cookie
1500
    .unwrap();
38833ed7 Andy McCall ↶ 1501
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1502
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1503
    let url = format!("{}/andy/demo", h.base);
1504
    let work = tempfile::tempdir().unwrap();
1505
    let w = work.path().to_path_buf();
1506
    tokio::task::spawn_blocking(move || {
1507
        let mut c = Repo::init(&w).unwrap();
1508
        c.config.set("remote.origin.url", &url).unwrap();
1509
        c.config.set("remote.origin.token", "site").unwrap();
1510
        c.save_config().unwrap();
1511
        write(&w, "a.txt", b"a\n");
1512
        c.commit("base", &[]).unwrap();
1513
        assert!(c.push("origin", false).unwrap()[0].ok);
1514
        c.bookmark_create("feature", None).unwrap();
1515
        c.bookmark_switch("feature", false).unwrap();
1516
        write(&w, "a.txt", b"a\nfixed\n");
1517
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1518
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1519
    })
1520
    .await
1521
    .unwrap();
1522
    for title in ["Slow start", "Crash on save"] {
1523
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1524
        assert!(st.is_success());
1525
    }
1526
    let (st, v) = api(
1527
        app,
1528
        "POST",
1529
        "/api/v1/repos/andy/demo/proposals",
1530
        Some("site"),
1531
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1532
    )
1533
    .await;
1534
    assert!(st.is_success(), "{st} {v}");
1535
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1536
1537
    // The proposal names its kind, links its references by kind, and shows
1538
    // the chain: the issues it closes (description and changes) → it → main.
1539
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1540
    assert!(p.contains(">proposal #3</small>"), "header");
1541
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1542
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1543
    let chain = &chain[..chain.find("</p>").unwrap()];
1544
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1545
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1546
    }
1547
    assert!(p.contains("<h3>Closes</h3>"));
1548
1549
    // The issue shows the proposal that closes it, and names its own kind.
1550
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1551
    assert!(i.contains(">issue #1</small>"));
1552
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1553
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
a1b98695 Andy McCall ↶ 1554
    // The conversation is a timeline with avatars; editing sits with the
1555
    // content, not in the sidebar, and labels and projects are editable.
1556
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1557
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1558
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1559
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1560
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1561
    assert!(st.is_success(), "{st}");
1562
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
9e50caed Andy McCall ↶ 1563
    assert!(
1564
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1565
        "the owner's projects to add to, in a menu"
1566
    );
a1b98695 Andy McCall ↶ 1567
    let csrf = csrf_of(&p);
1568
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1569
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1570
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1571
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1572
        .await;
1573
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1574
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1575
38833ed7 Andy McCall ↶ 1576
    // Closed by the proposal's change, not its description: still shown.
1577
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1578
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1579
    assert!(chain.contains("proposal #3"), "{chain}");
1580
}
e9bfea8e Andy McCall ↶ 1581
1582
/// What the hub is: its version and build, and the libraries it is built on,
1583
/// on /about, in the API and in /health (hub spec §15).
1584
#[tokio::test(flavor = "multi_thread")]
1585
async fn the_hub_says_what_version_it_is() {
1586
    let h = hub().await;
1587
    let app = &h.app;
1588
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1589
    assert_eq!(st, StatusCode::OK);
1590
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1591
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1592
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1593
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1594
    assert!(health.contains("\"build\""), "{health}");
b2107275 Andy McCall ↶ 1595
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1596
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
e9bfea8e Andy McCall ↶ 1597
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1598
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1599
    assert!(about.contains("href=\"/about\""), "the footer links here");
1600
}
df71c789 Andy McCall ↶ 1601
1602
#[tokio::test(flavor = "multi_thread")]
1603
async fn device_sign_in() {
1604
    let h = hub().await;
1605
    let app = &h.app;
c8684d44 Andy McCall 1606
    let r = call(
1607
        app,
1608
        "POST",
1609
        "/register",
1610
        None,
1611
        None,
1612
        None,
1613
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1614
    )
1615
    .await;
df71c789 Andy McCall ↶ 1616
    let andy = r.cookie.unwrap();
1617
1618
    // An unknown scope is refused.
1619
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1620
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1621
1622
    // The app asks for a code and polls; nobody has approved it yet.
1623
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1624
    assert_eq!(st, StatusCode::OK, "{v}");
1625
    let device = v["device_code"].as_str().unwrap().to_string();
1626
    let user = v["user_code"].as_str().unwrap().to_string();
1627
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1628
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1629
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1630
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1631
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1632
    assert_eq!(v["error"], "slow_down", "polled too soon");
1633
1634
    // The user approves it on the web, allowing less than it asked for.
1635
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1636
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1637
    let csrf = csrf_of(&page.body);
1638
    let r =
1639
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1640
            .await;
4da8b828 Andy McCall ↶ 1641
    // oxygenhub#83: the answer page says it is done, with no code form.
1642
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1643
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
df71c789 Andy McCall ↶ 1644
1645
    // The next poll gets a token with what was allowed, once.
1646
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1647
    assert_eq!(st, StatusCode::OK, "{v}");
1648
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1649
    let token = v["access_token"].as_str().unwrap().to_string();
1650
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1651
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1652
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1653
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1654
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1655
    assert!(tokens.body.contains("device: Phone app"));
60f11b71 Andy McCall ↶ 1656
    // oxygenhub#70: a device's token expires, and each use renews it.
1657
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
df71c789 Andy McCall ↶ 1658
60f11b71 Andy McCall ↶ 1659
    // The token can revoke itself (oxy auth logout), and is then refused.
1660
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1661
    assert_eq!(st, StatusCode::NO_CONTENT);
1662
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1663
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1664
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1665
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1666
df71c789 Andy McCall ↶ 1667
    // A denied code says so.
1668
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1669
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1670
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1671
    let csrf = csrf_of(&page.body);
1672
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1673
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1674
    assert_eq!(v["error"], "access_denied");
ecac6e8d Andy McCall ↶ 1675
1676
    // A code the app gave up on (#304) is gone at once: the page no longer
1677
    // takes it, and the app's poll says so.
1678
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Cancelled"}"#)).await;
1679
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1680
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1681
    assert_eq!(st, StatusCode::NO_CONTENT);
1682
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1683
    let csrf = csrf_of(&page.body);
1684
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve"))).await;
1685
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1686
    assert_eq!(v["error"], "expired_token", "{v}");
1687
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1688
    assert_eq!(st, StatusCode::NO_CONTENT, "again: still fine");
df71c789 Andy McCall ↶ 1689
1690
    // Signed out, the page asks for a sign-in first.
1691
    let r = call(app, "GET", "/device", None, None, None, None).await;
1692
    assert!(r.status.is_redirection(), "{}", r.status);
1693
}
62ceb2ee Andy McCall ↶ 1694
1695
#[tokio::test(flavor = "multi_thread")]
1696
async fn api_assistants_at_each_level() {
1697
    let h = hub().await;
1698
    let app = &h.app;
c8684d44 Andy McCall 1699
    let andy = call(
1700
        app,
1701
        "POST",
1702
        "/register",
1703
        None,
1704
        None,
1705
        None,
1706
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1707
    )
1708
    .await
1709
    .cookie
1710
    .unwrap();
62ceb2ee Andy McCall ↶ 1711
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1712
    let csrf = csrf_of(&page.body);
1713
    let mint = |scopes: &'static str| {
1714
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1715
        async move {
1716
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1717
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1718
        }
1719
    };
1720
    let admin = mint("scopes=repo%3Aadmin").await;
1721
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1722
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1723
    // A stand-in endpoint with no model list: any model name is taken.
1724
    let router = axum::Router::new().route(
1725
        "/v1/chat/completions",
1726
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1727
    );
1728
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1729
    let port = listener.local_addr().unwrap().port();
1730
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1731
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1732
1733
    // The site's, by its administrator; the repository's, by its admin.
1734
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1735
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1736
    assert_eq!(st, StatusCode::OK, "{v}");
1737
    assert_eq!(v["ok"], "Gemini added");
1738
    let body =
1739
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1740
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1741
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1742
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1743
    assert_eq!(st, StatusCode::OK, "{v}");
1744
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1745
    assert_eq!(st, StatusCode::OK);
1746
    let names: Vec<(&str, &str, bool)> = v
1747
        .as_array()
1748
        .unwrap()
1749
        .iter()
1750
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1751
        .collect();
1752
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1753
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1754
    // Changing it keeps the token when none is given.
1755
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1756
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1757
    assert_eq!(v["ok"], "Claude updated");
1758
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1759
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1760
    // Prompts: the site's is inherited by the repository.
1761
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1762
    assert_eq!(st, StatusCode::OK);
1763
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1764
    assert_eq!(v["prompt"], "Rust.");
1765
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1766
    // Removed.
1767
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1768
    assert_eq!(st, StatusCode::NO_CONTENT);
1769
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1770
    assert_eq!(st, StatusCode::NOT_FOUND);
1771
}