OXYGENHUB
◆ v0.9.11 oxygenhub / crates / hub / tests / api.rs
96.0 KiB · Rust · last changed Your sky over the API: GET /api/v1/user/sky, the dashboard backdrop's data for the Android app; 0.9.11 (refs andymccall/oxygenhub-android#23) 8 days ago source blame history raw
1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use std::sync::{Arc, Mutex};
15
use tower::ServiceExt;
16
17
fn hermetic() {
18
    static ONCE: std::sync::Once = std::sync::Once::new();
19
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
20
    ONCE.call_once(|| {
21
        let d = tempfile::tempdir().unwrap();
22
        std::env::set_var("OXY_HOME", d.path());
23
        DIR.set(d).ok();
24
    });
25
}
26
27
fn write(root: &Path, rel: &str, content: &[u8]) {
28
    let p = root.join(rel);
29
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
30
    std::fs::write(p, content).unwrap();
31
}
32
33
struct Hub {
34
    app: Shared,
35
    base: String,
36
    _dir: tempfile::TempDir,
37
}
38
39
async fn hub() -> Hub {
40
    hermetic();
41
    let dir = tempfile::tempdir().unwrap();
42
    let mut config = Config::load(dir.path()).unwrap();
43
    // The first account's setup code (oxygenhub#245).
44
    config.registration.setup_code = "test-setup".into();
45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
50
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
51
    config.outbound.allow = vec!["http://127.0.0.1".into()];
52
    let app = oxygenhub::build(config).await.unwrap();
53
    let router = oxygenhub::router(app.clone());
54
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
55
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
56
}
57
58
struct Res {
59
    status: StatusCode,
60
    body: String,
61
    cookie: Option<String>,
62
    location: Option<String>,
63
}
64
65
async fn call(
66
    app: &Shared,
67
    method: &str,
68
    path: &str,
69
    bearer: Option<&str>,
70
    cookie: Option<&str>,
71
    json: Option<&str>,
72
    form: Option<&str>,
73
) -> Res {
74
    let mut req = Request::builder().method(method).uri(path);
75
    if let Some(b) = bearer {
76
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
77
    }
78
    if let Some(c) = cookie {
79
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
80
    }
81
    let body = if let Some(j) = json {
82
        req = req.header(header::CONTENT_TYPE, "application/json");
83
        Body::from(j.to_string())
84
    } else if let Some(f) = form {
85
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
86
        Body::from(f.to_string())
87
    } else {
88
        Body::empty()
89
    };
90
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
91
    let status = res.status();
92
    let cookie = res
93
        .headers()
94
        .get(header::SET_COOKIE)
95
        .and_then(|v| v.to_str().ok())
96
        .and_then(|v| v.split(';').next())
97
        .and_then(|kv| kv.split_once('='))
98
        .map(|(_, v)| v.to_string());
99
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
100
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
101
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
102
}
103
104
/// A repository settings form's answer (#278): a redirect to the page that
105
/// holds the form, followed.
106
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
107
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
108
    let to = r.location.expect("a redirect");
109
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
110
    call(app, "GET", &to, None, cookie, None, None).await
111
}
112
113
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
114
    let r = call(app, method, path, bearer, None, json, None).await;
115
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
116
    (r.status, v)
117
}
118
119
fn csrf_of(page: &str) -> String {
120
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
121
    page[i..].split('"').next().unwrap().to_string()
122
}
123
124
/// A webhook receiver that records what it gets and fails the first time.
125
struct Receiver {
126
    url: String,
127
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
128
    fail_first: Arc<Mutex<bool>>,
129
}
130
131
async fn receiver() -> Receiver {
132
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
133
    let fail_first = Arc::new(Mutex::new(true));
134
    let (s2, f2) = (seen.clone(), fail_first.clone());
135
    let router = Router::new().route(
136
        "/hook",
137
        post(move |headers: header::HeaderMap, body: String| {
138
            let (s2, f2) = (s2.clone(), f2.clone());
139
            async move {
140
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
141
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
142
                let mut f = f2.lock().unwrap();
143
                if *f {
144
                    *f = false;
145
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
146
                }
147
                s2.lock().unwrap().push((event, sig, body));
148
                (StatusCode::OK, "ok")
149
            }
150
        }),
151
    );
152
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
153
    let port = listener.local_addr().unwrap().port();
154
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
155
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
156
}
157
158
#[tokio::test(flavor = "multi_thread")]
159
async fn api_webhooks_and_checks() {
160
    let h = hub().await;
161
    let app = &h.app;
162
    // Accounts and tokens through the pages.
163
    let r = call(
164
        app,
165
        "POST",
166
        "/register",
167
        None,
168
        None,
169
        None,
170
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
171
    )
172
    .await;
173
    let andy = r.cookie.unwrap();
174
    let r = call(
175
        app,
176
        "POST",
177
        "/register",
178
        None,
179
        None,
180
        None,
181
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
182
    )
183
    .await;
184
    let bob = r.cookie.unwrap();
185
    let mint = |cookie: String, scopes: &'static str| {
186
        let app = app.clone();
187
        async move {
188
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
189
            let csrf = csrf_of(&page.body);
190
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
191
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
192
        }
193
    };
194
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
195
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
196
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
197
198
    // Create a repository through the API; the read-only token cannot.
199
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
200
    assert_eq!(st, StatusCode::FORBIDDEN);
201
    let (st, v) = api(
202
        app,
203
        "POST",
204
        "/api/v1/repos",
205
        Some(&andy_admin),
206
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
207
    )
208
    .await;
209
    assert_eq!(st, StatusCode::CREATED, "{v}");
210
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
211
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
212
    assert_eq!(st, StatusCode::CONFLICT);
213
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
214
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
215
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
216
    assert_eq!(st, StatusCode::OK);
217
    assert_eq!(v["username"], "andy");
218
219
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
220
    let rx = receiver().await;
221
    let (st, v) = api(
222
        app,
223
        "POST",
224
        "/api/v1/repos/andy/demo/hooks",
225
        Some(&andy_admin),
226
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
227
    )
228
    .await;
229
    assert_eq!(st, StatusCode::CREATED, "{v}");
230
    let work = tempfile::tempdir().unwrap();
231
    let mut client = Repo::init(work.path()).unwrap();
232
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
233
    client.config.set("remote.origin.token", "site").unwrap();
234
    client.save_config().unwrap();
235
    write(work.path(), "a.txt", b"a\n");
236
    client.snapshot("t").unwrap();
237
    let base = client.commit("base", &[]).unwrap();
238
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
239
    // The worker retries with backoff; drive it directly for the retry.
240
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
241
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
242
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
243
    oxygenhub::hooks::deliver_due(app).await;
244
    let seen = rx.seen.lock().unwrap().clone();
245
    assert_eq!(seen.len(), 1, "{seen:?}");
246
    assert_eq!(seen[0].0, "push");
247
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
248
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
249
    assert_eq!(payload["repository"]["name"], "demo");
250
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
252
    assert_eq!(v.as_array().unwrap().len(), 1);
253
254
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
255
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
256
    assert_eq!(st, StatusCode::OK);
257
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
258
    // A revset in place of the whole history (`?r=`), under a budget; a
259
    // bad one is the caller's problem.
260
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
261
    assert_eq!(st, StatusCode::OK, "{v}");
262
    assert_eq!(v["total"].as_u64(), Some(1));
263
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
264
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
265
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
266
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
267
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
268
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
269
    assert_eq!(v[0]["name"], "a.txt");
270
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
271
    assert_eq!(r.body, "a\n");
272
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
273
    assert_eq!(v[0]["change"], base.to_hex());
274
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
275
    assert_eq!(v["files"][0]["path"], "a.txt");
276
    assert_eq!(v["files"][0]["lines"][0], serde_json::json!({"kind": "add", "new": 1, "text": "a"}), "{v}");
277
    assert_eq!(v["files"][0]["truncated"], false);
278
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
279
    assert!(v["policy"].is_null());
280
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
281
    assert_eq!(v[0]["reference"], "main");
282
283
    // Issues through the API: Bob opens one, comments, and closes it.
284
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
285
    assert_eq!(st, StatusCode::CREATED, "{v}");
286
    assert_eq!(v["number"], 1);
287
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
288
    assert_eq!(st, StatusCode::CREATED);
289
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
290
    assert_eq!(st, StatusCode::OK, "{v}");
291
    assert_eq!(v["state"], "closed");
292
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
293
    assert_eq!(v[0]["comments"], 1);
294
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
295
    assert_eq!(v[0]["number"], 1);
296
297
    // A proposal through the API, then a required check gates its landing.
298
    client.bookmark_create("feat", Some(&[base])).unwrap();
299
    client.bookmark_switch("feat", false).unwrap();
300
    write(work.path(), "b.txt", b"b\n");
301
    write(work.path(), "a.txt", b"a\nA\n");
302
    client.snapshot("t").unwrap();
303
    let feat = client.commit("feat", &[]).unwrap();
304
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
305
    let (st, v) =
306
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
307
            .await;
308
    assert_eq!(st, StatusCode::CREATED, "{v}");
309
    assert_eq!(v["number"], 2);
310
    let state = v["projected_state"].as_str().unwrap().to_string();
311
    assert_eq!(v["landable"], true);
312
    // A wiki takes no proposals, and says so rather than "no such
313
    // repository" (oxygenhub#128); a repository's that does not exist
314
    // still does not.
315
    let (st, v) =
316
        api(app, "POST", "/api/v1/repos/andy/demo.wiki/proposals", Some(&bob_rw), Some(r#"{"title":"W","target":"main","source":"p"}"#))
317
            .await;
318
    let detail = v["detail"].as_str().unwrap_or_default();
319
    assert!(st == StatusCode::NOT_FOUND && detail.contains("is the wiki of andy/demo") && detail.contains("push main"), "{v}");
320
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/nope.wiki/proposals", Some(&bob_rw), None).await;
321
    assert_eq!(v["detail"], "no such repository");
322
    // Its files, and each side's bytes, for editors' diff views.
323
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
324
    assert_eq!(st, StatusCode::OK, "{v}");
325
    let files: Vec<(String, String)> =
326
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
327
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
328
    assert_eq!(v[0]["added"], 1);
329
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
330
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
331
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
332
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
333
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
334
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
335
    // The same files with their diffs, as a change's (oxygenhub-android#4).
336
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/diff", None, None).await;
337
    assert_eq!(st, StatusCode::OK, "{v}");
338
    assert_eq!((v[0]["path"].as_str(), v[0]["added"].as_u64(), v[0]["truncated"].as_bool()), (Some("a.txt"), Some(1), Some(false)), "{v}");
339
    let lines: Vec<(String, String)> = v[0]["lines"]
340
        .as_array()
341
        .unwrap()
342
        .iter()
343
        .map(|l| (l["kind"].as_str().unwrap().to_string(), l["text"].as_str().unwrap().to_string()))
344
        .collect();
345
    assert_eq!(lines, vec![("context".into(), "a".into()), ("add".into(), "A".into())], "{v}");
346
    assert_eq!(v[1]["kind"], "added");
347
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/proposals/99/diff", None, None).await.0, StatusCode::NOT_FOUND);
348
    // An anchored comment comes back with its line in the projected state.
349
    let (st, v) = api(
350
        app,
351
        "POST",
352
        "/api/v1/repos/andy/demo/proposals/2/comments",
353
        Some(&bob_rw),
354
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
355
    )
356
    .await;
357
    assert_eq!(st, StatusCode::CREATED, "{v}");
358
    assert_eq!(v["line"], 2);
359
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
360
    assert_eq!(v[0]["path"], "a.txt");
361
    assert_eq!(v[0]["line"], 2, "{v}");
362
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
363
    // Require the "build" check.
364
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
365
    let csrf = csrf_of(&settings.body);
366
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
367
        .await;
368
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
369
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
370
    assert_eq!(v["landable"], false);
371
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
372
    // Nothing to land yet for its owner (#311), and the list is only there when asked for.
373
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
374
    assert!(v.get("landable").is_none(), "{v}");
375
    // A checker reports on the projected state: first running, then passed; the page streams it.
376
    let (st, v) = api(
377
        app,
378
        "POST",
379
        "/api/v1/repos/andy/demo/checks",
380
        Some(&andy_ro),
381
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
382
    )
383
    .await;
384
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
385
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
386
    let (st, v) = api(
387
        app,
388
        "POST",
389
        "/api/v1/repos/andy/demo/checks",
390
        Some(&bob_rw),
391
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
392
    )
393
    .await;
394
    assert_eq!(st, StatusCode::CREATED, "{v}");
395
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
396
    assert_eq!(ev.kind, "check");
397
    assert_eq!(ev.check.unwrap().name, "build");
398
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
399
    assert_eq!(v[0]["status"], "passed");
400
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
401
    assert_eq!(v["landable"], true, "{v}");
402
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
403
    assert_eq!((v["landable"][0]["repository"].as_str(), v["landable"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
404
    assert!(api(app, "GET", "/api/v1/user/proposals", Some(&andy_ro), None).await.1.get("landable").is_none(), "only when asked");
405
    // Your sky for the app (oxygenhub-android#23): the dashboard's backdrop data.
406
    let (st, v) = api(app, "GET", "/api/v1/user/sky", Some(&andy_ro), None).await;
407
    assert_eq!(st, StatusCode::OK, "{v}");
408
    let demo = v["repos"].as_array().unwrap().iter().position(|r| r == "andy/demo").expect("andy's repository") as i64;
409
    let events = v["events"].as_array().unwrap();
410
    assert!(events.iter().any(|e| e[0] == demo && e[1] == 0), "a push: {v}");
411
    assert!(events.iter().any(|e| e[0] == demo && e[1] == 1), "a proposal event: {v}");
412
    assert!(events.iter().all(|e| e[2].as_i64().unwrap() <= v["now"].as_i64().unwrap()));
413
    assert_eq!(api(app, "GET", "/api/v1/user/sky", None, None).await.0, StatusCode::UNAUTHORIZED);
414
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
415
    assert!(page.body.contains("42 tests"), "{}", page.body);
416
    // A summary carrying whole hashes shows them by their ends, so the
417
    // Checks panel keeps its width (a pin mismatch's message, 2026-10-16).
418
    let (a, b) = (
419
        "6ea27b1d35037a4e4d0f6208b1ca99630df40888bd21fd55c8f8aba51dcdd7cb",
420
        "f7495d7689da3ac5b68684f26fce28b91ce55e6b8131c5e484ad2aab90c3020f",
421
    );
422
    let summary = format!("could not run: flow-init has BLAKE3 {a}, but {b} is pinned");
423
    let body = serde_json::json!({ "state": state, "name": "lint", "status": "failed", "summary": summary }).to_string();
424
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/checks", Some(&bob_rw), Some(&body)).await;
425
    assert_eq!(st, StatusCode::CREATED, "{v}");
426
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await.body;
427
    assert!(page.contains("6ea27b1d…1dcdd7cb") && page.contains(&format!("data-full=\"{a}\"")), "{page}");
428
    assert!(!page.contains(&format!("BLAKE3 {a},")), "never the whole hash inline");
429
    // The Checks section refreshes itself; nothing reloads the whole page.
430
    assert!(!page.contains("location.reload()"), "no full reload on a check");
431
    let part = call(app, "GET", "/andy/demo/proposal/2?fragment=checks", None, Some(&andy), None, None).await.body;
432
    assert!(part.contains("<h3>Checks</h3>") && part.contains("6ea27b1d…1dcdd7cb") && !part.contains("<html"), "{part}");
433
    // The check and the proposal reached the webhook too.
434
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
435
    oxygenhub::hooks::deliver_due(app).await;
436
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
437
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
438
    let _ = feat;
439
    let _ = rx.fail_first;
440
441
    // The inbox through the API: count, list, mark one read, mark all read.
442
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
443
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
444
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
445
    oxygenhub::db::notify::add(
446
        &app.db,
447
        oxygenhub::db::notify::New {
448
            account_id: bob_id,
449
            repo_id: Some(oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id),
450
            reason: oxygenhub::db::notify::Reason::Participating,
451
            kind: "issue.opened",
452
            title: "andy/demo#1: Bug",
453
            url: "/andy/demo/issue/1",
454
            actor: "andy",
455
        },
456
    )
457
    .await
458
    .unwrap();
459
    oxygenhub::db::notify::add(
460
        &app.db,
461
        oxygenhub::db::notify::New {
462
            account_id: bob_id,
463
            repo_id: None,
464
            reason: oxygenhub::db::notify::Reason::Participating,
465
            kind: "review",
466
            title: "andy/demo#2: Feat",
467
            url: "/andy/demo/proposal/2",
468
            actor: "andy",
469
        },
470
    )
471
    .await
472
    .unwrap();
473
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
474
    assert_eq!(st, StatusCode::OK, "{v}");
475
    assert_eq!(v["unread"], 2);
476
    assert_eq!(v["items"][0]["read"], false);
477
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
478
    // Its repository, why, its thread and the kind's label (#305).
479
    let bug = v["items"].as_array().unwrap().iter().find(|n| n["title"] == "andy/demo#1: Bug").unwrap();
480
    assert_eq!(
481
        (bug["repository"].as_str(), bug["reason"].as_str(), bug["label"].as_str()),
482
        (Some("andy/demo"), Some("participating"), Some("🐛 New Issue")),
483
        "{bug}"
484
    );
485
    assert_eq!(bug["thread"].as_str(), Some(format!("{}/andy/demo/issue/1", h.base).as_str()));
486
    let first = v["items"][0]["id"].as_i64().unwrap();
487
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
488
    assert_eq!(st, StatusCode::NO_CONTENT);
489
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
490
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
491
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
492
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
493
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
494
    // No token at all is 401, so a client knows to sign in (#303).
495
    assert_eq!(api(app, "GET", "/api/v1/notifications", None, None).await.0, StatusCode::UNAUTHORIZED);
496
    assert_eq!(api(app, "GET", "/api/v1/user", None, None).await.0, StatusCode::UNAUTHORIZED);
497
498
    // Review requests: the author asks andy; andy is told, reviews, and the
499
    // request is answered; the author hears of the review.
500
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
501
    let (st, orgs) = api(app, "GET", "/api/v1/user/orgs", Some(&andy_user), None).await;
502
    assert!(st == StatusCode::OK && orgs.is_array(), "the caller's organisations (#302): {orgs}");
503
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
504
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
505
        .await
506
        .unwrap();
507
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
508
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
509
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
510
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
511
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
512
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
513
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
514
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
515
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
516
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
517
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
518
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
519
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
520
    let (st, _) =
521
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
522
    assert_eq!(st, StatusCode::CREATED);
523
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
524
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
525
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
526
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
527
    // Asking again and withdrawing it.
528
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
529
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
530
    assert_eq!(st, StatusCode::NO_CONTENT);
531
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
532
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
533
    // oxygenhub#84: the page's menu sets who is asked, all at once.
534
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
535
    assert!(
536
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
537
        "the reviewers menu lists andy"
538
    );
539
    let csrf = csrf_of(&page.body);
540
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
541
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
542
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
543
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
544
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
545
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
546
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
547
548
    // A source bookmark with `/` in its name, as a feature/N-name workflow
549
    // makes them: by name, and as this repository's owner/name:bookmark.
550
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
551
        client.bookmark_create(b, Some(&[base])).unwrap();
552
        client.bookmark_switch(b, false).unwrap();
553
        write(work.path(), file, b"c\n");
554
        client.snapshot("t").unwrap();
555
        client.commit(b, &[]).unwrap();
556
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
557
    }
558
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
559
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
560
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
561
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
562
        let n = v["number"].as_i64().unwrap();
563
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
564
        assert_eq!(page.status, StatusCode::OK);
565
        assert!(page.body.contains("feature/"), "the page names its source");
566
    }
567
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
568
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
569
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
570
571
    // oxygenhub#76: a proposal's title and description are edited through
572
    // the API by its author or a maintainer; what is not given stays.
573
    let edit = |token: &str, number: i64, body: &str| {
574
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
575
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
576
    };
577
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
578
    assert_eq!(st, StatusCode::OK, "{v}");
579
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
580
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
581
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
582
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
583
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
584
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
585
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
586
    let (st, v) = api(
587
        app,
588
        "POST",
589
        "/api/v1/repos/andy/demo/proposals",
590
        Some(&andy_pw),
591
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
592
    )
593
    .await;
594
    assert_eq!(st, StatusCode::CREATED, "{v}");
595
    let n = v["number"].as_i64().unwrap();
596
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
597
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
598
599
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
600
    // before anything changes, shown in its JSON.
601
    for l in ["ui", "flow"] {
602
        let body = format!(r#"{{"name":"{l}"}}"#);
603
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
604
    }
605
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
606
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
607
    assert_eq!(st, StatusCode::OK, "{v}");
608
    let names = |v: &serde_json::Value| -> Vec<String> {
609
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
610
    };
611
    assert_eq!(names(&v), ["flow", "ui"]);
612
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
613
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
614
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
615
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
616
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
617
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
618
    assert_eq!(names(&v), ["flow"]);
619
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
620
}
621
622
#[tokio::test(flavor = "multi_thread")]
623
async fn api_issue_triage_and_labels() {
624
    let h = hub().await;
625
    let app = &h.app;
626
    let andy = call(
627
        app,
628
        "POST",
629
        "/register",
630
        None,
631
        None,
632
        None,
633
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
634
    )
635
    .await
636
    .cookie
637
    .unwrap();
638
    let bob = call(
639
        app,
640
        "POST",
641
        "/register",
642
        None,
643
        None,
644
        None,
645
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
646
    )
647
    .await
648
    .cookie
649
    .unwrap();
650
    let mint = |cookie: String, scopes: &'static str| {
651
        let app = app.clone();
652
        async move {
653
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
654
            let csrf = csrf_of(&page.body);
655
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
656
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
657
        }
658
    };
659
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
660
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
661
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
662
    assert_eq!(st, StatusCode::CREATED);
663
664
    // Labels through the API; bad colours and non-triage callers are refused.
665
    let (st, v) = api(
666
        app,
667
        "POST",
668
        "/api/v1/repos/andy/demo/labels",
669
        Some(&andy_t),
670
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
671
    )
672
    .await;
673
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
674
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
675
    assert_eq!(
676
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
677
        StatusCode::BAD_REQUEST
678
    );
679
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
680
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
681
    assert_eq!(labels.as_array().unwrap().len(), 2);
682
    // oxygenhub#91: milestones over the API, for triage.
683
    let (st, m) = api(
684
        app,
685
        "POST",
686
        "/api/v1/repos/andy/demo/milestones",
687
        Some(&andy_t),
688
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
689
    )
690
    .await;
691
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
692
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
693
    assert_eq!(
694
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
695
        StatusCode::BAD_REQUEST
696
    );
697
    assert_eq!(
698
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
699
        StatusCode::FORBIDDEN
700
    );
701
    let (st, m) =
702
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
703
            .await;
704
    assert_eq!(
705
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
706
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
707
        "{m}"
708
    );
709
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
710
    assert_eq!(
711
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
712
        StatusCode::NOT_FOUND,
713
        "renamed"
714
    );
715
    assert_eq!(
716
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
717
        StatusCode::BAD_REQUEST
718
    );
719
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
720
    assert_eq!(list.as_array().unwrap().len(), 1);
721
722
    // An issue created with its labels and assignee in one call.
723
    let (st, v) = api(
724
        app,
725
        "POST",
726
        "/api/v1/repos/andy/demo/issues",
727
        Some(&andy_t),
728
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
729
    )
730
    .await;
731
    assert_eq!(st, StatusCode::CREATED, "{v}");
732
    assert_eq!(v["labels"][0]["name"], "bug");
733
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
734
    let n = v["number"].as_i64().unwrap();
735
    // Unknown names are refused before anything is created.
736
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
737
    assert_eq!(st, StatusCode::BAD_REQUEST);
738
    assert!(v["detail"].as_str().unwrap().contains("no label"));
739
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
740
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
741
    // Without triage, labels cannot be set, but a plain issue can be opened.
742
    assert_eq!(
743
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
744
        StatusCode::FORBIDDEN
745
    );
746
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
747
    assert_eq!(st, StatusCode::CREATED);
748
    let bob_n = bobs["number"].as_i64().unwrap();
749
750
    // PATCH: the whole label set, assignees and milestone, with events.
751
    let (st, v) =
752
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
753
            .await;
754
    assert_eq!(st, StatusCode::OK, "{v}");
755
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
756
    assert_eq!(v["assignees"], serde_json::json!([]));
757
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
758
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
759
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
760
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
761
    // The author edits their own title; others cannot; nobody but triage sets labels.
762
    let (st, v) =
763
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
764
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
765
    assert_eq!(
766
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
767
        StatusCode::FORBIDDEN
768
    );
769
    assert_eq!(
770
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
771
        StatusCode::FORBIDDEN
772
    );
773
    assert_eq!(
774
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
775
        StatusCode::BAD_REQUEST
776
    );
777
778
    // Deleting a label takes it off the issues.
779
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
780
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
781
    assert_eq!(v["labels"], serde_json::json!([]));
782
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
783
}
784
785
#[tokio::test(flavor = "multi_thread")]
786
async fn webhook_formats_editing_and_web_issue_events() {
787
    let h = hub().await;
788
    let app = &h.app;
789
    let andy = call(
790
        app,
791
        "POST",
792
        "/register",
793
        None,
794
        None,
795
        None,
796
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
797
    )
798
    .await
799
    .cookie
800
    .unwrap();
801
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
802
    let r = call(
803
        app,
804
        "POST",
805
        "/settings/tokens",
806
        None,
807
        Some(&andy),
808
        None,
809
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
810
    )
811
    .await;
812
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
813
    assert_eq!(
814
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
815
        StatusCode::CREATED
816
    );
817
    let rx = receiver().await;
818
    *rx.fail_first.lock().unwrap() = false;
819
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
820
    let csrf = csrf_of(&settings);
821
    let form = |f: String| {
822
        let andy = andy.clone();
823
        async move {
824
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
825
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
826
        }
827
    };
828
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
829
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
830
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
831
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
832
    {
833
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
834
        let before: i64 =
835
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
836
        for i in 0..MAX_WAITING {
837
            sqlx::query(
838
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
839
            )
840
            .bind(hook.id)
841
            .bind(format!("flood-{i}"))
842
            .execute(&app.db)
843
            .await
844
            .unwrap();
845
        }
846
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
847
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
848
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
849
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
850
        let after: i64 =
851
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
852
        assert_eq!(before, after);
853
    }
854
    assert_eq!(hook.format, "discord");
855
    // Ping arrives as a Discord message.
856
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
857
    let mut got = String::new();
858
    for _ in 0..100 {
859
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
860
            got = body.clone();
861
        }
862
        if !got.is_empty() {
863
            break;
864
        }
865
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
866
    }
867
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
868
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
869
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
870
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
871
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
872
873
    // Editing: a blank URL and secret keep theirs; format, events and active change.
874
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
875
        .await
876
        .contains("Webhook saved"));
877
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
878
    assert_eq!(
879
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
880
        (rx.url.as_str(), "issue", "oxygenhub", true)
881
    );
882
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
883
884
    // An issue opened on the web now reaches the hook, as the signed envelope.
885
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
886
    call(
887
        app,
888
        "POST",
889
        "/andy/demo/issues/new",
890
        None,
891
        Some(&andy),
892
        None,
893
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
894
    )
895
    .await;
896
    let mut envelope = None;
897
    for _ in 0..100 {
898
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
899
        if envelope.is_some() {
900
            break;
901
        }
902
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
903
    }
904
    let (_, sig, body) = envelope.expect("issue.opened delivered");
905
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
906
    assert_eq!(v["data"]["issue"]["title"], "From the web");
907
    assert!(sig.starts_with("blake3-keyed="));
908
    // A disabled hook through the edit form (no active box).
909
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
910
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
911
}
912
913
#[tokio::test(flavor = "multi_thread")]
914
async fn api_projects() {
915
    let h = hub().await;
916
    let app = &h.app;
917
    let andy = call(
918
        app,
919
        "POST",
920
        "/register",
921
        None,
922
        None,
923
        None,
924
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
925
    )
926
    .await
927
    .cookie
928
    .unwrap();
929
    let bob = call(
930
        app,
931
        "POST",
932
        "/register",
933
        None,
934
        None,
935
        None,
936
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
937
    )
938
    .await
939
    .cookie
940
    .unwrap();
941
    let mint = |cookie: String, scopes: &'static str| {
942
        let app = app.clone();
943
        async move {
944
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
945
            let csrf = csrf_of(&page.body);
946
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
947
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
948
        }
949
    };
950
    let a = mint(andy, "scopes=repo%3Aadmin").await;
951
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
952
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
953
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
954
955
    // The caller's own repositories, a page at a time (#302); bob has none.
956
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"zeta","visibility":"private"}"#)).await;
957
    let names =
958
        |v: &serde_json::Value| -> Vec<String> { v.as_array().unwrap().iter().map(|r| r["name"].as_str().unwrap().to_string()).collect() };
959
    let (st, v) = api(app, "GET", "/api/v1/user/repos", Some(&a), None).await;
960
    assert_eq!((st, names(&v)), (StatusCode::OK, vec!["demo".to_string(), "zeta".to_string()]), "{v}");
961
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?limit=1", Some(&a), None).await.1), ["demo"]);
962
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?after=andy/demo", Some(&a), None).await.1), ["zeta"]);
963
    assert!(names(&api(app, "GET", "/api/v1/user/repos", Some(&b), None).await.1).is_empty(), "not bob's");
964
    assert_eq!(api(app, "GET", "/api/v1/user/repos?affiliation=friend", Some(&a), None).await.0, StatusCode::BAD_REQUEST);
965
    assert_eq!(api(app, "GET", "/api/v1/user/repos", None, None).await.0, StatusCode::UNAUTHORIZED);
966
    // The proposals to act on, as the dashboard lists them: bob's in andy's
967
    // repository is andy's to review and bob's own.
968
    let demo = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
969
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
970
    oxygenhub::db::proposals::create(
971
        &app.db,
972
        oxygenhub::db::proposals::NewProposal {
973
            repo_id: demo.id,
974
            title: "Faster startup",
975
            body: "",
976
            author_id: Some(bob_id),
977
            author: "bob",
978
            draft: false,
979
            target: "main",
980
            source_kind: "bookmark",
981
            source_repo_id: Some(demo.id),
982
            source_bookmark: "fast",
983
            source_changes: "",
984
        },
985
    )
986
    .await
987
    .unwrap();
988
    let (st, v) = api(app, "GET", "/api/v1/user/proposals", Some(&a), None).await;
989
    assert_eq!(st, StatusCode::OK, "{v}");
990
    assert_eq!((v["review"][0]["repository"].as_str(), v["review"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
991
    assert_eq!(v["review"][0]["state"], "open");
992
    assert!(v["review"][0]["url"].as_str().unwrap().ends_with("/andy/demo/proposal/2"));
993
    assert_eq!(v["authored"].as_array().map(Vec::len), Some(0));
994
    let (_, v) = api(app, "GET", "/api/v1/user/proposals", Some(&b), None).await;
995
    assert_eq!((v["review"].as_array().map(Vec::len), v["authored"][0]["title"].as_str()), (Some(0), Some("Faster startup")), "{v}");
996
    assert_eq!(api(app, "GET", "/api/v1/user/proposals", None, None).await.0, StatusCode::UNAUTHORIZED);
997
998
    // Organisations need user:read, which this token lacks.
999
    assert_eq!(api(app, "GET", "/api/v1/user/orgs", Some(&a), None).await.0, StatusCode::FORBIDDEN);
1000
1001
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
1002
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
1003
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
1004
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
1005
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
1006
1007
    // Cards by reference, into a column by name, and a note into the first column.
1008
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
1009
    assert_eq!(st, StatusCode::CREATED, "{card}");
1010
    assert_eq!(
1011
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
1012
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
1013
    );
1014
    assert_eq!((card["labels"].as_array().map(Vec::len), card["assignees"].as_array().map(Vec::len)), (Some(0), Some(0)), "{card}");
1015
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
1016
    assert_eq!(st, StatusCode::BAD_REQUEST);
1017
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
1018
    // The form the board shows its cards in is taken too (#118); another owner's is refused.
1019
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"andy/demo#1"}"#)).await;
1020
    assert!(v["detail"].as_str().unwrap().contains("already on this project"), "{v}");
1021
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"other/demo#1"}"#)).await;
1022
    assert!(v["detail"].as_str().unwrap().contains("only andy's"), "{v}");
1023
    assert_eq!(
1024
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
1025
        StatusCode::BAD_REQUEST
1026
    );
1027
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
1028
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
1029
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
1030
1031
    // Move and read the board.
1032
    let id = card["id"].as_i64().unwrap();
1033
    assert_eq!(
1034
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
1035
        StatusCode::NO_CONTENT
1036
    );
1037
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1038
    let names: Vec<(&str, usize)> =
1039
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1040
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
1041
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
1042
    // The cards by column (#115), and a wrong method answers with a body.
1043
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
1044
    assert_eq!(st, StatusCode::OK);
1045
    assert_eq!(cols, board["columns"]);
1046
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
1047
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
1048
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
1049
1050
    // A column's cards at once (#289): with exceptions, a state filter and
1051
    // a dry run; one audit entry.
1052
    for t in ["Second", "Third"] {
1053
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(&format!(r#"{{"title":"{t}"}}"#))).await;
1054
    }
1055
    for n in [2, 3] {
1056
        let body = format!(r#"{{"reference":"demo#{n}","column":"Doing"}}"#);
1057
        assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(&body)).await.0, StatusCode::CREATED);
1058
    }
1059
    let bulk = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&a), Some(body));
1060
    let refs = |v: &serde_json::Value, k: &str| -> Vec<String> {
1061
        v[k].as_array().unwrap().iter().map(|c| c["reference"].as_str().unwrap().to_string()).collect()
1062
    };
1063
    let (st, v) = bulk(r##"{"from":"Doing","column":"Done","except":["#2"],"dry_run":true}"##).await;
1064
    assert_eq!(st, StatusCode::OK, "{v}");
1065
    assert_eq!((refs(&v, "moved"), refs(&v, "kept")), (vec!["andy/demo#3".to_string()], vec!["andy/demo#2".to_string()]));
1066
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1067
    assert_eq!(board["columns"][1]["cards"].as_array().unwrap().len(), 2, "a dry run moves nothing");
1068
    let (_, v) = bulk(r#"{"from":"Doing","column":"Done","state":["closed"]}"#).await;
1069
    assert!(refs(&v, "moved").is_empty(), "both are open: {v}");
1070
    let (_, v) = bulk(r#"{"from":"doing","column":"done","except":["demo#2"]}"#).await;
1071
    assert_eq!(refs(&v, "moved"), ["andy/demo#3"]);
1072
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1073
    let names: Vec<(&str, usize)> =
1074
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1075
    assert_eq!(names, [("Backlog", 1), ("Doing", 1), ("Done", 2)]);
1076
    let audited: i64 =
1077
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_moved'").fetch_one(&app.db).await.unwrap();
1078
    assert_eq!(audited, 1, "the dry run and the empty move are not audited");
1079
    assert_eq!(bulk(r#"{"from":"Done","column":"Done"}"#).await.0, StatusCode::BAD_REQUEST);
1080
    assert_eq!(
1081
        api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&b), Some(r#"{"from":"Doing","column":"Done"}"#)).await.0,
1082
        StatusCode::FORBIDDEN
1083
    );
1084
1085
    // Archive (#293): Done's cards there more than a week (#3, made old),
1086
    // listed with ?archived=true, restored once.
1087
    sqlx::query("UPDATE project_cards SET moved_ms = 0 WHERE number = 3").execute(&app.db).await.unwrap();
1088
    let archive = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/archive", Some(&a), Some(body));
1089
    let (st, v) = archive(r#"{"from":"Done","older_days":7,"dry_run":true}"#).await;
1090
    assert_eq!((st, refs(&v, "archived")), (StatusCode::OK, vec!["andy/demo#3".to_string()]), "{v}");
1091
    assert!(v["archived"][0].get("archived_ms").is_none(), "a dry run archives nothing: {v}");
1092
    let (_, v) = archive(r#"{"from":"Done","older_days":7}"#).await;
1093
    assert_eq!((refs(&v, "archived"), refs(&v, "kept").len()), (vec!["andy/demo#3".to_string()], 1), "{v}");
1094
    assert!(v["archived"][0]["archived_ms"].as_i64().is_some());
1095
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1096
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 1, "off the board: {board}");
1097
    let (st, archived) = api(app, "GET", "/api/v1/projects/andy/1/cards?archived=true", None, None).await;
1098
    assert_eq!((st, archived[2]["cards"][0]["reference"].as_str()), (StatusCode::OK, Some("andy/demo#3")), "{archived}");
1099
    let card = archived[2]["cards"][0]["id"].as_i64().unwrap();
1100
    let restore = format!("/api/v1/projects/andy/1/cards/{card}/restore");
1101
    assert_eq!(api(app, "POST", &restore, Some(&b), None).await.0, StatusCode::FORBIDDEN);
1102
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NO_CONTENT);
1103
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NOT_FOUND, "not archived now");
1104
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1105
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 2);
1106
    assert_eq!(archive(r#"{"from":"Done","older_days":-1}"#).await.0, StatusCode::BAD_REQUEST);
1107
    let audited: i64 =
1108
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_archived'").fetch_one(&app.db).await.unwrap();
1109
    assert_eq!(audited, 1);
1110
1111
    // Private: hidden from others; closed: read-only; then remove a card.
1112
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
1113
    assert_eq!(edited["public"], false);
1114
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
1115
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
1116
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
1117
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
1118
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
1119
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
1120
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
1121
}
1122
1123
#[tokio::test(flavor = "multi_thread")]
1124
async fn api_required_checks() {
1125
    let h = hub().await;
1126
    let app = &h.app;
1127
    let andy = call(
1128
        app,
1129
        "POST",
1130
        "/register",
1131
        None,
1132
        None,
1133
        None,
1134
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1135
    )
1136
    .await
1137
    .cookie
1138
    .unwrap();
1139
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1140
    let csrf = csrf_of(&page.body);
1141
    let mint = |scopes: &'static str| {
1142
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1143
        async move {
1144
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1145
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1146
        }
1147
    };
1148
    let admin = mint("scopes=repo%3Aadmin").await;
1149
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1150
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1151
1152
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1153
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1154
    let (st, v) = api(
1155
        app,
1156
        "PUT",
1157
        "/api/v1/repos/andy/demo/checks/required",
1158
        Some(&admin),
1159
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1160
    )
1161
    .await;
1162
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1163
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1164
    assert_eq!(
1165
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1166
        serde_json::json!(["flow/fmt", "flow/test"])
1167
    );
1168
    assert_eq!(
1169
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1170
        StatusCode::FORBIDDEN,
1171
        "repo:admin only"
1172
    );
1173
    assert_eq!(
1174
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1175
        StatusCode::BAD_REQUEST
1176
    );
1177
    // The settings page shows the same list.
1178
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
1179
}
1180
1181
/// OxygenFlow per repository: site administrators turn it on or off in
1182
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1183
#[tokio::test(flavor = "multi_thread")]
1184
async fn flow_is_switched_per_repository_by_site_admins() {
1185
    let h = hub().await;
1186
    let app = &h.app;
1187
    let andy = call(
1188
        app,
1189
        "POST",
1190
        "/register",
1191
        None,
1192
        None,
1193
        None,
1194
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1195
    )
1196
    .await
1197
    .cookie
1198
    .unwrap();
1199
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1200
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1201
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1202
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1203
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
1204
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
1205
1206
    let set = |value: &'static str| {
1207
        let (app, andy) = (app.clone(), andy.clone());
1208
        async move {
1209
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1210
            let r = call(
1211
                &app,
1212
                "POST",
1213
                "/andy/demo/settings/flow",
1214
                None,
1215
                Some(&andy),
1216
                None,
1217
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1218
            )
1219
            .await;
1220
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
1221
        }
1222
    };
1223
    // A repository admin who is not a site admin sees the state but cannot change it.
1224
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1225
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
1226
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1227
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1228
    let r = set("on").await;
1229
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1230
    assert_eq!(row().await.flow, "");
1231
1232
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1233
    let r = set("on").await;
1234
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1235
    assert_eq!(row().await.flow, "on");
1236
    assert!(oxygenhub::flow::enabled(app, &row().await));
1237
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1238
    set("off").await;
1239
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1240
    set("default").await;
1241
    assert_eq!(row().await.flow, "");
1242
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
1243
}
1244
1245
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1246
/// button, never the repository's default bookmark as the hub sets it.
1247
#[tokio::test(flavor = "multi_thread")]
1248
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1249
    let h = hub().await;
1250
    let app = &h.app;
1251
    let andy = call(
1252
        app,
1253
        "POST",
1254
        "/register",
1255
        None,
1256
        None,
1257
        None,
1258
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1259
    )
1260
    .await
1261
    .cookie
1262
    .unwrap();
1263
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1264
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1265
    let url = format!("{}/andy/demo", h.base);
1266
    let work = tempfile::tempdir().unwrap();
1267
    let (w, u) = (work.path().to_path_buf(), url.clone());
1268
    let client = tokio::task::spawn_blocking(move || {
1269
        let mut c = Repo::init(&w).unwrap();
1270
        c.config.set("remote.origin.url", &u).unwrap();
1271
        c.config.set("remote.origin.token", "site").unwrap();
1272
        c.save_config().unwrap();
1273
        write(&w, "a.txt", b"a\n");
1274
        c.commit("a", &[]).unwrap();
1275
        assert!(c.push("origin", false).unwrap()[0].ok);
1276
        for b in ["develop", "feature/x", "stray"] {
1277
            c.bookmark_create(b, None).unwrap();
1278
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1279
        }
1280
        // A pushed deletion.
1281
        let r = c.push_delete("origin", "feature/x").unwrap();
1282
        assert!(r[0].ok, "{r:?}");
1283
        c
1284
    })
1285
    .await
1286
    .unwrap();
1287
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1288
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1289
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1290
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1291
    assert!(!anon.body.contains("/bookmarks/delete"));
1292
1293
    // The hub's default, not the repository's config, is protected: make
1294
    // develop the default, then main can go and develop cannot.
1295
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1296
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1297
    let client = tokio::task::spawn_blocking(move || {
1298
        let r = client.push_delete("origin", "develop").unwrap();
1299
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1300
        let r = client.push_delete("origin", "main").unwrap();
1301
        assert!(r[0].ok, "{r:?}");
1302
        client
1303
    })
1304
    .await
1305
    .unwrap();
1306
    drop(client);
1307
1308
    // On the web: a writer deletes stray; the default is refused.
1309
    let form = |b: &'static str| {
1310
        let (app, andy) = (app.clone(), andy.clone());
1311
        async move {
1312
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1313
            call(
1314
                &app,
1315
                "POST",
1316
                "/andy/demo/bookmarks/delete",
1317
                None,
1318
                Some(&andy),
1319
                None,
1320
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1321
            )
1322
            .await
1323
        }
1324
    };
1325
    let r = form("stray").await;
1326
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1327
    assert!(!r.body.contains(">stray<"));
1328
    let r = form("develop").await;
1329
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1330
    let r = form("nope").await;
1331
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1332
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1333
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1334
    // Anonymous visitors cannot.
1335
    assert_ne!(
1336
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1337
        StatusCode::OK
1338
    );
1339
}
1340
1341
/// A change signed by a key no account has linked says so, on its page
1342
/// and in the API (feedback 14).
1343
#[tokio::test(flavor = "multi_thread")]
1344
async fn changes_signed_by_unlinked_keys_say_so() {
1345
    let h = hub().await;
1346
    let app = &h.app;
1347
    let andy = call(
1348
        app,
1349
        "POST",
1350
        "/register",
1351
        None,
1352
        None,
1353
        None,
1354
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1355
    )
1356
    .await
1357
    .cookie
1358
    .unwrap();
1359
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1360
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1361
    let url = format!("{}/andy/demo", h.base);
1362
    let work = tempfile::tempdir().unwrap();
1363
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1364
    let hash = tokio::task::spawn_blocking(move || {
1365
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1366
        c.config.set("remote.origin.url", &u).unwrap();
1367
        c.config.set("remote.origin.token", "site").unwrap();
1368
        c.save_config().unwrap();
1369
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1370
        write(&w.join("r"), "a.txt", b"a\n");
1371
        let h = c.commit("signed by Ada", &[]).unwrap();
1372
        assert!(c.push("origin", false).unwrap()[0].ok);
1373
        h.to_hex()
1374
    })
1375
    .await
1376
    .unwrap();
1377
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1378
    assert_eq!(st, StatusCode::OK, "{v}");
1379
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1380
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1381
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1382
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1383
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1384
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1385
}
1386
1387
/// Function history (hub spec §6.6): the file page lists a file's
1388
/// functions, and a function's page lists exactly the changes to its lines.
1389
#[tokio::test(flavor = "multi_thread")]
1390
async fn a_function_has_its_own_history() {
1391
    let h = hub().await;
1392
    let app = &h.app;
1393
    let andy = call(
1394
        app,
1395
        "POST",
1396
        "/register",
1397
        None,
1398
        None,
1399
        None,
1400
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1401
    )
1402
    .await
1403
    .cookie
1404
    .unwrap();
1405
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1406
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1407
    let url = format!("{}/andy/demo", h.base);
1408
    let work = tempfile::tempdir().unwrap();
1409
    let w = work.path().to_path_buf();
1410
    tokio::task::spawn_blocking(move || {
1411
        let mut c = Repo::init(&w).unwrap();
1412
        c.config.set("remote.origin.url", &url).unwrap();
1413
        c.config.set("remote.origin.token", "site").unwrap();
1414
        c.save_config().unwrap();
1415
        let steps = [
1416
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1417
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1418
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1419
        ];
1420
        for (msg, text) in steps {
1421
            write(&w, "src/lib.rs", text.as_bytes());
1422
            c.commit(msg, &[]).unwrap();
1423
        }
1424
        assert!(c.push("origin", false).unwrap()[0].ok);
1425
    })
1426
    .await
1427
    .unwrap();
1428
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1429
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1430
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1431
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1432
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1433
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1434
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1435
    assert_ne!(bad.status, StatusCode::OK);
1436
}
1437
1438
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1439
/// dependency edges, linked cards.
1440
#[tokio::test(flavor = "multi_thread")]
1441
async fn a_bookmark_shows_as_swimlanes() {
1442
    let h = hub().await;
1443
    let app = &h.app;
1444
    let andy = call(
1445
        app,
1446
        "POST",
1447
        "/register",
1448
        None,
1449
        None,
1450
        None,
1451
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1452
    )
1453
    .await
1454
    .cookie
1455
    .unwrap();
1456
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1457
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1458
    let url = format!("{}/andy/demo", h.base);
1459
    let work = tempfile::tempdir().unwrap();
1460
    let w = work.path().to_path_buf();
1461
    tokio::task::spawn_blocking(move || {
1462
        let mut c = Repo::init(&w).unwrap();
1463
        c.config.set("remote.origin.url", &url).unwrap();
1464
        c.config.set("remote.origin.token", "site").unwrap();
1465
        c.save_config().unwrap();
1466
        // Two files edited independently: two lanes.
1467
        write(&w, "a.txt", b"a\n");
1468
        c.commit("add a", &[]).unwrap();
1469
        write(&w, "b.txt", b"b\n");
1470
        c.commit("add b", &[]).unwrap();
1471
        write(&w, "a.txt", b"a\na2\n");
1472
        c.commit("grow a", &[]).unwrap();
1473
        assert!(c.push("origin", false).unwrap()[0].ok);
1474
    })
1475
    .await
1476
    .unwrap();
1477
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1478
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1479
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1480
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1481
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1482
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1483
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1484
    assert_eq!(board.matches("<rect ").count(), 3);
1485
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1486
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1487
}
1488
1489
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1490
/// offers only what makes sense and rewrites nothing itself.
1491
#[tokio::test(flavor = "multi_thread")]
1492
async fn a_proposal_board_plans_squashes_and_rebases() {
1493
    let h = hub().await;
1494
    let app = &h.app;
1495
    let andy = call(
1496
        app,
1497
        "POST",
1498
        "/register",
1499
        None,
1500
        None,
1501
        None,
1502
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1503
    )
1504
    .await
1505
    .cookie
1506
    .unwrap();
1507
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1508
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1509
    let url = format!("{}/andy/demo", h.base);
1510
    let work = tempfile::tempdir().unwrap();
1511
    let w = work.path().to_path_buf();
1512
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1513
        let mut c = Repo::init(&w).unwrap();
1514
        c.config.set("remote.origin.url", &url).unwrap();
1515
        c.config.set("remote.origin.token", "site").unwrap();
1516
        c.save_config().unwrap();
1517
        write(&w, "a.txt", b"a\n");
1518
        let base = c.commit("base", &[]).unwrap();
1519
        assert!(c.push("origin", false).unwrap()[0].ok);
1520
        c.bookmark_create("feature", None).unwrap();
1521
        c.bookmark_switch("feature", false).unwrap();
1522
        write(&w, "a.txt", b"a\nfirst\n");
1523
        let first = c.commit("first", &[]).unwrap();
1524
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1525
        let second = c.commit("second", &[]).unwrap();
1526
        write(&w, "b.txt", b"apart\n");
1527
        let apart = c.commit("apart", &[]).unwrap();
1528
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1529
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1530
    })
1531
    .await
1532
    .unwrap();
1533
    // No proposal yet: the board is read-only.
1534
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1535
    assert!(!board.contains("data-plan="));
1536
    let (st, _) = api(
1537
        app,
1538
        "POST",
1539
        "/api/v1/repos/andy/demo/proposals",
1540
        Some("site"),
1541
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1542
    )
1543
    .await;
1544
    assert!(st.is_success(), "{st}");
1545
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1546
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1547
    let csrf = csrf_of(&board);
1548
    let plan = |c: &str, t: &str| {
1549
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1550
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1551
        async move {
1552
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1553
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1554
        }
1555
    };
1556
    let kinds = |v: &serde_json::Value| {
1557
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1558
    };
1559
    // second already depends on first: squash, no rebase.
1560
    let v = plan(&second, &first).await;
1561
    assert_eq!(kinds(&v), ["squash"], "{v}");
1562
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
1563
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
1564
    // apart is independent of second: either.
1565
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1566
    // first under second: nothing (second depends on first).
1567
    assert!(plan(&first, &second).await["error"].is_string());
1568
    // What has landed on main is not rearranged.
1569
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1570
}
1571
1572
/// Issues and proposals share a number space, so every number says what it
1573
/// is, and the chain of work shows from both ends (hub spec §8).
1574
#[tokio::test(flavor = "multi_thread")]
1575
async fn proposals_and_issues_show_their_chain() {
1576
    let h = hub().await;
1577
    let app = &h.app;
1578
    let andy = call(
1579
        app,
1580
        "POST",
1581
        "/register",
1582
        None,
1583
        None,
1584
        None,
1585
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1586
    )
1587
    .await
1588
    .cookie
1589
    .unwrap();
1590
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1591
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1592
    let url = format!("{}/andy/demo", h.base);
1593
    let work = tempfile::tempdir().unwrap();
1594
    let w = work.path().to_path_buf();
1595
    tokio::task::spawn_blocking(move || {
1596
        let mut c = Repo::init(&w).unwrap();
1597
        c.config.set("remote.origin.url", &url).unwrap();
1598
        c.config.set("remote.origin.token", "site").unwrap();
1599
        c.save_config().unwrap();
1600
        write(&w, "a.txt", b"a\n");
1601
        c.commit("base", &[]).unwrap();
1602
        assert!(c.push("origin", false).unwrap()[0].ok);
1603
        c.bookmark_create("feature", None).unwrap();
1604
        c.bookmark_switch("feature", false).unwrap();
1605
        write(&w, "a.txt", b"a\nfixed\n");
1606
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1607
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1608
    })
1609
    .await
1610
    .unwrap();
1611
    for title in ["Slow start", "Crash on save"] {
1612
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1613
        assert!(st.is_success());
1614
    }
1615
    let (st, v) = api(
1616
        app,
1617
        "POST",
1618
        "/api/v1/repos/andy/demo/proposals",
1619
        Some("site"),
1620
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1621
    )
1622
    .await;
1623
    assert!(st.is_success(), "{st} {v}");
1624
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1625
1626
    // The proposal names its kind, links its references by kind, and shows
1627
    // the chain: the issues it closes (description and changes) → it → main.
1628
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1629
    assert!(p.contains(">proposal #3</small>"), "header");
1630
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1631
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1632
    let chain = &chain[..chain.find("</p>").unwrap()];
1633
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1634
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1635
    }
1636
    assert!(p.contains("<h3>Closes</h3>"));
1637
1638
    // The issue shows the proposal that closes it, and names its own kind.
1639
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1640
    assert!(i.contains(">issue #1</small>"));
1641
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1642
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
1643
    // The conversation is a timeline with avatars; editing sits with the
1644
    // content, not in the sidebar, and labels and projects are editable.
1645
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1646
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1647
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1648
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1649
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1650
    assert!(st.is_success(), "{st}");
1651
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1652
    assert!(
1653
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1654
        "the owner's projects to add to, in a menu"
1655
    );
1656
    let csrf = csrf_of(&p);
1657
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1658
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1659
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1660
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1661
        .await;
1662
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1663
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1664
1665
    // Closed by the proposal's change, not its description: still shown.
1666
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1667
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1668
    assert!(chain.contains("proposal #3"), "{chain}");
1669
}
1670
1671
/// What the hub is: its version and build, and the libraries it is built on,
1672
/// on /about, in the API and in /health (hub spec §15).
1673
#[tokio::test(flavor = "multi_thread")]
1674
async fn the_hub_says_what_version_it_is() {
1675
    let h = hub().await;
1676
    let app = &h.app;
1677
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1678
    assert_eq!(st, StatusCode::OK);
1679
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1680
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1681
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1682
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1683
    assert!(health.contains("\"build\""), "{health}");
1684
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1685
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
1686
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1687
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1688
    assert!(about.contains("href=\"/about\""), "the footer links here");
1689
}
1690
1691
#[tokio::test(flavor = "multi_thread")]
1692
async fn device_sign_in() {
1693
    let h = hub().await;
1694
    let app = &h.app;
1695
    let r = call(
1696
        app,
1697
        "POST",
1698
        "/register",
1699
        None,
1700
        None,
1701
        None,
1702
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1703
    )
1704
    .await;
1705
    let andy = r.cookie.unwrap();
1706
1707
    // An unknown scope is refused.
1708
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1709
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1710
1711
    // The app asks for a code and polls; nobody has approved it yet.
1712
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1713
    assert_eq!(st, StatusCode::OK, "{v}");
1714
    let device = v["device_code"].as_str().unwrap().to_string();
1715
    let user = v["user_code"].as_str().unwrap().to_string();
1716
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1717
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1718
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1719
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1720
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1721
    assert_eq!(v["error"], "slow_down", "polled too soon");
1722
1723
    // The user approves it on the web, allowing less than it asked for.
1724
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1725
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1726
    let csrf = csrf_of(&page.body);
1727
    let r =
1728
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1729
            .await;
1730
    // oxygenhub#83: the answer page says it is done, with no code form.
1731
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1732
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
1733
1734
    // The next poll gets a token with what was allowed, once.
1735
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1736
    assert_eq!(st, StatusCode::OK, "{v}");
1737
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1738
    let token = v["access_token"].as_str().unwrap().to_string();
1739
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1740
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1741
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1742
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1743
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1744
    assert!(tokens.body.contains("device: Phone app"));
1745
    // oxygenhub#70: a device's token expires, and each use renews it.
1746
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
1747
1748
    // The token can revoke itself (oxy auth logout), and is then refused.
1749
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1750
    assert_eq!(st, StatusCode::NO_CONTENT);
1751
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1752
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1753
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1754
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1755
1756
    // A denied code says so.
1757
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1758
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1759
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1760
    let csrf = csrf_of(&page.body);
1761
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1762
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1763
    assert_eq!(v["error"], "access_denied");
1764
1765
    // A code the app gave up on (#304) is gone at once: the page no longer
1766
    // takes it, and the app's poll says so.
1767
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Cancelled"}"#)).await;
1768
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1769
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1770
    assert_eq!(st, StatusCode::NO_CONTENT);
1771
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1772
    let csrf = csrf_of(&page.body);
1773
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve"))).await;
1774
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1775
    assert_eq!(v["error"], "expired_token", "{v}");
1776
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1777
    assert_eq!(st, StatusCode::NO_CONTENT, "again: still fine");
1778
1779
    // Signed out, the page asks for a sign-in first.
1780
    let r = call(app, "GET", "/device", None, None, None, None).await;
1781
    assert!(r.status.is_redirection(), "{}", r.status);
1782
}
1783
1784
#[tokio::test(flavor = "multi_thread")]
1785
async fn api_assistants_at_each_level() {
1786
    let h = hub().await;
1787
    let app = &h.app;
1788
    let andy = call(
1789
        app,
1790
        "POST",
1791
        "/register",
1792
        None,
1793
        None,
1794
        None,
1795
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1796
    )
1797
    .await
1798
    .cookie
1799
    .unwrap();
1800
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1801
    let csrf = csrf_of(&page.body);
1802
    let mint = |scopes: &'static str| {
1803
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1804
        async move {
1805
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1806
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1807
        }
1808
    };
1809
    let admin = mint("scopes=repo%3Aadmin").await;
1810
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1811
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1812
    // A stand-in endpoint with no model list: any model name is taken.
1813
    let router = axum::Router::new().route(
1814
        "/v1/chat/completions",
1815
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1816
    );
1817
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1818
    let port = listener.local_addr().unwrap().port();
1819
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1820
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1821
1822
    // The site's, by its administrator; the repository's, by its admin.
1823
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1824
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1825
    assert_eq!(st, StatusCode::OK, "{v}");
1826
    assert_eq!(v["ok"], "Gemini added");
1827
    let body =
1828
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1829
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1830
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1831
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1832
    assert_eq!(st, StatusCode::OK, "{v}");
1833
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1834
    assert_eq!(st, StatusCode::OK);
1835
    let names: Vec<(&str, &str, bool)> = v
1836
        .as_array()
1837
        .unwrap()
1838
        .iter()
1839
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1840
        .collect();
1841
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1842
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1843
    // Changing it keeps the token when none is given.
1844
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1845
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1846
    assert_eq!(v["ok"], "Claude updated");
1847
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1848
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1849
    // Prompts: the site's is inherited by the repository.
1850
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1851
    assert_eq!(st, StatusCode::OK);
1852
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1853
    assert_eq!(v["prompt"], "Rust.");
1854
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1855
    // Removed.
1856
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1857
    assert_eq!(st, StatusCode::NO_CONTENT);
1858
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1859
    assert_eq!(st, StatusCode::NOT_FOUND);
1860
}