OXYGENHUB
◆ v0.9.2 oxygenhub / crates / hub / tests / browse.rs
20.6 KiB · Rust · last changed A mistyped address shows the not-found page (closes #294) 11 days ago source blame history raw
1
//! End to end: a hub in a temporary data directory, a real `oxy` client
2
//! pushing over the wire protocol, and every milestone 0.1 page fetched.
3
4
use axum::body::Body;
5
use axum::http::{Request, StatusCode};
6
use http_body_util::BodyExt;
7
use oxy_core::repo::Repo;
8
use oxygenhub::config::Config;
9
use oxygenhub::repos::RepoName;
10
use oxygenhub::{db, Shared};
11
use std::path::Path;
12
use tower::ServiceExt;
13
14
/// Point `$OXY_HOME` at a throwaway directory so the client's identity and
15
/// configuration never touch the developer's.
16
fn hermetic() {
17
    static ONCE: std::sync::Once = std::sync::Once::new();
18
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
19
    ONCE.call_once(|| {
20
        let d = tempfile::tempdir().unwrap();
21
        std::env::set_var("OXY_HOME", d.path());
22
        DIR.set(d).ok();
23
    });
24
}
25
26
fn write(root: &Path, rel: &str, content: &[u8]) {
27
    let p = root.join(rel);
28
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
29
    std::fs::write(p, content).unwrap();
30
}
31
32
struct Hub {
33
    app: Shared,
34
    base: String,
35
    _dir: tempfile::TempDir,
36
}
37
38
/// Held by every clone here and while OXY_TOKEN is set: the variable is the
39
/// whole process's, and a clone in another test sent it (oxygenhub#247).
40
static ENV: std::sync::Mutex<()> = std::sync::Mutex::new(());
41
42
fn clone(url: &str, dir: &Path) -> Result<Repo, oxy_core::repo::RepoError> {
43
    let _env = ENV.lock().unwrap_or_else(|p| p.into_inner());
44
    Repo::clone(url, dir)
45
}
46
47
async fn hub(push_tokens: Vec<String>) -> Hub {
48
    hermetic();
49
    let dir = tempfile::tempdir().unwrap();
50
    let mut config = Config::load(dir.path()).unwrap();
51
    // The first account's setup code (oxygenhub#245).
52
    config.registration.setup_code = "test-setup".into();
53
    config.auth.push_tokens = push_tokens;
54
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
55
    let port = listener.local_addr().unwrap().port();
56
    config.server.base_url = format!("http://127.0.0.1:{port}");
57
    let app = oxygenhub::build(config).await.unwrap();
58
    let router = oxygenhub::router(app.clone());
59
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
60
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
61
}
62
63
async fn get(app: &Shared, path: &str) -> (StatusCode, String) {
64
    let res = oxygenhub::router(app.clone()).oneshot(Request::get(path).body(Body::empty()).unwrap()).await.unwrap();
65
    let status = res.status();
66
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
67
    (status, String::from_utf8_lossy(&bytes).into_owned())
68
}
69
70
async fn page(app: &Shared, path: &str) -> String {
71
    let (status, body) = get(app, path).await;
72
    assert_eq!(status, StatusCode::OK, "{path}: {}", body.lines().find(|l| l.contains("lead")).unwrap_or(""));
73
    body
74
}
75
76
/// Push a small history from a client: two changes on main, a second
77
/// bookmark, a tag.
78
fn populate(url: &str, work: &Path) -> (Repo, String, String) {
79
    // The hosted repository is unbound until the first push, so it cannot
80
    // be cloned yet: start locally and push, as moving an existing
81
    // repository to the hub does.
82
    assert!(clone(url, &work.join("early")).err().unwrap().to_string().contains("unbound"));
83
    let mut client = Repo::init(work).unwrap();
84
    // A signing identity, so changes and the tag travel signed.
85
    client.create_identity("Test Author", "[email protected]", oxy_core::repo::IdentityScope::User).unwrap();
86
    client.config.set("remote.origin.url", url).unwrap();
87
    client.config.set("remote.origin.token", "site-token").unwrap();
88
    client.config.set("core.sign", "change").unwrap();
89
    client.save_config().unwrap();
90
    write(work, "README.md", b"# Demo\n\nSee [docs](docs/guide.md).\n");
91
    write(work, "src/main.rs", b"fn main() {\n    println!(\"hi\");\n}\n");
92
    write(work, "docs/guide.md", b"# Guide\n");
93
    client.snapshot("test").unwrap();
94
    let c1 = client.commit("Initial import", &[]).unwrap();
95
    write(work, "src/main.rs", b"fn main() {\n    println!(\"hello\");\n}\n\nfn two() {}\n");
96
    client.snapshot("test").unwrap();
97
    let c2 = client.commit("Greet properly\n\nAlso adds two().", &[]).unwrap();
98
    client.tag_create("v0.1", &[c2], "First tag").unwrap();
99
    client.bookmark_create("feature", Some(&[c1])).unwrap();
100
    let results = client.push("origin", false).unwrap();
101
    assert!(results.iter().all(|r| r.ok), "{results:?}");
102
    let results = client.push_bookmark("origin", "feature", false).unwrap();
103
    assert!(results.iter().all(|r| r.ok), "{results:?}");
104
    // Bound now: a clone shares the id.
105
    let clone = clone(url, &work.join("clone")).unwrap();
106
    assert_eq!(clone.id().unwrap(), client.id().unwrap());
107
    (client, c1.to_hex(), c2.to_hex())
108
}
109
110
#[tokio::test(flavor = "multi_thread")]
111
async fn create_push_and_browse() {
112
    let h = hub(vec!["site-token".into()]).await;
113
    let name = RepoName::parse("andy/demo").unwrap();
114
    h.app.repos.create(&name, None).unwrap();
115
    db::repos::create(&h.app.db, "andy", "demo", "A demo", hub_api::Visibility::Public).await.unwrap();
116
    let work = tempfile::tempdir().unwrap();
117
    let (_client, c1, c2) = populate(&format!("{}/andy/demo", h.base), work.path());
118
119
    // Help, filled in for this hub (hub spec §6.3).
120
    // #294: an address the router matches but cannot read (a project or
121
    // issue number that is not one) is the not-found page, not a parse error.
122
    for bad in ["/projects/andy/metalgear2", "/andy/demo/issue/abc", "/andy/demo/proposal/x1"] {
123
        let (status, body) = get(&h.app, bad).await;
124
        assert_eq!(status, StatusCode::NOT_FOUND, "{bad}");
125
        assert!(body.contains("There is nothing at this address.") && !body.contains("Cannot parse"), "{bad}: {body}");
126
    }
127
    let help = page(&h.app, "/help").await;
128
    assert!(help.contains(&format!("oxy remote add hub {}/OWNER/REPOSITORY", h.base)), "commands carry this hub's address");
129
    assert!(help.contains(&format!("oxy clone {}/OWNER/REPOSITORY", h.base)));
130
    assert!(help.contains(&format!("curl -fsSL {}/.well-known/oxyhub-key -o hub.identity", h.base)), "the delegation recipe");
131
    assert!(!help.contains("oxyhub-ca.pem"), "no certificate step for a hub without a self-signed certificate");
132
    for id in ["start", "identity", "push", "clone", "proposals", "delegate", "agents", "flow", "keys", "glossary"] {
133
        assert!(help.contains(&format!("id=\"{id}\"")) && help.contains(&format!("href=\"#{id}\"")), "section {id}");
134
    }
135
    // oxygenhub#287: AI identities, with this hub in the commands.
136
    assert!(help.contains("oh agent grant claude") && help.contains(&format!("oxy auth grant {}", h.base)), "agent grants");
137
    assert!(help.contains("oxy policy grant-subject agent:claude@OWNER --issuer hub.identity"), "subject grants");
138
    assert!(help.contains("via agent:claude@OWNER"), "how agent work shows");
139
    assert!(help.contains("<strong>bookmark</strong>") && help.contains("<strong>proposal</strong>"), "glossary");
140
    assert!(home_has_help(&page(&h.app, "/explore").await), "linked from every page");
141
142
    // Front page and owner page list it.
143
    let home = page(&h.app, "/").await;
144
    assert!(home.contains("/andy/demo"), "{home}");
145
    assert!(page(&h.app, "/andy").await.contains("demo"));
146
    assert_eq!(get(&h.app, "/nobody").await.0, StatusCode::NOT_FOUND);
147
148
    // Overview: tree, README rendered with rebased links, clone URL, counts.
149
    let o = page(&h.app, "/andy/demo").await;
150
    assert!(o.contains("src"), "tree entries");
151
    assert!(o.contains("href=\"/andy/demo/file/main/docs/guide.md\""), "README link rebased: {o}");
152
    assert!(o.contains(&format!("oxy clone {}/andy/demo", h.base)));
153
    assert!(o.contains("2 changes"));
154
    // Overview: clone popover, contributors, languages, visibility badge.
155
    assert!(o.contains("class=\"clone-pop\"") && o.contains("value=\"oxy clone "), "clone behind a button");
156
    // The Code button also offers the default bookmark as a zip.
157
    assert!(o.contains("&lt;&gt;</span> Code</summary>"), "a Code button");
158
    assert!(o.contains("href=\"/andy/demo/archive?ref=main&amp;format=zip\" download>"), "a zip download: {o}");
159
    let (status, zip) = get(&h.app, "/andy/demo/archive?ref=main&format=zip").await;
160
    assert_eq!(status, StatusCode::OK);
161
    assert!(zip.starts_with("PK"), "a zip archive");
162
    assert!(o.contains("<h3>Contributors") && o.contains("<h3>Languages</h3>") && o.contains("<strong>Rust</strong>"), "{o}");
163
    assert!(o.contains("class=\"vis vis-public\""));
164
    // Landmarks, skip link, current tab (hub spec §6.13).
165
    assert!(o.contains("<a class=\"skip\" href=\"#main\">") && o.contains("<main id=\"main\""));
166
    assert!(o.contains("aria-label=\"Site\"") && o.contains("aria-label=\"Repository\"") && o.contains("aria-label=\"Account\""));
167
    assert!(o.contains("class=\"on\" aria-current=\"page\">Code</a>"), "the current tab is announced");
168
    assert!(o.contains("v0.1"));
169
    assert!(o.contains("feature"));
170
171
    // Tree at a bookmark, a tag and a change; file with highlighting; raw; blame.
172
    let t = page(&h.app, "/andy/demo/tree/main/src").await;
173
    assert!(t.contains("main.rs"));
174
    // A ref's root is the overview with it chosen, side bar and all (#191).
175
    assert_eq!(get(&h.app, "/andy/demo/tree/v0.1").await.0, StatusCode::SEE_OTHER);
176
    let at_tag = page(&h.app, "/andy/demo?at=v0.1").await;
177
    assert!(at_tag.contains("README.md") && at_tag.contains("class=\"ref-pick\"") && at_tag.contains("side cards"), "{at_tag}");
178
    assert!(at_tag.contains("href=\"/andy/demo?at=v0.1\" class=\"on\""), "the tag is the one chosen");
179
    assert!(page(&h.app, &format!("/andy/demo?at={}", &c1[..10])).await.contains("README.md"));
180
    // A whole hash shows its two ends, the rest in a tip (#198).
181
    let at_hash = page(&h.app, &format!("/andy/demo?at={c1}")).await;
182
    let ends = format!("{}…{}", &c1[..8], &c1[c1.len() - 8..]);
183
    assert!(at_hash.contains(&format!("data-full=\"{c1}\"")) && at_hash.contains(&format!(">{ends}</span>")), "{at_hash}");
184
    assert_eq!(get(&h.app, "/andy/demo/tree/main/nope").await.0, StatusCode::NOT_FOUND);
185
    let (hits_before, _, _) = oxygenhub::render::highlight::cache_stats();
186
    let f = page(&h.app, "/andy/demo/file/main/src/main.rs").await;
187
    let again = page(&h.app, "/andy/demo/file/main/src/main.rs").await;
188
    assert!(oxygenhub::render::highlight::cache_stats().0 > hits_before, "the second view is served from the highlight cache");
189
    assert_eq!(f.split("<table").nth(1), again.split("<table").nth(1), "and renders the same");
190
    assert!(f.contains("sy-storage sy-type sy-function"), "highlighted: {f}");
191
    assert!(f.contains("id=\"L5\""));
192
    assert!(f.contains("Rust"));
193
    let (status, raw) = get(&h.app, "/andy/demo/file/main/src/main.rs?plain=1").await;
194
    assert_eq!(status, StatusCode::OK);
195
    assert_eq!(raw, "fn main() {\n    println!(\"hello\");\n}\n\nfn two() {}\n");
196
    let b = page(&h.app, "/andy/demo/file/main/src/main.rs?blame=1").await;
197
    assert!(b.contains(&c1[..8]) && b.contains(&c2[..8]), "both changes blamed: {b}");
198
    // Sidebar, permalink, blame shading and "blame before this change" (hub spec §6.6).
199
    assert!(f.contains("class=\"file-side\""), "sidebar");
200
    assert!(f.contains("href=\"/andy/demo/tree/main/docs\""), "sibling directory listed");
201
    let here = f.split("class=\"here\" aria-current=\"page\">").nth(1).unwrap_or("");
202
    assert!(here.trim_start().starts_with("<a href=\"/andy/demo/file/main/src/main.rs\""), "the file marked");
203
    assert!(f.contains(&format!("data-permalink=\"/andy/demo/file/{c2}/src/main.rs\"")), "permalink at the head");
204
    assert!(b.contains(&format!("data-permalink=\"/andy/demo/file/{c2}/src/main.rs?blame=1\"")));
205
    assert!(b.contains("blame age-0") && b.contains("blame age-9"), "oldest and newest shaded");
206
    assert!(b.contains(&format!("href=\"/andy/demo/file/{c1}/src/main.rs?blame=1#L")), "the state before c2 is c1");
207
    assert_eq!(b.matches("class=\"before\"").count(), b.matches("blame age-9").count(), "c1 has no dependencies, so no link");
208
    let before = page(&h.app, &format!("/andy/demo/file/{c1}/src/main.rs?blame=1")).await;
209
    assert!(before.contains(&c1[..8]) && !before.contains(&c2[..8]), "blamed in c1's state");
210
    // States: heads joined with +, in any order; not a change otherwise.
211
    let (lo, hi) = if c1 < c2 { (&c1, &c2) } else { (&c2, &c1) };
212
    assert!(page(&h.app, &format!("/andy/demo/tree/{hi}+{lo}/src"))
213
        .await
214
        .contains(&format!("data-permalink=\"/andy/demo/tree/{lo}+{hi}/src\"")));
215
    assert_ne!(get(&h.app, &format!("/andy/demo/tree/{c1}+{}", &c2[..12])).await.0, StatusCode::OK, "state heads are full hashes");
216
    let md = page(&h.app, "/andy/demo/file/main/README.md").await;
217
    assert!(md.contains("<h1>Demo</h1>"), "markdown rendered");
218
    // Last-change JSON for tree rows.
219
    let (status, json) = get(&h.app, "/andy/demo/last/main?paths=README.md,src").await;
220
    assert_eq!(status, StatusCode::OK);
221
    assert!(json.contains("Initial import") && json.contains("Greet properly"), "{json}");
222
223
    // History with graph rows, filtered by path; change page with diff; compare.
224
    let hist = page(&h.app, "/andy/demo/changes/main").await;
225
    assert!(hist.contains("Greet properly") && hist.contains("Initial import"));
226
    assert!(hist.contains("<circle"), "graph drawn");
227
    assert!(hist.contains("lbl-tag") && hist.contains("v0.1"), "tag label on its head");
228
    let by_path = page(&h.app, "/andy/demo/changes/main?path=README.md").await;
229
    assert!(by_path.contains("Initial import") && !by_path.contains("Greet properly"));
230
    let c = page(&h.app, &format!("/andy/demo/change/{c2}")).await;
231
    assert!(c.contains("Also adds two()"), "body shown");
232
    assert!(c.contains("+fn two() {}") || c.contains("fn two() {}"), "diff shown: {c}");
233
    assert!(c.contains("class=\"add\"") && c.contains("class=\"del\""));
234
    assert!(c.contains(&c1[..12]), "dependency listed");
235
    assert!(page(&h.app, &format!("/andy/demo/change/{}", &c2[..8])).await.contains("Greet properly"));
236
    let cmp = page(&h.app, "/andy/demo/compare/feature...main").await;
237
    assert!(cmp.contains("1 change") && cmp.contains("Greet properly"));
238
    assert_eq!(get(&h.app, "/andy/demo/compare/feature").await.0, StatusCode::BAD_REQUEST);
239
    // Pickers, swap and the /compare form (hub spec §6.3).
240
    assert!(
241
        cmp.contains("<datalist id=\"compare-refs\">")
242
            && cmp.contains("<option value=\"feature\">bookmark</option>")
243
            && cmp.contains("<option value=\"v0.1\">tag</option>")
244
    );
245
    assert!(cmp.contains("href=\"/andy/demo/compare/main...feature\""), "swap");
246
    assert!(!cmp.contains("Propose this"), "anonymous viewers cannot propose");
247
    let redirect = |path: &'static str| {
248
        let app = h.app.clone();
249
        async move {
250
            let res = oxygenhub::router(app).oneshot(Request::get(path).body(Body::empty()).unwrap()).await.unwrap();
251
            (res.status(), res.headers().get("location").and_then(|v| v.to_str().ok()).unwrap_or("").to_string())
252
        }
253
    };
254
    let (st, loc) = redirect("/andy/demo/compare").await;
255
    assert!(st.is_redirection() && loc == "/andy/demo/compare/main...feature", "the newest other bookmark against the default: {loc}");
256
    let (_, loc) = redirect("/andy/demo/compare?base=v0.1&head=+feature+").await;
257
    assert_eq!(loc, "/andy/demo/compare/v0.1...feature");
258
259
    // Bookmarks, tags, conflicts (none), trust (no policy), pushes.
260
    let bm = page(&h.app, "/andy/demo/bookmarks").await;
261
    assert!(bm.contains("feature") && bm.contains("default"));
262
    let tags = page(&h.app, "/andy/demo/tags").await;
263
    assert!(tags.contains("v0.1") && tags.contains("First tag"));
264
    // The bar (#254): Tags is Releases' second view and in the More menu;
265
    // the less used pages sit in More, the outputs in Artifacts; Projects
266
    // and Conflicts are off the bar.
267
    assert!(tags.contains("href=\"/andy/demo/releases\" class=\"on\" aria-current=\"page\">Releases</a>"), "{tags}");
268
    assert!(tags.contains("href=\"/andy/demo/tags\" class=\"on\" aria-current=\"page\">tags</a>"), "the sub-tab");
269
    let more = &tags[tags.find(">More</summary>").expect("the More menu")..];
270
    let more = &more[..more.find("</details>").unwrap()];
271
    for p in ["bookmarks", "tags", "trust", "pushes", "conflicts"] {
272
        assert!(more.contains(&format!("href=\"/andy/demo/{p}\"")), "More has {p}: {more}");
273
    }
274
    let artifacts = &tags[tags.find(">Artifacts</summary>").expect("the Artifacts menu")..];
275
    let artifacts = &artifacts[..artifacts.find("</details>").unwrap()];
276
    for p in ["releases", "artifacts", "images", "terraform"] {
277
        assert!(artifacts.contains(&format!("href=\"/andy/demo/{p}\"")), "Artifacts has {p}: {artifacts}");
278
    }
279
    assert!(!tags.contains("project boards\">Projects</a>"), "Projects is not a repository tab");
280
    let releases = page(&h.app, "/andy/demo/releases").await;
281
    assert!(releases.contains("href=\"/andy/demo/tags\">tags</a>"), "{releases}");
282
    for p in ["artifacts", "images", "terraform"] {
283
        let body = page(&h.app, &format!("/andy/demo/{p}")).await;
284
        assert!(body.contains("<summary class=\"on\">Artifacts</summary>"), "{p}: {body}");
285
    }
286
    assert!(page(&h.app, "/andy/demo/conflicts").await.contains("No bookmark carries a conflict"));
287
    let trust = page(&h.app, "/andy/demo/trust").await;
288
    assert!(trust.contains("No trust policy") && trust.contains(&h.app.hub_key.key.to_hex()));
289
    assert!(trust.contains("2 signed"), "signed changes verified on the host: {trust}");
290
    assert!(c.contains("signed by Test Author"), "change page shows the signer");
291
    let pushes = page(&h.app, "/andy/demo/pushes").await;
292
    assert!(pushes.contains("accepted") && pushes.contains("main"), "{pushes}");
293
    assert!(pushes.contains("<td>2</td>") && pushes.contains("<code title="), "two changes imported and the state shown: {pushes}");
294
295
    // API and small endpoints.
296
    let (_, repos) = get(&h.app, "/api/v1/repos").await;
297
    assert!(repos.contains("\"name\":\"demo\""));
298
    let (_, bms) = get(&h.app, "/api/v1/repos/andy/demo/bookmarks").await;
299
    assert!(bms.contains("\"default\":true"));
300
    let (status, key) = get(&h.app, "/.well-known/oxyhub-key").await;
301
    assert_eq!(status, StatusCode::OK);
302
    assert!(!key.is_empty());
303
    assert!(get(&h.app, "/health").await.1.contains("\"ok\":true"));
304
    assert_eq!(get(&h.app, "/.well-known/oxyhub-ca.pem").await.0, StatusCode::NOT_FOUND, "no self-signed certificate configured");
305
    assert_eq!(get(&h.app, "/style.css").await.0, StatusCode::OK);
306
    assert_eq!(get(&h.app, "/static/fonts/Barlow-400.woff2").await.0, StatusCode::OK);
307
    assert_eq!(get(&h.app, "/andy/demo/oxy/v1/nothing").await.0, StatusCode::NOT_FOUND);
308
}
309
310
#[tokio::test(flavor = "multi_thread")]
311
async fn private_repositories_and_push_tokens() {
312
    let h = hub(vec!["s3cret".into()]).await;
313
    for (name, vis) in [("pub", hub_api::Visibility::Public), ("priv", hub_api::Visibility::Private)] {
314
        // `priv` is created bound so it can be cloned while still empty.
315
        let id = if name == "priv" { Some([7u8; 16]) } else { None };
316
        h.app.repos.create(&RepoName::parse(&format!("andy/{name}")).unwrap(), id).unwrap();
317
        db::repos::create(&h.app.db, "andy", name, "", vis).await.unwrap();
318
    }
319
    // The private one is invisible on pages and to anonymous clients.
320
    assert_eq!(get(&h.app, "/andy/priv").await.0, StatusCode::NOT_FOUND);
321
    assert!(!page(&h.app, "/").await.contains("priv"));
322
    assert!(clone(&format!("{}/andy/priv", h.base), &tempfile::tempdir().unwrap().path().join("x")).is_err());
323
    // Anonymous push to the public one is refused; with the token it lands.
324
    let work = tempfile::tempdir().unwrap();
325
    let mut client = Repo::init(work.path()).unwrap();
326
    client.config.set("remote.origin.url", &format!("{}/andy/pub", h.base)).unwrap();
327
    write(work.path(), "a.txt", b"a\n");
328
    client.snapshot("test").unwrap();
329
    client.commit("a", &[]).unwrap();
330
    assert!(client.push("origin", false).is_err());
331
    client.config.set("remote.origin.token", "s3cret").unwrap();
332
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
333
    // With the token, the private repository can be cloned too.
334
    let priv_dir = tempfile::tempdir().unwrap();
335
    let ok = {
336
        let _env = ENV.lock().unwrap_or_else(|p| p.into_inner());
337
        std::env::set_var("OXY_TOKEN", "s3cret");
338
        let ok = Repo::clone(&format!("{}/andy/priv", h.base), &priv_dir.path().join("p")).is_ok();
339
        std::env::remove_var("OXY_TOKEN");
340
        ok
341
    };
342
    assert!(ok, "a token reads a private repository until accounts exist");
343
    // The pushes log shows the accepted update; the front page shows activity.
344
    tokio::time::sleep(std::time::Duration::from_millis(100)).await;
345
    assert!(page(&h.app, "/andy/pub/pushes").await.contains("accepted"));
346
    assert!(page(&h.app, "/andy/pub").await.contains("1 change"));
347
}
348
349
fn home_has_help(page: &str) -> bool {
350
    page.contains("<a href=\"/help\">Help</a>")
351
}