OXYGENHUB
◆ v0.9.23 oxygenhub / crates / hub / tests / api.rs
99.7 KiB · Rust · last changed Board columns by API and oh, newest-run watch, close with a comment (closes #366, closes #367, closes #368) 1 day ago source blame history raw
b64e2537 Andy McCall ↶ 1
//! Milestone 0.5 end to end: the JSON API with scoped tokens, webhooks
2
//! delivered to a local receiver with signatures and retries, checks on a
3
//! projected state that gate landing, and the proposal event stream.
4
5
use axum::body::Body;
6
use axum::http::{header, Request, StatusCode};
7
use axum::routing::post;
8
use axum::Router;
9
use http_body_util::BodyExt;
10
use oxy_core::repo::Repo;
11
use oxygenhub::config::Config;
12
use oxygenhub::Shared;
13
use std::path::Path;
14
use std::sync::{Arc, Mutex};
15
use tower::ServiceExt;
16
17
fn hermetic() {
18
    static ONCE: std::sync::Once = std::sync::Once::new();
19
    static DIR: std::sync::OnceLock<tempfile::TempDir> = std::sync::OnceLock::new();
20
    ONCE.call_once(|| {
21
        let d = tempfile::tempdir().unwrap();
22
        std::env::set_var("OXY_HOME", d.path());
23
        DIR.set(d).ok();
24
    });
25
}
26
27
fn write(root: &Path, rel: &str, content: &[u8]) {
28
    let p = root.join(rel);
29
    std::fs::create_dir_all(p.parent().unwrap()).unwrap();
30
    std::fs::write(p, content).unwrap();
31
}
32
33
struct Hub {
34
    app: Shared,
35
    base: String,
36
    _dir: tempfile::TempDir,
37
}
38
39
async fn hub() -> Hub {
40
    hermetic();
41
    let dir = tempfile::tempdir().unwrap();
42
    let mut config = Config::load(dir.path()).unwrap();
c8684d44 Andy McCall 43
    // The first account's setup code (oxygenhub#245).
44
    config.registration.setup_code = "test-setup".into();
b64e2537 Andy McCall ↶ 45
    config.auth.push_tokens = vec!["site".into()];
46
    config.registration.mode = "open".into();
47
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
48
    let port = listener.local_addr().unwrap().port();
49
    config.server.base_url = format!("http://127.0.0.1:{port}");
9a777fec Andy McCall ↶ 50
    // The stand-in webhook and assistant servers listen on 127.0.0.1 (#219).
51
    config.outbound.allow = vec!["http://127.0.0.1".into()];
b64e2537 Andy McCall ↶ 52
    let app = oxygenhub::build(config).await.unwrap();
53
    let router = oxygenhub::router(app.clone());
54
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
55
    Hub { app, base: format!("http://127.0.0.1:{port}"), _dir: dir }
56
}
57
58
struct Res {
59
    status: StatusCode,
60
    body: String,
61
    cookie: Option<String>,
c7067c7b Andy McCall 62
    location: Option<String>,
b64e2537 Andy McCall ↶ 63
}
64
65
async fn call(
66
    app: &Shared,
67
    method: &str,
68
    path: &str,
69
    bearer: Option<&str>,
70
    cookie: Option<&str>,
71
    json: Option<&str>,
72
    form: Option<&str>,
73
) -> Res {
74
    let mut req = Request::builder().method(method).uri(path);
75
    if let Some(b) = bearer {
76
        req = req.header(header::AUTHORIZATION, format!("Bearer {b}"));
77
    }
78
    if let Some(c) = cookie {
79
        req = req.header(header::COOKIE, format!("oxyhub={c}"));
80
    }
81
    let body = if let Some(j) = json {
82
        req = req.header(header::CONTENT_TYPE, "application/json");
83
        Body::from(j.to_string())
84
    } else if let Some(f) = form {
85
        req = req.header(header::CONTENT_TYPE, "application/x-www-form-urlencoded");
86
        Body::from(f.to_string())
87
    } else {
88
        Body::empty()
89
    };
90
    let res = oxygenhub::router(app.clone()).oneshot(req.body(body).unwrap()).await.unwrap();
91
    let status = res.status();
92
    let cookie = res
93
        .headers()
94
        .get(header::SET_COOKIE)
95
        .and_then(|v| v.to_str().ok())
96
        .and_then(|v| v.split(';').next())
97
        .and_then(|kv| kv.split_once('='))
98
        .map(|(_, v)| v.to_string());
c7067c7b Andy McCall 99
    let location = res.headers().get(header::LOCATION).and_then(|v| v.to_str().ok()).map(String::from);
b64e2537 Andy McCall ↶ 100
    let bytes = res.into_body().collect().await.unwrap().to_bytes();
c7067c7b Andy McCall 101
    Res { status, body: String::from_utf8_lossy(&bytes).into_owned(), cookie, location }
b64e2537 Andy McCall ↶ 102
}
103
c7067c7b Andy McCall 104
/// A repository settings form's answer (#278): a redirect to the page that
105
/// holds the form, followed.
106
async fn settled(app: &Shared, r: Res, cookie: Option<&str>, page: &str) -> Res {
107
    assert_eq!(r.status, StatusCode::SEE_OTHER, "{}", r.body);
108
    let to = r.location.expect("a redirect");
109
    assert!(to.starts_with(&format!("{page}?")), "{to} is not {page}");
110
    call(app, "GET", &to, None, cookie, None, None).await
111
}
112
b64e2537 Andy McCall ↶ 113
async fn api(app: &Shared, method: &str, path: &str, bearer: Option<&str>, json: Option<&str>) -> (StatusCode, serde_json::Value) {
114
    let r = call(app, method, path, bearer, None, json, None).await;
115
    let v = serde_json::from_str(&r.body).unwrap_or(serde_json::Value::String(r.body.clone()));
116
    (r.status, v)
117
}
118
119
fn csrf_of(page: &str) -> String {
120
    let i = page.find("name=\"_csrf\" value=\"").expect("csrf field") + "name=\"_csrf\" value=\"".len();
121
    page[i..].split('"').next().unwrap().to_string()
122
}
123
124
/// A webhook receiver that records what it gets and fails the first time.
125
struct Receiver {
126
    url: String,
127
    seen: Arc<Mutex<Vec<(String, String, String)>>>,
128
    fail_first: Arc<Mutex<bool>>,
129
}
130
131
async fn receiver() -> Receiver {
132
    let seen: Arc<Mutex<Vec<(String, String, String)>>> = Arc::new(Mutex::new(vec![]));
133
    let fail_first = Arc::new(Mutex::new(true));
134
    let (s2, f2) = (seen.clone(), fail_first.clone());
135
    let router = Router::new().route(
136
        "/hook",
137
        post(move |headers: header::HeaderMap, body: String| {
138
            let (s2, f2) = (s2.clone(), f2.clone());
139
            async move {
140
                let event = headers.get("x-oxyhub-event").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
141
                let sig = headers.get("x-oxyhub-signature").and_then(|v| v.to_str().ok()).unwrap_or("").to_string();
142
                let mut f = f2.lock().unwrap();
143
                if *f {
144
                    *f = false;
145
                    return (StatusCode::INTERNAL_SERVER_ERROR, "flaky");
146
                }
147
                s2.lock().unwrap().push((event, sig, body));
148
                (StatusCode::OK, "ok")
149
            }
150
        }),
151
    );
152
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
153
    let port = listener.local_addr().unwrap().port();
154
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
155
    Receiver { url: format!("http://127.0.0.1:{port}/hook"), seen, fail_first }
156
}
157
158
#[tokio::test(flavor = "multi_thread")]
159
async fn api_webhooks_and_checks() {
160
    let h = hub().await;
161
    let app = &h.app;
162
    // Accounts and tokens through the pages.
c8684d44 Andy McCall 163
    let r = call(
164
        app,
165
        "POST",
166
        "/register",
167
        None,
168
        None,
169
        None,
170
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
171
    )
172
    .await;
b64e2537 Andy McCall ↶ 173
    let andy = r.cookie.unwrap();
c8684d44 Andy McCall 174
    let r = call(
175
        app,
176
        "POST",
177
        "/register",
178
        None,
179
        None,
180
        None,
181
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
182
    )
183
    .await;
b64e2537 Andy McCall ↶ 184
    let bob = r.cookie.unwrap();
185
    let mint = |cookie: String, scopes: &'static str| {
186
        let app = app.clone();
187
        async move {
188
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
189
            let csrf = csrf_of(&page.body);
190
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
191
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
192
        }
193
    };
194
    let andy_admin = mint(andy.clone(), "scopes=repo%3Aadmin").await;
195
    let andy_ro = mint(andy.clone(), "scopes=repo%3Aread").await;
196
    let bob_rw = mint(bob.clone(), "scopes=repo%3Aread&scopes=repo%3Awrite").await;
197
198
    // Create a repository through the API; the read-only token cannot.
199
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_ro), Some(r#"{"owner":"andy","name":"x"}"#)).await;
200
    assert_eq!(st, StatusCode::FORBIDDEN);
201
    let (st, v) = api(
202
        app,
203
        "POST",
204
        "/api/v1/repos",
205
        Some(&andy_admin),
206
        Some(r#"{"owner":"andy","name":"demo","description":"d","visibility":"public"}"#),
207
    )
208
    .await;
209
    assert_eq!(st, StatusCode::CREATED, "{v}");
210
    assert_eq!(v["clone_url"], format!("{}/andy/demo", h.base));
211
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_admin), Some(r#"{"owner":"andy","name":"demo"}"#)).await;
212
    assert_eq!(st, StatusCode::CONFLICT);
213
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&andy_ro), None).await;
214
    assert_eq!(st, StatusCode::FORBIDDEN, "user:read is a scope of its own");
215
    let (st, v) = api(app, "GET", "/api/v1/users/andy", None, None).await;
216
    assert_eq!(st, StatusCode::OK);
217
    assert_eq!(v["username"], "andy");
218
219
    // A webhook on the repository; push, then see the delivery with a valid signature after a retry.
220
    let rx = receiver().await;
221
    let (st, v) = api(
222
        app,
223
        "POST",
224
        "/api/v1/repos/andy/demo/hooks",
225
        Some(&andy_admin),
226
        Some(&format!(r#"{{"url":"{}","secret":"s3","events":"push,proposal,check"}}"#, rx.url)),
227
    )
228
    .await;
229
    assert_eq!(st, StatusCode::CREATED, "{v}");
230
    let work = tempfile::tempdir().unwrap();
231
    let mut client = Repo::init(work.path()).unwrap();
232
    client.config.set("remote.origin.url", &format!("{}/andy/demo", h.base)).unwrap();
233
    client.config.set("remote.origin.token", "site").unwrap();
234
    client.save_config().unwrap();
235
    write(work.path(), "a.txt", b"a\n");
236
    client.snapshot("t").unwrap();
237
    let base = client.commit("base", &[]).unwrap();
238
    assert!(client.push("origin", false).unwrap().iter().all(|r| r.ok));
239
    // The worker retries with backoff; drive it directly for the retry.
240
    tokio::time::sleep(std::time::Duration::from_millis(400)).await;
241
    assert!(rx.seen.lock().unwrap().is_empty(), "the first attempt failed");
242
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
243
    oxygenhub::hooks::deliver_due(app).await;
244
    let seen = rx.seen.lock().unwrap().clone();
245
    assert_eq!(seen.len(), 1, "{seen:?}");
246
    assert_eq!(seen[0].0, "push");
247
    assert_eq!(seen[0].1, oxygenhub::hooks::signature("s3", seen[0].2.as_bytes()));
248
    let payload: serde_json::Value = serde_json::from_str(&seen[0].2).unwrap();
249
    assert_eq!(payload["repository"]["name"], "demo");
250
    assert_eq!(payload["data"]["updates"][0]["reference"], "main");
251
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/hooks", Some(&andy_admin), None).await;
252
    assert_eq!(v.as_array().unwrap().len(), 1);
253
254
    // History, tree, file, blame, bookmarks, trust, pushes through the API.
255
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main", None, None).await;
256
    assert_eq!(st, StatusCode::OK);
257
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
f28389bd Andy McCall ↶ 258
    // A revset in place of the whole history (`?r=`), under a budget; a
259
    // bad one is the caller's problem.
260
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=%3A%3Amain%20%26%20kind(normal)", None, None).await;
261
    assert_eq!(st, StatusCode::OK, "{v}");
262
    assert_eq!(v["total"].as_u64(), Some(1));
263
    assert_eq!(v["changes"][0]["hash"], base.to_hex());
264
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=none()", None, None).await;
265
    assert_eq!((st, v["total"].as_u64()), (StatusCode::OK, Some(0)));
266
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=main%20%26", None, None).await.0, StatusCode::BAD_REQUEST);
267
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/history/main?r=nosuch()", None, None).await.0, StatusCode::BAD_REQUEST);
b64e2537 Andy McCall ↶ 268
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/tree/main", None, None).await;
269
    assert_eq!(v[0]["name"], "a.txt");
270
    let r = call(app, "GET", "/api/v1/repos/andy/demo/file/main/a.txt", None, None, None, None).await;
271
    assert_eq!(r.body, "a\n");
272
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/blame/main/a.txt", None, None).await;
273
    assert_eq!(v[0]["change"], base.to_hex());
274
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{}", base.to_hex()), None, None).await;
275
    assert_eq!(v["files"][0]["path"], "a.txt");
d2263e29 Andy McCall ↶ 276
    assert_eq!(v["files"][0]["lines"][0], serde_json::json!({"kind": "add", "new": 1, "text": "a"}), "{v}");
277
    assert_eq!(v["files"][0]["truncated"], false);
b64e2537 Andy McCall ↶ 278
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/trust", None, None).await;
279
    assert!(v["policy"].is_null());
280
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/pushes", None, None).await;
281
    assert_eq!(v[0]["reference"], "main");
282
283
    // Issues through the API: Bob opens one, comments, and closes it.
284
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_rw), Some(r#"{"title":"Bug","body":"it broke"}"#)).await;
285
    assert_eq!(st, StatusCode::CREATED, "{v}");
286
    assert_eq!(v["number"], 1);
287
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1/comments", Some(&bob_rw), Some(r#"{"body":"more"}"#)).await;
288
    assert_eq!(st, StatusCode::CREATED);
289
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues/1", Some(&bob_rw), Some(r#"{"state":"closed"}"#)).await;
290
    assert_eq!(st, StatusCode::OK, "{v}");
291
    assert_eq!(v["state"], "closed");
292
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
293
    assert_eq!(v[0]["comments"], 1);
294
    let (_, v) = api(app, "GET", "/api/v1/search?q=broke", None, None).await;
295
    assert_eq!(v[0]["number"], 1);
296
297
    // A proposal through the API, then a required check gates its landing.
298
    client.bookmark_create("feat", Some(&[base])).unwrap();
299
    client.bookmark_switch("feat", false).unwrap();
300
    write(work.path(), "b.txt", b"b\n");
3f02e5ea Andy McCall ↶ 301
    write(work.path(), "a.txt", b"a\nA\n");
b64e2537 Andy McCall ↶ 302
    client.snapshot("t").unwrap();
303
    let feat = client.commit("feat", &[]).unwrap();
304
    assert!(client.push_bookmark("origin", "feat", false).unwrap().iter().all(|r| r.ok));
305
    let (st, v) =
306
        api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(r#"{"title":"Feat","target":"main","source":"feat"}"#))
307
            .await;
308
    assert_eq!(st, StatusCode::CREATED, "{v}");
309
    assert_eq!(v["number"], 2);
310
    let state = v["projected_state"].as_str().unwrap().to_string();
311
    assert_eq!(v["landable"], true);
a0dd06b0 Andy McCall ↶ 312
    // A wiki takes no proposals, and says so rather than "no such
313
    // repository" (oxygenhub#128); a repository's that does not exist
314
    // still does not.
315
    let (st, v) =
316
        api(app, "POST", "/api/v1/repos/andy/demo.wiki/proposals", Some(&bob_rw), Some(r#"{"title":"W","target":"main","source":"p"}"#))
317
            .await;
318
    let detail = v["detail"].as_str().unwrap_or_default();
319
    assert!(st == StatusCode::NOT_FOUND && detail.contains("is the wiki of andy/demo") && detail.contains("push main"), "{v}");
320
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/nope.wiki/proposals", Some(&bob_rw), None).await;
321
    assert_eq!(v["detail"], "no such repository");
3f02e5ea Andy McCall ↶ 322
    // Its files, and each side's bytes, for editors' diff views.
323
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/files", None, None).await;
324
    assert_eq!(st, StatusCode::OK, "{v}");
325
    let files: Vec<(String, String)> =
326
        v.as_array().unwrap().iter().map(|f| (f["path"].as_str().unwrap().to_string(), f["kind"].as_str().unwrap().to_string())).collect();
327
    assert_eq!(files, vec![("a.txt".into(), "modified".into()), ("b.txt".into(), "added".into())], "{v}");
328
    assert_eq!(v[0]["added"], 1);
329
    let side = |s: &str, p: &str| format!("/api/v1/repos/andy/demo/proposals/2/content/{s}/{p}");
330
    assert_eq!(call(app, "GET", &side("base", "a.txt"), None, None, None, None).await.body, "a\n");
331
    assert_eq!(call(app, "GET", &side("head", "a.txt"), None, None, None, None).await.body, "a\nA\n");
332
    assert_eq!(call(app, "GET", &side("head", "b.txt"), None, None, None, None).await.body, "b\n");
333
    assert_eq!(call(app, "GET", &side("base", "b.txt"), None, None, None, None).await.status, StatusCode::NOT_FOUND, "b.txt is new");
334
    assert_eq!(call(app, "GET", &side("middle", "a.txt"), None, None, None, None).await.status, StatusCode::BAD_REQUEST);
70c3d029 Andy McCall ↶ 335
    // The same files with their diffs, as a change's (oxygenhub-android#4).
336
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/diff", None, None).await;
337
    assert_eq!(st, StatusCode::OK, "{v}");
338
    assert_eq!((v[0]["path"].as_str(), v[0]["added"].as_u64(), v[0]["truncated"].as_bool()), (Some("a.txt"), Some(1), Some(false)), "{v}");
339
    let lines: Vec<(String, String)> = v[0]["lines"]
340
        .as_array()
341
        .unwrap()
342
        .iter()
343
        .map(|l| (l["kind"].as_str().unwrap().to_string(), l["text"].as_str().unwrap().to_string()))
344
        .collect();
345
    assert_eq!(lines, vec![("context".into(), "a".into()), ("add".into(), "A".into())], "{v}");
346
    assert_eq!(v[1]["kind"], "added");
347
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/demo/proposals/99/diff", None, None).await.0, StatusCode::NOT_FOUND);
c0fac31d Andy McCall ↶ 348
    // An anchored comment comes back with its line in the projected state.
349
    let (st, v) = api(
350
        app,
351
        "POST",
352
        "/api/v1/repos/andy/demo/proposals/2/comments",
353
        Some(&bob_rw),
354
        Some(r#"{"body":"why capital A?","path":"a.txt","line":2}"#),
355
    )
356
    .await;
357
    assert_eq!(st, StatusCode::CREATED, "{v}");
358
    assert_eq!(v["line"], 2);
359
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/comments", None, None).await;
360
    assert_eq!(v[0]["path"], "a.txt");
361
    assert_eq!(v[0]["line"], 2, "{v}");
362
    assert_eq!(v[0]["anchor"]["change"], feat.to_hex());
b64e2537 Andy McCall ↶ 363
    // Require the "build" check.
364
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await;
365
    let csrf = csrf_of(&settings.body);
c7067c7b Andy McCall 366
    let r = call(app, "POST", "/andy/demo/settings/checks", None, Some(&andy), None, Some(&format!("_csrf={csrf}&required_checks=build")))
367
        .await;
368
    assert!(settled(app, r, Some(&andy), "/andy/demo/settings/checks").await.body.contains("Required checks saved."));
b64e2537 Andy McCall ↶ 369
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
370
    assert_eq!(v["landable"], false);
371
    assert!(v["blockers"][0].as_str().unwrap().contains("build"), "{v}");
5d818ec7 Andy McCall ↶ 372
    // Nothing to land yet for its owner (#311), and the list is only there when asked for.
373
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
374
    assert!(v.get("landable").is_none(), "{v}");
b64e2537 Andy McCall ↶ 375
    // A checker reports on the projected state: first running, then passed; the page streams it.
376
    let (st, v) = api(
377
        app,
378
        "POST",
379
        "/api/v1/repos/andy/demo/checks",
380
        Some(&andy_ro),
381
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"running"}}"#)),
382
    )
383
    .await;
384
    assert_eq!(st, StatusCode::FORBIDDEN, "{v}");
33d98147 Andy McCall 385
    let mut events = app.bus.subscribe(oxygenhub::bus::Topic::Proposals);
b64e2537 Andy McCall ↶ 386
    let (st, v) = api(
387
        app,
388
        "POST",
389
        "/api/v1/repos/andy/demo/checks",
390
        Some(&bob_rw),
391
        Some(&format!(r#"{{"state":"{state}","name":"build","status":"passed","summary":"42 tests","url":"https://ci.example/1"}}"#)),
392
    )
393
    .await;
394
    assert_eq!(st, StatusCode::CREATED, "{v}");
33d98147 Andy McCall 395
    let oxygenhub::bus::Event::Proposal { event: ev, .. } = events.recv().await.unwrap() else { panic!("a proposal event") };
b64e2537 Andy McCall ↶ 396
    assert_eq!(ev.kind, "check");
397
    assert_eq!(ev.check.unwrap().name, "build");
398
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2/checks", None, None).await;
399
    assert_eq!(v[0]["status"], "passed");
400
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
401
    assert_eq!(v["landable"], true, "{v}");
5d818ec7 Andy McCall ↶ 402
    let (_, v) = api(app, "GET", "/api/v1/user/proposals?landable=true", Some(&andy_ro), None).await;
403
    assert_eq!((v["landable"][0]["repository"].as_str(), v["landable"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
404
    assert!(api(app, "GET", "/api/v1/user/proposals", Some(&andy_ro), None).await.1.get("landable").is_none(), "only when asked");
4dfa4599 Andy McCall ↶ 405
    // Your sky for the app (oxygenhub-android#23): the dashboard's backdrop data.
406
    let (st, v) = api(app, "GET", "/api/v1/user/sky", Some(&andy_ro), None).await;
407
    assert_eq!(st, StatusCode::OK, "{v}");
408
    let demo = v["repos"].as_array().unwrap().iter().position(|r| r == "andy/demo").expect("andy's repository") as i64;
409
    let events = v["events"].as_array().unwrap();
410
    assert!(events.iter().any(|e| e[0] == demo && e[1] == 0), "a push: {v}");
411
    assert!(events.iter().any(|e| e[0] == demo && e[1] == 1), "a proposal event: {v}");
412
    assert!(events.iter().all(|e| e[2].as_i64().unwrap() <= v["now"].as_i64().unwrap()));
413
    assert_eq!(api(app, "GET", "/api/v1/user/sky", None, None).await.0, StatusCode::UNAUTHORIZED);
851a26a2 Andy McCall ↶ 414
    // One repository's, its pages' backdrop, in the same shape.
415
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/sky", Some(&andy_ro), None).await;
416
    assert_eq!(st, StatusCode::OK, "{v}");
417
    assert_eq!(v["repos"], serde_json::json!(["andy/demo"]));
418
    assert!(v["events"].as_array().unwrap().iter().all(|e| e[0] == 0) && v["events"].as_array().unwrap().iter().any(|e| e[1] == 0), "{v}");
419
    assert_eq!(api(app, "GET", "/api/v1/repos/andy/nope/sky", Some(&andy_ro), None).await.0, StatusCode::NOT_FOUND);
b64e2537 Andy McCall ↶ 420
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
421
    assert!(page.body.contains("42 tests"), "{}", page.body);
a2ef53c5 Andy McCall ↶ 422
    // A summary carrying whole hashes shows them by their ends, so the
423
    // Checks panel keeps its width (a pin mismatch's message, 2026-10-16).
424
    let (a, b) = (
425
        "6ea27b1d35037a4e4d0f6208b1ca99630df40888bd21fd55c8f8aba51dcdd7cb",
426
        "f7495d7689da3ac5b68684f26fce28b91ce55e6b8131c5e484ad2aab90c3020f",
427
    );
428
    let summary = format!("could not run: flow-init has BLAKE3 {a}, but {b} is pinned");
429
    let body = serde_json::json!({ "state": state, "name": "lint", "status": "failed", "summary": summary }).to_string();
430
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/checks", Some(&bob_rw), Some(&body)).await;
431
    assert_eq!(st, StatusCode::CREATED, "{v}");
432
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await.body;
433
    assert!(page.contains("6ea27b1d…1dcdd7cb") && page.contains(&format!("data-full=\"{a}\"")), "{page}");
434
    assert!(!page.contains(&format!("BLAKE3 {a},")), "never the whole hash inline");
435
    // The Checks section refreshes itself; nothing reloads the whole page.
436
    assert!(!page.contains("location.reload()"), "no full reload on a check");
437
    let part = call(app, "GET", "/andy/demo/proposal/2?fragment=checks", None, Some(&andy), None, None).await.body;
438
    assert!(part.contains("<h3>Checks</h3>") && part.contains("6ea27b1d…1dcdd7cb") && !part.contains("<html"), "{part}");
b64e2537 Andy McCall ↶ 439
    // The check and the proposal reached the webhook too.
440
    sqlx::query("UPDATE deliveries SET next_ms = 0").execute(&app.db).await.unwrap();
441
    oxygenhub::hooks::deliver_due(app).await;
442
    let kinds: Vec<String> = rx.seen.lock().unwrap().iter().map(|s| s.0.clone()).collect();
443
    assert!(kinds.contains(&"proposal.opened".to_string()) && kinds.contains(&"check".to_string()), "{kinds:?}");
444
    let _ = feat;
445
    let _ = rx.fail_first;
42a0ba4b Andy McCall ↶ 446
447
    // The inbox through the API: count, list, mark one read, mark all read.
448
    let bob_user = mint(bob.clone(), "scopes=user%3Aread").await;
449
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
450
    oxygenhub::db::notify::mark_read(&app.db, bob_id, None).await.unwrap();
eb0c44a9 Andy McCall ↶ 451
    oxygenhub::db::notify::add(
452
        &app.db,
453
        oxygenhub::db::notify::New {
454
            account_id: bob_id,
ecac6e8d Andy McCall ↶ 455
            repo_id: Some(oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap().id),
eb0c44a9 Andy McCall ↶ 456
            reason: oxygenhub::db::notify::Reason::Participating,
ecac6e8d Andy McCall ↶ 457
            kind: "issue.opened",
eb0c44a9 Andy McCall ↶ 458
            title: "andy/demo#1: Bug",
459
            url: "/andy/demo/issue/1",
460
            actor: "andy",
461
        },
462
    )
463
    .await
464
    .unwrap();
465
    oxygenhub::db::notify::add(
466
        &app.db,
467
        oxygenhub::db::notify::New {
468
            account_id: bob_id,
469
            repo_id: None,
470
            reason: oxygenhub::db::notify::Reason::Participating,
471
            kind: "review",
472
            title: "andy/demo#2: Feat",
473
            url: "/andy/demo/proposal/2",
474
            actor: "andy",
475
        },
476
    )
477
    .await
478
    .unwrap();
42a0ba4b Andy McCall ↶ 479
    let (st, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
480
    assert_eq!(st, StatusCode::OK, "{v}");
481
    assert_eq!(v["unread"], 2);
482
    assert_eq!(v["items"][0]["read"], false);
483
    assert!(v["items"][0]["url"].as_str().unwrap().starts_with(&h.base), "absolute urls: {v}");
ecac6e8d Andy McCall ↶ 484
    // Its repository, why, its thread and the kind's label (#305).
485
    let bug = v["items"].as_array().unwrap().iter().find(|n| n["title"] == "andy/demo#1: Bug").unwrap();
486
    assert_eq!(
487
        (bug["repository"].as_str(), bug["reason"].as_str(), bug["label"].as_str()),
488
        (Some("andy/demo"), Some("participating"), Some("🐛 New Issue")),
489
        "{bug}"
490
    );
491
    assert_eq!(bug["thread"].as_str(), Some(format!("{}/andy/demo/issue/1", h.base).as_str()));
42a0ba4b Andy McCall ↶ 492
    let first = v["items"][0]["id"].as_i64().unwrap();
493
    let (st, _) = api(app, "POST", &format!("/api/v1/notifications/{first}/read"), Some(&bob_user), None).await;
494
    assert_eq!(st, StatusCode::NO_CONTENT);
495
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 1);
496
    assert_eq!(api(app, "POST", "/api/v1/notifications/read", Some(&bob_user), None).await.0, StatusCode::NO_CONTENT);
497
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await.1["unread"], 0);
498
    // Another account's notification is not the caller's to clear, and a token without user:read sees nothing.
499
    assert_eq!(api(app, "GET", "/api/v1/notifications", Some(&bob_rw), None).await.0, StatusCode::FORBIDDEN);
ecac6e8d Andy McCall ↶ 500
    // No token at all is 401, so a client knows to sign in (#303).
501
    assert_eq!(api(app, "GET", "/api/v1/notifications", None, None).await.0, StatusCode::UNAUTHORIZED);
502
    assert_eq!(api(app, "GET", "/api/v1/user", None, None).await.0, StatusCode::UNAUTHORIZED);
0b20f1ec Andy McCall ↶ 503
cc1cd197 Andy McCall ↶ 504
    // Review requests: the author asks andy; andy is told, reviews, and the
505
    // request is answered; the author hears of the review.
506
    let andy_user = mint(andy.clone(), "scopes=user%3Aread").await;
ecac6e8d Andy McCall ↶ 507
    let (st, orgs) = api(app, "GET", "/api/v1/user/orgs", Some(&andy_user), None).await;
508
    assert!(st == StatusCode::OK && orgs.is_array(), "the caller's organisations (#302): {orgs}");
cc1cd197 Andy McCall ↶ 509
    let andy_pw = mint(andy.clone(), "scopes=proposals%3Awrite").await;
510
    oxygenhub::db::notify::mark_read(&app.db, oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id, None)
511
        .await
512
        .unwrap();
513
    let path = "/api/v1/repos/andy/demo/proposals/2/reviewers";
514
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["nobody"]}"#)).await;
515
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "{v}");
516
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["bob"]}"#)).await;
517
    assert_eq!(st, StatusCode::UNPROCESSABLE_ENTITY, "the author cannot review: {v}");
518
    let (st, v) = api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["@andy"]}"#)).await;
519
    assert_eq!((st, v.clone()), (StatusCode::OK, serde_json::json!(["andy"])));
520
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
521
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
522
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&andy_user), None).await;
523
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review_requested" && n["read"] == false), "{v}");
524
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&andy), None, None).await;
525
    assert!(page.body.contains("Reviewers") && page.body.contains("review requested"), "{}", page.body);
526
    let (st, _) =
527
        api(app, "POST", "/api/v1/repos/andy/demo/proposals/2/reviews", Some(&andy_pw), Some(r#"{"verdict":"comment","body":"ok"}"#)).await;
528
    assert_eq!(st, StatusCode::CREATED);
529
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
530
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "answered by the review");
531
    let (_, v) = api(app, "GET", "/api/v1/notifications", Some(&bob_user), None).await;
532
    assert!(v["items"].as_array().unwrap().iter().any(|n| n["kind"] == "proposal.review" && n["read"] == false), "{v}");
533
    // Asking again and withdrawing it.
534
    api(app, "POST", path, Some(&bob_rw), Some(r#"{"reviewers":["andy"]}"#)).await;
535
    let (st, _) = api(app, "DELETE", &format!("{path}/andy"), Some(&bob_rw), None).await;
536
    assert_eq!(st, StatusCode::NO_CONTENT);
537
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
538
    assert_eq!(v["requested_reviewers"], serde_json::json!([]));
8e96499f Andy McCall ↶ 539
    // oxygenhub#84: the page's menu sets who is asked, all at once.
540
    let page = call(app, "GET", "/andy/demo/proposal/2", None, Some(&bob), None, None).await;
541
    assert!(
542
        page.body.contains("Request reviews") && page.body.contains("name=\"username\" value=\"andy\""),
543
        "the reviewers menu lists andy"
544
    );
545
    let csrf = csrf_of(&page.body);
546
    let form = |list: &str| format!("_csrf={csrf}&action=set{list}");
547
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form("&username=andy"))).await;
548
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
549
    assert_eq!(v["requested_reviewers"], serde_json::json!(["andy"]));
550
    call(app, "POST", "/andy/demo/proposal/2/reviewers", None, Some(&bob), None, Some(&form(""))).await;
551
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
552
    assert_eq!(v["requested_reviewers"], serde_json::json!([]), "an empty menu withdraws them");
cc1cd197 Andy McCall ↶ 553
0b20f1ec Andy McCall ↶ 554
    // A source bookmark with `/` in its name, as a feature/N-name workflow
555
    // makes them: by name, and as this repository's owner/name:bookmark.
556
    for (b, file) in [("feature/1-one", "c.txt"), ("feature/2-two", "d.txt")] {
557
        client.bookmark_create(b, Some(&[base])).unwrap();
558
        client.bookmark_switch(b, false).unwrap();
559
        write(work.path(), file, b"c\n");
560
        client.snapshot("t").unwrap();
561
        client.commit(b, &[]).unwrap();
562
        assert!(client.push_bookmark("origin", b, false).unwrap().iter().all(|r| r.ok));
563
    }
564
    for source in ["feature/1-one", "andy/demo:feature/2-two"] {
565
        let body = format!(r#"{{"title":"Slash","target":"main","source":"{source}"}}"#);
566
        let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(&body)).await;
567
        assert_eq!(st, StatusCode::CREATED, "{source}: {v}");
568
        let n = v["number"].as_i64().unwrap();
569
        let page = call(app, "GET", &format!("/andy/demo/proposal/{n}"), None, None, None, None).await;
570
        assert_eq!(page.status, StatusCode::OK);
571
        assert!(page.body.contains("feature/"), "the page names its source");
572
    }
573
    let body = r#"{"title":"None","target":"main","source":"feature/3-none"}"#;
574
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/proposals", Some(&bob_rw), Some(body)).await;
575
    assert!(st.is_client_error() && v.to_string().contains("no bookmark feature/3-none"), "{st} {v}");
739a763a Andy McCall ↶ 576
577
    // oxygenhub#76: a proposal's title and description are edited through
578
    // the API by its author or a maintainer; what is not given stays.
579
    let edit = |token: &str, number: i64, body: &str| {
580
        let (app, token, body) = (app.clone(), token.to_string(), body.to_string());
581
        async move { api(&app, "PATCH", &format!("/api/v1/repos/andy/demo/proposals/{number}"), Some(&token), Some(&body)).await }
582
    };
583
    let (st, v) = edit(&bob_rw, 2, r#"{"body":"8 of 8, not 9 of 9"}"#).await;
584
    assert_eq!(st, StatusCode::OK, "{v}");
585
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat"), Some("8 of 8, not 9 of 9")), "{v}");
586
    let (st, v) = edit(&andy_pw, 2, r#"{"title":"Feat, renamed"}"#).await;
587
    assert_eq!(st, StatusCode::OK, "a maintainer edits another's proposal: {v}");
588
    assert_eq!((v["title"].as_str(), v["body"].as_str()), (Some("Feat, renamed"), Some("8 of 8, not 9 of 9")));
589
    assert_eq!(edit(&bob_rw, 2, r#"{"title":"  "}"#).await.0, StatusCode::BAD_REQUEST, "a title is required");
590
    assert_eq!(edit(&bob_rw, 99, r#"{"body":"x"}"#).await.0, StatusCode::NOT_FOUND);
591
    // Andy's own proposal: Bob, a writer but not a maintainer, cannot edit it.
592
    let (st, v) = api(
593
        app,
594
        "POST",
595
        "/api/v1/repos/andy/demo/proposals",
596
        Some(&andy_pw),
597
        Some(r#"{"title":"Andy's","target":"main","source":"feature/1-one"}"#),
598
    )
599
    .await;
600
    assert_eq!(st, StatusCode::CREATED, "{v}");
601
    let n = v["number"].as_i64().unwrap();
602
    assert_eq!(edit(&bob_rw, n, r#"{"body":"mine now"}"#).await.0, StatusCode::FORBIDDEN);
603
    assert_eq!(edit(&andy_ro, 2, r#"{"body":"x"}"#).await.0, StatusCode::FORBIDDEN, "a read-only token cannot edit");
2291f8cc Andy McCall ↶ 604
605
    // oxygenhub#80: labels on a proposal, the whole set by name, checked
606
    // before anything changes, shown in its JSON.
607
    for l in ["ui", "flow"] {
608
        let body = format!(r#"{{"name":"{l}"}}"#);
609
        assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_admin), Some(&body)).await.0, StatusCode::CREATED);
610
    }
611
    assert_eq!(edit(&bob_rw, 2, r#"{"labels":["ui"]}"#).await.0, StatusCode::FORBIDDEN, "labels need triage, not authorship");
612
    let (st, v) = edit(&andy_pw, 2, r#"{"labels":["ui","flow"]}"#).await;
613
    assert_eq!(st, StatusCode::OK, "{v}");
614
    let names = |v: &serde_json::Value| -> Vec<String> {
615
        v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap().to_string()).collect()
616
    };
617
    assert_eq!(names(&v), ["flow", "ui"]);
618
    assert_eq!(v["title"], "Feat, renamed", "labels alone leave the text");
619
    let (st, _) = edit(&andy_pw, 2, r#"{"labels":["ui","nope"]}"#).await;
620
    assert_eq!(st, StatusCode::BAD_REQUEST, "an unknown label is refused");
621
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/proposals/2", None, None).await;
622
    assert_eq!(names(&v), ["flow", "ui"], "and nothing changed");
623
    let (_, v) = edit(&andy_pw, 2, r#"{"labels":["flow"]}"#).await;
624
    assert_eq!(names(&v), ["flow"]);
625
    assert_eq!(edit(&andy_ro, 2, r#"{"labels":[]}"#).await.0, StatusCode::FORBIDDEN);
b64e2537 Andy McCall ↶ 626
}
76f262e1 Andy McCall ↶ 627
628
#[tokio::test(flavor = "multi_thread")]
629
async fn api_issue_triage_and_labels() {
630
    let h = hub().await;
631
    let app = &h.app;
c8684d44 Andy McCall 632
    let andy = call(
633
        app,
634
        "POST",
635
        "/register",
636
        None,
637
        None,
638
        None,
639
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
640
    )
641
    .await
642
    .cookie
643
    .unwrap();
644
    let bob = call(
645
        app,
646
        "POST",
647
        "/register",
648
        None,
649
        None,
650
        None,
651
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
652
    )
653
    .await
654
    .cookie
655
    .unwrap();
76f262e1 Andy McCall ↶ 656
    let mint = |cookie: String, scopes: &'static str| {
657
        let app = app.clone();
658
        async move {
659
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
660
            let csrf = csrf_of(&page.body);
661
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
662
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
663
        }
664
    };
665
    let andy_t = mint(andy, "scopes=repo%3Aadmin").await;
666
    let bob_t = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
667
    let (st, _) = api(app, "POST", "/api/v1/repos", Some(&andy_t), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
668
    assert_eq!(st, StatusCode::CREATED);
669
670
    // Labels through the API; bad colours and non-triage callers are refused.
671
    let (st, v) = api(
672
        app,
673
        "POST",
674
        "/api/v1/repos/andy/demo/labels",
675
        Some(&andy_t),
676
        Some(r##"{"name":"bug","colour":"#ff0000","description":"Broken"}"##),
677
    )
678
    .await;
679
    assert_eq!((st, v["name"].as_str()), (StatusCode::CREATED, Some("bug")));
680
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r#"{"name":"flow"}"#)).await.0, StatusCode::CREATED);
681
    assert_eq!(
682
        api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&andy_t), Some(r##"{"name":"x","colour":"red"}"##)).await.0,
683
        StatusCode::BAD_REQUEST
684
    );
685
    assert_eq!(api(app, "POST", "/api/v1/repos/andy/demo/labels", Some(&bob_t), Some(r#"{"name":"mine"}"#)).await.0, StatusCode::FORBIDDEN);
686
    let (_, labels) = api(app, "GET", "/api/v1/repos/andy/demo/labels", None, None).await;
687
    assert_eq!(labels.as_array().unwrap().len(), 2);
5ea4872f Andy McCall ↶ 688
    // oxygenhub#91: milestones over the API, for triage.
689
    let (st, m) = api(
690
        app,
691
        "POST",
692
        "/api/v1/repos/andy/demo/milestones",
693
        Some(&andy_t),
694
        Some(r#"{"title":"v1","description":"First","due":"2027-01-01"}"#),
695
    )
696
    .await;
697
    assert_eq!((st, m["title"].as_str(), m["state"].as_str()), (StatusCode::CREATED, Some("v1"), Some("open")), "{m}");
698
    assert_eq!(m["due_ms"].as_i64(), Some(1_798_761_600_000));
699
    assert_eq!(
700
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&andy_t), Some(r#"{"title":"v2","due":"soon"}"#)).await.0,
701
        StatusCode::BAD_REQUEST
702
    );
703
    assert_eq!(
704
        api(app, "POST", "/api/v1/repos/andy/demo/milestones", Some(&bob_t), Some(r#"{"title":"mine"}"#)).await.0,
705
        StatusCode::FORBIDDEN
706
    );
707
    let (st, m) =
708
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"title":"v1.0","due":"","state":"closed"}"#))
709
            .await;
710
    assert_eq!(
711
        (st, m["title"].as_str(), m["state"].as_str(), m["due_ms"].is_null()),
712
        (StatusCode::OK, Some("v1.0"), Some("closed"), true),
713
        "{m}"
714
    );
715
    assert_eq!(m["description"].as_str(), Some("First"), "what is not given stays");
716
    assert_eq!(
717
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1", Some(&andy_t), Some(r#"{"state":"open"}"#)).await.0,
718
        StatusCode::NOT_FOUND,
719
        "renamed"
720
    );
721
    assert_eq!(
722
        api(app, "PATCH", "/api/v1/repos/andy/demo/milestones/v1.0", Some(&andy_t), Some(r#"{"state":"done"}"#)).await.0,
723
        StatusCode::BAD_REQUEST
724
    );
725
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/milestones", None, None).await;
726
    assert_eq!(list.as_array().unwrap().len(), 1);
76f262e1 Andy McCall ↶ 727
728
    // An issue created with its labels and assignee in one call.
729
    let (st, v) = api(
730
        app,
731
        "POST",
732
        "/api/v1/repos/andy/demo/issues",
733
        Some(&andy_t),
734
        Some(r#"{"title":"Crash","body":"b","labels":["bug"],"assignees":["bob"]}"#),
735
    )
736
    .await;
737
    assert_eq!(st, StatusCode::CREATED, "{v}");
738
    assert_eq!(v["labels"][0]["name"], "bug");
739
    assert_eq!(v["assignees"], serde_json::json!(["bob"]));
740
    let n = v["number"].as_i64().unwrap();
741
    // Unknown names are refused before anything is created.
742
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&andy_t), Some(r#"{"title":"X","labels":["nope"]}"#)).await;
743
    assert_eq!(st, StatusCode::BAD_REQUEST);
744
    assert!(v["detail"].as_str().unwrap().contains("no label"));
745
    let (_, list) = api(app, "GET", "/api/v1/repos/andy/demo/issues?state=all", None, None).await;
746
    assert_eq!(list.as_array().unwrap().len(), 1, "nothing half-made");
747
    // Without triage, labels cannot be set, but a plain issue can be opened.
748
    assert_eq!(
749
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"Y","labels":["bug"]}"#)).await.0,
750
        StatusCode::FORBIDDEN
751
    );
752
    let (st, bobs) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&bob_t), Some(r#"{"title":"From Bob"}"#)).await;
753
    assert_eq!(st, StatusCode::CREATED);
754
    let bob_n = bobs["number"].as_i64().unwrap();
755
756
    // PATCH: the whole label set, assignees and milestone, with events.
757
    let (st, v) =
758
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"labels":["flow"],"assignees":[]}"#))
759
            .await;
760
    assert_eq!(st, StatusCode::OK, "{v}");
761
    assert_eq!(v["labels"].as_array().unwrap().iter().map(|l| l["name"].as_str().unwrap()).collect::<Vec<_>>(), ["flow"]);
762
    assert_eq!(v["assignees"], serde_json::json!([]));
763
    let (st, _) = api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"milestone":"v9"}"#)).await;
764
    assert_eq!(st, StatusCode::BAD_REQUEST, "no such milestone");
765
    let issue_page = call(app, "GET", &format!("/andy/demo/issue/{n}"), None, None, None, None).await.body;
766
    assert!(issue_page.contains("set labels") && issue_page.contains("unassigned"), "timeline events");
767
    // The author edits their own title; others cannot; nobody but triage sets labels.
768
    let (st, v) =
769
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"title":"From Bob, clearer"}"#)).await;
770
    assert_eq!((st, v["title"].as_str()), (StatusCode::OK, Some("From Bob, clearer")));
771
    assert_eq!(
772
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&bob_t), Some(r#"{"title":"mine now"}"#)).await.0,
773
        StatusCode::FORBIDDEN
774
    );
775
    assert_eq!(
776
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{bob_n}"), Some(&bob_t), Some(r#"{"labels":["bug"]}"#)).await.0,
777
        StatusCode::FORBIDDEN
778
    );
779
    assert_eq!(
780
        api(app, "PATCH", &format!("/api/v1/repos/andy/demo/issues/{n}"), Some(&andy_t), Some(r#"{"title":"  "}"#)).await.0,
781
        StatusCode::BAD_REQUEST
782
    );
783
784
    // Deleting a label takes it off the issues.
785
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NO_CONTENT);
786
    let (_, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/issues/{n}"), None, None).await;
787
    assert_eq!(v["labels"], serde_json::json!([]));
788
    assert_eq!(api(app, "DELETE", "/api/v1/repos/andy/demo/labels/flow", Some(&andy_t), None).await.0, StatusCode::NOT_FOUND);
789
}
9756c67d Andy McCall ↶ 790
791
#[tokio::test(flavor = "multi_thread")]
792
async fn webhook_formats_editing_and_web_issue_events() {
793
    let h = hub().await;
794
    let app = &h.app;
c8684d44 Andy McCall 795
    let andy = call(
796
        app,
797
        "POST",
798
        "/register",
799
        None,
800
        None,
801
        None,
802
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
803
    )
804
    .await
805
    .cookie
806
    .unwrap();
9756c67d Andy McCall ↶ 807
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
808
    let r = call(
809
        app,
810
        "POST",
811
        "/settings/tokens",
812
        None,
813
        Some(&andy),
814
        None,
815
        Some(&format!("_csrf={}&name=t&scopes=repo%3Aadmin", csrf_of(&page.body))),
816
    )
817
    .await;
818
    let token = r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap();
819
    assert_eq!(
820
        api(app, "POST", "/api/v1/repos", Some(&token), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await.0,
821
        StatusCode::CREATED
822
    );
823
    let rx = receiver().await;
824
    *rx.fail_first.lock().unwrap() = false;
825
    let settings = call(app, "GET", "/andy/demo/settings", None, Some(&andy), None, None).await.body;
826
    let csrf = csrf_of(&settings);
827
    let form = |f: String| {
828
        let andy = andy.clone();
c7067c7b Andy McCall 829
        async move {
830
            let r = call(app, "POST", "/andy/demo/settings/hooks", None, Some(&andy), None, Some(&f)).await;
831
            settled(app, r, Some(&andy), "/andy/demo/settings/webhooks").await.body
832
        }
9756c67d Andy McCall ↶ 833
    };
834
    let url = rx.url.replace(':', "%3A").replace('/', "%2F");
835
    assert!(form(format!("_csrf={csrf}&url={url}&format=discord&events=*")).await.contains("Webhook added"));
836
    let hook = oxygenhub::db::hooks::hooks_for_repo(&app.db, 1).await.unwrap().remove(0);
c9893553 Andy McCall ↶ 837
    // #220: a hook with MAX_WAITING deliveries waiting takes no more until it catches up.
838
    {
839
        use oxygenhub::db::hooks::{queue_delivery, MAX_WAITING};
840
        let before: i64 =
3b1bc27f Andy McCall 841
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 842
        for i in 0..MAX_WAITING {
843
            sqlx::query(
3b1bc27f Andy McCall 844
                "INSERT INTO deliveries (hook_id, delivery, event, payload, created_ms, next_ms) VALUES ($1, $2, 'push', '{}', 0, 0)",
c9893553 Andy McCall ↶ 845
            )
846
            .bind(hook.id)
847
            .bind(format!("flood-{i}"))
848
            .execute(&app.db)
849
            .await
850
            .unwrap();
851
        }
852
        assert_eq!(queue_delivery(&app.db, hook.id, "one-more", "push", "{}").await.unwrap(), None, "the queue is full");
853
        sqlx::query("DELETE FROM deliveries WHERE delivery LIKE 'flood-%'").execute(&app.db).await.unwrap();
854
        assert!(queue_delivery(&app.db, hook.id, "now-room", "push", "{}").await.unwrap().is_some());
855
        sqlx::query("DELETE FROM deliveries WHERE delivery = 'now-room'").execute(&app.db).await.unwrap();
856
        let after: i64 =
3b1bc27f Andy McCall 857
            sqlx::query_scalar("SELECT COUNT(*) FROM deliveries WHERE hook_id = $1").bind(hook.id).fetch_one(&app.db).await.unwrap();
c9893553 Andy McCall ↶ 858
        assert_eq!(before, after);
859
    }
9756c67d Andy McCall ↶ 860
    assert_eq!(hook.format, "discord");
861
    // Ping arrives as a Discord message.
862
    form(format!("_csrf={csrf}&id={}&action=ping", hook.id)).await;
863
    let mut got = String::new();
864
    for _ in 0..100 {
865
        if let Some((_, _, body)) = rx.seen.lock().unwrap().first() {
866
            got = body.clone();
867
        }
868
        if !got.is_empty() {
869
            break;
870
        }
871
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
872
    }
873
    let v: serde_json::Value = serde_json::from_str(&got).unwrap();
874
    assert_eq!(v["embeds"][0]["title"], "OxygenHub is connected");
875
    assert_eq!(v["allowed_mentions"]["parse"], serde_json::json!([]));
c7067c7b Andy McCall 876
    let page = call(app, "GET", "/andy/demo/settings/webhooks", None, Some(&andy), None, None).await.body;
9756c67d Andy McCall ↶ 877
    assert!(page.contains("last delivery <span class=\"sig sig-valid\">✔</span> 200"), "the table shows how it went");
878
879
    // Editing: a blank URL and secret keep theirs; format, events and active change.
880
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=&secret=&events=issue&format=oxygenhub&active=1", hook.id))
881
        .await
882
        .contains("Webhook saved"));
883
    let edited = oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap();
884
    assert_eq!(
885
        (edited.url.as_str(), edited.events.as_str(), edited.format.as_str(), edited.active),
886
        (rx.url.as_str(), "issue", "oxygenhub", true)
887
    );
888
    assert!(form(format!("_csrf={csrf}&id={}&action=update&url=ftp%3A%2F%2Fx&events=*", hook.id)).await.contains("starts with http"));
889
890
    // An issue opened on the web now reaches the hook, as the signed envelope.
891
    let new = call(app, "GET", "/andy/demo/issues/new", None, Some(&andy), None, None).await.body;
892
    call(
893
        app,
894
        "POST",
895
        "/andy/demo/issues/new",
896
        None,
897
        Some(&andy),
898
        None,
899
        Some(&format!("_csrf={}&title=From+the+web&body=hello", csrf_of(&new))),
900
    )
901
    .await;
902
    let mut envelope = None;
903
    for _ in 0..100 {
904
        envelope = rx.seen.lock().unwrap().iter().find(|(e, _, _)| e == "issue.opened").cloned();
905
        if envelope.is_some() {
906
            break;
907
        }
908
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
909
    }
910
    let (_, sig, body) = envelope.expect("issue.opened delivered");
911
    let v: serde_json::Value = serde_json::from_str(&body).unwrap();
912
    assert_eq!(v["data"]["issue"]["title"], "From the web");
913
    assert!(sig.starts_with("blake3-keyed="));
914
    // A disabled hook through the edit form (no active box).
915
    form(format!("_csrf={csrf}&id={}&action=update&url=&events=*&format=oxygenhub", hook.id)).await;
916
    assert!(!oxygenhub::db::hooks::hook(&app.db, hook.id).await.unwrap().unwrap().active);
917
}
ef20fdc1 Andy McCall ↶ 918
919
#[tokio::test(flavor = "multi_thread")]
920
async fn api_projects() {
921
    let h = hub().await;
922
    let app = &h.app;
c8684d44 Andy McCall 923
    let andy = call(
924
        app,
925
        "POST",
926
        "/register",
927
        None,
928
        None,
929
        None,
930
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
931
    )
932
    .await
933
    .cookie
934
    .unwrap();
935
    let bob = call(
936
        app,
937
        "POST",
938
        "/register",
939
        None,
940
        None,
941
        None,
942
        Some("username=bob&email=b%40example.com&password=correct-horse-battery&setup=test-setup"),
943
    )
944
    .await
945
    .cookie
946
    .unwrap();
ef20fdc1 Andy McCall ↶ 947
    let mint = |cookie: String, scopes: &'static str| {
948
        let app = app.clone();
949
        async move {
950
            let page = call(&app, "GET", "/settings/tokens", None, Some(&cookie), None, None).await;
951
            let csrf = csrf_of(&page.body);
952
            let r = call(&app, "POST", "/settings/tokens", None, Some(&cookie), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
953
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
954
        }
955
    };
956
    let a = mint(andy, "scopes=repo%3Aadmin").await;
957
    let b = mint(bob, "scopes=repo%3Aread&scopes=repo%3Awrite").await;
958
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
959
    api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Crash"}"#)).await;
960
ecac6e8d Andy McCall ↶ 961
    // The caller's own repositories, a page at a time (#302); bob has none.
962
    api(app, "POST", "/api/v1/repos", Some(&a), Some(r#"{"owner":"andy","name":"zeta","visibility":"private"}"#)).await;
963
    let names =
964
        |v: &serde_json::Value| -> Vec<String> { v.as_array().unwrap().iter().map(|r| r["name"].as_str().unwrap().to_string()).collect() };
965
    let (st, v) = api(app, "GET", "/api/v1/user/repos", Some(&a), None).await;
966
    assert_eq!((st, names(&v)), (StatusCode::OK, vec!["demo".to_string(), "zeta".to_string()]), "{v}");
967
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?limit=1", Some(&a), None).await.1), ["demo"]);
968
    assert_eq!(names(&api(app, "GET", "/api/v1/user/repos?after=andy/demo", Some(&a), None).await.1), ["zeta"]);
969
    assert!(names(&api(app, "GET", "/api/v1/user/repos", Some(&b), None).await.1).is_empty(), "not bob's");
970
    assert_eq!(api(app, "GET", "/api/v1/user/repos?affiliation=friend", Some(&a), None).await.0, StatusCode::BAD_REQUEST);
971
    assert_eq!(api(app, "GET", "/api/v1/user/repos", None, None).await.0, StatusCode::UNAUTHORIZED);
f4e13830 Andy McCall ↶ 972
    // The proposals to act on, as the dashboard lists them: bob's in andy's
973
    // repository is andy's to review and bob's own.
974
    let demo = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
975
    let bob_id = oxygenhub::db::accounts::account_by_name(&app.db, "bob").await.unwrap().unwrap().id;
976
    oxygenhub::db::proposals::create(
977
        &app.db,
978
        oxygenhub::db::proposals::NewProposal {
979
            repo_id: demo.id,
980
            title: "Faster startup",
981
            body: "",
982
            author_id: Some(bob_id),
983
            author: "bob",
984
            draft: false,
985
            target: "main",
986
            source_kind: "bookmark",
987
            source_repo_id: Some(demo.id),
988
            source_bookmark: "fast",
989
            source_changes: "",
990
        },
991
    )
992
    .await
993
    .unwrap();
994
    let (st, v) = api(app, "GET", "/api/v1/user/proposals", Some(&a), None).await;
995
    assert_eq!(st, StatusCode::OK, "{v}");
996
    assert_eq!((v["review"][0]["repository"].as_str(), v["review"][0]["number"].as_i64()), (Some("andy/demo"), Some(2)), "{v}");
997
    assert_eq!(v["review"][0]["state"], "open");
998
    assert!(v["review"][0]["url"].as_str().unwrap().ends_with("/andy/demo/proposal/2"));
999
    assert_eq!(v["authored"].as_array().map(Vec::len), Some(0));
1000
    let (_, v) = api(app, "GET", "/api/v1/user/proposals", Some(&b), None).await;
1001
    assert_eq!((v["review"].as_array().map(Vec::len), v["authored"][0]["title"].as_str()), (Some(0), Some("Faster startup")), "{v}");
1002
    assert_eq!(api(app, "GET", "/api/v1/user/proposals", None, None).await.0, StatusCode::UNAUTHORIZED);
1003
8f1d76f4 Andy McCall ↶ 1004
    // The open issues assigned to the caller (#359), for apps.
1005
    let (st, v) =
1006
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(r#"{"title":"Widget counts","assignees":["andy"]}"#)).await;
1007
    assert_eq!(st, StatusCode::CREATED, "{v}");
1008
    let n = v["number"].as_i64();
1009
    let (st, v) = api(app, "GET", "/api/v1/user/issues", Some(&a), None).await;
1010
    assert_eq!(st, StatusCode::OK, "{v}");
1011
    assert_eq!(v.as_array().map(Vec::len), Some(1), "only the assigned one: {v}");
1012
    assert_eq!(
1013
        (v[0]["repository"].as_str(), v[0]["number"].as_i64(), v[0]["title"].as_str()),
1014
        (Some("andy/demo"), n, Some("Widget counts"))
1015
    );
1016
    assert!(v[0]["url"].as_str().unwrap().ends_with(&format!("/andy/demo/issue/{}", n.unwrap())), "{v}");
1017
    assert_eq!(api(app, "GET", "/api/v1/user/issues", Some(&b), None).await.1.as_array().map(Vec::len), Some(0), "nothing assigned to bob");
1018
    assert_eq!(api(app, "GET", "/api/v1/user/issues", None, None).await.0, StatusCode::UNAUTHORIZED);
1019
ecac6e8d Andy McCall ↶ 1020
    // Organisations need user:read, which this token lacks.
1021
    assert_eq!(api(app, "GET", "/api/v1/user/orgs", Some(&a), None).await.0, StatusCode::FORBIDDEN);
1022
ef20fdc1 Andy McCall ↶ 1023
    let (st, p) = api(app, "POST", "/api/v1/projects/andy", Some(&a), Some(r#"{"title":"Roadmap","description":"Next"}"#)).await;
1024
    assert_eq!((st, p["number"].as_i64()), (StatusCode::CREATED, Some(1)), "{p}");
1025
    assert!(p["url"].as_str().unwrap().ends_with("/projects/andy/1"));
1026
    assert_eq!(api(app, "POST", "/api/v1/projects/andy", Some(&b), Some(r#"{"title":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
1027
    assert_eq!(api(app, "POST", "/api/v1/projects/nobody", Some(&a), Some(r#"{"title":"X"}"#)).await.0, StatusCode::NOT_FOUND);
1028
1029
    // Cards by reference, into a column by name, and a note into the first column.
1030
    let (st, card) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"doing"}"#)).await;
1031
    assert_eq!(st, StatusCode::CREATED, "{card}");
1032
    assert_eq!(
1033
        (card["kind"].as_str(), card["reference"].as_str(), card["title"].as_str(), card["state"].as_str()),
1034
        (Some("issue"), Some("andy/demo#1"), Some("Crash"), Some("open"))
1035
    );
6a306cd0 Andy McCall ↶ 1036
    assert_eq!((card["labels"].as_array().map(Vec::len), card["assignees"].as_array().map(Vec::len)), (Some(0), Some(0)), "{card}");
ef20fdc1 Andy McCall ↶ 1037
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1"}"#)).await;
1038
    assert_eq!(st, StatusCode::BAD_REQUEST);
1039
    assert!(v["detail"].as_str().unwrap().contains("already on this project"));
efb51b39 Andy McCall ↶ 1040
    // The form the board shows its cards in is taken too (#118); another owner's is refused.
1041
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"andy/demo#1"}"#)).await;
1042
    assert!(v["detail"].as_str().unwrap().contains("already on this project"), "{v}");
1043
    let (_, v) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"other/demo#1"}"#)).await;
1044
    assert!(v["detail"].as_str().unwrap().contains("only andy's"), "{v}");
ef20fdc1 Andy McCall ↶ 1045
    assert_eq!(
1046
        api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"reference":"demo#1","column":"nope"}"#)).await.0,
1047
        StatusCode::BAD_REQUEST
1048
    );
1049
    let (st, note) = api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"Write docs"}"#)).await;
1050
    assert_eq!((st, note["kind"].as_str()), (StatusCode::CREATED, Some("note")));
1051
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&b), Some(r#"{"note":"hi"}"#)).await.0, StatusCode::FORBIDDEN);
1052
1053
    // Move and read the board.
1054
    let id = card["id"].as_i64().unwrap();
1055
    assert_eq!(
1056
        api(app, "PATCH", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), Some(r#"{"column":"Done"}"#)).await.0,
1057
        StatusCode::NO_CONTENT
1058
    );
1059
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1060
    let names: Vec<(&str, usize)> =
1061
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1062
    assert_eq!(names, [("Backlog", 1), ("Doing", 0), ("Done", 1)]);
1063
    assert_eq!(board["columns"][2]["cards"][0]["reference"], "andy/demo#1");
17a3a84b Andy McCall ↶ 1064
    // The cards by column (#115), and a wrong method answers with a body.
306aec18 Andy McCall ↶ 1065
    // Columns by API (#366): add, rename, move, remove; answers are the board.
1066
    let col_names = |v: &serde_json::Value| -> Vec<String> {
1067
        v["columns"].as_array().unwrap().iter().map(|c| c["name"].as_str().unwrap().to_string()).collect()
1068
    };
1069
    let (st, v) = api(app, "POST", "/api/v1/projects/andy/1/columns", Some(&a), Some(r#"{"name":"Sprint 1"}"#)).await;
1070
    assert_eq!((st, col_names(&v)), (StatusCode::OK, vec!["Backlog".to_string(), "Doing".into(), "Done".into(), "Sprint 1".into()]), "{v}");
1071
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/columns", Some(&a), Some(r#"{"name":"sprint 1"}"#)).await.0, StatusCode::CONFLICT);
1072
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/columns", Some(&a), Some(r#"{"name":"  "}"#)).await.0, StatusCode::BAD_REQUEST);
1073
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/columns", Some(&b), Some(r#"{"name":"Mine"}"#)).await.0, StatusCode::FORBIDDEN);
1074
    let (st, v) =
1075
        api(app, "PATCH", "/api/v1/projects/andy/1/columns/Sprint%201", Some(&a), Some(r#"{"name":"Sprint 2","position":0}"#)).await;
1076
    assert_eq!((st, col_names(&v)), (StatusCode::OK, vec!["Sprint 2".to_string(), "Backlog".into(), "Doing".into(), "Done".into()]), "{v}");
1077
    let sprint = v["columns"][0]["id"].as_i64().unwrap();
1078
    let (_, v) = api(app, "PATCH", &format!("/api/v1/projects/andy/1/columns/{sprint}"), Some(&a), Some(r#"{"position":99}"#)).await;
1079
    assert_eq!(col_names(&v).last().map(String::as_str), Some("Sprint 2"));
1080
    assert_eq!(api(app, "PATCH", "/api/v1/projects/andy/1/columns/Sprint%202", Some(&a), Some("{}")).await.0, StatusCode::BAD_REQUEST);
1081
    assert_eq!(
1082
        api(app, "PATCH", "/api/v1/projects/andy/1/columns/Sprint%202", Some(&a), Some(r#"{"name":"done"}"#)).await.0,
1083
        StatusCode::CONFLICT
1084
    );
1085
    assert_eq!(
1086
        api(app, "PATCH", "/api/v1/projects/andy/1/columns/nope", Some(&a), Some(r#"{"position":0}"#)).await.0,
1087
        StatusCode::NOT_FOUND
1088
    );
1089
    let (st, v) = api(app, "DELETE", "/api/v1/projects/andy/1/columns/Sprint%202", Some(&a), None).await;
1090
    assert_eq!((st, col_names(&v)), (StatusCode::OK, vec!["Backlog".to_string(), "Doing".into(), "Done".into()]), "{v}");
17a3a84b Andy McCall ↶ 1091
    let (st, cols) = api(app, "GET", "/api/v1/projects/andy/1/cards", None, None).await;
1092
    assert_eq!(st, StatusCode::OK);
1093
    assert_eq!(cols, board["columns"]);
1094
    let (st, v) = api(app, "PUT", "/api/v1/projects/andy/1/cards", Some(&a), Some("{}")).await;
1095
    assert_eq!(st, StatusCode::METHOD_NOT_ALLOWED);
1096
    assert!(v["detail"].as_str().unwrap().contains("not for PUT"), "{v}");
ef20fdc1 Andy McCall ↶ 1097
456f4197 Andy McCall ↶ 1098
    // A column's cards at once (#289): with exceptions, a state filter and
1099
    // a dry run; one audit entry.
1100
    for t in ["Second", "Third"] {
1101
        api(app, "POST", "/api/v1/repos/andy/demo/issues", Some(&a), Some(&format!(r#"{{"title":"{t}"}}"#))).await;
1102
    }
1103
    for n in [2, 3] {
1104
        let body = format!(r#"{{"reference":"demo#{n}","column":"Doing"}}"#);
1105
        assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(&body)).await.0, StatusCode::CREATED);
1106
    }
1107
    let bulk = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&a), Some(body));
1108
    let refs = |v: &serde_json::Value, k: &str| -> Vec<String> {
1109
        v[k].as_array().unwrap().iter().map(|c| c["reference"].as_str().unwrap().to_string()).collect()
1110
    };
1111
    let (st, v) = bulk(r##"{"from":"Doing","column":"Done","except":["#2"],"dry_run":true}"##).await;
1112
    assert_eq!(st, StatusCode::OK, "{v}");
1113
    assert_eq!((refs(&v, "moved"), refs(&v, "kept")), (vec!["andy/demo#3".to_string()], vec!["andy/demo#2".to_string()]));
1114
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1115
    assert_eq!(board["columns"][1]["cards"].as_array().unwrap().len(), 2, "a dry run moves nothing");
1116
    let (_, v) = bulk(r#"{"from":"Doing","column":"Done","state":["closed"]}"#).await;
1117
    assert!(refs(&v, "moved").is_empty(), "both are open: {v}");
1118
    let (_, v) = bulk(r#"{"from":"doing","column":"done","except":["demo#2"]}"#).await;
1119
    assert_eq!(refs(&v, "moved"), ["andy/demo#3"]);
1120
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1121
    let names: Vec<(&str, usize)> =
1122
        board["columns"].as_array().unwrap().iter().map(|c| (c["name"].as_str().unwrap(), c["cards"].as_array().unwrap().len())).collect();
1123
    assert_eq!(names, [("Backlog", 1), ("Doing", 1), ("Done", 2)]);
1124
    let audited: i64 =
1125
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_moved'").fetch_one(&app.db).await.unwrap();
1126
    assert_eq!(audited, 1, "the dry run and the empty move are not audited");
1127
    assert_eq!(bulk(r#"{"from":"Done","column":"Done"}"#).await.0, StatusCode::BAD_REQUEST);
1128
    assert_eq!(
1129
        api(app, "POST", "/api/v1/projects/andy/1/cards/move", Some(&b), Some(r#"{"from":"Doing","column":"Done"}"#)).await.0,
1130
        StatusCode::FORBIDDEN
1131
    );
1132
439ecd87 Andy McCall ↶ 1133
    // Archive (#293): Done's cards there more than a week (#3, made old),
1134
    // listed with ?archived=true, restored once.
1135
    sqlx::query("UPDATE project_cards SET moved_ms = 0 WHERE number = 3").execute(&app.db).await.unwrap();
1136
    let archive = |body: &'static str| api(app, "POST", "/api/v1/projects/andy/1/cards/archive", Some(&a), Some(body));
1137
    let (st, v) = archive(r#"{"from":"Done","older_days":7,"dry_run":true}"#).await;
1138
    assert_eq!((st, refs(&v, "archived")), (StatusCode::OK, vec!["andy/demo#3".to_string()]), "{v}");
1139
    assert!(v["archived"][0].get("archived_ms").is_none(), "a dry run archives nothing: {v}");
1140
    let (_, v) = archive(r#"{"from":"Done","older_days":7}"#).await;
1141
    assert_eq!((refs(&v, "archived"), refs(&v, "kept").len()), (vec!["andy/demo#3".to_string()], 1), "{v}");
1142
    assert!(v["archived"][0]["archived_ms"].as_i64().is_some());
1143
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1144
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 1, "off the board: {board}");
1145
    let (st, archived) = api(app, "GET", "/api/v1/projects/andy/1/cards?archived=true", None, None).await;
1146
    assert_eq!((st, archived[2]["cards"][0]["reference"].as_str()), (StatusCode::OK, Some("andy/demo#3")), "{archived}");
1147
    let card = archived[2]["cards"][0]["id"].as_i64().unwrap();
1148
    let restore = format!("/api/v1/projects/andy/1/cards/{card}/restore");
1149
    assert_eq!(api(app, "POST", &restore, Some(&b), None).await.0, StatusCode::FORBIDDEN);
1150
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NO_CONTENT);
1151
    assert_eq!(api(app, "POST", &restore, Some(&a), None).await.0, StatusCode::NOT_FOUND, "not archived now");
1152
    let (_, board) = api(app, "GET", "/api/v1/projects/andy/1", None, None).await;
1153
    assert_eq!(board["columns"][2]["cards"].as_array().unwrap().len(), 2);
1154
    assert_eq!(archive(r#"{"from":"Done","older_days":-1}"#).await.0, StatusCode::BAD_REQUEST);
1155
    let audited: i64 =
1156
        sqlx::query_scalar("SELECT COUNT(*) FROM audit WHERE action = 'project.cards_archived'").fetch_one(&app.db).await.unwrap();
1157
    assert_eq!(audited, 1);
1158
ef20fdc1 Andy McCall ↶ 1159
    // Private: hidden from others; closed: read-only; then remove a card.
1160
    let (_, edited) = api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"private":true}"#)).await;
1161
    assert_eq!(edited["public"], false);
1162
    assert_eq!(api(app, "GET", "/api/v1/projects/andy/1", Some(&b), None).await.0, StatusCode::NOT_FOUND);
1163
    assert_eq!(api(app, "GET", "/api/v1/projects/andy", None, None).await.1, serde_json::json!([]));
1164
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":true}"#)).await;
1165
    assert_eq!(api(app, "POST", "/api/v1/projects/andy/1/cards", Some(&a), Some(r#"{"note":"late"}"#)).await.0, StatusCode::CONFLICT);
1166
    api(app, "PATCH", "/api/v1/projects/andy/1", Some(&a), Some(r#"{"closed":false}"#)).await;
1167
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NO_CONTENT);
1168
    assert_eq!(api(app, "DELETE", &format!("/api/v1/projects/andy/1/cards/{id}"), Some(&a), None).await.0, StatusCode::NOT_FOUND);
1169
}
961c10be Andy McCall ↶ 1170
1171
#[tokio::test(flavor = "multi_thread")]
1172
async fn api_required_checks() {
1173
    let h = hub().await;
1174
    let app = &h.app;
c8684d44 Andy McCall 1175
    let andy = call(
1176
        app,
1177
        "POST",
1178
        "/register",
1179
        None,
1180
        None,
1181
        None,
1182
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1183
    )
1184
    .await
1185
    .cookie
1186
    .unwrap();
961c10be Andy McCall ↶ 1187
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1188
    let csrf = csrf_of(&page.body);
1189
    let mint = |scopes: &'static str| {
1190
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1191
        async move {
1192
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1193
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1194
        }
1195
    };
1196
    let admin = mint("scopes=repo%3Aadmin").await;
1197
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1198
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1199
1200
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await;
1201
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!([])));
1202
    let (st, v) = api(
1203
        app,
1204
        "PUT",
1205
        "/api/v1/repos/andy/demo/checks/required",
1206
        Some(&admin),
1207
        Some(r#"{"names":["flow/test"," flow/fmt ","flow/test",""]}"#),
1208
    )
1209
    .await;
1210
    assert_eq!((st, v["names"].clone()), (StatusCode::OK, serde_json::json!(["flow/fmt", "flow/test"])), "trimmed, sorted, once each");
1211
    assert_eq!(oxygenhub::db::hooks::required_checks(&app.db, 1).await.unwrap(), ["flow/fmt", "flow/test"]);
1212
    assert_eq!(
1213
        api(app, "GET", "/api/v1/repos/andy/demo/checks/required", None, None).await.1["names"],
1214
        serde_json::json!(["flow/fmt", "flow/test"])
1215
    );
1216
    assert_eq!(
1217
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&write), Some(r#"{"names":[]}"#)).await.0,
1218
        StatusCode::FORBIDDEN,
1219
        "repo:admin only"
1220
    );
1221
    assert_eq!(
1222
        api(app, "PUT", "/api/v1/repos/andy/demo/checks/required", Some(&admin), Some(r#"{"names":["a,b"]}"#)).await.0,
1223
        StatusCode::BAD_REQUEST
1224
    );
1225
    // The settings page shows the same list.
c7067c7b Andy McCall 1226
    assert!(call(app, "GET", "/andy/demo/settings/checks", None, Some(&andy), None, None).await.body.contains("flow/fmt, flow/test"));
961c10be Andy McCall ↶ 1227
}
9008bf6c Andy McCall ↶ 1228
1229
/// OxygenFlow per repository: site administrators turn it on or off in
1230
/// the repository's settings; hub.toml's `[flow] repos` is the default.
1231
#[tokio::test(flavor = "multi_thread")]
1232
async fn flow_is_switched_per_repository_by_site_admins() {
1233
    let h = hub().await;
1234
    let app = &h.app;
c8684d44 Andy McCall 1235
    let andy = call(
1236
        app,
1237
        "POST",
1238
        "/register",
1239
        None,
1240
        None,
1241
        None,
1242
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1243
    )
1244
    .await
1245
    .cookie
1246
    .unwrap();
9008bf6c Andy McCall ↶ 1247
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1248
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1249
    let row = || async { oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap() };
1250
    assert!(!oxygenhub::flow::enabled(app, &row().await), "not in [flow] repos");
1251
    let tab = call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await;
c7067c7b Andy McCall 1252
    assert!(tab.body.contains("not enabled") && tab.body.contains("/andy/demo/settings/flow"));
9008bf6c Andy McCall ↶ 1253
1254
    let set = |value: &'static str| {
1255
        let (app, andy) = (app.clone(), andy.clone());
1256
        async move {
c7067c7b Andy McCall 1257
            let settings = call(&app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
1258
            let r = call(
9008bf6c Andy McCall ↶ 1259
                &app,
1260
                "POST",
1261
                "/andy/demo/settings/flow",
1262
                None,
1263
                Some(&andy),
1264
                None,
1265
                Some(&format!("_csrf={}&flow={value}", csrf_of(&settings.body))),
1266
            )
c7067c7b Andy McCall 1267
            .await;
1268
            settled(&app, r, Some(&andy), "/andy/demo/settings/flow").await
9008bf6c Andy McCall ↶ 1269
        }
1270
    };
1271
    // A repository admin who is not a site admin sees the state but cannot change it.
1272
    let id = oxygenhub::db::accounts::account_by_name(&app.db, "andy").await.unwrap().unwrap().id;
1273
    oxygenhub::db::accounts::set_admin(&app.db, id, false).await.unwrap();
c7067c7b Andy McCall 1274
    let settings = call(app, "GET", "/andy/demo/settings/flow", None, Some(&andy), None, None).await;
9008bf6c Andy McCall ↶ 1275
    assert!(settings.body.contains("do not start runs") && !settings.body.contains("name=\"flow\""));
1276
    let r = set("on").await;
1277
    assert!(r.body.contains("Only site administrators"), "{}", r.body);
1278
    assert_eq!(row().await.flow, "");
1279
1280
    oxygenhub::db::accounts::set_admin(&app.db, id, true).await.unwrap();
1281
    let r = set("on").await;
1282
    assert!(r.body.contains("OxygenFlow is on"), "{}", r.body);
1283
    assert_eq!(row().await.flow, "on");
1284
    assert!(oxygenhub::flow::enabled(app, &row().await));
1285
    assert!(!call(app, "GET", "/andy/demo/flow", None, Some(&andy), None, None).await.body.contains("not enabled"));
1286
    set("off").await;
1287
    assert!(!oxygenhub::flow::enabled(app, &row().await));
1288
    set("default").await;
1289
    assert_eq!(row().await.flow, "");
1870e4fa Andy McCall ↶ 1290
    assert!(set("sometimes").await.body.contains("Pick on, own runners, off"));
9008bf6c Andy McCall ↶ 1291
}
e271a37b Andy McCall ↶ 1292
1293
/// Deleting bookmarks (hub spec §6.4): pushed deletions and the delete
1294
/// button, never the repository's default bookmark as the hub sets it.
1295
#[tokio::test(flavor = "multi_thread")]
1296
async fn bookmarks_are_deleted_by_push_and_on_the_web() {
1297
    let h = hub().await;
1298
    let app = &h.app;
c8684d44 Andy McCall 1299
    let andy = call(
1300
        app,
1301
        "POST",
1302
        "/register",
1303
        None,
1304
        None,
1305
        None,
1306
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1307
    )
1308
    .await
1309
    .cookie
1310
    .unwrap();
e271a37b Andy McCall ↶ 1311
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1312
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1313
    let url = format!("{}/andy/demo", h.base);
1314
    let work = tempfile::tempdir().unwrap();
1315
    let (w, u) = (work.path().to_path_buf(), url.clone());
1316
    let client = tokio::task::spawn_blocking(move || {
1317
        let mut c = Repo::init(&w).unwrap();
1318
        c.config.set("remote.origin.url", &u).unwrap();
1319
        c.config.set("remote.origin.token", "site").unwrap();
1320
        c.save_config().unwrap();
1321
        write(&w, "a.txt", b"a\n");
1322
        c.commit("a", &[]).unwrap();
1323
        assert!(c.push("origin", false).unwrap()[0].ok);
1324
        for b in ["develop", "feature/x", "stray"] {
1325
            c.bookmark_create(b, None).unwrap();
1326
            assert!(c.push_bookmark("origin", b, false).unwrap()[0].ok);
1327
        }
1328
        // A pushed deletion.
1329
        let r = c.push_delete("origin", "feature/x").unwrap();
1330
        assert!(r[0].ok, "{r:?}");
1331
        c
1332
    })
1333
    .await
1334
    .unwrap();
1335
    let page = call(app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1336
    assert!(!page.body.contains(">feature/x<") && page.body.contains(">stray<"), "{}", page.body);
1337
    assert!(page.body.contains("/andy/demo/bookmarks/delete"), "writers see delete buttons");
1338
    let anon = call(app, "GET", "/andy/demo/bookmarks", None, None, None, None).await;
1339
    assert!(!anon.body.contains("/bookmarks/delete"));
1340
1341
    // The hub's default, not the repository's config, is protected: make
1342
    // develop the default, then main can go and develop cannot.
1343
    let row = oxygenhub::db::repos::get(&app.db, "andy", "demo").await.unwrap().unwrap();
1344
    oxygenhub::db::repos::set_default_bookmark(&app.db, row.id, "develop").await.unwrap();
1345
    let client = tokio::task::spawn_blocking(move || {
1346
        let r = client.push_delete("origin", "develop").unwrap();
1347
        assert!(!r[0].ok && r[0].reason.contains("default bookmark"), "{r:?}");
1348
        let r = client.push_delete("origin", "main").unwrap();
1349
        assert!(r[0].ok, "{r:?}");
1350
        client
1351
    })
1352
    .await
1353
    .unwrap();
1354
    drop(client);
1355
1356
    // On the web: a writer deletes stray; the default is refused.
1357
    let form = |b: &'static str| {
1358
        let (app, andy) = (app.clone(), andy.clone());
1359
        async move {
1360
            let page = call(&app, "GET", "/andy/demo/bookmarks", None, Some(&andy), None, None).await;
1361
            call(
1362
                &app,
1363
                "POST",
1364
                "/andy/demo/bookmarks/delete",
1365
                None,
1366
                Some(&andy),
1367
                None,
1368
                Some(&format!("_csrf={}&bookmark={b}", csrf_of(&page.body))),
1369
            )
1370
            .await
1371
        }
1372
    };
1373
    let r = form("stray").await;
1374
    assert!(r.body.contains("Deleted stray"), "{}", r.body);
1375
    assert!(!r.body.contains(">stray<"));
1376
    let r = form("develop").await;
1377
    assert!(r.body.contains("is the default bookmark"), "{}", r.body);
1378
    let r = form("nope").await;
1379
    assert!(r.body.contains("There is no bookmark nope"), "{}", r.body);
1380
    let pushes = call(app, "GET", "/andy/demo/pushes", None, Some(&andy), None, None).await;
1381
    assert!(pushes.body.contains("deleted on the web"), "logged like a push");
1382
    // Anonymous visitors cannot.
1383
    assert_ne!(
1384
        call(app, "POST", "/andy/demo/bookmarks/delete", None, None, None, Some("_csrf=x&bookmark=develop")).await.status,
1385
        StatusCode::OK
1386
    );
1387
}
760a7dd3 Andy McCall ↶ 1388
1389
/// A change signed by a key no account has linked says so, on its page
1390
/// and in the API (feedback 14).
1391
#[tokio::test(flavor = "multi_thread")]
1392
async fn changes_signed_by_unlinked_keys_say_so() {
1393
    let h = hub().await;
1394
    let app = &h.app;
c8684d44 Andy McCall 1395
    let andy = call(
1396
        app,
1397
        "POST",
1398
        "/register",
1399
        None,
1400
        None,
1401
        None,
1402
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1403
    )
1404
    .await
1405
    .cookie
1406
    .unwrap();
760a7dd3 Andy McCall ↶ 1407
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1408
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1409
    let url = format!("{}/andy/demo", h.base);
1410
    let work = tempfile::tempdir().unwrap();
1411
    let (w, u, home) = (work.path().to_path_buf(), url.clone(), work.path().join(".home"));
1412
    let hash = tokio::task::spawn_blocking(move || {
1413
        let mut c = Repo::init(&w.join("r")).unwrap().with_home(home);
1414
        c.config.set("remote.origin.url", &u).unwrap();
1415
        c.config.set("remote.origin.token", "site").unwrap();
1416
        c.save_config().unwrap();
1417
        c.create_identity("Ada", "[email protected]", oxy_core::repo::IdentityScope::Repo).unwrap();
1418
        write(&w.join("r"), "a.txt", b"a\n");
1419
        let h = c.commit("signed by Ada", &[]).unwrap();
1420
        assert!(c.push("origin", false).unwrap()[0].ok);
1421
        h.to_hex()
1422
    })
1423
    .await
1424
    .unwrap();
1425
    let (st, v) = api(app, "GET", &format!("/api/v1/repos/andy/demo/changes/{hash}"), None, None).await;
1426
    assert_eq!(st, StatusCode::OK, "{v}");
1427
    assert!(v["change"]["author"]["account"].is_null(), "{v}");
1428
    assert!(v["change"]["author"]["note"].as_str().unwrap().contains("not linked"), "{v}");
1429
    let page = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, Some(&andy), None, None).await;
1430
    assert!(page.body.contains("key not linked") && page.body.contains("/settings/keys"), "a signed-in viewer is pointed at Settings");
1431
    let anon = call(app, "GET", &format!("/andy/demo/change/{hash}"), None, None, None, None).await;
1432
    assert!(anon.body.contains("key not linked") && !anon.body.contains("link your key"));
1433
}
65be9f9c Andy McCall ↶ 1434
1435
/// Function history (hub spec §6.6): the file page lists a file's
1436
/// functions, and a function's page lists exactly the changes to its lines.
1437
#[tokio::test(flavor = "multi_thread")]
1438
async fn a_function_has_its_own_history() {
1439
    let h = hub().await;
1440
    let app = &h.app;
c8684d44 Andy McCall 1441
    let andy = call(
1442
        app,
1443
        "POST",
1444
        "/register",
1445
        None,
1446
        None,
1447
        None,
1448
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1449
    )
1450
    .await
1451
    .cookie
1452
    .unwrap();
65be9f9c Andy McCall ↶ 1453
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1454
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1455
    let url = format!("{}/andy/demo", h.base);
1456
    let work = tempfile::tempdir().unwrap();
1457
    let w = work.path().to_path_buf();
1458
    tokio::task::spawn_blocking(move || {
1459
        let mut c = Repo::init(&w).unwrap();
1460
        c.config.set("remote.origin.url", &url).unwrap();
1461
        c.config.set("remote.origin.token", "site").unwrap();
1462
        c.save_config().unwrap();
1463
        let steps = [
1464
            ("add lib", "use x;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1465
            ("change the import", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n    }\n}\n"),
1466
            ("log twice", "use y;\n\nimpl Repo {\n    fn log(&self) {\n        one();\n        one();\n    }\n}\n"),
1467
        ];
1468
        for (msg, text) in steps {
1469
            write(&w, "src/lib.rs", text.as_bytes());
1470
            c.commit(msg, &[]).unwrap();
1471
        }
1472
        assert!(c.push("origin", false).unwrap()[0].ok);
1473
    })
1474
    .await
1475
    .unwrap();
1476
    let file = call(app, "GET", "/andy/demo/file/main/src/lib.rs", None, None, None, None).await.body;
1477
    assert!(file.contains("Functions") && file.contains("/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog"), "{file}");
1478
    let r = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=7&name=Repo%3A%3Alog", None, None, None, None).await;
1479
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1480
    assert!(r.body.contains("History of <code>Repo::log</code>") && r.body.contains("2 changes"), "{}", r.body);
1481
    assert!(r.body.contains("log twice") && r.body.contains("add lib") && !r.body.contains("change the import"));
1482
    let bad = call(app, "GET", "/andy/demo/function/main/src/lib.rs?start=4&end=99", None, None, None, None).await;
1483
    assert_ne!(bad.status, StatusCode::OK);
1484
}
92574625 Andy McCall ↶ 1485
1486
/// Swimlanes (hub spec §6.7): independent changes in their own lanes,
1487
/// dependency edges, linked cards.
1488
#[tokio::test(flavor = "multi_thread")]
1489
async fn a_bookmark_shows_as_swimlanes() {
1490
    let h = hub().await;
1491
    let app = &h.app;
c8684d44 Andy McCall 1492
    let andy = call(
1493
        app,
1494
        "POST",
1495
        "/register",
1496
        None,
1497
        None,
1498
        None,
1499
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1500
    )
1501
    .await
1502
    .cookie
1503
    .unwrap();
92574625 Andy McCall ↶ 1504
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1505
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1506
    let url = format!("{}/andy/demo", h.base);
1507
    let work = tempfile::tempdir().unwrap();
1508
    let w = work.path().to_path_buf();
1509
    tokio::task::spawn_blocking(move || {
1510
        let mut c = Repo::init(&w).unwrap();
1511
        c.config.set("remote.origin.url", &url).unwrap();
1512
        c.config.set("remote.origin.token", "site").unwrap();
1513
        c.save_config().unwrap();
1514
        // Two files edited independently: two lanes.
1515
        write(&w, "a.txt", b"a\n");
1516
        c.commit("add a", &[]).unwrap();
1517
        write(&w, "b.txt", b"b\n");
1518
        c.commit("add b", &[]).unwrap();
1519
        write(&w, "a.txt", b"a\na2\n");
1520
        c.commit("grow a", &[]).unwrap();
1521
        assert!(c.push("origin", false).unwrap()[0].ok);
1522
    })
1523
    .await
1524
    .unwrap();
1525
    let hist = call(app, "GET", "/andy/demo/changes/main", None, None, None, None).await.body;
1526
    assert!(hist.contains("/andy/demo/lanes/main"), "the history page links the board");
1527
    let r = call(app, "GET", "/andy/demo/lanes/main", None, None, None, None).await;
1528
    assert_eq!(r.status, StatusCode::OK, "{}", r.body);
1529
    assert!(r.body.contains("3 changes in 2 lanes"), "{}", r.body);
1530
    let start = r.body.find("<div class=\"lanes-board\"").unwrap();
1531
    let board = &r.body[start..start + r.body[start..].find("</svg>").unwrap()];
1532
    assert_eq!(board.matches("<rect ").count(), 3);
1533
    assert_eq!(board.matches("<path d=\"M").count(), 1, "grow a depends on add a only");
1534
    assert!(r.body.contains("grow a") && r.body.contains("/andy/demo/change/"));
1535
}
2bfe5ef6 Andy McCall ↶ 1536
1537
/// Planning rewrites from a proposal's swimlanes (hub spec §6.7): the hub
1538
/// offers only what makes sense and rewrites nothing itself.
1539
#[tokio::test(flavor = "multi_thread")]
1540
async fn a_proposal_board_plans_squashes_and_rebases() {
1541
    let h = hub().await;
1542
    let app = &h.app;
c8684d44 Andy McCall 1543
    let andy = call(
1544
        app,
1545
        "POST",
1546
        "/register",
1547
        None,
1548
        None,
1549
        None,
1550
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1551
    )
1552
    .await
1553
    .cookie
1554
    .unwrap();
2bfe5ef6 Andy McCall ↶ 1555
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1556
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1557
    let url = format!("{}/andy/demo", h.base);
1558
    let work = tempfile::tempdir().unwrap();
1559
    let w = work.path().to_path_buf();
1560
    let (base, first, second, apart) = tokio::task::spawn_blocking(move || {
1561
        let mut c = Repo::init(&w).unwrap();
1562
        c.config.set("remote.origin.url", &url).unwrap();
1563
        c.config.set("remote.origin.token", "site").unwrap();
1564
        c.save_config().unwrap();
1565
        write(&w, "a.txt", b"a\n");
1566
        let base = c.commit("base", &[]).unwrap();
1567
        assert!(c.push("origin", false).unwrap()[0].ok);
1568
        c.bookmark_create("feature", None).unwrap();
1569
        c.bookmark_switch("feature", false).unwrap();
1570
        write(&w, "a.txt", b"a\nfirst\n");
1571
        let first = c.commit("first", &[]).unwrap();
1572
        write(&w, "a.txt", b"a\nfirst\nsecond\n");
1573
        let second = c.commit("second", &[]).unwrap();
1574
        write(&w, "b.txt", b"apart\n");
1575
        let apart = c.commit("apart", &[]).unwrap();
1576
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1577
        (base.to_hex(), first.to_hex(), second.to_hex(), apart.to_hex())
1578
    })
1579
    .await
1580
    .unwrap();
1581
    // No proposal yet: the board is read-only.
1582
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1583
    assert!(!board.contains("data-plan="));
1584
    let (st, _) = api(
1585
        app,
1586
        "POST",
1587
        "/api/v1/repos/andy/demo/proposals",
1588
        Some("site"),
1589
        Some(r#"{"title":"Feature","target":"main","source":"feature"}"#),
1590
    )
1591
    .await;
1592
    assert!(st.is_success(), "{st}");
1593
    let board = call(app, "GET", "/andy/demo/lanes/feature", None, Some(&andy), None, None).await.body;
1594
    assert!(board.contains("data-plan=\"/andy/demo/lanes/feature/plan\""), "{board}");
1595
    let csrf = csrf_of(&board);
1596
    let plan = |c: &str, t: &str| {
1597
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1598
        let form = format!("_csrf={csrf}&change={c}&target={t}");
1599
        async move {
1600
            let r = call(&app, "POST", "/andy/demo/lanes/feature/plan", None, Some(&andy), None, Some(&form)).await;
1601
            serde_json::from_str::<serde_json::Value>(&r.body).unwrap()
1602
        }
1603
    };
1604
    let kinds = |v: &serde_json::Value| {
1605
        v["options"].as_array().map(|a| a.iter().map(|o| o["kind"].as_str().unwrap().to_string()).collect::<Vec<_>>()).unwrap_or_default()
1606
    };
1607
    // second already depends on first: squash, no rebase.
1608
    let v = plan(&second, &first).await;
1609
    assert_eq!(kinds(&v), ["squash"], "{v}");
1610
    assert!(v["options"][0]["command"].as_str().unwrap().contains(&format!("oxy squash #{second} --into #{first}")));
c96b3286 Andy McCall ↶ 1611
    assert!(v["options"][0]["vscode"].as_str().unwrap().starts_with("vscode://oxygenhub.oxygen-vscode/plan?"));
2bfe5ef6 Andy McCall ↶ 1612
    // apart is independent of second: either.
1613
    assert_eq!(kinds(&plan(&apart, &second).await), ["squash", "rebase"]);
1614
    // first under second: nothing (second depends on first).
1615
    assert!(plan(&first, &second).await["error"].is_string());
1616
    // What has landed on main is not rearranged.
1617
    assert!(plan(&second, &base).await["error"].as_str().unwrap().contains("already on main"));
1618
}
38833ed7 Andy McCall ↶ 1619
1620
/// Issues and proposals share a number space, so every number says what it
1621
/// is, and the chain of work shows from both ends (hub spec §8).
1622
#[tokio::test(flavor = "multi_thread")]
1623
async fn proposals_and_issues_show_their_chain() {
1624
    let h = hub().await;
1625
    let app = &h.app;
c8684d44 Andy McCall 1626
    let andy = call(
1627
        app,
1628
        "POST",
1629
        "/register",
1630
        None,
1631
        None,
1632
        None,
1633
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1634
    )
1635
    .await
1636
    .cookie
1637
    .unwrap();
38833ed7 Andy McCall ↶ 1638
    let page = call(app, "GET", "/new", None, Some(&andy), None, None).await;
1639
    call(app, "POST", "/new", None, Some(&andy), None, Some(&format!("_csrf={}&owner=andy&name=demo", csrf_of(&page.body)))).await;
1640
    let url = format!("{}/andy/demo", h.base);
1641
    let work = tempfile::tempdir().unwrap();
1642
    let w = work.path().to_path_buf();
1643
    tokio::task::spawn_blocking(move || {
1644
        let mut c = Repo::init(&w).unwrap();
1645
        c.config.set("remote.origin.url", &url).unwrap();
1646
        c.config.set("remote.origin.token", "site").unwrap();
1647
        c.save_config().unwrap();
1648
        write(&w, "a.txt", b"a\n");
1649
        c.commit("base", &[]).unwrap();
1650
        assert!(c.push("origin", false).unwrap()[0].ok);
1651
        c.bookmark_create("feature", None).unwrap();
1652
        c.bookmark_switch("feature", false).unwrap();
1653
        write(&w, "a.txt", b"a\nfixed\n");
1654
        c.commit("Fix the crash\n\nfixes #2", &[]).unwrap();
1655
        assert!(c.push_bookmark("origin", "feature", false).unwrap()[0].ok);
1656
    })
1657
    .await
1658
    .unwrap();
1659
    for title in ["Slow start", "Crash on save"] {
1660
        let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/issues", Some("site"), Some(&format!(r#"{{"title":"{title}"}}"#))).await;
1661
        assert!(st.is_success());
1662
    }
1663
    let (st, v) = api(
1664
        app,
1665
        "POST",
1666
        "/api/v1/repos/andy/demo/proposals",
1667
        Some("site"),
1668
        Some(r#"{"title":"Faster, safer","body":"Closes #1. See also #2.","target":"main","source":"feature"}"#),
1669
    )
1670
    .await;
1671
    assert!(st.is_success(), "{st} {v}");
1672
    assert_eq!(v["number"], 3, "one number space: issues 1 and 2, then proposal 3");
1673
1674
    // The proposal names its kind, links its references by kind, and shows
1675
    // the chain: the issues it closes (description and changes) → it → main.
1676
    let p = call(app, "GET", "/andy/demo/proposal/3", None, None, None, None).await.body;
1677
    assert!(p.contains(">proposal #3</small>"), "header");
1678
    assert!(p.contains(">issue #1</a>") && p.contains(">issue #2</a>"), "links in the description say what they point at");
1679
    let chain = &p[p.find("class=\"chain\"").expect("a chain")..];
1680
    let chain = &chain[..chain.find("</p>").unwrap()];
1681
    for want in ["issue #1</span> Slow start", "issue #2</span> Crash on save", "proposal #3", ">main<"] {
1682
        assert!(chain.contains(want), "chain lacks {want:?}: {chain}");
1683
    }
1684
    assert!(p.contains("<h3>Closes</h3>"));
1685
1686
    // The issue shows the proposal that closes it, and names its own kind.
1687
    let i = call(app, "GET", "/andy/demo/issue/1", None, None, None, None).await.body;
1688
    assert!(i.contains(">issue #1</small>"));
1689
    let chain = &i[i.find("class=\"chain\"").expect("a chain on the issue")..];
1690
    assert!(chain.contains("closed by") && chain.contains("proposal #3</span> Faster, safer"), "{chain}");
a1b98695 Andy McCall ↶ 1691
    // The conversation is a timeline with avatars; editing sits with the
1692
    // content, not in the sidebar, and labels and projects are editable.
1693
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1694
    assert!(p.contains("class=\"tl-avatar\" src=\"/avatar/"), "avatars");
1695
    assert!(p.contains("id=\"edit\"") && !p.contains("<h3>Edit</h3>"), "the editor is inline, not in the sidebar");
1696
    assert!(p.contains("no labels yet") && p.contains("/andy/demo/labels"), "a way to make labels");
1697
    let (st, _) = api(app, "POST", "/api/v1/projects/andy", Some("site"), Some(r#"{"title":"Board"}"#)).await;
1698
    assert!(st.is_success(), "{st}");
1699
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
9e50caed Andy McCall ↶ 1700
    assert!(
1701
        p.contains("name=\"project\" value=\"1\"") && p.contains("Add to a project") && p.contains("Board<small>"),
1702
        "the owner's projects to add to, in a menu"
1703
    );
a1b98695 Andy McCall ↶ 1704
    let csrf = csrf_of(&p);
1705
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=add"))).await;
1706
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1707
    assert!(p.contains("/projects/andy/1\">Board</a>") && p.contains("value=\"remove\""), "on the project, removable");
1708
    call(app, "POST", "/andy/demo/proposal/3/project", None, Some(&andy), None, Some(&format!("_csrf={csrf}&project=1&action=remove")))
1709
        .await;
1710
    let p = call(app, "GET", "/andy/demo/proposal/3", None, Some(&andy), None, None).await.body;
1711
    assert!(!p.contains("/projects/andy/1\">Board</a>"), "taken off again");
1712
38833ed7 Andy McCall ↶ 1713
    // Closed by the proposal's change, not its description: still shown.
1714
    let two = call(app, "GET", "/andy/demo/issue/2", None, None, None, None).await.body;
1715
    let chain = &two[two.find("class=\"chain\"").expect("a chain on issue 2")..];
1716
    assert!(chain.contains("proposal #3"), "{chain}");
1717
}
e9bfea8e Andy McCall ↶ 1718
1719
/// What the hub is: its version and build, and the libraries it is built on,
1720
/// on /about, in the API and in /health (hub spec §15).
1721
#[tokio::test(flavor = "multi_thread")]
1722
async fn the_hub_says_what_version_it_is() {
1723
    let h = hub().await;
1724
    let app = &h.app;
1725
    let (st, v) = api(app, "GET", "/api/v1/version", None, None).await;
1726
    assert_eq!(st, StatusCode::OK);
1727
    assert_eq!(v["oxygenhub"]["version"], env!("CARGO_PKG_VERSION"));
1728
    assert!(v["oxygenhub"]["build"].as_str().is_some_and(|b| !b.is_empty()), "{v}");
1729
    assert!(v["oxy_core"].as_str().is_some() && v["flow_core"].as_str().is_some());
1730
    let health = call(app, "GET", "/health", None, None, None, None).await.body;
1731
    assert!(health.contains("\"build\""), "{health}");
b2107275 Andy McCall ↶ 1732
    let h: serde_json::Value = serde_json::from_str(&health).unwrap();
1733
    assert!(h["state_cache"]["budget_mb"].as_u64().is_some_and(|b| b > 0) && h["state_cache"]["states"].is_u64(), "{health}");
e9bfea8e Andy McCall ↶ 1734
    let about = call(app, "GET", "/about", None, None, None, None).await.body;
1735
    assert!(about.contains(&format!("<strong>{}</strong>", env!("CARGO_PKG_VERSION"))) && about.contains("oxy-core"), "{about}");
1736
    assert!(about.contains("href=\"/about\""), "the footer links here");
1737
}
df71c789 Andy McCall ↶ 1738
1739
#[tokio::test(flavor = "multi_thread")]
1740
async fn device_sign_in() {
1741
    let h = hub().await;
1742
    let app = &h.app;
c8684d44 Andy McCall 1743
    let r = call(
1744
        app,
1745
        "POST",
1746
        "/register",
1747
        None,
1748
        None,
1749
        None,
1750
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1751
    )
1752
    .await;
df71c789 Andy McCall ↶ 1753
    let andy = r.cookie.unwrap();
1754
1755
    // An unknown scope is refused.
1756
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"x","scopes":["root"]}"#)).await;
1757
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("invalid_scope")));
1758
1759
    // The app asks for a code and polls; nobody has approved it yet.
1760
    let (st, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Phone app","scopes":["repo:read","user:read"]}"#)).await;
1761
    assert_eq!(st, StatusCode::OK, "{v}");
1762
    let device = v["device_code"].as_str().unwrap().to_string();
1763
    let user = v["user_code"].as_str().unwrap().to_string();
1764
    assert_eq!(v["verification_uri_complete"], format!("{}/device?code={user}", h.base));
1765
    let poll = format!(r#"{{"device_code":"{device}"}}"#);
1766
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1767
    assert_eq!((st, v["error"].as_str()), (StatusCode::BAD_REQUEST, Some("authorization_pending")));
1768
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1769
    assert_eq!(v["error"], "slow_down", "polled too soon");
1770
1771
    // The user approves it on the web, allowing less than it asked for.
1772
    let page = call(app, "GET", &format!("/device?code={}", user.to_lowercase().replace('-', "")), None, Some(&andy), None, None).await;
1773
    assert!(page.body.contains("Phone app") && page.body.contains("repo:read"), "{}", page.body);
1774
    let csrf = csrf_of(&page.body);
1775
    let r =
1776
        call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve&scopes=user%3Aread")))
1777
            .await;
4da8b828 Andy McCall ↶ 1778
    // oxygenhub#83: the answer page says it is done, with no code form.
1779
    assert!(r.body.contains("Signed in") && r.body.contains("nothing to copy or enter"), "{}", r.body);
1780
    assert!(!r.body.contains("The code your app shows"), "no code form after approving");
df71c789 Andy McCall ↶ 1781
1782
    // The next poll gets a token with what was allowed, once.
1783
    let (st, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1784
    assert_eq!(st, StatusCode::OK, "{v}");
1785
    assert_eq!((v["scope"].as_str(), v["username"].as_str()), (Some("user:read"), Some("andy")));
1786
    let token = v["access_token"].as_str().unwrap().to_string();
1787
    let (st, v) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1788
    assert_eq!((st, v["username"].as_str()), (StatusCode::OK, Some("andy")));
1789
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&poll)).await;
1790
    assert_eq!(v["error"], "expired_token", "a code gives one token");
1791
    let tokens = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1792
    assert!(tokens.body.contains("device: Phone app"));
60f11b71 Andy McCall ↶ 1793
    // oxygenhub#70: a device's token expires, and each use renews it.
1794
    assert!(tokens.body.contains("renewed on use"), "{}", tokens.body);
df71c789 Andy McCall ↶ 1795
60f11b71 Andy McCall ↶ 1796
    // The token can revoke itself (oxy auth logout), and is then refused.
1797
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", Some(&token), None).await;
1798
    assert_eq!(st, StatusCode::NO_CONTENT);
1799
    let (st, _) = api(app, "GET", "/api/v1/user", Some(&token), None).await;
1800
    assert_eq!(st, StatusCode::UNAUTHORIZED);
1801
    let (st, _) = api(app, "DELETE", "/api/v1/user/token", None, None).await;
1802
    assert_eq!(st, StatusCode::UNAUTHORIZED, "revoking needs a token");
1803
df71c789 Andy McCall ↶ 1804
    // A denied code says so.
1805
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Other"}"#)).await;
1806
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1807
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1808
    let csrf = csrf_of(&page.body);
1809
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=deny"))).await;
1810
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1811
    assert_eq!(v["error"], "access_denied");
ecac6e8d Andy McCall ↶ 1812
1813
    // A code the app gave up on (#304) is gone at once: the page no longer
1814
    // takes it, and the app's poll says so.
1815
    let (_, v) = api(app, "POST", "/api/v1/device/code", None, Some(r#"{"client":"Cancelled"}"#)).await;
1816
    let (device, user) = (v["device_code"].as_str().unwrap().to_string(), v["user_code"].as_str().unwrap().to_string());
1817
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1818
    assert_eq!(st, StatusCode::NO_CONTENT);
1819
    let page = call(app, "GET", &format!("/device?code={user}"), None, Some(&andy), None, None).await;
1820
    let csrf = csrf_of(&page.body);
1821
    call(app, "POST", "/device", None, Some(&andy), None, Some(&format!("_csrf={csrf}&code={user}&action=approve"))).await;
1822
    let (_, v) = api(app, "POST", "/api/v1/device/token", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1823
    assert_eq!(v["error"], "expired_token", "{v}");
1824
    let (st, _) = api(app, "DELETE", "/api/v1/device/code", None, Some(&format!(r#"{{"device_code":"{device}"}}"#))).await;
1825
    assert_eq!(st, StatusCode::NO_CONTENT, "again: still fine");
df71c789 Andy McCall ↶ 1826
1827
    // Signed out, the page asks for a sign-in first.
1828
    let r = call(app, "GET", "/device", None, None, None, None).await;
1829
    assert!(r.status.is_redirection(), "{}", r.status);
1830
}
62ceb2ee Andy McCall ↶ 1831
1832
#[tokio::test(flavor = "multi_thread")]
1833
async fn api_assistants_at_each_level() {
1834
    let h = hub().await;
1835
    let app = &h.app;
c8684d44 Andy McCall 1836
    let andy = call(
1837
        app,
1838
        "POST",
1839
        "/register",
1840
        None,
1841
        None,
1842
        None,
1843
        Some("username=andy&email=a%40example.com&password=correct-horse-battery&setup=test-setup"),
1844
    )
1845
    .await
1846
    .cookie
1847
    .unwrap();
62ceb2ee Andy McCall ↶ 1848
    let page = call(app, "GET", "/settings/tokens", None, Some(&andy), None, None).await;
1849
    let csrf = csrf_of(&page.body);
1850
    let mint = |scopes: &'static str| {
1851
        let (app, andy, csrf) = (app.clone(), andy.clone(), csrf.clone());
1852
        async move {
1853
            let r = call(&app, "POST", "/settings/tokens", None, Some(&andy), None, Some(&format!("_csrf={csrf}&name=t&{scopes}"))).await;
1854
            r.body.split("oxyhub_").nth(1).map(|s| format!("oxyhub_{}", s.split('<').next().unwrap().trim())).unwrap()
1855
        }
1856
    };
1857
    let admin = mint("scopes=repo%3Aadmin").await;
1858
    let write = mint("scopes=repo%3Aread&scopes=repo%3Awrite").await;
1859
    api(app, "POST", "/api/v1/repos", Some(&admin), Some(r#"{"owner":"andy","name":"demo","visibility":"public"}"#)).await;
1860
    // A stand-in endpoint with no model list: any model name is taken.
1861
    let router = axum::Router::new().route(
1862
        "/v1/chat/completions",
1863
        axum::routing::post(|| async { axum::Json(serde_json::json!({ "choices": [{ "message": { "content": "OK" } }] })) }),
1864
    );
1865
    let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
1866
    let port = listener.local_addr().unwrap().port();
1867
    tokio::spawn(async move { axum::serve(listener, router).await.unwrap() });
1868
    let ep = format!("http://127.0.0.1:{port}/v1/chat/completions");
1869
1870
    // The site's, by its administrator; the repository's, by its admin.
1871
    let body = serde_json::json!({ "preset": "gemini", "endpoint": ep, "model": "gemini-3-pro", "token": "sk-secret" }).to_string();
1872
    let (st, v) = api(app, "POST", "/api/v1/admin/assistants", Some(&admin), Some(&body)).await;
1873
    assert_eq!(st, StatusCode::OK, "{v}");
1874
    assert_eq!(v["ok"], "Gemini added");
1875
    let body =
1876
        serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m", "token": "sk-2" }).to_string();
1877
    let (st, _) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&write), Some(&body)).await;
1878
    assert_eq!(st, StatusCode::FORBIDDEN, "repo:admin is needed");
1879
    let (st, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1880
    assert_eq!(st, StatusCode::OK, "{v}");
1881
    let (st, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1882
    assert_eq!(st, StatusCode::OK);
1883
    let names: Vec<(&str, &str, bool)> = v
1884
        .as_array()
1885
        .unwrap()
1886
        .iter()
1887
        .map(|a| (a["name"].as_str().unwrap(), a["from"].as_str().unwrap_or(""), a["has_token"].as_bool().unwrap()))
1888
        .collect();
1889
    assert_eq!(names, [("Gemini", "the site", true), ("Claude", "", true)]);
1890
    assert!(!v.to_string().contains("sk-"), "tokens never come back");
1891
    // Changing it keeps the token when none is given.
1892
    let body = serde_json::json!({ "name": "Claude", "endpoint": ep, "api": "chat-completions", "model": "m2" }).to_string();
1893
    let (_, v) = api(app, "POST", "/api/v1/repos/andy/demo/assistants", Some(&admin), Some(&body)).await;
1894
    assert_eq!(v["ok"], "Claude updated");
1895
    let (_, v) = api(app, "GET", "/api/v1/repos/andy/demo/assistants", Some(&admin), None).await;
1896
    assert_eq!((v[1]["model"].as_str(), v[1]["has_token"].as_bool()), (Some("m2"), Some(true)));
1897
    // Prompts: the site's is inherited by the repository.
1898
    let (st, _) = api(app, "PUT", "/api/v1/admin/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Be brief."}"#)).await;
1899
    assert_eq!(st, StatusCode::OK);
1900
    let (_, v) = api(app, "PUT", "/api/v1/repos/andy/demo/assistants/prompt", Some(&admin), Some(r#"{"prompt":"Rust."}"#)).await;
1901
    assert_eq!(v["prompt"], "Rust.");
1902
    assert_eq!(v["inherited"], serde_json::json!([["the site", "Be brief."]]));
1903
    // Removed.
1904
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1905
    assert_eq!(st, StatusCode::NO_CONTENT);
1906
    let (st, _) = api(app, "DELETE", "/api/v1/repos/andy/demo/assistants/claude", Some(&admin), None).await;
1907
    assert_eq!(st, StatusCode::NOT_FOUND);
1908
}