Landing without review: say plainly when no approval is required, and record how a proposal was landed issue #47 closed: completed andymccall opened this 1 month ago · 0 comments

From metalgear feedback issue #20 (doomsdayone/rstar-api#2). The hub record shows issue #2 was landed explicitly as andymccall 91 s after it opened (audit 'proposal.landed', event 'landed from the hub', push 'landed issue #2'): the Land button or the API, not the push and not the hub on its own. It could land with no approval because the repository requires none, and the page said only 'ready to land'.

• When a repository requires no approvals, say so beside Land ('no approval required by this repository's settings', with a link to Settings), and ask for confirmation when landing with none.
• Record how a proposal was landed (web or API token, with the token's name) in its event, the audit log and the push record, so 'who landed this' has an answer.
• Consider requiring one approval by default for organisation repositories; that is Andy's call.